Summary,Issue id,Status,Priority,Resolution,Created,Resolved,Affects Version/s,Description shaded mapreduce and shaded byo-hadoop client artifacts contains no classes,13434743,Resolved,Blocker,Fixed,20/Mar/22 14:07,30/Mar/22 22:09,2.5.0,"After fixing the logging problem in HBASE-26870, we could see the actual error. {noformat} /home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hadoop-3/bin/hadoop --config /home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/output-integration/hadoop-3/hbase-conf/ jar /home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/lib/shaded-clients/hbase-shaded-mapreduce-2.6.0-SNAPSHOT.jar importtsv -Dimporttsv.columns=HBASE_ROW_KEY,family1:column1,family1:column4,family1:column3 test:example example/ -libjars /home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/shaded-clients/hbase-shaded-mapreduce-2.6.0-SNAPSHOT.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/commons-logging-1.2.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/htrace-core4-4.1.0-incubating.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/opentelemetry-api-1.0.1.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/opentelemetry-context-1.0.1.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/opentelemetry-semconv-1.0.1-alpha.jar:/home/jenkins/jenkins-home/workspace/ase_Nightly_HBASE-26870-branch-2/hbase-client/bin/../lib/client-facing-thirdparty/slf4j-api-1.7.33.jar WARNING: log4j.properties is not found. HADOOP_CONF_DIR may be incomplete. Exception in thread ""main"" java.lang.ClassNotFoundException: org.apache.hadoop.hbase.mapreduce.Driver at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:348) at org.apache.hadoop.util.RunJar.run(RunJar.java:311) at org.apache.hadoop.util.RunJar.main(RunJar.java:232) {noformat}" "Netty ""leak detected"" and OutOfDirectMemoryError due to direct memory buffering with SASL implementation",13424759,Resolved,Blocker,Fixed,25/Jan/22 18:36,07/Jul/22 08:31,2.4.6,"Under constant data ingestion, using default Netty based RpcServer and RpcClient implementation results in OutOfDirectMemoryError, supposedly caused by leaks detected by Netty's LeakDetector. {code:java} 2022-01-25 17:03:10,084 ERROR [S-EventLoopGroup-1-3] util.ResourceLeakDetector - java:115)   org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.expandBTW. have you run the related test case?(ByteToMessageDecoder.java:538)   org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder$1.cumulate(ByteToMessageDecoder.java:97)   org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:274)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)   org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)   org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)   org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)   org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)   org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)   org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)   org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)   org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)   java.lang.Thread.run(Thread.java:748) {code} {code:java} 2022-01-25 17:03:14,014 ERROR [S-EventLoopGroup-1-3] util.ResourceLeakDetector - apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:507)   org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:446)   org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)   org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)   org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)   org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)   org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)   org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)   org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)   org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)   org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)   org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)   java.lang.Thread.run(Thread.java:748) {code} And finally handlers are removed from the pipeline due to OutOfDirectMemoryError: {code:java} 2022-01-25 17:36:28,657 WARN  [S-EventLoopGroup-1-5] channel.DefaultChannelPipeline - An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception. org.apache.hbase.thirdparty.io.netty.channel.ChannelPipelineException: org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.handlerAdded() has thrown an exception; removed.   at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:624)   at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:181)   at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:358)   at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:339)   at org.apache.hadoop.hbase.ipc.NettyRpcConnection.saslNegotiate(NettyRpcConnection.java:229)   at org.apache.hadoop.hbase.ipc.NettyRpcConnection.access$600(NettyRpcConnection.java:79)   at org.apache.hadoop.hbase.ipc.NettyRpcConnection$2.operationComplete(NettyRpcConnection.java:312)   at org.apache.hadoop.hbase.ipc.NettyRpcConnection$2.operationComplete(NettyRpcConnection.java:300)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:578)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:571)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:550)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:491)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:616)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setSuccess0(DefaultPromise.java:605)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:104)   at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:84)   at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.fulfillConnectPromise(AbstractEpollChannel.java:653)   at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.finishConnect(AbstractEpollChannel.java:691)   at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:567)   at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:470)   at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)   at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)   at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)   at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hbase.thirdparty.io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 16777216 byte(s) of direct memory (used: 33269220801, max: 33285996544)   at org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:802)   at org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:731)   at org.apache.hbase.thirdparty.io.netty.buffer.PoolArena$DirectArena.allocateDirect(PoolArena.java:632)   at org.apache.hbase.thirdparty.io.netty.buffer.PoolArena$DirectArena.newChunk(PoolArena.java:607)   at org.apache.hbase.thirdparty.io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:202)   at org.apache.hbase.thirdparty.io.netty.buffer.PoolArena.tcacheAllocateSmall(PoolArena.java:172)   at org.apache.hbase.thirdparty.io.netty.buffer.PoolArena.allocate(PoolArena.java:134)   at org.apache.hbase.thirdparty.io.netty.buffer.PoolArena.allocate(PoolArena.java:126)   at org.apache.hbase.thirdparty.io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:395)   at org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:187)   at org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:178)   at org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBufAllocator.buffer(AbstractByteBufAllocator.java:115)   at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.writeResponse(NettyHBaseSaslRpcClientHandler.java:79)   at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.handlerAdded(NettyHBaseSaslRpcClientHandler.java:115)   at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.callHandlerAdded(AbstractChannelHandlerContext.java:938)   at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:609)   ... 24 more {code}" Backport the log4j2 changes to branch-2,13432116,Resolved,Blocker,Fixed,05/Mar/22 01:42,11/Mar/22 19:46,,"One thing is that, we'd better make sure that users can still use the old log4j.properties for logging." Missing opentelemetry agent in hadoop-two-compat.xml,13432167,Resolved,Blocker,Fixed,05/Mar/22 13:40,10/Mar/22 20:06,2.5.0,"We do not have hadoop-two-compat.xml on master, this is probably why we missed this file when backporting to branch-2." The way we bypass broken track file is not enough in StoreFileListFile,13424163,Resolved,Critical,Fixed,22/Jan/22 15:23,25/Jan/22 07:22,,"When implementing HBASE-26690, I found that a pb message can be parsed with partial bytes, if we stop at some special point. So we can not rely on the pb parser to always throw InvalidProtocolBufferException for us, we need to detect the incomplete file by ourselves." NPE caused by WAL Compression and Replication,13434041,Resolved,Critical,Won't Fix,16/Mar/22 07:40,09/Aug/22 08:08,1.7.1,"My cluster uses HBase 1.4.12, opened WAL compression and replication. I could found replication sizeOfLogQueue backlog, and after some debugs, found the NPE throwed by [https://github.com/apache/hbase/blob/branch-1/hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/LRUDictionary.java#L109:] !image-2022-03-16-14-25-49-276.png!   The root cause for this problem is: WALEntryStream#checkAllBytesParsed: !image-2022-03-16-14-30-15-247.png! resetReader does not create a new reader, the original CompressionContext and the dict in it will still be retained. However, at this time, the position is reset to 0, which means that the HLog needs to be read from the beginning, but the cache that has not been cleared is still used, so there will be problems: the same data has already in the LRUCache, and it will be directly added to the cache again. Recreate a new reader here, the problem is solved. I will open a PR later. But, there are some other places in the current code to resetReader or seekOnFs. I guess these codes doesn't take into account the wal compression case at all...   In theory, as long as the file is read again, the LRUCache should also be rolled back, otherwise there will be inconsistent behavior of READ and WRITE links. But the position can be roll back to any intermediate position at will, but LRUCache can't..." "Snapshot is corrupted due to interaction between move, warmupRegion, compaction, and HFileArchiver",13425509,Resolved,Critical,Duplicate,29/Jan/22 01:21,29/Jan/22 01:25,1.3.5,"There is an interesting sequence of events which leads to split-brain, double-assignment type of behavior with management of store files. The scenario is this: # Take snapshot # RegionX of snapshotted table is hosted on RegionServer1. # Stop RegionServer1, using {{region_mover}}, gracefully moving all regions to other regionservers using {{move}} RPCs. # RegionX is now opened on RegionServer2. # RegionServer2 compacts RegionX after opening. # RegionServer1 starts and uses {{region_mover}} to {{move}} all previously owned regions back to itself. # The HMaster RPC to {{move}} calls {{warmupRegion}} on RegionServer1. # As part of {{warmupRegion}}, RegionServer1 opens all store files of RegionX. CompactedHFilesDischarger chore has not yet archived the pre-compacted store file. RegionServer1 finds both the pre-compacted store file and post-compacted store file. It logs a warning and archives the pre-compacted file. # RegionServer1 has warmed up the region, so now HMaster resumes the {{move}} and sends {{close}} RegionX to RegionServer2. # RegionServer2 closes its store files. As part of this, it archives any compacted files which have not yet been archived by the {{CompactedHFilesDischarger}} chore. # Since RegionServer1 already archived the file, RegionServer2's {{HFileArchiver}} finds the destination archive file already exists. (code link) # RegionServer2 renames the archived file, to free up the desired destination filename. With the archived file renamed, RegionServer2 attempts to archive the file as planned. But the source file doesn't exist because RegionServer1 already moved it... to the location RegionServer2 expected to use! # RegionServer2 silently ignores this archival failure. (code link) # HMaster {{HFileCleaner}} chore later deletes the renamed archive file, because there is no active reference to it. (The snapshot reference is to the original named file, not the ""backup"" timestamped version.) The snapshot data is irretrievably lost. HBASE-26718 tracks a potential, specific change to the archival process to avoid this specific issue. However, there is a more fundamental problem here that a region opened by {{warmupRegion}} can operate on that region's store files while the region is opened elsewhere, which must not be allowed. This was seen on branch-1, and is a combination of HBASE-22330 and not having the fix for HBASE-22163." ShortCircuitingClusterConnection fails to close RegionScanners when making short-circuited calls,13432570,Resolved,Critical,Fixed,08/Mar/22 06:34,01/Apr/22 02:44,2.4.9,"Just ran into this on the Phoenix side. We retrieve a Connection via {{{}RegionCoprocessorEnvironment.createConnection... getTable(...){}}}. And then call get on that table. The Get's key happens to be local. Now each call to table.get() leaves an open StoreScanner around forever. (verified with a memory profiler). There references are held via RegionScannerImpl.storeHeap.scannersForDelayedClose. Eventially the RegionServer goes into a GC of death and can only ended with kill -9. The reason appears to be that in this case there is no currentCall context. Some time in 2.x the Rpc handler/call was made responsible for closing open region scanners, but we forgot to handle {{ShortCircuitingClusterConnection}} It's not immediately clear how to fix this. But it does make ShortCircuitingClusterConnection useless and dangerous. If you use it, you *will* create a giant memory leak." Wait on the future returned by FanOutOneBlockAsyncDFSOutput.flush would stuck,13423215,Resolved,Critical,Fixed,18/Jan/22 09:17,28/Jan/22 12:53,2.4.9,"Consider there are three dataNodes: dn1,dn2,and dn3, and we write some data to {{FanOutOneBlockAsyncDFSOutput}} and then flush it, there are one {{Callback}} in {{FanOutOneBlockAsyncDFSOutput.waitingAckQueue}}. If the ack from dn1 arrives firstly and triggers Netty to invoke {{FanOutOneBlockAsyncDFSOutput.completed}} with dn1's channel, then in {{FanOutOneBlockAsyncDFSOutput.completed}}, dn1's channel is removed from {{Callback.unfinishedReplicas}}. But dn2 and dn3 respond slowly, before dn2 and dn3 sending ack , dn1 is shut down or have a exception, so {{FanOutOneBlockAsyncDFSOutput.failed}} is triggered by Netty with dn1's channel, and because the {{Callback.unfinishedReplicas}} does not contain dn1's channel,the {{Callback}} is skipped in {{FanOutOneBlockAsyncDFSOutput.failed}} method, just as following line250, and at line 245, {{FanOutOneBlockAsyncDFSOutput.state}} is set to {{State.BROKEN}}. {code:java} 233 private synchronized void failed(Channel channel, Supplier errorSupplier) { 234 if (state == State.BROKEN || state == State.CLOSED) { 235 return; 236 } .... 244 // disable further write, and fail all pending ack. 245 state = State.BROKEN; 246 Throwable error = errorSupplier.get(); 247 for (Iterator iter = waitingAckQueue.iterator(); iter.hasNext();) { 248 Callback c = iter.next(); 249 // find the first sync request which we have not acked yet and fail all the request after it. 250 if (!c.unfinishedReplicas.contains(channel.id())) { 251 continue; 252 } 253 for (;;) { 254 c.future.completeExceptionally(error); 255 if (!iter.hasNext()) { 256 break; 257 } 258 c = iter.next(); 259 } 260 break; 261 } 262 datanodeInfoMap.keySet().forEach(ChannelOutboundInvoker::close); 263 } {code} At the end of above method in line 262, dn1,dn2 and dn3 are all closed, so the {{FanOutOneBlockAsyncDFSOutput.failed}} is triggered again by dn2 and dn3, but at the above line 234, because {{FanOutOneBlockAsyncDFSOutput.state}} is already {{State.BROKEN}}, the whole {{FanOutOneBlockAsyncDFSOutput.failed}} is skipped. So wait on the future returned by {{FanOutOneBlockAsyncDFSOutput.flush}} would stuck for ever. When we roll the wal, we would create a new {{FanOutOneBlockAsyncDFSOutput}} and a new {{AsyncProtobufLogWriter}}, in {{AsyncProtobufLogWriter.init}} we write wal header to {{FanOutOneBlockAsyncDFSOutput}} and wait it to complete. If we run into this situation, the roll would stuck forever. I have simulate this case in the PR, and my fix is even through the {{FanOutOneBlockAsyncDFSOutput.state}} is already {{State.BROKEN}}, we would still try to trigger {{Callback.future}}" HFileLinkCleaner should be added even if snapshot is disabled,13422683,Resolved,Critical,Fixed,14/Jan/22 07:37,14/Mar/22 04:36,,"We encountered a problem in our cluster: 1. Cluster has many snapshots, cause the archive directory is too big. 2. We delete some snapshots, but the cleaner runs slowly because this is a race in synchronized method of SnapshotHFileCleaner. 3. We delete all snapshots, and disable snapshot feature(hbase.snapshot.enabled=false), so the cleaner will skip the synchronized method in SnapshotHFileCleaner. 4. After cleaner runs, some back reference and data files under archive directory are deleted, but they are still used by some restored tables. This does not meet expectations. One solution is add HFileLinkCleaner even if snapshot is disabled." Replacing log4j with reload4j for branch-2.x,13423883,Resolved,Critical,Fixed,21/Jan/22 01:52,04/Mar/22 20:07,,"There are several new CVEs for log4j1 now. As it is not suitable to upgrade to log4j2 for 2.x releases, let's replace the log4j1 dependencies with reload4j." Incorrect exception handling in shell,13426993,Resolved,Critical,Fixed,07/Feb/22 17:02,10/Feb/22 11:49,2.4.10,"The exception handling changed in the shell compared to 2.2. {noformat} ➜ hbase-upstream git:(branch-2.4) ✗ cat commands.txt scan 'foo' exit ➜ hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt 2022-02-07 16:21:33,654 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable hbase:001:0> scan 'foo' ROW COLUMN+CELL Took 0.3890 seconds Traceback (most recent call last): RuntimeError (Unknown table foo!) hbase:002:0> exit ➜ hbase-upstream git:(branch-2.4) ✗ echo $? 0 {noformat} The execution continues even after an exception is thrown. In 2.2.7 the execution stops when an exception is thrown and the shell exits with error code. {noformat} ➜  hbase-2.2.7 bin/hbase shell -n commands.txt 2022-02-07 16:33:54,930 WARN  [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable ROW                                  COLUMN+CELL Took 0.3082 seconds                                                                                                                         RuntimeError: Unknown table foo!   translate_hbase_exceptions at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130                 command_safe at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49             internal_command at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148                      command at /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140                         scan at (eval):2                      
at commands.txt:1                         load at org/jruby/RubyKernel.java:973                      
at /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186 ➜  hbase-2.2.7 echo $? 1 {noformat}" Log4j2 integration is incorrect in nighly's client integration test,13434739,Resolved,Critical,Fixed,20/Mar/22 12:50,21/Mar/22 03:31,,"On master it still uses log4j2.xml and on branch-2.x we completely misses this part... Let me prepare PRs to fix them." TestSnapshotProcedure fails in branch-2,13433861,Resolved,Critical,Fixed,15/Mar/22 12:01,18/Mar/22 09:49,,"We still use the origin implementation for Admin in branch-2, which is different from the AdminOverAsyncAdmin in master branch. This patch will try to introduce the snapshot procedure to the origin Admin implementation client in branch-2." LoadBalancer should not return empty map,13420402,Resolved,Critical,Fixed,03/Jan/22 15:52,07/Jan/22 16:43,2.5.0,"After HBASE-26641, these two tests are still flaky, they also fail for me locally sometimes. After digging, I found that, while we see this in the log output after master failover {noformat} Wanted to do round robin assignment but no servers to assign to {noformat} The UTs will fail. Need to dig more." Automatically add default security headers to http/rest if SSL enabled,13431501,Resolved,Major,Fixed,02/Mar/22 13:01,26/Oct/24 14:15,2.0.6,"In the previous ticket https://issues.apache.org/jira/browse/HBASE-23303 we implemented these security headers as optional which had to explicitly enabled in the config. With this change the headers will automatically be added with meaningful default values if SSL is enabled." Update ref guide about log4j2 after we changed to use properties file,13432114,Resolved,Major,Fixed,05/Mar/22 01:36,23/Jan/25 02:49,,"In HBASE-25862 we changed the ref guide to mention log4j2.xml, now it should be log4j2.properties then." Update downloads.xml for 2.4.10,13432108,Resolved,Major,Fixed,05/Mar/22 00:39,05/Mar/22 00:41,, Scan#setRowPrefixFilter incorrectly marked as deprecated,13429446,Resolved,Major,Fixed,19/Feb/22 14:03,02/Mar/22 15:35,3.0.0-alpha-2,"Issue HBASE-25299 is about the Scan#setRowPrefixFilter having not the expected effects when using also the setStartRow and/or setStopRow. The setRowPrefixFilter is intended to make setting the right startRow and stopRow for prefix scans. So it was always intended of using it *instead* of doing separate setStartRow and/or setStopRow calls. The reason for adding this to the Scan (~ 8 years ago, HBASE-11990 ) was that calculating the correct start and stop row for doing the very efficient prefix scan is very very hard to do right in the generic case. This is still a current usecase and many of my applications rely on this function (I even prefer the HBase Client when connecting to Google BigTable for this method). With issue HBASE-25299 it has now been marked as deprecated. Quote from the changes made in HBASE-25299: {code} @deprecated since 3.0.0. The scan result might be unexpected in some cases. {code} Yes, if you use this very valuable method incorrectly it will yield incorrect results. I do not consider this a valid reason to deprecate it. So I do agree with the confusion of the effects as described in HBASE-25299 which should be fixed with additional documentation. I disagree with the deprecation of this method.   I'll put up a pull request in which I improve the documentation and remove the deprecation." VerifyReplication recompare async,13434920,Resolved,Major,Fixed,21/Mar/22 13:51,21/Nov/24 02:45,,"VerifyReplication includes an option ""sleepMsBeforeReCompare"". This is useful for helping work around replication lag. However, adding a sleep in a hadoop job can drastically slow that job down if there is anything more than a small number of invalid results. We can mitigate this by doing the recompare in a separate thread. We can limit the thread pool and fallback to doing the recompare in the main thread if the thread pool is full. This way we offload some of the slowness but still retain the same validation guarantees. A configuration can be added to control how many threads per mapper." Cannot rebuild a cluster from an existing root directory,13436208,Resolved,Major,Duplicate,28/Mar/22 16:16,21/Nov/24 02:47,3.0.0-alpha-2,"When I tested to rebuild an HBase cluster, and the rootdir was configured as a existed directory (the directory was generated by another HBase cluster of the same version), I found the following error message： {code:java} java.net.UnknownHostException: Call to address=worker-1.cluster-xxx:16020 failed on local exception: java.net.UnknownHostException: worker-1.cluster-xxx:16020 could not be resolved     at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)     at java.lang.reflect.Constructor.newInstance(Constructor.java:423)     at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:234)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:387)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:93)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:424)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:419)     at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:119)     at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:134)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.lambda$sendRequest$4(NettyRpcConnection.java:351)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469)     at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)     at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)     at java.lang.Thread.run(Thread.java:748) Caused by: java.net.UnknownHostException: worker-1.cluster-xxx:16020 could not be resolved     at org.apache.hadoop.hbase.ipc.RpcConnection.getRemoteInetAddress(RpcConnection.java:192)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.connect(NettyRpcConnection.java:275)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.access$800(NettyRpcConnection.java:78)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection$4.run(NettyRpcConnection.java:325)     at org.apache.hadoop.hbase.ipc.HBaseRpcControllerImpl.notifyOnCancel(HBaseRpcControllerImpl.java:262)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.sendRequest0(NettyRpcConnection.java:308)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.lambda$sendRequest$4(NettyRpcConnection.java:349) {code} Eventually, I fail to create the cluster. But for cloud environments, this operation is a common scenario（Rebuild a cluster from an existing rootdir directory）    " Replace log4j with reload4j for hbase-connector,13433771,Resolved,Major,Duplicate,15/Mar/22 02:46,02/Oct/24 08:32,1.0.0,"As a result of the [discussion thread of replacing log4j with reload4j|https://lists.apache.org/thread/kfmjg6zmvdjqcwolj0oh634nzv42y806] and HBASE-26691, we have replaced log4j with reload4j in branch-2. Where hbase-connector as a part of the community, this JIRA propose to align with the active hbase release and replace log4j with reload4j before the next release of hbase-connector" Report client backoff time for server overloaded in ConnectionMetrics,13432520,Resolved,Major,Fixed,07/Mar/22 22:16,15/Nov/22 20:50,,"Servers can throw CallQueueTooBigException and CallDroppedException when overloaded. As of HBASE-26807, these can have a configurable extra backoff to allow the server to recover. Depending on the server side queue implementation, different callers may be more or less impacted by server load. It is very useful to measure in the client how much time is spent backing off so we can see which clients are most affected by server overload." The implementation of TestMergesSplitsAddToTracker is problematic,13420209,Resolved,Major,Fixed,01/Jan/22 16:23,07/Jan/22 15:29,,"As it will clear the trackedFiles map in TestStoreFileTracker for every test but we will also store the files for system tables, so it will cause NPE. Not sure why on master the it will not fail but on branch-2 at least testSplitLoadsFromTracker will fail..." ModifyTableDescriptorProcedure shoud load TableDescriptor while executing,13421550,Resolved,Major,Fixed,09/Jan/22 15:24,16/Jan/22 08:49,,"Found this problem when implementing HBASE-26587. We should not pass the old table descriptor when constructing the procedure, as we may have some other MTPs before us so when executing, the table descriptor may have already been changed." Should modify filesCompacting under storeWriteLock,13422843,Resolved,Major,Fixed,15/Jan/22 09:37,19/Jan/22 08:56,,"The stacktrace {noformat} java.lang.IllegalArgumentException at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:131) at org.apache.hadoop.hbase.regionserver.compactions.SortedCompactionPolicy.getCurrentEligibleFiles(SortedCompactionPolicy.java:173) at org.apache.hadoop.hbase.regionserver.compactions.SortedCompactionPolicy.preSelectCompactionForCoprocessor(SortedCompactionPolicy.java:44) at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.preSelect(DefaultStoreEngine.java:130) at org.apache.hadoop.hbase.regionserver.HStore.requestCompaction(HStore.java:1438) at org.apache.hadoop.hbase.regionserver.HStore.requestCompaction(HStore.java:1419) at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2238) at org.apache.hadoop.hbase.coprocessor.example.TestWriteHeavyIncrementObserver.test(TestWriteHeavyIncrementObserver.java:70) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) {noformat} Haven't seen it flaky before. And this is a runtime exception in our non test code base, which seems critical. Not sure if it has the same root cause with HBASE-26644. Need to dig more." Data race on Compactor.writer,13422915,Resolved,Major,Fixed,16/Jan/22 15:09,24/Jan/22 11:56,,"In Compactor.getCompactionTargets, we use synchronized on the writer instance but it does not help resolve the data race problem, because in other places we do not use synchronized... And since it is not a big deal to the upper layer an old snapshot, we could just make the writer instance volatile and use it directly in the method, just make sure we always use the same instance in the method, i.e, assign it to a local var first." Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor,13423765,Resolved,Major,Fixed,20/Jan/22 14:49,27/Jan/22 05:39,, Reduce number of renames during bulkload,13424729,Resolved,Major,Fixed,25/Jan/22 16:06,25/Feb/22 20:12,,Make sure we only do a single rename operation during bulkload when StoreEngine does not require the the use of tmp directories. Set SFT config when creating TableDescriptor in TestCloneSnapshotProcedure,13433676,Resolved,Major,Fixed,14/Mar/22 15:41,16/Mar/22 12:20,,See posts in HBASE-26836. Backport HBASE-25368 to branch-2 ,13435327,Resolved,Major,Fixed,23/Mar/22 10:41,25/Mar/22 10:06,2.5.0,"HBASE-26640 introduced two extra paths under master:store table: "".initializing"" and "".initialized"", in order to control when such store has been completed started for SFT. Problem is that TestHFileProcedurePrettyPrinter uses RegionInfo.isEncodedRegionName to determine if a given child path in the table dir is a valid region dir. Current implementation for RegionInfo.isEncodedRegionName considers "".initializing"" and "".initialized"" as valid region encoded names, thus the test ends up picking one of the flag dirs to list hfiles that should had been modified when validating the test outcome. Further improvements have been made to RegionInfo.isEncodedRegionName in HBASE-25368 to proper validate region names, but those weren't backported to branch-2." [hbase-thirdparty] Introduce a hbase-unsafe module in hbase-thirdparty to remove the direct references of Unsafe in our main code base,13430796,Resolved,Major,Fixed,26/Feb/22 03:28,01/Mar/22 13:30,,"For java 9+, sun.misc.Unsafe is in the module jdk.unsupported. When compiling with java 11 --release 8, these symbols will not be exported and lead to compile errors. There is a jdk issue https://bugs.openjdk.java.net/browse/JDK-8214165 But seems the jdk team does not want to fix it. So if we want to move up to java 11 but still keep the java 8 compatibility, a possible choice is to remove the direct reference of sun.misc.Unsafe so at compile time there will be no problem, and at runtime we export the jdk.unsupported so there will be no problem too. For more details, please see the discussion of this thread on the dev mailing list. https://lists.apache.org/thread/w5lrxkhswlonj09xf9hcwgvck3nsjdfx" Increase the timeout for TestStochasticLoadBalancerRegionReplicaLargeCluster,13420330,Resolved,Major,Fixed,03/Jan/22 08:26,29/Jan/24 18:32,2.5.0,"TestStochasticLoadBalancerRegionReplicaLargeCluster is on the flaky list for branch-2, it fails 50%+. Looking at the output, sometimes it can not finish all the calculation in time, so let's see if increasing the timeout can help here." Introduce read/write request size metrics,13434715,Open,Major,,20/Mar/22 06:51,,2.4.11,"Calculating the read and write size(unit is bytes) in the region, and aggregated in table and regionserver levels." "When encounters EOF exception, replication log will not be dequeued",13433866,Open,Major,,15/Mar/22 12:25,,2.4.10,"We met this problem on our production clusters, and in the pre-commit tests, it also occured.  We can see this test logs,   {code:java} 2022-03-14T15:31:16,225 INFO [Time-limited test] wal.AbstractFSWAL(840): Rolled WAL /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4219/yetus-jdk8-hadoop3-check/src/hbase-server/target/test-data/b3808e70-5b17-10bb-3bd3-fdd825fd8fab/WALs/testSizeOfLogQueue/testSizeOfLogQueue.1647271876165 with entries=1, filesize=210 B; new WAL /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4219/yetus-jdk8-hadoop3-check/src/hbase-server/target/test-data/b3808e70-5b17-10bb-3bd3-fdd825fd8fab/WALs/testSizeOfLogQueue/testSizeOfLogQueue.1647271876191 2022-03-14T15:31:16,225 DEBUG [Time-limited test] wal.AbstractFSWAL(927): Create new AsyncFSWAL writer with pipeline: [DatanodeInfoWithStorage[127.0.0.1:34961,DS-77496ab4-d8f2-4bee-af67-6f1c3e08de20,DISK], DatanodeInfoWithStorage[127.0.0.1:38455,DS-50a46a7f-6202-4177-a91f-7da535dbf07f,DISK], DatanodeInfoWithStorage[127.0.0.1:40111,DS-d41b66a9-f9d5-4a57-9969-ac93cae6c9ac,DISK]] 2022-03-14T15:31:16,338 WARN [Close-WAL-Writer-0] asyncfs.FanOutOneBlockAsyncDFSOutputHelper(593): complete file /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4219/yetus-jdk8-hadoop3-check/src/hbase-server/target/test-data/b3808e70-5b17-10bb-3bd3-fdd825fd8fab/WALs/testSizeOfLogQueue/testSizeOfLogQueue.1647271876165 not finished, retry = 0 2022-03-14T15:31:16,357 DEBUG [Time-limited test] wal.ProtobufLogReader(456): Encountered a malformed edit, seeking back to last good position in file, from 211 to 210 java.io.EOFException: Partial PB while reading WAL, probably an unexpected EOF, ignoring. current offset=211 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:399) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:105) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:93) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:264) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:178) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:103) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testSizeOfLogQueue(TestBasicWALEntryStream.java:698) ~[test-classes/:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_282] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_282] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_282] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_282] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) ~[junit-4.13.2.jar:4.13.2] at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) ~[junit-4.13.2.jar:4.13.2] at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) ~[hbase-common-3.0.0-alpha-3-SNAPSHOT-tests.jar:3.0.0-alpha-3-SNAPSHOT] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) ~[junit-4.13.2.jar:4.13.2] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_282] at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_282] 2022-03-14T15:31:16,511 DEBUG [Time-limited test] wal.AbstractFSWAL(1050): Moved 2 WAL file(s) to /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4219/yetus-jdk8-hadoop3-check/src/hbase-server/target/test-data/b3808e70-5b17-10bb-3bd3-fdd825fd8fab/oldWALs 2022-03-14T15:31:16,511 INFO [Time-limited test] wal.AbstractFSWAL(1053): Closed WAL: AsyncFSWAL testSizeOfLogQueue:(num 1647271876191) {code} And this is the failure info,     {code:java} Failedprecommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStreamFSHLog.testSizeOfLogQueueFailing for the past 1 build (Since #1 )运行时间：0.41 secError Messageexpected:<1> but was:<2>Stacktracejava.lang.AssertionError: expected:<1> but was:<2> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testSizeOfLogQueue(TestBasicWALEntryStream.java:701) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) {code} The link is [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4219/1/testReport/org.apache.hadoop.hbase.replication.regionserver/TestBasicWALEntryStreamFSHLog/precommit_checks___yetus_jdk8_Hadoop3_checks___testSizeOfLogQueue/]     I can not figure out what the problem is yet, but we can change the UT to find more info.  " HFileBlock.verifyOnDiskSizeMatchesHeader throw IOException: Passed in onDiskSizeWithHeader= A != B,13431289,Open,Major,,01/Mar/22 14:51,,2.2.2,"When I scan a region, HBase throw IOException: Passed in onDiskSizeWithHeader= A != B The HFile mentioned Error message can be access normally. it recover by command – move region. I guess that onDiskSizeWithHeader of HFileBlock has been changed. And RS get the correct BlockHeader Info after region reopened.  " HBASE-26664 hbase-connector upgrades extra-enforcer-rules to 1.5.1,13422616,Resolved,Major,Fixed,13/Jan/22 20:02,13/Jan/22 22:12,hbase-connectors-1.1.0,"hbase-connector fails when building with -Prelease after maven-enforcer-plugin upgraded to 3.0.0 from 3.0.0-M3 in HBASE-26534. We upgraded maven-enforcer-plugin from 3.0.0-M3 to 3.0.0, but then we hit the problem of `extra-enforcer-rules` has different as mentioned in https://github.com/mojohaus/extra-enforcer-rules/issues/131#issuecomment-890329715 {code} $ mvn clean install -Prelease [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) on project hbase-connectors: Unable to parse configuration of mojo org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce for parameter enforceBytecodeVersion: Cannot create instance of class org.apache.maven.plugins.enforcer.EnforceBytecodeVersion: org/apache/maven/shared/dependency/tree/DependencyTreeBuilderException: org.apache.maven.shared.dependency.tree.DependencyTreeBuilderException -> [Help 1] {code} https://github.com/mojohaus/extra-enforcer-rules/commit/d380fe56a7317a237bbce5b94fbab7f4581d3d1b" "hbase master crash after running couple of days with error STUCK Region-In-Transition rit=FAILED_OPEN, location=null, table=hbase:meta, region=xxxxxxxxxx",13428237,Open,Major,,14/Feb/22 06:04,,2.4.8,"hbase master not responding after running couple of days and region server keep restarting. we are seeing bellow warning in master and region server     WARN [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition rit=FAILED_OPEN, location=null, table=hbase:meta, region=xxxxxxxxxxxxx [master/xxxx-infra-xxxxx-hbase-master-0:16000.Chore.3] master.HMaster: Not running balancer because processing dead regionserver(s): 2022-02-07 19:54:11,512 INFO [ReadOnlyZKClient-xxxxxx-zookeeper:2181@0x2fcc92d9] zookeeper.ZooKeeper: Initiating client connection, connectString=xxxx-zookeeper:2181 sessionTimeout=90000 watcher=org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$$Lambda$158/0x000000010057b440@48d2e00b     WARN [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition rit=FAILED_OPEN, location=null, table=hbase:meta, region=1588230740 2022-02-07 19:54:15,643 INFO [hconnection-0x31420403-shared-pool7-t9731] client.RpcRetryingCallerImpl: org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3223) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:2947) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3272) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42002) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:409) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) , details=row '' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=xxx-infra-xxxx-hbase-regionserver-0.xxx-infra-xxxx-hbase-regionserver.default.svc.cluster.local,16020,1644089730940, seqNum=-1   from region server logs 2022-02-05 19:39:16,722 WARN [RpcServer.default.FPBQ.Fifo.handler=109,queue=5,port=16020] regionserver.RSRpcServices: Client tried to access missing scanner 0 2022-02-05 19:39:16,722 WARN [RpcServer.default.FPBQ.Fifo.handler=25,queue=12,port=16020] regionserver.RSRpcServices: Client tried to access missing scanner 0 2022-02-05 19:39:16,721 WARN [RpcServer.default.FPBQ.Fifo.handler=24,queue=11,port=16020] regionserver.RSRpcServices: Client tried to access missing scanner 0 2022-02-05 19:39:16,721 WARN [RpcServer.default.FPBQ.Fifo.handler=112,queue=8,port=16020] regionserver.RSRpcServices: Client tried to access missing scanner 0 2022-02-05 19:39:16,721 WARN [RpcServer.default.FPBQ.Fifo.handler=40,queue=1,port=16020] regionserver.RSRpcServices: Client tried to access missing scanner 0 ==> /opt/hbase-2.0.1/logs/SecurityAuth.audit <== 2022-02-05 19:39:17,882 INFO SecurityLogger.org.apache.hadoop.hbase.Server: Auth successful for hdfs (auth:) 2022-02-05 19:39:17,882 INFO SecurityLogger.org.apache.hadoop.hbase.Server: Connection from 10.42.0.124 port: 44876 with unknown version info 2022-02-05 19:40:18,307 INFO SecurityLogger.org.apache.hadoop.hbase.Server: Auth successful for hdfs (auth:) 2022-02-05 19:40:18,307 INFO SecurityLogger.org.apache.hadoop.hbase.Server: Connection from 10.42.0.124 port: 51098 with unknown version info ==> /opt/hbase-2.0.1/logs/hbase--regionserver-xxxx-infra-xxxxx-hbase-regionserver-0.log <== 2022-02-05 19:40:32,848 INFO [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=300.98 KB, freeSize=399.71 MB, max=400 MB, blockCount=0, accesses=0, hits=0, hitRatio=0, cachingAccesses=0, cachingHits=0, cachingHitsRatio=0,evictions=29, evicted=0, evictedPerRun=0.0" Rowkey pushdown does not work with complex conditions,13434599,Resolved,Major,Fixed,18/Mar/22 16:19,04/Aug/23 03:17,connector-1.0.0,"When using pushdown column filter feature of hbase-spark-connector, issuing complex query containing rowkey conditions does not get expected rowkey pushdown. {code:java} { ""table"":{""namespace"":""default"", ""name"":""t1""}, ""rowkey"":""key"", ""columns"":{ ""KEY_FIELD"":{""cf"":""rowkey"", ""col"":""key"", ""type"":""string""}, ""A_FIELD"":{""cf"":""c"", ""col"":""a"", ""type"":""string""}, ""B_FIELD"":{""cf"":""c"", ""col"":""b"", ""type"":""string""} } } {code} For example, given the catalog, a query `spark.sql(""SELECT * FROM table WHERE KEY_FIELD >= 'get1' AND KEY_FIELD <= 'get3' AND A_FIELD IS NOT NULL"")` gets incomplete rowkey pushdown (ScanRange:(upperBound:get3,isUpperBoundEqualTo:true,lowerBound:,isLowerBoundEqualTo:true)). If a query is `spark.sql(""SELECT * FROM table WHERE KEY_FIELD >= 'get1' AND KEY_FIELD <= 'get3'"")`, we get normal rowkey pushdown (ScanRange:(upperBound:get3,isUpperBoundEqualTo:true,lowerBound:,isLowerBoundEqualTo:true)). I found that ScanRange#getOverlapScanRange and ScanRange#mergeIntersect return incorrect results if the range from the arguments is wider than the instance (or  scanRange.getOverlapScanRange(scanRange) where scanRange1⊂scanRange2). Depending on the order of the Filters that the Spark optimization results produce, the order of the scan ranges that these methods receive could be the one that causes such a problem. I will create a PR later." Make the WAL interface async so sync replication can be built up on the WAL interface,13435958,Resolved,Major,Won't Fix,26/Mar/22 13:11,15/Jun/23 15:46,,"Instead of hacking into the WAL implementation. This could make the implementation more general if later we want to change the WAL implementation." HBase 1.x clients will choke on rep_barrier rows when scanning hbase 2.x meta,13431748,Resolved,Major,Fixed,03/Mar/22 15:09,04/Mar/22 22:01,1.7.1,"In hbase 2.x, support for serial replication included adding a new CF to meta called rep_barrier. When regions are split or merged, these rep_barrier rows will not be cleaned up. Instead there's a ReplicationBarrierCleaner chore which runs every 12 hours. HBase 2.x clients will ignore these rep_barrier rows, per the [addFamily call in locateRegionInMeta|[https://github.com/apache/hbase/blob/branch-2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L929].] Encountering these orphan rep_barrier rows causes the hbase 1.x client to fail when it [tries to extract the region location from the meta row|[https://github.com/apache/hbase/blob/branch-1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java#L1340-L1344].] This is a non-recoverable exception, so retries will fail and it will eventually bubble up. The immediate fix when encountering this is to run {{{}hbck2 fixMeta{}}}, but we should fix the hbase 1.x client to similarly filter on the CATALOG_FAMILY to avoid these issues altogether." Remove javax.ws.rs-api dependency,13432699,Reopened,Major,,08/Mar/22 20:33,,2.5.0,"I see that we still have {{javax.ws.rs-api}} as a dependency in our hbase-http pom. If, for example, the {{ClientBuilder}} from this jar is used, it'll instantiate whatever non-shaded jersey client is on the class path." RSRpcServices.scan should deep clone cells when RpcCallContext is null,13434735,Resolved,Major,Fixed,20/Mar/22 11:41,23/Mar/22 11:46,2.4.11,"When inspect HBASE-26812, I find that if {{RpcCallContext}} is null, {{RSRpcServices.scan}} does not set {{ServerCall.rpcCallback}} and directly closes {{RegionScannerImpl}}, but it does not deep clone the result cells , so these cells may be returned to the {{ByteBuffAllocator}} and may be overwritten before the caller reads them, similar as HBASE-26036, and at the same time, if {{RpcCallContext}} is null, when {{RSRpcServices.scan}} return partial results, it does not invoke {{RegionScannerImpl.shipped}} to release the used resources such as {{HFileScanner}}, pooled {{ByteBuffer}} etc. No matter {{ShortCircuitingClusterConnection}} should be removed or not, I think this {{RSRpcServices.scan}} problem should fix for future maintainability." "Default StoreHotnessProtector to off, with logs to guide when to turn it on",13432700,Resolved,Major,Fixed,08/Mar/22 20:41,10/Mar/22 18:12,,"As discussed in HBASE-26522 and somewhat in HBASE-26575, StoreHotnessProtector is too conservative. One can easily trigger RegionTooBusyException on an otherwise idle regionserver with relatively small amount of traffic. The idea behind this protection is good, but it needs to take into account current load in order to warrant being enabled by default. Until it's improved as such, we should change it to default off. One thing we can do to help drive usage would be to add warning logs when it would have triggered. Operators who are diagnosing performance issues will naturally look at the logs and see indication of a potential tool for mitigation. cc [~andrew.purtell@gmail.com] " Shutdown WAL may abort region server,13434645,Resolved,Major,Fixed,19/Mar/22 02:06,24/Mar/23 09:31,,"https://nightlies.apache.org/hbase/HBase-Flaky-Tests/master/3140/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.replication.TestSyncReplicationActive-output.txt TestSyncReplicationAcive is flaky because of we may abort the region server when shutting down WAL. {noformat} 2022-03-18T04:50:37,205 WARN [RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=36877] master.MasterRpcServices(682): jenkins-hbase13.apache.org,33377,1647579008859 reported a fatal error: ***** ABORTING region server jenkins-hbase13.apache.org,33377,1647579008859: Log rolling failed ***** Cause: java.util.concurrent.RejectedExecutionException: Task org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$$Lambda$681/1458648270@37209753 rejected from java.util.concurrent.ThreadPoolExecutor@69662eb7[Shutting down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks = 0] at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063) at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830) at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379) at java.util.concurrent.Executors$DelegatedExecutorService.execute(Executors.java:668) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.cleanOldLogs(AbstractFSWAL.java:773) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriterInternal(AbstractFSWAL.java:935) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$rollWriter$8(AbstractFSWAL.java:953) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:196) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:953) at org.apache.hadoop.hbase.wal.AbstractWALRoller$RollController.rollWal(AbstractWALRoller.java:316) at org.apache.hadoop.hbase.wal.AbstractWALRoller.run(AbstractWALRoller.java:214) {noformat} The problem here is that, the removal of WAL is async, when shuttting down the WAL, we will close the thread pool so it will throw reject execution exception and cause region server abort." FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1,13426744,Open,Major,,05/Feb/22 10:15,,,"I just had the same problem when i started the hbase cluster. HRegionServers were started and HMaster threw an exception. This is HMaster's log: {code:java} 2022-02-05 18:07:51,323 WARN  [RS-EventLoopGroup-1-1] concurrent.DefaultPromise: An exception was thrown by org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$4.operationComplete() java.lang.IllegalArgumentException: object is not an instance of declaring class         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.apache.hadoop.hbase.io.asyncfs.ProtobufDecoder.(ProtobufDecoder.java:69)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.processWriteBlockResponse(FanOutOneBlockAsyncDFSOutputHelper.java:343)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$100(FanOutOneBlockAsyncDFSOutputHelper.java:112)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$4.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:425)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:577)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:551)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:490)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:183)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.initialize(FanOutOneBlockAsyncDFSOutputHelper.java:419)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$300(FanOutOneBlockAsyncDFSOutputHelper.java:112)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$5.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:477)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$5.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:472)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:577)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:570)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:549)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:490)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:615)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setSuccess0(DefaultPromise.java:604)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:104)         at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:84)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.fulfillConnectPromise(AbstractEpollChannel.java:615)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.finishConnect(AbstractEpollChannel.java:653)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:529)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:465)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)         at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)         at java.lang.Thread.run(Thread.java:748) 2022-02-05 18:07:51,326 WARN  [RS-EventLoopGroup-1-2] concurrent.DefaultPromise: An exception was thrown by org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$4.operationComplete() java.lang.IllegalArgumentException: object is not an instance of declaring class         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.apache.hadoop.hbase.io.asyncfs.ProtobufDecoder.(ProtobufDecoder.java:69)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.processWriteBlockResponse(FanOutOneBlockAsyncDFSOutputHelper.java:343)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$100(FanOutOneBlockAsyncDFSOutputHelper.java:112)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$4.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:425)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:577)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:551)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:490)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:183)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.initialize(FanOutOneBlockAsyncDFSOutputHelper.java:419)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$300(FanOutOneBlockAsyncDFSOutputHelper.java:112)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$5.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:477)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$5.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:472)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:577)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:570)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:549)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:490)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:615)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setSuccess0(DefaultPromise.java:604)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:104)         at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:84)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.fulfillConnectPromise(AbstractEpollChannel.java:615)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.finishConnect(AbstractEpollChannel.java:653)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:529)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:465)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)         at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)         at java.lang.Thread.run(Thread.java:748) {code}  " [hbase-operator-tools] Upgrade log4j to 2.17.1,13421273,Resolved,Major,Fixed,07/Jan/22 10:13,07/Jan/22 12:27,hbase-operator-tools-1.2.0,For addressing CVE-2021-44832. Optimize the implementation of LRUCache in LRUDictionary,13434063,Reopened,Major,,16/Mar/22 09:14,,1.7.1,"*This issue is to unify the behavior of reading and writing links.*   During my research on HBASE-26849, I found that there seems to be something wrong with the implementation of LRUDictionary. It uses array to save data, and uses hashMap to save array index. For the write link: {code:java} CompressedKvEncoder#write -> LRUDictionary#findEntry -> LRUDictionary#addEntry {code} And for the read link: {code:java} CompressedKVDecoder#readIntoArray -> LRUDirectory#addEntry {code} Then we could see the logic in {_}findEntry{_}: {code:java} @Override public short findEntry(byte[] data, int offset, int length) { short ret = backingStore.findIdx(data, offset, length); if (ret == NOT_IN_DICTIONARY) { addEntry(data, offset, length); } return ret; } private short findIdx(byte[] array, int offset, int length) { Short s; final Node comparisonNode = new Node(); comparisonNode.setContents(array, offset, length); if ((s = nodeToIndex.get(comparisonNode)) != null) { moveToHead(indexToNode[s]); return s; } else { return -1; } } {code} At first it will try to find if there is same node in the cache, If there is, use it directly. The problem is, *if we have some same nodes, The behavior on the read and write links are inconsistent:* On the write link we will reuse just one node, but on the read link multiple copies will be stored in the array. but there is only one mapping from the node to the array index in the map. So, on the read link, if the first 'same' node is evict, we will remove it from the map, then we might met a NPE because when the second 'same' node evict we can not find it in the map." Upgrade create-release to support both JDK8 and JDK11,13420644,In Progress,Major,,04/Jan/22 18:50,,3.0.0-alpha-3,"Follow-on for HBASE-25465, assuming that builds with JDK11 meet our runtime compatibility requirements." [hbase-thirdparty] Upgrade Netty to 4.1.73.Final,13426703,Resolved,Major,Fixed,04/Feb/22 20:15,05/Feb/22 08:20,,"Netty 4.1.71.Final included a fix for [HTTP-request-smuggling|https://github.com/netty/netty/security/advisories/GHSA-wx5j-54mm-rqqq]. We are still on 4.1.70.Final. Latest is 4.1.73.Final, use that." Run spotless:apply,13436227,Resolved,Major,Fixed,28/Mar/22 18:13,01/May/22 15:14,,"Given we will ask and encourage contributors to run spotless:apply before completing contributions, we should apply spotless:apply to all live branches, to establish a clean baseline. In particular branch-2.4 has issues. " getAllRegionLocations can cache locations with null hostname,13431524,Resolved,Major,Fixed,02/Mar/22 15:53,24/Jun/22 11:56,,"RegionLocator methods typically delegate to ConnectionImplementation.locateRegion, which throws a NoServerForRegionException if the located region's serverName is null. RegionLocator.getAllRegionLocations does not go through that path, instead caching all returned region locations without any validation. This can result in a ""dirty"" meta cache, since clients do not expect to have null serverNames in the meta cache. We should add the same throwing of NoServerForRegionException to this method as used in the others. Or at least we should not cache the result if the serverName is null." ExportSnapshot should validate the source snapshot before copying files,13425291,Resolved,Major,Fixed,28/Jan/22 01:14,16/Mar/22 12:34,0.99.0,"Running {{ExportSnapshot}} with default parameters will copy the snapshot to a target location, and then use {{verifySnapshot}} to validate the integrity of the written snapshot. However, it is possible for the source snapshot to be invalid which leads to an invalid exported snapshot. We can validate the source snapshot before export. By default, we can validate the source snapshot unless the {{-no-target-verify}} parameter is set. We could also introduce a separate parameter for {{-no-source-verify}} if an operator wanted to validate the target but not validate the source for some reason, to provide some amount of backwards compatibility if that scenario is important." "RpcServer failure to SASL handshake always logs user ""unknown"" to audit log",13430960,Resolved,Major,Fixed,28/Feb/22 10:23,02/Mar/22 14:52,2.4.10,"Over on HBASE-26622, we noticed that the ""attempting user"" is always returned as ""Unknown"". This information is sent to the audit log when constructing the {{HBaseSaslRpcServer}}." Upgrade Maven Enforcer Plugin,13422612,Resolved,Major,Fixed,13/Jan/22 19:17,28/Feb/22 09:25,2.5.0,I've noticed that the beanshell rule run by our configuration of the enforcer plugin will sometimes cause build failures when I run maven with {{-T1.0C}}. It seems that this is a known issue (MENFORCER-336) that has been fixed in a later version of the plugin. Let's upgrade. Close and do not write trailer for the broken WAL writer,13423229,Resolved,Major,Fixed,18/Jan/22 09:56,16/Mar/22 12:36,2.0.0,"{code:java} public static AsyncWriter createAsyncWriter(Configuration conf, FileSystem fs, Path path, boolean overwritable, long blocksize, EventLoopGroup eventLoopGroup, Class channelClass, StreamSlowMonitor monitor) throws IOException { // Configuration already does caching for the Class lookup. Class logWriterClass = conf.getClass( WRITER_IMPL, AsyncProtobufLogWriter.class, AsyncWriter.class); try { AsyncWriter writer = logWriterClass.getConstructor(EventLoopGroup.class, Class.class) .newInstance(eventLoopGroup, channelClass); writer.init(fs, path, conf, overwritable, blocksize, monitor); return writer; } catch (Exception e) { if (e instanceof CommonFSUtils.StreamLacksCapabilityException) { LOG.error(""The RegionServer async write ahead log provider "" + ""relies on the ability to call "" + e.getMessage() + "" for proper operation during "" + ""component failures, but the current FileSystem does not support doing so. Please "" + ""check the config value of '"" + CommonFSUtils.HBASE_WAL_DIR + ""' and ensure "" + ""it points to a FileSystem mount that has suitable capabilities for output streams.""); } else { LOG.debug(""Error instantiating log writer."", e); } Throwables.propagateIfPossible(e, IOException.class); throw new IOException(""cannot get log writer"", e); } } {code} I think writer should be closed when encounters init exception here. This can reduce the recoverLease time before log split, and will reduce side effects after HBASE-26552.  Broken writers need to be closed, so that when doing log split, there will be no need to recover lease for those length 0 wals." Secondary replica may be disabled for read incorrectly forever,13432533,Resolved,Major,Fixed,08/Mar/22 02:13,01/Apr/22 03:54,2.4.10,"For read replica, when I set {{hbase.region.replica.wait.for.primary.flush}} to false, and set {{TableDescriptorBuilder.setRegionMemStoreReplication}} to true explicitly at table level, the secondary replica would be disabled for read, reading on this replica region would throw : {code:java} java.io.IOException: The region's reads are disabled. Cannot serve the request at org.apache.hadoop.hbase.regionserver.HRegion.checkReadsEnabled(HRegion.java:5187) at org.apache.hadoop.hbase.regionserver.HRegion.startRegionOperation(HRegion.java:8279) {code} Very strange, if I don't set {{TableDescriptorBuilder.setRegionMemStoreReplication}} to true explicitly (which default value is true), the secondary replica is normal. This problem is because when set {{hbase.region.replica.wait.for.primary.flush}} to false, the {{HRegionServer.startServices}} would not create the {{ExecutorType.RS_REGION_REPLICA_FLUSH_OPS}} for {{RegionReplicaFlushHandler}} at HRegionServer-level: {code:java} if (ServerRegionReplicaUtil.isRegionReplicaWaitForPrimaryFlushEnabled(conf)) { final int regionReplicaFlushThreads = conf.getInt( ""hbase.regionserver.region.replica.flusher.threads"", conf.getInt( ""hbase.regionserver.executor.openregion.threads"", 3)); executorService.startExecutorService(executorService.new ExecutorConfig().setExecutorType( ExecutorType.RS_REGION_REPLICA_FLUSH_OPS).setCorePoolSize(regionReplicaFlushThreads)); } {code} but when I set {{TableDescriptorBuilder.setRegionMemStoreReplication}} to true explicitly, it also set {{hbase.region.replica.wait.for.primary.flush}} to true at table-level(there is no public {{hbase.region.replica.wait.for.primary.flush} config for hbase user at table-level): {code:java} public ModifyableTableDescriptor setRegionMemStoreReplication(boolean memstoreReplication) { setValue(REGION_MEMSTORE_REPLICATION_KEY, Boolean.toString(memstoreReplication)); // If the memstore replication is setup, we do not have to wait for observing a flush event // from primary before starting to serve reads, because gaps from replication is not applicable return setValue(REGION_REPLICA_WAIT_FOR_PRIMARY_FLUSH_CONF_KEY, Boolean.toString(memstoreReplication)); } {code} So when the secondary replica region is open,{{HRegionServer.triggerFlushInPrimaryRegion}} is invoked for this region, because {{hbase.region.replica.wait.for.primary.flush}} to true at table-level, the line 2234 is skipped, secondary replica is disabled for read at line 2238, but there is no {{ExecutorType.RS_REGION_REPLICA_FLUSH_OPS}} for {{RegionReplicaFlushHandler}} at HRegionServer-level, so line 2243 would not schedule {{RegionReplicaFlushHandler}}, the secondary replica would be disabled for read. {code:java} 2227 private void triggerFlushInPrimaryRegion(final HRegion region) { ... 2232 if (!ServerRegionReplicaUtil.isRegionReplicaReplicationEnabled(region.conf, tn) || 2233 !ServerRegionReplicaUtil.isRegionReplicaWaitForPrimaryFlushEnabled(region.conf)) { 2234 region.setReadsEnabled(true); 2235 return; 2236 } 2237 2238 region.setReadsEnabled(false); // disable reads before marking the region as opened. 2239 // RegionReplicaFlushHandler might reset this. 2240 2241 // Submit it to be handled by one of the handlers so that we do not block OpenRegionHandler 2242 if (this.executorService != null) { 2243 this.executorService.submit(new RegionReplicaFlushHandler(this, region)); 2244 } else { ... {code} I think for above {{ModifyableTableDescriptor.setRegionMemStoreReplication}}, when set it to true, there is no reason to also set the {{hbase.region.replica.wait.for.primary.flush}} to true at table-level. This problem may be more serious on master because the new replication framework (HBASE-26233) does not enable the secondary replica read when receives the flush marker, that is to say, the secondary replica read would be disabled for read forever. But for branch-2, the secondary replica would be enabled for read when receives the flush marker. " Avoid repeated releasing of flushed wal entries in AsyncFSWAL#syncCompleted ,13433592,Resolved,Major,Fixed,14/Mar/22 08:08,28/Mar/22 00:13,2.4.10,"As some discussions in HBASE-22761, without checking the epoch in AsyncFSWAL#syncCompleted may cause some entries be released too early." Increase the concurrency when running UTs in pre commit job,13433375,Resolved,Major,Fixed,11/Mar/22 16:13,17/Mar/22 00:10,,"The default forkCount is 0.25C. We used to run on a 16 cores machine so the concurrency is 4, but now our build nodes are all 8 cores, so the concurrency is 2. The build time is way more slower than before. Since we only have 2 slots on the build node, I think it is OK to increase the forkCount to 0.5C. But I'm not sure whether we should change the default value in pom, or we just set it in the pre commit job." "Junit jar is not included in the hbase tar ball, causing issues for some hbase tools that do rely on it",13433726,Resolved,Major,Fixed,14/Mar/22 22:02,31/Mar/22 22:08,2.4.11,"We used to include junit jar on the generated tar ball lib directory. After some sanitisation of unnecessary libs for most of hbase processes, junit got removed from the packing, so that it don't end in hbase classpath by default.  Some testing tools, however do depend on junit at runtime, and would now fail with NoClassDefFoundError, like [IntegrationTestIngest:|https://hbase.apache.org/book.html#chaos.monkey.properties] {noformat} 2022-03-14T21:54:50,483 INFO  [main] client.AsyncConnectionImpl: Connection has been closed by main. Exception in thread ""main"" java.lang.NoClassDefFoundError: org/junit/Assert at org.apache.hadoop.hbase.IntegrationTestIngest.initTable(IntegrationTestIngest.java:101) at org.apache.hadoop.hbase.IntegrationTestIngest.setUpCluster(IntegrationTestIngest.java:92) at org.apache.hadoop.hbase.IntegrationTestBase.setUp(IntegrationTestBase.java:170) at org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:153) at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:153) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.IntegrationTestIngest.main(IntegrationTestIngest.java:259) Caused by: java.lang.ClassNotFoundException: org.junit.Assert at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) ... 7 more {noformat} Discussing with [~elserj] internally, we believe a reasonable solution would be to include junit jar back into the tarball, under ""lib/test"" dir so that it's not automatically added to hbase processes classpath, but still allow operators to manually define it in a convenient way, like below: {noformat} HBASE_CLASSPATH=""$HBASE_HOME/lib/tests/*"" hbase org.apache.hadoop.hbase.IntegrationTesngest -m slowDeterministic {noformat}" Use HIGH_QOS for ResultScanner.close requests,13431365,Resolved,Major,Fixed,01/Mar/22 20:58,08/Mar/22 19:40,,"Active scanners take resources on the RegionServer, and scanner leaks can have a big impact on GC. Under high load, ResultScanner.close() calls might get rejected or timed out before executing. Exceptions thrown by close() are currently swallowed, so clients will not retry. This leads to a leak of active scanners on the server side. These calls should be relatively free to execute, and executing them will free up the resources which can have an impact on overall RegionServer performance. As such it can be beneficial to execute all ResultScanner.close() requests with HIGH_QOS regardless of the priority of the underlying Scan. In a scan-heavy stress test I ran, after a couple minutes the Full GC time (using G1GC) starts increasing and we start seeing 1s pauses, due to increasing number of active scanners (into the 10s of thousands). Re-running the stress test with HIGH_QOS for ResultScanner.close() eliminates the leak and GC time remains stable." ScannerCallable doubly clears meta cache on retries,13431347,Resolved,Major,Fixed,01/Mar/22 18:50,09/Mar/22 22:41,2.4.10,"Way back in HBASE-15658 [~ghelmling] fixed RegionServerCallable to not clear meta in {{{}prepare(boolean reload){}}}. because it already would have cleared it in the try/catch when {{{}throwable(Throwable t, boolean retrying){}}}. I have recently been doing some load tests where I am causing HBase RegionServers to throw many CallDroppedExceptions because they are overloaded by the test. While this is an extreme example, it does sometimes crop up in production when a bad actor executes a job without rate limiting, etc. What I noticed was that the RegionServer hosting meta was most affected by the load, way more than any other server in the cluster. Digging into the issue I realized that the extra meta load was coming mostly from the scans, originating from {{{}ScannerCallable.prepare(boolean reload){}}}. I'm not sure why ScannerCallable was excluded from the original jira, maybe an oversight. But ScannerCallable is called in the same context of RetryingRpcCaller, which will handle clearing meta in the try/catch like other callables. We should similarly update ScannerCallable's prepare method not always pass useCache=true when getting region locations." The TRSP should not go on when it get a bogus server name from AM,13435791,Resolved,Major,Fixed,25/Mar/22 11:23,04/Apr/22 12:32,,"Currently it will submit lots of unnecessary OpenRegionProcedure by retry. Related log looks like below, 'localhost,1,1' is the bogus server: {code:java} 2022-03-22 10:17:48,301 WARN  [PEWorker-8] assignment.RegionRemoteProcedureBase: Can not add remote operation pid=17952, ppid=17951, state=RUNNABLE, locked=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure for region {ENCODED => 490391c232c7aa13f7e0d50bfe1f7235, NAME => 'TestTable1,0000000000000000002497747,1647568640784.490391c232c7aa13f7e0d50bfe1f7235.', STARTKEY => '0000000000000000002497747', ENDKEY => ''} to server localhost,1,1, this usually because the server is alread dead, give up and mark the procedure as complete, the parent procedure will take care of this. org.apache.hadoop.hbase.procedure2.NoServerDispatchException: localhost,1,1; pid=17952, ppid=17951, state=RUNNABLE, locked=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure         at org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher.addOperationToNode(RemoteProcedureDispatcher.java:168)         at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:285)         at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:58)         at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1648)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1395)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1965) 2022-03-22 10:17:48,301 DEBUG [PEWorker-8] procedure2.RootProcedureState: Add procedure pid=17952, ppid=17951, state=SUCCESS, locked=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure as the 8th rollback step {code}" User.createUserForTesting should not reset UserProvider.groups every time if hbase.group.service.for.test.only is true,13422564,Resolved,Major,Fixed,13/Jan/22 16:05,18/Jan/22 13:24,2.4.9,"The _if check_ below will always unnecessarily reset static var _UserProvider.groups_ to a newly created instance of TestingGroups every time `User.createUserForTesting` is called. {noformat} if (!(UserProvider.groups instanceof TestingGroups) || conf.getBoolean(TestingGroups.TEST_CONF, false)) { UserProvider.groups = new TestingGroups(UserProvider.groups); } {noformat} For tests creating multiple {_}test users{_}, this causes the latest created user to reset _groups_ and all previously created users would now have to be available on the {_}User.underlyingImplementation{_}, which not always will be true." Balancer encounters NPE in rare case,13425023,Resolved,Major,Fixed,26/Jan/22 19:34,16/Feb/22 10:10,2.4.9,"  {code:java} ERROR [ster-1:60000.Chore.1] hbase.ScheduledChore - Caught error java.lang.NullPointerException     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.balance(AssignmentManager.java:758)     at org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1834)     at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1797)     at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1707)     at org.apache.hadoop.hbase.master.balancer.BalancerChore.chore(BalancerChore.java:49)     at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:153)     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)     at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)     at org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:748) {code} Let's fix this." Blocked on SyncFuture in AsyncProtobufLogWriter#write,13425168,Resolved,Major,Fixed,27/Jan/22 13:47,10/Mar/22 20:21,,"Ran into an issue on hbase 2.4.6, I think related to HBASE-26679. Individual writes are blocking on SyncFuture, which never gets completed. Eventually (5m) the writes timeout and fail. But the regionserver hung on like this basically forever until I killed it about 14 hours later. While 26679 may fix the hang bug, I think we should have additional protection against such zombie states. In this case I think what happened is that the rollWAL was requested due to failed appends, but it also hung forever. See the below stack trace:   {code:java} Thread 240 (regionserver/host:60020.logRoller): State: WAITING Blocked count: 38 Waited count: 293 Waiting on java.util.concurrent.CompletableFuture$Signaller@13342c6d Stack: java.base@11.0.5/jdk.internal.misc.Unsafe.park(Native Method) java.base@11.0.5/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194) java.base@11.0.5/java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1796) java.base@11.0.5/java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3128) java.base@11.0.5/java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1823) java.base@11.0.5/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1998) app//org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.write(AsyncProtobufLogWriter.java:189) app//org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeMagicAndWALHeader(AsyncProtobufLogWriter.java:202) app//org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:170) app//org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:113) app//org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:669) app//org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:130) app//org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:841) app//org.apache.hadoop.hbase.wal.AbstractWALRoller$RollController.rollWal(AbstractWALRoller.java:268) app//org.apache.hadoop.hbase.wal.AbstractWALRoller.run(AbstractWALRoller.java:187) {code}   The wall roller thread was stuck on this wait seemingly forever, so it was never able to roll the wal and get writes working again. I think we should add a timeout here, and abort the regionserver if a WAL cannot be rolled in a timely manner." Avoid waiting to clear buffer usage of ReplicationSourceShipper when aborting the RS,13433624,Resolved,Major,Fixed,14/Mar/22 10:05,17/Mar/22 15:33,2.4.10,"HBASE-24813 introduced the clear of buffer used in replication source shipper, but there is sleep in the method, if the variable sleepForRetries has a large value, and there are many wal groups, the aborting of RS may last a long time, but we should only do some necessary things in the aborting progress. {code:java} void clearWALEntryBatch() { long timeout = System.currentTimeMillis() + this.shipEditsTimeout; while(this.isAlive() || this.entryReader.isAlive()){ try { if (System.currentTimeMillis() >= timeout) { LOG.warn(""Shipper clearWALEntryBatch method timed out whilst waiting reader/shipper "" + ""thread to stop. Not cleaning buffer usage. Shipper alive: {}; Reader alive: {}"", this.source.getPeerId(), this.isAlive(), this.entryReader.isAlive()); return; } else { // Wait both shipper and reader threads to stop Thread.sleep(this.sleepForRetries); } } catch (InterruptedException e) { LOG.warn(""{} Interrupted while waiting {} to stop on clearWALEntryBatch. "" + ""Not cleaning buffer usage: {}"", this.source.getPeerId(), this.getName(), e); return; } } ...... {code}" TestHBaseTestingUtil.testResolvePortConflict failing after HBASE-26582,13433184,Resolved,Major,Fixed,10/Mar/22 17:14,11/Mar/22 07:11,, Mark RpcExecutor as IA.LimitedPrivate COPROC and PHOENIX,13432853,Resolved,Major,Fixed,09/Mar/22 11:56,11/Mar/22 10:12,2.4.10,"{{RpcExecutor}}, an abstract base class, is marked as {{IA.Private}}. However, it has several subclasses that are marked as {{IA.LimitedPrivate(COPROC, PHOENIX)}}. I think that the base class needs to match the highest exposure level of any of its subclasses." SplitTableRegionProcedure calls openParentRegions() at a wrong state during rollback.,13434618,Resolved,Major,Fixed,18/Mar/22 19:59,26/Mar/22 19:22,2.4.10,"Changed the issue title and description for the scope of the work.  there is a bug in handling Rollback in SplitTableRegionProcedure. [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java#L304] [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java#L385] {code:java} In the state machine:         case SPLIT_TABLE_REGION_CLOSE_PARENT_REGION:           addChildProcedure(createUnassignProcedures(env)); // Comments from HX:           // createUnassignProcedures() can throw out IOException. If this happens,           // it wont reach state SPLIT_TABLE_REGIONS_CHECK_CLOSED_REGION and no parent regions           // is closed as all created UnassignProcedures are rolled back. If it rolls back with           // state SPLIT_TABLE_REGION_CLOSE_PARENT_REGION, no need to call openParentRegion(),           // otherwise, it will result in OpenRegionProcedure for an already open region.           setNextState(SplitTableRegionState.SPLIT_TABLE_REGIONS_CHECK_CLOSED_REGIONS);           break; In the rollback,         case SPLIT_TABLE_REGIONS_CHECK_CLOSED_REGIONS:           // Doing nothing, in SPLIT_TABLE_REGION_CLOSE_PARENT_REGION,           // we will bring parent region online           break;         case SPLIT_TABLE_REGION_CLOSE_PARENT_REGION: // Comments from HX: // OpenParentRegion() should not be called here as explained above.           openParentRegion(env);           break; {code}" Disable Checks API callback from test results in PRs,13431475,Resolved,Major,Fixed,02/Mar/22 10:46,03/Mar/22 14:10,,"Often as not, PR builds will succeed but be reported on the PR as a failure. The reason is represented in Jenkins pipeline as a warning in the ""Archive Junit-formatted test results"", with the message {noformat} [2022-03-01T22:05:49.166Z] Recording test results [2022-03-01T22:05:50.627Z] [Checks API] No suitable checks publisher found. {noformat} This is confusing and discouraging to contributors." Increments submitted by 1.x clients will be stored with timestamp 0 on 2.x+ clusters,13425044,Resolved,Major,Fixed,26/Jan/22 22:52,28/Jan/22 20:59,,"We discovered this in our work on upgrading from ~1.2.0 to 2.4.6. A 1.2.0 client will submit an Increment, without specifying a timestamp. This should be translated as LATEST_TIMESTAMP, but an hbase 2 server will store it with a timestamp of 0. This is because the QualifierValue timestamp proto field is optional, and is not set in branch-1 MutationProtos: [https://github.com/apache/hbase/blob/branch-1/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java#L218-L219.] In branch-1, the timestamp is actually ignored entirely: [https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L8435-L8456.] So this is not an issue there. As of HBASE-18546, the timestamp is no longer ignored, but the usage of QualiferValue.getTimestamp() in deserialization is not wrapped in a .hasTimestamp() call: [https://github.com/apache/hbase/blob/7d8dc3524981a04e82ff236bb3dc18d36ebc82b4/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L886-L909]. The default value for non-present optionals is defined by the underlying primitive, so for longs that is 0. Since the Increment's timestamp is now respected by HRegion, it causes the erroneous 0 value to be stored: [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L4180] (updateLatestStamp only overwrites the cell timestamp if it's LATEST_TIMESTAMP, which in this case it has been deserialized as 0) I think this might only apply to clients who do not use a KeyValueCodec." BufferedDataBlockEncoder$OffheapDecodedExtendedCell.deepClone throws UnsupportedOperationException,13431031,Resolved,Major,Fixed,28/Feb/22 15:50,04/Mar/22 21:53,2.4.10,"BufferedDataBlockEncoder$OffheapDecodedExtendedCell.deepClone throws an unsupportedException. However, org.apache.hadoop.hbase.regionserver.HRegion.get(Get, boolean, long, long) calls the method: {code:java}       // Copy EC to heap, then close the scanner.       // This can be an EXPENSIVE call. It may make an extra copy from offheap to onheap buffers.       // See more details in HBASE-26036. for (Cell cell : tmp) {         results.add(cell instanceof ByteBufferExtendedCell ?           ((ByteBufferExtendedCell) cell).deepClone(): cell);       } {code} According to the comment above, this is probably caused by HBASE-26036.  " Document JWT authentication in HBase book,13422634,Open,Major,,13/Jan/22 22:28,,,Add a chapter to the hbase book about JWT authentication and everything that users and admins need to know. Integrate user-experience for hbase-client,13422632,Reopened,Major,,13/Jan/22 22:22,,,"Today, we have two mechanism in order to get the tokens needed to authenticate: # Kerberos, we rely on a Kerberos ticket being present in a well-known location (defined by JVM properties) or via programmatic invocation of UserGroupInformation # Delegation tokens, we rely on special API to be called (our mapreduce API) which loads the token into the current UserGroupInformation ""context"" (the JAAS PrivilegedAction). The JWT bearer token approach is very similar to the delegation token mechanism, but HBase does not generate this JWT (as we do with delegation tokens). How does a client provide this token to the hbase-client (i.e. {{ConnectionFactory.getConnection()}} or a {{UserGroupInformation}} call)? We should be mindful of all of the different ""entrypoints"" to HBase ({{{}hbase ...{}}} commands, {{java -cp}} commands, Phoenix commands, Spark comands, etc). Our solution should be effective for all of these approaches and not require downstream changes. *Update* The environment variable approach is done, but I have a new idea which will support token renewal as well: Implement a generic JwtTokenProvider interface with a default file-based provider. Read the token from a specific file similar to what happens in Kerberos. Token renewal is not part of this ticket." Define user experience for JWT renewal,13422633,Open,Major,,13/Jan/22 22:27,,,"We need to define what our level of support will be for an HBase application which must run longer than the lifetime of a JWT token. The JWT 2.0 RFCs mention different kinds of tokens, notably a Refresh token may be helpful [https://datatracker.ietf.org/doc/html/rfc8693] This is inter-twined with HBASE-26667. For example, if we maintained a Refresh token in the client, we would have to build in logic (like we have for Kerberos credentials) to automatically launch a thread and know where to obtain a new JWT token from. *Idea* Once the JwtTokenProvider interface and file-based provider is ready, implement token renewal logic. Port FileWatcher class from the ZooKeeper project and watch for file changes." Add native TLS encryption support to RPC server/client,13422631,Resolved,Major,Fixed,13/Jan/22 22:17,06/Aug/22 23:53,2.4.12,"Today, HBase must complete the SASL handshake (saslClient.complete()) prior to turning on any RPC encryption (hbase.rpc.protection=privacy, sasl.QOP=auth-conf). This is a problem because we have to transmit the bearer token to the server before we can complete the sasl handshake. This would mean that we would insecurely transmit the bearer token (which is equivalent to any other password) which is a bad smell. Ideally, if we can solve this problem for the oauth bearer mechanism, we could also apply it to our delegation token interface for digest-md5 (which, I believe, suffers the same problem). The plan is to port Server/Client TLS implementation from the ZooKeeper project. It's a Netty based solution which looks like the best fit for NettyRpc client/server. " Add dynamic configuration support for system coprocessors,13432530,Resolved,Major,Fixed,08/Mar/22 01:13,25/Mar/22 00:14,3.0.0-alpha-3,"[Dynamic Configuraiton|https://hbase.apache.org/book.html#dyn_config] is very helpful that the operator can keep the JVM for regionserver or master running without restarting it. With this feature, this task aims to extend the scope of on demend configuration to system coprocessors including REGION, USER REGION, REGIONSERVER, MASTER such that we could save time on rolling restart with a quicker update. " "Backport ""HBASE-26810 Add dynamic configuration support for system coprocessors"" to branch-2",13435686,Resolved,Major,Fixed,25/Mar/22 00:11,23/Aug/22 12:06,2.4.12,Backport HBASE-26810 to streams of branch-2 Update Hadoop3 versions for JEP 223 compliance,13436648,Resolved,Major,Won't Fix,30/Mar/22 12:28,16/Aug/22 12:25,2.4.12,"It happened that my JDK version upgraded to 11.0.14.1. Running unit tests involving the HDFS mini cluster now fails with a stack trace that ends with {noformat} Caused by: java.lang.IllegalArgumentException: Invalid Java version 11.0.14.1 at org.eclipse.jetty.util.JavaVersion.parseJDK9(JavaVersion.java:71) at org.eclipse.jetty.util.JavaVersion.parse(JavaVersion.java:49) at org.eclipse.jetty.util.JavaVersion.(JavaVersion.java:43) {noformat} We are using hadoop-3.2.0, which uses jetty-9.3.24. This is a Jetty issue has been fixed upstream in Jetty via https://github.com/eclipse/jetty.project/issues/2090. Hadoop has upgraded its Jetty version to 9.4.20 in HADOOP-16152, which is available as of hadoop-3.2.2." TestProcedureSchedulerConcurrency fails in pre commit,13430851,Resolved,Major,Fixed,27/Feb/22 07:56,08/Aug/22 10:12,,"Saw this on the jenkins page. Seems like a test issue. {noformat} Exception in thread ""Thread-10"" java.util.ConcurrentModificationException at java.base/java.util.ArrayDeque.nonNullElementAt(ArrayDeque.java:271) at java.base/java.util.ArrayDeque$DeqIterator.next(ArrayDeque.java:701) at java.base/java.util.AbstractCollection.toString(AbstractCollection.java:472) at java.base/java.lang.String.valueOf(String.java:2951) at java.base/java.lang.StringBuilder.append(StringBuilder.java:168) at org.apache.hadoop.hbase.procedure2.ProcedureEvent.toString(ProcedureEvent.java:134) at java.base/java.lang.String.valueOf(String.java:2951) at java.base/java.lang.StringBuilder.append(StringBuilder.java:168) at org.apache.hadoop.hbase.procedure2.TestProcedureSchedulerConcurrency$2.run(TestProcedureSchedulerConcurrency.java:130) {noformat}" Introduce custom attributes to threads,13429968,Open,Major,,22/Feb/22 16:02,,,The idea is to introduce custom attributes to a thread. We will be passing this from thread to newly spawned thread. More details can be found here: https://docs.google.com/document/d/1b6CJt7_E8NU5fe41yeZZhuVPx-5SDx7x1jNtIRmnR_g/edit#heading=h.bv19tq8gxgcv Switch to use log4j2.properties file to configure log4j2,13425523,Resolved,Major,Fixed,29/Jan/22 03:46,02/Mar/22 13:18,,"After LOG4J2-3341, we could set the level and appender at once in properties file, so we do not need to split the ROOT_LOGGER config in the start up scripts any more." Introduce a little RAMBuffer for bucketcache to reduce gc and improve throughput,13423269,Resolved,Major,Fixed,18/Jan/22 12:05,02/Aug/22 08:28,,"In branch-1, BucketCache just allocate new onheap bytebuffer to construct new HFileBlock when get cached blocks. This rough allocation increases the GC pressure for those ""hot"" blocks. Here introduce a RAMBuffer for those ""hot"" blocks in BucketCache. The thought is simple. The RAMBuffer is an timeout expiring cache. When a Multi-level block is read twice, we cache it in the RAMBuffer. When the block timeout in the cache (e.g. 60s), that means the block is not being accessed in 60s, we evict it. Not like LRU, we do not cache block when the whole RAMBuffer size reaches to a threshold (to fit different workload, the threshold is dynamic). This will prevent the RAMBuffer from being churned. {panel:title=The performance of RAMBuffer with its hit ratio is 100%} !Hit 100%.png|height=250|width=250! {panel} I also did a YCSB performance test. The circumstance is: Size of BucketCache: 40 GB Target table size: 112 GB Properties: !Properties.png|height=250|width=250! The operation distribution of YCSB workload is latest. Client Side Metrics See the attachment ClientSideMetrics.png Server Side GC: The current bucket cache triggered 217 GCs, which costs 2.74 minutes in total. With RAMBuffer, the server side had 210 times GC and 2.56 minutes in total. As the master & branch-2 using ByteBufferAllocator to manage the bucketcache memory allocation, the RAMBuffer may not have GC improvement as much as branch-1. " Backport HBASE-26688 to branch-1,13424615,Resolved,Major,Fixed,25/Jan/22 08:15,02/Aug/22 08:26,1.7.1,Backport issue [HBASE-26688|https://issues.apache.org/jira/browse/HBASE-26688] to branch-1 to eliminate the client crash when using threads shared EMPTY_RESULT. Reimplement master local region initialization to better work with SFT,13420256,Resolved,Major,Fixed,02/Jan/22 07:55,24/Feb/22 03:16,,"It is not like a normal region where we have a TableDescriptor so it can store the SFT implementation of its own. In the current implementation, if we change the global SFT configuration, the SFT implementation of the master local reigon will be changed and cause data loss. First I think we could hard coded it to use DefaultSFT. The region is small and will not cause too much performance impact. Then we could find a way to manage the SFT implementation of it. ====== Update ====== The initialization of master local region depends on renaming, which can not work well on OSS. So we should also change it. The basic idea is to touch a '.initialized' file to indicate it is initialized. Need to consider how to migrate from the existing master local region where it does not have this file. And we could also store the TableDescriptor on file system, so we can determine whether this is a SFT change. If so, we should do the migration before actually opening the master local region." RegionServer JVM crash when compact mob table,13433308,Open,Major,,11/Mar/22 08:32,,,"When compact a mob table, RS JVM may crash or failed to do compaction as the following logs: {code:java} 2022-03-11T16:18:44,089 ERROR [RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=45525-shortCompactions-0] regionserver.CompactSplit$CompactionRunner(675): Compaction failed Request=regionName=t1,,1646986716811.964618e679a2434aa7d27018baef8154., storeName=A, fileCount=2, fileSize=2.0 M (1010.2 K, 1010.2 K), priority=1, time=1646986723135java.io.IOException: Mob compaction failed for region: 964618e679a2434aa7d27018baef8154 at org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.performCompaction(DefaultMobStoreCompactor.java:574) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:365) ~[classes/:?] at org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.compact(DefaultMobStoreCompactor.java:225) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1141) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2442) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:656) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:702) ~[classes/:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_292] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_292] at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_292]Caused by: java.io.IOException: Added a key not lexically larger than previous. Current cell = org.apache.hadoop.hbase.PrivateCellUtil$ValueAndTagRewriteByteBufferExtendedCell@565d5bac, prevCell = user00000000000000000000/A:filed01/1646986721047/Put/vlen=0/mvcc=0 at org.apache.hadoop.hbase.util.BloomContext.sanityCheck(BloomContext.java:63) ~[classes/:?] at org.apache.hadoop.hbase.util.BloomContext.writeBloom(BloomContext.java:54) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.appendGeneralBloomfilter(StoreFileWriter.java:296) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.append(StoreFileWriter.java:315) ~[classes/:?] at org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.performCompaction(DefaultMobStoreCompactor.java:464) ~[classes/:?] ... 10 more {code} It is the same problem as [HBASE-25929|https://issues.apache.org/jira/browse/HBASE-25929], because DefaultMobStoreCompactor overwrite performCompaction method of DefaultCompactor." BufferedDataBlockEncoder.OnheapDecodedCell value can get corrupted,13434272,Reopened,Major,,17/Mar/22 06:12,,,"In our production cluster we observed the cell value is modified after successful scanner read. After analyzing we observed OnheapDecodedCell is not created properly. We create OnheapDecodedCell with complete valAndTagsBuffer underlying array. {code:java} return new OnheapDecodedCell(Bytes.copy(keyBuffer, 0, this.keyLength), currentKey.getRowLength(), currentKey.getFamilyOffset(), currentKey.getFamilyLength(), currentKey.getQualifierOffset(), currentKey.getQualifierLength(), currentKey.getTimestamp(), currentKey.getTypeByte(), valAndTagsBuffer.array(), valAndTagsBuffer.arrayOffset() + vOffset, this.valueLength, memstoreTS, tagsArray, tOffset, this.tagsLength); {code} Here we are passing valAndTagsBuffer.array() for value extraction. The underlying array will be modified if it is altered anywhere. " Allow builders of hbase to specify hadoop inclusion mode for hbase-shaded-client,13436943,Resolved,Major,Won't Fix,31/Mar/22 15:57,22/Jun/22 23:36,,"HBASE-20333 added a new shaded artifact, hbase-shaded-client-byo-hadoop. This is useful in environments where they already depend on hadoop so pulling in the hadoop classes from hbase-shaded-client would be extreme. I think the split that [~busbey] decided on there definitely made sense for the general case (with byo-hadoop being the specially named artifact). But some of us may work in environments where the default case is the byo-hadoop case. For those environments, it's a little confusing and verbose to have to refer to the hbase client as hbase-shaded-client-byo-hadoop everywhere. For example, we have well over 500 poms directly pulling in hbase client and many more pulling it in transitively. We'll want to use byo-hadoop everywhere in our environment, but that's an implementation detail that the teams owning those 500 poms don't need to know or care about. Using profiles I think we could provide an optional activation which allows someone building their own hbase to decide whether hbase-shaded-client should include hadoop or not. This way normal users using the artifacts published to maven central are unaffected, but super users building their own have some extra flexibility." hbase-shaded-mapreduce and hbase-shaded-client expose some of the same classes,13436733,Resolved,Major,Won't Fix,30/Mar/22 18:23,22/Jun/22 23:35,,"We supply 2 primary artifacts for end-users to consume: * hbase-shaded-client, which is for general use * hbase-shaded-mapreduce, which is for use when you need to connect to hbase via mapreduce. For example, TableInputFormat The problem is that these artifacts expose tons of duplicate classes. One example (among many) is org.apache.hadoop.hbase.Cell, which appears in both jars. This may not be a problem if your projects are always very isolated – either doing mapreduce, or not. In that case you just depend in the one you need. Many users might exist in much more complicated environments where dependencies tend to bleed along more between projects. Here's an illustration: * Imagine a project FooService, which includes two modules FooServiceRestWeb (for the rest http resources) and FooServiceData (which includes DAOs for accessing data). FooServiceRestWeb depends on FooServiceData to access hbase.  In this case, FooServiceData should depend on hbase-shaded-client. * Now imagine another project FooPipeline, which has modules FooPipelineHadoop (with M/R jobs for processing data) and FooPipelineData (which has some DAOs for accessing data). In this case, FooPipelineData might depend on hbase-shaded-mapreduce since the context is intended for M/R. * The problem arises when suddenly we want to include some data from FooService into our pipeline. The most straightforward way to achieve this is by depending on FooServiceData,  which has all of he DAOs for that data but also depends on hbase-shaded-client. At this point you have a problem, because FooPipelineHadoop now depends on both hbase-shaded-mapreduce and hbase-shaded-client. (Note, this obviously skirts around potential microservice solutions like only accessing FooService's data through the API... it's just for illustration, and it does come up.) From a plain java perspective, having these 2 jars on the classpath is somewhat wasteful but not a huge issue since the implementations are all the same. From a maven perspective, it's problematic because the maven dependency plugin will complain about the conflicting classes. One potential fix is to add exclusions to the FooServiceData dependency, to avoid pulling in hbase-shaded-client. This works on a one-off basis but is much more painful in a large and complicated environment where this may come up hundreds of times. A better fix in my opinion is to make hbase-shaded-mapreduce depend on hbase-shaded-client and then only expose the classes that aren't already exposed by the shaded client. [~busbey] also mentioned a BOM being a potential solution, but I don't have experience with that.  " [hbase-thirdparty] Upgrade jackson to 2.13.3,13436052,Resolved,Major,Fixed,28/Mar/22 00:19,17/Jun/22 14:59,,https://github.com/FasterXML/jackson-databind/issues/2816 Find unavailable regions by the startcode checking on hmaster start up and reassign them,13435761,Open,Major,,25/Mar/22 09:23,,,"Sometimes we have seen there are regions in open or opening state, but does not deployed on any rs and without procs for them, and after  checking the meta table, we find these startcode are expired.  It is no easy to reproduce, may be caused by corner bug or user misoperation. My approach is add some checking on hmaster start up, if the startcode of the regionLocation expired, and neither TRSP on region nor SCP on regionserver, then we should reassign the region, then we can resovle it easily just by restart hmaster.  Hbck2 maybe also useful for some of them cases, but not easily for common user to use, especially the number of these regions not small and need to be recovery quickly." "Backport StoreFileTracker (HBASE-26067, HBASE-26584, and others) to branch-2.5",13433214,Resolved,Major,Fixed,10/Mar/22 21:09,05/Jun/22 20:22,,"In a discussion on dev@ the idea was floated that StoreFileTracker could be backported into branch-2.5 to be released as part of 2.5.0 as an experimental feature. This issue considers the backport. There are sixteen subtasks on HBASE-26067 and several other tangential commits. Cherry pick the list in sequence, fixing up as necessary. These appear to be the core commits: - commit 6aaef8978 HBASE-26064 Introduce a StoreFileTracker to abstract the store file tracking logic - commit 43b40e937 HBASE-25988 Store the store file list by a file (#3578) - commit 6e053765e HBASE-26079 Use StoreFileTracker when splitting and merging (#3617) - commit 090b2fecf HBASE-26224 Introduce a MigrationStoreFileTracker to support migrating from different store file tracker implementations (#3656) - commit 0ee168933 HBASE-26246 Persist the StoreFileTracker configurations to TableDescriptor when creating table (#3666) - commit 2052e80e5 HBASE-26248 Should find a suitable way to let users specify the store file tracker implementation (#3665) - commit 5ff0f98a5 HBASE-26264 Add more checks to prevent misconfiguration on store file tracker (#3681) - commit fc4f6d10e HBASE-26280 Use store file tracker when snapshoting (#3685) - commit 06db852aa HBASE-26326 CreateTableProcedure fails when FileBasedStoreFileTracker… (#3721) - commit e4e7cf80b HBASE-26386 Refactor StoreFileTracker implementations to expose the set method (#3774) - commit 08d117197 HBASE-26328 Clone snapshot doesn't load reference files into FILE SFT impl (#3749) - commit 8bec26ea9 HBASE-26263 [Rolling Upgrading] Persist the StoreFileTracker configurations to TableDescriptor for existing tables (#3700) - commit a288365f9 HBASE-26271 Cleanup the broken store files under data directory (#3786) - commit d00b5faad HBASE-26454 CreateTableProcedure still relies on temp dir and renames… (#3845) - commit 771e552cf HBASE-26286: Add support for specifying store file tracker when restoring or cloning snapshot - commit f16b7b1bf HBASE-26265 Update ref guide to mention the new store file tracker im… (#3942) And from HBASE-26584 and beyond: - commit 755b3b4cb HBASE-26585 Add SFT configuration to META table descriptor when creating META (#3998) - commit 39c42c7dc HBASE-26639 The implementation of TestMergesSplitsAddToTracker is problematic (#4010) - commit 6e1f5b7fe HBASE-26586 Should not rely on the global config when setting SFT implementation for a table while upgrading (#4006) - commit f1dd865c3 HBASE-26654 ModifyTableDescriptorProcedure shoud load TableDescriptor while executing (#4034) - commit 8fbc9a260 HBASE-26674 Should modify filesCompacting under storeWriteLock (#4040) - commit 5aa0fd265 HBASE-26675 Data race on Compactor.writer (#4035) - commit 3021c5851 HBASE-26700 The way we bypass broken track file is not enough in StoreFileListFile (#4055) - commit a8b68c9b8 HBASE-26690 Modify FSTableDescriptors to not rely on renaming when writing TableDescriptor (#4054) - commit dffeb8e63 HBASE-26587 Introduce a new Admin API to change SFT implementation (#4030) (#4080) - commit b265fe55b HBASE-26673 Implement a shell command for change SFT implementation (#4113) - commit 4cdb380cc HBASE-26640 Reimplement master local region initialization to better work with SFT (#4111) - commit 77bb153a2 HBASE-26707: Reduce number of renames during bulkload (#4066) (#4122) - commit a4b192e33 HBASE-26611 Changing SFT implementation on disabled table is dangerous (#4082) - commit d3629bbf1 HBASE-26837 Set SFT config when creating TableDescriptor in TestCloneSnapshotProcedure (#4226) " Support meta replica LoadBalance mode for RegionLocator#getAllRegionLocations(),13421172,Resolved,Major,Fixed,06/Jan/22 21:56,03/Jun/22 22:45,2.4.9,"When HBase application restarts, its meta cache is empty. Normally, it will fill the meta cache one region at a time by scanning the meta region. This will cause huge pressure to the region server hosting meta during application restart.  It can prefetching all region locations by calling RegionLocator#getAllRegionLocations().Meta replica LoadBalance mode is support in 2.4, it will be nice to load balance RegionLocator#getAllRegionLocations() to all meta replica regions so batch scan can spread across all meta replica regions." Shell startup logs a bunch of noise,13434163,Resolved,Major,Fixed,16/Mar/22 16:22,27/May/22 21:02,2.5.0,I noticed a behavior on branch-2.5 that is not present on master or branch-2: starting up the shell produces a bunch of extra zookeeper logging. The classes are {{zookeeper.ZooKeeper}} and {{zookeeper.ClientCnxn}}. Should always set SFT implementation when cloning snapshot,13433670,Open,Major,,14/Mar/22 15:15,,,"Saw the TestCloneSnapshotProcedureFileBasedSFT failing several times {noformat} 2022-03-14T11:23:13,782 INFO [PEWorker-1] procedure2.ProcedureExecutor(1432): Finished pid=99, state=SUCCESS, hasLock=false; CloneSnapshotProcedure (table=testRecoverWithRestoreAclFlag snapshot=name: ""snapshot-1647256973399"" table: ""testCloneSnapshot"" creation_time: 1647256982366 type: FLUSH version: 2 owner: """" ttl: 0 max_file_size: 0 ) in 6.9090 sec 2022-03-14T11:23:13,794 WARN [PEWorker-1] procedure2.ProcedureExecutor$Testing(127): Toggle KILL before store update to: false 2022-03-14T11:23:13,794 DEBUG [PEWorker-1] procedure2.ProcedureExecutor(1777): TESTING: Kill BEFORE store update: pid=112, state=RUNNABLE:MODIFY_TABLE_DESCRIPTOR_UPDATE, hasLock=true; InitializeStoreFileTrackerProcedure table=testRecoverWithRestoreAclFlag 2022-03-14T11:23:13,794 INFO [PEWorker-1] procedure2.ProcedureExecutor(635): Stopping 2022-03-14T11:23:13,795 WARN [PEWorker-1] procedure2.ProcedureExecutor$WorkerThread(1997): Worker terminating UNNATURALLY null java.lang.RuntimeException: TESTING: Kill BEFORE store update: pid=112, state=RUNNABLE:MODIFY_TABLE_DESCRIPTOR_UPDATE, hasLock=true; InitializeStoreFileTrackerProcedure table=testRecoverWithRestoreAclFlag at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.kill(ProcedureExecutor.java:1779) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1723) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981) ~[classes/:?] 2022-03-14T11:23:14,012 WARN [Time-limited test] procedure2.ProcedureTestingUtility(193): Set Kill before store update to: false {noformat} The CloneSnapshotProcedure is finished but then we get a InitializeStoreFileTrackerProcedure which messes up the test. The InitializeStoreFileTrackerProcedure will be scheduled when rolling upgrade, where we do not have SFT set for a table. So typically it should not be schedule. Not sure how this could happen in the UT, need to dig more. But anyway, when we clone a snapshot which was taken before we have SFT, it is possible the TableDescriptor does not have SFT implementation set, so we should set one for it." Delete unnecessary dependency on jaxb-runtime jar,13434168,Resolved,Major,Fixed,16/Mar/22 16:38,18/May/22 23:30,,"Since we've moved to using only shaded versions of our jersey stuff, we have no need for this explicit dependency." ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists,13436492,Resolved,Major,Fixed,29/Mar/22 17:49,14/May/22 01:29,,"ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists. Currently it throws generic DoNotRetryIOException. {code:java} private ReplicationPeerDescription checkPeerExists(String peerId) throws DoNotRetryIOException { ReplicationPeerDescription desc = peers.get(peerId); if (desc == null) { throw new DoNotRetryIOException(""Replication peer "" + peerId + "" does not exist""); } return desc; } {code}" Add spotless:check in our pre commit general check,13436023,Resolved,Major,Fixed,27/Mar/22 15:12,03/May/22 14:09,,To force the style. Improve fidelity of RegionLocator spans,13421139,Resolved,Major,Fixed,06/Jan/22 18:20,03/May/22 11:50,,"While backporting HBASE-26474 to branch-2, I realized that the nuance of tracing of region locator calls is lacking. In the current implementation, all calls to the region locator produce {{SpanKind.CLIENT}} spans. This is correct only for the code path where the client reaches out to a remote host to populate cache locations. This doesn't happen every time. Instead, the top-level span should be {{SpanKind.INTERNAL}} and only when a region location must be requested remotely should we create a child span with {{SpanKind.CLIENT}}." Proto files in hbase-protocol and hbase-shaded-protocol are out of sync,13426293,Resolved,Major,Won't Fix,02/Feb/22 23:45,03/May/22 00:24,2.5.0,"Are we reserving hbase-protocol at a point in time and only doing new development in hbase-shaded-protocol? This is probably the case but I'm not seeing documentation anywhere about it. At the very least, if so, every file in hbase-protocol should carry a very prominent comment that it is a point in time snapshot and not receiving new development. If these files are supposed to be in sync, they are not. Noticed divergence in ClusterStatus.proto on branch-2. There's almost certainly more elsewhere. " splitRegion and mergeRegion admin RPCs are in hbase-protocol but not hbase-shaded-protocol,13432936,Resolved,Major,Won't Fix,09/Mar/22 18:53,03/May/22 00:24,,"On parent issue [~gjacoby] indicates that splitRegion and mergeRegion admin RPCs are in hbase-protocol but not hbase-shaded-protocol. It would seem functionally it is not a serious break, but is a compatibility concern. " "Backport ""HBASE-25681 Add a switch for server/table queryMeter"" to branch-2.4",13434432,Resolved,Major,Fixed,17/Mar/22 18:58,30/Apr/22 01:58,,"https://issues.apache.org/jira/browse/HBASE-25687 backported this config to branch-2, but that didn't include 2.4 because it was already released by then. This backports to branch-2.4, because I think the config is valuable. I find in performance testing that the per-table metrics specifically here can have a non-trivial impact on throughput." Avoid unnecessary replication suspending in RegionReplicationSink,13430217,Resolved,Major,Fixed,23/Feb/22 13:17,10/Mar/22 03:01,3.0.0-alpha-2,"It seems that the problem HBASE-26449 described still exists in following {{RegionReplicationSink.onComplete}},which is running in Netty's nioEventLoop. Assuming we have only one secondary replica, first we add the replica to the {{failed}} because a failure of replicating in following line 228, but before we enter the line 238, the flusher thread calls {{RegionReplicationSink.add}} and we clear the {{RegionReplicationSink.failedReplicas}} due to a flush all edit. When the Netty nioEventLoop continues to enter line 238, we still add a replica to the failedReplicas even though the {{maxSequenceId < lastFlushedSequenceId}}. {code:java} 207 private void onComplete(List sent, 208 Map> replica2Error) { .... 217 Set failed = new HashSet<>(); 218 for (Map.Entry> entry : replica2Error.entrySet()) { 219 Integer replicaId = entry.getKey(); 220 Throwable error = entry.getValue().getValue(); 221 if (error != null) { 222 if (maxSequenceId > lastFlushedSequenceId) { ... 228 failed.add(replicaId); 229 } else { ...... 238 synchronized (entries) { 239 pendingSize -= toReleaseSize; 240 if (!failed.isEmpty()) { 241 failedReplicas.addAll(failed); 242 flushRequester.requestFlush(maxSequenceId); 243 } ...... 253 } 254 } {code} What is worse, when we invoke {{RegionReplicationFlushRequester.requestFlush}}, the flushing may be skipped because in following {{RegionReplicationFlushRequester.flush}}, {{pendingFlushRequestSequenceId}} is less than {{lastFlushedSequenceId}}, so the only secondary replica is marked failed and requested flushing is skipped, the replication may suspend until next memstore flush : {code:java} private synchronized void flush(Timeout timeout) { pendingFlushRequest = null; if (pendingFlushRequestSequenceId >= lastFlushedSequenceId) { request(); } } {code} I simulate this problem in the PR and my fix is double check the {{if (maxSequenceId > lastFlushedSequenceId)}} in the {{synchronized}} block in {{RegionReplicationSink.onComplete}}. " TestBasicWALEntryStreamFSHLog testSizeOfLogQueue is flaky,13433212,Resolved,Major,Cannot Reproduce,10/Mar/22 20:19,30/Apr/22 01:53,2.4.10,"[ERROR] org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStreamAsyncFSWAL.testSizeOfLogQueue Time elapsed: 0.056 s <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<2> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testSizeOfLogQueue(TestBasicWALEntryStream.java:701) " Traces of async chains result in arbitrarily deep trace stack,13425497,Resolved,Major,Cannot Reproduce,28/Jan/22 23:09,28/Apr/22 12:21,3.0.0-alpha-2,"Trying out the latest {{master}} on a real cluster, traces of async operations do not report the way I expect. Actions that are sequential (for example, locate meta then locate region) do not render as trace peers. Instead the subsequent action is a child of the previous. I believe this means that we are not handling parent span context propagation in async callback chains. I've not yet tried branch-2 to see if it's applicable there as well." Unify CallQueueTooBigException special pause with CallDroppedException,13432442,Resolved,Major,Fixed,07/Mar/22 14:14,25/Apr/22 17:28,,"CallQueueTooBigException and CallDroppedException crop up in very similar circumstances – the former is thrown if the request cannot be enqueued because the queue is full; the latter is thrown when a call is dropped from the queue to make room for another call. HBASE-17114 added a special pause feature, which allows pausing for a longer period of time when CallQueueTooBigException is encountered, vs the normal pause for other exceptions. The idea here is to help reduce load so the server can process its queue. We should extend this feature to encompass CallDroppedException for the same reason. Currently the config is called ""hbase.client.pause.cqtbe"". We should probably deprecate that in favor of a more generic name." Remove duplicate dependency declaration,13436637,Resolved,Major,Fixed,30/Mar/22 11:47,19/Apr/22 14:08,2.5.0,"On branch-2 derivatives, I noticed on PR builds of JDK11+Hadoop3 that running tests with {{-pl}} results in a warning from maven {noformat} [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.hbase:hbase-build-configuration:pom:2.6.0-SNAPSHOT [WARNING] 'profiles.profile[hadoop-3.0].dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.hadoop:hadoop-mapreduce-client-app:test-jar -> duplica te declaration of version ${hadoop-three.version} @ org.apache.hbase:hbase:2.6.0-SNAPSHOT, /Users/ndimiduk/repos/apache/hbase/pom.xml, line 3816, column 23 [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.hbase:hbase:pom:2.6.0-SNAPSHOT [WARNING] 'profiles.profile[hadoop-3.0].dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.hadoop:hadoop-mapreduce-client-app:test-jar -> duplica te declaration of version ${hadoop-three.version} @ line 3816, column 23 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] {noformat} I _think_ they're harmless, but we should clean them up." "on hbase shell, 'delete/deleteall' for a columnfamily is not working",13436129,Resolved,Major,Fixed,28/Mar/22 10:23,12/Apr/22 13:04,2.4.11,"on hbase shell, 'delete' or 'deleteall' for the whole columnFamily is not working properly.   {code:java} hbase(main):026:0* put 'test', 'r1', 'f:1', 'a' Took 0.0233 seconds hbase(main):029:0> delete 'test', 'r1', 'f' Took 0.0070 seconds hbase(main):030:0> get 'test', 'r1' COLUMN                                                                  CELL  f:1                                                                    timestamp=1648114865022, value=a 1 row(s) hbase(main):038:0> deleteall 'test', 'r1', 'f' Took 0.0059 seconds hbase(main):039:0> get 'test', 'r1' COLUMN                                                                  CELL  f:1                                                                    timestamp=1648114865022, value=a 1 row(s) {code}   looking inside of hbase-shell, all delete/deleteall on hbase shell are converted to delete.addColumn/addColumns. thus, delete/deleteall request without columnQualifier converted to 'null' qualifier deletion. (since HBASE-15616, null columnQualifier is possible)   {code:java}         if column && all_version           family, qualifier = parse_column_name(column)           d.addColumns(family, qualifier, timestamp)         elsif column && !all_version           family, qualifier = parse_column_name(column)           d.addColumn(family, qualifier, timestamp)         end {code}   According to the description of help 'deleteall' and HBASE-9549  ""Users of the shell, MapReduce, REST, and Thrift who wish to interact with an *entire column family must use ""family""* instead of ""family:"" (notice the omitted ':'). Including the ':' will be interpreted as an interaction with the empty qualifier in the ""family"" column family.""   a column expression without ':' means whole family. so in these cases, it's deletion request for the columnFamily, and we should use addFamily/addFamilyVersion instead of addColumn/addColumns for deletion.      " delete with null columnQualifier occurs NullPointerException when NewVersionBehavior is on,13436442,Resolved,Major,Fixed,29/Mar/22 13:39,12/Apr/22 12:45,2.4.11,"since  HBASE-15616, setting column qualifier as null is possible. but when NewVersionBehavior is on, delete with null columnQualifier occurs NullPointerException.   {code:java} @Test public void testNullColumnQualifier() throws IOException { try (Table t = createTable()) { Delete del = new Delete(ROW); del.addColumn(FAMILY, null); t.delete(del); Result r = t.get(new Get(ROW)); //NPE happens. assertTrue(r.isEmpty()); } } {code} {code:java} //output Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.regionserver.querymatcher.NewVersionBehaviorTracker.add(NewVersionBehaviorTracker.java:214) at org.apache.hadoop.hbase.regionserver.querymatcher.NormalUserScanQueryMatcher.match(NormalUserScanQueryMatcher.java:73) at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:627) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:157) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6672) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6836) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6606) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:6583) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:6570) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2645) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2571) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42274) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:418) ... 3 more {code}  " Set java.io.tmpdir on mvn command when running jenkins job,13433894,Resolved,Major,Fixed,15/Mar/22 14:50,17/Mar/22 08:50,,"Recently on hbase1-10, it is easy to eat all the space of /tmp. I've checked several times, it is always the stderr*deferred file, which is the temp output of our UTs. I think it means we have some problem for some of our UTs which could generate very big output, but if the tmp is full, it is not easy for us to find out the root cause as we need to delete the file to recover first... Looking at the code of surefire https://github.com/apache/maven-surefire/blob/68bca29b23d27dba3e06cf5e73a3fdc1a22598db/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/Utf8RecodingDeferredFileOutputStream.java#L69 It just creates the file with jdk's Files.createTempFile, the location can be controlled by java.io.tmpdir, so let's point it to the target directory under the jenkins workspace to avoid wat all the spaces of /tmp first." Refactor TestMasterRegionOnTwoFileSystems to avoid dead loop,13434372,Resolved,Major,Fixed,17/Mar/22 13:24,18/Mar/22 16:50,,See the posts on HBASE-26848. Remove warnings from meta replicas feature references in the HBase book,13436661,Resolved,Major,Fixed,30/Mar/22 13:29,31/Mar/22 21:12,,"Meta replicas is a new feature in HBase 2.4 and mentioned in ""Use with caution"" in the docs. Given that the feature and the related ""async wal replication for meta"" is actively used in production already, I'd like to remove these warnings from the docs. With this change, users will have more confidence in the feature." Spotless formatting can leave line-ending whitespace that violates whitespace check in PR,13437034,Open,Major,,31/Mar/22 17:45,,,It looks like this happens for blank lines in javadoc. Use new hbase-thirdparty and jackson 2.13.2.1 due to CVE-2020-36518,13436053,Open,Major,,28/Mar/22 00:21,,,https://github.com/FasterXML/jackson-databind/issues/2816 Adapt ConnectionRule for both sync and async connections,13433645,Resolved,Major,Fixed,14/Mar/22 12:23,21/Mar/22 17:28,2.4.11,"Backporting recent tracing work to branch-2 has presented some difficulties using the {{ConnectionRule}}. The issue comes down to {{AsyncConnection}} on master provides a {{toConnection}} method, which is not available on branch-2. Start with a branch-2 implementation and then forward-port the API changes to master." Minor refactor of async scanning code,13429755,Resolved,Major,Fixed,21/Feb/22 16:28,24/Feb/22 18:12,,Some small changes to internal/private classes implementing async scan will make the code easier to read and reason about. Implement generic exception support for TraceUtil methods over Callables and Runnables,13429754,Resolved,Major,Fixed,21/Feb/22 16:26,07/Mar/22 12:58,,{{TraceUtil.trace}} methods can be consolidated with some generics. Fix trace continuity through CallRunner,13428868,Resolved,Major,Fixed,16/Feb/22 16:15,05/Mar/22 00:03,,We appear to be generating spans with without a parent context with the name {{RegionScanner.close}}. Track this down. list_quota_snapshots fails with ‘ERROR NameError: uninitialized constant Shell::Commands::ListQuotaSnapshots::TABLE’,13436154,Resolved,Major,Fixed,28/Mar/22 12:36,28/Mar/22 19:36,2.4.11,"The list_quota_snapshots command fails with  {noformat} ERROR NameError: uninitialized constant Shell::Commands::ListQuotaSnapshots::TABLE{noformat} regardless of the parameters it's called with. Apparently, it used to work in HBase 2.2. I don't know enough about Ruby to tell why it used to work, and what broke this exactly,  but using qualified constants fixes the problem." HFileArchiver can remove referenced StoreFiles from the archive,13425289,Resolved,Major,Fixed,28/Jan/22 00:46,28/Mar/22 18:58,0.95.0,"There is a comment in {{HFileArchiver#resolveAndArchiveFile}}: {code:java} // if the file already exists in the archive, move that one to a timestamped backup. This is a // really, really unlikely situtation, where we get the same name for the existing file, but // is included just for that 1 in trillion chance. {code} In reality, we did encounter this frequently enough to cause problems. More details will be included and linked in a separate issue. But regardless of how we get into this situation, we can consider a different approach to solving it. If we assume store files are immutable, and a store file with the same name and location already exists in the archive, then it can be safer to assume the file was already archived successfully, and react accordingly." Load rate calculator for cost functions should be more precise,13434782,Resolved,Major,Fixed,21/Mar/22 02:33,28/Mar/22 15:40,2.4.11,"The rate calculator should avoid negative values, e.g. if a region is moved from RS1 to RS2, the request count loads in the balancer cache maybe [100,200,0,100,200], then the region load cost calculated by CostFromRegionLoadAsRateFunction#getRegionLoadCost will be (100-200+100+100)/4=25, while the real cost is (100+0+100+200)/4=100.  {code:java} protected double getRegionLoadCost(Collection regionLoadList) { Iterator iter = regionLoadList.iterator(); if (!iter.hasNext()) { return 0; } double previous = getCostFromRl(iter.next()); if (!iter.hasNext()) { return 0; } double cost = 0; do { double current = getCostFromRl(iter.next()); cost += current - previous; previous = current; } while (iter.hasNext()); return Math.max(0, cost / (regionLoadList.size() - 1)); } {code} We should change the cost accumulate codes to, {code:java} cost += current >= previous ? current - previous : current; {code}" Pooled and reuse scanner lease,13436395,Open,Major,,29/Mar/22 10:41,,2.4.11,"We can make the scanner lease be pooled and reuse them to reduce the GC pressure, e.g. when there are large concurrent scans for the meta table, many new leases can be avoid to create." Crash Meta-RS and active HMaster successively make cluster out of service,13436186,Open,Major,,28/Mar/22 14:32,,2.4.8,"We got a cluster of 2 master nodes (hm1, hm2) and 3 slaves nodes (rs1, rs2, rs3)   # hm1 becomes active # rs3 becomes the meta RS # rs3 crashes # hm1 crashes. At this time, the meta-region-server in ZooKeeper is still rs3 # hm2 becomes active, but stucks in ""master.HMaster: hbase:meta,,1.1588230740 is NOT online; state=\{1588230740 state=OPEN, ts=1648007404659, server=rs3,16020,1648007272771}; ServerCrashProcedures=true. Master startup cannot progress, in holding-pattern until region onlined.""" Implement a shell command for change SFT implementation,13422764,Resolved,Major,Fixed,14/Jan/22 15:44,19/Feb/22 17:02,, Crash HM and META-RS when truncating table causes data loss,13435705,Open,Major,,25/Mar/22 03:18,,2.4.8,"I have a hbae cluster of 2 master nodes (C1HM1:172.0.0.2 and C1HM2:172.0.0.3) and 3 slave nodes (C1RS1:172.0.0.4, C1RS2:172.0.0.5, C1RS3:172.0.0.6). The following is the bug triggering process ({color:#de350b}red {color}for crash and exception events; {color:#00875a}green {color}for events in hbase nodes): * the active master is C1HM1, the meta server is C1RS2 * client requests to create a table ""FAVMyInfo"" * {color:#de350b}2022-03-24 01:44:54,317 [MyTest] - INFO - Going to crash node 172.25.0.5（table ""FAVMyInfo"" exists in the ZooKeeper at this time）{color} * {color:#00875a}C1HM1 assigns meta regions to C1RS3{color} * client receives ACK about creating table ""FAVMyInfo"", and then makes some changes to ""FAVMyInfo"" * 2022-03-24 01:46:20,664 [MyTest] - INFO - Client has disabled table ""FAVMyInfo"" and requests to truncate ""FAVMyInfo"" * {color:#00875a}C1HM1 first deleted table ""FAVMyInfo"", and then create a new ""FAVMyInfo"" region;{color} * {color:#de350b}2022-03-24 01:46:23,302 [MyTest] - INFO - Going to crash node 172.25.0.2 (at this time, table ""FAVMyInfo"" does not exist in the ZooKeeper). The node C1HM1 was killed before:{color} {code:java} org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$BlockingStub.mutate(ClientProtos.java), org.apache.hadoop.hbase.client.ClientServiceCallable.doMutate(ClientServiceCallable.java:55), org.apache.hadoop.hbase.client.HTable$3.rpcCall(HTable.java:534), org.apache.hadoop.hbase.client.HTable$3.rpcCall(HTable.java:529), org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127), org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:108), org.apache.hadoop.hbase.client.HTable.put(HTable.java:538), org.apache.hadoop.hbase.MetaTableAccessor.put(MetaTableAccessor.java:1365), org.apache.hadoop.hbase.MetaTableAccessor.putToMetaTable(MetaTableAccessor.java:1355), org.apache.hadoop.hbase.MetaTableAccessor.updateTableState(MetaTableAccessor.java:1657), org.apache.hadoop.hbase.MetaTableAccessor.updateTableState(MetaTableAccessor.java:1169), org.apache.hadoop.hbase.master.TableStateManager.updateMetaState(TableStateManager.java:174), org.apache.hadoop.hbase.master.TableStateManager.setTableState(TableStateManager.java:84), org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.setEnablingState(CreateTableProcedure.java:376), org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:140), org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:45), org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:191), org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:956), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1665), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1412), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78), org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1979), org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java) {code} * {color:#de350b}2022-03-24 01:46:46,023 [MyTest] - INFO - Going to crash node 172.25.0.6. The node C1RS3 was killed before:{color} {code:java} org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java), org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45253), org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:392), org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133), org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:354), org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:334), org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java)]{code} * {color:#00875a}C1HM2 takes over the cluster, and unexpectedly deleted table FAVMyInfo{color} * 2022-03-24 01:48:13,497 [MyTest] - INFO - client receives response for truncating ""FAVMyInfo"", no Exceptions here. Then client requests to get a row from ""FAVMyInfo"", but gets {color:#ff0000}""TableNotFoundException: FAVMyInfo""{color}" nightly yetus tests don't reflect failure when required environment variables are missing.,13435938,Open,Major,,26/Mar/22 07:17,,,"the nightly yetus wrapper shows an error when we're missing some needed environment variables, but the stage shows success still. e.g {code:java} [2022-03-24T22:35:39.450Z] [ERROR] Required environment variable 'DEBUG' is not set. [2022-03-24T22:35:39.451Z] [ERROR] Required environment variable 'USE_YETUS_PRERELEASE' is not set. [2022-03-24T22:35:39.451Z] [ERROR] Please set the required environment variables before invoking. If this error is on Jenkins, then please file a JIRA about the error. {code}" Update branch-specific nightly test handling to allow for earlier release line feature branches,13435936,Open,Major,,26/Mar/22 07:09,,,"due to limitations in ASF infra our branch protection rules prohibit force pushes or deletions on branches that start with ""master"" or ""branch-"". Our current nightly tests assume that feature branches specific to branch-2 or branch-1 will start with the release branch name rather than the feature Jira key. However, doing so would mean we need to file INFRA jiras to clean up afterwards.   We can't change the limitations of branch protection rules, so we should update the nightly tests to allow for feature branches named like {{{}HBASE-XXXXX-branch-2{}}}." nightly integration test claims success while showing error parsing shell output,13435935,Open,Major,,26/Mar/22 06:59,,,"current master branch claims that the integration test is succeeding, but looking at the detailed output shows a failure to parse the shell output:   {code:java} Starting up Hadoop waiting for Hadoop to finish starting up. waiting for Hadoop to finish starting up. waiting for Hadoop to finish starting up. waiting for Hadoop to finish starting up. Verifying configs WARNING: log4j.properties is not found. HADOOP_CONF_DIR may be incomplete. /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/output-integration/hadoop-3/hbase-conf/core-site.xml: valid /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/output-integration/hadoop-3/hbase-conf/hbase-site.xml: valid OK Listing HDFS contents Starting up HBase running master, logging to /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase12.out retry waiting for hbase to come up. Setting up table 'test:example' with 1,000 regions writing out example TSV to example.tsv uploading example.tsv to HDFS WARNING: log4j.properties is not found. HADOOP_CONF_DIR may be incomplete. WARNING: log4j.properties is not found. HADOOP_CONF_DIR may be incomplete. Importing TSV via shaded client artifact for HBase - MapReduce integration. Verifying row count from import. /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh: line 418: [: hbase:002:0> : integer expression expected Hadoop client jars not given; getting them from 'hadoop classpath' for the example. WARNING: log4j.properties is not found. HADOOP_CONF_DIR may be incomplete. Building shaded client example. Running shaded client example. It'll fetch the set of regions, round-trip them to a file in HDFS, then write them one-per-row into the test table. Checking on results of example program. WARNING: log4j.properties is not found. HADOOP_CONF_DIR may be incomplete. Verifying row count from example. /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh: line 531: [: hbase:002:0> : integer expression expected ERROR: Only found hbase:002:0> rows. Shutting down HBase {code}" Nightlies should test our gateway services,13434155,Open,Major,,16/Mar/22 15:44,,,"Our nightly integration test runs a small cluster, but I don't think it tests any of our gateway interfaces. It would be nice if we could also stand up the various gateway services and ping them as well. Having such automation would increase my confidence in changes like HBASE-26813." Nightly tests should exercise all of our public tools,13434881,Open,Major,,21/Mar/22 11:02,,,"As noticed on HBASE-26838, we have previously released breaking changes for some of the tools we ship to our users. We should catalogue what all those tools are and add explicit coverage that at least launching all of those tools works." Tests for shell exit behavior,13427742,Open,Major,,10/Feb/22 11:47,,,"HBase shell exit behavior and exception handling is not covered with tests. The tests should cover the clean exits and also when a command throws exceptions in interactive and non-interactive modes." TestRegisterPeerWorkerWhenRestarting fails with IllegalStateException,13435030,Open,Major,,22/Mar/22 04:54,,,"{noformat} 2022-03-21T12:25:09,067 ERROR [RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1] regionserver.ReplicationSource(434): Unexpected exception in RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1 currentPath=null java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:553) ~[classes/:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] 2022-03-21T12:25:09,068 ERROR [RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1] regionserver.HRegionServer(2284): ***** ABORTING region server b0aef29cdb13,33413,1647865503466: Unexpected exception in RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1 ***** java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:553) ~[classes/:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] 2022-03-21T12:25:09,069 ERROR [RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1] regionserver.HRegionServer(2291): RegionServer abort: loaded coprocessors are: [org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint] 2022-03-21T12:25:09,072 ERROR [RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1] regionserver.ReplicationSource(434): Unexpected exception in RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1 currentPath=null java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:553) ~[classes/:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] 2022-03-21T12:25:09,072 ERROR [RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1] regionserver.HRegionServer(2284): ***** ABORTING region server b0aef29cdb13,41089,1647865503422: Unexpected exception in RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1 ***** java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:553) ~[classes/:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] 2022-03-21T12:25:09,072 ERROR [RS_REFRESH_PEER-regionserver/b0aef29cdb13:0-0.replicationSource,1] regionserver.HRegionServer(2291): RegionServer abort: loaded coprocessors are: [org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint] {noformat}" HBase client does not honor UserGroupInformation.doAs,13430440,Resolved,Major,Won't Fix,24/Feb/22 13:31,23/Mar/22 19:24,,"Despite passing necessary UserInformation to the RegionServer, which does authorize the request, the async and block clients do not work correctly with the following access pattern: {code:java} Connection connection = ConnectionFactory.createConnection(); Table table = connection.getTable(name); UserGroupInformation proxy = UserGroupInformation.createProxyUser( ""testUser"", UserGroupInformation.getCurrentUser() ); Result result = proxy.doAs(() -> table.get(get));{code} In this case, you would expect the get to be executed as ""testUser"", but instead it is executed as whichever user created the initial connection. This can be verified by checking the security logger on the RegionServer side. The reason for this is we stash the current User onto the actual ConnectionImplementation, and we pass that through all calls in the stack when executing an RPC. I think the appropriate way would be to replace usage of this stashed User with a call to UserGroupInformation.getCurrentUser() in RpcConnection, where sasl is negotiated and headers generated." Memstore flush fencing issue for SFT,13431535,Resolved,Major,Fixed,02/Mar/22 16:39,21/Mar/22 11:55,2.6.0,"The scenarios is the following: # rs1 is flushing file to S3 for region1 # rs1 loses ZK lock # region1 gets assigned to rs2 # rs2 opens region1 # rs1 completes flush and updates sft file for region1 # rs2 has a different “version” of the sft file for region1 The flush should fail at the end, but the SFT file gets overwritten before that, resulting in potential data loss.   Potential solutions include: * Adding timestamp to the tracker file names. This and creating a new tracker file when an rs open the region would allow us to list available tracker files before an update and compare the found timestamps to the one stored in memory to verify the store still owns the latest tracker file * Using the existing timestamp in the tracker file content. This would also require us to create a new tracker file when a new rs opens the region, but instead of listing the available tracker files, we could try to load and de-serialize the last tracker file and compare the timestamp found in it to the one stored in memory." Allow Accepting snapshot location also to mapreduce jobs to run over exported snapshot.,13435174,Open,Major,,22/Mar/22 18:01,,,Currently there is no way to provide the snapshot location to mapreduce jobs to run over the exported snapshot. It would be better to provide the option so that even we can scan snapshots available at exported location. Fix flaky TestSnapshotFromMaster.testSnapshotHFileArchiving,13434510,Resolved,Major,Fixed,18/Mar/22 07:19,18/Mar/22 16:51,,"After investigating, finally I found that the problem is we just use tryLock in SnapshotFileCache.getUnreferencedFiles. If we failed to grab lock, we will skip cleaning of the archive files. We should add some retries in the test to make it more stable." [hbase-thirdparty] Release hbase-thirdparty 4.1.0,13431735,Resolved,Major,Fixed,03/Mar/22 14:34,19/Mar/22 01:13,,We have added a new module so I think we'd better dump the minor version. [hbase-thirdparty] Put up 4.1.0RC0,13431742,Resolved,Major,Fixed,03/Mar/22 14:45,19/Mar/22 01:13,, AsyncFSWAL.unackedAppends should clear after transfered to AsyncFSWAL.toWriteAppends,13421966,Resolved,Major,Won't Fix,11/Jan/22 11:47,17/Jan/22 13:21,2.4.9,"When {{ASyncFSWAL}} syncing to HDFS failed, {{AsyncFSWAL.unackedAppends}} are transfered to {{AsyncFSWAL.toWriteAppends}} to avoid data loss, but {{AsyncFSWAL.unackedAppends}} itself is not cleared. I think there is no need to continue retain them in {{AsyncFSWAL.unackedAppends}} because we would open a new HDFS pipeline to resend the {{AsyncFSWAL.unackedAppends}}. BTW : It would also simplify the logic for fixing HBASE-25905, current fix for HBASE-25905 is somewhat hard to understand. I think the problem to cause HBASE-25905 is that {{AsyncFSWAL.unackedAppends}} could not exactly reflect the *unacked* for current HDFS pipeline. If we clear {{AsyncFSWAL.unackedAppends}} after transferring them to {{AsyncFSWAL.toWriteAppends}}, HBASE-25905 could also avoid." EOL HBase 2.3.x,13424583,Resolved,Major,Fixed,25/Jan/22 05:45,17/Mar/22 20:09,,"VOTE thread is here: [https://lists.apache.org/thread/v3gfoyf255rpvql4h3g68ong5p4ps4rs] * remove from [https://hbase.apache.org/downloads] * delete from dist svn repo [https://dist.apache.org/repos/dist/release/hbase/] (which will remove the release from downloads.apache.org) * send an announcement to user@hbase and dev@hbase * delete Jenkins jobs" --hadoop-profile is not honored in branch-2 PR builds,13434115,Resolved,Major,Invalid,16/Mar/22 13:32,17/Mar/22 15:09,2.4.12,"I noticed in the PR builds for HBASE-26834 that the {{HADOOP_PROFILE}} is apparently not honored. This is problematic for the JDK11 build, which only works on Hadoop3, which must be enabled via this variable." Rsgroup: move machine to group error report table is disabledrsgroup,13434282,Open,Major,,17/Mar/22 06:58,,2.1.0,"1. Start rsgroup in cluster 2. Add a group 3. Move a machine into a group and report the following error !微信图片_20220317150240(1).png!" Rewrite TestLruAdaptiveBlockCache to make it more stable,13433654,Resolved,Major,Fixed,14/Mar/22 13:26,15/Mar/22 12:56,,Similiar to HBASE-26830. TestAdminShell2 is failing because of we referenced a deleted method,13433569,Resolved,Major,Fixed,14/Mar/22 05:32,15/Mar/22 07:52,,"{noformat} src/test/ruby/hbase/admin2_test.rb:70:in `block in test_Get_detailed_status' /home/zhangduo/hbase/code/hbase-shell/src/test/ruby/test_helper.rb:161:in `capture_stdout' 67: end 68: 69: define_test 'Get detailed status' do ^[[48;5;16;38;5;226;1m => 70: output = capture_stdout { admin.status('detailed', '') }^[[0m 71: puts ""Status output:\n#{output}"" 72: # Some text which isn't in the simple output 73: assert output.include? 'regionsInTransition' src/test/ruby/hbase/admin2_test.rb:70:in `block in test_Get_detailed_status' uri:classloader:/hbase/admin.rb:926:in `status' Error: ^[[48;5;16;38;5;226;1mtest_Get_detailed_status(Hbase::StatusTest)^[[0m: NoMethodError: undefined method `getMaster' for # Did you mean? get_master_name {noformat} It is introduced by HBASE-26730." Rewrite TestLruBlockCache to make it more stable,13433522,Resolved,Major,Fixed,13/Mar/22 15:02,14/Mar/22 03:36,,"It is very easy to fail when the build machine is busy, use Waiter.waitFor as much as possible and also increase the wait time, to make it more stable." Rest server should not use a large Header Cache.,13429996,Resolved,Major,Fixed,22/Feb/22 18:20,24/Feb/22 00:48,2.4.9,"In the RESTServer we set the HeaderCache size to DEFAULT_HTTP_MAX_HEADER_SIZE (65536). That's not compatible with jetty-9.4.x because the cache size is limited by Character.MAX_VALUE - 1 (65534) there. According to the Jetty source code comments, it's possible to have a buffer overflow in the cache for higher values and that might lead to wrong/incomplete values returned by cache and following incorrect header handling. There are a couple of ways to fix it: 1. change the value of DEFAULT_HTTP_MAX_HEADER_SIZE to 65534 2. make header cache size configurable and set its size separately from the header size. I believe that the second would give us more flexibility." Introduce path configuration for system coprocessors,13425052,Resolved,Major,Fixed,27/Jan/22 00:08,04/Feb/22 04:38,2.5.0,"Currently when region server starts, system coprocessors are normally loaded as part of the local classpath and the jar is stored in the local storage; in short words, Operator would have to copy the jar to each host (or a shared file system) and construct it as part of HBASE_CLASSPATH. although operator may have been doing the presetup of copying jar and making it available to the HBASE_CLASSPATH without any issue, it could be helpful if we provide an alternative method and centralize this configuration in hbase-site similar to the support of table-level coprocessor, e.g. configuring {{hbase.coprocessor.region.classes}} with the local/remote path along with the classname with a specific path token in the form of {{className|priority|path}}. Similarly in HBASE-23710, it provided the priority configuration via hbase-site that this new improvement aligns with the same purpose, and further help to simplify the deployment of System Coprocessors to e.g. hdfs or supported cloud storage." "Backport ""HBASE-26714 Introduce path configuration for system coprocessors"" to branch-2",13426520,Resolved,Major,Fixed,03/Feb/22 21:35,04/Feb/22 14:34,2.5.0,"backport HBASE-26714 to branch-2, mainly it's due to the unclear cherry pick of the change of HBaseCommonTestUtility to HBaseCommonTestingUtility" Threads shared EMPTY_RESULT may lead to unexpected client job down.,13423647,Resolved,Major,Fixed,20/Jan/22 03:40,15/Feb/22 12:40,,"Currently, we use a pre-created EMPTY_RESULT in the ProtoBuf.util to reduce the object creation. But these objects could be shared by multi client threads. The Result#cellScannerIndex related methods could throw confusing exception and make the client job down. Could refine the logic of these methods. The precreated objects in ProtoBufUtil.java: {code:java} private final static Cell[] EMPTY_CELL_ARRAY = new Cell[]{}; private final static Result EMPTY_RESULT = Result.create(EMPTY_CELL_ARRAY); final static Result EMPTY_RESULT_EXISTS_TRUE = Result.create(null, true); final static Result EMPTY_RESULT_EXISTS_FALSE = Result.create(null, false); private final static Result EMPTY_RESULT_STALE = Result.create(EMPTY_CELL_ARRAY, null, true); {code} Result#advance {code:java} public boolean advance() { if (cells == null) return false; cellScannerIndex++; if (cellScannerIndex < this.cells.length) { return true; } else if (cellScannerIndex == this.cells.length) { return false; } // The index of EMPTY_RESULT could be incremented by multi threads and throw this exception. throw new NoSuchElementException(""Cannot advance beyond the last cell""); } {code} Result#current {code:java} public Cell current() { if (cells == null || cellScannerIndex == INITIAL_CELLSCANNER_INDEX || cellScannerIndex >= cells.length) return null; // Although it is almost impossible, // We can arrive here when the client threads share the common reused EMPTY_RESULT. return this.cells[cellScannerIndex]; } {code} In this case, the client can easily got confusing exceptions even if they use different connections, tables in different threads. We should change the if condition cells == null to isEmpty() to avoid the client crashed from these exception." Revert the changes on hbase-daemon.sh after switching to log4j2 properties file,13433040,Resolved,Major,Fixed,10/Mar/22 07:57,12/Mar/22 08:51,,"In HBASE-19577, we changed to use two ENVVARs to specify log level and appender, so we also changed hbase-daemon.sh to use two ENVVARs. In HBASE-26723 we switched back to use one ENVVAR, so we should also revert the changes in hbase-daemon.sh." TestFanOutOneBlockAsyncDFSOutput is flakey,13432731,Resolved,Major,Fixed,09/Mar/22 02:09,10/Mar/22 08:13,,"{code:java} // [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 160.408 s <<< FAILURE! - in org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput [ERROR] org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput.testConnectToDatanodeFailed  Time elapsed: 9.631 s  <<< FAILURE! java.lang.AssertionError: expected:<2> but was:<1>         at org.junit.Assert.fail(Assert.java:89)         at org.junit.Assert.failNotEquals(Assert.java:835)         at org.junit.Assert.assertEquals(Assert.java:647)         at org.junit.Assert.assertEquals(Assert.java:633)         at org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput.testConnectToDatanodeFailed(TestFanOutOneBlockAsyncDFSOutput.java:220)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)         at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)         at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)         at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)         at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)         at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)         at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)         at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)         at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)         at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.lang.Thread.run(Thread.java:748) {code} I added some logs and found that the files were created with the old Datanode that had been restarted. !WX20220308-164340.png!" ci-hbase expansion,13433166,In Progress,Major,,10/Mar/22 15:59,,,I need a place to host images related to a dev@hbase discussion about how ci-hbase is going an what we as a project would like to expand into. Document HBaseInterfaceAudience values,13432855,Open,Major,,09/Mar/22 12:07,,,We have several values in {{HBaseInterfaceAudience}} that are not documented in their javadoc. Most of these values are not [documented in the book|https://hbase.apache.org/book.html#_interface_classifications]. Fix this. Update jackson to 2.13.1,13426702,Resolved,Major,Fixed,04/Feb/22 20:07,08/Mar/22 20:04,,Update jackson-databind to 2.13.1 to address a raised vulnerability that could possible DoS attack certain versions of Jackson. Please refer to https://github.com/FasterXML/jackson-databind/issues/3328 for further info. YCSB section of docs refers to unexisting github repo,13432480,Open,Major,,07/Mar/22 16:45,,,"in [the YCSB section|https://hbase.apache.org/book.html#ycsb] of the Apache HBase book the [Ted Dunning's YCSB repo|https://github.com/tdunning/YCSB] is mentioned. This repo doesn't exist anymore, maybe to be replaced by [Brian Frank Cooper|https://github.com/brianfrankcooper/YCSB/] ones?" Ban reload4j and logback dependencies,13432155,Resolved,Major,Fixed,05/Mar/22 11:40,07/Mar/22 01:55,,"Multiple logging framework on classpath can lead to strange behaviors, so we need to make sure that there is only one framework on our classpath. We used to ban log4j when switching to log4j2, now since hadoop is going to switch to reload4j for current release branches and zookeeper has switched to logback, we should exclude them too." TestRegionHDFSBlockLocationFinder is flaky,13432205,Resolved,Major,Fixed,06/Mar/22 06:56,07/Mar/22 00:17,,"THe refresh of the cache is async, we need to make sure the refresh is complete before doing assertion." HBase tombstone markers for MOB files are not flushed during the major compaction,13432398,Open,Major,,07/Mar/22 10:48,,2.0.2,"Hi,  While running the major compaction, non MOB Files are flushed while MOB Files are not flushed. Can someone suggest the solution." TestCanaryTool.testWriteTableTimeout is flaky,13431854,Resolved,Major,Fixed,04/Mar/22 04:43,05/Mar/22 04:06,,"{noformat} Wanted but not invoked: appender.append(); -> at org.apache.hadoop.hbase.tool.TestCanaryTool.testWriteTableTimeout(TestCanaryTool.java:310) However, there were exactly 2 interactions with this mock: appender.getName(); -> at org.apache.logging.log4j.core.config.AbstractConfiguration.addLoggerAppender(AbstractConfiguration.java:859) appender.getName(); -> at org.apache.logging.log4j.core.config.AppenderControl.(AppenderControl.java:56) {noformat} May be related to the recent log4j2 change." [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 4.1.0,13431738,Resolved,Major,Fixed,03/Mar/22 14:38,04/Mar/22 15:28,, [hbase-thirdparty] Set version as 4.1.0 in master in prep for first RC of 4.1.0,13431737,Resolved,Major,Fixed,03/Mar/22 14:35,04/Mar/22 05:54,, [hboss] Limit synchronization from hot path of HBoss APIs,13431387,Resolved,Major,Fixed,01/Mar/22 23:16,03/Mar/22 22:28,hbase-filesystem-1.0.0-alpha2,"Problem:- While using HBase with S3, timeouts were observed while restoring a snapshot of a table having many regions and HFiles, and the problem regressed as we added more restores or snapshots in parallel.   Root cause:- HBoss has some of the APIs interacting with the cache as synchronized, but as these are in the hot path of the interaction with the filesystem, threads are blocked until one is done, causing all threads working on the filesystem to run serially. In the case of restore_snapshot, which includes getting a list of completed snapshots, validating each store file, creating an HFile link in the target table, archiving files, etc. Therefore the problem is highlighted more with restore snapshot.   Solution:- Remove the synchronization as those seem unnecessary, change cache data structure to a thread-safe which provides the required level concurrency.    " TestRegionReplicaReplicationError should inject error in replicateToReplica method,13431405,Resolved,Major,Fixed,02/Mar/22 03:20,03/Mar/22 04:04,3.0.0-alpha-2,"{{TestRegionReplicaReplicationError}} added by HBASE-26233 now injects error in {{RSRpcServices.replay}}, but {{RSRpcServices.replay}} in fact is not invoked, seems we should inject error in {{RSRpcServices.replicateToReplica}}." [hbase-thirdparty] Introduce the sun.misc.Signal delegation in hbase-unsafe,13431293,Resolved,Major,Fixed,01/Mar/22 15:00,03/Mar/22 14:15,, hbck setTableState and setRegionState should accept one or more files for batch processing,13431366,Resolved,Major,Fixed,01/Mar/22 21:04,02/Mar/22 23:26,,"They should take a list of input files containing list of target and state pair, one pair per line.   This aa separate jira and pr from HBASE-24587 because that involves changing the interface of calls to server." Introduce a config to enable setting normalizer target region count through hbase site.,13431208,Open,Major,,01/Mar/22 11:03,,1.7.1,"Currently, we can define NORMALIZER_TARGET_REGION_COUNT in table descriptors. I am thinking of introducing a global property through hbase-site so we don't need to set it at each level but just add the property and that would be considered a default value. If we want to override this value we can always use htable descriptor for selected tables. priority of configs (priority decreases as we move down) NORMALIZER_TARGET_REGION_COUNT hbase.normalizer.target_region_count  " [hbase-thirdparty] Set version as 4.1.0-SNAPSHOT,13430800,Resolved,Major,Duplicate,26/Feb/22 06:15,26/Feb/22 06:21,, The ByteBuffer of metadata in RAMQueueEntry in BucketCache could be reused.,13422257,Resolved,Major,Fixed,12/Jan/22 14:39,18/Feb/22 16:48,,"Currently, the process to write HFileBlocks into IOEngine in BucketCache is: {code:java} if (data instanceof HFileBlock) { // If an instance of HFileBlock, save on some allocations. HFileBlock block = (HFileBlock) data; ByteBuff sliceBuf = block.getBufferReadOnly(); ByteBuffer metadata = block.getMetaData(); ioEngine.write(sliceBuf, offset); ioEngine.write(metadata, offset + len - metadata.limit()); } {code} The getMetaData() function in HFileBlock is: {code:java} public ByteBuffer getMetaData() { ByteBuffer bb = ByteBuffer.allocate(BLOCK_METADATA_SPACE); bb = addMetaData(bb, true); bb.flip(); return bb; } {code} It will allocate new ByteBuffer every time. We could reuse a local variable of WriterThread to reduce the new allocation of this small piece ByteBuffer. Reasons: 1. In a WriterThread, blocks in doDrain() function are written into IOEngine sequentially, there is no multi-threads problem. 2. After IOEngine.write() function, the data in metadata ByteBuffer has been transferred into ByteArray (ByteBufferIOEngine) or FileChannel (FileIOEngine) safely. The lifecycle of it is within the if statement above. So that it could be cleared and reused by the next block's writing process." Update create-release template to link to publicly visible resources,13430447,Open,Major,,24/Feb/22 14:06,,,"Per discussion on [0], let us update the template used by release managers to link to resources that are not gated by any type of authentication. [0]: https://lists.apache.org/thread/148xwk7vsgsncbomqqrzh477rlr7smdr" Create module hbase-client-test-support,13421173,Resolved,Major,Won't Fix,06/Jan/22 22:38,12/Jan/22 20:27,,I have test utilities that I need available to test code in both hbase-client and hbase-server modules. Introduce a module where such code can be consumed by any tests downstream of the hbase-client module. Setback occurs to AsyncFSWAL#highestProcessedAppendTxid and then IllegalArgumentException,13429616,Resolved,Major,Duplicate,21/Feb/22 03:54,22/Feb/22 09:56,2.4.9,"The consumer thread in AsyncFSWAL crashed by IllegalArgumentException, stack trace is as follows, {code:java} Exception in thread ""XXXX"" java.lang.IllegalArgumentException: fromKey > toKey         at java.util.TreeMap$NavigableSubMap.(TreeMap.java:1368)         at java.util.TreeMap$AscendingSubMap.(TreeMap.java:1855)         at java.util.TreeMap.subMap(TreeMap.java:913)         at java.util.TreeSet.subSet(TreeSet.java:325)         at java.util.TreeSet.subSet(TreeSet.java:361)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.isHsync(AsyncFSWAL.java:375)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:392)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.appendAndSync(AsyncFSWAL.java:504)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.consume(AsyncFSWAL.java:565)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:745) Exception in thread ""XXXX"" java.lang.IllegalArgumentException: fromKey > toKey         at java.util.TreeMap$NavigableSubMap.(TreeMap.java:1368)         at java.util.TreeMap$AscendingSubMap.(TreeMap.java:1855)         at java.util.TreeMap.subMap(TreeMap.java:913)         at java.util.TreeSet.subSet(TreeSet.java:325)         at java.util.TreeSet.subSet(TreeSet.java:361)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.isHsync(AsyncFSWAL.java:375)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:392)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.appendAndSync(AsyncFSWAL.java:504)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.consume(AsyncFSWAL.java:565)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:745) {code}" hbase thrift2 FilterString not working,13428517,Open,Major,,15/Feb/22 09:00,,2.4.9,"I am trying to connect hbase by thrift2 golang client. Everything works well but the filterString field. No matter what value I set (just simply convert from string to []byte) it doesn't work and return an empty result. And I had tried the thrift service of the old version and it worked. Is there some hint trick to generate the filterString []byte in thrift2?" Backporting of HBASE-25643,13422498,Resolved,Major,Fixed,13/Jan/22 10:46,25/Jan/22 13:52,1.7.1, Migrate our jenkins jobs from ci-hadoop to ci-hbase,13424115,Resolved,Major,Fixed,22/Jan/22 03:43,17/Feb/22 18:04,,"We have our own jenkins controller now. Let's do the migration." remove disabled hbase jobs from ci-hadoop,13428391,Resolved,Major,Fixed,14/Feb/22 17:32,17/Feb/22 18:04,,There are a bunch of disabled jobs on ci-hadoop from us cautiously moving to ci-hbase. Delete them all once we're confident that things are moved over to ci-hbase enough that we are going to handle future problems by fixing them in-place on ci-hbase rather than rolling back to running on ci-hadoop. Use python2 instead of python in our python scripts,13427328,Resolved,Major,Fixed,09/Feb/22 01:57,09/Feb/22 08:47,,"According to the suggestion from INFRA team, let's specify python2 directly. Later we could see if we can migrate to python3." Comparator of NOT_EQUAL NULL is invalid for checkAndMutate,13427082,Resolved,Major,Fixed,08/Feb/22 04:18,16/Feb/22 03:26,1.8.0," In server side, checkAndMutate ignores CompareOperator for null or empty comparator value, but NOT_EQUAL should be treated specially. The check logic in HRegion#checkAndMutateInternal is as follows, {code:java} boolean valueIsNull = comparator.getValue() == null || comparator.getValue().length == 0; if (result.isEmpty() && valueIsNull) { matches = true; } else if (result.size() > 0 && result.get(0).getValueLength() == 0 && valueIsNull) { matches = true; cellTs = result.get(0).getTimestamp(); } else if (result.size() == 1 && !valueIsNull) { Cell kv = result.get(0); cellTs = kv.getTimestamp(); int compareResult = PrivateCellUtil.compareValue(kv, comparator); matches = matches(op, compareResult); }{code} For current logics, here are some  counter examples(Comparator value is set null), # result is null, operator is NOT_EQUAL, but matches is true; # result size >0, the value of the first cell is empty, operator is NOT_EQUAL, but matches is true; # result size is 1, operator is NOT_EQUAL, but matches is false;" HBase website generation should show error details on failure,13428359,Resolved,Major,Fixed,14/Feb/22 15:40,14/Feb/22 20:49,,website build failed this morning while running maven. no details because we have to opt-in via {{--errors}} HBase Thirdparty repo should have nightly for checking main repo tests on top of SNAPSHOT artifacts,13428849,Open,Major,,16/Feb/22 15:06,,,"We should have a nightly test that runs if there are changes to * top level pom * any of the hbase-shaded-* modules That test should grab the current HEAD of a configurable branch of the main repo (which defaults to the repo's default branch, currently master) and then attempt a build + tests while setting {{hbase-thirdparty.version}} to the in-progress SNAPSHOT build. The test run should exclude the current set of flaky tests." RegionReplicationSink.send set timeout for replicating meta edits error,13428124,Resolved,Major,Fixed,12/Feb/22 06:00,14/Feb/22 09:15,3.0.0-alpha-3,"HBASE-26539 introduce separate {{RegionReplicationSink.metaEditRpcTimeoutNs}} and {{RegionReplicationSink.metaEditOperationTimeoutNs}} for replicating meta edits, but seems in {{RegionReplicationSink.send}} set timeout is erroneous: {code:java} if (hasMetaEdit) { rpcTimeoutNsToUse = rpcTimeoutNs; operationTimeoutNsToUse = operationTimeoutNs; } else { rpcTimeoutNsToUse = metaEditRpcTimeoutNs; operationTimeoutNsToUse = metaEditOperationTimeoutNs; } {code}" migrate ARM specific build,13426965,Resolved,Major,Fixed,07/Feb/22 16:04,14/Feb/22 17:30,, Migrate HBase main pre commit job to ci-hbase,13427424,Resolved,Major,Fixed,09/Feb/22 08:53,11/Feb/22 03:51,,"We used to run this on the hadoop label so first we need to change the label in jenkins file. And before migration, we need to move the 10 hbase nodes from ci-hadoop to ci-hbase as there are no jobs on them any more." Migrate HBase Nightly HBase-Flaky-Tests and HBase-Find-Flaky-Tests to ci-hbase,13424116,Resolved,Major,Fixed,22/Jan/22 03:44,11/Feb/22 03:50,,"They are tied together so let's do them at once. We also need to modify the url for our pre commit job." Spurious compaction failures with file tracker,13420609,Resolved,Major,Not A Problem,04/Jan/22 16:01,11/Feb/22 01:49,,"Noticed when running a basic {{{}hbase pe randomWrite{}}}, we'll see compactions failing at various points. One example: {noformat} 2022-01-03 17:41:18,319 ERROR [regionserver/localhost:16020-shortCompactions-0] regionserver.CompactSplit(670): Compaction failed region=TestTable,00000000000000000004054490,1641249249856.2dc7251c6eceb660b9c7bb0b587db913., storeName=2dc7251c6eceb660b9c7bb0b587db913/info0,       priority=6, startTime=1641249666161 java.io.IOException: Root-level entries already added in single-level mode   at org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexWriter.writeSingleLevelIndex(HFileBlockIndex.java:1136)   at org.apache.hadoop.hbase.io.hfile.CompoundBloomFilterWriter$MetaWriter.write(CompoundBloomFilterWriter.java:279)   at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl$1.writeToBlock(HFileWriterImpl.java:713)   at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.writeBlock(HFileBlock.java:1205)   at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.close(HFileWriterImpl.java:660)   at org.apache.hadoop.hbase.regionserver.StoreFileWriter.close(StoreFileWriter.java:377)   at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.commitWriter(DefaultCompactor.java:70)   at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:386)   at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62)   at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125)   at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1141)   at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2388)   at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:654)   at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:697)   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)   at java.lang.Thread.run(Thread.java:748) {noformat} This isn't a super-critical issue because compactions will be retried automatically and they appear to eventually succeed. However, when the max storefiles limit is reaching, this does cause ingest to hang (as I was doing with my modest configuration). We had seen a similar kind of problem in our testing when backporting to HBase 2.4 (not upstream as the decision was to not do this) which we eventually tracked down to a bad merge-conflict resolution to the new HFile Cleaner. However, initial investigations don't have the same exact problem. It seems that we have some kind of generic race condition. Would be good to add more logging to catch this in the future (since we have two separate instances of this category of bug already)." "The branch-1 nightly jenkins job fails with ""No such DSL method 'jiraComment' found""",13427505,Resolved,Major,Fixed,09/Feb/22 13:07,10/Feb/22 16:26,, Ban the usage of junit 3 TestCase,13424831,Resolved,Major,Fixed,26/Jan/22 05:41,09/Feb/22 17:10,,We should move up all our UTs to junit 4 style. Backport the UT changes in HBASE-24510 to branch-2.x,13425524,Resolved,Major,Fixed,29/Jan/22 03:49,09/Feb/22 16:54,,We could still keep HBaseTestCase but we can modify our own UTs to not rely on it. The replication batch size is too large and cannot be written to the standby cluster,13424673,Open,Major,,25/Jan/22 11:59,,1.3.1,"Recently, we met a replication failure and it cannot be recovered. The main reason is that the number of data records read from the wal during synchronization is not limited. In addition, the batch size is not limited when data is written to the peer cluster. As a result, the replication will be failed because of writing timeout. It is recommended that the number of records to be written  with a controllable range, for example, 2000 records, and can be modified through configuration. Here are some log stacks !image-2022-01-25-19-59-39-118.png!  " hbase regionserver keep on restarting in azure setup,13424148,Open,Major,,22/Jan/22 13:52,,,"hadoop hbase version 2.4.8 hadoop hdfs version 2.7.7   Hbase master and regionserver keep on restarting due to procedure.SplitWALProcedure: Failed to split wa   logs from master and regionserver attached" migrate hbase-thirdparty PR ,13427099,Resolved,Major,Fixed,08/Feb/22 06:11,08/Feb/22 06:37,, migrate hbase-native-client PR job,13426827,Resolved,Major,Fixed,07/Feb/22 05:10,07/Feb/22 15:57,, Performance regression in asyncwal ,13426931,Open,Major,,07/Feb/22 14:00,,2.4.6,"I've been doing load testing of hbase2, using hadoop 3.3.1 (client and server). Comparing the results to an identical cluster running hbase/hadoop cdh5.16.2 (hbase ~1.2.0, hadoop ~2.6.0). With a heavy write workload I would consistently see 99th percentile sync times of 5-6ms in cdh5, but 20-30ms in hbase2. Configuring hbase2 to use 'filesystem' wal provider mostly resolves this regression, resulting in latencies of 6-8ms. So still a little slower than cdh5, but much more reasonable. Unfortunately I don't have a lot of flexibility in my environment to try various versions of hadoop. I didn't notice any exceptions or anything to indicate an API problem with hadoop 3.3.1, this may just be a general regression in the 2.x branch. I briefly tried profiling wall clock time and the process was dominated by waiting in SyncFuture.get. I haven't dug deep enough into the code yet to know how to identify a bottleneck in whatever threads are responsible for completing those futures. One thing to note, I tried enabling hbase.wal.async.use-shared-event-loop but noticed no difference." migrate hhbase-operator-tools PR job,13426825,Resolved,Major,Fixed,07/Feb/22 04:50,07/Feb/22 05:05,, migrate hbase-connectors PR job,13426821,Resolved,Major,Fixed,07/Feb/22 03:34,07/Feb/22 04:45,, migrate website generation,13424121,Resolved,Major,Fixed,22/Jan/22 06:11,07/Feb/22 02:29,, Changes to hbase-client should result in pre-commit testing of hbase-server,13425829,Open,Major,,31/Jan/22 17:09,,,The client is an integral component of hbase-server. Our pre-commit check should hold a PR accountable to the hbase-server module when proposing changes to hbase-client. Remove 2.3 from Downloads page,13424938,Resolved,Major,Fixed,26/Jan/22 14:33,26/Jan/22 15:37,, Remove jenkins files from branch-2.3,13424934,Resolved,Major,Fixed,26/Jan/22 14:23,26/Jan/22 15:04,,Remove jenkins files as 2.3 reached EOL. Standalone unit test in hbase-examples,13422629,Resolved,Major,Fixed,13/Jan/22 22:13,25/Jan/22 12:56,,"Andor is already working on this with nimbus, but filing this for him. We should have a unit test which exercises the oauth bearer authentication mechanism so that we know if the feature is functional at a basic level (without having to set up on OAuth server)." Initial commit with basic functionality and example code,13421704,Resolved,Major,Fixed,10/Jan/22 12:48,20/Jan/22 23:25,, Remove deprecated methods in MasterObserver,13422547,Resolved,Major,Fixed,13/Jan/22 14:48,19/Jan/22 11:27,,We have several methods which are marked as deprecated and should be removed in 3.0.0. [Flakey Tests] TestBackupStatusProgress fails opaquely waiting on YARN,13423591,Open,Major,,19/Jan/22 18:57,,3.0.0-alpha-2,"The test failed with only this message, followed by a thread dump. Apparently something timed out. {noformat} [ERROR] org.apache.hadoop.hbase.backup.TestBackupStatusProgress Time elapsed: 0.175 s <<< ERROR! org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.util.concurrent.TimeoutException: Timed out waiting for condition. Thread diagnostics: {noformat} The junit ""main"" thread in the dump looks like, {noformat} ""Time-limited test"" daemon prio=5 tid=21 runnable java.lang.Thread.State: RUNNABLE at java.lang.Thread.dumpThreads(Native Method) at java.lang.Thread.getAllStackTraces(Thread.java:1610) at org.apache.hadoop.test.TimedOutTestsListener.buildThreadDump(TimedOutTestsListener.java:87) at org.apache.hadoop.test.TimedOutTestsListener.buildThreadDiagnosticString(TimedOutTestsListener.java:73) at org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:389) at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster$JobHistoryServerWrapper.serviceStart(MiniMRYarnCluster.java:260) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) at org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121) at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceStart(MiniYARNCluster.java:322) at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster.serviceStart(MiniMRYarnCluster.java:211) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) at org.apache.hadoop.mapred.MiniMRClientClusterFactory.create(MiniMRClientClusterFactory.java:80) at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:188) at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:176) at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:168) at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:129) at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2336) at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2269) at org.apache.hadoop.hbase.backup.TestBackupBase.setUpHelper(TestBackupBase.java:300) at org.apache.hadoop.hbase.backup.TestBackupBase.setUp(TestBackupBase.java:327) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) {noformat}" [Flakey Tests] TestHBCKSCPUnknown.test fails while scheduling,13423587,Open,Major,,19/Jan/22 18:46,,3.0.0-alpha-2,"{noformat} [ERROR] org.apache.hadoop.hbase.master.procedure.TestHBCKSCPUnknown.test Time elapsed: 89.103 s <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hbase.master.procedure.TestHBCKSCPUnknown.scheduleHBCKSCP(TestHBCKSCPUnknown.java:51) at org.apache.hadoop.hbase.master.procedure.TestHBCKSCP.test(TestHBCKSCP.java:138) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) {noformat}" [Flakey Tests] TestThriftSpnegoHttpServer violates SystemExitRule,13423576,Open,Major,,19/Jan/22 18:41,,3.0.0-alpha-2,"{noformat} [ERROR] org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpServer.testRunThriftServer Time elapsed: 7.604 s <<< ERROR! org.apache.hadoop.hbase.SystemExitRule$SystemExitInTestException at org.apache.hadoop.hbase.TestSecurityManager.checkExit(TestSecurityManager.java:32) at java.lang.Runtime.exit(Runtime.java:107) at java.lang.System.exit(System.java:973) at org.apache.hadoop.hbase.thrift.ThriftServer$2.run(ThriftServer.java:873) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:360) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1709) at org.apache.hadoop.hbase.thrift.ThriftServer.run(ThriftServer.java:859) at org.apache.hadoop.hbase.thrift.ThriftServerRunner.run(ThriftServerRunner.java:55) {noformat}" [Flakey Tests] TestBindExceptionHandling.testProtocolPortClash doesn't assert clean starting point,13423574,Open,Major,,19/Jan/22 18:39,,3.0.0-alpha-2,"Looks like the metrics subsystem is not being reset between test runs. {noformat} [ERROR] org.apache.hadoop.hbase.thrift.TestBindExceptionHandling.testProtocolPortClash Time elapsed: 6.441 s <<< ERROR! org.apache.hadoop.metrics2.MetricsException: Metrics source Thrift,sub=ThriftOne already exists! at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newSourceName(DefaultMetricsSystem.java:152) at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.sourceName(DefaultMetricsSystem.java:125) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.register(MetricsSystemImpl.java:229) at org.apache.hadoop.hbase.metrics.BaseSourceImpl.(BaseSourceImpl.java:119) at org.apache.hadoop.hbase.metrics.ExceptionTrackingSourceImpl.(ExceptionTrackingSourceImpl.java:47) at org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceImpl.(MetricsThriftServerSourceImpl.java:58) at org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceFactoryImpl.createThriftOneSource(MetricsThriftServerSourceFactoryImpl.java:42) at org.apache.hadoop.hbase.thrift.ThriftMetrics.(ThriftMetrics.java:77) at org.apache.hadoop.hbase.thrift.ThriftServer.createThriftMetrics(ThriftServer.java:206) at org.apache.hadoop.hbase.thrift.ThriftServer.setupParamters(ThriftServer.java:234) at org.apache.hadoop.hbase.thrift.ThriftServer.run(ThriftServer.java:853) at org.apache.hadoop.hbase.thrift.ThriftServerRunner.run(ThriftServerRunner.java:55) {noformat}" Backport HBASE-26579 to branch-1,13423161,Resolved,Major,Fixed,18/Jan/22 03:05,18/Jan/22 07:09,,Our branch-1 cluster also met the storage policy problem in usage. Backport the path to branch-1. "This is really fantastic blog with full of knowledgeable thoughts. Readers are always like to read full informational blogs, and this is one of them. You really done great job.",13422965,Resolved,Major,Invalid,17/Jan/22 06:49,17/Jan/22 08:11,, [operator-tools] Provide a utility to detect and correct incorrect RegionInfo's in hbase:meta,13421812,Resolved,Major,Fixed,10/Jan/22 20:18,12/Jan/22 18:44,,"HBASE-23328 describes a problem in which the serialized RegionInfo in the value of hbase:meta cells have an encoded regionname which doesn't match the encoded region name in the rowkey for that cell. This problem is normally harmless as assignment only consults the rowkey to get the encoded region name. However, this problem does break other HBCK2 tooling, like {{{}extraRegionsInMeta{}}}.  Rather than try to update each tool to account for when this problem may be present, create a new tool which an operator can run to correct meta and then use any subsequent tools as originally intended." TestDrainReplicationQueuesForStandBy is flakey,13421183,Open,Major,,07/Jan/22 00:39,,3.0.0-alpha-3,"{{TestDrainReplicationQueuesForStandBy}} is behaving badly for me, it keeps coming up as a failure in PRs. It's been passing on master nightlies. When I checkout a recent master, {{ce2bbaf30a}}, and run the test in a loop, I see it failing with this error at a rate of about 2 in 10 tries. {noformat} [INFO] Running org.apache.hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 35.264 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy [ERROR] org.apache.hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy.test Time elapsed: 15.628 s <<< ERROR! java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0 at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248) at java.base/java.util.Objects.checkIndex(Objects.java:372) at java.base/java.util.ArrayList.get(ArrayList.java:459) at org.apache.hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy.test(TestDrainReplicationQueuesForStandBy.java:77) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:829) {noformat}" Auto-disable setCacheBlocks when large scans are detected,13420914,Open,Major,,05/Jan/22 20:00,,,"Block cache churn is the biggest driver of GC issues, and also impacts the performance of clients which may rely on the cache. Ideally all users would remember to call setCacheBlocks(false) on their scan before doing a large scan, but it's also easy to forget. Operators may not realize this was a problem until a job is running which is quickly churning your cache. It seems like we could provide a mechanism to detect large scans and transparently disable block caching on the server side when they might churn large portions of the cache." Split TestMasterFailoverWithProcedures,13420268,Resolved,Major,Fixed,02/Jan/22 12:58,02/Jan/22 16:42,,"For each test in it, we will start a new mini cluster. Let's split it into several tests." Cherry-pick the ReflectionUtils improvements in HBASE-21515 to branch-2,13420207,Resolved,Major,Fixed,01/Jan/22 16:03,02/Jan/22 09:34,,So we can accept null parameters when finding constructors. MetricsStochasticBalancerSource metrics don't render in /jmx endpoint,13427243,Resolved,Minor,Fixed,08/Feb/22 16:29,03/Mar/22 01:49,,"The check in JSONBean [here|https://github.com/apache/hbase/blob/master/hbase-http/src/main/java/org/apache/hadoop/hbase/util/JSONBean.java#L266] causes the balancer cost metrics to be excluded from the {{/jmx}} endpoint. I think we should just remove the check for "":"". I don't think including metrics with a colon in them poses any problem, since the strings are quoted. We removed this check in our cdh5 fork almost a year ago and have not seen any issues. Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit metrics that adhere to these filters, but I think that would be a backwards incompatible change since this is only a json rendering issue and people might be consuming JMX directly." Update downloads.xml for 2.4.11,13434643,Resolved,Minor,Fixed,19/Mar/22 01:56,19/Mar/22 01:57,, Introduce a FlushProcedure,13434711,Resolved,Minor,Fixed,20/Mar/22 05:36,28/Aug/23 03:11,,Reimplement proc-v1 based flush procedure in proc-v2. Fix flaky TestBasicWALEntryStreamFSHLog.testSizeOfLogQueue,13433867,Open,Minor,,15/Mar/22 12:26,,2.4.12,The failed info is described in HBASE-26843. WALPlayer should obtain token from filesystem,13420758,Resolved,Minor,Fixed,05/Jan/22 08:57,04/May/23 18:52,,"When we use WALPlayer, we got the following exceptions: {code:java} 2021-12-27 17:20:13,388 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.io.IOException: Failed on local exception: java.io.IOException: org.apache.hadoop.security.AccessControlException: Client cannot authenticate via:[TOKEN, KERBEROS]; Host Details : local host is: ""c4-hadoop-tst-st95.bj/10.132.18.11""; destination host is: ""c4-hadoop-tst-ct01.bj"":58300;      at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:775)     at org.apache.hadoop.ipc.Client.call(Client.java:1488)     at org.apache.hadoop.ipc.Client.call(Client.java:1415)     at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:232)     at com.sun.proxy.$Proxy13.getFileInfo(Unknown Source)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo(ClientNamenodeProtocolTranslatorPB.java:807)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:249)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:107)     at com.sun.proxy.$Proxy14.getFileInfo(Unknown Source)     at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:2115)     at org.apache.hadoop.hdfs.DistributedFileSystem$20.doCall(DistributedFileSystem.java:1221)     at org.apache.hadoop.hdfs.DistributedFileSystem$20.doCall(DistributedFileSystem.java:1217)     at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)     at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1233)     at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:64)     at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.init(ProtobufLogReader.java:168)     at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:332)     at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:314)     at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:302)     at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:444)     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.openReader(AbstractFSWALProvider.java:497)     at org.apache.hadoop.hbase.mapreduce.WALInputFormat$WALRecordReader.openReader(WALInputFormat.java:161)     at org.apache.hadoop.hbase.mapreduce.WALInputFormat$WALRecordReader.initialize(WALInputFormat.java:154)     at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:552)     at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:790)     at org.apache.hadoop.mapred.MapTask.run(MapTask.java:342)     at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:163)     at java.security.AccessController.doPrivileged(Native Method)     at javax.security.auth.Subject.doAs(Subject.java:422)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1885)     at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158) {code}" Fix CME in ReplicationSourceManager,13432822,Resolved,Minor,Fixed,09/Mar/22 09:54,29/Jan/24 18:54,2.4.10,"Exception in thread ""regionserver/hostname/ip:port"" java.util.ConcurrentModificationException         at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)         at java.util.ArrayList$Itr.next(ArrayList.java:851)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.join(ReplicationSourceManager.java:832)         at org.apache.hadoop.hbase.replication.regionserver.Replication.join(Replication.java:162)         at org.apache.hadoop.hbase.replication.regionserver.Replication.stopReplicationService(Replication.java:155)         at org.apache.hadoop.hbase.regionserver.HRegionServer.stopServiceThreads(HRegionServer.java:2623)         at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1175)         at java.lang.Thread.run(Thread.java:745)" Enhance StochasticLoadBalancer reported metrics and logs ,13431803,Open,Minor,,03/Mar/22 20:21,,2.4.11,"Sometimes we have noticeable skew in our hbase clusters but see the balancer cannot find a better plan to resolve this skew. When trying to reason about why the StochasticLoadBalancer is not taking action and appropriately tuning costs as needed, it is often hard to quickly reason about how the published metrics  and output in the logs correlate and impact the balancer actions. It is also sometimes hard to reason about how a cost like the move cost (which doesnt show up in imbalance and is a hidden cost against every move in calculating a new plan) might be impacting the balancer effectiveness.    It would be nice to include some additional information like the sumMultiplier and overallCost in the logs as well as publish the weighted imbalance metrics and rename the cost metrics to CostFunctionPercentage. Also additional logging for the state of the cost functions when an improved plan cannot be found would also be helpful. " Shell suspended in background,13430490,Resolved,Minor,Fixed,24/Feb/22 17:56,01/Mar/22 12:40,,"The hbase shell process hangs when running in the background with piped input. {noformat} $ cat command.sh #!/bin/bash echo ""list"" | bin/hbase shell > shell.out 2>&1 $ ./command.sh & [1] 62907 $ [1]  + 62907 suspended (tty output)  ./command.sh{noformat} This regression was introduced with JRuby 9.1 -> 9.2 upgrade and the process hangs on this line: [https://github.com/apache/hbase/blob/master/hbase-shell/src/main/ruby/jar-bootstrap.rb#L41]  " Update protobuf-java to 3.19.4,13427251,Resolved,Minor,Fixed,08/Feb/22 17:19,19/Feb/22 01:25,,"Refer, https://nvd.nist.gov/vuln/detail/CVE-2021-22569" Metrics for tracking of active scanners,13426622,Resolved,Minor,Fixed,04/Feb/22 13:07,04/Mar/22 22:15,,"Active scanners take up resources on the RegionServer. This can result in GC issues or even OOMs in cases of leaked scanners. It'd be helpful to have metrics for tracking scanners. I was thinking of: * activeScanners - a gauge, showing the number of active scanners at a point in time * scannerLeaseExpirations - a counter of lease expirations" TableInputFormatBase should cache RegionSizeCalculator,13435130,Resolved,Minor,Fixed,22/Mar/22 13:56,25/Mar/22 02:06,,"TableInputFormatBase's getSplits() method instantiates a new RegionSizeCalculator every time. Instantiating a RegionSizeCalculator involves scanning for all regionlocations for a given table in meta. This can be costly for large tables, and we don't know how often a subclass will call getSplits(). When initializeTable is called, we already cache the RegionLocator and Admin that are used for passing into the RegionSizeCalculator. We should similarly cache the RegionSizeCalculator itself at that same time to avoid unnecessary meta scans on repeat getSplits() calls." "LICENSE handling should not allow non-aggregated ""apache-2.0""",13429192,Resolved,Minor,Fixed,17/Feb/22 19:11,07/Mar/22 19:11,2.4.10,"our non-aggregated license check currently allows the malformed name ""apache-2.0"". All ALv2 licenses should be aggregated. - remove ""apache-2.0"" from the {{non_aggregate_fine}} list - figure out what dependencies are referring to this license and correct them in {{supplemental-models.xml}} nice to have: maybe add a precommit check that complains if the {{non_aggregate_fine}} set is changed?" Allow configuration of IPC queue balancer,13424517,Resolved,Minor,Fixed,24/Jan/22 21:28,19/Feb/22 02:05,,"Currently we randomly assign IPC calls to queues using a RandomQueueBalancer, which relies on ThreadLocalRandom. I would like to make that configurable so that one can plug in their own queue balancer. This usefully combines with the existing ability to specify a pluggable queue type." Allow disable of region warmup before graceful move,13425864,Resolved,Minor,Fixed,31/Jan/22 22:17,01/Feb/22 23:48,,"We have encountered two issues with region warmup before the assignment manager gracefully moves a region from one regionserver to another. The first instance is HBASE-26722. Part of the failure chain is temporary double assignment like conditions where both the source and destination regionservers think they have exclusive rights to storefile management (as they should) but warmup opens a region before it is closed and then both regionservers take compaction related actions. While this can be remediated with more care to this case, it is unclear if warmup affords significant advantage. The motivation of the original commit in 2015 introducing this feature was avoidance of blockcache misses once region ownership transfer was advertised to clients. Depending on use case and additional default-false schema options (like preload) this could be valuable. Or not. The second instance is in place upgrade from HBase 1 to HBase 2. In a scenario where regionservers have been replaced by HBase 2 versions, but the master is still HBase 1, the region warmup RPC request fails. This is not particularly harmful but indicates it will not be useful during the transition period. We think it would be good to allow for warmup before move to be optionally disabled by a site configuration setting. In particular there have been many unrelated changes committed since 2015 and expectations of invariants in the contribution of the warmup-on-move feature have been invalidated. HBASE-26722 may be the only case, or it might not. This is a fairly trivial change." Remove 'patch' file added as part of commit for HBASE-25973 ,13425290,Resolved,Minor,Fixed,28/Jan/22 00:46,28/Jan/22 00:48,2.5.0, Extend hbase shell 'status' command to support an option 'tasks',13426540,Resolved,Minor,Fixed,04/Feb/22 02:04,16/Feb/22 02:40,,"Extend status command to support an option 'tasks', which will iterate over live regionservers and pretty print the status of any active MonitoredTasks. 1. Expose monitored tasks state in ClusterStatus API via new option in ServerLoad 2. Add shell support for interrogating monitored tasks state in ServerLoad Here is a prototype running on a small test cluster of a fork of branch-2.4: !Screen Shot 2022-02-03 at 5.57.26 PM.png! " TestMobStoreScanner (testGetMassive) can OOME,13429415,Resolved,Minor,Fixed,19/Feb/22 01:12,11/Mar/22 07:27,2.4.10,"Running TestMobStoreScanner, looks like it may need to go on a diet. The test case testGetMassive will reliably OOME for me. It might be because I am using an aarch64 Java 8 JVM and surefire.Xmx as currently defined in pom.xml at 2200m is not quite enough. {noformat} 2022-02-18T17:04:04,886 ERROR [RS:0;buildbox:45315] util.OOMEChecker(40): Run out of memory; RSRpcServices will abort itself immediate ly java.lang.OutOfMemoryError: Java heap space {noformat} Where the OOME is thrown is usually not germane so the rest of the stacktrace is not included. A repeatable failure for me." Use toStringBinary for rowkey in RegionServerCallable error string,13434935,Resolved,Minor,Fixed,21/Mar/22 15:11,25/Mar/22 22:50,2.4.11,"Bytes.toString does not work well with most row keys, since the row key is very unlikely to actually be a simple UTF-8 string. Bytes.toStringBinary is better" Fix CallDroppedException reporting,13425884,Resolved,Minor,Fixed,01/Feb/22 00:48,19/Feb/22 01:44,,"HBASE-26623 added a new metric for counting CallDroppedExceptions, but actually was not being incremented because the exception is thrown before it ever gets handled by the RpcServer. We need to increment the exception in the CallRunner.drop(), where the exception is thrown." Minor code cleanup in and around RpcExecutor,13431333,Resolved,Minor,Fixed,01/Mar/22 17:08,10/Mar/22 13:33,2.5.0,"While working on tracing, I see some minor cleanup that can be done around the RpcExecutor class. The implementations of the {{dispatch}} methods don't actually throw the exceptions defined in their signatures, and there's some simplification to be done and checkstyle warnings to resolve while I'm in there." Minor code cleanup in and around RpcScheduler,13432906,Resolved,Minor,Fixed,09/Mar/22 16:46,11/Mar/22 10:16,2.5.0,"Following the coattails of HBASE-26782. See detailed compatibility discussion on https://github.com/apache/hbase/pull/4173 See a related concern regarding {{IA.LimitedPrivate}} annotations on class hierarchies on HBASE-26817." ProfileServlet should move the output location to hbase specific directory,13421904,Resolved,Minor,Fixed,11/Jan/22 07:25,11/Jan/22 10:37,,"Since ProfileServlet is forked and being used by several projects, we should allow HBase specific profile servlet to use hbase specific profiler output location rather than the common location: ""${java.io.tmpdir}/prof-output""." RpcRetryingCallerImpl translateException ignores return value of recursive call,13434933,Resolved,Minor,Fixed,21/Mar/22 14:59,25/Mar/22 16:20,2.4.11,"RpcRetryingCallerImpl.translateException recurses if the translated exception is a ServiceException. The stated reason is because the ServiceException may be a RemoteException, which should be unwrapped. However, the return value of that recursion is ignored so the RemoteException is not being properly unwrapped (unless it's a DoNotRetryIOException in which case it will throw) Looking at the similar translateException call in the AsyncRpcRetryingCaller, it looks like that bug was fixed there. We should similarly fix in the blocking client for branch-2." Fix NPE in the retry of logroller,13433770,Resolved,Minor,Fixed,15/Mar/22 02:39,15/Mar/22 14:24,2.4.10,"{code:java} LOG.warn(""Retry to roll log, nAttempts={}, waiting time={}ms, sleeping 1s to retry,"" + "" last excepiton= {}"", nAttempts, waitingTime, ioe.getCause().getClass().getSimpleName()); {code} ioe.getCause() maybe null." Normalizer exits without normalizing all the tables,13427208,Resolved,Minor,Fixed,08/Feb/22 14:22,10/Feb/22 09:58,1.7.1,"Currently if there are multiple tables to normalize, normalizer is exiting even before iterating all the table if there is a table that doesnot require normalization here is the offending code [https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1736]   {code:java} List plans = this.normalizer.computePlansForTable(table); if (plans == null || plans.isEmpty()) { return true; } {code} this is running inside loop over tables  " "add archive directory, old WAL direcotry and disabled tables space usage information to metrics",13430338,Open,Minor,,24/Feb/22 05:57,,,"Currently we don't have space usage information for the archive directory, the old wal directory and disabled tables.  This patch is to add this part of the information to the metric system.    " [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes,13425281,Resolved,Minor,Duplicate,27/Jan/22 23:58,04/Mar/22 19:58,,"Found artifact with unexpected contents: '/home/apurtell/src/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-2.5.0-SNAPSHOT.jar' com/sun/activation/ javax/activation/ javax/xml/bind/" Bump checkstyle from 8.28 to 8.29,13437094,Resolved,Minor,Fixed,31/Mar/22 21:16,19/May/22 00:59,2.4.11,"Dependabot generated pull request. Bumps checkstyle from 8.28 to 8.29. The security fix is disabling the 'external-parameter-entities' feature by default. " Fix CME when closing region,13434553,Resolved,Minor,Won't Fix,18/Mar/22 10:27,05/May/22 03:55,2.4.11,"KeyValueHeap.scannersForDelayedClose is not thread safe, CME might occurs when closing a scanning region, who is adding scanners to the  delayed close list. {code:java} 2022-03-18 17:24:17,435 INFO  [regionserver/hostname/ip:16020-splits-0] regionserver.SplitRequest: Running rollback/cleanup of failed split of hmart-waimaiups_poi_bitmap_theme_pool,,1645769651132.56363df04da85752aa67669989de19fd.; java.util.ConcurrentModificationException java.io.IOException: java.util.ConcurrentModificationException         at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1767)         at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1593)         at org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:394)         at org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:276)         at org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:567)         at org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)         at org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:156)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:745) Caused by: java.util.ConcurrentModificationException         at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)         at java.util.ArrayList$Itr.next(ArrayList.java:851)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.close(KeyValueHeap.java:221)         at org.apache.hadoop.hbase.regionserver.StoreScanner.close(StoreScanner.java:548)         at org.apache.hadoop.hbase.regionserver.StoreScanner.close(StoreScanner.java:520)         at org.apache.hadoop.hbase.regionserver.HStore.closeChangedReadersObservers(HStore.java:1296)         at org.apache.hadoop.hbase.regionserver.HStore.close(HStore.java:1001)         at org.apache.hadoop.hbase.regionserver.HStore.close(HStore.java:131)         at org.apache.hadoop.hbase.regionserver.HRegion$2.call(HRegion.java:1745)         at org.apache.hadoop.hbase.regionserver.HRegion$2.call(HRegion.java:1741)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         ... 3 more {code}" Add unit test for custom RpcControllerFactory's ability to overwrite priorities,13435875,Resolved,Minor,Fixed,25/Mar/22 18:32,30/Apr/22 02:05,,We're planning on using the pluggable nature of RpcControllerFactory to send along custom priorities that are calculated based on some special logic in our stack. Unfortunately it's virtually impossible to test this from user code. On the other hand it's relatively easy to test within the hbase codebase. We should add a test class which verifies for users that this logic works. Then it's just up to them to test their own implementation of their HBaseRpcController rather than do the full integration test. Make MetricsConnection scope configurable,13435960,Resolved,Minor,Fixed,26/Mar/22 14:05,22/Apr/22 16:03,,"Currently MetricsConnection scope is just the connection.toString(), which is typically the default toString() implementation for an object. This is not very useful for identifying different connections in processes that might connect to multiple clusters or maintain different connections to the same cluster. We can add a new config param ""hbase.client.metrics.scope"" which defaults to connection.toString()." Misspelling commands in hbase shell will crash the shell,13435215,Resolved,Minor,Fixed,22/Mar/22 23:16,11/Apr/22 08:48,2.4.10,"Misspelling commands in hbase shell will crash the shell, e.g. {noformat} hbase:001:0> hlep NameError: undefined local variable or method `hlep' for # Did you mean?  help                   evaluate at (hbase):1                       eval at org/jruby/RubyKernel.java:1048                   evaluate at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/workspace.rb:85                   evaluate at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/context.rb:380                 eval_input at uri:classloader:/irb/hirb.rb:112              signal_status at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:623                 eval_input at uri:classloader:/irb/hirb.rb:109   each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:246                       loop at org/jruby/RubyKernel.java:1442   each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:232                      catch at org/jruby/RubyKernel.java:1189   each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:231                 eval_input at uri:classloader:/irb/hirb.rb:108                        run at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:428                      catch at org/jruby/RubyKernel.java:1189                        run at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:427                    
at classpath:/jar-bootstrap.rb:221 {noformat}" Bump httpclient from 4.5.3 to 4.5.13,13436473,Resolved,Minor,Fixed,29/Mar/22 16:12,30/Mar/22 22:04,,"Dependabot auto-generated dependency upgrade: https://github.com/apache/hbase/pull/4291 We can't accept the dependabot PR as-is because it causes a unit test failure. Bump the dependency and fix the test by hand. There is a comment in our POM indicating this is a known issue: {noformat} {noformat} Staying back on a version of httpclient with CVE listed vulnerabilities just for this isn't a good option. " Bump bcprov-jdk15on from 1.60 to 1.67,13436470,Resolved,Minor,Fixed,29/Mar/22 16:01,29/Mar/22 16:09,,"Dependabot generated dependency upgrade. https://github.com/apache/hbase/pull/4292" [REST] Client must disable URI normalization,13436478,Resolved,Minor,Won't Fix,29/Mar/22 16:32,29/Mar/22 17:02,,"There is a comment in our POM indicating we cannot upgrade httpclient, which is problematic. {noformat} {noformat} This behavior in httpclient manifests when URI normalization is enabled, which is the default. The client must disable it, Otherwise some required URI constructions for performing various actions against the REST gateway are impossible. " Split TestSnapshotProcedure to several smaller tests,13434426,Resolved,Minor,Fixed,17/Mar/22 18:07,18/Mar/22 15:18,,TestSnapshotProcedure is too big. It's easy to timeout. [Documentation] Point out compatibility issues with WAL Compression and Replication in doc,13434106,Resolved,Minor,Fixed,16/Mar/22 12:37,18/Mar/22 07:34,,"Could see details in HBASE-26849. We had a discuss in dev mail list, and decided to point out this problem in doc." Fix compatibility issues in 2.4.11RC0,13433730,Resolved,Minor,Fixed,14/Mar/22 22:28,14/Mar/22 22:41,,"package org.apache.hadoop.hbase.http SecurityHeadersFilter LimitedPrivate(CONFIG) Removed method: SecurityHeadersFilter.getDefaultParameters ( Configuration conf ) [static] : Map package org.apache.hadoop.hbase.filter RandomRowFilter Public Field random of type java.util.Random has been removed from this class. A client program may be interrupted by NoSuchFieldError exception." Move AsyncProcess configs to HConstants,13433871,Open,Minor,,15/Mar/22 12:39,,,"AsyncProcess has a few public static config constants, but the class itself is package-private so users cannot access them. Moving them to HConstants will make it easier for users to change these settings: {code:java} hbase.client.primaryCallTimeout.multiget hbase.client.start.log.errors.counter hbase.client.log.batcherrors.details hbase.client.log.detail.period.ms {code}" Move ConnectionImplementation public configs to HConstants,13433873,Open,Minor,,15/Mar/22 12:43,,,"ConnectionImplementation has a few public static config constants, but the class itself is package-private so users cannot access them. Moving them to HConstants will make it easier for users to change these settings: {code:java} hbase.client.retries.by.server hbase.resolve.hostnames.on.failure {code} Note: AsyncConnectionImpl also separately defines the second config, so we can unify them both in HConstants." Expose meta lookup configs in HConstants,13433870,Open,Minor,,15/Mar/22 12:37,,,"This makes it easier for clients to set this config in an upgrade-compatible way. In other words, if a future release changes or removes these configs it will be clear to users because imports will break. Otherwise hbase may start silently ignoring these fields: {code:java} hbase.hconnection.meta.lookup.threads.max hbase.hconnection.meta.lookup.threads.core{code}" MultiRowRangeFilter does not appear in hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java,13433515,Resolved,Minor,Works for Me,13/Mar/22 13:25,13/Mar/22 19:50,2.4.4,"You can instantiate a Filter using the REST API. For Instance, the following is the body of the POST request against the REST API  that instantiates a filter list comprised of a RowFilter and a ColumnRangeFilter: {""type"": ""FilterList"", ""op"": ""MUST_PASS_ALL"", ""filters"": [\{""type"": ""RowFilter"", ""op"": ""EQUAL"", ""comparator"": {""type"": ""BinaryComparator"", ""value"": ""Rm1vYy1BbGFuaW5lLU5lZ2F0aXZlLUNFLVJhbXAtRm1vYy1BbGFuaW5lIFtNLUhdLS0wMDAwMDAwMDA5NDk5""}}, \{""type"": ""ColumnRangeFilter"", ""minColumn"": ""MDAwNTAuMDI2OTA="", ""minColumnInclusive"": true, ""maxColumn"": ""MDA1MDAuMDI2OTA="", ""maxColumnInclusive"": true}]} However, it seems impossible to do that with a MultiRowRangeFilter (using the REST API). Upon closer look, this class does not seem to appear in the ParseFilter class (hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java). It is completely missing." Bump dependencies in /dev-support/git-jira-release-audit,13432945,Resolved,Minor,Fixed,09/Mar/22 19:37,10/Mar/22 20:26,,"Bumps urllib3 from 1.25.8 to 1.26.5 to resolve two dependabot warnings - CRLF injection (Moderate) urllib3 (pip) · dev-support/git-jira-release-audit/requirements.txt - Catastrophic backtracking in URL authority parser when passed URL containing many @ characters (High) urllib3 (pip) · dev-support/git-jira-release-audit/requirements.txt Bumps cryptography from 2.8 to 3.3.2 to resolve one dependabot warning - RSA decryption vulnerable to Bleichenbacher timing vulnerability (Moderate) cryptography (pip) · dev-support/git-jira-release-audit/requirements.txt " Implement ScanInfo#toString,13431575,Resolved,Minor,Fixed,02/Mar/22 20:48,05/Mar/22 09:55,,"We don't have ScanInfo#toString. We use ScanInfo while creating StoreScanner which is used in preFlushScannerOpen in co-proc.  " "[HBase-Client] In some cases, no value is obtained using method Result.getValue()",13423935,Resolved,Minor,Not A Problem,21/Jan/22 08:09,21/Feb/22 03:00,2.0.0,"Results are not sorted during the query by Result.getValue(). As a result, existing values cannot be queried. In normal cases, the results by get or scan are sorted and this problem does not occur. However, in some cases, such as when the HFile file is read by MR and the cells obtained are combined as result by rowkey, there is no sorting.  Result.getvalue (byte [] family, byte [] qualifier) is null.     * The test results are shown in the figures !1.png!!2.png![^Test.java]" " In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried",13427413,Open,Minor,,09/Feb/22 08:33,,,"In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried since it only output the hostname of RegionServer" Fix flappy test TestSimpleRegionNormalizerOnCluster.java,13427946,Resolved,Minor,Fixed,11/Feb/22 07:24,13/Feb/22 14:48,1.7.1,"TestSimpleRegionNormalizerOnCluster.java can hang after HBASE-26744 The assumption that order of HTable list is sorted is wrong so depending on that order can cause the test to hang or be inaccurate" "Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain histogram.",13424428,Resolved,Minor,Fixed,24/Jan/22 14:21,09/Feb/22 02:48,1.7.1,"Currently age of last ship metric is an instance of an Histogram type. [Here|https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSourceImpl.java#L58] {quote} ageOfLastShippedOpHist = rms.getMetricsRegistry().getHistogram(SOURCE_AGE_OF_LAST_SHIPPED_OP); {quote} We can change it to TimeHistogram so that we get the range information also. " NPE caused by converting uppercase hostname to lowercase in RegionMover,13425171,Open,Minor,,27/Jan/22 13:57,,2.4.9,"In HBASE-19456, we introduced case-insensitivity feature in RegionMover and converted uppercase hostnames to lowercase hostnames. But this maybe causes that we can't get the rsgroup info of unloading server, because the addresses in hbase are case insensitive. This will make org.apache.hadoop.hbase.util.TestRegionMoverWithRSGroupEnable fail.     2022-01-27T20:53:31,948 INFO [Time-limited test] util.TestRegionMoverWithRSGroupEnable(127): Unloading {*}VM{*}-154-75-centos 2022-01-27T20:53:31,959 INFO [RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=49232] master.MasterRpcServices(3011): rsGroupInfo of {*}vm{*}-154-75-centos:39126 is null 2022-01-27T20:53:31,961 INFO [pool-332-thread-1] util.RegionMover(419): rsgroup of {*}vm{*}-154-75-centos:39126 is null 2022-01-27T20:53:31,961 ERROR [pool-332-thread-1] util.RegionMover(471): Error while unloading regions java.lang.NullPointerException: null at org.apache.hadoop.hbase.util.RegionMover.lambda$unloadRegions$3(RegionMover.java:421) ~[classes/:?] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_292] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_292] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_292] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_292]" Backport HBASE-24443 Refactor TestCustomSaslAuthenticationProvider,13423690,Resolved,Minor,Fixed,20/Jan/22 09:05,20/Jan/22 14:56,,Test execution times for TestCustomSaslAuthenticationProvider on branch-2 takes 24 minutes. The refactored tests after HBASE-24443 on master succeed in just under 2 * 2 minutes. Throw exception if region has same start key when writePartitions use HFileOutputFormat2,13423941,Open,Minor,,21/Jan/22 08:29,,,"Some exception info is not friendly in MapReduce task log such as: {code:java} 2022-01-21 06:23:39,156 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.IllegalArgumentException: Can't read partitions file at org.apache.hadoop.mapreduce.lib.partition.TotalOrderPartitioner.setConf(TotalOrderPartitioner.java:116) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:73) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:133) at org.apache.hadoop.mapred.MapTask$NewOutputCollector.(MapTask.java:719) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:797) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:344) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:169) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1865) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:163) Caused by: java.io.IOException: Wrong number of partitions in keyset at org.apache.hadoop.mapreduce.lib.partition.TotalOrderPartitioner.setConf(TotalOrderPartitioner.java:90) ... 10 more {code} when I write hfile use HFileOutputFormat2 in a MapReduce task. I can not understand what happend to my job. And got some wrong suggestions such as: trucate table or add cancelDeleteOnExit code in my code. Those are useless and stupid.    *The real reason is my table has same start key ,and I didn't find this problem in hbck web ui overlaps list immediately.*  {*}So{*}， I thanks it's a good idea to check same start key in writePartitions(), we can print each same start key  and throw a same start key exception if my table regions has same start key. It is a more friendly exception info than 'Can't read partitions file'. Here is my code  [https://github.com/Mengqi777/hbase/commit/d8dc093695d02cfb16ba303389de9f7cef778ee1] May I create a pull request ?              " Throw exception if region has same start key when writePartitions use HFileOutputFormat2,13423942,Resolved,Minor,Duplicate,21/Jan/22 08:29,21/Jan/22 08:31,,"Some exception info is not friendly in MapReduce task log such as: {code:java} 2022-01-21 06:23:39,156 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.IllegalArgumentException: Can't read partitions file at org.apache.hadoop.mapreduce.lib.partition.TotalOrderPartitioner.setConf(TotalOrderPartitioner.java:116) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:73) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:133) at org.apache.hadoop.mapred.MapTask$NewOutputCollector.(MapTask.java:719) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:797) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:344) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:169) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1865) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:163) Caused by: java.io.IOException: Wrong number of partitions in keyset at org.apache.hadoop.mapreduce.lib.partition.TotalOrderPartitioner.setConf(TotalOrderPartitioner.java:90) ... 10 more {code} when I write hfile use HFileOutputFormat2 in a MapReduce task. I can not understand what happend to my job. And got some wrong suggestions  via google/baidu such as: trucate table or add cancelDeleteOnExit code in my code. Those are useless and stupid.    *The real reason is my table has same start key ,and I didn't find this problem in hbck web ui overlaps list immediately.*  {*}So{*}， I thanks it's a good idea to check same start key in writePartitions(), we can print each same start key  and throw a same start key exception if my table regions has same start key. It is more friendly exception info than 'Can't read partitions file'. Here is my code  [https://github.com/Mengqi777/hbase/commit/d8dc093695d02cfb16ba303389de9f7cef778ee1] can I create a pull request ?              " Throw exception if region has same start key when writePartitions use HFileOutputFormat2,13423943,Resolved,Minor,Duplicate,21/Jan/22 08:29,21/Jan/22 08:31,,"Some exception info is not friendly in MapReduce task log such as: {code:java} 2022-01-21 06:23:39,156 WARN [main] org.apache.hadoop.mapred.YarnChild: Exception running child : java.lang.IllegalArgumentException: Can't read partitions file at org.apache.hadoop.mapreduce.lib.partition.TotalOrderPartitioner.setConf(TotalOrderPartitioner.java:116) at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:73) at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:133) at org.apache.hadoop.mapred.MapTask$NewOutputCollector.(MapTask.java:719) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:797) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:344) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:169) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1865) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:163) Caused by: java.io.IOException: Wrong number of partitions in keyset at org.apache.hadoop.mapreduce.lib.partition.TotalOrderPartitioner.setConf(TotalOrderPartitioner.java:90) ... 10 more {code} when I write hfile use HFileOutputFormat2 in a MapReduce task. I can not understand what happend to my job. And got some wrong suggestions such as: trucate table or add cancelDeleteOnExit code in my code. Those are useless and stupid.    *The real reason is my table has same start key ,and I didn't find this problem in hbck web ui overlaps list immediately.*  {*}So{*}， I thanks it's a good idea to check same start key in writePartitions(), we can print each same start key  and throw a same start key exception if my table regions has same start key. It is more friendly exception info than 'Can't read partitions file'. Here is my code  [https://github.com/Mengqi777/hbase/commit/d8dc093695d02cfb16ba303389de9f7cef778ee1|https://github.com/Mengqi777/hbase/commit/d8dc093695d02cfb16ba303389de9f7cef778ee1],] can I create a pull request ?              " Account for HBASE-24500 in regionInfoMismatch tool,13423593,Resolved,Minor,Fixed,19/Jan/22 19:14,20/Jan/22 00:55,,"Had a coworker try to use the RegionInfoMismatch tool I added in HBASE-26656. Curiously, the tool failed on the sanity check I added. {noformat} Aborting: sanity-check failed on updated RegionInfo. Expected encoded region name 736ee6186975de6967cd9e9e242423f0 but got 323748c77dde5b05982df0285b013232. Incorrectly created RegionInfo was: {ENCODED => 323748c77dde5b05982df0285b013232, NAME => 'test4,,1642405560420_0002.323748c77dde5b05982df0285b013232.', STARTKEY => '', ENDKEY => ''} {noformat} I couldn't understand why the tool wasn't working until I hooked up a debugger and realized that the problem wasn't in my code :). The version of HBase on the system did not have the fix from HBASE-24500 included which meant that I was hitting the same ""strange behavior"", as Duo put it, in the RegionInfoBuilder ""copy constructor"". While the versions of HBase which do not have this fix are EOL in terms of Apache releases, we can easily work around this in operator-tools (which may be used by any hbase 2.x release still in the wild)." Misspellings of hbck usage,13422738,Resolved,Minor,Fixed,14/Jan/22 13:05,16/Jan/22 08:47,,"In the manual of hbck, option cleanReplicationBarrier is spelled cleanReplicationBrarier " The threadGroup.destroy in ProcedureExecutor.join fails in some tests,13422758,Open,Minor,,14/Jan/22 15:31,,,"Always see it dumps the threads in the group to stdout. This is an example {noformat} java.lang.ThreadGroup[name=PEWorkerGroup,maxpri=10] Thread[HFileArchiver-1,5,PEWorkerGroup] {noformat} I guess the problem is that we create a thread pool when executing a procedure so the thread pool will inherit the thread group. Not a big problem but still a bit nasty..." Unintuitive AccesControlClient.getUserPermissions() semantics,13421233,Open,Minor,,07/Jan/22 07:39,,,"The behaviour of the AccesControlClient.getUserPermissions() calls is unintuitive. It takes a tablename regex, and return the union of all permissinons on all tables that it matches. While the returned UserPermission objects do have the information on the object they apply to, this still requires post-processing the results. To get the permissions for a single table, one has to either do something like {code:java} Admin.getTablePermission(conn, ""^"" + tableName.getNameWithNamespaceInclAsString() + ""$"") {code} or post-process the results of the call. We should add some methods that return the permission for a single table / family / qualifier without making the caller jump though hoops, or at least call out the non-intuitive behavior in the Javadoc, and advise on how to use the API to get the results the caller likely wants. " [Documentation] Correct description of WAL directory ,13426884,Resolved,Trivial,Fixed,07/Feb/22 10:11,18/Feb/22 14:22,2.4.9,"h3. [Write Ahead Log (WAL)|https://hbase.apache.org/book.html#purpose.wal] {quote}The WAL resides in HDFS in the _/hbase/WALs/_ directory, with subdirectories per region. {quote} The subdirectory should belong to RegionServer." KafkaProxy enablePeer parameter mismatch,13424321,Resolved,Trivial,Fixed,24/Jan/22 10:04,03/Oct/24 08:06,,"In KafkaProxy class, enable peer by setting ""e"" {code:java} options.addOption(""e"", ""enablepeer"", false, ""enable peer on startup (defaults to false)""); {code} but it actually uses ""a"": {code:java} if (commandLine.hasOption('a')){ createPeer=true; } if (commandLine.hasOption(""a"")){ enablePeer=true; }{code}" Proper bulk load tracking,13600308,Open,Critical,,28/Nov/24 13:10,,2.6.0,"As part of the incremental backup mechanism, HBase tracks which files were bulk-loaded (since the last backup). This data is stored in the backup:system_bulk table. Entries are added when a bulk load occurs through the BackupObserver co-processor. Entries are deleted when an incremental backup is completed. There are 2 flaws in this implementation: 1) Performing a full backup should clear the list. Imagine following scenario: * Create a full backup B1 of table T. * Perform a bulk load L1. * Take a full backup B2 of table T. * Take an incremental backup of table T. ** The data stored for this backup will include L1, even though that data is already present due to B2. (This is an inefficiency, not a real error.) 2) Performing a table deletion should clear the list of bulk-loaded files. Imagine the following scenario: * Create a full backup of table T. * Perform a bulk-load B1 into T. * Disable, delete and recreate T. * Create an incremental backup (taking a full backup instead is similar to the previous case) ** The backup will contain B1, even though it doesn't belong there.   Note that this *can also cause backup corruption* after a backup restores (which is how we encountered this issue), which makes this problem less niche than the above scenarios indicate. Backup restore effectively uses bulk loads as well, so users could run into following scenario, where they are trying to restore data corruption: * (create an environment with backup B1 (time t), backup B2 (time t2 > t). * Users notice data corruption, and restore backup B2 after clearing the table * Users notice data corruption is already present, and restore backup B1 after clearing the table. * Users find data corruption solved, and resume regular backup cycle from here on. ** Any incremental backup taken will contain the (possible corrupt) data from B2 (due to the restore operation using bulk operations). The backups will be affected until a FULL backup is taken after an incremental backup (so this could span a period of weeks assuming bi-weekly/monthly full backups). A minimal reproduction example: {code:java} echo ""create 'table', 'cf'; put 'table', 'row1', 'cf:a', 'value1', 1400523142819"" | bin/hbase shell -n bin/hbase backup create full file:/tmp/backup -t table -i echo ""disable 'table'; drop 'table'"" | bin/hbase shell -n # Empty echo ""scan 'backup:system_bulk'"" | bin/hbase shell -n bin/hbase restore file:/tmp/backup backup_1732787972748 -t ""table"" # 1 entry echo ""scan 'backup:system_bulk'"" | bin/hbase shell -n echo ""disable 'table'; drop 'table'"" | bin/hbase shell -n # 1 entry echo ""scan 'backup:system_bulk'"" | bin/hbase shell -necho ""create 'table', 'cf'; put 'table', 'row1', 'cf:b', 'value2', 1400523142819"" | bin/hbase shell -n bin/hbase backup create full file:/tmp/backup -t table -i echo ""scan 'backup:system_bulk'"" | bin/hbase shell -n echo ""put 'table', 'row1', 'cf:b', 'value3', 1400523142819"" | bin/hbase shell -n bin/hbase backup create incremental file:/tmp/backup -t table -i # Emtpy echo ""scan 'backup:system_bulk'"" | bin/hbase shell -n echo ""disable 'table'; drop 'table'"" | bin/hbase shell -n bin/hbase restore file:/tmp/backup backup_1732788098586 -t ""table"" # Will contain ""value1"" (unexpected) and ""value3"" (expected) echo ""scan 'table'"" | bin/hbase shell -n {code}" "When StoreFileTracker is FILE, unable to recognize StoreFileListFile after upgrade from 2.5 to 2.6",13601221,Resolved,Critical,Fixed,06/Dec/24 21:49,23/Dec/24 10:05,2.5.10,"h1. Symptoms After upgrading from HBase 2.5.10 to HBase 2.6.1, I observed an inconsistent read across versions. Before the upgrade, I created a table with one row. Invoking a count command returns 1. After upgrading to 2.6.1, execute the same count command, it returns 0. {code:java} count 'test' Old Version Result: 1 row(s) Took 0.5582 seconds => 1 New Version Result: 0 row(s) Took 1.4439 seconds => 0 {code} h1. Reproduce It can be reproduced deterministically with the following steps Step1: Start up the HBase cluster in 2.5.10 and execute the following commands {code:java} create 'test', 'cf', CONFIGURATION => {'hbase.store.file-tracker.impl' => 'FILE'} put 'test', 'row', 'cf:q', 'value'{code} Step2: Execute the count command in the old version {code:java} count 'test' 1 row(s) Took 0.5582 seconds => 1 {code} Step3: Stop the entire cluster, upgrade to 2.6.1 and execute the same count command {code:java} count 'test' 0 row(s) Took 0.0842 seconds => 0{code} h1. Analysis The names of {{StoreFileListFile}} differ between the two versions: * In 2.5.10: {{f1}} or {{f2}} * In 2.6.1: {{{}f1.{timestamp{}}}} or {{{}f2.{timestamp{}}}} The addition of a timestamp to the file name was introduced in HBASE-26791. It can be resolved by handling missing timestamps by setting them to 0. However, in the case of downgrading versions, the above approach does not work. A workaround is available: * Change the storefile tracker implementation from {{FILE}} > {{MIGRATION > DEFAULT}} before downgrading." Static resources are not loaded on REST web UI pages in dev mode,13599371,Patch Available,Major,,20/Nov/24 11:38,,2.5.11,"The HBase REST server component has a web UI (exposes an info servlet on the hbase.rest.info.port, default: 8085).   While working on HBASE-28832 noticed that with the git cloned project, started REST server, on these  REST web UI pages the static resources (images, CSS, JS files) are not loaded (server responds with HTTP 404 Not Found).    !image-2024-11-20-12-38-16-447.png|width=453,height=323!   In the downloaded HBase 2.5.9 distribution (production release) this was still working: !screenshot-1.png|width=543,height=228!" Phase 1: Enhance the full backup command to support continuous backups by introducing an additional flag,13601594,In Progress,Major,,10/Dec/24 18:23,,2.6.0, Enhancing WALPlayer for Continuous Backup Capabilities,13599532,In Progress,Major,,21/Nov/24 12:26,,2.6.0,"*Add Support for Bulk-Loaded Files in WALPlayer* Currently, WALPlayer lacks support for bulk-loaded files. We need to add functionality to handle bulk-loaded files both during the batching of WALs to generate HFiles and while replaying the WALs" Port HBASE-26932 to branch-3,13599496,Resolved,Major,Fixed,21/Nov/24 07:43,28/Feb/25 16:11,,"HBASE-26932 is landed before branch-3 is cut, we should include it in branch-3 too." Developing a Custom ReplicationEndpoint to Support External Storage Integration,13599530,In Progress,Major,,21/Nov/24 12:12,,2.6.0,"*Develop a Custom Replication Endpoint* Implement a custom replication endpoint to support the backup of WALs to external storage systems, such as HDFS-compliant storages (including HDFS, S3, ADLS, and GCS via respective Hadoop connectors). *Support for Bulk-loaded Files* Add functionality to back up bulk-loaded files in addition to regular WALs. *Ensure Process Durability* Ensure the backup process is durable, with no WALs being missed, even in the event of issues in the cluster." Implement Custom ReplicationEndpoint to Enable WAL Backup to External Storage,13599770,Resolved,Major,Fixed,23/Nov/24 10:01,28/Feb/25 14:36,, Incremental backup test missing explicit test for bulkloads,13594357,Open,Major,,04/Oct/24 19:36,,,"Our incremental backup tests don't explicitly test our ability to backup and restore bulkloads. It'd be nice to have this to verify bulkloads work in the context of the backup/restore flow, and to avoid regressions in the future" Alter table causes AccessDeniedException at the client side,13599462,In Progress,Major,,21/Nov/24 02:41,,2.4.16,"When altering a table there is a chance that the client catches some AccessDeniedExceptions:     {code:java} #444021290, table=***, attempt=1/5 failed=1ops, last exception: org.apache.hadoop.hbase.security.AccessDeniedException: org.apache.hadoop.hbase.security.AccessDeniedException: Insufficient permissions (user=***, scope=default:***, family=***, params=[table=***,family=***],action=WRITE)     at org.apache.hadoop.hbase.security.access.AccessController.prePut(AccessController.java:1388)     at org.apache.hadoop.hbase.coprocessor.RegionObserver.prePut(RegionObserver.java:413)     at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$23.call(RegionCoprocessorHost.java:907)     at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$23.call(RegionCoprocessorHost.java:904)     at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:558)     at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:631)     at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.prePut(RegionCoprocessorHost.java:904)     at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.callPreMutateCPHook(HRegion.java:4160)     at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.access$800(HRegion.java:3610)     at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation$1.visit(HRegion.java:3685)     at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3218)     at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.checkAndPrepare(HRegion.java:3674)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4447)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4380)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:1009)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:927)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:892)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2855)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45008)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:387)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:132)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349) {code}     This is because HBase updates the table owner when a table is altered. By updating the table, ZKPermissionWatcher receives the permission changes and tries to update the permission cache in AuthManager:   [https://github.com/apache/hbase/blob/rel/2.4.16/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AuthManager.java#L185-L192] {code:java}   private void updateTableCache(TableName table, ListMultimap tablePerms) {     PermissionCache cacheToUpdate =       tableCache.getOrDefault(table, new PermissionCache<>());     clearCache(cacheToUpdate);     updateCache(tablePerms, cacheToUpdate);     tableCache.put(table, cacheToUpdate);     mtime.incrementAndGet();   } {code}   At the same time, AccessController is accessing the same reference of the permission cache in AuthManager: [https://github.com/apache/hbase/blob/rel/2.4.16/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AuthManager.java#L298-L319] {code:java}   public boolean accessUserTable(User user, TableName table, Permission.Action action) {     if (user == null) {       return false;     }     if (table == null) {       table = PermissionStorage.ACL_TABLE_NAME;     }     if (authorizeUserNamespace(user, table.getNamespaceAsString(), action)) {       return true;     }     PermissionCache tblPermissions =       tableCache.getOrDefault(table, TBL_NO_PERMISSION);     if (hasAccessTable(tblPermissions.get(user.getShortName()), action)) {       return true;     }     for (String group : user.getGroupNames()) {       if (hasAccessTable(tblPermissions.get(AuthUtil.toGroupEntry(group)), action)) {         return true;       }     }     return false;   } {code}   I think this is a bug introduced in the previous refactoring: https://issues.apache.org/jira/browse/HBASE-21255    " Replace some deprecated calls,13601645,Resolved,Major,Fixed,11/Dec/24 07:45,20/Feb/25 09:24,4.0.0-alpha-1,"While working on https://issues.apache.org/jira/browse/HBASE-28832 I noticed that there are several calls to deprecated methods. * {{java.net.URLEncoder.encode()}} - Deprecated. The resulting string may vary depending on the platform's default encoding. Instead, use the encode(String,String) method to specify the encoding. * java.net.URLEncoder.encode(String) -> java.net.URLEncoder.encode(String, Charset) * org.apache.hadoop.util.StringUtils.humanReadableInt(long) -> org.apache.hadoop.util.StringUtils.TraditionalBinaryPrefix.long2String(long, """", 1) * org.apache.hadoop.fs.FileSystem.getLength(Path) -> getFileStatus(Path).getLen() * org.apache.hadoop.hbase.ServerName.getStartcode() -> org.apache.hadoop.hbase.ServerName.getStartCode() These will not be replaced as we'd need to add commons-text dependency which was decided no to do (see PR): * {{org.apache.commons.lang3.StringEscapeUtils.escapeHtml4()}} - Deprecated As of 3.6, use Apache Commons Text [StringEscapeUtils|https://commons.apache.org/proper/commons-text/javadocs/api-release/org/apache/commons/text/StringEscapeUtils.html] instead * {{org.apache.commons.lang3.StringEscapeUtils.escapeXml()}} - Deprecated As of 3.6, use Apache Commons Text [StringEscapeUtils|https://commons.apache.org/proper/commons-text/javadocs/api-release/org/apache/commons/text/StringEscapeUtils.html] instead" Soft drop for destructive table actions,13595719,Open,Major,,16/Oct/24 18:34,,,"When we administratively drop a table column or entire table, or truncate a table, the process begins rapidly. Procedures are scheduled for immediate execution that then modify or remove descriptors and state in META and on disk, and take unrecoverable actions at the HDFS layer. Although HFiles are copied to the archive in a destructive action, recovery scenarios are not automatic and involve some operator labor to reconstruct the table and re-import the archived data. If the HFileCleaner is not properly configured to facilitate such recovery then some data is not recoverable soon after procedure execution commences and all affected data is not recoverable within minutes. A customer faced with such an accident will be unhappy because the recovery scenarios available to them from this will involve either a restore from backup or from an earlier snapshot, and any changes committed more recently than the time of the last backup or last snapshot will be lost.  An effective solution is very simple: We can easily prevent the deletion of the HFiles of a deleted table or table column family by taking a snapshot of the table immediately prior to taking any destructive actions. We set a TTL on the snapshot so housekeeping of truly unwanted HFiles remains no touch. Because we take a table snapshot all table structure and metadata is also captured and saved so fast recovery is possible, as either a restore from snapshot, or a clone from snapshot to a new table. For as long as the snapshot is retained it is straightforward to recover the table data by either restoring the table from the snapshot or cloning the snapshot to a new table, at the operator’s discretion. No manual actions are required to see the table or column family (or families) truly dropped. Once the snapshot TTL expires all the HFiles related to the dropped table become eligible for deletion. When the HFileCleaner chore executes after that time the HDFS level file deletes will commence with associated reduction in storage requirements.  Design document is attached.  I have a *working implementation* of this proposal based on a fork of branch-2.5. " RSMobFileCleanerChore may close the StoreFileReader object which is being used by Compaction thread,13597615,Resolved,Major,Fixed,04/Nov/24 12:33,06/Jan/25 08:42,2.5.10,"For MOB table, RSMobFileCleanerChore is responsible for cleaning MOB files that are no longer referebced by the region located in the current RegionServer. RSMobFileCleanerChore get the  the information of MOB files by reading the storefile, as fallow. ```java // RSMobFileCleanerChore.chore() sf.initReader(); byte[] mobRefData = sf.getMetadataValue(HStoreFile.MOB_FILE_REFS); byte[] bulkloadMarkerData = sf.getMetadataValue(HStoreFile.BULKLOAD_TASK_KEY); // close store file to avoid memory leaks sf.closeStoreFile(true); ``` There is an issue in here, if the StoreFileReader was not created by RSMobFileCleanerChore, but RSMobFileCleanerChore closed it, which will cause the thread that created the object to be unusable, resuting ERROR finally.   Reproduction: This is an occasional problem, but the probability of its occurrence can be increased by making the following modifications. 1. Setting hbase.master.mob.cleaner.period from 24h to 10s, and restart hbase. 2. Puting some mob data into a MOB table. 3. At the same time, executing compaction command for the MOB table, and it is possible that this problem may occur.   The error logs as follow. ERROR: java.io.IOException: Cannot invoke ""org.apache.hadoop.hbase.regionserver.StoreFileReader.getMaxTimestamp()"" because the return value of ""org.apache.hadoop.hbase.regionserver.HStoreFile.getReader()"" is null         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:512)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) Caused by: java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.hbase.regionserver.StoreFileReader.getMaxTimestamp()"" because the return value of ""org.apache.hadoop.hbase.regionserver.HStoreFile.getReader()"" is null         at org.apache.hadoop.hbase.regionserver.DefaultStoreFileManager.lambda$getUnneededFiles$3(DefaultStoreFileManager.java:235)" "Introduce ""pitr"" Command for Point-in-Time Recovery/Restore",13599538,In Progress,Major,,21/Nov/24 12:39,,2.6.0,"The PITR command restores table data to a specific point in time using a combination of full backups, incremental backups, and WALs. If no end time is specified, it defaults to the current time. {*}Command{*}: {code:java} $ hbase pitr [-t ]  [-s ]  [-q ]  [-c]  [-m ]  [-o] [--to-datetime ] {code} {*}Options{*}: * -to-datetime : _(Optional)_ Specifies the end time for restoration. Defaults to the current time if not provided.   {*}Description{*}: * For each specified table: * Locate the most recent full backup taken before the -to-datetime. * Apply the full backup, followed by all incremental backups up to the specified point. * Replay the WALs to bring the data to the exact state as of -to-datetime." "POC: Ensure Continuous Backup Durability with No Missed WALs, Even During Cluster Issues",13600831,Resolved,Major,Implemented,04/Dec/24 05:19,18/Feb/25 09:32,,"This task focuses on ensuring the durability of the continuous backup process for WALs, even during cluster issues, as part of implementing a custom replication endpoint for backing up WALs and bulk-loaded files to external storage systems." WAL Split Delays Due to Concurrent WAL Splitting During worker RS Abort,13597446,In Progress,Major,,01/Nov/24 11:45,,2.5.8,"When a worker RS gets aborted after the SplitWALRemoteProcedure got dispatched, RegionServerTracker takes care of it and [aborts the pending Operation|https://github.com/apache/hbase/blob/rel/2.5.8/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java#L160] on the aborting region as part of [expireServer|https://github.com/apache/hbase/blob/rel/2.5.8/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionServerTracker.java#L172].  It did help the parent procedure, SplitWalProcedure, to choose another worker RS but the aborting RS is also splitting the WAL. Now while creating the recovered edits both will try to write the same file. One RS that starts late for the file deletes the previous file that cause failures.  h4. Logs -  region server tracker marking the remove procedure failed {code:java} 2024-10-01 23:02:32,274 WARN [RegionServerTracker-0] procedure.SplitWALRemoteProcedure - Sent hdfs://hbase1a/hbase/WALs/regionserver-33.regionserver.hbase.,XXXXX,1727362162836-splitting/regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172 to wrong server regionserver-283.regionserver.hbase.,XXXXX,1727420096936, try another org.apache.hadoop.hbase.DoNotRetryIOException: server not online regionserver-283.regionserver.hbase.,XXXXX,1727420096936 at org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.abortPendingOperations(RSProcedureDispatcher.java:163) at org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.abortPendingOperations(RSProcedureDispatcher.java:61) at org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher$BufferNode.abortOperationsInQueue(RemoteProcedureDispatcher.java:417) at org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher.removeNode(RemoteProcedureDispatcher.java:201) at org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.serverRemoved(RSProcedureDispatcher.java:176) at org.apache.hadoop.hbase.master.ServerManager.lambda$expireServer$2(ServerManager.java:576) at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:647) at org.apache.hadoop.hbase.master.ServerManager.expireServer(ServerManager.java:576) at org.apache.hadoop.hbase.master.ServerManager.expireServer(ServerManager.java:530) at org.apache.hadoop.hbase.master.RegionServerTracker.processAsActiveMaster(RegionServerTracker.java:172) at org.apache.hadoop.hbase.master.RegionServerTracker.refresh(RegionServerTracker.java:206) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750){code} {code:java} 2024-10-01 23:02:32,340 INFO [PEWorker-21] procedure2.ProcedureExecutor - Finished pid=122448609, ppid=122448595, state=SUCCESS; SplitWALRemoteProcedure regionserver-33.regionserver.hbase.,XXXXX%2C1727362162836.1727822221172, worker=regionserver-283.regionserver.hbase.,XXXXX,1727420096936 in 54.0500 sec{code} Parent SplitWalProcedure will create another RemoteProcedure for this  {code:java} 2024-10-01 23:02:32,726 WARN [PEWorker-17] procedure.SplitWALProcedure - Failed to split wal hdfs://hbase1a/hbase/WALs/regionserver-33.regionserver.hbase.,XXXXX,1727362162836-splitting/regionserver-33.regionserver.hbase.,XXXXX%2C1727362162836.1727822221172 by server regionserver-283.regionserver.hbase.,XXXXX,1727420096936, retry...{code} {code:java} 2024-10-01 23:02:39,414 INFO [PEWorker-28] procedure2.ProcedureExecutor - Initialized subprocedures=[{pid=122452821, ppid=122448595, state=RUNNABLE; SplitWALRemoteProcedure regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172, worker=regionserver-323.regionserver.hbase.,XXXXX,1727308912906}]{code} Splitting still in progress on dying rs  {code:java} 2024-10-01 23:02:45,652 INFO [G_REPLAY_OPS-regionserver/regionserver-283:XXXXX-0] wal.WALSplitter - Splitting hdfs://hbase1a/hbase/WALs/regionserver-33.regionserver.hbase.,XXXXX,1727362162836-splitting/regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172, size=128.1 M (134313407bytes){code} rs-323 creating recovered edits {code:java} 2024-10-01 23:02:42,876 INFO [OPS-regionserver/regionserver-323:XXXXX-5-Writer-2] monitor.StreamSlowMonitor - New stream slow monitor 0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp{code} {code:java} 2024-10-01 23:02:43,171 INFO [OPS-regionserver/regionserver-323:XXXXX-5-Writer-2] wal.RecoveredEditsOutputSink - Creating recovered edits writer path=hdfs://hbase1a/hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp{code} rs-283 deletes the above files and again creates the file  {code:java} 2024-10-01 23:02:50,520 WARN [OPS-regionserver/regionserver-283:XXXXX-0-Writer-2] wal.RecoveredEditsOutputSink - Found old edits file. It could be the result of a previous failed split attempt. Deleting hdfs://hbase1a/hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp, length=0{code} {code:java} 2024-10-01 23:02:50,794 INFO [OPS-regionserver/regionserver-283:XXXXX-0-Writer-2] monitor.StreamSlowMonitor - New stream slow monitor 0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp{code} {code:java} 2024-10-01 23:02:51,135 INFO  [OPS-regionserver/regionserver-283:XXXXX-0-Writer-2] wal.RecoveredEditsOutputSink - Creating recovered edits writer path=hdfs://hbase1a/hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp{code} Now rs 323 will start failing  {code:java} 2024-10-01 23:03:02,137 WARN  [Thread-1081409] hdfs.DataStreamer - DataStreamer Exception java.io.FileNotFoundException: File does not exist: /hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.hbase1a.hbase.core2.aws-prod5-uswest2.aws.sfdc.is%2C60020%2C1727362162836.1727822221172.temp (inode 1440741238) [Lease.  Holder: DFSClient_NONMAPREDUCE_-2039838105_1, pending creates: 21]     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:3103)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.analyzeFileState(FSDirWriteFileOp.java:610)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.validateAddBlock(FSDirWriteFileOp.java:171)     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2977)     at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:912)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:595)     at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:618)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573)     at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1227)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1105)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1028)     at java.security.AccessController.doPrivileged(Native Method)     at javax.security.auth.Subject.doAs(Subject.java:422)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)     at org.apache.hadoop.ipc.Server$Handler.run(Server.java:3060)     at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)     at java.lang.reflect.Constructor.newInstance(Constructor.java:423)     at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:121)     at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:88)     at org.apache.hadoop.hdfs.DFSOutputStream.addBlock(DFSOutputStream.java:1091)     at org.apache.hadoop.hdfs.DataStreamer.locateFollowingBlock(DataStreamer.java:1939)     at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForCreate(DataStreamer.java:1734)     at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:717) Caused by: org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.hbase1a.hbase.core2.aws-prod5-uswest2.aws.sfdc.is%2C60020%2C1727362162836.1727822221172.temp (inode 1440741238) [Lease.  Holder: DFSClient_NONMAPREDUCE_-2039838105_1, pending creates: 21]     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:3103)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.analyzeFileState(FSDirWriteFileOp.java:610)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.validateAddBlock(FSDirWriteFileOp.java:171)     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2977)     at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:912)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:595)     at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:618)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573)     at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1227)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1105)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1028)     at java.security.AccessController.doPrivileged(Native Method)     at javax.security.auth.Subject.doAs(Subject.java:422)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)     at org.apache.hadoop.ipc.Server$Handler.run(Server.java:3060)     at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1567)     at org.apache.hadoop.ipc.Client.call(Client.java:1513)     at org.apache.hadoop.ipc.Client.call(Client.java:1410)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:258)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:139)     at com.sun.proxy.$Proxy18.addBlock(Unknown Source)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.lambda$addBlock$11(ClientNamenodeProtocolTranslatorPB.java:495)     at org.apache.hadoop.ipc.internal.ShadedProtobufHelper.ipc(ShadedProtobufHelper.java:160)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.addBlock(ClientNamenodeProtocolTranslatorPB.java:495)     at sun.reflect.GeneratedMethodAccessor247.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:433)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:166)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:158)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:96)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:362)     at com.sun.proxy.$Proxy19.addBlock(Unknown Source)     at sun.reflect.GeneratedMethodAccessor247.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:361)     at com.sun.proxy.$Proxy20.addBlock(Unknown Source)     at sun.reflect.GeneratedMethodAccessor247.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:361)     at com.sun.proxy.$Proxy20.addBlock(Unknown Source)     at org.apache.hadoop.hdfs.DFSOutputStream.addBlock(DFSOutputStream.java:1088)   ... 3 more {code} {code:java} 2024-10-01 23:03:02,143 ERROR [split-log-closeStream-pool-1] wal.RecoveredEditsOutputSink - Could not close recovered edits at hdfs://hbase1a/hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp java.io.FileNotFoundException: File does not exist: /hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp (inode 1440741238) [Lease.  Holder: DFSClient_NONMAPREDUCE_-2039838105_1, pending creates: 21]     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:3103)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.analyzeFileState(FSDirWriteFileOp.java:610)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.validateAddBlock(FSDirWriteFileOp.java:171)     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2977)     at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:912)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:595)     at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:618)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573)     at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1227)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1105)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1028)     at java.security.AccessController.doPrivileged(Native Method)     at javax.security.auth.Subject.doAs(Subject.java:422)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)     at org.apache.hadoop.ipc.Server$Handler.run(Server.java:3060)    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)     at java.lang.reflect.Constructor.newInstance(Constructor.java:423)     at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:121)     at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:88)     at org.apache.hadoop.hdfs.DFSOutputStream.addBlock(DFSOutputStream.java:1091)     at org.apache.hadoop.hdfs.DataStreamer.locateFollowingBlock(DataStreamer.java:1939)     at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForCreate(DataStreamer.java:1734)     at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:717) Caused by: org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /hbase/data/default/SEARCH.REPLAY_ID_BATCH_INDEX_START_INDEX/d3be13a8187ff35746fff1def4f4dba4/recovered.edits/0000000000007468971-regionserver-33.regionserver.hbase.%2CXXXXX%2C1727362162836.1727822221172.temp (inode 1440741238) [Lease.  Holder: DFSClient_NONMAPREDUCE_-2039838105_1, pending creates: 21]     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:3103)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.analyzeFileState(FSDirWriteFileOp.java:610)     at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.validateAddBlock(FSDirWriteFileOp.java:171)     at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2977)     at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:912)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:595)     at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:618)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573)     at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1227)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1105)     at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1028)     at java.security.AccessController.doPrivileged(Native Method)     at javax.security.auth.Subject.doAs(Subject.java:422)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)     at org.apache.hadoop.ipc.Server$Handler.run(Server.java:3060)    at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1567)     at org.apache.hadoop.ipc.Client.call(Client.java:1513)     at org.apache.hadoop.ipc.Client.call(Client.java:1410)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:258)     at org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:139)     at com.sun.proxy.$Proxy18.addBlock(Unknown Source)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.lambda$addBlock$11(ClientNamenodeProtocolTranslatorPB.java:495)     at org.apache.hadoop.ipc.internal.ShadedProtobufHelper.ipc(ShadedProtobufHelper.java:160)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.addBlock(ClientNamenodeProtocolTranslatorPB.java:495)     at sun.reflect.GeneratedMethodAccessor247.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:433)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:166)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:158)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:96)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:362)     at com.sun.proxy.$Proxy19.addBlock(Unknown Source)     at sun.reflect.GeneratedMethodAccessor247.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:361)     at com.sun.proxy.$Proxy20.addBlock(Unknown Source)     at sun.reflect.GeneratedMethodAccessor247.invoke(Unknown Source)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:361)     at com.sun.proxy.$Proxy20.addBlock(Unknown Source)     at org.apache.hadoop.hdfs.DFSOutputStream.addBlock(DFSOutputStream.java:1088) {code}   Some more info that needs to be noted is - the aborting RS starts splitting a little late. I am adding one such case below. rs-219 is aborting one and rs-216 is the second worker. The aborting rs started 50 the second late from the second worker although aborting rs was the one who got the RPC request first. {code:java} 2024-10-01 23:02:15,499 INFO [G_REPLAY_OPS-regionserver/regionserver-216:XXXXX-3] wal.WALSplitter - Splitting hdfs://hbase1a/hbase/WALs/regionserver-150.regionserver.hbase.<>,XXXXX,1727347097348-splitting/regionserver-150.regionserver.hbase.<>%2CXXXXX%2C1727347097348.1727823118024, size=92 (92bytes){code} {code:java} 2024-10-01 23:03:05,793 INFO [G_REPLAY_OPS-regionserver/regionserver-219:XXXXX-1] wal.WALSplitter - Splitting hdfs://hbase1a/hbase/WALs/regionserver-150.regionserver.hbase.<>,XXXXX,1727347097348-splitting/regionserver-150.regionserver.hbase.<>%2CXXXXX%2C1727347097348.1727823118024, size=93.4 M (97950842bytes){code} {code:java} 2024-10-01 23:03:15,405 INFO [G_REPLAY_OPS-regionserver/regionserver-216:XXXXX-3] wal.WALSplitter - Splitting hdfs://hbase1a/hbase/WALs/regionserver-150.regionserver.hbase.<>,XXXXX,1727347097348-splitting/regionserver-150.regionserver.hbase.<>%2CXXXXX%2C1727347097348.1727823118024, size=93.4 M (97950842bytes){code}" Abort RS if unable to sync internal markers.,13596382,Open,Major,,22/Oct/24 21:30,,2.5.8,"RS kept on running even if it was unable to write replication marker for 5 minutes. But this issue is not specific to just replication marker. It applies to compaction marker as well as region event marker (like open, close). Sample exception trace: {noformat} 2024-10-09 10:12:21,659 ERROR [regionserver/regionserver-33:60020.Chore.3] regionserver.ReplicationMarkerChore - Exception whil e sync'ing replication tracker edit org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=15030132, WAL system stuck? at org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:171) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:876) at org.apache.hadoop.hbase.regionserver.wal.FSHLog.publishSyncThenBlockOnCompletion(FSHLog.java:802) at org.apache.hadoop.hbase.regionserver.wal.FSHLog.doSync(FSHLog.java:836) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$sync$3(AbstractFSWAL.java:602) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.sync(AbstractFSWAL.java:602) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.sync(AbstractFSWAL.java:592) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullMarkerAppendTransaction(WALUtil.java:169) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeMarker(WALUtil.java:146) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeReplicationMarkerAndSync(WALUtil.java:230) at org.apache.hadoop.hbase.replication.regionserver.ReplicationMarkerChore.chore(ReplicationMarkerChore.java:99) at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:161) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:107) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) {noformat} In this case there was namenode crash and all the hdfs clients on regionservers didn't failover to new active namenode due to our inefficient failover configuration parameters.        " Add coprocessor hook to authorize user based on client SSL certificate chain,13597488,In Progress,Major,,01/Nov/24 21:49,,2.6.1,"In order to authorize the connected user based on the provided SSL client certificate chain, a new coprocessor hook is needed for Master and RegionServer, because currently there's no way to abort connection by a coprocessor when or after the user is authenticated." s390x Nightly jobs are not running,13602213,Open,Major,,16/Dec/24 06:20,,,"Hi [~zhangduo] This is regarding the s390x jobs that have been disabled - [https://ci-hbase.apache.org/job/HBase-Nightly-s390x/]. The last job ([https://ci-hbase.apache.org/job/HBase-Nightly-s390x/605/console]) does produce a result with some flaky test fails. Most of them fails due to timeout issue. Please let me know if there is something I can do at my end to help re-enable s390x jobs in CI." Force CF compatibility during incremental backup,13594184,Resolved,Major,Fixed,03/Oct/24 14:41,27/Jan/25 16:18,2.6.2,"Incremental backups can be taken even if the table descriptor of the current table does not match the column families of the full backup for that same table. When restoring the table, we choose to use the families of the full backup. This can cause the restore process to fail if we add a column family in the incremental backup that doesn't exist in the full backup. The bulkload process will fail because it is trying to write column families that don't exist in the restore table.    I think the correct solution here is to prevent incremental backups from being taken if the families of the current table don't match those of the full backup. This will force users to instead take a full backup." ColumnFamilyMismatchException mixes IA public and private,13595715,Resolved,Major,Fixed,16/Oct/24 18:02,30/Oct/24 14:59,2.6.2,"The current implementation of ColumnFamilyMismatchException is IA public, but extends BackupException, which is IA private.    " Provide HBase Docker Image for Integration Testing on Docker Hub or Github Packages,13601119,Open,Major,,06/Dec/24 08:47,,,"* I noticed that documents like [https://hbase.apache.org/book.html#_get_started_with_hbase] require batch shell commands to initialize the HBase environment. *  It would be nice if HBase could provide a runtime Docker image on Docker Hub or Github Packages. This would help writing unit tests for third-party libraries like *testcontainers-java* . - Some early investigation came from https://issues.apache.org/jira/browse/PHOENIX-6912 and https://issues.apache.org/jira/browse/PHOENIX-6919 .   Previous test images: [https://github.com/F21/hbase-phoenix-all-in-one]  [https://github.com/cloudera/opdb-docker]" Optimize read performance for accumulated delete markers on the same row or cell,13602993,Patch Available,Major,,23/Dec/24 06:01,,2.5.10,"I have been confronted with a problem that some Get operations take several seconds. !screenshot-2.png! The reason was founded that users Put and Delete on some rows repeatedly. As delete markers are accumulated on the same row or cell, Get operations slow down. It can be reproduced by follow HBase shell commands. {code:java} create 'test', 'c' java_import org.apache.hadoop.hbase.client.Delete java_import org.apache.hadoop.hbase.TableName java_import java.lang.System con = @hbase.instance_variable_get(:@connection) table = con.getTable(TableName.valueOf('test')) 1000.times do |i| # batch 10000 deletes with different timestamps every 10 seconds now = System.currentTimeMillis() dels = 10000.times.map do |i| del = Delete.new(Bytes.toBytes('row')) del.addFamily(Bytes.toBytes('c'), now + i) end table.delete(dels) sleep(10) puts ""i - #{i}"" get 'test', 'row' end {code} {code:java} i - 0 COLUMN CELL 0 row(s) Took 0.0251 seconds ... i - 10 COLUMN CELL 0 row(s) Took 0.0412 seconds ... i - 20 COLUMN CELL 0 row(s) Took 0.0760 seconds ... i - 30 COLUMN CELL 0 row(s) Took 0.1014 seconds ... i - 40 COLUMN CELL 0 row(s) Took 0.1616 seconds ... {code} But the performance of Get operations can be optimized by using SEEK_NEXT_COL. {code:java} i - 1 COLUMN CELL 0 row(s) Took 0.0087 seconds ... i - 11 COLUMN CELL 0 row(s) Took 0.0077 seconds ... i - 21 COLUMN CELL 0 row(s) Took 0.0087 seconds ... {code} Please review the PR. [https://github.com/apache/hbase/pull/6557]" Remove spymemcached from assembly,13601505,Resolved,Major,Won't Do,10/Dec/24 07:46,21/Jan/25 05:48,,"As discussed on the mailing list, we should remove the spymemcached client jar from the assembly. At the same time, we should add instructions in the reference guide on how to add it manually." StoreFileInfo.isMobRefFile() would return true if the file is mob file not a reference mob file,13598935,Open,Major,,15/Nov/24 14:53,,,"StoreFileInfo.isMobRefFile() is used to determine whether a file is a reference MOB file created through snapshot. But StoreFileInfo.isMobRefFile() may mistakenly identify the real MOB file as a reference MOB file created through snapshot. For example: A reference MOB file, the name is t02_mob=34916d9a943a3b1fdb4a2bbeef2e3e97-d41d8cd98f00b204e9800998ecf8427e20241112464aebcdfc354fbb834d58900de1226d_6424974cfc2ba56e1c6f43c34e833a8e, StoreFileInfo.isMobRefFile() would return true for this name; A real MOb file, the name is d41d8cd98f00b204e9800998ecf8427e202411128ebcda68f97943cb80b64a00a0841a8d_6424974cfc2ba56e1c6f43c34e833a8e， StoreFileInfo.isMobRefFile() would also return true for this name." Optimize unnecessary type castings in Scan and Get setter methods,13600330,Resolved,Major,Fixed,28/Nov/24 16:43,18/Jan/25 02:27,,"In the setter methods of Scan and Get, we invoke the super class method, type cast and return the object. {code:java} public Scan setColumnFamilyTimeRange(byte[] cf, long minStamp, long maxStamp) { return (Scan) super.setColumnFamilyTimeRange(cf, minStamp, maxStamp); }{code}   In profiler reports it's observed that this typecasting does take some additional cpu cycles. we can optimize this  by adding an explicit return statement with current object.  {code:java} public Scan setColumnFamilyTimeRange(byte[] cf, long minStamp, long maxStamp) { super.setColumnFamilyTimeRange(cf, minStamp, maxStamp); return this; }{code}" Refactor direct interactions of HFilelink file creations to SFT interface,13598077,Resolved,Major,Fixed,07/Nov/24 15:54,13/Jan/25 21:23,,"HBASE-27826 introduces tracking of Link/Reference files with StoreFileTracker interface and with that, we can have the FileBasedStoreFileTracker implementation to track Link/Reference files only using .filelist file itself and not create actual link/ref files (virtual links). To support the same, we need to refactor all the direct interactions of Ref/Link file creations to SFT layer and this change - adds a createHFilelink() api to StoreFileTrackerBase. - Moves all the creations of HFileLink (except for Snapshot which will be handled in HBASE-28863) to SFT layer" Bump jruby to 9.4.9.0 to fix rexml CVE,13598049,Resolved,Major,Fixed,07/Nov/24 12:21,13/Jan/25 07:07,,"JRuby 9.4.9.0 has been released on November 04 2024 See release notes at [https://www.jruby.org/2024/11/04/jruby-9-4-9-0.html] This release drops moderate rexml [CVE-2024-49761|https://github.com/advisories/GHSA-2rxp-v6pw-ch6m] [ |https://github.com/advisories/GHSA-2rxp-v6pw-ch6m]from our classpath with following change along with several other bugs/fixes:  * REXML was updated to 3.3.9 to get recent fixes and to address [CVE-2024-49761|https://github.com/advisories/GHSA-2rxp-v6pw-ch6m], a ReDOS vulnerability. Only users parsing unsanitized XML with REXML are affected. [#8396|https://github.com/jruby/jruby/pull/8396]   Also, based on our internal sonatype scanner we had following CVE due to rexml in 9.4.8.0: |THREAT|SECURITY ISSUE|CVSS SCORE|COMPONENT| |8|[CVE-2024-35176|https://nvd.nist.gov/vuln/detail/CVE-2024-35176]|7.5|rexml 3.2.5| |8|[CVE-2024-41123|https://nvd.nist.gov/vuln/detail/CVE-2024-41123]|7.5|rexml 3.2.5| |8|[CVE-2024-41946|https://nvd.nist.gov/vuln/detail/CVE-2024-41946]|7.5|rexml 3.2.5| |7|[CVE-2024-39908|https://nvd.nist.gov/vuln/detail/CVE-2024-39908]|5.3|rexml 3.2.5| Let's see which all CVEs we get rid of with this change!" Amount of region cached in the region metrics not updated for a region immediately after it is flushed with cacheOnWrite turned on,13602516,In Progress,Major,,18/Dec/24 06:31,,2.6.1,"An issue has been observed where if a new region is created and flushed with the configuration ""hbase.rs.cacheblocksonwrite"" is set to true, then, the region metrics does not reflect the amount of region cached for this new region. It starts reflecting the correct metric when this region is reopened for whatever reason.   The steps to reproduce this issue are as follows: * Create a table {{create 'tprefetch', 'cf'}} * {{{}{}}}Insert a record in the table {{put 'tprefetch', 'row1', 'cf:col1', 'aaaaa'}} * {{{}{}}}{{{}flush 'tprefetch'{}}} After the flush, query the region metrics for this region and it will show that the region is 05 cached. This leads to the cacheAwareLoadBalancer take incorrect decisions whenever a region server is restarted. {{}}" Deleted data reappears: Files generated by compaction interruption or failure cause deleted data to reappear,13595648,Open,Major,,16/Oct/24 09:09,,0.98.0,"Encountered a ghost data issue in the online production environment: A business batch request simultaneously includes put and delete operations. Deleted data has a very small probability of reappearing after some time, and the problematic data is within a single region. The primary cluster has a backup cluster, and after the problematic rowkey appears in the primary cluster, it cannot be found in the backup cluster." "Modify the ""Incremental"" Command to Leverage Existing Backed-Up WALs for Continuous Backup",13599537,Open,Major,,21/Nov/24 12:37,,2.6.0,"The incremental backup collects all the WALs generated since the last full or incremental backup and processes them into HFiles for optimized restoration. With the new continuous backup feature, the necessary WALs are already available at the backup location and are used directly, eliminating the need to retrieve them from the source cluster. The incremental backup command itself remains unchanged. If previous backups are part of a continuous backup: Uses the WALs already backed up in the backup location. If previous backups are not part of a continuous backup: Operates as a traditional incremental backup, collecting WALs from the source cluster." Get asyncfs working with custom SASL mechanisms,13598094,Resolved,Major,Fixed,07/Nov/24 18:22,10/Jan/25 06:37,,"There are a lot of SASL changes in Hadoop 3.5. We need to somehow handle this. There are two changes we need to make: - Correctly handle SASL mechanisms that do not support QOP, like SCRAM - Correctly handle SASL mechanisms that do send a non-empty initial response." Upgrade JAX-WS to to 2.3.7,13600535,Resolved,Major,Fixed,02/Dec/24 07:15,10/Jan/25 06:19,2.5.10,"The current version is old and pulls in a lot of CVEs. -The jaxws-ri artifact is for the binary assembly, jaxws-rt is the one to be used from maven.- -(Actual dependencies should be identical)-" Change the default Hadoop 3 version to 3.4.1 on branch-2.5 and branch-2.6,13599104,Resolved,Major,Fixed,18/Nov/24 09:43,09/Jan/25 11:04,,"We've already done this on the non-release branches. Opening a separate ticket to track doing the same on the non-release branches. To recap the discussion:  Duo and I +1 this change. Nick has reservations, and has suggesed involving [~apurtell@yahoo.com] in the dicussion.  " Backport missing UI patches to branch-2.5,13601841,Resolved,Major,Fixed,12/Dec/24 13:41,08/Jan/25 11:57,,"While working on HBASE-28832, we noticed that some UI-related patches were not merged to branch-2.5, branch-2.6 or branch-2 which makes it harder to backport HBASE-28832 changes. It was suggested to identify specific JIRAs that need to be backported. Reason: it's better/easier to do that work than to maintain and enhance divergence between the branches. " Refactor assembly creation to use only DependencySets and move cached classpath creation to a new module,13600875,Resolved,Major,Fixed,04/Dec/24 12:22,10/Dec/24 11:56,,"There are a few problem with the current assembly creation: * The assembly and cached classpath creation is done from the same module, even though they need to include different JARs. *  To filter out the test jars, the descriptor uses a combination of moduleSets and dependencySets. * However, the results are less than ideal, as some test-related JARs are still included in the assembly, while some others have multiple versions of the same jar added to the assembly. Separating the assembly and cached classpath creation lets us build the assembly without the extra test dependencies and duplicate versions in a much simpler and more robust manner. Relying heavily on the maven dependency mechanism solves the problem of duplicate versions, and not depending on the test-related modules at all solves the problem of lingering test dependencies." Backport missing UI patches to branch-2.6,13602527,Resolved,Major,Fixed,18/Dec/24 07:24,08/Jan/25 11:53,,"While working on HBASE-28832, we noticed that some UI-related patches were not merged to branch-2.5, branch-2.6 or branch-2 which makes it harder to backport HBASE-28832 changes. It was suggested to identify specific JIRAs that need to be backported. Reason: it's better/easier to do that work than to maintain and enhance divergence between the branches. " "Extending the ""Full Backup"" Command to Enable Continuous Backup Support",13599536,In Progress,Major,,21/Nov/24 12:33,,2.6.0,"Enhance the Full Backup command to support continuous backup functionality. This includes: * Adding new options/parameters to the backup create command that are required for continuous backup. * Creating the replication peer and replicating WALs to the specified storage location, in addition to the usual full backup process." Backport missing UI patches to branch-2,13602530,Resolved,Major,Fixed,18/Dec/24 07:30,24/Dec/24 06:14,,"While working on HBASE-28832, we noticed that some UI-related patches were not merged to branch-2.5, branch-2.6 or branch-2 which makes it harder to backport HBASE-28832 changes. It was suggested to identify specific JIRAs that need to be backported. Reason: it's better/easier to do that work than to maintain and enhance divergence between the branches.    The following Jira patches were backported to branch-2 in this Jira: * HBASE-24624 Optimize table.jsp code * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing * HBASE-20452 Master UI: Table merge button should validate required fields before submit" Bump jinja2 from 3.1.4 to 3.1.5 in /dev-support/flaky-tests,13603366,Resolved,Major,Fixed,29/Dec/24 13:25,29/Dec/24 13:28,, Remove the java 16 instanceof usage in BulkLoad.java,13603146,Resolved,Major,Fixed,25/Dec/24 02:09,27/Dec/24 08:34,,"We still want to align the code between branch-3+ and branch-2+, so we should not use new grammers from java9+. And it also causes the mvn site command fail because checkstyle can not process the statement." Document enable/disable_rpc_throttle shell commands,13602399,Open,Major,,17/Dec/24 09:07,,,"Over on HBASE-21159 we gained the nice {{disable_rpc_throttle}} shell command. However it's not mentioned in the book, so it's relatively hidden. Let's at least make mention of it in the book." Poll SSL cert file for changes,13596259,Resolved,Major,Fixed,21/Oct/24 19:15,13/Dec/24 12:55,2.6.1,"At my company we have an issue with our HBase servers not reloading TLS certificate files after they change on disk. We run our HMasters inside Kubernetes Pods, and define our certificate contents as Kubernetes Secrets. Then, the Secrets are projected into the HMaster containers as files. When the value of a Secret changes, the file changes automatically. However, Kubernetes does some complicated indirection, and does not change the files directly. It swaps a new directory in with new files in it. HBase sets up a WatchService on the directory containing the TLS cert. For example, at my company, the cert is at {{{}/etc/hadoop/conf/ssl/cert/server-chain.pem{}}}. Then, events from that WatchService are delivered to a [handler method|https://github.com/apache/hbase/blob/836630422df2776287a860eff9d7104c3eca0582/hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java#L530] which contains this check: {code:java} Path eventFilePath = dirPath.resolve((Path) event.context()); if (filePath.equals(eventFilePath)) { shouldResetContext = true; }{code} Debug logs show why this conditional is never true: {code:java} 2024-10-21T17:48:13,659 [FileChangeWatcher-server-chain.pem] DEBUG org.apache.hadoop.hbase.io.FileChangeWatcher: Got file changed event: ENTRY_CREATE with context: ..2024_10_21_17_48_13.2471317370 2024-10-21T17:48:13,659 [FileChangeWatcher-server-chain.pem] DEBUG org.apache.hadoop.hbase.io.FileChangeWatcher: Got file changed event: ENTRY_CREATE with context: ..2024_10_21_17_48_13.2471317370 2024-10-21T17:48:13,660 [FileChangeWatcher-server-chain.pem] DEBUG org.apache.hadoop.hbase.io.crypto.tls.X509Util: Ignoring watch event and keeping previous default SSL context. Event kind: ENTRY_CREATE with context: ..2024_10_21_17_48_13.2471317370 .... {code} The watcher events have a variety of files attached to them, but none of them are {{{}server-chain.pem{}}}, so HBase thinks they are not relevant. I propose that we simply remove the condition inspecting the file name that was changed, and always reload the SSL context if a watcher event fires. This may lead to unnecessary reloads, but that will be harmless." Add a shell command for inspecting the state of enable/disable_rpc_throttle,13602405,Open,Major,,17/Dec/24 09:30,,,Over in HBASE-21159 we added shell commands to enable/disable rpc quotas. We should also have a command provides read-only access to the current state. Performance regression in hot reads after split/merge,13600635,Open,Major,,02/Dec/24 20:29,,2.6.1,"We noticed a significant performance regression which comes from HBASE-27474. In that ticket, logic is added so that we don't cache blocks that exist within a reference or a link if compactions are enabled. The issue we noticed is that we had a cluster which had compactions enabled, but compactions were a bit delayed. During the time, there were some regions which were recently split/merged and they contained references. This cluster is very hot reads and relies heavily on bloom filters. I noticed through profiles that we were spending a lot of time fetching BLOOM_CHUNK blocks from hdfs. This is almost never the case since we continually rightside the block cache to ensure all blooms are cached. In fact, we had no evictions at the time. So why weren't they getting cached? With trace logging enabled I noticed that all of the blocks being read over and over happened to come from hfiles that looked to be references. This led me to the ticket in question. This feels like a very serious regression, as it leads to substantantial impact to both hdfs and hbase in terms of request times and GC time and the host becomes fully hosed. I sort of wonder if we should revert that issue, or at the very least make it configurable. I'm not sure how to preserve the intended behavior of the ticket while also protecting the regionserver performance. In our case this happened for bloom blocks, but it could just as easily happen to a hot data block." Introduce a new WALProvider to generate WAL files consumed by Replication,13601649,Open,Major,,11/Dec/24 08:15,,,"Under our current Replication implementation, all WAL files will be consumed and the data will be filtered by a table attribute  REPLICATION_SCOPE_GLOBAL   We are using 2.4.11 version in our production env. And we have a small group table to use the replication to do CDC, however with the growth of the number of other non-replicated tables, we met the log queue accumulation issue and the data lag grew to hours level.    To solve the issue we write the tables, which has CF marked the replication_scope to global, to separated WAL files and let the replication only consume those files. The feature solved our problems and push it to the community.  In our env, we have 19 tables and only 8 of them need to be replicated.  There are write heavy tables in the the rest of 11. So that our business benefits a lot from this feature.   The attached screenshot shows the improvement.  " The RegionServer metrics of WALs is incorrect,13600712,Resolved,Major,Fixed,03/Dec/24 11:06,16/Dec/24 14:20,,"RegionServer Metrics of wals (file count and file size) is incorrect. We should should recalculate every time, rather than continuously accumulating them.   // MetricsRegionServerWrapperImpl.RegionServerMetricsWrapperRunnable.run() List providers = regionServer.getWalFactory().getAllWALProviders(); for (WALProvider provider : providers) {     numWALFiles += provider.getNumLogFiles();     walFileSize += provider.getLogFileSize(); }" Add a banner to the masterUI when disable_rpc_throttle is active,13602407,Open,Major,,17/Dec/24 09:34,,,"When quotas are enabled, rpc throttling is also enabled. There's a shell command to disable rpc throttles, added in HBASE-21159. As we do with the balancer, we should display a warning banner on the master UI when the quota system is enabled but the {{disable_rpc_throttle}} has been activated." Depend on jaxws-rt instead jaxws-ri,13600555,Resolved,Major,Fixed,02/Dec/24 09:01,13/Dec/24 13:05,2.5.10,"Jaxws-ri pulls in extra dependencies that are not needed for either the rest server or client:  _jakarta.mail-api-1.6.3.jar_  _jakarta.persistence-api-2.2.2.jar_  _jaxb-jxc-2.3.2.jar_  _jaxb-xjc-2.3.2.jar_  _jaxws-eclipselink-plugin-2.3.2.jar_  _jaxws-rt-2.3.2.jar_  _jaxws-tools-2.3.2.jar_  _org.eclipse.persistence.asm-2.7.4.jar_  _org.eclipse.persistence.core-2.7.4.jar_  _org.eclipse.persistence.moxy-2.7.4.jar_  _org.eclipse.persistence.sdo-2.7.4.jar_  _sdo-eclipselink-plugin-2.3.2.jar_ However replacing jaxws-rt with jaxws-ri adds the following duplicate dependencies to  the assembly: stax2-api-4.1.jar woodstox-core-5.1.0.jar The assembly already has several duplicate dependencies, which is tracked in HBASE-29002 ." Restore bulkload testing to branch-2 branches,13602053,Open,Major,,13/Dec/24 14:54,,2.5.0,"While backporting HBASE-28767 I noticed that {{TestIncrementalBackupWithBulkLoad}} wasn't present on branch-2. This is the only backups test that wasn't present. I tried to restore it but found that {{TestIncrementalBackupWithBulkLoad}} depends on {{TestBulkLoadHFiles}}, which also doesn't exist on branch-2. We should ensure basic test coverage of the bulkload features on branch-2 release lines and consider reintroducing these tests (and others?)" Remove unrelocated JAX-WS from assembly,13600564,Resolved,Major,Fixed,02/Dec/24 09:38,10/Dec/24 12:19,3.0.0-beta-2,"HBase-rest uses thirdparty jax-ws. The only thing requiring unrelocated JAX-WS is hbase-it. (and probably even that could be replaced with the thirdparty version) There is no need to ship jax-ws in the assembly if we don't ship hbase-it." Snapshots tab is always empty (not implemented) on Master web UI,13599684,Resolved,Major,Invalid,22/Nov/24 10:15,11/Dec/24 14:07,4.0.0-alpha-1,"While working on HBASE-28832 noticed that the Snapshots tab content on the Master web UI is always empty. !image-2024-11-22-11-14-24-161.png|width=1307,height=664! Actually the tab content div is completely empty in the .jamon file: {code:java}                    
                   
{code} See: https://github.com/apache/hbase/blob/master/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon#L286" Simplify & remove reflections in FanOutOneBlockAsyncDFSOutputSaslHelper,13601456,Open,Major,,10/Dec/24 00:26,,3.0.0-beta-1,"HBASE-23833 maintained compatibility for both Hadoop 3.3 and below, using reflection to access protobuf objects. Now that HBase master branch moved up Hadoop version (3.4.1), we can remove the complex reflection hack to simplify the code. Make it less error prone." Update logging references to org.apache.hadoop.ipc in docs and examples,13601130,Resolved,Major,Fixed,06/Dec/24 09:15,09/Dec/24 14:34,,"That hasn't worked for a long time. The correct  subsystem is: _org.apache.hadoop.hbase.ipc_ or _org.apache.hadoop.hbase.ipc.RpcServer_ . and TRACE level is required." Investigate integrating OpenAPI / Swagger to hbase-rest,13598633,Resolved,Major,Won't Do,13/Nov/24 14:19,09/Dec/24 08:07,,"Using OpenAPI / Swagger it would be possible to generate a schema file of HBase REST API. In theory the generated schema file could be used as documentation / generating API clients. Even Swagger UI could be used to have an interactive playground for the HBase REST API. Check how much HBase could gain having this." Duplicate dependency versions in assembly,13600299,Resolved,Major,Duplicate,28/Nov/24 12:02,09/Dec/24 07:00,,"When building master, I see the following duplicate dependencies in /lib in the assembly. {noformat} -rw-r--r-- 1 stoty stoty  193322 Jan 22  2020 checker-qual-2.5.2.jar -rw-r--r-- 1 stoty stoty  204610 Jan 22  2020 checker-qual-3.1.0.jar -rw-r--r-- 1 stoty stoty   36576 Jan 22  2020 jackson-module-jaxb-annotations-2.12.7.jar -rw-r--r-- 1 stoty stoty   37123 Jan 22  2020 jackson-module-jaxb-annotations-2.17.2.jar -rw-r--r-- 1 stoty stoty   44399 Jan 22  2020 jakarta.activation-api-1.2.1.jar -rw-r--r-- 1 stoty stoty   46613 Jan 22  2020 jakarta.activation-api-1.2.2.jar -rw-r--r-- 1 stoty stoty   25150 Jan 22  2020 jakarta.annotation-api-1.3.4.jar -rw-r--r-- 1 stoty stoty   25058 Jan 22  2020 jakarta.annotation-api-1.3.5.jar -rw-r--r-- 1 stoty stoty  115498 Jan 22  2020 jakarta.xml.bind-api-2.3.2.jar -rw-r--r-- 1 stoty stoty  115638 Jan 22  2020 jakarta.xml.bind-api-2.3.3.jar -rw-r--r-- 1 stoty stoty   56674 Jan 22  2020 javax.activation-api-1.2.0.jar -rw-r--r-- 1 stoty stoty   26366 Jan 22  2020 javax.annotation-api-1.2.jar -rw-r--r-- 1 stoty stoty  116120 Jan 22  2020 kerb-crypto-1.0.1.jar -rw-r--r-- 1 stoty stoty  115065 Jan 22  2020 kerb-crypto-2.0.3.jar -rw-r--r-- 1 stoty stoty   36708 Jan 22  2020 kerb-util-1.0.1.jar -rw-r--r-- 1 stoty stoty   36361 Jan 22  2020 kerb-util-2.0.3.jar -rw-r--r-- 1 stoty stoty   30674 Jan 22  2020 kerby-config-1.0.1.jar -rw-r--r-- 1 stoty stoty   30190 Jan 22  2020 kerby-config-2.0.3.jar {noformat}          " Scan endpoint returns HTTP 500 Internal Server Error when table is disabled,13600151,Resolved,Major,Won't Fix,27/Nov/24 09:49,06/Dec/24 09:36,4.0.0-alpha-1,"h2. Scenario Try to use stateless scanner a *disabled table* on REST interface. h2. Actual result Scan endpoint returns HTTP 500 Internal Server Error. {code:java} { ""servlet"":""org.apache.hbase.thirdparty.org.glassfish.jersey.servlet.ServletContainer-33c2bd"", ""message"":""Request failed."", ""url"":""/test/*"", ""status"":""500"" } {code} h2. Expected result It should NOT return HTTP 500 Internal Server Error. (?) Probably some client error status code (4xx). h2. How to reproduce * Create a new table (e.g via hbase shell, etc) * Disable the table * Try to scan the table with the [stateless scanner|https://issues.apache.org/jira/browse/HBASE-9343] REST endpoint {code:java} curl -v -X GET \   -H ""Accept: application/json"" \   ""http://localhost:8080/test/*"" ... < HTTP/1.1 500 Server Error ...{code} h2. Additional information REST server logs snippet: {code:java} 2024-11-26T08:53:25,140 WARN  [qtp485475507-50 {}] server.HttpChannel: handleException /test/* com.fasterxml.jackson.databind.JsonMappingException: org.apache.hadoop.hbase.TableNotEnabledException: test (through reference chain: org.apache.hadoop.hbase.rest.TableScanResource$CellSetModelStream[""Row""])2024-11-26T08:53:25,141 WARN  [qtp485475507-50 {}] server.HttpChannelState: unhandled due to prior sendErrorjavax.servlet.ServletException: org.apache.hbase.thirdparty.org.glassfish.jersey.server.ContainerException: com.fasterxml.jackson.databind.JsonMappingException: org.apache.hadoop.hbase.TableNotEnabledException: test (through reference chain: org.apache.hadoop.hbase.rest.TableScanResource$CellSetModelStream[""Row""]) Caused by: java.io.UncheckedIOException: org.apache.hadoop.hbase.TableNotEnabledException: test at org.apache.hadoop.hbase.client.ResultScanner$1.hasNext(ResultScanner.java:53) ~[hbase-client-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.rest.TableScanResource$1$1.hasNext(TableScanResource.java:77) ~[hbase-rest-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] {code} The other scan endpoint handles this better (returns HTTP 406 - Not Acceptable): {code:java} curl -v -X PUT \ -H ""Accept: application/json"" \ -H ""Content-Type: text/xml"" \ -d '' \ ""http://localhost:8080/test/scanner"" | jq * Host localhost:8080 was resolved. * IPv6: ::1 * IPv4: 127.0.0.1 * Connected to localhost (::1) port 8080 > PUT /test/scanner HTTP/1.1 > Host: localhost:8080 > User-Agent: curl/8.9.1 > Accept: application/json > Content-Type: text/xml > Content-Length: 20 > } [20 bytes data] * upload completely sent off: 20 bytes < HTTP/1.1 201 Created < X-Frame-Options: DENY < X-Content-Type-Options: nosniff < X-XSS-Protection: 1; mode=block < Location: http://localhost:8080/test/scanner/17327004740183794717d < Content-Length: 0 curl -vi -X GET -H ""Accept: text/json"" http://localhost:8080/test/scanner/17327004740183794717d * Host localhost:8080 was resolved. * IPv6: ::1 * IPv4: 127.0.0.1 * Trying [::1]:8080... * Connected to localhost (::1) port 8080 > GET /test/scanner/17327004740183794717d HTTP/1.1 > Host: localhost:8080 > User-Agent: curl/8.9.1 > Accept: text/json > * Request completely sent off < HTTP/1.1 406 Not Acceptable HTTP/1.1 406 Not Acceptable < X-Frame-Options: DENY X-Frame-Options: DENY < X-Content-Type-Options: nosniff X-Content-Type-Options: nosniff < X-XSS-Protection: 1; mode=block X-XSS-Protection: 1; mode=block < Cache-Control: must-revalidate,no-cache,no-store Cache-Control: must-revalidate,no-cache,no-store < Content-Type: text/json Content-Type: text/json < Content-Length: 187 Content-Length: 187 < { ""servlet"":""org.apache.hbase.thirdparty.org.glassfish.jersey.servlet.ServletContainer-1dfd5f51"", ""message"":""Not Acceptable"", ""url"":""/test/scanner/17327004740183794717d"", ""status"":""406"" * Connection #0 to host localhost left intact }% {code}" bin/hbase-daemons.sh start rest does not work,13600995,Open,Major,,05/Dec/24 09:56,,,"The REST server cannot be started by the hbase-daemons.sh script: {noformat} 2024-12-05T10:49:02,588 INFO  [main] RESTServer: ***** STARTING service 'RESTServer' ***** 2024-12-05T10:49:02,592 INFO  [main] util.VersionInfo: HBase 4.0.0-alpha-1-SNAPSHOT 2024-12-05T10:49:02,592 INFO  [main] util.VersionInfo: Source code repository git://stoty-Precision-5570/home/stoty/workspaces/hbase/hbase revision=c556dde144612aa71524a011e01892316ca15d57 2024-12-05T10:49:02,592 INFO  [main] util.VersionInfo: Compiled by stoty on Wed Dec  4 03:33:22 PM CET 2024 2024-12-05T10:49:02,592 INFO  [main] util.VersionInfo: From source with checksum 560992c1bb047ee39799a052cd32c63379cb7622c8fa8ef46f6260c9ce65f50501eb8b041b6570791fd520f39648c75d2359a5344a04b85da65532baa0fa2d7e 2024-12-05T10:49:02,730 ERROR [main] RESTServer: Could not parse:  org.apache.hbase.thirdparty.org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: -Dhbase.regionserver.port=16020         at org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.processOption(Parser.java:244) ~[hbase-shaded-miscellaneous-4.1.9.jar:4.1.9]         at org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.parse(Parser.java:176) ~[hbase-shaded-miscellaneous-4.1.9.jar:4.1.9]         at org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.parse(Parser.java:94) ~[hbase-shaded-miscellaneous-4.1.9.jar:4.1.9]         at org.apache.hadoop.hbase.rest.RESTServer.parseCommandLine(RESTServer.java:181) ~[hbase-rest-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]         at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:468) ~[hbase-rest-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] Thu Dec  5 10:55:16 AM CET 2024 Starting rest on stoty-Precision-5570 {noformat}" Cannot split hbase:quota table when quota enforcement is enabled,13600408,Resolved,Major,Fixed,29/Nov/24 12:51,05/Dec/24 08:50,2.5.0,"When quotas are enabled, splitting the quota table fails due to the namespace region quotas system being partially initialized. {noformat} 2024-11-28T14:11:38,672 ERROR [PEWorker-2 {}] procedure2.ProcedureExecutor(1844): CODE-BUG: Uncaught runtime exception: pid=7, state=RUNNABLE:SPLIT_TABLE_REGION_PRE_OPERATION, hasLock=true; SplitTableRegionProcedure table=hbase:quota, parent=3c1dbd551845ed2e8033b76570c6d8f6, daughterA=a8f5e70728d93859d7c3d95aa5a0f63b, daughterB=c71f49ad7e689a57742a9fe65b918d08 java.lang.NullPointerException: Cannot invoke ""java.util.concurrent.atomic.AtomicInteger.addAndGet(int)"" because the return value of ""java.util.Map.get(Object)"" is null at org.apache.hadoop.hbase.namespace.NamespaceTableAndRegionInfo.incRegionCountForTable(NamespaceTableAndRegionInfo.java:101) ~[classes/:?] at org.apache.hadoop.hbase.namespace.NamespaceStateManager.checkAndUpdateNamespaceRegionCount(NamespaceStateManager.java:95) ~[classes/:?] at org.apache.hadoop.hbase.namespace.NamespaceAuditor.checkQuotaToSplitRegion(NamespaceAuditor.java:116) ~[classes/:?] at org.apache.hadoop.hbase.quotas.MasterQuotaManager.onRegionSplit(MasterQuotaManager.java:544) ~[classes/:?] at org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.preSplitRegion(SplitTableRegionProcedure.java:607) ~[classes/:?] at org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.executeFromState(SplitTableRegionProcedure.java:298) ~[classes/:?] at org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.executeFromState(SplitTableRegionProcedure.java:98) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:941) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1825) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1503) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:2154) ~[classes/:?] at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2181) ~[classes/:?] {noformat} See discussion on the dev list, https://lists.apache.org/thread/gdnjb1ys8m93lowykdrh4m7o55mgw3vo" Clear all meta caches of the server on which hardware failure related exceptions occurred,13596878,Patch Available,Major,,28/Oct/24 03:23,,2.4.18,"CallTimeoutException and ConnectException might be caused by a network or hardware issue of that server. We might not be able to connect to that server for a while. So we have to clear all meta caches of the server on which hardware failure related exceptions occurred. If we don't clear the caches, we might get the same exceptions as many times as the number of location caches of that server.   https://issues.apache.org/jira/browse/HBASE-7590 https://issues.apache.org/jira/browse/HBASE-22261 We already have ClusterStatusPublisher/Listener feature. But it is not possible to use this feature in some infrastructure environments like me.  " SLF4j logging backend incorrectly picked up from Hadoop when external Hadoop is specified,13600183,Resolved,Major,Fixed,27/Nov/24 12:20,28/Nov/24 08:46,2.5.10,"When I set  HADOOP_CLASSPATH: {noformat} SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/stoty/x/hadoop-3.4.1/share/hadoop/common/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/stoty/workspaces/hbase/hbase/hbase-assembly/target/hbase-2.5.11-SNAPSHOT-client/lib/client-facing-thirdparty/log4j-slf4j-impl-2.17.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory] {noformat} HBase should always pick its own log4j2 backend." Master Failed to Start after upgrading from 2.5.10 to 3.0.0-beta-1 ,13600492,Resolved,Major,Duplicate,01/Dec/24 13:38,01/Dec/24 14:18,,"Master Failed to Start after upgrading from 2.5.10 to 3.0.0-beta-1 {code:java} 2024-12-01T19:00:47,390 ERROR [master/master:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILED         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:384) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:324) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1535) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1204) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2494) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-beta-1.jar:3.0.0-beta-1]         at java.lang.Thread.run(Thread.java:840) ~[?:?] Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 18 actions: RetriesExhaustedException: 18 times, servers with issues:         at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.makeError(BufferedMutatorOverAsyncBufferedMutator.java:107) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.internalFlush(BufferedMutatorOverAsyncBufferedMutator.java:122) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.close(BufferedMutatorOverAsyncBufferedMutator.java:166) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.TableNamespaceManager.migrateNamespaceTable(TableNamespaceManager.java:92) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:122) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:61) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:252) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1532) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         ... 5 more 2024-12-01T19:00:47,390 ERROR [master/master:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [] 2024-12-01T19:00:47,390 ERROR [master/master:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master master,16000,1733059831148: Unhandled exception. Starting shutdown. ***** java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILED         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:384) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:324) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1535) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1204) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2494) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-beta-1.jar:3.0.0-beta-1]         at java.lang.Thread.run(Thread.java:840) ~[?:?]{code} Region Server has below warning log   {code:java} 2024-12-01T19:00:47,354 WARN  [RpcServer.priority.RWQ.Fifo.write.handler=0,queue=0,port=16020] regionserver.HRegion: No such column family in batch mutation in region org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation@74bf756d org.apache.hadoop.hbase.regionserver.NoSuchColumnFamilyException: Column family ns does not exist in region hbase:meta,,1.1588230740 in table 'hbase:meta', {TABLE_ATTRIBUTES => {IS_META => 'true', coprocessor$1 => '|org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint|536870911|', METADATA => {'hbase.store.file-tracker.impl' => 'DEFAULT'}}}, {NAME => 'info', INDEX_BLOCK_ENCODING => 'NONE', VERSIONS => '3', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'ROW_INDEX_V1', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '8192 B (8KB)'}, {NAME => 'rep_barrier', INDEX_BLOCK_ENCODING => 'NONE', VERSIONS => '2147483647', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'ROW_INDEX_V1', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536 B (64KB)'}, {NAME => 'table', INDEX_BLOCK_ENCODING => 'NONE', VERSIONS => '3', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'ROW_INDEX_V1', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '8192 B (8KB)'}         at org.apache.hadoop.hbase.regionserver.HRegion.checkFamily(HRegion.java:5344) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion.checkFamily(HRegion.java:5331) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion.checkFamilies(HRegion.java:5325) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion.access$100(HRegion.java:239) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.checkAndPreparePut(HRegion.java:3849) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.checkAndPrepareMutation(HRegion.java:3486) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.checkAndPrepareMutation(HRegion.java:3498) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation$1.visit(HRegion.java:3878) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3377) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.checkAndPrepare(HRegion.java:3857) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4753) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4673) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:984) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:902) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:867) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2830) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45018) ~[hbase-protocol-shaded-3.0.0-beta-1.jar:3.0.0-beta-1]{code} complete log files are attached" The region assignment retry logic in unconstrained and may cause workload amplification,13600440,Open,Major,,30/Nov/24 04:59,,2.6.0,"We found a potential feedback loop in the region assignment process that may overload the RegionServer (RS). The `AssigmentManager.processAssignmentPlans()` will retry the assignment when any HBaseIOException happens. For example, `FavoerableNodeAssignmentHelper.canPlaceFavoredNodes` may throw an HIOE when the nodes available are less than three. The HIOE will be caught by the catch block here: {code:java}   private void processAssignmentPlans(final HashMap regions,     final HashMap retainMap, final List hris,     final List servers) {     boolean isTraceEnabled = LOG.isTraceEnabled();     if (isTraceEnabled) {       LOG.trace(""Available servers count="" + servers.size() + "": "" + servers);     }    final LoadBalancer balancer = getBalancer();     // ask the balancer where to place regions     if (retainMap != null && !retainMap.isEmpty()) {       if (isTraceEnabled) {         LOG.trace(""retain assign regions="" + retainMap);       }       try {         acceptPlan(regions, balancer.retainAssignment(retainMap, servers));       } catch (HBaseIOException e) {         LOG.warn(""unable to retain assignment"", e);         addToPendingAssignment(regions, retainMap.keySet());       }     } {code} The assignment is simply retried and is not bounded. This can cause problems when the assignment fails because the RS is overloaded. More retries in the region assignment can make the overloading worse." Remove lib/jdk11 directory in 3.0+,13600285,Resolved,Major,Duplicate,28/Nov/24 09:05,28/Nov/24 09:19,3.0.0-beta-2,"As 3.0+ requires JDK17+, there is no longer a point in handling the libraries that were removed from JDK11 specially. I propose removing the jdk11 directory, and treating those libraries like the rest of the dependencies. The special code handling it could also be removed from the script(s). WDYT [~zhangduo] [~ndimiduk] [~nihaljain] ?" Backup support for S3 broken by checksum added in HBASE-28625,13599925,Open,Major,,25/Nov/24 15:36,,,"With the 2.6.1 version, we fail to backup to S3 because of the introduction of the checksum validation (introduced with HBASE-28625). Stacktrace: {code:java} Error: java.io.IOException: Checksum mismatch between hdfs://hdfsns/hbase/hbase/data/SYSTEM/CATALOG/b884434cc05aae3a21c0d0723173ce02/0/43b0e3a7b608441eab7dbce2782511bf and s3a://product-eks-v2-brt-master-574-backup/hbase/backup_1732545852227/SYSTEM/CATALOG/archive/data/SYSTEM/CATALOG/b884434cc05aae3a21c0d0723173ce02/0/43b0e3a7b608441eab7dbce2782511bf. Input and output filesystems are of different types. Their checksum algorithms may be incompatible. You can choose file-level checksum validation via -Ddfs.checksum.combine.mode=COMPOSITE_CRC when block-sizes or filesystems are different.  Or you can skip checksum-checks altogether with -no-checksum-verify, for the table backup scenario, you should use -i option to skip checksum-checks.  (NOTE: By skipping checksums, one runs the risk of masking data-corruption during file-transfer.)        at org.apache.hadoop.hbase.snapshot.ExportSnapshot$ExportMapper.verifyCopyResult(ExportSnapshot.java:596)         at org.apache.hadoop.hbase.snapshot.ExportSnapshot$ExportMapper.copyFile(ExportSnapshot.java:332)         at org.apache.hadoop.hbase.snapshot.ExportSnapshot$ExportMapper.map(ExportSnapshot.java:254)         at org.apache.hadoop.hbase.snapshot.ExportSnapshot$ExportMapper.map(ExportSnapshot.java:180)       at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:145)         at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:800)         at org.apache.hadoop.mapred.MapTask.run(MapTask.java:348)         at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:178)         at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)         at java.base/javax.security.auth.Subject.doAs(Subject.java:525)         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1953)         at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:172)2024-11-25 14:47:42,715 ERROR org.apache.hadoop.hbase.snapshot.ExportSnapshot: Snapshot export failed org.apache.hadoop.hbase.snapshot.ExportSnapshotException: Task failed task_1732545054899_0007_m_000001 Job failed as tasks failed. failedMaps:1 failedReduces:0 killedMaps:0 killedReduces: 0        at org.apache.hadoop.hbase.snapshot.ExportSnapshot.runCopyJob(ExportSnapshot.java:935)         at org.apache.hadoop.hbase.snapshot.ExportSnapshot.doWork(ExportSnapshot.java:1204)         at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:151)         at org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyJob.copy(MapReduceBackupCopyJob.java:382)         at org.apache.hadoop.hbase.backup.impl.FullTableBackupClient.snapshotCopy(FullTableBackupClient.java:113)         at org.apache.hadoop.hbase.backup.impl.FullTableBackupClient.execute(FullTableBackupClient.java:175)         at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.backupTables(BackupAdminImpl.java:594){code} I think the solution is to only do the checksum validation if the filesystems are the same." Table Regions Total Locality value on the UI shows 1.0 even though some of the regions locality value is zero,13599785,Open,Major,,23/Nov/24 15:50,,,"Table Regions Total Locality value on the UI shows 1.0 even though some of the regions locality value is zero. This is due to the rounding of happening inside the String.format() function.  I have a table with 200 regions and 1 of the regions locality is zero, the overall locality calculated value is ~0.99524385, but the String.format function rounded of this value to 1.0. If some of the table regions localtiy is zero then we should not show the total Locality of the table as 1.0 as this can be misleading  to the user.  " Meta replication is inconsistent after startup when reusing hbase storage location,13597927,Open,Major,,06/Nov/24 15:01,,,"Meta replication is inconsistent after startup when reusing HBase storage location for example the new cluster is created with the same S3 storage location that a previous one had.  USE_META_REPLICAS is set to true META_REPLICAS_NUM is set to 3 For both hbck output: {noformat} ERROR: hbase:meta, replicaId 1 is not found on any region. ERROR: hbase:meta, replicaId 2 is not found on any region. ERROR: hbase:meta table is not consistent. Run HBCK with proper fix options to fix hbase:meta inconsistency. Exiting... Summary: 3 inconsistencies detected. Status: INCONSISTENT{noformat}" "Backport ""HBASE-28608 More sensible client meta operation timeout default"" to branch-2",13599126,Resolved,Major,Duplicate,18/Nov/24 12:48,21/Nov/24 14:33,, Enhance Remaining Backup Commands to Support Continuous Backup and Point-in-Time Recovery (PITR),13599542,Open,Major,,21/Nov/24 12:48,,2.6.0,"Investigate whether any of the following remaining commands need modification to support continuous backup. If necessary, make the required changes: * Merge * Describe * Progress * History * Repair * Help" "Ensure the Existing ""Delete"" Backup Command Functions Properly with Continuous Backup Enablement",13599540,Open,Major,,21/Nov/24 12:43,,2.6.0,"Ensure that the current ""Delete"" backup command continues to work as expected. Additionally, the command should: * Clean up the replication peer. * Provide an option to purge all collected data from the storage." "Add a ""Cleanup"" Command to Free Up Storage Beyond a Specified Time Period",13599539,Open,Major,,21/Nov/24 12:40,,2.6.0,"Implement a ""cleanup"" command to allow users to free up storage by removing data older than a specified time period. This should include: * Full backup cleanup * WAL cleanup * HFile cleanup" Adding support for continuous Backup and Point-in-Time Recovery,13597682,Open,Major,,04/Nov/24 22:46,,2.6.0,"Current solutions like replication and snapshots offer data redundancy but have limitations that prevent effective point-in-time recovery in cases of data corruption or accidental changes. Replication requires maintaining a live cluster that mirrors the original, which incurs substantial costs to keep both clusters operational. Snapshots, on the other hand, do not support point-in-time recovery, leading to potential data loss between snapshots. Incremental snapshots improve this situation but still do not provide full protection, as they only capture data at specific intervals. Limitations of the Current Incremental Backup Solution The current incremental backup solution in HBase has several critical limitations that highlight the need for continuous backup and PITR: • Risk of Data Loss: Since incremental backups are created in batches rather than continuously, any changes made since the last backup are at risk of being lost if data corruption or deletion occurs before the next scheduled backup. • Restore Point Limitations: Users can only restore data to specific backup timestamps rather than any exact moment in time, restricting flexibility and the ability to revert to the most recent stable state before an issue. • WAL Management Challenges: Write-Ahead Logs on the source cluster cannot be archived until the backup process completes, making WAL management complex and storage-intensive on the source cluster. • Complex Backup Tracking: Managing backup IDs, job history, and logs is currently challenging, requiring substantial manual tracking and oversight to ensure consistency. • Dependency on YARN: The incremental backup process relies on a YARN cluster to move WALs, adding both resource dependency and complexity to the backup workflow. " Fix UT flakeyness in TestBucketCache.testBlockAdditionWaitWhenCache and TestVerifyBucketCacheFile.testRetrieveFromFile,13598610,Resolved,Major,Fixed,13/Nov/24 11:39,20/Nov/24 12:48,2.5.10,"Noticed these two tests failing intermittently on some of the pre-commit runs.  1) TestBucketCache.testBlockAdditionWaitWhenCache: The test calls  BucketCache.cacheBlock() passing true to the waitWhenCache parameter, assuming the cache call will wait for a success cache, however this is only true if the BucketCache.QUEUE_ADDITION_WAIT_TIME property is also defined, so I believe this may be causing the intermittent failures when the pre-commit runs on slower vms.   2) TestVerifyBucketCacheFile.testRetrieveFromFile: One of the checks performed by this test is to delete the bucket cache file, shutdown the current BucketCache instance, then create a new BucketCache instance that would load the persistent file but should fail to recover the cache, as the cache file has been deleted. The way this recover works, internally, is async. We first read the contents of the persistent file, which includes the last serialized backingMap and a checksum of the cache file at that time. It then compares this recovered checksum against the current cache file checksum. If this verification fails, it starts a background thread to traverse all backingMap entries and check if those entries are still available in the cache. At this point, the test is ready to check the BucketCache allocator size, expecting it to be 0, but if the background verification has not finished yet, this assert will fail." Change the default Hadoop 3 version to 3.4.1,13596726,Resolved,Major,Fixed,25/Oct/24 12:50,18/Nov/24 09:42,, Support client access to HBase servers using IP in IPV6 env,13598275,Open,Major,,09/Nov/24 13:37,,3.0.0-alpha-4,"Using IPV6 address failed to create the WAL path. IPV6 address contains "":"", eg: [0:0:0:0:0:0:0:1] WAL path creation will fail, because FS will not support to create path with "":"". so for use IP is true and the env is ipv6 # Encode for wal path creation with IPV6 address # Decode the IPV6 address, if RS servernames are prepared from the WAL path. {noformat} 2024-11-18 10:55:43,931 | ERROR | master/:16000:becomeActiveMaster | ***** ABORTING master 0:0:0:0:0:0:0:1,16000,1731910552237: Unhandled exception. Starting shutdown. ***** | org.slf4j.helpers.MarkerIgnoringBase.error(MarkerIgnoringBase.java:159) java.lang.IllegalArgumentException: Pathname /hbase/MasterData/WALs/0:0:0:0:0:0:0:1,16000,1731910552237 from hdfs://hacluster/hbase/MasterData/WALs/0:0:0:0:0:0:0:1,16000,1731910552237 is not a valid DFS filename.         at org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:272)         at org.apache.hadoop.hdfs.DistributedFileSystem$31.doCall(DistributedFileSystem.java:1849)         at org.apache.hadoop.hdfs.DistributedFileSystem$31.doCall(DistributedFileSystem.java:1846)         at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)         at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1861)         at org.apache.hadoop.fs.FileSystem.exists(FileSystem.java:1811)         at org.apache.hadoop.hbase.master.region.MasterRegion.createWAL(MasterRegion.java:192)         at org.apache.hadoop.hbase.master.region.MasterRegion.open(MasterRegion.java:263)         at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:344)         at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:104)         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:892)         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2485)         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:558)         at java.lang.Thread.run(Thread.java:750){noformat} IPV6 address contains colon( : ) which is not a valid name in HDFS." Updating Quota Factors is too expensive,13597946,Resolved,Major,Fixed,06/Nov/24 16:53,15/Nov/24 12:48,2.6.1,"My company is running Quotas across a few hundred clusters of varied size. One cluster has hundreds of servers and tens of thousands of regions. We noticed that the HMaster was quite busy for this cluster, and after some investigation we realized that RegionServers were hammering the HMaster's ClusterMetrics endpoint to facilitate the refreshing of table machine quota factors. There are a few things that we could do here — in a perfect world, I think the RegionServers would have a better P2P communication of region states, and whatever else is, necessary to derive new quota factors. Relying solely on the HMaster for this coordination creates a tricky bottleneck for the horizontal scalability of clusters. That said, I think that a simpler and preferable initial step would be to make our code a bit more cost conscious. At my company, for example, we don't even define any table-scoped quotas. Without any table scoped quotas in the cache, our cache could be much more thoughtful about the work that it chooses to do on each refresh. So I'm proposing that we check [the size of the tableQuotaCache keyset|https://github.com/apache/hbase/blob/db3ba44a4c692d26e70b6030fc519e92fd79f638/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L418] earlier, and use this inference to determine what ClusterMetrics we bother to fetch." Improve lease renew for FanOutOneBlockAsyncDFSOutput,13597605,Resolved,Major,Fixed,04/Nov/24 11:15,06/Nov/24 14:29,,"When working with hadoop 3.4.x, we saw this in the stdout file {noformat} Exception in thread ""LeaseRenewer:zhangduo@home"" java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.hdfs.DFSOutputStream.getNamespace()"" because ""outputStream"" is null at org.apache.hadoop.hdfs.DFSClient.getNamespaces(DFSClient.java:596) at org.apache.hadoop.hdfs.DFSClient.renewLease(DFSClient.java:618) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer.renew(LeaseRenewer.java:425) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer.run(LeaseRenewer.java:445) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer.access$800(LeaseRenewer.java:77) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer$1.run(LeaseRenewer.java:336) at java.base/java.lang.Thread.run(Thread.java:840) {noformat} This is because in newer DFSClient implementation, we need to pass namespace when renewer lease so we can not just pass null as DFSOutputStream when calling DFSClient.beginFileLease. We should find a way to deal with it." Make the approach in HBASE-28955 can work together with hadoop 2.x,13598014,Resolved,Major,Fixed,07/Nov/24 06:54,15/Nov/24 14:39,,"The solution before HBASE-28955 can work with hadoop 2.x but after applying the changes in HBASE-28955, we can work with hadoop 3.4.x but we can not compile with hadoop 2.x then. We should find a way to support hadoop 2.x so we can also port the changes to branch-2.x as well." Remove the netty 3 dependency management section,13597228,Resolved,Major,Fixed,30/Oct/24 14:38,13/Nov/24 02:19,,"After HBASE-28942, netty will only be pulled in from hadoop 3.3.x, so we can remove the dependency management section for it. This will also remove the dependabot warnings about netty 3." Update dev-support/hbase_docker Dockerfiles to use JDK17,13598546,Open,Major,,12/Nov/24 23:50,,4.0.0-alpha-1,"HBase master branch requires JDK17, but the docker files under dev-support/hbase_docker install only JDK8. Time to update to JDK17." "After modifying the 'zookeeper.znode.parent' parameter and restarting HBase, HBase is unable to complete its initialization.",13597310,Resolved,Major,Fixed,31/Oct/24 06:57,13/Nov/24 06:13,2.4.17,"In my tests, after modifying the 'zookeeper.znode.parent' parameter and restarting HBase, HBase is unable to complete its initialization with versions 2.3.* and 2.4.* , but this issue does not occur with version 2.2.* . If the Zookeeper cluster crashes and the data stored in zk cannot be recovered, and only a new ZK cluster can be set up, the HBase cluster will never be able to return to a normal state. This problem is particularly severe under certain failure scenarios.   The following describes the situation after I modified the znode and restarted HBase. The data in the hbase:meta table was lost, the number of regions displayed on the Master UI remained at 1, and the meta table could not come online. Moreover, there were no obvious error messages found in the logs of the Master or Region Servers.   Maybe it's related to the issue fixed by HBASE-26193?" Limit the number of retries in FanOutOneBlockAsyncDFSOutputHelper.completeFile,13598166,Resolved,Major,Fixed,08/Nov/24 07:00,11/Nov/24 15:03,,"After HBASE-28955, when shutting down MiniDFSCluster, we will close all the output streams. And in some WAL related tests, we want to keep the WAL file as open so we set namenode to safe mode before shutting down, like TestWALFactory.testAppendClose. And in FanOutOneBlockAsyncDFSOutputHelper.completeFile, we will only give up when hitting LeaseExpireException, so in this scenario, we will block there forever... In general, if there is an error while complete file, we could go with the recoverLease logic so it is OK to throw exception when completeFile. We should change the implementation so it does not block there forever." Update nightlies to run with HADOOP2_VERSION = 2.10.2,13597195,Resolved,Major,Fixed,30/Oct/24 10:21,11/Nov/24 05:47,,"We are running nighlies with older hadoop2 and hence expected failures are not seen: * I see hadoop distributed 2.10.0 installed for last run at [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/lastCompletedBuild/execution/node/121/ws/hadoop-2/share/hadoop/hdfs/] ** Ref: [https://github.com/apache/hbase/blob/master/dev-support/Jenkinsfile#L133] IMO they are wrong should be 2.10.2 for all branches. CC: [~stoty] " "Backport ""HBASE-27598 Upgrade mockito to 4.x"" to branch-2.5",13597207,Resolved,Major,Fixed,30/Oct/24 11:36,11/Nov/24 05:45,2.5.10,"Mockito 2.28.2 is release May 29, 2019, which is very old now. Let's upgrade to the latest 4.x version, as mockito 5.0.0 requires java 11, which is not suitable for us. Need to backport this to branch-2.5 as we face https://issues.apache.org/jira/browse/HBASE-28944 w/o this." FSHLog can not roll the WAL log properly,13598118,Open,Major,,07/Nov/24 21:03,,2.4.18,"For the FSHLog, when we try to roll the writer, we will # initiate the zigzagLatch, and wait for the safe point # After the safe point obtained, continue to close the writer For above process, looks like we have [assumption|https://github.com/apache/hbase/blob/branch-2.6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L388] that the highestSyncedTxid will must be bigger than highestUnsyncedTxid, I do not think it must be true, because for [attainSafePoint|https://github.com/apache/hbase/blob/branch-2.6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L1119] we did not limit the save point much be sync workload, if its stop at append workload, the highestUnsyncedTxid will always be bigger highestSyncedTxid, right? In our environment, we can reproduce the issue which will causing the wal log pilling up very quickly if a lot of writing, if we want to to make sure the the existing logic is working, we need to add a check and make attainSafePoint get correct safe point, or make sure the doReplaceWriter handle the WAL close correctly when highestUnsyncedTxid > highestSyncedTxid  " Add Clearwater Analytics to powered by hbase,13595735,In Progress,Major,,16/Oct/24 22:08,,,"According to [https://hbase.apache.org/poweredbyhbase.html] is this the right ticket to add my organization name? If so, could you please add the content below? LMK if you have any questions. Thank you! ========== Clearwater Analytics ([https://clearwateranalytics.com/]) has an HBase cluster with 9 nodes in production. We have a handful of tables hosting billions of rows (and growing) in a time series manner. Some tables are pretty wide, with several hundreds of columns, while others are very tall and narrow. ========== Thanks! Sanjeev Dhiman Principal Engineer Clearwater Analytics" Add essential build plugins to hbase-diagnostics,13597910,Resolved,Major,Fixed,06/Nov/24 13:42,07/Nov/24 12:05,,Seems I missed to add some essential / required plugin while adding the new module.  Avoid bundling hbase-webapps folder in default jars,13595823,Resolved,Major,Fixed,17/Oct/24 12:23,06/Nov/24 13:10,,"We are bundling all webapp resources in hbase-server, hbase-thrift and transitively to hbase-shaded-mapreduce jar. This can be an issue as if any of the js projects used by hbase are vulnerable, security scan tools like sonatype start flagging the jars too as vulnerable since they contain vulnerable code. With this JIRA, we want to avoid bundling static webapp resources in our jars. For example: Bootstrap 3.4.1 which is used by hbase, has multiple medium CVEs reported recently. See [https://security.snyk.io/package/npm/bootstrap/3.4.1] for details. And since we are bundling all webapp resources in hbase-server, hbase-thrift and transitively to hbase-shaded-mapreduce jar. And hence sonatype reports all such jars also as vulnerable: |3|CVE-2024-6484|2.3|bootstrap 3.4.1| |3|CVE-2024-6484|2.3|org.apache.hbase : hbase-server : 2.6.0| |3|CVE-2024-6484|2.3|org.apache.hbase : hbase-shaded-mapreduce : 2.6.0| |3|CVE-2024-6484|2.3|org.apache.hbase : hbase-thrift : 2.6.0| It is wise to remove such files from our jars to avoid any bigger hiccups in future." "Remove all jackson 1.x dependencies for hadoop-3 profile, since all jackson 1.x versions have vulnerabilities",13596930,Resolved,Major,Fixed,28/Oct/24 10:40,06/Nov/24 13:16,2.5.10,"Building hbase with hadoop-3 profile on branch-2, still requires jackson 1.x jars, which has vulnerabilities. Ideally these should not be needed as with HADOOP-13332 hadoop has already ""Remove jackson 1.9.13 and switch all jackson code to 2.x code line"" for branch-3. Also in HBASE-27148, where we worked on ""Move minimum hadoop 3 support version to 3.2.3"" we had did a similar cleanup for branch-3 but somehow we missed to port the relevant changes to the branch-2 backport of same jira. This task is to take care of this so that we donot need jackson 1.x to build/run hbase with hadoop-3 profile on branch-2.x.   We have following in our dependency tree: {code:java} [INFO] ----------< org.apache.hbase:hbase-shaded-client-byo-hadoop >----------- [INFO] Building Apache HBase - Shaded - Client 2.7.0-SNAPSHOT [33/53] [INFO] from hbase-shaded/hbase-shaded-client-byo-hadoop/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:provided [INFO] +- org.codehaus.jackson:jackson-xc:jar:1.9.13:provided . . [INFO] --------------< org.apache.hbase:hbase-shaded-mapreduce >--------------- [INFO] Building Apache HBase - Shaded - MapReduce 2.7.0-SNAPSHOT [34/53] [INFO] from hbase-shaded/hbase-shaded-mapreduce/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:provided [INFO] +- org.codehaus.jackson:jackson-xc:jar:1.9.13:provided . . [INFO] -------------< org.apache.hbase:hbase-shaded-testing-util >------------- [INFO] Building Apache HBase - Shaded - Testing Util 2.7.0-SNAPSHOT [46/53] [INFO] from hbase-shaded/hbase-shaded-testing-util/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:compile [INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:compile [INFO] |  \- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:compile [INFO] |  +- org.codehaus.jackson:jackson-jaxrs:jar:1.9.13:test . . [INFO] ---------< org.apache.hbase:hbase-shaded-testing-util-tester >---------- [INFO] Building Apache HBase - Shaded - Testing Util Tester 2.7.0-SNAPSHOT [47/53] [INFO] from hbase-shaded/hbase-shaded-testing-util-tester/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] +- org.codehaus.jackson:jackson-mapper-asl:jar:1.9.13:test [INFO] |  \- org.codehaus.jackson:jackson-core-asl:jar:1.9.13:test {code}" [hbase-thirdparty] add jersey-media-json-jackson in hbase-shaded-jersey,13598035,Open,Major,,07/Nov/24 09:54,,thirdparty-4.1.9,"In a REST service built using hbase-shaded-jersey.jar, I'm unable to convert a Response object into a JSON string. The reason I cannot convert a Response object to a JSON string in my REST service built with hbase-shaded-jersey.jar is because it lacks the necessary dependencies from jersey-media-json-jackson." Clean up explicit depency versions in poms,13596253,Open,Major,,21/Oct/24 18:45,,,"Unless there is some specific reason, all dependency versions should be set in DependencyManage sections. Right now we at least some Hadoop dependencies where the versions are redundantly set directly in the Dependency entries. We should also consistently set hadoop.version from the hadoop3 profiles in the modules that have them. (I think that those aren't relevant in branch-3+, but we should either set them consistently, or just remove them outside branch-2.x)" Apply workaround for HADOOP-19164 for Hadoop 3.4.1,13597601,Resolved,Major,Fixed,04/Nov/24 10:45,05/Nov/24 04:09,,"HADOOP-19164 is also present in 3.4.1, not just 3.4.0. We need to update the scripts to apply the workaround for both 3.4.0 and 3.4.1" TestMemStoreLAB often fails with OOM,13597874,Open,Major,,06/Nov/24 07:27,,,"I see this quite often in the failed nightly tests: IIRC I've always seen this on the JDK8 tests, but the sample size is very small. [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/619/]" RegionMover tool fails when table is deleted,13597217,Resolved,Major,Fixed,30/Oct/24 13:20,04/Nov/24 08:29,,"The issue occurs when the RegionMover tool encounters a TableNotFoundException while moving regions. This happens if the table being processed is deleted while the RegionMover is running. {noformat} 2024-10-30 11:58:20,500 INFO org.apache.hadoop.hbase.util.RegionMover: Moving 10 regions to server0.example.org,16020,1730289478970 using 30 threads.Ack mode:false 2024-10-30 11:58:20,564 ERROR org.apache.hadoop.hbase.util.RegionMover: Error while loading regions to server0.example.org org.apache.hadoop.hbase.TableNotFoundException: cluster_test at org.apache.hadoop.hbase.client.HBaseAdmin$46.rpcCall(HBaseAdmin.java:2120) at org.apache.hadoop.hbase.client.HBaseAdmin$46.rpcCall(HBaseAdmin.java:2116) at org.apache.hadoop.hbase.client.RpcRetryingCallable.call(RpcRetryingCallable.java:57) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:104) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3088) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3080) at org.apache.hadoop.hbase.client.HBaseAdmin.checkTableExists(HBaseAdmin.java:2116) at org.apache.hadoop.hbase.client.HBaseAdmin.isTableEnabled(HBaseAdmin.java:978) at org.apache.hadoop.hbase.util.MoveWithAck.getServerNameForRegion(MoveWithAck.java:140) at org.apache.hadoop.hbase.util.RegionMover.loadRegions(RegionMover.java:358) at org.apache.hadoop.hbase.util.RegionMover.lambda$getRegionsMovePlan$2(RegionMover.java:333) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840) {noformat}" Purge all netty 3 dependencies by default,13596894,Resolved,Major,Fixed,28/Oct/24 07:02,01/Nov/24 04:17,,"After bumping default hadoop version to 3.4.1, we should be able to remove all netty 3 dependencies. Now the problem is in hbase-external-blockcache, where we use jmemcached for testing, it is an old library which still depends on netty 3. We should find a way to deal with this." "Prioritize ""orphan"" blocks for eviction inside BucketCache.freespace",13595857,Resolved,Major,Fixed,17/Oct/24 15:23,31/Oct/24 16:41,2.6.1,"The Persistent Cache feature brought the ability to recover the cache in the event of a restart or crash. Under certain conditions, the cache recovery can lead to _orphan_ blocks hanging on the cache, causing unnecessary extra cache usage. For example, when a region server crashes or restarts, the original regions on this region server would be immediately reassigned on the remaining servers. Once the crashed/restarted server comes back online, persistent cache will recover the cache state prior to the crash/restart, which would contain the blocks from the regions it was holding prior to the incident. This can lead to the _orphan_ blocks situation described above in the following conditions: * If balancer is off, or cache aware balancer fails to move back the very same regions from prior the crash; * If compaction completes for the regions on the temporary servers; Also, with the default evictsOnClose is set to false, any region move would leave ""orphans"" blocks behind.  This proposes additional logic for identifying blocks not belonging to any files from current online regions inside BucketCache.freeSpace method. This would need to modify both BlockCacheFactory and BucketCache to pass along the map of online regions kept by HRegionServer. Inside BucketCache.freeSpace method, when iterating through the backingMap and before separating the entries between the different eviction priority groups, we can check if the given entry belongs to a block from any of the online regions files, using BucketCache.evictBucketEntryIfNoRpcReferenced method to remove it if its file is not found on any of the online regions. An additional configurable grace period should be added, to consider only blocks cached before this grace period as potentially orphans. This is to avoid evicting blocks from currently being written files by flushes/compactions, when “caching on write/caching on compaction” is enabled." Run nightly tests with multiple Hadoop 3 versions,13594485,Resolved,Major,Fixed,07/Oct/24 09:44,30/Oct/24 15:18,, Should check if compaction are needed after flushing,13596587,Open,Major,,24/Oct/24 10:59,,2.4.13,"Regardless of whether we have enabled flsuh procedure or not, even if the threshold is reached, hbase would not execute comapct after flushing operation. I think we should check the HRegion.FlushResult, and send compact request if it is needed." Do not run the backwards compatibility tests with the default Hadoop3 version,13596837,Resolved,Major,Fixed,27/Oct/24 07:21,30/Oct/24 15:19,,"We are running the full test suite with it already, running the dev tests as well is completely redundant and a waste of time and resources." Update nightlies to run with HADOOP3_VERSION = 3.2.4,13597193,Resolved,Major,Duplicate,30/Oct/24 10:11,30/Oct/24 12:03,2.5.10,"We are running nighlies with older hadoop3 on branch-2.5 and hence expected failures are not seen: * Also I see hadoop 3.1.1 for hadoop3 at [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/lastCompletedBuild/execution/node/121/ws/hadoop-3/share/hadoop/client/]  ** Ref: [https://github.com/apache/hbase/blob/branch-2.5/dev-support/Jenkinsfile#L157] IMO is is wrong should 3.2.4 for branch-2.5 CC: [~stoty] " Handle NPE in Split/Merge table when getMasterQuotaManager returns null,13596190,Resolved,Major,Fixed,21/Oct/24 09:51,29/Oct/24 06:26,2.5.8,"Currently when doing splits or merge we notify quota manager about the same. But if quota instance is null on below call {code:java} // code placeholder env.getMasterServices().getMasterQuotaManager() {code} So the below two lines will throw unexpected exception which ideally can be handled.  {code:java} // SplitTableRegionProcedure.java env.getMasterServices().getMasterQuotaManager().onRegionSplit(this.getParentRegion()); {code} {code:java} // MergeTableRegionProcedure.java env.getMasterServices().getMasterQuotaManager().onRegionMerged(this.mergedRegion); {code}" TestShadedHBaseTestingUtility fails with NCDFE: org/mockito/stubbing/Answer,13597184,Resolved,Major,Duplicate,30/Oct/24 08:41,30/Oct/24 11:40,2.5.10,"While working on https://github.com/apache/hbase/pull/6414 found we have following pre-existing test failure: {code:java} [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.006 s <<< FAILURE! - in org.apache.hbase.shaded.TestShadedHBaseTestingUtility [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed: 0.002 s <<< ERROR! java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer at org.apache.hadoop.hdfs.MiniDFSCluster.isNameNodeUp(MiniDFSCluster.java:2590) at org.apache.hadoop.hdfs.MiniDFSCluster.isClusterUp(MiniDFSCluster.java:2604) at org.apache.hadoop.hdfs.MiniDFSCluster.waitClusterUp(MiniDFSCluster.java:1479) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:958) at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:849) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:689) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:669) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1141) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1116) at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:46) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.lang.ClassNotFoundException: org.mockito.stubbing.Answer at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527) ... 24 more [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestShadedHBaseTestingUtility.setUp:46 » NoClassDefFound org/mockito/stubbing/Answer [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 16.878 s (Wall Clock) [INFO] Finished at: 2024-10-30T07:43:39Z [INFO] ------------------------------------------------------------------------ {code} Seems related to https://issues.apache.org/jira/browse/HDFS-15915  " Fix spotbugs issues introduced by refactoring to hbase-diagnostics with HBASE-28432,13595961,Resolved,Major,Fixed,18/Oct/24 09:31,24/Oct/24 15:31,,"Seeing a lot of spotbugs issues across PRs lately. These are coming due to newly added main code refactored as part of https://issues.apache.org/jira/browse/HBASE-28432 I was not aware spotbugs issues will be on complete code and not just PR code change. Also wanted to avoid changing code as we were just 'refactoring'. As now code sits inside main and not test, we should try to fix all the spotbugs issues. CC: [~ndimiduk], [~stoty] " The HFile Reader creation should not be blocked due to waits for cache initialisation.,13596469,Resolved,Major,Fixed,23/Oct/24 12:28,28/Oct/24 09:45,2.7.0,"When persistent bucket cache is enabled, bucket cache needs to read and load the persistent cache file contents during region server starting time. This cache initialisation is currently asynchronous. The server restart completes after spawning a thread to initialise the cache. When the subsequent HFile readers are created, the current implementation is such that the constructor of the hfile (HFilePreadReader) waits until the cache is initialised. Due to this wait, all client requests to these regions would fail during the whole cache initialisation period, as these regions are not yet online. The correct way to handle this is that, the constructors of HFile readers should not wait for cache initialisation. Only the prefetch threads should wait for the cache initialisation. Subsequently, any client requests should be served by accessing the underlying file system if the cache is not yet initialised, and a cache miss should be computed in the cache stats. Thanks, Janardhan" HBaseTestingUtility failed to start MiniHbaseCluster in case of Hadoop3.4.0,13594617,Open,Major,,08/Oct/24 10:05,,,"Test env: Hbase 2.5.10-hadoop3 Hadoop 3.4.0   *You can use the attached files to reproduce the issue.* I have noticed two error message: 1) The first is that *_NoSuchMethodException: org.apache.hadoop.hdfs.DFSClient.beginFileLease(long, org.apache.hadoop.hdfs.DFSOutputStream)._* I think this is due to the incompatible change in Hadoop 3.4.0 change [https://github.com/apache/hadoop/pull/5536/files#diff-405edd18f9ff05d7ae8c25efef90266db403ecbe0e75ae8ce8fb68bb02f03041|https://github.com/apache/hadoop/pull/4813/files#diff-405edd18f9ff05d7ae8c25efef90266db403ecbe0e75ae8ce8fb68bb02f03041]   {code:java} 2024-10-08 06:08:27,401 ERROR [master/zbt-ubuntu:0:becomeActiveMaster] asyncfs.FanOutOneBlockAsyncDFSOutputHelper (FanOutOneBlockAsyncDFSOutputHelper.java:(316)) - Couldn't properly initialize access to HDFS internals. Please update your WAL Provider to not make use of the 'asyncfs' provider. See HBASE-16110 for more information. java.lang.NoSuchMethodException: org.apache.hadoop.hdfs.DFSClient.beginFileLease(long, org.apache.hadoop.hdfs.DFSOutputStream)     at java.lang.Class.getDeclaredMethod(Class.java:2130)     at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createLeaseManager(FanOutOneBlockAsyncDFSOutputHelper.java:205)     at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.(FanOutOneBlockAsyncDFSOutputHelper.java:308)     at java.lang.Class.forName0(Native Method)     at java.lang.Class.forName(Class.java:264)     at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.load(AsyncFSWALProvider.java:140)     at org.apache.hadoop.hbase.wal.WALFactory.getProviderClass(WALFactory.java:139)     at org.apache.hadoop.hbase.wal.WALFactory.getProvider(WALFactory.java:179)     at org.apache.hadoop.hbase.wal.WALFactory.(WALFactory.java:207)     at org.apache.hadoop.hbase.wal.WALFactory.(WALFactory.java:186)     at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:388)     at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:132)     at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:949)     at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2428)     at org.apache.hadoop.hbase.master.HMaster.lambda$null$0(HMaster.java:566)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177)     at org.apache.hadoop.hbase.master.HMaster.lambda$run$1(HMaster.java:563)     at java.lang.Thread.run(Thread.java:748){code}     2) The second error is *_java.lang.NoClassDefFoundError: Could not initialize class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper._* But i have added the hbase-asyncfs dependency in {*}pom.xml{*}, i don't figure out why there is this error?   {code:java} 2024-10-08 06:08:32,615 WARN  [RS_OPEN_META-regionserver/zbt-ubuntu:0-0] handler.AssignRegionHandler (AssignRegionHandler.java:handleException(173)) - Fatal error occurred while opening region hbase:meta,,1.1588230740, aborting... java.lang.NoClassDefFoundError: Could not initialize class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper     at org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:54)     at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:193)     at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:180)     at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:117)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:696)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:127)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriterInternal(AbstractFSWAL.java:916)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$rollWriter$8(AbstractFSWAL.java:948)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:948)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:582)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:523)     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:160)     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:62)     at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:298)     at org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2393)     at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)     at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:748){code}  " "Use reflection to access recoverLease(), setSafeMode() APIs.",13594248,Resolved,Major,Fixed,04/Oct/24 03:04,25/Oct/24 19:54,,"HBASE-27769 used the new Hadoop API (available since Hadoop 3.3.6/3.4.0) to access recoverLease() and setSafeMode() APIs, and committed the change in a feature branch. However, until we move beyond Hadoop 3.3.6, we can not use them directly. I'd like to propose to use reflection to access these APIs in the interim so HBase can use Ozone sooner." Automatic SSL keystore reloading for HttpServer,13595231,Open,Major,,13/Oct/24 11:05,,,"Since https://issues.apache.org/jira/browse/HADOOP-16524, Hadoop can reload SSL keystore without restarting. It can be adopted to HBase similarly. It is painful to rolling-restart HBase master and all the HBase regionservers on large cluster in order to refresh ssl keystore every year." Add support for multi region splits in Catalog Janitor,13596578,Open,Major,,24/Oct/24 10:39,,,"This is to add the API to support multi region splitting - HBASE-28438 Catalog janitor checks ongoing region splits  and compactions on the daughter regions completed or not by looking at the reference files present in the daughter region directories to delete the parent region from meta. All the APIs used by catalog janitor check only two daughter regions and reference files of those two daughter regions which need to be changed to support multi region split feature - HBASE-28438.  " TestPrefetch#testPrefetchWithDelay fails intermittently,13595863,Resolved,Major,Fixed,17/Oct/24 16:08,21/Oct/24 15:32,,"TestPrefetch#testPrefetchWithDelay fails intermittently with {_}""{_}_AssertionError: Prefetch should start post configured delay""_ " Bump Avro dependency version to 1.11.4,13593977,Resolved,Major,Fixed,02/Oct/24 08:28,05/Oct/24 18:14,, Set hadoop-three.version in Hadoop 3 backwards compatibility tests,13596197,Resolved,Major,Fixed,21/Oct/24 11:52,22/Oct/24 06:29,,"Found by the new 3.4.0 nighty tests: {noformat} [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.backup.TestBackupRestoreOnEmptyEnvironment.null [ERROR] Run 1: TestBackupRestoreOnEmptyEnvironment.testRestoreToCorrectTable:126->backup:223 » TestTimedOut test timed out after 1560 seconds [ERROR] Run 2: TestBackupRestoreOnEmptyEnvironment » Appears to be stuck in thread MiniHBaseClusterRegionServer-EventLoopGroup-3-1 [INFO] [ERROR] TestBackupRestoreOnEmptyEnvironment.testRestoreCorrectTableForIncremental:156->backup:223 » NoClassDefFound org/apache/hadoop/util/Sets [ERROR] org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.null [ERROR] Run 1: TestIncrementalBackupMergeWithBulkLoad.testMergeContainingBulkloadedHfiles:127->backup:219 » TestTimedOut test timed out after 1560 seconds [ERROR] Run 2: TestIncrementalBackupMergeWithBulkLoad » Appears to be stuck in thread MiniHBaseClusterRegionServer-EventLoopGroup-3-1 [INFO] [ERROR] TestIncrementalBackupMergeWithBulkLoad.testMergeContainingBulkloadedHfiles:134->backup:219 » NoClassDefFound org/apache/hadoop/util/Sets [ERROR] TestIncrementalBackupMergeWithBulkLoad.testMergeContainingBulkloadedHfiles:127->backup:219 » InterruptedIO [INFO] {noformat}" CopyTable to accept custom cf/qualifier for timestamp range filtering,13596389,In Progress,Major,,22/Oct/24 23:15,,2.4.18,"Currently CopyTable starttime/endtime param filters on HBase's built-in timestamp. Add the following options to support filtering based on the value of custom timestamp column. {noformat}  ts.cf        column family for time range checking (use HBase built-in timestamp if not specified)  ts.qualifier qualifier for time range checking (use HBase built-in timestamp if not specified) {noformat}" checkcompatibility.py can run maven commands with parallelism,13594309,Resolved,Major,Fixed,04/Oct/24 13:03,19/Oct/24 09:06,,We can speed up the create-release process by taking advantage of maven parallelism during creation of the API compatibility report. Add announcement as a release in GitHub,13595948,Resolved,Major,Done,18/Oct/24 07:54,19/Oct/24 08:25,, Bump commons-io:commons-io from 2.11.0 to 2.14.0,13595843,Resolved,Major,Fixed,17/Oct/24 14:13,17/Oct/24 14:26,, Publish release artifacts in SVN,13595949,Resolved,Major,Done,18/Oct/24 07:58,18/Oct/24 10:47,,Don't forget to also drop the old release candidate artifacts. Supports enabling storage policy in the data copying scenario of bulkload,13594396,Open,Major,,05/Oct/24 09:39,,,"The Bulkload process consists of two steps: 1. generate hfiles using MR/SPARK and write them to an HDFS cluster. 2. execute 'hbase completebulkload [OPTIONS] ' or invoke the BulkLoadHFilesTool API. [HBASE-1721|https://issues.apache.org/jira/browse/HBASE-15172] implements tiered storage capabilities for bulkload, but it is only applicable to scenarios where hfiles generated by MR/SPARK are directly written to the HDFS cluster used by HBase (tiered storage is configured). However, in most bulkload scenarios, hfiles generated by MR/SPARK are first written to an offline HDFS cluster (non-HBase HDFS Cluster, and tiered storage is not configured). Subsequently, the 'hbase completebulkload' command is used to copy these hfiles from the offline HDFS cluster to the HDFS cluster used by HBase, and rename them to the appropriate table/region/columnfamily directory. This scenario is not supported by [HBASE-1721|https://issues.apache.org/jira/browse/HBASE-15172], this issue will support tiered storage for this more general bulkload scenario. " Refactor chaos monkey related code to a new module hbase-chaos,13595649,Open,Major,,16/Oct/24 09:11,,3.0.0-beta-2,"As part of this Jira we will create a new module named {{hbase-chaos}} and optionally include it in the assembly. This change is necessary because we will be removing all test jars from our assembly (with HBASE-28433), resulting in the removal of chaos monkey and all its code, which may need to be manually copied by operators. Currently, all the code resides in {{{}hbase-it{}}}. This fix will provide an option to build hbase such that we can bundle hbase-chaos in assembly, albeit we wont do this by default. CC: [~stoty], [~ndimiduk] " Avoid resetting bucket cache during restart if inconsistency is observed for some blocks.,13594301,Resolved,Major,Fixed,04/Oct/24 11:39,15/Oct/24 11:23,2.6.0,"During the execution of persistence of backing map into the persistence file, the backing map is not guarded by a lock against caching of blocks and block evictions. Hence, some of the block entries in the backing map in persistence may not be consistent with the bucket cache. During, the retrieval of the backing map from persistence if an inconsistency is detected, the complete bucket cache is discarded and is rebuilt. One of the errors, seen, is, as mentioned below: {code:java} 2024-09-30 08:58:33,840 WARN org.apache.hadoop.hbase.io.hfile.bucket.BucketCache: Can't restore from file[/hadoopfs/ephfs1/bucketcache.map]. The bucket cache will be reset and rebuilt. Exception seen: org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Couldn't find match for index 26 in free list         at org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocator$Bucket.addAllocation(BucketAllocator.java:140)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocator.(BucketAllocator.java:406)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(BucketCache.java:1486)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.lambda$startPersistenceRetriever$0(BucketCache.java:377)         at java.base/java.lang.Thread.run(Thread.java:840) {code} This retrieval can be optimised to only discard the inconsistent entries in the persistent backing map and retain the remaining entries. The bucket cache validator will throw away the inconsistent entry from the backing map. Thanks, Janardhan" "hbase 2.5.10 execute ""./bin/hbase shell"" occurred an error jar-bootstrap.rb",13595615,Open,Major,,16/Oct/24 06:37,,2.5.10,"{code:java} $ $HBASE_HOME/bin/hbase shell -n   This file has been superceded by packaging our ruby files into a jar   and using jruby's bootstrapping to invoke them. If you need to   source this file fo some reason it is now named 'jar-bootstrap.rb' and is   located in the root of the file hbase-shell.jar and in the source tree at   'hbase-shell/src/main/ruby' {code}" NPE on TestPrefetch.testPrefetchWithDelay,13593949,Resolved,Major,Fixed,01/Oct/24 20:57,14/Oct/24 10:09,2.7.0,"I'm seeing some failures on TestPrefetch.testPrefetchWithDelay in some pre-commit runs, I believe this is due to a race condition in PrefetchExecutor. loadConfiguration. In these failures, it seems we are getting the NPE below: {noformat} Stacktracejava.lang.NullPointerException at java.util.concurrent.ConcurrentSkipListMap.put(ConcurrentSkipListMap.java:1580) at org.apache.hadoop.hbase.io.hfile.PrefetchExecutor.request(PrefetchExecutor.java:108) at org.apache.hadoop.hbase.io.hfile.PrefetchExecutor.lambda$loadConfiguration$0(PrefetchExecutor.java:206) at java.util.concurrent.ConcurrentSkipListMap.forEach(ConcurrentSkipListMap.java:3269) at org.apache.hadoop.hbase.io.hfile.PrefetchExecutor.loadConfiguration(PrefetchExecutor.java:200) at org.apache.hadoop.hbase.regionserver.PrefetchExecutorNotifier.onConfigurationChange(PrefetchExecutorNotifier.java:51) at org.apache.hadoop.hbase.io.hfile.TestPrefetch.testPrefetchWithDelay(TestPrefetch.java:378) {noformat} I think this is because we are completing prefetch in this test before the induced delay, then this test triggers a new configuration change, but the prefetch thread calls PrefetchExecutor.complete just before the test thread reaches [this point|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java#L206]: {noformat} 2024-10-01T11:28:10,660 DEBUG [Time-limited test {}] hfile.PrefetchExecutor(102): Prefetch requested for /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-6328/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-data/b646497b-7616-6533-e8cb-98e5c9e2e083/TestPrefetchWithDelay/71eefdb271ae4f65b694a6ec3d4287a0, delay=25000 ms 2024-10-01T11:28:30,668 INFO [Time-limited test {}] hbase.Waiter(181): Waiting up to [10,000] milli-secs(wait.for.ratio=[1]) 2024-10-01T11:28:35,661 DEBUG [hfile-prefetch-1727782088576 {}] hfile.HFilePreadReader$1(103): No entry in the backing map for cache key 71eefdb271ae4f65b694a6ec3d4287a0_0. ... 2024-10-01T11:28:35,673 DEBUG [hfile-prefetch-1727782088576 {}] hfile.HFilePreadReader$1(103): No entry in the backing map for cache key 71eefdb271ae4f65b694a6ec3d4287a0_52849. 2024-10-01T11:28:35,674 DEBUG [Time-limited test {}] hfile.PrefetchExecutor(142): Prefetch cancelled for /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-6328/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-data/b646497b-7616-6533-e8cb-98e5c9e2e083/TestPrefetchWithDelay/71eefdb271ae4f65b694a6ec3d4287a0 2024-10-01T11:28:35,674 DEBUG [hfile-prefetch-1727782088576 {}] hfile.PrefetchExecutor(121): Prefetch completed for 71eefdb271ae4f65b694a6ec3d4287a0 2024-10-01T11:28:35,674 DEBUG [Time-limited test {}] hfile.PrefetchExecutor(102): Prefetch requested for /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-6328/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-data/b646497b-7616-6533-e8cb-98e5c9e2e083/TestPrefetchWithDelay/71eefdb271ae4f65b694a6ec3d4287a0, delay=991 ms ... {noformat} CC: [~kabhishek4]" LoadBalancerPerformanceEvaluation fails with NPE,13595260,Open,Major,,13/Oct/24 20:18,,,"While testing [https://github.com/apache/hbase/pull/6258] found that LoadBalancerPerformanceEvaluation fails with NPE, not related to PR as fails for master as well. This Jira is to track and fix this issue. {code:java} bin % ./hbase org.apache.hadoop.hbase.master.balancer.LoadBalancerPerformanceEvaluation -regions 30000 -servers 10 2024-10-14T01:48:06,772 INFO  [main {}] metrics.MetricRegistries: Loaded MetricRegistries class org.apache.hadoop.hbase.metrics.impl.MetricRegistriesImpl 2024-10-14T01:48:06,841 INFO  [main {}] balancer.LoadBalancerPerformanceEvaluation: Calling roundRobinAssignment 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 0 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 1 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 2 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 3 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 4 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 5 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 6 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 7 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 8 is on rack 0 2024-10-14T01:48:06,850 INFO  [main {}] balancer.BalancerClusterState: server 9 is on rack 0 Time for roundRobinAssignment     : 238ms 2024-10-14T01:48:07,079 INFO  [main {}] balancer.LoadBalancerPerformanceEvaluation: Calling retainAssignment 2024-10-14T01:48:07,091 INFO  [main {}] balancer.BalancerClusterState: server 0 is on rack 0 2024-10-14T01:48:07,091 INFO  [main {}] balancer.BalancerClusterState: server 1 is on rack 0 2024-10-14T01:48:07,091 INFO  [main {}] balancer.BalancerClusterState: server 2 is on rack 0 2024-10-14T01:48:07,091 INFO  [main {}] balancer.BalancerClusterState: server 3 is on rack 0 2024-10-14T01:48:07,091 INFO  [main {}] balancer.BalancerClusterState: server 4 is on rack 0 2024-10-14T01:48:07,091 INFO  [main {}] balancer.BalancerClusterState: server 5 is on rack 0 2024-10-14T01:48:07,092 INFO  [main {}] balancer.BalancerClusterState: server 6 is on rack 0 2024-10-14T01:48:07,092 INFO  [main {}] balancer.BalancerClusterState: server 7 is on rack 0 2024-10-14T01:48:07,092 INFO  [main {}] balancer.BalancerClusterState: server 8 is on rack 0 2024-10-14T01:48:07,092 INFO  [main {}] balancer.BalancerClusterState: server 9 is on rack 0 2024-10-14T01:48:07,284 INFO  [main {}] balancer.BaseLoadBalancer: Reassigned 30000 regions. 0 retained the pre-restart assignment. 30000 regions were assigned to random hosts, since the old hosts for these regions are no longer present in the cluster. These hosts were:    Time for retainAssignment         : 204ms 2024-10-14T01:48:07,284 INFO  [main {}] balancer.LoadBalancerPerformanceEvaluation: Calling balanceCluster 2024-10-14T01:48:07,315 INFO  [main {}] balancer.BalancerClusterState: server 0 is on rack 0 2024-10-14T01:48:07,315 INFO  [main {}] balancer.BalancerClusterState: server 1 is on rack 0 2024-10-14T01:48:07,315 INFO  [main {}] balancer.BalancerClusterState: server 2 is on rack 0 2024-10-14T01:48:07,323 INFO  [main {}] balancer.BalancerClusterState: server 3 is on rack 0 2024-10-14T01:48:07,323 INFO  [main {}] balancer.BalancerClusterState: server 4 is on rack 0 2024-10-14T01:48:07,323 INFO  [main {}] balancer.BalancerClusterState: server 5 is on rack 0 2024-10-14T01:48:07,323 INFO  [main {}] balancer.BalancerClusterState: server 6 is on rack 0 2024-10-14T01:48:07,323 INFO  [main {}] balancer.BalancerClusterState: server 7 is on rack 0 2024-10-14T01:48:07,323 INFO  [main {}] balancer.BalancerClusterState: server 8 is on rack 0 2024-10-14T01:48:07,323 INFO  [main {}] balancer.BalancerClusterState: server 9 is on rack 0 2024-10-14T01:48:07,325 ERROR [main {}] util.AbstractHBaseTool: Error running command-line tool java.lang.NullPointerException: Cannot invoke ""java.util.List.size()"" because ""this.candidateGenerators"" is null         at org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.initCosts(StochasticLoadBalancer.java:750) ~[hbase-balancer-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]         at org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.balanceTable(StochasticLoadBalancer.java:475) ~[hbase-balancer-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]         at org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer.balanceCluster(BaseLoadBalancer.java:620) ~[hbase-balancer-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]         at org.apache.hadoop.hbase.master.balancer.LoadBalancerPerformanceEvaluation.doWork(LoadBalancerPerformanceEvaluation.java:172) ~[hbase-balancer-4.0.0-alpha-1-SNAPSHOT-tests.jar:4.0.0-alpha-1-SNAPSHOT]         at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:150) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]         at org.apache.hadoop.hbase.master.balancer.LoadBalancerPerformanceEvaluation.main(LoadBalancerPerformanceEvaluation.java:181) ~[hbase-balancer-4.0.0-alpha-1-SNAPSHOT-tests.jar:4.0.0-alpha-1-SNAPSHOT]{code}" NPE when starting up the HBase 2.6.0 cluster if there's a temporal network delay with HDFS cluster,13595259,Open,Major,,13/Oct/24 20:13,,2.6.0,"I ran into an NPE exception when starting up the HBase 2.6.0 cluster This bug is non-deterministic. It happens rarely and likely requires certain concurrency control to trigger. h1. Description When starting up 2.6.0 HBase cluster: 1HM, 1RS and a HDFS cluster, some network delay between RS and HDFS cluster could lead to RS aborting with NPE. {code:java} 2024-09-28T07:59:33,183 WARN  [RS_OPEN_META-regionserver/hregion1:16020-0] handler.AssignRegionHandler: Failed to open region hbase:meta,,1.1588230740, will report to master org.apache.hadoop.hbase.FailedCloseWALAfterInitializedErrorException: Failed close after init wal failed.     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:164) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:59) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:323) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2513) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) ~[hbase-server-2.6.0.jar:2.6.0]     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_362]     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_362]     at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] Caused by: java.io.IOException: java.lang.NullPointerException     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.shutdown(AbstractFSWAL.java:1020) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.close(AbstractFSWAL.java:1046) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:162) ~[hbase-server-2.6.0.jar:2.6.0]     ... 8 more Caused by: java.lang.NullPointerException     at java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011) ~[?:1.8.0_362]     at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006) ~[?:1.8.0_362]     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.closeWriter(AsyncFSWAL.java:718) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doShutdown(AsyncFSWAL.java:775) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:992) ~[hbase-server-2.6.0.jar:2.6.0]     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:987) ~[hbase-server-2.6.0.jar:2.6.0]     at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_362]     ... 3 more {code} It cannot open hbase:meta region correctly. {*}The WAL is in a broken state{*}.    I tried to start up the HBase in another version (trunk: fdd8fa5) after the network delay between HBase and HDFS was recovered. However, the HMaster would also abort with the following exception {code:java} 2024-09-28T08:57:22,319 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master hmaster,16000,1727513781417: Unhandled exception. Starting shutdown. ***** java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILED     at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:384) ~[hbase-shaded-miscellaneous-4.1.8.jar:4.1.8]     at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:324) ~[hbase-shaded-miscellaneous-4.1.8.jar:4.1.8]     at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1565) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1218) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2535) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: org.apache.hadoop.hbase.TableNotFoundException: hbase:namespace     at java.lang.Thread.getStackTrace(Thread.java:1610) ~[?:?]     at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:144) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:163) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.client.AsyncTableResultScanner.next(AsyncTableResultScanner.java:173) ~[hbase-client-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.TableNamespaceManager.loadFromNamespace(TableNamespaceManager.java:126) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.TableNamespaceManager.loadNamespaceIntoCache(TableNamespaceManager.java:168) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:175) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:61) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:252) ~[hbase-shaded-miscellaneous-4.1.8.jar:4.1.8]     at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1562) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1218) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2535) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]     at java.lang.Thread.run(Thread.java:833) ~[?:?] {code}   I need to manually remove all files stored in HDFS and do a fresh restart of HBase to resolve this problem. I attached my HM and RS logs to this ticket. I think a better way could be to avoid writing broken WAL to disk, which likely would block the restart/upgrade. In that case, users do not need to clear the entire disk state manually." Ranger doesn't work with hbase 2.6 when using hadoop 3.3.6,13594638,Resolved,Major,Duplicate,08/Oct/24 12:21,08/Oct/24 12:24,2.5.0,"Hello,  I have this issue on my stack {code:java} 2024-09-23T08:12:51.336Z - ERROR [PolicyRefresher(serviceName=hbase-tdp)-196:Errors@168] - The following errors and warnings have been detected with resource and/or provider classes:   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONListElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for field: javax.ws.rs.core.UriInfo com.sun.jersey.server.impl.template.ViewableMessageBodyWriter.ui   SEVERE: Missing dependency for field: com.sun.jersey.spi.template.TemplateContext com.sun.jersey.server.impl.template.ViewableMessageBodyWriter.tc   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONListElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JacksonProviderProxy.setFeaturesAndProperties(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 1   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONJAXBElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONJAXBElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0 {code} The issue is that jersey-json and jersey-jar are missing on the hbase plugin The solution is to add this lines to distro/src/main/assembly/hbase-agent.xml under  lib/ranger-hbase-plugin-impl {code:java} com.sun.jersey:jersey-json:jar:${jersey-bundle.version}Line58added     com.sun.jersey:jersey-server:jar:${jersey-bundle.version}Line59added   com.sun.jersey:jersey-servlet:jar:${jersey-bundle.version} {code}    " Add metrics around FSFT backed file reads and updates,13594522,Open,Major,,07/Oct/24 14:45,,,"With HBASE-27826, number of interactions via SFT layer would increase, as all the interactions of StoreFiles going forward would require StoreFileTracker context and that would increase the number of reads to inherent backed file of FileBaseStoreFileTracker, this would add metrics on number of times we read/update backed file " Performance regression from 2.5.8 to 2.6.0 when seeking SEEK_NEXT_USING_HINT to a next column family.,13594315,Open,Major,,04/Oct/24 13:42,,2.6.0,"We have a custom hbase filter that seeks (SEEK_NEXT_USING_HINT) to a next column family (called ""cf"" in our case) based on data in a cell in a prior column family (called ""bf_slicing""). We upgraded to hbase 2.6.0 from 2.5.8, the change in this ticket https://issues.apache.org/jira/browse/HBASE-27788 caused a significant performance degradation (from instant seeking to the next family to traversing the entire bf_slicing family). We traced the cause to the following: When comparing families here, the 'cf' family is ordered lower than 'bf_slicing' due to its length, causing the first column family (""bf_slicing"") to be fully traversed. The offending code is here: [https://github.com/apache/hbase/pull/5171/files#diff-1ec9654ed8e00f46e11430fc726f8351db59597723efa0bf1e268196f00244c6R54] The original story (HBASE_27788) mentions no seeking should be done outside a column family, but our use case seems legitimate in the data model, so we think this is a bug.  The attached screenshot shows a jprofiler dump with invocation counts showing it is traversing all data (going to 12M cells in this case), this is on hbase 2.6.0 [^Screenshot from 2024-10-04 15-52-32.png]" Explore adopting Revapi for compatibility reporting in PRs and RCs,13594276,Open,Major,,04/Oct/24 07:55,,,"The first release candidate of 2.6.1 had quite a few incompatible changes. It would be great to surface issues at the time when changes are bring introduced, instead of at release time. Our current API Compatibility report is quite nice, but is driven by a program that carries a restrictive license and so we haven't been able to deploy it widely. It happens that I was looking at another ASF project this week and noticed that they do have compatibility checking in pre-commit, powered by [Revapi|https://revapi.org/], which has the Apache v2 license." Automate organization of pom.xml using spotless,13594156,Open,Major,,03/Oct/24 09:37,,,"In our codebase, dependencies in POM files should be auto organized such that test dependencies are listed after compile dependencies. To ensure this is consistently applied across the project, we will utilize the {{sortPom}} functionality provided by the Spotless plugin. See discussion here: [https://github.com/apache/hbase/pull/6258#discussion_r1784337008]   CC: [~ndimiduk], [~stoty] " RefCnt Leak error when closing a HalfStoreFileReader,13593877,Resolved,Major,Fixed,01/Oct/24 11:34,02/Oct/24 15:37,2.7.0,"In HBASE-28596 we have added ability for references to get resolved to the original file blocks in bucket cache. As part of this, we had to modify HalfStoreFileReader.close method, to create a scanner and seek to boundary cell in order to get the related offset and calculate the limiting offset for blocks we want to evict. We missed close the scanner instance there, which then cause the refcount leaks reported as below: {noformat} 2024-09-25 14:24:51,292 ERROR org.apache.hbase.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: RefCnt.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information. Recent access records: Created at: org.apache.hadoop.hbase.nio.RefCnt.(RefCnt.java:59) org.apache.hadoop.hbase.nio.RefCnt.create(RefCnt.java:54) org.apache.hadoop.hbase.nio.ByteBuff.wrap(ByteBuff.java:550) org.apache.hadoop.hbase.io.ByteBuffAllocator.allocate(ByteBuffAllocator.java:357) org.apache.hadoop.hbase.io.hfile.bucket.FileIOEngine.read(FileIOEngine.java:134) org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:666) org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.getBlock(CombinedBlockCache.java:98) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.getCachedBlock(HFileReaderImpl.java:1102) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1287) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1248) org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$CellBasedKeyBlockIndexReader.loadDataBlockWithScanInfo(HFileBlockIndex.java:318) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:670) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:623) org.apache.hadoop.hbase.io.HalfStoreFileReader.close(HalfStoreFileReader.java:368) org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(HStore.java:2352) org.apache.hadoop.hbase.regionserver.HStore.closeAndArchiveCompactedFiles(HStore.java:2314) org.apache.hadoop.hbase.regionserver.CompactedHFilesDischargeHandler.process(CompactedHFilesDischargeHandler.java:41) org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) {noformat}" "Resuming a release build from stage ""publish-dist"" fails due to missing CHANGES.md and RELEASENOTES.md",13593850,Open,Major,,01/Oct/24 06:58,,,"The do-release scripts seem to be built to support resuming a partial release from a ""stage"". I found that resuming a release at the ""publish-dist"" stage fails due to missing CHANGES.md and RELEASENOTES.md. The script appears to assume the files are present in the output directory, which won't be the case if the output directory is cleaned after the previous failed attempt. These files are populated via the ""tag"" stage." Refactor BackupHFileCleaner + fix test,13601874,In Progress,Minor,,12/Dec/24 15:54,,2.6.0,"The TestBackupHFileCleaner test is broken, as it uses a different API to register bulk loads than the API that is actually used to register bulk loads during backups. The test also incorrectly closes the FS of the HBaseTestingUtil, causing this test to block for about 5 minutes during shutdown. Both the test and BackupHFileCleaner itself are overly convoluted and should be cleaned up. This is another intermediate step towards fixing HBASE-28715." Set UncaughtException Handler for RegionServer ExecutorService,13603096,Resolved,Minor,Fixed,24/Dec/24 08:06,03/Feb/25 10:26,2.5.10,"In an HBase cluster, we encountered a scenario where the RegionServer crash procedure (SCP) took for more than 3 hours to complete. The incident was triggered by temporary network unavailability in the HBase cluster. Upon debugging, we found that the SCP was stuck due to the child SplitWALProcedure, which was waiting for the completion of the SplitWALRemote procedure by the RegionServer worker. While executing, the SplitWALRemote procedure encountered an unknown exception. The logs show an error message: ""hdfs.DataStreamer - No ack received,"" indicating an issue with the RegionServer's connection to the DataNode. After this error, the thread either became stuck or terminated, as no related logs were available. During this period, inconsistent regions were reported. Worker RS was healthy and didn't reported any signs of abort or unhealthy. All procedures were restarted and completed successfully after the Active HMaster service was bounced. We might need to setUncaughtExecptionHandler [here|[link|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java#L255]] Related logs: [HMASTER-4] 2024-12-05 14:55:11,264 INFO [PEWorker-41] procedure2.ProcedureExecutor - Initialized subprocedures=[ {pid=6003288, ppid=6002575, state=RUNNABLE; SplitWALRemoteProcedureregionserver-53.regionserver.hbase.hbasexxxxxx. %2Cxxxxx%2C1730886070174.1733410178680, worker=regionserver-15.regionserver.xxxxx,1730878238028} ] [RS-15] 2024-12-05 14:55:11,461 DEBUG [iority.RWQ.Fifo.read.handler=83,queue=2,port=xxxx] regionserver.RSRpcServices - Executing remote procedure classorg.apache.hadoop.hbase.regionserver.SplitWALCallable, pid=6003288 [RS-15] 2024-12-05 14:55:54,689 ERROR [split-log-closeStream-pool-0] hdfs.DataStreamer - No ack received, took 25002ms (threshold=25000ms). File being written: /hbase/data/default/tsdb/c997c5f8dd36481dcd3ebb9b79a35b51/recovered.edits/0000000000539451088-regionserver-53.regionserver.hbase.hbasexxa.xxxxx.is%2Cxxxxx%2C1730886070174.1733410178680.temp, block: BP-1745262640-10.60.130.13-1712173738392:blk_1330710217_257120451, Write pipeline datanodes: [DatanodeInfoWithStorage[10.60.52.107:xxxxx,DS-f2b7ba1a-68b5-433a-9fe8-99315a172098,SSD], DatanodeInfoWithStorage[10.60.75.52:xxxxxx,DS-93a433be-972f-4457-92ae-dd07288e41b5,SSD]]. [HMASTER-1] 2024-12-05 18:11:42,036 DEBUG [master/hmaster-1:xxxxx:becomeActiveMaster] store.ProcedureTree -Procedure Procedure(pid=6003288, ppid=6002575, class=org.apache.hadoop.hbase.master.procedure.SplitWALRemoteProcedure) stack ids=[3592] [HMASTER-1] 2024-12-05 18:11:42,214 DEBUG [master/hmaster-1:xxxxx:becomeActiveMaster] procedure2.ProcedureExecutor - Loading pid=6003288, ppid=6002575, state=RUNNABLE; SplitWALRemoteProcedure regionserver-53.regionserver.hbase.xxxxxx.is%2C60020%2C1730886070174.1733410178680, worker=regionserver-15.regionserver.hbase.hbasexxa.xxxxx.is,xxxxx,1730878238028 [RS-15] 2024-12-05 18:11:42,769 DEBUG [iority.RWQ.Fifo.read.handler=79,queue=7,port=60020] regionserver.RSRpcServices - Executing remote procedure classorg.apache.hadoop.hbase.regionserver.SplitWALCallable, pid=6003288 [RS-15] 2024-12-05 18:11:48,247 DEBUG [_REPLAY_OPS-regionserver/regionserver-15:xxxxx-192] regionserver.RemoteProcedureResultReporter - Successfully complete execution of pid=6003288 [HMASTER-1] 2024-12-05 18:11:48,304 INFO [PEWorker-2] procedure2.ProcedureExecutor - Finished pid=6002575, ppid=6000775, state=SUCCESS; SplitWALProcedureregionserver-53.regionserver.hbase.hbasexxa.xxxxxxx.is%2Cxxxxx%2C1730886070174.1733410178680, worker=regionserver-15.regionserver.hbase.hbasexxa.xxxxxx,xxxxxx,1730878238028 in 3 hrs, 16 mins, 52.806 sec" NPE in processRS.jsp due to failure to get value from MBean,13602897,Resolved,Minor,Fixed,20/Dec/24 22:00,14/Feb/25 14:55,2.5.10,"Fetching processRS.jsp from a RegionServer occasionally causes a NullPointerException. First an ERROR is reported that JSONMetricUtil is unable to get a value from MBean, ""pauseWarnThresholdExceeded"" and then there is an NPE rendering the page on the line that tries to cast that MBean value to a long.   {code:java} ERROR [qtp1510333744-119] util.JSONMetricUtil: Unable to get value from MBean= Hadoop:service=HBase,name=RegionServer,sub=Serverfor attribute=pauseWarnThresholdExceeded Hadoop:service=HBase,name=RegionServer,sub=Server WARN  [qtp1510333744-119] server.HttpChannel: /processRS.jsp java.lang.NullPointerException     at org.apache.hadoop.hbase.generated.regionserver.processRS_jsp._jspService(processRS_jsp.java:83)     at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)     at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656)     at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:117)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)     at org.apache.hadoop.hbase.http.SecurityHeadersFilter.doFilter(SecurityHeadersFilter.java:65)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)     at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:49)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)     at org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1521)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)     at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:47)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1626)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:552)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)     at org.apache.hbase.thirdparty.org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)     at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.handle(Server.java:516)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)     at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277)     at org.apache.hbase.thirdparty.org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)     at org.apache.hbase.thirdparty.org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)     at org.apache.hbase.thirdparty.org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)     at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:338)     at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:315)     at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:173)     at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)     at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:409)     at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)     at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)     at java.base/java.lang.Thread.run(Unknown Source) {code}" Make PerformanceEvaluation support larger data sets,13600665,Resolved,Minor,Fixed,03/Dec/24 03:42,29/Dec/24 13:03,,"The use of 4-byte integers in PerformanceEvaluation can be limiting when you want to test with larger data sets. Suppose you want to generate 10TB of data with the default value size of 1KB, you would need 10G rows. {code:java} bin/hbase pe --nomapred --presplit=21 --compress=LZ4 --rows=10737418240 randomWrite 1 {code} But you can't do it because {{--rows}} expect a number that can be represented with 4 bytes. {noformat} java.lang.NumberFormatException: For input string: ""10737418240"" {noformat} We can instead increase the value size and decrease the number of the rows to circumvent the limitation, but I don't see a good reason to have the limitation in the first place. And even if we use a smaller value for {{{}--row{}}}, we can accidentally cause integer overflow as we increase the number of clients. {code:java} bin/hbase pe --nomapred --compress=LZ4 --rows=1073741824 randomWrite 20 {code} {noformat} 2024-12-03T12:21:10,333 INFO [main {}] hbase.PerformanceEvaluation: Created 20 connections for 20 threads 2024-12-03T12:21:10,337 INFO [TestClient-5 {}] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$RandomWriteTest at offset 1073741824 for 1073741824 rows 2024-12-03T12:21:10,337 INFO [TestClient-1 {}] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$RandomWriteTest at offset 1073741824 for 1073741824 rows 2024-12-03T12:21:10,337 INFO [TestClient-3 {}] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$RandomWriteTest at offset -1073741824 for 1073741824 rows 2024-12-03T12:21:10,337 INFO [TestClient-4 {}] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$RandomWriteTest at offset 0 for 1073741824 rows 2024-12-03T12:21:10,337 INFO [TestClient-7 {}] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$RandomWriteTest at offset -1073741824 for 1073741824 rows 2024-12-03T12:21:10,337 INFO [TestClient-8 {}] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$RandomWriteTest at offset 0 for 1073741824 rows ... 2024-12-03T12:21:10,338 INFO [TestClient-17 {}] hbase.PerformanceEvaluation: Sampling 1 every 0 out of 1073741824 total rows. 2024-12-03T12:21:10,338 INFO [TestClient-16 {}] hbase.PerformanceEvaluation: Sampling 1 every 0 out of 1073741824 total rows. 2024-12-03T12:21:10,338 INFO [TestClient-6 {}] hbase.PerformanceEvaluation: Sampling 1 every 0 out of 1073741824 total rows. 2024-12-03T12:21:10,338 INFO [TestClient-4 {}] hbase.PerformanceEvaluation: Sampling 1 every 0 out of 1073741824 total rows. ... java.io.IOException: java.lang.ArithmeticException: / by zero at org.apache.hadoop.hbase.PerformanceEvaluation.doLocalClients(PerformanceEvaluation.java:540) at org.apache.hadoop.hbase.PerformanceEvaluation.runTest(PerformanceEvaluation.java:2674) at org.apache.hadoop.hbase.PerformanceEvaluation.run(PerformanceEvaluation.java:3216) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:97) at org.apache.hadoop.hbase.PerformanceEvaluation.main(PerformanceEvaluation.java:3250) {noformat} So I think it's best that we just use 8-byte long integers throughout the code.  " Output fsreadtime in SlowLogPayLoad to hbase:slowlog,13597758,Resolved,Minor,Fixed,05/Nov/24 11:32,12/Dec/24 20:47,, Append REST endpoint invoked with not existing column family or table returns Exception stack trace,13600587,Resolved,Minor,Invalid,02/Dec/24 12:51,11/Dec/24 13:48,4.0.0-alpha-1,"h2. Scenario Calling append REST operation with not existing column family or table. h2. Actual result Returns Exception stack trace in response body - *NOK* (x) h2. Expected result Should not return the Exception stack trace in response body. h2. How to reproduce TestRowResource table does NOT exists: {code:java} curl -vi -X PUT \ -H ""Content-type: application/json"" \ -H ""Accept: application/json"" \ -d '{""Row"":[{""key"":""dGVzdHJvdzE="",""Cell"":[{""column"":""YTox"",""$"":""dGVzdHZhbHVlMgo=""},{""column"":""YToy"",""$"":""dGVzdHZhbHVlMTIK""}]}]}' \ ""http://localhost:8080/TestRowResourcea/testrow1?check=append"" * Host localhost:8080 was resolved. * IPv6: ::1 * IPv4: 127.0.0.1 * Trying [::1]:8080... * Connected to localhost (::1) port 8080 > PUT /TestRowResourcea/testrow1?check=append HTTP/1.1 > Host: localhost:8080 > User-Agent: curl/8.9.1 > Content-type: application/json > Accept: application/json > Content-Length: 123 > * upload completely sent off: 123 bytes < HTTP/1.1 404 Not Found HTTP/1.1 404 Not Found < X-Frame-Options: DENY X-Frame-Options: DENY < X-Content-Type-Options: nosniff X-Content-Type-Options: nosniff < X-XSS-Protection: 1; mode=block X-XSS-Protection: 1; mode=block < Content-Type: text/plain Content-Type: text/plain < Transfer-Encoding: chunked Transfer-Encoding: chunked < Not found org.apache.hadoop.hbase.TableNotFoundException: TestRowResourcea at java.base/java.lang.Thread.getStackTrace(Thread.java:1619) at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:144) at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:163) at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:186) at org.apache.hadoop.hbase.client.TableOverAsyncTable.append(TableOverAsyncTable.java:325) at org.apache.hadoop.hbase.rest.RowResource.append(RowResource.java:702) at org.apache.hadoop.hbase.rest.RowResource.update(RowResource.java:183) at org.apache.hadoop.hbase.rest.RowResource.put(RowResource.java:324) ... {code} Create TestRowResource table with column family ""a"". Call append with column family ""cf"": {code:java} curl -vi -X PUT \ -H ""Accept: text/xml"" \ -H ""Content-Type: text/xml"" \ -d 'dmFsdWU1Cg==' \ ""http://localhost:8080/TestRowResource/testrow1?check=append"" * Host localhost:8080 was resolved. * IPv6: ::1 * IPv4: 127.0.0.1 * Trying [::1]:8080... * Connected to localhost (::1) port 8080 > PUT /TestRowResource/testrow1?check=append HTTP/1.1 > Host: localhost:8080 > User-Agent: curl/8.9.1 > Accept: text/xml > Content-Type: text/xml > Content-Length: 143 > * upload completely sent off: 143 bytes < HTTP/1.1 404 Not Found HTTP/1.1 404 Not Found < X-Frame-Options: DENY X-Frame-Options: DENY < X-Content-Type-Options: nosniff X-Content-Type-Options: nosniff < X-XSS-Protection: 1; mode=block X-XSS-Protection: 1; mode=block < Content-Type: text/plain Content-Type: text/plain < Transfer-Encoding: chunked Transfer-Encoding: chunked < Not found org.apache.hadoop.hbase.regionserver.NoSuchColumnFamilyException: org.apache.hadoop.hbase.regionserver.NoSuchColumnFamilyException: Column family cf does not exist in region TestRowResource,,1732811650328.776b1d03b9852a83de1f77688b16865d. in table 'TestRowResource', {TABLE_ATTRIBUTES => {METADATA => {'hbase.store.file-tracker.impl' => 'DEFAULT'}}}, {NAME => 'a', INDEX_BLOCK_ENCODING => 'NONE', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536 B (64KB)'}, {NAME => 'b', INDEX_BLOCK_ENCODING => 'NONE', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536 B (64KB)'} at org.apache.hadoop.hbase.regionserver.HRegion.checkFamily(HRegion.java:5376) at org.apache.hadoop.hbase.regionserver.HRegion.checkFamily(HRegion.java:5363) at org.apache.hadoop.hbase.regionserver.HRegion.checkFamilies(HRegion.java:5357) at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.checkAndPrepareMutation(HRegion.java:3508) at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.checkAndPrepareMutation(HRegion.java:3515) at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation$1.visit(HRegion.java:3899) at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3394) at org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.checkAndPrepare(HRegion.java:3878) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4779) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4699) at org.apache.hadoop.hbase.regionserver.HRegion.mutate(HRegion.java:5194) at org.apache.hadoop.hbase.regionserver.HRegion.lambda$append$31(HRegion.java:8087) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) at org.apache.hadoop.hbase.regionserver.HRegion.append(HRegion.java:8081) at org.apache.hadoop.hbase.regionserver.RSRpcServices.append(RSRpcServices.java:699) at org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2972) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:43506) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:444) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) ... {code} " The slow response log output by RpcServer contains the request size.,13601306,Open,Minor,,09/Dec/24 02:10,,, [HBCK2] filesystem command always report region hole and doesn't exit automatically,13596559,Resolved,Minor,Fixed,24/Oct/24 07:54,22/Nov/24 09:41,,"1. When executing hbck2 filesystem command, it always reports region hole for all region like: {code:java} ERROR: There is a hole in the region chain between  and .  You need to create a new .regioninfo and region dir in hdfs to plug the hole. ERROR: Found inconsistency in table hbase:meta ERROR: There is a hole in the region chain between  and .  You need to create a new .regioninfo and region dir in hdfs to plug the hole. ERROR: Found inconsistency in table hbase:namespace{code}   The reason for this problem is that the region directories are not loaded at all. In hbck1, the process will load all region directories by default. 2. After the check is completed, the process will not exit automatically because the hbasefsck threads are not daemon threads." Fix memStoreSize metric for a table and add heap and off-heap size metrics,13599464,In Progress,Minor,,21/Nov/24 03:17,,,"The ""memStoreSize"" metric for a table is incorrect as it reports the sum of the data size, the heap size, and the off-heap size, while ""memStoreSize"" metric for a region or a region server is just the data size. https://github.com/apache/hbase/blob/e082405d8e7fa5c9b89e7af3153f022731168ecb/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableWrapperAggregateImpl.java#L79-L80 We should fix it to report only the data size for consistency and add additional metrics, similarly to HBASE-27892, not to lose the extra information for understanding the flush behavior. * {{memStoreHeapSize}} * {{memStoreOffHeapSize}}" Prefetch thread shouldn't run for master store,13597600,Resolved,Minor,Fixed,04/Nov/24 10:43,18/Nov/24 12:37,2.6.1,"The master store is hosted on Master processes. Since masters don't have a BlockCache, we shouldn't run a prefetch thread at all, when opening the master store region. Currently, this is causing a NoSuchElementException to be logged in master logs, which although harmless, can be confusing for operators: {noformat} 2024-10-23 15:23:29,236 WARN org.apache.hadoop.hbase.io.hfile.HFileReaderImpl: Prefetch path=s3a://odx-qe-bucket/cc-odx-coy6zg/cod-udzhubgp5l5k/hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682/proc/336a510d9f9a472c9e2a8f3e00352e3b, offset=0, end=82012 java.util.NoSuchElementException: No value present at java.base/java.util.Optional.get(Optional.java:143) at org.apache.hadoop.hbase.io.hfile.HFilePreadReader$1.run(HFilePreadReader.java:73) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecute {noformat}    " Add dry-run mode to RegionSplitter,13599211,Open,Minor,,19/Nov/24 06:41,,,"Currently RegionSplitter immediately starts splitting a table after logging splits it going to perform, so we don't have a chance to review the splits before actually performing splits. Dry-run mode would log the splits it going to perform without actually making changes to a table." Remove dead code: MemStore upsert,13599063,In Progress,Minor,,18/Nov/24 03:54,,,"Since HBASE-24602, we no longer perform MemStore upsert for increment and append operations, and we can remove the dead code." Improve the log message with parameterized logging in LRUBlockCache,13598369,Open,Minor,,11/Nov/24 12:49,,,Improve the log message with parameterized logging in LRUBlockCache.java and LRUAdaptiveBlockCache.java Test results for backwards compatibility tests are not distinguishable in Jenkins reports,13598021,Open,Minor,,07/Nov/24 08:22,,,"The failures are listed like this: * [health checks / yetus jdk17 hadoop3 backwards compatibility checks / org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1201/testReport/junit/org.apache.hadoop.hbase.regionserver.wal/TestAsyncWALReplay/health_checks___yetus_jdk17_hadoop3_backwards_compatibility_checks_______2/] We can determine which version failed by checking the console output of the individual maven jobs, but this is not ideal." hbase mapredcp returns unshaded jars when run from source directory,13597704,Open,Minor,,05/Nov/24 04:53,,,"It should return hbase-shaded-mapreduce + aux jars, same as when it is run from the proper assembly." Run Hadoop3 backward compatibility checks in parallel,13596676,Open,Minor,,25/Oct/24 05:53,,,"Adding the backwards compatibility cheks has increased the Nightly check runtime from ~9 hours to ~12 hours. My initial estimate for running the devTests was two hours, but it's actually four hours on the test runners. Run the backwards compatibility tests in parallel. Also consider running the older JDK8,JDK11 tests in parallel, perhaps by moving everything into a matrix section." "Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][])",13595716,Open,Minor,,16/Oct/24 18:08,,,"An unrelated spotbug warning popped up in one of precommit test. [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6342/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html]   h2. Bad practice Warnings ||Code||Warning|| |DMI|Random object created and used only once in org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][])| | |[Bug type DMI_RANDOM_USED_ONLY_ONCE (click for details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6342/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html#DMI_RANDOM_USED_ONLY_ONCE] In class org.apache.hadoop.hbase.util.LoadTestKVGenerator In method org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, byte[][]) Called method java.util.Random.nextBytes(byte[]) At LoadTestKVGenerator.java:[line 111]| h1. Details h2. DMI_RANDOM_USED_ONLY_ONCE: Random object created and used only once This code creates a java.util.Random object, uses it to generate one random number, and then discards the Random object. This produces mediocre quality random numbers and is inefficient. If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number is required invoke a method on the existing Random object to obtain it. If it is important that the generated Random numbers not be guessable, you _must_ not create a new Random for each random number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead (and avoid allocating a new SecureRandom for each random number needed)." "Within the bulkLoadThinRows method of HBaseContext, whether to consider obtaining the BloomFilter and compression attributes of the column family from the table schema",13595074,Open,Minor,,11/Oct/24 11:30,,,"Within the bulkLoadThinRows method of HBaseContext, whether to consider obtaining the BloomFilter and compression attributes of the column family from the table attributes" Skip excessive evaluations of LINK_NAME_PATTERN and REF_NAME_PATTERN regular expressions,13594432,Resolved,Minor,Fixed,06/Oct/24 13:02,09/Oct/24 09:04,2.6.0,"To test if a file is a link file, HBase checks if its file name matches the regex {code:java} ^(?:((?:[_\p{Digit}\p{IsAlphabetic}]+))(?:\=))?((?:[_\p{Digit}\p{IsAlphabetic}][-_.\p{Digit}\p{IsAlphabetic}]*))=((?:[a-f0-9]+))-([0-9a-f]+(?:(?:_SeqId_[0-9]+_)|(?:_del))?)$ {code} To test if an HFile has a ""reference name,"" HBase checks if its file name matches the regex {code:java} ^([0-9a-f]+(?:(?:_SeqId_[0-9]+_)|(?:_del))?|^(?:((?:[_\p{Digit}\p{IsAlphabetic}]+))(?:\=))?((?:[_\p{Digit}\p{IsAlphabetic}][-_.\p{Digit}\p{IsAlphabetic}]*))=((?:[a-f0-9]+))-([0-9a-f]+(?:(?:_SeqId_[0-9]+_)|(?:_del))?)$)\.(.+)$ {code} Matching against these big regexes is computationally expensive. HBASE-27474 introduced (in 2.6.0) [code in a hot path|https://github.com/apache/hbase/blob/1602c531b245b4d455b48161757cde2ec3d1930b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java#L1716] in {{HFileReaderImpl}} that checks whether an HFile is a link or reference file while deciding whether to cache blocks from that file. In flamegraphs taken at my company during performance tests, this meant that these regex evaulations take 2-3% of the CPU time on a busy RegionServer. Later, the hot-path invocation of the regexes was removed in HBASE-28596 in branch-2 and later, but not branch-2.6, so only the 2.6.x series suffers the performance regression. Nonetheless, all invocations of these regexes are still unnecessarily expensive and can be fast-failed easily. The link name pattern contains a literal ""="", so any string that does not contain a ""="" can be assumed to not match the regex. The reference name pattern contains a literal ""."", so any string that does not contain a ""."" can be assumed to not match the regex. This optimization is mostly helpful in 2.6.x, but is valid in all branches. Running performance tests of this optimization removed the regex evaluations from my flamegraphs entirely, and reduced query latency by 15%. Some charts are attached." Update vote template to also propose an email subject line,13593859,Open,Minor,,01/Oct/24 08:54,,,"The create-release scripts propose an email for the VOTE thread, populated by the details of the release candidate. This template should also include a proposed subject line for the email." "Fix incorrect description of ""sampleRate"" option of PerformanceEvaluation",13602998,Resolved,Trivial,Fixed,23/Dec/24 07:19,13/Jan/25 12:33,,"{{hbase pe}} says {{sampleRate}} option is only for {{{}randomRead{}}}, but this is not true since HBASE-10788." Use HDFS port 9000 in examples,13601026,Resolved,Trivial,Fixed,05/Dec/24 13:15,09/Dec/24 14:31,,"Modern HDFS uses port 9000 by default, update the example(s) to be more copy-paste friendly." Remove redundant hadoop-two.version specification in shaded poms,13598011,Resolved,Trivial,Duplicate,07/Nov/24 06:30,07/Nov/24 07:58,,"On branch-2.x, we explicitly set the hadoop-hdfs version to ${hadoop-two.version} We don't do that for the rest of the hadoop artifacts, and the managed version is already set to 2.10.2 when using the Hadoop 2 profile, so this is unneccessary." Introduce a general 'local region' to store data on master,13306377,Resolved,Blocker,Fixed,21/May/20 06:20,23/May/20 08:46,,"We already have a local region to store the procedure data and when implementing HBASE-11288, splittable meta, we are thinking of also storing the data for root table in a local region. Now in the patch for HBASE-24388, we introduced another local region to store the data for root table, but maybe it is better to store the procedure data and root table together in a single region(with different families). And this should be done before 2.3.0, to prevent shipping the procedure store region out in a release. Set it a blocker for 2.3.0. Patch will be available soon." The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange,13309121,Resolved,Blocker,Fixed,03/Jun/20 07:25,05/Jun/20 07:41,,"In this method, we will copy all the fields, including RegionName and EncodedRegionName of the RegionInfo, so after we changed some other fields like start key or stop key or replica id, and then create a new RegionInfo, the RegionName of the RegionInfo will not be regenerated and cause problem." HdfsFileStatus incompatibility when used with Hadoop 3.1.3 and Hbase version 2.2.4,13297380,Resolved,Blocker,Not A Bug,09/Apr/20 13:23,23/Apr/20 12:23,2.2.4,"Hi,  Even after compiling from source  I am getting below error message. Hbasse master start without any issue, but region server fails with below message handler.AssignRegionHandler: Fatal error occurred while opening region hbase:meta,,1.1588230740, aborting... java.lang.IncompatibleClassChangeError: Found interface org.apache.hadoop.hdfs.protocol.HdfsFileStatus, but class was expected at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:496) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$400(FanOutOneBlockAsyncDFSOutputHelper.java:116) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$8.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:576) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$8.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:571) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:584) at org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:51) at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:169) at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:166) at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:113) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:643) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:126) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:767) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:501) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:442) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61) at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:284) at org.apache.hadoop.hbase.regionserver.HRegionServer.getWAL(HRegionServer.java:2181) at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:133) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)" [JDK11] shell fails to launch,13300108,Resolved,Blocker,Cannot Reproduce,21/Apr/20 23:02,15/Sep/20 16:17,3.0.0-alpha-1,"{noformat} $ JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home ./bin/hbase shell WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.apache.hadoop.hbase.util.UnsafeAvailChecker (file:/Users/ndimiduk/repos/apache/hbase/hbase-common/target/hbase-common-3.0.0-SNAPSHOT.jar) to method java.nio.Bits.unaligned() WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.util.UnsafeAvailChecker WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release HBase Shell Use ""help"" to get list of supported commands. Use ""exit"" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/book.html#shell Version 3.0.0-SNAPSHOT, rbcacc4ce939e60fd69891df6315a39aef852b567, Tue Apr 21 15:47:27 PDT 2020 Took 0.0000 seconds ArgumentError: wrong number of arguments (1 for 0) ` at uri:classloader:/jruby/kernel/jruby/process_manager.rb:32 ` at uri:classloader:/jruby/kernel/jruby/process_manager.rb:54 initialize at /Users/ndimiduk/repos/apache/hbase/hbase-shell/src/main/ruby/irb/hirb.rb:46 start at /Users/ndimiduk/repos/apache/hbase/bin/../bin/hirb.rb:207
at /Users/ndimiduk/repos/apache/hbase/bin/../bin/hirb.rb:219 {noformat}" async client deadlock,13309564,Resolved,Blocker,Fixed,05/Jun/20 00:34,08/Jun/20 02:21,2.2.4,"I ran into an issue where one instance in a cluster of application servers backed by HBase stopped processing requests. Looking at a thread dump, it seems HBase client threads are deadlocked: https://pastebin.com/raw/B3FJL1Ag The deadlock seemed to happen at the same time that a region server was abruptly stopped (the physical server was restarted unexpectedly). I'm using the hbase async API. The hbase client version is 2.2.4. The server is running 2.2.4 as well." Reimplement Hbck.setRegionStateInMeta,13309437,Resolved,Blocker,Fixed,04/Jun/20 12:08,05/Jun/20 07:37,, Rename LocalRegion to MasterRegion,13308417,Resolved,Blocker,Fixed,29/May/20 23:57,02/Jun/20 18:14,,"This is a suggestion by [~ndimiduk] when reviewing the PR for HBASE-24408. https://github.com/apache/hbase/pull/1753#discussion_r432783115 I think this can make the code less confusing." Unable to start HRegionserver and Master node considers as a dead region,13300432,Resolved,Blocker,Invalid,23/Apr/20 04:41,14/May/20 10:27,,"Hi Team, I am currently using Apache Hbase version - 1.3.6 and I am trying to run Master and region server separately and then join the cluster dynamically but it was region server was not starting and hangs at ""*The RegionServer is initializing*!"" Commands used as below: (Master and region are on separate nodes ) Node A - Hbase Master - */opt/hbase/bin/hbase-daemon.sh --config /usr/local/bin/hbase/conf start master* Node B - Hbase Region - */opt/hbase/bin/hbase-daemon.sh --config /usr/local/bin/hbase/conf start regionserver* *{color:#ff0000}Please advice If the above command is the right way to start hbase master and region{color}* Environment - *Google Compute Engine (GCE) Instance groups/VM's* OS Type - *CentOS -7* Master running ports *- 16000.tcp 16010/web*  Region server running ports *- 16020/tcp* *16030/web* Also not sure on how to enable reverse DNS across both the machines and whether that is the problem and please do advice on how do i achieve it *Master logs:* From the below master logs it clearly says that master is trying to connect to region and then eventually getting disconnected from the client region server  * *{color:#ff0000}""{color}{color:#ff0000}*DEBUG [RpcServer.reader=1,bindAddress=pinpoint-master-v000-rh5k.c.gcp-ushi-telemetry-npe.internal,port=16000] ipc.RpcServer: RpcServer.listener,port=16000: DISCONNECTING client 10.148.6.13:45732 because read count=-1. Number of active connections: 1*{color}""* *complete logs* 2020-04-22 19:38:24,812 DEBUG [RpcServer.listener,port=16000] ipc.RpcServer: RpcServer.listener,port=16000: connection from 10.148.6.13:45732; # active connections: 1 2020-04-22 19:38:24,961 DEBUG [RpcServer.FifoWFPBQ.default.handler=29,queue=2,port=16000] ipc.RpcServer: RpcServer.FifoWFPBQ.default.handler=29,queue=2,port=16000: callId: 0 service: RegionServerStatusService methodName: RegionServerStartup size: 47 connection: 10.148.6.13:45732 2020-04-22 19:38:30,591 DEBUG [*pinpoint-master-v000-rh5k:16000*.activeMasterManager] ipc.RpcClientImpl: Connecting to *pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020* 2020-04-22 19:38:31,268 *DEBUG [hconnection-0x5f02b9cb-shared--pool3-t1] ipc.RpcClientImpl: Connecting to pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020* 2020-04-22 19:38:31,478 DEBUG [ProcedureExecutor-3] ipc.RpcClientImpl: Connecting to pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020 2020-04-22 19:39:32,714 *DEBUG [RpcServer.reader=1,bindAddress=pinpoint-master-v000-rh5k.c.gcp-ushi-telemetry-npe.internal,port=16000] ipc.RpcServer: RpcServer.listener,port=16000: DISCONNECTING client 10.148.6.13:45732 because read count=-1. Number of active connections: 1*   *Region server logs:* From the below logs region server discovers the master on it's own but unable to join the cluster with below logs ===============================================================   *{color:#ff0000}2020-04-22 19:38:24,675 INFO [regionserver/pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020] regionserver.HRegionServer: reportForDuty to master=pinpoint-master-v000-rh5k.c.gcp-ushi-telemetry-npe.internal,16000{color}*,1587584303253 with port=16020, startcode=1587583634667 2020-04-22 19:38:24,801 DEBUG [regionserver/pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020] ipc.RpcClientImpl: Connecting to pinpoint-master-v000-rh5k.c.gcp-ushi-telemetry-npe.internal/10.148.6.154:16000 2020-04-22 19:38:28,005 INFO [regionserver/pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020] regionserver.HRegionServer: reportForDuty to master=pinpoint-master-v000-rh5k.c.gcp-ushi-telemetry-npe.internal,16000,1587584303253 with port=16020, startcode=1587583634667 2020-04-22 19:38:28,033 INFO [regionserver/pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020] regionserver.HRegionServer: Config from master: hbase.rootdir=hdfs://10.148.6.68:9000/hbase 2020-04-22 19:38:28,033 INFO [regionserver/pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020] regionserver.HRegionServer: Config from master: fs.defaultFS=hdfs://10.148.6.68:9000 2020-04-22 19:38:28,033 INFO [regionserver/pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020] regionserver.HRegionServer: Config from master: hbase.master.info.port=16010 ===============================================================   2020-04-22 19:38:24,801 DEBUG [regionserver/pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal/10.148.6.13:16020] ipc.RpcClientImpl: Connecting to pinpoint-master-v000-rh5k.c.gcp-ushi-telemetry-npe.internal/10.148.6.154:16000 2020-04-22 19:38:30,592 DEBUG [RpcServer.listener,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: connection from 10.148.6.154:53050; # active connections: 1 2020-04-22 19:38:31,269 DEBUG [RpcServer.listener,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: connection from 10.148.6.154:53052; # active connections: 2 2020-04-22 19:38:31,479 DEBUG [RpcServer.listener,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: connection from 10.148.6.154:53056; # active connections: 3 2020-04-22 19:39:32,413 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 3 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,440 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 4 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,443 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 5 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,445 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 6 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,447 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 7 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,450 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 8 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,452 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 9 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,454 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 10 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,456 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 11 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 2020-04-22 19:39:32,458 DEBUG [RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020] ipc.RpcServer: RpcServer.FifoWFPBQ.priority.handler=19,queue=1,port=16020: callId: 12 service: AdminService methodName: OpenRegion size: 81 connection: 10.148.6.154:53050 =============================================================== 2020-04-23 04:40:07,751 DEBUG [RpcServer.reader=3,bindAddress=pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: DISCONNECTING client 10.148.6.13:44272 because read count=-1. Number of active connections: 1 2020-04-23 04:40:17,751 DEBUG [RpcServer.listener,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: connection from 10.148.6.13:44280; # active connections: 1 2020-04-23 04:40:17,752 DEBUG [RpcServer.reader=4,bindAddress=pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: DISCONNECTING client 10.148.6.13:44280 because read count=-1. Number of active connections: 1 2020-04-23 04:40:27,752 DEBUG [RpcServer.listener,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: connection from 10.148.6.13:44282; # active connections: 1 2020-04-23 04:40:27,752 DEBUG [RpcServer.reader=5,bindAddress=pinpoint-r-v000-976s.c.gcp-ushi-telemetry-npe.internal,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: DISCONNECTING client 10.148.6.13:44282 because read count=-1. Number of active connections: 1 2020-04-23 04:40:37,752 DEBUG [RpcServer.listener,port=16020] ipc.RpcServer: RpcServer.listener,port=16020: connection from 10.148.6.13:44284; # active connections: 1  " Use rubocop 0.81.0 in Dockerfile,13304143,Resolved,Blocker,Fixed,11/May/20 15:18,12/May/20 08:36,2.2.5,Nightly branch-2.2 docker image is broken as a result of rubocop 0.82.0 which dropped support for Ruby 2.3 Some classes still use log4j logger directly,13302624,Resolved,Blocker,Fixed,04/May/20 11:52,05/May/20 14:37,,Found this when implementing HBASE-24309. Should use slf4j instead. Drop hadoop 2 support for hbase 3.x,13297742,Resolved,Blocker,Fixed,11/Apr/20 06:18,05/May/20 11:50,,"As discussed several times on mailing list, I think it is time to do this." TestDelegationTokenWithEncryption always fails,13300407,Resolved,Blocker,Duplicate,23/Apr/20 01:58,30/Apr/20 15:32,3.0.0-alpha-1,"TestDelegationTokenWithEncryption and TestGenerateDelegationToken _always_ fail.   Incidentally, they don't fail in branch-2.3 and branch-2.2.   I suspect there's a regression with delegation token code, because if I comment out the following code in the test, they pass:   {code:java} try (Connection conn = ConnectionFactory.createConnection(TEST_UTIL.getConfiguration())) {   Token token = TokenUtil.obtainToken(conn);   UserGroupInformation.getCurrentUser().addToken(token); } {code} Effectively, use Kerberos to login instead of delegation token. The tests fail all the time (100%) in the last 29 runs: [https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/dashboard.html] Initially I thought this was caused by pluggable authentication (HBASE-23347), but the tests don't fail in branch-2.3 so looks unlikely." Bump git version in Dockerfile,13299001,Resolved,Blocker,Fixed,17/Apr/20 07:49,17/Apr/20 21:34,,"Nightly build fails when Docker image rebuild is needed on workers. Dockerfile has hardcoded version for git but it is not available anymore. git=1:2.17.1-1ubuntu0.6 These versions are available: {noformat} root@44cf3485b02e:/# apt-cache madison git git | 1:2.17.1-1ubuntu0.6 | http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages git | 1:2.17.1-1ubuntu0.6 | http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages git | 1:2.17.0-1ubuntu1 | http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages {noformat} {noformat} [2020-04-16T15:31:15.100Z] ============================================================================ [2020-04-16T15:31:15.100Z] ============================================================================ [2020-04-16T15:31:15.100Z] Docker Image Creation [2020-04-16T15:31:15.100Z] ============================================================================ [2020-04-16T15:31:15.100Z] ============================================================================ [2020-04-16T15:31:15.100Z] [2020-04-16T15:31:15.100Z] [2020-04-16T15:31:15.100Z] Sending build context to Docker daemon 18.99kB [2020-04-16T15:31:15.815Z] Step 1/60 : FROM ubuntu:18.04 AS BASE_IMAGE [2020-04-16T15:31:16.537Z] 18.04: Pulling from library/ubuntu [2020-04-16T15:31:16.537Z] Digest: sha256:bec5a2727be7fff3d308193cfde3491f8fba1a2ba392b7546b43a051853a341d [2020-04-16T15:31:16.537Z] Status: Downloaded newer image for ubuntu:18.04 [2020-04-16T15:31:16.537Z] ---> 4e5021d210f6 [2020-04-16T15:31:16.537Z] Step 2/60 : SHELL [""/bin/bash"", ""-o"", ""pipefail"", ""-c""] [2020-04-16T15:31:16.537Z] ---> Using cache [2020-04-16T15:31:16.537Z] ---> 1d47e8973913 [2020-04-16T15:31:16.537Z] Step 3/60 : RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y ca-certificates=20180409 curl=7.58.0-2ubuntu3.8 locales=2.27-3ubuntu1 bash=4.4.18-2ubuntu1.2 build-essential=12.4ubuntu1 diffutils=1:3.6-1 git=1:2.17.1-1ubuntu0.5 rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1 wget=1.19.4-1ubuntu2.2 bats=0.4.0-1.1 libperl-critic-perl=1.130-1 python3=3.6.7-1~18.04 python3-pip=9.0.1-2.3~ubuntu1.18.04.1 python3-setuptools=39.0.1-2 ruby=1:2.5.1 ruby-dev=1:2.5.1 shellcheck=0.4.6-1 && apt-get clean && rm -rf /var/lib/apt/lists/* [2020-04-16T15:31:19.732Z] ---> Running in a130e4f222ae [2020-04-16T15:31:27.852Z] E: Version '1:2.17.1-1ubuntu0.5' for 'git' was not found [2020-04-16T15:31:28.566Z] The command '/bin/bash -o pipefail -c DEBIAN_FRONTEND=noninteractive apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y ca-certificates=20180409 curl=7.58.0-2ubuntu3.8 locales=2.27-3ubuntu1 bash=4.4.18-2ubuntu1.2 build-essential=12.4ubuntu1 diffutils=1:3.6-1 git=1:2.17.1-1ubuntu0.5 rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1 wget=1.19.4-1ubuntu2.2 bats=0.4.0-1.1 libperl-critic-perl=1.130-1 python3=3.6.7-1~18.04 python3-pip=9.0.1-2.3~ubuntu1.18.04.1 python3-setuptools=39.0.1-2 ruby=1:2.5.1 ruby-dev=1:2.5.1 shellcheck=0.4.6-1 && apt-get clean && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100 [2020-04-16T15:31:28.566Z] ERROR: Docker failed to build yetus/hbase:f2f86c1790. {noformat} " release scripts on mac os are too slow,13308050,Resolved,Critical,Not A Problem,28/May/20 14:08,26/Oct/24 08:19,,related changes to try to bring the time down to something I can use Remove/Retain deprecated configs,13304513,Open,Critical,,13/May/20 03:34,,,This umbrella issue is to discuss and decide on each config which are deprecated in 2.x line (Or even before itself). Whether we can completely remove them from code. If so whether we need have some migration tool/step. Balancer should avoid leaving idle region servers,13297066,Resolved,Critical,Fixed,08/Apr/20 12:56,23/Apr/20 18:18,,"After HBASE-15529 the StochasticLoadBalancer makes the decision to run based on its internal cost functions rather than the simple region count skew of BaseLoadBalancer. Given the default weights for those cost functions, the default minimum cost to indicate a need to rebalance, and a regions per region server density of ~90 we are not very responsive to adding additional region servers for non-trivial cluster sizes: * For clusters ~10 nodes, the defaults think a single RS at 0 regions means we need to balance * For clusters >20 nodes, the defaults will not consider a single RS at 0 regions to mean we need to balance. 2 RS at 0 will cause it to balance. * For clusters ~100 nodes, having 6 RS with no regions will still not meet the threshold to cause a balance. Note that this is the decision to look at balancer plans at all. The calculation is severely dominated by the region count skew (it has weight 500 and all other weights are ~105), so barring a very significant change in all other cost functions this condition will persist indefinitely. Two possible approaches: * add a new cost function that's essentially ""don't have RS with 0 regions"" that an operator can tune * add a short circuit condition for the {{needsBalance}} method that checks for empty RS similar to the check we do for colocated region replicas For those currently hitting this an easy work around is to set {{hbase.master.balancer.stochastic.minCostNeedBalance}} to {{0.01}}. This will mean that a single RS having 0 regions will cause the balancer to run for clusters of up to ~90 region servers. It's essentially the same as the default slop of 0.01 used by the BaseLoadBalancer." "A ""stuck"" master should not idle as active without taking action",13302175,Open,Critical,,30/Apr/20 18:02,,2.3.0,"The master schedules a SCP for the region server hosting meta. However, due to a misconfiguration, the cluster cannot make progress. After fixing the configuration issue and restarting, the cluster still cannot make progress. After the configured period (15 minuets), the master enters a ""holding pattern"" where it retains Active master status, but isn't taking any action. This ""brown-out"" state is toxic. It should either keep trying to make progress, or it should abort. Staying up and not doing anything is the wrong thing to do." MergeNormalizer is merging non-adjacent regions and causing region overlaps/holes.,13305078,Resolved,Critical,Fixed,15/May/20 00:48,25/May/20 23:13,2.3.0,"Currently, we found normalizer was merging regions which are non-adjacent, it will cause inconsistencies in the cluster. {code:java} 439055 2020-05-08 17:47:09,814 INFO org.apache.hadoop.hbase.master.normalizer.MergeNormalizationPlan: Executing merging normalization plan: MergeNormalizationPlan{firstRegion={ENCODED => 47fe236a5e3649ded95cb64ad0c08492, NAME => 'TABLE,\x03\x01\x05\x01\x04\x02,1554838974870.47fe236a5e3649ded95cb64ad 0c08492.', STARTKEY => '\x03\x01\x05\x01\x04\x02', ENDKEY => '\x03\x01\x05\x01\x04\x02\x01\x02\x02201904082200\x00\x00\x03Mac\x00\x00\x00\x00\x00\x00\x00\x00\x00iMac13,1\x00\x00\x00\x00\x00\x049.3-14E260\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x05'}, secondRegion={ENCODED => 0c0f2aa67f4329d5c4 8ba0320f173d31, NAME => 'TABLE,\x03\x01\x05\x02\x01\x01,1554830735526.0c0f2aa67f4329d5c48ba0320f173d31.', STARTKEY => '\x03\x01\x05\x02\x01\x01', ENDKEY => '\x03\x01\x05\x02\x01\x02'}} 439056 2020-05-08 17:47:11,438 INFO org.apache.hadoop.hbase.ScheduledChore: CatalogJanitor-*****:16000 average execution time: 1676219193 ns. 439057 2020-05-08 17:47:11,730 INFO org.apache.hadoop.hbase.master.HMaster: Client=null/null merge regions [47fe236a5e3649ded95cb64ad0c08492], [0c0f2aa67f4329d5c48ba0320f173d31] {code}   The root cause is that getMergeNormalizationPlan() uses a list of regionInfo which is ordered by regionName. regionName does not necessary guarantee the order of STARTKEY (let's say 'aa1', 'aa1!', in order of regionName, it will be 'aa1!' followed by 'aa1'. This will result in normalizer merging non-adjacent regions into one and creates overlaps. This is not an issue in branch-1 as the list is already ordered by RegionInfo.COMPARATOR in normalizer.  " Shutdown AssignmentManager before ProcedureExecutor may cause SCP to accidentally skip assigning a region,13296233,Resolved,Critical,Fixed,05/Apr/20 00:31,29/Jun/20 15:15,,"I saw this on TestCloseRegionWithRSCrash. The Region 788a516d1f86af98e0a16bcc1afe4fa1 was being moved to RS example.com,62652,1586032098445 just after it was killed. The Move Close fails because the RS has no node in the Master. The Move then tries to 'confirm' the close but it fails because no remote RS. We are then to wait in this state until operator or some other procedure intervenes to 'fix' the state. Normally a ServerCrashProcedure would do the job but in this test the Master is restarted after the RS is killed, a condition we do not accommodate. Let me attach the test log." Get all row ids in a table using Hbase Rest Server API,13306552,Open,Critical,,21/May/20 17:38,,,How to get Row Ids in a table using Hbase Rest Server because I need to get all families with respective qualifiers using hbase rest server. By using row id we get families and qualifiers so i need how to get ROW IDS  AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.,13313259,Resolved,Critical,Fixed,24/Jun/20 13:41,10/Aug/20 02:23,2.0.0,"By HBASE-14004, we introduce {{WALFileLengthProvider}} interface to keep the current writing wal file length by ourselves, {{WALEntryStream}} used by {{ReplicationSourceWALReader}} could only read WAL file byte size <= {{WALFileLengthProvider.getLogFileSizeIfBeingWritten}} if the WAL file is current been writing on the same RegionServer . {{AsyncFSWAL}} implements {{WALFileLengthProvider}} by {{AbstractFSWAL.getLogFileSizeIfBeingWritten}}, just as folllows : {code:java} public OptionalLong getLogFileSizeIfBeingWritten(Path path) { rollWriterLock.lock(); try { Path currentPath = getOldPath(); if (path.equals(currentPath)) { W writer = this.writer; return writer != null ? OptionalLong.of(writer.getLength()) : OptionalLong.empty(); } else { return OptionalLong.empty(); } } finally { rollWriterLock.unlock(); } } {code} For {{AsyncFSWAL}}, above {{AsyncFSWAL.writer}} is {{AsyncProtobufLogWriter}} ，and {{AsyncProtobufLogWriter.getLength}} is as follows: {code:java} public long getLength() { return length.get(); } {code} But for {{AsyncProtobufLogWriter}}, any append method may increase the above {{AsyncProtobufLogWriter.length}}, especially for following {{AsyncFSWAL.append}} method just appending the {{WALEntry}} to {{FanOutOneBlockAsyncDFSOutput.buf}}: {code:java} public void append(Entry entry) { int buffered = output.buffered(); try { entry.getKey(). getBuilder(compressor).setFollowingKvCount(entry.getEdit().size()).build() .writeDelimitedTo(asyncOutputWrapper); } catch (IOException e) { throw new AssertionError(""should not happen"", e); } try { for (Cell cell : entry.getEdit().getCells()) { cellEncoder.write(cell); } } catch (IOException e) { throw new AssertionError(""should not happen"", e); } length.addAndGet(output.buffered() - buffered); } {code} That is to say, {{AsyncFSWAL.getLogFileSizeIfBeingWritten}} could not reflect the file length which successfully synced to underlying HDFS, which is not as expected. " Deadlock executing assign meta procedure,13310462,Open,Critical,,09/Jun/20 19:07,,2.3.0,"I have what appears to be a deadlock while assigning meta. During recovery, master creates the assign procedure for meta, and immediately marks meta as assigned in zookeeper. It then creates the subprocedure to open meta on the target region. However, the PEWorker pool is full of procedures that are stuck, I think because their calls to update meta are going nowhere. For what it's worth, the balancer is running concurrently, and has calculated a plan size of 41. From the master log, {noformat} 2020-06-06 00:34:07,314 INFO org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure: Starting pid=17802, ppid=17801, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=hbase:meta, region=1588230740, ASSIGN; state=OPEN, location=null; forceNewPlan=true, retain=false 2020-06-06 00:34:07,465 INFO org.apache.hadoop.hbase.zookeeper.MetaTableLocator: Setting hbase:meta (replicaId=0) location in ZooKeeper as hbasedn139.example.com,16020,1591403576247 2020-06-06 00:34:07,466 INFO org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Initialized subprocedures=[{pid=17803, ppid=17802, state=RUNNABLE; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure}] {noformat} {{pid=17803}} is not mentioned again. hbasedn139 never receives an {{openRegion}} RPC. Meanwhile, additional procedures are scheduled and picked up by workers, each getting ""stuck"". I see log lines for all 16 PEWorker threads, saying that they are stuck. {noformat} 2020-06-06 00:34:07,961 INFO org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler: Took xlock for pid=17804, state=RUNNABLE:REGION_STATE_TRANSITION_CLOSE; TransitRegionStateProcedure table=IntegrationTestBigLinkedList, region=54f4f6c0e921e6d25e6043cba79c09aa, REOPEN/MOVE 2020-06-06 00:34:07,961 INFO org.apache.hadoop.hbase.master.assignment.RegionStateStore: pid=17804 updating hbase:meta row=54f4f6c0e921e6d25e6043cba79c09aa, regionState=CLOSING, regionLocation=hbasedn046.example.com,16020,1591402383956 ... 2020-06-06 00:34:22,295 WARN org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Worker stuck PEWorker-16(pid=17804), run time 14.3340 sec ... 2020-06-06 00:34:27,295 WARN org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Worker stuck PEWorker-16(pid=17804), run time 19.3340 sec ... {noformat} The cluster stays in this state, with PEWorker thread stuck for upwards of 15 minutes. Eventually master starts logging {noformat} 2020-06-06 00:50:18,033 INFO org.apache.hadoop.hbase.client.RpcRetryingCallerImpl: Call exception, tries=30, retries=31, started=970072 ms ago, cancelled=false, msg=Call queue is full on hbasedn139.example.com,16020,1591403576247, too many items queued ?, details=row 'IntegrationTestBigLinkedList,,1591398987965.54f4f6c0e921e6d25e6043cba79c09aa.' on table 'hbase:meta' at region=hbase:meta,,1. 1588230740, hostname=hbasedn139.example.com,16020,1591403576247, seqNum=-1, see https://s.apache.org/timeout {noformat} The master never recovers on its own. I'm not sure how common this condition might be. This popped after about 20 total hours of running ITBLL with ServerKillingMonkey." "HBCK's ""Orphan Regions on FileSystem"" reports regions with referenced HFiles",13301379,Resolved,Critical,Fixed,27/Apr/20 20:11,11/May/20 22:23,2.2.4,"This issue came up after merging regions. MergeTableRegionsProcedure removes the parent regions from hbase:meta and creates HFile references in child region to the old parent regions. Running `hbck_chore_run` right after the `merge_region` will show the parent regions in ""Orphan Regions on FileSystem"" until major compaction is run on child region which will remove HFile references and cause Catalog Janitor to clean up the parent regions. There are probably other situations which can cause the same issue (maybe region split?) Having ""Orphan Regions on FileSystem"" list parent regions and suggest to ""_hbase completebulkload_"" is dangerous in this case as completing bulk load will lead to stale HFile references in child region which will cause its OPEN to fail because referenced HFile doesn't exist. Figuring out these things for database administrators is tedious, so I think it would be reasonable to not consider regions with referenced HFiles to be orphans (or maybe could give an extra hint saying that it has referenced HFiles)." Zookeeper sync() call is async,13312652,Resolved,Critical,Fixed,21/Jun/20 03:46,26/Jun/20 01:55,1.7.0,"Here is the method that does a sync() of lagging followers with leader in the quorum. We rely on this to see a consistent snapshot of ZK data from multiple clients. However the problem is that the underlying sync() call is actually asynchronous since we are passing a 'null' call back. See the ZK API [doc|https://zookeeper.apache.org/doc/r3.5.7/apidocs/zookeeper-server/index.html] for details. The end-result is that sync() doesn't guarantee that it has happened by the time it returns. {noformat} /** * Forces a synchronization of this ZooKeeper client connection. *

* Executing this method before running other methods will ensure that the * subsequent operations are up-to-date and consistent as of the time that * the sync is complete. *

* This is used for compareAndSwap type operations where we need to read the * data of an existing node and delete or transition that node, utilizing the * previously read version and data. We want to ensure that the version read * is up-to-date from when we begin the operation. */ public void sync(String path) throws KeeperException { this.recoverableZooKeeper.sync(path, null, null); } {noformat} We rely on this heavily (at least in the older branches that do ZK based region assignment). In branch-1 we saw weird ""BadVersionException"" exceptions in RITs because of the inconsistent view of the ZK snapshot. It could manifest differently in other branches. Either way, this is something we need to fix." hbase create namespace blocked when all datanodes has restarted,13312506,Open,Critical,,19/Jun/20 15:37,,2.1.6,"environment: jdk: 1.8.0_181 hadoop: 3.1.1 hbase: 2.1.6 hbase shell create namespace blocked when all datanodes has restarted in kerberos environment, but create it successfully without kerberos hmaster log： 2020-06-19 23:47:48,241 WARN [PEWorker-15] procedure.CreateNamespaceProcedure: Retriable error trying to create namespace=abcd2 (in state=CREATE_NAMESPACE_INSERT_INTO_NS_TABLE) java.net.SocketTimeoutException: callTimeout=1200000, callDuration=1220061: Call to hadoop-hbnn0005.com/172.20.101.36:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call id=116, waitTime=10763, rpcTimeout=10759 row 'abcd2' on table 'hbase:namespace' at region=hbase:namespace,,1592548148073.f5c7e71fb5e5cab3b27e52600996f7fd., hostname=hadoop-hbnn0005.com,16020,1592580274989, seqNum=162 at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:159) at org.apache.hadoop.hbase.client.HTable.put(HTable.java:542) at org.apache.hadoop.hbase.master.TableNamespaceManager.insertIntoNSTable(TableNamespaceManager.java:167) at org.apache.hadoop.hbase.master.procedure.CreateNamespaceProcedure.insertIntoNSTable(CreateNamespaceProcedure.java:240) at org.apache.hadoop.hbase.master.procedure.CreateNamespaceProcedure.executeFromState(CreateNamespaceProcedure.java:85) at org.apache.hadoop.hbase.master.procedure.CreateNamespaceProcedure.executeFromState(CreateNamespaceProcedure.java:39) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:189) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:965) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1723) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1462) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1200(ProcedureExecutor.java:78) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2039) Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to hadoop-hbnn0005.com/172.20.101.36:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call id=116, waitTime=10763, rpcTimeout=10759 at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:205) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:390) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:95) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:410) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:406) at org.apache.hadoop.hbase.ipc.Call.setTimeout(Call.java:96) at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:199) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:682) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:757) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:485) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call id=116, waitTime=10763, rpcTimeout=10759 at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:200) ... 4 more 2020-06-19 23:47:49,218 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 1.262sec 2020-06-19 23:47:54,220 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 6.263sec 2020-06-19 23:47:59,220 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 11.264sec 2020-06-19 23:48:04,220 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 16.264sec 2020-06-19 23:48:09,221 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 21.265sec 2020-06-19 23:48:14,221 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 26.265sec 2020-06-19 23:48:19,221 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 31.265sec 2020-06-19 23:48:24,222 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 36.266sec 2020-06-19 23:48:29,222 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 41.266sec 2020-06-19 23:48:34,223 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 46.267sec 2020-06-19 23:48:39,223 WARN [ProcExecTimeout] procedure2.ProcedureExecutor: Worker stuck PEWorker-15(pid=171), run time 20mins, 51.267sec" WrongRowIOException occasionally thrown during batch append ,13312604,Open,Critical,,20/Jun/20 10:16,,2.2.4,"We recently used the HTable.batch() to do batch Append, and RS occasionally throws a large number of errors as follows: {code:java} The row in 970~xxx/f:\x00\x00\x00\x17/LATEST_TIMESTAMP/Put/vlen=24/seqid=0/3160:50472:;3873:52121:; doesn't match the original one 841~aaa at org.apache.hadoop.hbase.client.Mutation.add(Mutation.java:788) at org.apache.hadoop.hbase.client.Append.add(Append.java:183) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toDelta(ProtobufUtil.java:815) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toAppend(ProtobufUtil.java:864) at org.apache.hadoop.hbase.regionserver.RSRpcServices.append(RSRpcServices.java:676) at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:881) at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2755) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42290) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318){code} Finally, the RS write handler and write queue are full, and the RS is unavailable. Looks the same as [HBASE-19876|https://issues.apache.org/jira/browse/HBASE-19876]." AssignmentManager.start should add meta region to ServerStateNode,13310073,Resolved,Critical,Fixed,08/Jun/20 09:53,15/Jun/20 02:46,,"In AssignmentManager.start, we will load the meta region state and location from zk and create the RegionStateNode, but we forget to call regionStates.addRegionToServer to add the region to the region server. Found this when implementing HBASE-24390. As in HBASE-24390, we will remove RegionInfoBuilder.FIRST_META_REGIONINFO so in SCP, we need to use the getRegionsOnServer instead of RegionInfoBuilder.FIRST_META_REGIONINFO when assigning meta, so the bug becomes a real problem. Though it is not a big problem for SCP for current 2.x and master branches, it is a high risky bug. For example, in AssignmentManager.submitServerCrash, now we use the RegionStateNode of meta regions to determine whether the given region server carries meta regions. But it is also valid to test through the ServerStateNode's region list. If later we change this method to use ServerStateNode, it will cause very serious data loss bug." The default readRpcTimeout and writeRpcTimeout is incorrectly calculated in AsyncConnectionConfiguration,13309856,Resolved,Critical,Fixed,06/Jun/20 10:55,07/Jun/20 10:40,, Failed to write replication wal position,13300497,Resolved,Critical,Information Provided,23/Apr/20 08:44,24/Apr/20 15:08,1.5.0,"I turned on replication for tables, index tables did not, wrote data using phoneix, and hbase regionserver went down after running for a while. regionserver log: 2020-04-20 19:22:49,531 FATAL [main-EventThread.replicationSource,1.replicationSource.a2-test-regionserver-52-23.sh%2C16020%2C1587378758523,1] regionserver.HRegionServe r: ABORTING region server a2- test-regionserver-52-23.sh,16020,1587378758523: Failed to write replication wal position (filename=a2-test-regionserver-52-23.sh%2C16020%2C 1587378758523.1587381739689, position=3388929) org.apache.zookeeper. KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/replication/rs/a2-test-regionserver-52-23.sh,16020,1587378758523/1/a2-test-reg ionserver-52-23.sh%2C16020%2C1587378758523. 1587381739689 at org.apache.zookeeper.KeeperException.create(KeeperException.java:111) at org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1327) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:510) at org.apache.hadoop.hbase.zookeeper.ZKUtil .setData(ZKUtil.java:867) at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:917) at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:911 ) at org.apache.hadoop.hbase.replication.ReplicationQueuesZKImpl.setLogPosition(ReplicationQueuesZKImpl.java:155) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.logPositionAndCleanOldLogs(ReplicationSourceManager.java:197) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.updateLogPosition(ReplicationSource.java:791) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.shipEdits(ReplicationSource.java:762) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.run(ReplicationSource.java:601)" Hedged read might hang infinitely if read data from all DN failed,13308272,Open,Critical,,29/May/20 08:35,,,"Found out that after an ungraceful Datanode shutdown, the number of HBase active handlers started to grow, making RegionServer stuck and not able to serve any RPC. Took the thread dump and found out multiple read handlers were in some kind of dead lock state and also write handlers stuck. This also caused to not be able to flush the memstore because it was waiting for this lock: [https://github.com/apache/hbase/blob/136414dd72a80f379b80cd6f74b5b6ebd78f33ec/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java#L1225] Without being able to flush it, I could not gracefully stop the RegionServer, since we can't move out the flushing region.   Found out that the real issue was in Hadoop's DFSInputStream. When no hedged reads succeed, the internal hedgedService.take() call hangs forever since it's internally using a BlockingQueue: [https://github.com/apache/hadoop/blob/rel/release-2.8.5/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1435]   Reproduced in HBase 1.4.13, but I think it affects to other versions:  # Datanode dies # A read handler holding a read lock of an HStore is blocked by hedged read that does not succeed. # Other read handlers try to acquire the lock and stuck. # Memstore flusher tries to acquire write lock in HStore and also blocked because of the other read locks. # Others like CompactedHFilesDischarger also blocks because memstore holds the lock. # Tried to use graceful_stop.sh, but region_mover.rb fails because can't move out the region being flushed. # Forcefully killed the RegionServer because no other option (I am not sure if there is possibility of data loss, since HStore#updateStorefiles is not finished at this point).   This is the Hadoop side issue: https://issues.apache.org/jira/browse/HDFS-11303 and it's fixed for 2.9.0. This is not directly related with HBase code, but just wanted community to be aware that with current used Hadoop version (2.8.5), this issue could happen.   I would like to suggest to upgrade the used Hadoop version to 2.9.0." Assignment manager should never give up assigning meta,13302180,Open,Critical,,30/Apr/20 18:21,,2.3.0,"Not yet sure how we got here, but, {noformat} 2020-04-29 22:39:16,140 INFO org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure: pid=308, state=RUNNABLE:SERVER_CRASH_ASSIGN_META, locked=true; ServerCrashProcedure server= host-a.example.com,16020,1588033841562, splitWal=true, meta=true found a region state=OFFLINE, location=null, table=hbase:meta, region=1588230740 which is no longer on us host-a.example.com,16020,1588033841562, give up assigning... {noformat} Assignment manager gives up on this procedure and nothing can progress. Manual intervention is necessary. From this [conditional block|https://github.com/apache/hbase/blob/1415a82d41a1e125440014a4b23364371b30d065/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L475], it seems the {{regionNode}} location is {{null}}. {noformat} // This is possible, as when a server is dead, TRSP will fail to schedule a RemoteProcedure // to us and then try to assign the region to a new RS. And before it has updated the region // location to the new RS, we may have already called the am.getRegionsOnServer so we will // consider the region is still on us. And then before we arrive here, the TRSP could have // updated the region location, or even finished itself, so the region is no longer on us // any more, we should not try to assign it again. Please see HBASE-23594 for more details. if (!serverName.equals(regionNode.getRegionLocation())) { LOG.info(""{} found a region {} which is no longer on us {}, give up assigning..."", this, regionNode, serverName); continue; } {noformat}" Correct snapshot handling,13295614,Resolved,Critical,Not A Problem,01/Apr/20 19:39,19/Apr/20 02:50,," Reopening this umbrella to address correct snapshot handling. Particularly, the following scenario must be verified: # load data to a table # take snapshot # major compact table # run mob file cleaner chore # load data to table # restore table from snapshot into another table # verify data integrity # restore table from snapshot into original table # verify data integrity" "Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null",13304837,Resolved,Major,Fixed,14/May/20 05:09,14/May/20 20:10,2.3.0,"This is an incidental noticed when in a hole trying to fix up a cluster. The 'obvious' remediation didn't work. This issue is about addressing this. HBASE-23594 added a filtering of Regions on the crashed server to handle the case where an Assign may be concurrent to the ServerCrashProcedure. To avoid double assign, the SCP will skip assign if the RegionStateNode RegionLocation is not that of the crashed server. This is good. Where it is an obstacle is when a Region is stuck in OPENING state, it references an 'Unknown Server' -- a server no longer tracked by the Master -- and there is no assign currently in flight. In this case, scheduling a ServerCrashProcedure to clean up the reference to the Unknown Server and to get the Region reassigned skips out when RegionStateNode in Master has a RegionLocation that does not match that of the ServerCrashProcedure, even when it is set to null (we set the RegionLocation to null when we fail an assign as we might if the server no longer is part of the cluster). For background, cluster had a RIT. The RIT was a Region failing to open because of a missing Reference (Another issue). The Region open would fail with a FileNotFoundException. The master would attempt assign and then would fail when it went to confirm OPEN, logging the complaint about FNFE asking for operator intervention in master logs. This state was in place for weeks on this particular cluster (a dev cluster not under close observation). The cluster had been restarted once or twice so the server the Region had once been on was no longer 'known' but it still had an entry in the hbase:meta table as last location assigned (The now 'Unknown Server'). To fix, I went about the task in the wrong order. I bypassed the long-running stuck procedure to terminate it and cleanup 'Procedures and Locks'. Mistake. Now there was no longer an assign Procedure for this Region. But I now had a Region in OPENING state with a reference to an unknown server with an in-memory RegionStateNode whose RegionLocation was null (set null on each failed assign). Running catalogjanitor_run and hbck_chore_report had the unknown server show in the 'HBCK Report' in the 'Unknown Servers' list. Attempts at assign fail because Region is in OPENING state -- you can't assign a Region in OPENING state. Scheduling an HBCKSCP via hbck2 scheduleRecoveries always generated the below in the logs. {code} org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure: pid=157217, state=RUNNABLE:SERVER_CRASH_ASSIGN, locked=true; HBCKServerCrashProcedure server=unknown_server.example.com,16020,1587577972683, splitWal=true, meta=false found a region state=OPENING, location=null, table=bobby_analytics, region=1501ea3bd822c1a3e4e6216ea48733bd which is no longer on us unknown_server.example.com,16020,1587577972683, give up assigning... {code} My workaround was setting region state to CLOSED with hbck2 and then doing an assign with hbck2. At this point I noticed the FNFE. Easier if the HBCKSCP worked." Create table is slow in large cluster when AccessController is enabled.,13299246,Resolved,Major,Fixed,17/Apr/20 22:57,11/May/20 09:15,1.3.6,"*Problem:* In HBase 1.3.x  large, performance test, cluster (100 RS, 60k tables, 600k regions) a simple table creation takes around 150 seconds. The time taken varies but still takes lot of time. *Analysis:* 1. When HBase creates a table , it calls AssignmentManager#assign(final ServerName destination, final List regions) In AssignmentManager#assign，it calls asyncSetOfflineInZooKeeper(state, cb, destination), and waits in below code loop for 2 minutes.  {code:java} if (useZKForAssignment) { // Wait until all unassigned nodes have been put up and watchers set. int total = states.size(); for (int oldCounter = 0; !server.isStopped();) { int count = counter.get(); if (oldCounter != count) { LOG.debug(destination.toString() + "" unassigned znodes="" + count + "" of total="" + total + ""; oldCounter="" + oldCounter); oldCounter = count; } if (count >= total) break; Thread.sleep(5); } } {code} 2. asyncSetOfflineInZooKeeper creates a znode under /hbase/region-in-transition/ and calls exist to ensure that znode is created. This is simple operation should not take much time. Then where the time it taken!!! 3. ZooKeeper client API process watcher notification and async API response through a queue one by one. If there is a delay in any watcher/response processing by the client, in this case HBase, all other response processing is delayed. Then it appears as if API call has taken more time. Same thing happen in this issue. Watcher processing for znode creation under /hbase/acl took most of the time and delayed /hbase/region-in-transition/region znode creation processing. This is why wait in loop was too long.  4. Watcher processing for znode creation under hbase/acl/ calls ZKPermissionWatcher#nodeChildrenChanged, which internally calls ZKUtil.getChildDataAndWatchForNewChildren *which calls ZooKeeper's getData API, in this use case, 60k times which takes most of the time.* *Solutions:* Move getChildDataAndWatchForNewChildren call into the async code block in ZKPermissionWatcher#nodeChildrenChanged.   " Skip compaction request/check for replica regions at the early stage.,13312056,Resolved,Major,Fixed,17/Jun/20 21:13,18/Dec/24 13:59,2.3.0,"I found that in certain cases replica regions can trigger compaction, one example as follows, need to check all places to avoid compaction for replica regions. {code:java} @Override public void postOpenDeployTasks(final PostOpenDeployContext context) throws IOException { HRegion r = context.getRegion(); long openProcId = context.getOpenProcId(); long masterSystemTime = context.getMasterSystemTime(); rpcServices.checkOpen(); LOG.info(""Post open deploy tasks for {}, openProcId={}, masterSystemTime={}"", r.getRegionInfo().getRegionNameAsString(), openProcId, masterSystemTime); // Do checks to see if we need to compact (references or too many files) // TODO: SHX, do not do this for replica regions? Otherwise, it is going to lost data locality for primary regions. for (HStore s : r.stores.values()) { if (s.hasReferences() || s.needsCompaction()) { this.compactSplitThread.requestSystemCompaction(r, s, ""Opening Region""); } } {code}" Hadoop2 and Hadoop3 profiles being activated simultaneously causing test failures,13301675,Resolved,Major,Fixed,29/Apr/20 00:05,03/Jun/20 23:39,,"[~ndimiduk] pointed out that, after this change went in, TestSecureRESTServer started failing with Hadoop3 on branch-2.3 https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/56/ Of course, I ran this with 1.8.0_241 and Maven 3.6.33 and it passed :) {{mvn clean package -Dtest=TestSecureRESTServer -Dhadoop.profile=3.0 -DfailIfNoTests=false}} FYI [~stoty] in case you can repro a failure and want to dig in. Feel free to re-assign. It looks like we didn't have a nightly run of branch-2.2 due to docker container build issues. Will be interesting to see if it fails there. It did not fail the master nightly." Address other hard references to '/tmp' found in Configuration,13300097,Resolved,Major,Fixed,21/Apr/20 21:53,18/Dec/24 13:56,,"HBASE-24175 started up cleaning hard /tmp references out of Configuration when tests run. I got most of them but then if its hadoop2 or hadoop3 or jenkins or local, the list seems to change. Here are more..." Skip hadoop2 check for master branch,13298779,Resolved,Major,Fixed,16/Apr/20 11:11,21/Apr/20 09:08,,"Now we will run hadoop2 check on jdk8 and hadoop3 check on jdk11, since the support of hadoop2 has been dropped, let's make jdk8 check also on hadoop3." Add Increment and Append support to CheckAndMutate,13312648,Resolved,Major,Fixed,21/Jun/20 02:00,08/Sep/20 12:34,,"Currently, CheckAndMutate supports only Put and Delete. Supporting Increment and Append would be helpful for some use cases." Revisit onlineRegions and onlineRegionsLock in HRegionServer,13308908,Patch Available,Major,,02/Jun/20 08:47,,,"The onlineRegionsLock is only used in closeMetaTableRegions and closeUserRegions, and only writeLock is used so I wonder whether we can change it to a Lock instead of ReadWriteLock. And also, in the several getRegions method, we have synchronized (this.onlineRegions), which is not necessary, since the onlineRegions is already a ConcurrentMap." do-release should sign the commits and tag it creates,13311775,Resolved,Major,Implemented,16/Jun/20 16:55,26/Oct/24 08:29,,We go through all this trouble to make the release manager's GPG keys available to the build environment. We should make use of them everywhere we can. CatalogJanitor resubmits GCMultipleMergedRegionsProcedure for the same region,13300708,Resolved,Major,Implemented,24/Apr/20 04:40,26/Oct/24 08:17,2.2.4,"If a lot of regions were merged (due to change of region sizes, for example), there can be a long backlog of procedures to clean up the merged regions. If going through this backlog is slower than the CatalogJanitor's scan interval, it will end resubmitting GCMultipleMergedRegionsProcedure for the same regions over and over again." skip duplicate GCMultipleMergedRegionsProcedure while previous finished,13302876,Resolved,Major,Fixed,05/May/20 13:38,08/May/20 10:00,, GCRegionProcedure doesn't assign region from RegionServer leading to orphans,13300833,Resolved,Major,Cannot Reproduce,24/Apr/20 16:12,26/Oct/24 08:15,2.2.4,"We've found ourselves in a situation where parents of merged or split regions needed to be opened again on a regionserver due to having to recover from cluster meltdown (HBCK2's fixMeta kicks off GCMultipleMergedRegionsProcedure which requiters all regions to be merged to be open). Then, when a GCProcedure is kicked of to clean a parent region up by GCMultipleMergedRegionsProcedure, it ends up deleting it from hbase:meta, but doesn't unassign it from RegionServer leading for it to show up in ""Orphan Regions on RegionServer"" in hbck tab of HBase Master. Also, the hbase client doesn't detect that the region is closed either because it's still technically open on a regionserver (it doesn't reread hbase:meta all the time). The only way to recover from this is to restart regionserver which isn't idea as it can lead to other issues in clusters with region inconsistencies." Backport the pre commit changes for HBASE-24169 to all branches,13299265,Resolved,Major,Fixed,18/Apr/20 02:26,22/Apr/20 02:50,, Change fork count from 0.5C to 0.25C,13295938,Resolved,Major,Fixed,03/Apr/20 04:04,03/Apr/20 04:08,,"The parent issue, not surprisingly, shows that 0.25C fork count is more likely to pass than the more aggressive 0.5C. Let me down branch-2.3/master branches to 0.25C (I've already done it on branch-2)." RSGroupInfo add configuration map to store something extra,13307331,Resolved,Major,Fixed,26/May/20 03:28,08/Jul/20 06:40,3.0.0-alpha-1,"Maybe we should add a _Map configuration_ into RSGroupInfo to store extra infomation. For example, we can store the minimum number of machines the group needs, in order to move machine into this group automatically." Support loading cluster level CPs from Hadoop file system,13306957,Open,Major,,23/May/20 12:42,,,"Right now we allow configuring CPs, which needs to be loaded from hadoop FS, at table level. (Via the Java API or shell) > alter 't1', METHOD => 'table_att', 'coprocessor'=>'hdfs:///foo.jar|com.foo.FooRegionObserver|1001|arg1=1,arg2=2' But for the cluster level CPs at Master/RS/WAL level, only way is to config at hbase-site.xml. But here we dont allow to specify any jar path. This jira suggest to add such a feature Note: We already support config the priority of CP at xml level (FQCN|). Same way how shell command works we can take the jar pathalso. || If no '|' separator at all, consider that as FQCN in the classpath. If one '|' that will be FQCN and priority (Same as of today). If 2 '|' separators we consider the 1st part as path to the external jar. This will help in cloud scenario specially with auto scaling. Or else customer should be executing some special scripts to make the CP jar available within the HBase classpath." Extend HBASE-24205 to know the scan requests that comes to a memstore,13306544,Open,Major,,21/May/20 17:00,,,An extension to HBASE-24205 where we can try to get how many of the scan requests where trying to get the latest data. A heuristic should be good enough to know the pattern of the reads here too. "Backport fix for ""Netty SASL implementation does not wait for challenge response"" to branch-2.x",13298059,Resolved,Major,Fixed,13/Apr/20 15:08,03/Nov/23 20:23,,"From the parent: * Need backports of the Netty impl to the other 2.x branches which contain HBASE-23347 * Need to make the same fix to the NIO impl to branches which contain HBASE-23347 " Redo all of our github notification integrations on new ASF infra feature,13300876,Resolved,Major,Fixed,24/Apr/20 19:51,10/May/20 16:53,,"The new [ASF Infra feature for customizing how project gets notifications from github|https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories] appears to have silently thrown away all the integration we already had set up. I don't know that full set of things we need. We presumably need to do this for all of our repos. * make sure all notifications on PRs is going to issues@ * make sure we get links on JIRA for related PRs * make sure we do not get updates on JIRA for every PR comment" Move MetaTableAccessor out of hbase-client,13312685,Resolved,Major,Fixed,21/Jun/20 12:47,24/Jun/20 13:26,,"On master branch we have AsyncMetaTableAccessor which is used at client side and MetaTableAccessor has lots of internal methods for implementing assignment, which is not part of our client code. So let's move it to hbase-server, and in the future, maybe in hbase-balancer?" Try github ci for hbase-connectors,13307948,Resolved,Major,Won't Do,28/May/20 08:08,28/Feb/23 14:09,, hbase spark connector doesn't support writing to table not in default namespace,13301527,Resolved,Major,Fixed,28/Apr/20 11:07,28/Apr/20 19:54,connector-1.0.0,"Defining the following table catalog: {code:java} val catalog = """"""{ |""table"": {""namespace"": ""ns1"", ""name"": ""test1""}, |""rowkey"": ""id"", |""columns"": { |""id"": {""cf"": ""rowkey"", ""col"": ""id"", ""type"": ""string""}, |""x"": {""cf"": ""d"", ""col"": ""xxx"", ""type"": ""int""} |} |}"""""".stripMargin {code} Try to write some test data to {{ns1:test1}} table using spark: {code:java} val df = Seq((""abc"", 1), (""def"", 2)).toDF(""id"", ""x"") df.write.options(Map(HBaseTableCatalog.tableCatalog -> catalog, ""hbase.spark.use.hbasecontext"" -> ""false"", HBaseTableCatalog.newTable-> ""5"")).format(""org.apache.hadoop.hbase.spark"").save() {code} After executing the code above, I found out that the test data was written to {{default:test1}}, rather than {{ns1:test1}}. " Junit tests do not behave well with System.exit or Runtime.halt or JVM exits in general.,13298259,Resolved,Major,Fixed,14/Apr/20 12:30,21/Apr/20 05:25,,This ends up exiting the JVM and confusing / erroring out the test runner that manages that JVM as well as cutting off test output files. Calculate FIXED_OVERHEAD automatically,13314185,Resolved,Major,Fixed,30/Jun/20 01:57,06/Aug/20 22:54,,"Now the FIXED_OVERHEAD in some classes are maintained manually, an we have a method to TestHeapSizes to confirm that the value is correct. But it is really hard for developers to count the fields in a complicated class like HRegion. Since we have the ability to calcuate the accurate size in UT, I think we it is also possible to calcuate it when loading the class, which is a one time operation so should not effect the performance too much." Classic (ZK-based) distributed WAL splitter is inscrutable in operation,13311312,Open,Major,,14/Jun/20 04:16,,,"Scenario: decent sized cluster (700 nodes) and WALs backing up (TBD: A Replication Peer was in place) such that many RSs had hundreds of WALs. Next, a power outage-like event where we have to cold-start. Master comes up and files SCPs for old server instances; hundreds. SCP finds there are hundreds of WALs and dutifully asks the wal-splitter to do its job. Meantime it goes to sleep until completion (See HBASE-24545); no status in log, just loads of complaint in log about STUCK procedure worker. Operator sees a stalled master dumping into its logs the occasional split completion and STUCK procedures but thats it. Operator tries poking up in zk under '/hbase/splitWAL' to see whats up but gets a spew back of one-line listing thousands of znodes. Operator gets no indication of how we are progressing or of when all is done. In my particular case, there were > 100k WALs backed-up. I could dig around some and could see that 40k WALs were in-flight at any one time (necessitating upping jute.maxbuffer for zk). I could do this: {code}$ echo ""ls /hbase/splitWAL"" | hbase -Djute.maxbuffer=10000000 org.apache.hadoop.hbase.zookeeper.ZKMainServer | sed -e 's/, /\n/g'|wc{code} but it didn't help much as new WALs got added to the backlog. I could do the below but it didn't help when WAL count > 100k: {code}$ hdfs dfs -lsr /hbase/WALs/*|wc{code} Is the count here all the WALs that need splitting (yes, I think). Its less than zk count at any one time. How are they tied? Dunno. This issue is about improving visibility in our distributed wal-splitter. In particular the zk-based splitter visibility is poor (HBASE-21588 is a new splitter built on procedures that probably has similar issue). We need to have a count of overall outstanding tasks, of how long tasks are taking, and of how well distributed the job is (see below). An aside was that I had default for {code}HBASE_SPLIT_WAL_MAX_SPLITTER = ""hbase.regionserver.wal.max.splitters""{code} which is {code} public static final int DEFAULT_HBASE_SPLIT_WAL_MAX_SPLITTER = 2; {code} so in extremis, I upped the count to 10 but even then looking at random RS's they were only getting work on occasion sometimes with hours passing between split tasks as though the Master was bad at passing out the jobs: hard to tell when no view on what is going on. Below is from log of random RS... notice how sporadically it gets split work though thousands of WALs to work on: {code} 89 2020-06-11 04:38:40,113 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-1] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@271eba8d in 12309ms. Status = DONE 90 2020-06-11 04:38:51,445 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-0] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@6c9e0b6 in 13230ms. Status = DONE 91 2020-06-11 04:38:57,060 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-1] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@7f102aeb in 16759ms. Status = DONE 92 2020-06-11 09:17:12,762 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-0] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@28c31f7d in 1181ms. Status = DONE 93 2020-06-11 09:17:14,512 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-1] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@3ecd4959 in 2224ms. Status = DONE 94 2020-06-11 09:17:14,750 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-0] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@5a72b3ad in 1345ms. Status = DONE 95 2020-06-11 09:17:19,898 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-1] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@6af0858d in 5319ms. Status = DONE 96 2020-06-11 09:17:21,558 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-0] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@1bca0d8b in 890ms. Status = DONE 97 2020-06-11 16:12:31,676 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-1] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@50a124bc in 1193ms. Status = DONE 98 2020-06-11 16:12:34,140 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-0] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@519c681c in 2383ms. Status = DONE 99 2020-06-11 16:12:35,943 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-1] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@4a47b062 in 2278ms. Status = DONE 100 2020-06-11 16:12:36,437 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-0] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@f9bcea in 1497ms. Status = DONE 101 2020-06-11 16:12:39,953 INFO [RS_LOG_REPLAY_OPS-regionserver/ps1406:16020-1] handler.WALSplitterHandler: Worker ps1406.example.org,16020,1591849310794 done with task org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination$ZkSplitTaskDetails@42d82ac4 in 914ms. Status = DONE {code}" why always encounter Cannot get region location for multi-region request,13295795,Open,Major,,02/Apr/20 13:12,,1.2.1,"there is error log ,and much more repeat [AsyncProcess.java:762][ERROR][org.apache.hadoop.hbase.client.AsyncProcess] - #1, Caught throwable while calling. This is unexpected. Retrying. Server is hbase18.hz,60020,1585111359062, tableName=xxx:copyright_competitor_song_resource_match java.lang.RuntimeException: Cannot get region location for multi-region request at org.apache.hadoop.hbase.client.MultiServerCallable.getLocation(MultiServerCallable.java:72) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncProcess.java:748) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.sendMultiAction(AsyncProcess.java:1025) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.groupAndSendMultiAction(AsyncProcess.java:934) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.resubmit(AsyncProcess.java:1252) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.receiveGlobalFailure(AsyncProcess.java:1213) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.access$1200(AsyncProcess.java:615) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncProcess.java:764) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.sendMultiAction(AsyncProcess.java:1025) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.groupAndSendMultiAction(AsyncProcess.java:934) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.resubmit(AsyncProcess.java:1252) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.receiveGlobalFailure(AsyncProcess.java:1213) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.access$1200(AsyncProcess.java:615) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncProcess.java:764) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.sendMultiAction(AsyncProcess.java:1025) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.groupAndSendMultiAction(AsyncProcess.java:934) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.resubmit(AsyncProcess.java:1252) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.receiveGlobalFailure(AsyncProcess.java:1213) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.access$1200(AsyncProcess.java:615) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncProcess.java:764) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.sendMultiAction(AsyncProcess.java:1025) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.groupAndSendMultiAction(AsyncProcess.java:934) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.resubmit(AsyncProcess.java:1252) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.receiveGlobalFailure(AsyncProcess.java:1213) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.access$1200(AsyncProcess.java:615) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncProcess.java:764) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.sendMultiAction(AsyncProcess.java:1025) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.groupAndSendMultiAction(AsyncProcess.java:934) ~[hbase-client-1.2.6.jar:1.2.6] at org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl.resubmit(AsyncProcess.java:1252) ~[hbase-client-1.2.6.jar:1.2.6]" HMaster won't become healthy after after cloning or creating a new cluster pointing at the same file system,13301868,Resolved,Major,Won't Fix,29/Apr/20 17:20,08/Sep/22 18:06,2.2.3,"h1. How to reproduce: # user starts an HBase cluster on top of a file system # user performs some operations and shuts down the cluster, all the data are still persisted in the file system # user creates a new HBase cluster using a different set of servers on top of the same file system with the same root directory # HMaster cannot initialize h1. Root cause: During HMaster initialization phase, the following happens: # HMaster waits for namespace table online # AssignmentManager gets all namespace table regions info # region servers of namespace table are already dead, online check fails # HMaster waits for namespace regions online, keep retrying for 1000 times which means forever Code waiting for namespace table to be online: https://github.com/apache/hbase/blob/rel/2.2.3/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1102 h1. Stack trace (running on S3): 2020-04-23 08:15:57,185 WARN [master/ip-10-12-13-14:16000:becomeActiveMaster] master.HMaster: hbase:namespace,,1587628169070.d34b65b91a52644ed3e77c5fbb065c2b. is NOT online; state=\{d34b65b91a52644ed3e77c5fbb065c2b state=OPEN, ts=1587629742129, server=ip-10-12-13-14.ec2.internal,16020,1587628031614}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. where ip-10-12-13-14.ec2.internal is the old region server hosting the region of hbase:namespace. h1. Discussion for the fix We see there is a fix for this at branch-3: https://issues.apache.org/jira/browse/HBASE-21154. Before we provide a patch, we would like to know from the community if we should backport this change to branch-2, or if we should just perform a fix with minimum code change." Release scripts in docker mode should be able to use a named volume for maven repo,13308199,In Progress,Major,,28/May/20 23:56,,,"Allow optional volume name to use to mount the maven repo so we get reuse of third party artifacts between runs. Forcefully remove artifacts we build from it (assuming we can't make a read-only one that's shared for third party dependencies and an isolated one that's for what we're building)" MOB compactor implementations should use format specifiers when calling String.format,13297526,Resolved,Major,Fixed,10/Apr/20 03:21,17/Aug/22 11:59,3.0.0-alpha-1,"HBASE-23723 includes a few IOException message constructions that rely on String.format but use slf4j parameters instead of format specifiers. Discovered by nightly failing error-prone." Failed SASL authentication does not result in an exception on client side,13311920,Resolved,Major,Fixed,17/Jun/20 09:30,23/Jun/20 09:05,2.2.5,"When HBaseSaslRpcClient.saslConnect tries to authenticate it only reads the input stream if the process is not complete yet. However if the authentication failed and the process is completed the exception sent back in the stream never gets read. We should always try to read the input stream even if the process is complete to make sure it was empty." Document general framework to execute remote procedure on RegionServer,13312524,Closed,Major,Duplicate,19/Jun/20 17:12,24/Jul/20 04:14,,"Document -- probably best in javadoc -- the system added by HBASE-19216 'Implement a general framework to execute remote procedure on RS ' for having procedures run tasks on remote regionservers. The system evolved a good while ago in HBASE-19216 to manage replication peers. It was then adopted by the new procedure-based distributed WAL splitting feature with some worry that the latter didn't use the framework properly (so far, all looks good). This issue is about vetting the distributed WAL splitters usage and doc'ing the framework as I go. This framework is useful. Others will want to exploit it." Failed start recovering crash in standalone mode if procedure-based distributed WAL split & hbase.wal.split.to.hfile=true,13312114,Closed,Major,Not A Problem,18/Jun/20 05:51,25/Jun/20 19:04,,"(This description got redone after I figured out what was going on. Previously it was just a litany of me banging around trying to learn procedure-based WAL splitting and hbase.wal.split.to.hfile; no one needs to read that; hence the refactor). HBASE-24574 procedure-based distributed WAL splitting is enabled and split-to-hflie too. A force crash requires recovery with ServerCrashProcedure splitting old WALs on restart. The recovery fails because we get stuck. The Master can't assign meta because it is being recovered. The recovery can't make progress because it is asking for a table descriptor for meta -- needed by the hbase.wal.split.to.hfile feature -- and the master is not yet initialized. After the default timeout, Master shuts down because it can't initialize. {code} 2020-06-18 19:53:54,175 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: Master not initialized after 200000ms at org.apache.hadoop.hbase.util.JVMClusterUtil.waitForEvent(JVMClusterUtil.java:232) at org.apache.hadoop.hbase.util.JVMClusterUtil.startup(JVMClusterUtil.java:200) at org.apache.hadoop.hbase.LocalHBaseCluster.startup(LocalHBaseCluster.java:430) at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:232) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3059) {code} The abort of Master interrupts other ongoing actions so later in the log we'll see the WAL split show as interrupted {code} 2020-06-17 21:20:37,472 ERROR [RS_LOG_REPLAY_OPS-regionserver/localhost:16020-0] handler.RSProcedureHandler: Error when call RSProcedureCallable: java.io.IOException: Failed WAL split, status=RESIGNED, wal=file:/Users/stack/checkouts/hbase.apache.git/tmp/hbase/WALs/localhost,16020,1592440848604-splitting/localhost%2C16020%2C1592440848604.meta.1592440852959.meta at org.apache.hadoop.hbase.regionserver.SplitWALCallable.splitWal(SplitWALCallable.java:106) at org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:86) at org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:49) at org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code} This issue becomes how to make hbase.wal.split.to.hfile work in standalone mode." Review client binary size,13313312,Closed,Major,Fixed,24/Jun/20 19:03,24/Jun/20 20:57,2.3.0,Discussion on 2.3.0RC0 noted that the client tarball is larger than the default tarball. Docs were pointed out as the culprit. Lets dig deeper and see what's going on. Purge dev javadoc from client bin tarball,13313325,Closed,Major,Fixed,24/Jun/20 20:55,25/Jun/20 00:27,,"For 2.0, the decision was made to exclude the bulky ""developer"" api docs from the binary artifacts, via HBASE-20149. This change needs applied to the client tarball as well." Download CyrusSasl and DoubleConversion,13313097,Closed,Major,Incomplete,23/Jun/20 18:24,23/Jun/22 20:39,,Download these dependencies at build time. Update to c++17,13313096,Closed,Major,Not A Problem,23/Jun/20 18:23,23/Jun/22 20:38,,Update to C++17 as a base standard as we update the version of folly/wangle/fizz Generate version.h include file during compilation,13307867,Closed,Major,Fixed,27/May/20 23:32,28/May/20 22:29,3.0.0-alpha-1,"Curious case of {{version.h}} hbase-native-client relies on this include file to compile. However that is not generated by the HBase repo. I see no trace of it in the git log, wonder how it even worked until now. I think it will be useful to generate it during compilation and package it with the release tar ball. This helps [~phrocker] in HBASE-24400." Automatically download CMake Dependencies,13305985,Closed,Major,Fixed,19/May/20 19:04,11/Jun/20 19:40,,"To improve the ability to build we should download and link a local version of dependencies ( in the build folder )   This will help with skew of versions and the ability to build the project.   This will help the build process in docker and allow people to develop locally. this will also pave the way for future work to support" Lets get a clean test run for hbase-native-client,13310770,Closed,Major,Not A Problem,10/Jun/20 23:24,23/Jun/22 20:14,native-client-0.1.0,"Now that the build system is cleaned up somewhat (via HBASE-24400), lets aim to get a clean test run on hbase-native-client. Upon quick inspection of code, there are tons of issues with tests that needs to be fixed. Lets make them as sub tasks of this jira so that its easy to track the whole effort." Remove 2.1.10 from the release dist site,13301805,Closed,Major,Fixed,29/Apr/20 14:09,01/May/20 12:36,,Will do this after the rebuilding of our website. Remove jenkins files on branch-2.1 to disable nightly and pre commit,13297749,Closed,Major,Fixed,11/Apr/20 06:29,25/Apr/20 01:45,, Remove 2.1 from the release managers section in ref guide,13297748,Closed,Major,Fixed,11/Apr/20 06:29,25/Apr/20 01:47,, Remove 2.1.10 from download page,13297747,Closed,Major,Fixed,11/Apr/20 06:28,29/Apr/20 14:07,, add EOM date for 2.1.x to downloads.a.o header,13306208,Closed,Major,Fixed,20/May/20 14:53,20/May/20 14:57,, [hbase-operator-tools] Tool to Report on row sizes and column counts,13305737,Closed,Major,Fixed,18/May/20 18:29,16/Aug/20 12:40,,"Tool to run against a table that will report on row sizes and column counts. {code} $ HBASE_CLASSPATH_PREFIX=./target/hbase-table-reporter-1.1.0-SNAPSHOT.jar ../../hbase.apache.git/bin/hbase org.apache.hbase.reporter.TableReporter Usage: reporter TABLENAME OPTIONS: -h,--help Output this help message -l,--limit Scan row limit (per thread): default none -f,--fraction Fraction of table Regions to read; between 0 and 1: default 1.0 (all) -r,--region Scan this Region only; pass encoded name; 'fraction' is ignored. -t,--threads Concurrent thread count (thread per Region); default 1 -Dproperty=value Properties such as the zookeeper to connect to; e.g: -Dhbase.zookeeper.quorum=ZK0.remote.cluster.example.org {code} Primitive. Uses sketches to generate percentiles and histograms. Can be expanded upon." Disable webui access log by default,13308399,Closed,Major,Not A Problem,29/May/20 20:53,29/May/20 21:38,,"HBASE-24310 introduced an access log for http requests, which logs through the standard logging facility. This adds a lot of noise to the master and region server logs. Let's disable it by default." Implement JvmMetrics in HBase instead of using the one in hadoop,13304874,Closed,Major,Later,14/May/20 08:23,20/Jun/20 01:55,,"The JvmMetrics from hadoop is hard coded to use log4j. Although we do not make use of the ability, it still prevents us to ban the log4j dependencies completely. So let's implement the JvmMetrics by our own, based on log4j2." Document how to move WebUI access log entries to a separate log file,13304768,Closed,Major,Duplicate,13/May/20 21:34,14/May/20 18:19,2.3.0,"I've noticed that after a recent commit, we now have webui access log lines going into our service log file. The log entires are going to a logger called {{http.requests.regionserver}}, and after the preamble of timestamp, log level, logger, they appear to be conformant to the [CLF|https://en.wikipedia.org/wiki/Common_Log_Format] specification. Tools designed for parsing http logs usually expect to have just the CLF entries, and not need preprocessing. We should document how to configure the service to log these entries into a separate log file." Document how to configure the http request log,13303531,Closed,Major,Fixed,08/May/20 02:51,30/May/20 00:10,2.3.0, Use Slf4jRequestLog for hbase-http,13302558,Closed,Major,Fixed,04/May/20 02:40,08/May/20 03:31,,To remove the direct dependency on log4j in hbase-http server. Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly,13302556,Closed,Major,Fixed,04/May/20 01:58,03/Jun/20 17:28,,"In general, a library should not force the down stream users to use a specific logging framework, and this is why there is a slf4j library. For HBase, since we also publish the testing-util module which almost depends on all other sub modules, we should not introduce logging dependencies other than slf4j-api in these modules. We should only add log4j dependencies in hbase-assembly and ship it with our binary distribution. This is also important for switching to log4j2." batch Increment/Append fails when retrying the RPC,13309907,Closed,Major,Fixed,07/Jun/20 01:44,08/Jun/20 02:22,,"When a client hits RPC timeout and sends a second RPC request for batch Increment/Append but the first RPC is already processed actually, the nonce of the RPC is saved in the RS. In this case, for the second RPC, the RS just reads the previous result and returns it to the client to avoid the Increment/Append is processed twice. At that time, for batch Increment/Append, we try to create a Get object from a CellScanner object in the following code: [https://github.com/apache/hbase/blob/66452afc09d8b82927e5e58565f97939faa22c7b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L773-L776] However, the CellScanner object is already consumed to create the Increment/Append object in the following code, and it fails with the following exception: [https://github.com/apache/hbase/blob/66452afc09d8b82927e5e58565f97939faa22c7b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L757] {code:java} 2020-06-06 14:09:06,153 WARN [hconnection-0x79c3903e-shared-pool3-t209] client.AsyncRequestFutureImpl: id=1, table=REF_Test, attempt=3/36, failureCount=1ops, last exception=org.apache.hadoop.hbase.DoNotRetryIOException: org.apache.hadoop.hbase.DoNotRetryIOException: Cell count of 1 but at index 0 no cell returned: row: ""xxxxxxxxxxx"" mutate_type: INCREMENT timestamp: 9223372036854775807 durability: USE_DEFAULT time_range { from: 0 to: 9223372036854775807 } associated_cell_count: 1 nonce: 5281583076322914765 at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toGet(ProtobufUtil.java:934) at org.apache.hadoop.hbase.regionserver.RSRpcServices.increment(RSRpcServices.java:737) at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:877) at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2702) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42202) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:132) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) {code}" hbck2 command should accept one or more files containing a list of region names/table names/namespaces,13312267,Resolved,Major,Fixed,18/Jun/20 15:43,22/Apr/22 14:04,hbase-operator-tools-1.0.0,"Currently many command accepts a list of region names/ table names/namespaces on the command line.  We should accept paths to one or more files that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files. Similar work has been done in https://issues.apache.org/jira/browse/HBASE-23927" Improve region housekeeping status observability,13310495,Resolved,Major,Implemented,09/Jun/20 23:27,13/Jun/22 15:22,,"We provide a coarse grained admin API and associated shell command for determining the compaction status of a table: {noformat} hbase(main):001:0> help ""compaction_state"" Here is some help for this command: Gets compaction status (MAJOR, MAJOR_AND_MINOR, MINOR, NONE) for a table: hbase> compaction_state 'ns1:t1' hbase> compaction_state 't1' {noformat} We also log compaction activity, including a compaction journal at completion, via log4j to whatever log aggregation solution is available in production. This is not sufficient for online and interactive observation, debugging, or performance analysis of current compaction activity. In this kind of activity an operator is attempting to observe and analyze compaction activity in real time. Log aggregation and presentation solutions have typical latencies (end to end visibility of log lines on the order of ~minutes) which make that not possible today. We don't offer any API or tools for directly interrogating split and merge activity in real time. Some indirect knowledge of split or merge activity can be inferred from RIT information via ClusterStatus. It can also be scraped, with some difficulty, from the debug servlet. We should have new APIs and shell commands, and perhaps also new admin UI views, for at regionserver scope: * listing the current state of a regionserver's compaction, split, and merge tasks and threads * counting (simple view) and listing (detailed view) a regionserver's compaction queues * listing a region's currently compacting, splitting, or merging status at master scope, aggregations of the above detailed information into: * listing the active compaction tasks and threads for a given table, the extension of _compaction_state_ with a new detailed view * listing the active split or merge tasks and threads for a given table's regions Compaction detail should include the names of the effective engine and policy classes, and the results and timestamp of the last compaction selection evaluation. Split and merge detail should include the names of the effective policy classes and the result of the last split or merge criteria evaluation. " Skip HDFSBlockDistribution calc when FS is not HDFS,13304168,Resolved,Major,Incomplete,11/May/20 17:07,12/Jun/22 18:40,2.5.0,"HDFSBlockDistribution is used in different places like Balancer, DateTieredCompaction, CompactionTool etc. In Balancer area there is a config 'hbase.master.balancer.uselocality' using which we can skip this. But irrespective of this config, if we are on non HDFS FS, we should skip this. The block distribution issue many file status commands to underlying FS which wont be that cheap in a cloud FS. This jira aims at correcting all these places. " Replication queue recovery tool for rescuing deep queues,13307494,Resolved,Major,Won't Fix,26/May/20 17:27,11/Jun/22 23:49,,"In HBase cross site replication, on the source side, every regionserver places its WALs into a replication queue and then drains the queue to the remote sink cluster. At the source cluster every regionserver participates as a source. At the sink cluster, a configurable subset of regionservers volunteer to process inbound replication RPC. When data is highly skewed we can take certain steps to mitigate, such as pre-splitting, or manual splitting, and rebalancing. This can most effectively be done at the sink, because replication RPCs are randomly distributed over the set of receiving regionservers, and splitting on the sink side can effectively redistribute resulting writes there. On the source side we are more limited. If writes are deeply unbalanced, a regionserver's source replication queue may become very deep. Hotspotting can happen, despite mitigations. Unlike on the sink side, once hotspotting has happened at the source, it is not possible to increase parallelism or redistribute work among sources once WALs have already been enqueued. Increasing parallelism on the sink side will not help if there is a big rock at the source. Source side mitigations like splitting and region redistribution cannot help deep queues already accumulated. Can we redistribute source work? Yes and no. If a source regionserver fails, its queues will be recovered by other regionservers. However the other rs must still serve the recovered queue as an atomic entity. We can move a deep queue, but we can't break it up. Where time is of the essence, and ordering semantics can be allowed to break, operators should have available to them a recovery tool that rescues their production from the consequences of deep source queues. A very large replication queue can be split into many smaller queues. Perhaps even one new queue for each WAL file. Then, these new synthetic queues can be distributed to any/all source regionservers through the normal recovery queue assignment protocol. This increases parallelism at the source. Of course this would break serial replication semantics and even in branch-1 which does not have that feature it would signficantly increase the probability of reordering of edits. That is an unavoidable consequence of breaking up the queue for more parallelism. As long as this is done by a separate tool, invoked by operators, it is a valid option for emergency drain, and once the drain is complete, the final state will be properly ordered. Every cell in the WAL entries carries a timestamp assigned at the source, and will be applied on the sink with this timestamp. When the queue is drained and all edits have been persisted at the target, there will be a complete and correct temporal data ordering at that time. An operator will be and must be prepared to handle intermediate mis-/re-ordered states if they intend to invoke this tool. In many use cases the interim states are not important. The final state after all edits have transferred cross cluster and persisted at this sink, after invocation of the recovery tool, is the point where the operator would transition back into service. As a strawman we can propose these work items: - Add a replication admin command that can reassign a replication queue away from an active source. The active source makes a new queue and continues. The previously active queue can be assigned to another regionserver as a recovery queue or can be left unassigned (e.g. target = null) - Administratively unassigned recovery queues should not be automatically processed, but must be discoverable. - Add a replication admin command that transitions an unassigned replication queue into an active and eligible recovery queue. - Create a tool that uses these new APIs to take control of a (presumably deep) replication queue, breaks up the queue into its constituent WAL files, creates new synthetic queues according to a configurable and parameterized grouping function, and uses the new APIs to make the new synthetic queues eligible for recovery. The original queue retains one group as defined by the grouping policy and itself is made re-eligible for recovery. " SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy,13313165,Resolved,Major,Incomplete,24/Jun/20 04:14,11/Jun/22 19:41,2.3.0,"In testing, 1% of a decent cluster went down with this seg fault in the vm: {code} # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f6659052410, pid=37208, tid=0x00007f3c89453700 # # JRE version: OpenJDK Runtime Environment (8.0_232-b09) (build 1.8.0_232-b09) # Java VM: OpenJDK 64-Bit Server VM (25.232-b09 mixed mode linux-amd64 ) # Problematic frame: # v ~StubRoutines::jbyte_disjoint_arraycopy {code} Looking in the hs_err log, the crash happens in the same area. Here are a few of the stack traces: {code} Stack: [0x00007f3c89353000,0x00007f3c89454000], sp=0x00007f3c89452110, free space=1020k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) v ~StubRoutines::jbyte_disjoint_arraycopy J 17674 C2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V (69 bytes) @ 0x00007f665af000d1 [0x00007f665aefffe0+0xf1] J 17732 C1 org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I (59 bytes) @ 0x00007f665bc440dc [0x00007f665bc43b80+0x55c] j org.apache.hadoop.hbase.CellUtil.cloneQualifier(Lorg/apache/hadoop/hbase/Cell;)[B+12 J 22278 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B (5 bytes) @ 0x00007f6659bd4784 [0x00007f6659bd4760+0x24] j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;Ljava/util/function/Function;)Ljava/lang/String;+97 j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;)Ljava/lang/String;+6 j org.apache.hadoop.hbase.CellUtil.toString(Lorg/apache/hadoop/hbase/Cell;Z)Ljava/lang/String;+16 j org.apache.hadoop.hbase.ByteBufferKeyValue.toString()Ljava/lang/String;+2 j org.apache.hadoop.hbase.client.Mutation.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Mutation;+28 J 22605 C2 org.apache.hadoop.hbase.client.Put.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Put; (8 bytes) @ 0x00007f665a982a04 [0x00007f665a9829e0+0x24] J 22112 C2 org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MutationProto;Lorg/apache/hadoop/hbase/CellScanner;)Lorg/apache/hadoop/hbase/client/Put; (910 bytes) @ 0x00007f665c706700 [0x00007f665c706000+0x700] J 24084 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apache/hadoop/hbase/quotas/OperationQuota;Ljava/util/List;Lorg/apache/hadoop/hbase/CellScanner;Lorg/apache/hadoop/hbase/quotas/ActivePolicyEnforcement;Z)V (646 bytes) @ 0x00007f665cc21100 [0x00007f665cc20c80+0x480] J 14696 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apache/hadoop/hbase/quotas/OperationQuota;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionAction;Lorg/apache/hadoop/hbase/CellScanner;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;Ljava/util/List;JLorg/apache/hadoop/hbase/regionserver/RSRpcServices$RegionScannersCloseCallBack;Lorg/apache/hadoop/hbase/ipc/RpcCallContext;Lorg/apache/hadoop/hbase/quotas/ActivePolicyEnforcement;)Ljava/util/List; (901 bytes) @ 0x00007f665b722148 [0x00007f665b7218e0+0x868] {code} Here's another: {code} Stack: [0x00007edd015e2000,0x00007edd016e3000], sp=0x00007edd016e11b0, free space=1020k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) v ~StubRoutines::jbyte_disjoint_arraycopy J 18255 C2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V (69 bytes) @ 0x00007f06d2593551 [0x00007f06d2593460+0xf1] j org.apache.hadoop.hbase.PrivateCellUtil.copyTagsTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31 j org.apache.hadoop.hbase.CellUtil.cloneTags(Lorg/apache/hadoop/hbase/Cell;)[B+12 j org.apache.hadoop.hbase.ByteBufferKeyValue.getTagsArray()[B+1 j org.apache.hadoop.hbase.CellUtil.toString(Lorg/apache/hadoop/hbase/Cell;Z)Ljava/lang/String;+40 j org.apache.hadoop.hbase.ByteBufferKeyValue.toString()Ljava/lang/String;+2 j org.apache.hadoop.hbase.client.Mutation.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Mutation;+28 J 24361 C2 org.apache.hadoop.hbase.client.Put.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Put; (8 bytes) @ 0x00007f06d1c04d04 [0x00007f06d1c04ce0+0x24] J 24273 C2 org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MutationProto;Lorg/apache/hadoop/hbase/CellScanner;)Lorg/apache/hadoop/hbase/client/Put; (910 bytes) @ 0x00007f06d4de48b4 [0x00007f06d4de40e0+0x7d4] ... {code} And here… {code} Stack: [0x00007f63d89ba000,0x00007f63d8abb000], sp=0x00007f63d8ab9170, free space=1020k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) v ~StubRoutines::jbyte_disjoint_arraycopy J 22303 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B (5 bytes) @ 0x00007f8dac8dc067 [0x00007f8dac8dbae0+0x587] j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;Ljava/util/function/Function;)Ljava/lang/String;+97 j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;)Ljava/lang/String;+6 j org.apache.hadoop.hbase.CellUtil.toString(Lorg/apache/hadoop/hbase/Cell;Z)Ljava/lang/String;+16 j org.apache.hadoop.hbase.ByteBufferKeyValue.toString()Ljava/lang/String;+2 j org.apache.hadoop.hbase.client.Mutation.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Mutation;+28 j org.apache.hadoop.hbase.client.Put.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Put;+2 .... {code} Its this bit of code....in Mutation...processing a large multi request: {code} Mutation add(Cell cell) throws IOException { //Checking that the row of the kv is the same as the mutation // TODO: It is fraught with risk if user pass the wrong row. // Throwing the IllegalArgumentException is more suitable I'd say. if (!CellUtil.matchingRows(cell, this.row)) { throw new WrongRowIOException(""The row in "" + cell.toString() + "" doesn't match the original one "" + Bytes.toStringBinary(this.row)); } ... {code} Its the call to 'cell.toString()' seemingly each time. Oh, I can't reproduce at least with basic messing. " Prevent temporal misordering on timescales smaller than one clock tick,13307500,Open,Major,,26/May/20 17:54,,,"When mutations are sent to the servers without a timestamp explicitly assigned by the client the server will substitute the current wall clock time. There are edge cases where it is at least theoretically possible for more than one mutation to be committed to a given row within the same clock tick. When this happens we have to track and preserve the ordering of these mutations in some other way besides the timestamp component of the key. Let me bypass most discussion here by noting that whether we do this or not, we do not pass such ordering information in the cross cluster replication protocol. We also have interesting edge cases regarding key type precedence when mutations arrive ""simultaneously"": we sort deletes ahead of puts. This, especially in the presence of replication, can lead to visible anomalies for clients able to interact with both source and sink. There is a simple solution that removes the possibility that these edge cases can occur: We can detect, when we are about to commit a mutation to a row, if we have already committed a mutation to this same row in the current clock tick. Occurrences of this condition will be rare. We are already tracking current time. We have to know this in order to assign the timestamp. Where this becomes interesting is how we might track the last commit time per row. Making the detection of this case efficient for the normal code path is the bulk of the challenge. One option is to keep track of the last locked time for row locks. (Todo: How would we track and garbage collect this efficiently and correctly. Not the ideal option.) We might also do this tracking somehow via the memstore. (At least in this case the lifetime and distribution of in memory row state, including the proposed timestamps, would align.) Assuming we can efficiently know if we are about to commit twice to the same row within a single clock tick, we would simply sleep/yield the current thread until the clock ticks over, and then proceed. " Remove HBaseTestCase and GenericTestUtils,13309751,Resolved,Major,Fixed,05/Jun/20 15:00,09/Jun/20 07:56,,"It is still a junit3 style test base, let's remove it. GenericTestUtils is also useless, remove it." Run a perf comparison of 2.3.x with 2.2.x,13297186,Resolved,Major,Won't Do,08/Apr/20 18:43,10/Feb/22 14:38,2.3.0,Kick the tires on a recent build. Compare results with a run on the latest 2.2.x. [hbase-thirdparty] Bump the dependencies for hbase-thirdparty,13300408,Resolved,Major,Fixed,23/Apr/20 02:00,24/Apr/20 17:52,, Refactor TestCustomSaslAuthenticationProvider,13307751,Resolved,Major,Fixed,27/May/20 14:03,28/May/20 12:52,,"As now it will restart the cluster after every single test, which is not necessary, as we only need to restart the cluster when we change the rpc server implementation, it is better to split it into two files." Move hbase-connectors to hbase-thirdparty-3.3.0,13304322,Resolved,Major,Duplicate,12/May/20 09:27,13/Jan/22 19:16,hbase-connectors-1.0.1, Reduce cpu load of locating region especially in batch mode.,13302296,Patch Available,Major,,01/May/20 11:46,,1.2.12,"Binary search is used to speedup the process of locating region. It is already fast enough, while cpu of HBASE client becomes the bottleneck when doing TCSB benchmark. We can make the process of locating region faster to reduce cpu load in some special cases , which however is our common case in production environment.  It is the case:          1. Predefined splits in uniform distribution.           2. Load data in batch mode. The optimization is very simple, just to contract range of binary search. Initially,  record all startIndex and endIndex of first or two bytes of keys. When a region key comes, find the contracted startIndex and endIndex of the key. Then return to normal binary search process with the specified startIndex and endIndex.  Then we can ideally reduce cpu to 1/8 with 1 byte or 1/16 with 2 bytes." HBCK2 feature negotiation for commands not on Hbck interface,13299054,Open,Major,,17/Apr/20 09:58,,,"Some HBCK2 commands use version based checking for determining compatibility. HBASE-24039 changed this to feature-based compatibility check with commands using org.apache.hadoop.hbase.client.Hbck interface. A similar approach is needed for the remaining commands that are using different APIs." Make PE to have both read and write ability to go in parallel as in YCSB,13309741,Open,Major,,05/Jun/20 14:12,,2.5.0,Currently we can either run pure writes or pure reads in case of PE. The case where few threads can do write and few can do reads is not available. We can improve the PE to atleast support writes and either Scans or Gets in parallel. Purge use of VisibleForTesting,13313649,Resolved,Major,Fixed,26/Jun/20 16:33,25/Nov/20 22:29,2.4.0,"From the dev-list thread [""[DISCUSS] VisibleForTesting annotation as it pertains to our API compatibility guidelines""|https://lists.apache.org/thread.html/rc7c7c66f134fe135d0a4454a883215e26ff3d20e5a31ecd6a2d1db77%40%3Cdev.hbase.apache.org%3E], when used in classes annotated with interface audience other than IA.Private, the VisibleForTesting annotation is confusing and considered harmful. The consensus is that we do not want to use this annotation as part of the definition of our public APIs, and we need to remove the point of confusion." Update GC config examples in hbase-env.sh for G1GC,13300064,Open,Major,,21/Apr/20 19:08,,2.3.0,"Anywhere we changed the default collector to G1GC, we should also update {{hbase-env.sh}} to include GC configuration examples appropriate for that collector and JVM. This means, where we support both JDK8 and JDK11, we'll have two sections of examples, one for CMS and the other for G1." Improve balancer decision observability,13310502,Resolved,Major,Fixed,09/Jun/20 23:56,16/Oct/20 06:53,,"We provide detailed INFO and DEBUG level logging of balancer decision factors, outcome, and reassignment planning, as well as similarly detailed logging of the resulting assignment manager activity. However, an operator may need to perform online and interactive observation, debugging, or performance analysis of current balancer activity. Scraping and correlating the many log lines resulting from a balancer execution is labor intensive and has a lot of latency (order of ~minutes to acquire and index, order of ~minutes to correlate). The balancer should maintain a rolling window of history, e.g. the last 100 region move plans, or last 1000 region move plans submitted to the assignment manager. This history should include decision factor details and weights and costs. The rsgroups balancer may be able to provide fairly simple decision factors, like for example ""this table was reassigned to that regionserver group"". The underlying or vanilla stochastic balancer on the other hand, after a walk over random assignment plans, will have considered a number of cost functions with various inputs (locality, load, etc.) and multipliers, including custom cost functions. We can devise an extensible class structure that represents explanations for balancer decisions, and for each region move plan that is actually submitted to the assignment manager, we can keep the explanations of all relevant decision factors alongside the other details of the assignment plan like the region name, and the source and destination regionservers. This history should be available via API for use by new shell commands and admin UI widgets. The new shell commands and UI widgets can unpack the representation of balancer decision components into human readable output. " RequestId Tracing feature for HBase ,13313604,Resolved,Major,Not A Problem,26/Jun/20 13:38,09/Oct/21 07:43,,Associate a TraceId corresponding to Hbase Put Request on the mutation level which will be further propagated to the RPC layer. This will enable cost-effective logging of the Request Flow and help identifying Network bottlenecks. We aim to send the TraceId to the RPC server by modifying the RequestProto. CloneSnapshotProcedure unlimited retry,13311067,Resolved,Major,Fixed,12/Jun/20 06:55,06/Jul/20 06:13,2.2.5,"since regions dir was not remove in the previous execution created, need to be remove when retrying, resulting in exception, unlimited retry {code:java} procedure.CloneSnapshotProcedure: Retriable error trying to clone snapshot=snapshot_test to table=test:backup state=CLONE_SNAPSHOT_WRITE_FS_LAYOUT org.apache.hadoop.hbase.snapshot.RestoreSnapshotException: clone snapshot={ ss=snapshot_test table=test:backup type=FLUSH } failed because A clone should not have regions to remove at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:434) at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFsLayout(CloneSnapshotProcedure.java:465) at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.createFilesystemLayout(CloneSnapshotProcedure.java:392) at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:142) at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure.executeFromState(CloneSnapshotProcedure.java:67) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:194) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1662) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1409) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1979) Caused by: java.lang.IllegalArgumentException: A clone should not have regions to remove at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142) at org.apache.hadoop.hbase.master.procedure.CloneSnapshotProcedure$1.createHdfsRegions(CloneSnapshotProcedure.java:418) ... 10 more {code} and the cloned regions name are unchanged, resulting in new created regions be removed when retrying" Change default Hfile storage policy from HOT to NONE for HDFS,13312626,Resolved,Major,Fixed,20/Jun/20 16:55,02/Oct/21 08:46,2.2.5,"The current HBase hfile directory specifies the *HOT* storage strategy by default(`hbase.hstore.blockingStoreFiles` ), which is different from the default value of HDFS *heterogeneous* strategy now(should be empty) It should be set to *NONE* like `hbase.wal.storage.policy`'s default value on HBASE-20691, and the reason for modification is the same Otherwise, it could have a significant impact because most HDFS Managers doesn't know the default value has been changed to *HOT* by hbase, for example: HDFS manger want to set hfile's dir to ONE_SSD for speed up read, they will do: {code:java} // Set Hbas Hfile dir to ONE_SSD for speed up read // The policy that expects all subdirectories to inherit the parent directory by default (empty by default) bin/hdfs storagepolicies -setStoragePolicy -path /home/hbase/data -policy ONE_SSD bin/hdfs storagepolicies -setStoragePolicy -path /home/hbase/WALs -policy ALL_SSD // If we do not change Hbase default setting, we will find this bin/hdfs storagepolicies -getStoragePolicy -path /home/hbase/data/hbase/meta/xxxx/info return ""HOT"" instead of ""ONE_SSD""{code} And here is a pic to show the problem ↑:   !hfile-policy-problem.png! However, if Hfile uses the *HOT* strategy by default, then we will find that the actually stored directory has been set to HOT, then it will *not inherit* the *ONE_SSD* of the parent directory policy, and if we set *NONE* in hbase, this is problem can be avoided  Unless someone sets other values manually, then we believe the operator knows what he is doing" Reseek regression related to filter SKIP hinting,13313535,Open,Major,,26/Jun/20 01:39,,2.2.5,"I have been looking into reported performance regressions in HBase 2 relative to HBase 1. Depending on the test scenario, HBase 2 can demonstrate significantly better microbenchmarks in a number of cases, and usually shows improvement in whole cluster benchmarks like YCSB. To assist in debugging I added methods to RpcServer for updating per-call metrics that leverage the fact it puts a reference to the current Call into a thread local and that all activity for a given RPC is processed by a single thread context. I then instrumented ScanQueryMatcher (in branch-1) and its various friends (in branch-2.2), StoreScanner, HFileReaderV2 and HFileReaderV3 (in branch-1) and HFileReaderImpl (in branch-2.2), HFileBlock, and DefaultMemStore (branch-1) and SegmentScanner (branch-2.2). Test tables with one family and 1, 5, 10, 20, 50, and 100 distinct column-qualifiers per row were created, snapshot, dropped, and cloned from the snapshot. Both 1.6 and 2.2 versions under test operated on identical data files in HDFS. For tests with 1.6 and 2.2 on the server side the same 1.6 PE client was used, to ensure only the server side differed. The results for pe --filterAll were revealing. See attached. It appears a refactor to ScanQueryMatcher and friends has disabled the ability of filters to provide meaningful SKIP hints, which disables an optimization that avoids reseeking, leading to a serious and proportional regression in reseek activity and time spent in that code path. So for queries that use filters, there can be a substantial regression. Other test cases that did not use filters did not show this regression. If filters are not used the behavior of ScanQueryMatcher between 1.6 and 2.2 was almost identical, as measured by counts of the hint types returned, whether or not column or version trackers are called, and counts of store seeks or reseeks. Regarding micro-timings, there was a 10% variance in my testing and results generally fell within this range, except for the filter all case of course. " BulkLoad Will Fall Into Unbelievable Retry Attempt in Some case,13306905,Patch Available,Major,,23/May/20 02:17,,,"In https://issues.apache.org/jira/browse/HBASE-14541, the retry logic changed from a configurable retry times(by configuration item hbase.bulkload.retries.number) to below retry logic to process the issue that the RegionSplit happened during bulk load:   {code:java} int maxRetries = getConf().getInt(""hbase.bulkload.retries.number"", 10); maxRetries = Math.max(maxRetries, startEndKeys.getFirst().length + 1); if (maxRetries != 0 && count >= maxRetries) { throw new IOException(""Retry attempted "" + count + "" times without completing, bailing out""); }{code} This issue caused another issue in our cluster, that is: Our table has *2000* regions and our bulk load failed for an configuration issue: This failure is caused by a client mis-configuration and cause the RegionServer fail to load the HFile, but the response is not thrown as exception to client, but marked as a variable `*loaded*` in the `*BulkLoadHFileResponse*` {code:java} message BulkLoadHFileResponse { required bool loaded = 1; }{code} After this failure, the bulk load fall into a retry disaster and after the retry reached about 200, our HDFS crashed for OOM. {code:java}  {code}   But during with, the HBase table splits in fact didn't happen ever. I think the patch in HBASE-14541 didn't handle the unrecoverable retry case and in this case(I think many reason may incur unrecoverable retry) the meaningless retry attempts becomes disaster and is un-configurable because we cannot change the Region number of our table;" Remove data locality and StoreFileCostFunction for replica regions out of balancer's cost calculation,13313355,Open,Major,,25/Jun/20 00:35,,2.3.0,"We found one of the clusters with read replica enabled always balance lots of replica regions. going through the balancer's cost functions, found that data locality and StoreFileCost have same multiplier for both primary and replica regions. That is something we can improve. Data locality for replica regions should not be a dominant factor for balancer. We can either remove it out of balancer's picture for now and give it a small multiplier." Store the locations of meta regions in master local store,13305489,Resolved,Major,Fixed,17/May/20 13:04,27/May/20 03:34,, Replace Cluster#primariesOfRegionsPerServer from int array to treemap,13313659,Open,Major,,26/Jun/20 17:21,,2.3.0,"Currently, primariesOfRegionsPerServer is an int array, moveRegion does heavy work by searching the array (linearly) and insert/remove an element requires allocating/copying the whole array." Backport HBASE-24305 to branch-2,13309884,Resolved,Major,Fixed,06/Jun/20 18:16,05/Apr/21 20:10,2.5.0,"Backport the changes from HBASE-24305, which are not related to removed deprecated methods." "Add Increment, Append and CheckAndMutate support to RowMutations",13299225,Resolved,Major,Won't Fix,17/Apr/20 20:48,04/Nov/20 04:56,,"Currently, RowMutations supports only Put and Delete. Supporting Increment, Append and CheckAndMutate in RowMutations would be helpful for some use cases." Normalizer merge plans should consider more than 2 regions when possible,13306827,Resolved,Major,Fixed,22/May/20 16:09,30/Oct/20 17:44,2.3.0,"The merge plans produced by the normalizer operate over two regions. Our merge operation supports multiple regions in a single request. When there are multiple merge plans generated over contiguous region space, these should be collapsed into a single merge operation. This should automatically honor whatever existing configuration settings exist limiting the number of regions that can participate in a merge procedure." [Flakey Tests] Disable TestClusterPortAssignment.testClusterPortAssignment as it can't pass 100% of the time,13303480,Resolved,Major,Fixed,07/May/20 20:14,07/May/20 20:26,,"This is a BindException special. We get randomFreePort and then put up the procesess. {code} 2020-05-07 00:30:15,844 INFO [Time-limited test] http.HttpServer(1080): HttpServer.start() threw a non Bind IOException java.net.BindException: Port in use: 0.0.0.0:59568 at org.apache.hadoop.hbase.http.HttpServer.openListeners(HttpServer.java:1146) at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1077) at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:148) at org.apache.hadoop.hbase.regionserver.HRegionServer.putUpWebUI(HRegionServer.java:2133) at org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:670) at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:511) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:132) at org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:239) at org.apache.hadoop.hbase.LocalHBaseCluster.(LocalHBaseCluster.java:181) at org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:245) at org.apache.hadoop.hbase.MiniHBaseCluster.(MiniHBaseCluster.java:115) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1178) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1142) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1106) at org.apache.hadoop.hbase.TestClusterPortAssignment.testClusterPortAssignment(TestClusterPortAssignment.java:57) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) Caused by: java.net.BindException: Address already in use at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:433) at sun.nio.ch.Net.bind(Net.java:425) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:351) at org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:319) at org.apache.hadoop.hbase.http.HttpServer.openListeners(HttpServer.java:1137) ... 41 more {code} It came in w/ HBASE-20027. It picks random ports and then asserts that it was able to up processes on these ports. This cannot pass 100% of the time so I'm disabling this test." RegionNormalizer spliting region should not be limited by hbase.normalizer.min.region.count,13306666,Resolved,Major,Fixed,22/May/20 04:03,28/May/20 08:29,3.0.0-alpha-1,"In method computePlanForTable of SimpleRegionNormalizer:  we will skip spliting region if the number of regions in the table is less than hbase.normalizer.min.region.count, even if there is a huge region in the table. {code:java} ... if (tableRegions == null || tableRegions.size() < minRegionCount) { ... return null; } ... // get region split plan if (splitEnabled) { List splitPlans = getSplitNormalizationPlan(table); if (splitPlans != null) { plans.addAll(splitPlans); } } {code}  " Consolidate Normalizer implementations,13306824,Resolved,Major,Fixed,22/May/20 16:04,03/Jun/20 23:45,2.3.0,"After HBASE-22285, we have two implementations of {{RegionNormalizer}}, that have different feature sets and different configurations. I think these can be combined into a single implementation, with clear, decoupled configuration parameters. At least on branch-2.3, there's too many subsequent changes for HBASE-22285 to revert cleanly, so I'll use this ticket to consolidate the implementations. If you have issues with the current normalizer, speak up here and we can include them, or add them as sub-tasks." ServerName#getHostname() is case sensitive,13305642,Resolved,Major,Fixed,18/May/20 09:43,15/Mar/21 23:56,1.3.1,"ServerName calss，the getServerName(String hostName, int port, long startcode),equals and compareTo are case insensitive, but getHostname() is case sensitive. if hostName is HOSTNAME1, ServerName is hostname1,11111,1589615319931, and getHostname() returns HOSTNAME1. and then BaseLoadBalancer#retainAssignment() uses ServerName#getHostname(), all keys of serversByHostname are upperCase(HOSTNAME1,HOSTNAME2,HOSTNAME3,HOSTNAME4...) from ServerManager#createDestinationServersList, but oldServerName.getHostname() is lowerCase(hostname1,hostname2,hostname3...) from walLog dir. !image-2020-05-18-17-42-57-119.png! and finally...all region of old ServerName will be assigned to random hosts" "HBCK2 should accept ""hbase:meta"" as an alias for the encoded region name",13302173,Open,Major,,30/Apr/20 17:54,,2.3.0,"Simple one: hbck2 should accept the alias ""meta"" in place of the encoded region name. It's a little silly to have to say {{hbck2 assigns 1588230740}}" DateTiered Compaction should disallow 'hbase.rs.cachecompactedblocksonwrite' if the compacted file is from older window,13305174,Open,Major,,15/May/20 11:06,,3.0.0-alpha-1,"This issue is related to https://issues.apache.org/jira/browse/HBASE-23066. In Date tiered compaction once we move to old window - we should ideally not cache the resultant file because generally those files are not read (as it is not the window of our interest). We can provide a switch to either turn it ON or OFF. Preferrably for Data tiered compaction this switch should be OFF." Improvement update_config for PressureAwareCompactionThroughputController,13300929,In Progress,Major,,25/Apr/20 06:03,,,"If we start major compaction on a big table first, then we modified compaction limit configuration and execute 'update_config' command, it will not effective immediately. The compaction which is running is still use the old Controller object. The higher.bound,lower.bound,offPeakHours is still the old value.   I think we can make the modification effective immediately. There is 2 points about it: 1.keep there is always only one PressureAwareCompactionThroughputController object in RS. 2.add a updateConfig method in Controller. when we use 'update_config' command to update compact pressure conf , it just change the value of  higher.bound,lower.bound,offPeakHours ,instead of create a new Controller" HBCK2 fix addFsRegionsMissingInMeta to add regions in CLOSED state again,13311721,Resolved,Major,Fixed,16/Jun/20 13:24,18/Jun/20 08:48,,"Originally, _addFsRegionsMissingInMeta_ relied on _MetaTableAccessor_ to add new regions, which correctly added new regions in CLOSED state. HBASE-23791 removed dependency on _MetaTableAccessor_ as to avoid relying on HBase IA private methods. _MetaTableAccessor_ functions needed by HBCK2 were then re-implemented on _HBCKMetaTableAccessor_. Implementation for _addRegionToMeta_, though, was not fully ported, and it was not setting newly added regions state.  This would cause attempts to assign the newly added regions to fail, as AM ignore regions without state defined in meta, requiring extra calls for hbck2 setRegionState command for each of the newly added regions. Kudos for [~brfrn169] who identified this problem while troubleshooting/fixing regions assignments issues with hbck2. This PR fix implementation of _HBCKMetaTableAccessor_._addRegionToMeta_ to insert new regions with _CLOSED_ state, and also adds extra checks for this behaviour on both _TestHBCKMetaTableAccessor_ and _TestFsRegionsMetaRecoverer_ UTs." hbase-filesystem to use guava from hbase-thirdparty,13296589,Resolved,Major,Fixed,06/Apr/20 18:42,14/Apr/20 21:57,hbase-filesystem-1.0.0-alpha1,"hbase-filesystem repo is on guava23.0: {noformat} $ grep -r ""guava"" . ./pom.xml: 23.0 ./hbase-oss/pom.xml: com.google.guava ./hbase-oss/pom.xml: guava ./hbase-oss/pom.xml: ${guava.version} ./hbase-oss/pom.xml: The bug lies here. We are not processing last bucket. long val = snapshot.getCountAtOrBelow(ranges[i]); if (val - cumNum > 0) { metricsRecordBuilder.addCounter( Interns.info(name + ""_"" + rangeType + ""_"" + priorRange + ""-"" + ranges[i], desc), val - cumNum); } priorRange = ranges[i]; cumNum = val; } long val = snapshot.getCount(); if (val - cumNum > 0) { metricsRecordBuilder.addCounter( Interns.info(name + ""_"" + rangeType + ""_"" + ranges[ranges.length - 1] + ""-inf"", desc), val - cumNum); } } {code} " [Flakey Tests] TestSnapshotScannerHDFSAclController,13296146,Resolved,Major,Fixed,04/Apr/20 00:34,08/Apr/20 21:13,2.3.0,"Still see the following error from the test. {code:java} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController ------------------------------------------------------------------------------- Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 342.32 s <<< FAILURE! - in org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.testGrantTable  Time elapsed: 6.82 s  <<< FAILURE! java.lang.AssertionError: expected:<6> but was:<-1>         at org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.testGrantTable(TestSnapshotScannerHDFSAclController.java:349) {code}" Tweak the master registry docs for branch-2,13310750,Resolved,Major,Fixed,10/Jun/20 20:54,12/Jun/20 21:59,2.3.0,"As Nick pointed out in https://github.com/apache/hbase/pull/1880, we need to re-word the content a bit so that it makes sense to branch-2 users. Specifically the following - What version has the feature shipped - A slight modification to the config keys after hedging moved from rpc layer to the registry code (HBASE-24265) The latter applies to the master branch too." TestHttpServer.testBindAddress failure with latest jetty,13298587,Resolved,Major,Fixed,15/Apr/20 14:23,16/Apr/20 09:58,,"The latest jetty version (tested with 9.4.28.v20200408 which is not included in HBase yet) wraps BindException into an IOException when it fails to bind to a port. This breaks HttpServer's findPort functionality, which manifests in TestHttpServer.testBindAddress failing. The proposed patch handles both the old and the new jetty behaviour correctly. " Apache Yetus test-patch and Jenkins integration,13313652,Resolved,Major,Fixed,26/Jun/20 17:01,13/Jul/20 16:24,,"Now that we have a clean test run with all the tests passing on trunk (with HBase trunk) , lets get the Yetus integration with test-patch utility working. That makes it much easier to implement a precommit with github." Fix README with docs on compiling and running tests,13311208,Open,Major,,12/Jun/20 22:20,,,"Once all the other issues are fixed, lets fix the documentation with the following information - Building shared and static libs for client. - Running the full test suite - Compiling with a custom HBase version ....." [Flakey Test] regionserver.TestRegionReplicas ,13295834,Resolved,Major,Fixed,02/Apr/20 16:28,05/Apr/20 20:26,2.3.0,"There are 3 failed runs from flakey test board. {code:java} org.apache.hadoop.hbase.regionserver.TestRegionReplicas.testFlushAndCompactionsInPrimaryFailing for the past 1 build (Since #5954 )Took 45 sec.Error Messageexpected null, but was:Stacktracejava.lang.AssertionError: expected null, but was: at org.apache.hadoop.hbase.regionserver.TestRegionReplicas.testFlushAndCompactionsInPrimary(TestRegionReplicas.java:432) Standard OutputFormatting using clusterid: testClusterID java.lang.ThreadGroup[name=PEWorkerGroup,maxpri=10] Thread[HFileArchiver-3,5,PEWorkerGroup] Thread[HFileArchiver-4,5,PEWorkerGroup] Standard Error {code}" Fix logging in tests,13311384,Resolved,Major,Fixed,15/Jun/20 05:49,19/Jun/20 20:43,,"In the current tests, glog/gflags etc are not initialized before running the tests. This results in logging to stderr by default. Fix the initialization so that we can redirect the logging to the appropriate log files/directories." Fix the classpath for the local mini-cluster,13310774,Resolved,Major,Fixed,10/Jun/20 23:40,12/Jun/20 22:13,3.0.0-alpha-1,"The classpath is created assuming the native-client is a module of the parent hbase repo. Since that is not the case anymore and we rely on a dynamically pulled HBase version, we need to fix the classpath for the JVM that is spun using JNI. Otherwise mini-cluster won't start.. {noformat} using hbase::MiniCluster; JNIEnv *MiniCluster::CreateVM(JavaVM **jvm) { JavaVMInitArgs args; JavaVMOption jvm_options; args.version = JNI_VERSION_1_6; args.nOptions = 1; char *classpath = getenv(""CLASSPATH""); std::string clspath; if (classpath == NULL || strstr(classpath, ""-tests.jar"") == NULL) { std::string clsPathFilePath(""../../../hbase-build-configuration/target/cached_classpath.txt""); std::ifstream fd(clsPathFilePath); std::string prefix(""""); if (fd.is_open()) { if (classpath == NULL) { LOG(INFO) << ""got empty classpath""; } else { // prefix bootstrapper.jar prefix.assign(classpath); } std::string line; {noformat}    " Deadlock in mini-cluster-test teardown on setup() failure,13310773,Resolved,Major,Fixed,10/Jun/20 23:35,17/Jun/20 19:09,3.0.0-alpha-1,"Code seems to be weirdly strucutred. Cleanup the life cycle {noformat} #0 __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135 #1 0x00007f4e2ce84023 in __GI___pthread_mutex_lock (mutex=0x55d922b810e8) at ../nptl/pthread_mutex_lock.c:78 #2 0x000055d9207b263a in __gthread_mutex_lock () #3 0x000055d9207b3bf4 in std::mutex::lock() () #4 0x000055d9207c2d88 in std::lock_guard::lock_guard(std::mutex&) () <== Attempts to lock mutex again. #5 0x000055d9208cbf86 in hbase::MiniCluster::Setup() () #6 0x000055d9208cc87c in hbase::MiniCluster::env() () #7 0x000055d9208cd33b in hbase::MiniCluster::StopCluster() () #8 0x000055d9208c8ace in hbase::TestUtil::StopMiniCluster() () #9 0x000055d9208c86d8 in hbase::TestUtil::~TestUtil() () #10 0x000055d92061bbb0 in std::default_delete::operator()(hbase::TestUtil*) const () #11 0x000055d920616c17 in std::unique_ptr >::~unique_ptr() () #12 0x00007f4e29e96041 in __run_exit_handlers (status=-1, listp=0x7f4e2a23e718 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true) at exit.c:108 #13 0x00007f4e29e9613a in __GI_exit (status=) at exit.c:139 #14 0x000055d9208cbb67 in hbase::MiniCluster::CreateVM(JavaVM_**) () #15 0x000055d9208cbfb1 in hbase::MiniCluster::Setup() () <== Locks mutex #16 0x000055d9208cc87c in hbase::MiniCluster::env() () #17 0x000055d9208cd227 in hbase::MiniCluster::StartCluster(int) () #18 0x000055d9208c879b in hbase::TestUtil::StartMiniCluster(int) () #19 0x000055d920613076 in AsyncBatchRpcRetryTest::SetUpTestCase() () #20 0x000055d9208eaa48 in testing::TestCase::RunSetUpTestCase() () #21 0x000055d9208f7347 in void testing::internal::HandleSehExceptionsInMethodIfSupported(testing::TestCase*, void (testing::TestCase::*)(), char const*) () #22 0x000055d9208f1b19 in void testing::internal::HandleExceptionsInMethodIfSupported(testing::TestCase*, void (testing::TestCase::*)(), char const*) () #23 0x000055d9208d6647 in testing::TestCase::Run() () #24 0x000055d9208dd552 in testing::internal::UnitTestImpl::RunAllTests() () #25 0x000055d9208f7d29 in bool testing::internal::HandleSehExceptionsInMethodIfSupported(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) () #26 0x000055d9208f21a5 in bool testing::internal::HandleExceptionsInMethodIfSupported(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) () #27 0x000055d9208dc116 in testing::UnitTest::Run() () #28 0x000055d920904ce7 in RUN_ALL_TESTS() () #29 0x000055d920904c76 in main () {noformat}" Switch docker to use new build system,13310776,Resolved,Major,Fixed,10/Jun/20 23:52,15/Jun/20 16:22,3.0.0-alpha-1,"Currently we download and build them manually [1], switch to use DOWNLOAD_DEPENDENCIES flag. [1] https://github.com/apache/hbase-native-client/blob/master/docker-files/Dockerfile" FsDelegationToken should cache Token,13306063,Patch Available,Major,,20/May/20 05:18,,2.2.5,"When doing Bulkload, we find that FsDelegationToken will acquire token of NameNode everytime for a single file, although, from the comment of acquireDelegationToken(), it claims that it is trying to find token in cache firstly, but the newly requested token is never put to cache and thus the cache is still empty for the following request; In cases there are many files to do the bulk load, the token request will cause big short to NameNode.   {code:java} public void acquireDelegationToken(final FileSystem fs) throws IOException { if (userProvider.isHadoopSecurityEnabled()) { this.fs = fs; userToken = userProvider.getCurrent().getToken(""HDFS_DELEGATION_TOKEN"", fs.getCanonicalServiceName()); if (userToken == null) { hasForwardedToken = false; try { userToken = fs.getDelegationToken(renewer); } catch (NullPointerException npe) { // we need to handle NullPointerException in case HADOOP-10009 is missing LOG.error(""Failed to get token for "" + renewer); } } else { hasForwardedToken = true; LOG.info(""Use the existing token: "" + userToken); } } }{code}" The way we bootstrap meta table is confusing,13308298,Resolved,Major,Fixed,29/May/20 10:19,30/May/20 09:05,,"I used to thought the work is only done in the InitMetaProcedure but in fact we have several pieces of code related to this which are placed in different classes. In HRegionServer.initializeFileSystem, we will test whether we are HMaster. If so, we will call FSTableDescriptors.tryUpdateMetaTableDescriptor. And in MasterFileSystem.checkRootDir, we will check if meta region is available. If not, we will bootstrap it, and it will also call FSTableDescriptors.tryUpdateMetaTableDescriptor. The problem here is that, HRegionServer.initializeFileSystem is called in the constructor of HRegionServer, which means it will be executed before MasterFileSystem.checkRootDir, as we will only create the MasterFileSystem for active master... Ideally I prefer we move all the bootstrap code into InitMetaProcedure, which will be much cleaner. If this can not be done, at least we could move the code into MasterFileSystem." Update DumpClusterStatusAction to notice changes in region server count,13314389,Resolved,Major,Fixed,30/Jun/20 23:49,06/Aug/20 16:21,,"Sometimes running chaos monkey, I've found that we lose accounting of region servers. I've taken to a manual process of checking the reported list against a known reference. It occurs to me that ChaosMonkey has a known reference, and it can do this accounting for me." Support flush a single column family of region,13306071,Resolved,Major,Fixed,20/May/20 06:34,07/Aug/20 10:36,2.4.0,"It is useful when we set many column families for a table, could avoid generate too many small files.  " Improve/stable read replica,13311215,Open,Major,,12/Jun/20 23:27,,2.3.0,"Tracing some read replica issues recently, this is the umbrella Jira to track this effort. A few observations so far: # balancer balances replica regions too often, need to spend time on it. Replica region does not serve write and rarely serve reads (unless the client specifically selects the replica region). So data locality should be a very minimum factor for replica regions.  # Need to study split/merge for regions with replica, need to make them more robust. With proc-v2, probably it is already robust.     " Removal from streamReaders can be done in finally,13302790,Resolved,Major,Won't Fix,05/May/20 06:00,03/Aug/20 04:43,2.1.6,"As part of the fix for https://issues.apache.org/jira/browse/HBASE-21551 we removed the storeReaders from the set inside the try block. The code there seems to catch IOException. But if you drill down and see how the actual readers are closed - FSDataInputStreamWrapper#close() uses IOUtils.closeQuietly where we swallow the IOException (So ideally IOException will not be thrown). But there are cases we endup getting other type of RuntimeExceptions which may fail the close() and we endup not removing the storeReader from the Set. So it is safe to always remove it in finally. " release scripts should try to use a keyid when refering to GPG keys.,13311772,Resolved,Major,Fixed,16/Jun/20 16:53,02/Aug/20 03:29,,"Right now the template us substituting the release manager's email address in for the variable {{GPG_KEY}}. I think it doesn't hurt to make note of the email address, but what we really want here is the key's fingerprint, or some meaningly identifiable portion of it." [Hadoop3.3] Add Hadoop-3.3.0-SNAPSHOT to hadoopcheck in our yetus personality,13299223,Resolved,Major,Won't Fix,17/Apr/20 20:39,23/Jul/20 19:33,,"Since HBASE-23833 we're paying attention to our builds on Hadoop trunk, currently 3.3.0-SNAPSHOT. Let's add this version to the version lists in hadoopcheck so our CI will let us know when things break, at least compile-time anyway." Upgrade to Apache ZooKeeper 3.5.7,13296842,Resolved,Major,Fixed,07/Apr/20 14:22,29/May/20 20:41,2.2.3,"Apache ZooKeeper 3.5.7 has been released, HDFS and other projects have updated the dependent zookeeper verison. Perhaps Hbase may update as well. Some of the interfaces are changed in this zookeeper version ." Try compact the recovered hfiles firstly after region online,13312969,Open,Major,,23/Jun/20 06:06,,2.3.0,"As discussed in HBASE-23739 and in HBASE-24632, there may have many recovered hfiles. Should find a better way to compact them firstly after region online.   For instance (quoting our [~anoop.hbase]): ""Assume there were some small files because of flush but never got compacted before the RS down happened. We will look for the possible candidate from oldest files and in all chance the very old files would get excluded because of the size math. But It is possible that new flushed files would get selected. And we have the max files to compact config also which is 10 by default. Even these small files count alone might be >10. If there are say 15 WAL files to split, for sure we will have at least 15 small HFiles. My thinking was this. After the region open, we have to make sure these small files are compacted in one go and we should not even consider the max files limit for this compaction. Also to note that this files might not even have the DBE/compression etc being applied. Ya coding wise am not sure how clean it might come.""   And from our [~pankaj2461]   ""...concern is the compaction after region open, which impact MTTR due to heavy IO in large cluster with many outstanding WALs""  " Flush partial stores of region filtered by seqId when archive wal due to too many wals,13305369,Resolved,Major,Fixed,16/May/20 09:44,26/Jun/20 05:04,2.4.0,"When the logRoller archive the oldest wal due to too many wals, if a region should be flushed, we flush all stores of it, but it is not necessary, maybe we can use unflushedSeqId of store to filter them." Make it so can make an hbase1 schema and hbase2 schema equate,13304232,Resolved,Major,Fixed,11/May/20 23:51,12/May/20 19:36,,"Currently, NEW_VERSION_BEHAVIOR displays in hbase2 schemas with default value of 'false'. This default is added whenever we create a new column descriptor. Its not needed. We'll return default if empty or undefined. Meantime, since this is not defined in hbase1, it makes it so we can't make equivalent schemas so not possible to replicate from hbase1 to hbase2." [WAL] Add a parameter to config RingBufferEventHandler's SyncFuture count,13311871,Resolved,Major,Fixed,17/Jun/20 04:51,17/Jul/20 03:10,1.4.13,"The current value of RingBufferEventHandler's handler is the value of {{hbase.regionserver.handler.count}}, which works good in default wal provider --- one WAL per regionserver. When trying to use WAL group provider, either by group or wal per region, the default value is bad. If rs has 100 regions and wal per region strategy is used, then rs will allocate 100 * SyncFuture[$hbase.regionserver.handler.count] array {code} int maxHandlersCount = conf.getInt(HConstants.REGION_SERVER_HANDLER_COUNT, 200); this.ringBufferEventHandler = new RingBufferEventHandler( conf.getInt(""hbase.regionserver.hlog.syncer.count"", 5), maxHandlersCount); ... ---- RingBufferEventHandler(final int syncRunnerCount, final int maxHandlersCount) { this.syncFutures = new SyncFuture[maxHandlersCount]; ... } {code} " Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out,13308204,Resolved,Major,Fixed,29/May/20 00:48,16/Jul/20 11:53,2.2.5, "Relocate test-only REST ""client"" from src/ to test/ and mark Private",13296149,Resolved,Major,Fixed,04/Apr/20 00:43,22/May/20 02:52,,"Relocate test-only REST ""client"" from src/ to test/ and annotate as Private. The classes o.a.h.h.rest.Remote* were developed to facilitate REST unit tests and incorrectly committed to src/ . Although this ""breaks"" compatibility by moving public classes to test jar and marking them private, no attention has been paid to these classes with respect to performance, convenience, or security. Consensus from various discussions over the years is to move them to test/ as was intent of the original committer, but misplaced by the same individual. " Add 2.3.0 to the downloads page,13311565,Resolved,Major,Fixed,15/Jun/20 21:26,14/Jul/20 17:10,,"Once release bits are finalized, add reference to downloads page." Add 2.3 Documentation to the website,13308772,Resolved,Major,Fixed,01/Jun/20 17:45,14/Jul/20 17:00,, Ensure StochasticLoadBalancer can log details of decision to not run balancer,13297061,Resolved,Major,Fixed,08/Apr/20 12:38,09/Apr/20 05:54,,"Ran into a customer case where the StochasticLoadBalancer was consistently deciding not to balance when bringing new region servers on line. Even setting the class to TRACE logging would only log a summary statement like: {code} 2020-04-03 00:29:55,133 TRACE org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer: Skipping load balancing because balanced cluster; total cost is 25.24853189705185, sum multiplier is 602.0 min cost which need balance is 0.05 {code} Without any details about what went into that decision it's really hard to figure out what we need to tune to get the behavior we want." Use a fair ReentrantReadWriteLock for the region close lock,13295591,Resolved,Major,Fixed,01/Apr/20 17:38,08/Apr/20 18:38,,"Consider creating the region's ReentrantReadWriteLock with the fair locking policy. We have had a couple of production incidents where a regionserver stalled in shutdown for a very very long time, leading to RIT (FAILED_CLOSE). The latest example is a 43 minute shutdown, ~40 minutes (2465280 ms) of that time was spent waiting to acquire the write lock on the region in order to finish closing it. {quote} ... Finished memstore flush of ~66.92 MB/70167112, currentsize=0 B/0 for region XXXX. in 927ms, sequenceid=6091133815, compaction requested=false at 1585175635349 (+60 ms) Disabling writes for close at 1585178100629 (+2465280 ms) {quote} This time was spent in between the memstore flush and the task status change ""Disabling writes for close at..."". This is at HRegion.java:1481 in 1.3.6: {code} 1480: // block waiting for the lock for closing 1481: lock.writeLock().lock(); // FindBugs: Complains UL_UNRELEASED_LOCK_EXCEPTION_PATH but seems fine {code} The close lock is operating in unfair mode. The table in question is under constant high query load. When the close request was received, there were active readers. After the close request there were more active readers, near-continuous contention. Although the clients would receive RegionServerStoppingException and other error notifications, because the region could not be reassigned, they kept coming, region (re-)location would find the region still hosted on the stuck server. Finally the closing thread waiting for the write lock became no longer starved (by chance) after 40 minutes. The ReentrantReadWriteLock javadoc is clear about the possibility of starvation when continuously contended: ""_When constructed as non-fair (the default), the order of entry to the read and write lock is unspecified, subject to reentrancy constraints. A nonfair lock that is continuously contended may indefinitely postpone one or more reader or writer threads, but will normally have higher throughput than a fair lock._"" We could try changing the acquisition semantics of this lock to fair. This is a one line change, where we call the RW lock constructor. Then: ""_When constructed as fair, threads contend for entry using an approximately arrival-order policy. When the currently held lock is released, either the longest-waiting single writer thread will be assigned the write lock, or if there is a group of reader threads waiting longer than all waiting writer threads, that group will be assigned the read lock._"" This could be better. The close process will have to wait until all readers and writers already waiting for acquisition either acquire and release or go away but won't be starved by future/incoming requests. There could be a throughput loss in request handling, though, because this is the global reentrant RW lock for the region. " Enable CompactionTool executions on non-HDFS filesystems,13296008,Resolved,Major,Fixed,03/Apr/20 10:47,06/Apr/20 10:31,,"CompactionTool on non-HDFS filesystems does not work because the used filesystems are mixed up. To collect the StoreFiles the {{Filesystem.get(conf)}} method is used instead of relying on the root dir filesystem. With YARN the delegation tokens are not handled correctly with a different filesystem and the mappers only get delegation token for the staging directory's filesystem. Another issue is in MapReduce mode when YARN is used. In this case the TMP directory ({{hbase.tmp.dir}}) is created under {{yarn.nodemanager.local-dirs}} but this directory is created (even on HDFS a regular user can't create this directory) on the Storefile's filesystem where a local filesystem temp directory shouldn't be used. In this ticket I plan to clean up the used filesystems, remove the custom temp directory (use the regions' .tmp directory) and collect delegation tokens for staging dir + store dir paths' FileSystems." Implement proxyuser/doAs mechanism for hbase-http,13300726,Resolved,Major,Fixed,24/Apr/20 06:47,27/Apr/20 19:14,,"The REST and Thrift interfaces for HBase already implement the standard hadoop ProxyUser mechanism for SPNEGO, but it is not implemented in hbase-httpserver. Implement it." "Add an ""ignoreTimestamps"" option (defaulted to false) to HashTable/SyncTable tool",13302339,Resolved,Major,Fixed,01/May/20 18:51,04/May/20 14:16,2.2.5,"Currently, when hashing and comparing values between a source and a target table, HashTable/SyncTable always consider cell timestamp values. However, cell timestamp values are not always relevant for client applications, so these use cases could benefit of a more flexible comparison logic where timestamps could be ignored. For such scenarios, HashTable/SyncTable could have better performance, since cells with only timestamps diverging would not be copied.  Another case that would benefit from this option is when bulk deletes are wrongly applied at target. At the moment, HashTable/SyncTable on it's own is not capable of syncing back the clusters, as the source Puts would have an older TS than the delete markers in the target. That would require target to complete major compaction on the whole table before HashTable/SyncTable could be run." hbase.rs.evictblocksonclose is not honored when removing compacted files and closing the storefiles,13310543,Resolved,Major,Fixed,10/Jun/20 04:36,12/Jun/20 11:12,,"Currently, when removing compacted files and closing the storefiles, RS always does evict block caches for the store files. It should honor hbase.rs.evictblocksonclose: https://github.com/apache/hbase/blob/7b396e9b8ca93361de6a6c4bc8a40442db77c4da/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java#L2744 https://github.com/apache/hbase/blob/7b396e9b8ca93361de6a6c4bc8a40442db77c4da/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java#L625" Hadoop2&Hadoop3 profiles are both active when pre-commit PR builds run,13303948,Resolved,Major,Fixed,10/May/20 17:26,01/Jun/20 11:46,,"We need the magic done in the parent out in our precommit builds too. See how https://github.com/apache/hbase/pull/1664 fails in hbase-rest w/ complaint about jersey; this is a symptom of double hadoop2+hadoop3 profile activation. " Support deleteall with ts but without column in shell mode,13303070,Resolved,Major,Fixed,06/May/20 09:30,07/May/20 17:27,3.0.0-alpha-1,"The position after rowkey is column, so we can't only specify ts now. My proposal is use a empty string to represent no column specified. useage:  deleteall 'test','r1','',1588765900000 deleteall 'test', \{ROWPREFIXFILTER => 'prefix'}, '', 1588765900000" GCMulitpleMergedRegionsProcedure is not idempotent,13302678,Resolved,Major,Fixed,04/May/20 16:36,06/May/20 23:08,2.3.0,"Currently deleteMergeQualifiers() is not idempotent. If two GCMulitpleMergedRegionsProcedures are run for the same merged child region, the second run will delete the row for the merge region from meta table and leave a hole. It needs to make sure it only deletes columns with merge qualifiers. [https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java#L1849]" [flakey test] regionserver.TestRegionMergeTransactionOnCluster,13297464,Resolved,Major,Fixed,09/Apr/20 19:07,10/Apr/20 20:03,2.3.0,"As reported in [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.3/lastSuccessfulBuild/artifact/dashboard.html#job_1,]  testCleanMergeReference fails when waiting for merge table in meta table to be cleaned. Debugged a bit, found that this is case that state is polluted from other testing cases.   the meta table is polluted from the previous region merge test cases (tables are not deleted after the testing case finishes). While compaction still goes on and janitor kicks in, it will clean up the old table state and breaks the loop (cleaned > 0), so leave the state under test never cleaned up.The solution is to delete tables after each test case." "When fixOverlap hits the max region limit, it is possible to include the same region in multiple merge request",13300837,Resolved,Major,Fixed,24/Apr/20 16:50,12/May/20 16:58,2.3.0,"If the same region is included in multiple merge requests, the first merge cleans up the region state, the second merge request will fail with error msg ""No state for region ****"". The algo needs to be improved to make sure the same region is not included in multi merge requests." update copyright notices year to 2020,13306690,Resolved,Major,Fixed,22/May/20 06:59,27/May/20 08:56,, Avoid aggressive MergeRegion and GCMultipleMergedRegionsProcedure ,13304840,Resolved,Major,Fixed,14/May/20 05:27,25/May/20 23:14,,"In [https://github.com/apache/hbase/blob/a40a0322a73add68d9cb0579abacdd6a2e41e8fb/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java#L478,  |https://github.com/apache/hbase/blob/a40a0322a73add68d9cb0579abacdd6a2e41e8fb/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java#L478] prepareMergeRegion, it checks if one of merged parent regions is a merged child region and has not been GCed. If it is ready to GC, it will kick off a GCMultipleMergedRegionsProcedure and also start the MergeRegionProcedure. There is a race condition here. If MergeRegionProcedure finishes first, it will delete meta row for the merged child region. Then GCMultipleMergedRegionsProcedure runs, and because the newly added check, it thinks GC has been done and wont schedule GCRegionProcedure to clean up those merged parent regions. The end result is that these merged parent regions are left as orphans on Filesystem.   [https://github.com/apache/hbase/blob/a40a0322a73add68d9cb0579abacdd6a2e41e8fb/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/GCMultipleMergedRegionsProcedure.java#L105]   The proposed solution is to avoid being so aggressive, if it needs to kick off GCMultipleMergedRegionsProcedure, then abort MergeRegionProcedure and user can try MergeRegionProcedure later. [|https://github.com/apache/hbase/blob/a40a0322a73add68d9cb0579abacdd6a2e41e8fb/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java#L478]    " fix building cpp-example DemoClient,13307358,Resolved,Major,Fixed,26/May/20 07:19,27/May/20 21:26,1.7.0,"Changed boost::shared_ptr to std::shared_ptr for compatibility with apache thrift v0.13. https://github.com/apache/hbase/pull/1775" Deflake TestCompaction#testStopStartCompaction,13308601,Resolved,Major,Fixed,31/May/20 22:45,01/Jun/20 06:56,1.7.0,"Saw this in our internal test runs. {noformat} org.apache.hadoop.hbase.regionserver.TestCompactionWithCoprocessor.testStopStartCompaction Failing for the past 1 build (Since Unstable#10 ) Took 0.72 sec. add description Error Message expected:<1> but was:<0> Stacktrace java.lang.AssertionError: expected:<1> but was:<0> {noformat} The test asserts can be tightened to improve this. Will follow up with a patch shortly. HBASE-23899 added some debug logging to figure out why. " Verify Jira and git agree on issue fixVersions,13297187,Resolved,Major,Fixed,08/Apr/20 18:45,13/Jul/20 18:28,,Compare what's on the branches with fixVersions tagged in Jira. Introduce a split policy similar with SteppingSplitPolicy but count all store size,13310592,Resolved,Major,Won't Do,10/Jun/20 08:19,13/Jul/20 08:52,,"SteppingSplitPolicy decide whether split by max store size, if there are several column families and write evenly, then the region will grows very big.   In this case, count by all store size would be a better choise." Add table level locality in table.jsp,13312116,Resolved,Major,Fixed,18/Jun/20 06:35,11/Jul/20 11:59,,"For now, we only show locality for each region, it should be apply to table as what Base Stats and Compactions does." Show snapshot owner on Master WebUI,13313914,Resolved,Major,Fixed,29/Jun/20 04:19,10/Jul/20 07:13,,"Now Master UI shows lots of snapshot informations, and owner is also useful to find out who create this snapshot." Rewrite TestClusterRestartFailover.test since namespace table is gone on on master,13308858,Resolved,Major,Fixed,02/Jun/20 03:50,10/Jul/20 02:04,,"We still have this {code} // Find server that does not have hbase:namespace on it. This tests holds up SCPs. If it // holds up the server w/ hbase:namespace, the Master initialization will be held up // because this table is not online and test fails. for (JVMClusterUtil.RegionServerThread rst: UTIL.getHBaseCluster().getLiveRegionServerThreads()) { HRegionServer rs = rst.getRegionServer(); if (rs.getRegions(TableName.NAMESPACE_TABLE_NAME).isEmpty()) { SERVER_FOR_TEST = rs.getServerName(); } } {code}" Split TestMetaWithReplicas,13313472,Resolved,Major,Fixed,25/Jun/20 15:46,04/Jul/20 14:49,,"It will stop and then start a mini cluster every time after each test method, so let's just split them into individual test files." [branch-2.2] Fix the maven compilation failure for nightly build,13312397,Resolved,Major,Fixed,19/Jun/20 07:29,06/Jul/20 06:26,,[https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/896/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] Stabilize master startup with meta replicas enabled,13311507,Resolved,Major,Fixed,15/Jun/20 14:55,02/Jul/20 20:45,2.2.5,"This is related to HBASE-21624 . I created a separate ticket because in the original one a ""complete solution for meta replicas"" was requested and this is not one. I'm just trying to make master startup more stable by making assigning meta replicas asynchronous and preventing a potential assignment failure from crashing master. The idea is that starting master with less or even no meta replicas assigned is preferable to not having a running master." Priority compaction for recently split daughter regions,13307271,Resolved,Major,Fixed,25/May/20 17:12,27/May/20 17:29,,"We observe that under hotspotting conditions that splitting will proceed very slowly and the ""_Cannot split region due to reference files being there_"" log line will be logged excessively. (branch-1 based production.) This is because after a region is split it must be compacted before it can be split again. Reference files must be replaced by real HFiles, normal housekeeping performed during compaction. However if the regionserver is under excessive load, its compaction queues may become deep. The daughters of a recently split hotspotting region may themselves continue to hotspot and will rapidly need to split again. If the scheduled compaction work to remove/replace reference files is queued hundreds or thousands of compaction queue elements behind current, the recently split daughter regions will not be able to split again for a long time and may grow very large, producing additional complications (very large regions, very deep replication queues). To help avoid this condition we should prioritize the compaction of recently split daughter regions. Compaction requests include a {{priority}} field and CompactionRequest implements a comparator that sorts by this field. We already detect when a compaction request involves a region that has reference files, to ensure that it gets selected to be eligible for compaction, but we do not seem to prioritize the requests for post-split housekeeping. Split work should be placed at the top of the queue. Ensure that this is happening." RegionMover should exclude draining/decommissioning nodes from target RSs,13295706,Resolved,Major,Fixed,02/Apr/20 06:38,22/Jun/20 17:31,,"When using RegionMover tool to unload the regions from a given RS, it decides the list of destination RSs by {code} List regionServers = new ArrayList<>(); regionServers.addAll(admin.getRegionServers()); // Remove the host Region server from target Region Servers list ServerName server = stripServer(regionServers, hostname, port); ..... // Remove RS present in the exclude file stripExcludes(regionServers); stripMaster(regionServers); {code} Ya it is removing the RSs mentioned in the exclude file. Better when the RegionMover user is NOT mentioning any exclude list, we can exclude the draining/decommissioning RSs Admin#listDecommissionedRegionServers()" Procedure V2 - Distributed WAL Splitting => LOGGING,13311795,Resolved,Major,Fixed,16/Jun/20 18:37,18/Jun/20 15:54,,"The procedure-based distributed WAL splitter uses the old SplitLogManager class. It registers it as a chore even though the chore #run immediately skips out. Meantime we log SLM ran in #0ms frequently. For example... {code} ... 2020-06-17 17:48:30,567 DEBUG [localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. 2020-06-17 17:48:31,567 DEBUG [localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. 2020-06-17 17:48:32,570 DEBUG [localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. 2020-06-17 17:48:33,567 DEBUG [localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. 2020-06-17 17:48:34,569 DEBUG [localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. 2020-06-17 17:48:35,569 DEBUG [localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. 2020-06-17 17:48:36,568 DEBUG [localhost:16000.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. ... {code} The new pv2 WAL splitter introduces new procedures that log their class name only w/o detail on log that is being split or the server that is running the split." Set the log level for ScheduledChore to INFO in HBTU,13313713,Resolved,Major,Fixed,27/Jun/20 02:29,28/Jun/20 15:37,,"Now we changed the thead waken interval to 100ms in tests, which causes the test log beng flooded with {noformat} 2020-06-27 10:28:00,680 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): MemstoreFlusherChore execution time: 0 ms. 2020-06-27 10:28:00,680 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. 2020-06-27 10:28:00,684 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): MemstoreFlusherChore execution time: 0 ms. 2020-06-27 10:28:00,684 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. 2020-06-27 10:28:00,696 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. 2020-06-27 10:28:00,696 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): MemstoreFlusherChore execution time: 0 ms. 2020-06-27 10:28:00,782 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. 2020-06-27 10:28:00,782 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): MemstoreFlusherChore execution time: 0 ms. 2020-06-27 10:28:00,786 DEBUG [regionserver/zhangduo-ubuntu:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. {noformat} We could set the log level to INFO when starting a mini cluster in HBTU." Rewrite MetaTableAccessor.multiMutate to remove the deprecated coprocessorService call,13313737,Resolved,Major,Fixed,27/Jun/20 09:45,01/Jul/20 00:14,, Remove the legacy 'forceSplit' related code at region server side,13313740,Resolved,Major,Fixed,27/Jun/20 09:54,29/Jun/20 21:22,,I believe it is useless after we move split operation to master. Let's purge the uesless code. TestHeapSize.testSizes failure,13314384,Resolved,Major,Fixed,30/Jun/20 22:17,30/Jun/20 23:08,3.0.0-alpha-1,"{code:java} INFO] [INFO] --- maven-surefire-plugin:3.0.0-M4:test (default-test) @ hbase-server --- [INFO] [INFO] ------------------------------------------------------- [INFO]  T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.io.TestHeapSize [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.884 s <<< FAILURE! - in org.apache.hadoop.hbase.io.TestHeapSize [ERROR] org.apache.hadoop.hbase.io.TestHeapSize.testSizes  Time elapsed: 0.308 s  <<< FAILURE! java.lang.AssertionError: expected:<368> but was:<360> at org.apache.hadoop.hbase.io.TestHeapSize.testSizes(TestHeapSize.java:493) [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR]   TestHeapSize.testSizes:493 expected:<368> but was:<360> [INFO] [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0 [INFO] {code}" Job failed because of TableInputFormatBase HRegionLocation.getHostname NullPointerException,13314358,Open,Major,,30/Jun/20 18:28,,2.3.0,"I've not seen this before. Failed the job. {code} 00:30:11 Caused by: java.lang.NullPointerException 00:30:11 at org.apache.hadoop.hbase.HRegionLocation.getHostname(HRegionLocation.java:107) 00:30:11 at org.apache.hadoop.hbase.mapreduce.TableInputFormatBase.oneInputSplitPerRegion(TableInputFormatBase.java:337) 00:30:11 at org.apache.hadoop.hbase.mapreduce.TableInputFormatBase.getSplits(TableInputFormatBase.java:257) 00:30:11 at org.apache.hadoop.hbase.mapreduce.TableInputFormat.getSplits(TableInputFormat.java:254) 00:30:11 at org.apache.spark.rdd.NewHadoopRDD.getPartitions(NewHadoopRDD.scala:130) 00:30:11 at org.apache.spark.rdd.RDD.$anonfun$partitions$2(RDD.scala:253) 00:30:11 at scala.Option.getOrElse(Option.scala:189) 00:30:11 at org.apache.spark.rdd.RDD.partitions(RDD.scala:251) 00:30:11 at org.apache.spark.rdd.MapPartitionsRDD.getPartitions(MapPartitionsRDD.scala:49) 00:30:11 at org.apache.spark.rdd.RDD.$anonfun$partitions$2(RDD.scala:253) 00:30:11 at scala.Option.getOrElse(Option.scala:189) 00:30:11 at org.apache.spark.rdd.RDD.partitions(RDD.scala:251) 00:30:11 at org.apache.spark.rdd.MapPartitionsRDD.getPartitions(MapPartitionsRDD.scala:49) 00:30:11 at org.apache.spark.rdd.RDD.$anonfun$partitions$2(RDD.scala:253) 00:30:11 at scala.Option.getOrElse(Option.scala:189) 00:30:11 at org.apache.spark.rdd.RDD.partitions(RDD.scala:251) 00:30:11 at org.apache.spark.rdd.MapPartitionsRDD.getPartitions(MapPartitionsRDD.scala:49) 00:30:11 at org.apache.spark.rdd.RDD.$anonfun$partitions$2(RDD.scala:253) 00:30:11 at scala.Option.getOrElse(Option.scala:189) 00:30:11 at org.apache.spark.rdd.RDD.partitions(RDD.scala:251) 00:30:11 at org.apache.spark.rdd.MapPartitionsRDD.getPartitions(MapPartitionsRDD.scala:49) 00:30:11 at org.apache.spark.rdd.RDD.$anonfun$partitions$2(RDD.scala:253) 00:30:11 at scala.Option.getOrElse(Option.scala:189) 00:30:11 at org.apache.spark.rdd.RDD.partitions(RDD.scala:251) 00:30:11 at org.apache.spark.sql.execution.datasources.FileFormatWriter$.write(FileFormatWriter.scala:159) 00:30:11 ... 31 more 00:30:11 00:30:11 ApplicationMaster host: ps1331.example.org 00:30:11 ApplicationMaster RPC port: 27682 00:30:11 queue: root.adhoc 00:30:11 start time: 1593502056697 00:30:11 final status: FAILED 00:30:11 tracking URL: http://web2.example.org:8088/proxy/application_1593477746222_0014/ 00:30:11 user: nobody {code}" Promote TestLogRollingNoCluster to LargeTests,13313441,Resolved,Major,Invalid,25/Jun/20 12:49,30/Jun/20 13:38,,"It spends 7 minutes to finish on my local machine, so I think it should be a LargeTests instead of MediumTests." Include target hostname/ip/port in `ipc.ServerNotRunningYetException`,13310240,Open,Major,,08/Jun/20 22:58,,2.3.0,"We get almost 100 lines of exception backtrace along with this exception, but the identity of the server with whom the client is trying to communication is not included. For example, {noformat} 2020-06-06 00:35:37,123 WARN [ChaosMonkey] client.ConnectionImplementation: Checking master connection org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet at org.apache.hadoop.hbase.master.HMaster.checkServiceStarted(HMaster.java:2901) at org.apache.hadoop.hbase.master.MasterRpcServices.isMasterRunning(MasterRpcServices.java:1178) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) ... {noformat}" release script utils should set local user when GPG_KEY is defined.,13313823,Resolved,Major,Fixed,28/Jun/20 06:38,30/Jun/20 04:09,,right now the release scripts fail to set the gpg local user to the specified gpg key during the actual build steps. Update docs from master,13297184,Resolved,Major,Fixed,08/Apr/20 18:41,29/Jun/20 15:36,2.3.0,"Take a pass updating the docs. Have a look at what's on branch-2.2 and add whatever updates we need from master. Consider refreshing branch-2 as well, since it's been a while." Address asciidoc warnings about images,13314107,Open,Major,,29/Jun/20 17:20,,,"Noticed this while tailing the log for 2.3.0rc1. I assume this is related to generating the PDF version of the book. Should verify these images do indeed make it into the pdf. {noformat} 17:15:36 [INFO] asciidoctor: WARN: image to embed not found or not readable: /home/vagrant/hbase-rm/output/hbase/src/main/asciidoc/images/WAL_splitting.png 17:16:37 [INFO] asciidoctor: WARN: image to embed not found or not readable: /home/vagrant/hbase-rm/output/hbase/src/main/asciidoc/images/master-snapshot.png 17:16:37 [INFO] asciidoctor: WARN: image to embed not found or not readable: /home/vagrant/hbase-rm/output/hbase/src/main/asciidoc/images/1-snapshot.png 17:16:37 [INFO] asciidoctor: WARN: image to embed not found or not readable: /home/vagrant/hbase-rm/output/hbase/src/main/asciidoc/images/2-snapshots.png 17:16:37 [INFO] asciidoctor: WARN: image to embed not found or not readable: /home/vagrant/hbase-rm/output/hbase/src/main/asciidoc/images/empty-snapshots.png 17:17:03 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/top_screen.gif to PNG. 17:17:03 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/scrolling_metric_records.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/changing_mode.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/changing_refresh_delay.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/changing_displayed_fields.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/changing_sort_field.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/changing_order_of_fields.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/adding_filters.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/showing_and_clearing_filters.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/driling_down.gif to PNG. 17:17:04 [INFO] asciidoctor: WARN: GIF image format not supported. Install the prawn-gmagick gem or convert https://hbase.apache.org/hbtop-images/help_screen.gif to PNG. {noformat}" Remove BoundedRecoveredHFilesOutputSink dependency on a TableDescriptor,13312926,Resolved,Major,Fixed,23/Jun/20 00:04,25/Jun/20 19:01,,"BoundedRecoveredHFilesOutputSink wants to read TableDescriptor so it writes the particular hfile format specified by a table's schema. Getting the table schema can be tough at various points of operation especially around startup. HBASE-23739 tried to read from the fs if unable to read TableDescriptor from Master. This approach works generally but fails in standalone mode as in standalone mode we will have given-up our start up attempt BEFORE the request to Master for TableDescriptor times out (the read from fs is never attempted). The suggested patch here does away w/ reading TableDescriptor and just has BoundedRecoveredHFilesOutputSink write generic hfiles." TestSimpleRegionNormalizerOnCluster is broken,13313756,Resolved,Major,Duplicate,27/Jun/20 13:30,28/Jun/20 15:39,,"It failed for all the recent pre commit build, and has started to show on the flaky page. Spent some time when merging HBASE-24389, copy the comments from PR here It seems the problem is that while issuing a split, the normalizer also issues a merge, which lead to an unchanged region count and make the tests timeout. Not sure what is the root cause yet. HBASE-24588 maybe?" Normalizer plan execution is not consistent between plan types,13312320,Resolved,Major,Fixed,18/Jun/20 23:50,27/Jun/20 19:46,2.3.0,"I left a comment on a merged [commit|https://github.com/apache/hbase/commit/5d0e0fc5fd09bddb2d766d1e24e28e472961f454#r39987289] where a little discussion has blossomed. Right now the normalizer produces two types of plans: ""split"" or ""merge"". The master receives the list of plans and executes them in a simple loop. The way it does the actual execution is delegated off to the plan implementation. The bug I noticed is that the two implementations are subtly different. Both use async APIs to submit procedures, but ""split"" blocks on completion while ""merge"" does not. Furthermore, because ""split"" blocks, it's able to capture any exception that's thrown, while ""merge"" cannot. These implementations should be made consistent. My thinking at the moment is this {{execute}} method should instead be named {{submit}}, creating and returning the {{Future}} that represents whatever work it submitted, and the calling context should handle the resolution of those futures in a single place." Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-1,13312566,Resolved,Major,Fixed,19/Jun/20 23:34,27/Jun/20 19:59,, Support bulkLoadHFile by family,13299866,Resolved,Major,Fixed,21/Apr/20 04:29,26/Jun/20 16:23,2.2.4,Support bulkLoadHFile by family to avoid long time waiting of bulkLoadHFile because of compacting at server side Edit doc on (offheap) memory management,13313548,Resolved,Major,Fixed,26/Jun/20 06:11,26/Jun/20 16:11,,Gave it a read over to try and figure current state of memory management in hbase-2.3.0. Updated it to reflect more of what the current state is. Include dump files in the jenkins archive,13313672,Open,Major,,26/Jun/20 19:09,,,"Tracking down jenkins test failures in the face of {{org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?}} is difficult right now. Let's include the ""dump"" files in our archives so that there's something to look at, maybe find a usable stack trace. The failures I want to track look like {noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test (default-test) on project hbase-common: There are test failures. [ERROR] [ERROR] Please refer to /home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.3@2/component/hbase-common/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.3@2/component/hbase-common && /usr/lib/jvm/jdk8u232-b09/jre/bin/java -enableassertions -Dhbase.build.id=2020-06-24T15:53:27Z -Xmx2200m -Djava.security.egd=file:/dev/./urandom -Djava.net.preferIPv4Stack=true -Djava.awt.headless=true -Djdk.net.URLClassPath.disableClassPathURLCheck=true -Dorg.apache.hbase.thirdparty.io.netty.leakDetection.level=advanced -Dio.netty.eventLoopThreads=3 -jar /home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.3@2/component/hbase-common/target/surefire/surefirebooter9093790277421313959.jar /home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.3@2/component/hbase-common/target/surefire 2020-06-24T15-53-31_857-jvmRun1 surefire8040542579565444758tmp surefire_783341445535876751188tmp [ERROR] Process Exit Code: 0 {noformat}" Add linter checks for patches,13313651,Open,Major,,26/Jun/20 16:59,,,"I've worked with clang-tidy before and I think it works well. There is also a [helper script|https://clang.llvm.org/extra/doxygen/clang-tidy-diff_8py_source.html] that runs clang-tidy on a patch rather than the entire source tree. - pull in clang as a dependency - Define .clang-format - Run clang-tidy-diff on each checkin There are also other tools like cpplint from Google. I don't have any preference, so either works for me." "Loosen Dockerfile pinned package versions of the ""debian-revision""",13313335,Resolved,Major,Fixed,24/Jun/20 22:05,25/Jun/20 14:27,3.0.0-alpha-1,"Portions of PR jobs have started failing. From the log, our versions of curl is no longer available in ubuntu package servers. {noformat} [2020-06-24T21:41:59.524Z] ============================================================================ [2020-06-24T21:41:59.524Z] ============================================================================ [2020-06-24T21:41:59.524Z] Docker Image Creation [2020-06-24T21:41:59.524Z] ============================================================================ [2020-06-24T21:41:59.524Z] ============================================================================ [2020-06-24T21:41:59.524Z] [2020-06-24T21:41:59.524Z] [2020-06-24T21:41:59.524Z] Sending build context to Docker daemon 18.99kB [2020-06-24T21:41:59.524Z] Step 1/60 : FROM ubuntu:18.04 AS BASE_IMAGE [2020-06-24T21:42:00.233Z] 18.04: Pulling from library/ubuntu [2020-06-24T21:42:00.943Z] Digest: sha256:86510528ab9cd7b64209cbbe6946e094a6d10c6db21def64a93ebdd20011de1d [2020-06-24T21:42:00.943Z] Status: Downloaded newer image for ubuntu:18.04 [2020-06-24T21:42:00.943Z] ---> 8e4ce0a6ce69 [2020-06-24T21:42:00.943Z] Step 2/60 : SHELL [""/bin/bash"", ""-o"", ""pipefail"", ""-c""] [2020-06-24T21:42:00.943Z] ---> Using cache [2020-06-24T21:42:00.943Z] ---> 9170e78be248 [2020-06-24T21:42:00.943Z] Step 3/60 : RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y ca-certificates=20180409 curl=7.58.0-2ubuntu3.8 locales=2.27-3ubuntu1 bash=4.4.18-2ubuntu1.2 build-essential=12.4ubuntu1 diffutils=1:3.6-1 git=1:2.17.1-1ubuntu0.7 rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1 wget=1.19.4-1ubuntu2.2 bats=0.4.0-1.1 libperl-critic-perl=1.130-1 python3=3.6.7-1~18.04 python3-pip=9.0.1-2.3~ubuntu1.18.04.1 python3-setuptools=39.0.1-2 ruby=1:2.5.1 ruby-dev=1:2.5.1 shellcheck=0.4.6-1 && apt-get clean && rm -rf /var/lib/apt/lists/* [2020-06-24T21:42:02.413Z] ---> Running in 87d1f25abbc4 [2020-06-24T21:42:11.760Z] E: Version '7.58.0-2ubuntu3.8' for 'curl' was not found [2020-06-24T21:42:12.471Z] The command '/bin/bash -o pipefail -c DEBIAN_FRONTEND=noninteractive apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y ca-certificates=20180409 curl=7.58.0-2ubuntu3.8 locales=2.27-3ubuntu1 bash=4.4.18-2ubuntu1.2 build-essential=12.4ubuntu1 diffutils=1:3.6-1 git=1:2.17.1-1ubuntu0.7 rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1 wget=1.19.4-1ubuntu2.2 bats=0.4.0-1.1 libperl-critic-perl=1.130-1 python3=3.6.7-1~18.04 python3-pip=9.0.1-2.3~ubuntu1.18.04.1 python3-setuptools=39.0.1-2 ruby=1:2.5.1 ruby-dev=1:2.5.1 shellcheck=0.4.6-1 && apt-get clean && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100 [2020-06-24T21:42:12.472Z] ERROR: Docker failed to build yetus/hbase:023c6fe56b.{noformat}" [HBCK2] Remove reference to hase I.A. private class CommonFsUtils from FsRegionsMetaRecoverer,13313305,Resolved,Major,Fixed,24/Jun/20 18:14,26/Jun/20 12:11,hbase-operator-tools-1.0.0,"FsRegionsMetaRecoverer used to reference I.A. private targeted interface FSUtils, which changed on hbase 2.3, causing hbck2 fail to compile. HBASE-24482 fixed it by pointing to CommonFSUtils interface, where the methods it was relying upon was actually defined. Since this is also a IA private interface, there's no compatibility guarantees. This PR removes reference to CommonFSUtils on FsRegionsMetaRecoverer. Other classes in hbck2 still require similar work." Empty RegionAction added to MultiRequest in case of RowMutations/CheckAndMutate batch,13312611,Resolved,Major,Fixed,20/Jun/20 12:18,25/Jun/20 01:32,,"When a client sends RowMutations/CheckAndMutate batch requests, no Action objects are added to the *builder* (RegionAction.Builder), so empty RegionAction is added to MultiRequest at the following line: https://github.com/apache/hbase/blob/3c319811799cb4c1f51fb5b43dd4743acd28052c/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java#L593 We need to check if the *builder* has any Action objects or not here. " testReplicationStatusSink last applied op ts comparison failure,13312425,Resolved,Major,Fixed,19/Jun/20 09:36,21/Jun/20 10:57,,"The failure to compare timestamp of last applied op with RS start is not a permanent failure, nor does it seem flaky but while running all tests as part of 2.3 RC0 validation, I did encounter the failure:   [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 29.212 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.TestReplicationStatus[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 29.212 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.TestReplicationStatus[ERROR] org.apache.hadoop.hbase.replication.TestReplicationStatus.testReplicationStatusSink  Time elapsed: 1.016 s  <<< FAILURE!java.lang.AssertionError: expected:<1592477704810> but was:<1592477719964> at org.apache.hadoop.hbase.replication.TestReplicationStatus.testReplicationStatusSink(TestReplicationStatus.java:134)   It seems we should allocate separate resources to testReplicationStatusSink: separate class, shutdown peer cluster (if running already), bring it up and check timestamp of lastAppliedOp, then proceed with remaining test i.e timestampsOfLastAppliedOp > timestampStarted within specific period of time soon after inserting some records." Add hadoop 3.2.x support,13299551,Resolved,Major,Fixed,20/Apr/20 01:42,23/Jun/20 14:36,, Backport HBASE-21204 (NPE when scan raw DELETE_FAMILY_VERSION and codec is not set) to branch-1,13312935,Resolved,Major,Fixed,23/Jun/20 01:47,24/Jun/20 17:24,1.6.0, Add hadoop 3.2.x in our support matrix,13300141,Resolved,Major,Fixed,22/Apr/20 03:15,23/Jun/20 14:33,, Create release should url-encode all characters when building git uri,13311584,Resolved,Major,Fixed,15/Jun/20 23:59,22/Jun/20 22:22,,"The release tool doesn't url encode all characters provided for {{ASF_USERNAME, ASF_PASSWORD}}." Remove the stable-1 notice on our download page,13312667,Resolved,Major,Fixed,21/Jun/20 09:24,22/Jun/20 14:56,,We have already removed it from our dist release directory. RollingBatchRestartRsAction loses track of dead servers,13304473,Resolved,Major,Fixed,12/May/20 23:37,18/May/20 20:01,2.3.0,"{{RollingBatchRestartRsAction}} doesn't handle failure cases when tracking its list of dead servers. The original author believed that a failure to restart would result in a retry. However, by removing the dead server from the failed list prematurely, that state is lost, and retry of that server never occurs. Because this action doesn't ever look back to the current state of the cluster, relying only on its local state for the current action invocation, it never realizes the abandoned server is still dead. Instead, be more careful to only remove the dead server from the list when the {{startRs}} invocation claims to have been successful." Enable injecting build start time value as part of build,13312931,Open,Major,,23/Jun/20 01:00,,2.3.0,"The HBase build's creation time is presented in the HBase UI, and made available through Java, via the {{org.apache.hadoop.hbase.Version}} class's {{date}} value, which is generated at build time by {{hbase-common/src/saveVersion.sh}}. The script just invokes the shell command {{date}} and captures its result as a string. The problem is, this occurs every time hbase-common is built. And, for good and sufficient reason, when making a release via dev-support/create-release, the task for building and deploying hbase jars as maven libraries and the task for building binary release artifacts as tarballs, EACH do a {{clean}} build. Thus, the build time found in the libs is different from the build time found in the release tarballs. There is value in keeping the two tasks independent, and able to run fully each by themselves. And there is value in doing a {{clean}} at the start of such processes, to make sure you're releasing binaries that exactly match the source code. So to keep these benefits, but enable the start time to be determined once and used for a couple builds in a row in a given environment, I propose to allow injecting the desired value. Specifically, I want to change saveVersion.sh to look for an existing value of env var HBASE_BUILD_TIME, and if it exists use it instead of calling {{date}}. One would of course set it as part of the build process (in create-release) and clear this value by unsetting the environment variable when done with the build." [flakey test] TestExportSnapshot family of tests failing due to timeout in AbstractDelegationTokenSecretManager$ExpiredTokenRemover,13309002,Resolved,Major,Fixed,02/Jun/20 17:17,08/Jun/20 21:21,2.3.0,"I've observed another occurrence of this test timing out, over on https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1786/3/ The failure message is cryptic, but I think i found the issue. This isn't the {{HBaseClassTestRule}} invoking the timeout, it's something in the test, I think in the mini-cluster. There appears to be a timeout set in some kind of secret manager, which is too aggressive for this mini-cluster test. The last component of the mini-cluster, MapReduce, is finally available at T+273501ms -- ~4.5 minutes after process launch. This is how I interpret the log line {noformat} 2020-06-02 03:20:49,252 INFO [Thread-223] server.Server(419): Started @273501ms {noformat} a scant 20ms later we get {noformat} 2020-06-02 03:20:50,274 ERROR [Thread[Thread-224,5,FailOnTimeoutGroup]] delegation.AbstractDelegationTokenSecretManager$ExpiredTokenRemover(700): ExpiredTokenRemover received java.lang.InterruptedException: sleep interrupted 2020-06-02 03:20:50,351 INFO [Time-limited test] hbase.HBaseTestingUtility(1272): Shutting down minicluster {noformat} These thread group names have no meaning to me." Bring back old constructor of SnapshotDescription,13312710,Resolved,Major,Fixed,21/Jun/20 18:25,22/Jun/20 10:12,,"As part of HBASE-22648 (Snapshot TTL), one of SnapshotDescription constructor was modified with an additional argument and hence, this is raising source compatibility concerns for minor releases. We need to bring back old constructor, mark it deprecated and internally point to new constructor with null/empty snapshotProps." o.a.h.h.tool.LoadIncrementalHFiles deprecation comment does not span an entire release,13312864,Open,Major,,22/Jun/20 16:05,,2.2.0,"While evaluating interface compatibilities for 2.3.0RC0, I noticed the deprecation comment for {{o.a.h.h.tool.LoadIncrementalHFiles}} says {noformat} * @deprecated since 2.2.0, will be removed in 3.0.0. Use {@link BulkLoadHFiles} instead. {noformat} This is contrary to an explicit example in our [book|https://hbase.apache.org/book.html#hbase.versioning], which states: {quote} An API needs to be deprecated for a whole major version before we will change/remove it. An example: An API was deprecated in 2.0.1 and will be marked for deletion in 4.0.0. On the other hand, an API deprecated in 2.0.0 can be removed in 3.0.0. {quote} Maybe there are other comments like this, which need addressed. We should grep the codebase and make appropriate adjustments." Doesn't work SplitPolicy attributs for table,13312854,Open,Major,,22/Jun/20 15:08,,1.4.8,"Doesn't work SplitPolicy settings at the table level. Regions are splits to very low size. Table describe:    {code:java} test_split, {TABLE_ATTRIBUTES => {MAX_FILESIZE => '2147483648', METADATA => {'SPLIT_POLICY' => 'org.apache.hadoop.hbase.regionserver.ConstantSizeRegionSplitPolicy'}} COLUMN FAMILIES DESCRIPTION {NAME => 'data', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'} {NAME => 'number', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'} {NAME => 'uuid', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', COMPRESSION => 'NONE', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}{code}   Global settings that affect split: * Maximum Region File Size - 10GB * Memstore Flush Size - 128MB * hbase.regionserver.region.split.policy - org.apache.hadoop.hbase.regionserver.ConstantSizeRegionSplitPolicy  As a result, regions are splits to  400-600MB, but we expecting should region size 2GB.  !image-2020-06-22-18-04-27-155.png! Why it happens? This is a bug?  " get_table_rsgroup ignored the existence of rsgroup config for namespace,13312337,Resolved,Major,Fixed,19/Jun/20 02:14,21/Jun/20 09:55,3.0.0-alpha-1,"{code:java} public GetRSGroupInfoOfTableResponse getRSGroupInfoOfTable(RpcController controller, GetRSGroupInfoOfTableRequest request) throws ServiceException { TableName tableName = ProtobufUtil.toTableName(request.getTableName()); ... try { ... GetRSGroupInfoOfTableResponse resp; TableDescriptor td = master.getTableDescriptors().get(tableName); if (td == null) { resp = GetRSGroupInfoOfTableResponse.getDefaultInstance(); } else { RSGroupInfo rsGroupInfo = null; if (td.getRegionServerGroup().isPresent()) { rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(td.getRegionServerGroup().get()); } if (rsGroupInfo == null) { rsGroupInfo = master.getRSGroupInfoManager().getRSGroup(RSGroupInfo.DEFAULT_GROUP); } resp = GetRSGroupInfoOfTableResponse.newBuilder() .setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(rsGroupInfo)).build(); } ... return resp; } catch (IOException e) { throw new ServiceException(e); } } {code} In method MasterRpcServices#getRSGroupInfoOfTable, ignored namespace hbase.rsgroup.name config.    It should be replaced by RSGroupUtil#getRSGroupInfo.   " TestSecureExport is failing ,13312693,Resolved,Major,Duplicate,21/Jun/20 15:23,22/Jun/20 01:50,,"Error Message Expected exception was not thrown for user 'rouser' Stacktrace java.lang.AssertionError: Expected exception was not thrown for user 'rouser' at org.apache.hadoop.hbase.coprocessor.TestSecureExport.testAccessCase(TestSecureExport.java:319)" Port HBASE-24380 (Improve WAL splitting log lines to enable sessionization) to branch-2.2,13312567,Resolved,Major,Fixed,19/Jun/20 23:36,21/Jun/20 10:39,, [brnach-2.2] Upgrade junit to 4.13,13312394,Resolved,Major,Fixed,19/Jun/20 07:25,21/Jun/20 01:11,2.2.5, The current implementation of assignMetaReplicas() may assign replica meta regions to the same server hosting primary meta region.,13312061,Open,Major,,17/Jun/20 21:29,,2.3.0,"We need to take the approach similar to SplitTableRegionProcedure, which uses round robin algo to assign replica regions and excludes the primary server.   {code:java} return AssignmentManagerUtil.createAssignProceduresForOpeningNewRegions(env, hris, getRegionReplication(env), getParentRegionServerName(env));{code}" waitForNamespaceOnline() should return false if any region is offline,13310142,Resolved,Major,Fixed,08/Jun/20 13:46,17/Jun/20 14:41,,"HMaster waits for namespace regions to come online only for rolling upgrade scenario (from 1.x to 2.x), however, waitForNamespaceOnline() does not return false for any offline region. We should fix this." Make RS abort call idempotent,13311551,Resolved,Major,Fixed,15/Jun/20 19:20,16/Jun/20 16:17,1.7.0,"We noticed this in our deployment based on branch-1, but it affects other branches too. 1. abort() is not idempotent. There can be multiple aborts that can un-necessarily complicate the state machine. Following is the timeline of actions. - HMaster detected that the RS lost its ZK session and started the SCP. This was caused by ZK flakiness {noformat} 2020-06-11 01:08:39,110 DEBUG [ProcedureExecutor-34] master.DeadServer - Started processing foo,60020,1591683150711; numProcessing=2 2020-06-11 01:08:39,110 INFO [ProcedureExecutor-34] procedure.ServerCrashProcedure - Start processing crashed foo,60020,1591683150711 {noformat} - RS wakes up and attempts to report to master and receives a YouAreDead... This triggers an abort {noformat} Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.YouAreDeadException): org.apache.hadoop.hbase.YouAreDeadException: Server REPORT rejected; currently processing foo,60020,1591683150711 as dead server at org.apache.hadoop.hbase.master.ServerManager.checkIsDead(ServerManager.java:438) at org.apache.hadoop.hbase.master.ServerManager.regionServerReport(ServerManager.java:343) at org.apache.hadoop.hbase.master.MasterRpcServices.regionServerReport(MasterRpcServices.java:359) at org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:8617) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2421) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:390) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:94) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:413) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:409) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:103) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:118) at org.apache.hadoop.hbase.ipc.BlockingRpcConnection.readResponse(BlockingRpcConnection.java:600) at org.apache.hadoop.hbase.ipc.BlockingRpcConnection.run(BlockingRpcConnection.java:334) ... 1 more {noformat} - After a few seconds, RS also realizes that it lost the ZK session and initiates a second abort {noformat} 2020-06-11 01:08:50,321 FATAL [main-EventThread] regionserver.HRegionServer - ABORTING region server foo,60020,1591683150711: regionserver:60020-0x1725cd18ff3c55f, quorum=foo:2181,bar:2181,baz:2181 baseZNode=/hbase regionserver:60020-0x1725cd18ff3c55f received expired from ZooKeeper, aborting org.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode = Session expired at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.connectionEvent(ZooKeeperWatcher.java:697) at org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:629) at org.apache.hadoop.hbase.zookeeper.PendingWatcher.process(PendingWatcher.java:40) at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:544) at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:519) {noformat} Overall, there were two sequences of aborts running at the same time. This can be avoided by making abort idempotent. -2. Abort timeout task doesn't init as expected.- (edited, see comments)" Bump version on branch-2.3 to 2.3.1-SNAPSHOT,13311564,Resolved,Major,Invalid,15/Jun/20 21:26,17/Jun/20 21:18,,Upgrade pom version after successful 2.3.0 release. "[hbase-operator-tools] build of hbck2 fails with HBase branch-2.3, due to missing dependencies",13308636,Resolved,Major,Fixed,01/Jun/20 05:01,17/Jun/20 17:00,hbase-operator-tools-1.1.0,"If we do a local build of the current HBase branch-2.3 as version 2.3.0-SNAPSHOT, and 'mvn install' it in the local maven repository,  then attempt to build hbase-operator-tools master branch, with -Dhbase.version=2.3.0-SNAPSHOT,  the HBCK2 class file HBCKMetaTableAccessor.java (line 25) fails to compile with error: ""package edu.umd.cs.findbugs.annotations does not exist"", followed by multiple instances of missing ""symbol: class Nullable"".  (A longer log extract is attached.) It would appear the default HBase version 2.1.6 made this dependency package available in some manner, but the newer HBase does not. *Later Edit:* After addressing this missing dependency (see comment of 5 June below), it unmasked a bunch more, in the hbck1 code path.  Please see second attachment. If the @Nullable annotation is still needed, it may be sufficient to simply add it to the hbase-operator-tools pom.xml file, so maven will load it.  However, it is actually deprecated in the current documentation for edu.umd.cs.findbugs.annotations. Various commentary online suggest that we should be using the similar jsr305.jar (*{{javax.annotation)}}* instead; see eg * [https://stackoverflow.com/questions/4963300/which-notnull-java-annotation-should-i-use]  Does anyone know if that was HBase's approach?" Java client with IBM JDK does not work if HBase is configured with Kerberos,13300342,Resolved,Major,Incomplete,22/Apr/20 19:13,17/Jun/20 14:41,2.1.0,"When a java HBase client is run with IBM JDK connecting to a HBase cluster configured with Kerberos Authentication, the client fails to connect to HBase. The client is using {{UGI.loginUserFromKeytab(principal, keytab) }} to get a Kerberos ticket and then it is creating create connection, table, scanner and iterate. Code works fine with Oracle/Open JDK. It fails when run with IBM JDK. Following exception is found in logs with DEBUG level logging: {code:java} DEBUG client.RpcRetryingCallerImpl: Call exception, tries=6, retries=11, started=4700 ms ago, cancelled=false, msg=Call to nightly6x-1.nightly6x.root.hwx.site/172.27.21.201:22101 failed on local exception: javax.security.sasl.SaslException: Failure to initialize security context [Caused by org.ietf.jgss.GSSException, major code: 13, minor code: 0 major string: Invalid credentials minor string: SubjectCredFinder: no JAAS Subject], details=row 'users,,99999999999999' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=nightly6x-1.nightly6x.root.hwx.site,22101,1587511170413, seqNum=-1, see https://s.apache.org/timeout, exception=javax.security.sasl.SaslException: Call to nightly6x-1.nightly6x.root.hwx.site/172.27.21.201:22101 failed on local exception: javax.security.sasl.SaslException: Failure to initialize security context [Caused by org.ietf.jgss.GSSException, major code: 13, minor code: 0 major string: Invalid credentials minor string: SubjectCredFinder: no JAAS Subject] [Caused by javax.security.sasl.SaslException: Failure to initialize security context [Caused by org.ietf.jgss.GSSException, major code: 13, minor code: 0 major string: Invalid credentials minor string: SubjectCredFinder: no JAAS Subject]] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:83) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:57) at java.lang.reflect.Constructor.newInstance(Constructor.java:437) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:220) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:390) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:95) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:410) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:406) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:103) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:118) at org.apache.hadoop.hbase.ipc.BufferCallBeforeInitHandler.userEventTriggered(BufferCallBeforeInitHandler.java:92) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:304) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.userEventTriggered(DefaultChannelPipeline.java:1426) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireUserEventTriggered(DefaultChannelPipeline.java:924) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.failInit(NettyRpcConnection.java:179) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.saslNegotiate(NettyRpcConnection.java:197) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.access$800(NettyRpcConnection.java:71) at org.apache.hadoop.hbase.ipc.NettyRpcConnection$3.operationComplete(NettyRpcConnection.java:273) at org.apache.hadoop.hbase.ipc.NettyRpcConnection$3.operationComplete(NettyRpcConnection.java:261) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:502) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:495) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:474) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:415) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:540) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setSuccess0(DefaultPromise.java:529) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:101) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:84) at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.fulfillConnectPromise(AbstractNioChannel.java:306) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:665) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:612) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:529) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:491) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:905) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:820) Caused by: javax.security.sasl.SaslException: Failure to initialize security context [Caused by org.ietf.jgss.GSSException, major code: 13, minor code: 0 major string: Invalid credentials minor string: SubjectCredFinder: no JAAS Subject] at com.ibm.security.sasl.gsskerb.GssKrb5Client.(GssKrb5Client.java:161) at com.ibm.security.sasl.gsskerb.FactoryImpl.createSaslClient(FactoryImpl.java:79) at javax.security.sasl.Sasl.createSaslClient(Sasl.java:400) at org.apache.hadoop.hbase.security.AbstractHBaseSaslRpcClient.createKerberosSaslClient(AbstractHBaseSaslRpcClient.java:125) at org.apache.hadoop.hbase.security.AbstractHBaseSaslRpcClient.(AbstractHBaseSaslRpcClient.java:106) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClient.(NettyHBaseSaslRpcClient.java:43) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.(NettyHBaseSaslRpcClientHandler.java:70) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.saslNegotiate(NettyRpcConnection.java:194) ... 20 more Caused by: org.ietf.jgss.GSSException, major code: 13, minor code: 0 major string: Invalid credentials minor string: SubjectCredFinder: no JAAS Subject at com.ibm.security.jgss.i18n.I18NException.throwGSSException(Unknown Source) at com.ibm.security.jgss.mech.krb5.v.run(Unknown Source) at java.security.AccessController.doPrivileged(AccessController.java:734) at com.ibm.security.jgss.mech.krb5.s.c(Unknown Source) at com.ibm.security.jgss.mech.krb5.s.a(Unknown Source) at com.ibm.security.jgss.mech.krb5.s.a(Unknown Source) at com.ibm.security.jgss.mech.krb5.s.(Unknown Source) at com.ibm.security.jgss.mech.krb5.Krb5MechFactory.getCredentialElement(Unknown Source) at com.ibm.security.jgss.GSSManagerImpl.createMechCredential(Unknown Source) at com.ibm.security.jgss.GSSCredentialImpl.add(Unknown Source) at com.ibm.security.jgss.GSSCredentialImpl.(Unknown Source) at com.ibm.security.jgss.GSSManagerImpl.createCredential(Unknown Source) at com.ibm.security.jgss.GSSContextImpl.a(Unknown Source) at com.ibm.security.jgss.GSSContextImpl.(Unknown Source) at com.ibm.security.jgss.GSSManagerImpl.createContext(Unknown Source) at com.ibm.security.sasl.gsskerb.GssKrb5Client.(GssKrb5Client.java:135) ... 27 more {code}" Set values in `conf/hbase-site.xml` that enable running on `LocalFileSystem` out of the box,13301351,Resolved,Major,Fixed,27/Apr/20 18:10,14/May/20 21:41,1.7.0,"This ticket is to implement the changes as described on the [discussion on dev|https://lists.apache.org/thread.html/r089de243a9bc9d923fa07c81e6bc825b82be68f567b892a342a0c61f%40%3Cdev.hbase.apache.org%3E]. It reverts and supersedes changes made on HBASE-24086 and HBASE-24106. {quote} The conclusion I understand from this thread looks something like this: 1. revert HBASE-24086, make it so that running on `LocalFileSystem` is a fatal condition with default configs. 2. ship a conf/hbase-site.xml that contains hbase.unsafe.stream.capability.enforce=false, along with a big comment saying this is not safe for production. 3. ship a conf/hbase-site.xml that contains hbase.tmp.dir=./tmp, along with a comment saying herein you'll find temporary and persistent data, reconfigure for production with hbase.rootdir pointed to a durable filesystem that supports our required stream capabilities (see above). 4. update HBASE-24106 as appropriate. Neither 2 nor 3 are suitable for production deployments, thus the changes do not go into hbase-default.xml. Anyone standing up a production deploy must edit hbase-site.xml anyway, so this doesn't change anything. It also restores our ""simple"" first-time user experience of not needing to run anything besides `bin/start-hbase.sh` (or `bin/hbase master start`, or whatever it is we're telling people these days). We can reassess this once more when a durable equivalent to LocalFileSystem comes along. {quote}" Thrift support for HBASE-23941,13311076,Resolved,Major,Fixed,12/Jun/20 07:48,15/Jun/20 10:41,, HBase upgrade from 2.2 to 2.3 fails due to failure in ZooKeeper,13311289,Open,Major,,13/Jun/20 20:13,,2.3.0,"When we tested upgrading HBase from 2.2 to 2.3, the upgraded node failed to start due to a known zookeeper failure - ZOOKEEPER-3056. The error message is shown below:   {code:java} 2020-06-12 23:15:11,432 ERROR [main] master.HMasterCommandLine: Master exiting2020-06-12 23:15:11,432 ERROR [main] master.HMasterCommandLine: Master exitingjava.io.IOException: No snapshot found, but there are log entries. Something is broken! at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:240) at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:240) at org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:290) at org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:450) at org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:764) at org.apache.zookeeper.server.ServerCnxnFactory.startup(ServerCnxnFactory.java:98) at org.apache.hadoop.hbase.zookeeper.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:259) at org.apache.hadoop.hbase.zookeeper.MiniZooKeeperCluster.startup(MiniZooKeeperCluster.java:189) at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:210) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3035) {code}   It can be reproduced through the following steps: * Start a single-node HBase 2.2 with the following configuration. {code:java} hbase.rootdir /var/lib/hbase hbase.zookeeper.property.dataDir /var/lib/zookeeper {code} * Use HBase performance evaluation tool to generate data. {code:java} /hbase/bin/hbase pe --nomapred --oneCon=true --valueSize=10 --rows=100 sequentialWrite 1{code} * Upgrade the node to 2.3 with the same configuration. The new version node failed to start because of the zookeeper. HBase 2.2 is using zookeeper-3.4.10.jar, and Kafka 2.3 are using zookeeper-3.5.7.jar. The bug has been fixed by ZOOKEEPER-3056 in zookeeper-3.6.0. Should we upgrade the dependency of HBase 2.3 to use zookeeper-3.6.0.jar? or upgrade the configuration file of zookeeper-3.5.7.jar?  " improvement for HBase RS Stop ,13311085,Resolved,Major,Not A Problem,12/Jun/20 08:40,15/Jun/20 07:38,,"In our internal hbase based on branch-2.1 in community, we find after the regionserver is stopped about 30 s later, the master find it dead finally from its ephemeral node deleted in zk. During this time, the regions on this server is unavailable and no progress. The log is as follows: {code:java} [2020-06-12 15:51:41.888 ActorThreadPool-consumer-processor-talos-set-alias-55-1 ERROR c.x.xmpush.hbase.utils.HBaseHelper] [get data hbase failed, tableName = mipush:app_alias_new] com.xiaomi.infra.hbase.client.HException: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=10, exceptions: Fri Jun 12 15:50:44 CST 2020, org.apache.hadoop.hbase.client.RpcRetryingCaller@2dc1865, org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: Server c3-hadoop-srv-st639.bj,13700,1591932264018 stopping at org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1551) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2565) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) Fri Jun 12 15:50:44 CST 2020, org.apache.hadoop.hbase.client.RpcRetryingCaller@2dc1865, org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: org.apache.hadoop.hbase.regionserver.RegionServerStoppedException: Server c3-hadoop-srv-st639.bj,13700,1591932264018 stopping at org.apache.hadoop.hbase.regionserver.RSRpcServices.checkOpen(RSRpcServices.java:1551) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2565) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code} The logs in master: {code:java} 2020-06-12,15:51:12,003 INFO [RegionServerTracker-0] org.apache.hadoop.hbase.master.RegionServerTracker: RegionServer ephemeral node deleted, processing expiration [c3-hadoop-srv-st639.bj,13700,1591932264018] 2020-06-12,15:51:12,003 INFO [RegionServerTracker-0] org.apache.hadoop.hbase.master.ServerManager: Processing expiration of c3-hadoop-srv-st639.bj,13700,1591932264018 on c3-hadoop-miui-zk05.bj,13600,1591927126881 2020-06-12,15:51:12,109 INFO [RegionServerTracker-0] org.apache.hadoop.hbase.master.assignment.AssignmentManager: Added c3-hadoop-srv-st639.bj,13700,1591932264018 to dead servers which carryingMeta=false, submitted ServerCrashProcedure pid=97428 2020-06-12,15:51:12,109 INFO [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-c3-hadoop-miui-zk05.bj,13600,1591927126881] org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread: Updating default servers. 2020-06-12,15:51:12,111 INFO [PEWorker-11] org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure: Start pid=97428, state=RUNNABLE:SERVER_CRASH_START, locked=true; ServerCrashProcedure server=c3-hadoop-srv-st639.bj,13700,1591932264018, splitWal=true, meta=false {code} After discussion with [~zghao] offline, we could accelerate this process by sending the message to the master or deleting the ephemeral node itself before stop." WALSplit recreates region dirs for deleted table with recovered edits data,13298407,Resolved,Major,Fixed,14/Apr/20 22:01,13/Jun/20 16:53,2.2.4,"Under the following scenario region directories in HDFS can be recreated with only recovered.edits in them: # Create table ""test"" # Put into ""test"" # Delete table ""test"" # Create table ""test"" again # Crash the regionserver to which the put has went to force the WAL replay # Region directory in old table is recreated in new table # hbase hbck returns inconsistency This appears to happen due to the fact that WALs are not cleaned up once a table is deleted and they still contain the edits from old table. I've tried wal_roll command on the regionserver before crashing it, but it doesn't seem to help as under some circumstances there are still WAL files around. The only solution that works consistently is to restart regionserver before creating the table at step 4 because that triggers log cleanup on startup: [https://github.com/apache/hbase/blob/f3ee9b8aa37dd30d34ff54cd39fb9b4b6d22e683/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java#L508|https://github.com/apache/hbase/blob/f3ee9b8aa37dd30d34ff54cd39fb9b4b6d22e683/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java#L508)]   Truncating a table also would be a workaround by in our case it's a no-go as we create and delete tables in our tests which run back to back (create table in the beginning of the test and delete in the end of the test). A nice option in our case would be to provide hbase shell utility to force clean up of log files manually as I realize that it's not really viable to clean all of those up every time some table is removed." Add backoff to SCP check on WAL split completion,13311060,Resolved,Major,Fixed,12/Jun/20 06:09,12/Jun/20 15:00,,"Crashed cluster. Lots of backed up WALs. Startup. Recover hundreds of servers; each has a running SCP. Taking a thread dump during recovery, I noticed that there were 160 threads each in SCP waiting on split WAL completion. Each thread was scanning zk splitWAL directory every 100ms. The dir had thousands of entries in it so each check was pulling down MB from zk... * 160 (max configured PE threads (16) * 10 for the KeepAlive factor that has us do 10 * configured PEs as max for PE worker pool). If lots of remaining WALs to split, have the SCP backoff on its wait so it checks less frequently." Cluster locked up due to REST gateway queries for non-existent tables,13311160,Open,Major,,12/Jun/20 15:39,,,"We had a case where a REST gateway instance was picked up by an automated security scanning tool. Many of the http requests it generated were interpreted requests against non-existent tables. The result was a flood of queries against meta, completely overrunning the priority queue of the region server hosting meta. We need some kind of back pressure mechanism that can protect meta from a single bad actor." Execute region plans with throttle should return succeeded plans,13310726,Resolved,Major,Fixed,10/Jun/20 18:20,11/Jun/20 13:01,,"executeRegionPlansWithThrottling() in HMaster does not return successfully executed region plans and hence, MasterCoprocessorHost.postBalance() is not able to retrieve any region plan." Recommend upping zk jute.maxbuffer in all but minor installs,13311050,Open,Major,,12/Jun/20 04:24,,,"Add a doc note in upgrade and in zookeeper section recommending upping zk jute.maxbuffer to be above the default of 1M. Here is jute.maxbuffer from zk doc. {code} jute.maxbuffer: (Java system property: jute.maxbuffer) This option can only be set as a Java system property. There is no zookeeper prefix on it. It specifies the maximum size of the data that can be stored in a znode. The default is 0xfffff, or just under 1M. If this option is changed, the system property must be set on all servers and clients otherwise problems will arise. This is really a sanity check. ZooKeeper is designed to store data on the order of kilobytes in size. {code} It seems easy enough blowing the 1MB default. Here is one such scenario. A peer is disabled so WALs backup on each RegionServer or a bug makes it so we don't clear WALs out from under the RegionServer promptly. Backed-up WALs get into the hundreds... easy enough on a busy cluster. Next, there is a power outage and the cluster crashes down. Recovery may require an SCP recovering hundreds of WALs. As is, the way our SCP works, we can end up with a /hbase/splitWAL dir with hundreds -- even thousands -- of WALs in it. The 1MB buffer limit in zk can't carry listings this big. Of note, the jute.maxbuffer needs to be set on the zk servers -- with restart so the change is noticed -- and on the client-side, in the hbase master at least. This issue is about highlighting this old issue in our doc. It seems to be absent totally. " Update anonymous git url on website,13310997,Open,Major,,11/Jun/20 21:17,,,Our [source repository page|https://hbase.apache.org/source-repository.html] lists the anonymous gitbox url using {{git://}} protocol. They tell me over on {{#asfinfra}} that gitbox has never supported the {{git://}} protocol. Change HBASE_TARGET_TAG to a human readable tag,13310648,Open,Major,,10/Jun/20 12:59,,,HBASE-24400 ([https://github.com/apache/hbase-native-client/pull/2)] introduced HBASE_TARGET_TAG which is a target HBase repo tag. A hash was used originally then changed to the master branch. We should change this to a tagged version when the target functionality is tagged upstream. Ability to configure timeout between RPC retry to RS from master,13309778,Resolved,Major,Fixed,05/Jun/20 17:27,10/Jun/20 08:01,,"This is useful for the cases where there is an injected environment edge and when the first RS RPC request fails causing it to go to the retry block. In the absence of this , the default timeout would be set to 100 ms and the DelayedUtil class is meant to execute the retry after 100 ms. However as per the getRemainingTime() logic here (https://github.com/apache/hbase/blob/5b01e613fbbb92e243e99a1d199b4ffbb21ed2d9/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/util/DelayedUtil.java#L94), the equation would be evaluated to   EnvironmentEdgeManager.currentTime() >= EnvironmentEdgeManager.currentTime() + 100 which would never get evaluated to true in case of injected edge and retry never happens. Hence this config helps you to override it to 0 in cases we want to test with a manual injected environment edge so that the retry would succeed   An example would be Master trying to open the meta region even before the RS is online, In this case the retry of opening the meta region would never happen in the case of injected environment edge and master would never finish the initialization" Reenable the TestExportSnapshot family of tests,13310195,Open,Major,,08/Jun/20 17:28,,2.3.0,"The yarn history server can take a while to start. It is hardcoded at one minute before all is killed. On loaded servers can take this long to start. Cannot disable history server in tests nor can we configure the mini yarn cluster so it can take longer starting history server. After this addressed, and yarn history server is given more time or disabled, reenable the TestExportSnapshot* family of tests. See parent issue for details." Remove RS entry from zk draining servers node after RS been stopped,13299206,Resolved,Major,Fixed,17/Apr/20 19:24,08/Jun/20 17:26,,"When a RS is been decommissioned, we will add an entry into the zk node. This will be there unless the same RS instance is recommissioned. But if we want to scale down a cluster, the best path would be to decommission the RSs in the scaling down nodes. The regions in these RSs will get moved to live RSs. In this case these decommissioned RSs will get stopped later. These will never get recommissioned. The zk nodes will still be there under draining servers path. We can remove this zk node when the RS is getting stopped." Run a correctness test with ITBLL,13297185,Resolved,Major,Done,08/Apr/20 18:42,08/Jun/20 18:33,2.3.0,Kick the tires on a recent commit. The tab of Base Stats not actived by default in table.jsp,13309085,Resolved,Major,Fixed,03/Jun/20 03:04,06/Jun/20 13:50,3.0.0-alpha-1,"This bug was introduced by HBASE-21404, it expect to resovle the active issue of nav bar, but impact other areas." release scripts using docker should specify needed disk consistency,13308053,Resolved,Major,Fixed,28/May/20 14:17,05/Jun/20 01:04,,"reading through existing docs and write ups for Docker Desktop (the dominant docker option for running on OS X machines), it looks like the host-to-container mapping get significant perf gains if we can relax from strict container-host consistency on the filesystem." Immutable Scan as unmodifiable subclass or wrapper of Scan,13308023,Resolved,Major,Fixed,28/May/20 12:21,04/Jun/20 11:07,,We should provide an ImmutableScan as subclass or wrapper of Scan which can be used specifically by Coprocessors as read only Scan. This suggestion came up while reviewing HBASE-24321 by multiple reviewers: [https://github.com/apache/hbase/pull/1655] TestRemoteBackup is broken,13302305,Resolved,Major,Fixed,01/May/20 12:56,05/Jun/20 08:01,,It seems that the bulk load rpc request is timed out after 1 minute and fails the test. Canary support check only one column family per RegionTask,13306491,Resolved,Major,Fixed,21/May/20 12:37,04/Jun/20 14:14,, Update docs re: ZooKeeper compatibility of 2.3.x release,13308817,Resolved,Major,Fixed,01/Jun/20 22:37,02/Jun/20 17:00,,"HBASE-24132 bumps the ZooKeeper version, which itself has some known upgrade steps. We have a release note, but we can call this out in our [2.3 upgrading section|https://hbase.apache.org/book.html#upgrade2.3] of the book." Test coverage for HBASE-23202 - ExportSnapshot (import) will fail if copying files to root directory takes longer than cleaner TTL,13307539,Resolved,Major,Duplicate,26/May/20 20:47,02/Jun/20 23:59,1.4.11,"This is a followup Jira to add test coverage for HBASE-23202, it is broken since there is no test coverage. Will try to add an unittest for this case to avoid future broke." [Flakey Tests] TestExportSnapshot takes too long; up against 13min max,13296727,Resolved,Major,Fixed,07/Apr/20 03:53,08/Apr/20 20:24,,"TestExportSnapshot fails fairly regularly locally. Looking, its test timeout. Looking at how long it ran, its 13minutes plus. Looking at recent successful branch-2 run, it passed but it took about 7-8minutes. Let me break up the test into to pieces. org.junit.runners.model.TestTimedOutException: test timed out after 780 seconds at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:227) at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportRetry(TestExportSnapshot.java:267) ... I see this in the log: ====> TEST TIMED OUT. PRINTING THREAD DUMP. <==== Test started at: 2020-04-06 17:19:21,739 INFO ... and the timestamp just above the TIMED OUT was 2020-04-06 17:31:01,758 " Deflake TestRSGroupsBasics#testClearDeadServers,13308613,Resolved,Major,Fixed,01/Jun/20 01:48,01/Jun/20 17:01,1.7.0,"Ran into this on our internal forks based on branch-1. It also applies to branch-2 but not master because the code has been re-implemented without co-proc due to HBASE-22514 Running into this exception in the test run.. {noformat} org.apache.hadoop.hbase.constraint.ConstraintException: The set of servers to remove cannot be null or empty. at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.removeServers(RSGroupAdminServer.java:391) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postClearDeadServers(RSGroupAdminEndpoint.java:1175) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$104.call(MasterCoprocessorHost.java:1251) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.execOperation(MasterCoprocessorHost.java:1507) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postClearDeadServers(MasterCoprocessorHost.java:1247) at org.apache.hadoop.hbase.master.MasterRpcServices.clearDeadServers(MasterRpcServices.java:1167) at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2421) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291) "" type=""org.apache.hadoop.hbase.constraint.ConstraintException"">org.apache.hadoop.hbase.constraint.ConstraintException: org.apache.hadoop.hbase.constraint.ConstraintException: The set of servers to remove cannot be null or empty. at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.removeServers(RSGroupAdminServer.java:391) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postClearDeadServers(RSGroupAdminEndpoint.java:1175) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$104.call(MasterCoprocessorHost.java:1251) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.execOperation(MasterCoprocessorHost.java:1507) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postClearDeadServers(MasterCoprocessorHost.java:1247) at org.apache.hadoop.hbase.master.MasterRpcServices.clearDeadServers(MasterRpcServices.java:1167) at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2421) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291) at org.apache.hadoop.hbase.rsgroup.TestRSGroupsBasics.testClearDeadServers(TestRSGroupsBasics.java:215) Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException: org.apache.hadoop.hbase.constraint.ConstraintException: The set of servers to remove cannot be null or empty. at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.removeServers(RSGroupAdminServer.java:391) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postClearDeadServers(RSGroupAdminEndpoint.java:1175) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$104.call(MasterCoprocessorHost.java:1251) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.execOperation(MasterCoprocessorHost.java:1507) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postClearDeadServers(MasterCoprocessorHost.java:1247) at org.apache.hadoop.hbase.master.MasterRpcServices.clearDeadServers(MasterRpcServices.java:1167) at org.apache.hadoop.hbase.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2421) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291) {noformat}" Enhanced version of KeyPrefixRegionSplitPolicy,13308376,Patch Available,Major,,29/May/20 17:44,,,"With KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy, splitting regions policy is limited to either fixed length or based on delimiter. With Yarn Application Timeline Server V2, as discussed in YARN-10077, it will be nice to have enhanced version of DelimitedKeyPrefixRegionSplitPolicy that will give more flexibility to users to define the ordinance of delimiter to consider.  " Scanners for Replicas region return many HFileLink name exceptions,13308687,Open,Major,,01/Jun/20 09:57,,2.2.4,"When region read replicas is enabled and scan is running, regionsevers logged so many warns as follows；It appears replicas region StoreFileInfo took normal hfile as filelink , however function getActiveFileName would throw exception when checking filelink format. 2020-05-31 10:40:48,486 WARN [RpcServer.default.RWQ.Fifo.scan.handler=238,queue=238,port=16020] regionserver.StoreScanner: failed to switch to stream read java.lang.IllegalArgumentException: 153052181a084e70a1242870fe6e4961 is not a valid HFileLink name! at org.apache.hadoop.hbase.io.HFileLink.getReferencedHFileName(HFileLink.java:252) at org.apache.hadoop.hbase.regionserver.StoreFileInfo.getActiveFileName(StoreFileInfo.java:624) at org.apache.hadoop.hbase.regionserver.HStore.recreateScanners(HStore.java:2104) at org.apache.hadoop.hbase.regionserver.StoreScanner.trySwitchToStreamRead(StoreScanner.java:1068) at org.apache.hadoop.hbase.regionserver.StoreScanner.shipped(StoreScanner.java:1202) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.shipped(KeyValueHeap.java:437) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.shipped(HRegion.java:7037) at org.apache.hadoop.hbase.regionserver.RSRpcServices$RegionScannerShippedCallBack.run(RSRpcServices.java:396) at org.apache.hadoop.hbase.ipc.ServerCall.setResponse(ServerCall.java:289) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:167) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)" BucketCache disabled instantly before error duration toleration is reached due to timing issue,13307997,Resolved,Major,Fixed,28/May/20 10:30,31/May/20 04:11,1.4.10,"We saw an instance where BucketCache was disabled after only two IO error were encountered at nearly the same time. The following shows all errors from a region server log for the 2020-05-26 17:00 hour. Notice that there are no other errors until the 17:14:50 at which time the BucketCache is disabled because it claims duration time has exceeded 60000 ms: $ grep ERROR hbase-hbase-regionserver-ip-172-20-113-147.log.2020-05-26-17 2020-05-26 17:14:50,396 ERROR [hfile-prefetch-1589117924884] bucket.BucketCache: Failed reading block 9adfad3a603047cfa0c98b16da0b0974_13786 from bucket cache 2020-05-26 17:14:50,397 ERROR [regionserver/ip-172-20-113-147.us-west-2.compute.internal/172.20.113.147:16020-BucketCacheWriter-0] bucket.BucketCache: Failed syncing IO engine 2020-05-26 17:14:50,400 ERROR [hfile-prefetch-1589117924884] bucket.BucketCache: Failed reading block 9adfad3a603047cfa0c98b16da0b0974_13786 from bucket cache 2020-05-26 17:14:50,401 ERROR [hfile-prefetch-1589117924884] bucket.BucketCache: IO errors duration time has exceeded 60000ms, disabling cache, please check your IOEngine The region server is very busy so it should be constantly getting successful reads and writes in the bucket cache (it is not as though there was some long ago error and then no successful IO to clear the error flag). We are running a busy EMR cluster backed by S3. A bucketcache getting disabled is a huge performance issue because all reads must go to S3. Looking at the code, I believe I've found a timing issue. Here is the code for checking and setting the ioErrorStartTime (taken from BucketCache.java):   {code:java} /** * Check whether we tolerate IO error this time. If the duration of IOEngine * throwing errors exceeds ioErrorsDurationTimeTolerated, we will disable the * cache */ private void checkIOErrorIsTolerated() { long now = EnvironmentEdgeManager.currentTime(); if (this.ioErrorStartTime > 0) { if (cacheEnabled && (now - ioErrorStartTime) > this.ioErrorsTolerationDuration) { LOG.error(""IO errors duration time has exceeded "" + ioErrorsTolerationDuration + ""ms, disabling cache, please check your IOEngine""); disableCache(); } } else { this.ioErrorStartTime = now; } } {code}   And here is the code for clearing the ioErrorStartTime when a successful read or write is done: {code:java} if (this.ioErrorStartTime > 0) { ioErrorStartTime = -1; } {code} Notice that that if ioErrorStartTime is set to -1 after the first if statement in checkIOErrorIsTolerated but before (now - ioErrorStartTime), then (now - ioErrorStartTime) will evaluate to (now + 1) resulting in the code thinking it has exceeded ioErrorsTolerationDuration." Remove the HasThread because the related bug had been fixed since jdk7,13307928,Resolved,Major,Fixed,28/May/20 05:45,29/May/20 12:31,,"The HasThread was introduced as a wrapper of Thread to workaround a deadlock bug, and this bug had fixed since jdk7, so I think it is the time to remove it as we are using jdk8+.   Related links: [https://issues.apache.org/jira/browse/HBASE-4367|https://slack-redir.net/link?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FHBASE-4367] [https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6915621|https://slack-redir.net/link?url=https%3A%2F%2Fbugs.java.com%2Fbugdatabase%2Fview_bug.do%3Fbug_id%3D6915621]" Add TTL to PE so that we can create a table with TTL,13305639,Open,Major,,18/May/20 09:38,,,It may be very helpful to add TTL while creating the table. Improve default thread pool size for opening store files,13307799,Open,Major,,27/May/20 16:16,,,"For each store open we create a CompletionService and also create a thread pool for opening and closing store files. See HStore#openStoreFiles and HRegion#getStoreFileOpenAndCloseThreadPool. By default this pool has only one thread. It can be increased with ""hbase.hstore.open.and.close.threads.max"" but this config value is then divided by number of stores in the region. ""hbase.hstore.open.and.close.threads.max"" is also used to size other thread pools for opening and closing the stores themselves, so it's an unfortunate overloading. We should have a configuration parameter that directly and simply tunes the thread pool size for opening store files. Introduce a new configuration parameter: ""hbase.hstore.hfile.open.threads.max"" which will define the upper bound for a thread pool shared by the entire store for opening hfiles. The default should be 1 to preserve default behavior. Once this is done, we could increase this to 2, 4, 8, or more for increased parallelism when opening store files without impact on other activities. The time required to open all storefiles often dominates the total time for bringing a region online. The thread pool will be shut down and eligible for garbage collection once all files are loaded and the store is online. Number of open threads should scale with the number of stores, so allocating the pool at the store level continues to make sense. Longer term we might try recursively decomposing the region open task with a fork-join pool such that the opening of store files can be dynamically parallelized in a probably superior way (conjecture pending a real attempt with metrics) . " CatalogJanitor misreports region holes when there are actually over laps.,13305262,Resolved,Major,Fixed,15/May/20 18:26,29/May/20 16:46,2.3.0,"We found a case that there is actually an overlap, but a region hole is reported. r1: [aa, bb), r2: [cc, dd), r3: [a, cc)   In this case, there are only overlaps from ""a"" to ""d"". However, hole (r1, r2) is reported." region_mover.rb NoMethodError: undefined method `tmpdir' for Dir:Class,13308190,Open,Major,,28/May/20 22:41,,1.6.0,"Trying to use region_mover.rb to unloadRegion and see the following   NoMethodError: undefined method `tmpdir' for Dir:Class getFilename at /usr/current/hbase-regionserver/bin/region_mover.rb:445 unloadRegions at /usr/current/hbase-regionserver/bin/region_mover.rb:299 (root) at /usr/current/hbase-regionserver/bin/region_mover.rb:525" set up reproducible builds,13308124,Open,Major,,28/May/20 18:24,,,"it would be really nice if we had reproducible builds https://maven.apache.org/guides/mini/guide-reproducible-builds.html if we had reproducible builds it'd be easier to e.g. do piecemeal optimization of our release process." Expose HBCK Chore Reports via metrics,13308108,Open,Major,,28/May/20 17:12,,,"Talking with an operator about their experience upgrading to HBase2. They automate as much as they can, and like having access to so much system state via {{/json}} endpoint. One of the things they miss on the endpoint is access to hbck reports. Now in HBase2 these reports are managed by the master, we can represent them in JMX and make them available as metrics as well." Make it easy to delete all data for specify qualifiers,13307118,Open,Major,,25/May/20 03:08,,,"We developed a great many user features that each one as a qualifier stored in a table which has only one column family, when we planed to decommission some of them, but found not easy to do.   My propasal is add a hint for major_compact, eg: {code:java} major_compact_delete_extra_qualifiers 'table','cf','q1','q2'{code} This command will delete all of the cells for q1 and q2." Run hbck_chore_run and catalogjanitor_run on draw of 'HBCK Report' page,13307123,Resolved,Major,Fixed,25/May/20 03:51,27/May/20 02:53,,"Run the 'catalogjanitor_run' and the 'hbck_chore_run' when we draw the 'HBCK Report' page. Its PITA running command on the shell every time you need a new report. Can avoid new behavior by passing '?cache=true' on URL." "Flaky test, TestLocalRegionOnTwoFileSystems#testFlushAndCompact",13307490,Resolved,Major,Fixed,26/May/20 17:20,27/May/20 03:29,,"{code:java} precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.store.TestLocalRegionOnTwoFileSystems.testFlushAndCompactFailing for the past 1 build (Since #1 )Took 17 sec.Error MessageWaiting timed out after [15,000] msecStacktracejava.lang.AssertionError: Waiting timed out after [15,000] msec at org.apache.hadoop.hbase.master.store.TestLocalRegionOnTwoFileSystems.testFlushAndCompact(TestLocalRegionOnTwoFileSystems.java:178) Standard OutputFormatting using clusterid: testClusterID Standard Error2020-05-26 00:26:29,624 INFO [main] hbase.HBaseClassTestRule(94): Test class org.apache.hadoop.hbase.master.store.TestLocalRegionOnTwoFileSystems timeout: 13 mins 2020-05-26 00:26:30,158 DEBUG [main] hbase.HBaseTestingUtility(348): Setting hbase.rootdir to /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1776/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-data/f6a36278-321e-2b82-017a-bbe71410a0cf 2020-05-26 00:26:30,231 INFO [Time-limited test] hbase.HBaseTestingUtility(1114): Starting up minicluster with option: StartMiniClusterOption{numMasters=1, masterClass=null, numRegionServers=3, rsPorts=, rsClass=null, numDataNodes=3, dataNodeHosts=null, numZkServers=1, createRootDir=false, createWALDir=false} 2020-05-26 00:26:30,232 INFO [Time-limited test] hbase.HBaseZKTestingUtility(83): Created new mini-cluster data directory: /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1776/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-data/f6a36278-321e-2b82-017a-bbe71410a0cf/cluster_ddea42b7-f6f1-92fe-0685-674774d0fce2, deleteOnExit=true 2020-05-26 00:26:30,233 INFO [Time-limited test] hbase.HBaseTestingUtility(1128): STARTING DFS {code}" Add 2.2.5 to download page,13307352,Resolved,Major,Fixed,26/May/20 07:06,26/May/20 11:13,, Release 2.2.5,13303535,Resolved,Major,Fixed,08/May/20 03:35,26/May/20 11:14,, Set version as 2.2.6-SNAPSHOT in branch-2.2,13307350,Resolved,Major,Fixed,26/May/20 07:02,26/May/20 07:05,, Cell size limit check on append should consider 0 or less value to disable the check,13306040,Resolved,Major,Fixed,20/May/20 02:32,25/May/20 05:39,1.4.10,"HBASE-22274 added a cell size check for append in HRegion, but did not consider 0 and less values. If we set  the parameter *hbase.server.keyvalue.maxsize* to 0, expect to turn off the cell size check, all append operations will fail.  " TableSnapshotInputFormatImpl support row limit on each InputSplit,13305447,Resolved,Major,Fixed,17/May/20 04:53,25/May/20 05:40,,"In some scenario , We want to  scan limited rows on each InputSplit for sampling data extraction" Set version to 2.2.5 in branch-2.2 for first RC of 2.2.5,13306469,Resolved,Major,Fixed,21/May/20 10:08,25/May/20 07:15,2.2.5, Generate CHANGES.md and RELEASENOTES.md for 2.2.5,13306428,Resolved,Major,Fixed,21/May/20 09:30,25/May/20 08:26,2.2.5, release scripts should be able to use a custom git repo,13302251,Resolved,Major,Fixed,01/May/20 02:34,23/May/20 03:39,,"doing a full new clone is expensive, especially for the main repo. we should be able to optionally point at an existing clone." install yetus as a part of building the rm docker image.,13302250,Resolved,Major,Fixed,01/May/20 02:32,23/May/20 03:39,,right now we have to download yetus on each release run. we should be able to point at a local install instead. Document hbase:slowlog in detail,13306158,Resolved,Major,Fixed,20/May/20 10:55,23/May/20 06:15,, "HBASE-22259 Removed deprecated getTimeStampOfLastShippedOp method from ReplicationLoadSource, but there were still references to this method on ruby admin.rb",13306532,Resolved,Major,Fixed,21/May/20 16:23,22/May/20 09:47,3.0.0-alpha-1, "When running the tests, a tremendous number of connections are put into TIME_WAIT.",13297391,Resolved,Major,Information Provided,09/Apr/20 14:12,13/May/20 13:24,,"When you run the test suite and monitor the number of connections in TIME_WAIT, it appears that a very large number of connections do not end up with a proper connection close lifecycle or perhaps proper reuse. Given connections can stay in TIME_WAIT from 1-4 minutes depending on OS/Env, running the tests faster or with more tests in parallel increases the TIME_WAIT connection buildup. Some tests spin up a very, very large number of connections and if the wrong ones run at the same time, this can also greatly increase the number of connections put into TIME_WAIT. This can have a dramatic affect on performance (as it can take longer to create a new connection) or flat out fail or timeout. In my experience, a much, much smaller number of connections in a test suite would end up in TIME_WAIT when connection handling is all correct. Notes to come in comments below." Make `RESTApiClusterManager` more resilient,13304475,Resolved,Major,Fixed,12/May/20 23:48,19/May/20 16:53,2.3.0,"The Cloudera Manager API client in {{RESTApiClusterManager}} appears to assume that API calls sent to CM for process commands block on command completion. However, these commands are ""asynchronous,"" queuing work in the background for execution. Update the client to track command submission and block on completion of that commandId. This allows this {{ClusterManager}} to conform to the expectations of the {{Actions}} that invoke it." TableSnapshotScanner support scan limit,13305436,Resolved,Major,Fixed,17/May/20 02:26,19/May/20 16:04,, Backport HBASE-23998 to branch-2.2,13300391,Resolved,Major,Fixed,23/Apr/20 00:07,29/Apr/20 22:38,, Backport HBASE-23833 to branch-2.2,13300070,Resolved,Major,Fixed,21/Apr/20 19:28,29/Apr/20 22:39,, Backport HBASE-22103 to branch-2.2,13300390,Resolved,Major,Fixed,22/Apr/20 23:57,29/Apr/20 22:38,, Retain the ReadRequests and WriteRequests of region on web UI after alter table,13297568,Resolved,Major,Fixed,10/Apr/20 08:21,18/May/20 19:57,,"When we alter a table, all regions of it will do a rs self move, then the ReadRequests and WriteRequests will be cleared, but they are very useful metrics, my propose is keep them in RegionServerAccounting on close if it is a rs self move, and recover them on open." [Chaos Monkey] Invalid data block encoding in ChangeEncodingAction,13304613,Resolved,Major,Fixed,13/May/20 10:01,20/May/20 10:57,,"I found the following exception when I run ITBLL: {code:java} 2020-05-12 11:43:14,201 WARN [ChaosMonkey] policies.Policy: Exception performing action: java.lang.IllegalArgumentException: There is no data block encoder for given id '6' at org.apache.hadoop.hbase.io.encoding.DataBlockEncoding.getEncodingById(DataBlockEncoding.java:168) at org.apache.hadoop.hbase.chaos.actions.ChangeEncodingAction.lambda$perform$0(ChangeEncodingAction.java:50) at org.apache.hadoop.hbase.chaos.actions.Action.modifyAllTableColumns(Action.java:356) at org.apache.hadoop.hbase.chaos.actions.ChangeEncodingAction.perform(ChangeEncodingAction.java:48) at org.apache.hadoop.hbase.chaos.policies.PeriodicRandomActionPolicy.runOneIteration(PeriodicRandomActionPolicy.java:59) at org.apache.hadoop.hbase.chaos.policies.PeriodicPolicy.run(PeriodicPolicy.java:41) at java.lang.Thread.run(Thread.java:748) {code} Because PREFIX_TREE is removed in DataBlockEncoding: {code:java} /** Disable data block encoding. */ NONE(0, null), // id 1 is reserved for the BITSET algorithm to be added later PREFIX(2, ""org.apache.hadoop.hbase.io.encoding.PrefixKeyDeltaEncoder""), DIFF(3, ""org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder""), FAST_DIFF(4, ""org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder""), // id 5 is reserved for the COPY_KEY algorithm for benchmarking // COPY_KEY(5, ""org.apache.hadoop.hbase.io.encoding.CopyKeyDataBlockEncoder""), // PREFIX_TREE(6, ""org.apache.hadoop.hbase.codec.prefixtree.PrefixTreeCodec""), ROW_INDEX_V1(7, ""org.apache.hadoop.hbase.io.encoding.RowIndexCodecV1""); {code}" "[DOCS] Document ""ignoreTimestamps"" option added to HashTable/SyncTable by HBASE-24302 to related ref-guide section",13302623,Resolved,Major,Fixed,04/May/20 11:40,18/May/20 15:58,3.0.0-alpha-1, [hbase-operator-tools] RegionsMerger ConcurrentModificationException,13305819,Resolved,Major,Fixed,19/May/20 05:39,19/May/20 11:15,hbase-operator-tools-1.1.0, MemStoreFlusher throw NullPointerException,13305141,Resolved,Major,Fixed,15/May/20 08:24,18/May/20 02:32,,"{code} 2020-02-26 10:15:33,585 ERROR [MemStoreFlusher.2] regionserver.MemStoreFlusher: Cache flusher failed for entry null java.lang.NullPointerException at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushOneForGlobalPressure(MemStoreFlusher.java:158) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$700(MemStoreFlusher.java:68) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:346) at java.lang.Thread.run(Thread.java:745) {code} Need to setFlushType first before use it. " The Size metrics in Master Webui is wrong if the size is 0,13305333,Resolved,Major,Fixed,16/May/20 03:04,18/May/20 01:47,2.2.4,"As shown in attachment, there is no storefiles on the last RS, but the StoreFile Size is as large as the previous RS." Add ServerSsdLocalityCostFunction to StochasticLoadBalancer,13297331,Open,Major,,09/Apr/20 09:27,,,"When use ONE_SSD storagy policy, or ALL_SSD but has not enough SSD, there will be some hdfs blocks on DISK and others on SSD,so it is reasonable to consider the locality of ssd for StochasticLoadBalancer." release scripts should do compat report that includes LimitedPrivate APIs for maintenance releases,13305412,Open,Major,,16/May/20 18:25,,,currently the release script does a compatibility report that just covers IA.Public apis. That's covers our promises for new minor versions. When doing maintenance versions (e.g. 2.2.5) we ought to be reporting on any breaking changes in IA.LimitedPrivate APIs as well. compatibility report in release process should use existing binaries,13305410,Open,Major,,16/May/20 18:17,,,"right now the compatibility report generation in the release scripts does an additional build of both the current RC and the comparison release. Instead, we should have an option to grab artifacts for the previous release from the mirroring / archive system. Additionally, we should always use the binary bits we just created for the binary distribution for the RC." Update getting started documentation after HBASE-24086,13295869,Resolved,Major,Won't Fix,02/Apr/20 18:19,14/May/20 21:04,,HBASE-24086 allows HBase to degrade gracefully to running on a {{LocalFileSystem}} without further user configuration. Update the docs accordingly. Assign table to default RSGroup may throw exception when RSGroup enabled,13304868,Resolved,Major,Duplicate,14/May/20 08:03,15/May/20 10:23,,"{code} 2020-03-25 14:58:58,375 INFO [RpcServer.default.FPBQ.Fifo.handler=397,queue=77,port=60000] master.HMaster: Client=hbaseadmin//10.196.142.227 create 'extra_500000039', {NAME => 'extra', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'false', CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'DIFF', TTL => '2592000 SECONDS (30 DAYS)', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false', CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', COMPRESSION => 'SNAPPY', BLOCKCACHE => 'true', BLOCKSIZE => '65536'} 2020-03-25 14:58:58,482 INFO [RpcServer.default.FPBQ.Fifo.handler=397,queue=77,port=60000] rsgroup.RSGroupAdminServer: Moving table extra_500000039 to RSGroup default 2020-03-25 14:58:58,485 ERROR [RpcServer.default.FPBQ.Fifo.handler=397,queue=77,port=60000] master.TableStateManager: Unable to get table extra_500000039 state org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: extra_500000039 at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:233) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:347) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:456) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:479) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350) at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347) at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2048) at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2031) at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:658) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2020-03-25 14:58:58,486 INFO [RpcServer.default.FPBQ.Fifo.handler=397,queue=77,port=60000] rsgroup.RSGroupAdminServer: Moving region(s) for table extra_500000039 to RSGroup default 2020-03-25 14:58:58,486 INFO [RpcServer.default.FPBQ.Fifo.handler=397,queue=77,port=60000] master.MasterRpcServices: Client=hbaseadmin//10.196.142.227 procedure request for creating table: namespace: ""default"" qualifier: ""extra_500000039"" procId is: 14019 {code} Latch is released when execute prepareCreate, so MasterCoprocessorHost#postCreateTable can run before the table actually created, when RSGroup enable, it will throw exception like the above. Looks like the issue will not happen in master, but can happen in branch-2." Make kerberos value of hbase.security.authentication property case insensitive,13298423,Resolved,Major,Fixed,15/Apr/20 00:56,14/May/20 08:39,,"In hbase-20586 (https://issues.apache.org/jira/browse/HBASE-20586) （commit_sha: [https://github.com/apache/hbase/commit/cd61bcc0] ） The code added ([SyncTable.java|https://github.com/apache/hbase/commit/cd61bcc0#diff-d1b79635f33483bf6226609e91fd1cc3]) for the use of *hbase.security.authentication* is case-sensitive. So users setting it to “KERBEROS” won’t take effect.    {code:java}  private void initCredentialsForHBase(String zookeeper, Job job) throws IOException {    Configuration peerConf = HBaseConfiguration.createClusterConf(job.getConfiguration(), zookeeper);    if(peerConf.get(""hbase.security.authentication"").equals(""kerberos"")){ TableMapReduceUtil.initCredentialsForCluster(job, peerConf);    }  } {code}   However, in current code base, other uses of *hbase.security.authentication* are all case-insensitive. For example in *MasterFileSystem.java.*    {code:java} public MasterFileSystem(Configuration conf) throws IOException{   ...   this.isSecurityEnabled = ""kerberos"".equalsIgnoreCase(conf.get(""hbase.security.authentication""));   ... } {code}   The doc in GitHub repo is also misleading (Giving upper-case value). {quote}As a distributed database, HBase must be able to authenticate users and HBase services across an untrusted network. Clients and HBase services are treated equivalently in terms of authentication (and this is the only time we will draw such a distinction). There are currently three modes of authentication which are supported by HBase today via the configuration property {{hbase.security.authentication}} {{1.SIMPLE}} {{2.KERBROS}} {{3.TOKEN}} {quote} Users may misconfigure the parameter because of the case-senstive problem. *How To Fix* Using *eqaulsIgnoreCase* API consistently in every place when using *hbase.security.authentication* or make it clear in Doc." Allow hbase1 cluster to replicate to an hbase2 cluster,13304231,Open,Major,,11/May/20 23:49,,,Umbrella issue to make it so an hbase1 cluster can replicate to an hbase2 cluster. I thought this worked but just tried it and it doesn't seem like it can. Replication compares table schemas before it starts. The hbase2 has a default that is not defined in hbase1 so we are unable to make the schemas equivalent. There are probably other issues in here too. Let me make an umbrella. Fix failed ut TestAssignmentManagerMetrics for branch-2.2,13304584,Resolved,Major,Fixed,13/May/20 09:18,14/May/20 04:13,2.2.4, Fix CI builds on branch-2.2,13298889,Resolved,Major,Invalid,16/Apr/20 18:52,14/May/20 07:30,2.2.5,"From a recent [PR build|https://builds.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-1532/1/pipeline/] {noformat} [2020-04-16T18:43:21.548Z] Setting up ruby2.3 (2.3.3-1+deb9u7) ... [2020-04-16T18:43:21.548Z] Setting up ruby2.3-dev:amd64 (2.3.3-1+deb9u7) ... [2020-04-16T18:43:21.548Z] Setting up ruby-dev:amd64 (1:2.3.3) ... [2020-04-16T18:43:21.548Z] Setting up ruby (1:2.3.3) ... [2020-04-16T18:43:22.261Z] Processing triggers for libc-bin (2.24-11+deb9u3) ... [2020-04-16T18:43:22.975Z] Successfully installed rake-13.0.1 [2020-04-16T18:43:22.975Z] Building native extensions. This could take a while... [2020-04-16T18:43:25.277Z] ERROR: Error installing rubocop: [2020-04-16T18:43:25.277Z] rubocop requires Ruby version >= 2.4.0. {noformat} Looks like the Dockerfile on branch-2.2 has bit-rot. I suspect package versions are partially pinned or not pinned at all: the rubocop version has incremented by ruby version has not." "Backport HBASE-24304 ""Separate a hbase-asyncfs module"" to branch-2.x",13303036,Resolved,Major,Fixed,06/May/20 06:49,14/May/20 02:10,, Create-release scripts fixes and enhancements,13302701,Resolved,Major,Fixed,04/May/20 17:14,13/May/20 17:50,2.3.0,"The create-release tools are a set of scripts that promote best practice in making Apache releases, by automating most of the steps and running them under Docker for reliability. However, the current state of the scripts has many bugs and ambiguities. The proposed PR cleans up the code and clarifies usage. It enables: - Clear statement of the four steps, which are now called `tag`, `publish-dist`, `publish-snapshot`, and `publish-release` (the latter two being mutually exclusive alternatives). - Ability to do the three tag-dist-release steps with a single command, or do any of the steps singly. (Running singly had bugs and unfulfilled dependencies before.) - Ability to do a reliable and useful ""dry run"" of all steps or each step, and chain together the tag step with publish steps in a dry run. - Ability to run any or all steps correctly in Docker or outside of Docker, on Linux and Mac. - Cleaned up all `shellcheck` errors in the scripts, and removed ambiguities and redundancies in the many environment variables used. In addition, the changes move the code toward being more general / less HBase-specific, so it can be run on any Apache project (while still accommodating HBase-specific features regarding how sub-projects are named and organized in Jira and release repos). In future I propose to take it further along that path, and move create-release into Yetus (recognizing that this create-release code has been passed between a couple other projects already). These changes have NO IMPACT on HBase functionality." Backport HBASE-24302 to branch-1,13304159,Resolved,Major,Fixed,11/May/20 16:21,12/May/20 16:05,1.4.13, [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP,13303160,Resolved,Major,Fixed,06/May/20 16:38,12/May/20 03:52,,Seen in local runs.... Move to hbase-thirdparty-3.3.0,13301809,Resolved,Major,Fixed,29/Apr/20 14:27,30/Apr/20 08:17,, Release hbase-thirdparty 3.3.0,13300411,Resolved,Major,Fixed,23/Apr/20 02:29,29/Apr/20 13:57,, Move hbase-filesystem to hbase-thirdparty-3.3.0,13304324,Resolved,Major,Duplicate,12/May/20 09:31,12/May/20 09:32,hbase-filesystem-1.0.0-alpha2, Add writable MinVersions and read-only Scan to coproc ScanOptions,13302732,Resolved,Major,Fixed,04/May/20 19:11,11/May/20 08:51,,"Between HBase 1.x and 2.0, the RegionObserver pre*ScannerOpen coprocessors were significantly changed so that the coproc implementer no longer has access to the actual Scanner, just a ScanOptions object that can be changed in limited ways. This is safer and prevents resource leaks and other bugs. While ScanOptions provides support for changing TTL, KeepDeletedCells, and MaxVersions, a fourth column family config parameter, MinVersions, appears to have been missed. This prevents coproc implementers from changing MinVersions dynamically. An example of this is PHOENIX-5645, which in the forthcoming Phoenix 4.16 (based on HBase 1.x) will allow users to configure a moving window where all versions are kept, and thus point-in-time queries are safe. This cannot be put in the forthcoming Phoenix 5.1 (based on HBase 2.1 and 2.2) because of the coproc changes. Relatedly, preStoreScannerOpen lacks access to the Scan in HBase 2.0 and up. This prevents coprocs from reading the Scan parameters to check if, for example, a Scan has set the max time to a point in the past, and thus needs to override KeepDeletedCells. This can lead to incorrect behavior when doing point-in-time queries or using transactional engines that treat physically committed HBase writes as logically uncommitted parts of a transaction. It's also a correctness problem for PHOENIX-5645. Please note that only _read-only_ access to the Scan from the store scanner coproc hook is in scope for this change. " [ACL] renameRSGroup should require Admin level permission,13303549,Resolved,Major,Fixed,08/May/20 05:54,11/May/20 06:56,,Currently renameRSgroup can be called by anyone without permission Separate a hbase-asyncfs module,13302426,Resolved,Major,Fixed,02/May/20 11:35,06/May/20 06:50,,To hold the async fs related class for WAL implementation as the hbase-server module is too big. [h3/jdk11] REST server won't start,13301808,Resolved,Major,Fixed,29/Apr/20 14:21,08/May/20 20:09,,"{code} 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080} Exception in thread ""main"" java.lang.NoSuchMethodError: 'java.util.Map javax.ws.rs.core.Application.getProperties()' at org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331) at org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392) at org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177) {code} Seems fine for hadoop2/jdk8. I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11. Fix coming..." [Flakey Test] TestJMXListener rmi port clash,13302942,Resolved,Major,Fixed,05/May/20 18:33,08/May/20 22:30,,The TestJMXListener can fail because the random port it wants to put the jmx listener on is occupied when it goes to run. Handle this case in test startup. [Flakey Tests] krb server for secure thrift tests throws BindException,13302477,Resolved,Major,Fixed,03/May/20 00:11,06/May/20 04:37,,"Thought I'd put all the BindExceptions in thrift to sleep but just came across this one putting up the *krb* server used by the secure thrift http tests. There are two tests that use krb: {code} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer ------------------------------------------------------------------------------- Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.042 s <<< FAILURE! - in org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer Time elapsed: 0.017 s <<< ERROR! org.apache.kerby.kerberos.kerb.KrbException: Failed to start KDC-Server at org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137) Caused by: java.net.BindException: Address already in use (Bind failed) at org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137) {code}" [flakey test] replication.TestAddToSerialReplicationPeer,13298198,Resolved,Major,Fixed,14/Apr/20 07:16,15/Apr/20 21:44,2.3.0,"From both 2.3 and branch-2 flaky test board, it constantly runs into the following flaky:   {code:java} org.apache.hadoop.hbase.replication.TestAddToSerialReplicationPeer.testAddToSerialPeerFailing for the past 1 build (Since #6069 )Took 15 sec.Error MessageSequence id go backwards from 122 to 24Stacktracejava.lang.AssertionError: Sequence id go backwards from 122 to 24 at org.apache.hadoop.hbase.replication.TestAddToSerialReplicationPeer.testAddToSerialPeer(TestAddToSerialReplicationPeer.java:176) Standard Output{code}" "Remove hedged rpc call support, implement the logic in MaterRegistry directly",13301094,Resolved,Major,Fixed,26/Apr/20 14:55,06/May/20 12:23,, [Flakey Tests] TestCloseRegionWhileRSCrash,13296235,Resolved,Major,Fixed,05/Apr/20 00:43,06/May/20 04:19,,TestCloseRegionWhileRSCrash is flakey because of HBASE-24117 -- because moved Region may not online in the end. Remove the last bit of the test... Undo core of parent TestSecureRESTServer change; use fix over in HBASE-24280 instead,13302359,Resolved,Major,Fixed,01/May/20 21:01,04/May/20 17:15,2.3.0,"Parent issue puts in a place that makes TestSecureRESTServer pass up on jenkins by shoving into the dependency list the jersey1 ServletContainer. Root issue was change in how we specified profiles in nightlies; both hadoop3 and hadoop2 were mistakenly active (HBASE-24280). This issue is about undoing the dependency insertion after fix for HBASE-24280 goes in. Don't want to revert the parent. It has cleanups that should stay." Remove hadoop-two-compat.xml in hbase-assembly,13302628,Resolved,Major,Fixed,04/May/20 12:27,05/May/20 11:50,,Missed this one. Add more details in MultiVersionConcurrencyControl STUCK log message,13302565,Resolved,Major,Fixed,04/May/20 04:46,05/May/20 11:48,,"Now the warn logs look like {code} STUCK: MultiVersionConcurrencyControl{readPoint=30944485, writePoint=30944498} {code} We don't have any details on which region the writes are stuck. It would be better to include the region name detail also in this log. May be we can even log for how long we are waiting for the read point to catch up. cc [~stack]" NPE from /procedures.jsp on backup master,13302767,Open,Major,,04/May/20 23:54,,2.3.0,"When going to {{/procedures.jsp}} on a backup master (i.e., a user hits refresh on a window they have open, meanwhile, the active master has flipped over), we throw an NPE back to the user. Instead, we should do practically anything else. {noformat} java.lang.NullPointerException at org.apache.hadoop.hbase.generated.master.procedures_jsp._jspService(procedures_jsp.java:63) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:840) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.apache.hadoop.hbase.http.SecurityHeadersFilter.doFilter(SecurityHeadersFilter.java:66) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:52) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1491) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.apache.hadoop.hbase.http.NoCacheFilter.doFilter(NoCacheFilter.java:50) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:548) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:226) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1180) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:513) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1112) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:119) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:134) at org.eclipse.jetty.server.Server.handle(Server.java:539) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:333) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:283) at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:108) at org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:93) at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.executeProduceConsume(ExecuteProduceConsume.java:303) at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceConsume(ExecuteProduceConsume.java:148) at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:136) at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:671) at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:589) at java.base/java.lang.Thread.run(Thread.java:834) {noformat}" Avoid two parallel running of GCMulitpleMergedRegionsProcedure over the same region.,13302766,Resolved,Major,Duplicate,04/May/20 23:37,05/May/20 23:16,2.3.0,"As [~stack] suggested in one of PRs, ""This method is called from GCMergedRegionsProcedure and GCMulitpleMergedRegionsProcedure. I was wondering if we took a lock on the Region being Merged would it stop two overlapping GCs happening?""" [fakey test] TestInfoServersACL testJmxAvailableForAdmin,13302903,Open,Major,,05/May/20 15:34,,2.3.0,"There was a failure on branch-2.3 last night, https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/65/testReport/ This test failed for JDK11 but not JDK8. Before the failed assertion, I do see a log from the loop on line 312: {noformat} 2020-05-05 10:57:45,323 INFO [Time-limited test] http.TestInfoServersACL$11(312): Hadoop:service=HBase,name=StartupProgress {noformat} This indicates to me that the HBase portion of the process hadn't finished coming online yet, and so the precondition was not yet satisfied. Just speculation though; I don't understand why the same bean wouldn't be available to the admin user as well. Furthermore, looks like the test does not clean up after itself correctly. On retry, the subsequent attempt flat-out failed with {noformat} Failed to load or create keytab /home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.3/component/hbase-server/target/test-data/f2e84dcf-0d1f-fe85-3519-4fcb37058d39/keytab org.apache.kerby.kerberos.kerb.KrbException: Failed to load or create keytab /home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2.3/component/hbase-server/target/test-data/f2e84dcf-0d1f-fe85-3519-4fcb37058d39/keytab at org.apache.hadoop.hbase.http.TestInfoServersACL.beforeClass(TestInfoServersACL.java:114) Caused by: java.io.IOException: No such file or directory at org.apache.hadoop.hbase.http.TestInfoServersACL.beforeClass(TestInfoServersACL.java:114) {noformat}" Clearly document how profiles for the sake of Hadoop compatibility work across all branches,13302712,Open,Major,,04/May/20 17:42,,,"In HBASE-24280, we investigated a test failure which was ultimately caused by the simultaneous activation of the (intended mutually exclusive) hadoop-2 and hadoop-3 profiles. After master has moved to only supporting profile activation via the profile itself (rather than a system property) with the removal of the hadoop-2 profile, the build was inadvertently broken as all branches (or is it just 2.x branches and master?) use the one build/yetus scripts in dev-support. To make sure that these scripts continue to work against all branches, we need to have a clear decision on how profile activation is expected to work in our HBase build. Otherwise, we'll come back to this problem where each branch does things ever-so-slightly different, requiring a bunch of {{if branch-2; else if branch-2.2; else if branch-2.3}} type changes to our yetus scripts." check-aggregate-license on hbase-shaded-client-byo-hadoop is not compatible with `--threads`,13302718,Open,Major,,04/May/20 18:09,,2.3.0,"I see occasional failures in this enforcer rule when running maven with {{-T1.0C}}. Usually it succeeds when building again. Looks related to the bean shell script that loops over license files. I have been using {{mvn -U -T1.0C clean install -DskipTests}} for both JDK8 and JDK11." Configuring HBase to Use HDFS HA,13302299,Resolved,Major,Invalid,01/May/20 12:20,04/May/20 13:52,2.2.4,"Problem: HMasters fail to start. Solution: Check for this error in the HMaster log: 2020-05-01 19:30:13,125 ERROR [main] regionserver.HRegionServer: Failed construction RegionServer java.lang.IllegalArgumentException: java.net.UnknownHostException: hdfscluster     Hadoop's hdfs-site.xml and core-site.xml files are in your hbase/conf directory" Move hbase-rsgroup code into hbase-server code,13302492,Resolved,Major,Won't Do,03/May/20 08:11,04/May/20 10:16,2.2.3,"Keeping rsgroup code into separate module is causing many problem. HBASE-22740 and HBASE-24212 are blocked because of this. In master branch hbase-rsgroup code is already moved into hbase-server. It is better to be in sync with master branch so issue fixes can be applied on branch-2 easily. This jira moves hbase-rsgroup code into hbase-server as it is, does not make change in protobuff etc. " Document of Hbase on Aarch64,13301136,Resolved,Major,Fixed,27/Apr/20 01:35,01/May/20 23:01,,Provide documentation on how to run hbase on aarch64 architecture. Allow admin user to create table and do bulkLoad,13301970,Resolved,Major,Fixed,30/Apr/20 03:51,01/May/20 19:00,2.2.2,Allow admin users who don't have CREATE privileges to create tables and do bulkload. TestZooKeeper is flaky,13301602,Resolved,Major,Fixed,28/Apr/20 16:01,02/May/20 14:12,,"After checking the code, the problem is that, when creating table during master shutdown, it is easy to hit MasterStoppedException or other strange exceptions which make the creation fail. In general I think this should be a test issue, need to learn why we do not have the problem on branch-2.x." [Flakey Tests] TestThriftHttpServer BindException,13302216,Resolved,Major,Fixed,30/Apr/20 21:32,01/May/20 15:41,,"Came across this last night: {code} Expected: (an instance of org.apache.thrift.transport.TTransportException and exception with message a string containing ""HTTP Response code: 431"") but: an instance of org.apache.thrift.transport.TTransportException is a java.lang.Exception Stacktrace was: java.lang.Exception: java.net.BindException: Address already in use at org.apache.hadoop.hbase.thrift.TestThriftHttpServer.stopHttpServerThread(TestThriftHttpServer.java:253) at org.apache.hadoop.hbase.thrift.TestThriftHttpServer.runThriftServer(TestThriftHttpServer.java:183) at org.apache.hadoop.hbase.thrift.TestThriftHttpServer.testRunThriftServerWithHeaderBufferLength(TestThriftHttpServer.java:147) {code} " [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate,13299426,Resolved,Major,Fixed,19/Apr/20 03:32,29/Apr/20 14:56,,"Happened in two builds... 2.3 and 2: jdk8 hadoop3 nightly just now https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2.3/44/ {code} [ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed: 0.01 s <<< ERROR! java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202) Caused by: java.lang.ClassNotFoundException: com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202) {code} Then again in branch2 https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2/2619/ {code} [ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed: 0.017 s <<< ERROR! java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202) Caused by: java.lang.ClassNotFoundException: com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202) {code} " Failed multi-merge because two regions not adjacent (legitimately).,13300656,Resolved,Major,Fixed,23/Apr/20 21:05,29/Apr/20 21:40,,"Below is a multi-merge created by FixMeta provoked by 'hbck2 fixMeta'. The merge is legitimate in that indeed all Regions overlap. The merge is cutoff off at the current max of 10 Regions-at-a-time (which is another issue). The merge fails though because two Regions in the Set of Regions to merge are not adjacent when we do our pre-flight check. We could 'force' the merge but better if the 'check' is improved. {code} 2020-04-22 22:04:57,048 WARN org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure: Unable to merge non-adjacent or non-overlapping regions 50b9f911320f64d0ab54a7606a6cdb77, 15877a8df3987176b12a2e2c4712c95f when force=false 2020-04-22 22:04:57,048 WARN org.apache.hadoop.hbase.master.MetaFixer: Failed overlap fix of [{ENCODED => 6f880442573f4ca0c2536ce2352e4883, NAME => 'X,,1567882650838.6f880442573f4ca0c2536ce2352e4883.', STARTKEY => '', ENDKEY => '\x01\x02\x05\x01\x03\x02\x01\x01\x01\x01\x02201908310200\x00\x00\x048.1-11B117\x00\x00\x00\x00\x00\x00iPad4,1\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'}, {ENCODED => 98af7f02916e014c07ac099724c7ffaf, NAME => 'X,\x01\x01\x05\x01\x01,1558718898305.98af7f02916e014c07ac099724c7ffaf.', STARTKEY => '\x01\x01\x05\x01\x01', ENDKEY => '\x01\x01\x05\x01\x02'}, {ENCODED => d1a0b8772432c1148cdf7a8fad8e770c, NAME => 'X,\x01\x01\x05\x01\x02,1558718898305.d1a0b8772432c1148cdf7a8fad8e770c.', STARTKEY => '\x01\x01\x05\x01\x02', ENDKEY => '\x01\x01\x05\x01\x03'}, {ENCODED => 99738e58d057dafb861116a3efcb0285, NAME => 'X,\x01\x01\x05\x01\x03,1558718898305.99738e58d057dafb861116a3efcb0285.', STARTKEY => '\x01\x01\x05\x01\x03', ENDKEY => '\x01\x01\x05\x02\x01'}, {ENCODED => 50b9f911320f64d0ab54a7606a6cdb77, NAME => 'X,\x01\x01\x05\x02\x01,1558718898305.50b9f911320f64d0ab54a7606a6cdb77.', STARTKEY => '\x01\x01\x05\x02\x01', ENDKEY => '\x01\x01\x05\x02\x02'}, {ENCODED => 15877a8df3987176b12a2e2c4712c95f, NAME => 'X,\x01\x01\x05\x02\x03,1558718898305.15877a8df3987176b12a2e2c4712c95f.', STARTKEY => '\x01\x01\x05\x02\x03', ENDKEY => '\x01\x01\x06\x01\x01'}, {ENCODED => d5f0929fffbaec29ca99d4d0cd90c491, NAME => 'X,\x01\x01\x06\x01\x01,1558718898305.d5f0929fffbaec29ca99d4d0cd90c491.', STARTKEY => '\x01\x01\x06\x01\x01', ENDKEY => '\x01\x01\x06\x01\x02'}, {ENCODED => 8d72ed0d1d635511a323abef7026ec4f, NAME => 'X,\x01\x01\x06\x01\x03,1558718898305.8d72ed0d1d635511a323abef7026ec4f.', STARTKEY => '\x01\x01\x06\x01\x03', ENDKEY => '\x01\x01\x06\x02\x01'}, {ENCODED => 977f5a0e2f77a91531000d358f9a8eba, NAME => 'X,\x01\x01\x06\x02\x01,1558718898305.977f5a0e2f77a91531000d358f9a8eba.', STARTKEY => '\x01\x01\x06\x02\x01', ENDKEY => '\x01\x01\x06\x02\x02'}, {ENCODED => 21cdc09d13ae1ecefc6531786229f2ec, NAME => 'X,\x01\x01\x06\x02\x03,1558718898305.21cdc09d13ae1ecefc6531786229f2ec.', STARTKEY => '\x01\x01\x06\x02\x03', ENDKEY => '\x01\x01\x07\x01\x01'}] org.apache.hadoop.hbase.exceptions.MergeRegionException: Unable to merge non-adjacent or non-overlapping regions 50b9f911320f64d0ab54a7606a6cdb77, 15877a8df3987176b12a2e2c4712c95f when force=false at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.checkRegionsToMerge(MergeTableRegionsProcedure.java:140) at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.(MergeTableRegionsProcedure.java:105) at org.apache.hadoop.hbase.master.HMaster$2.run(HMaster.java:1961) at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134) at org.apache.hadoop.hbase.master.HMaster.mergeRegions(HMaster.java:1955) at org.apache.hadoop.hbase.master.MetaFixer.fixOverlaps(MetaFixer.java:221) at org.apache.hadoop.hbase.master.MetaFixer.fix(MetaFixer.java:77) at org.apache.hadoop.hbase.master.MasterRpcServices.fixMeta(MasterRpcServices.java:2649) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$HbckService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:388) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code}" `RESTApiClusterManager` attempts to deserialize response using serialization API,13301418,Resolved,Major,Fixed,28/Apr/20 00:27,29/Apr/20 20:22,2.2.4,"I'm not sure if this class ever worked, or if Gson changed their API behavior and we never noticed. The fix is quite simple, to use the streaming {{JsonParser}} API instead of the higher-level object API. However, testing this means standing up a web service that mocks Cloudera Manager response bodies." Remove some stale hadoop.version properties in the pom for sub modules,13301722,Resolved,Major,Fixed,29/Apr/20 07:01,29/Apr/20 10:28,,"For example in hbase-client/pom.xml, we have this in the hadoop-3.0 profile {code} 3.0-SNAPSHOT {code} Which is useless and confusing. Let's purge them." TestDelegationToken is broken,13301011,Resolved,Major,Fixed,26/Apr/20 02:06,27/Apr/20 01:34,,"After reverting HBASE-23881, it is fine." Move code in FSHDFSUtils to FSUtils and mark related classes as final,13300701,Resolved,Major,Fixed,24/Apr/20 03:45,29/Apr/20 03:42,,"It is a bit strange that a 'util' class can be instantiated. I think the motivation is to provide multiple recoverFileLease implementation based on different filesystem implementation. But until now, there is still only one implementation for HDFS in HBase, and all the related classes are marked as IA.Private so we do not expect user to extend the class. Let's just move the code in FSHDFSUtils to FSUtils directly and make FSUtils a true 'util' class." Exclude jsr311-api from classpath,13300841,Resolved,Major,Won't Fix,24/Apr/20 17:05,29/Apr/20 18:25,2.3.0,"When building on Hadoop3, we get two incompatible version of java-ws rs on the class path, both 1.1.1 and 2.0.1. These cause conflicts when running chaos monkey and integration test tools. {noformat} [INFO] | | +- org.apache.hadoop:hadoop-yarn-server-timelineservice:jar:3.1.2:test [INFO] | | | +- org.apache.commons:commons-csv:jar:1.0:test [INFO] | | | \- javax.ws.rs:jsr311-api:jar:1.1.1:test {noformat} {noformat} [INFO] org.apache.hbase:hbase-http:jar:2.3.0-SNAPSHOT [INFO] +- javax.ws.rs:javax.ws.rs-api:jar:2.0.1:compile {noformat} Problem looks like {noformat} 20/04/23 15:36:04 INFO hbase.RESTApiClusterManager: Executing GET against ... Exception in thread ""ChaosMonkey"" java.lang.NoSuchMethodError: 'void javax.ws.rs.core.MultivaluedMap.addAll(java.lang.Object, java.lang.Object[])' at org.glassfish.jersey.client.ClientRequest.accept(ClientRequest.java:336) at org.glassfish.jersey.client.JerseyWebTarget.request(JerseyWebTarget.java:221) at org.glassfish.jersey.client.JerseyWebTarget.request(JerseyWebTarget.java:59) at org.apache.hadoop.hbase.RESTApiClusterManager.getJsonNodeFromURIGet(RESTApiClusterManager.java:244) {noformat}" "TestExportSnapshotWithTemporaryDirectory fails with ""No such file or directory""",13301873,Resolved,Major,Duplicate,29/Apr/20 17:34,29/Apr/20 18:23,2.3.0,"Running tests locally last night, I get this failure. {noformat} org.apache.hadoop.yarn.exceptions.YarnRuntimeException: org.apache.hadoop.service.ServiceStateException: ExitCodeException exitCode=1: chmod: /private/tmp/hadoop-yarn-ndimiduk/node-attribute/nodeattribute.mirror.writing: No such file or directory at org.apache.hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory.setUpBeforeClass(TestExportSnapshotWithTemporaryDirectory.java:43) Caused by: org.apache.hadoop.service.ServiceStateException: ExitCodeException exitCode=1: chmod: /private/tmp/hadoop-yarn-ndimiduk/node-attribute/nodeattribute.mirror.writing: No such file or directory at org.apache.hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory.setUpBeforeClass(TestExportSnapshotWithTemporaryDirectory.java:43) Caused by: org.apache.hadoop.util.Shell$ExitCodeException: chmod: /private/tmp/hadoop-yarn-ndimiduk/node-attribute/nodeattribute.mirror.writing: No such file or directory at org.apache.hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory.setUpBeforeClass(TestExportSnapshotWithTemporaryDirectory.java:43) {noformat}" Merge the code in hbase-hadoop2-compat module to hbase-hadoop-compat,13300128,Resolved,Major,Fixed,22/Apr/20 01:46,29/Apr/20 02:37,,"As now we only depend on hadoop3 and the compatible issues are mostly resolved by reflection, no need to maintain a hadoop2-compat module any more." Add limit support for scan in rest api,13301175,Resolved,Major,Fixed,27/Apr/20 07:08,28/Apr/20 09:18,3.0.0-alpha-1,"rest scan api currently does not support limit.  " The -Phadoop-3.0 option does not work on branch-2 and branch-2.3 with JDK11,13299924,Resolved,Major,Fixed,21/Apr/20 09:07,23/Apr/20 02:33,,"Because we have an enforcer rule which requires the hadoop.profile property to be set to 3.0. I tried to use requireActiveProfile but it failed when building hbase-annotations as in the pom of the module we do not declare a hadoop-3.0 profile(since it does not depend on hadoop...). So we need to find another trick solution." "Backport ""Implement proxyuser/doAs mechanism for hbase-http"" to 2.1.x",13301372,Resolved,Major,Won't Fix,27/Apr/20 19:13,28/Apr/20 15:17,,"Could you make the modification to your change for branch-2.1 please, [~stoty]? If not, let me know and I'll dig in and fix it." [JDK11] Switch default garbage collector from CMS,13297181,Resolved,Major,Fixed,08/Apr/20 18:36,27/Apr/20 16:39,2.3.0,"When running HBase tools on the cli, one of the warnings generated is {noformat} OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release. {noformat} Java9+ use G1GC as the default collector. Maybe we simply omit GC configurations and use the default settings? Or someone has some suggested settings we can ship out of the box?" Disable TestNettyIPC.testHedgedAsyncEcho,13301093,Resolved,Major,Fixed,26/Apr/20 14:50,27/Apr/20 01:45,,"It is flaky and cause the flaky job time out. Disable it for now, and re-enable it in the sub task." Use `set -e` in our bin scripts,13301336,Open,Major,,27/Apr/20 16:26,,,"We don't {{set -e}} in our bin scripts anywhere, as far as I can tell. We can have an error, of our own making, or a user's setting in {{conf}}, and our scripts proceed as if all is right in the world." remove FSUtils.checkAccess and replace with FileSystem.access in HBCK,13299899,Resolved,Major,Fixed,21/Apr/20 07:41,24/Apr/20 03:30,,"since hadoop2.6.0, we can check if a user has certain permissions on a file  using FileSystem.access https://issues.apache.org/jira/browse/HDFS-6570" HBASE-Find-Flaky-Tests job is failing because of can not build docker image,13300743,Resolved,Major,Fixed,24/Apr/20 08:44,24/Apr/20 11:49,,"{noformat} 06:30:14 Step 3/4 : RUN DEBIAN_FRONTEND=noninteractive apt-get -qq -y update && DEBIAN_FRONTEND=noninteractive apt-get -qq -y install --no-install-recommends curl=7.58.0-2ubuntu3.8 python2.7=2.7.17-1~18.04 python-pip=9.0.1-2.3~ubuntu1.18.04.1 python-setuptools=39.0.1-2 && apt-get clean && rm -rf /var/lib/apt/lists/* 06:30:14 ---> Running in 484963d42320 06:30:23 E: Version '2.7.17-1~18.04' for 'python2.7' was not found 06:30:23 The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive apt-get -qq -y update && DEBIAN_FRONTEND=noninteractive apt-get -qq -y install --no-install-recommends curl=7.58.0-2ubuntu3.8 python2.7=2.7.17-1~18.04 python-pip=9.0.1-2.3~ubuntu1.18.04.1 python-setuptools=39.0.1-2 && apt-get clean && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100 {noformat}" PreCommit build is failing because of can not build docker image,13300722,Resolved,Major,Fixed,24/Apr/20 06:33,24/Apr/20 12:02,,"{noformat} 06:29:35 Failed in branch yetus general check 06:29:36 + '[' -f /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1574@2/yetus-jdk8-hadoop3-check/output/pidfile.txt ']' 06:29:36 + '[' -f /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1574@2/yetus-jdk8-hadoop3-check/output/cidfile.txt ']' 06:29:36 + chmod -R u+rxw /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1574@2 [Pipeline] dir 06:29:36 Running in /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1574@2/yetus-jdk8-hadoop3-check [Pipeline] { [Pipeline] deleteDir 06:29:36 E: Version '1:2.17.1-1ubuntu0.6' for 'git' was not found {noformat}" [thirdparty] Update Protobuf to 3.11.4,13300858,Resolved,Major,Fixed,24/Apr/20 18:20,24/Apr/20 18:33,, Bump netty version to 4.1.48.Final,13297230,Resolved,Major,Fixed,08/Apr/20 22:56,17/Apr/20 17:46,thirdparty-3.2.0,There is a new netty version to fix some bugs. Update openjdk-8-jdk version in create-release,13300797,Resolved,Major,Fixed,24/Apr/20 12:37,24/Apr/20 16:02,3.0.0-alpha-1,"The create-release script fails with missing openjdk-8-jdk package. It needs to be updated to openjdk-8-jdk=8u252-b09-1~18.04 version." [Flakey Tests] TestSecureExportSnapshot FileNotFoundException,13297792,Resolved,Major,Fixed,11/Apr/20 18:01,21/Apr/20 16:44,,"Why we writing '/tmp' dir? {code} Error Message org.apache.hadoop.service.ServiceStateException: java.io.FileNotFoundException: File file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing does not exist Stacktrace org.apache.hadoop.yarn.exceptions.YarnRuntimeException: org.apache.hadoop.service.ServiceStateException: java.io.FileNotFoundException: File file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing does not exist at org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56) Caused by: org.apache.hadoop.service.ServiceStateException: java.io.FileNotFoundException: File file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing does not exist at org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56) Caused by: java.io.FileNotFoundException: File file:/tmp/hadoop-yarn-jenkins/node-attribute/nodeattribute.mirror.writing does not exist at org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56) {code}" Remove hadoop-2.0 profile,13297743,Resolved,Major,Fixed,11/Apr/20 06:19,16/Apr/20 11:10,, Avoid redundant connection creation during Quota operation,13299786,Open,Major,,20/Apr/20 19:20,,,"QuotaRetriever.init() create a managed connection with the given configuration for each operation, which can be avoided by reusing existing connection." Add hadoop 3.2.x in hadoop check,13299552,Resolved,Major,Fixed,20/Apr/20 01:43,22/Apr/20 03:00,, [Build] Pin rubocop version <= 0.81,13300136,Resolved,Major,Fixed,22/Apr/20 02:45,22/Apr/20 05:06,1.4.13,"rubocop 0.82 has been released, which drops Ruby 2.3 support. We are still using Ruby 2.3 in the Docker, and the docker build will fail (at least in branch-1). Similar to AVRO-2807" [Shell] Add rename rsgroup command in hbase shell,13298535,Resolved,Major,Fixed,15/Apr/20 11:28,22/Apr/20 06:25,,HBASE-24112 supports renaming rsgroup. So here we add shell command support. Client getting stuck infinitely while connecting to thrift2 server in Secure mode,13300157,Open,Major,,22/Apr/20 05:37,,2.2.3,"Tried connecting thrift2 server to test PUT operation from a secure client to 1.3.x server . It works fine , But when same operation is performed in 2.2.3 server, client is getting stuck infinitely. it's unable to connect to server . Exception in thread ""main"" java.security.PrivilegedActionException: org.apache.thrift.transport.TTransportException: java.net.SocketTimeoutException: Read timed out at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.hbase.thrift2.GitDemoClient.main(GitDemoClient.java:80) Caused by: org.apache.thrift.transport.TTransportException: java.net.SocketTimeoutException: Read timed out at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:129) at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86) at org.apache.thrift.transport.TSaslTransport.receiveSaslMessage(TSaslTransport.java:178) at org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:277) at org.apache.thrift.transport.TSaslClientTransport.open(TSaslClientTransport.java:38) at org.apache.hadoop.hbase.thrift2.GitDemoClient.run(GitDemoClient.java:117) at org.apache.hadoop.hbase.thrift2.GitDemoClient$1.run(GitDemoClient.java:84) at org.apache.hadoop.hbase.thrift2.GitDemoClient$1.run(GitDemoClient.java:1) ... 3 more Caused by: java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.socketRead(SocketInputStream.java:116) at java.net.SocketInputStream.read(SocketInputStream.java:171) at java.net.SocketInputStream.read(SocketInputStream.java:141) at java.io.BufferedInputStream.fill(BufferedInputStream.java:246) at java.io.BufferedInputStream.read1(BufferedInputStream.java:286) at java.io.BufferedInputStream.read(BufferedInputStream.java:345) at org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:127) ... 10 more Getting above exception when timeout has been set at client side. *References* https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift2/DemoClient.java https://hbase.apache.org/book.html#hbase.secure.configuration (section 60.4) Client-side Configuration for Secure operation- Thrift Gateway " Allow that zk NOTEMPTY multi exception is retryable by running in-series,13299825,Resolved,Major,Fixed,20/Apr/20 22:42,20/Apr/20 23:01,,"It looks like our zk behavior changed slightly on upgrade. In tests on occasion, I see a fail because the zk delete of dir fails because dir is not empty. Or, this flakey type we just ignored in the past (its rare enough -- I'm just seeing it of late because I'm running tests back-to-back on 4 different hardwares). Let me try allowing NOTEMPTY as a retryable. Lets see how it does. Threw in some debug while at it for other issues I've seen in test." [Flakey Tests] Thrift tests (TestThrift?ServerCmdLine),13296560,Open,Major,,06/Apr/20 16:19,,,"TestThrift2ServerCmdLine and TestThriftServerCmdLine are flakey. They fail frequently in local runs for myriad reasons: protocol failures, wrong answers on query, connection resets, etc. Each test runs 40 different combinations of config. This is after work done to try and stabilize by fixing port clash issues. Let me list in here the ways in which it fails. I will disable after I get a good list. Will also try and do some more stabilization too in sub-issues. Lets see which prevails; stabilization or disabling. For starters, this morning I got this: {code} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine ------------------------------------------------------------------------------- Tests run: 32, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 126.301 s <<< FAILURE! - in org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.testRunThriftServer[29] Time elapsed: 0.964 s <<< ERROR! java.lang.Exception: org.apache.thrift.transport.TTransportException: java.net.SocketException: Connection reset at org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92) Caused by: java.net.SocketException: Connection reset at org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92) {code} " Fix findbugs warning on ServiceAuthorizationManager,13297781,Resolved,Major,Fixed,11/Apr/20 15:24,18/Apr/20 06:00,,"Inconsistent synchronization of org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time. It is introduced by HBASE-24121, let me fix it. It haven't got released yet. Looks affect branch-1 so far." Upgrade Thrift to 0.13.0: 0.12.0 has outstanding CVEs.,13297226,Resolved,Major,Fixed,08/Apr/20 22:02,17/Apr/20 19:13,3.0.0-alpha-1,"In Apache Thrift all versions up to and including 0.12.0, a server or client may run into an endless loop when feed with specific input data. Because the issue had already been partially fixed in version 0.11.0, depending on the installed version it affects only certain language bindings. To be on the safe side, we could update to 0.13.0." PR Hanger. Ignore,13298327,Resolved,Major,Won't Fix,14/Apr/20 16:06,17/Apr/20 19:02,, HRegion#processRowsWithLocks count memstore size wrong when sync failed,13298432,Resolved,Major,Fixed,15/Apr/20 02:23,16/Apr/20 08:34,1.7.0,"HRegion#processRowsWithLocks when wal sync failed, it will roll back the memstore in Store and reduce the size in DefaultMemStore, but still add memStoreSize to HRegion#memstoreSize. And this only affect branch-1 verions, not apply to master/branch-2." [Flakey Tests] TestAsyncTableGetMultiThreaded,13297452,Resolved,Major,Fixed,09/Apr/20 17:56,16/Apr/20 15:08,,"I've already cut down the number of threads used by this test but it failed in nightly last night unable to close out its xml and locally it failed too in a run overnight. I ran it under harness and it seems well-behaved. It doesn't use much memory -- 700MB -- and thread counts are usual (~450). It does use near 100% CPU which is a little unusual. Otherwise, looks fine. Let me keep an eye on it. Could down the thread count more and use less processes... this makes it use less CPU. There does seems a bunch of overlap with tests done elsewhere." Nightly CI's USE_YETUS_PRERELEASE feature is broken,13298912,Open,Major,,16/Apr/20 22:29,,,"I tried kicking off a [build|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1701/pipeline/] with the latest Yetus today, only to find {noformat} [2020-04-16T20:54:09.742Z] bash: /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/yetus-git/precommit/test-patch.sh: No such file or directory {noformat} Looks like we don't adjust the path to test-patch.sh based on working from a source tarball vs. a release tarball." Admin.getRegionServers() should return live servers excluding decom RS optionally,13298527,Resolved,Major,Fixed,15/Apr/20 10:34,16/Apr/20 15:01,,Admin.getRegionServers() returns all live RS of the cluster. It should consider optionally excluding decommissioned RS for operators to get live non-decommissioned RS list from single API. [RSGroup] Support renaming rsgroup,13296064,Resolved,Major,Fixed,03/Apr/20 16:23,15/Apr/20 11:27,,"Rsgroup name once is decided at the beginning, it is difficult to rename it. Current approach is removing all tables and servers back to default rsgroup, then delete it and add a rsgroup with the new name, after that moving regions and servers back. Or without moving back, if machine resources is ample. Anyway, it is an expensive operation: moving regions, breaking region's locality. And given that rsgroup is one kind of managements in cluster, and management sometimes changes, renaming is necessary. It is simple in implementation. I'm working on it." Edit test doc around forkcount and speeding up test runs,13298178,Resolved,Major,Fixed,14/Apr/20 04:30,14/Apr/20 18:33,,"Give the 'Running unit tests' section an edit. Fold in findings of late around how to speed up tests, hardware limits and sizings, etc." Let ChaosMonkeyRunner expose the chaos monkey runner it creates for branch-1,13298517,Open,Major,,15/Apr/20 09:28,,, [Flakey Tests] TestHRegionWithInMemoryFlush#testWritesWhileScanning gets stuck MVCC,13297723,Resolved,Major,Fixed,11/Apr/20 01:12,13/Apr/20 18:46,,"I see this in recent nightly fails on branch-2, my experimental branch. It happened in the two builds last night. It was only test to fail. Both failed with: 2020-04-10 07:42:46,700 WARN [Time-limited test] regionserver.MultiVersionConcurrencyControl(228): STUCK: MultiVersionConcurrencyControl{readPoint=8684, writePoint=8686} I ran the test in my harness and it pushes up against heap limits for sure, especially after recent cut down in forked jvm size. For now, see if alleviating scope of testWritesWhileScanning just when called from this test helps w/ flakeyness. Probably worth a deep dive why we get into this state w/ in-memory compaction." Document usage of hbase.regionserver.fair.region.close.lock,13298310,Open,Major,,14/Apr/20 15:12,,, Down forked JVM heap size from 2800m to 2200m for jdk8 and jdk11,13296892,Resolved,Major,Fixed,07/Apr/20 18:34,14/Apr/20 04:38,,"Docker container we run tests in is hardcoded 20G. Our fork count is 0.25C currently. The jenkins machines are 16CPUs. 0.25C means 4CPUs so 4 forks running at any one time. Our current forked JVM heap size is 2800m if jdk8 or 3200m if jdk11. If we want to move our fork count to 0.5C, then that means 8 forks possibly running at once: i.e. 8 * 2800 = 22.4G... i.e. too big for the container. This issue is about running w/ smaller forked jvm heap size. If 2200m then, its 19.6G which is cutting it close but might allow us sqeeze through (mvn takes 4G!). Lets see." Move CandidateGenerator out of StochasticLoadBalancer,13297113,Resolved,Major,Fixed,08/Apr/20 15:34,12/Apr/20 14:43,,StochasticLoadBalancer is very huge as of today. We should move CandidateGenerator and their big implementors out of it and keep them accessible to master.balancer package. Align the internal.protobuf.version in hbase-protocol-shaded with hbase-thirdparty,13297728,Resolved,Major,Fixed,11/Apr/20 02:42,13/Apr/20 00:50,,"The hbase-thirdparty-3.2.0 has already bumped the protobuf version to 3.11.4 but in hbase-protocol-shaded we still use 3.5.1-1. It has already been done in HBASE-24119 for master branch, let's also do this on branch-2 and branch-2.3." some tests of org.apache.hadoop.hbase.TestZooKeeper.* failed on aarch64,13297997,Open,Major,,13/Apr/20 10:13,,,"I build and test Hbase on aarch64, and tests org.apache.hadoop.hbase.TestZooKeeper.testMasterZKSessionRecoveryFailure and testMasterSessionExpired failed by chance. I found ARM CI in jenkins failed by chance too https://builds.apache.org/view/H-L/view/HBase/job/HBase-Nightly-ARM/73/testReport/junit/org.apache.hadoop.hbase/TestZooKeeper/testMasterZKSessionRecoveryFailure/, see: {quote}Error Message Unable to instantiate exception received from server:org.apache.hadoop.hbase.master.HMaster$MasterStoppedException.(java.lang.String) Stacktrace org.apache.hadoop.hbase.DoNotRetryIOException: Unable to instantiate exception received from server:org.apache.hadoop.hbase.master.HMaster$MasterStoppedException.(java.lang.String) at org.apache.hadoop.hbase.TestZooKeeper.testSanity(TestZooKeeper.java:153) at org.apache.hadoop.hbase.TestZooKeeper.testMasterZKSessionRecoveryFailure(TestZooKeeper.java:140) Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException: org.apache.hadoop.hbase.master.HMaster$MasterStoppedException at org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:2932) at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2135) at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:716) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:400) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318){quote} It looks like the master is still stopped when we want to create table after stop it. I made thread to sleep 1 second in testSanity function before calling admin.createTable(desc), then I run the tests for more than 10 times and the tests are success: ************************************************************************** {quote}private void testSanity(final String testName) throws Exception { String tableName = testName + ""_"" + System.currentTimeMillis(); TableDescriptor desc = TableDescriptorBuilder.newBuilder(TableName.valueOf(tableName)) .setColumnFamily(ColumnFamilyDescriptorBuilder.of(""fam"")).build(); {color:#DE350B}Thread.sleep(1000);{color} LOG.info(""Creating table "" + tableName); Admin admin = TEST_UTIL.getAdmin(); try { admin.createTable(desc); } finally { admin.close(); }{quote} **************************************************************************" "Move CHANGES.txt to CHANGES.md. Add RELEASENOTES.md too on branch-2, branch-2.3, and master",13297512,Resolved,Major,Fixed,10/Apr/20 00:14,10/Apr/20 21:44,,"Way back on HBASE-18828 for release 2.0.0 we moved to use releasemaker from yetus for generating changes/releasenotes. At that time we moved to *.md files instead of *.txt for CHANGES. Let me make the change on branch-2.3, branch-2 and master, the remaining outposts for *.txt files. Doing it because it confused a coworker (why wouldn't it?)." [Authorization] ServiceAuthorizationManager isn't dynamically updatable. And it should be.,13296454,Resolved,Major,Fixed,06/Apr/20 08:42,09/Apr/20 10:03,,"Some more background information. ServiceAuthorizationManager is responsible for the Services access rights defined in hbase-policy.xml which locates under $hbase_home/conf directory. Currently, since it doesn't support update dynamically, we need to restart master/regionservers to make configurations take effect. It is an expensive and low efficient admin operation. HDFS has the refreshPolicy to do that, HBase also has update_config command, we can make use of that." Make ZK registry the default for branch-2 and branch-2.3,13297438,Resolved,Major,Fixed,09/Apr/20 16:57,09/Apr/20 23:15,2.3.0,"This is already the case due to [this commit|https://github.com/apache/hbase/commit/558ee079fd04dfab8e61eca10ee98ab5bac89dfa], however it wasn't tagged with a jira ID. I'm creating a new jira so that I can revert and re-apply this commit with this jira ID. Easier to track fix versions this way." [Flakey Tests] Add adjunct Mob and Security ExportSnapshot unit tests that subclass TestExportSnapshotAdjunct,13297165,Open,Major,,08/Apr/20 18:08,,,"The parent issue moved a few tests out of the TestExportSnapshot suite so it would complete in less time. TES has a few subclassers that run the TES suite but with adornments (MOB, Security). With the parent move of a few methods to an adjunct, we should add adjuncts for the subclassers too. I was thinking the moved methods don't need MOB exercising. Security maybe. Probably best if we add the coverage. Suggested by our [~psomogyi]" [Flakey Tests] Add retry on thrift cmdline if client fails plus misc debug,13296673,Resolved,Major,Fixed,06/Apr/20 22:37,07/Apr/20 16:31,," {code} hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java Saw case where Master failed startup because of BindException but it came out wrapped in an IOE so we did not trip the BindException retry logic. Make the catch more general. hbase-server/src/test/java/org/apache/hadoop/hbase/TestInfoServers.java Add some debug and up timeouts. This test fails frequently for me locally. hbase-server/src/test/java/org/apache/hadoop/hbase/client/locking/TestEntityLocks.java Up the wait from 2x 200ms to 10x in case a pause on hardware or GC. This test fails locally and up on jenkins. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClearRegionBlockCache.java Debug. Have assert say what bad count was. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingToCellFlatMapMemStore.java Fails on occasion. Found count is off by a few. Tricky to debug. Adding sub-issue to reenable. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java Debug. Add wait and check before moving to assert. hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java Check for null before shutting; can be null if failed start. hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java Add retry if client messes up connection. Fails for me locally. {code}" [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot,13295413,Resolved,Major,Fixed,01/Apr/20 04:19,01/Apr/20 15:39,,"Fails on occasion, 15% of the time according to flakie report. I can reproduce it failing locally. A single method fails. I don't follow how it is supposed to work (what looks wrong to me passes...). I noticed that if I ran testRestoreSnapshot on its own, it passed but failed when run as part of the test suite so I broke it out into its own suite. Now both old and new suites pass for me locally after 20 repeats. Let me push it up. " [Flakey Tests] Add test to check we work properly when port clash setting up thriftserver,13295608,Resolved,Major,Fixed,01/Apr/20 19:20,01/Apr/20 19:26,,My hack to add retry when thrift setup has a port clash over in HBASE-24079 didn't work. Add a test and fix what it turns up. [Flakey Tests] TestSnapshotScannerHDFSAclController,13295724,Resolved,Major,Fixed,02/Apr/20 07:54,02/Apr/20 16:59,,"According to HBASE-24097, TestSnapshotScannerHDFSAclController is still flakey: https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2/5950/" [Flakey Test] TestThriftServerCmdLine.testRunThriftServer NPEs if InfoServer port clash,13295933,Resolved,Major,Fixed,03/Apr/20 03:23,03/Apr/20 03:32,,"Push yesterday, HBASE-24100 [Flakey Tests] Add test to check we work properly when port clash setting up thriftserver, fixed the thrift protocol clash on ports. Today I ran into a clash where the info put up by thrift clashes. It looks like this. This issue adds tests where info port clashes. {code} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine ------------------------------------------------------------------------------- Tests run: 32, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 81.368 s <<< FAILURE! - in org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine.testRunThriftServer[9] Time elapsed: 10.161 s <<< ERROR! java.lang.NullPointerException at org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine.createBoundServer(TestThriftServerCmdLine.java:251) at org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine.createBoundServer(TestThriftServerCmdLine.java:178) at org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine.testRunThriftServer(TestThriftServerCmdLine.java:258) {code}" Temporary issue... ignore,13296862,Resolved,Major,Not A Bug,07/Apr/20 15:57,07/Apr/20 17:34,,Issue to try PRs against. Ignore. Switch to `RawLocalFileSystem` as default FS for tests,13296660,Open,Major,,06/Apr/20 21:01,,,"In the PR discussion on HBASE-24106, [~elserj] [mentioned|https://github.com/apache/hbase/pull/1422#discussion_r403789851] that another project has had success with switching its unit test suite to use {{RawLocalFileSystem}} from {{LocalFileSystem}}. This is discussed in the context of the availability of the {{hsync}} and {{hflush}} stream capabilities, which are not available on {{LocalFileSystem}}. Perhaps we should also consider doing the same for our default {{standalone}} user experience. I don't know if doing so should be a separate task from this one, or if completing one is effectively performing the implementation for the other." Change machine ulimit-l to ulimit-a so dumps full ulimit rather than just 'max locked memory',13296552,Resolved,Major,Fixed,06/Apr/20 15:56,06/Apr/20 17:19,,Dump out full ulimit list under the machine dir job output rather than one-liner. More utility. Polish the protobuf usage in hbase-examples,13296399,Resolved,Major,Fixed,06/Apr/20 02:13,06/Apr/20 14:16,, Reenable TestCompactingToCellFlatMapMemStore,13296674,Open,Major,,06/Apr/20 22:40,,,Disabled in the parent. Reenable when flakyness fixed. Upgrade the maven we use from 3.5.4 to 3.6.3 in nightlies,13296139,Resolved,Major,Fixed,03/Apr/20 23:21,06/Apr/20 18:33,,"I want to up parallelism of nightlies and hopefully improve stability. Lets use latest maven, go from 3.5.4 to 3.6.3." Get ulimit and how many threads we can make up on hadoop nodes,13295936,Resolved,Major,Invalid,03/Apr/20 03:46,03/Apr/20 03:50,,Let me run my little probing patch. Ban imports of com.google.protobuf.*,13295522,Open,Major,,01/Apr/20 12:05,,,At least in our code base we should not depend on them any more. Fix TestRSGroupsBalance,13295401,Resolved,Major,Fixed,01/Apr/20 02:33,01/Apr/20 06:42,3.0.0-alpha-1,"run TestRSGroupsBalance failed, after debug into it, it related to HBASE-24032." Optimize table.jsp code,13313213,Resolved,Minor,Fixed,24/Jun/20 09:15,18/Dec/24 14:02,3.0.0-alpha-1,"# Rename buildRegionServerLink to buildRegionLink, for it returns the link of region, not regionserver. # Add buildRegionDeployedServerTag and moreRegionsToRender, this two function can be used everywhere in table.jsp, and with them we can reduce a lot of same code. # Fix bug which locality stats tab can not sort. This is because we set wrong id for locality stats tab. # We use too much ""if (withReplica)..."" statements, remove it and let the page always show the replica id of regions. This can help to keep the code simple and the UI style union. # When there is no primary region on regionserver, show 0 instead of null" MetricsTable#updateFlushTime is wrong,13297995,Resolved,Minor,Fixed,13/Apr/20 10:01,30/Sep/24 02:59,2.2.1,"MetricsRegionServer does an update on the MetricsRegionServerSource, MetricsTable etc. While doing updateFlushTime, the time taken for flush is rightly updated in the RegionServerSource but at the MetricsTable level we update the memstoresize instead of the time. This applies from 1.1 version onwards. " AsyncRpcRetryingCaller should include master call details,13300665,Open,Minor,,23/Apr/20 21:53,,2.3.0,"I think the below is a retry loop from a coprocessor execution pointed at a master. The call details are missing some important details, such as: * hostname and port * call id * remote (rpc) method name {noformat} 20/04/23 21:09:26 WARN client.AsyncRpcRetryingCaller: Call to master failed, tries = 6, maxAttempts = 10, timeout = 1200000 ms, time elapsed = 2902 ms org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet at org.apache.hadoop.hbase.master.HMaster.checkServiceStarted(HMaster.java:2873) at org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:2885) at org.apache.hadoop.hbase.master.MasterRpcServices.rpcPreCheck(MasterRpcServices.java:438) at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:882) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:99) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:89) at org.apache.hadoop.hbase.client.ConnectionUtils.translateException(ConnectionUtils.java:321) at org.apache.hadoop.hbase.client.AsyncRpcRetryingCaller.onError(AsyncRpcRetryingCaller.java:159) at org.apache.hadoop.hbase.client.AsyncMasterRequestRpcRetryingCaller.lambda$null$4(AsyncMasterRequestRpcRetryingCaller.java:73) at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859) at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:837) at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) at java.base/java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2088) at org.apache.hadoop.hbase.client.MasterCoprocessorRpcChannelImpl$1.run(MasterCoprocessorRpcChannelImpl.java:63) at org.apache.hadoop.hbase.client.MasterCoprocessorRpcChannelImpl$1.run(MasterCoprocessorRpcChannelImpl.java:58) at org.apache.hbase.thirdparty.com.google.protobuf.RpcUtil$1.run(RpcUtil.java:79) at org.apache.hbase.thirdparty.com.google.protobuf.RpcUtil$1.run(RpcUtil.java:70) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:378) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:87) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:407) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:403) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:117) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:132) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.readResponse(NettyRpcDuplexHandler.java:162) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelRead(NettyRpcDuplexHandler.java:192) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:377) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:355) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:316) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:377) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:355) at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:377) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:355) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:377) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:163) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:714) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:650) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:576) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.ipc.ServerNotRunningYetException): org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running at org.apache.hadoop.hbase.master.HMaster.checkServiceStarted(HMaster.java:2873) at org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:2885) at org.apache.hadoop.hbase.master.MasterRpcServices.rpcPreCheck(MasterRpcServices.java:438) at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:882) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:373) ... 32 more {noformat}" Add support to run LoadIncrementalHFiles in a distributed manner,13310924,Patch Available,Minor,,11/Jun/20 14:04,,1.4.0,"LoadIncrementalHFiles takes a very long time to complete when running HBase on top of S3 and attempting to bulkload 500K-700K files. The root cause of this is a combination of the higher latency of S3 (as compared to HDFS) as well as the calls made by LoadIncrementalHFiles to the underlying filesystem(each file is opened, seeked to the trailer offset at the end, and then the trailer is read). Increasing the parallelism does not yield any significant improvement. This seems to stem from the fact that once the trailer is read the stream is not consumed to the end. This causes the underlying HTTP connection to be aborted and it cannot be re-used.   The proposed solution would be to also add support to run LoadIncrementalHFiles on multiple machines as a map reduce job. " Moving the meta region causes MetricsException when using above 2.6.0 hadoop version,13306041,Resolved,Minor,Won't Fix,20/May/20 02:48,09/Aug/22 07:55,1.4.13,"When the meta region moved out from a region server then moved in to the one again, we got MetricsException below and the metric source for coprocessor couldn't be re-registered. it happened with hadoop 2.8.5 {noformat} 2020-04-21 15:13:02,956 WARN [HBase-Metrics2-1] util.MBeans: Error creating MBean object name: Hadoop:service=HBase,name=RegionServer,sub=Coprocessor.Region.C P_org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint org.apache.hadoop.metrics2.MetricsException: org.apache.hadoop.metrics2.MetricsException: Hadoop:service=HBase,name=RegionServer,sub=Coprocessor.Region.CP_org. apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint already exists! at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newObjectName(DefaultMetricsSystem.java:127) at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.newMBeanName(DefaultMetricsSystem.java:102) at org.apache.hadoop.metrics2.util.MBeans.getMBeanName(MBeans.java:121) at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:64) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:222) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:100) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:268) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:239) at jdk.internal.reflect.GeneratedMethodAccessor82.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:320) at com.sun.proxy.$Proxy10.postStart(Unknown Source) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:193) at org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:109) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) {noformat}" JsonBean representation of metrics at /jmx endpoint now quotes all numbers,13314129,Closed,Minor,Fixed,29/Jun/20 19:53,02/Jul/20 13:39,1.3.6,"HBASE-20571 had a fix to look for NaN or Infinity in numbers, and to quote those as strings. The order of the `if-else` block is different in branch-1 (https://github.com/apache/hbase/commit/2d493556f3c8ae87fb92422b525bf7c9345e6ccd) and branch-2 (https://github.com/apache/hbase/commit/39ea1efa885e2f27f41af59228e0a12c4ded08f8) HBASE-23015 changed the JsonBean.java code in a meaningful way, and the order of the changes were consistent between branch-1 ([https://github.com/apache/hbase/commit/f77c14d18150f55ee892f8d24a5ee231c1ae7e20#diff-87e9e2722b9210eebfd8c820c5d72a46L319-L324]) and branch-2 ([https://github.com/apache/hbase/commit/761aef6d9d0b8a455842de4d5eac7d9486f00633#diff-2c8f5dd222141c69112c5c5b5f70cf55R319-R324]) Unfortunately, they need to be reversed since the order is different between branch-1 and branch-2." Remove hbase-native-client code from the master branch,13307013,Closed,Minor,Fixed,24/May/20 02:12,24/May/20 23:20,,"Per recent discussions in the slack channel, there is not much value in having this code in the master branch. This code has it's dedicated git repo at https://github.com/apache/hbase-native-client. It was already removed from branch-1 (HBASE-19419) and branch-2 (HBASE-19176)" Bring back hedged reads metrics to branch-1,13307383,Closed,Minor,Fixed,26/May/20 09:38,28/May/20 02:15,1.4.13,"Seems at some point, the hedged metrics were added to MetricsRegionServerWrapperImpl (they were added without mentioning Jira ticket, but may be it was https://issues.apache.org/jira/browse/HBASE-12220 ?)   However, because of compilation issue, it was reverted: https://issues.apache.org/jira/browse/HBASE-12246   And never re-applied for branch-1: https://issues.apache.org/jira/browse/HBASE-12246?focusedCommentId=16425102&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16425102" The store file open and close thread pool should be shared at the region level,13307468,Resolved,Minor,Won't Fix,26/May/20 15:06,11/Jun/22 19:35,,"For now, we provide threads per column family evenly in general, but there are some cases that some column families have much more store files than others( maybe that's the life, right? ). So in that case, some Stores have beed done quickly while others are struggling.We should share the thread pool at the region level in case of data skew." Backport HBASE-23968 to branch-2,13303159,Resolved,Minor,Fixed,06/May/20 16:32,18/Aug/21 17:22,, Delete old hbase-thirdparty releases from dist.a.o,13302020,Resolved,Minor,Done,30/Apr/20 08:12,01/May/20 11:00,,"On dist.apache.org only the latest releases should be available. Currently these are available there: hbase-thirdparty-3.0.0/ hbase-thirdparty-3.1.1/ hbase-thirdparty-3.2.0/ hbase-thirdparty-3.3.0/" Break long region names in the web UI,13312676,Resolved,Minor,Fixed,21/Jun/20 12:08,23/Jun/20 02:09,3.0.0-alpha-1,"Before this patch, when it comes to the long region name, the UI content will be out of the screen, making it unreadable. Like this: !image-2020-06-21-20-18-37-041.png|width=542,height=50! !image-2020-06-21-20-19-25-183.png|width=531,height=23! !image-2020-06-21-20-20-02-782.png|width=542,height=146!   After this patch, the long region name wil be break to the new line, like this: !image-2020-06-21-20-27-23-474.png|width=529,height=35! !image-2020-06-21-20-28-36-464.png|width=533,height=33! !image-2020-06-21-20-29-07-819.png|width=531,height=117!" connection#close throws NPE,13311704,Resolved,Minor,Fixed,16/Jun/20 12:19,17/Aug/21 00:10,2.2.3,"In the ConnectionImplementation construction method, if getRegistry throws exception， registry will be null，and then close will throw NPE {code:java} try { this.registry = AsyncRegistryFactory.getRegistry(conf); ... } catch (Throwable e) { // avoid leaks: registry, rpcClient, ... LOG.debug(""connection construction failed"", e); close(); throw e; } {code}" master-status UI make date type fields sortable,13313868,Resolved,Minor,Fixed,28/Jun/20 16:00,16/Aug/21 23:07,2.1.5,"Revisit of HBASE-21207, HBASE-22543 date type values such as regionserver list 'Start time' field on master-status page, are not sorted by time. HBASE-21207, HBASE-22543 missed it. so before this fix, date sorted as String. The first field of it is 'day'. therefore always Friday goes first Wednesday goes last, no matter what date it is.    * SCREEN_SHOT1.png   this fix make date type values sorted by time and date." Backport HBASE-23968 to branch-1,13303162,Resolved,Minor,Won't Fix,06/May/20 16:47,16/Aug/21 18:52,, ProtobufLogReader.readNext does not need looping,13308998,Resolved,Minor,Fixed,02/Jun/20 17:08,03/Jun/20 16:57,,"ProtobufLogReader.readNext is using infinite while loop for the whole method, however it returns value or throws errors in single execution. while(true) was part of initial code and with better improvements in the method, this loop has not been removed yet." Handle deprecations in ServerName,13302433,Resolved,Minor,Fixed,02/May/20 13:34,06/Jun/20 18:17,3.0.0-alpha-1,Some functions in {{ServerName}} were deprecated in 2.0.0 and should be removed for version 3.0.0. Clone snapshot with optional table level property overrides,13312332,Open,Minor,,19/Jun/20 01:47,,1.6.0,"We have this use case where we try to clone from snapshots of a table with replication enabled. Cloning process just reads the TableDescriptor from the manifest and uses it for the new target table. In our case, the moment we clone it, replication kicks in and attempts to replicate table to peers but since the target table doesn't exist, it keeps throwing TNFE in a loop. I propose to add additional *optional* parameters to clone_snapshot that takes the target table property overrides (table leve/cf level). For example: {noformat} clone_snapshot 'snapshotName', 'tableName' # default clone_snapshot 'snapshotName', 'tableName', {NAME => 'f1', REPLICATION_SCOPE => 0 } clone_snapshot 'snapshotName, 'tableName', {MERGE_ENABLED => false} ..... {noformat}   Implementation wise, this just adds a {{ModifyTableProcedure}} as a child procedure (if args are provided) for {{CloneSnapshotProcedure}} after {{CLONE_SNAPSHOT_ADD_TO_META}}, so we reuse most of the ""modifyTable"" code.  Also, since clone puts the table in a disabled state, using ""ModifyTableProcedure"" shouldn't cause any issues.  Thoughts? Is there any easier way to do it?  " Destination RSGroup Aware Export Snapshot,13297442,In Progress,Minor,,09/Apr/20 17:28,,,Export Snapshot to a destination Hbase cluster which is not RSGroup aware can lead to data spill outside of destination RSGroup. This improvement aims at ensuring export snapshort to be aware of destination RSGroup nodes and placing the data only in those boxes.  [branch-1] Support ZooKeeper 3.6.0+,13310441,Resolved,Minor,Fixed,09/Jun/20 17:10,05/Apr/21 03:49,,"Fix compilation issues against ZooKeeper 3.6.0. Backwards compatible changes with 3.4 and 3.5. Tested with: {{  mvn clean install -Dtest=org.apache.hadoop.hbase.zookeeper.**}} {{  mvn clean install -Dzookeeper.version=3.5.8 -Dtest=org.apache.hadoop.hbase.zookeeper.**}} {{  mvn clean install -Dzookeeper.version=3.6.0 -Dtest=org.apache.hadoop.hbase.zookeeper.**}}" Consider allowing a separate EventLoopGroup for accepting new connections.,13312850,Open,Minor,,22/Jun/20 14:57,,,"Netty applications often set a separate thread pool for accepting connections rather than sharing a single pool for accepting new connections and the work those connections do. It would be interesting to allow configuring a separation of pools to allow users to experiment with a pool dedicated to accepting new connections." Add more details when print CompactionConfiguration info,13304861,Resolved,Minor,Fixed,14/May/20 07:27,27/May/20 11:54,,"Now the CompactionConfiguration info logs look like {code} 2020-05-14 15:32:45,468 INFO [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16020] compactions.CompactionConfiguration: size [128 MB, 8.00 EB, 8.00 EB); files [3, 10); ratio 1.200000; off-peak ratio 5.000000; throttle point 2684354560; major period 604800000, major jitter 0.500000, min locality to compact 0.000000; tiered compaction: max_age 9223372036854775807, incoming window min 6, compaction policy for tiered window org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy, single output for minor true, compaction window factory org.apache.hadoop.hbase.regionserver.compactions.ExponentialCompactionWindowFactory 2020-05-14 15:32:45,468 INFO [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16020] compactions.CompactionConfiguration: size [128 MB, 8.00 EB, 8.00 EB); files [3, 10); ratio 1.200000; off-peak ratio 5.000000; throttle point 2684354560; major period 604800000, major jitter 0.500000, min locality to compact 0.000000; tiered compaction: max_age 9223372036854775807, incoming window min 6, compaction policy for tiered window org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy, single output for minor true, compaction window factory org.apache.hadoop.hbase.regionserver.compactions.ExponentialCompactionWindowFactory 2020-05-14 15:32:45,469 INFO [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16020] compactions.CompactionConfiguration: size [128 MB, 8.00 EB, 8.00 EB); files [3, 10); ratio 1.200000; off-peak ratio 5.000000; throttle point 2684354560; major period 604800000, major jitter 0.500000, min locality to compact 0.000000; tiered compaction: max_age 9223372036854775807, incoming window min 6, compaction policy for tiered window org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy, single output for minor true, compaction window factory org.apache.hadoop.hbase.regionserver.compactions.ExponentialCompactionWindowFactory 2020-05-14 15:32:45,469 INFO [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16020] compactions.CompactionConfiguration: size [128 MB, 8.00 EB, 8.00 EB); files [3, 10); ratio 1.200000; off-peak ratio 5.000000; throttle point 2684354560; major period 604800000, major jitter 0.500000, min locality to compact 0.000000; tiered compaction: max_age 9223372036854775807, incoming window min 6, compaction policy for tiered window org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy, single output for minor true, compaction window factory org.apache.hadoop.hbase.regionserver.compactions.ExponentialCompactionWindowFactory {code} We don't have any details on which region and which column family the CompactionConfiguration for. It would be better to include the region name and column family detail also in this log. " Region move to different rsgroup server should fail fast.,13300441,Open,Minor,,23/Apr/20 05:28,,,"When I tried to move a region (which was the part of the Table T1 present in RSG1 rsgroup) to RegionServer of another RSGroup RSG2, the move was not successful and yet the output was ""Took 3.4 seconds"" instead of an error. Also, during the move, the master logs did not show the destination address as the RS address, it showed localhost which I think is misleading.   STEPS TO RETRACE THE SCENARIO: # Create a RSGroup 'RSG1' and add region servers into it. # Create another RSGroup 'RSG2' and add region servers into it also. # Create a table 't1' with multiple regions and move it to rsgroup 'RSG1'. # Now try to move a region of table t1 from 'RSG1' to region server of 'RSG2'.    " Support user-defined version timestamp when bulk load data,13300138,Resolved,Minor,Fixed,22/Apr/20 03:07,30/Nov/20 14:36,1.0.0,"In hbase-connectors-1.0.0, loading data in bulk, only the current system time can be used as the KeyValue version timestamp." "REST and Thrift server do not handle the ""doAs"" parameter case insensitively",13301319,Resolved,Minor,Fixed,27/Apr/20 15:46,24/Nov/20 17:32,,"Hadoop does a case-insensitve comparison on the doAs parameter name when handling principal impersonation. The HBase Rest and Thrift servers do not do that, they only accept the ""doAs"" form. According to HADOOP-11083, the the correct Hadoop behaviour is accepting doAs in any case." RegionMover ignores replicationId,13298308,Resolved,Minor,Fixed,14/Apr/20 15:05,16/Apr/20 14:35,,"When RegionMover looks up which rs hosts a region, it does this based on startRowKey. When read replication is enabled this might not return the expected region's data and this can prevent the moving of these regions." Upgrade to Yetus 0.12.0,13298861,Resolved,Minor,Fixed,16/Apr/20 16:21,02/Nov/20 21:07,1.4.14,A new Yetus release is imminent. Unsupported rollback should not be logged as CODE-BUG ,13299157,Resolved,Minor,Cannot Reproduce,17/Apr/20 15:02,06/Oct/20 06:26,,"When executing rollback from a state that does not support rollback functionality UnsupportedOperationException is thrown. The Procedure framework does not handle this case specially and logs an ERROR message because it is caught as a Throwable. This scenario should have a cleaner log message. {noformat} 2020-04-08 20:57:10,137 ERROR org.apache.hadoop.hbase.procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception for pid=14791, state=FAILED:SERVER_CRASH_START, locked=true, exception=org.apache.hadoop.hbase.procedure2.ProcedureAbortedException via AssignProcedure:org.apache.hadoop.hbase.procedure2.ProcedureAbortedException: 6f48ff190e182c204056eb8b227ff6e8 owned by pid=9419, CANNOT run 'this' (pid=14797).; ServerCrashProcedure server=example.com,16020,1584086541944, splitWal=true, meta=false java.lang.UnsupportedOperationException: unhandled state=SERVER_CRASH_GET_REGIONS at org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.rollbackState(ServerCrashProcedure.java:265) at org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.rollbackState(ServerCrashProcedure.java:59) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.rollback(StateMachineProcedure.java:208) at org.apache.hadoop.hbase.procedure2.Procedure.doRollback(Procedure.java:982) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1663) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1595) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1438) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1200(ProcedureExecutor.java:78) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2058) {noformat}" Contribute a Test class that shows some examples for using the Async Client API,13307835,Resolved,Minor,Incomplete,27/May/20 20:04,06/Oct/20 00:57,,"类似于  [https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/AsyncClientExample.java] 但最初是以测试的形式进行，以使验证和环境变得容易。 这基本上是一些示例，说明如何将CompletableFuture API与Async Client一起使用-鉴于CompletableFuture API的表达力和大小，从头开始做一个新手可能会有些痛苦，但是使用其他示例代码要容易得多建立或修补。" Include jetty-schemas so that xml parsing does not need to hit sun/oracle urls.,13309097,Resolved,Minor,Incomplete,03/Jun/20 04:09,06/Oct/20 00:56,, Close one off connections in RawSyncHBaseAdmin.,13309096,Resolved,Minor,Incomplete,03/Jun/20 04:09,06/Oct/20 00:56,, Backport HBASE-24492 to all 2.x branch,13309232,Resolved,Minor,Fixed,03/Jun/20 16:58,02/Oct/20 11:50,,"After release 2.3.0 is out, we need to backport HBASE-24492 to all 2.x branches." HBase Rest: Request for region detail of a table which doesn't exits is success(200 success code) instead of 404,13308635,Resolved,Minor,Fixed,01/Jun/20 04:51,19/Sep/20 14:33,2.2.3,"Request for region detail of a table which doesn't exits is success(200 success code) however response doesn't have any region data. However response for a request of schema detail for a table which doesn't exits, is 404(Not found)" Update Apache POM to version 23,13302335,Resolved,Minor,Fixed,01/May/20 18:04,02/May/20 13:22,,"The most recent version of the Apache parent POM is v23. We should update to this one. There should not be big changes, except that it updates the rat-plugin to the version we already have." Get hostAndWeights in addition using localhost if it is null in local mode,13311640,Resolved,Minor,Fixed,16/Jun/20 06:22,01/Sep/20 13:23,,"In local mode, regionserver use pcname as hostname, but the blockLocation returned by filesystem use localhost as hostname, it cause mismatch when we get hostAndWeight from hostAndWeights." [Hadoop3.3] Update license for org.ow2.asm:*,13300851,Resolved,Minor,Fixed,24/Apr/20 18:03,04/May/20 22:00,,"Hadoop 3.3 brings a few Jetty dependencies which transitively brings in org.ow2.asm:asm-analysis, org.ow2.asm:asm-commons, org.ow2.asm:asm-tree. When testing with the latest Jetty (9.4.26.v20200117) I found its org.ow2.asm:* updated from 7.1 to 7.2, which changed the declared license from ""BSD"" to ""BSD-3-Clause License"" (The actual license text did not change). The HBase's license checker doesn't accept it. File the jira to update it to ""BSD 3-Clause License"" so that HBase can build. {noformat} [INFO] | | | +- org.eclipse.jetty.websocket:javax-websocket-server-impl:jar:9.4.26.v20200117:test [INFO] | | | | +- org.eclipse.jetty:jetty-annotations:jar:9.4.26.v20200117:test [INFO] | | | | | +- org.eclipse.jetty:jetty-plus:jar:9.4.26.v20200117:test [INFO] | | | | | | \- org.eclipse.jetty:jetty-jndi:jar:9.4.26.v20200117:test [INFO] | | | | | \- org.ow2.asm:asm-commons:jar:7.2:test [INFO] | | | | | +- org.ow2.asm:asm-tree:jar:7.2:test [INFO] | | | | | \- org.ow2.asm:asm-analysis:jar:7.2:test {noformat} {noformat} This product includes asm-analysis licensed under the BSD-3-Clause. ERROR: Please check ^^^^^^^^^^^^ this License for acceptability here: https://www.apache.org/legal/resolved If it is okay, then update the list named 'non_aggregate_fine' in the LICENSE.vm file. If it isn't okay, then revert the change that added the dependency. More info on the dependency: org.ow2.asm asm-analysis 7.2 {noformat}" Update PolicyBasedChaosMonkey to handle uncaught exceptions,13314174,Resolved,Minor,Fixed,29/Jun/20 23:32,21/Jul/20 17:03,,"Running {{ServerKillingChaosMonkey}} via {{RESTApiClusterManager}} for any duration of time slowly leaks region servers. I see failures on the RESTApi side go unreported on the ChaosMonkey side. It seems like {{RuntimeExceptions}} are being thrown and lost. {{PolicyBasedChaosMonkey}} uses a primitive means of thread management anyway. Update to use a thread pool, thread groups, and an uncaughtExceptionHandler." Cleanup the build directory structure,13311829,Resolved,Minor,Fixed,16/Jun/20 21:54,17/Jun/20 19:34,,"Currently all the build binaries (along with shared-libs and dependencies) are installed in the same current build directory. That is super messy to work with. It looks something like this {noformat} . ├── apachehbase-build ├── apachehbase-download ├── apachehbase-src ├── append-test ├── async-batch-rpc-retrying-test ├── async-rpc-retrying-test ├── build ├── bytes-util-test ├── cell-test ├── client-deserializer-test ├── client-serializer-test ├── client-test ├── CMakeCache.txt ├── CMakeFiles ├── cmake_install.cmake ├── concurrent-map-test ├── configuration-test ├── connection-pool-test ├── CTestTestfile.cmake ├── delete-test ├── dependencies ├── exception-test ├── facebook-folly-proj-prefix ├── facebook-wangle-proj-prefix ├── filter-test ├── get-test ├── hbase-configuration-test ├── increment-test ├── libhbaseclient.a ├── libhbaseclient.so ├── libtestutil.a ├── load-client ├── location-cache-retry-test ├── location-cache-test ├── Makefile ├── Protobuf-build ├── Protobuf-download ├── Protobuf-src ├── put-test ├── region-info-deserializer-test ├── request-converter-test ├── result-test ├── rpc-test ├── scanner-test ├── scan-result-cache-test ├── scan-test ├── server-name-test ├── simple-client ├── table-name-test ├── target ├── Testing ├── time-range-test ├── user-util-test ├── zk-deserializer-test ├── zk-util-test └── ZooKeeper-prefix {noformat} I have a patch that switches the build layout to the following (logically grouped). Very clean and easy to work with. {noformat} . ├── bin ├── build ├── CMakeCache.txt ├── CMakeFiles ├── cmake_install.cmake ├── CTestTestfile.cmake ├── dependencies ├── libs ├── Makefile └── tests {noformat} With Depth 2 (to show the layout better) {noformat} ├── bin │   └── examples ├── build │   └── test-data ├── CMakeCache.txt ├── CMakeFiles │   ├── 3.10.2 │   ├── append-test.dir │   ├── async-batch-rpc-retrying-test.dir │   ├── async-rpc-retrying-test.dir │   ├── bytes-util-test.dir │   ├── cell-test.dir │   ├── CheckLibraryExists │   ├── client-deserializer-test.dir │   ├── client-serializer-test.dir │   ├── client-test.dir │   ├── cmake.check_cache │   ├── CMakeDirectoryInformation.cmake │   ├── CMakeError.log │   ├── CMakeOutput.log │   ├── CMakeRuleHashes.txt │   ├── CMakeTmp │   ├── concurrent-map-test.dir │   ├── configuration-test.dir │   ├── connection-pool-test.dir │   ├── delete-test.dir │   ├── exception-test.dir │   ├── facebook-folly-proj-complete │   ├── facebook-folly-proj.dir │   ├── facebook-wangle-proj-complete │   ├── facebook-wangle-proj.dir │   ├── feature_tests.bin │   ├── feature_tests.cxx │   ├── filter-test.dir │   ├── get-test.dir │   ├── hbase │   ├── hbaseclient-shared.dir │   ├── hbaseclient-static.dir │   ├── hbase-configuration-test.dir │   ├── increment-test.dir │   ├── linter.dir │   ├── load-client.dir │   ├── location-cache-retry-test.dir │   ├── location-cache-test.dir │   ├── Makefile2 │   ├── Makefile.cmake │   ├── progress.marks │   ├── put-test.dir │   ├── region-info-deserializer-test.dir │   ├── request-converter-test.dir │   ├── result-test.dir │   ├── rpc-test.dir │   ├── scanner-test.dir │   ├── scan-result-cache-test.dir │   ├── scan-test.dir │   ├── server-name-test.dir │   ├── simple-client.dir │   ├── table-name-test.dir │   ├── TargetDirectories.txt │   ├── testutil.dir │   ├── time-range-test.dir │   ├── user-util-test.dir │   ├── zk-deserializer-test.dir │   ├── zk-util-test.dir │   ├── ZooKeeper-complete │   └── ZooKeeper.dir ├── cmake_install.cmake ├── CTestTestfile.cmake ├── dependencies │   ├── apache-hbase-build │   ├── apache-hbase-download │   ├── apache-hbase-src │   ├── facebook-folly-proj-install │   ├── facebook-folly-proj-src │   ├── facebook-wangle-proj-download │   ├── facebook-wangle-proj-install │   ├── facebook-wangle-proj-src │   ├── Protobuf-build │   ├── Protobuf-download │   ├── Protobuf-src │   ├── src │   ├── tmp │   ├── zookeeper-install │   └── zookeeper-src ├── libs │   ├── libhbaseclient.a │   ├── libhbaseclient.so │   └── libtestutil.a ├── Makefile └── tests ├── append-test ├── async-batch-rpc-retrying-test ├── async-rpc-retrying-test ├── bytes-util-test ├── cell-test ├── client-deserializer-test ├── client-serializer-test ├── client-test ├── concurrent-map-test ├── configuration-test ├── connection-pool-test ├── delete-test ├── exception-test ├── filter-test ├── get-test ├── hbase-configuration-test ├── increment-test ├── location-cache-retry-test ├── location-cache-test ├── put-test ├── region-info-deserializer-test ├── request-converter-test ├── result-test ├── rpc-test ├── scanner-test ├── scan-result-cache-test ├── scan-test ├── server-name-test ├── table-name-test ├── time-range-test ├── user-util-test ├── zk-deserializer- {noformat} " HStore.add log format error,13307204,Resolved,Minor,Fixed,25/May/20 10:21,25/May/20 13:10,2.2.4, There was a partial failure due to IO when attempting to load,13307906,Resolved,Minor,Not A Problem,28/May/20 03:43,11/Aug/20 11:34,2.2.4, Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5),13309104,Resolved,Minor,Fixed,03/Jun/20 05:47,05/Jun/20 15:11,1.3.2,"The no.of retries for Sasl handshake is hardcoded to 5 (MAX_ATTEMPTS). Use cases which have strict SLAs on their operation timeouts need this to be configurable to meet their SLAs. Sample Scenario: * RS is slow in accepting connections but is slow in responding to requests. * Client makes a Sasl Connection attempt but times out on read (can be configurable via hbase.ipc.client.socket.timeout.read) and retries 5 times at this time (this is not configurable) and eventually bails out. Make this configurable by a new client property (say *hbase.security.relogin.maxretries)* so that clients/usecases can override and meet their timeout SLAs." [Chaos Monkey] abstract logging through the class hierarchy,13302221,Resolved,Minor,Fixed,30/Apr/20 21:51,03/Aug/20 19:57,2.3.0,"Running chaos monkey and watching the logs, it's very difficult to tell what actions are actually running. There's lots of shared methods through the class hierarchy that extends from {{abstract class Action}}, and each class comes with its own {{Logger}}. As a result, the logs have useless stuff like {noformat} INFO actions.Action: Started regionserver... {noformat} Add {{protected abstract Logger getLogger()}} to the class's internal interface, and have the concrete implementations provide their logger." release scripts should provide timing information,13308492,Resolved,Minor,Fixed,30/May/20 13:40,02/Aug/20 03:45,,right now I can get timing from the individual maven commands but it would be nice to get higher level times. [Metrics] FSDataInputStream's localBytesRead is wrong,13303082,Resolved,Minor,Fixed,06/May/20 10:51,06/May/20 11:56,, Clear the description of hbase.hregion.max.filesize,13311234,Resolved,Minor,Fixed,13/Jun/20 04:42,21/Jul/20 10:08,3.0.0-alpha-1,"After we improve the splitpolicy in HBASE-24664, seems it is better to clear this option's meaning." "Correct the doc of ""On the number of column families""",13308015,Resolved,Minor,Fixed,28/May/20 11:49,01/Jun/20 08:44,,"Currently all the compaction is store basis yet, so correct the content." Move ConfigurationObserver and related classes to hbase-common,13308531,Resolved,Minor,Fixed,30/May/20 21:53,31/May/20 21:28,,It's a nice utility that all the modules can leverage. Putting it in common makes it accessible. I want to use it in client for dynamic reconfiguration of master addresses in HBASE-18095. No need to get lock in canSplit because hasReferences will get lock too,13307054,Resolved,Minor,Fixed,24/May/20 12:07,26/May/20 20:38,, CacheConfig details logged at Store open is not really useful,13307507,Resolved,Minor,Fixed,26/May/20 18:19,09/Jun/20 06:21,3.0.0-alpha-1,"CacheConfig constructor is logging 'this' object at INFO level. This log comes during Store open(As CacheConfig instance for that store is created). As the log is at CacheConfig only, we don't get to know this is for which region:store. So not really useful log. {code} blockCache=org.apache.hadoop.hbase.io.hfile.CombinedBlockCache@7bc02941, cacheDataOnRead=true, cacheDataOnWrite=true, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false {code} Also during every compaction also this logs keeps coming. This is because during compaction we create new CacheConfig based on the HStore level CacheConfig object. We can avoid this log with every compaction happening." Add region info when log meessages in HStore.,13308221,Resolved,Minor,Fixed,29/May/20 04:00,09/Jun/20 06:17,3.0.0-alpha-1,"Some log message do not have region info when log, need to add it." SyncTable logging improvements,13310360,Resolved,Minor,Fixed,09/Jun/20 10:29,10/Jun/20 08:46,2.2.5,"While troubleshooting mismatches in replication deployment, SyncTable logging can provide some insights on what is diverging between two clusters. One caveat, though, is that it logs diverging row key as hexdecimal values, which is not so useful for operators trying to figure out which rows are mismatching, ideally, this info should be human readable, so that operators could have the exact value they could use for querying the tables with other tools, such as hbase shell. Another issue is that while rows mismatches are logged as info, cell values mismatches are only logged as debug. In general, any of the mismatches would already be quite verbose, so ideally both should be logged in debug level." Missing regionName while logging warning in HBCKServerCrashProcedure,13307154,Resolved,Minor,Fixed,25/May/20 07:00,25/May/20 12:33,, UnsafeAvailChecker should also check that required methods are available,13302765,Resolved,Minor,Fixed,04/May/20 23:21,05/May/20 19:09,,"We had a weird test failure due to accidentally running tests with some Java > 8 (exact version I am unsure of), where Unsafe is available, but the method signatures were different or some methods were removed, leading to this: {noformat} 020-05-02 14:57:15,145 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:143) at org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:237) at org.apache.hadoop.hbase.LocalHBaseCluster.(LocalHBaseCluster.java:163) at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:225) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:138) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:127) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2911) Caused by: java.lang.NoSuchMethodError: 'void sun.misc.Unsafe.putInt(java.lang.Object, int, int)' at org.apache.hadoop.hbase.util.UnsafeAccess.putInt(UnsafeAccess.java:233) at org.apache.hadoop.hbase.util.Bytes$ConverterHolder$UnsafeConverter.putInt(Bytes.java:1499) at org.apache.hadoop.hbase.util.Bytes.putInt(Bytes.java:1021) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.appendMetaData(RecoverableZooKeeper.java:850) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.create(RecoverableZooKeeper.java:640) at org.apache.hadoop.hbase.zookeeper.ZKUtil.createEphemeralNodeAndWatch(ZKUtil.java:1027) at org.apache.hadoop.hbase.zookeeper.MasterAddressTracker.setMasterAddress(MasterAddressTracker.java:211) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2095) at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:520) at org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.(HMasterCommandLine.java:315) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:138) ... 7 more {noformat} We should also check that all methods that will be invoked on Unsafe in UnsafeAccess.java are available when deciding in UnsafeAvailChecker if Unsafe is available (and usable). " Add a clause to the book noting that sometimes we short-circuit the deprecation cycle,13313660,Resolved,Minor,Fixed,26/Jun/20 17:26,29/Jun/20 14:45,,Let's add a note to the book that describes the circumstances around HBASE-21782 and how that can result in code not following our stated deprecation cycle guidelines. Parameter copyFiles should be passed in SecureBulkLoadClient,13310034,Resolved,Minor,Fixed,08/Jun/20 06:43,19/Jun/20 06:53,2.2.2,When refactor SecureBulkLoadClient started in HBASE-22380. The public secureBulkLoadHFiles  method parameter copyFiles was not passed to the refactoring method. Improve WAL splitting log lines to enable sessionization,13305287,Resolved,Minor,Fixed,15/May/20 20:19,19/Jun/20 23:37,,"Looking to reconstruct a timeline from write of recovered.edits file back to start of WAL file split, with a bunch of unrelated activity in the meantime, there isn't a consistent token that links split file write messages (which include store path including region hash) to beginning of WAL splitting activity. Sessonizing by host doesn't work because work can bounce around through retries. Thread context names in the logs vary and can be like [nds1-225-fra:60020-7] or [fb472085572ba72e96f1] (trailing digits of region hash) or [splits-1589016325868] . We could have WALSplitter get the current time when starting the split of a WAL file and have it log this timestamp in every line as a splitting session identifier. Related, we should track the time of split task execution end to end and export a metric that captures it. It might also be worthwhile to wire up more of WAL splitting to TaskMonitor status logging. If we do this we can also enable status journal logging, so when a WAL split has completed, a line will appear in the log that has the list of all status messages recorded during splitting and the time delta in milliseconds between them. " The regionInfo parameter for MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions should be plural ,13308567,Resolved,Minor,Fixed,31/May/20 13:44,16/Jun/20 09:48,3.0.0-alpha-1,"MasterProcedureScheduler#waitRegions and MasterProcedureScheduler#wakeRegions deal with a list of regions, so the variable name of region info should be plural" Use EnvironmentEdgeManager to compute clock skew in Master,13307801,Resolved,Minor,Fixed,27/May/20 16:29,23/Jun/20 16:23,1.6.0,"There are few cases where the Master is not able to complete the initialization as it waiting for the region server to report to it. The region server actually reported to the master but the master rejected the request because of clock skew issue though both of them are on  same JVM The Region server uses EnvironmentEdgeManager.currentTime to report the current time and HMaster uses System.currentTimeMillis() to get the current time for computation against the reported time by RS.  We should also just use EnvironmentEdgeManager even in Master as we are expected not to use System.currentTime directly and instead go through EnvironmentEdgeManager  " "ScheduledChore logging is too chatty, replace with metrics",13311015,Open,Minor,,11/Jun/20 23:48,,,"ScheduledChore logs at DEBUG level the execution time of each chore. We used to log an average execution time across all chores every five minutes, which by consensus was judged to not be useful. Derived metrics like averages or histograms should be calculated per chore. So we modified the logging to dump the chore execution time each time it runs, to facilitate such calculations with the log aggregation and searching tool of choice. Per chore execution logging is more useful, in that sense, but may be too chatty. This is not unexpected but let me provide my observations so we can revisit this. On the master, for example, this is logged every second: {noformat} 2020-06-11 16:35:28,263 DEBUG [master/apurtell-ltm:8100.splitLogManager..Chore.1] hbase.ScheduledChore: SplitLogManager Timeout Monitor execution time: 0 ms. {noformat} Does the value of these lines outweigh the cost of 86,400 log lines per day per master instance? (At least.) On the regionserver it is somewhat better, these are logged every 10 seconds: {noformat} 2020-06-11 16:37:57,203 DEBUG [regionserver/apurtell-ltm:8120.Chore.1] hbase.ScheduledChore: CompactionChecker execution time: 0 ms. 2020-06-11 16:37:57,203 DEBUG [regionserver/apurtell-ltm:8120.Chore.1] hbase.ScheduledChore: MemstoreFlusherChore execution time: 0 ms. {noformat} So that will be 17,280 log lines per day per regionserver. (At least.) These could be moved to TRACE level, perhaps. I propose we replace this logging with histogram metrics. There should be a separate metric for each distinct chore classname, allocated as needed. " "In HBase UI, srcChecksum has bad content",13312323,Open,Minor,,19/Jun/20 00:12,,2.3.0,"The value of srcChecksum displayed in the HBase UI is generated at build time by https://github.com/apache/hbase/blob/master/hbase-common/src/saveVersion.sh#L53-L61 On a Linux build host, if `openssl`(v 1.1.1) is available, the resulting value of srcChecksum is `(stdin)=` else if `gpg` (v 2.2.19) is available, the value is only the first 8-character substring of the sha512 hash. On a Mac build host, if `openssl`(LibreSSL 2.8.3) is available, the resulting value of srcChecksum is correct else if `gpg` (v 2.2.19) is available, the value is again the first 8-character substring of the sha512 hash. Furthermore, while ""sha512"" is well defined and gives the same value from all four programs, the associated leader text for file names has a different format, and gpg generates uppercase hex divided into 8-character blocks while openssl generates lowercase hex in a single string. Either of these differences will cause the sum-of-sums generated by openssl and gpg to be different! Which is unacceptable if srcChecksum is to be used for validation. " Persist map of regions-to-last-flush-sequenceid across restarts,13312029,Open,Minor,,17/Jun/20 18:58,,,"A nice suggestion by our [~ndimiduk] was that we persist the last-successful-flush-sequenceid per region kept up by an in-memory map in Master. We could add it to our nice new general local master store. On restart, could rehydrate the map. Would be helpful on cold start in particular, especially if a big backlog of WALs to replay." "Changing ""whitelist"" and ""blacklist"" in our docs and project.",13311830,Open,Minor,,16/Jun/20 21:54,,,"Replace instances of “whitelist” and “blacklist” in our project, trails, documentation and UI text. We can replace blacklist with blocklist, blocklisted, or block and whitelist with allowlist, allowlisted, or allow. In my current workplace they are suggesting us to make this change. Also Google has an exhaustive list to write inclusive documentation: https://developers.google.com/style/inclusive-documentation There might be few issues while making the change. 1. If these words are part of config property name then all customers needs to make the change. 2. There might be some client-server compatibility if we change server side variables/method names. Creating this jira just to start the conversation. Please chip in with ideas." "TableNotFoundException will be occurred, when executing the command 'describe' in shell",13311462,Open,Minor,,15/Jun/20 10:53,,2.3.0,"when the feature 'hbase:quota' is disabled, it will throw TableNotFoundException by using the command 'describe' in shell. {code:ruby} hbase(main):002:0> desc 't1' Table t1 is ENABLED t1 COLUMN FAMILIES DESCRIPTION {NAME => 'f1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', KEEP_DELETED_CELLS => 'FALSE', CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false', CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'} 1 row(s) QUOTAS 18:30:29.992 [main] WARN org.apache.hadoop.hbase.quotas.QuotaRetriever - org.apache.hadoop.hbase.TableNotFoundException: hbase:quota at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegionInMeta(ConnectionImplementation.java:889) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegion(ConnectionImplementation.java:784) at org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.getRegionLocations(RpcRetryingCallerWithReadReplicas.java:328) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:162) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:58) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192) at org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:267) at org.apache.hadoop.hbase.client.ClientScanner.loadCache(ClientScanner.java:435) at org.apache.hadoop.hbase.client.ClientScanner.nextWithSyncCache(ClientScanner.java:310) at org.apache.hadoop.hbase.client.ClientScanner.next(ClientScanner.java:595) at org.apache.hadoop.hbase.quotas.QuotaRetriever.next(QuotaRetriever.java:105) at org.apache.hadoop.hbase.quotas.QuotaRetriever$Iter.(QuotaRetriever.java:129) at org.apache.hadoop.hbase.quotas.QuotaRetriever.iterator(QuotaRetriever.java:121) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(JavaMethod.java:438) at org.jruby.javasupport.JavaMethod.invokeDirect(JavaMethod.java:302) at org.jruby.java.invokers.InstanceMethodInvoker.call(InstanceMethodInvoker.java:36) ... {code}  " Expose a function in HBase WALKey to set the tablename,13306398,Resolved,Minor,Abandoned,21/May/20 07:52,14/Jun/20 00:46,,"Currently, table name in WALKey can not be changed once set. But exposing this function to change the table name can be very helpful for Customized WAL filters since they can flip the table name and make replication possible between different table names in source and sink clusters. " Delete reference off to Hadoop wiki's HBase FAQ,13310736,Resolved,Minor,Fixed,10/Jun/20 19:09,11/Jun/20 21:20,,"Our `faq.adoc` has a link off to [a FAQ|https://cwiki.apache.org/confluence/display/HADOOP2/Hbase+FAQ] in the Hadoop wiki, which is empty other than a pointer back to our book. Let's just delete the reference to the hadoop wiki." Change the IA for MutableSizeHistogram and MutableTimeHistogram,13310191,Open,Minor,,08/Jun/20 16:55,,,Currently the IA for MutableSizeHistogram and MutableTimeHistogram is private. We want to use these classes in phoenix project and I thought we can leverage the existing implementation from hbase histo implementation. IIUC the private IA can't be used in other projects. Proposing to make it LimitedPrivate and mark HBaseInterfaceAudience.PHOENIX. Please suggest. Backport HBASE-23896 to branch-1: Snapshot owner cannot delete snapshot when ACL is enabled and Kerberos is not enabled,13298235,Resolved,Minor,Fixed,14/Apr/20 10:24,10/Jun/20 08:13,,"For the owner of snapshots(not global admin user), currently list_snapshots returns empty if i just use simple acls for authorization but not use authentication. The code in AccessController.preListSnapshot: {code:java} if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, user)) { // list it, if user is the owner of snapshot AuthResult result = AuthResult.allow(""listSnapshot "" + snapshot.getName(), ""Snapshot owner check allowed"", user, null, null, null); accessChecker.logResult(result); }{code} And SnapshotManager.takeSnapshotInternal: {code:java} if (User.isHBaseSecurityEnabled(master.getConfiguration()) && user != null) { builder.setOwner(user.getShortName()); } {code} User.isHBaseSecurityEnabled： {code:java} public static boolean isHBaseSecurityEnabled(Configuration conf) { return ""kerberos"".equalsIgnoreCase(conf.get(HBASE_SECURITY_CONF_KEY)); } {code} So i think the logic of setOwner is used for authorization, not authentication, SnapshotManager should not only setOwner when hbase.security.authentication = kerberos, which cause listSnapshots returns empty when i just use simple acls." Doc section describing meta schema needs updated,13310758,Open,Minor,,10/Jun/20 21:24,,,"The bit in our [architecture|https://hbase.apache.org/book.html#arch.catalog.meta] section that describes the content of meta table needs an update. At the minimum, it's missing a description of read replica tracking." Migrate Seconding Indexing documentation from Hadoop wiki to our book,13310735,Open,Minor,,10/Jun/20 19:04,,,"I noticed we have a link in `cp.adoc` over to [a page|https://cwiki.apache.org/confluence/display/HADOOP2/Hbase+SecondaryIndexing] in the Hadoop wiki that pertains to secondary indexing. Hadoop Wiki has been deprecated as a reference point for HBase since HBASE-14481, but seems new content snuck in since then. We should take ownership over this advice." ScheduledChore log elapsed timespan in a human-friendly format,13304778,Resolved,Minor,Fixed,13/May/20 22:30,09/Jun/20 16:56,2.3.0,"I noticed this in a log line, {noformat} 2020-04-23 18:31:14,183 INFO org.apache.hadoop.hbase.ScheduledChore: host-a.example.com,16000,1587577999888-ClusterStatusChore average execution time: 68488258 ns. {noformat} I'm not sure if there's a case when elapsed time in nanoseconds is meaningful for these background chores, but we could do a little work before printing the number and time unit to truncate precision down to something a little more intuitive for operators. This number purports to be an average, so a high level of precision isn't necessarily meaningful. Separately, or while we're here, if we think an operator really cares about the performance of this chore, we should print a histogram of elapsed times, rather than an opaque average." PerformanceEvaluation options should not mandate any specific order,13303171,Resolved,Minor,Fixed,06/May/20 17:07,09/Jun/20 06:13,2.1.0,"During parsing of options, there are some validations. One such is checking whether autoFlush = false AND multiPut > 0. This validation code mandates an order that autoFlush=true should be specified before adding multiPut = x in PE command. {code} final String multiPut = ""--multiPut=""; if (cmd.startsWith(multiPut)) { opts.multiPut = Integer.parseInt(cmd.substring(multiPut.length())); if (!opts.autoFlush && opts.multiPut > 0) { throw new IllegalArgumentException(""autoFlush must be true when multiPut is more than 0""); } continue; } {code} 'autoFlush ' default value is false. If multiPut is specified prior to autoFlush in the PE command, we will end up throwing IllegalArgumentException. Checking other validations, seems not having such issue. Still better to move all the validations together into a private method and call that once the parse is over." Should shutdown mini cluster after class in TestMetaAssignmentWithStopMaster,13307786,Resolved,Minor,Fixed,27/May/20 15:44,09/Jun/20 00:31,, Add ndimiduk as release manager for 2.3,13310190,Resolved,Minor,Fixed,08/Jun/20 16:54,08/Jun/20 17:04,,Looks like we explicitly mention the active release managers in {{_chapters/community.adoc}}. Update. Add repeated prefix logging for MultipleColumnPrefixFilter,13308663,Resolved,Minor,Fixed,01/Jun/20 08:42,08/Jun/20 11:08,,"Current it is not easy to find which one is repeated if the input prefixes are not a few.   {code:java} java.lang.IllegalArgumentException: prefixes must be distinct at org.apache.hadoop.hbase.filter.MultipleColumnPrefixFilter.(MultipleColumnPrefixFilter.java:50) {code}" Backport HBase-24199 to 2.1.x branches,13302594,Resolved,Minor,Fixed,04/May/20 07:55,09/Jun/20 08:58,2.1.6,Noticed that 2.1.x line has this issue also and we need this patch backported to 2.1.x line consolidate TestSnapshotFileCacheWithDifferentWorkingDir and TestSnapshotFileCache by parameterized test.,13310197,Open,Minor,,08/Jun/20 17:49,,3.0.0-alpha-1,This is a followup Jira for HBASE-23202. refactor call setupCluster/tearDownCluster in TestTableSnapshotInputFormat,13309417,Resolved,Minor,Fixed,04/Jun/20 10:16,05/Jun/20 08:03,, "ITBLL, ChaosMonkey log message sheer/interleave",13309806,Open,Minor,,05/Jun/20 22:01,,2.3.0,"Running {{IntegrationTestBigLinkedList}} with {{ServerKillingChaosMonkey}}, I've noticed that some log messages are sheered/interwoven. This is particularly visible via the output of the {{DumpClusterStatusAction}}. I suspect we are running two logging instances simultaneously, rather than all loggers going through the same instance, and they're not coordinating on the output stream. I'm running ITBLL against a distributed/external cluster, launched via the {{bin/hbase}} script." Backport to branch-1 HBASE-17738 BucketCache startup is slow,13308688,Resolved,Minor,Fixed,01/Jun/20 10:02,05/Jun/20 03:49,,"I'd like to backport [HBASE-17738|https://issues.apache.org/jira/browse/HBASE-17738] to branch-1. Also removed some Unnecessary locks related to [HBASE-15785|https://issues.apache.org/jira/browse/HBASE-15785]" Wrap long lines in `_chapters/configuration.adoc`,13309064,Resolved,Minor,Fixed,02/Jun/20 23:03,03/Jun/20 16:12,,"Trying to make doc changes is pretty awful, with lines running on for hundreds of columns. At least for this time, clean up with line breaks where asciidoc will let us." Backport to branch-1 HBASE-15785 Unnecessary lock in ByteBufferArray,13309187,Resolved,Minor,Fixed,03/Jun/20 12:39,04/Jun/20 01:08,,Backport [HBASE-15785|https://issues.apache.org/jira/browse/HBASE-15785] to branch-1 ExportSnapshot which does not honor the case that working dir/root dir are from different filesystem,13309068,Open,Minor,,02/Jun/20 23:58,,2.3.0,"HBASE-21098 introduce a config ""hbase.snapshot.working.dir"", which allows tmp directory for snapshot manifest files to be on a different filesystem than rootdir's. ExportSnapshot does not seem honor this config and assumes they are the same filesystem." Remove the unused method online in admin.rb,13308738,Resolved,Minor,Fixed,01/Jun/20 14:43,02/Jun/20 18:23,,"Skiming the todo list, seems this method not used any more.   {code:java} # Enables/disables a region by name def online(region_name, on_off) # Open meta table meta = @connection.getTable(org.apache.hadoop.hbase.TableName::META_TABLE_NAME) # Read region info # FIXME: fail gracefully if can't find the region region_bytes = region_name.to_java_bytes g = org.apache.hadoop.hbase.client.Get.new(region_bytes) g.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY, org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER) hri_bytes = meta.get(g).value # Change region status hri = org.apache.hadoop.hbase.util.Writables.getWritable(hri_bytes, org.apache.hadoop.hbase.HRegionInfo.new) hri.setOffline(on_off) # Write it back put = org.apache.hadoop.hbase.client.Put.new(region_bytes) put.addColumn(org.apache.hadoop.hbase.HConstants::CATALOG_FAMILY, org.apache.hadoop.hbase.HConstants::REGIONINFO_QUALIFIER, org.apache.hadoop.hbase.util.Writables.getBytes(hri)) meta.put(put) end {code}" TestWALProcedureStoreOnHDFS#testWalAbortOnLowReplicationWithQueuedWriters fails too easily.,13303939,Resolved,Minor,Later,10/May/20 14:43,01/Jun/20 09:16,, Clean up the master thread name getting in SplitLogManager and AssignmentManager,13308463,Resolved,Minor,Fixed,30/May/20 08:15,31/May/20 05:26,,"As discussed in PR of HBASE-24451, seems just use master.getServerName().toShortString() is enough." Add store file info when log meessages in HStore.,13308280,Resolved,Minor,Fixed,29/May/20 09:06,29/May/20 13:56,3.0.0-alpha-1,"Some log message do not have store file info when log, need to add it." BackPort HBASE-20220 to branch-1,13307969,Resolved,Minor,Fixed,28/May/20 09:05,29/May/20 03:40,,Backport Jira : HBASE-20220 to branch-1 Flaky tests for region server in branch-1,13307860,Resolved,Minor,Not A Bug,27/May/20 22:47,28/May/20 02:07,1.7.0,"[https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1781/4/testReport/] Tests failed after unrelated code style changes for metrics for branch-1. Rerun passed." RetryCounter#sleepUntilNextRetry should use uninterrupted sleep,13305699,Resolved,Minor,Won't Fix,18/May/20 15:15,24/May/20 07:41,,"RetryCounter utility which is used at multiple places like MetaRegionLocationCache, RecoverableZookeeper etc provides a method to sleep for a back off time as supplied by the backoff policy. However, sleep used by sleepUntilNextRetry() makes thread sleep and throws InterruptedException which clients have to deal with. Clients using sleep for any backoff policy should not worry about handling InterruptedException. Dealing with InterruptedException is something for sleepUntilNextRetry() to take care of." Correct the comment of clusterRegionLocationMocks in TestStochasticLoadBalancer,13306349,Resolved,Minor,Fixed,21/May/20 01:52,22/May/20 22:37,,It's a little bit inaccurate in comment. [Flakey Tests] Some UTs about RSGroup should wait RSGroupInfoManager to be online,13305923,Resolved,Minor,Fixed,19/May/20 12:54,20/May/20 10:05,2.3.0,"We will access table hbase:rsgroup when call addRSGroup, so we should ensure RSGroupInfoManagerImpl is online before testing in the UTs about RSGroup. Otherwise, the following exceptions may be saw. {code:java} java.io.IOException: java.io.IOException: Only servers in default group can be updated during offline modejava.io.IOException: java.io.IOException: Only servers in default group can be updated during offline mode at org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.flushConfig(RSGroupInfoManagerImpl.java:602) at org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.addRSGroup(RSGroupInfoManagerImpl.java:217) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.addRSGroup(RSGroupAdminServer.java:391) {code}" [flakey test] locking.TestEntityLocks.testEntityLockTimeout,13297505,Resolved,Minor,Fixed,09/Apr/20 23:24,10/Apr/20 16:43,2.3.0,"From 2.3 flakey board, [https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2.3/199/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.locking.TestEntityLocks.txt]   {code:java} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.client.locking.TestEntityLocks ------------------------------------------------------------------------------- Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.917 s <<< FAILURE! - in org.apache.hadoop.hbase.client.locking.TestEntityLocks org.apache.hadoop.hbase.client.locking.TestEntityLocks.testEntityLockTimeout Time elapsed: 2.022 s <<< FAILURE! java.lang.AssertionError at org.apache.hadoop.hbase.client.locking.TestEntityLocks.testEntityLockTimeout(TestEntityLocks.java:178) Mapping to the code, it complains assertFalse(lock.getWorker().isAlive()); {code}" release scripts should allow for creation of initial CHANGES/RELEASE on new major version.,13305562,Resolved,Minor,Fixed,18/May/20 00:54,18/May/20 17:11,,"Right now if you try to run the release scripts on a new major version, e.g. one without a RELEASENOTES.md and CHANGES.md things fail: {code} /opt/hbase-rm/output + sed -i -e '/^## Release 3.0.0-alpha-1/,/^## Release/ {//!d; /^## Release 3.0.0-alpha-1/d;}' /opt/hbase-rm/output/hbase/CHANGES.md sed: can't read /opt/hbase-rm/output/hbase/CHANGES.md: No such file or directory + true + sed -i -e '/^# HBASE 3.0.0-alpha-1 Release Notes/,/^# HBASE/{//!d; /^# HBASE 3.0.0-alpha-1 Release Notes/d;}' /opt/hbase-rm/output/hbase/RELEASENOTES.md sed: can't read /opt/hbase-rm/output/hbase/RELEASENOTES.md: No such file or directory + true + sed -i -e '/## Release/,$!d' CHANGELOG.3.0.0-alpha-1.md + sed -i -e '/DO NOT REMOVE/r CHANGELOG.3.0.0-alpha-1.md' /opt/hbase-rm/output/hbase/CHANGES.md sed: can't read /opt/hbase-rm/output/hbase/CHANGES.md: No such file or directory + cleanup {code} instead we should just create the new files." MetricsTableWrapperAggregateImpl runnable fails due to exception and never runs,13304695,Resolved,Minor,Fixed,13/May/20 14:45,18/May/20 09:57,2.1.9,"MetricsTableWrapperAggregateImpl has a thread that periodically updates the values. It seems that once the region server is online and the meta is assigned if there are no store files the Optional values here {code} mt.maxStoreFileAge = Math.max(mt.maxStoreFileAge, store.getMaxStoreFileAge().getAsLong()); mt.minStoreFileAge = Math.min(mt.minStoreFileAge, store.getMinStoreFileAge().getAsLong()); {code} is not available and thus throwing NoSuchElementException and the thread dies. It never updates the values till the RS is alive. " TableStateNotFoundException happends when table creation if rsgroup is enable,13296897,Resolved,Minor,Fixed,07/Apr/20 19:18,17/May/20 14:51,2.2.3,"IF RS group is enabled then Unable to get table state error is thrown while creating a new table   Stpes: 1: Make sure RS group feature is enabled 2: Create a table say usertable2000 3: Check master log and observe below exception is thrown  org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: usertable2000" Procedure related metrics is not consumed in the JMX metric,13298792,Resolved,Minor,Fixed,16/Apr/20 11:49,01/May/20 18:54,,"We have ProcedureMetrics and that is being tracked for every procedure that we create for all the ops in the system. But when we check the UI, the UI does not display those information at all. It may be useful to know atleast in the case of ServerCrashProcedure exactly to know how much it has taken for the procedure to complete. Similarly other procedures also can be added to the UI. Currently checked in master code - but think it will apply to other branches also. " maxPoolSize is logged incorrectly in ByteBufferPool,13297575,Resolved,Minor,Fixed,10/Apr/20 09:02,16/May/20 23:02,2.2.4,"In ByteBufferPool _maxPoolSize_ is converted into byte format, https://github.com/apache/hbase/blob/a521a80c4b9a8b0749c368d1ff66fea2ed2d77a2/hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferPool.java#L85   Currently maxPoolSize is logged as below, 2020-04-10 14:20:56,000 INFO  [Time-limited test] io.ByteBufferPool(83): Created with bufferSize=64 KB and maxPoolSize=320 B" new major version in release script should default compat report to previous latest minor release,13305411,Open,Minor,,16/May/20 18:21,,,"currently if you are starting a new major version, the default calculated comparison version is invalid: {code} ======================== === Gathering release details. PROJECT [hbase]: hbase GIT_BRANCH [branch-2.3]: master Current branch VERSION is 3.0.0-SNAPSHOT. RELEASE_VERSION [3.0.0]: 3.0.0-alpha-1 NEXT_VERSION [3.0.1-SNAPSHOT]: 3.0.0-alpha-2-SNAPSHOT RC_COUNT [0]: RELEASE_TAG [3.0.0-alpha-1RC0]: This is a dry run. If tag does not actually exist, please confirm the ref that will be built for testing. GIT_REF [3.0.0-alpha-1RC0]: api_diff_tag [rel/3.0.-2]: rel/2.2.4 {code} when the new version is a new major we should either default to the prior initial major release (e.g. 2.0.0) or we should scan the release metadata for the most recent release from the prior major release (e.g. 2.2.4)." Potential Race in class org.apache.hadoop.hbase.io.crypto.Encryption,13305014,Open,Minor,,14/May/20 19:00,,,"We run our static race detector on ZooKeeper and discovered three methods in class org/apache/zookeeper/server/DataTree may have concurrent accesses on ephemerals without proper lock protection. {code:java} public final class Encryption { ... static final Map,KeyProvider> keyProviderCache = new ConcurrentHashMap<>(); ... public static KeyProvider getKeyProvider(Configuration conf) { String providerClassName = conf.get(HConstants.CRYPTO_KEYPROVIDER_CONF_KEY, KeyStoreKeyProvider.class.getName()); String providerParameters = conf.get(HConstants.CRYPTO_KEYPROVIDER_PARAMETERS_KEY, """"); try { Pair providerCacheKey = new Pair<>(providerClassName, providerParameters); KeyProvider provider = keyProviderCache.get(providerCacheKey); if (provider != null) { return provider; } provider = (KeyProvider) ReflectionUtils.newInstance( getClassLoaderForClass(KeyProvider.class).loadClass(providerClassName), conf); provider.init(providerParameters); if (LOG.isDebugEnabled()) { LOG.debug(""Installed "" + providerClassName + "" into key provider cache""); } keyProviderCache.put(providerCacheKey, provider); return provider; } catch (Exception e) { throw new RuntimeException(e); } } } {code} => Race: org/apache/hadoop/hbase/io/crypto/Encryption.java/util/Map (org/apache/hadoop/hbase/io/crypto/Encryption:553 (TID: 3863) , org/apache/hadoop/hbase/io/crypto/Encryption:542 (TID: 3864) ) Trace 1st node: (TID: 3863) //3863 and 3864 are threads created by a loop. -> Call org/apache/hadoop/util/ToolRunner.run from org/apache/hadoop/hbase/IntegrationTestRegionReplicaReplication.main (line 224) -> Call org/apache/hadoop/hbase/util/AbstractHBaseTool.run from org/apache/hadoop/util/ToolRunner.run (line 76) -> Call org/apache/hadoop/hbase/util/LoadTestTool.doWork from org/apache/hadoop/hbase/util/AbstractHBaseTool.run (line 154) -> Call org/apache/hadoop/hbase/util/LoadTestTool.parallelLoadTables from org/apache/hadoop/hbase/util/LoadTestTool.doWork (line 589) *> Thread (3863) created by Application,Lorg/apache/hadoop/hbase/util/LoadTestTool.parallelLoadTables (line 880) -> Call org/apache/hadoop/hbase/util/LoadTestTool$WorkerThread.run from java/lang/Thread.start (line -1) -> Call org/apache/hadoop/util/ToolRunner.run from org/apache/hadoop/hbase/util/LoadTestTool$WorkerThread.run (line 931) -> Call org/apache/hadoop/hbase/util/AbstractHBaseTool.run from org/apache/hadoop/util/ToolRunner.run (line 76) -> Call org/apache/hadoop/hbase/util/LoadTestTool.doWork from org/apache/hadoop/hbase/util/AbstractHBaseTool.run (line 154) -> Call org/apache/hadoop/hbase/util/LoadTestTool.loadTable from org/apache/hadoop/hbase/util/LoadTestTool.doWork (line 591) -> Call org/apache/hadoop/hbase/util/LoadTestTool.initTestTable from org/apache/hadoop/hbase/util/LoadTestTool.loadTable (line 605) -> Call org/apache/hadoop/hbase/util/LoadTestTool.applyColumnFamilyOptions from org/apache/hadoop/hbase/util/LoadTestTool.initTestTable (line 580) -> Call org/apache/hadoop/hbase/security/EncryptionUtil.wrapKey from org/apache/hadoop/hbase/util/LoadTestTool.applyColumnFamilyOptions (line 300) -> Call org/apache/hadoop/hbase/io/crypto/Encryption.encryptWithSubjectKey from org/apache/hadoop/hbase/security/EncryptionUtil.wrapKey (line 107) -> Call org/apache/hadoop/hbase/io/crypto/Encryption.getSecretKeyForSubject from org/apache/hadoop/hbase/io/crypto/Encryption.encryptWithSubjectKey (line 448) -> Call org/apache/hadoop/hbase/io/crypto/Encryption.getKeyProvider from org/apache/hadoop/hbase/io/crypto/Encryption.getSecretKeyForSubject (line 424) => Write to org/apache/hadoop/hbase/io/crypto/Encryption.java/util/Map(keyProviderCache) in org/apache/hadoop/hbase/io/crypto/Encryption.getKeyProvider (line 553)" Point hbase-it pom value for testFailureIgnore to value defined in main hbase pom,13305077,Open,Minor,,14/May/20 23:53,,1.6.0,The testFailureIgnore value in the hbase-it submodule pom is hard-coded to {{false}}; it should be changed to inherit the value defined in the main hbase pom to for consistency reasons. Fix typos in the HStore#compact annotation,13304281,Resolved,Minor,Fixed,12/May/20 06:15,12/May/20 15:42,1.2.6.1, TestJMXListener.setupBeforeClass can fail due to not getting a random port.,13302944,Resolved,Minor,Duplicate,05/May/20 18:54,11/May/20 17:57,,"[ERROR] Errors: [ERROR] TestJMXListener.setupBeforeClass:61 » IO Shutting down" The region should be removed from ConfigurationManager as a ConfigurationObserver when it is closed,13303388,Resolved,Minor,Fixed,07/May/20 13:04,11/May/20 12:03,,"When the region is opened, we register the region to the ConfigurationManager as a ConfigurationObserver object.However, when the region is closed, we don't deregister the region as a ConfigurationObserver object from the ConfigurationManager correspondingly. It's not a bug for now cos we can update the conf whenever the region is open or not.But it is bug-prone, and we should remove it from the ConfigureManager object when the region is closed." CloseChecker should think Pressure Aware Throughput Controller,13303981,Open,Minor,,11/May/20 01:59,,,"CloseChecker called from the compaction thread. In a compaction thread can sleep state by Pressure Aware Throughput Controller. As a result, the time-based check can be delayed." Remove deprecated CoprocessorService,13302890,In Progress,Minor,,05/May/20 14:36,,3.0.0-alpha-1,The interface {{CoprocessorService}} was deprecated in 2.0.0 and should be removed for 3.0.0. The max merge count of metafixer may be remind in hbase-site.xml,13297045,Resolved,Minor,Fixed,08/Apr/20 10:47,05/May/20 23:16,3.0.0-alpha-1,The max merge count of metafixer should be configurable in MetaFixer Remove deprecated setCacheDataInL1 in HColumnDescriptor,13302686,Resolved,Minor,Fixed,04/May/20 16:57,05/May/20 07:20,3.0.0-alpha-1,{{setCacheDataInL1}} in {{HColumnDescriptor}} was deprecated back in 2.0.0 and should be removed for 3.0.0. TestJMXConnectorServer can fail to start the minicluster due to it's port already having been chosen by another test.,13302772,Open,Minor,,05/May/20 01:20,,, "Make getServerName(String, int, long) private",13302435,Resolved,Minor,Duplicate,02/May/20 13:39,03/May/20 21:27,3.0.0-alpha-1,"{{getServerName(String, int, long)}} was marked deprecated in 2.0.0 with the option to make it private in 3.0.0. It should be made sure that it is marked as private in 3.0.0." Add region info when log meessages in HRegion.,13298182,Resolved,Minor,Fixed,14/Apr/20 05:07,14/Apr/20 12:06,3.0.0-alpha-1,"Some log message do not have region info when log, need to add it." shell命令扫描无法使用,13301491,Resolved,Minor,Invalid,28/Apr/20 08:54,28/Apr/20 15:09,1.2.1,在shell命令行查询字段值的时候想将byte转为string，用scan命令查询后没有效果，结果还是byte，但是get命令可以转为string Relax version numbers specified in Dockerfiles,13301340,Open,Minor,,27/Apr/20 16:46,,2.3.0,"It seems the version numbers used in our dockerfiles are too strict. As debian maintainers bump internal revisions, the old ones roll off, and our docker builds break. We should be less strict on the version numbers, but exactly how strict will need a package-by-package evaluation." Update Apache POM to version 23 for hbase-thirdparty,13299363,Resolved,Minor,Fixed,18/Apr/20 11:07,23/Apr/20 15:14,,Version 23 for the Apache parent POM has been released. We should update the hbase-thirdparty to use this one. [HBCK2] Remove removeExtraRegionsFromMeta from HBCK2 doc,13300402,Resolved,Minor,Fixed,23/Apr/20 01:26,23/Apr/20 10:35,hbase-operator-tools-1.0.0,"HBCK2 doc mentions about an internal method name, removeExtraRegionsFromMeta, which is called from the *extraRegionsInMeta --fix* command internally. https://github.com/apache/hbase-operator-tools/tree/master/hbase-hbck2#extra-regions-in-hbasemeta-regiontable-restorerebuild {noformat} Such problem can be addressed with the Master online, using the removeExtraRegionsFromMeta command in HBCK2. {noformat} We should replace with the right command." ChecksumUtil class validateChecksum method log level does not match,13300211,Resolved,Minor,Duplicate,22/Apr/20 09:00,23/Apr/20 10:21,2.2.0,"In the validateChecksum method of the ChecksumUtil class, still use LOG.info after judging LOG.isTraceEnabled. eg:  if (LOG.isTraceEnabled()) { LOG.info(""dataLength="" + buffer.capacity() + "", sizeWithHeader="" + onDiskDataSizeWithHeader + "", checksumType="" + cktype.getName() + "", file="" + pathName + "", offset="" + offset + "", headerSize="" + hdrSize + "", bytesPerChecksum="" + bytesPerChecksum); }" hbase,13300143,Resolved,Minor,Invalid,22/Apr/20 03:29,22/Apr/20 04:28,, Duplicate implementation for acquireLock between CreateTableProcedure and its parent class,13297600,Resolved,Minor,Fixed,10/Apr/20 11:14,18/Apr/20 02:40,2.2.4,The override method _acquireLock_ in _CreateTableProcedure_ and _InitMetaProcedure_ is the same as the implementation in its parent class _AbstractStateMachineTableProcedure_. So delete the override method in subclass. Wrong input argument order in TestCompactorMemLeak#assertMajorCompactionOK,13299190,Patch Available,Minor,,17/Apr/20 18:00,,2.2.4,"In TestCompactorMemLeak#assertMajorCompactionOK, the input argument order for  Assert.assertEquals(long expected, long actual) is wrong. This produced confusion when the test failed.   Below is the original code: {code:java} Assert.assertEquals(regions.size(), 1); HRegion region = regions.get(0); Assert.assertEquals(region.getStores().size(), 1); HStore store = region.getStore(FAMILY); Assert.assertEquals(store.getStorefilesCount(), 1); {code}" log when the region is set to closing status,13298188,Resolved,Minor,Fixed,14/Apr/20 06:25,17/Apr/20 19:22,,"When the region is closing, any incoming read or write request from users will receive an NotServingRegionException, so I think it is an very important point if we want to measure the unavailability duration and we should log the closing point. What do you guys think about it?" Refactor BufferedEncodedSeeker anonymous classes to named inner class,13298526,Resolved,Minor,Fixed,15/Apr/20 10:30,16/Apr/20 14:10,,BufferedEncodedSeeker has multiple anonymous inner sub-classes with huge code. Better to refactor them to named inner classes. [rsgroup] The master server aborted for IllegalThreadStateException,13297262,Resolved,Minor,Fixed,09/Apr/20 05:28,16/Apr/20 10:45,2.1.7,"if 'hbase.master.loadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer' and 'hbase.rsgroup.grouploadbalancer.class=org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer', The master server will aborted for IllegalThreadStateException. {code:java} 2020-04-09 11:24:26,142 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.IllegalThreadStateException at java.lang.Thread.start(Thread.java:705) at org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.start(RSGroupInfoManagerImpl.java:172) at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:417) at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.initialize(RSGroupBasedLoadBalancer.java:430) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2275) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:584) at java.lang.Thread.run(Thread.java:745) 2020-04-09 11:24:26,144 ERROR [master/xx.xx.xx.xx:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [org.apache.hadoop.hbase.security.access.AccessController, org.apache.hadoop.hbase.quotas.MasterQuotasObserver, org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint]{code}" BackPort HBASE-18651 to branch-1,13298518,Resolved,Minor,Fixed,15/Apr/20 09:40,16/Apr/20 02:14,,"Backport Jira : [HBASE-18651|https://issues.apache.org/jira/browse/HBASE-18651] to branch-1  " user_permission '.*' command failed to show all table permissions,13297928,Resolved,Minor,Fixed,13/Apr/20 02:57,14/Apr/20 02:49,,"When we grant somebody global permission, then we use '.*' as the argument of user_permission to show all table permissions, the following exception occurred: {code:java} hbase(main):001:0> grant 'user3', 'RW' Took 0.4144 seconds hbase(main):002:0> user_permission User Namespace,Table,Family,Qualifier:Permission user2 ,,,: [Permission: actions=READ,WRITE] user3 ,,,: [Permission: actions=READ,WRITE] hbaseadmin ,,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN] 3 row(s) Took 0.0445 seconds hbase(main):003:0> user_permission '.*' User Namespace,Table,Family,Qualifier:Permission user1 default,t1,,: [Permission: actions=READ,WRITE] hbaseadmin default,t1,,: [Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN] ERROR: failed to coerce org.apache.hadoop.hbase.security.access.GlobalPermission to org.apache.hadoop.hbase.security.access.TablePermissionFor usage try 'help ""user_permission""'Took 0.0940 seconds {code}" create-release fails to process x.y.0 version info correctly,13297487,Resolved,Minor,Fixed,09/Apr/20 22:04,10/Apr/20 19:05,,"Trying out {{create-release/do-release-docker.sh}}, is has trouble parsing the 2.3.0-SNAPSHOT version. It also builds an invalid tag name for the API check. {noformat} Current branch VERSION is 2.3.0-SNAPSHOT. RELEASE_VERSION [2.3.-1]: 2.3.0 NEXT_VERSION [2.3.0-SNAPSHOT]: 2.3.1-SNAPSHOT RC_COUNT [0]: GIT_REF [2.3.0RC0]: api_diff_tag, [rel/2.2.0)]: {noformat}" Add release branch report to git-jira-release-audit tool,13296954,Resolved,Minor,Fixed,08/Apr/20 00:00,09/Apr/20 16:29,,"Update {{git-jira-release-audit}} to build a ""what's new"" report for a release branch (i.e., {{branch-2.3}}). Currently it only supports building such a report from a release line branch (i.e., {{branch-2}})." rat plugin complains about having an unlicensed file.,13296725,Resolved,Minor,Fixed,07/Apr/20 03:48,07/Apr/20 16:20,,"Files with unapproved licenses:     dev-support/HOW_TO_YETUS_LOCAL.md" Update Apache POM to version 23 for hbase-operator-tools,13296226,Resolved,Minor,Fixed,04/Apr/20 22:08,06/Apr/20 08:53,,Version 23 for the Apache parent POM has been released. We should update the hbase-operator-tools to use this one. Move to Apache parent POM version 23 for connectors,13296005,Resolved,Minor,Fixed,03/Apr/20 10:24,04/Apr/20 20:47,,Version 23 for the Apache parent POM has been released. We should update the hbase-connectors to use this one. Passing '-h' or '--help' to bin/hbase doesn't do as expected,13311175,Resolved,Trivial,Fixed,12/Jun/20 17:19,19/Jun/20 17:42,,"If I do 'bin/hbase -h' or './bin/hbase --help', it doesn't dump usage as I'd expect. Instead, the param gets passed direct to the jvm for it to spew complaint that the param is unrecognized. Should do the right thing." hbase-filesystem to use hbase-thirdparty 3.2.0,13296635,Open,Trivial,,06/Apr/20 19:12,,hbase-filesystem-1.0.0-alpha1,hbase-filesystem is currently on hbase-thirdparty 2.2.1. Update it to 3.2.0 so we can use the latest guava. Doc WALSplitter classes,13311835,Resolved,Trivial,Fixed,16/Jun/20 23:06,17/Jun/20 22:01,,Trivial. Added doc to classes and added trace-level logging so can better study this feature in action (added it to old impl too). Why ProtobufUtil does not set scan's limit,13309698,Resolved,Trivial,Not A Bug,05/Jun/20 11:12,06/Jun/20 07:10,2.2.5,"{code:java} //ProtobufUtil /** * Convert a client Scan to a protocol buffer Scan * * @param scan the client Scan to convert * @return the converted protocol buffer Scan * @throws IOException */ public static ClientProtos.Scan toScan( final Scan scan) throws IOException { ClientProtos.Scan.Builder scanBuilder = ClientProtos.Scan.newBuilder(); scanBuilder.setCacheBlocks(scan.getCacheBlocks()); if (scan.getBatch() > 0) { scanBuilder.setBatchSize(scan.getBatch()); } if (scan.getMaxResultSize() > 0) { scanBuilder.setMaxResultSize(scan.getMaxResultSize()); } if (scan.isSmall()) { scanBuilder.setSmall(scan.isSmall()); } if (scan.getAllowPartialResults()) { scanBuilder.setAllowPartialResults(scan.getAllowPartialResults()); } Boolean loadColumnFamiliesOnDemand = scan.getLoadColumnFamiliesOnDemandValue(); if (loadColumnFamiliesOnDemand != null) { scanBuilder.setLoadColumnFamiliesOnDemand(loadColumnFamiliesOnDemand); } scanBuilder.setMaxVersions(scan.getMaxVersions()); scan.getColumnFamilyTimeRange().forEach((cf, timeRange) -> { scanBuilder.addCfTimeRange(HBaseProtos.ColumnFamilyTimeRange.newBuilder() .setColumnFamily(UnsafeByteOperations.unsafeWrap(cf)) .setTimeRange(toTimeRange(timeRange)) .build()); }); scanBuilder.setTimeRange(ProtobufUtil.toTimeRange(scan.getTimeRange())); Map attributes = scan.getAttributesMap(); if (!attributes.isEmpty()) { NameBytesPair.Builder attributeBuilder = NameBytesPair.newBuilder(); for (Map.Entry attribute: attributes.entrySet()) { attributeBuilder.setName(attribute.getKey()); attributeBuilder.setValue(UnsafeByteOperations.unsafeWrap(attribute.getValue())); scanBuilder.addAttribute(attributeBuilder.build()); } } byte[] startRow = scan.getStartRow(); if (startRow != null && startRow.length > 0) { scanBuilder.setStartRow(UnsafeByteOperations.unsafeWrap(startRow)); } byte[] stopRow = scan.getStopRow(); if (stopRow != null && stopRow.length > 0) { scanBuilder.setStopRow(UnsafeByteOperations.unsafeWrap(stopRow)); } if (scan.hasFilter()) { scanBuilder.setFilter(ProtobufUtil.toFilter(scan.getFilter())); } if (scan.hasFamilies()) { Column.Builder columnBuilder = Column.newBuilder(); for (Map.Entry> family: scan.getFamilyMap().entrySet()) { columnBuilder.setFamily(UnsafeByteOperations.unsafeWrap(family.getKey())); NavigableSet qualifiers = family.getValue(); columnBuilder.clearQualifier(); if (qualifiers != null && qualifiers.size() > 0) { for (byte [] qualifier: qualifiers) { columnBuilder.addQualifier(UnsafeByteOperations.unsafeWrap(qualifier)); } } scanBuilder.addColumn(columnBuilder.build()); } } if (scan.getMaxResultsPerColumnFamily() >= 0) { scanBuilder.setStoreLimit(scan.getMaxResultsPerColumnFamily()); } if (scan.getRowOffsetPerColumnFamily() > 0) { scanBuilder.setStoreOffset(scan.getRowOffsetPerColumnFamily()); } if (scan.isReversed()) { scanBuilder.setReversed(scan.isReversed()); } if (scan.getConsistency() == Consistency.TIMELINE) { scanBuilder.setConsistency(toConsistency(scan.getConsistency())); } if (scan.getCaching() > 0) { scanBuilder.setCaching(scan.getCaching()); } long mvccReadPoint = PackagePrivateFieldAccessor.getMvccReadPoint(scan); if (mvccReadPoint > 0) { scanBuilder.setMvccReadPoint(mvccReadPoint); } if (!scan.includeStartRow()) { scanBuilder.setIncludeStartRow(false); } scanBuilder.setIncludeStopRow(scan.includeStopRow()); if (scan.getReadType() != Scan.ReadType.DEFAULT) { scanBuilder.setReadType(toReadType(scan.getReadType())); } if (scan.isNeedCursorResult()) { scanBuilder.setNeedCursorResult(true); } return scanBuilder.build(); } {code}" Remove duplicated dependency declaration in hbase-hadoop-compat,13303044,Resolved,Trivial,Fixed,06/May/20 07:39,06/May/20 12:22,3.0.0-alpha-1,"Currently hbase-metrics-api is declared twice with hbase-hadoop-compat. This leads to the following warning in Maven: {code} [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.hbase:hbase-hadoop-compat:jar:3.0.0-SNAPSHOT [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.hbase:hbase-metrics-api:jar -> duplicate declaration of version (?) @ line 113, column 19 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] {code} One declaration should be removed." Clean up root pom after removing hadoop-2.0 profile,13300401,Resolved,Trivial,Fixed,23/Apr/20 01:26,04/May/20 21:05,3.0.0-alpha-1,HBASE-24170 removed hadoop-2.0 profile and hadoop.guava.version is therefore not used afterwards. The Java doc for minFilesToCompact is wrong,13301603,Resolved,Trivial,Fixed,28/Apr/20 16:11,29/Apr/20 05:10,,"It is the lower bound, not the upper bound on number of files to be included in minor compactions, its name reveals that clearly. I think it is a slip of the pen" Fix thirdparty-3.2.0 release notes,13301608,Resolved,Trivial,Fixed,28/Apr/20 16:30,28/Apr/20 17:12,thirdparty-3.2.0,The RELEASENOTES for hbase-thirdparty-3.2.0 contains gson upgrade which was reverted before the release. Add .idea directory to Gitignore in hbase-thirdparty,13299515,Resolved,Trivial,Fixed,19/Apr/20 19:04,24/Apr/20 18:02,,The Gitignore file in hbase-thirdparty should be extended to ignore files generated by IntelliJ. Remove unnecessary super() in MultiVersionConcurrencyControl#MultiVersionConcurrencyControl(),13297341,Resolved,Trivial,Fixed,09/Apr/20 10:14,10/Apr/20 22:47,, correct parsing of hbase shell args with GetoptLong,13415680,Resolved,Blocker,Fixed,06/Dec/21 21:08,08/Jan/22 04:47,2.5.0,"shell cli arg parsing is broken: * debug is eating a possible arg * -D handling is consuming part of ARGV without declaring it * -Dfoo=bar no longer works * non-interactive mode is eating a possible arg * top level definitions is eating a possible arg * script2run is being ignored entirely" Tracing Spans of RPCs should follow otel semantic conventions,13409954,Resolved,Blocker,Fixed,03/Nov/21 23:28,03/May/22 00:30,2.5.0,The OpenTelemetry project has a [conventions document|https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/rpc.md] for RPCs that is pretty prescriptive. One thing I noticed is that it requires there be spans named as {{$package.$service/$method}} ; we don't do this. We should address this and any other gaps. Upgrade hbase-thirdparty dependency to 4.0.1,13414651,Resolved,Blocker,Fixed,01/Dec/21 02:23,18/May/22 23:30,2.5.0, Document new provided compression codecs,13405098,Resolved,Blocker,Fixed,06/Oct/21 01:59,07/May/22 18:26,,"Document the new compression codecs: - The configuration keys used for setting the codec implementations for the various algorithms - The provided compression codecs - Default schema recommendations (LZ4) - Default WAL value compression recommendations (Snappy (aircompressor))" Fix the broken shaded protobuf module,13418150,Resolved,Blocker,Fixed,17/Dec/21 04:28,17/Dec/21 13:16,,"First, we should include the proto files in the final uber jar. Second, we should not pull in the protobuf-java dependency as we always include everything in the uber jar." "[site, branch-2] DependencyManagement report is broken",13415102,Resolved,Blocker,Fixed,02/Dec/21 17:00,06/Dec/21 01:42,2.5.0,"[INFO] Generating ""Dependency Management"" report --- maven-project-info-reports-plugin:3.0.0:dependency-management [WARNING] Unable to create Maven project for org.xerial.snappy:snappy-java:jar:1.1.8.4 from repository. org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs: [ERROR] Unknown packaging: bundle @ line 6, column 16 Seems caused by org.xerial.snappy:snappy-java dependency introduced by HBASE-26259" Tracing INSTRUMENTATION_NAME is incorrect,13409564,Resolved,Blocker,Fixed,01/Nov/21 23:53,10/Nov/21 05:59,2.5.0,"I believe the value we use for {{TraceUtil#INSTRUMENTATION_NAME}}, {{""io.opentelemetry.contrib.hbase""}}, is incorrect. According to the java docs, {noformat} * @param instrumentationName The name of the instrumentation library, not the name of the * instrument*ed* library (e.g., ""io.opentelemetry.contrib.mongodb""). Must not be null. {noformat} This namespace appears to be reserved for implementations shipped by the otel project, found under https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation I don't have a suggestion for a suitable name at this time. Will report back." Changing SFT implementation on disabled table is dangerous,13418446,Resolved,Critical,Fixed,19/Dec/21 14:42,15/Mar/22 12:56,,"As our current design is to have a MIGRATION SFT so when region opens, we will mirror the store files to the dst SFT. But for a disabled table, the region will not be reopened so we have no chance to mirror the store files list, so after user enable the table, it may find out that all the store files are gone..." Should not rely on the global config when setting SFT implementation for a table while upgrading,13418022,Resolved,Critical,Fixed,16/Dec/21 15:24,07/Jan/22 15:49,,"If a table does not have a SFT implementation in its table descriptor, it means we are upgrading from an older version where SFT is not implemented, so the SFT implementation for the table should always be DEFAULT. A misconfigure here could cause data loss." correct HBase shell exit behavior to match code passed to exit,13412712,Resolved,Critical,Fixed,19/Nov/21 07:04,15/Jan/22 20:51,2.4.8,"The HBase shell has changed behavior in a way that breaks being able to exit properly. Two example scripts to act as stand ins for hbase shell scripts to ""do something simple then exit"": {code} tmp % echo ""list\nexit"" > clean_exit.rb tmp % echo ""list\nexit 1"" > error_exit.rb {code} Giving these two scripts is possible: * passed as a cli argument * via redirected stdin Additionally the shell invocation can be: * in the default compatibility mode * with the ""non interactive"" flag that gives an exit code that reflects runtime errors I'll post logs of the details as attachments but here are some tables of the exit codes. The {{clean_exit.rb}} invocations ought to exit with success, exit code 0. || || 1.4.14 || 1.7.1 || 2.0.6 || 2.1.9 || 2.2.7 || 2.3.7 || 2.4.8 || master || | cli, default | 0 | 0 | 0 | 0 | 0 | 0 | 1 | 1* | | cli, -n | 0 | 0 | 0 | 0 | 0 | 0 | 1 | hang | | stdin, default | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | stdin, -n | 1 | 1 | 1 | 1 | 1 | 1 | 1* | 1* | The {{error_exit.rb}} invocation should return a non-zero exit code, unless we're specifically trying to match a normal hbase shell session. || || 1.4.14 || 1.7.1 || 2.0.6 || 2.1.9 || 2.2.7 || 2.3.7 || 2.4.8 || master || | cli, default | 1 | 1 | 1 | 1 | 1 | 1 | 1* | 1* | | cli, -n | 1 | 1 | 1 | 1 | 1 | 1 | 1* | hang | | stdin, default | 0 | 0 | 0 | 0 | 0 | 0 | 0 | 0 | | stdin, -n | 1 | 1 | 1 | 1 | 1 | 1 | 1* | 1* | In cases marked with * the error details are different. The biggest concern are the new-to-2.4 non-zero exit code when we should have a success and the hanging. The former looks like this: {code} ERROR NoMethodError: private method `exit' called for nil:NilClass {code} The change in error details for the error exit script also shows this same detail. This behavior appears to be a side effect of HBASE-11686. As far as I can tell, the IRB handling of 'exit' calls fail because we implement our own handling of sessoins rather than rely on the intended session interface. We never set a current session, and IRB's exit implementation presumes there will be one. Running in debug shows this in a stacktrace: {code} Took 0.4563 seconds ERROR NoMethodError: private method `exit' called for nil:NilClass NoMethodError: private method `exit' called for nil:NilClass irb_exit at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/extend-command.rb:30 evaluate at stdin:2 eval at org/jruby/RubyKernel.java:1048 evaluate at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/workspace.rb:85 eval_io at uri:classloader:/shell.rb:327 each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:246 loop at org/jruby/RubyKernel.java:1442 each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:232 catch at org/jruby/RubyKernel.java:1189 each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:231 eval_io at uri:classloader:/shell.rb:326 classpath:/jar-bootstrap.rb at classpath:/jar-bootstrap.rb:194 exception_handler at uri:classloader:/shell.rb:339

at classpath:/jar-bootstrap.rb:194 {code} And in our version of IRB (0.9.6) [line 30 for extend-commands|https://github.com/ruby/irb/blob/v0.9.6/lib/irb/extend-command.rb#L30] corresponds to this code: {code} # Quits the current irb context # # +ret+ is the optional signal or message to send to Context#exit # # Same as IRB.CurrentContext.exit. def irb_exit(ret = 0) irb_context.exit(ret) end {code} " HMaster may clean wals that is replicating in rare cases,13413319,Closed,Critical,Fixed,23/Nov/21 07:07,05/Dec/21 14:26,,"In our cluster, i can found some FileNotFoundException when ReplicationSourceWALReader running for replication recovery queue. I guss the wal most likely removed by hmaste. And i found something to support it. The method getAllWALs: [https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java#L509   |https://github.com/apache/hbase/blob/master/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ZKReplicationQueueStorage.java#L509]Use zk cversion of /hbase/replication/rs as an optimistic lock to control concurrent ops. But, zk cversion *only can only reflect the changes of child nodes, but not the changes of grandchildren.* So, HMaster may loss some wal from this method in follow situation. # HMaster do log clean , and invoke getAllWALs to filter log which should not be deleted. # HMaster cache current cversion of /hbase/replication/rs  as *v0* # HMaster cache all RS server name, and traverse them, get the WAL in each Queue # *RS2* dead after HMaster traverse {*}RS1{*}, and before traverse *RS2* # *RS1* claim one queue of *RS2,* which named *peerid-RS2* now # By the way , the cversion of /hbase/replication/rs not changed before all of *RS2* queue is removed, because the children of /hbase/replication/rs not change. # So, Hmaster will lost the wals in *peerid-RS2,* because we have already traversed *RS1 ,* and ** this queue not exists in *RS2* The above expression is currently only speculation, not confirmed Flie Not Found Log.   {code:java} // code placeholder 2021-11-22 15:18:39,593 ERROR [ReplicationExecutor-0.replicationSource,peer_id-hostname,60020,1636802867348.replicationSource.wal-reader.hostname%2C60020%2C1636802867348,peer_id-hostname,60020,1636802867348] regionserver.WALEntryStream: Couldn't locate log: hdfs://namenode/hbase/oldWALs/hostname%2C60020%2C1636802867348.1636944748704 2021-11-22 15:18:39,593 ERROR [ReplicationExecutor-0.replicationSource,peer_id-hostname,60020,1636802867348.replicationSource.wal-reader.hostname%2C60020%2C1636802867348,peer_id-hostname,60020,1636802867348] regionserver.ReplicationSourceWALReader: Failed to read stream of replication entries java.io.FileNotFoundException: File does not exist: hdfs://namenode/hbase/oldWALs/hostname%2C60020%2C1636802867348.1636944748704         at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1612)         at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1605)         at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)         at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1620)         at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:64)         at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.init(ProtobufLogReader.java:168)         at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:321)         at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:303)         at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:291)         at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:427)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:355)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:303)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:294)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:175)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:192)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:138) {code}    " Address recent the log4j2 CVEs,13416776,Resolved,Critical,Fixed,11/Dec/21 13:00,28/Jan/22 13:25,,"https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-44228 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45046 https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45105" MemStoreLAB may be released early when its SegmentScanner is scanning,13412512,Resolved,Critical,Fixed,18/Nov/21 11:21,25/Nov/21 13:39,2.5.0,"HBASE-26144 moved {{MemStore.clearSnapshot}} out of write lock of {{HStore#lock}}, but because {{MemStore.clearSnapshot}} closed {{DefaultMemStore#snapshot}} which may be used by {{DefaultMemStore#getScanners}}, when {{DefaultMemStore#getScanners}} and {{MemStore}} flushing execute conurrently, {{MemStoreLAB}} used by {{DefaultMemStore#snapshot}} may be released early when its {{SegmentScanner}} is scanning. Considering follow thread sequences: 1.The flush thread starts {{DefaultMemStore}} flushing after some cells have be added to {{DefaultMemStore}}. 2.The flush thread stopping before {{DefaultMemStore#clearSnapshot}} in following line 1238 in {{HStore#updateStorefiles}} after completed flushing memStore to hfile. {code:java} 1221 private boolean updateStorefiles(List sfs, long snapshotId) throws IOException { 1222 this.lock.writeLock().lock(); 1223 try { 1224 this.storeEngine.getStoreFileManager().insertNewFiles(sfs); 1225 } finally { 1226 // We need the lock, as long as we are updating the storeFiles 1227 // or changing the memstore. Let us release it before calling 1228 // notifyChangeReadersObservers. See HBASE-4485 for a possible 1229 // deadlock scenario that could have happened if continue to hold 1230 // the lock. 1231 this.lock.writeLock().unlock(); 1232 } 1233 // We do not need to call clearSnapshot method inside the write lock. 1234 // The clearSnapshot itself is thread safe, which can be called at the same time with other 1235 // memstore operations expect snapshot and clearSnapshot. And for these two methods, in HRegion 1236 // we can guarantee that there is only one onging flush, so they will be no race. 1237 if (snapshotId > 0) { 1238 this.memstore.clearSnapshot(snapshotId); 1239 } ...... {code} 3.The scan thread starts and stopping after {{DefaultMemStore.snapshot.getAllSegments}} in following line 141 in {{DefaultMemStore#getScanners}},here the scan thread gets the {{DefaultMemStore#snapshot}} which is created by the flush thread. {code:java} 138 public List getScanners(long readPt) throws IOException { 139 List list = new ArrayList<>(); 140 addToScanners(getActive(), readPt, list); 141 addToScanners(snapshot.getAllSegments(), readPt, list); 142 return list; 143 } {code} 4.The flush thread continues {{DefaultMemStore#clearSnapshot}} and close {{DefaultMemStore#snapshot}} in following line 253,because the reference count of the corresponding {{MemStoreLABImpl}} is decreased to 0, the Chunks in corresponding {{MemStoreLABImpl}} are recycled. {code:java} 240 public void clearSnapshot(long id) throws UnexpectedStateException { ...... 248 Segment oldSnapshot = this.snapshot; 249 if (!this.snapshot.isEmpty()) { 250 this.snapshot = SegmentFactory.instance().createImmutableSegment(this.comparator); 251 } 252 this.snapshotId = NO_SNAPSHOT_ID; 253 oldSnapshot.close(); 254 } {code} 5.The scan thread continues {{DefaultMemStore#getScanners}}, and create a {{SegmentScanner}} for this {{DefaultMemStore#snapshot}}, and invokes {{MemStoreLABImpl.incScannerCount}} in line 281 to increase the reference count , but here {{MemStoreLABImpl.incScannerCount}} does not check that the reference count is already 0 and {{Chunks}} are already recycled by step 4, so these {{Chunks}} may be overwritten by other write threads when the {{SegmentScanner}} is scanning, which may cause serious problem. {code:java} 280 public void incScannerCount() { 281 this.openScannerCount.incrementAndGet(); 282 } {code} I simulate above case in my PR, and my Fix is as following: 1.Moving {{MemStore.clearSnapshot}} back under write lock of {{HStore#lock}}, because {{DefaultMemStore#getScanners}} is protected under the read lock of {{HStore#lock}}, so {{DefaultMemStore#getScanners}} and {{DefaultMemStore#clearSnapshot}} could not execute concurrently. 2. Introducing {{RefCnt}} into {{MemStoreLABImpl}} to replace its flawed reference count implementation, so checking and increasing or decreasing is done in atomicity and if there is illegal state in reference count, it would throw exception rather than using corrupt data, but this modification is not included in PR now because I find that there is another bug HBASE-26488 would disrupt the reference count in {{MemStoreLABImpl}} , I would Introduce {{RefCnt}} after fixing this another bug in HBASE-26494." Should persist restoreAcl flag in the procedure state for CloneSnapshotProcedure and RestoreSnapshotProcedure,13412405,Resolved,Critical,Fixed,18/Nov/21 02:26,06/Dec/21 15:29,,Found this when reviewing HBASE-26454. Close netty channel causes regionserver crash in handleTooBigRequest,13412295,Open,Critical,,17/Nov/21 15:06,,2.0.0,"In HBASE-26170, I proposed the coredump problem after calling handleTooBigRequest, but that issue did not resolve the regionserver crash problem, which occurs before the WAL corruption in HBASE-24984. After looking through the codes, I think the problem is in CLOSE channel.  The direct byte buffer used by RPC call request is allocated by Netty, though we add a reference count to record when to release the direct byte buffer, the byte buffer is managed by Netty actually. It is allocated from Netty PoolArena, and is released there.  When the HBase ipc handler is processing a request, the Netty channel handler can process the channel events and message coming back in succession. When there is a too big request by NettyRpcFrameDecoder, the channel will be closed, and all the resources of the channel will be released, though there is HBase ipc handlers using the direct byte buffer to process previous requests. Netty provides two methods to request the pooled byte buffer, one is through the PoolThreadCache, each handler thread owns a private one. Another is through PoolArena#allocateNormal. Each ChannelHandler has a local PoolThreadCache. When a new Netty channel is created, a new ChannelHandler instance is created.  And when a channel is closed, the relevant channel handler will be removed from the pipeline. I found this annotation in the Channel class of Netty, {code:java} It is important to call close() or close(ChannelPromise) to release all resources once you are done with the Channel. This ensures all resources are released in a proper way, i.e. filehandles. {code} And when channel handler is removed in ByteToMessageDecoder#handlerRemoved, it will release the byte buffer, {code:java} @Override public final void handlerRemoved(ChannelHandlerContext ctx) throws Exception { if (decodeState == STATE_CALLING_CHILD_DECODE) { decodeState = STATE_HANDLER_REMOVED_PENDING; return; } ByteBuf buf = cumulation; if (buf != null) { // Directly set this to null so we are sure we not access it in any other method here anymore. cumulation = null; int readable = buf.readableBytes(); if (readable > 0) { ByteBuf bytes = buf.readBytes(readable); buf.release(); ctx.fireChannelRead(bytes); } else { buf.release(); } ... {code} We should not close the channel when encountering too big request, I think it should just skip the bytes like that in LengthFieldBasedFrameDecoder." Wrong Cell Generated by MemStoreLABImpl.forceCopyOfBigCellInto when Cell size bigger than data chunk size ,13412621,Resolved,Critical,Fixed,18/Nov/21 18:37,21/Nov/21 13:11,,"In our company 2.X cluster. I found some region compaction keeps failling because some cell can't construct succefully. In fact , we even can't read these cell. From follow stack , we can found the bug cause KeyValue can't constructed. Simple Log and Stack:  {code:java} // code placeholder 2021-11-18 16:50:47,708 ERROR [regionserver/xxxx:60020-longCompactions-4] regionserver.CompactSplit: Compaction failed region=xx_table,3610ff49595a0fc4a824f2a575f37a31,1570874723992.dac703ceb35e8d8703233bebf34ae49f., storeName=c, priority=-319, startTime=1637225447127 java.lang.IllegalArgumentException: Invalid tag length at position=4659867, tagLength=0,          at org.apache.hadoop.hbase.KeyValueUtil.checkKeyValueTagBytes(KeyValueUtil.java:685)         at org.apache.hadoop.hbase.KeyValueUtil.checkKeyValueBytes(KeyValueUtil.java:643)         at org.apache.hadoop.hbase.KeyValue.(KeyValue.java:345)         at org.apache.hadoop.hbase.SizeCachedKeyValue.(SizeCachedKeyValue.java:43)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.getCell(HFileReaderImpl.java:981)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:233)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekScanners(StoreScanner.java:418)         at org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:322)         at org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:288)         at org.apache.hadoop.hbase.regionserver.compactions.Compactor.createScanner(Compactor.java:487)         at org.apache.hadoop.hbase.regionserver.compactions.Compactor$1.createScanner(Compactor.java:248)         at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:318)         at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:65)         at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:126)         at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1468)         at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2266)         at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:624)         at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:666)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:748) {code} From further observation, I found the following characteristics: # Cell size more than 2M # We can reproduce the bug only after in memory compact # Cell bytes end with \x00\x02\x00\x00   In fact, the root reason is method (MemStoreLABImpl.forceCopyOfBigCellInto) which only invoked when cell bigger than data chunk size construct cell with wrong length.  So there are 4 bytes (chunk head size) append end of the cell bytes." [hboss] Rename does not clean up znodes for src location,13410933,Resolved,Critical,Fixed,09/Nov/21 22:27,18/Nov/21 01:16,hbase-filesystem-1.0.0-alpha1,"We ran into a fun situation where the partition hosting ZK data was repeatedly filling up while heavy ExportSnapshot+clone_snapshot operations were running (10's of TB). The cluster was previously working just fine. Upon investigation of the ZK tree, we found a large number of znodes beneath /hboss, specifically many in the corresponding ZK HBOSS path for $hbase.rootdir/.tmp. Tracing back from the code, we saw that the CloneSnapshotProcedure (like CreateTableProcedure) will create the table filesystem layout in $hbase.rootdir/.tmp and then rename it into $hbase.rootdir/data/. However, it appears that, upon rename, HBOSS was not cleaning up the src path's znode. This is a bug as it allows ZK to grow unbounded (which explains why this problem slowly arose and not suddenly). As a workaround, HBase can be stopped and the corresponding ZK path for $hbase.rootdir/.tmp can be cleaned up to reclaim 1/2 the space taken up by znodes for imported hbase tables (we would still have znodes for $hbase.rootdir/data/...)" [hboss] removeInMemoryLocks can remove still in-use locks,13411511,Resolved,Critical,Fixed,12/Nov/21 15:59,18/Nov/21 01:16,hbase-filesystem-1.0.0-alpha1,"While implementing HBASE-26437, I was fighting with unit tests which just wouldn't complete. After adding the code change to delete the locks held by the {{src}} in a {{mv src dst}} operation, releasing the {{dst}} lock would claim that the current thread doesn't hold the lock. After investigating, the specific contract test in question is doing a rename of the form: {{{}mv /foo /foodest{}}}. This actually breaks the logic which tries to determine if a lock's path is contained beneath the path we're tryign to clean up. Specifically: cleaning up locks beneath {{/foo}} incorrectly removes locks for {{/foodest}}" HBCK incorrectly reports inconsistencies for recently split regions following a master failover,13407467,Resolved,Critical,Fixed,20/Oct/21 09:15,20/Oct/21 22:50,2.4.3,"When a region P splits into A and B, following a master failover the newly active master reports that P is in an inconsistent state. This seems to be a regression introduced in HBASE-25847 (cc [~andrew.purtell@gmail.com]) which changed {{regionInfo.isParentSplit()}} to {{regionState.isSplit()}}. The region state after restart is CLOSED (rather than SPLIT), so both region state and region info should be checked, presumably with {{regionState.isSplit() || regionInfo.isSplit()}}. This situation resolves itself on its own when a major compaction occurs and P is GCed, but having the master incorrectly report inconsistencies is pretty bad. We had a pretty big outage due to a series of operator errors as our SRE team was trying to fix this inconsistency that, in fact, didn't even exist. Thanks to Stack for helping look over this issue and Vlad Hanciuta for root causing the bug." Update downloads.xml for release 2.4.9,13419388,Resolved,Major,Fixed,24/Dec/21 22:59,24/Dec/21 22:59,, Update download page for HBase Operator Tools to 1.2.0,13419357,Resolved,Major,Fixed,24/Dec/21 11:14,25/Dec/21 06:26,, Wal do not roll and write a big wal ,13409395,Open,Major,,01/Nov/21 09:39,,2.4.8,"We see wal have long time to roll and write a big wal which has 3TB. And according to the jstack we can see the wal create hang. {code} ""regionserver/11.149.48.227:60020.logRoller"" #667 daemon prio=5 os_prio=0 cpu=116916.81ms elapsed=447455.26s tid=0x00007fa35d231000 nid=0xbdd2 waiting on condition [0x00007f79c7407000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00007f9f10df5158> (a java.util.concurrent.CompletableFuture$Signaller) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1707) at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323) at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1742) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908) at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.write(AsyncProtobufLogWriter.java:178) at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeMagicAndWALHeader(AsyncProtobufLogWriter.java:191) at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:170) at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:113) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:615) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:126) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:763) at org.apache.hadoop.hbase.regionserver.LogRoller.run(LogRoller.java:184) at java.lang.Thread.run(Thread.java:748) {code}" Run some tests to verify the new region replication framework,13413958,Resolved,Major,Fixed,26/Nov/21 07:20,18/Dec/21 05:41,,Make sure there is no big bugs before merging back. [JDK17] Jenkins build support,13407338,Resolved,Major,Implemented,19/Oct/21 16:22,26/Oct/24 13:40,,We'll need to update our build infrastructure to include a JDK17 environment. Post blog to hbase.apache.org on SCR cache sizing,13404565,Resolved,Major,Fixed,02/Oct/21 02:47,05/Oct/21 15:53,,[~huaxiangsun] and I wrote up our experience debugging a Short-circuit Read cache size issue. Let me attach link here and leave it hang here a few days in case edits or input from others.  Intend to put it up here https://blogs.apache.org/hbase/ hbase shell config override option does not work,13414286,Resolved,Major,Fixed,29/Nov/21 11:59,16/Sep/24 06:58,3.0.0-alpha-2,"According to the docs, we should be able to specify properties on the command line with the -D switch. https://hbase.apache.org/book.html#_overriding_configuration_starting_the_hbase_shell However: {noformat} ./bin/hbase shell -Dhbase.zookeeper.quorum=ZK0.remote.cluster.example.org,ZK1.remote.cluster.example.org,ZK2.remote.cluster.example.org -Draining=false Usage: shell [OPTIONS] [SCRIPTFILE [ARGUMENTS]] -d | --debug Set DEBUG log levels. -h | --help This help. -n | --noninteractive Do not run within an IRB session and exit with non-zero status on first error. --top-level-defs Compatibility flag to export HBase shell commands onto Ruby's main object -Dkey=value Pass hbase-*.xml Configuration overrides. For example, to use an alternate zookeeper ensemble, pass: -Dhbase.zookeeper.quorum=zookeeper.example.org For faster fail, pass the below and vary the values: -Dhbase.client.retries.number=7 -Dhbase.ipc.client.connect.max.retries=3 classpath:/jar-bootstrap.rb: invalid option -- b GetoptLong::InvalidOption: invalid option -- b set_error at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/getoptlong.rb:395 get at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/getoptlong.rb:572 each at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/getoptlong.rb:603 loop at org/jruby/RubyKernel.java:1442 each at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/getoptlong.rb:602
at classpath:/jar-bootstrap.rb:98 {noformat} Something is broken in the command line parsing." Use unique thread name for group WALs,13414700,Resolved,Major,Fixed,01/Dec/21 08:22,21/May/24 08:30,2.0.0,"The consumer threads for each WAL group has the same name, since they only use the WAL root dir in the thread name. {code:java} new ThreadFactoryBuilder().setNameFormat(""AsyncFSWAL-%d-"" + rootDir.toString()). setDaemon(true).build()); {code} For example, for BoundedGroupingStrategy, the consumer threads names are as follows, !image-2021-12-01-16-20-18-912.png|width=1199,height=130! We can use the log prefix instead, the consumer threads names will be changed to !image-2021-12-02-17-38-21-959.png|width=1102,height=197! So we can clearly see what happens from the log and the jstack info if something wrong with the WAL.  " CreateTableProcedure fails when FileBasedStoreFileTracker is set in global config,13404796,Resolved,Major,Fixed,04/Oct/21 14:27,13/Oct/21 14:50,,"CreateTableProcedure tries to instantiate SFT impl in its preCreate method so that the given SFT impl can update the tbl descriptor with all its required configs. When global config is set to FILE, FileBasedStoreFileTracker currently needs store dir path at its construction time (via the passed StoreContext param), but we don't have this info at this stage, so FileBasedStoreFileTracker get's an NPE: {noformat} 2021-10-01 14:28:21,310 ERROR org.apache.hadoop.hbase.procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception: pid=54, state=RUNNABLE:CREATE_TABLE_PRE_OPERATION, locked=true; CreateTableProcedure table=test-3 java.lang.UnsupportedOperationException: Constructor threw an exception for org.apache.hadoop.hbase.regionserver.storefiletracker.MigrationStoreFileTracker at org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:66) at org.apache.hadoop.hbase.util.ReflectionUtils.newInstance(ReflectionUtils.java:72) at org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.create(StoreFileTrackerFactory.java:107) at org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.persistTrackerConfig(StoreFileTrackerFactory.java:164) at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.preCreate(CreateTableProcedure.java:274) at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:102) at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:58) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:194) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1662) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1409) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1979) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:58) ... 12 more Caused by: java.lang.UnsupportedOperationException: Constructor threw an exception for org.apache.hadoop.hbase.regionserver.storefiletracker.FileBasedStoreFileTracker at org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:66) at org.apache.hadoop.hbase.util.ReflectionUtils.newInstance(ReflectionUtils.java:72) at org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileTrackerFactory.createForMigration(StoreFileTrackerFactory.java:157) at org.apache.hadoop.hbase.regionserver.storefiletracker.MigrationStoreFileTracker.(MigrationStoreFileTracker.java:50) ... 17 more Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:58) ... 20 more Caused by: java.lang.NullPointerException at org.apache.hadoop.fs.Path.(Path.java:146) at org.apache.hadoop.fs.Path.(Path.java:125) at org.apache.hadoop.hbase.regionserver.storefiletracker.StoreFileListFile.(StoreFileListFile.java:70) at org.apache.hadoop.hbase.regionserver.storefiletracker.FileBasedStoreFileTracker.(FileBasedStoreFileTracker.java:59) ... 25 more {noformat}" Clone snapshot doesn't load reference files into FILE SFT impl,13404956,Resolved,Major,Fixed,05/Oct/21 10:13,22/Oct/21 15:56,,"After cloning a snapshot from a FILE SFT enabled table, noticed that none of the cloned table files were added into the FILE SFT meta files, in fact, FILE SFT meta dir didn't even got created. Scanning this cloned table gives no results, as none of the files are tracked. I believe we need to call StoreFileTracker.add during the snapshot cloning." Refactor StoreFileTracker implementations to expose the set method,13407509,Resolved,Major,Fixed,20/Oct/21 12:59,21/Oct/21 02:28,,"As when clone/restore a snapshot, we need to set the store file list directly to StoreFileTracker, which means we need this method in upper layer." CreateTableProcedure still relies on temp dir and renames when creating table FS layout,13411515,Resolved,Major,Fixed,12/Nov/21 16:29,19/Nov/21 12:17,,"As pointed by [~elserj] when reviewing some other issue, internally, CreateTableProcedure still creates the FS layout on temp folder first, then rename to actual dir. I think this is unnecessary, we could create it straight in the final dir, just like we did in [CloneSnapshotProcedure here|https://github.com/apache/hbase/pull/3749/files#r728424375]." Fix MiniMapReduceCluster failure under Java17,13413013,Resolved,Major,Fixed,21/Nov/21 11:52,23/Jun/23 08:10,,"MiniMapReduceCluster in HBaseTestingUtil.java will not work. Find the error message in the container log: {code:java} Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not ""opens java.lang"" to unnamed module @755c9148 at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354) ~[?:?] at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297) ~[?:?] at java.lang.reflect.Method.checkCanSetAccessible(Method.java:199) ~[?:?] at java.lang.reflect.Method.setAccessible(Method.java:193) ~[?:?] at com.google.inject.internal.cglib.core.$ReflectUtils$2.run(ReflectUtils.java:56) ~[guice-4.0.jar:?] at java.security.AccessController.doPrivileged(AccessController.java:318) ~[?:?] at com.google.inject.internal.cglib.core.$ReflectUtils.(ReflectUtils.java:46) ~[guice-4.0.jar:?] {code} The container of MiniMapReduceCluster is running in an independent JVM. So that we need to pass the JVM opts to the container JVM. Impacted UTs: TestSecureExportSnapshot TestMobSecureExportSnapshot TestVerifyReplicationCrossDiffHdfs " Backport HBASE-26524 Support remove coprocessor by class name via alter table command ,13414912,Resolved,Major,Fixed,01/Dec/21 23:33,10/Dec/21 18:17,2.5.0,porting HBASE-26524 to branch-2 CompactedHFilesDischarger should be shutdown when aborting regionserver,13417602,Resolved,Major,Fixed,15/Dec/21 04:21,05/Jan/22 08:41,2.0.0,The CompactedHFilesDischarger chore service should be shutdown when regionserver aborting. Introduce a new Admin API to change SFT implementation,13418023,Resolved,Major,Fixed,16/Dec/21 15:26,30/Jan/22 13:03,,"Now changing SFT implementation requires two MTP, and there are also lots of rules on how to correctly set the MIGRATION SFT, I think we'd better introduce a special method to implement the complicated logic by code,to make our users life easier." Add SFT configuration to META table descriptor when creating META,13418007,Resolved,Major,Fixed,16/Dec/21 14:38,05/Jan/22 13:11,2.6.0,"META doesn't get created via CreateTableProcedure, but rather during master initialisation on cluster's first run, so changes implemented on HBASE-26246 don't take effect for meta table." Update ref guide about the new changes for RpcConnectionRegistry,13413968,Resolved,Major,Fixed,26/Nov/21 07:52,07/Mar/24 09:28,,The ref guide still only introduces MasterRegistry. We should update the ref guide to mention that it is already deprecated and will be removed in 4.0.0. RpcConnectionRegistry is the alternate. Provide HBase upgrade guidelines from 1.6 to 2.4+ versions,13406080,Resolved,Major,Implemented,12/Oct/21 06:57,14/Feb/24 02:21,,"Provide some ref guide under section: [https://hbase.apache.org/book.html#upgrade2.0.rolling.upgrades]  This should include experience of performing in-place rolling upgrade (without downtime) from 1.6/1.7 to 2.4+ release versions." Implement a table-based region grouping strategy for RegionGroupingProvider,13406054,Open,Major,,12/Oct/21 03:46,,,"In our company, we create only one namespace for each RegionServer group, but we have about 1000 region per regionserver. Neither _identity_ nor _bounded are good choices, So we need to a_  WAL grouping strategy based on table name" check-aggregate-license error related to javadns after HADOOP-17317,13410927,Resolved,Major,Fixed,09/Nov/21 21:37,11/Nov/21 15:48,2.5.0,"This impacts any HBase branch compiling vs. Hadoop trunk (current 3.4.0-SNAPSHOT), which includes HADOOP-17317. Build fails with {noformat} [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (check-aggregate-license) @ hbase-shaded-client --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed with message: License errors detected, for more detail find ERROR in /Users/ndimiduk/repos/apache/hbase/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE {noformat} The aggregated license file contains this entry, {noformat} -- This product includes dnsjava licensed under the BSD-2-Clause. ERROR: Please check ^^^^^^^^^^^^ this License for acceptability here: https://www.apache.org/legal/resolved If it is okay, then update the list named 'non_aggregate_fine' in the LICENSE.vm file. If it isn't okay, then revert the change that added the dependency. More info on the dependency: dnsjava dnsjava 3.4.0 maven central search g:dnsjava AND a:dnsjava AND v:3.4.0 project website https://github.com/dnsjava/dnsjava project source https://github.com/dnsjava/dnsjava {noformat}  " OAuth Bearer authentication mech plugin for SASL,13416275,In Progress,Major,,09/Dec/21 11:35,,,"Implementation of a new SASL plugin to add support for OAuth Bearer token authentication for HBase client RPC. * The plugin supports secured (cryptographically signed) JSON Web Token authentication as defined in [RFC-7628|https://datatracker.ietf.org/doc/html/rfc7628]  and the JWT format in [RFC-7519|https://datatracker.ietf.org/doc/html/rfc7519] . * The implementation is inspired by [Apache Kafka's OAuth Bearer token|https://docs.confluent.io/platform/current/kafka/authentication_sasl/authentication_sasl_oauth.html] support with the important difference that HBase version is intended for production usage. The two main differences are that Kafka supports unsecured tokens only and it issues the tokens for itself which breaks the principle of OAuth token authentication. * We use the [Nimbus JOSE + JWT|https://bitbucket.org/connect2id/nimbus-jose-jwt/src/master/] Java library for signature verification and token processing and we add it as a new dependency to HBase. * We add secure JWT support and verification of digital signatures with multiple algorithms as supported by Nimbus. Json-formatted JWK set is required for the signature verification as defined in [RFC-7517|https://datatracker.ietf.org/doc/html/rfc7517]. * The impl is verified with Apache Knox issued tokens, because that's the primary use case of this new feature. * New client example is added to the hbase-examples project to showcase the feature. * It's important that this Jira does not cover the solution for obtaining a token from Knox. The assumption is that the client already has a valid token in base64 encoded string and we only provide a helper method for adding it to user's credentials. * Renewing expired tokens is also the responsibility of the client. We don't provide a mechanism for that in this Jira, but it's planned to be covered in a follow-up ticket. The following new parameters are introduced in hbase-site.xml: * hbase.security.oauth.jwt.jwks.file - Path of a local file for JWK set. (required if URL not specified) * hbase.security.oauth.jwt.jwks.url - URL to download the JWK set. (required if File not specified) * hbase.security.oauth.jwt.audience - Required audience, ""aud"" claim of the JWT. (optional) * hbase.security.oauth.jwt.issuer - Required issuer, ""iss"" claim of the JWT. (optional) The feature will be behind feature-flag. No code part is executed unless the following configuration is set in hbase-site.xml: {noformat}     hbase.client.sasl.provider.extras     org.apache.hadoop.hbase.security.provider.OAuthBearerSaslClientAuthenticationProvider         hbase.server.sasl.provider.extras     org.apache.hadoop.hbase.security.provider.OAuthBearerSaslServerAuthenticationProvider         hbase.client.sasl.provider.class     org.apache.hadoop.hbase.security.provider.OAuthBearerSaslProviderSelector   {noformat} Example of Knox provided JWKS file: {noformat} { ""keys"": [{ ""kty"": ""RSA"", ""e"": """", ""use"": ""sig"", ""kid"": """", ""alg"": ""RS256"", ""n"": """" }] }{noformat} Example of Knox issued JWT header: {noformat} { ""jku"": ""https://path/to/homepage/knoxtoken/api/v1/jwks.json"", ""kid"": """", ""alg"": ""RS256"" }{noformat} And payload: {noformat} { ""sub"": ""user_andor"", ""aud"": ""knox-proxy-token"", ""jku"": ""https://path/to/homepage/knoxtoken/api/v1/jwks.json"", ""kid"": """", ""iss"": ""KNOXSSO"", ""exp"": 1636644029, ""managed.token"": ""true"", ""knox.id"": """" }{noformat}" Further improvements on StoreFileTracker,13417869,Open,Major,,16/Dec/21 05:36,,, Introduce a SnapshotProcedure,13404685,Resolved,Major,Fixed,03/Oct/21 13:39,12/Mar/22 16:00,,"Currently，snapshot in hbase uses zk as coordinator. It has some limitations,  a. Snapshot maybe fails when there are region server crashes. b. Snapshot maybe failed when master restarts. c. Only one snapshot per table can be taken in a time. d. Snapshot verify will be handled by master, which may take long time when our table has a large number of regions, for example 10000.   Since we have procedure v2 framework now, it is possible to solve the above problems. So here is a procedure2-based snapshot implementation. It has some goals, a. Snapshot can continue when there are region server crashes. b. Snapshot can continue when master restarts. c. More than one snapshot per table can be taken in a time. d. We can use region servers to verify snapshot to accelerate procedure.   Here are some details about implementation. *SnapshotProcedure* SnapshotProcedure is used to take snapshot on a table. It acquires shared table lock on the snapshot table and hold the shared lock during suspend and yield.  *SnapshotRegionProcedure* SnapshotRegionProcedure is used to take snapshot on a specific region of the snapshot table. It acquires exclusive region lock and releases lock during suspend and yield. Before dispatch remote snapshot operations to region server, it will check target region in RIT or not. If target region is in RIT, it will sleep some time and retry. *SnapshotVerifyProcedure* SnapshotVerifyProcedure is used to send snapshot verify request to region server. If snapshot is corrupted, it will notify parent snapshot to retry. When remote region server is crashed, it will choose another online server and retry.   I would be very grateful for any advice and guidance. Is anyone interested in taking a look?" Using RefCnt to fix the flawed MemStoreLABImpl,13414073,Resolved,Major,Fixed,27/Nov/21 04:25,01/Jan/22 13:06,2.4.9,"As HBASE-26465 said, reference count implementation in {{MemStoreLABImpl}} is flawed because its checking and increasing or decreasing is not done in atomicity and it ignores state checking when there is illegal state in reference count(eg. increasing or decreasing when the resource is already freed) , just as following {{incScannerCount}} and {{decScannerCount}} methods illustrated, and this flawed implementation has shield the bugs HBASE-26465 and HBASE-26488. {code:java} public void incScannerCount() { this.openScannerCount.incrementAndGet(); } public void decScannerCount() { int count = this.openScannerCount.decrementAndGet(); if (this.closed.get() && count == 0) { recycleChunks(); } } {code} We could Introduce {{RefCnt}} into {{MemStoreLABImpl}} to replace its flawed reference count implementation, so checking and increasing or decreasing is done in atomicity and if there is illegal state in reference count, it would throw exception rather than continue using the corrupt data to cause some subtle bugs, and meanwhile, the code is more simpler." Hbase-client Meta lookup performance regression between hbase-1 and hbase-2,13418087,Resolved,Major,Fixed,16/Dec/21 20:09,06/Jan/22 19:58,2.3.7,"One of our users complained higher latency after application upgrades from hbase-1.2 client (CDH-5.16.2) to hbase-2.4.5 client with meta replica Load Balance mode during app restart. I reproduced the regression by a test for meta lookup.  At my test cluster, there are 160k regions for the test table, so there are 160k entries in meta region. Used one thread to do 1 million meta lookup against the meta region server.   ||Version ||Meta Replica Load Balance Enabled||Time               || ||2.4.5-with-fixed||Yes||336458ms|| ||2.4.5-with-fixed||No||333253ms|| ||2.4.5||Yes||469980ms|| ||2.4.5||No||470515ms|| |      *cdh-5.16.2*|                                *No* |  *323412ms*|  " Introduce a timeout to shutdown of WAL,13414722,Resolved,Major,Fixed,01/Dec/21 09:00,24/Mar/23 09:31,2.0.0,"When the regionserver is aborted(server.isAborted() is true), it will just reject the newly coming requests, so it is important to keep a short time to stop to make a short MTTR.  When the WAL is shutting down, we can wait some time to flush the unacked appends, but if that is a long time, I think we can just abort without flushing them.  By introducing a timeout for WAL shutdown, we can control the shutdown time, especially for those sensitive businesses." Replication could choose the same named group if it is exist in the target cluster,13414941,Open,Major,,02/Dec/21 04:34,,,"Now replication just choose random sinks. But on target cluster, if we use rsgroup, the sink client may bring about performance impact between different groups." Separate Log Cleaner DirScanPool to prevent the OLDWALs from filling up the disk when archive is large,13404562,Resolved,Major,Fixed,01/Oct/21 22:50,27/Nov/22 18:16,1.7.1,"We currently share the DirScanPool (threadpool for scanning for files to delete in the OldLogs and archive directories) between the LogCleaner and HFileCleaner. This means that if the archive directory is large/has lots of files/directories, the threads can get stuck scanning through the archive directory, starving the LogCleaner. This is especially apparent on S3 where list can be slower than on HDFS. This JIRA creates separate DirScanPools for the LogCleaner and HFileCleaner" Use HFileLink file to replace entire file‘s reference when splitting,13410043,Resolved,Major,Fixed,04/Nov/21 12:50,18/Nov/21 14:00,,"++When splitting store files, if a file should be owned by only one child region, then there will be an entire file's reference in the child region. We can use HFileLink files, just like those in snapshot tables, to replace the reference files that refer to entire files." Separate master read and client read meta,13409572,Open,Major,,02/Nov/21 02:23,,2.4.8,"If there are some regions in abnormal state，client may give high pressure to meta，if we restart hmaster，hmaster restart will scan the whole meta, and blocked by the client request." "maven-gpg-plugin failing with ""Inappropriate ioctl for device""",13418327,Resolved,Major,Fixed,18/Dec/21 01:55,18/Dec/21 02:39,,"In some environments, if the Maven GPG plugin is too old, GPG signing will fail with ""Inappropriate ioctl for device"" The fix is to specify the latest version of the GPG plugin in the {{pluginManagement}} section of the project's POM, currently 3.0.1. {noformat} ... org.apache.maven.plugins maven-gpg-plugin 3.0.1 ... {noformat}" Add FastPath feature to HBase RWQueueRpcExecutor,13416204,Resolved,Major,Fixed,09/Dec/21 06:53,18/Jan/22 03:13,,"In ticket [HBASE-17808|https://issues.apache.org/jira/browse/HBASE-17808], the author introduced a fastpath implementation for RWQueueRpcExecutor. It aggregated 3 different independent RpcExecutor to implement the mechanism. This redundancy costed more memory and from its own performance test, it cannot outperform the original implementation. This time, I directly extended RWQueueRpcExecutor to implement the fast path mechanism. From my test result, it has a better queue time performance than before. YCSB Test: Constant Configurations: hbase.regionserver.handler.count: 1000 hbase.ipc.server.callqueue.read.ratio: 0.5 hbase.ipc.server.callqueue.handler.factor: 0.2 Test Workload: YCSB: 50% Write, 25% Get, 25% Scan. Max Scan length: 1000. Client Threads: 100 ||FastPathRWQueueRpcExecutor||RWQueueRpcExecutor|| |[OVERALL], RunTime(ms), 909365 [OVERALL], Throughput(ops/sec), 5498.3422498116815 [TOTAL_GCS_PS_Scavenge], Count, 1208 [TOTAL_GC_TIME_PS_Scavenge], Time(ms), 8006 [TOTAL_GC_TIME_%_PS_Scavenge], Time(%), 0.8803945610398465 [TOTAL_GCS_PS_MarkSweep], Count, 2 [TOTAL_GC_TIME_PS_MarkSweep], Time(ms), 96 [TOTAL_GC_TIME_%_PS_MarkSweep], Time(%), 0.010556817119638429 [TOTAL_GCs], Count, 1210 [TOTAL_GC_TIME], Time(ms), 8102 [TOTAL_GC_TIME_%], Time(%), 0.8909513781594849 [READ], Operations, 1248885 [READ], AverageLatency(us), 14080.154160711354 [READ], MinLatency(us), 269 [READ], MaxLatency(us), 180735 [READ], 95thPercentileLatency(us), 29775 [READ], 99thPercentileLatency(us), 39391 [READ], Return=OK, 1248885 [CLEANUP], Operations, 200 [CLEANUP], AverageLatency(us), 311.78 [CLEANUP], MinLatency(us), 1 [CLEANUP], MaxLatency(us), 59647 [CLEANUP], 95thPercentileLatency(us), 26 [CLEANUP], 99thPercentileLatency(us), 173 [INSERT], Operations, 1251067 [INSERT], AverageLatency(us), 14235.898240461942 [INSERT], MinLatency(us), 393 [INSERT], MaxLatency(us), 204159 [INSERT], 95thPercentileLatency(us), 29919 [INSERT], 99thPercentileLatency(us), 39647 [INSERT], Return=OK, 1251067 [UPDATE], Operations, 1249582 [UPDATE], AverageLatency(us), 14166.923049467741 [UPDATE], MinLatency(us), 321 [UPDATE], MaxLatency(us), 203647 [UPDATE], 95thPercentileLatency(us), 29855 [UPDATE], 99thPercentileLatency(us), 39551 [UPDATE], Return=OK, 1249582 [SCAN], Operations, 1250466 [SCAN], AverageLatency(us), 30056.68854251135 [SCAN], MinLatency(us), 787 [SCAN], MaxLatency(us), 509183 [SCAN], 95thPercentileLatency(us), 57823 [SCAN], 99thPercentileLatency(us), 74751 [SCAN], Return=OK, 1250466|[OVERALL], RunTime(ms), 958763 [OVERALL], Throughput(ops/sec), 5215.053146606617 [TOTAL_GCS_PS_Scavenge], Count, 1264 [TOTAL_GC_TIME_PS_Scavenge], Time(ms), 8680 [TOTAL_GC_TIME_%_PS_Scavenge], Time(%), 0.9053332262509086 [TOTAL_GCS_PS_MarkSweep], Count, 1 [TOTAL_GC_TIME_PS_MarkSweep], Time(ms), 38 [TOTAL_GC_TIME_%_PS_MarkSweep], Time(%), 0.00396344039142103 [TOTAL_GCs], Count, 1265 [TOTAL_GC_TIME], Time(ms), 8718 [TOTAL_GC_TIME_%], Time(%), 0.9092966666423298 [READ], Operations, 1250961 [READ], AverageLatency(us), 14663.084518222391 [READ], MinLatency(us), 320 [READ], MaxLatency(us), 204415 [READ], 95thPercentileLatency(us), 30815 [READ], 99thPercentileLatency(us), 43071 [READ], Return=OK, 1250961 [CLEANUP], Operations, 200 [CLEANUP], AverageLatency(us), 366.845 [CLEANUP], MinLatency(us), 1 [CLEANUP], MaxLatency(us), 70719 [CLEANUP], 95thPercentileLatency(us), 36 [CLEANUP], 99thPercentileLatency(us), 80 [INSERT], Operations, 1248183 [INSERT], AverageLatency(us), 14334.938754974231 [INSERT], MinLatency(us), 390 [INSERT], MaxLatency(us), 2828287 [INSERT], 95thPercentileLatency(us), 30271 [INSERT], 99thPercentileLatency(us), 41919 [INSERT], Return=OK, 1248183 [UPDATE], Operations, 1250212 [UPDATE], AverageLatency(us), 14283.836318960304 [UPDATE], MinLatency(us), 337 [UPDATE], MaxLatency(us), 2828287 [UPDATE], 95thPercentileLatency(us), 30255 [UPDATE], 99thPercentileLatency(us), 41855 [UPDATE], Return=OK, 1250212 [SCAN], Operations, 1250644 [SCAN], AverageLatency(us), 33153.01709839091 [SCAN], MinLatency(us), 742 [SCAN], MaxLatency(us), 645119 [SCAN], 95thPercentileLatency(us), 62879 [SCAN], 99thPercentileLatency(us), 80447 [SCAN], Return=OK, 1250644| In the metrics screenshot, the first interval is the performance of RWQueueRpcExecutor and the second interval is FastPathRWQueueRpcExecutor. " FuzzyRowFilter backwards compatibility,13415305,Resolved,Major,Fixed,03/Dec/21 15:06,18/Dec/21 02:56,1.1.13,"HBASE-15676 introduced a backwards incompatible change which makes it impossible to upgrade in our designated upgraded order (server first, then client) without potential bad results. Worse, the failure mode is silent – a pre-HBASE-15676 client would incorrectly receive 0 results from a post-HBASE-15676 server. I solved this internally as part of our upgrade from 1.2.0 to 2.4.6 by adding a new proto field to switch between the two implementations. I'm submitting this Jira to capture and potentially backport that fix for anyone else who encounters it. " Display the excluded datanodes on regionserver UI,13408434,Resolved,Major,Fixed,26/Oct/21 11:51,10/Jan/22 05:05,,"!image-2021-12-30-17-33-29-004.png|width=674,height=155! Like in the image, display the excluded datanode info and the timestamp when it was added to the cache." Update to error-prone 2.10,13419270,Resolved,Major,Fixed,23/Dec/21 18:58,03/Mar/22 10:53,2.5.0, Introduce retry to logroller to avoid abort,13416208,Resolved,Major,Fixed,09/Dec/21 07:18,07/Mar/22 08:43,2.4.10,"When calling RollController#rollWal in AbstractWALRoller, the regionserver may abort when encounters exception, {code:java} ... } catch (FailedLogCloseException | ConnectException e) { abort(""Failed log close in log roller"", e); } catch (IOException ex) { // Abort if we get here. We probably won't recover an IOE. HBASE-1132 abort(""IOE in log roller"", ex instanceof RemoteException ? ((RemoteException) ex).unwrapRemoteException() : ex); } catch (Exception ex) { LOG.error(""Log rolling failed"", ex); abort(""Log rolling failed"", ex); } {code} I think we should support retry of rollWal here to avoid recovering the service by killing regionserver. The restart of regionserver is costly and very not friendly to the availability. I find that when creating new writer for the WAL in FanOutOneBlockAsyncDFSOutputHelper#createOutput, it supports retry to addBlock by setting this config ""hbase.fs.async.create.retries"". The idea of retry to roll WAL is similar to it, they both try best to make roll WAL succeed.  But the initialization of new WAL writer also includes flushing the write buffer flush and waiting until it is completed by AsyncProtobufLogWriter#writeMagicAndWALHeader, which can also fail by some hardware reasons. The regionserver connected to the datanodes after addBlock, but that not means the magic and header can be flushed successfully. {code:java} protected long writeMagicAndWALHeader(byte[] magic, WALHeader header) throws IOException { return write(future -> { output.write(magic); try { header.writeDelimitedTo(asyncOutputWrapper); } catch (IOException e) { // should not happen throw new AssertionError(e); } addListener(output.flush(false), (len, error) -> { if (error != null) { future.completeExceptionally(error); } else { future.complete(len); } }); }); }{code} We have found that in our production clusters, there exists aborting of regionservers that caused by ""IOE in log roller"". And the practice in our clusters is that just one more retry of rollWal can make the WAL roll complete and continue serving.    " "Refactor code related to ""dump""ing ZK nodes",13418731,Resolved,Major,Fixed,21/Dec/21 02:26,26/Jan/22 17:06,2.5.0,"The code starting at {{ZKUtil.dump(ZKWatcher)}} is a small mess -- it has cyclic dependencies woven through itself, {{ZKWatcher}} and {{RecoverableZooKeeper}}. It also initializes a static variable in {{ZKUtil}} through the factory for {{RecoverableZooKeeper}} instances. Let's decouple and clean it up." hbase-protocol-shaded not buildable on M1 MacOSX,13415669,Resolved,Major,Fixed,06/Dec/21 19:04,09/Dec/21 00:55,2.4.8,I needed to make some changes to get branch-2's hbase-protocol-shaded building on an M1 mac. Support custom paths of independent configuration and pool for hfile cleaner,13405735,Resolved,Major,Fixed,09/Oct/21 05:34,24/May/22 08:03,1.7.1,"With this, we can clean some paths more quickly. We found in our cluster, when the very huge table with thousands of regions and high write throughputs and many snapshots tables on the same cluster, the speed of delete files in  archive path will lower than the speed of moved in files by compaction. Then archive may remains PB level data.  The bottleneck is in cleaner but not in the thread pool size or queue size. It is because there is synchronized lock in SnapshotFileCache, and a batch of files need once SnapshotFileCache#refreshCache(), which look through all the snapshot dirs. The speed of clear a path without the SnapshotHFileCleaner is thirty times faster." hbase-shaded-client missing required thirdparty classes under hadoop 3.3.1,13415876,Resolved,Major,Fixed,07/Dec/21 17:44,22/Feb/22 07:15,2.4.3,"In HBASE-25792, the shaded thirdparty libraries from hadoop were removed from the hbase-shaded-client fat jar to satisfy invariant checks. Unfortunately this causes users of hbase-shaded-client to fail, because required classes are not available at runtime. The specific failure I'm seeing is when trying to call new Configuration(), which results in:     {code:java} Caused by: java.lang.NoClassDefFoundError: org/apache/hadoop/thirdparty/com/google/common/base/Preconditions   at org.apache.hadoop.conf.Configuration$DeprecationDelta.(Configuration.java:430)   at org.apache.hadoop.conf.Configuration$DeprecationDelta.(Configuration.java:443)   at org.apache.hadoop.conf.Configuration.(Configuration.java:525){code}     If you take a look at the hbase-shaded-client fat jar, it contains the org.apache.hadoop.conf.Configuration class as you'd expect. If you decompile that class (or look at the 3.3.1 source), you'll see that there is an import for org.apache.hadoop.thirdparty.com.google.common.base.Preconditions but the fat jar does not provide it.   One way for clients to get around this is to add an explicit dependency on hadoop-shaded-guava, but this is problematic for a few reasons:   - it's best practice to use maven-dependency-plugin to disallow declared, unused dependencies (which this would be) - it requires users to continually keep the version of hadoop-shaded-guava up-to-date over time. - it only covers guava, but there is also protobuf and potentially other shaded libraries in the future.   I think we should remove the exclusion of {{org/apache/hadoop/thirdparty/**/*}} from the shading config and instead add that pattern to the allowlist so that hbase-shaded-client is all clients need to get started with hbase." Refactor code related to ZooKeeper authentication,13419104,Resolved,Major,Fixed,22/Dec/21 23:14,11/Jan/22 23:48,2.5.0,"This refactor reduces the size and scope of the {{ZKUtil}} class. The core of this refactor is moving the {{login*}} methods from {{ZKUtil}} into their own class, {{ZKAuthentication}}. The class {{JaasConfiguration}} is also moved along with them." hbaseprotoc plugin should initialize maven,13416167,Resolved,Major,Fixed,09/Dec/21 00:13,14/Dec/21 15:16,3.0.0-alpha-1,"My PR testing HBASE-26542 fails because the mvn incantation does not find other project module dependencies. Looking over our personality file and the Yetus documentation [precommit-advanced|https://yetus.apache.org/documentation/0.12.0/precommit-advanced/] says {quote} NOTE: If the plug-in has support for maven, the maven_add_install pluginname should be executed. See more information in Custom Maven Tests in the build tool documentation. {quote}" Support detect and exclude slow DNs in fan-out of WAL,13405922,Resolved,Major,Fixed,11/Oct/21 12:06,30/Dec/21 09:22,2.0.0,"We all knows the WAL sync performance directly affects the RPC process time. And we use self-designed FanOutOneBlockAsyncDFSOutput to sync WAL entries, which connect straightly to all the block located DNs. But when even one DN of the locations is slow, e.g. some disk hardware failures, the WAL syncs slow. And what's more, the hardware failure detected by the lower layer HDFS system is not so sensitive. We can detect slow DNs by the ACK time of packets in FanOutOneBlockAsyncDFSOutput, and exclude them when add new blocks after log rolled(rolling log can also be triggered by slow syncs). And shows this info in UI. We can also invalid these excluded DN cache after a duration, to aware the recovery of those DNs.  I think this idea can quickly reduce the influence of slow DNs, and improve the service availability.    " Investigate mTLS in RPC layer,13416115,Resolved,Major,Done,08/Dec/21 17:38,24/Aug/22 18:08,,"Current authentication options are heavily based on SASL and Kerberos. For organizations that don't already deploy Kerberos or other token provider, this is a heavy lift. Another very common way of authenticating in the industry is mTLS, which makes use of SSL certifications and can solve both wire encryption and auth. For those already deploying trusted certificates in their infra, mTLS may be much easier to integrate. It isn't necessarily easy to implement this, but I do think we could use existing Netty SSL support in the NettyRpcClient and NettyRpcServer. I know it's easy to add SSL to non-blocking IO through a hadoop.rpc.socket.factory.class.default which returns SSLSockets, but that doesn't touch on the certification verification at all. Much more investigation is needed, but logging this due to some interest encountered on slack. Slack thread: https://apache-hbase.slack.com/archives/C13K8NVAM/p1638980520110600" region_mover should gracefully ignore null response from RSGroupAdmin#getRSGroupOfServer,13418202,Resolved,Major,Won't Fix,17/Dec/21 09:38,09/Aug/22 08:07,1.7.1,"If regionserver has any non-daemon thread running even after it's own shutdown, the running non-daemon thread can prevent clean JVM exit and regionserver could be stuck in the zombie state. We have recently provided a workaround for this in HBASE-26468 for regionserver exit hook to wait 30s for all non-daemon threads to get stopped before terminating JVM abnormally. However, if regionserver is stuck in such state, region_mover unload fails with: {code:java} NoMethodError: undefined method `getName` for nil:NilClass getSameRSGroupServers at /bin/region_mover.rb:503 __ensure__ at /bin/region_mover.rb:313 unloadRegions at /bin/region_mover.rb:310 (root) at /bin/region_mover.rb:572 {code} This happens if the cluster has RSGroup enabled and the given server is already stopped, hence RSGroupAdmin#getRSGroupOfServer would return null (as the server is not running anymore so it is not part of any RSGroup). region_mover should ride over this null response and gracefully exit from unloadRegions() call.   We should also check if the fix is applicable to branch-2 and above." Concurrent assign and SCP may cause regionserver abort,13414546,Resolved,Major,Won't Fix,30/Nov/21 13:19,02/Aug/22 09:10,1.7.0,"When concurrent assign a region, the RS may abort when reporting region state to master encounters transit region state error,    {code:java} 2021-11-26 04:40:54,689 INFO  [PostOpenDeployTasks:ee1df69da9c7fb7698d2972f81d40b65] regionserver.HRegionServer: Post open deploy tasks for growthosudx:growthos-udx_dmx_supply_waimaisku_application_basic,cc,1631020952330.ee1df69da9c7fb7698d2972f81d40b65. 2021-11-26 04:40:54,689 INFO  [PostOpenDeployTasks:ee1df69da9c7fb7698d2972f81d40b65] regionserver.HRegionServer: Failed to transition {ENCODED => ee1df69da9c7fb7698d2972f81d40b65, NAME => 'growthosudx:growthos-udx_dmx_supply_waimaisku_application_basic,cc,1631020952330.ee1df69da9c7fb7698d2972f81d40b65.', STARTKEY => 'cc', ENDKEY => 'cd'} to OPENED: ee1df69da9c7fb7698d2972f81d40b65 is not pending open on zf-data-hbase250.mt,16020,1637872783437 2021-11-26 04:40:54,689 FATAL [PostOpenDeployTasks:ee1df69da9c7fb7698d2972f81d40b65] regionserver.HRegionServer: ABORTING region server zf-data-hbase250.mt,16020,1637872783437: Exception running postOpenDeployTasks; region=ee1df69da9c7fb7698d2972f81d40b65 java.io.IOException: Failed to report opened region to master: growthosudx:growthos-udx_dmx_supply_waimaisku_application_basic,cc,1631020952330.ee1df69da9c7fb7698d2972f81d40b65.         at org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2387)         at org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler$PostOpenDeployTasksThread.run(OpenRegionHandler.java:327) {code} In the master log, we can see that the region is being assigned by both the bulk assigner and the SCP. !master-error-logs.png|width=600,height=140! This steps can reproduce the problem: # thread 1 calls Assignment#assign to assign region A, and calls RegionStates#updateRegionsState and stops before the synchronize; #  thread 2 calls RegionStates#serverOffline and gets the lock, it sees that region A is on the processed dead server and add region A to the regionsToOffline list(region A is not in the RIT cache now); # thread 2 prepare to execute RegionStates#regionOffline, and released the lock; # thread 1 get the lock, and add region A to the RIT cache, and also update the region state by RegionStates#putRegionState, set the region state from OFFLINE to PENDING_OPEN, then release the lock; # thread2 execute  RegionStates#regionOffline, acquires the lock and sets the region state from PENDING_OPEN to OFFLINE; # the RS that region A assigned by thread 1 report region A should be transited to OPENED, but finds that region A last state is OFFLINE, error occures, the RS abort itself.    " Close NamedQueueRecorder to allow HMaster/RS to shutdown gracefully,13413184,Resolved,Major,Fixed,22/Nov/21 14:02,24/Nov/21 07:49,1.7.0,"Saw one case in our production cluster where RS was not exiting. Saw this non-daemon thread in hung RS stack trace: {noformat} ""main.slowlog.append-pool-pool1-t1"" #26 prio=5 os_prio=31 tid=0x00007faf23bf7800 nid=0x6d07 waiting on condition [0x0000700003f4d000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00000004039e3840> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) at com.lmax.disruptor.BlockingWaitStrategy.waitFor(BlockingWaitStrategy.java:47) at com.lmax.disruptor.ProcessingSequenceBarrier.waitFor(ProcessingSequenceBarrier.java:56) at com.lmax.disruptor.BatchEventProcessor.processEvents(BatchEventProcessor.java:159) at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:125) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat}         This is coming from [NamedQueueRecorder|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/NamedQueueRecorder.java#L65] implementation. This bug doesn't exists in branch-2 and master since the Disruptor initialization has changed and we set daemon=true also. See [this code|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/NamedQueueRecorder.java#L68]   FYI [~vjasani] [~zhangduo]" Limit the length of initial resultSets for HBase thrift service,13414090,Open,Major,,27/Nov/21 10:21,,1.4.14,"When the client requests getScannerResults or getScannerRows, set up a large numRows will cause ArrayIndexOutOfBoundsException ，and  may  cause OOM. For example {code:java} conn := cli.(*hbase.THBaseServiceClient) tscan := &hbase.TScan{ StartRow: []byte(""prefix_1""), StopRow: []byte(""prefix_2""), Columns: []*hbase.TColumn{ { Family: []byte(""N""), Qualifier: []byte(""title""), }, }, } scanresult, err := conn.GetScannerResults([]byte(""rowkey1""), tscan, 10000000){code} Here initialize the length of resultSets using the minimum value of ""hbase.thrift.max.scanner.results.init.length""  and numRows。" Update ClassSize.BYTE_BUFFER for JDK17,13407907,Resolved,Major,Fixed,22/Oct/21 08:30,27/Oct/21 14:07,,"In JDK17, the implement of Buffer.java is changed a little, which makes the heapsize of BYTE_BUFFER different as earlier JDK. This makes related UTs fail." Set version as 3.0.0-alpha-3-SNAPSHOT in master,13419166,Resolved,Major,Fixed,23/Dec/21 08:59,24/Dec/21 06:20,, Immutable timeseries usecase - Create new region rather than split existing one,13412526,Open,Major,,18/Nov/21 12:44,,,"For insertion of immutable data usecase (specifically time-series data), region split mechanism doesn't seem to provide better availability when ingestion rate is very high. When we ingest lot of data, the region split policy tries to split the given hot region based on the size (either size of all stores combined or size of any single store exceeding max file size configured) if we consider default {_}SteppingSplitPolicy{_}. The latest hot regions tend to receive all latest inserts. When the region is split, the first half of the region (say daughterA) stays on the same server whereas the second half (daughterB) region – likely to become another hot region because all new latest updates come to second half region in the sequential write fashion – is moved out to other servers in the cluster. Hence, once new daughter region is created, client traffic will be redirected to another server. Client requests will be piled up when region split is triggered till new daughters come alive and once done, client will have to request meta for updated daughter region and redirect traffic to new server. If we could have configurable region creation strategy that 1) keeps the split disabled for the given table, and 2) create new region dynamically with lexicographically higher start key on the same server and update it's own region boundary, the client will have to look up meta once and continue ingestion without any degraded SLA caused by region split transitions. Note: region split might also encounter some complications, requiring the procedure to be rolled back from some step, or continue with internal retries, eventually further delaying the ingestion from clients.   There are some complications around updating live region's start and end keys as this key range is immutable. We could brainstorm ideas around making them optionally mutable and any issues around them. For instance, client might continue writing data to the region with updated end key but writes will fail for out of range keys and hence, they will lookup in meta for updated key-space range (new region created with end key: EMPTY_END_ROW) of the table." Provide meaningful parent spans to ZK interactions,13407171,Resolved,Major,Fixed,18/Oct/21 22:40,13/Jun/22 08:34,2.5.0,"Enable tracing with {{-Dotel.traces.sampler=always_on}} and launch the standalone master, check the trace store. We see lots of single-span traces, each a call to different {{RecoverableZooKeeper}} methods, like {{create}} and {{exists}}. Whatever master startup thread this is should define its own root span." Extend RSGroup to support data isolation to achieve true multitenancy in Hbase,13405797,Resolved,Major,Incomplete,10/Oct/21 02:31,11/Jun/22 23:49,,"RSGroups currently only provide isolation on serving layer, but not on the data layer. And there is a need for providing data isolation between rsgroups to achieve true multitenancy in hbase leading to independently scale individual rsgroups on need bases. Some of the aspects to be covered in this umbrella project are  # Provide data isolation between different RSGroups # Add balancer support to understand this construct while performing balancer activity # Extend support on various ancillary services such as export snapshot, cluster replication, etc " Use spotless to reduce the pain on fixing checkstyle issues,13419106,Resolved,Major,Fixed,23/Dec/21 00:18,01/May/22 15:11,,"https://github.com/diffplug/spotless Spotless is a tool for reformatting code based on your configuration file, it supports the google java format, as well as a eclipse formatter file. I think we could use it to format our code, based on a configuration file in our repo, and all the developpers, no matter what IDE they use, they can just type a mvn spotless:apply before commiting a PR, then everything is fine." [hbase-thirdparty] Bump jetty version to 9.4.44.v20210927,13414154,Resolved,Major,Fixed,28/Nov/21 13:47,29/Nov/21 14:09,, The dockerfile for running pre commit and nightly jobs can not be built on branch-1,13407966,Resolved,Major,Fixed,22/Oct/21 14:36,23/Oct/21 12:36,,"Because of can not download the findbugs binaries, due to lack of CAs. Need to solve the problem, either by updating the docker file, or switching to use spotbugs(still need to update the docker file, though)." Update next set of minor releases for Hadoop 3.1 EOM ,13405208,Open,Major,,06/Oct/21 14:10,,2.5.0,"Looks like Hadoop 3.1 went EOL back in June. I can't find a formal announcement, but ""[\[VOTE\] Hadoop 3.1.x EOL|https://s.apache.org/hadoop-vote-3.1-eol]"" passed and HADOOP-17759 removed 3.1 from their active downloads page and the asf active distribution mirroring. We should update our minimum testing version to 3.2 and update the hadoop dependency matrix to reflect this change." TableSplit returns false size under 1MB,13405594,Resolved,Major,Fixed,08/Oct/21 09:55,18/Dec/21 05:28,,"We calculate region size in the mapreduce package by getting the size in MB first and multiplying: https://github.com/apache/hbase/blob/39a20c528e2bf27cedf12734dbdb1b7b1e538076/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RegionSizeCalculator.java#L87 This will give a size of 0 until at least 1MB is reached. (And it will have an unwanted rounding affect as well). Spark for example can be tuned to do some performance tuning by eliminating the 0 sized regions. This will eliminate any small regions which are not actually empty. The hadoop interface states the size is returned in bytes, and while this is true do to the multiplication, we multiply by 0 until 1MB is reached. I'm not sure why we get the size in MB units and not in bytes straight up." [branch-2] TestLruBlockCache is flaky,13414065,Resolved,Major,Cannot Reproduce,27/Nov/21 00:50,30/Apr/22 01:17,,"[WARNING] Flakes: [WARNING] org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testBackgroundEvictionThread [ERROR] Run 1: TestLruBlockCache.testBackgroundEvictionThread:147 Eviction never happened. [INFO] Run 2: PASS" Use openlabtesting protoc on linux arm64 in HBASE 2.x,13412720,Resolved,Major,Fixed,19/Nov/21 08:19,22/Nov/21 15:19,,"This is the same issue as HBASE-23612 but for HBase 2.x. Please backport the fix to HBase 2.x because at the moment it is not possible to use Apache Phoenix on Linux ARM64. I will send a new Pull Request! ------------------------- Currently, there is no protoc 2.5.0 for release [1]. So we can make a new one for ARM specific. For make sure that could work on ARM. We will introduce a new ARM artifact for protoc, group_id is org.openlabtesting.protobuf .. This is just used for protobuf-maven-plugin to compile .proto files. As the 3.X version of protoc support ARM already. So this won't affect the internal protoc usage, which is 3.5.1-1 now.   [1][https://github.com/protocolbuffers/protobuf/issues/3844#issuecomment-343355946]" Enable OpenTelemetry to be used from developer sandbox,13406623,Resolved,Major,Fixed,14/Oct/21 18:52,18/Oct/21 22:52,2.5.0,"Enabling OpenTelemetry tracing in a checkout doesn't work. {noformat} Attach opentelemetry agent to enable trace find: lib/trace: No such file or directory Error opening zip file or JAR manifest missing : Error occurred during initialization of VM agent library failed to init: instrument {noformat} A little tweak to {{bin/hbase}} should do the trick." OpenTelemetry configuration support for per-process service names,13406833,Resolved,Major,Fixed,15/Oct/21 16:10,04/Nov/21 18:41,,"Our configuration should support setting a different {{service.name}} for each identifiable HBase process/component. This will make it easier to distinguish between, say, master, region server, when visualizing a trace. As a first pass, I'm guessing that most of the command targets of {{bin/hbase}} should be represented by the configuration. For examples of how this might be implemented, see how we support per-process GC arguments, or how its done in this [Hadoop PR|https://github.com/apache/hadoop/pull/3445/files#diff-a6a286a42078a3fc5eed5bd1bf23163b3574a8f2246d7d8d2f81436b7603f1c2R436]." Support remove coprocessor by class name via alter table command,13414670,Resolved,Major,Fixed,01/Dec/21 05:10,06/Dec/21 22:19,3.0.0-alpha-2,"With the shell, when operator wants to remove a table coprocessor, the flow is to 1. first use {{decs}} find the the mapping of coprocessor$# e.g. coprocessor$1, where # is the ordered number when the coprocessor was internally added to the table attribute 2. issue {{table_att_unset}} with the target `coprocessor$#` that maps to a value that include the unique class name. This task is to simplify the flow if the operator know exactly the class name of the added coprocessor, and create a new sub-method to {{alter}}, such that operator can do it only with the class name. NOTE that this logic has been added behind the scenes at [TableDescriptorBuilder#removeCoprocessor|https://github.com/apache/hbase/blob/358c4dc9022c507ee0159c1d4916aba41d42cde8/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L1537-L1565] for removing `ConstraintProcessor` , and we are just exposing this logic with a new method to {{alter}} command. " Add more information to release manager table in our ref guide,13420109,Resolved,Major,Fixed,31/Dec/21 02:25,05/Apr/22 13:41,,"I think our ref guide should record the release managers for EOL releases too, this is a honor." Implement a migration tool to help users migrate SFT implementation for a large set of tables,13418025,Resolved,Major,Later,16/Dec/21 15:27,04/Apr/22 17:25,,It will be very useful for our users who deploy HBase on S3 like systems. Implement tracing of scan,13415699,Resolved,Major,Fixed,07/Dec/21 00:09,01/Apr/22 10:47,,"Naive tracing of a long scan, where each back-and-forth between client and server gets its own Span, can result in many 100's or 1000's of Spans. This is easily overwhelming for tracing infrastructure. Identify some solution that allows for a reasonable out-of-the-box behavior when a scan is to be traced." Trace coprocessor exec endpoints,13414913,Resolved,Major,Fixed,01/Dec/21 23:46,22/Mar/22 13:13,,"Decide how to trace Coprocessor Exec endpoints. They either look like table operations OR generic RPC calls... I'm guessing the latter, but will give it some study." Name RPC spans as `$package.$service/$method`,13414582,Resolved,Major,Fixed,30/Nov/21 16:17,10/Feb/22 11:58,,As per https://github.com/open-telemetry/opentelemetry-specification/blob/3e380e2/specification/trace/semantic_conventions/rpc.md#span-name Remove use of `db.hbase.namespace` tracing attribute,13414580,Resolved,Major,Fixed,30/Nov/21 16:10,24/Jan/22 20:47,,Noticed by [~taklwu] and confirmed via https://github.com/open-telemetry/opentelemetry-specification/issues/1760. The HBase-specific attribute {{db.hbase.namespace}} has been deprecated in favor of the generic {{db.name}}. Implement connection-level attributes,13412867,Resolved,Major,Fixed,20/Nov/21 00:44,24/Jan/22 22:20,,"Add support for `db.system`, `db.connection_string`, `db.user`." Introduce `db.hbase.container_operations` span attribute,13412866,Resolved,Major,Fixed,20/Nov/21 00:43,01/Feb/22 00:55,,"For batch operations, collect and annotate the associated span with the set of all operations contained in the batch. " Adhere to semantic conventions regarding table data operations,13412865,Resolved,Major,Fixed,20/Nov/21 00:43,01/Feb/22 21:53,,Follow the guidance outlined in https://github.com/open-telemetry/opentelemetry-specification/blob/3e380e2/specification/trace/semantic_conventions/database.dm Cherry pick HBASE-26537 to branch-2.4,13418332,Resolved,Major,Fixed,18/Dec/21 02:56,14/Mar/22 21:50,,This may need more discussion for going into a patch release (or not). Consider for 2.4.10. "[branch-2, hbase-thirdparty, Java 8] TestUnloadAccessController and other unit tests fail to start due to ByteBuffer link error",13414064,Resolved,Major,Fixed,27/Nov/21 00:23,14/Mar/22 20:53,2.4.8,"org.apache.hadoop.hbase.security.access.TestUnloadAccessController Hang in setUpBeforeClass. Master will not initialize. Root cause is a NoSuchMethodError. {noformat} 2021-11-26 19:09:56,465 WARN [RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=62950] ipc.RpcExecutor$Handler(370): Handler errors java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; at org.apache.hbase.thirdparty.com.google.protobuf.CodedOutputStream$HeapNioEncoder.flush(CodedOutputStream.java:1546) at org.apache.hadoop.hbase.ipc.ServerCall.writeToCOS(ServerCall.java:378) at org.apache.hadoop.hbase.ipc.ServerCall.createHeaderAndMessageBytes(ServerCall.java:385) at org.apache.hadoop.hbase.ipc.ServerCall.createHeaderAndMessageBytes(ServerCall.java:363) at org.apache.hadoop.hbase.ipc.ServerCall.setResponse(ServerCall.java:267) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:168) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:354) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:334) {noformat} This is a known issue with ByteBuffer in JDK 8 vs ByteBuffer in later versions. When code is compiled with Java 9 or later using a specific subset of ByteBuffer APIs, the resulting bytecode will not link with Java 8's runtime. It works fine the other way. When compiled with Java 8, the bytecode will link with later Java runtimes just fine. protobuf included into hbase-thirdparty was likely compiled with Java 9 or later. We shade that bytecode as is into hbase-thirdparty. Tests were attempted with Java 8, so this failure case manifested. Apache Maven 3.8.3 (ff8e977a158738155dc465c6a97ffaf31982d739) Java version: 1.8.0_312, vendor: Azul Systems, Inc., runtime: /Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/jre OS name: ""mac os x"", version: ""12.0.1"", arch: ""aarch64"", family: ""mac"" We should be able to fix this problem by compiling protobuf with Java 8 and then shading the result when building hbase-thirdparty. " Support priority select reference files in StripeCompactionPolicy,13410044,Patch Available,Major,,04/Nov/21 12:52,,,"The reference files are those with these patterns, . and =-.. We can compact these reference files in the first compaction after splitting, instead of a major compaction. Then when the region only has normal hfiles and HFileLink files, it can be splitted once more. From the overall perspective, it can reduce compaction IOs." Region opens sometimes fail when bucket cache is in use,13411114,Resolved,Major,Cannot Reproduce,10/Nov/21 17:17,04/Mar/22 20:04,2.4.8,"After a split, I think, the region is reopened, and: 2021-11-10 16:47:48,929 ERROR [RS_OPEN_REGION-regionserver/ip-172-31-63-83:8120-1] regionserver.HRegion: Could not initialize all stores for the region=IntegrationTestLoadCommonCrawl,,1636562865609.e2df2061bcdc037070041de734a187ff. Caused by: java.io.IOException: java.lang.RuntimeException: Cached block contents differ, which should not have happened. cacheKey:1e395fa6f0584ebc9fd831f1451dc4ba.cbb4e3a74e703805898a2a3bf0af94e7_48543272         at org.apache.hadoop.hbase.regionserver.HStore.openStoreFiles(HStore.java:577)         at org.apache.hadoop.hbase.regionserver.HStore.loadStoreFiles(HStore.java:534)         at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:298)         at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6546) Caused by: java.lang.RuntimeException: Cached block contents differ, which should not have happened. cacheKey:1e395fa6f0584ebc9fd831f1451dc4ba.cbb4e3a74e703805898a2a3bf0af94e7_48543272         at org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.validateBlockAddition(BlockCacheUtil.java:205)         at org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.shouldReplaceExistingCacheBlock(BlockCacheUtil.java:237)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.shouldReplaceExistingCacheBlock(BucketCache.java:446)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.cacheBlockWithWait(BucketCache.java:431)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.cacheBlock(BucketCache.java:417)         at org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.cacheBlock(CombinedBlockCache.java:64)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.lambda$readBlock$2(HFileReaderImpl.java:1346) The open fails but another attempt somewhere else succeeds." branch-2 modules dependencies are confused,13408545,Resolved,Major,Cannot Reproduce,26/Oct/21 21:03,04/Mar/22 20:03,2.5.0,"When trying to build branch-2, I get several dependency resolution issues. Different issues based on what approach I try.   {{mvn -e -B --no-transfer-progress -Dhadoop.profile=3.0 -Dhadoop-three.version=3.0.0-cdh6.3.2 clean install -Dmaven.test.skip=true}} will fail with: {noformat} 231.4 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce (hadoop-profile-min-maven-min-java-banned-xerces) on project hbase-build-configuration: Execution hadoop-profile-min-maven-min-java-banned-xerces of goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce failed: org.apache.maven.shared.dependency.graph.DependencyGraphBuilderException: Could not resolve following dependencies: [org.apache.hbase:hbase-annotations:jar:tests:2.5.0-SNAPSHOT (test)]: Could not resolve dependencies for project org.apache.hbase:hbase-build-configuration:pom:2.5.0-SNAPSHOT: Could not find artifact org.apache.hbase:hbase-annotations:jar:tests:2.5.0-SNAPSHOT in snapshots{noformat} Note that I'm running this behind a corporate firewall, so if there is a snapshot available upstream in apache snapshots repo, then I'm not able to access it. I would have thought that it can use the locally built and installed one instead, since build-configuration does correctly come after annotations.   If I change to {{-DskipTests}} then this target succeeds, but later {{mvn site}} fails with {noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project hbase: Error generating maven-javadoc-plugin:3.2.0:aggregate-no-fork report: [ERROR] Exit code: 1 - /home/jenkins-agent/hbase/hbase-testing-util/src/main/java/org/apache/hadoop/hbase/testing/TestingHBaseClusterOption.java:24: error: cannot find symbol [ERROR] import org.apache.hadoop.hbase.StartMiniClusterOption; [ERROR] ^ [ERROR] symbol: class StartMiniClusterOption [ERROR] location: package org.apache.hadoop.hbase {noformat} Again, I'm missing testing packages, this time for javadocs.   I believe I was getting similar errors on main branch, although I don't have logs for that anymore." [branch-1] The log rolling request maybe canceled immediately in LogRoller due to a race ,13410892,Resolved,Major,Fixed,09/Nov/21 16:52,03/Mar/22 09:49,1.6.0,"Saw this issue in our internal 1.6 branch. All the writes to this RS were getting failing since the underlying hdfs file was corrupt. This healed after 1 hour (equivalent to hbase.regionserver.logroll.period conf key). The WAL  was rolled but the new WAL file was not writable and it logged the following error also. {noformat} 2021-11-03 19:20:19,503 WARN [.168:60020.logRoller] hdfs.DFSClient - Error while syncing java.io.IOException: Could not get block locations. Source file ""/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389"" - Aborting... at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466) at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670) 2021-11-03 19:20:19,507 WARN [.168:60020.logRoller] wal.FSHLog - pre-sync failed but an optimization so keep going java.io.IOException: Could not get block locations. Source file ""/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389"" - Aborting... at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466) at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670) {noformat} Since the new WAL file was not writable, appends to that file started failing immediately it was rolled. {noformat} 2021-11-03 19:20:19,677 INFO [.168:60020.logRoller] wal.FSHLog - Rolled WAL /hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635965392022 with entries=253234, filesize=425.67 MB; new WAL /hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389 2021-11-03 19:20:19,690 WARN [020.append-pool17-t1] wal.FSHLog - Append sequenceId=1962661783, requesting roll of WAL java.io.IOException: Could not get block locations. Source file ""/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635967219389"" - Aborting... at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466) at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670) 2021-11-03 19:20:19,690 INFO [.168:60020.logRoller] wal.FSHLog - Archiving hdfs://prod-EMPTY-hbase2a/hbase/WALs/,60020,1635567166484/%2C60020%2C1635567166484.1635960792837 to hdfs://prod-EMPTY-hbase2a/hbase/oldWALs/hbase2a-dnds1-232-ukb.ops.sfdc.net%2C60020%2C1635567166484.1635960792837 {noformat} We always reset the rollLog flag within LogRoller thread after the rollWal call is complete. Within FSHLog#rollWriter method, it does many things, like replacing the writer and archiving old logs. If append thread fails to write to new file while logRoller thread is cleaning old logs, we will miss the rollLog flag since LogRoller will reset the flag to false while the previous rollWriter call is going on. Relevant code: https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java#L183-L203 We need to reset rollLog flag before we start rolling the wal. This is fixed in branch-2 and master via HBASE-22684 but we didn't fix it in branch-1 Also branch-2 has multi wal implementation so it can apply cleanly in branch-1." [hbase-thirdparty] Make a 4.0.1 release for hbase-thirdparty,13418149,Resolved,Major,Fixed,17/Dec/21 04:27,26/Feb/22 06:21,,"Copy the content in mailing list here {noformat} Oh, when backporting to branch-2, I found that there is a serious problem with this release. We do not include the proto files in protobuf-java jar, I think this is a side effect of HBASE-26496. And on the master branch, hbase-shaded-protobuf also pulls in protobuf-java 3.19.1 dependency so everything is fine. But for branch-2, we will need to depend on protobuf 2.5.0 then the compilation is broken. Anyway, we should include the proto files in hbase-shaded-protobuf, and also we should not pull in the original protobuf-java dependency. Let me fix this and do a 4.0.1 release. {noformat}" The way we add or clear failedReplicas may have race,13411172,Resolved,Major,Fixed,11/Nov/21 02:20,14/Nov/21 13:03,,"We will add a replica to failedReplicas in the callback of the replay method call, and we will clear the failedReplicas in add method when we meet a flush all edit. They are in different threads, so it is possible that, we have already clear the failedReplicas due to a flush all edit, then in the callback of replay, we add a replica to the failedReplicas because of a failure of replicating, although the failure is actually before the flush all edit. We should find a way to fix this." [hbase-thirdparty] Bump protobuf version to 3.19.1,13414153,Resolved,Major,Fixed,28/Nov/21 13:46,29/Nov/21 08:17,, Compact L0 files for cold regions using StripeCompactionPolicy,13410849,Resolved,Major,Fixed,09/Nov/21 13:11,15/Feb/22 14:42,2.0.0,"For cold regions, the L0 files can be all expired after a long while. We should compact and delete all TTL expired data in them if the count of them is less than the configured min files to compact in L0." The default rpc timeout 200ms is too small for replicating meta edits,13415410,Resolved,Major,Fixed,04/Dec/21 13:54,07/Dec/21 15:19,,"For most meta edits, we will call refreshStoreFiles, which is time consuming. When running tests in HBASE-26487, it is very easy to timeout and cause the replicating to pause for a while. I think for replicating meta edits, we should have a larger timeout value." [hbase-operator-tools] Introduce a HBCK2 tool to fix the store file tracking,13419308,Open,Major,,24/Dec/21 04:21,,,We should provide a HBCK2 tool to recover the store file tracking if it is broken. hbase master got stuck after running couple of days in Azure setup,13417050,Resolved,Major,Workaround,13/Dec/21 14:48,13/Dec/21 21:51,2.0.1,"hadoop hbase version 2.0.1 hadoop hdfs version 2.7.7   In Azure cluster setup, hbase master got hangs or not responding after running couple of days and the only way to recover hbase master is delete /hbase and restart. Bellow is the error getting in the hbase-master   Error message ============== 2021-11-18 13:06:55,396 INFO [RpcServer.priority.FPBQ.Fifo.handler=19,queue=1,port=16000] assignment.AssignProcedure: Retry=10 of max=10; pid=320, ppid=319, state=RUNNABLE:REGION_TRANSITION_DISPATCH; AssignProcedure table=hbase:meta, region=1588230740; rit=OPENING, location=XXXXinfra-aaaa-hbase-regionserver-1.XXXXinfra-aaaa-hbase-regionserver.default.svc.cluster.local,16020,1637238611975 2021-11-18 13:06:55,396 INFO [PEWorker-16] assignment.AssignProcedure: Retry=11 of max=10; pid=320, ppid=319, state=RUNNABLE:REGION_TRANSITION_QUEUE; AssignProcedure table=hbase:meta, region=1588230740; rit=OFFLINE, location=null 2021-11-18 13:06:55,944 ERROR [PEWorker-16] procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception for pid=319, state=FAILED:RECOVER_META_ASSIGN_REGIONS, exception=org.apache.hadoop.hbase.client.RetriesExhaustedException via AssignProcedure:org.apache.hadoop.hbase.client.RetriesExhaustedException: Max attempts exceeded; RecoverMetaProcedure failedMetaServer=null, splitWal=true java.lang.UnsupportedOperationException: unhandled state=RECOVER_META_ASSIGN_REGIONS at org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.rollbackState(RecoverMetaProcedure.java:209) at org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.rollbackState(RecoverMetaProcedure.java:52) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.rollback(StateMachineProcedure.java:203) at org.apache.hadoop.hbase.procedure2.Procedure.doRollback(Procedure.java:864) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1372) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1328) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1197) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:75) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1760) 2021-11-18 13:06:55,958 ERROR [PEWorker-16] procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception for pid=319, state=FAILED:RECOVER_META_ASSIGN_REGIONS, exception=org.apache.hadoop.hbase.client.RetriesExhaustedException via AssignProcedure:org.apache.hadoop.hbase.client.RetriesExhaustedException: Max attempts exceeded; RecoverMetaProcedure failedMetaServer=null, splitWal=true java.lang.UnsupportedOperationException: unhandled state=RECOVER_META_ASSIGN_REGIONS at org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.rollbackState(RecoverMetaProcedure.java:209) at org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.rollbackState(RecoverMetaProcedure.java:52) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.rollback(StateMachineProcedure.java:203) at org.apache.hadoop.hbase.procedure2.Procedure.doRollback(Procedure.java:864) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1372) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1328) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1197) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:75) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1760) 2021-11-18 13:06:55,969 ERROR [PEWorker-16] procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception for pid=319, state=FAILED:RECOVER_META_ASSIGN_REGIONS, exception=org.apache.hadoop.hbase.client.RetriesExhaustedException via AssignProcedure:org.apache.hadoop.hbase.client.RetriesExhaustedException: Max attempts exceeded; RecoverMetaProcedure failedMetaServer=null, splitWal=true java.lang.UnsupportedOperationException: unhandled state=RECOVER_META_ASSIGN_REGIONS at org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.rollbackState(RecoverMetaProcedure.java:209) at org.apache.hadoop.hbase.master.procedure.RecoverMetaProcedure.rollbackState(RecoverMetaProcedure.java:52) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.rollback(StateMachineProcedure.java:203) at org.apache.hadoop.hbase.procedure2.Procedure.doRollback(Procedure.java:864) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1372) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1328) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1197) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:75) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1760) 2021-11-18 13:06:55,970 WARN [PEWorker-16] procedure2.ProcedureExecutor: Worker terminating UNNATURALLY null java.lang.ArrayIndexOutOfBoundsException: 2 at org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker$BitSetNode.updateState(ProcedureStoreTracker.java:405) at org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker$BitSetNode.delete(ProcedureStoreTracker.java:178) at org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker.delete(ProcedureStoreTracker.java:513) at org.apache.hadoop.hbase.procedure2.store.ProcedureStoreTracker.delete(ProcedureStoreTracker.java:505) at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.updateStoreTracker(WALProcedureStore.java:741) at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.pushData(WALProcedureStore.java:691) at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.delete(WALProcedureStore.java:603) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1406) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1328) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1197) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$800(ProcedureExecutor.java:75) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1760) 2021-11-18 13:07:46,268 INFO [ReadOnlyZKClient-aaaa-zookeeper:2181@0x7e131580] zookeeper.ZooKeeper: Session: 0x200000efa5dfae6 closed ============================================================   Error Message: ============================================================ ==> /opt/hbase-2.0.1/logs/hbase--master-XXXXinfra-aaaa-hbase-master-0.log <== 2021-12-02 12:43:51,351 INFO  [RpcServer.default.FPBQ.Fifo.handler=129,queue=12,port=16000] master.ServerManager: Registering regionserver=XXXXinfra-aaaa-hbase-regionserver-1.XXXXinfra-aaaa-hbase-regionserver.default.svc.cluster.local,16020,1638449029563 2021-12-02 12:43:54,699 ERROR [RpcServer.default.FPBQ.Fifo.handler=129,queue=12,port=16000] master.MasterRpcServices: lock(Unknown Source)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:372)     at com.sun.proxy.$Proxy20.addBlock(Unknown Source)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$6.addBlock(FanOutOneBlockAsyncDFSOutputHelper.java:380)     at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:774)     ... 24 more 2021-12-02 12:43:54,746 INFO  [main-EventThread] master.RegionServerTracker: RegionServer ephemeral node deleted, processing expiration [XXXXinfra-aaaa-hbase-regionserver-1.XXXXinfra-aaaa-hbase-regionserver.default.svc.cluster.local,16020,1638449029563] 2021-12-02 12:43:54,746 INFO  [main-EventThread] master.ServerManager: Processing expiration of XXXXinfra-aaaa-hbase-regionserver-1.XXXXinfra-aaaa-hbase-regionserver.default.svc.cluster.local,16020,1638449029563 on XXXXinfra-aaaa-hbase-master-0.XXXXinfra-aaaa-hbase-master.default.svc.cluster.local,16000,1638448730439 2021-12-02 12:43:54,860 INFO  [PEWorker-10] procedure.ServerCrashProcedure: Start pid=10, state=RUNNABLE:SERVER_CRASH_START; ServerCrashProcedure server=XXXXinfra-aaaa-hbase-regionserver-1.XXXXinfra-aaaa-hbase-regionserver.default.svc.cluster.local,16020,1638449029563, splitWal=true, meta=false  " [hbase-connectors] Added python client for HBase thrift service,13406254,Patch Available,Major,,13/Oct/21 01:50,,,A python client for HBase thrift service. Has request retry mechanism and exception handling. Also encapsulated redundant parameters to make the usage easier. [hbase-thirdparty] Bump guava version to 31.0.1-jre,13414156,Resolved,Major,Fixed,28/Nov/21 13:49,29/Nov/21 14:10,, [hbase-thirdparty] Bump commons-cli version to 1.5.0,13414158,Resolved,Major,Fixed,28/Nov/21 13:52,29/Nov/21 14:14,, [hbase-thirdparty] Make a 4.0.0 release for hbase-thirdparty,13414151,Resolved,Major,Fixed,28/Nov/21 13:45,17/Dec/21 04:26,, [hbase-thirdparty] Bump netty version to 4.1.70.Final,13414152,Resolved,Major,Fixed,28/Nov/21 13:45,29/Nov/21 14:08,, [hbase-thirdparty] Create a branch-3 in case we still need to support JDK7 for hbase 1.x,13414150,Open,Major,,28/Nov/21 13:27,,,And then bump the version for master to 4.x. [hbase-thirdparty] Bump gson version to 2.8.9,13414155,Resolved,Major,Fixed,28/Nov/21 13:48,29/Nov/21 14:09,, [hbase-thirdparty] Bump maven plugin versions,13414157,Resolved,Major,Fixed,28/Nov/21 13:50,30/Nov/21 15:57,, [hbase-thirdparty] Bump version to 4.0.0-SNAPSHOT on master branch,13414198,Resolved,Major,Fixed,29/Nov/21 01:20,29/Nov/21 09:24,, [hbase-thirdparty] Bump jersey version to 2.35,13414159,Resolved,Major,Fixed,28/Nov/21 13:54,01/Dec/21 13:46,, [hbase-thirdparty] Exclude the original protobuf-java jar when shading,13414149,Resolved,Major,Fixed,28/Nov/21 13:25,29/Nov/21 01:17,,"We have a patched version of protobuf and we will compile it, and then in shade we also include the original protobuf-java, where we will get lot of warnings {noformat} WARNING] hbase-shaded-protobuf-3.5.1.jar, protobuf-java-3.17.1.jar define 670 overlapping class and resource: [WARNING] - META-INF/MANIFEST.MF [WARNING] - com.google.protobuf.AbstractMessage [WARNING] - com.google.protobuf.AbstractMessage$Builder [WARNING] - com.google.protobuf.AbstractMessage$BuilderParent [WARNING] - com.google.protobuf.AbstractMessageLite [WARNING] - com.google.protobuf.AbstractMessageLite$Builder [WARNING] - com.google.protobuf.AbstractMessageLite$Builder$LimitedInputStream [WARNING] - com.google.protobuf.AbstractMessageLite$InternalOneOfEnum [WARNING] - com.google.protobuf.AbstractParser [WARNING] - com.google.protobuf.AbstractProtobufList [WARNING] - 660 more... [WARNING] maven-shade-plugin has detected that some class files are [WARNING] present in two or more JARs. When this happens, only one [WARNING] single version of the class is copied to the uber jar. [WARNING] Usually this is not harmful and you can skip these warnings, [WARNING] otherwise try to manually exclude artifacts based on [WARNING] mvn dependency:tree -Ddetail=true and the above output. [WARNING] See http://maven.apache.org/plugins/maven-shade-plugin/ [WARNING] hbase-shaded-protobuf-3.5.1-sources.jar, protobuf-java-3.17.1-sources.jar define 202 overlapping resources: [WARNING] - META-INF/MANIFEST.MF [WARNING] - com/google/protobuf/AbstractMessage.java [WARNING] - com/google/protobuf/AbstractMessageLite.java [WARNING] - com/google/protobuf/AbstractParser.java [WARNING] - com/google/protobuf/AbstractProtobufList.java [WARNING] - com/google/protobuf/AllocatedBuffer.java [WARNING] - com/google/protobuf/Android.java [WARNING] - com/google/protobuf/Any.java [WARNING] - com/google/protobuf/AnyOrBuilder.java [WARNING] - com/google/protobuf/AnyProto.java [WARNING] - 192 more... [WARNING] maven-shade-plugin has detected that some class files are [WARNING] present in two or more JARs. When this happens, only one [WARNING] single version of the class is copied to the uber jar. [WARNING] Usually this is not harmful and you can skip these warnings, [WARNING] otherwise try to manually exclude artifacts based on [WARNING] mvn dependency:tree -Ddetail=true and the above output. [WARNING] See http://maven.apache.org/plugins/maven-shade-plugin/ {noformat} Maybe this is the case why we bundle the incorrect protobuf classes and cause the failure when running with JDK8." Fix HBase TestCanaryTool for Java17,13409385,Resolved,Major,Fixed,01/Nov/21 08:24,09/Nov/21 14:27,,"The UT TestCanaryTool will fail under Java17. The error message is {code:java} [ERROR] org.apache.hadoop.hbase.tool.TestCanaryTool.testZookeeperCanaryPermittedFailuresArgumentWorks Time elapsed: 7.994 s <<< FAILURE! Wanted but not invoked: zookeeperStdOutSink.publishReadTiming( ""/hbase"", ""localhost:52497"", ); -> at org.apache.hadoop.hbase.tool.TestCanaryTool.testZookeeperCanaryWithArgs(TestCanaryTool.java:390) However, there were exactly 4 interactions with this mock: zookeeperStdOutSink.publishReadFailure( ""/hbase"", ""localhost/:52497"" ); -> at org.apache.hadoop.hbase.tool.CanaryTool$ZookeeperTask.call(CanaryTool.java:451) zookeeperStdOutSink.incReadFailureCount(); -> at org.apache.hadoop.hbase.tool.CanaryTool$ZookeeperStdOutSink.publishReadFailure(CanaryTool.java:287) zookeeperStdOutSink.getReadFailureCount(); -> at org.apache.hadoop.hbase.tool.CanaryTool$Monitor.finalCheckForErrors(CanaryTool.java:1325) zookeeperStdOutSink.getWriteFailureCount(); -> at org.apache.hadoop.hbase.tool.CanaryTool$Monitor.finalCheckForErrors(CanaryTool.java:1326) at org.apache.hadoop.hbase.tool.TestCanaryTool.testZookeeperCanaryWithArgs(TestCanaryTool.java:390) at org.apache.hadoop.hbase.tool.TestCanaryTool.testZookeeperCanaryPermittedFailuresArgumentWorks(TestCanaryTool.java:108) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:833) {code} " ArrayIndexOutOfBoundsException in KeyValueUtil.copyToNewKeyValue(),13414786,Resolved,Major,Fixed,01/Dec/21 12:53,06/Dec/21 15:59,2.2.7,"While investigating a Phoenix crash, I've found a possible problem in KeyValueUtil. When using Phoenix, we need configure (at least for older versions) org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec as a WAL codec in HBase. This codec will eventually serialize standard (not phoenix specifc WAL entries) to the WAL file, and internally converts the Cell objects to KeyValue objects, by building a new byte[]. This fails with an ArrayIndexOutOfBoundsException, because the we allocate a byte[] the size of Cell.getSerializedSize(), and it seems that we are processing a Cell that does not actually serialize the column family and later fields. However, we are building a traditional KeyValue object for serialization, which does serialize them, hence we run out of bytes. I think that since we are writing a KeyValue, we should not rely of the getSerializedSize() method of the source cell, but rather calculate the backing array size based on how KeyValue expects its data to be serialized. The stack trace for reference: {noformat} java.lang.ArrayIndexOutOfBoundsException: 9787 at org.apache.hadoop.hbase.util.Bytes.putByte(Bytes.java:502) at org.apache.hadoop.hbase.KeyValueUtil.appendKeyTo(KeyValueUtil.java:142) at org.apache.hadoop.hbase.KeyValueUtil.appendToByteArray(KeyValueUtil.java:156) at org.apache.hadoop.hbase.KeyValueUtil.copyToNewByteArray(KeyValueUtil.java:133) at org.apache.hadoop.hbase.KeyValueUtil.copyToNewKeyValue(KeyValueUtil.java:97) at org.apache.phoenix.util.PhoenixKeyValueUtil.maybeCopyCell(PhoenixKeyValueUtil.java:214) at org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$IndexKeyValueEncoder.write(IndexedWALEditCodec.java:218) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:59) at org.apache.hadoop.hbase.regionserver.wal.FSHLog.doAppend(FSHLog.java:294) at org.apache.hadoop.hbase.regionserver.wal.FSHLog.doAppend(FSHLog.java:65) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.appendEntry(AbstractFSWAL.java:931) at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.append(FSHLog.java:1075) at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:964) at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:873) at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:129) at java.lang.Thread.run(Thread.java:748) {noformat} Note that I am still not sure exactly what triggers this bug, one possibility is org.apache.hadoop.hbase.ByteBufferKeyOnlyKeyValue " Set storage policy of recovered edits when wal storage type is configured,13417690,Resolved,Major,Fixed,15/Dec/21 10:40,18/Dec/21 15:37,,"In our cluster, we has many SSD and a little HDD.  (Most table configured storage policy ONE_SSD, and all wals is configured ALL_SSD) when all cluster down, It's difficult to recovery cluster. Because HDD Disk IO bottleneck (Almost all disk io util is 100%). I think the most hdfs operation when recovery is split wal to recovered edits dir, And read it. And it goes better when i stop hbase and set all recovered.edits to ALL_SSD. So we can get benifit of recovery time if we set recovered.edits dir to better storage like WAL. Now i reuse config item  hbase.wal.storage.policy to set recovered.edits storage type. Because I did not find a scenario where they use different storage Policy" "Should use downloads.apache.org for checksum, signature, changes.md and releasenote.md",13419720,Resolved,Major,Fixed,28/Dec/21 14:00,06/Jan/22 12:35,,"We still use dist.apache.org for some releases, should change them too." Upgrade log4j to 2.17.1,13419818,Resolved,Major,Fixed,29/Dec/21 06:47,04/Jan/22 15:57,,For addressing CVE-2021-44832. Remove IndexType from ChunkCreator,13417029,Resolved,Major,Fixed,13/Dec/21 12:55,04/Jan/22 16:13,2.4.8,"For {{CellChunkImmutableSegment}}, cells in data chunks is indexed in index chunks by chunk id ,index chunks use chunk id to locate the data chunk by look up chunk id in {{ChunkCreator.chunkIdMap}} . Whether or not the {{ChunkCreator}} put the data chunk in {{ChunkCreator.chunkIdMap}} depends on the data chunk is pooled or the index type is {{IndexType.CHUNK_MAP}}. So when we call {{ChunkCreator.getChunk}}, it is very important to specify the IndexType. {{ChunkCreator}} has following package-visible method, which does not require the {{IndexType}} parameter and use {{IndexType.ARRAY_MAP}}. {code:java} Chunk getChunk(ChunkType chunkType) { return getChunk(CompactingMemStore.IndexType.ARRAY_MAP, chunkType); } {code} This method is used by following line 363 in {{MemStoreLABImpl.getNewExternalChunk}} now, which is used by {{CellChunkImmutableSegment.copyCellIntoMSLAB}} which index type is {{IndexType.CHUNK_MAP}} to force copy a big cell into {{MemStoreLAB}}, which should allocate a new not-pooled chunk. {code:java} 359 public Chunk getNewExternalChunk(ChunkCreator.ChunkType chunkType) { 360 switch (chunkType) { 361 case INDEX_CHUNK: 362 case DATA_CHUNK: 363 Chunk c = this.chunkCreator.getChunk(chunkType); 364 chunks.add(c.getId()); 365 return c; 366 case JUMBO_CHUNK: // a jumbo chunk doesn't have a fixed size 367 default: 368 return null; 369 } 370 } {code} Even though fortunately this {{IndexType}} mismatch does not cause bug now because {{MemStoreLABImpl.getNewExternalChunk}} in fact is not invoked by {{CellChunkImmutableSegment.copyCellIntoMSLAB}} when the cell is bigger than chunkSize，but I think it is dangerous to not specify the {{IndexType}} if we want to refactor or add new functionalities in the future. We would better to specify the {{IndexType}} explicitly when we use {{ChunkCreator.getChunk}}. When thinking this problem more, I think we could remove the {{IndexType}} from {{ChunkCreator}} completely to simplify the code, because when use {{MemStoreLABImpl}}, the {{IndexType}} could only be {{IndexType.CHUNK_MAP}} ,just as following line 106 in {{MemStoreLABImpl}} ctor. {code:java} 96 public MemStoreLABImpl(Configuration conf) { 97 dataChunkSize = conf.getInt(CHUNK_SIZE_KEY, CHUNK_SIZE_DEFAULT); 98 maxAlloc = conf.getInt(MAX_ALLOC_KEY, MAX_ALLOC_DEFAULT); 99 this.chunkCreator = ChunkCreator.getInstance(); 100 // if we don't exclude allocations >CHUNK_SIZE, we'd infiniteloop on one! 101 Preconditions.checkArgument(maxAlloc <= dataChunkSize, 102 MAX_ALLOC_KEY + "" must be less than "" + CHUNK_SIZE_KEY); 103 104 // if user requested to work with MSLABs (whether on- or off-heap), then the 105 // immutable segments are going to use CellChunkMap as their index 106 idxType = CompactingMemStore.IndexType.CHUNK_MAP; 107 } {code} And because the get {{chunk}} from {{ChunkCreator}} is only used by {{MemStoreLABImpl}}, and only when we not use {{MemStoreLABImpl}} we could use {{IndexType.ARRAY_MAP}}, we can remove the {{IndexType}} from {{ChunkCreator}} completely. " Upgrade junit to 4.13.2,13419719,Resolved,Major,Fixed,28/Dec/21 13:52,04/Jan/22 16:04,,"There is a CVE-2020-15250 of 4.13, not very critical but let's fix it." Add expiration for long time vacant scanners in Thrift2,13419503,Resolved,Major,Fixed,27/Dec/21 08:14,02/Jan/22 13:32,,"In thrift1 implementation, the ThriftHBaseSerivceHandler holds a Cache with an expire time after access. This will make the long time vacant scanners be collected by gc. However, in thrift2 we do not have this feature and only use a map to store scanners and we need the client close the scanner manually. If not, the expired scanners will live in memory forever. In this case, I applied the cache expiration to thrift2 service." Optimize decodeNumeric in OrderedBytes,13419869,Resolved,Major,Fixed,29/Dec/21 12:53,01/Jan/22 13:06,,"Currently, when we decode a byte array to a big decimal, there are plenty of BigDecimal operations, which result in a lot of only once used BigDecimal objects. Furthermore, the BigDecimal calculations are slow. We could boost this function by using String concatenation and point movement of BigDecimal. The JMH benchmark is uploaded to the attachment. Also, I added a UT to test the encoding / decoding correctness of 200 random test samples. The logic of the process is same as the Optimization of the encode function in the ticket [HBASE-26566|https://issues.apache.org/jira/browse/HBASE-26566]" Implement a tool to verify the lag of region replication,13415413,Resolved,Major,Fixed,04/Dec/21 14:02,17/Dec/21 13:25,,"The new region replication framework is expected to have a smaller lag when replicating, as it uses an in memory queue. We should implement a tool to see if it works as expected." Should find a way to clear the replication queue for a legacy region_replica_replication peer,13415407,Resolved,Major,Fixed,04/Dec/21 13:33,07/Dec/21 15:19,,"When rolling upgrading, we will delete the legacy region_replica_replication peer. But since the old region servers still use this peer for replicating, we can not delete all the replication queues. We need to find a way to deal with these legacy replication queues after upgrading." Attach the new region replication framework design doc to git repo,13413956,Resolved,Major,Fixed,26/Nov/21 07:13,27/Nov/21 13:30,, Update ref guide about the new region replication framework,13413118,Resolved,Major,Fixed,22/Nov/21 10:05,27/Nov/21 13:29,,"About the basic design, how to use it, and how to upgrade from old framework." Consider rolling upgrading from old region replication framework,13413205,Resolved,Major,Fixed,22/Nov/21 15:51,27/Nov/21 04:08,,"In the old implementation, we will cerate a replication peer for region replication. And in the new framework, we do not need the peer any more, so we have deleted the RegionReplicaReplicationEndpoint class. But when rolling upgrading, the peer is still there so we will try to load it and it will lead to a class not found exception. We need to handle it. And during the upgrading, some of the region servers may not have the correct replicateToReplica method yet. Maybe we could try to catch the no such method error and try to fallback to use replay method. Although it is not perfect, but finally a flush can fix everything." Remove NoopReplicationQueueStorage,13409701,Resolved,Major,Fixed,02/Nov/21 15:38,26/Nov/21 15:17,,It is not used any more since we removed CatalogReplicationSource. Limit the size for one replicating,13411629,Resolved,Major,Fixed,13/Nov/21 15:54,23/Nov/21 14:25,,"Now we will always try to replicate all the pending entries, which could be too large. We should have a size/count limit, to avoid putting too much pressure to the target region server for some extreme cases." Implement a new method for region replication instead of using replay,13409686,Resolved,Major,Fixed,02/Nov/21 14:44,22/Nov/21 15:12,,"The replay method is design to be used for DLR, which has been removed for a long time. We should have our own version for replay the edits for region replication, which could be more flexible." Should not always clear all the failed replicas when getting a flush all request,13411840,Resolved,Major,Fixed,15/Nov/21 16:05,17/Nov/21 15:21,,"As described in this section in the design doc: https://docs.google.com/document/d/1WPSBwRqIPgTrPRM2wtzAe-3XUvA9S7auWy3Fy8xuZLc/edit#heading=h.8nfip05gosr We need to make sure that all the edits which have been sent to the broken replica must have a less sequence id than the flush sequence number of the commit flush edit, then we are safe to recover it. Otherwise we may miss some edit. The current implementation is not enough, we need to improve it." Make sure we do not flush a region too frequently,13411171,Resolved,Major,Fixed,11/Nov/21 02:08,15/Nov/21 16:07,,"In HBASE-26412, once we found there is an error replicating the edits, we will trigger a flush, and in HBASE-26413, we are likely to also trigger a flush when the pending edits are too large. We should find a way to avoid flushing the region too much. And a failure of replicating usually means the region is moved or the target region server is crashed, only a flush after the secondary replica is online will be useful, so flushing the region lots of times before the scedondary replica online is just useless." Limit the total size of buffered region replication entries,13409464,Resolved,Major,Fixed,01/Nov/21 15:30,13/Nov/21 02:46,, Handle sink failure in RegionReplicationSink,13409463,Resolved,Major,Fixed,01/Nov/21 15:30,09/Nov/21 13:42,, Introduce a region replication sink for sinking WAL edits to secondary replicas directly,13409145,Resolved,Major,Fixed,29/Oct/21 16:01,02/Nov/21 02:16,,"Without reading the WAL file. This could decouple the dependency between WAL and replication a bit, and also it will have a much lower latency." Update the ref guide upgrading section to mention that the master issue when upgrading to 2.3,13419951,Resolved,Major,Fixed,30/Dec/21 01:57,31/Dec/21 04:07,,"Since we migrate the procedure store while upgrading the active master, if there are backup masters which are still on the old version should not become active any more, otherwise it may cause problems. We should mention this in the ref guide." Put up 4.0.1RC0,13418162,Resolved,Major,Fixed,17/Dec/21 05:38,29/Dec/21 12:29,, "When getting rowkey, the program enters the org.apache.hadoop.hbase.regionserver.KeyValueHeap#generalizedSeek and an endless loop occurs",13419723,Open,Major,,28/Dec/21 14:17,,,"1. Phenomenon description: Get rowkey: 350ef10764bc4af960b6b468479aff1e_ The data of 10032279726411 is the master of the program card and enters the dead cycle 2. Data information: hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/250853d176294585ae0339d11f9714c1 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:directory/1637459509892/Put/vlen=0/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1637459509892/Put/vlen=0/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637459509892/Put/vlen=14/seqid=0 hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/85ab3a19f409476aada64ab5bf906653 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:directory/1637373810660/Put/vlen=0/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1637373810660/Put/vlen=0/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637373810660/Put/vlen=14/seqid=0 hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/93cc194d62fc419792991613332b990d K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:directory/1637112759915/Put/vlen=0/seqid=1555467268 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:product_ext_nick/1637057318457/Put/vlen=27/seqid=1554882684 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:store_info_ex_pc/1637125253154/Put/vlen=10329/seqid=1555632639 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1637112759915/Put/vlen=0/seqid=1555467268 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:warehouse/1637125253154/Put/vlen=17843/seqid=1555632639 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637112759915/Put/vlen=14/seqid=1555467268 hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/a001e8a2dd454029ae38554b88018109 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:directory/1637027051359/Put/vlen=0/seqid=1554430204 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:dredisprice/1636877442107/Put/vlen=5/seqid=1552727948 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:lastupdatetime/1636829185081/Put/vlen=10/seqid=1552173184 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:store_info_ex_pc/1636979778239/Put/vlen=10297/seqid=1553901027 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1637027051359/Put/vlen=0/seqid=1554430204 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:warehouse/1636979778239/Put/vlen=17299/seqid=1553901027 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637027051359/Put/vlen=14/seqid=1554430204 hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/a62976c426574d43af4b5d3fef8af921 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:directory/1637545456304/Put/vlen=0/seqid=1556484345 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:product_ext_nick/1637629087047/Put/vlen=18/seqid=1556602639 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:union_spec_ids/1637582728941/Put/vlen=213/seqid=1556506804 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1637545456304/Put/vlen=0/seqid=1556484345 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637545456304/Put/vlen=14/seqid=1556484345 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wstate/1637549762970/Put/vlen=2/seqid=1556484528 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wyn/1637549762970/Put/vlen=1/seqid=1556484528 hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/ff8f38c495ba46398ae9c02207950f7d K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:directory/1636594256197/Put/vlen=0/seqid=1549353741 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:dredisprice/1636646590929/Put/vlen=5/seqid=1550021079 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:lastupdatetime/1635940338088/Put/vlen=10/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:product_ext_nick/1634995561817/Put/vlen=41/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:product_id/1623293068319/Put/vlen=14/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:sku_union_spec_ids/1623293068319/Put/vlen=213/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:store_info_ex_pc/1636191109189/Put/vlen=10297/seqid=1544129517 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:union_expand_ids/1623293068319/Put/vlen=0/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:union_spec_ids/1635935424287/Put/vlen=213/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:unlimit_catid/1623293068319/Put/vlen=4/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_id/1623293068319/Put/vlen=6/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1636594256197/Put/vlen=0/seqid=1549353741 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:ware_type/1623293068319/Put/vlen=1/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:ware_weight/1623293068319/Put/vlen=3/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:warehouse/1636405561106/Put/vlen=17321/seqid=1546667844 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1636594256197/Put/vlen=14/seqid=1549353741 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:warename/1623293068319/Put/vlen=99/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:warepid/1623293068319/Put/vlen=14/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:waretitle/1627360205219/Put/vlen=54/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:winsdate/1623293068319/Put/vlen=10/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wpid2/1623293068319/Put/vlen=1/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wredisprice/1623293074488/Put/vlen=5/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wstate/1635418719233/Put/vlen=1/seqid=0 K: 350ef10764bc4af960b6b468479aff1e_10032279726411/d:wyn/1623293070700/Put/vlen=1/seqid=0 3. Abnormal process: When executed to: d:vender_ name column ScanQueryMatcher.MatchCode qcode = matcher.match(cell); The return value is: seek_ NEXT_ COL，The method calling process is： seekOrSkipToNextColumn-》seekAsDirection-》reseek-》heap.resee-》generalizedSeek However, when the program executes the generalizedseek method, it cannot exit，At this time, the data information of heap is： 2021-12-28 19:02:26,801 INFO  [main] regionserver.StoreScanner(844): current:StoreFileScanner[HFileScanner for reader reader=[hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/93cc194d62fc419792991613332b990d], compression=lz4, cacheConf=cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false, firstKey=Optional[34f5c0cb717779d9ede9a8b80e46d4d4_10039682866610/d:product_ext_nick/1637109574351/Put/seqid=0], lastKey=Optional[351eb49327ecd6099a11efe0d1347724_10020558744609/d:commentcount/1637134716442/Put/seqid=0], avgKeyLen=70, avgValueLen=76, entries=3831303, length=251907468, cur=350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1637112759915/Put/vlen=0/seqid=1555467268] 2021-12-28 19:02:26,801 INFO  [main] regionserver.StoreScanner(847): keyValueScanner:StoreFileScanner[HFileScanner for reader reader=[hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/a001e8a2dd454029ae38554b88018109], compression=lz4, cacheConf=cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false, firstKey=Optional[34f5c0c9f049e2fa0b0b18b50a4f8b82_10039161263881/d:product_ext_nick/1637024214199/Put/seqid=0], lastKey=Optional[351eb49327ecd6099a11efe0d1347724_10020558744609/d:commentcount/1637044327190/Put/seqid=0], avgKeyLen=71, avgValueLen=48, entries=9028492, length=456744125, cur=350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1637027051359/Put/vlen=0/seqid=1554430204] 2021-12-28 19:02:26,801 INFO  [main] regionserver.StoreScanner(847): keyValueScanner:StoreFileScanner[HFileScanner for reader reader=[hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/ff8f38c495ba46398ae9c02207950f7d], compression=lz4, cacheConf=cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false, firstKey=Optional[34f5c0c91665cb0a1a3360076a6294f2_10037000082814/d:averagescore/1631432545837/Put/seqid=0], lastKey=Optional[351eb49327ecd6099a11efe0d1347724_10020558744609/d:wyn/1626850561189/Put/seqid=0], avgKeyLen=69, avgValueLen=26, entries=539934002, length=17765279323, cur=350ef10764bc4af960b6b468479aff1e_10032279726411/d:vender_name/1636594256197/Put/vlen=0/seqid=1549353741] 2021-12-28 19:02:26,801 INFO  [main] regionserver.StoreScanner(847): keyValueScanner:StoreFileScanner[HFileScanner for reader reader=[hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/250853d176294585ae0339d11f9714c1], compression=lz4, cacheConf=cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false, firstKey=Optional[34f5c0dcb467c26bd5355982cc01a095_43099352773/d:directory/1637459509892/Put/seqid=0], lastKey=Optional[351eb48a36179802a0f8b38452e26b7a_10039387550202/d:wareid/1637459509892/Put/seqid=0], avgKeyLen=68, avgValueLen=12, entries=336963, length=9094030, cur=350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637459509892/Put/vlen=14/seqid=-1] 2021-12-28 19:02:26,801 INFO  [main] regionserver.StoreScanner(847): keyValueScanner:StoreFileScanner[HFileScanner for reader reader=[hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/a62976c426574d43af4b5d3fef8af921], compression=lz4, cacheConf=cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false, firstKey=Optional[34f5c0cca42ad68aa73b72953336d214_10038013927618/d:catname/1637623282535/Put/seqid=0], lastKey=Optional[351eb49327ecd6099a11efe0d1347724_10020558744609/d:union_spec_ids/1637582728941/Put/seqid=0], avgKeyLen=71, avgValueLen=42, entries=18764748, length=899013217, cur=350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637545456304/Put/vlen=14/seqid=1556484345] 2021-12-28 19:02:26,801 INFO  [main] regionserver.StoreScanner(847): keyValueScanner:StoreFileScanner[HFileScanner for reader reader=[hdfs://snake/hbase/data/realtime_search/WD_MERGED_DATA/2fc7bd24c7d6d8d500f04b2480660de9/d/85ab3a19f409476aada64ab5bf906653], compression=lz4, cacheConf=cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false, firstKey=Optional[34f5c0dcb467c26bd5355982cc01a095_43099352773/d:directory/1637373810660/Put/seqid=0], lastKey=Optional[351eb48a36179802a0f8b38452e26b7a_10039387550202/d:wareid/1637373810660/Put/seqid=0], avgKeyLen=68, avgValueLen=12, entries=334692, length=9047191, cur=350ef10764bc4af960b6b468479aff1e_10032279726411/d:wareid/1637373810660/Put/vlen=14/seqid=-1] Because cur of multiple storefilescanners in heap are the  d:vender_name  columns,So in the while loop of the generalizedSeek method，After entering the while loop, the comparator will be compared infinitely getComparator(). Compare (seekkey, topkey), the next cycle will not exit,and The value of the scan variable is not changing !image-2021-12-28-22-17-36-088.png!    " Optimize encodeNumeric in OrderedBytes,13416988,Resolved,Major,Fixed,13/Dec/21 09:24,27/Dec/21 16:08,,"Found current estimate E step in OrderedBytes is to search step by step in loops. We can directly calculate the length to move the point and let the time complexity become to O(1). From the comments of the method encodeNumericLarge: {panel:title=encodeNumericLarge} Encode the large magnitude floating point number *val* using the key encoding. The caller guarantees that *val* will be finite and abs({*}val{*}) >= 1.0. A floating point value is encoded as an integer exponent *E* and a mantissa {*}M{*}. The original value is equal to {*}(M * 100^E){*}. *E* is set to the smallest value possible without making *M* greater than or equal to 1.0. Each centimal digit of the mantissa is stored in a byte. If the value of the centimal digit is *X* (hence X>=0 and X<=99) then the byte value will be 2*X+1 for every byte of the mantissa, except for the last byte which will be 2*X+0. The mantissa must be the minimum number of bytes necessary to represent the value; trailing *X==0* digits are omitted. This means that the mantissa will never contain a byte with the value 0x00. The function could be divided into 4 steps: # Confirm the sign (Negative or not) # Normalise the abs({*}val{*}), transformed to *(M * 100^E)* # Encode *M* by peeling off centimal digit and # Encode *X*{panel} At the step 2, we normalise abs(*val*) and determine the exponent *E*. The current implementation is : {code:java} while (abs.compareTo(E32) >= 0 && e <= 350) { abs = abs.movePointLeft(32); e +=16; } while (abs.compareTo(E8) >= 0 && e <= 350) { abs = abs.movePointLeft(8); e+= 4; } while (abs.compareTo(BigDecimal.ONE) >= 0 && e <= 350) { abs = abs.movePointLeft(2); e++; } {code} Which just move the point of abs(*val*), (which is in form yyyy.zzzz, where y & z are digits, e.g. 1000.0001) from right to left step by step, until abs(val) < 1. In the loop body, the increment of e is always the half of steps the point moved to left. (step=32, deltaE=16), (step=8, deltaE=4), (step=2, deltaE=1) As e starts from 0, the value of e must be the half of the total moved steps at last. So that we could save the above three loops and calculate the moved length and e directly. My implementation: {code:java} // This is the number of digits of the Integer part of abs(val) when val > 10 int integerDigits = abs.precision() - abs.scale(); // If length of the Integer part is odd, from the last loop above, we actually moved one more step forward. int lengthToMoveLeft = integerDigits % 2 == 0 ? integerDigits : integerDigits + 1; e = lengthToMoveLeft / 2; // The edge condition. if (e > 350) { e = 351; lengthToMoveLeft = 702; } abs = abs.movePointLeft(lengthToMoveLeft); {code} In this case, we only move the point once. The time complexity is O(1). Same idea to the method of encodeNumericSmall. From the JMH test, (*JmhBenchmark.java & Benchmark.log in attachments*), the throughput has an incredible improvement. At step 3 peeling off M into centimals. Current implementation is: {code:java} for (int i = 0; i < 18 && abs.compareTo(BigDecimal.ZERO) != 0; i++) { abs = abs.movePointRight(2); // Will create new BigDecimal object. d = abs.intValue(); dst.put((byte) (2 * d + 1)); abs = abs.subtract(BigDecimal.valueOf(d)); // Will create new BigDecimal object. } {code} Also move the point of big decimal step by step. BigDecimal operations are costly and create plenty of new BigDecimal objects, which are only used once. Here I tried to directly encoding the BigDecimal based on the string to avoid BigDecimal operations. My implementation: {code:java} private static void encodeToCentimal(PositionedByteRange dst, BigDecimal val) { String stringOfAbs = val.stripTrailingZeros().toPlainString(); String value = stringOfAbs.substring(stringOfAbs.indexOf('.') + 1); int d; int maxPrecision = Math.min(MAX_NUM_ENCODE_BYTES * 2, value.length()); for (int i = 0; i < maxPrecision; i += 2) { d = (value.charAt(i) - '0') * 10; if (i + 1 < maxPrecision) { d += (value.charAt(i + 1) - '0'); } dst.put((byte) (2 * d + 1)); } } {code} From the JMH test, (*EncodingBenchmark.java & Benchmark-encoding.log*) this raises the throughtput of the encoding about 200%. " The logic of the method incrementIV in Encryption class has problem,13418728,Resolved,Major,Fixed,21/Dec/21 01:53,22/Dec/21 16:17,,"{code:java} public static void incrementIv(byte[] iv, int v) { int length = iv.length; boolean carry = true; // TODO: Optimize for v > 1, e.g. 16, 32 do { for (int i = 0; i < length; i++) { if (carry) { iv[i] = (byte) ((iv[i] + 1) & 0xFF); carry = 0 == iv[i]; } else { break; } } v--; } while (v > 0); } {code} The carry flag is outside the while loop and the inner loop check the carry value is true, so that when it was set to false, it will make the rest iterations busy spinning. And the logic becomes whatever the v is, the IV will be incremented by (1 or 2). As the description in todo, this function should support increment value > 1. So that this is not what we expect I think." Backport HBASE-26613 to branch-1,13419137,Resolved,Major,Fixed,23/Dec/21 04:16,27/Dec/21 16:07,1.7.1, Snapshot referenced data files are deleted when delete a table with merge regions,13418782,Resolved,Major,Fixed,21/Dec/21 08:33,23/Dec/21 11:14,,"In our cluster, we have a feature: take a snapshot when delete a table. But when we restore the snapshot, we found that some data files are deleted. The problem is that, when delete a table with merge regions, HBase only archive regions in meta, and merged parent regions are deleted in file system which contain data files in snapshot .  " Release hbase-operator-tools 1.2.0,13416779,Resolved,Major,Resolved,11/Dec/21 13:06,27/Dec/21 04:02,, [hbase-operator-tools] Set version as 1.3.0-SNAPSHOT in master,13419359,Resolved,Major,Fixed,24/Dec/21 11:35,27/Dec/21 03:17,hbase-operator-tools-1.2.0, Add 3.0.0-alpha-2 to download page,13419163,Resolved,Major,Fixed,23/Dec/21 08:56,23/Dec/21 14:26,, Netty exclusion through ZooKeeper not effective as intended,13418312,Open,Major,,17/Dec/21 21:14,,2.4.8,"Picking up where [~psomogyi] has been digging this week. We've been seeing an issue where MiniDFS-based tests fail to start due to missing netty classes. HBASE-25969 seems to have intended to remove transitive Netty but was ineffective (at least for hadoop.profile=3.0). The dependency exclusion was for {{io.netty:netty}} and {{io.netty:netty-all}} but ZooKeeper 3.5.7 transitively depends on {{netty-handler}} and {{netty-transport-native-epoll}}  (per [https://search.maven.org/artifact/org.apache.zookeeper/zookeeper/3.5.7/jar)] The funny part is that we _should_ have seen failures in any hbase unit test using MiniDFS because we excluded netty and netty-all in HBASE-25969, but because we missed the exclusions, we still keep running. The intent of HBASE-25969 was good, but I think we need to revisit the execution. We need netty dependencies on the scope=test classpath. We just want to keep them off the scope=compile classpath (out of our client and server jars). disclaimer: I have not yet looked at 2.5.x or master yet to see if this also affects them." Round the size to MB or KB at the end of calculation in HRegionServer.createRegionLoad,13418441,Resolved,Major,Fixed,19/Dec/21 13:10,23/Dec/21 04:48,,This is a follow up issue of HBASE-26340. Fix excessive connections in MajorCompactor,13418298,Resolved,Major,Fixed,17/Dec/21 19:39,23/Dec/21 04:45,,MajorCompactor creates excessive connections: once every time MajorCompactionRequest.getConnection is called. Can do better by using the Connection object created in MajorCompactor. Put up 3.0.0-alpha-2RC2,13418430,Resolved,Major,Fixed,19/Dec/21 06:15,23/Dec/21 08:59,, Upgrade log4j2 to 2.17.0,13418429,Resolved,Major,Fixed,19/Dec/21 06:13,19/Dec/21 08:35,, [hbase-operator-tools] Upgrade log4j2 to 2.17.0,13418434,Resolved,Major,Fixed,19/Dec/21 08:39,19/Dec/21 17:22,, Memory leak when MemStore retry flushing,13413966,Resolved,Major,Fixed,26/Nov/21 07:47,18/Dec/21 05:29,2.4.8,"{{HStore.flushCache}} use following {{DefaultStoreFlusher.flushSnapshot}} to flush memStore and retry this method when this method throws exception(the default retry count is 10),but increasing reference count of {{MemStoreLABImpl}} which used by {{DefaultMemStore.snapshot}} in following line 55 and decreasing reference count of {{MemStoreLABImpl}} in following line 82 is asymmetrical： {code:java} 47 public List flushSnapshot(MemStoreSnapshot snapshot, long cacheFlushId, 48 MonitoredTask status, ThroughputController throughputController, 49 FlushLifeCycleTracker tracker) throws IOException { 50 ArrayList result = new ArrayList<>(); 51 int cellsCount = snapshot.getCellsCount(); 52 if (cellsCount == 0) return result; // don't flush if there are no entries 53 54 // Use a store scanner to find which rows to flush. 55 InternalScanner scanner = createScanner(snapshot.getScanners(), tracker); 56 StoreFileWriter writer; 57 try { 58 // TODO: We can fail in the below block before we complete adding this flush to 59 // list of store files. Add cleanup of anything put on filesystem if we fail. 60 synchronized (flushLock) { 61 status.setStatus(""Flushing "" + store + "": creating writer""); 62 // Write the map out to the disk 63 writer = store.createWriterInTmp(cellsCount, 64 store.getColumnFamilyDescriptor().getCompressionType(), false, true, 65 snapshot.isTagsPresent(), false); 66 IOException e = null; 67 try { 68 performFlush(scanner, writer, throughputController); 69 } catch (IOException ioe) { 70 e = ioe; 71 // throw the exception out 72 throw ioe; 73 } finally { 74 if (e != null) { 75 writer.close(); 76 } else { 77 finalizeWriter(writer, cacheFlushId, status); 78 } 79 } 80 } 81 } finally { 82 scanner.close(); 83 } ...... {code} The asymmetry because above line 55 {{snapshot.getScanners}} ,which is following {{MemStoreSnapshot.getScanners}}： {code:java} public List getScanners() { return scanners; } {code} {{MemStoreSnapshot.getScanners}} does not create new {{SegmentScanner}}, instead it reuses the {{SegmentScanner}} in following line 43 created in {{MemStoreSnapshot}} ctor： {code:java} 38 public MemStoreSnapshot(long id, ImmutableSegment snapshot) { 39 this.id = id; 40 this.cellsCount = snapshot.getCellsCount(); 41 this.memStoreSize = snapshot.getMemStoreSize(); 42 this.timeRangeTracker = snapshot.getTimeRangeTracker(); 43 this.scanners = snapshot.getSnapshotScanners(); 44 this.tagsPresent = snapshot.isTagsPresent(); 45 } {code} So when flushing MemStore by {{DefaultStoreFlusher.flushSnapshot}} at first time, the reference count of {{MemStoreLABImpl}} which used by {{DefaultMemStore.snapshot}} is 1, and if {{DefaultStoreFlusher.flushSnapshot}} throws exception, the {{SegmentScanner}} of {{DefaultMemStore.snapshot}} is closed at the end of {{DefaultStoreFlusher.flushSnapshot}} , and the reference count of corresponding {{MemStoreLABImpl}} is decreased to 0. When retry flushing {{MemStore}} by {{DefaultStoreFlusher.flushSnapshot}} at second time, if it success, the {{SegmentScanner}} of {{DefaultMemStore.snapshot}} is closed again at the end of {{DefaultStoreFlusher.flushSnapshot}} , and the reference count of corresponding {{MemStoreLABImpl}} is decreased to -1. When flush is completed, {{DefaultMemStore.clearSnapshot}} is called to close {{DefaultMemStore.snapshot}} and corresponding {{MemStoreLABImpl}} , but in the following line 268, reference count is -1 not 0, so {{MemStoreLABImpl.recycleChunks}} is not called and the Chunks used by this {{MemStoreLABImpl}} is leaked. {code:java} 261 public void close() { 262 if (!this.closed.compareAndSet(false, true)) { 263 return; 264 } 265 // We could put back the chunks to pool for reusing only when there is no 266 // opening scanner which will read their data 267 int count = openScannerCount.get(); 268 if(count == 0) { 269 recycleChunks(); 270 } 271 } {code} My fix is for {{MemStoreSnapshot.getScanners}}, we call {{snapshot.getSnapshotScanners}} to create a new {{SegmentScanner}}, and we do not create {{SegmentScanner}} in {{MemStoreSnapshot}} ctor." [hbase-operator-tools] Upgrade to log4j 2.16.0,13417341,Resolved,Major,Fixed,14/Dec/21 09:27,14/Dec/21 11:04,, Upgrade to log4j 2.16.0,13417343,Resolved,Major,Fixed,14/Dec/21 09:29,14/Dec/21 20:37,, Upgrade to log4j 2.16.0,13417339,Resolved,Major,Done,14/Dec/21 09:27,14/Dec/21 20:37,,"Log4j just release version 2.16.0 where jndi is turned off by default. Based on the release announcement it is not required to fix CVE-2021-44228 but recommended.  [https://lists.apache.org/thread/d6v4r6nosxysyq9rvnr779336yf0woz4]" Put up 3.0.0-alpha-2RC1,13417236,Resolved,Major,Fixed,14/Dec/21 00:14,19/Dec/21 06:14,, log4j2 has a critical RCE vulnerability,13416434,Resolved,Major,Fixed,10/Dec/21 04:09,14/Dec/21 00:12,,"Impacted log4j version: Apache Log4j 2.x <= 2.14.1 I found that our current log4j version at master is 2.14.1. Should upgrade the version to 2.15.0" Missing junit when executing IntegrationTestRegionReplicaReplication,13418274,Open,Major,,17/Dec/21 15:55,,,"{noformat} Exception in thread ""main"" java.lang.NoClassDefFoundError: org/junit/Assert at org.apache.hadoop.hbase.IntegrationTestIngest.initTable(IntegrationTestIngest.java:101) at org.apache.hadoop.hbase.IntegrationTestIngest.setUpCluster(IntegrationTestIngest.java:92) at org.apache.hadoop.hbase.IntegrationTestBase.setUp(IntegrationTestBase.java:170) at org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:153) at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:153) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.IntegrationTestRegionReplicaReplication.main(IntegrationTestRegionReplicaReplication.java:225) Caused by: java.lang.ClassNotFoundException: org.junit.Assert at java.net.URLClassLoader.findClass(URLClassLoader.java:387) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ... 7 more {noformat}" [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 4.0.1,13418161,Resolved,Major,Fixed,17/Dec/21 05:38,17/Dec/21 14:13,, [hbase-thirdparty] Set version as 4.0.1 in prep for first RC,13418159,Resolved,Major,Fixed,17/Dec/21 05:38,17/Dec/21 14:12,, Protobuf Services should be resolved by their full name,13418072,Open,Major,,16/Dec/21 18:44,,2.5.0,"I noticed this while investigating test failures resulting from HBASE-26542. The test in question ({{TestRpcServerSlowConnectionSetup}}) builds a connection header by populating the {{serviceName}} field with the service descriptor's {{getFullName()}} method. The value returned by {{getFullName()}} is the protobuf service's package and name. However, down in {{RpcServer}}, we resolve the service named by the connection header using the service descriptor's {{getName()}} method. {{getName()}} returns the protobuf service's name, without the package. It is my opinion that this is a bug in the {{RpcServer}}, it should resolve services using their fully qualified name." [hbase-operator-tools] Set version as 1.2.0 in master,13417378,Resolved,Major,Resolved,14/Dec/21 09:59,15/Dec/21 06:22,, [hbase-operator-tools] Generate CHANGES.md and RELEASENOTES.md for 1.2.0,13417375,Resolved,Major,Resolved,14/Dec/21 09:58,15/Dec/21 02:23,, StoreHotnessProtector may block Replication,13417531,Open,Major,,14/Dec/21 19:32,,,"I'm upgrading from hbase1 to hbase2, and I'm still in my QA environment where load is very low. Even still, I've noticed some bad interaction between Replication and the StoreHotnessProtector. The ReplicationSink collects edits from the WAL and executes them in batches via the normal HTable interface. Despite the name of this property, the max batch sizes are based on ""hbase.rpc.rows.warning.threshold"" which has a default of 5000.  The StoreHotnessProtector defaults to allowing 10 concurrent writes (of 100 columns or more) to a Store, or 20 concurrent ""prepares"" of said writes. The Prepare part is what causes issues here. When a batch mutate comes in, the RS first takes a lock on all rows in the batch. This happens in HRegion#lockRowsAndBuildMiniBatch, and the writes are recorded as ""preparing"" in StoreHotnessProtector before acquiring the lock. This recording basically increments a counter, and throws an exception if that counter goes over 20. Back in HRegion#lockRowsAndBuildMiniBatch, the exception is caught and recorded in the results for any items that failed. Any items that succeed continue on to write,  unless the write is atomic, in which case it immediately throws an exception. This response gets back to the client, which automatically handles retries. With enough retries, the batch call will eventually succeed because each retry contains fewer and fewer writes to handle. Assuming you have enough retries, this is basically enforcing an automatic chunking of of a batch write into sub-batches of 20. Again, this only affects writes that hit more than 100 columns (by default). At this point I'll say that this in general seems overly aggressive, especially since the StoreHotnessProtector doesn't actually do any checks for actual load on the RS. You could have a totally idle RegionServer and submit a single batch of 100 Puts with 101 columns each – if you don't have at least 5 retries configured, the batch will fail. Back to ReplicationSink, the default batch size is 5000 Puts and the default retries is 4. For a table with wide rows (which might cause replication to try to sink Puts with more than 100 columns), it becomes basically impossible to replicate because the number of retries is not nearly enough to move through a batch of up to 5000, 20 at a time." Put up 3.0.0-alpha-2RC0,13416597,Resolved,Major,Fixed,10/Dec/21 15:54,14/Dec/21 00:13,, [hbase-thirdparty] Put up 4.0.0RC1,13414805,Resolved,Major,Fixed,01/Dec/21 13:54,13/Dec/21 15:31,, Set version as 3.0.0-alpha-2 in master in prep for first RC of 3.0.0-alpha-2,13416596,Resolved,Major,Fixed,10/Dec/21 15:38,11/Dec/21 12:55,, Unexpected crash of meta RegionServer causes the cluster out of service,13409964,Open,Major,,04/Nov/21 03:12,,1.7.1,"We have a cluster of two HMasters, C3HM1 and C3HM2, and three RegionServers, C3RS1, C3RS2, C3RS3. We use an external ZooKeeper cluster which is a pseudo-distributed cluster: {code:java} hbase.zookeeper.quorum C3hb-zk hbase.zookeeper.property.clientPort 11181 {code} For other HBase options, we use the default settings. The buggy scenario is as follows: 1. Start the cluster, C3HM1 becomes the active master; 2. C3RS2 crashes right before creating the znode ""/hbase/meta-region-server"" on ZooKeeper; {code:java} [org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.createNonSequential(RecoverableZooKeeper.java:665), org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.create(RecoverableZooKeeper.java:644), org.apache.hadoop.hbase.zookeeper.ZKUtil.createAndWatch(ZKUtil.java:1182), org.apache.hadoop.hbase.zookeeper.MetaTableLocator.setMetaLocation(MetaTableLocator.java:464), org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2182), org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler$PostOpenDeployTasksThread.run(OpenRegionHandler.java:329)] {code} 3. The meta server is still not online after 10 minutes. The data of znode ""/hbase/master"" is C3HM1. And the bug does not appear on HBase-2.4.5. " [hbase-operator-tools] Upgrade log4j2 to 2.15.0 to address CVE-2021-44228,13416777,Resolved,Major,Fixed,11/Dec/21 13:01,11/Dec/21 13:06,, Unexpected crash makes client receive error exception,13407263,Open,Major,,19/Oct/21 10:37,,1.7.1,"There is a table {{mytable}} in a HBase cluster with two HMasters and two RegionServers. 1. Current active HMaster is HMaster1; 2. Client disabled the table {{mytable}}; 3. {{mytable}} is in disabled state; 4. Client request to truncate {{mytable}}; 5. HMaster1 tries to truncate {{mytable}}. For the TruncateTableState {{TRUNCATE_TABLE_ASSIGN_REGIONS}}, HMaster1 assigns the regions of the table and mark the table as Enabling; 6. HMaster1 crashes; 7. HMaster2 becomes active; 8. Client gets info that the truncate operation failed due to {{TableNotDisabledException}}, while the table has already be truncated. In HMaster2, we got following info: {code:java} INFO [ProcedureExecutor-12] procedure2.ProcedureExecutor: Rolledback procedure TruncateTableProcedure (table=mytable preserveSplits=true) id=9 owner=myhbase state=ROLLEDBACK exec-time=4.6030 sec exception=org.apache.hadoop.hbase.TableNotDisabledException: mytable {code} It seems that the client receives such error message due to HMaster's recovery process is recovering the truncate table process. But for client, it should not get this error message caused by HMaster failover. Similarly, for create table, disable table request, client can get java.util.concurrent.TimeoutException caused by HMaster failover." [HBOSS] Update readme to reflect dependencies change introduced by HBASE-25900,13414289,Open,Major,,29/Nov/21 12:17,,, Passing an invalid DURABILITY when creating a table enters an endless loop of retries,13415884,Open,Major,,07/Dec/21 18:25,,,"As part of our Hbase2 upgrade, our automation copies the HTableDescriptor from a CDH5 cluster into the HBase2 cluster, then kicks off replication. During our testing we encountered a misconfigured table, which had a DURABILITY => 'DEFAULT', when the correct value is 'USE_DEFAULT'. In hbase 1.x, any invalid value encountered by Durability.valueOf is try/caught and results in the default value of USE_DEFAULT. So this misconfiguration caused no pain in cdh5. In hbase 2.x+, the IllegalArgumentException from Durability.valueOf is no longer caught. This is probably a good thing, but unfortunately it caused the CreateTableProcedure to fail in a way that resulted in an endless loop of retries, with no backoff. This may be a general issue with CreateTableProcedure – there should probably be a pre-step which validates the HTableDescriptor and terminally fails if invalid. Additionally, does it make sense to have a backoff on the retry of procedures? The vary rapid retry of this procedure actually caused HDFS issues because it was creating many thousands of .regioninfo files in rapid succession, enough to lag replication and cause DataNodes to be considered bad, which caused RegionServers to abort due to failed WAL writes." HMaster should move non-meta region only if meta is ONLINE,13412263,Resolved,Major,Fixed,17/Nov/21 12:01,03/Dec/21 17:31,1.7.1,"Any non-meta region movement has dependency over meta's availability, hence it is important for any non-meta region to wait for meta to be assigned and be available for scan before attempting to move non-meta region. This concept has already been well managed by SCP (ServerCrashProcedure) on HBase 1.x and 2.x versions. However, for 1.x versions, HMaster#move API doesn't check for any prerequisite of meta being available before attempting to move any non-meta region. On the other hand, 2.x versions already have TransitRegionStateProcedure (TRSP) in place that uses lock _LockState.LOCK_EVENT_WAIT_ in case if meta is not yet assigned and loaded in AssignmentManager's memory: {code:java} @Override protected boolean waitInitialized(MasterProcedureEnv env) { if (TableName.isMetaTableName(getTableName())) { return false; } // First we need meta to be loaded, and second, if meta is not online then we will likely to // fail when updating meta so we wait until it is assigned. AssignmentManager am = env.getAssignmentManager(); return am.waitMetaLoaded(this) || am.waitMetaAssigned(this, getRegion()); } {code} For 1.x versions, it is recommended to introduce configurable wait time in master's region move API for non-meta region movement until meta region is available. If meta remains in transition after the wait time elapses, we should fail fast and avoid non-meta region move." Make timestamp format configurable in HBase shell scan output,13414288,Resolved,Major,Fixed,29/Nov/21 12:16,01/Dec/21 19:19,3.0.0-alpha-1,"HBASE-23930 and HBASE-24937 has changed the timestamp format shown in scan results in HBase shells. This may break existing use cases that use hbase shell as a client. (as opposed to the java, rest, or thrift APIs) I propose adding a configuration option to make it configurable. " Move tracing semantic attributes to their own class,13412864,Resolved,Major,Fixed,20/Nov/21 00:42,01/Dec/21 21:24,2.5.0,A small refactor of constants used by tracing. Unexpected crash in the process of deleting a table causes stale data in ZooKeeper,13407888,Open,Major,,22/Oct/21 06:26,,1.7.1,"There is a table {{mytable}} in a HBase cluster with two HMasters and two RegionServers. 1. Current active HMaster is HMaster1; 2. Client request to delete the table {{mytable}}; 3. HMaster1 deletes znode in ZooKeeper: /hbase/table/mytable {code:java} [org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:238), org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1367), org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1359), org.apache.hadoop.hbase.zookeeper.ZKTableStateManager.setDeletedTable(ZKTableStateManager.java:244), org.apache.hadoop.hbase.master.procedure.DeleteTableProcedure.deleteAssignmentState(DeleteTableProcedure.java:383), org.apache.hadoop.hbase.master.procedure.DeleteTableProcedure.executeFromState(DeleteTableProcedure.java:136), org.apache.hadoop.hbase.master.procedure.DeleteTableProcedure.executeFromState(DeleteTableProcedure.java:57), org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:139), org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:499), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1166), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:954), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:907), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$400(ProcedureExecutor.java:76), org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.run(ProcedureExecutor.java:481), org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.run(ProcedureExecutor.java)] {code} 4. HMaster1 crashes before deleting the znode: /hbase/table-lock/mytable {code:java} [org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:238), org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1341), org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1330), org.apache.hadoop.hbase.master.TableLockManager$ZKTableLockManager.tableDeleted(TableLockManager.java:442), org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.markTableAsDeleted(MasterProcedureScheduler.java:895), org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.completionCleanup(MasterProcedureScheduler.java:261), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.procedureFinished(ProcedureExecutor.java:1415), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:974), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:907), org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$400(ProcedureExecutor.java:76), org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.run(ProcedureExecutor.java:481), org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.run(ProcedureExecutor.java)] {code} 5. HMaster2 becomes active 6. The table {{mytable}} was deleted, but the znode ""/hbase/table-lock/mytable"" was left on ZooKeeper. " Region Server doesn't exit cleanly incase it crashes.,13412645,Resolved,Major,Fixed,18/Nov/21 21:59,01/Dec/21 05:51,1.6.0,"Observed this in our production cluster running 1.6 version. RS crashed due to some reason but the process was still running. On debugging more, found out there was 1 non-daemon thread running and that was not allowing RS to exit cleanly. Our clusters are managed by Ambari and have auto restart capability within them. But since the process was running and pid file was present, Ambari also couldn't do much. There will be some bug where we will miss to stop some non daemon thread. Shutdown hook will not be called unless one of the following 2 conditions are met: # The Java virtual machine shuts down in response to two kinds of events: The program exits normally, when the last non-daemon thread exits or when the exit (equivalently, System.exit) method is invoked, or # The virtual machine is terminated in response to a user interrupt, such as typing ^C, or a system-wide event, such as user logoff or system shutdown. Considering the first condition, when the last non-daemon thread exits or when the exit method is invoked. Below is the code snippet from [HRegionServerCommandLine.java|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java#L51] {code:java} private int start() throws Exception { try { if (LocalHBaseCluster.isLocal(conf)) { // Ignore this. } else { HRegionServer hrs = HRegionServer.constructRegionServer(regionServerClass, conf); hrs.start(); hrs.join(); if (hrs.isAborted()) { throw new RuntimeException(""HRegionServer Aborted""); } } } catch (Throwable t) { LOG.error(""Region server exiting"", t); return 1; } return 0; } {code} Within HRegionServer, there is a subtle difference between when a server is aborted v/s when it is stopped. If it is stopped, then isAborted will return false and it will exit with return code 0. Below is the code from [ServerCommandLine.java|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java#L147] {code:java} public void doMain(String args[]) { try { int ret = ToolRunner.run(HBaseConfiguration.create(), this, args); if (ret != 0) { System.exit(ret); } } catch (Exception e) { LOG.error(""Failed to run"", e); System.exit(-1); } } {code} If return code is 0, then it won't call System.exit. This means JVM will wait to call ShutdownHook until all non daemon threads are stopped which means infinite wait if we don't close all non-daemon threads cleanly. " [hbase-thirdparty] Put up 4.0.0RC0,13414329,Resolved,Major,Fixed,29/Nov/21 15:06,01/Dec/21 13:54,, [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 4.0.0,13414328,Resolved,Major,Fixed,29/Nov/21 15:06,01/Dec/21 13:53,, [hbase-thirdparty] Set version as 4.0.0 in prep for first RC,13414327,Resolved,Major,Fixed,29/Nov/21 15:04,30/Nov/21 14:59,, TestStochasticLoadBalancerRegionReplicaWithRacks fails consistently,13411615,Resolved,Major,Fixed,13/Nov/21 12:42,28/Nov/21 14:24,,"https://nightlies.apache.org/hbase/HBase/HBase-Find-Flaky-Tests/master/442/output/dashboard.html [~claraxiong] Mind taking a look? I guess it is because some recent changes... Thanks." Remove 1.4.x from our download page,13408662,Resolved,Major,Fixed,27/Oct/21 10:30,28/Nov/21 15:36,, EOL 1.4.x,13408567,Resolved,Major,Fixed,27/Oct/21 02:43,29/Nov/21 01:14,, Update HEADER.html to mention the EOL of 1.4.x,13414172,Resolved,Major,Fixed,28/Nov/21 16:12,28/Nov/21 16:13,, Remove 1.4.14 from dist.a.o,13414171,Resolved,Major,Fixed,28/Nov/21 16:05,28/Nov/21 16:09,, Update vote.tmpl in our create-release scripts to link KEYS from downloads.a.o instead of dist.a.o,13413504,Resolved,Major,Fixed,24/Nov/21 01:52,27/Nov/21 12:17,,This is required by the ASF policy. Make DefaultMemStore extensible for HStore.memstore ,13412944,Resolved,Major,Fixed,20/Nov/21 13:05,27/Nov/21 04:11,2.4.8,"When {{HStore.memstore}} is {{DefaultMemStore}} , I find that it is impossible to extend {{DefaultMemStore}} to add some custom logic when I was work on HBASE-26465, because following code in {{HStore.getMemstore}} and {{HStore.getMemstore}} is a private method and is called in {{HStore}} ctor .We should make the {{DefaultMemStore}} extensible just as in branch-1. {code:java} switch (inMemoryCompaction) { case NONE: ms = ReflectionUtils.newInstance(DefaultMemStore.class, new Object[] { conf, getComparator(), this.getHRegion().getRegionServicesForStores()}); break; default: Class clz = conf.getClass(MEMSTORE_CLASS_NAME, CompactingMemStore.class, CompactingMemStore.class); ms = ReflectionUtils.newInstance(clz, new Object[]{conf, getComparator(), this, this.getHRegion().getRegionServicesForStores(), inMemoryCompaction}); } return ms; } {code}" WALPrettyPrinter: JSON output is broken/malformed,13412444,Open,Major,,18/Nov/21 06:26,,1.7.1,"The JSON output of wal pretty printer is malformed and cannot be parsed. There are 2 major issue: * The writer classes and cell codec classes are added (as normal text) whenever a new WAL file printing starts (NOTE: WALPrettyPrinter can take multiple WAL files as input) * The edit heap size and position are outside json formatting These are side effects of some patches done in past which missed to cover json output scenarios. Current sample output, which is malformed JSON: {code:java} [Writer Classes: ProtobufLogWriter AsyncProtobufLogWriter Cell Codec Class: org.apache.hadoop.hbase.regionserver.wal.WALCellCodec {""sequence"":""3"",""region"":""f0153c5d890d96f06ec304eebc4aacf9"",""actions"":[{""qualifier"":""HBASE::REGION_EVENT::REGION_OPEN"",""vlen"":176,""row"":""\\x00"",""type"":""Put"",""family"":""METAFAMILY"",""timestamp"":""1637170532553"",""total_size_sum"":""288""}],""table"":{""name"":[104,98,97,115,101,58,110,97,109,101,115,112,97,99,101],""nameAsString"":""hbase:namespace"",""namespace"":[104,98,97,115,101],""namespaceAsString"":""hbase"",""qualifier"":[110,97,109,101,115,112,97,99,101],""qualifierAsString"":""namespace"",""systemTable"":true,""hashCode"":771659354}}edit heap size: 328 position: 389 ,{""sequence"":""26"",""region"":""e42fbcf354fcf7e4e425f2d06130797c"",""actions"":[{""qualifier"":""HBASE::REGION_EVENT::REGION_OPEN"",""vlen"":218,""row"":""\\x00"",""type"":""Put"",""family"":""METAFAMILY"",""timestamp"":""1637170533215"",""total_size_sum"":""336""}],""table"":{""name"":[116,101,115,116],""nameAsString"":""test"",""namespace"":[100,101,102,97,117,108,116],""namespaceAsString"":""default"",""qualifier"":[116,101,115,116],""qualifierAsString"":""test"",""systemTable"":false,""hashCode"":3556498}}edit heap size: 376 position: 726 ,{""sequence"":""4"",""region"":""f0153c5d890d96f06ec304eebc4aacf9"",""actions"":[{""qualifier"":""d"",""vlen"":9,""row"":""default"",""type"":""Put"",""family"":""info"",""timestamp"":""1637170533278"",""total_size_sum"":""96""}],""table"":{""name"":[104,98,97,115,101,58,110,97,109,101,115,112,97,99,101],""nameAsString"":""hbase:namespace"",""namespace"":[104,98,97,115,101],""namespaceAsString"":""hbase"",""qualifier"":[110,97,109,101,115,112,97,99,101],""qualifierAsString"":""namespace"",""systemTable"":true,""hashCode"":771659354}}edit heap size: 136 position: 834 ,{""sequence"":""5"",""region"":""f0153c5d890d96f06ec304eebc4aacf9"",""actions"":[{""qualifier"":""d"",""vlen"":7,""row"":""hbase"",""type"":""Put"",""family"":""info"",""timestamp"":""1637170533340"",""total_size_sum"":""88""}],""table"":{""name"":[104,98,97,115,101,58,110,97,109,101,115,112,97,99,101],""nameAsString"":""hbase:namespace"",""namespace"":[104,98,97,115,101],""namespaceAsString"":""hbase"",""qualifier"":[110,97,109,101,115,112,97,99,101],""qualifierAsString"":""namespace"",""systemTable"":true,""hashCode"":771659354}}edit heap size: 128 position: 938 ,{""sequence"":""27"",""region"":""e42fbcf354fcf7e4e425f2d06130797c"",""actions"":[{""qualifier"":"""",""vlen"":2,""row"":""r6"",""type"":""Put"",""family"":""cf"",""timestamp"":""1637170714545"",""total_size_sum"":""80""}],""table"":{""name"":[116,101,115,116],""nameAsString"":""test"",""namespace"":[100,101,102,97,117,108,116],""namespaceAsString"":""default"",""qualifier"":[116,101,115,116],""qualifierAsString"":""test"",""systemTable"":false,""hashCode"":3556498}}edit heap size: 120 position: 1020 Writer Classes: ProtobufLogWriter AsyncProtobufLogWriter Cell Codec Class: org.apache.hadoop.hbase.regionserver.wal.WALCellCodec ,{""sequence"":""3"",""region"":""f0153c5d890d96f06ec304eebc4aacf9"",""actions"":[{""qualifier"":""HBASE::REGION_EVENT::REGION_OPEN"",""vlen"":176,""row"":""\\x00"",""type"":""Put"",""family"":""METAFAMILY"",""timestamp"":""1637170532553"",""total_size_sum"":""288""}],""table"":{""name"":[104,98,97,115,101,58,110,97,109,101,115,112,97,99,101],""nameAsString"":""hbase:namespace"",""namespace"":[104,98,97,115,101],""namespaceAsString"":""hbase"",""qualifier"":[110,97,109,101,115,112,97,99,101],""qualifierAsString"":""namespace"",""systemTable"":true,""hashCode"":771659354}}edit heap size: 328 position: 389 ,{""sequence"":""26"",""region"":""e42fbcf354fcf7e4e425f2d06130797c"",""actions"":[{""qualifier"":""HBASE::REGION_EVENT::REGION_OPEN"",""vlen"":218,""row"":""\\x00"",""type"":""Put"",""family"":""METAFAMILY"",""timestamp"":""1637170533215"",""total_size_sum"":""336""}],""table"":{""name"":[116,101,115,116],""nameAsString"":""test"",""namespace"":[100,101,102,97,117,108,116],""namespaceAsString"":""default"",""qualifier"":[116,101,115,116],""qualifierAsString"":""test"",""systemTable"":false,""hashCode"":3556498}}edit heap size: 376 position: 726 ,{""sequence"":""4"",""region"":""f0153c5d890d96f06ec304eebc4aacf9"",""actions"":[{""qualifier"":""d"",""vlen"":9,""row"":""default"",""type"":""Put"",""family"":""info"",""timestamp"":""1637170533278"",""total_size_sum"":""96""}],""table"":{""name"":[104,98,97,115,101,58,110,97,109,101,115,112,97,99,101],""nameAsString"":""hbase:namespace"",""namespace"":[104,98,97,115,101],""namespaceAsString"":""hbase"",""qualifier"":[110,97,109,101,115,112,97,99,101],""qualifierAsString"":""namespace"",""systemTable"":true,""hashCode"":771659354}}edit heap size: 136 position: 834 ,{""sequence"":""5"",""region"":""f0153c5d890d96f06ec304eebc4aacf9"",""actions"":[{""qualifier"":""d"",""vlen"":7,""row"":""hbase"",""type"":""Put"",""family"":""info"",""timestamp"":""1637170533340"",""total_size_sum"":""88""}],""table"":{""name"":[104,98,97,115,101,58,110,97,109,101,115,112,97,99,101],""nameAsString"":""hbase:namespace"",""namespace"":[104,98,97,115,101],""namespaceAsString"":""hbase"",""qualifier"":[110,97,109,101,115,112,97,99,101],""qualifierAsString"":""namespace"",""systemTable"":true,""hashCode"":771659354}}edit heap size: 128 position: 938 ,{""sequence"":""27"",""region"":""e42fbcf354fcf7e4e425f2d06130797c"",""actions"":[{""qualifier"":"""",""vlen"":2,""row"":""r6"",""type"":""Put"",""family"":""cf"",""timestamp"":""1637170714545"",""total_size_sum"":""80""}],""table"":{""name"":[116,101,115,116],""nameAsString"":""test"",""namespace"":[100,101,102,97,117,108,116],""namespaceAsString"":""default"",""qualifier"":[116,101,115,116],""qualifierAsString"":""test"",""systemTable"":false,""hashCode"":3556498}}edit heap size: 120 position: 1020 ] {code}" The flush and compact methods in HTU should skip processing secondary replicas,13412879,Resolved,Major,Fixed,20/Nov/21 05:15,23/Nov/21 10:59,,"To avoid generating bunch of ""NOT flushing because not writable"" warning logs." Try to rebuild the stripes in child regions to improve compaction efficiency,13410048,Open,Major,,04/Nov/21 13:03,,,"This is an issue to improve the old rebuild stripes logic when loading files. And this issue is not necessary for the umbrella." Hbase Export/Import via MapReduce job,13411259,Resolved,Major,Not A Bug,11/Nov/21 11:55,17/Nov/21 15:35,2.0.1,"Hi Hbase support team,   While using the MapReduce job with export/import commands we have the below behaviour.   {+}Step1{+}:  I have a hbase table(tsdb) with 3 rows. and export the table like below: /opt/hbase/bin/hbase org.apache.hadoop.hbase.mapreduce.Export tsdb file:///opt/hbase/backup/tsdb {+}Step2{+}: Then I delete 1 row. {+}Step3{+}: Then I import tsdb table from the exported data from Step 1. /opt/hbase/bin/hbase org.apache.hadoop.hbase.mapreduce.Import tsdb file:///opt/hbase/backup/tsdb   There are still only 2 rows in the table. Is this a valid behaviour?   Br, Chris" [hboss] Delete self lock without orphaning znode,13412387,Open,Major,,18/Nov/21 01:21,,,"Fallout from HBASE-26437 {quote}Could do the {{removeInMemoryLocks}} separately in HBASE-26453, but I think then znodes would get created again when unlocking, failing this PR tests. So, once we fix {{{}removeInMemoryLocks{}}}, we need to make sure {{rename}} and {{delete}} would not recreate the path again when calling {{{}unlock{}}}. {quote} The changes from HBASE-26453 inadvertently passed their unit tests because we didn't remove the Mutex object like we intended to do (after deleting a file/dir or renaming a file/dir, we intend to remove the mutex and znode for that file/dir and all beneath it). Right now, we only actually delete the children (znode and mutex objects) for that deleted/renamed path. Meaning, we are still orphaning resources. I implemented the fix in lockRename based on what we did in lockDelete, so we're making incremental progress. The lock cleanup process and Mutex logic need to be reworked because we cannot do it in two-phases as we currently do. In order to get the mutex to release it (when we are holding it already), we currently will re-create znodes back in ZooKeeper. The other solution, based on googling, appears to be to use a [Reaper|https://www.javadoc.io/doc/org.apache.curator/curator-recipes/2.4.1/org/apache/curator/framework/recipes/locks/Reaper.html]. This might also be an easier solution to the problem to do the rest of the cleanup." Some BaseLoadBalancer log lines should be at DEBUG level,13411142,Resolved,Major,Fixed,10/Nov/21 22:10,16/Nov/21 00:11,2.4.9,"These are printed per chore run, per host: {noformat} [00]2021-11-10 22:07:32,998 INFO  [master/ip-172-31-58-47:8100.Chore.1] balancer.BaseLoadBalancer: server is on rack {noformat} One log line per server. On a large cluster, this is a lot of unnecessary logging. The 'server is on rack ' log line arguably should be at TRACE. It is not interesting unless you are debugging the balancer. This 'Start Generate Balance plan for cluster.' log line should be at DEBUG: {noformat} [00]2021-11-10 22:07:32,984 INFO [master/ip-172-31-58-47:8100.Chore.1] balancer.BaseLoadBalancer: Start Generate Balance plan for cluster. {noformat} While we are in here, this should also be logged at DEBUG level: {noformat} [00]2021-11-10 22:14:33,005 INFO  [master/ip-172-31-58-47:8100.Chore.1] master.HMaster: Balancer is going into sleep until next period in 60000ms {noformat} " "BucketCacheWriter should log only the BucketAllocatorException message, not the full stack trace",13411144,Resolved,Major,Fixed,10/Nov/21 22:13,16/Nov/21 00:42,2.4.8,"We have recently improved the logging of BucketAllocatorException to not overwhelm the log if there are a lot of blocks that are too large, but when we do log it, we still log the full stack trace. That is wasteful. The messages always come from the same location in source code. The stack trace provides no value." Rollback from ZK-less to ZK-based assignment could produce inconsistent state - doubly assigned regions,13410677,Resolved,Major,Fixed,08/Nov/21 17:48,09/Nov/21 17:14,1.7.1,"By enabling config {_}hbase.assignment.usezk.migrating{_}, we initiate the transition of HBase 1.x cluster from default ZK-based region assignment to ZK-less region assignments. Once the migration is enabled, any subsequent region transition is going to add two additional CQs in meta: info:sn and info:state. The workflow that adds new CQs in meta should be the only workflow reading it (unless it requires coordination among multiple workflows), however that is not the case here. Reading info:sn and info:state to rebuild user region states in RegionStateStore data structure is a hidden bug because it doesn't restrict the usage for only ZK-less region assignment. What are the effects? After enabling ZK-less migration, if we revert it back, info:state and info:sn are not reverted. Moreover, new active master rebuilds the region states in memory and use this info. So if all regions have consistent info:sn values (i.e. consistent with info:server and info:serverstartcode), nothing goes wrong and this is likely going to happen when we revert the config with rolling restart of masters. However, after this config revert, if any region moves, only info:server and info:serverstartcode get updated but info:sn and info:state values stay the same. Because of the missing condition, subsequent active master restart would try to rebuild regions and assign regions as per info:sn, but those regions are already OPEN on info:server, hence we get doubly assigned regions. We need two part fix for this: # Guard reading of info:sn and info:state with proper conditions. # Once active master init is complete, if ZK-based region assignment is enabled and redundant CQs are available in meta (info:sn and info:state), delete them all." Fix flaky test TestHStore.testCompactingMemStoreCellExceedInmemoryFlushSize,13410981,Resolved,Major,Fixed,10/Nov/21 06:48,12/Nov/21 15:10,2.4.8,"{{TestHStore.testCompactingMemStoreCellExceedInmemoryFlushSize}} sometimes is failed and the error stack is : {code:java} org.apache.hadoop.hbase.DroppedSnapshotException: Failed clearing memory after 6 attempts on region: table,,1636366699236.cc87b170ebf180005d5c4bf09d404b3d. at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1788) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1595) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1563) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1528) at org.apache.hadoop.hbase.regionserver.TestHStore.tearDown(TestHStore.java:661) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.RunAfters.invokeMethod(RunAfters.java:46) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) {code} If I modify the test code to make the test method finished after waiting for in memory compacting completed, the test would fail all the time with the same error stack, and if the test method finished before the in memory compacting start, the test would always success. Why the test would fail after the in memory compacting completed is somewhat subtle: 1. Because {{TestHStore}} only test {{HStore}} , so in following {{TestHStore.init}} method the new store is created separately and does not added to {{HRegion.stores}}， {code:java} private HStore init(String methodName, Configuration conf, TableDescriptorBuilder builder, ColumnFamilyDescriptor hcd, MyStoreHook hook, boolean switchToPread) throws IOException { initHRegion(methodName, conf, builder, hcd, hook, switchToPread); if (hook == null) { store = new HStore(region, hcd, conf, false); } else { store = new MyStore(region, hcd, conf, hook, switchToPread); } return store; } {code} 2.When cell is added to Store,{{HStore.add}} method would not increase {{HRegion.memStoreSizing}}, {{HRegion.memStoreSizing}} is always 0, but when in memory compaction, the cell is forced to copy to MSLAB by {{CellChunkImmutableSegment.copyCellIntoMSLAB}} in following line 218 in {{CellChunkImmutableSegment.reinitializeCellSet}} ,so the type of the cell is changed from {{KeyValue}} to {{NoTagByteBufferChunkKeyValue}},which size increased 4 byte and {{HRegion.memStoreSizing}} is 4 : {code:java} 211 try { 212 while ((curCell = segmentScanner.next()) != null) { 213 assert(curCell instanceof ExtendedCell); 214 if (((ExtendedCell)curCell).getChunkId() == ExtendedCell.CELL_NOT_BASED_ON_CHUNK) { 215 // CellChunkMap assumes all cells are allocated on MSLAB. 216 // Therefore, cells which are not allocated on MSLAB initially, 217 // are copied into MSLAB here. 218 curCell = copyCellIntoMSLAB(curCell, memstoreSizing); 219 } {code} 3. When the region close, following {{HRegion.doClose}} finds that {{HRegion.memStoreSizing}} is not zero in line 1772 and tries to flush the region,but the {{HRegion.stores}} is empty so flushing takes no effect, when the {{failedfFlushCount}} bigger than 5, {{DroppedSnapshotException}} is thrown. {code:java} 1771 long remainingSize = this.memStoreSizing.getDataSize(); 1772 while (remainingSize > 0) { 1773 try { 1774 internalFlushcache(status); 1775 if(flushCount >0) { 1776 LOG.info(""Running extra flush, "" + flushCount + 1777 "" (carrying snapshot?) "" + this); 1778 } 1779 flushCount++; 1780 tmp = this.memStoreSizing.getDataSize(); 1781 if (tmp >= remainingSize) { 1782 failedfFlushCount++; 1783 } 1784 remainingSize = tmp; 1785 if (failedfFlushCount > 5) { 1786 // If we failed 5 times and are unable to clear memory, abort 1787 // so we do not lose data 1788 throw new DroppedSnapshotException(""Failed clearing memory after "" + 1789 flushCount + "" attempts on region: "" + 1790 Bytes.toStringBinary(getRegionInfo().getRegionName())); 1791 } {code} My fix is adding the new created {{HStore}} to {{HRegion.stores}} in {{TestHStore.init}} " Optimization for weighted random generators,13405516,Resolved,Major,Fixed,07/Oct/21 22:45,11/Nov/21 01:58,,"Currently we use four move candidate generators and pick one randomly for every move with even probability, all with optimization associated with a certain group of cost functions. We can assign weight for the random picking of generators based on balancing pressure on each group. " Segment already flushed to hfile may still be remained in CompactingMemStore ,13407479,Resolved,Major,Fixed,20/Oct/21 10:43,10/Nov/21 19:14,2.4.8,"When {{CompactingMemStore}} prepares flushing, {{CompactingMemStore.snapshot}} invokes following {{CompactingMemStore.pushPipelineToSnapshot}} method to get {{Snapshot}}, following line 570 and line 575 uses {{CompactionPipeline#version}} to track whether the Segments in {{CompactionPipeline#pipeline}} has changed since it gets {{VersionedSegmentsList}} in line 570 before emptying {{CompactionPipeline#pipeline}} in line 575. {code:java} 565 private void pushPipelineToSnapshot() { 566 int iterationsCnt = 0; 567 boolean done = false; 568 while (!done) { 569 iterationsCnt++; 570 VersionedSegmentsList segments = pipeline.getVersionedList(); 571 pushToSnapshot(segments.getStoreSegments()); 572 // swap can return false in case the pipeline was updated by ongoing compaction 573 // and the version increase, the chance of it happenning is very low 574 // In Swap: don't close segments (they are in snapshot now) and don't update the region size 575 done = pipeline.swap(segments, null, false, false); ....... } {code} However, when {{CompactingMemStore#inMemoryCompaction}} executes {{CompactionPipeline#flattenOneSegment}}, it does not change {{CompactionPipeline#version}} , if there is an {{in memeory compaction}} which executes {{CompactingMemStore#flattenOneSegment}} between above line 570 and line 575, the {{CompactionPipeline#version}} not change, but the {{Segment}} in {{CompactionPipeline}} has changed. Because {{CompactionPipeline#version}} not change, {{pipeline.swap}} in above line 575 could think it is safe to invoke following {{CompactionPipeline#swapSuffix}} method to remove {{Segment}} in {{CompactionPipeline}} , but the {{Segment}} in {{CompactionPipeline}} has changed because of {{CompactingMemStore#flattenOneSegment}} , so the {{Segment}} not removed in following line 295 and still remaining in {{CompactionPipeline}}. {code:java} 293 private void swapSuffix(List suffix, ImmutableSegment segment, 294 boolean closeSegmentsInSuffix) { 295 pipeline.removeAll(suffix); 296 if(segment != null) pipeline.addLast(segment); .... {code} However {{CompactingMemStore.snapshot}} think it is successful and continues to flush the {{Segment}} got by {{CompactingMemStore.snapshot}} as normal, but the {{Segment}} with the same cells still be left in {{CompactingMemStore}}. Leaving {{Segment}} which already flushed in {{MemStore}} is dangerous: if a Major Compaction before the left {{Segment}} flushing, there may be data erroneous. My Fix in the PR is as following: # Increasing the {{CompactionPipeline#version}} in {{CompactingMemStore#flattenOneSegment}} . Branch-2 has this problem but master not， because the branch-2 patch for HBASE-18375 omitting this. # For {{CompactionPipeline#swapSuffix}} , explicitly checking that the {{Segment}} in {{suffix}} input parameter is same as the {{Segment}} in {{pipeline}} one by one from the last element to the first element of {{suffix}} ， I think explicitly throwing Exception is better than hiding error and causing subtle problem. I made separate PRs for master and branch-2 so the code for master and brach-2 could consistent and master could also has UTs for this problem. [PR#3777|https://github.com/apache/hbase/pull/3777] is for master and [PR#3779|https://github.com/apache/hbase/pull/3779] is for branch-2.The difference between them is patch for brach-2 including following code in {{CompactionPipeline.replaceAtIndex}} which not included in branch-2 patch for HBASE-18375: {code:java} // the version increment is indeed needed, because the swap uses removeAll() method of the // linked-list that compares the objects to find what to remove. // The flattening changes the segment object completely (creation pattern) and so // swap will not proceed correctly after concurrent flattening. version++; {code} " Remove 'Review Board' section from the site,13410109,Resolved,Major,Fixed,04/Nov/21 17:45,10/Nov/21 04:51,,"Under the ""Apache HBase Project"" menu we have a link off to Review Board. We have settled on Github for code review, so we should drop that link." Replicas cohosted on a rack shouldn't keep triggering Balancer,13404873,Resolved,Major,Fixed,04/Oct/21 22:23,11/Nov/21 02:01,,"Currently, Balancer has a shortcut check for cohosted replicas of the same region/host/rack and will keep triggering balancer if it is non-zero. With the trending of kube and cloud solution for HBase, operators don't have full control of the topology or are not even aware of the topology. There are cases that it is not possible to satisfy or requires sacrificing other constraints such as region count balancing on RS. We want to keep there per RS/host check for availability of regions, especially for meta region. We haven't heard problem with rack so far. The cost functions will still be considered during balancing." TestReplicationEndpoint#testInterClusterReplication fails in branch-1,13411135,Open,Major,,10/Nov/21 19:53,,1.7.1,"{noformat} [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ hbase-server --- [INFO] [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.replication.TestReplicationEndpoint [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.978 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.TestReplicationEndpoint [ERROR] org.apache.hadoop.hbase.replication.TestReplicationEndpoint Time elapsed: 3.921 s <<< FAILURE! java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at org.apache.hadoop.hbase.replication.TestReplicationEndpoint.tearDownAfterClass(TestReplicationEndpoint.java:88) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestReplicationEndpoint.tearDownAfterClass:88 [INFO] [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0 {noformat} It fails if testInterClusterReplication is run alone but succeeds (depending on the order of test it ran) as a test suite." HeapMemoryManager fails memstore flushes with NPE if enabled,13410331,Resolved,Major,Fixed,05/Nov/21 22:01,09/Nov/21 02:31,2.4.8,"Nonstandard configuration under test: {quote} hfile.block.cache.size.min.range 0.1 hfile.block.cache.size.max.range 0.5 hbase.regionserver.global.memstore.size.min.range 0.2 hbase.regionserver.global.memstore.size.max.range 0.7 {quote} The NPE: {noformat} 2021-11-05 21:52:13,828 ERROR [MemStoreFlusher.1] regionserver.MemStoreFlusher: Cache flusher failed for entry [flush region IntegrationTestLoadCommonCrawl,com.yeqingteng.www//gysy/28,1636143958130.4be7e8d968cc73cf729cb4713328f729.] java.lang.NullPointerException at org.apache.hadoop.hbase.regionserver.HeapMemoryManager$HeapMemoryTunerChore.flushRequested(HeapMemoryManager.java:402) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.notifyFlushRequest(MemStoreFlusher.java:661) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:616) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:586) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:360) {noformat} The reason for the NPE is obvious in MemStoreFlusher.java. " Add hadoop 3.3.x to our hadoop version support matrix,13410403,Resolved,Major,Fixed,06/Nov/21 15:45,08/Nov/21 08:07,, "Add hadoop 2.10.1, 3.2.2 and 3.3.1 to our hadoop checks",13410286,Resolved,Major,Fixed,05/Nov/21 16:01,07/Nov/21 17:09,, Remove branch-1.4 from compatibility matrix and release manager section in our ref guide,13408572,Resolved,Major,Fixed,27/Oct/21 03:10,06/Nov/21 15:01,, Modify download page to mention that 2.4.x is the stable release line,13410156,Resolved,Major,Fixed,05/Nov/21 01:40,05/Nov/21 15:55,,"We have updated the pointer in the dist, but our download page still marks 2.3.x as the stable release line." Clear useless moved files' reference files,13410046,Open,Major,,04/Nov/21 12:55,,, Limit min size of stripe and L0 files compaction,13407085,Resolved,Major,Won't Fix,18/Oct/21 14:04,04/Nov/21 12:28,2.0.0,"In the StripeCompactPolicy#needsSingleStripeCompaction, it only checks if the file count is up to the min compaction limit. {code:java} protected boolean needsSingleStripeCompaction(StripeInformationProvider si) { int minFiles = this.config.getStripeCompactMinFiles(); for (List stripe : si.getStripes()) { if (stripe.size() >= minFiles) return true; } return false; } {code} When select files in stripe by ExploringCompactionPolicy#applyCompactionPolicy, there is no min size limit too. {code:java} // Sanity checks if (potentialMatchFiles.size() < minFiles) { continue; } if (potentialMatchFiles.size() > maxFiles) { continue; } // Compute the total size of files that will // have to be read if this set of files is compacted. long size = getTotalStoreSize(potentialMatchFiles); // Store the smallest set of files. This stored set of files will be used // if it looks like the algorithm is stuck. if (mightBeStuck && size < smallestSize) { smallest = potentialMatchFiles; smallestSize = size; } if (size > comConf.getMaxCompactSize(mayUseOffPeak)) { continue; } ++opts; if (size >= comConf.getMinCompactSize() && !filesInRatio(potentialMatchFiles, currentRatio)) { continue; }{code} While we should also limit the min size of compaction for stripes, because small stripe compactions will occupy the compaction queue.  " Can not add peer replicating to non-HBase,13409083,Resolved,Major,Fixed,29/Oct/21 09:44,02/Nov/21 07:39,2.4.0,"Failed to add a peer replicating to non-HBase(like MQ) by implementing custom ReplicationEndpoint,  got exception like this in my UT:  {code:java} 2021-10-29T15:14:47,632 INFO  [RPCClient-NioEventLoopGroup-5-3] client.RawAsyncHBaseAdmin$ReplicationProcedureBiConsumer(2761): Operation: ADD_REPLICATION_PEER, peerId: 1 failed with Invalid cluster key: , should not replicate to itself for HBaseInterClusterReplicationEndpoint2021-10-29T15:14:47,632 INFO  [RPCClient-NioEventLoopGroup-5-3] client.RawAsyncHBaseAdmin$ReplicationProcedureBiConsumer(2761): Operation: ADD_REPLICATION_PEER, peerId: 1 failed with Invalid cluster key: , should not replicate to itself for HBaseInterClusterReplicationEndpoint org.apache.hadoop.hbase.DoNotRetryIOException: Invalid cluster key: , should not replicate to itself for HBaseInterClusterReplicationEndpoint at java.lang.Thread.getStackTrace(Thread.java:1559) at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130) at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149) at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:186) at org.apache.hadoop.hbase.client.Admin.addReplicationPeer(Admin.java:1948) at org.apache.hadoop.hbase.client.Admin.addReplicationPeer(Admin.java:1936) at org.apache.hadoop.hbase.replication.TestNonHBaseReplicationEndpoint.test(TestNonHBaseReplicationEndpoint.java:97) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) at --------Future.get--------(Unknown Source) at org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.checkClusterId(ReplicationPeerManager.java:527) at org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.checkPeerConfig(ReplicationPeerManager.java:367) at org.apache.hadoop.hbase.master.replication.ReplicationPeerManager.preAddPeer(ReplicationPeerManager.java:123) at org.apache.hadoop.hbase.master.replication.AddPeerProcedure.prePeerModification(AddPeerProcedure.java:101) at org.apache.hadoop.hbase.master.replication.ModifyPeerProcedure.executeFromState(ModifyPeerProcedure.java:162) at org.apache.hadoop.hbase.master.replication.ModifyPeerProcedure.executeFromState(ModifyPeerProcedure.java:43) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:190) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:953) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1667) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981) {code} HBASE-24743 ignored this situation and introduced this bug." Aborting to preserve WAL as source of truth can abort in recoverable situations,13409189,Open,Major,,29/Oct/21 19:25,,1.8.0,"HBASE-26195 added an important feature to avoid data corruption by preserving the WAL as a source of truth when WAL sync fails. See that issue for background. That issue's primary driver was a TimeoutIOException, but the solution was to catch and abort on Throwable. The idea here was that we can't anticipate all possible failures, so we should err on the side of data correctness. As pointed out by [~rushabh.shah] in his comments, this solution has the potential to lose HBase capacity quickly in ""not very grave"" situations. It would be good to add an escape hatch for those explicit known cases, of which I recently encountered: I recently rolled this out to some of our test clusters, most of which are small. Afterward, doing a rolling restart of DataNodes caused the following IOException: ""Failed to replace a bad datanode on the existing pipeline due to no more good datanodes being available to try..."" If you're familiar with HDFS pipeline recovery, this error will be familiar. Basically the restarted DataNodes caused pipeline failures, those datanodes were added to an internal exclude list that never gets cleared, and eventually there were no more nodes to choose from resulting in an error. This error is pretty explicit, and at this point the DFSOutputStream for the WAL is dead. I think this error is a reasonable one to simply bubble up and not abort the RegionServer on, instead just failing and rolling back the writes. What do people think about starting an allowlist of known good error messages for which we do not trigger an abort of the RS? Something like this: {{} catch (Throwable t) {}} {{  // WAL sync failed. Aborting to avoid a mismatch between the memstore, WAL,}} {{  // and any replicated clusters.}} {{  if (!walSyncSuccess && !allowedException(t)) {}} {{  rsServices.abort(""WAL sync failed, aborting to preserve WAL as source of truth"", t);}} \{{ }}} {{... snip ..}} {{private boolean allowedException(Throwable t) {}}{\{  }} {{  return t.getMessage().startsWith(""Failed to replace a bad datanode"");}} {{}}} We could of course make configurable if people like, or just add to it over time." Update javadoc for CellUtil#createCell with tags methods.,13408687,Resolved,Major,Fixed,27/Oct/21 13:11,01/Nov/21 08:03,2.4.8,"We have the following methods in CellUtil class which are deprecated. We used to use this method within custom COPROC to create cells with custom tags. We deprecated them in 2.0.0 version and created a new class called RawCell which is LimitedPrivate with visibility set to COPROC. There is no reference to RawCell#createCell(Cell cell, List tags) method in javadoc of CellUtil#createCell methods which are now deprecated. This is not user friendly. We should improve the javadoc within CellUtil#createCell(Cell, tags) method. {noformat} /** * Note : Now only CPs can create cell with tags using the CP environment * @return A new cell which is having the extra tags also added to it. * @deprecated As of release 2.0.0, this will be removed in HBase 3.0.0. * */ @Deprecated public static Cell createCell(Cell cell, List tags) { return PrivateCellUtil.createCell(cell, tags); } {noformat} {noformat} public static Cell createCell(Cell cell, byte[] tags) public static Cell createCell(Cell cell, byte[] value, byte[] tags) { {noformat} This improvement is only applicable to branch-2 since we have removed these methods in branch-3. " Make flaky find job track more builds,13404494,Resolved,Major,Fixed,01/Oct/21 12:55,29/Oct/21 10:37,,"As now we could use the nightlies.apache.org to store the test output for saving space, which means we can keep more builds, so we could have more builds for our flaky dashboard." Cache in RSRpcServices.executeProcedures does not take effect,13408219,Resolved,Major,Fixed,25/Oct/21 11:28,26/Oct/21 08:07,2.4.8,"In {{RSRpcServices.executeProcedures}} , we use tdCache to avoid reading from the {{TableDescritor}} every time(usually it will read from the file system), just as following line 3923 : {code:java} 3914 public ExecuteProceduresResponse executeProcedures(RpcController controller, 3915 ExecuteProceduresRequest request) throws ServiceException { 3916 try { 3917 checkOpen(); 3918 throwOnWrongStartCode(request); 3919 regionServer.getRegionServerCoprocessorHost().preExecuteProcedures(); 3920 if (request.getOpenRegionCount() > 0) { 3921 // Avoid reading from the TableDescritor every time(usually it will read from the file 3922 // system) 3923 Map tdCache = new HashMap<>(); 3924 request.getOpenRegionList().forEach(req -> executeOpenRegionProcedures(req, tdCache)); 3925 } ...... {code} but for {{RSRpcServices.executeOpenRegionProcedures}} in above line 3924, there is no place to fill the {{tdCache}}, so the {{tdCache}} does not take effect in fact." Upload src tarball to nightlies for nightly jobs,13407866,Resolved,Major,Fixed,22/Oct/21 02:54,25/Oct/21 15:44,,"The src tarball is around 30-40MB, so it is also a bit space consuming. Let’s upload it to nightlies and link it from the Jenkins artifacts." Clear CellScanner when replay,13407493,Resolved,Major,Fixed,20/Oct/21 12:14,21/Oct/21 14:13,2.4.7,"RSRpcServices#mutate and RSRpcServices#multi we clear CellScanner immediately when get CellScanner from HBaseRpcController，so need it in RSRpcServices#replay and RSRpcServices#replicateWALEntry also. {code} // rpc controller is how we bring in data via the back door; it is unprotobuf'ed data. // It is also the conduit via which we pass back data. HBaseRpcController controller = (HBaseRpcController)rpcc; CellScanner cellScanner = controller != null ? controller.cellScanner(): null; if (controller != null) { controller.setCellScanner(null); } {code} if not we will see the error like the following {code} 2021-10-18 12:04:13,971 WARN [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16022] ipc.RpcServer: RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16022: caught: java.lang.IllegalArgumentException: ReferenceCount : 0 (expected: > 0) at org.apache.hbase.thirdparty.io.netty.util.internal.ObjectUtil.checkPositive(ObjectUtil.java:80) at org.apache.hadoop.hbase.nio.ByteBuff.checkRefCount(ByteBuff.java:70) at org.apache.hadoop.hbase.nio.SingleByteBuff.hasRemaining(SingleByteBuff.java:155) at org.apache.hadoop.hbase.codec.KeyValueCodec$ByteBuffKeyValueDecoder.advance(KeyValueCodec.java:90) at org.apache.hadoop.hbase.ipc.CellBlockBuilder.encodeCellsTo(CellBlockBuilder.java:191) at org.apache.hadoop.hbase.ipc.CellBlockBuilder.buildCellBlockStream(CellBlockBuilder.java:228) at org.apache.hadoop.hbase.ipc.ServerCall.setResponse(ServerCall.java:243) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:168) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code} " Use gen_redirect_html for linking flaky test logs,13407406,Resolved,Major,Fixed,20/Oct/21 01:57,22/Oct/21 13:59,,Missed this part when implementing HBASE-26360... Upload mvn site artifacts for nightly build to nightlies,13406774,Resolved,Major,Fixed,15/Oct/21 11:15,21/Oct/21 15:15,,"It is also pretty big and due to the strict CSP rules, the site is not fully functional on jenkins. Sometimes we also have site build for pre commit, but it is rare and we include the url in yetus vote table, where it is not easy to replace the url with nightlies. So this issue only focus on nightly job." Add 1.4.14 to download page,13408258,Resolved,Major,Fixed,25/Oct/21 14:47,26/Oct/21 15:09,, Remove jenkins files for branch-1.4,13408571,Resolved,Major,Fixed,27/Oct/21 03:09,27/Oct/21 10:25,,"The nightly for branch-1.4 has been broken for a very long time. Since now we have decided to EOL branch-1.4, let's remove these jenkins files for branch-1.4." Release 1.4.14,13406268,Resolved,Major,Fixed,13/Oct/21 05:38,27/Oct/21 02:43,,"Per the end of this thread: https://lists.apache.org/thread.html/r34d3fb86d667f8b3e58cbba78655733ac76e10f5883650f4910adc5c%40%3Cdev.hbase.apache.org%3E Let's do a final 1.4.14 release and mark branch-1.4 as EOL." Design doc for HBase NamedQueue framework,13405824,Resolved,Major,Fixed,10/Oct/21 17:00,12/Oct/21 15:17,,We have a couple of usecases already being served by the NamedQueue framework. It would be good to also provide a design doc to provide the high level system components view and let other usecases be onboarded with ease. Release 2.3.7,13407354,Resolved,Major,Done,19/Oct/21 17:48,25/Oct/21 20:35,, Send announce email,13407362,Resolved,Major,Done,19/Oct/21 17:50,25/Oct/21 20:34,, Add 2.3.7 to downloads page,13407361,Resolved,Major,Fixed,19/Oct/21 17:50,21/Oct/21 13:12,, Put up 1.4.14RC0,13406284,Resolved,Major,Fixed,13/Oct/21 06:39,25/Oct/21 14:46,, Publish test logs for flaky jobs to nightlies,13404493,Resolved,Major,Fixed,01/Oct/21 12:53,07/Oct/21 15:36,, Prioritize meta region move over other region moves in region_mover,13407316,Resolved,Major,Fixed,19/Oct/21 14:46,20/Oct/21 17:43,1.6.0,"We have seen few issues in production when meta region movement took some time from one server to another and in the meanwhile some other system table's regions were also moved (that were hosted on the same server) simultaneously but when non-meta system regions came online on other servers, the new servers could not make info:sn update to meta table for updated destination of system regions (e.g namespace region) and at the same time, active master was also bounced and the new active master that comes online usually reads namespace region's location from meta table and considers it as final, hence even if for instance, namespace region is already online (but on different host), the inconsistent info:sn value would prevent master from getting initialized because it keeps waiting for namespace region's availability on old regionserver. In this case, we need to make special arrangement to bring namespace region online on the old server only. {code:java} 2021-10-12 20:00:00,630 INFO [1f507eff84ef336f1250] regionserver.HRegionServer - Post open deploy tasks for hbase:namespace,1626899414773.52693312958f1f507eff84ef336f1250. 2021-10-12 20:04:18,622 INFO [1f507eff84ef336f1250] hbase.MetaTableAccessor - Updated row hbase:namespace,1626899414773.52693312958f1f507eff84ef336f1250. with server=server-0,60020,1633467603387 2021-10-12 20:04:18,622 INFO [1f507eff84ef336f1250] client.AsyncProcess - #27, waiting for some tasks to finish. Expected max=0, tasksInProgress=4 hasError=false, tableName=hbase:meta 2021-10-12 20:04:18,622 INFO [1f507eff84ef336f1250] client.AsyncProcess - Left over 4 task(s) are processed on server(s): [] 2021-10-12 20:04:18,622 DEBUG [1f507eff84ef336f1250] regionserver.HRegionServer - Finished post open deploy task for hbase:namespace,1626899414773.52693312958f1f507eff84ef336f1250. {code} Similar to namespace, even other user or system table regions that are hosted on the same server as meta have also encountered inconsistent state updates specifically when meta region moves around and active master is also restarted around the same time. And once active master comes online, we have to fix such inconsistencies with hbck. On the other hand, there have been some enhancement around not requiring meta region's colocation with active master as part of ZK-less region assignment, e.g HBASE-11610 We have not yet enabled ZK-less region assignment entirely, only migration config is enabled i.e. hbase.assignment.usezk.migrating. With this, we expect active master to perform an additional write to meta table for the updated region state (in addition to updating RIT map in the memory of RegionStates). We have seen some hanging state here as well if meta region is going through some transition (not available) and other non-meta regions are also moved by the region mover simultaneously, and active master cannot complete meta update, which further delays intermediate state transition based ZK watcher updates. {code:java} client.AsyncProcess - #3, waiting for 1 actions to finish on table: hbase:meta {code} If we take a step back, and think about these issues, all issues are associated with graceful start/stop of regionservers. Region mover will try to move all regions of the given server in parallel using user configurable thread pool and hence it gives no preference to meta. On the other hand, after trying to reproduce this inconsistent region state behaviour with non-graceful start/stop, I have realized that we don't face such issues because ServerCrashProcedure (SCP) always prioritize meta region's availability over any other regions if the server being processed by the SCP was hosting the meta region. This is exactly what region_mover should also provide. Given that every non-meta region's location is stored in meta table, meta region must always be moved first and only after it comes online, can other regions be allowed to be moved in parallel using the configured thread pool." Fix broken links and use https in HEADER.html,13407776,Resolved,Major,Fixed,21/Oct/21 13:21,21/Oct/21 13:24,, Modify HEADER.html to reflect recent stable and EOL release line changes,13407647,Resolved,Major,Fixed,21/Oct/21 01:49,21/Oct/21 13:20,, Remove EOL artifacts from release dist,13407773,Resolved,Major,Fixed,21/Oct/21 13:14,21/Oct/21 13:17,,"They are 1.6.0 and 2.2.7, as they are not listed on the download page any more." Generate CHANGES.txt for 1.4.14,13406283,Resolved,Major,Fixed,13/Oct/21 06:38,17/Oct/21 14:39,, TestThriftServer is failing 100% in our flaky test job,13406976,Resolved,Major,Fixed,18/Oct/21 03:57,18/Oct/21 14:36,2.3.6,https://nightlies.apache.org/hbase/HBase/HBase-Find-Flaky-Tests/master/410/output/dashboard.html Push signed release tag,13407360,Resolved,Major,Done,19/Oct/21 17:50,19/Oct/21 17:52,, Update reporter tool with new release,13407359,Resolved,Major,Done,19/Oct/21 17:49,19/Oct/21 17:52,, Promote artifacts in SVN,13407358,Resolved,Major,Done,19/Oct/21 17:49,19/Oct/21 17:51,, Release version 2.3.7 in Jira,13407357,Resolved,Major,Done,19/Oct/21 17:49,19/Oct/21 17:51,, """Release"" staged nexus repository",13407356,Resolved,Major,Done,19/Oct/21 17:49,19/Oct/21 17:51,, Spin RCs,13407355,Resolved,Major,Done,19/Oct/21 17:49,19/Oct/21 17:51,, Use gen_redirect_html for linking test logs,13406597,Resolved,Major,Fixed,14/Oct/21 15:11,17/Oct/21 15:28,,"It is introduced in HBASE-26341, for linking the flaky dashboard. We could also use it to link test logs." Set version as 1.4.14 in branch-1.4 in prep for first RC of 1.4.14,13406282,Resolved,Major,Fixed,13/Oct/21 06:37,17/Oct/21 14:06,, Upload dashboard html for flaky find job to nightlies,13405728,Resolved,Major,Fixed,09/Oct/21 04:04,14/Oct/21 15:09,,"This is an example https://nightlies.apache.org/hbase/flaky.html The nightlies server does not have strict CSP rules so it could display the html correctly." "Fix Bug for MultiByteBuff.put(int, byte)",13405817,Resolved,Major,Fixed,10/Oct/21 12:18,14/Oct/21 15:02,2.4.7,"MultiByteBuff. put(int index, byte b) has some obvious bugs, following line 732 should be getItemIndex(*index*), not getItemIndex(*limit*); {code:java} 730 public MultiByteBuff put(int index, byte b) { 731 checkRefCount(); 732 int itemIndex = getItemIndex(limit); 733 ByteBuffer item = items[itemIndex]; 734 item.put(index - itemBeginPos[itemIndex], b); 735 return this; 736 } {code}" Implement a special procedure to migrate rs group information when upgrading,13405972,Resolved,Major,Fixed,11/Oct/21 15:28,14/Oct/21 14:52,, Loosen Dockerfile pinned package versions for `create-release/mac-sshd-gpg-agent/Dockerfile`,13406411,Resolved,Major,Fixed,13/Oct/21 17:42,13/Oct/21 19:16,,We need to apply a similar fix as was done for other dockerfiles in HBASE-24631. hbck2 setRegionState cannot set replica region state,13405520,Resolved,Major,Fixed,07/Oct/21 23:28,11/Oct/21 20:48,hbase-operator-tools-1.1.0,"Currently, there is no way to use hbck2 setRegionState to set a replica region's state, which makes hard to fix inconsistency related with replica regions." Upgrade commons-io to 2.11.0,13404957,Resolved,Major,Fixed,05/Oct/21 10:15,10/Oct/21 18:31,,The 2.11.0 version got released from commons-io. Design support for rsgroup data isolation ,13405880,In Progress,Major,,11/Oct/21 08:13,,,Put down design for changes required to support rsgroup data isolation.   SshPublisher will skip uploading artifacts if the build is failure,13405532,Resolved,Major,Fixed,08/Oct/21 02:23,09/Oct/21 02:14,,"This is not what we expect, need to force it always try to upload the artifacts." Publish the test logs for pre commit jenkins job to nightlies ,13404492,Resolved,Major,Fixed,01/Oct/21 12:52,07/Oct/21 15:51,, Upgrade commons-io to 2.11.0 in hbase-connectors,13405403,Resolved,Major,Fixed,07/Oct/21 13:21,08/Oct/21 14:21,,Upgrade commons-io in hbase-connectors to 2.11.0. verify hbase testing infra is up to date wrt H node renaming,13405205,Open,Major,,06/Oct/21 13:55,,,"Infra is renaming all the H* nodes. https://cwiki.apache.org/confluence/display/INFRA/H+node+renaming+Proposal do a pass through the Jenkins scripts and manually configured jobs to make sure we either do not directly name H* nodes or to update such for the rename." Add Admin or HBaseHbck method waiting for a procedure by pid,13415688,Open,Minor,,06/Dec/21 22:14,,,"HBaseHbck methods like unassigns and assigns return a list of pids. It's hard to do anything with these pids because the GetProcedureResultRequest used by HBaseAdmin is not publicly accessible. It would be very helpful to expose the waitProcedureResult method used by ProcedureFuture in HBaseAdmin, or something else like that. The use-case I have in mind is for a stuck region, where you might want to use HBaseHbck.unassigns followed by assigns. But you should not do assigns until the unassigns has finished, so we need a way to wait for the returned pids." Update ref guide section for IT and Chaos Monkey to explain the additions from HBASE-26556,13417558,Resolved,Minor,Fixed,14/Dec/21 21:49,25/Jan/22 17:26,,"HBASE-26556 introduced a customisable monkey factory for the slow deterministic policy, as well as made possible for pluggable implementations of the hbase remote shell commands. This is to document how these new features can be used." IT and Chaos Monkey improvements,13416414,Resolved,Minor,Fixed,10/Dec/21 00:17,14/Dec/21 21:46,2.3.7,"While running the IntegrationTestIngest with slowDeterministic chaos monkey in our environment, we faced some issues with some of the chaos actions that required run some linux shell commands, due to the way we set hbase environment variables and start/stop scripts. This patch allows for defining extensions of HBaseShellCommandProvider in the configuration, so that custom commands can be used. It also extends SlowDeterministicMonkeyFactory to provide the ability to configure the destructive actions to be executed." Update downloads.xml for release 2.4.8,13409929,Resolved,Minor,Fixed,03/Nov/21 19:10,03/Nov/21 20:39,, Update downloads.xml for release 2.4.7,13407183,Resolved,Minor,Fixed,19/Oct/21 00:34,19/Oct/21 01:17,, ExportSnapshot tool failed to copy data files for tables with merge region,13419340,Resolved,Minor,Fixed,24/Dec/21 09:16,16/May/24 12:51,,"When export snapshot for a table with merge regions, we found following exceptions: {code:java} 2021-12-24 17:14:41,563 INFO  [main] snapshot.ExportSnapshot: Finalize the Snapshot Export 2021-12-24 17:14:41,589 INFO  [main] snapshot.ExportSnapshot: Verify snapshot integrity 2021-12-24 17:14:41,683 ERROR [main] snapshot.ExportSnapshot: Snapshot export failed org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException: Missing parent hfile for: 043a9fe8aa7c469d8324956a57849db5.8e935527eb39a2cf9bf0f596754b5853 path=A/a=t42=8e935527eb39a2cf9bf0f596754b5853-043a9fe8aa7c469d8324956a57849db5     at org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.concurrentVisitReferencedFiles(SnapshotReferenceUtil.java:232)     at org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.concurrentVisitReferencedFiles(SnapshotReferenceUtil.java:195)     at org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.verifySnapshot(SnapshotReferenceUtil.java:172)     at org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.verifySnapshot(SnapshotReferenceUtil.java:156)     at org.apache.hadoop.hbase.snapshot.ExportSnapshot.verifySnapshot(ExportSnapshot.java:851)     at org.apache.hadoop.hbase.snapshot.ExportSnapshot.doWork(ExportSnapshot.java:1096)     at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:154)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)     at org.apache.hadoop.hbase.util.AbstractHBaseTool.doStaticMain(AbstractHBaseTool.java:280)     at org.apache.hadoop.hbase.snapshot.ExportSnapshot.main(ExportSnapshot.java:1144) {code}" Add rsgroup support for Backup,13404591,In Progress,Minor,,02/Oct/21 14:19,,3.0.0-alpha-2,"There are some places where backup needs some changes with respect to rsgroup. Some of them being addressed here are  # Incremental backup wal backup should happen only for servers which are part of a particular rsgroup under which namespace is configured for table backup under consideration # BackupLogCleaner should keep references only from those servers which are part of a particular rsgroup under which namesapce is configured for table backup under consideration" "Update dependencies in hbase-connectors: HBase version to 2.4.8, and make Hadoop 3 and Spark 3 defaults",13415090,Resolved,Minor,Fixed,02/Dec/21 15:32,13/Jan/22 19:13,hbase-connectors-1.0.1,"This proposes to bump up the default versions used by hbase-connectors to recent versions, in particular for HBase, Spark, Hadoop. HBase is upgraded to 2.4.8, Spark to 3.1.2, Hadoop to 3.2.0. This proposes also to make Spark 3 and Hadoop 3 default version (as opposed to Spark 2 and Hadoop 2)." TableSnapshotInputFormat terminates in the middle,13419663,Resolved,Minor,Duplicate,28/Dec/21 06:46,23/Jun/23 16:19,2.2.3,"I am using by adding SingleColumnValueFilter in TableSnapshotInputFormat. In fact, there is a lot of data in the snapshot, but it was found that the mapper was completed in the middle.   There was a problem in the next method of ClientSideRegionScanner.   {code:java} public Result next() throws IOException { values.clear(); scanner.nextRaw(values); if (values.isEmpty()) { //we are done return null; } Result result = Result.create(values); if (this.scanMetrics != null) { long resultSize = 0; for (Cell cell : values) { resultSize += PrivateCellUtil.estimatedSerializedSizeOf(cell); } this.scanMetrics.countOfBytesInResults.addAndGet(resultSize); this.scanMetrics.countOfRowsScanned.incrementAndGet(); } return result; } {code} values is empty, but scanner.nextRaw(values) returned true. I modified it as follows and it worked normally. {code:java} public Result next() throws IOException { values.clear(); boolean moreValues; do { moreValues = scanner.nextRaw(values); } while (values.isEmpty() && moreValues); if (!moreValues) { return null; } Result result = Result.create(values); if (this.scanMetrics != null) { long resultSize = 0; for (Cell cell : values) { resultSize += PrivateCellUtil.estimatedSerializedSizeOf(cell); } this.scanMetrics.countOfBytesInResults.addAndGet(resultSize); this.scanMetrics.countOfRowsScanned.incrementAndGet(); } return result; } {code} Please check this.  " [HBOSS] add lock around openFile operation,13413440,Resolved,Minor,Fixed,23/Nov/21 17:31,10/Sep/22 00:49,,"The HBoss FS wrapper doesn't wrap the openFile(path) call with a lock, which means anything using that builder isn't going to have access synchronized. adding a wrapper for this method will allow hbase to use the api call and so request different read policies on different files, or other options" I can't read/write a Hbase table by spark-hbase connector when the table is in non-default namespace,13413992,Resolved,Minor,Duplicate,26/Nov/21 09:39,01/Mar/23 14:38,1.0.0,"I found I can't read/write a Hbase table by spark-hbase connector when the hbase table is  in a non-default namespace.   Because when spark opens a table(related to a hbase table), it creates a HBaseRelation instance first, and initializes a HBaseTableCatalog from the table definition saved in spark catalog. But in the function 'convert' the field 'tableCatalog' is constructed from a string template, in which the namespace is set as 'default', leading to a wrong namespace. This namespace is not  the one defined when user created the table before.   Pls have a look: !image-2021-11-26-17-32-53-507.png!" Apply a `package` to test protobuf files,13415676,Resolved,Minor,Fixed,06/Dec/21 20:16,17/Dec/21 00:41,,"This is needed in a couple places in order to test that traces over the IPC layer carry correct span names, and it's good hygiene anyway." KeyValueScanner might not be properly closed when using InternalScan.checkOnlyMemStore(),13414976,Resolved,Minor,Fixed,02/Dec/21 08:41,05/Dec/21 14:45,2.3.6,"While writing a custom RegionObserver and using InternalScan.checkOnlyMemStore() I stumbled upon an issue. The number of files opened by region servers would grow steadily and eventually region servers would crash with {code:java} 2021-11-15 00:54:34,290 ERROR [MemStoreFlusher.1] regionserver.HStore: Failed to commit store file hdfs://<...removed...>:8020/hbase/data/default/<...removed...>/743071139057c819d7e6f7b59f065152/.tmp/f/394ba71102ec401d8779aa5f45819f84 java.io.IOException: Failed on local exception: java.io.IOException: Too many open files; Host Details : local host is: ""<...removed...>/<...removed...>""; destination host is: ""<...removed...>"":8020;         at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:805)         at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1544)         at org.apache.hadoop.ipc.Client.call(Client.java:1486)         at org.apache.hadoop.ipc.Client.call(Client.java:1385)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:232)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:118)         at com.sun.proxy.$Proxy27.getFileInfo(Unknown Source)         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo(ClientNamenodeProtocolTranslatorPB.java:800) {code} Another symptom is the following messages in region server logs: {code:java} 2021-11-18 13:41:29,539 INFO [RS_COMPACTED_FILES_DISCHARGER-regionserver/<...removed...>:16020-7] regionserver.HStore: Can't archive compacted file hdfs://<...removed...>:8020/hbase/data/default/<...removed...>/ce6f08fdd82967df94d1c83e289d3142/f/9b01b8bdea324c22a92f1ba6b386e050.6261a24c6a689d5406ae1ea87dc9bb9f because of either isCompactedAway=true or file has reference, isReferencedInReads=true, refCount=7, skipping for now. {code} The culprit is KeyValueScanner not being closed in StoreScanner.selectScannersFrom() before `continue` [https://github.com/apache/hbase/blame/f000b775320330eb2f426f6b2a3b5e27a794a707/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java#L467]    " Prune use of Random and SecureRandom objects,13417795,Resolved,Minor,Fixed,15/Dec/21 18:24,09/Mar/22 01:42,,"While looking over Findbugs/Spotbugs findings on HBASE-26555 I noticed we have some violations of Spotbugs rules regarding lack of Random object re-use, and generally have a lot of static Random and SecureRandom objects in our code, especially in tests, where ThreadLocalRandom would be more than sufficient. This is nitty stuff but let's clean it up. It will reduce noise on the analysis reports and SecureRandom is unnecessarily slow when used wherever we don't need it. " Allow Pluggable Queue to belong to FastPath or normal Balanced Executor,13417547,Resolved,Minor,Fixed,14/Dec/21 20:45,18/Feb/22 18:51,,"The PluggableQueue implementation added in [https://github.com/apache/hbase/pull/3522] for https://issues.apache.org/jira/browse/HBASE-6908 is only wired up with the BalancedQueueRpcExecutor. Users should be able to decide their queue operates with the FastPathBalancedQueueRpcExecutor optionally via configuration. I plan to submit a PR for this update soon.  " IntegrationTestLoadSmallValues,13408734,Resolved,Minor,Later,27/Oct/21 15:49,11/Jun/22 17:59,,"This integration test emulates a use case that stores a lot of small values into a table that would likely be heavily indexed (ROW_INDEX_V1, small blocks, etc.), an application that crowdsources weather (temperature) observation data. This IT can be used to test and optimize compression settings for such cases. It comes with a companion utility, HFileBlockExtracter, which extracts block data from HFiles into a set of individual files for each block's data, for use in training external compression dictionaries, perhaps with ZStandard's 'zstd' utility. See javadoc on class IntegrationTestLoadSmallValues for usage. This was used to test the changes on HBASE-26353." Fix findbugs/spotbugs findings,13416401,Resolved,Minor,Won't Fix,09/Dec/21 22:12,11/Jun/22 17:58,,"Clean up findbugs/spotbugs findings on branch HEADs (master, branch-2, branch-2.5, branch-2.4, branch-2.3) For example, from recent precommits: Possible null pointer dereference in org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:[line 230] Possible null pointer dereference in org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opWithClientMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opWithClientMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:[line 210] Possible null pointer dereference in org.apache.hadoop.hbase.io.hfile.LruCachedBlockQueue.add(LruCachedBlock) due to return value of called method Method invoked at LruCachedBlockQueue.java:org.apache.hadoop.hbase.io.hfile.LruCachedBlockQueue.add(LruCachedBlock) due to return value of called method Method invoked at LruCachedBlockQueue.java:[line 73] Possible null pointer dereference in org.apache.hadoop.hbase.io.hfile.bucket.CachedEntryQueue.add(Map$Entry) due to return value of called method Dereferenced at CachedEntryQueue.java:org.apache.hadoop.hbase.io.hfile.bucket.CachedEntryQueue.add(Map$Entry) due to return value of called method Dereferenced at CachedEntryQueue.java:[line 79]" Add metrics for BrokenStoreFileCleaner,13411119,Open,Minor,,10/Nov/21 17:48,,,"This is a followup for HBASE-26271. Cleaner chores lacking visibility is returning issue so I would like to add metrics for BrokenStoreFileCleaner to have a better idea of the tasks it performs." [aarch64] TestAsyncNonMetaRegionLocator is flaky,13418329,Resolved,Minor,Cannot Reproduce,18/Dec/21 02:19,30/Apr/22 02:11,2.4.9,"There was an earlier issue where the problem was diagnosed as a race (see HBASE-20822). The test is flaky again now on MacOS aarch64, which is likely a timing/race issue again. The underlying hardware memory model is different so the JVM will be using memory barriers in more places on aarch64 than x86_64 etc. and multithreaded timings and interactions can be expected to be slightly different. org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator.testMultiRegionTable[1] [ERROR] Run 1: TestAsyncNonMetaRegionLocator.testMultiRegionTable:251->lambda$testMultiRegionTable$5:251->lambda$null$4:253->assertLocEquals:196 array lengths differed, expected.length=3 actual.length=0; arrays first differed at element [0]; expected:<49> but was: [INFO] Run 2: PASS org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator.testRegionMove[1] [ERROR] Run 1: TestAsyncNonMetaRegionLocator.testRegionMove:292->assertLocEquals:197 expected:<192.168.1.25,64070,1639793242964> but was:<192.168.1.25,64053,1639793242927> [INFO] Run 2: PASS org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator.testRegionReplicas[1] [ERROR] Run 1: TestAsyncNonMetaRegionLocator.testRegionReplicas:433 expected:<3> but was:<1> [INFO] Run 2: PASS org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator.testReload[1] [ERROR] Run 1: TestAsyncNonMetaRegionLocator.testReload:365->assertLocEquals:197 expected:<192.168.1.25,64083,1639793243015> but was:<192.168.1.25,64053,1639793242927> [INFO] Run 2: PASS org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator.testSingleRegionTable[1] [ERROR] Run 1: TestAsyncNonMetaRegionLocator.testSingleRegionTable:205->assertLocEquals:197 expected:<192.168.1.25,64070,1639793242964> but was:<192.168.1.25,64053,1639793242927> [INFO] Run 2: PASS" Add metrics around failed replication edits,13417745,Resolved,Minor,Fixed,15/Dec/21 15:01,26/Apr/22 21:49,,"We ran into HBASE-26575 recently, but had a hard time tracking down where the edits were coming from. The only real evidence of a failure in replication was the ageOfLastShipped metric and some warnings in the logs. It would be nice to add an explicit metric around source.failedBatches and sink.failedBatches, incremented whenever an exception is encountered." Involving primary meta region in meta scan with CatalogReplicaLoadBalanceSimpleSelector,13419111,Resolved,Minor,Fixed,23/Dec/21 01:06,11/Apr/22 17:47,2.4.9,"In the current release with Meta replica LoadBalance mode, the primary meta region is not serving the meta scan (only meta replica region serves the read). When the result from meta replica region is stale, it will go to primary meta region for up-to-date location.  From our experience, the primary meta region serves very less read traffic, so it will be better to load balance read traffic across the primary meta region as well." Improve documentation of hbase 1.x to 2.x potential incompatibilities,13414636,Open,Minor,,30/Nov/21 22:46,,,"We're working on a major upgrade of almost 900 tables across 100 production clusters (and corresponding QA environment clusters). We've upgraded about 25% of our QA environment and run into a series of incompatibilities along the way. Most of them have been easy to get around, but I wanted to create this Jira to collect them so that we can make an update to the docs for future upgraders. My plan is to periodically edit this description to add to the list. If anyone else has anything to contribute, feel free to edit as well or add a comment.  Incompatibilities to document: -  HBASE-15676 changed the serialized byte string used for the fuzzy mask. FuzzyRowFilters created by older clients will not match any rows in an hbase2 cluster. This was fixed in HBASE-26537 but should be documented in our upgrade guide. - CDH5 try/catches bad HTableDescriptor.getDurability calls and returns USE_DEFAULT. In hbase2, if someone creates a table with a bad durability (i.e. DEFAULT instead of USE_DEFAULT), it results in a failure which causes the CreateTableProcedure to infinitely retries with no backoff. This rapid retry caused a bunch of pain on the cluster that encountered it, backing up datanode's ability to keep up with the millions of calls to create and delete .regioninfo files. - This isn't quite an incompatibility, but HBASE-19389 introduced a concurrency mitigation which may have surprising results coming from older versions. The defaults are pretty conservative – when writing more than 100 columns, no more than 10 concurrent writes or 20 pending writes at once. - Increments sent from branch-1 clients may get erroneously stored with a timestamp of 0 on hbase2+ clusters: HBASE-26713 - CheckAndMutate with a ""null"" compare value used to ignore CompareOp. Fixed in HBASE-26742, checkAndMutate affects may change between versions. - client will not know how to handle dangling rep_barrier rows in meta: HBASE-26797 - the default hbase split policy is SteppingSplitPolicy. This is overall a good policy which is more likely to split small tables to ensure they are spread across more servers. If you upgrade, you may notice your tables suddenly getting split more than you're used to. This may be an issue if you use a row key prefix, because hbase isn't aware of your prefix and may mess up your splits. You can get around this by defining a RegionSplitRestriction. See HBASE-25766 - Regression in meta requests may impact replication on clusters with many regions. Fixed in 2.4.10+, per HBASE-26590" Checkstyle: permit single-line if-then statements,13415147,Resolved,Minor,Won't Fix,03/Dec/21 00:15,01/Apr/22 12:26,,"Change the [LeftCurly|https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly] module [LeftCurlyOption|https://checkstyle.sourceforge.io/property_types.html#LeftCurlyOption] from the default {{eol}} to {{nlow}}. This will permit single-line code blocks like {noformat} if (foo == null) { return null; } {noformat}" Make StatisticThread alternative in LruBC,13416930,Open,Minor,,13/Dec/21 02:08,,,"Currently, LruBlockCache will log the cacheState every 5 minutes. It is only used in heavy debug. I added a configuration property to make it possible to turn it off." Make StatisticThread alternative in BucketCache,13417851,Open,Minor,,16/Dec/21 02:47,,,"Added a property to turn the periodic statistic thread off. Actually, it is only needed for heavy debugging. Make the thread disabled as default." "Adjust log level when looking for .filelist/{f1,f2}",13418697,Resolved,Minor,Implemented,20/Dec/21 21:59,30/Jan/22 13:32,,"Currently, we get a really big exception in the RegionServer log under normal assignment conditions when we are currently using .filelist/f2 as the tracker file. We should move this to debug/trace to avoid making operators think there is a problem when there isn't one." Clean shared state pollution to avoid flaky tests,13405338,Open,Minor,,07/Oct/21 08:10,,,"h2. What is the purpose of this change * Fixing a flaky test to avoid shared state pollution {{org.apache.hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy.test}} h2. Reproduce the test failure * Run the test twice in the same JVM. h2. Expected result: * The test should run successfully when multiple tests that use this state are run in the same JVM. h2. Actual result: * We get the failure:  {{org.apache.hadoop.hbase.DoNotRetryIOException: Can not transit current cluster state from STANDBY to STANDBY for peer id=1}} h2. Why the test fails * When the test ends, current cluster for peer id=1 is STANDBY, it can not be transitted from STANDBY to STANDBY. h2. Fix * Reset the state when test ends." Make enableReplicationPeer/disableReplicationPeer idempotent,13411166,Open,Minor,,11/Nov/21 01:31,,,"When enableReplicationPeer is called and the peer is already enabled, DoNotRetryIOException is being thrown as part of preEnablePeer [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java#L164], similarly with disableReplicationPeer [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java#L171]. java.lang.RuntimeException: org.apache.hadoop.hbase.DoNotRetryIOException: Replication peer 1 has already been enabled Ideally, it should not throw a runtimeException, if the peer is already in desired state Either 1. we should add a check before trying to enable/disable peer, and if it is already enabled return, else enable the peer or 2. Log the message instead of throwing exception in preEnablePeer/preDisablePeer" RSRollLogTask didn't call coprocessor when request roll log in backup,13418445,Open,Minor,,19/Dec/21 14:32,,2.4.9, Report CallDroppedException in exception metrics,13419271,Resolved,Minor,Fixed,23/Dec/21 19:02,29/Dec/21 16:08,,"`CallDroppedException` can be thrown with `CallRunner.drop()` by queue implementations that decide to drop calls to groom the RPC call backlog. The LifoCoDel queue does this I believe and with Pluggable queue it's possible for 3rd party queue implementations to be using `drop()` for similar reasons (my use case). It would be nice for the server to be tracking these exceptions in metrics since otherwise you might have to do some extra lifting on the client side.   I have a patch I will submit soon." Retire the method visitLogEntryBeforeWrite without RegionInfo in WALActionListner,13416894,Resolved,Minor,Fixed,12/Dec/21 12:31,28/Dec/21 16:22,,visitLogEntryBeforeWrite without region info as parameter variable is only used in ReplicationSourceWALActionListener. Has retired it from WALActionListener Interface. "[branch-2, create-release] Private per build Maven caches won't work on aarch64 MacOS",13418325,Open,Minor,,18/Dec/21 01:24,,,"Private per build Maven caches won't work on aarch64 MacOS. The problem is we have to compile a patched version of protobuf 2.5.0 binaries and install them into the local cache. (See this gist: https://gist.github.com/liusheng/64aee1b27de037f8b9ccf1873b82c413 . ) Typically the developer will do this once, the results placed into the standard local cache $HOME/.m2/repository . However because the create-release scripts use unconditionally a private repo and similar workarounds for aarch64 MacOS systems are not known to these scripts, the result is a build failure: {noformat} 17:13:57 [INFO] BUILD FAILURE 17:13:57 [ERROR] Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile (compile-protoc) on project hbase-protocol: Unable to resolve artifact: Missing: 17:13:57 [ERROR] ---------- 17:13:57 [ERROR] 1) com.google.protobuf:protoc:exe:osx-aarch_64:2.5.0 17:13:57 [ERROR] 17:13:57 [ERROR] Try downloading the file manually from the project website. 17:13:57 [ERROR] 17:13:57 [ERROR] Then, install it using the command: 17:13:57 [ERROR] mvn install:install-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file 17:13:57 [ERROR] 17:13:57 [ERROR] Alternatively, if you host your own repository you can deploy the file there: 17:13:57 [ERROR] mvn deploy:deploy-file -DgroupId=com.google.protobuf -DartifactId=protoc -Dversion=2.5.0 -Dclassifier=osx-aarch_64 -Dpackaging=exe -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] 17:13:57 [ERROR] 17:13:57 [ERROR] Path to dependency: 17:13:57 [ERROR] 1) org.apache.hbase:hbase-protocol:jar:2.4.9 17:13:57 [ERROR] 2) com.google.protobuf:protoc:exe:osx-aarch_64:2.5.0 17:13:57 [ERROR] 17:13:57 [ERROR] ---------- 17:13:57 [ERROR] 1 required artifact is missing. 17:13:57 [ERROR] 17:13:57 [ERROR] for artifact: 17:13:57 [ERROR] org.apache.hbase:hbase-protocol:jar:2.4.9 17:13:57 [ERROR] 17:13:57 [ERROR] from the specified remote repositories: 17:13:57 [ERROR] apache.snapshots (https://repository.apache.org/snapshots, releases=false, snapshots=true), 17:13:57 [ERROR] central (https://repo.maven.apache.org/maven2, releases=true, snapshots=false) {noformat}" Replace new allocation with ThreadLocal in CellBlockBuilder to reduce GC,13418362,Resolved,Minor,Won't Fix,18/Dec/21 11:08,23/Dec/21 05:22,,"In CellBlockBuilder decompress method, we currently allocate a new ByteBufferOutputStream object each invoke. {code:java} try { // TODO: This is ugly. The buffer will be resized on us if we guess wrong. //TODO: reuse buffers. bbos = new ByteBufferOutputStream(osInitialSize); IOUtils.copy(cis, bbos); bbos.close(); return bbos.getByteBuffer(); } finally { CodecPool.returnDecompressor(poolDecompressor); } {code} We can use a ThreadLocal variable to reuse the buffer in each Thread. As: {code:java} try { // TODO: This is ugly. The buffer will be resized on us if we guess wrong. if (this.decompressBuff.get() == null) { this.decompressBuff.set(new ByteBufferOutputStream(osInitialSize)); } ByteBufferOutputStream localBbos = this.decompressBuff.get(); localBbos.clear(); IOUtils.copy(cis, localBbos); return localBbos.getByteBuffer(); } finally { CodecPool.returnDecompressor(poolDecompressor); } {code} " Introduce a new parameter in jmx servlet to exclude the specific mbean,13416310,Resolved,Minor,Fixed,09/Dec/21 15:35,14/Dec/21 14:57,2.4.8,"There are many regionservers serving over a thousand regions in our company, and the metric load is pretty big. I tried to exclude some huge mbean like 'Hadoop:service=HBase,name=RegionServer,sub=Regions' with regex, but didn't succeed. So I want to propose a new parameter 'excl' in jmx servlet to exclude the splecific bean or beans." Make sure the master is running normally before accepting a balance command,13416170,Resolved,Minor,Fixed,09/Dec/21 00:22,14/Dec/21 15:35,,"Noticed this in a unit test from [https://github.com/apache/hbase/pull/3851] I believe this is a result of the new balance() implementation in the Master, and a client submitting a request to the master before it's completed its instantiation. Simple fix to avoid the NPE. {noformat} Failed after attempts=2, exceptions: 2021-12-07T18:14:19.203Z, java.io.IOException: java.io.IOException at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:461) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:138) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:354) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:334) Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.master.HMaster.getProcedures(HMaster.java:3335) at org.apache.hadoop.hbase.master.ServerManager.areDeadServersInProgress(ServerManager.java:505) at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1886) at org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:740) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) ... 3 more {noformat}" Add builder for class ReplicationLoadSink,13413970,Resolved,Minor,Fixed,26/Nov/21 08:01,04/Dec/21 15:25,, TestHStore#testRefreshStoreFiles broken due to unqualified and qualified paths,13418416,Open,Minor,,18/Dec/21 22:25,,2.4.9,"Was looking at a failures of this method where  {noformat} [ERROR] org.apache.hadoop.hbase.regionserver.TestHStore.testRefreshStoreFiles  Time elapsed: 4.2 s  <<< ERROR! java.util.NoSuchElementException     at org.apache.hbase.thirdparty.com.google.common.collect.AbstractIndexedListIterator.next(AbstractIndexedListIterator.java:75)     at org.apache.hadoop.hbase.regionserver.TestHStore.closeCompactedFile(TestHStore.java:962)     at org.apache.hadoop.hbase.regionserver.TestHStore.testRefreshStoreFiles(TestHStore.java:1000) {noformat} This was on a branch where I had some HBASE-26067 changes backported, so I thought the problem _was_ those changes. After a bit of digging, I believe the test case itself is ""broken"" (the test passes, but for the wrong reasons). This test methods adds some files to a Store (via memstore flush or direct addition of a file) and eventually tries to get the first file which is candidate to be removed. The test {*}never compacted any files{*}. This was the first sign that the test itself was wrong. After lots of comparison with the HBASE-26067 logging to compare against, I found that the Store was listing a file which was created by the memstore flush as a file to retain AND a file to remove. Second warning. Upon closer inspection, I finally noticed that one of the files was qualified with the filesystem URI and the other was not. {noformat} 2021-12-18 16:57:10,903 INFO [Time-limited test] regionserver.HStore(675): toBeAddedFiles=[file:/Users/jelser/projects/cldr/hbase-copy.git/hbase-server/target/test-data/f4ed7913-e62a-8d5f-a968-bb4c94d5494a/TestStoretestRefreshStoreFiles/data/default/table/297ad8361c3326bfb1520dbc54b1c3bd/family/dd8a430b391546d8b9bdc39bb77d447b, file:/Users/jelser/projects/cldr/hbase-copy.git/hbase-server/target/test-data/f4ed7913-e62a-8d5f-a968-bb4c94d5494a/TestStoretestRefreshStoreFiles/data/default/table/297ad8361c3326bfb1520dbc54b1c3bd/family/d4c5442b772c43fd9ebdfed1a11c0e73], toBeRemovedFiles=[/Users/jelser/projects/cldr/hbase-copy.git/hbase-server/target/test-data/f4ed7913-e62a-8d5f-a968-bb4c94d5494a/TestStoretestRefreshStoreFiles/data/default/table/297ad8361c3326bfb1520dbc54b1c3bd/family/d4c5442b772c43fd9ebdfed1a11c0e73] {noformat} {{d4c5442b772c43fd9ebdfed1a11c0e73}} how are we both adding and removing this file! Turns out, this is because one of them is ""/..."" and the other is ""file:/..."". Either the problem is in TestHStore in how it is creating/adding these files behind the scenes or we should be qualifying the Path inside of StoreFileInfo with the filesystem that we're using. I remember too vividly the problems when trying to separate the rootdir and waldir from each other and am cautious against adding something to StoreFileInfo to {{{}fs.qualifyPath(p){}}}. Need to look some more, but will get a patch up to fix." Separate the blockcache enabled key and cache data on read key,13414278,Resolved,Minor,Won't Do,29/Nov/21 11:22,14/Dec/21 05:26,,"Currently, we use CACHE_DATA_ON_READ_KEY as BLOCKCACHE_ENABLED. This makes the usage ambiguous. In my opinion, we should use a flag to control the on/off of the whole blockcache and one another flag to control if we cache data blocks on read (cache on write stay the same). I added a new BLOCKCACHE_ENABLED key to make the name and usage more clear. However, there are some cache logic changes, for which I changes the related UTs a little bit in my MR. Hope to have a discussion about the cache logic then." Procedure state pretty-printing should use printable character friendly encoding,13411146,Resolved,Minor,Later,10/Nov/21 22:24,09/Dec/21 01:09,2.4.8,"The shell 'list_procedures' command produces output like: ---- 889 org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure SUCCESS 2021-11-10 22:20:34 UTC 2021-11-10 22:20:35 UTC [{""state""=>[1, 2, 3, 11, 4, 5, 6, 7, 8, 9, 10, 2147483648]}, {""regionId""=>""1636579678894"", ""tableName""=>{""namespace""=>""ZGVmYXVsdA=="", ""qualifier""=>""SW50ZWdyYXRpb25UZXN0TG9hZENvbW1vbkNyYXds""}, ""startKey""=>""dWsuY28uZ3Jhbml0ZXRyYW5zZm9ybWF0aW9ucy53d3d8L2dhbGxlcnkvdA=="", ""endKey""=>""dXMuYmFuZHwvYmFuZC81OA=="", ""offline""=>false, ""split""=>false, ""replicaId""=>0}, {""userInfo""=>{""effectiveUser""=>""apurtell""}, ""parentRegionInfo""=>{""regionId""=>""1636579678894"", ""tableName""=>{""namespace""=>""ZGVmYXVsdA=="", ""qualifier""=>""SW50ZWdyYXRpb25UZXN0TG9hZENvbW1vbkNyYXds""}, ""startKey""=>""dWsuY28uZ3Jhbml0ZXRyYW5zZm9ybWF0aW9ucy53d3d8L2dhbGxlcnkvdA=="", ""endKey""=>""dXMuYmFuZHwvYmFuZC81OA=="", ""offline""=>false, ""split""=>false, ""replicaId""=>0}, ""childRegionInfo""=>[{""regionId""=>""1636582834759"", ""tableName""=>{""namespace""=>""ZGVmYXVsdA=="", ""qualifier""=>""SW50ZWdyYXRpb25UZXN0TG9hZENvbW1vbkNyYXds""}, ""startKey""=>""dWsuY28uZ3Jhbml0ZXRyYW5zZm9ybWF0aW9ucy53d3d8L2dhbGxlcnkvdA=="", ""endKey""=>""dWsuY28uc2ltb25hbmRzY2h1c3Rlci53d3d8L2Jvb2tzL1RoZS1P"", ""offline""=>false, ""split""=>false, ""replicaId""=>0}, {""regionId""=>""1636582834759"", ""tableName""=>{""namespace""=>""ZGVmYXVsdA=="", ""qualifier""=>""SW50ZWdyYXRpb25UZXN0TG9hZENvbW1vbkNyYXds""}, ""startKey""=>""dWsuY28uc2ltb25hbmRzY2h1c3Rlci53d3d8L2Jvb2tzL1RoZS1P"", ""endKey""=>""dXMuYmFuZHwvYmFuZC81OA=="", ""offline""=>false, ""split""=>false, ""replicaId""=>0}]}] ---- The base64 encoding of byte[] values offers poor usability. Generally, table names etc are printable characters encoded in byte[]. Base64 encoding them totally obfuscates information that is important to see at a glance. Even start keys and end keys might be printable characters. It would be better to use Bytes.toStringBinary or something else that shows printable characters as-is while escaping others that would be invalid in JSON formatting." Document HBASE-26524 to section of Dynamic Unloading,13414910,Resolved,Minor,Fixed,01/Dec/21 23:31,06/Dec/21 22:19,2.5.0,"HBASE-26524 has merged, and we need to update the documentation such that operator knows there is a method of {{table_remove_coprocessor}} for {{alter}} command" `MAXIMUN_KEY_LENGTH` changed from 0.20.0 to 0.20.2,13409350,Open,Minor,,01/Nov/21 01:01,,0.20.0,"In HFile.java, there is a constant called `MAXIMUM_KEY_LENGTH`, which is used to check the validity of the key. However, the value changed from 64 * 1024 to Integer.MAX_VALUE. Therefore, I wonder whether it might throw an exception when checking the key after downgrading from 0.20.2 to 0.20.0." Introduce a method to clean restore directory after Snapshot Scan,13413702,Resolved,Minor,Fixed,24/Nov/21 16:44,30/Nov/21 12:57,,"SnapshotScan is widely used in our company. However, after the snapshot scan job, the restore directory is not cleaned, and this maybe puts a lot of pressure on HDFS after a long time. So maybe we can introduce a method for users to clean the snapshot restore directory after job." StoreFileScanner parallel seek -- productionize or drop?,13414574,Open,Minor,,30/Nov/21 15:51,,,"hbase.storescanner.parallel.seek.enable was added a few years ago in https://issues.apache.org/jira/browse/HBASE-7495, but still defaults to disabled. The description of that says ""Enables StoreFileScanner parallel-seeking in StoreScanner, a feature which can reduce response latency under special conditions"". It's not very clear what ""special conditions"" means. Reading through the entire comment history on that issue seems to indicate it can help when you have ""high random read, low cache hit rate, many store files"".  We have a bunch of clusters with this shape, and in fact we use SSDs for all storage so I figured this might help a lot. I tried setting this to true on one RegionServer of one of our highest QPS clusters hoping I'd see some clear improvement. This very simple test was pretty much a wash, so I need to do more methodical testing. In the test one thing became clear though – is the default thread pool size of 10 good enough for my use-case? I have no way of knowing, as there is no logging or metrics that I can find around thread pool saturation. What I ended up doing was spamming refresh of the /dump endpoint of the RS, and noticed that there were sometimes 1-5 tasks queued for the RS_PARALLEL_SEEK executor. This indicates maybe I should scale the thread pool, but use-cases change over time so this seems like not a great way to determine that. Task queuing seems not great for a feature which is aimed at reducing latencies. I wonder if we should consider some changes to make this more easy to deploy in production. Here are some ideas I had: * Can we generate a better default value for the thread pool size, maybe based on number of RS handler threads or some other heuristic? * Should we consider eliminating queuing for this feature? Instead, if the threadpool is saturated run the seek in-line in the current thread (i.e. revert to normal). This would be more similar to how hedged reads work in HDFS. * Can we expose a metric or logging to help operators know when to scale up the thread pool? If we implemented the 2nd option above we could expose ""seeksInCurrentThread"" counter to track this, again similar to how hedged reads report on saturation. But with all of this said, I wonder if anyone is running this in production and has any updated guidance on when to use this? Does it still make sense given the last 8 years of development in HBase? Would it ever make sense to make it enabled by default?" Value of hbase.master.snapshot.ttl is not used,13411914,Resolved,Minor,Fixed,15/Nov/21 23:32,24/Nov/21 06:47,1.7.1,"When creating a snapshot, users can explicitly specify the TTL to be used. If no TTL is specified, then the SnapshotDescription is initially created with a TTL of -1 to indicate FOREVER. When the SnapshotDescription runs through SnapshotDescriptionUtils#validate, the TTL is checked to see if the default value of hbase.master.snapshot.ttl should be applied. The value from the config is only applied if the TTL == 0, but it should be -1. This has another nasty side-effect: any user who creates a snapshot and explicitly sets \{TTL => 0} will find that their snapshot gets its TTL from hbase.master.snapshot.TTL." Server configuration will overwrite HStore configuration after using shell command 'update_config',13411247,Resolved,Minor,Fixed,11/Nov/21 10:29,27/Nov/21 08:39,2.5.0,"When we tried to update the configuration of online servers with shell commands, we found that the configuration of the server would overwrite the configuration that originally belonged to HStore." Print too slow/big scan's operation_id in region server log,13413147,Resolved,Minor,Fixed,22/Nov/21 11:40,25/Nov/21 04:12,,"Tracing is very important in large-scale distributed systems. The attribute *__operation.attributes.id_*  of a scan request can be used as trace id between hbase client and region server. We should print operation id in region server's log if the scan request is too slow or too big. It will be very helpful for finding problematic requests." Table name and Column Family Name not always initialized in the HFileContext,13411432,Open,Minor,,12/Nov/21 09:09,,2.4.8,"{noformat} Example:{noformat} {noformat} 2021-10-21 01:48:42,860 WARN [main-BucketCacheWriter-0] bucket.BucketCache: Most recent failed allocation in 60000 milliseconds; Table Name = null, Column Family = null, HFile Name : 1919692f80b841b7a3d4453ec01186f1 org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=1050637; adjust BucketCache sizes hbase.bucket cache.bucket.sizes to accomodate if size seems reasonable and you want it cached. {noformat}" Backport HBASE-26305 to branch-1,13404718,Resolved,Minor,Fixed,04/Oct/21 02:28,22/Nov/21 10:47,,Backport the HBASE-26305 to branch-1. Move NavigableSet add operation to writer thread in BucketCache Support move linked data files between regions of the same table in StripeCompactionPolicy,13410045,Open,Minor,,04/Nov/21 12:54,,,"There are two important contents for this issue, # must add reference files for moved data files in a dependent directory which will be looked through to find out which region the data file is currently in; # for HFileLinks in the same table of snapshot table, must support these links to add more locations according to the move info." CellCounter should report serialized cell size counts too,13411164,Resolved,Minor,Fixed,11/Nov/21 01:18,16/Nov/21 00:49,,"Add the following stats for a given table: - 7. Total size of serialized cells of each CF. - 8. Total size of serialized cells of each qualifier. - 9. Total size of serialized cells across all rows. " Add tracing support in hbase shell,13410586,Resolved,Minor,Fixed,08/Nov/21 10:42,12/Nov/21 14:50,2.5.0,Adding support to enable tracing from hbase shell improve upgrading doc,13411057,Resolved,Minor,Fixed,10/Nov/21 12:42,10/Nov/21 15:20,2.4.8,improve upgrading doc Increase DefaultHeapMemoryTuner log level,13410343,Resolved,Minor,Fixed,06/Nov/21 01:35,09/Nov/21 02:36,2.4.8,"The DefaultHeapMemoryTuner chore will explain what it is doing when deciding to make changes, once per chore interval. This is not frequent logging and deserves to be at INFO level as it is making changes of some import. While making the change, also log a line when ignoring the initial periods, so operators are not surprised when nothing happens for a while." Support loadable dictionaries in hbase-compression-zstd,13406253,Resolved,Minor,Fixed,13/Oct/21 01:44,29/Oct/21 16:28,,"ZStandard supports initialization of compressors and decompressors with a precomputed dictionary, which can dramatically improve and speed up compression of tables with small values. For more details, please see [The Case For Small Data Compression|https://github.com/facebook/zstd#the-case-for-small-data-compression]. If a table is going to have a lot of small values and the user can put together a representative set of files that can be used to train a dictionary for compressing those values, a dictionary can be trained with the {{zstd}} command line utility, available in any zstandard package for your favorite OS: Training: {noformat} $ zstd --maxdict=1126400 --train-fastcover=shrink \ -o mytable.dict training_files/* Trying 82 different sets of parameters ... k=674 d=8 f=20 steps=40 split=75 accel=1 Save dictionary of size 1126400 into file mytable.dict {noformat} Deploy the dictionary file to HDFS or S3, etc. Create the table: {noformat} hbase> create ""mytable"", ... , CONFIGURATION => { 'hbase.io.compress.zstd.level' => '6', 'hbase.io.compress.zstd.dictionary' => 'hdfs://nn/zdicts/mytable.dict' } {noformat} Now start storing data. Compression results even for small values will be excellent. Note: Beware, if the dictionary is lost, the data will not be decompressable." CellCounter fails for large tables filling up local disk,13408516,Resolved,Minor,Fixed,26/Oct/21 17:18,28/Oct/21 08:54,2.2.7,"CellCounter dumps all cell coordinates into its output, which can become huge. The spill can fill the local disk on the reducer. CellCounter hardcodes *mapreduce.job.reduces* to *1*, so it is not possible to use multiple reducers to get around this. Fixing this is easy, by not hardcoding *mapreduce.job.reduces*, it still defaults to 1, but can be overriden by the user. CellCounter also generates two extra records with constant keys for each cell, which have to be processed by the reducer. Even with multiple reducers, these (1/3 of the totcal records) will go the same reducer, which can also fill up the disk. This can be fixed by adding a Combiner to the Mapper, which sums the counter records, thereby reducing the Mapper output records to 1/3 of their previous amount, which can be evenly distibuted between the reducers." Remove duplicate thread creation during migrating rsgroup,13408324,Resolved,Minor,Fixed,26/Oct/21 00:10,27/Oct/21 14:02,3.0.0-alpha-2,"There is a thread that migrate the table rs group info from RSGroupInfo into the table descriptor. The thread is created when RSGroupManager is initialized and is created again when RSGroupStartupWorker is started. I think this is a bug. Since this thread will not exit until all table rsgroups are migrated, there is no reason to need two threads to run together?" Improve recent change to IntegrationTestLoadCommonCrawl,13406013,Resolved,Minor,Fixed,11/Oct/21 20:16,19/Oct/21 21:20,,"Using BufferedMutator wasn't a good idea because we assign client timestamps, and the store loop is fast enough that on rare occasion two temporally adjacent URLs in the set of WARCs are equivalent and the timestamp does not advance, leading later to a rare false positive CORRUPT finding. While making changes, support direct S3N paths as input paths on the command line." Per-table or per-CF compression codec setting overrides,13404396,Resolved,Minor,Fixed,01/Oct/21 01:32,19/Oct/21 21:19,2.5.0,"This won't work as expected today... {noformat} hbase> create 'sometable', \ { NAME => 'somefamily', VERSIONS => 1000, COMPRESSION => 'ZSTD' }, \ CONFIGURATION => { 'hbase.io.compress.zstd.level' => '9' } {noformat} ... but it should. We get and retain Compressor instances in HFileBlockDefaultEncodingContext, and could in theory call Compressor#reinit when setting up the context, to update compression parameters like compression level and buffer size per the ambient configuration, but we do not plumb through the CompoundConfiguration from the Store into HFileBlockDefaultEncodingContext. Instead can only update codec parameters globally in system site conf files. This is actually pretty important for algorithms like ZSTD, which offers more than 20 different compression levels, where at level 1 it is almost as fast at compression as LZ4, and where at levels > 19 it utilizes computationally expensive techniques to rival LZMA at compression ratio (and poor compression speed). It is very likely that the ZSTD level you'd want to employ for a given table's data will vary by use case." Missing server side debugging on failed SASL handshake,13406017,Resolved,Minor,Fixed,11/Oct/21 21:00,14/Oct/21 22:26,,"In trying to debug some problems with the pluggable authentication, I noticed that we are eating the IOException without logging it (at any level) in ServerRpcConnection. This makes it super hard to debug when that pluggable interface has a problem because the context gets lost (clients just get a pretty useless DNRIOE)." Minor improvements to IntegrationTestLoadCommonCrawl,13405464,Resolved,Minor,Fixed,07/Oct/21 17:22,08/Oct/21 17:02,,"Use BufferedMutator instead of Table. Improve row key generator. Improve retries and log levels. " Reuse compressors and decompressors in WAL CompressionContext,13404710,Resolved,Minor,Fixed,03/Oct/21 19:41,07/Oct/21 16:45,,"WAL value compression CompressionContext allocates more compressors and decompressors than it requires and does not attempt to return those instances to their respective pools. Found while profiling. Harmless, but let's fix it. " RegionServer leaks DFSInputStreams due to not closing region after warmup,13405467,Open,Minor,,07/Oct/21 17:44,,,"I'm working on HDFS-16262, in which we add tracking of DFSInputStreams. The DFSInputStreams are registered on creation and de-registered on call to close(). As part of testing I noticed that extra DFSInputStreams were being created and never closed. I tracked it down to HBASE-15441 in which the r.close() was removed here: [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L7480] This has not been a huge issue because DFSInputStreams don't currently keep resources unless you do a non-positional read or use extended read buffers. So for the warmup case, the DFSInputStream is created and then eventually GC'd. That said, the contract of a Closeable is typically that you should close them to release resources. So we're kind of lucking out that it's not strictly necessary until you do a read, and that could change at any time (like in HDFS-16262). I think we should either add back a call to r.close(), or maybe it's possible to skip creating the Reader altogether for warmup. It doesn't look like the reader itself is necessary for warmup, but I could be missing something." TestCacheOnWrite and TestCompactingToCellFlatMapMemStore use too many file descriptors,13416843,Resolved,Trivial,Cannot Reproduce,11/Dec/21 20:36,03/May/22 00:29,2.5.0,"This is somewhat test environment specific but an indication that TestCacheOnWrite could stand to go on a resource diet. Likewise, TestCompactingToCellFlatMapMemStore Apache Maven 3.8.3 (ff8e977a158738155dc465c6a97ffaf31982d739) Java version: 1.8.0_312, vendor: Azul Systems, Inc., runtime: /Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/jre OS name: ""mac os x"", version: ""12.0.1"", arch: ""aarch64"", family: ""mac"" Representative output from TestCacheOnWrite: [ERROR] org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testCachingDataBlocksThresholdDuringCompaction[35] Time elapsed: 2.113 s <<< ERROR! java.lang.IllegalStateException: failed to create a child event loop at org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:88) at org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:60) at org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:49) at org.apache.hbase.thirdparty.io.netty.channel.MultithreadEventLoopGroup.(MultithreadEventLoopGroup.java:59) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:86) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:81) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:68) at org.apache.hadoop.hbase.wal.NettyAsyncFSWALConfigHelper.getEventLoopConfig(NettyAsyncFSWALConfigHelper.java:64) at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.doInit(AsyncFSWALProvider.java:80) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.init(AbstractFSWALProvider.java:125) at org.apache.hadoop.hbase.wal.SyncReplicationWALProvider.init(SyncReplicationWALProvider.java:115) at org.apache.hadoop.hbase.wal.WALFactory.(WALFactory.java:207) at org.apache.hadoop.hbase.wal.WALFactory.(WALFactory.java:178) Caused by: java.io.IOException: Too many open files at java.base/sun.nio.ch.IOUtil.makePipe(Native Method) at java.base/sun.nio.ch.KQueueSelectorImpl.(KQueueSelectorImpl.java:86) at java.base/sun.nio.ch.KQueueSelectorProvider.openSelector(KQueueSelectorProvider.java:35) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.openSelector(NioEventLoop.java:173) ... 55 more " The message of StoreTooBusy is confused,13417692,Resolved,Trivial,Fixed,15/Dec/21 10:49,18/Dec/21 15:37,,"  When check Store limit. We both check parallelPutToStoreThreadLimit and parallelPreparePutToStoreThreadLimit.  {code:java} if (store.getCurrentParallelPutCount() > this.parallelPutToStoreThreadLimit || preparePutCount > this.parallelPreparePutToStoreThreadLimit) { tooBusyStore = (tooBusyStore == null ? store.getColumnFamilyName() : tooBusyStore + "","" + store.getColumnFamilyName()); } {code} But we only print Above parallelPutToStoreThreadLimit only.      {code:java} if (tooBusyStore != null) { String msg = ""StoreTooBusy,"" + this.region.getRegionInfo().getRegionNameAsString() + "":"" + tooBusyStore + "" Above parallelPutToStoreThreadLimit("" + this.parallelPutToStoreThreadLimit + "")""; if (LOG.isTraceEnabled()) { LOG.trace(msg); } throw new RegionTooBusyException(msg); }{code} It confused me a lot time ......  Just add message of parallelPreparePutToStoreThreadLimit  " Add auth method information to AccessChecker audit log,13414450,Resolved,Trivial,Fixed,30/Nov/21 05:44,04/Dec/21 15:24,,"If we turn on audit logging, authentication events are logged with auth method information (e.g. KERBEROS, TOKEN etc) like below. {noformat} 2021-11-30 14:15:07,417 INFO SecurityLogger.org.apache.hadoop.hbase.Server: Auth successful for PRINCIPAL@REALM (auth:KERBEROS) {noformat} However, authorization event logs which are emitted by AccessChecker class don't contain auth method information. I need this info to filter out audit log lines generated by MapReduce jobs, auth method = TOKEN case. " Unreadable table names after HBASE-24605,13412425,Resolved,Trivial,Fixed,18/Nov/21 05:00,21/Nov/21 12:53,3.0.0-alpha-1,"During the fix HBASE-24605 (Break long region names in the web UI) the 'word break' rule was applied to the 'table-striped' style, so literally, all tables in Master Web UI were affected. The most noticeable is the 'User Tables' when table names, as well as descriptions, and even State are wrapped in a very ugly way. We have two options here: 1. Fix the user tables only as it was done previously for the procedures table 2. Apply 'word break' to those tables that require that. Since most of the users are comfortable with the current UI we may go through the first way, so the changes would affect only the User table. Sample screenshots before and after are attached. " Fix checkstyle issues for HBase-common: KeyValue and ByteBufferUtils,13407221,Resolved,Trivial,Fixed,19/Oct/21 07:27,22/Oct/21 14:22,2.4.6,Fixing the checkstyle issues in KeyValue and  ByteBufferUtils. Fix checkstyle issues for HRegionserver,13407207,Resolved,Trivial,Fixed,19/Oct/21 06:05,22/Oct/21 07:22,2.4.6,Multiple checkstyle issues present for HRegionserver.java  Revert REST protobuf package to org.apache.hadoop.hbase.rest,13585500,Resolved,Blocker,Fixed,11/Jul/24 19:31,29/Oct/24 06:34,,"In Hbase 3+, the package name of the REST messages has been renamed to org.apache.hadoop.hbase.shaded.rest from org.apache.hadoop.hbase.rest These definitions are only used by REST, and have nothing to do with standard HBase RPC communication. I propose reverting the package name. We may also want to move the protobuf definitions back to the hbase-rest module." BackupLogCleaner cleans required WALs when using multiple backuproots,13584502,Resolved,Blocker,Fixed,02/Jul/24 14:01,26/Sep/24 08:13,2.6.0,"The BackupLogCleaner is responsible for avoiding the deletion of WAL/logs that still need to be included in a future backup. The logic to decide which files can be deleted does not work correctly when multiple backup roots are used. Each backup root has a different chain of backups (full, incremental1, incremental2, ...). So, if any chain requires a log, it should be preserved. This is not the case. The result is that logs could be incorrectly deleted, resulting in data loss in backups. PR incoming with test & fix." Tracking of bulk-loads for backup does not work for multi-root backups,13584509,Open,Blocker,,02/Jul/24 14:30,,2.6.0,"Haven't been able to test this yet, but I highly suspect that IncrementalTableBackupClient#handleBulkLoad will delete records of the files that were bulk loaded, even if those records are still needed for backups in other backuproots. I base this on the observation that the code for tracking which WALs should be kept around, and backup metadata in general, are all tracked per individual backuproot. But for the tracking of bulk uploads, this is not the case. The result would be data loss (i.e. the bulk loaded data) when taking backups across different backuproots. Edit: This is minimal test to reproduce the issue from the master branch: First, enable backups by adding this to hbase-site.xml {code:java} hbase.backup.enable true hbase.master.logcleaner.plugins org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreWALCleaner,org.apache.hadoop.hbase.backup.master.BackupLogCleaner hbase.procedure.master.classes org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager hbase.procedure.regionserver.classes org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager hbase.coprocessor.region.classes org.apache.hadoop.hbase.backup.BackupObserver hbase.fs.tmp.dir file:/tmp/hbase-tmp {code} Next, execute: {code:java} # Create an hfile (to local storage) echo -e 'row1\tvalue1' > /tmp/hfile_data bin/hbase org.apache.hadoop.hbase.mapreduce.ImportTsv -Dimporttsv.columns=HBASE_ROW_KEY,cf:q1 -Dimporttsv.bulk.output=/tmp/bulk-output table1 /tmp/hfile_data # Create a table, and 2 full backups (using different roots) of the empty table echo ""create 'table1', 'cf'"" | bin/hbase shell -n bin/hbase backup create full file:/tmp/backup1 -t table1 bin/hbase backup create full file:/tmp/backup2 -t table1 # Bulk load the HFile into the table, scan confirms it is loaded bin/hbase completebulkload /tmp/bulk-output table1 echo ""scan 'table1'"" | bin/hbase shell # Take an incremental backup for each backup root bin/hbase backup create incremental file:/tmp/backup1 -t table1 export BACKUP_ID1=$(bin/hbase backup history | head -n1  | tail -n -1 | grep -o -P ""backup_\d+"") bin/hbase backup create incremental file:/tmp/backup2 -t table1 export BACKUP_ID2=$(bin/hbase backup history | head -n1  | tail -n -1 | grep -o -P ""backup_\d+"") # Restore root 1: bulk loaded data is present bin/hbase restore file:/tmp/backup1 $BACKUP_ID1 -t ""table1"" -m ""table1-backup1"" echo ""scan 'table1-backup1'"" | bin/hbase shell # Restore root 2: bulk loaded data is missing bin/hbase restore file:/tmp/backup2 $BACKUP_ID2 -t ""table1"" -m ""table1-backup2"" echo ""scan 'table1-backup2'"" | bin/hbase shell {code} Output of the final commands for reference: {code:java} hbase:001:0> scan 'table1-backup1' ROW                                              COLUMN+CELL                                                                                                                                   row1                                            column=cf:q1, timestamp=2024-08-02T14:43:24.403, value=value1                                                                                1 row(s) hbase:001:0> scan 'table1-backup2' ROW                                              COLUMN+CELL                                                                                                                                  0 row(s) {code}" Need to call parent class's serialization methods in CloseExcessRegionReplicasProcedure,13586211,Resolved,Blocker,Fixed,18/Jul/24 06:20,18/Jul/24 16:05,, "when a procedure on a table executed as a child procedure, further table procedure operations on that table are blocked forever waiting to acquire the table procedure lock ",13591661,Resolved,Critical,Implemented,10/Sep/24 14:59,17/Oct/24 11:46,2.5.10,"when a procedure on a table executed as a child procedure, furthur table procedure operations on that table are blocked forever waiting to aquire the table procedure lock . This issue occur due to not clearing of table lock for the table procedures submitted as child procedures after the changes in HBASE-28683," HBase Master stuck due to improper handling of WALSyncTimeoutException within UncheckedIOException,13590291,Resolved,Critical,Fixed,28/Aug/24 09:00,01/Oct/24 02:44,2.6.0,"One of our test clusters stuck during a rolling restart due to a WAL.sync timeout. This issue did not result in the Master aborting because the WALSyncTimeoutException was wrapped in an UncheckedIOException, which prevented the proper exception handling mechanism from being triggered. As a result, the Master was handing for a long time and  procedures were stuck. This was a 2.4 based HBase with HBASE-27230. {noformat} 2024-08-17 17:23:07,567 ERROR org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore: Failed to delete pid=2027 org.apache.hadoop.hbase.regionserver.wal.WALSyncTimeoutIOException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=4347, WAL system stuck?     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:848)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:718)     at org.apache.hadoop.hbase.regionserver.HRegion.sync(HRegion.java:8902)     at org.apache.hadoop.hbase.regionserver.HRegion.doWALAppend(HRegion.java:8469)     at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4523)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4447)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4377)     at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4853)     at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4847)     at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4843)     at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3155)     at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.lambda$delete$8(RegionProcedureStore.java:379)     at org.apache.hadoop.hbase.master.region.MasterRegion.update(MasterRegion.java:141)     at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.delete(RegionProcedureStore.java:379)     at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.delete(RegionProcedureStore.java:410)     at org.apache.hadoop.hbase.procedure2.CompletedProcedureCleaner.periodicExecute(CompletedProcedureCleaner.java:135)     at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.executeInMemoryChore(TimeoutExecutorThread.java:122)     at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.execDelayedProcedure(TimeoutExecutorThread.java:101)     at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.run(TimeoutExecutorThread.java:68) Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=4347, WAL system stuck?     at org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:171)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:844)     ... 18 more 2024-08-17 17:23:07,568 ERROR org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread: Ignoring pid=-1, state=WAITING_TIMEOUT; org.apache.hadoop.hbase.procedure2.CompletedProcedureCleaner exception: org.apache.hadoop.hbase.regionserver.wal.WALSyncTimeoutIOException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=4347, WAL system stuck? java.io.UncheckedIOException: org.apache.hadoop.hbase.regionserver.wal.WALSyncTimeoutIOException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=4347, WAL system stuck?     at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.delete(RegionProcedureStore.java:383)     at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.delete(RegionProcedureStore.java:410)     at org.apache.hadoop.hbase.procedure2.CompletedProcedureCleaner.periodicExecute(CompletedProcedureCleaner.java:135)     at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.executeInMemoryChore(TimeoutExecutorThread.java:122)     at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.execDelayedProcedure(TimeoutExecutorThread.java:101)     at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.run(TimeoutExecutorThread.java:68) Caused by: org.apache.hadoop.hbase.regionserver.wal.WALSyncTimeoutIOException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=4347, WAL system stuck?     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:848)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:718)     at org.apache.hadoop.hbase.regionserver.HRegion.sync(HRegion.java:8902)     at org.apache.hadoop.hbase.regionserver.HRegion.doWALAppend(HRegion.java:8469)     at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4523)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4447)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4377)     at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4853)     at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4847)     at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4843)     at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3155)     at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.lambda$delete$8(RegionProcedureStore.java:379)     at org.apache.hadoop.hbase.master.region.MasterRegion.update(MasterRegion.java:141)     at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.delete(RegionProcedureStore.java:379)     ... 5 more Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=4347, WAL system stuck?     at org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:171)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:844)     ... 18 more 2024-08-17 17:23:07,569 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: STUCK Region-In-Transition state=OPEN, location=host-10.example.com,22101,1723906425777, table=OMID_COMMIT_TABLE, region=1b8c62897ed9e90955e299bfca1e7aa9{noformat} " Setting `hbase.oldwals.cleaner.thread.size` to negative value will break HMaster and produce hard-to-diagnose logs,13592685,Patch Available,Critical,,20/Sep/24 08:02,,2.4.2,"============================ Problem ------------------------------------------------- HBase Master cannot be initialized with the following setting:       hbase.oldwals.cleaner.thread.size     -1     Default is 2     After running the start-hbase.sh, the Master node could not be started due to an exception: {code:java} ERROR [master/localhost:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.IllegalArgumentException: Illegal Capacity: -1     at java.util.ArrayList.(ArrayList.java:157)     at org.apache.hadoop.hbase.master.cleaner.LogCleaner.createOldWalsCleaner(LogCleaner.java:149)     at org.apache.hadoop.hbase.master.cleaner.LogCleaner.(LogCleaner.java:80)     at org.apache.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1329)     at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:917)     at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2081)     at org.apache.hadoop.hbase.master.HMaster.lambda$0(HMaster.java:505)     at java.lang.Thread.run(Thread.java:750){code} We were really confused and misled by the error log as the 'Illegal Capacity' of ArrayList seems like an internal code issue.   After we read the source code, we found that ""hbase.oldwals.cleaner.thread.size"" is parsed and used in createOldWalsCleaner() function without checking: {code:java} int size = conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE);    this.oldWALsCleaner = createOldWalsCleaner(size); {code} The value of ""hbase.oldwals.cleaner.thread.size"" will be served as the initialCapacity of ArrayList. If the configuration value is negative, an IllegalArgumentException will be thrown.: {code:java} private List createOldWalsCleaner(int size) { ...     List oldWALsCleaner = new ArrayList<>(size); ... } {code} ============================ Solution (the attached patch) ------------------------------------------------- The basic idea of the attached patch is to add a check and relevant logging for this value during the initialization of the {{LogCleaner}} in the constructor. This will help users better diagnose the issue. The detailed patch is shown below. {code:java} @@ -78,6 +78,11 @@ public class LogCleaner extends CleanerChore       pool, params, null);      this.pendingDelete = new LinkedBlockingQueue<>();      int size = conf.getInt(OLD_WALS_CLEANER_THREAD_SIZE, DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE); +    if (size <= 0) { +      LOG.warn(""The size of old WALs cleaner thread is {}, which is invalid, "" +          + ""the default value will be used."", size); +      size = DEFAULT_OLD_WALS_CLEANER_THREAD_SIZE; +    }      this.oldWALsCleaner = createOldWalsCleaner(size);    this.cleanerThreadTimeoutMsec = conf.getLong(OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC,        DEFAULT_OLD_WALS_CLEANER_THREAD_TIMEOUT_MSEC);{code} Thanks!" Setting `hbase.master.procedure.threads` to negative value doesn't break HMaster but clients cannot connect,13593105,Patch Available,Critical,,24/Sep/24 15:04,,2.4.2,"============================ Problem ------------------------------------------------- When we set 'hbase.master.procedure.threads' to a negative value as following:       hbase.master.procedure.threads     -1   We found that HMaster starts normally, but the HBase client cannot connect to the server. Additionally, there are no related error messages in the HMaster logs, making it difficult for users to diagnose the root cause of the issue. The root cause may be in the following code: After 'hbase.master.procedure.threads' is parsed and loaded in  createProcedureExecutor(), it will be propagated to init(): {code:java} private void createProcedureExecutor() throws IOException {   final int numThreads = conf.getInt(MasterProcedureConstants.MASTER_PROCEDURE_THREADS, Math.max(       (cpus > 0 ? cpus / 4 : 0), MasterProcedureConstants.DEFAULT_MIN_MASTER_PROCEDURE_THREADS)); ...    procedureExecutor.init(numThreads, abortOnCorruption);     } {code} In the {{init}} function, the parameter {{numThreads}} is used to initialize a series of work threads in a loop. However, since the configuration value is set to -1, the program does not enter the loop, resulting in no work threads being initialized. This leads to the client being unable to connect. {code:java}     for (int i = 0; i < corePoolSize; ++i) {       workerThreads.add(new WorkerThread(threadGroup));     } {code} However, when this failure occurs, there are no error logs in the HMaster that explicitly point to this configuration parameter, making it difficult for users to diagnose the root cause. It is recommended that validation checks and corresponding log messages for this configuration parameter be added to assist users in diagnosing this issue.   ============================ Solution (the attached patch) ------------------------------------------------- Since {{numThreads}} is declared as final in the {{createProcedureExecutor}} method and cannot be modified, it may be beneficial to add logging within that method to capture the configuration value. {code:java} @@ -1743,6 +1743,9 @@ public class HMaster extends HBaseServerBase implements Maste      int cpus = Runtime.getRuntime().availableProcessors();    final int numThreads = conf.getInt(MasterProcedureConstants.MASTER_PROCEDURE_THREADS, Math.max(        (cpus > 0 ? cpus / 4 : 0), MasterProcedureConstants.DEFAULT_MIN_MASTER_PROCEDURE_THREADS)); +    if (numThreads <= 0) { +      LOG.warn(MasterProcedureConstants.MASTER_PROCEDURE_THREADS + "" is set to {}."", numThreads); +    }      final boolean abortOnCorruption =       conf.getBoolean(MasterProcedureConstants.EXECUTOR_ABORT_ON_CORRUPTION,          MasterProcedureConstants.DEFAULT_EXECUTOR_ABORT_ON_CORRUPTION); {code}   These are the situations I encountered and possible mitigation solutions. If there is anything else you need to add, please remind me. Thank you." BackupLogCleaner unsafe for multi-root backups,13591914,Resolved,Critical,Duplicate,12/Sep/24 09:58,16/Sep/24 19:35,,"The BackupLogCleaner is responsible for keeping WALs around that are not yet backed-up. However, it does not keep track of multi-root backups. I.e. if there are 2 backups roots R1 and R2, where R1 was backed up 1 week ago, and R2 today, the WALS needed for R1 could be deleted (= data loss in the R1 backups)." Replication blocking: InvalidProtocolBufferException$InvalidWireTypeException: Protocol message tag had invalid wire type.,13586517,Resolved,Critical,Fixed,22/Jul/24 09:57,28/Jul/24 05:42,2.6.0,"h2. replication queue overstock, As shown below: !image-2024-07-23-12-33-50-395.png!   In the figure, the first wal file no longer exists, but has not been skipped, causing replciation to block. the second and third wal file were moved oldWals, you can see the attachment, the reading of these two files faile. h2. The error log in rs is 2024-07-22T17:47:49,130 WARN [RS_CLAIM_REPLICATION_QUEUE-regionserver/sh2-int-hbase-main-ha-9:16020-0.replicationSource,test_hbase_258-tx1-int-hbase-main-prod-3,16020,1720602522464.replicationSource.wal-reader.tx1-int-hbase-main-prod-3%2C16020%2C1720602522464,test_hbase_258-tx1-int-hbase-main-prod-3,16020,1720602522464] wal.ProtobufWALStreamReader: Error while reading WALKey, originalPosition=0, currentPosition=81 org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException$InvalidWireTypeException: Protocol message tag had invalid wire type. at org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException.invalidWireType(InvalidProtocolBufferException.java:119) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hbase.thirdparty.com.google.protobuf.UnknownFieldSet$Builder.mergeFieldFrom(UnknownFieldSet.java:503) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hbase.thirdparty.com.google.protobuf.GeneratedMessage$Builder.parseUnknownField(GeneratedMessage.java:770) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos$WALKey$Builder.mergeFrom(WALProtos.java:2829) ~[hbase-protocol-shaded-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos$WALKey$1.parsePartialFrom(WALProtos.java:4212) ~[hbase-protocol-shaded-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos$WALKey$1.parsePartialFrom(WALProtos.java:4204) ~[hbase-protocol-shaded-2.6.0.jar:2.6.0] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parsePartialFrom(AbstractParser.java:192) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:209) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:214) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:25) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hbase.thirdparty.com.google.protobuf.GeneratedMessage.parseWithIOException(GeneratedMessage.java:321) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7] at org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos$WALKey.parseFrom(WALProtos.java:2321) ~[hbase-protocol-shaded-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.regionserver.wal.ProtobufWALTailingReader.readWALKey(ProtobufWALTailingReader.java:128) ~[hbase-server-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.regionserver.wal.ProtobufWALTailingReader.next(ProtobufWALTailingReader.java:257) ~[hbase-server-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:490) ~[hbase-server-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.lastAttempt(WALEntryStream.java:306) ~[hbase-server-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:388) ~[hbase-server-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:130) ~[hbase-server-2.6.0.jar:2.6.0] at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:153) ~[hbase-server-2.6.0.jar:2.6.0] 2024-07-22T17:48:13,315 WARN [RS-EventLoopGroup-1-65] ipc.NettyRpcConnection: Exception encountered while connecting to the server tx1-int-hbase-main-prod-3:16020 org.apache.hbase.thirdparty.io.netty.channel.ConnectTimeoutException: connection timed out after 10000 ms: tx1-int-hbase-main-prod-3/127.0.0.1:16020 at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe$2.run(AbstractEpollChannel.java:615) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.concurrent.PromiseTask.runTask(PromiseTask.java:98) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:153) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:416) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[hbase-shaded-netty-4.1.7.jar:?] at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[hbase-shaded-netty-4.1.7.jar:?] at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_202]  h2. hbase wal -p error hbase wal -p hdfs://coreHBaseProdHa/hbase/oldWALs/tx1-int-hbase-main-prod-4%2C16020%2C1720602602602.1720609818921 error is : 2024-07-23 12:36:27,064 INFO  [main] hdfs.LocatedBlocksRefresher (LocatedBlocksRefresher.java:(98)) - Start located block refresher for DFSClient default. Writer Classes: ProtobufLogWriter AsyncProtobufLogWriter SecureProtobufLogWriter SecureAsyncProtobufLogWriter Cell Codec Class: org.apache.hadoop.hbase.regionserver.wal.WALCellCodec Exception in thread ""main"" java.io.EOFException: EOF while reading message size         at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.parseDelimitedFrom(ProtobufUtil.java:3727)         at org.apache.hadoop.hbase.regionserver.wal.ProtobufWALStreamReader.next(ProtobufWALStreamReader.java:56)         at org.apache.hadoop.hbase.wal.WALStreamReader.next(WALStreamReader.java:42)         at org.apache.hadoop.hbase.wal.WALPrettyPrinter.processFile(WALPrettyPrinter.java:297)         at org.apache.hadoop.hbase.wal.WALPrettyPrinter.run(WALPrettyPrinter.java:516)         at org.apache.hadoop.hbase.wal.WALPrettyPrinter.main(WALPrettyPrinter.java:429)" TestBackupMerge fails 100% of times on flaky dashboard,13584378,Resolved,Critical,Fixed,01/Jul/24 14:21,21/Jul/24 00:50,, Hadoop check for hadoop 3.4.0 is failing,13584998,Resolved,Critical,Fixed,08/Jul/24 11:32,10/Jul/24 02:31,,"In hadoop 3.4.0, hadoop common depends on org.bouncycastle:bcprov-jdk15on, where we an enforcer rule to force depending on org.bouncycastle:*-jdk18on. We should exlude org.bouncycastle:bcprov-jdk15on from hadoop. And also remove direct references of protobuf 2.5 in our asyncfs code." Data race in RecoveredEditsOutputSink while closing writers,13584379,Resolved,Critical,Fixed,01/Jul/24 14:27,05/Jul/24 22:46,,"Hit this error while testing jdk17 locally {noformat} Tests run: 37, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 42.3 s <<< FAILURE! - in org.apache.hadoop.hbase.wal.TestWALSplitValueCompression org.apache.hadoop.hbase.wal.TestWALSplitValueCompression.testEmptyLogFiles Time elapsed: 0.359 s <<< ERROR! java.io.IOException: java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 0 at org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink.closeWriters(RecoveredEditsOutputSink.java:129) at org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink.close(RecoveredEditsOutputSink.java:96) at org.apache.hadoop.hbase.wal.WALSplitter.splitWAL(WALSplitter.java:416) at org.apache.hadoop.hbase.wal.WALSplitter.split(WALSplitter.java:219) at org.apache.hadoop.hbase.wal.TestWALSplit.splitAndCount(TestWALSplit.java:529) at org.apache.hadoop.hbase.wal.TestWALSplit.testEmptyLogFiles(TestWALSplit.java:563) at org.apache.hadoop.hbase.wal.TestWALSplit.testEmptyLogFiles(TestWALSplit.java:548) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:840) Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 0 at java.base/java.util.ArrayList.add(ArrayList.java:455) at java.base/java.util.ArrayList.add(ArrayList.java:467) at org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink.lambda$closeWriters$0(RecoveredEditsOutputSink.java:111) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ... 1 more {noformat} It is a bit strange that we meet ArrayIndexOutOfBounds in ArrayList.add. Then I noticed that, we use a thread pool to close the writers but splits field is just an ArrayList, which is not thread safe..." Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3,13591743,Patch Available,Major,,11/Sep/24 07:27,,,"Bootstrap 3.4.1 was released in 13 Feb, 2019 and there has been no new 3.x release since then. This version of bootstrap has multiple medium CVEs reported recently. See [https://security.snyk.io/package/npm/bootstrap/3.4.1] for details. CVE List: * [https://www.cve.org/CVERecord?id=CVE-2024-6484] * [https://www.cve.org/CVERecord?id=CVE-2024-6485] Related Github Issue/Advisory: * [https://github.com/twbs/bootstrap/issues/40692] * [https://github.com/advisories/GHSA-9mvj-f7w8-pvh2] Based on synk.io the only non-vulnerable version seems to be in 5.x line. Upgrading from 3.x to 4.x itself would be substantial work. So may be we would have to move step by step i.e. migrate from 3.x to 4.x and then 4.x to 5.x. This JIRA is to capture all sub-task needed to achieve same." Backup delete incorrectly handles bulk loaded entries,13585013,Open,Major,,08/Jul/24 12:12,,2.6.0,"To delete a backup, `BackupAdminImpl#deleteBackup` calls `BackupSystemTable#deleteBulkLoadedRows` on all rows returned by `BackupSystemTable#readBulkLoadedFiles(backupId)`. This last method comes down to a scan over the bulk load table for all rows matching ""bulk:BACKUPID:"". However, current code never writes rows of that format. The only methods that do so are `BackupSystemTable#writeBulkLoadedFiles` and `BackupSystemTable#createPutForBulkLoadedFile`, which are only used in test code. Note that the bulkload rows that do get written (see `BackupObserver`) only get deleted when creating incremental backups, but suffer from HBASE-28706. Consequences: I suspect that if you do some bulk loads, create a full backup, and delete that backup before doing any incremental backup, those entries in the bulk load table will never get deleted, meaning those HFiles can never get deleted (because `BackupLogCleaner` blocks their deletion)." Parallelize the archival of compacted files ,13592019,Resolved,Major,Fixed,13/Sep/24 06:53,19/Feb/25 02:03,2.5.10,"While splitting a region in hbase it has to cleanup compacted files for bookkeeping.   Currently we do it sequentially and that is good enough because for hdfs as it is a fast operation. When we do the same in s3 it becomes a issue. We need to paralleize this to make it faster.  {code:java} // code placeholder for (File file : toArchive) {       // if its a file archive it       try {         LOG.trace(""Archiving {}"", file);         if (file.isFile()) {           // attempt to archive the file           if (!resolveAndArchiveFile(baseArchiveDir, file, startTime)) {             LOG.warn(""Couldn't archive "" + file + "" into backup directory: "" + baseArchiveDir);             failures.add(file);           }         } else {           // otherwise its a directory and we need to archive all files           LOG.trace(""{} is a directory, archiving children files"", file);           // so we add the directory name to the one base archive           Path parentArchiveDir = new Path(baseArchiveDir, file.getName());           // and then get all the files from that directory and attempt to           // archive those too           Collection children = file.getChildren();           failures.addAll(resolveAndArchive(fs, parentArchiveDir, children, start));         }       } catch (IOException e) {         LOG.warn(""Failed to archive {}"", file, e);         failures.add(file);       }     } {code}" Implement proper string builder for MoveRegionRequest in ProtobufUtil.getShortTextFormat ,13592663,Resolved,Major,Fixed,20/Sep/24 04:57,14/Oct/24 07:38,,"While looking into an issue where I was trying to debug MoveRegion, came across this responseTooSlow log where the params aren't properly build for MoveRegionRequest. Would be good to properly formulate this so that we know the regionName and other details. {code:java} ipc.RpcServer - (responseTooSlow): {""call"":""MoveRegion(org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MoveRegionRequest)"",""starttimems"":""<>"",""responsesize"":""0"",""method"":""MoveRegion"",""param"":""TODO: class org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MoveRegionRequest"",""processingtimems"":830247,""client"":""<>"",""queuetimems"":0,""class"":""HMaster""}{code}" Bump cryptography from 42.0.4 to 43.0.1 in /dev-support/git-jira-release-audit,13591020,Resolved,Major,Fixed,04/Sep/24 14:45,05/Sep/24 11:58,, Manage hbase-thirdparty transitive dependencies via BOM pom,13593199,Patch Available,Major,,25/Sep/24 12:07,,,"Despite the intentions to the contrary, there are several places where we need the version of a dependency managed in hbase-thirdparty to match an import in the main product (and maybe also in our other repos). Right now, this is managed via comments in the poms, which read ""when this changes there, don't for get to update it here..."". We can do better than this. I think that hbase-thirdparty could publish a BOM pom file that can be imported into any of the downstream hbase projects that make use of that release of hbase-thirdparty. That will centralize management of these dependencies in the hbase-thirdparty repo. This blog post has a nice write-up on the idea, https://www.garretwilson.com/blog/2023/06/14/improve-maven-bom-pattern" "Change the default Hadoop3 version to 3.4.1, and add tests to make sure HBase works with earlier supported Hadoop versions",13592438,Resolved,Major,Fixed,18/Sep/24 07:07,14/Jan/25 06:40,2.6.0,"Discussed on the mailing list: https://lists.apache.org/thread/orc62x0v2ktvj26ltvrqpfgzr94ncswn" Use region server configuration for evicting the cache while unassigning a region,13590955,Reopened,Major,,04/Sep/24 04:47,,2.6.0,"While unassigning a region because of either a region movement or split/merge, the master node sends a RPC to the region server where the region is currently hosted. As part of this RPC, it also tells the region server whether the blocks for the region being unassigned should be evicted from the cache. This is done by passing a boolean parameter. The value for this parameter is found from couple of configuration parameters seen on the master node. For example, ""hbase.rs.evictblocksonsplit"" (if the region is being unassigned because of split) or ""hbase.rs.evictblocksonclose"" (if the region is being moved from this region server to some other region server). With support for dynamic configuration, these configuration parameter values may differ between the master node and the worker nodes. Since, caching is managed by the worker nodes, we should use the configuration values as seen on the worker nodes rather than the values seen on the master node. The master node should just tell the worker nodes if the region unassignment is happening because of a split or a region movement and the worker nodes should take the appropriate decision about evicting from cache depending on the configuration seen there." NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing,13588706,Resolved,Major,Fixed,13/Aug/24 12:19,06/Sep/24 08:57,,"The reason: For table.jsp, NPE may occur when calling  master.getConnection() while Master is initializing. asyncClusterConnection will only be initialized when HMaster call method setupClusterConnection, so before that, asyncClusterConnection is null, at this moment,  we would get NPE if opening table.jsp. procedure.jsp and master-status may also encounter NPE for the similar reason.   Error Message： java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.hbase.procedure2.ProcedureExecutor.getProcedures()"" because ""procExecutor"" is null at org.apache.hadoop.hbase.generated.master.procedures_jsp._jspService(procedures_jsp.java:76) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:117) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)   2024-08-13T20:41:40,056 WARN  [qtp463313451-80] server.HttpChannel: /master-status java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.hbase.master.assignment.RegionStateNode.isInState(org.apache.hadoop.hbase.master.RegionState$State[])"" because ""rsn"" is null         at org.apache.hadoop.hbase.master.http.MasterStatusServlet.getMetaLocationOrNull(MasterStatusServlet.java:80) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]         at org.apache.hadoop.hbase.master.http.MasterStatusServlet.doGet(MasterStatusServlet.java:60) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]         at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) ~[javax.servlet-api-3.1.0.jar:3.1.0]         at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) ~[javax.servlet-api-3.1.0.jar:3.1.0]         at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) ~[hbase-shaded-jetty-4.1.7.jar:?]         at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1656) ~[hbase-shaded-jetty-4.1.7.jar:?]         at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:117) ~[hbase-http-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]    " [hbase-thirdparty] Bump protobuf version from 4.26.1 to 4.27.3,13587799,Resolved,Major,Fixed,03/Aug/24 19:56,12/Aug/24 04:02,, [hbase-thirdparty] Release hbase-thirdparty 4.1.8,13587797,Resolved,Major,Fixed,03/Aug/24 19:52,31/Aug/24 03:36,, SFT's BrokenStoreFileCleaner may cause data loss,13593268,Resolved,Major,Fixed,25/Sep/24 22:01,02/Oct/24 11:01,2.5.10,"When having this BrokenStoreFileCleaner enabled, one of our customers has run into a data loss situation, probably due to a race condition between regions getting moved out of the regionserver while the BrokenStoreFileCleaner was checking this region's files eligibility for deletion. We have seen that the file got deleted by the given region server, around the same time the region got closed on this region server. I believe a race condition during region close is possible here: 1) In BrokenStoreFileCleaner, for each region online on the given RS, we get the list of files in the store dirs, then iterate through it [1]; 2) For each file listed, we perform several checks, including this one [2] that checks if the file is ""active"" The problem is, if the region for the file we are checking got closed between point #1 and #2, by the time we check if the file is active in [2], the store may have already been closed as part of the region closure, so this check would consider the file as deletable. One simple solution is to check if the store's region is still open before proceeding with deleting the file. [1] https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BrokenStoreFileCleaner.java#L99 [2] https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BrokenStoreFileCleaner.java#L133" table level wal appendSize and replication source metrics not correctly shown in /jmx response,13592423,Resolved,Major,Duplicate,18/Sep/24 03:20,02/Jan/25 13:23,,"Found 2 metrics did not display in the /jmx http interface response, table level wal appendSize and table level replication source. I suspect it's because the metric name contains a colon :  !image-2024-09-18-11-21-10-279.png|width=521,height=161!   !image-2024-09-18-11-21-20-295.png|width=521,height=282!   after modify the table name string to ""Namespace_$namespace_table_$table, the metric really display correctly in the /jmx response  " Align the fixed issues in git and jira,13592359,In Progress,Major,,17/Sep/24 13:39,,,"The API cleanup is almost done, so we are entering the last steps for releasing the final 3.0.0. We should try our best to align the fixed issues in git and jira, especially for a major release. It will be a huge project, so file a jira issue to track this work. Plan to do this in the next few weeks, waiting for my 192GB machine to ready so I can start to run ITBLL and upgrading tests locally(Actually I've already bought everything for the machine but it failed to boot with 192G DDR5 RAM so I sent the motherboard back...)" Modify default value of hbase.bucketcache.persistence.chunksize to 10K,13592234,Resolved,Major,Fixed,16/Sep/24 11:11,16/Sep/24 17:15,2.7.0,"Currently, the default value of the configuration parameter ""hbase.bucketcache.persistence.chunksize"" is 10 million (10000000). This is the number of block entries that are processed during the persistence of bucket-cache backing map to the persistence file. During the testing, it was found that, this high number of chunksize resulted in high heap utilisation in region servers leading to longer GC pauses which also led to server crashes intermittently. When the value of this configuration is set to 10K(10000), the cache remains stable. No GC delays are observed. Also no server crashes are observed. The jmap outputs collected against the regionservers showed reduced memory utilisation from 4.5-5GB to 1-1.5GB for the objects related to persistence code. Hence, we need to adjust the default value of this configuration parameter to 10K. Thanks, Janardhan" Exception handling during retrieval of bucket-cache from persistence.,13592200,Resolved,Major,Fixed,16/Sep/24 04:41,24/Sep/24 11:57,2.7.0,"During the retrieval of bucket cache from the persistence file during the startup, it was observed that, if an exception, other than, the IOException occurs, the bucket cache internal members remain uninitialised and cause the bucket to remain unusable. The exception is not logged in the trace file and the retrieval thread exits without initialising the bucket-cache. Also, the NullPointerExceptions are seen when, trying to use the cache. {code:java} 2024-09-10 14:33:30,020 ERROR org.apache.hadoop.hbase.io.hfile.bucket.BucketCache: WriterThread encountered error java.lang.NullPointerException at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache$RAMQueueEntry.writeToCache(BucketCache.java:1975) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.doDrain(BucketCache.java:1298) {code}   {code:java} 2024-09-13 07:01:05,964 ERROR org.apache.hadoop.metrics2.impl.MetricsSourceAdapter: Error getting metrics from source RegionServer,sub=Server java.lang.NullPointerException at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getFreeSize(BucketCache.java:1819) at org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.getFreeSize(CombinedBlockCache.java:179) at org.apache.hadoop.hbase.regionserver.MetricsRegionServerWrapperImpl.getBlockCacheFreeSize(MetricsRegionServerWrapperImpl.java:308) at org.apache.hadoop.hbase.regionserver.MetricsRegionServerSourceImpl.addGaugesToMetricsRecordBuilder(MetricsRegionServerSourceImpl.java:525) at org.apache.hadoop.hbase.regionserver.MetricsRegionServerSourceImpl.getMetrics(MetricsRegionServerSourceImpl.java:333) {code} All type of exceptions need to be handled gracefully. All types of exceptions must be logged to the trace file. The bucket cache needs to reinitialised and made usable. Thanks, Janardhan" Remove the deprecated annotation in RegionCoprocessorHost,13591411,Resolved,Major,Fixed,08/Sep/24 13:10,13/Sep/24 02:33,,"To align with the pattern for other methods, where we only mark the methods in CP interface deprecated." ExportSnapshot failed if reference file presented,13590551,Open,Major,,30/Aug/24 09:48,,2.4.14,"ExportSnapshot tasks failed due to FNFE.   If there are reference files in data.manifest, they are converted to referred files, so same referred files are handled in multi map tasks. It will cause FNFE if the same file copied in different map tasks concurrently." Introduce row statistics coprocessor example,13592107,Resolved,Major,Fixed,13/Sep/24 18:25,20/Dec/24 16:18,2.0.0,"Goal: Add a coprocessor to HBase that allows administrators to track high level statistics on the rows and cells in their HBase tables. Administrators can load this coprocessor into their RegionServers if they wish to gain more visibility into the shape of their data in HBase. At my day job, we've leveraged the statistics from this coprocessor to automatically configure more optimal block sizes and smarter compaction schedules for our fleet of nearly 200 HBase clusters. Context: Since HBase tables can store terabytes or even petabytes of data, HBase administrators often have incomplete information about the data stored in their HBase tables. Without a comprehensive understanding of the shape of their data, it can be difficult for administrators to configure clusters for a desired level of performance and/or reliability. Row statistics have the potential to supercharge HBase management. [Design doc|https://docs.google.com/document/d/1oaNAZUER5zO8yivmzRBVAMmL6r2cYiJn9YCbDe14LMw/edit#heading=h.nch5d72p27ex]" hbase-connectors fails to build with hbase 2.6.0,13589164,Resolved,Major,Fixed,17/Aug/24 11:31,03/Oct/24 08:13,,"hbase-connectors fails to build with hbase 2.6.0 {code:java} [INFO] Reactor Summary for Apache HBase Connectors 1.1.0-SNAPSHOT: [INFO]  [INFO] Apache HBase Connectors ............................ SUCCESS [  4.377 s] [INFO] Apache HBase - Kafka ............................... SUCCESS [  0.116 s] [INFO] Apache HBase - Model Objects for Kafka Proxy ....... SUCCESS [  3.222 s] [INFO] Apache HBase - Kafka Proxy ......................... FAILURE [  8.305 s] [INFO] Apache HBase - Spark ............................... SKIPPED [INFO] Apache HBase - Spark Protocol ...................... SKIPPED [INFO] Apache HBase - Spark Protocol (Shaded) ............. SKIPPED [INFO] Apache HBase - Spark Connector ..................... SKIPPED [INFO] Apache HBase - Spark Integration Tests ............. SKIPPED [INFO] Apache HBase Connectors - Assembly ................. SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time:  16.703 s [INFO] Finished at: 2024-08-17T11:29:20Z [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project hbase-kafka-proxy: Compilation failure [ERROR] /workspaces/hbase-connectors/kafka/hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/KafkaBridgeConnection.java:[169,31] is not abstract and does not override abstract method setRequestAttribute(java.lang.String,byte[]) in org.apache.hadoop.hbase.client.TableBuilder {code}" Backup restores are broken if the backup has moved locations,13593120,Resolved,Major,Fixed,24/Sep/24 17:57,03/Dec/24 16:28,2.6.1,"My company runs a few hundred HBase clusters. We want to take backups everyday in one public cloud region, and then use said cloud's native replication solution to ""backup our backups"" in a secondary region. This is how we plan for region-wide disaster recovery. This system should work, but doesn't because of the way that BackupManifests are constructed. Backing up a bit (no pun intended): when we replicate backups verbatim, the manifest file continues to point to the original backup root. This shouldn't matter, because when taking a restore one passes a RestoreRequest to the RestoreTablesClient — and this RestoreRequest includes a BackupRootDir field. This works as you would expect initially, but eventually we build a BackupManifest that fails to interpolate this provided root directory and, instead, falls back to what it finds on disk in the backup (which would point back to the primary backup location, even if reading a replicated backup). To fix this, I'm proposing that we properly interpolate the request's root directory field when building BackupManifests." Verify the first argument passed to compaction_switch,13586825,Open,Major,,24/Jul/24 16:41,,2.2.3,"Sometimes, users may inadvertently attempt to use compaction_switch; therefore, it is advisable to implement a verification step for the first argument passed to this function, ensuring that incorrect inputs do not accidentally disable compaction." Concurrent execution of normalizer operations on tables in RegionNormalizerWorker,13588818,Open,Major,,14/Aug/24 08:10,,,"Recently, I have been managing the large tables in the HBase cluster by enabling the normalizer to set the size of the regions and keep the number of regions within a reasonable range. The current code retrieves tables from RegionNormalizerWorkQueue and performs normalization operations on the tables in series. When there are multiple large tables in a cluster that need to be managed, the efficiency will be very low. I have confirmed that each split or merge plan generated by each table during the normalizer process will be limited by RateLimiter, so I think it is reasonable to perform table normalizers concurrently. In terms of implementation, create a thread pool for executing tasks in RegionNormalizerWorker, with a default value of 1 for the number of thread pools, and provide a parameter that can be configured to other values." Add 2.6.x in hadoop support matrix in our ref guide,13584930,Resolved,Major,Fixed,07/Jul/24 14:41,12/Jul/24 11:17,,Now it is only up to 2.5.x. ParseException may occur when getting the fileDate of the mob file recovered through snapshot,13593075,Open,Major,,24/Sep/24 10:58,,2.4.13,"The task ExpiredMobFileCleaner may occur ParseException when parsing MOB file recovered through snapshot, causing these expired MOB file cannot be deleted.   The Reason: The task ExpiredMobFileCleaner obtain the MOB file creation time by parsing the MOB filename. In regular MOB table, the 32nd to 40th characters of the MOB filename indicate the file creation time, ExpiredMobFileCleaner can get the creation time of MOB file by obtaining these characters. However, in MOB tables recovered through snapshot, the format of MOB filename is tableName-mobregionaname-hfilename，so ExpiredMobFileCleaner may not be able to obtain the creation time of MOB file by obtaining the characters at the above location. So, in this situation, ParseException will occur, causing these expired MOB file cannot be deleted finally." Only return from ReplicationSink.replicationEntries while all background tasks are finished,13592448,Resolved,Major,Fixed,18/Sep/24 08:43,19/Sep/24 15:14,2.5.6, No data available when scan cross-region and setReversed(true) in Spark on HBase sc.newAPIHadoopRDD,13585705,Open,Major,,13/Jul/24 08:20,,2.2.3,"Using below scala code to scan data in Spark on HBase:     val scan = new Scan()     scan.withStartRow(Bytes.toBytes(startKey))     scan.withStopRow(Bytes.toBytes(stopKey))     if (reversed) {       scan.setReversed(true)     }     val conf = ConnectionFactory.createConnection.getConfiguration     conf.set(TableInputFormat.INPUT_TABLE, tableName)     conf.set(TableInputFormat.SCAN, TableMapReduceUtil.convertScanToString(scan))    val rdd = sc.newAPIHadoopRDD(conf, classOf[TableInputFormat], classOf[ImmutableBytesWritable], classOf[Result])   1.When scan cross-region  without reversed=true, the scan can be performed normally and the result can be obtained. 2.When scan do not cross-region but with reversed=true, the scan can be performed normally and the result can be obtained. 3.When scan cross-region  with reversed=true,  the result is empty." Add API for multi region splitting,13589531,Open,Major,,21/Aug/24 04:05,,,This is to add the API to support multi region splitting. Snapshot based mapreduce jobs fails with NPE while trying to close mslab within mapper,13586334,Resolved,Major,Fixed,19/Jul/24 06:45,23/Jul/24 01:47,,"{code:java} 2024-07-11 10:20:38,800 WARN  [main] client.ClientSideRegionScanner - Exception while closing region java.io.IOException: java.lang.NullPointerException         at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1808)         at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1557)         at org.apache.hadoop.hbase.client.ClientSideRegionScanner.close(ClientSideRegionScanner.java:133)         at org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormatImpl$RecordReader.close(TableSnapshotInputFormatImpl.java:310)         at org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormat$TableSnapshotRegionRecordReader.close(TableSnapshotInputFormat.java:184)         at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.close(MapTask.java:536)         at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:804)         at org.apache.hadoop.mapred.MapTask.run(MapTask.java:348)         at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:178)         at java.security.AccessController.doPrivileged(Native Method)         at javax.security.auth.Subject.doAs(Subject.java:422)         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)         at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:172) Caused by: java.lang.NullPointerException         at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.recycleChunks(MemStoreLABImpl.java:296)         at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.lambda$new$0(MemStoreLABImpl.java:109)         at org.apache.hadoop.hbase.nio.RefCnt.deallocate(RefCnt.java:95)         at org.apache.hbase.thirdparty.io.netty.util.AbstractReferenceCounted.handleRelease(AbstractReferenceCounted.java:86)         at org.apache.hbase.thirdparty.io.netty.util.AbstractReferenceCounted.release(AbstractReferenceCounted.java:76)         at org.apache.hadoop.hbase.nio.RefCnt.release(RefCnt.java:84)         at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.close(MemStoreLABImpl.java:269)         at org.apache.hadoop.hbase.regionserver.Segment.close(Segment.java:143)         at org.apache.hadoop.hbase.regionserver.AbstractMemStore.close(AbstractMemStore.java:381)         at org.apache.hadoop.hbase.regionserver.HStore.closeWithoutLock(HStore.java:723)         at org.apache.hadoop.hbase.regionserver.HStore.close(HStore.java:795)         at org.apache.hadoop.hbase.regionserver.HRegion$2.call(HRegion.java:1786)         at org.apache.hadoop.hbase.regionserver.HRegion$2.call(HRegion.java:1783)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:750) {code} This happens because the ChunkCreator is only initialized as part of HRegionServer [here.|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseServerBase.java#L410-L431] HRegion created on top of snapshot files within mapper wouldn't have ChunkCreator initialized causing NPE while trying to close the memstore This is seen after https://issues.apache.org/jira/browse/HBASE-28401 There are 2 possible solutions here :  1. Initialize ChunkCreator as while trying to create HRegion within snapashot based mapper 2. Disable the mslab altogether (via hbase.hregion.memstore.mslab.enabled set to false) within snapashot based mapper " Should call ProcedureSchduler.completionCleanup for non-root procedure too,13592860,Resolved,Major,Fixed,22/Sep/24 14:46,14/Oct/24 08:37,,"Per the discussion in this PR https://github.com/apache/hbase/pull/6247 And the related issue HBASE-28830, it seems incorrect that we only call cleanup for non-root procedures. This issue aims to see if there are any issues we call this method for every procedure." Add rel/2.6.1 to the downloads page,13592456,Resolved,Major,Fixed,18/Sep/24 08:51,18/Oct/24 18:12,, Send announce email,13592455,Resolved,Major,Done,18/Sep/24 08:47,19/Oct/24 08:25,, Release 2.6.1,13592444,Resolved,Major,Done,18/Sep/24 08:41,19/Oct/24 08:25,,"We have 130+ commits on branch-2.6 ; we're over-due for 2.6.1. That's a lot of changes, so lets track this a little more carefully than we might a standard patch release." Publish staged repository in Nexus,13592451,Resolved,Major,Done,18/Sep/24 08:46,18/Oct/24 13:24,, Update reporter tool with new release,13592454,Resolved,Major,Done,18/Sep/24 08:47,18/Oct/24 07:50,, Push signed release tag to git,13592453,Resolved,Major,Done,18/Sep/24 08:46,18/Oct/24 07:36,, Release version 2.6.1 in Jira,13592452,Resolved,Major,Done,18/Sep/24 08:46,18/Oct/24 07:36,, Propose Release Candidate(s),13592450,Resolved,Major,Done,18/Sep/24 08:45,17/Oct/24 15:41,, Review open issues and mark likely inclusion candidates with fixVersion=2.6.1,13592446,Resolved,Major,Done,18/Sep/24 08:43,17/Oct/24 15:41,, Audit Jira vs. git commit history,13592445,Resolved,Major,Done,18/Sep/24 08:42,17/Oct/24 15:41,, Run a correctness test with ITBLL,13592449,Resolved,Major,Done,18/Sep/24 08:44,17/Oct/24 15:41,, Add a metric of the amount of data written to WAL to determine the pressure of replication,13592463,Open,Major,,18/Sep/24 09:55,,,"Add a metric of the amount of data written to WAL to determine the pressure of replication. Combined with the replication shipped size metric, the user can determine how many RegionServers are needed to meet the data(WAL) writing requirements, that is to achieve the goal of no replication lag.   In the postAppend method of ReplicationSourceWALActionListener, the amount of WAL data that needs to be replicated is counted, and the filter logic in replication is reused. Alos add a hbase.replication.walAppendsize.metric.enable=false config to disable this metric, if it has some side effect." Protect hbase:meta from any hotspotting regions by balancing them to different region servers,13588351,Open,Major,,09/Aug/24 04:53,,,"During some of the incidents, it is observed that when hbase:meta is colocated with high load (or hotspotting) region, that makes meta unavailable and causes availability issues. This item is to provide a way to load balance such regions such that meta is not impacted." Change the generic type for ObserverContext from 'RegionCoprocessorEnvironment' to '? extends RegionCoprocessorEnvironment' in RegionObserver,13592607,Resolved,Major,Fixed,19/Sep/24 13:54,10/Oct/24 13:09,,"This will be a breaking change for coprocessor implementation, but the ability of region observer is not changed, so I think it is OK to include this in 3.0.0 release, as we have already changed the coprocessor protobuf to the relocated one, which already breaks lots of coprocessors." AsyncFSWAL is broken when running against hadoop 3.4.0,13585246,Resolved,Major,Fixed,10/Jul/24 02:20,09/Oct/24 08:31,,"{noformat} 2024-07-10T10:09:33,161 ERROR [master/localhost:0:becomeActiveMaster {}] asyncfs.FanOutOneBlockAsyncDFSOutputHelper(258): Couldn't properly initialize access to HDFS internals. Please update your WAL Provider to not make use of the 'asyncfs' provider. See HBASE-16110 for more information. java.lang.NoSuchMethodException: org.apache.hadoop.hdfs.DFSClient.beginFileLease(long,org.apache.hadoop.hdfs.DFSOutputStream) at java.lang.Class.getDeclaredMethod(Class.java:2675) ~[?:?] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createLeaseManager(FanOutOneBlockAsyncDFSOutputHelper.java:175) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.(FanOutOneBlockAsyncDFSOutputHelper.java:252) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at java.lang.Class.forName0(Native Method) ~[?:?] at java.lang.Class.forName(Class.java:375) ~[?:?] at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.load(AsyncFSWALProvider.java:149) ~[classes/:?] at org.apache.hadoop.hbase.wal.WALFactory.getProviderClass(WALFactory.java:174) ~[classes/:?] at org.apache.hadoop.hbase.wal.WALFactory.(WALFactory.java:262) ~[classes/:?] at org.apache.hadoop.hbase.wal.WALFactory.(WALFactory.java:231) ~[classes/:?] at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:383) ~[classes/:?] at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:135) ~[classes/:?] at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1003) ~[classes/:?] at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2524) ~[classes/:?] at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[classes/:?] at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at java.lang.Thread.run(Thread.java:840) ~[?:?] {noformat}" RefCnt Leak error when caching index blocks at write time,13593514,Resolved,Major,Fixed,27/Sep/24 13:40,03/Oct/24 07:59,2.5.10,"Following [~bbeaudreault] works from HBASE-27170 that added the (very useful) refcount leak detector, we sometimes see these reports on some branch-2 based deployments: {noformat} 2024-09-25 10:06:42,413 ERROR org.apache.hbase.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: RefCnt.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information. Recent access records: Created at: org.apache.hadoop.hbase.nio.RefCnt.(RefCnt.java:59) org.apache.hadoop.hbase.nio.RefCnt.create(RefCnt.java:54) org.apache.hadoop.hbase.nio.ByteBuff.wrap(ByteBuff.java:550) org.apache.hadoop.hbase.io.ByteBuffAllocator.allocate(ByteBuffAllocator.java:357) org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.cloneUncompressedBufferWithHeader(HFileBlock.java:1153) org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.getBlockForCaching(HFileBlock.java:1215) org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexWriter.lambda$writeIndexBlocks$0(HFileBlockIndex.java:997) java.base/java.util.Optional.ifPresent(Optional.java:178) org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexWriter.writeIndexBlocks(HFileBlockIndex.java:996) org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.close(HFileWriterImpl.java:635) org.apache.hadoop.hbase.regionserver.StoreFileWriter.close(StoreFileWriter.java:378) org.apache.hadoop.hbase.regionserver.StoreFlusher.finalizeWriter(StoreFlusher.java:69) org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:74) org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:831) org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2033) org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2878) org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2620) org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2592) org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2462) org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:602) org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:572) org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:65) org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:344) {noformat} It turns out that we always convert the block to a ""on-heap"" one, inside LruBlockCache.cacheBlock, so when the index block is a SharedMemHFileBlock, the blockForCaching instance in the code [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java#L1076] becomes eligible for GC without releasing buffers/decreasing refcount (leak), right after we return the BlockIndexWriter.writeIndexBlocks call." Support partial results in AggregateImplementation and AsyncAggregationClient,13588178,Resolved,Major,Fixed,07/Aug/24 16:41,08/Oct/24 14:53,2.6.0,"Currently there is a gap in the coverage of HBase's quota-based workload throttling. Requests sent by {{[Async]AggregationClient}} reach {{AggregateImplementation}}. This then executes Scans in a way that bypasses the quota system. We see issues with this at Hubspot where clusters suffer under this load and we don't have a good way to protect them. In this ticket I'm teaching {{AggregateImplementation}} to optionally stop scanning when a throttle is violated, and send back just the results it has accumulated so far. In addition, it will send back a row key to {{AsyncAggregationClient}}. When the client gets a response with a row key, it will sleep in order to satisfy the throttle, and then send a new request with a scan starting at that row key. This will have the effect of continuing the work where the last request stopped. This feature will be unconditionally enabled by {{AsyncAggregationClient}} once this ticket is finished. {{AggregateImplementation}} will not assume that clients support partial results, however, so it can keep supporting older clients. For clients that do not support partial results, throttles will not be respecting, and results will always be complete. This feature was [first proposed on the mailing list|https://lists.apache.org/thread/1vqnxb71z7swq2cogz4qg3cn6b10xp4v]. Builds on work in HBASE-28346." Missing dependency,13592925,Resolved,Major,Not A Bug,23/Sep/24 09:33,05/Oct/24 12:15,2.6.0,"Hello, I'm using hbase 2.6 with hadoop 3.3.6 and ranger 2.5 and i have the following errors in my logs : {code:java} 2024-09-23T08:12:51.336Z - ERROR [PolicyRefresher(serviceName=hbase-tdp)-196:Errors@168] - The following errors and warnings have been detected with resource and/or provider classes:   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONListElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONRootElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for field: javax.ws.rs.core.UriInfo com.sun.jersey.server.impl.template.ViewableMessageBodyWriter.ui   SEVERE: Missing dependency for field: com.sun.jersey.spi.template.TemplateContext com.sun.jersey.server.impl.template.ViewableMessageBodyWriter.tc   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONListElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JacksonProviderProxy.setFeaturesAndProperties(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 1   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONJAXBElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0   SEVERE: Missing dependency for method public void com.sun.jersey.json.impl.provider.entity.JSONJAXBElementProvider.setConfiguration(com.sun.jersey.core.util.FeaturesAndProperties) at parameter at index 0 {code} Do you have any ideas on how I can resolve that ?" TestRequestAttributes should fail when expected,13592301,Resolved,Major,Fixed,16/Sep/24 22:23,08/Oct/24 13:14,2.0.0,"Problem: The tests in the TestRequestAttributes class pass even when they should fail. I've included an example of a test that should fail but does not below. Fix: Throw an IOException in the AttributesCoprocessor when the map of expected request attributes does not match the map of given request attributes.   Test: We set 2+ request attributes on the Get request but always return 0 request attributes from AttributesCoprocessor::getRequestAttributesForRowKey method. Yet the test passes even though the map of expected request attributes never matches the map of given request attributes. {code:java} @Category({ ClientTests.class, MediumTests.class }) public class TestRequestAttributes { @ClassRule public static final HBaseClassTestRule CLASS_RULE = HBaseClassTestRule.forClass(TestRequestAttributes.class); private static final byte[] ROW_KEY1 = Bytes.toBytes(""1""); private static final Map> ROW_KEY_TO_REQUEST_ATTRIBUTES = new HashMap<>(); static { CONNECTION_ATTRIBUTES.put(""clientId"", Bytes.toBytes(""foo"")); ROW_KEY_TO_REQUEST_ATTRIBUTES.put(ROW_KEY1, addRandomRequestAttributes()); } private static final ExecutorService EXECUTOR_SERVICE = Executors.newFixedThreadPool(100); private static final byte[] FAMILY = Bytes.toBytes(""0""); private static final TableName TABLE_NAME = TableName.valueOf(""testRequestAttributes""); private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil(); private static SingleProcessHBaseCluster cluster; @BeforeClass public static void setUp() throws Exception { cluster = TEST_UTIL.startMiniCluster(1); Table table = TEST_UTIL.createTable(TABLE_NAME, new byte[][] { FAMILY }, 1, HConstants.DEFAULT_BLOCKSIZE, AttributesCoprocessor.class.getName()); table.close(); } @AfterClass public static void afterClass() throws Exception { cluster.close(); TEST_UTIL.shutdownMiniCluster(); } @Test public void testRequestAttributesGet() throws IOException { Configuration conf = TEST_UTIL.getConfiguration(); try ( Connection conn = ConnectionFactory.createConnection(conf, null, AuthUtil.loginClient(conf), CONNECTION_ATTRIBUTES); Table table = configureRequestAttributes(conn.getTableBuilder(TABLE_NAME, EXECUTOR_SERVICE), ROW_KEY_TO_REQUEST_ATTRIBUTES.get(ROW_KEY1)).build()) { table.get(new Get(ROW_KEY1)); } } private static Map addRandomRequestAttributes() { Map requestAttributes = new HashMap<>(); int j = Math.max(2, (int) (10 * Math.random())); for (int i = 0; i < j; i++) { requestAttributes.put(String.valueOf(i), Bytes.toBytes(UUID.randomUUID().toString())); } return requestAttributes; } public static class AttributesCoprocessor implements RegionObserver, RegionCoprocessor { @Override public Optional getRegionObserver() { return Optional.of(this); } @Override public void preGetOp(ObserverContext c, Get get, List result) throws IOException { validateRequestAttributes(getRequestAttributesForRowKey(get.getRow())));   } private Map getRequestAttributesForRowKey(byte[] rowKey) { return Collections.emptyMap(); // This line helps demonstrate the bug } private boolean validateRequestAttributes(Map requestAttributes) { RpcCall rpcCall = RpcServer.getCurrentCall().get(); Map attrs = rpcCall.getRequestAttributes(); if (attrs.size() != requestAttributes.size()) { return; } for (Map.Entry attr : attrs.entrySet()) { if (!requestAttributes.containsKey(attr.getKey())) { return; } if (!Arrays.equals(requestAttributes.get(attr.getKey()), attr.getValue())) { return; } } return; } } } {code}    " Migrate to GitHub Checks API for PR Precommit,13592458,Open,Major,,18/Sep/24 09:01,,,"Our PR pre-commit check is configured to leave comments on the PR with its build results. Especially for our 2.x branches, it is leaving upwards of 4 comments per build. This results in a lot of bot spam, which is distracting from human conversations. I've mitigated the issue via HBASE-28642, but it would be better if the bot didn't leave comments, but instead used the [Checks API|https://docs.github.com/en/rest/checks]. I believe that Yetus is already able to do this, and is configured to do so. I think we need to engage with INFRA to get our auth token adjusted." "Add ""2.6 Documentation"" to the website",13585925,Resolved,Major,Fixed,16/Jul/24 06:58,01/Oct/24 05:38,,We have released 2.6 but the website has not been updated with the new API docs. Bump hbase-thirdparty to 4.1.9,13592963,Resolved,Major,Fixed,23/Sep/24 15:41,30/Sep/24 12:17,, [hbase-thirdparty] Release hbase-thirdparty 4.1.9,13592735,Resolved,Major,Fixed,20/Sep/24 14:52,27/Sep/24 12:03,, [hbase-thirdparty] Finish hbase-thirdparty 4.1.9 release,13592740,Resolved,Major,Fixed,20/Sep/24 15:05,27/Sep/24 12:03,,"Release the artifacts on repository.apache.org Move the binaries from dist-dev to dist-release Push tag 4.1.9RC0 as tag rel/4.1.9 Release thirdparty-4.1.9 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12355077 Add release data on https://reporter.apache.org/addrelease.html?hbase Send announcement email" [hbase-thirdparty] Put up hbase-thirdparty-4.1.9RC0,13592739,Resolved,Major,Fixed,20/Sep/24 15:03,27/Sep/24 11:38,, Web site misses Reference guide for 2.5 and 2.6,13593324,Resolved,Major,Not A Problem,26/Sep/24 09:26,27/Sep/24 08:03,,"2.3 and 2.4 does have the reference guide links in the menu, but 2.5 and 2.6 does not. " apache.hadoop.hbase.DoNotRetryIOException: java.lang.UnsatisfiedLinkError: org-apache.hadoop.util.NativeCodeLoa der.buildSupportsSnappy()Z,13588595,Open,Major,,12/Aug/24 12:59,,2.4.16,".When I create a snappy compression table, it appeared exception: ERROR: org. apache.hadoop.hbase.DoNotRetryIOException: java.lang.UnsatisfiedLinkError: org-apache.hadoop.util.NativeCodeLoa der.buildSupportsSnappy()Z Set hbase.table.sanity.checks to false at conf or table descriptor if you want to bypass sanity checks at org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java: 337） at org.apache.hadoop.hbase.util.TableDescriptorChecker.checkCompression(TableDescriptorChecker-java:304) at org-apache.hadoop.hbase.util.TableDescriptorChecker.sanityCheck(TableDescriptorChecker-java:114) at org. apache.hadoop.hbase.master.HMaster. createrableHMaster-Java: 2094) at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:696) at org.apache.hadoop.hbase.shaded.protobuf-generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos. java) b b b b - b at org.apache.hadoop.hbase. ipc.RpcServer.call(RpcServer.java:387) at org-apache.hadoop.hbase.ipc.CallRunner.run(CallRunner-java:132) at org-apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369) at org-apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349) Caused by: org.apache.hadoop.hbase.DoNotRetryI0Exception: java.lang.UnsatisfiedLinkError: org.apache.hadoop.util.NativeCod eLoader.buildSupportsSnappy()Z at org.apache.hadoop.hbase.util.CompressionTest.testCompression(CompressionTest.java:100) at org.apache.hadoop.hbase.util.TableDescriptorChecker.checkCompression(TableDescriptorChecker.java:300) ... 8 more Caused by: java.lang.UnsatisfiedLinkError: org.apache.hadoop.util.NativeCodeLoader.buildSupportsSnappy()Z   I viewed the hbase documation, which hbase-2.4.16 is compatibled with hadoop 3.3.3 But hadoop 3.3.3 moves to use {{lz4-java}} and {{snappy-java}} instead of requring the native libraries of these to be installed on the systems running Hadoop.So i packaged hbase-2.4.16 by mvn {-}P hadoop{-}3.0, it still can not create snappy table.The problem is same as above. When I changed hadoop dependecy to hadoop-3.3.3.,the problem was fixed." "Backport ""HBASE-20653 Add missing observer hooks for region server group to MasterObserver"" to branch-2",13592694,Resolved,Major,Fixed,20/Sep/24 09:02,24/Sep/24 16:47,2.5.10,"Currently the following region server group operations don't have corresponding hook in MasterObserver : * getRSGroupInfo * getRSGroupInfoOfServer * getRSGroupInfoOfTable * listRSGroup This JIRA is to * add them to MasterObserver * add pre/post hook calls in RSGroupAdminEndpoint thru master.getMasterCoprocessorHost for the above operations * add corresponding tests to TestRSGroups (in similar manner to that of HBASE-20627)" New version of Region#getRowLock with timeout,13589371,Open,Major,,19/Aug/24 22:01,,2.6.0,"Region APIs are LimitedPrivate for Coprocs. One of the APIs provided by HBase for Coproc use is to acquire row level read/write lock(s): {code:java} /** * Get a row lock for the specified row. All locks are reentrant. Before calling this function * make sure that a region operation has already been started (the calling thread has already * acquired the region-close-guard lock). *

* The obtained locks should be released after use by {@link RowLock#release()} *

* NOTE: the boolean passed here has changed. It used to be a boolean that stated whether or not * to wait on the lock. Now it is whether it an exclusive lock is requested. * @param row The row actions will be performed against * @param readLock is the lock reader or writer. True indicates that a non-exclusive lock is * requested * @see #startRegionOperation() * @see #startRegionOperation(Operation) */ RowLock getRowLock(byte[] row, boolean readLock) throws IOException; {code} The implementation by default uses config ""hbase.rowlock.wait.duration"" as row level lock timeout for both read and write locks. The default value is quite high (~30s). While updating the cluster level row lock timeout might not be worth for all use cases, having new API that takes timeout param would be really helpful for critical latency sensitive Coproc APIs.   The new signature should be: {code:java} RowLock getRowLock(byte[] row, boolean readLock, int timeout) throws IOException; {code}" Use CompletableFuture instead of fixed sleep during the move operation at master ,13592145,Patch Available,Major,,14/Sep/24 06:45,,,"During move operation master submits the RegionTransitionProcedure and waits for the completion of this procedure, current wait mechanism is based on fixed sleep intervals of 1 second.  The procedure could have finished earlier than this 1 second sleep.. optimize this by using CompletableFuture and return after the completion of TRSP procedure." "The description of ""hbase.superuser"" is confusing",13591155,Resolved,Major,Fixed,05/Sep/24 11:52,22/Sep/24 14:17,,"With ""hbase.superuser"" configuration, you can also set groups. However, it should be prefixed with ""@"" but there are no such explanation." [hbase-thirdparty] Bump dependency versions before releasing,13592736,Resolved,Major,Fixed,20/Sep/24 14:53,23/Sep/24 15:16,, [hbase-thirdparty] Bump protobuf java to 4.27.5+,13592733,Resolved,Major,Fixed,20/Sep/24 14:45,23/Sep/24 15:16,,For addressing CVE-2024-7254 Implement chunked persistence of backing map for persistent bucket cache.,13590409,Resolved,Major,Fixed,29/Aug/24 07:47,09/Sep/24 11:55,2.6.0,"The persistent bucket cache implementation feature relies on the persistence of backing map to a persistent file. the protobuf APIs are used to serialise the backing map and its related structures into the file. An asynchronous thread periodically flushes the contents of backing map to the persistence file. The protobuf library has a limitation of 2GB on the size of protobuf messages. If the size of backing map increases beyond 2GB, an unexpected exception is reported in the asynchronous thread and stops the persister thread. This causes the persistent file go out of sync with the actual bucket cache. Due to this, the bucket cache shrinks to a smaller size after a cache restart. Checksum errors are also reported. This Jira tracks the implementation of introducing chunking of the backing map to persistence such that every protobuf is smaller than 2GB in size. Thanks, Janardhan" Introduce Cache for SFT instances created via StoreFileTrackerFactory,13592944,Open,Major,,23/Sep/24 13:15,,,"As part of HBASE-28564 the creation of HStoreFile is made SFT aware and anytime a store file is created, it need SFT instance. Now with this all the interaction of HStorefiles need SFT instance. In case of FileBasedStoreFileTracker, each instance of it loads the backed .filelist file and this can be a costly operation in S3 This Jira targets to introduce a cache layer at StoreFileTrackerFactory for SFT instances  per each _TableName + Region + CF + Mode_ (Write/ReadOnly mode of SFT) More detailed thought process around the same [here|https://github.com/apache/hbase/pull/5939#discussion_r1759312918] {code:java} Every time we create a StoreFileTracker object it will have no state, and so it will either need to go to the filesystem and list the directory or read the tracker file depending on which type it is in order to initialize as soon as we try to use it. It's fine... because the original code causes IO to happen also.. however, What do you think about the possibility of reuse? This is a more general question than a comment about this particular call site. Should the StoreFileTrackerFactory cache instances and return the cached instances that match the arguments to StoreFileTrackerFactory.create() rather than make a new instance? Can StoreFileTracker instances be made thread safe so they can be cached and shared? If we have reuse, and all the relevant filesystem ops go through the StoreFileTracker, then we could potentially save a lot of filesystem or object store IO, because a reused StoreFileTracker would have the ground truth already and would not need to go to the filesystem or object store and do IO in order to e.g. return the StoreFileInfo of a given path. {code} ----  " CanaryTool: Create canary tables in different RSgroup and write sniff when rsgroup is enabled,13591282,Open,Major,,06/Sep/24 09:34,,,"Now, when canary enables write sniff, the created canary table defaults to the default group. But when our cluster has other RSGroups, we cannot perform write sniff for other RSGroups." Remove the IA.Private annotation on WALEdit's add methods as they have already been used by CP users,13585852,Resolved,Major,Fixed,15/Jul/24 14:01,20/Sep/24 15:18,,"Per the discussion thread here https://lists.apache.org/thread/b7zfyqmxo9lrt2rpo0lc0m6vsomn217w" HFile.Reader#readAtOffset is not thread safe when not using preads,13592738,Open,Major,,20/Sep/24 14:59,,2.5.5,"When not using preads, multiple threads may call readAtOffset from multiple scanners in a concurrent way which may lead to another seek being called before the actual read." Optimise memory utilisation retrieval of bucket-cache from persistence.,13592204,Resolved,Major,Fixed,16/Sep/24 05:52,19/Sep/24 10:51,2.7.0,"During the persistence of bucket-cache backing map to a file, the backing map is divided into multiple smaller chunks and persisted to the file. This chunking avoids the high memory utilisation of during persistence, since only a small subset of backing map entries need to persisted in one chunk. However, during the retrieval of the backing map during the server startup, we accumulate all these chunks into a list and then process each chunk to recreate the in-memory backing map. Since, all the chunks are fetched from the persistence file and then processed, the memory requirement is higher. The retrieval of bucket-cache from persistence file can be optimised to enable the processing of one chunk at a time to avoid high memory utilisation. Thanks, Janardhan " Optimise bucket cache persistence by reusing backmap entry object.,13591313,Resolved,Major,Fixed,06/Sep/24 13:58,19/Sep/24 10:29,3.0.0-beta-2,"During the persistence of backing map entries into the backing map file, we create a new BackingMapEntry.Builder for each entry in the backing map. This can be optimised by using a single BackingMapEntry.Builder object and using it to build each entry during serialisation. This Jira tracks the optimisation by avoiding multiple builder objects. Thanks, Janardhan" Support for RS group endpoints in HBase REST,13592337,Open,Major,,17/Sep/24 10:10,,,"*Description:* Currently, the HBase REST server does not support endpoints for region server grouping. This feature request is to add new endpoints that will allow users to interact with and manage region server groups through the HBase REST API. *Goals:* # Expose endpoints to create, list, update, and delete region server groups along with other APIs as necessary, supported by Java client # Ensure endpoints support necessary authentication and authorization. # Provide appropriate error handling and logging for the new endpoints. *Acceptance Criteria:* # New endpoints for region server grouping are added to the HBase REST server. # Endpoints are thoroughly documented. # Unit and integration tests are created and passing. If there is no IT for existing features also, share manual test details. *Technical Details:* * New endpoints should follow RESTful principles. * Authentication/authorization mechanisms must be consistent with existing endpoints. * Ensure compatibility with existing HBase version and REST server. *For contributors looking to make a contribution here, please use following for quickstart:* * You can refer relevant code at [https://github.com/apache/hbase/tree/master/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest] * You can refer documentation of existing endpoints at [https://hbase.apache.org/book.html#_rest] and design new endpoints in-line with current standards * Build HBase code locally. Follow [https://hbase.apache.org/book.html#_build_a_tarball] * Start a localhost rest server. Follow [https://hbase.apache.org/book.html#_starting_and_stopping_the_rest_server] * Also feel free to use a starter REST postman collection at [https://gist.github.com/NihalJain/7db91823bd140e41953a88eb3df56eae]" Upgrade from 1.7.2 to 2.6.0 failed: HMaster aborted,13591050,Open,Major,,04/Sep/24 18:45,,2.5.0,"I am trying to migrate from 1.7.2 cluster to 2.6.0 (both are released versions). However, I observed that the hmaster crashed during the upgrade process. h1. Reproduce Step1: Start up 1.7.2 HBase cluster (1 HDFS, 1 HM, 1 RS). Step2: Stop the 1.7.2 HBase cluster. Step3: Upgrade to 2.6.0 HBase cluster. HMaster will crash with the following exception {code:java} 2024-09-04T16:04:47,004 WARN  [PEWorker-2] procedure.InitMetaProcedure: Failed to init meta, suspend 1000secs java.io.IOException: Meta table is not partial, please sideline this meta directory or run HBCK to fix this meta table, e.g. rebuild the server hostname in ZNode for the meta region         at org.apache.hadoop.hbase.master.procedure.InitMetaProcedure.deleteMetaTableDirectoryIfPartial(InitMetaProcedure.java:199) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.procedure.InitMetaProcedure.writeFsLayout(InitMetaProcedure.java:78) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.procedure.InitMetaProcedure.executeFromState(InitMetaProcedure.java:102) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.procedure.InitMetaProcedure.executeFromState(InitMetaProcedure.java:54) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:944) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1766) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1444) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:77) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:2092) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[hbase-common-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2119) ~[hbase-procedure-2.6.0.jar:2.6.0] 2024-09-04T16:04:47,005 INFO  [PEWorker-2] procedure2.TimeoutExecutorThread: ADDED pid=1, state=WAITING_TIMEOUT:INIT_META_WRITE_FS_LAYOUT, locked=true; InitMetaProcedure table=hbase:meta; timeout=1000, timestamp=1725465888005 2024-09-04T16:04:48,045 ERROR [PEWorker-1] procedure2.ProcedureExecutor: Root Procedure pid=1, state=FAILED:INIT_META_WRITE_FS_LAYOUT, exception=org.apache.hadoop.hbase.exceptions.TimeoutIOException via ProcedureExecutor:org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec; InitMetaProcedure table=hbase:meta does not support rollback but the execution failed and try to rollback, code bug? org.apache.hadoop.hbase.procedure2.RemoteProcedureException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec         at org.apache.hadoop.hbase.procedure2.Procedure.setFailure(Procedure.java:768) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.Procedure.setTimeoutFailure(Procedure.java:797) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.executeTimedoutProcedure(TimeoutExecutorThread.java:131) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.execDelayedProcedure(TimeoutExecutorThread.java:109) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.run(TimeoutExecutorThread.java:68) ~[hbase-procedure-2.6.0.jar:2.6.0] Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec         at org.apache.hadoop.hbase.procedure2.Procedure.setTimeoutFailure(Procedure.java:798) ~[hbase-procedure-2.6.0.jar:2.6.0]         ... 3 more 2024-09-04T16:04:48,058 INFO  [PEWorker-1] procedure2.ProcedureExecutor: Rolled back pid=1, state=ROLLEDBACK, exception=org.apache.hadoop.hbase.exceptions.TimeoutIOException via ProcedureExecutor:org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec; InitMetaProcedure table=hbase:meta exec-time=1.4160 sec 2024-09-04T16:04:48,059 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.io.IOException: Failed to initialize meta table         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1077) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2459) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.HMaster.lambda$null$0(HMaster.java:590) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) ~[hbase-common-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177) ~[hbase-common-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$1(HMaster.java:587) ~[hbase-server-2.6.0.jar:2.6.0]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] Caused by: org.apache.hadoop.hbase.procedure2.RemoteProcedureException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec         at org.apache.hadoop.hbase.procedure2.Procedure.setFailure(Procedure.java:768) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.Procedure.setTimeoutFailure(Procedure.java:797) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.executeTimedoutProcedure(TimeoutExecutorThread.java:131) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.execDelayedProcedure(TimeoutExecutorThread.java:109) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.run(TimeoutExecutorThread.java:68) ~[hbase-procedure-2.6.0.jar:2.6.0] Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec         at org.apache.hadoop.hbase.procedure2.Procedure.setTimeoutFailure(Procedure.java:798) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.executeTimedoutProcedure(TimeoutExecutorThread.java:131) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.execDelayedProcedure(TimeoutExecutorThread.java:109) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.run(TimeoutExecutorThread.java:68) ~[hbase-procedure-2.6.0.jar:2.6.0] 2024-09-04T16:04:48,060 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [org.apache.hadoop.hbase.quotas.MasterQuotasObserver] 2024-09-04T16:04:48,060 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master hmaster,16000,1725465872458: Unhandled exception. Starting shutdown. ***** java.io.IOException: Failed to initialize meta table         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1077) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2459) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.HMaster.lambda$null$0(HMaster.java:590) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) ~[hbase-common-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177) ~[hbase-common-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$1(HMaster.java:587) ~[hbase-server-2.6.0.jar:2.6.0]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] Caused by: org.apache.hadoop.hbase.procedure2.RemoteProcedureException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec         at org.apache.hadoop.hbase.procedure2.Procedure.setFailure(Procedure.java:768) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.Procedure.setTimeoutFailure(Procedure.java:797) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.executeTimedoutProcedure(TimeoutExecutorThread.java:131) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.execDelayedProcedure(TimeoutExecutorThread.java:109) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.run(TimeoutExecutorThread.java:68) ~[hbase-procedure-2.6.0.jar:2.6.0] Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec         at org.apache.hadoop.hbase.procedure2.Procedure.setTimeoutFailure(Procedure.java:798) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.executeTimedoutProcedure(TimeoutExecutorThread.java:131) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.execDelayedProcedure(TimeoutExecutorThread.java:109) ~[hbase-procedure-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.procedure2.TimeoutExecutorThread.run(TimeoutExecutorThread.java:68) ~[hbase-procedure-2.6.0.jar:2.6.0] 2024-09-04T16:04:48,065 INFO  [master/hmaster:16000:becomeActiveMaster] regionserver.HRegionServer: ***** STOPPING region server 'hmaster,16000,1725465872458' ***** 2024-09-04T16:04:48,065 INFO  [master/hmaster:16000:becomeActiveMaster] regionserver.HRegionServer: STOPPED: Stopped by master/hmaster:16000:becomeActiveMaster 2024-09-04T16:04:48,067 INFO  [master/hmaster:16000] regionserver.HRegionServer: Stopping infoServer 2024-09-04T16:04:48,169 INFO  [master/hmaster:16000] handler.ContextHandler: Stopped o.a.h.t.o.e.j.w.WebAppContext@78483404{master,/,null,STOPPED}{file:/hbase/hbase-2.6.0/hbase-webapps/master} 2024-09-04T16:04:48,180 INFO  [master/hmaster:16000] server.AbstractConnector: Stopped ServerConnector@3a7ba368{HTTP/1.1, (http/1.1)}{0.0.0.0:16010} 2024-09-04T16:04:48,180 INFO  [master/hmaster:16000] server.session: node0 Stopped scavenging 2024-09-04T16:04:48,182 INFO  [master/hmaster:16000] handler.ContextHandler: Stopped o.a.h.t.o.e.j.s.ServletContextHandler@b525e3a{static,/static,file:///hbase/hbase-2.6.0/hbase-webapps/static/,STOPPED} 2024-09-04T16:04:48,183 INFO  [master/hmaster:16000] handler.ContextHandler: Stopped o.a.h.t.o.e.j.s.ServletContextHandler@294e4c35{logs,/logs,file:///var/log/hbase/,STOPPED} 2024-09-04T16:04:48,188 INFO  [master/hmaster:16000] regionserver.HRegionServer: aborting server hmaster,16000,1725465872458 2024-09-04T16:04:48,190 INFO  [master/hmaster:16000] regionserver.HRegionServer: stopping server hmaster,16000,1725465872458; all regions closed. 2024-09-04T16:04:48,191 WARN  [OldWALsCleaner-1] cleaner.LogCleaner: Interrupted while cleaning old WALs, will try to clean it next round. Exiting. 2024-09-04T16:04:48,191 WARN  [OldWALsCleaner-0] cleaner.LogCleaner: Interrupted while cleaning old WALs, will try to clean it next round. Exiting. 2024-09-04T16:04:48,194 INFO  [master/hmaster:16000] hbase.ChoreService: Chore service for: master/hmaster:16000 had [] on shutdown 2024-09-04T16:04:48,196 INFO  [master/hmaster:16000] procedure2.RemoteProcedureDispatcher: Stopping procedure remote dispatcher 2024-09-04T16:04:48,196 INFO  [master/hmaster:16000] procedure2.ProcedureExecutor: Stopping 2024-09-04T16:04:48,205 INFO  [master/hmaster:16000] region.RegionProcedureStore: Stopping the Region Procedure Store, isAbort=true 2024-09-04T16:04:48,208 WARN  [master/hmaster:16000] master.ActiveMasterManager: Failed get of master address: java.io.IOException: Can't get master address from ZooKeeper; znode data == null 2024-09-04T16:04:48,208 INFO  [master/hmaster:16000] assignment.AssignmentManager: Stopping assignment manager 2024-09-04T16:04:48,209 INFO  [master/hmaster:16000] region.MasterRegion: Closing local region {ENCODED => 1595e783b53d99cd5eef43b6debb2682, NAME => 'master:store,,1.1595e783b53d99cd5eef43b6debb2682.', STARTKEY => '', ENDKEY => ''}, isAbort=true 2024-09-04T16:04:48,369 INFO  [master/hmaster:16000] regionserver.HRegion: Closing region master:store,,1.1595e783b53d99cd5eef43b6debb2682. 2024-09-04T16:04:48,373 ERROR [master/hmaster:16000] regionserver.HRegion: Memstore data size is 2190 in region master:store,,1.1595e783b53d99cd5eef43b6debb2682. 2024-09-04T16:04:48,374 INFO  [master/hmaster:16000] regionserver.HRegion: Closed master:store,,1.1595e783b53d99cd5eef43b6debb2682. 2024-09-04T16:04:48,374 INFO  [master/hmaster:16000] flush.MasterFlushTableProcedureManager: stop: server shutting down. 2024-09-04T16:04:48,374 INFO  [master:store-WAL-Roller] wal.AbstractWALRoller: LogRoller exiting. 2024-09-04T16:04:48,376 INFO  [master/hmaster:16000] ipc.NettyRpcServer: Stopping server on /192.168.227.2:16000 2024-09-04T16:04:48,511 INFO  [master/hmaster:16000] zookeeper.ZooKeeper: Session: 0x10009e5081e0000 closed 2024-09-04T16:04:48,511 INFO  [main-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x10009e5081e0000 2024-09-04T16:04:48,511 INFO  [master/hmaster:16000] regionserver.HRegionServer: Exiting; stopping=hmaster,16000,1725465872458; zookeeper connection closed. 2024-09-04T16:04:48,512 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: HMaster Aborted         at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:255) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:147) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) ~[hadoop-common-2.10.2.jar:?]         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:140) ~[hbase-server-2.6.0.jar:2.6.0] {code}   Upgrade from 1.7.2 to 2.4.18 can still succeed. I am wondering whether this is a backward incompatibility or if there are any additional steps I missed to upgrade to 2.6.0." Upgrade from 2.6.0 to 3.0.0 crashed,13590958,Resolved,Major,Fixed,04/Sep/24 05:22,16/Sep/24 14:11,3.0.0,"I am trying to upgrade from 2.6.0 (stable release) to 3.0.0. I built 3.0.0 using the following commit (a030e8099840e640684a68b6e4a79e7c1d5a6823) {code:java} commit a030e8099840e640684a68b6e4a79e7c1d5a6823 (HEAD -> branch-3, upstream/branch-3) Author: Ray Mattingly Date:   Mon Sep 2 04:38:29 2024 -0400    HBASE-28697 Don't clean bulk load system entries until backup is complete (#6089)          Co-authored-by: Ray Mattingly {code} However, the HMaster would crash during the upgrade process. h1. Reproduce Step1: Start up 2.6.0 cluster (1 HDFS, 1 HM, 1 RS) Step2: Stop the entire cluster Step3: Upgrade to 3.0.0 cluster. HMaster will crash with the following error message {code:java} 2024-09-04T04:29:18,917 WARN  [master/hmaster:16000:becomeActiveMaster] regionserver.HRegion: Failed initialize of region= master:store,,1.1595e783b53d99cd5eef43b6debb2682., starting to roll back memstore java.io.IOException: java.io.IOException: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading HFile Trailer from file hdfs://master:8020/hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682/info/82c6d244b6244c179cdbafcead00ed75         at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1215) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1158) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1030) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:974) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7794) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7749) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.region.MasterRegion.open(MasterRegion.java:277) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:432) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:135) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1003) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2524) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.io.IOException: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading HFile Trailer from file hdfs://master:8020/hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682/info/82c6d244b6244c179cdbafcead00ed75         at org.apache.hadoop.hbase.regionserver.StoreEngine.openStoreFiles(StoreEngine.java:289) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.initialize(StoreEngine.java:339) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:301) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6924) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1181) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1178) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]         ... 1 more Caused by: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading HFile Trailer from file hdfs://master:8020/hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682/info/82c6d244b6244c179cdbafcead00ed75         at org.apache.hadoop.hbase.io.hfile.HFileInfo.initTrailerAndContext(HFileInfo.java:359) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.HFileInfo.(HFileInfo.java:132) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.initHFileInfo(StoreFileInfo.java:763) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.open(HStoreFile.java:395) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.initReader(HStoreFile.java:524) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.createStoreFileAndReader(StoreEngine.java:226) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.lambda$openStoreFiles$0(StoreEngine.java:267) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]         ... 1 more Caused by: java.io.IOException: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.KeyValue$KVComparator         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.getComparatorClass(FixedFileTrailer.java:578) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.deserializeFromPB(FixedFileTrailer.java:304) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.deserialize(FixedFileTrailer.java:250) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.readFromStream(FixedFileTrailer.java:407) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.HFileInfo.initTrailerAndContext(HFileInfo.java:349) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.HFileInfo.(HFileInfo.java:132) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.initHFileInfo(StoreFileInfo.java:763) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.open(HStoreFile.java:395) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.initReader(HStoreFile.java:524) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.createStoreFileAndReader(StoreEngine.java:226) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.lambda$openStoreFiles$0(StoreEngine.java:267) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]         ... 1 more Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.KeyValue$KVComparator         at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?]         at jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188) ~[?:?]         at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]         at java.lang.Class.forName0(Native Method) ~[?:?]         at java.lang.Class.forName(Class.java:375) ~[?:?]         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.getComparatorClass(FixedFileTrailer.java:576) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.deserializeFromPB(FixedFileTrailer.java:304) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.deserialize(FixedFileTrailer.java:250) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.readFromStream(FixedFileTrailer.java:407) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.HFileInfo.initTrailerAndContext(HFileInfo.java:349) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.io.hfile.HFileInfo.(HFileInfo.java:132) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.initHFileInfo(StoreFileInfo.java:763) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.open(HStoreFile.java:395) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.initReader(HStoreFile.java:524) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.createStoreFileAndReader(StoreEngine.java:226) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.lambda$openStoreFiles$0(StoreEngine.java:267) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]         ... 1 more {code} This problem seems to be introduced recently, and I can still upgrade from 2.6.0 to 3.0.0 using the previous commits (E.g. commit from May 24: 516c89e8597fb6ed391f9e85e594f8b7e5b56e38).  I have attached the hmaster log." BucketCache.notifyFileCachingCompleted may throw IllegalMonitorStateException ,13585481,Resolved,Major,Fixed,11/Jul/24 15:37,22/Jul/24 15:01,2.6.0,"If the prefetch thread completes reading the file blocks faster than the bucket cache writer threads are able to drain it from the writer queues, we might run into a scenario where BucketCache.notifyFileCachingCompleted may throw IllegalMonitorStateException, as we can reach [this block of the code|https://github.com/wchevreuil/hbase/blob/684964f1c1693d2a0792b7b721c92693d75b4cea/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java#L2106]. I believe the impact is not critical, as the prefetch thread is already finishing at that point, but nevertheless, such error in the logs might be misleading." Add deprecation cycle for methods in TokenUtil,13591410,Resolved,Major,Fixed,08/Sep/24 13:07,14/Sep/24 01:39,, Add deprecation cycle for methods in RegionServerObserver,13591409,Resolved,Major,Fixed,08/Sep/24 13:06,13/Sep/24 02:31,, "Improve BackupLogCleaner naming, debug logging",13590908,Resolved,Major,Fixed,03/Sep/24 19:08,09/Sep/24 12:21,2.6.0,"While implementing HBase's incremental backups across a few hundred clusters, we continue to step on some rakes. Now and again, we find old WALs piling up due to a poorly cleaned up BackupInfo, or a bug in the BackupLogCleaner, etc. The BackupLogCleaner is difficult to debug for a couple of reasons: # It has a lack of useful debug logging # It has [a misleadingly named method|https://github.com/HubSpot/hbase/blob/2d08fa67dfe9458260bc0be3ebc7bbd769850190/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java#L83-L83] (this method returns the newest backup ts, not the oldest) I'm going to introduce a small refactor that will alleviate these pain points." Implement asynchronous retrieval of bucket-cache data from persistence.,13590326,Resolved,Major,Fixed,28/Aug/24 14:01,11/Sep/24 10:43,2.6.0,"    During the retrieval of data from bucket cache persistence file, a transient structure that stores the blocks ordered by filename is constructed from the backing map entries. The  population of this transient structure is done during the server start-up. This process increases the region-server startup time, if the bucketcache has large number of blocks. This population happens inline with the server restart and blocks the server for several minutes. This makes the server restart inconvenient for the external users. Restarts during upgrade can run into timeout issues due to this delay in the server startup.  Hence, the recommendation in this Jira is to make the cache-retrieval asynchronous to the server startup. During a server startup, a new thread is spawn that reads the persistence file and creates the required structures from persistence file. The server continues with the restart and does not wait for the bucket-cache initialisation to complete.    Note that the bucket cache is not available immediately for usage and will only be ready to use after the data is repopulated from persistence into memory. Thanks, Janardhan" Use thirdparty protobuf for REST interface in HBase 2.x,13585493,Resolved,Major,Fixed,11/Jul/24 18:08,11/Sep/24 09:48,2.5.9,"This change has already been done in branch 3+ as part of the protobuf 2.5 removal, We just need to backport it to 2.x. This removes the requirement of having unshaded protobuf 2.5.0 on the hbase-rest client classpath. " Change the LOG field in TableSplit to private,13591407,Resolved,Major,Fixed,08/Sep/24 13:01,11/Sep/24 08:10,, Change the LOG field in CodecPerformance to private,13591406,Resolved,Major,Fixed,08/Sep/24 12:59,11/Sep/24 08:09,, Increment Inconsistency in Replication,13591605,Open,Major,,10/Sep/24 07:18,,,"*Issue:* Consistency is not achieved for Increment operation in replication. *Setup:* Lets have two HBase clusters 'cluster1' and 'cluster2' and both are added as peers to each other in them and both have replication enabled. There is a counter cell with initial value '2' in a table. There is a replication delay from 'cluster1' to 'cluster2'. *Actions:* 1. Perform increment in 'cluster1' with 1. 2. Perform increment in 'cluster2' with 2. *Expected Behaviour:* The value in the counter cell should be 5. *Actual Behaviour:* The value in the counter cell is 4. *Analysis:* 1. After increment in 'cluster1', the value became 2 in 'cluster1'. 2. The replication from 'cluster1' to 'cluster2' gets initiated. 3. But there is a replication delay from 'cluster1' to 'cluster2' and within that timeframe, increment in 'cluster2' performed. 4. Now the value is 4 in 'cluster2' and it got replicated to 'cluster1'. 5. Since the replication is cell-based, not operation based and the 'cluster2' increment is the latest, value 4 from 'cluster2' overrides value 3 in 'cluster1'. *Steps to reproduce:* Add a coprocessor in 'cluster2' with 'Thread.sleep' in 'preWALAppend' to simulate replication delay. *Inference:* During debugging, it was discovered that the replication is cell-based, meaning the entire cell is being replicated rather than the specific operation being performed. This method works for other operations such as put and delete operations because it resolves the inconsistency problem by utilising the timestamp and version of the cell. However, for increment operations, which rely on the cell's previous value, this method is not successful." TableSkew cost scales beyond 1,13591294,Open,Major,,06/Sep/24 11:20,,2.5.7,"This may already be covered by later releases, but we noticed that the table skew cost function can produce cost values beyond 1. In our case with over 1000 tables caused the table skew cost to suppress the region count skew (and other) cost functions. I think this is because the cost per table are 'simply' summed in TableSkewCostFunction#cost. So if the number of tables with skew is large, this cost function may cause the balancer to favour actions that decrease this cost at to big of an expense of other costs such as region count skew. Logging from the HBase master that shows this: {code:java} [...] balancer.StochasticLoadBalancer: dBalancer.balancer, initial weighted average imbalance=0.25500371101846336, functionCost=RegionCountSkewCostFunction : (multiplier=100000.0, imbalance=0.24272066309658274, need balance); PrimaryRegionCountSkewCostFunction : (not needed); MoveCostFunction : (multiplier=7.0, imbalance=0.0); ServerLocalityCostFunction : (multiplier=25.0, imbalance=0.6022498608833904, need balance); RackLocalityCostFunction : (multiplier=15.0, imbalance=0.0); TableSkewCostFunction : (multiplier=35.0, imbalance=35.24784226006047, need balance); RegionReplicaHostCostFunction : (not needed); RegionReplicaRackCostFunction : (not needed); ReadRequestCostFunction : (multiplier=5.0, imbalance=0.24057323733439073, need balance); WriteRequestCostFunction : (multiplier=5.0, imbalance=0.3233739875438904, need balance); MemStoreSizeCostFunction : (multiplier=5.0, imbalance=0.3195880383071082, need balance); StoreFileCostFunction : (multiplier=5.0, imbalance=0.23335375436276784, need balance);  computedMaxSteps=1000000 {code} Note the {{TableSkewCostFunction : (multiplier=35.0, imbalance=35.24784226006047)}} part. In order to work-around this we temporarily reduced the multiplier of the table skew cost function to 0. The test case below fails on HBase the 2.5 and 2.6 branches. It simply assigns two tables with two regions each to a single server. {code:java} @Test public void testTableSkewCost() { TableName t1 = TableName.valueOf(""t1""); TableName t2 = TableName.valueOf(""t2""); TreeMap> clusterState = new TreeMap<>(); clusterState.put(ServerName.valueOf(""n1"", 16020,0), Arrays.asList( RegionInfoBuilder.newBuilder(t1).setRegionId(11).build(), RegionInfoBuilder.newBuilder(t1).setRegionId(12).build() )); clusterState.put(ServerName.valueOf(""n2"", 16020,0), Arrays.asList( RegionInfoBuilder.newBuilder(t2).setRegionId(21).build(), RegionInfoBuilder.newBuilder(t2).setRegionId(22).build() )); BalancerClusterState cluster = new BalancerClusterState(clusterState, null, null, null); Configuration conf = HBaseConfiguration.create(); CostFunction costFunction = new TableSkewCostFunction(conf); costFunction.prepare(cluster); double cost = costFunction.cost(); assertTrue(cost >= 0); assertTrue(cost <= 1.01); } {code}   It's the second assertion that fails since the computed cost for this cluster state is 2. I guess none of the existing cluster state test/mock configurations have a real table skew." Logging Enhancement on Configuration Setting in RpcConnection,13591246,Open,Major,,06/Sep/24 03:00,,3.0.0-beta-1,"The original implementation of the {{getConnectionHeader()}} method in {{RpcConnection}} does not include detailed logging regarding the configuration of the Crypto AES feature. This lack of logging can lead to several issues: # *Undetected Crypto AES Configuration:* If Crypto AES is enabled or disabled without proper logging, administrators may not be aware of the active encryption settings. This can lead to a misconfigured environment where sensitive data is not properly secured, or unnecessary resources are consumed by enabling encryption when it's not required. # *Troubleshooting Challenges:* Without logs that clearly indicate whether Crypto AES is enabled or disabled, diagnosing issues related to encrypted communication becomes significantly harder. In the event of a communication failure or performance issue, the lack of logs may hinder root cause analysis, delaying resolution. # *Unintended Configuration Behavior:* If the configuration is altered or misconfigured (e.g., Crypto AES is inadvertently disabled), the absence of logs makes it difficult to confirm that the system is operating as intended. This could lead to security vulnerabilities or unexpected behavior that goes unnoticed.   *Expected Behavior:* Enhanced logging should provide clear insights into the configuration state of Crypto AES during the establishment of the connection header: * If Crypto AES is enabled, the system should log the setup of the Cipher transformation, including the key and default value. * If Crypto AES is disabled, the system should log this state, ensuring that the administrator is aware and that this is the intended configuration.   *How-to-Fix:* To address these issues, the code can be enhanced by inserting specific log statements that capture the state of the Crypto AES configuration. These logs should be added right before the Cipher transformation is set up or bypassed, ensuring that the configuration's impact on the system is well-documented." Enhancing Logging for Connection Implementation in ConnectionFactory,13591245,Open,Major,,06/Sep/24 02:59,,3.0.0-beta-1,"The system lacks visibility into the specific connection implementation being used during the creation of a connection. This can lead to issues when troubleshooting connection-related problems, particularly when a custom connection implementation is specified. If the configuration is incorrect or the custom class is inaccessible, it is difficult to diagnose the issue without detailed logs. As a result, users may encounter unexpected behavior without a clear understanding of what went wrong, making it challenging to identify and resolve configuration or implementation errors.   *Expected Behavior:* The system should log detailed information about the connection implementation being used or attempted during the creation of a connection. If a custom connection class is specified, the system should log the attempt and the outcome, including any errors encountered. If the default implementation is used, this should also be logged.   *How-to-Fix:* To address this issue, we propose introducing logging in the {{createConnection}} method of the {{ConnectionFactory}} class. The logs will provide clear feedback about whether the default asynchronous connection implementation ({{{}ConnectionOverAsyncConnection{}}}) is used or if a custom implementation is specified. Additionally, if a custom connection implementation fails due to an inaccessible or misconfigured class, detailed error logs will be generated. This enhancement will significantly improve the ability to diagnose and resolve connection-related issues, ensuring that any configuration or implementation errors are promptly identified and addressed." AsyncTableImpl should call coprocessor callbacks in a defined order,13589172,Resolved,Major,Fixed,17/Aug/24 14:44,04/Sep/24 11:01,,"To call a coprocessor endpoint asynchronously, you start by calling {{AsyncTable#coprocessorService()}}, which gives you a {{CoprocessorServiceBuilder}}, and a few steps later you can talk to your coprocessor over the network. One argument to {{AsyncTable#coprocessorService()}} is a {{CoprocessorCallback}} object, which contains several methods that will be called during the lifecycle of a coprocessor endpoint call. {{AsyncTableImpl}}'s implementation of {{AsyncTable#coprocessorService()}} wraps your {{CoprocessorCallback}} with its own that delegates the work to a thread pool. A snippet of this: {code} @Override public void onRegionComplete(RegionInfo region, R resp) { pool.execute(context.wrap(() -> callback.onRegionComplete(region, resp))); } ... @Override public void onComplete() { pool.execute(context.wrap(callback::onComplete)); } {code} The trouble with this is that your implementations of {{onRegionComplete()}} and {{onComplete()}} will end up getting called in a random order, and/or at the same time. The tasks of calling them are delegated to a thread pool, and the completion of those tasks is not waited on, so the thread pool can choose any ordering it wants to. Troublingly, {{onComplete()}} can be called before the final {{onRegionComplete()}}, which is an violation of [the contract specified in the {{CoprocessorCallback#onComplete()}} javadoc|https://github.com/apache/hbase/blob/41dd87cd908d4d089d0b8cff6c88c01ed60622c5/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java#L671]. I discovered this while working on HBASE-28770. I found that {{AsyncAggregationClient#rowCount()}} returns incorrect results 5-10% of the time, and this bug is the reason. Other {{AsyncAggregationClient}} methods I presume are similarly affected." Update hbase-thirdparty to 4.1.8,13589181,Resolved,Major,Fixed,17/Aug/24 18:47,03/Sep/24 04:50,, Client always send flush requests twice when flush procedure is disabled,13590728,Open,Major,,02/Sep/24 12:32,,2.6.0,"When hbase disable flush procedure at server side, whether flush procedure is diabled or not at clien side, client always sends flush requests twice. In current hbase, There are four situations about flush request: 1. Both server and client enables flush Procedure, Client only sends a flush request by flush procedure. 2. Server disabled flush procedure and client enables flush procedurce, Client sends a flush request by flush procedure, after failure ,it will sends a flush request by old flush implementation 3. Server enables flush procedure and client disables flush procedure, Client only send a flush request by flush procedure 4. Both server and client disables flush Procedure, Client alwalys sends a flush request by flush procedure at first, after failure ,it will sends a flush request by old flush implementation    The situation 1/2 is no problem. For situation 3, I think client should only send a flush request by old flush implementation instead of flush procedure For situation 4, I think client should only send a flush request by old flush implementation, instead of first using flush procedure, and then switching to old flush implementation after failing" [hbase-operator-tools] Upgrade log4j to 2.17.2,13590716,Resolved,Major,Duplicate,02/Sep/24 09:30,02/Sep/24 09:34,hbase-operator-tools-1.2.0,"After HBASE-26723, we use log4j2.properties file instead of log4j2.xml, and upgrade log4j to 2.17.2 to resolve the issue of log4j2.properties not supporting old syntax. When using hbck2, if the log4j2.properties from the HBase classpath is loaded, an exception will occur due to the old syntax. Therefore, also upgrade hbck log4j2 to 2.17.2." [hbase-thirdparty] Finish hbase-thirdparty 4.1.8 release,13587801,Resolved,Major,Fixed,03/Aug/24 19:59,31/Aug/24 03:34,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Push tag 4.1.8RC1 as tag rel/4.1.8 # Release thirdparty-4.1.8 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12354962 # Add release data on [https://reporter.apache.org/addrelease.html?hbase] # Send announcement email " [hbase-thirdparty] Put up hbase-thirdparty-4.1.8RC0,13587800,Resolved,Major,Fixed,03/Aug/24 19:57,30/Aug/24 17:51,, mTLS client hostname verification doesn't work with OptionalSslHandler,13588621,Resolved,Major,Fixed,12/Aug/24 16:48,29/Aug/24 14:23,3.0.0-beta-1,"Netty's OptionalSslHandler cannot carry hostport information to SslEngine, hence HBASE-27673 fixed the TLS-only case only. We need to have a custom handling for the plaintext-enabled TLS mode in order to support client hostname verification in that case too." Fix typo in Jenkinsfile_Github for jdk8 hadoop2 check,13585853,Resolved,Major,Fixed,15/Jul/24 14:15,25/Aug/24 14:50,,"https://github.com/apache/hbase/blob/9dee538f65d84a900724d424c71793dff46e9684/dev-support/Jenkinsfile_GitHub#L314 This line PR JDK8 Hadoop3 Check Report Should be PR JDK8 Hadoop2 Check Report" Create PoC for RangeStoreFileReader to support multi region splitting,13588081,In Progress,Major,,07/Aug/24 04:49,,,This is the JIRA to create the PoC of the range store file reader. Create Range Reference file to store the range of the split,13589527,In Progress,Major,,21/Aug/24 03:17,,,This subtask to create the range reference file to store the split range and make use of it start the reader. Create Multi region splitting procedure,13589528,Open,Major,,21/Aug/24 03:17,,,This subtask to create the multi region splitting procedure Exclude samples and release-documentation zip of jaxws-ri from output tarball,13588870,Resolved,Major,Fixed,14/Aug/24 16:35,17/Aug/24 06:58,,"Found this while (testing HBASE-28070 and) I was checking lib folder for extracted assembly for master. I guess this must be a problem for all branches fixed for HBASE-28760 Following zip files are there in hbase-4.0.0-alpha-1-SNAPSHOT/lib: * samples-2.3.2.zip * release-documentation-2.3.2-docbook.zip " [JDK17] Jenkins build support for hbase-connectors,13589158,Open,Major,,17/Aug/24 09:17,,, Support JDK17 for hbase-connectors,13589157,Open,Major,,17/Aug/24 09:15,,, Support JDK17 for hbase-operator-tools,13589156,Open,Major,,17/Aug/24 09:10,,, Failed to start HBase MiniCluster when running UT with JDK 17 in hbase-hbck2,13588280,Resolved,Major,Fixed,08/Aug/24 12:29,13/Aug/24 14:52,hbase-operator-tools-1.2.0,"I noted that we have already supported to build hbase-operator-tools with JDK17. [HBASE-28381] Support building hbase-operator-tools with JDK17 - ASF JIRA (apache.org)   But, when running UT in the hbase-hbck2 project using JDK17, an error occurs when starting the hbase MiniCluster cluster.   java.lang.NoSuchFieldException: modifiers         at java.lang.Class.getDeclaredField(Class.java:2610) ~[?:?]         at org.apache.hadoop.hbase.fs.HFileSystem.addLocationsOrderInterceptor(HFileSystem.java:338) [hbase-server-2.4.4.jar:2.4.4]         at org.apache.hadoop.hbase.fs.HFileSystem.addLocationsOrderInterceptor(HFileSystem.java:295) [hbase-server-2.4.4.jar:2.4.4]         at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:100) [hbase-server-2.4.4.jar:2.4.4]         at org.apache.hadoop.hbase.regionserver.HRegionServer.initializeFileSystem(HRegionServer.java:767) [hbase-server-2.4.4.jar:2.4.4]         at org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:654) [hbase-server-2.4.4.jar:2.4.4]      The reason is that the 'modifiers' field is not accessible in JDK17. Since HBase 2.5.0 supports JDK 17, I updated the HBase dependencies, and the test cases can pass successfully." Exclude pom file of jaxws-ri in output tarball,13587146,Resolved,Major,Fixed,29/Jul/24 03:26,07/Aug/24 13:48,,"Permission denied... Not sure what is the real problem. {noformat} 17:21:17 Building a binary tarball from the source tarball succeeded. [Pipeline] echo 17:21:17 unpacking the hbase bin tarball into 'hbase-install' and the client tarball into 'hbase-client' [Pipeline] sh 17:21:18 tar: /jaxws-ri-2.3.2.pom: Cannot open: Permission denied 17:21:20 tar: Exiting with failure status due to previous errors Post stage [Pipeline] stash 17:21:20 Warning: overwriting stash ‘srctarball-result’ 17:21:20 Stashed 2 file(s) [Pipeline] sshPublisher 17:21:20 SSH: Current build result is [FAILURE], not going to run. [Pipeline] sh 17:21:20 Remove /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/output-srctarball/hbase-src.tar.gz for saving space [Pipeline] archiveArtifacts 17:21:20 Archiving artifacts [Pipeline] archiveArtifacts 17:21:20 Archiving artifacts [Pipeline] archiveArtifacts 17:21:20 Archiving artifacts [Pipeline] archiveArtifacts 17:21:20 Archiving artifacts [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // node [Pipeline] } [Pipeline] // stage [Pipeline] } 17:21:20 Failed in branch packaging and integration {noformat}" [hbase-thirdparty] Run spotless & fix any existing spotless issues,13588790,Open,Major,,14/Aug/24 03:23,,, [hbase-thirdparty] Add spotless in hbase-thirdparty pre-commit check,13588791,Open,Major,,14/Aug/24 03:23,,, [hbase-thirdparty] Add spotless plugin in hbase-thirdparty,13588789,Open,Major,,14/Aug/24 03:22,,, [hbase-thirdparty] Add spotless for hbase-thirdparty,13588788,Open,Major,,14/Aug/24 03:18,,, Locating region can exceed client operation timeout ,13585739,Open,Major,,13/Jul/24 18:53,,2.3.7,"I'll be referring to hbase.client.operation.timeout as 'operation timeout' and hbase.client.meta.operation.timeout as 'meta timeout'. In the branch-2 client there is a userRegionLock that a thread needs to acquire to run a meta scan to locate a region. userRegionLock acquisition time is bounded by the meta timeout (HBASE-24956) and once the lock is acquired the meta scan time is bounded by hbase.client.meta.scanner.timeout.period (HBASE-27078). The following describes two cases where resolving the region location for an operation can exceed the end to end operation timeout when there is contention around userRegionLock and/or meta slowness (high contention could result from meta slowness/hotspotting , and is more likely in a high concurrency environment where lots of batch operations are being executed): 1. In locateRegionInMeta , if the relevant region location is not cached, userRegion lock acquisition and meta scan (if userRegionLock is able to be acquired within the lock timeout) [may be retried up to hbase.client.retries.number times|https://github.com/apache/hbase/blob/branch-2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L1012]. Operation timeout check is not done in between retries, so even if one has meta operation timeout + meta scanner timeout < operation timeout, retries could take the client beyond the operation timeout before an exception gets thrown or we exit out of locateRegionInMeta if (meta operation timeout + meta scanner timeout) * region lookup attempts > operation timeout.  Suppose we have operation timeout = meta timeout = 10sec and client retries = 2, and there is enough contention/meta slowness that userRegionLock cannot be acquired for 1min, and we have a new thread running an operation that needs to do a region lookup. For this operation, locateRegionInMeta will try to acquire the userRegionLock 3 times , taking 3 * 10sec + some pause time in between retries before we exit out of locateRegionInMeta and the operation times out after >3x the configured 10sec operation/meta timeout. 2. Without any retries, if one has (hbase.client.meta.operation.timeout || hbase.client.meta.scanner.timeout.period) > hbase.client.operation.timeout (meta operation timeout default makes this easily possible -  HBASE-28608) the client operation timeout could be exceeded. +Proposal+ I propose two changes: 1. Doing an operation timeout check in between retrying userRegion lock acquisition + meta scan (perhaps moving the retry logic + loop outside of the locateRegionInMeta method?) 2. Change userRegionLock timeout and meta scanner timeout to dynamic values that depend on the time remaining for the end to end operation. userRegionLock acquisition and meta scan time are bounded by static values regardless of how much time was already spent trying to do region location lookups or how much time might be remaining to run the actual operations once all required region locations are found. If we were to use time remaining for the operation for the lock timeout, and then set the meta scanner timeout to min(hbase.client.meta.scanner.timeout.period, operation time remaining after userRegionLock acquisition), that would provide a good upper bound on time spent attempting to locate a region that should keep the operation closely within the desired end to end timeout. Dynamic userRegionLock and meta scanner timeouts would also remove some complexity/dependence on client configurations in the locate region codepath which should simplify the thought process behind choosing appropriate client timeouts. ---- Branch-2 blocking client is effected, I am not yet sure and have not tested how branch-2 AsyncTable is effected. Branch-3+ does not have userRegionLock, and the sync client connection implementation is very [different|https://github.com/apache/hbase/pull/6000#issuecomment-2210913557] (thank you Duo for explaining). This issue extends/develops on what was originally reported in the bottom of HBASE-28358. HBASE-27490 is related work which greatly improved the upper bound on region location resolution time for batch operations." hbase-table-reporter shoud use the hbase.version declared in the parent pom.xml and use junit for UT,13588011,Resolved,Major,Fixed,06/Aug/24 12:07,08/Aug/24 12:03,1.2.0,"In hbase-operator-tools project, the submodule hbase-table-reporter shoud use the hbase.version declared in the parent pom, rather than using 2.1.1 defined by itself. And, we need to add junit dependency and use junit for UT in this submodule." Implement asynchronous bucket-cache recovery from persistence.,13588264,Open,Major,,08/Aug/24 10:23,,,"During the recovery of bucket cache from persistence, we need to rebuild a transient in-memory structure (blockByHfile) which has the blocks sorted according to their filenames. This transient structure population is done during the server start-up during the recreation of bucket cache from persistence. This process can be time-consuming if bucket-cache has large number of blocks. (in millions). This population is executed inline with the server restart and this blocks the server from being available for several minutes. This makes the server restart inconvenient for the external users. The need is to make the cache retrieval asynchronous to server restart by spawning a new thread that rebuilds cache from the persistence, while the server continues with its restart. This prevents an unnecessary delay in the server restart. Note that the bucket cache may not available immediately for usage and will only be ready to use after the data is repopulated from persistence into memory. Thanks, Janardhan" [hbase-thirdparty] Bump dependencies for hbase-thirdparty-4.1.8 release,13587798,Resolved,Major,Fixed,03/Aug/24 19:56,05/Aug/24 10:44,,"Upgrade the dependencies, * guava 33.1.0-jre -> 33.2.1-jre         [https://mvnrepository.com/artifact/com.google.guava/guava] * commons-cli 1.6.0 -> 1.8.0         [https://mvnrepository.com/artifact/commons-cli/commons-cli] * error_prone_annotations 2.26.1 -> 2.28.0         [https://mvnrepository.com/artifact/com.google.errorprone/error_prone_annotations] * gson 2.10.1 -> 2.11.0         [https://mvnrepository.com/artifact/com.google.code.gson/gson] * jetty 9.4.54.v20240208 -> 9.4.55.v20240627         [https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server] * jersey 2.42 -> 2.43         [https://mvnrepository.com/artifact/org.glassfish.jersey.core/jersey-client] * jackson-jaxrs-json-provider 2.17.0 -> 2.17.2         [https://mvnrepository.com/artifact/com.fasterxml.jackson.jaxrs/jackson-jaxrs-json-provider]" HBase-Nightly-s390x Build failures,13586489,Resolved,Major,Fixed,22/Jul/24 06:01,29/Jul/24 06:22,,"Hi [~zhangduo] This is regarding recent [s390x CI failures|https://ci-hbase.apache.org/job/HBase-Nightly-s390x/] . The install.log and junit.log has got below output - {code:java} /tmp/jenkins18056117051185954087.sh: line 12: /home/jenkins/tools/maven/latest3//bin/mvn: No such file or directory{code}  Upon checking the machine stats it seems like the Apache Maven path is not getting set properly, since the mvn_home outputs - {code:java} MAVEN_HOME: /home/jenkins/tools/maven/latest3/{code}  where as the mvn_version outputs the following - {code:java} [1mApache Maven 3.6.3[m Maven home: /usr/share/maven Java version: 11.0.23, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-s390x Default locale: en_US, platform encoding: UTF-8 OS name: ""linux"", version: ""5.4.0-174-generic"", arch: ""s390x"", family: ""unix""{code}  Could you please help us get this fixed? Thanks." Change the generic type of List in InternalScanner.next,13585720,Resolved,Major,Fixed,13/Jul/24 13:25,31/Jul/24 02:37,,"Plan to change it from List to List, so we could pass both List and List to it, or even List for coprocessors. This could save a lot of casting in our main code. This is an incompatible change for coprocessors, so it will only go into branch-3+, and will be marked as incompatible change." FNFE may occur when accessing the region.jsp of the replica region,13586790,Resolved,Major,Fixed,24/Jul/24 12:08,30/Jul/24 03:12,2.4.13,"On hbase UI, we can get the details of storefiles in region region by accessing region.jsp. However, When hbase table enables the region replication, the replica region may reference deleted storefile due to it dosen't refresh in a timely manner, so in this case, we would get FNFE when openning the region.jsp of the region.   java.io.FileNotFoundException: File file:/home/gl/code/github/hbase/hbase-assembly/target/hbase-4.0.0-alpha-1-SNAPSHOT/tmp/hbase/data/default/t01/e073c6b7c05eadda3f91d5b9692fc98d/info/5c52361153044b89aa61090cd5497998.4433b98ccf6b4a011ab03fc4a5e38a1a does not exist at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:915) at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:1236) at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:905) at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:462) at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:462) at org.apache.hadoop.fs.FileSystem.getLength(FileSystem.java:1881) at org.apache.hadoop.hbase.generated.regionserver.region_jsp._jspService(region_jsp.java:97) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)" Remove the aarch64 profile,13587140,Resolved,Major,Fixed,29/Jul/24 02:26,30/Jul/24 03:00,,"We do not depend on protobuf 2.5 on branch-3+, so we do not need the special protoc compiler for arm any more. Just remove the profile." wal.AsyncFSWAL: sync failed,13586757,Open,Major,,24/Jul/24 08:13,,2.1.10,"Our HBase system is used for OLAP , The client has strict requirements for latency and stability, and the client configuration is as follows: {code:java} hbase.rpc.timeout: 100 hbase.client.operation.timeout: 500 hbase.client.retries.number: 3 hbase.client.pause: 120 {code} When I logged off the Datanode, I received this exception: {code:java} 2024-06-03 17:19:16,535 WARN  [RpcServer.default.RWQ.Fifo.read.handler=216,queue=4,port=16020] hdfs.BlockReaderFactory: I/O error constructing remote block reader. org.apache.hadoop.net.ConnectTimeoutException: 20000 millis timeout while waiting for channel to be ready for connect. ch : java.nio.channels.SocketChannel[connection-pending remote=/10.111.242.219:50010]     at org.apache.hadoop.net.NetUtils.connect(NetUtils.java:534)     at org.apache.hadoop.hdfs.DFSClient.newConnectedPeer(DFSClient.java:3436)     at org.apache.hadoop.hdfs.BlockReaderFactory.nextTcpPeer(BlockReaderFactory.java:777)     at org.apache.hadoop.hdfs.BlockReaderFactory.getRemoteBlockReaderFromTcp(BlockReaderFactory.java:694)     at org.apache.hadoop.hdfs.BlockReaderFactory.build(BlockReaderFactory.java:355)     at org.apache.hadoop.hdfs.DFSInputStream.actualGetFromOneDataNode(DFSInputStream.java:1173)     at org.apache.hadoop.hdfs.DFSInputStream.access$200(DFSInputStream.java:92)     at org.apache.hadoop.hdfs.DFSInputStream$2.call(DFSInputStream.java:1118)     at org.apache.hadoop.hdfs.DFSInputStream$2.call(DFSInputStream.java:1110)     at java.util.concurrent.FutureTask.run(FutureTask.java:266)     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)     at java.util.concurrent.FutureTask.run(FutureTask.java:266)     at java.util.concurrent.ThreadPoolExecutor$CallerRunsPolicy.rejectedExecution(ThreadPoolExecutor.java:2022)     at org.apache.hadoop.hdfs.DFSClient$2.rejectedExecution(DFSClient.java:3481)     at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823)     at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369)     at java.util.concurrent.ExecutorCompletionService.submit(ExecutorCompletionService.java:181)     at org.apache.hadoop.hdfs.DFSInputStream.hedgedFetchBlockByteRange(DFSInputStream.java:1297) {code} This will cause the HBase service to become unstable because HBase has accessed an offline datanode node, resulting in a long time required to create a socket connection to the offline datanode. Through stack logs, I found that it is controlled through the configuration of hdfs.client.socket timeout. – In hbase-site.xml,I found that adjusting the {color:#ff0000}hdfs.client.socket-time{color} configuration is effective,so I turned down the hdfs.client.socket time configuration from 60s to 5s. but I found that if I continued to turn down the hdfs.client.socket time configuration to {color:#ff0000}200ms{color}, the following exception occurred: {code:java} 2024-06-18 15:51:24,212 WARN  [AsyncFSWAL-0] wal.AsyncFSWAL: sync failed java.io.IOException: Timeout(200ms) waiting for response         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput$AckHandler.lambda$userEventTriggered$4(FanOutOneBlockAsyncDFSOutput.java:302)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.failed(FanOutOneBlockAsyncDFSOutput.java:235)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.access$300(FanOutOneBlockAsyncDFSOutput.java:98)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput$AckHandler.userEventTriggered(FanOutOneBlockAsyncDFSOutput.java:301)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:304)         at org.apache.hbase.thirdparty.io.netty.channel.ChannelInboundHandlerAdapter.userEventTriggered(ChannelInboundHandlerAdapter.java:108)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:304)         at org.apache.hbase.thirdparty.io.netty.channel.ChannelInboundHandlerAdapter.userEventTriggered(ChannelInboundHandlerAdapter.java:108)         at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.userEventTriggered(ByteToMessageDecoder.java:366)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:304)         at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelIdle(IdleStateHandler.java:371)         at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler$ReaderIdleTimeoutTask.run(IdleStateHandler.java:494)         at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler$AbstractIdleTask.run(IdleStateHandler.java:466)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.PromiseTask$RunnableAdapter.call(PromiseTask.java:38)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.ScheduledFutureTask.run(ScheduledFutureTask.java:127)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)         at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:333)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:905)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)         at java.lang.Thread.run(Thread.java:745){code}   The configuration of 'hdfs. client. socket time' is reused in the FanOutOneBlockAsyncDFSOutput.class of hbase. – In the 'FanOutOneBlockAsyncDFSOutput' construction method: {code:java} FanOutOneBlockAsyncDFSOutput(Configuration conf, FSUtils fsUtils, DistributedFileSystem dfs, DFSClient client, ClientProtocol namenode, String clientName, String src, long fileId, LocatedBlock locatedBlock, Encryptor encryptor, List datanodeList, DataChecksum summer, ByteBufAllocator alloc) { this.conf = conf; this.fsUtils = fsUtils; this.dfs = dfs; this.client = client; this.namenode = namenode; this.fileId = fileId; this.clientName = clientName; this.src = src; this.block = locatedBlock.getBlock(); this.locations = locatedBlock.getLocations(); this.encryptor = encryptor; this.datanodeList = datanodeList; this.summer = summer; this.maxDataLen = MAX_DATA_LEN - (MAX_DATA_LEN % summer.getBytesPerChecksum()); this.alloc = alloc; this.buf = alloc.directBuffer(sendBufSizePRedictor.initialSize()); this.state = State.STREAMING; * setupReceiver(conf.getInt(DFS_CLIENT_SOCKET_TIMEOUT_KEY, READ_TIMEOUT)); } {code} ---- My implementation process: 1. add a new configuration in hbase-site.xml {code:java} + + hbase.wal.asyncfsoutput.timeout + 60000 + {code} 2.modify source code with FanOutOneBlockAsyncDFSOutput.java {code:java} 151 + private static final String FANOUT_TIMEOUTKEY = ""hbase.wal.asyncfsoutput.timeout""; 339 - setupReceiver(conf.getInt(DFS_CLIENT_SOCKET_TIMEOUT_KEY, READ_TIMEOUT)); 339 + setupReceiver(conf.getInt(FANOUT_TIMEOUTKEY, READ_TIMEOUT)); {code} 3.repackge   — I would like to consult the community on whether it is possible to design a separate configuration item in FanOutOneBlockAsynchronousDFSOutput.jva to isolate the issue of writing WalLog timeout failure due to the small size of dfs.comient.socket-time?" Should wipe out all the output directories before unstash in nightly job,13585249,Resolved,Major,Fixed,10/Jul/24 02:57,29/Jul/24 04:02,,"For master and branch-3, we do not have jdk8 and jdk11 stages but we can still see there are comments on jira which include these stages's results. I think the problem is that, in the 'init health results' stage, we want to stash some empty results but actually there are some build results for previous builds there so we stash some non empty results. We should wipe out these directories first before stash them." Use ExtendedCell in WALEdit,13585188,Resolved,Major,Fixed,09/Jul/24 15:05,28/Jul/24 05:55,, CompactionTool fails with NPE when mslab is enabled,13586330,Resolved,Major,Fixed,19/Jul/24 06:29,27/Jul/24 07:02,2.5.9,"While using the CompactionTool, NPE is observed. *Command:* {code:java} hbase org.apache.hadoop.hbase.regionserver.CompactionTool  -major {code} *Exception Details:* {code:java} Exception in thread ""main"" java.lang.NullPointerException         at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.recycleChunks(MemStoreLABImpl.java:296)         at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.lambda$new$0(MemStoreLABImpl.java:109)         at org.apache.hadoop.hbase.nio.RefCnt.deallocate(RefCnt.java:95)         at org.apache.hbase.thirdparty.io.netty.util.AbstractReferenceCounted.handleRelease(AbstractReferenceCounted.java:86)         at org.apache.hbase.thirdparty.io.netty.util.AbstractReferenceCounted.release(AbstractReferenceCounted.java:76)         at org.apache.hadoop.hbase.nio.RefCnt.release(RefCnt.java:84)         at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.close(MemStoreLABImpl.java:269)         at org.apache.hadoop.hbase.regionserver.Segment.close(Segment.java:143)         at org.apache.hadoop.hbase.regionserver.AbstractMemStore.close(AbstractMemStore.java:381)         at org.apache.hadoop.hbase.regionserver.HStore.closeWithoutLock(HStore.java:723)         at org.apache.hadoop.hbase.regionserver.HStore.close(HStore.java:795)         at org.apache.hadoop.hbase.regionserver.CompactionTool$CompactionWorker.compactStoreFiles(CompactionTool.java:171)         at org.apache.hadoop.hbase.regionserver.CompactionTool$CompactionWorker.compactRegion(CompactionTool.java:137)         at org.apache.hadoop.hbase.regionserver.CompactionTool$CompactionWorker.compactTable(CompactionTool.java:129)         at org.apache.hadoop.hbase.regionserver.CompactionTool$CompactionWorker.compact(CompactionTool.java:118)         at org.apache.hadoop.hbase.regionserver.CompactionTool.doClient(CompactionTool.java:374)         at org.apache.hadoop.hbase.regionserver.CompactionTool.run(CompactionTool.java:424)         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)         at org.apache.hadoop.hbase.regionserver.CompactionTool.main(CompactionTool.java:460){code} *Fix Suggestions:* Initialize the ChunkCreator in CompactionTool when hbase.hregion.memstore.mslab.enabled is enabled." "RegionSizeCalculator ignored the size of memstore, which leads Spark miss data",13586871,Resolved,Major,Fixed,25/Jul/24 03:50,26/Jul/24 08:02,2.5.10,"RegionSizeCalculator only considers the size of StoreFile and ignores the size of MemStore. For a new region that has only been written to MemStore and has not been flushed, will consider its size to be 0. When we use TableInputFormat to read HBase table data in Spark. {code:java} spark.sparkContext.newAPIHadoopRDD( conf, classOf[TableInputFormat], classOf[ImmutableBytesWritable], classOf[Result]) }{code} Spark defaults to ignoring empty InputSplits, which is determined by the configuration  ""{{{}spark.hadoopRDD.ignoreEmptySplits{}}}"". {code:java} private[spark] val HADOOP_RDD_IGNORE_EMPTY_SPLITS = ConfigBuilder(""spark.hadoopRDD.ignoreEmptySplits"") .internal() .doc(""When true, HadoopRDD/NewHadoopRDD will not create partitions for empty input splits."") .version(""2.3.0"") .booleanConf .createWithDefault(true) {code} The above reasons lead to Spark missing data. So we should consider both the size of the StoreFile and the MemStore in the RegionSizeCalculator." Update downloads.xml for 2.5.10,13586851,Resolved,Major,Fixed,24/Jul/24 22:33,25/Jul/24 22:05,, Understand how supportplaintext property works in TLS setup.,13586970,Open,Major,,25/Jul/24 17:41,,2.6.0,"We are testing TLS feature and I am confused on how hbase.server.netty.tls.supportplaintext property works. Here is our current setup. This is a fresh cluster deployment. hbase.server.netty.tls.enabled --> true hbase.client.netty.tls.enabled --> true hbase.server.netty.tls.supportplaintext --> false (We don't want to fallback on kerberos) We still have our kerberos related configuration enabled. hbase.security.authentication --> kerberos *Our expectation:* During regionserver startup, regionserver will use TLS for authentication and the communication will succeed. *Actual observation* During regionserver startup, hmaster authenticates regionserver* via kerberos authentication*and *regionserver's reportForDuty RPC fails*. RS logs: {noformat} 2024-07-25 16:59:55,098 INFO [regionserver/regionserver-0:60020] regionserver.HRegionServer - reportForDuty to master=hmaster-0,60000,1721926791062 with isa=regionserver-0/:60020, startcode=1721926793434 2024-07-25 16:59:55,548 DEBUG [RS-EventLoopGroup-1-2] ssl.SslHandler - [id: 0xa48e3487, L:/:39837 - R:hmaster-0/:60000] HANDSHAKEN: protocol:TLSv1.2 cipher suite:TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 2024-07-25 16:59:55,578 DEBUG [RS-EventLoopGroup-1-2] security.UserGroupInformation - PrivilegedAction [as: hbase/regionserver-0. (auth:KERBEROS)][action: org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler$2@3769e55] java.lang.Exception at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1896) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.channelRead0(NettyHBaseSaslRpcClientHandler.java:161) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.channelRead0(NettyHBaseSaslRpcClientHandler.java:43) ... ... 2024-07-25 16:59:55,581 DEBUG [RS-EventLoopGroup-1-2] security.UserGroupInformation - PrivilegedAction [as: hbase/regionserver-0 (auth:KERBEROS)][action: org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler$2@c6f0806] java.lang.Exception at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1896) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.channelRead0(NettyHBaseSaslRpcClientHandler.java:161) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.channelRead0(NettyHBaseSaslRpcClientHandler.java:43) at org.apache.hbase.thirdparty.io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) 2024-07-25 16:59:55,602 WARN [regionserver/regionserver-0:60020] regionserver.HRegionServer - error telling master we are up org.apache.hbase.thirdparty.com.google.protobuf.ServiceException: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Call to address=hmaster-0:60000 failed on local exception: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Connection closed at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:340) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$200(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:595) at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$BlockingStub.regionServerStartup(RegionServerStatusProtos.java:16398) at org.apache.hadoop.hbase.regionserver.HRegionServer.reportForDuty(HRegionServer.java:2997) at org.apache.hadoop.hbase.regionserver.HRegionServer.lambda$run$2(HRegionServer.java:1084) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1079) Caused by: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Call to address=hmaster-0:60000 failed on local exception: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Connection closed at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:233) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:391) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:425) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:420) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.cleanupCalls(NettyRpcDuplexHandler.java:231) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelInactive(NettyRpcDuplexHandler.java:239) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:303) {noformat} Hmaster logs {noformat} 2024-07-25 16:59:55,378 DEBUG [RS-EventLoopGroup-1-2] ipc.NettyRpcServer - SSL handler added for channel: [id: 0xd4071764, L:/:60000 - R:regionserver-0/:39837] 2024-07-25 16:59:55,526 DEBUG [RS-EventLoopGroup-1-2] ssl.SslHandler - [id: 0xd4071764, L:/:60000 - R:regionserver-0/:39837] HANDSHAKEN: protocol:TLSv1.2 cipher suite:TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 2024-07-25 16:59:55,583 INFO [RS-EventLoopGroup-1-2] hbase.Server - Auth successful for hbase/regionserver-0 (auth:KERBEROS) {noformat} " Metrics for ConnectionRegistry API's need to be added,13586756,Open,Major,,24/Jul/24 08:09,,2.4.17,"For now, no metrics are being pushed for connection registry API's. We need at least some basic metrics for API's-  requestCount - number of requests from client failureCount - number of requests where we give failed response response time - time took to respond to request  " [hbase-thirdparty] Bump netty to latest 4.1.112.Final version,13586457,Resolved,Major,Fixed,21/Jul/24 19:07,23/Jul/24 17:25,,"netty 4.1.112.Final is released recently, let's upgrade the dependency." Add a new command-line option for table backup in our ref guide,13586386,Resolved,Major,Fixed,19/Jul/24 16:59,21/Jul/24 12:44,, Rpc ConnectionRegistry APIs should have timeout,13586328,Open,Major,,19/Jul/24 05:59,,2.4.18,"ConnectionRegistry are some of the most basic metadata APIs that determine how clients can interact with the servers after getting required metadata. These APIs should timeout quickly if they cannot serve metadata in time. Similar to HBASE-28428 introducing timeout for Zookeeper ConnectionRegistry APIs, we should also introduce timeout (same timeout values) for Rpc ConnectionRegistry APIs as well. RpcConnectionRegistry uses HBase RPC framework with hedge read fanout mode. We have two options to introduce timeout: # Use RetryTimer to keep watch on CompletableFuture and make it complete exceptionally if timeout is reached (similar proposal as HBASE-28428). # Introduce separate Rpc timeout config for AbstractRpcBasedConnectionRegistry as the rpc timeout for generic RPC operations (hbase.rpc.timeout) could be higher." Add the slack channel related information in README.md,13586098,Resolved,Major,Fixed,17/Jul/24 06:19,18/Jul/24 06:58,, The expired snapshot can be read by CopyTable or ExportSnapshot,13584488,Resolved,Major,Fixed,02/Jul/24 12:35,19/Jul/24 01:13,2.4.13,"We can get data of the expired snapshot through the following way. {code:java} hbase org.apache.hadoop.hbase.mapreduce.CopyTable --snapshot expired_snapshot --new.name my_table{code}  And we did not check if the snapshot is expired when we export a snaoshot by ExportSnapshot tool." Modify our ref guide about the slack channel change,13586097,Resolved,Major,Fixed,17/Jul/24 06:17,18/Jul/24 06:49,, Move our official slack channel from apache-hbase.slack.com to the one in the-asf.slack.com,13586096,Resolved,Major,Fixed,17/Jul/24 06:17,18/Jul/24 07:16,,"According to this thread in the mailing list https://lists.apache.org/thread/cyr8vfxvfqm2srz7m1kkp4mkk015r8wx Let's do the move." Send notice email to all mailing list to mention the slack channel change,13586099,Resolved,Major,Fixed,17/Jul/24 06:19,18/Jul/24 07:16,, Remove the specific logic for jdk11 in hbase-assembly and change our script to only support jdk17,13584622,Resolved,Major,Fixed,03/Jul/24 13:44,17/Jul/24 03:18,,"I think now the script worked fine with java17, but I think we need to add some checks that if users use a jdk version less 17, we should fail immediately and post the correct error message." [JDK17] TestSecureIPC fails under JDK17,13585392,Resolved,Major,Fixed,11/Jul/24 03:59,14/Jul/24 07:02,,"Although the tests only fail on branch-2.5, the same exception also produced on other active branches, so even if the tests passes, it does not test what we want I think. {noformat} 2024-07-11T11:56:44,323 DEBUG [Thread-3 {}] ipc.BlockingRpcConnection$1(409): Exception encountered while connecting to the server localhost:39851 java.lang.reflect.InaccessibleObjectException: Unable to make field private transient java.lang.String java.net.InetAddress.canonicalHostName accessible: module java.base does not ""opens java.net"" to unnamed module @26a7b76d at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354) ~[?:?] at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297) ~[?:?] at java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) ~[?:?] at java.lang.reflect.Field.setAccessible(Field.java:172) ~[?:?] at org.apache.hadoop.hbase.security.AbstractTestSecureIPC$CanonicalHostnameTestingAuthenticationProviderSelector$1.createClient(AbstractTestSecureIPC.java:202) ~[test-classes/:?] at org.apache.hadoop.hbase.security.AbstractHBaseSaslRpcClient.(AbstractHBaseSaslRpcClient.java:79) ~[classes/:?] at org.apache.hadoop.hbase.security.HBaseSaslRpcClient.(HBaseSaslRpcClient.java:74) ~[classes/:?] at org.apache.hadoop.hbase.ipc.BlockingRpcConnection.setupSaslConnection(BlockingRpcConnection.java:366) ~[classes/:?] at org.apache.hadoop.hbase.ipc.BlockingRpcConnection$2.run(BlockingRpcConnection.java:541) ~[classes/:?] at org.apache.hadoop.hbase.ipc.BlockingRpcConnection$2.run(BlockingRpcConnection.java:1) ~[classes/:?] at java.security.AccessController.doPrivileged(AccessController.java:712) ~[?:?] at javax.security.auth.Subject.doAs(Subject.java:439) ~[?:?] at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.hbase.ipc.BlockingRpcConnection.setupIOstreams(BlockingRpcConnection.java:538) ~[classes/:?] at org.apache.hadoop.hbase.ipc.BlockingRpcConnection.writeRequest(BlockingRpcConnection.java:685) ~[classes/:?] at org.apache.hadoop.hbase.ipc.BlockingRpcConnection$4.run(BlockingRpcConnection.java:819) ~[classes/:?] at org.apache.hadoop.hbase.ipc.HBaseRpcControllerImpl.notifyOnCancel(HBaseRpcControllerImpl.java:276) ~[classes/:?] at org.apache.hadoop.hbase.ipc.BlockingRpcConnection.sendRequest(BlockingRpcConnection.java:792) ~[classes/:?] at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:449) ~[classes/:?] at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:336) ~[classes/:?] at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:606) ~[classes/:?] at org.apache.hadoop.hbase.shaded.ipc.protobuf.generated.TestRpcServiceProtos$TestProtobufRpcProto$BlockingStub.echo(TestRpcServiceProtos.java:500) ~[classes/:?] at org.apache.hadoop.hbase.security.AbstractTestSecureIPC$TestThread.run(AbstractTestSecureIPC.java:451) ~[test-classes/:?] {noformat} We need to open java.net too." Backport the code changes in HBASE-28675 to branch-2.x,13584566,Resolved,Major,Fixed,03/Jul/24 03:15,11/Jul/24 11:21,,For aligning the code between different branches. Support FuzzyRowFilter in REST interface,13585026,Resolved,Major,Fixed,08/Jul/24 14:20,10/Jul/24 08:50,,"This is similar to MultiRowRangeFilter, but needs a new DTO to represent the keys with masks." Add JDK17 in the support matrix in our ref guide,13584929,Resolved,Major,Fixed,07/Jul/24 14:38,10/Jul/24 02:34,, "Should support different license name for 'Apache License, Version 2.0'",13585036,Resolved,Major,Fixed,08/Jul/24 15:43,09/Jul/24 09:57,,"Starting from v29 of apache parent pom, the license name was changed from 'Apache License, Version 2.0' to 'Apache-2.0'. We should support it so we do not need to set lots of exceptions in supplemental-models.xml." Remove download links for 2.4.x on download page,13584927,Resolved,Major,Fixed,07/Jul/24 14:19,08/Jul/24 03:12,, Update the information about the EOL for 2.4.x on https://downloads.apache.org/hbase/,13584928,Resolved,Major,Fixed,07/Jul/24 14:20,08/Jul/24 03:43,, Bump certifi from 2023.7.22 to 2024.7.4 in /dev-support/git-jira-release-audit,13584877,Resolved,Major,Fixed,06/Jul/24 03:16,06/Jul/24 03:17,, Use hasReferences api of SFT in RegionSplitter,13592505,Resolved,Minor,Fixed,18/Sep/24 17:06,23/Jan/25 16:32,,"HBASE-28564 Adds apis in SFT layer for all interaction related to Reference files - create, read, hasReferences  This Jira refactors RegionSplitter code to use the hasReferences api of SFT instead of HRegionFileSystem.hasReferences()" Simplify backup bulk-loading code,13587894,Resolved,Minor,Fixed,05/Aug/24 13:07,17/Dec/24 10:02,2.6.0,"While working on HBASE-28706, I came across a lot of overly complex/duplicate code related to how bulk uploads are tracked for backups. This ticket is to simplify some of it." [hbase-connectors] Add OpenLineage reporting support for Spark connector,13591028,Open,Minor,,04/Sep/24 15:26,,,"We would like to enhance the `hbase-spark` connector by integrating [OpenLineage|https://openlineage.io/] support. OpenLineage is a powerful framework for tracking and managing data lineage across various data systems. Adding this capability to the `hbase-spark` connector will allow users to automatically capture lineage information during data processing tasks, improving data governance, transparency, and auditability." Add support for non replica actions to AsyncRequestFutureImpl.isActionComplete,13588180,Resolved,Minor,Not A Problem,07/Aug/24 16:50,30/Sep/24 14:21,2.5.10,"The current isActionComplete method we have in AsyncRequestFutureImpl is only designed to support replica actions, it would be useful to have isActionComplete support non replica actions that could be reused for HBASE-27781 / [#6144|https://github.com/apache/hbase/pull/6144/files] and in other paths where non replica actions are being handled.  Since isActionComplete currently only has one caller we can move the replica action check to the caller method instead of having the check be inside isActionComplete. " Make connector support for Decimal type,13592013,Resolved,Minor,Fixed,13/Sep/24 05:25,03/Oct/24 08:27,connector-1.0.0, FSHlog closewrite closeErrorCount should increment for initial catch exception,13592835,Open,Minor,,22/Sep/24 03:12,,2.7.0,"During close writer for FSHlog, if any error occured then for initial exception itself need to increment the closeErrorCount counter." "Backport ""HBASE-18382 [Thrift] Add transport type info to info server"" to branch-2",13593463,Resolved,Minor,Fixed,27/Sep/24 06:02,27/Sep/24 06:48,,"It would be really helpful to know if the Thrift server was started using the HTTP or binary transport. Any additional info, like QOP settings for SASL etc. would be great too. Right now the UI is very limited and shows {{true/false}} for, for example, {{Compact Transport}}. It'd suggest to change this to show something more useful like this: {noformat} Thrift Impl Type: non-blocking Protocol: Binary Transport: Framed QOP: Authentication & Confidential {noformat} or {noformat} Protocol: Binary + HTTP Transport: Standard QOP: none {noformat} " Fix broken link to mailing lists page in reference guide,13593344,Resolved,Minor,Fixed,26/Sep/24 10:51,26/Sep/24 11:39,4.0.0-alpha-1,The Reference Guide (book) link to the mailing lists page [hbase-thirdparty] Enable infra automation: autolink to Jira and 'pull-request-available' label,13589234,Resolved,Minor,Fixed,18/Aug/24 17:42,30/Aug/24 06:46,,"Patterns like HBASE-28786 will be clickable, so it's easier to go to the Jira page. {{.asf.yaml}} provides an option to do this via config: See [https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AutolinksforJira] Even without manual configuring this already works for hbase somehow. See [https://github.com/apache/hbase/commits/master/] Maybe configured at repo level in INFRA? But same does not work for hbase-connectors and other repos. Will use this config to fix the issue. Also will enable label feature for 'pull-request-available', same as hbase main repo: HBASE-28325" [hbase-thirdparty] Bump hbase.stable.version to 2.5.10 in hbase-noop-htrace,13593300,Open,Minor,,26/Sep/24 06:56,,, Add missing permission check for updateRSGroupConfig in branch-2,13592711,Resolved,Minor,Fixed,20/Sep/24 11:26,24/Sep/24 17:26,2.7.0,"Found this during HBASE-28867, we do not have security check for updateRSGroupConfig in branch-2. See [https://github.com/apache/hbase/blob/0dc334f572329be7eb2455cec3519fc820c04c25/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java#L450] Same check exists in master [https://github.com/apache/hbase/blob/52082bc5b80a60406bfaaa630ed5cb23027436c1/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java#L2279]  " NoMethodError undefined method assignment_expression?,13592653,Resolved,Minor,Invalid,20/Sep/24 00:02,24/Sep/24 00:36,,"After HBASE-28250 Bump jruby to 9.4.8.0 to fix snakeyaml CVE after every command the message ""NoMethodError undefined method assignment_expression?"" is printed. This is called from code copied from https://github.com/ruby/irb/blob/v1.4.2/lib/irb.rb . The fix is to also copy over the definition of `assignment_expression`. " Create Snapshot V1 reference files using SFT,13592629,Open,Minor,,19/Sep/24 17:50,,,"HBASE-28564 adds apis to handler Reference files in SFT for create, read, hasReferences. This Jira refactors Snapshot code (V1 manifest) to create reference files using SFT and make the Snapshot layer SFT aware" Should check if table exists firstly when executing ExpiredMobFileCleaner,13591498,Open,Minor,,09/Sep/24 11:45,,2.4.13,"We would get the following error message when specifing an non_existing table whild executing ExpiredMobFileCleaner. ./bin/hbase org.apache.hadoop.hbase.mob.ExpiredMobFileCleaner  t04_mob01 info Exception in thread ""main"" org.apache.hadoop.hbase.TableNotFoundException: t04_mob01         at java.base/java.lang.Thread.getStackTrace(Thread.java:1610)         at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:144)         at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:163)         at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:186)         at org.apache.hadoop.hbase.client.AdminOverAsyncAdmin.getDescriptor(AdminOverAsyncAdmin.java:172)         at org.apache.hadoop.hbase.mob.ExpiredMobFileCleaner.run(ExpiredMobFileCleaner.java:99)         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)         at org.apache.hadoop.hbase.mob.ExpiredMobFileCleaner.main(ExpiredMobFileCleaner.java:75)         at --------Future.get--------(Unknown Source)         at org.apache.hadoop.hbase.client.RawAsyncHBaseAdmin.lambda$getDescriptor$24(RawAsyncHBaseAdmin.java:654)         at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:71)         at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)         at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)         at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)         at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147)         at org.apache.hadoop.hbase.client.AsyncMasterRequestRpcRetryingCaller.lambda$doCall$4(AsyncMasterRequestRpcRetryingCaller.java:80)         at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:71)         at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)         at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:841)         at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)         at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2147)         at org.apache.hadoop.hbase.client.RawAsyncHBaseAdmin$1.run(RawAsyncHBaseAdmin.java:467)         at org.apache.hbase.thirdparty.com.google.protobuf.RpcUtil$1.run(RpcUtil.java:56) Maybe it is better to return concise information when table does not exist by checking table exists firstly." Change the output of DatanodeInfo in the log to the hostname of the datanode,13588397,Resolved,Minor,Fixed,09/Aug/24 10:19,15/Sep/24 02:56,,"Now,  DatanodeInfo will be output in the print log. When we are troubleshooting and searching for slow datanode nodes, we need to convert IP addresses to hostnames, which is quite cumbersome. I think the output log should has good readability, so it would be better to output the hostname of the datanode." WALs are not cleaned even after all entries are flushed,13589542,Open,Minor,,21/Aug/24 05:51,,2.5.6,"In our production fleet we have observed that WAL files are not cleaned up even when all the entries have been flushed. I have fixed the WAL close issue when there is issue with the wal closures as part of [HBASE-28665|https://issues.apache.org/jira/projects/HBASE/issues/HBASE-28665]. There is a case in case of unflushed entried that can lead for the wal not be cleaned even after all the entries have been flushed [FSHLog.java |https://github.com/apache/hbase/blob/branch-2.6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L388] {code:java} if (isUnflushedEntries() || closeErrorCount.get() >= this.closeErrorsTolerated) { try { closeWriter(this.writer, oldPath, true); } finally { inflightWALClosures.remove(oldPath.getName()); if (!isUnflushedEntries()) { markClosedAndClean(oldPath); } } {code} If there are unflushed entries then wal will never be marked close and won't be cleaned further {code:java} private synchronized void cleanOldLogs() { List> logsToArchive = null; // For each log file, look at its Map of regions to the highest sequence id; if all sequence ids // are older than what is currently in memory, the WAL can be GC'd. for (Map.Entry e : this.walFile2Props.entrySet()) { if (!e.getValue().closed) { LOG.debug(""{} is not closed yet, will try archiving it next time"", e.getKey()); continue; } Path log = e.getKey(); Map sequenceNums = e.getValue().encodedName2HighestSequenceId; if (this.sequenceIdAccounting.areAllLower(sequenceNums)) { if (logsToArchive == null) { logsToArchive = new ArrayList<>(); } logsToArchive.add(Pair.newPair(log, e.getValue().logSize)); if (LOG.isTraceEnabled()) { LOG.trace(""WAL file ready for archiving "" + log); } } } {code} " Procedure queues & PE pool metrics,13592000,Open,Minor,,13/Sep/24 02:32,,,"While investigating a production incident, we observed that some procedures are getting created but never getting executed until a HMaster failover. - master-2 was active & rs-1 holding meta - 18:40, bunch of RSs (~80) reported crashed & SCPs were created & being executed - 19:51, balancer decided to move Meta region to another RS -> TRSP created -> Meta region went offline - 19:52, RS carrying meta crashed -> SCP created - 19:52 - Both TRSP & SCP seemed stuck/not executing  - No more logs related to these procedures - 19:55 - RPC queue size slightly increased to ~700 - 21:09 - Master failed over from master-2 to master-3 - Procs were loaded from store & attached. - 21:17 -  When the TRSP for meta had completed, meta came back online. I will post the logs in some time. We have a theory that the TRSP & SCP related to meta were submitted but never got executed possibly due to sitting in procedure queue. HMaster thread dumps would have been helpful but unfortunately, one was not availble. We do have RPC queue metrics at high level but having Procedure queue metrics would holistically indicate what could have happened to the procedures." compactionsQueuedCount metric is not cleared on 'clear_compaction_queues',13591721,Open,Minor,,11/Sep/24 03:14,,,"h2. Problem Description Region-level {{compactionsQueuedCount}} metric is not reset when the compaction queue is cleared by {{clear_compaction_queues}} command on HBase shell. Also, the compaction state of the regions are not reset, and table.jsp page reports incorrect compaction state. h2. To reproduce Trigger compaction and clear the compaction queue while the compaction is in progress. h2. Cause The counters of HRegion are not updated accordingly when the queue is cleared. * {{compactionsQueued}} * {{majorInProgress}} * {{minorInProgress}}" HBase should support scan limit 0,13591484,Open,Minor,,09/Sep/24 10:53,,2.4.14,"When do scan use a sannner, but i set limit=0(some code logic cause...), but the scanner return result.... alought hbase shell convert limit 0 to limit -1, but it not tell user... but we also could set limit 0 when use client api so should support limit 0? when I execute SELECT ... LIMIT 0 on MySQL...it work fine, not resturn any result..." Remove some useless code and add some logs for CanaryTool,13590626,Resolved,Minor,Fixed,31/Aug/24 04:58,07/Sep/24 11:42,,"Remove some useless code in CanaryTool.sniff. Add some logs when get null location for table region." Log the IP when hbase.server.useip.enabled is set to true,13590034,Resolved,Minor,Fixed,26/Aug/24 08:36,31/Aug/24 18:10,2.6.0,"For HRegionServer#handleReportForDutyResponse, when the hostname is different from the regionserver and master side, both the two conditions should abort RS error message is corrected." Region normalizer should work in off peak if config,13586658,Open,Minor,,23/Jul/24 11:21,,,"Region normalizer involves the splitting and merging of regions, which can cause jitter in online services, especially when there are many region normalizer plans. We should run this task during off peak hours if config." [hbase-operator-tools] Enable infra automation: autolink to Jira and 'pull-request-available' label,13589235,Resolved,Minor,Fixed,18/Aug/24 17:42,21/Aug/24 14:07,,"Patterns like HBASE-28786 will be clickable, so it's easier to go to the Jira page. {{.asf.yaml}} provides an option to do this via config: See [https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AutolinksforJira] Even without manual configuring this already works for hbase somehow. See [https://github.com/apache/hbase/commits/master/] Maybe configured at repo level in INFRA? But same does not work for hbase-connectors and other repos. Will use this config to fix the issue. Also will enable label feature for 'pull-request-available', same as hbase main repo: HBASE-28325" [hbase-connectors] Enable infra automation: autolink to Jira and 'pull-request-available' label,13589168,Resolved,Minor,Fixed,17/Aug/24 12:13,18/Aug/24 17:41,,"Patterns like HBASE-28786 will be clickable, so it's easier to go to the Jira page. {{.asf.yaml}} provides an option to do this via config: See [https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-AutolinksforJira] Even without manual configuring this already works for hbase somehow. See [https://github.com/apache/hbase/commits/master/] Maybe configured at repo level in INFRA? But same does not work for hbase-connectors and other repos. Will use this config to fix the issue. Also will enable label feature for 'pull-request-available', same as hbase main repo: HBASE-28325" Fix classname for command: copyreppeers in bin/hbase,13589061,Resolved,Minor,Fixed,16/Aug/24 08:22,17/Aug/24 07:13,,"Stumbled upon this. Dug deeper seems during review we missed to rename the classname in bin/hbase when the actual class was renamed from ReplicationPeerMigrationTool -> CopyReplicationPeers   See https://github.com/apache/hbase/compare/69603351b3f2817c74d869d32da0596bab3c409e..1d11ce96c44277df6ccdd16ae2c9d8a1c419f3da [hbase@hostname~]$ hbase copyreppeers Error: Could not find or load main class org.apache.hadoop.hbase.replication.ReplicationPeerMigrationTool Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.replication.ReplicationPeerMigrationTool    FYI [~zhangduo] " Expose HTTP context in REST Client,13587402,Open,Minor,,31/Jul/24 06:51,,,"We already expose the Apache HTTP Client object in the REST client, but we specify the context for each call separately, so it is not possible to retrieve it. Add a getter and setter for the stickyContext object. The use case for this is copying session cookies between clients to avoid re-authentication by each client object, but this may also be useful for debugging purposes." Canary should not create RefreshCredentials chore if not in daemon mode,13588871,Open,Minor,,14/Aug/24 17:10,,,"For kerberos enabled clusters, on startup Canary.runMonitor [will create a chore service running a RefreshCredentials chore regardless of the canary mode|https://github.com/apache/hbase/blob/97de2912396d303b78a0d85552953e3e9955a145/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L1057-L1067]. The [documentation in the reference|https://hbase.apache.org/book.html#_running_canary_in_a_kerberos_enabled_cluster] for running a canary against kerberos enabled clusters specifies that the RefreshCredentials chore will only be created in daemon mode, which makes sense as the canary is intended to be long lived if run in daemon mode. If the canary is being run one off (not in daemon mode) it should be relatively short lived, the default canary timeout we have set is 10min, and should not require credential refresh if one has a sane kerberos ticket lifetime.  If we do see a need to keep that behavior then this can turn into a ticket to correct what's documented in the reference. " SLF4J: Class path contains multiple SLF4J bindings.,13587141,Resolved,Minor,Not A Bug,29/Jul/24 02:30,29/Jul/24 06:50,2.5.10,"SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/data/app/hadoop-3.3.6/share/hadoop/common/lib/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/data/app/hbase-2.5.10/lib/client-facing-thirdparty/log4j-slf4j-impl-2.17.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See [http://www.slf4j.org/codes.html#multiple_bindings] for an explanation.   The above log dependency conflict causes the regionserver to be unable to output logs after it is started. By default, in the hbase script file in the bin directory, the value of HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP is true, which will append the hadoop lib to the classpath. In this way, after the hbase process is started, the hadoop jar will be loaded, which may cause dependency conflicts. Is it possible to set the variable HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP in the hbase-env.sh file, set the default value to true, and only modify this value to false when necessary?" Users of QuotaRetriever should pass an existing connection,13585022,Resolved,Minor,Fixed,08/Jul/24 13:36,24/Jul/24 11:03,,"Every call to {{HBaseAdmin#getQuota()}} opens a new {{Connection}}, and then closes it. As far as I can tell, this is pointless, since it could use the existing {{Connection}} object held by the {{HBaseAdmin}}. If you have a custom RpcClient (like we do at Hubspot), new connections have an expense that we'd rather not pay unnecessarily. I'll submit a PR that addresses this situation and similar ones." Remove the duplicate configurations named hbase.wal.batch.size,13586518,Resolved,Minor,Fixed,22/Jul/24 10:14,23/Jul/24 02:20,3.0.0-beta-1,"The following code appears in two places: AsyncFSWAL and AbstractFSWAL {code:java} public static final String WAL_BATCH_SIZE = ""hbase.wal.batch.size""; public static final long DEFAULT_WAL_BATCH_SIZE = 64L * 1024; {code}" Improve HBase shell snapshot command Doc with TTL option ,13585970,Resolved,Minor,Fixed,16/Jul/24 09:39,22/Jul/24 01:13,,"The current HBase shell snapshot command allows users to create a snapshot of a specific table. While this command is useful, it could be enhanced by adding a TTL (Time-to-Live) option. This would allow users to specify a time period after which the snapshot would automatically be deleted. I propose we introduce a TTL option in the snapshot command doc as follows: hbase> snapshot 'sourceTable', 'snapshotName', \{TTL => '7d'} This would create a snapshot of 'sourceTable' called 'snapshotName' that would automatically be deleted after 7 days. The addition document of a TTL option would provide a better user experience and assist with efficient storage management." Default Zookeeper ConnectionRegistry APIs timeout should be less,13586392,Resolved,Minor,Fixed,19/Jul/24 19:13,20/Jul/24 01:03,,"HBASE-28428 introduces timeout for Zookeeper ConnectionRegistry APIs. However, the default timeout value we have set is 60s. Given that connection registry are metadata APIs, they should have much lesser timeout value, including default. Let's set default timeout to 10s." Update downloads.xml for 2.5.9,13586179,Resolved,Minor,Fixed,17/Jul/24 19:53,17/Jul/24 19:56,, SteppingSplitPolicy may not work when table enables region replication,13585676,Resolved,Minor,Fixed,13/Jul/24 05:18,15/Jul/24 14:29,2.4.13,"Reproduction: 1. Create a table with region replication, and ensure that the primary region and replica region are on the same RS (eg: the HBase cluster has only one RS) create 't01', 'info', \{REGION_REPLICATION => 2} 2. The first region does not split when storefile size exceed  flushsize * 2, because that we get 2 regions about this table on this RS (1 primary region and 1 replica region)   I think we should ignore the replica reggion when getting the count of regions on this same regionserver. Is my idea correct? maybe can discuss it ." Merge repairs always fail to restore the BackupSystemTable snapshot,13585195,Open,Minor,,09/Jul/24 15:39,,2.6.0,"In `BackupCommands.RepairCommand#execute`, the following code block is present: {code:java} repairFailedBackupDeletionIfAny(conn, sysTable); repairFailedBackupMergeIfAny(conn, sysTable); {code} Both of these methods can be sketched as: {code:java} if (there are no unresolved merges/deletes) {    BackupSystemTable.deleteSnapshot(conn); } else {    BackupSystemTable.restoreFromSnapshot(conn); retry merge/delete }{code} In case of failed merges, there will be no unresolved deletes, hence the BackupSystemTable snapshot will be deleted. As a result, the restore for the merges will always fail. Currently unsure what the risks of this are, haven't explored the merge code yet. Update: it looks like the merge code doesn't create a BackupSystemTable snapshot. So the restore/delete snapshot for the merge method is pointless." Ignored flags in Yetus nightly runs,13593469,Open,Trivial,,27/Sep/24 07:18,,,"{noformat} 22:08:23 | -0 | yetus | 0m 6s | Unprocessed flag(s): 22:08:23 | | | | --blanks-tabs-ignore-file 22:08:23 | | | | --blanks-eol-ignore-file 22:08:23 | | | | --author-ignore-list {noformat} The flags seem to be still present in the Yetus source code. Maybe the modules are no longer getting activated ?" Add logging for WALs not closed properly,13589276,Open,Trivial,,19/Aug/24 08:17,,,In continuation to [HBASE-28665|https://issues.apache.org/jira/browse/HBASE-28665] . I am planning to add logging to get better understanding on if the wal was not archived because of unflushed entries or wal closure failure [hbase-connectors] Use log4j2 instead of log4j for logging,13537466,Resolved,Blocker,Fixed,24/May/23 10:33,10/Aug/23 12:21,,Move to log4j2 in hbase-connectors. [Close-WAL-Writer-178] wal.AsyncFSWAL: close old writer failed,13538477,Open,Critical,,02/Jun/23 00:13,,2.2.2,"*HBase Log：* 2023-06-02 08:07:57,423 INFO  [Close-WAL-Writer-177] util.FSHDFSUtils: Recover lease on dfs file /hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664417370 2023-06-02 08:07:57,425 INFO  [Close-WAL-Writer-177] util.FSHDFSUtils: Failed to recover lease, attempt=0 on file=/hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664417370 after 2ms 2023-06-02 08:08:01,427 WARN  [Close-WAL-Writer-177] wal.AsyncFSWAL: close old writer failed java.io.FileNotFoundException: File does not exist: /hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664417370         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:72)         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:62)         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.recoverLease(FSNamesystem.java:2358)         at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.recoverLease(NameNodeRpcServer.java:790)         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.recoverLease(ClientNamenodeProtocolServerSideTranslatorPB.java:693)         at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:503)         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:871)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:817)         at java.security.AccessController.doPrivileged(Native Method)         at javax.security.auth.Subject.doAs(Subject.java:422)         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1893)         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2606)         at sun.reflect.GeneratedConstructorAccessor33.newInstance(Unknown Source)         at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)         at java.lang.reflect.Constructor.newInstance(Constructor.java:423)         at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:121)         at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:88)         at org.apache.hadoop.hdfs.DFSClient.recoverLease(DFSClient.java:867)         at org.apache.hadoop.hdfs.DistributedFileSystem$3.doCall(DistributedFileSystem.java:304)         at org.apache.hadoop.hdfs.DistributedFileSystem$3.doCall(DistributedFileSystem.java:301)         at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)         at org.apache.hadoop.hdfs.DistributedFileSystem.recoverLease(DistributedFileSystem.java:301)         at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverLease(FSHDFSUtils.java:283)         at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverDFSFileLease(FSHDFSUtils.java:216)         at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverFileLease(FSHDFSUtils.java:163)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.recoverAndClose(FanOutOneBlockAsyncDFSOutput.java:559)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:157)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664417370         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:72)         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:62)         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.recoverLease(FSNamesystem.java:2358)         at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.recoverLease(NameNodeRpcServer.java:790)         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.recoverLease(ClientNamenodeProtocolServerSideTranslatorPB.java:693)         at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:503)         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:871)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:817)         at java.security.AccessController.doPrivileged(Native Method)         at javax.security.auth.Subject.doAs(Subject.java:422)         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1893)         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2606)         at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1489)         at org.apache.hadoop.ipc.Client.call(Client.java:1435)         at org.apache.hadoop.ipc.Client.call(Client.java:1345)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116)         at com.sun.proxy.$Proxy19.recoverLease(Unknown Source)         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.recoverLease(ClientNamenodeProtocolTranslatorPB.java:626)         at sun.reflect.GeneratedMethodAccessor124.invoke(Unknown Source)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409)         at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)         at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)         at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)         at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346)         at com.sun.proxy.$Proxy20.recoverLease(Unknown Source)         at sun.reflect.GeneratedMethodAccessor124.invoke(Unknown Source)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:372)         at com.sun.proxy.$Proxy21.recoverLease(Unknown Source)         at org.apache.hadoop.hdfs.DFSClient.recoverLease(DFSClient.java:865)         ... 13 more 2023-06-02 08:09:27,452 INFO  [regionserver/bdpprd07:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664477406 with entries=0, filesize=90 B; new WAL /hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664567427 2023-06-02 08:09:27,452 WARN  [Close-WAL-Writer-178] wal.AbstractProtobufLogWriter: Failed to write trailer, non-fatal, continuing... java.io.IOException: stream already broken         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush0(FanOutOneBlockAsyncDFSOutput.java:424)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush(FanOutOneBlockAsyncDFSOutput.java:513)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.lambda$writeWALTrailerAndMagic$3(AsyncProtobufLogWriter.java:220)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.write(AsyncProtobufLogWriter.java:176)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeWALTrailerAndMagic(AsyncProtobufLogWriter.java:211)         at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.writeWALTrailer(AbstractProtobufLogWriter.java:235)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:153)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-06-02 08:09:27,452 INFO  [regionserver/bdpprd07:16020.logRoller] wal.AbstractFSWAL: Archiving hdfs://xsbhdfs/hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664477406 to hdfs://xsbhdfs/hbase/oldWALs/bdpprd07%2C16020%2C1685646099569.1685664477406 2023-06-02 08:09:27,452 WARN  [Close-WAL-Writer-178] wal.AsyncProtobufLogWriter: normal close failed, try recover java.io.IOException: stream already broken         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.endBlock(FanOutOneBlockAsyncDFSOutput.java:521)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.close(FanOutOneBlockAsyncDFSOutput.java:569)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:154)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-06-02 08:09:27,452 INFO  [Close-WAL-Writer-178] util.FSHDFSUtils: Recover lease on dfs file /hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664477406 2023-06-02 08:09:27,454 INFO  [Close-WAL-Writer-178] util.FSHDFSUtils: Failed to recover lease, attempt=0 on file=/hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664477406 after 2ms 2023-06-02 08:09:31,718 WARN  [Close-WAL-Writer-178] wal.AsyncFSWAL: close old writer failed java.io.FileNotFoundException: File does not exist: /hbase/WALs/bdpprd07,16020,1685646099569/bdpprd07%2C16020%2C1685646099569.1685664477406         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:72)         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:62)         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.recoverLease(FSNamesystem.java:2358)         at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.recoverLease(NameNodeRpcServer.java:790)         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.recoverLease(ClientNamenodeProtocolServerSideTranslatorPB.java:693)         at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:503)         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:989)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:871)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:817)         at java.security.AccessController.doPrivileged(Native Method)         at javax.security.auth.Subject.doAs(Subject.java:422)         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1893)         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2606)         at sun.reflect.GeneratedConstructorAccessor33.newInstance(Unknown Source)         at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)         at java.lang.reflect.Constructor.newInstance(Constructor.java:423)         at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:121)         at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:88)         at org.apache.hadoop.hdfs.DFSClient.recoverLease(DFSClient.java:867)         at org.apache.hadoop.hdfs.DistributedFileSystem$3.doCall(DistributedFileSystem.java:304)         at org.apache.hadoop.hdfs.DistributedFileSystem$3.doCall(DistributedFileSystem.java:301)         at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)         at org.apache.hadoop.hdfs.DistributedFileSystem.recoverLease(DistributedFileSystem.java:301)         at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverLease(FSHDFSUtils.java:283)         at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverDFSFileLease(FSHDFSUtils.java:216)         at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverFileLease(FSHDFSUtils.java:163)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.recoverAndClose(FanOutOneBlockAsyncDFSOutput.java:559)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:157)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748)" Possible memory leak in MemStoreLAB implementation,13540645,Open,Critical,,19/Jun/23 15:35,,,"We got this error message when running ITBLL against branch-3. {noformat} 2023-06-09 14:44:15,386 ERROR [regionserver/core-1-2:16020-shortCompactions-0] util.ResourceLeakDetector: LEAK: RefCnt.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information. Recent access records: Created at: org.apache.hadoop.hbase.nio.RefCnt.(RefCnt.java:59) org.apache.hadoop.hbase.nio.RefCnt.create(RefCnt.java:54) org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.(MemStoreLABImpl.java:108) sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source) sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) java.lang.reflect.Constructor.newInstance(Constructor.java:423) org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:55) org.apache.hadoop.hbase.util.ReflectionUtils.instantiateWithCustomCtor(ReflectionUtils.java:43) org.apache.hadoop.hbase.regionserver.MemStoreLAB.newInstance(MemStoreLAB.java:116) org.apache.hadoop.hbase.regionserver.SegmentFactory.createMutableSegment(SegmentFactory.java:81) org.apache.hadoop.hbase.regionserver.AbstractMemStore.resetActive(AbstractMemStore.java:93) org.apache.hadoop.hbase.regionserver.AbstractMemStore.(AbstractMemStore.java:83) org.apache.hadoop.hbase.regionserver.DefaultMemStore.(DefaultMemStore.java:79) sun.reflect.GeneratedConstructorAccessor12.newInstance(Unknown Source) sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) java.lang.reflect.Constructor.newInstance(Constructor.java:423) org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:55) org.apache.hadoop.hbase.util.ReflectionUtils.newInstance(ReflectionUtils.java:92) org.apache.hadoop.hbase.regionserver.HStore.getMemstore(HStore.java:377) org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:283) org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6904) org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1173) org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1170) java.util.concurrent.FutureTask.run(FutureTask.java:266) java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) java.util.concurrent.FutureTask.run(FutureTask.java:266) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:750) {noformat} Need to dig more." RegionServer OOM under load when TLS is enabled,13541080,Resolved,Critical,Fixed,22/Jun/23 18:45,18/Aug/23 14:21,2.6.0,"We are rolling out the server side TLS settings to all of our QA clusters. This has mostly gone fine, except on 1 cluster. Most clusters, including this one have a sampled {{nettyDirectMemory}} usage of about 30-100mb. This cluster tends to get bursts of traffic, in which case it would typically jump to 400-500mb. Again this is sampled, so it could have been higher than that. When we enabled SSL on this cluster, we started seeing bursts up to at least 4gb. This exceeded our {{{}-XX:MaxDirectMemorySize{}}}, which caused OOM's and general chaos on the cluster.   We've gotten it under control a little bit by setting {{-Dorg.apache.hbase.thirdparty.io.netty.maxDirectMemory}} and {{{}-Dorg.apache.hbase.thirdparty.io.netty.tryReflectionSetAccessible{}}}. We've set netty's maxDirectMemory to be approx equal to ({{{}-XX:MaxDirectMemorySize - BucketCacheSize - ReservoirSize{}}}). Now we are seeing netty's own OutOfDirectMemoryError, which is still causing pain for clients but at least insulates the other components of the regionserver.   We're still digging into exactly why this is happening. The cluster clearly has a bad access pattern, but it doesn't seem like SSL should increase the memory footprint by 5-10x like we're seeing." HConnection (and ZookeeprWatcher threads) leak in case of AUTH_FAILED exception.,13542149,Open,Critical,,30/Jun/23 20:49,,1.7.2,"Observed this in production environment running some version of 1.7 release. Application didn't had the right keytab setup for authentication. Application was trying to create HConnection and zookeeper server threw AUTH_FAILED exception. After few hours of application in this state, saw thousands of zk-event-processor thread with below stack trace. {noformat} ""zk-event-processor-pool1-t1"" #1275 daemon prio=5 os_prio=0 cpu=1.04ms elapsed=41794.58s tid=0x00007fd7805066d0 nid=0x1245 waiting on condition [0x00007fd75df01000] java.lang.Thread.State: WAITING (parking) at jdk.internal.misc.Unsafe.park(java.base@11.0.18.0.102/Native Method) - parking to wait for <0x00007fd9874a85e0> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) at java.util.concurrent.locks.LockSupport.park(java.base@11.0.18.0.102/LockSupport.java:194) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(java.base@11.0.18.0.102/AbstractQueuedSynchronizer.java:2081) at java.util.concurrent.LinkedBlockingQueue.take(java.base@11.0.18.0.102/LinkedBlockingQueue.java:433) at java.util.concurrent.ThreadPoolExecutor.getTask(java.base@11.0.18.0.102/ThreadPoolExecutor.java:1054) at java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.18.0.102/ThreadPoolExecutor.java:1114) at java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.18.0.102/ThreadPoolExecutor.java:628) {noformat} {code:java|title=ConnectionManager.java|borderStyle=solid} HConnectionImplementation(Configuration conf, boolean managed, ExecutorService pool, User user, String clusterId) throws IOException { ... ... try { this.registry = setupRegistry(); retrieveClusterId(); ... ... } catch (Throwable e) { // avoid leaks: registry, rpcClient, ... LOG.debug(""connection construction failed"", e); close(); throw e; } {code} retrieveClusterId internally calls ZKConnectionRegistry#getClusterId {code:java|title=ZKConnectionRegistry.java|borderStyle=solid} private String clusterId = null; @Override public String getClusterId() { if (this.clusterId != null) return this.clusterId; // No synchronized here, worse case we will retrieve it twice, that's // not an issue. try (ZooKeeperKeepAliveConnection zkw = hci.getKeepAliveZooKeeperWatcher()) { this.clusterId = ZKClusterId.readClusterIdZNode(zkw); if (this.clusterId == null) { LOG.info(""ClusterId read in ZooKeeper is null""); } } catch (KeeperException | IOException e) { ---> WE ARE SWALLOWING THIS EXCEPTION AND RETURNING NULL. LOG.warn(""Can't retrieve clusterId from Zookeeper"", e); } return this.clusterId; } {code} ZkConnectionRegistry#getClusterId threw the following exception.(Our logging system trims stack traces longer than 5 lines.) {noformat} Cause: org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode = AuthFailed for /hbase/hbaseid StackTrace: org.apache.zookeeper.KeeperException.create(KeeperException.java:126) org.apache.zookeeper.KeeperException.create(KeeperException.java:54) org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1213) org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:285) org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:470) {noformat} We should throw KeeperException from ZKConnectionRegistry#getClusterId all the way back to HConnectionImplementation constructor to close all the watcher threads and throw the exception back to the caller. " AssertionError in AsyncRequestFutureImpl when timing out during location resolution,13531677,Patch Available,Major,,06/Apr/23 01:08,,,"In AsyncFutureRequestImpl we fail fast when operation timeout is exceeded during location resolution [here|https://github.com/apache/hbase/blob/branch-2.5/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java#L460-L462]. In that handling, we loop all actions and set them as failed. The problem is, some number of actions may already finished when we get to this spot. So the actionsInProgress would have been decremented for those already, and now we're going to decrement by all actions. This causes an assertion error since we go negative [here|https://github.com/apache/hbase/blob/branch-2.5/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java#L1197], causing the HBase client to throw an unchecked exception which can kill the caller thread that invoked the operation which should have timed out, as callers of the client should not be catching {{Error}} and its subclasses like {{AssertionError}}. We still want to fail all actions, because none will be executed. But we need special handling to avoid this case. Maybe don't bother decrementing the actionsInProgress at all, instead set to 0." Define RPC API for cache cleaning,13532647,Resolved,Major,Abandoned,14/Apr/23 10:31,17/Dec/24 11:09,,"We should add an RPC API to allow for a ""limited manual"" cache cleaning. If hbase.rs.evictblocksonclose is set to false, blocks may hang in the cache upon regions move between RSes. The method at the RS level, should compare the files from its online regions against the files in the prefetch list file, evicting blocks from the files in the prefetch list file that are not in any of the online regions for the given RS." DBB release too early for replication,13539962,Open,Major,,14/Jun/23 04:41,,2.4.17,"When the RS of destination cluster acts as client to forward the replicated entries and encounters exception, the DBB will be released too early by calling RpcResponse#done() in NettyRpcServerResponseEncoder. The coredump and log details are as follows, {code:java} Stack: [0x00007f92d9e6d000,0x00007f92d9f6e000],  sp=0x00007f92d9f6be18,  free space=1019kNative frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)C  [libc.so.6+0x89db4]  _wordcopy_fwd_dest_aligned+0xd4 Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)J 3297  sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007fad7d9aa267 [0x00007fad7d9aa200+0x67]j  org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36j  org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69j  org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39j  org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31J 15658 C1 org.apache.hadoop.hbase.CellUtil.cloneQualifier(Lorg/apache/hadoop/hbase/Cell;)[B (18 bytes) @ 0x00007fad7e9a6c2c [0x00007fad7e9a6aa0+0x18c]j  org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B+1j  org.apache.hadoop.hbase.client.Mutation.cellToStringMap(Lorg/apache/hadoop/hbase/Cell;)Ljava/util/Map;+12j  org.apache.hadoop.hbase.client.Mutation.toMap(I)Ljava/util/Map;+189j  org.apache.hadoop.hbase.client.Operation.toJSON(I)Ljava/lang/String;+2j  org.apache.hadoop.hbase.client.Operation.toString(I)Ljava/lang/String;+2j  org.apache.hadoop.hbase.client.Operation.toString()Ljava/lang/String;+2J 8353 C2 java.lang.StringBuilder.append(Ljava/lang/Object;)Ljava/lang/StringBuilder; (9 bytes) @ 0x00007fad7ea0a1bc [0x00007fad7ea0a180+0x3c]j  org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.manageLocationError(Lorg/apache/hadoop/hbase/client/Action;Ljava/lang/Exception;)V+28j  org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.groupAndSendMultiAction(Ljava/util/List;I)V+163J 23463 C2 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.resubmit(Lorg/apache/hadoop/hbase/ServerName;Ljava/util/List;IILjava/lang/Throwable;)V (214 bytes) @ 0x00007fad80effb54 [0x00007fad80eff7a0+0x3b4]J 19097 C2 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.receiveGlobalFailure(Lorg/apache/hadoop/hbase/client/MultiAction;Lorg/apache/hadoop/hbase/ServerName;ILjava/lang/Throwable;Z)V (312 bytes) @ 0x00007fad7ff53370 [0x00007fad7ff52fa0+0x3d0]J 20201 C1 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.access$1600(Lorg/apache/hadoop/hbase/client/AsyncRequestFutureImpl;Lorg/apache/hadoop/hbase/client/MultiAction;Lorg/apache/hadoop/hbase/ServerName;ILjava/lang/Throwable;Z)V (12 bytes) @ 0x00007fad803f31dc [0x00007fad803f3180+0x5c]J 18619 C2 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl$SingleServerRequestRunnable.run()V (677 bytes) @ 0x00007fad7f40a8b4 [0x00007fad7f409160+0x1754]J 13220 C2 java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V (225 bytes) @ 0x00007fad7f3b3a28 [0x00007fad7f3b38a0+0x188]J 10884 C1 java.util.concurrent.ThreadPoolExecutor$Worker.run()V (9 bytes) @ 0x00007fad7db53c44 [0x00007fad7db53b40+0x104]J 7961 C1 java.lang.Thread.run()V (17 bytes) @ 0x00007fad7d61bbfc [0x00007fad7d61bac0+0x13c]v  ~StubRoutines::call_stubStack: [0x00007f92d9e6d000,0x00007f92d9f6e000],  sp=0x00007f92d9f6be18,  free space=1019kNative frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)C  [libc.so.6+0x89db4]  _wordcopy_fwd_dest_aligned+0xd4 Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)J 3297  sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007fad7d9aa267 [0x00007fad7d9aa200+0x67]j  org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36j  org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69j  org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39j  org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31J 15658 C1 org.apache.hadoop.hbase.CellUtil.cloneQualifier(Lorg/apache/hadoop/hbase/Cell;)[B (18 bytes) @ 0x00007fad7e9a6c2c [0x00007fad7e9a6aa0+0x18c]j  org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B+1j  org.apache.hadoop.hbase.client.Mutation.cellToStringMap(Lorg/apache/hadoop/hbase/Cell;)Ljava/util/Map;+12j  org.apache.hadoop.hbase.client.Mutation.toMap(I)Ljava/util/Map;+189j  org.apache.hadoop.hbase.client.Operation.toJSON(I)Ljava/lang/String;+2j  org.apache.hadoop.hbase.client.Operation.toString(I)Ljava/lang/String;+2j  org.apache.hadoop.hbase.client.Operation.toString()Ljava/lang/String;+2J 8353 C2 java.lang.StringBuilder.append(Ljava/lang/Object;)Ljava/lang/StringBuilder; (9 bytes) @ 0x00007fad7ea0a1bc [0x00007fad7ea0a180+0x3c]j  org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.manageLocationError(Lorg/apache/hadoop/hbase/client/Action;Ljava/lang/Exception;)V+28j  org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.groupAndSendMultiAction(Ljava/util/List;I)V+163J 23463 C2 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.resubmit(Lorg/apache/hadoop/hbase/ServerName;Ljava/util/List;IILjava/lang/Throwable;)V (214 bytes) @ 0x00007fad80effb54 [0x00007fad80eff7a0+0x3b4]J 19097 C2 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.receiveGlobalFailure(Lorg/apache/hadoop/hbase/client/MultiAction;Lorg/apache/hadoop/hbase/ServerName;ILjava/lang/Throwable;Z)V (312 bytes) @ 0x00007fad7ff53370 [0x00007fad7ff52fa0+0x3d0]J 20201 C1 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.access$1600(Lorg/apache/hadoop/hbase/client/AsyncRequestFutureImpl;Lorg/apache/hadoop/hbase/client/MultiAction;Lorg/apache/hadoop/hbase/ServerName;ILjava/lang/Throwable;Z)V (12 bytes) @ 0x00007fad803f31dc [0x00007fad803f3180+0x5c]J 18619 C2 org.apache.hadoop.hbase.client.AsyncRequestFutureImpl$SingleServerRequestRunnable.run()V (677 bytes) @ 0x00007fad7f40a8b4 [0x00007fad7f409160+0x1754]J 13220 C2 java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V (225 bytes) @ 0x00007fad7f3b3a28 [0x00007fad7f3b38a0+0x188]J 10884 C1 java.util.concurrent.ThreadPoolExecutor$Worker.run()V (9 bytes) @ 0x00007fad7db53c44 [0x00007fad7db53b40+0x104]J 7961 C1 java.lang.Thread.run()V (17 bytes) @ 0x00007fad7d61bbfc [0x00007fad7d61bac0+0x13c]v  ~StubRoutines::call_stub {code} {code:java} 2023-06-13 09:04:08,106 ERROR [RpcServer.replication.FPBQ.Fifo.handler=9,queue=0,port=16020] regionserver.ReplicationSink: Unable to accept edit because: org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 816 actions: NotServingRegionException: 816 times, servers with issues: XXXXXX,XXXX,1686558427722,         at org.apache.hadoop.hbase.client.BatchErrors.makeException(BatchErrors.java:53)         at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.getErrors(AsyncRequestFutureImpl.java:1309)         at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:936)         at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:927)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.batch(ReplicationSink.java:434)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(ReplicationSink.java:261)         at org.apache.hadoop.hbase.replication.regionserver.Replication.replicateLogEntries(Replication.java:187)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.replicateWALEntry(RSRpcServices.java:2094)         at org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:32335)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:396)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:103)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:83) {code}" Update hadoop.version from 3.3.5 to 3.3.6,13540084,Resolved,Major,Duplicate,14/Jun/23 18:04,10/Oct/24 07:46,,"HBase's default Hadoop3 version is 3.2.4 but HBase already supports Haddoop 3.3.x. Hadoop 3.2 line has not been updated for over a year. It is perhaps the time to update the Hadoop dependency to the 3.3.x line. (I'll start a DISCUSS thread if the test goes well) 3.3.6 RC is out which fixed a bunch of CVEs and I'd like to test HBase against it. Additionally, Hadoop 3.3.6 will permit us to use non-HDFS as WAL storage." Region split and merge time while offline is O(n) with respect to number of store files,13534853,Open,Major,,03/May/23 16:07,,2.5.4,"This is a significant availability issue when HFiles are on S3. = HBASE-26079 ({_}Use StoreFileTracker when splitting and merging{_}) changed the split and merge table procedure implementations to indirect through the StoreFileTracker implementation when selecting HFiles to be merged or split, rather than directly listing those using file system APIs. It also changed the commit logic in HRegionFileSystem to add the link/ref files on resulting split or merged regions to the StoreFileTracker. However, the creation of a link file is still a filesystem operation and creating a “file” on S3 can take well over a second. If, for example there are 20 store files in a region, which is not uncommon, after the region is taken offline for a split (or merge) it may require more than 20 seconds to create the link files before the results can be brought back online, creating a severe availability problem. Splits and merges are supposed to be fast, completing in less than a second, certainly less than a few seconds. This has been true when HFiles are stored on HDFS only because file creation operations there are nearly instantaneous.  There are two issues but both can be handled with modifications to the store file tracker interface and the file based store file tracker implementation.  When the file based store file file tracker is enabled the HFile links should be virtual entities that only exist in the file manifest. We do not require physical files in the filesystem to serve as links now. That is the magic of the this file tracker, the manifest file replaces requirements to list the filesystem. Then, when splitting or merging, the HFile links should be collected into a list and committed in one batch using a new FILE file tracker interface, requiring only one update of the manifest file in S3, bringing the time requirement for this operation to O(1) down from O[n]." [JDK17] Add JDK17 compilation and unit test support to nightly job,13541132,Resolved,Major,Fixed,23/Jun/23 07:43,02/Mar/24 06:22,, FileBasedStoreFileTracker v2 ,13535039,Open,Major,,04/May/23 17:39,,,"Umbrella for considering a file-based SFT version 2, consolidating format changes, requiring migration." "wal.AbstractProtobufLogWriter: Failed to write trailer, non-fatal, continuing",13537535,Open,Major,,24/May/23 19:39,,2.2.2,"2023-05-25 03:35:58,546 INFO  [qtp772147225-791] hfile.CacheConfig: Created cacheConfig: cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false with blockCache=null 2023-05-25 03:36:20,083 INFO  [regionserver/bdp04:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956800003 with entries=11, filesize=64.23 KB; new WAL /hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956980051 2023-05-25 03:36:20,083 WARN  [Close-WAL-Writer-9]{color:#de350b} *wal.AbstractProtobufLogWriter: Failed to write trailer, non-fatal, continuing...*{color} *{color:#de350b}java.io.IOException: stream already broken{color}*         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush0(FanOutOneBlockAsyncDFSOutput.java:424)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush(FanOutOneBlockAsyncDFSOutput.java:513)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.lambda$writeWALTrailerAndMagic$3(AsyncProtobufLogWriter.java:220)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.write(AsyncProtobufLogWriter.java:176)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeWALTrailerAndMagic(AsyncProtobufLogWriter.java:211)         at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.writeWALTrailer(AbstractProtobufLogWriter.java:235)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:153)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-05-25 03:36:20,084 WARN  [Close-WAL-Writer-9] {color:#de350b}*wal.AsyncProtobufLogWriter: normal close failed, try recover*{color} java.io.IOException: stream already broken         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.endBlock(FanOutOneBlockAsyncDFSOutput.java:521)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.close(FanOutOneBlockAsyncDFSOutput.java:569)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:154)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-05-25 03:36:20,084 INFO  [Close-WAL-Writer-9] util.FSHDFSUtils:{color:#de350b} Recover lease on dfs file /hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956800003{color} 2023-05-25 03:36:20,087 INFO  [Close-WAL-Writer-9] util.FSHDFSUtils:{color:#de350b} Failed to recover lease, attempt=0 on file=/hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956800003 after 3ms{color} 2023-05-25 03:36:24,010 INFO  [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=3.45 MB, freeSize=3.16 GB, max=3.16 GB, blockCount=2, accesses=23184, hits=23184, hitRatio=100.00%, , cachingAccesses=23172, cachingHits=23172, cachingHitsRatio=100.00%, evictions=209, evicted=0, evictedPerRun=0.0 2023-05-25 03:36:24,088 INFO  [Close-WAL-Writer-9] util.FSHDFSUtils: Recovered lease, attempt=1 on file=/hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956800003 after 4004ms 2023-05-25 03:36:24,623 INFO  [BucketCacheStatsExecutor] bucket.BucketCache: failedBlockAdditions=0, totalSize=3.99 GB, freeSize=3.99 GB, usedSize=99 KB, cacheSize=58.92 KB, accesses=30276, hits=271, IOhitsPerSecond=1, IOTimePerHit=0.03, hitRatio=0.90%, cachingAccesses=298, cachingHits=259, cachingHitsRatio=86.91%, evictions=0, evicted=8, evictedPerRun=0.0 2023-05-25 03:38:08,248 WARN  [AsyncFSWAL-0] wal.AsyncFSWAL: sync failed java.io.IOException: stream already broken         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush0(FanOutOneBlockAsyncDFSOutput.java:424)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush(FanOutOneBlockAsyncDFSOutput.java:513)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.sync(AsyncProtobufLogWriter.java:144)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:352)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.consume(AsyncFSWAL.java:539)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-05-25 03:38:08,300 INFO  [regionserver/bdp04:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956980051 with entries=7, filesize=57.58 KB; new WAL /hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684957088248 2023-05-25 03:38:08,301 WARN  [Close-WAL-Writer-10] wal.AbstractProtobufLogWriter: Failed to write trailer, non-fatal, continuing... java.io.IOException: stream already broken         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush0(FanOutOneBlockAsyncDFSOutput.java:424)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.flush(FanOutOneBlockAsyncDFSOutput.java:513)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.lambda$writeWALTrailerAndMagic$3(AsyncProtobufLogWriter.java:220)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.write(AsyncProtobufLogWriter.java:176)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeWALTrailerAndMagic(AsyncProtobufLogWriter.java:211)         at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.writeWALTrailer(AbstractProtobufLogWriter.java:235)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:153)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-05-25 03:38:08,301 WARN  [Close-WAL-Writer-10] wal.AsyncProtobufLogWriter: normal close failed, try recover java.io.IOException: stream already broken         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.endBlock(FanOutOneBlockAsyncDFSOutput.java:521)         at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.close(FanOutOneBlockAsyncDFSOutput.java:569)         at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.close(AsyncProtobufLogWriter.java:154)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.lambda$closeWriter$6(AsyncFSWAL.java:646)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-05-25 03:38:08,302 INFO  [Close-WAL-Writer-10] util.FSHDFSUtils: Recover lease on dfs file /hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956980051 2023-05-25 03:38:08,304 INFO  [Close-WAL-Writer-10] util.FSHDFSUtils: Failed to recover lease, attempt=0 on file=/hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956980051 after 2ms 2023-05-25 03:38:12,306 INFO  [Close-WAL-Writer-10] util.FSHDFSUtils: Recovered lease, attempt=1 on file=/hbase/WALs/bdp04,16020,1684954879778/bdp04%2C16020%2C1684954879778.1684956980051 after 4004ms 2023-05-25 03:41:24,010 INFO  [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=3.45 MB, freeSize=3.16 GB, max=3.16 GB, blockCount=2, accesses=23193, hits=23193, hitRatio=100.00%, , cachingAccesses=23181, cachingHits=23181, cachingHitsRatio=100.00%, evictions=239, evicted=0, evictedPerRun=0.0" Bump up jruby to 9.4.2.0 and related joni and jcodings to 2.1.48 and 1.0.58 respectively,13539140,Resolved,Major,Duplicate,07/Jun/23 19:22,16/Dec/23 13:38,3.0.0-alpha-4,"Current version of *jruby* (9.3.9.0) has snakeyaml dependency version 1.33. {code:java} > find ./jruby-complete-9.3.9.0/ -name ""*snakeyaml*"" ./jruby-complete-9.3.9.0/META-INF/jruby.home/lib/ruby/stdlib/org/yaml/snakeyaml ./jruby-complete-9.3.9.0/META-INF/jruby.home/lib/ruby/stdlib/org/yaml/snakeyaml/1.33/snakeyaml-1.33.jar {code} *snakeyaml-1.33* has a critical CVE [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-1471]  {*}jruby-complete-9.4.2{*}{*}.0{*} uses {*}snakeyaml-engine-2.6{*}." NettyRpcServer may hange if it should skip initial sasl handshake,13539372,Resolved,Major,Fixed,09/Jun/23 06:09,12/Jun/23 07:16,2.6.0,"{{NettyRpcServer}} may hange if it should skip initial sasl handshake when server does not enable security and client enables security, I think this problem is caused by two reasons： * For Server: The type of the response is {{RpcResponse}}, but for {{NettyRpcServerPreambleHandler}},when it send {{RpcResponse}} ,{{NettyRpcServerResponseEncoder}} does not exist, so {{RpcResponse}} messages cannot be sent. * For Client When {{NettyHBaseSaslRpcClientHandler}} receives {{SaslUtil.SWITCH_TO_SIMPLE_AUTH}}, it does not remove {{SaslChallengeDecoder}} and {{NettyHBaseSaslRpcClientHandler}}, so the latter responses are considered to be incorrect. " RpcThrottlingException wait interval message is misleading between 0-1s,13532802,Resolved,Major,Fixed,16/Apr/23 19:48,04/May/23 18:40,,"When the wait interval is below 1s, it shows 0sec. We should show milliseconds." Add client side table metrics for rpc calls and request latency.,13535578,Open,Major,,10/May/23 03:17,,3.0.0-alpha-3,"Now we can get client metrics to see number of calls or latency of related RPC calls like get, mutate, scan etc... But more often, we are more concerned about table level metrics, so we need to subdivide them." Add support for default user quotas,13532804,Resolved,Major,Fixed,16/Apr/23 20:10,07/Feb/24 15:16,,"If someone sets a quota with USER => 'all' (or maybe '*'), treat that as a default quota for each individual user. When a request comes from a user, it will lookup current QuotaState based on username. If one doesn't exist, it will be pre-filled with whatever the 'all' quota was set to. Otherwise, if you then define a quota for a specific user that will override whatever default you have set for that user only." support quota user overrides,13531946,Resolved,Major,Fixed,08/Apr/23 15:27,29/Jan/24 18:44,,"The below is the original idea that started this work, but not what we actually landed on. See the first comment from [~rmdmattingly] and the release note for that.   Old description: {quote}Currently we provide the ability to define quotas for namespaces, tables, or users. On multi-tenant clusters, users may be broken down into groups based on their use-case. For us this comes down to 2 main cases: # Hadoop jobs – it would be good to be able to limit all hadoop jobs in aggregate # Proxy APIs - this is common where upstream callers don't hit hbase directly, instead they go through one of many proxy api's.  For us we have a custom auth plugin which sets the username to the upstream caller name. But it would still be useful to be able to limit all usage from some particular proxy API in aggregate. I think this could build upon the idea for Connection attributes in HBASE-27657. Basically when a Connection is established we can set an attribute (i.e. quotaGrouping=hadoop or quotaGrouping=MyProxyAPI).  In QuotaCache, we can add a {{getQuotaGroupLimiter(String groupName)}} and also allow someone to define quotas using {{set_quota TYPE => THROTTLE, GROUP => 'hadoop', LIMIT => '100M/sec'}} I need to do more investigation into whether we'd want to return a simple group limiter (more similar to table/namespace handling) or treat it more like the USER limiters which returns a QuotaState (so you can limit by-group-by-table). We need to consider how GROUP quotas interact with USER quotas. If a user has a quota defined, and that user is also part of a group with a quota defined, does the request need to honor both quotas? Maybe we provide a GROUP_BYPASS setting, similar to GLOBAL_BYPASS? {quote}" Introduce hdfs overlay,13534974,Patch Available,Major,,04/May/23 12:01,,,Provide a basic implementation HDFS deployment. Introduce HBase image,13535173,Patch Available,Major,,05/May/23 13:39,,,"As with the Hadoop image (HBASE-27846), we need a runtime image for the HBase containers, and we need a place to define an API between the runtime image and the orchestration layer. HBase project doesn't ship an image yet, so this will provide double-duty." Introduce zookeeper-single-instance component,13534975,In Progress,Major,,04/May/23 12:01,,,Provide a basic zookeeper deployment. Introduce hbase overlay,13534976,In Progress,Major,,04/May/23 12:01,,,Provide a basic HBase deployment. Introduce zookeeper-ha_ensemble component,13534977,In Progress,Major,,04/May/23 12:01,,,Extend the zookeeper deployment for HA. Introduce ha-hdfs overlay,13534978,In Progress,Major,,04/May/23 12:02,,,Extend the HDFS deployment for HA. Introduce ha-hbase overlay,13534979,In Progress,Major,,04/May/23 12:02,,,Extend the HBase deployment for HA. Introduce hadoop image,13535164,Resolved,Major,Fixed,05/May/23 12:29,02/Jan/24 07:54,,The image shipped by upstream requires some tweaks. Extend it to suit our needs. Use ADMIN_QOS in MasterRpcServices for regionserver operational dependencies,13541222,Resolved,Major,Fixed,23/Jun/23 22:50,28/Jun/23 19:43,2.4.10,"Analysis of a recent production incident is not yet complete but an item of note is an apparent deadlock. Imagine you are gracefully draining a regionserver by way of a flurry of moveRegion requests. The handler for moveRegion submits a TRSP and then waits on its future without timeout. Imagine that there are sufficient number of moveRegion requests to tie up the normal priority master RPC pool. Now imagine that all of those requests are waiting on TRSPs pending on a regionserver that is concurrently bounced or maybe it fails. The TRSPs are blocked in REGION_STATE_TRANSITION_CLOSE because the target regionserver terminated before responding to the close requests, blocking the moveRegion requests, blocking the RPC handlers. The regionserver restarts and tries to check in, but cannot report to the master because there are no free normal priority handlers to handle it. It seems not correct to have the regionserver operational dependencies (regionServerStartup, regionServerReport, and reportFatalRSError) contending with normal priority requests. They should be made ADMIN_QOS priority to avoid this case. " Client side should back off based on wait interval in RpcThrottlingException,13532801,Resolved,Major,Fixed,16/Apr/23 19:39,11/Jul/23 12:35,, Rework kuttl image as a yetus precommit base,13540779,Resolved,Major,Fixed,20/Jun/23 15:03,18/Dec/23 07:52,,"Due to permissions issues on build workers (INFRA-24621), I think we'll benefit by shifting the perspective a little on how the kuttl image is used in CI. The current PRs establish the kuttl image as a (relatively) small, self-contained utility image. When it is invoked in CI, we run yetus with docker-in-docker support, and launch tests by calling `docker container run ... kuttl ...`. So, docker is invoked from within the Yetus pre-commit docker container. Rather, I want to implement the kuttl image as extending from the yetus image (or yetus-base, I'm not sure yet). That way we don't need to run pre-commit with docker-in-docker mode and the precommit process can invoke kuttl directly. The existing kuttl image build is too sophisticated to be invoked by Yetus as a provided docker image (it makes use of build-args). It may also be too sophisticated to be run in a Jenkins worker (it makes use of buildx, INFRA-24704). So I guess we need to publish the image someplace and use the published tag via the Yetus `--docker-tag` flag." Introduce hbase-kubernetes-deployment module,13534972,Resolved,Major,Fixed,04/May/23 12:00,16/May/23 13:43,,Add a maven module under which the orchestration tools can reside. Report heap used by BucketCache as a jmx metric,13537718,Open,Major,,25/May/23 21:08,,,"The BucketCache can take a non-trivial amount of heap, especially for very large cache sizes. For example, we have a server with 500k blocks in the bucket cache, and according to a heap dump it was holding around 260mb. One needs to account for this when determining the size of heap to use, so we should report it. The major contributors I saw were the offsetLock, blocksByHFile set, and backingMap." Run ITBLL for branch-3,13539117,Open,Major,,07/Jun/23 15:16,,, Fix build error against Hadoop 3.3.5,13535898,Resolved,Major,Fixed,12/May/23 01:25,13/May/23 01:13,,"Build with hadoop 3.3.5 will fail with following messages. Some packages are not included in shaded jar. {code:java} $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.5 ... [INFO] --- exec:1.6.0:exec (check-jar-contents-for-stuff-with-hadoop) @ hbase-shaded-with-hadoop-check-invariants --- [ERROR] Found artifact with unexpected contents: '/home/yamasakisua/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-2.4.17.jar'     Please check the following and either correct the build or update     the allowed list with reasoning.    com/     com/sun/     com/sun/jersey/     com/sun/jersey/json/ {code}" Prepare the slides for introducing new features in HBase on CommunityOverCode Asia 2023,13538848,Resolved,Major,Fixed,06/Jun/23 02:53,21/Aug/23 08:02,,"Title: What's new in the recent and upcoming HBase releases Description: Apache HBase™ is the Hadoop database, a distributed, scalable, big data store. The HBase community is preparing new major release 3.0.0 and new minor release 2.6.0, with some brand new features. In this presentation, we will introduce these new features, about how they benefit our users and how we implement them in HBase. Like: - OpenTelemetry Tracing: HBASE-22120, HBASE-26419 - The new region replication framework: HBASE-26233 - Move the logging framework from log4j to log4j2: HBASE-19577 - Cloud native supports - Introduce StoreFileTracker for better object storage support: HBASE-26067, HBASE-26584 - K8s deployment support: HBASE-27827, in progress - No persistent data on zookeeper - Move meta location off zookeeper: HBASE-26193 - Table based replication queue storage: HBASE-27109 - File system based replication peer storage: HBASE-27110 - redeploy cluster with only root directory on object storage: HBASE-26245 - Future? - HBase on Ozone - WAL on Ozone: HBASE-27740 - Fully cloud native, no other self deployed services other than HBase itself - New WAL implementation: BookKeeper? Embedded WAL service?" Add client side table metrics for rpc calls and request latency.,13535577,Resolved,Major,Fixed,10/May/23 03:17,18/Sep/23 21:01,3.0.0-alpha-3,"Now we can get client metrics to see number of calls or latency of related RPC calls like get, mutate, scan etc... But more often, we are more concerned about table level metrics, so we need to subdivide them." Eliminate the 'WARNING: package jdk.internal.util.random not in java.base' when running UTs with jdk11,13536571,Resolved,Major,Fixed,17/May/23 13:42,18/May/23 15:41,,"When fixing a jdk17 issue, we add a --add-opens java.base/jdk.internal.util.random=ALL-UNNAMED line in our pom when running UTs with jdk11+, so it will also be applied for jdk11, but we only need this for jdk17, on jdk11, it will generate a warning, as described in the title. We should try some maven magics to fix this." Introduce kubernetes deployment,13534969,In Progress,Major,,04/May/23 11:46,,,"As per the [discussion|https://lists.apache.org/thread/fgxyk4y32xnhzr5prdmhfjkfpk15g5jx] on the dev list, introduce a basic harness for deploying ZooKeeper, HDFS, and HBase on Kubernetes." Skip zero length bytes of WALKey and WALEntry cells to avoid replication stuck with WAL compression,13539964,Open,Major,,14/Jun/23 05:19,,2.4.17,"We found both the two replication stuck circumstances on our production production clusters, which enables 'hbase.regionserver.wal.enablecompression' and 'hbase.regionserver.wal.value.compression.type'.  The zero length of WALKey and WALEntry cells should be skipped." "TimeoutIOException: Failed to get sync result after 300000 ms for txid=16920651960, WAL system stuck?",13535474,Open,Major,,09/May/23 06:44,,2.2.6,"A node under a RsGroup (only one table), at a certain moment, the write call queue is blocked, and the blocking time starts, and the reading and writing qps of this table are all reduced to 0, and the client cannot read and write the table, RS call At the point in time when queue blocking starts, the following errors are continuously reported in the log:   2023-05-08 12:42:27,310 ERROR [MemStoreFlusher.2] regionserver.MemStoreFlusher: Cache flush failed for region user_feature_v2,eacf_1658057555,1660314723816.2376cc2326b5372131cc530b115d959a. org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=16920651960, WAL system stuck?         at org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:155)         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:743)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:625)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:602)         at org.apache.hadoop.hbase.regionserver.HRegion.doSyncOfUnflushedWALChanges(HRegion.java:2754)         at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2691)         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2549)         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2523)         at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2409)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:611)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:580)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:360)         at java.lang.Thread.run(Thread.java:748) The data in the node memstore cannot be flushed to the WAL file, other indicators of the node are normal, and HDFS is not under pressure. After restarting the blocked node, the table returned to normal.   " Support wall clock profiling in ProfilerServlet,13541981,Resolved,Major,Fixed,29/Jun/23 17:45,04/Aug/23 12:54,,"The async-profiler supports profiling wall clock time, but our ProfilerServlet does not recognize that type. When an unrecognized type is passed, it defaults to cpu. We should add support for wall clock, which would be triggered via the string ""wall""" [hbase-filesystem] Use log4j2 instead of log4j for logging,13537467,Resolved,Major,Fixed,24/May/23 10:35,04/Aug/23 08:50,,Move to log4j2 in hbase-filesystem. Disable hdfs readahead for pread reads,13538033,Resolved,Major,Fixed,29/May/23 21:04,02/Aug/23 13:26,,"In https://issues.apache.org/jira/browse/HBASE-17914, a flag was introduced {{{}hbase.store.reader.no-readahead{}}}. The default is false, so readahead is enabled. This flag is used for creating the default store reader (i.e. the one used by PREAD reads). Stream readers don't use this flag, instead they always pass -1. When that flag is true, we pass a readahead value of 0 to FSDataInputStream.setReadahead. When the flag is false, we pass -1 which triggers hdfs default behavior. The default behavior is to use a readahead of 4MB. It seems to me that we don't want readahead for PREAD reads, and especially not such a large readahead. Our default block size is 64kb, which is much smaller than that. A PREAD read is not likely to do sequential IO, so not likely to utilize the cached readahead buffer. I set no-readahead to true in a few of our clusters and in each case saw a massive reduction in disk IO and thus increase in throughput. I load tested this in a test cluster which does fully random reads of ~300 byte rows on a dataset which is 20x larger than memory. The load test was able to achieve nearly double the throughput. As a follow-on, we might consider tuning the readahead for STREAM reads. 4mb seems way too big for many common workloads." Interrupt BucketCachePersister thread when BucketCache is shutdown,13535552,Resolved,Major,Fixed,09/May/23 19:51,12/May/23 11:12,2.6.0,"Recent changes with BucketCachePersister caused this unit test  [TestVerifyBucketCacheFile.testRetrieveFromFile()|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5222/3/testReport/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/precommit_checks___yetus_jdk8_Hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_1151e434_/] to become flaky. The BucketCachePersister thread keeps running even after BucketCache.shutdown() is run and we do not clear the contents of the backingMap during the shutdown if cache persistence is enabled causing this test to fail. BucketCachePersister should be interrupted in BucketCache.shutdown()." A random data generator tool leveraging bulk load.,13538632,Resolved,Major,Fixed,02/Jun/23 16:50,27/Jul/23 05:47,,"As of now, there is no data generator tool in HBase leveraging bulk load. Since bulk load skips client writes path, it's much faster to generate data and use of for load/performance tests where client writes are not a mandate. {*}Example{*}: Any tooling over HBase that need x TBs of HBase Table for load testing. {*}Requirements{*}: 1. Tooling should generate RANDOM data on the fly and should not require any pre-generated data as CSV/XML files as input. 2. Tooling should support pre-splited tables (number of splits to be taken as input). 3. Data should be UNIFORMLY distributed across all regions of the table. *High-level Steps* 1. A table will be created (pre-splited with number of splits as input) 2. The mapper of a custom Map Reduce job will generate random key-value pair and ensure that those are equally distributed across all regions of the table. 3. [HFileOutputFormat2|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java] will be used to add reducer to the MR job and create HFiles based on key value pairs generated by mapper. 4. Bulk load those HFiles to the respective regions of the table using [LoadIncrementalFiles|https://hbase.apache.org/2.2/devapidocs/org/apache/hadoop/hbase/tool/LoadIncrementalHFiles.html] *Results* We had POC for this tool in our organization, tested this tool with a 11 nodes HBase cluster (having HBase + Hadoop services running). The tool generated: 1. *100* *GB* of data in *6 minutes* 2. *340 GB* of data in *13 minutes* 3. *3.5 TB* of data in *3 hours and 10 minutes* *Usage* hbase org.apache.hadoop.hbase.util.bulkdatagenerator.BulkDataGeneratorTool -mapper-count 100 -table TEST_TABLE_1 -rows-per-mapper 1000000 -split-count 100 -delete-if-exist -table-options ""NORMALIZATION_ENABLED=false""  " The chunk created by mslab may cause memory fragement and lead to fullgc,13533301,Resolved,Major,Fixed,20/Apr/23 02:38,27/Jul/23 02:02,,"The default size of chunk is 2m, when we use G1, if heapRegionSize equals 4m, these chunks are allocated as humongous objects, exclusively allocating one region, then the remaining 2m become memory fragement. Lots of memory fragement may lead to fullgc even if the percent of used heap not high enough. I have tested to reduce the chunk size to 2047k(2m-1k, a bit lesser than half of heapRegionSize), there was no repeat of the above. BTW, in G1, humongous objects are objects larger or equal the size of half a region, and the heapRegionSize is automatically calculated based on the heap size parameter if not explicitly specified.  " ConnectionImplementation#locateRegionInMeta should pause and retry when taking user region lock failed,13538039,Resolved,Major,Fixed,30/May/23 01:45,11/Jul/23 14:08,2.4.17,"It just throws exception and skips the pause and retry logic when  ConnectionImplementation#takeUserRegionLock fails. In some circumstances, no pause and retry by outer logic will make next ConnectionImplementation#takeUserRegionLock still fails, since all the threads simultaneously grab the lock." HStore.needsCompaction() should return false if we disable comapction against a table,13540786,Open,Major,,20/Jun/23 15:43,,2.3.7,"As descibed in the title. But actually, we get true from HStore.needsCompaction() when a table has already disabled compaction" Expose a getter on Connection/AsyncConnection for getting public access to connection metrics,13537673,Open,Major,,25/May/23 13:32,,,"Currently the MetricsConnection metrics are only exposed via jmx. This is not very easy to deal with on the client side. In our environment we have 10s of thousands of client instances and we do not expose a jmx port. If we did, it'd be painful to try fetching from so many (and constantly changing) instances.  Many environments have their own monitoring stack and their own way of shipping deployables metrics to their monitoring. We should provide a way to get access to these metrics within the process. It's possible (but extremely cumbersome) to query jmx beans from within the process. We did this in my environment and I would recommend against it. Let's provide direct access to the metrics. I think we probably want to keep MetricsConnection IA.Private, but maybe we can create a new MetricsConnectionSnapshot and provide a getter on the Connection/AsyncConnection." HMaster.getCompactionState can happen NPE when region state is closed,13535824,Resolved,Major,Fixed,11/May/23 15:11,06/Jul/23 02:46,2.3.7,"Following steps to reproduce: 1 create table  {code:java} create 'hbase_region_test', 'info', SPLITS => ['3', '7']  {code}   2 write data {code:java} //代码占位符 put 'hbase_region_test', '10010', 'info:name', 'Tom' put 'hbase_region_test', '20010', 'info:name', 'Tom' put 'hbase_region_test', '30010', 'info:name', 'Tom' put 'hbase_region_test', '40010', 'info:name', 'Tom' put 'hbase_region_test', '50010', 'info:name', 'Tom' put 'hbase_region_test', '60010', 'info:name', 'Tom' put 'hbase_region_test', '70010', 'info:name', 'Tom' put 'hbase_region_test', '80010', 'info:name', 'Tom' put 'hbase_region_test', '90010', 'info:name', 'Tom' {code}   3 closed a region of hbase_region_test by unassign    4 calling method HMaster.getCompactionState:     At this step, we can trigger this method to be called by opening hbase UI page about 'hbase_region_test' table detailes and getting the compaction state of 'hbase_region_test' samply   5 HMaster print NPE logs about HMaster.getCompactionState" Skipping compact for this region if the table disable compaction,13539119,Resolved,Major,Fixed,07/Jun/23 15:41,06/Jul/23 02:31,2.3.7,"CompactionChecker.chore() is called periodically for compacting. as follow: {code:java} //代码占位符 protected void chore() {     for (Region r : this.instance.onlineRegions.values()) {         // Skip compaction if region is read only         if (r == null || r.isReadOnly()) {             continue;         }         HRegion hr = (HRegion) r;         for (HStore s : hr.stores.values()) {             // ...         }     } } {code} Just skip compact for the region if table disable compaction." Eliminate duplicate code for getNonRootIndexedKey in HFileBlockIndex,13541664,Resolved,Major,Fixed,28/Jun/23 03:59,03/Jul/23 14:04,3.0.0-alpha-4,"The code to get the {{midkey}} by {{midLeafBlock}} in {{HFileBlockIndex.CellBasedKeyBlockIndexReader.midkey}} method is almost the same as {{HFileBlockIndex.BlockIndexReader.getNonRootIndexedKey}}, the code is somewhat complicated, we could use the {{HFileBlockIndex.BlockIndexReader.getNonRootIndexedKey}} directly in {{HFileBlockIndex.CellBasedKeyBlockIndexReader.midkey}}." Asyncfs may print too many WARN logs when replace writer,13536697,Open,Major,,18/May/23 07:55,,,"When we use Asyncfs for WAL, could see many WARN logs like this: !image-2023-05-18-15-51-33-823.png! namenode#complete is a relatively heavy operation, and sometimes it takes seconds. So we can reduce this log, just as what [DFSOutputStream#completeFile|https://github.com/apache/hadoop/blob/706d88266abcee09ed78fbaa0ad5f74d818ab0e9/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java#L975]] do." Report memstore on-heap and off-heap size as jmx metrics in sub=Memory bean,13541098,Resolved,Major,Fixed,22/Jun/23 23:03,29/Jun/23 07:18,,"Currently we only report ""memStoreSize"" jmx metric in sub=Memory bean. There are ""Memstore On-Heap Size"" and ""Memsotre Off-Heap Size"" in the RS UI. It would be useful to report them in JMX. In addition, ""memStoreSize"" metric under sub=Memory is 0 for some reason (while that under sub=Server is not). Need to do some digging to see if it is a bug." RefreshPeerProcedure should be resilient to replication endpoint failures,13541673,Open,Major,,28/Jun/23 06:24,,2.4.14,"UpdatePeerConfigProcedure gets stuck when we see some failures in RefreshPeerProcedure. The only way to move forward is either by restarting active master or bypassing the stuck procedure.   For instance, {code:java} 2023-06-26 17:22:08,375 WARN  [,queue=24,port=61000] replication.RefreshPeerProcedure - Refresh peer peer0 for UPDATE_CONFIG on {host},{port},1687053857180 failed java.lang.NullPointerException via {host},{port},1687053857180:java.lang.NullPointerException:      at org.apache.hadoop.hbase.procedure2.RemoteProcedureException.fromProto(RemoteProcedureException.java:123)     at org.apache.hadoop.hbase.master.MasterRpcServices.lambda$reportProcedureDone$4(MasterRpcServices.java:2406)     at java.util.ArrayList.forEach(ArrayList.java:1259)     at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1082)     at org.apache.hadoop.hbase.master.MasterRpcServices.reportProcedureDone(MasterRpcServices.java:2401)     at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:16296)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:385)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:132)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349) Caused by: java.lang.NullPointerException:      at xyz(Abc.java:89) <========= replication endpoint failure example     at xyz(Abc.java:79)     <========= replication endpoint failure example    at org.apache.hadoop.hbase.replication.ReplicationPeerImpl.lambda$setPeerConfig$0(ReplicationPeerImpl.java:63)     at java.util.ArrayList.forEach(ArrayList.java:1259)     at org.apache.hadoop.hbase.replication.ReplicationPeerImpl.setPeerConfig(ReplicationPeerImpl.java:63)     at org.apache.hadoop.hbase.replication.regionserver.PeerProcedureHandlerImpl.updatePeerConfig(PeerProcedureHandlerImpl.java:131)     at org.apache.hadoop.hbase.replication.regionserver.RefreshPeerCallable.call(RefreshPeerCallable.java:70)     at org.apache.hadoop.hbase.replication.regionserver.RefreshPeerCallable.call(RefreshPeerCallable.java:35)     at org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49)     at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:98)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:750) {code} RefreshPeerProcedure should support reporting this failure and rollback of the parent procedure." Report memstore on-heap and off-heap size as jmx metrics,13537720,Resolved,Major,Fixed,25/May/23 21:28,27/Jun/23 15:47,,"Currently we only report ""memStoreSize"" metric in sub=RegionServer bean. I've noticed a big discrepancy between this metric and the RS UI's ""Memstore On-Heap Size"". It seems like ""memStoreSize"" is the overall data size, while the on-heap size is coming from our heap estimation which includes POJO heap overhead, etc. I have a regionserver with only 750mb of ""memStoreSize"", but the on-heap size is over 1gb.  This is non-trivial for estimating overall heap size necessary for a regionserver. Since we have the data, let's report it." IntegrationTestImportTsv doesn't respect -Dfs.defaultFS to override FS,13537574,Open,Major,,25/May/23 02:29,,,"Tried modifying the command using -Dfs.defaultFS to run the integration tests on top of Ozone: {noformat} hbase org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv -Dfs.defaultFS=ofs://ozone1 -Dhbase.fs.tmp.dir=ofs://ozone1/vol1/bucket1/hbase/bulkload{noformat} Still getting: {noformat} 2023-05-24 19:16:12,683|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|Exception in thread ""main"" java.lang.IllegalArgumentException: Wrong FS: ofs://ozone1/vol1/bucket1/hbase/bulkload/partitions_b5cae401-0fb6-4322-b2bd-892eed7786ef, expected: hdfs://ns1{noformat} Full trace: {noformat} 1.cdh7.1.8.p3.40935426/bin/../lib/hadoop/lib/native 2023-05-24 19:16:07,662|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:java.io.tmpdir=/tmp 2023-05-24 19:16:07,662|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:java.compiler= 2023-05-24 19:16:07,662|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:os.name=Linux 2023-05-24 19:16:07,662|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:os.arch=amd64 2023-05-24 19:16:07,662|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:os.version=5.4.0-135-generic 2023-05-24 19:16:07,663|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:user.name=hrt_qa 2023-05-24 19:16:07,663|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:user.home=/home/hrt_qa 2023-05-24 19:16:07,663|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:user.dir=/hwqe/hadoopqe 2023-05-24 19:16:07,663|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:os.memory.free=96MB 2023-05-24 19:16:07,663|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:os.memory.max=228MB 2023-05-24 19:16:07,663|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Client environment:os.memory.total=145MB 2023-05-24 19:16:07,666|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ZooKeeper: Initiating client connection, connectString=ozn-lease19-4.ozn-lease19.root.hwx.site:2181,ozn-lease19-1.ozn-lease19.root.hwx.site:2181,ozn-lease19-2.ozn-lease19.root.hwx.site:2181 sessionTimeout=30000 watcher=org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$$Lambda$16/1316897284@50feaef5 2023-05-24 19:16:07,673|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO common.X509Util: Setting -D jdk.tls.rejectClientInitiatedRenegotiation=true to disable client-initiated TLS renegotiation 2023-05-24 19:16:07,683|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ClientCnxnSocket: jute.maxbuffer value is 4194304 Bytes 2023-05-24 19:16:07,692|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ClientCnxn: zookeeper.request.timeout value is 0. feature enabled= 2023-05-24 19:16:07,712|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.Login: Client successfully logged in. 2023-05-24 19:16:07,714|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.Login: TGT refresh thread started. 2023-05-24 19:16:07,742|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.Login: TGT valid starting at: Wed May 24 18:49:50 UTC 2023 2023-05-24 19:16:07,743|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.Login: TGT expires: Thu May 25 18:49:50 UTC 2023 2023-05-24 19:16:07,743|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO client.ZooKeeperSaslClient: Client will use GSSAPI as SASL mechanism. 2023-05-24 19:16:07,743|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.Login: TGT refresh sleeping until: Thu May 25 14:19:58 UTC 2023 2023-05-24 19:16:07,768|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ClientCnxn: Opening socket connection to server ozn-lease19-2.ozn-lease19.root.hwx.site/172.27.192.66:2181. Will attempt to SASL-authenticate using Login Context section 'Client' 2023-05-24 19:16:07,773|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ClientCnxn: Socket connection established, initiating session, client: /10.104.34.66:35400, server: ozn-lease19-2.ozn-lease19.root.hwx.site/172.27.192.66:2181 2023-05-24 19:16:07,780|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:07 INFO zookeeper.ClientCnxn: Session establishment complete on server ozn-lease19-2.ozn-lease19.root.hwx.site/172.27.192.66:2181, sessionid = 0x30587a0caee02c2, negotiated timeout = 30000 2023-05-24 19:16:08,663|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.ZooKeeper: Initiating client connection, connectString=ozn-lease19-4.ozn-lease19.root.hwx.site:2181,ozn-lease19-1.ozn-lease19.root.hwx.site:2181,ozn-lease19-2.ozn-lease19.root.hwx.site:2181 sessionTimeout=30000 watcher=org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$$Lambda$16/1316897284@50feaef5 2023-05-24 19:16:08,664|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.ClientCnxnSocket: jute.maxbuffer value is 4194304 Bytes 2023-05-24 19:16:08,664|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.ClientCnxn: zookeeper.request.timeout value is 0. feature enabled= 2023-05-24 19:16:08,667|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.Login: Client successfully logged in. 2023-05-24 19:16:08,668|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.Login: TGT refresh thread started. 2023-05-24 19:16:08,668|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO client.ZooKeeperSaslClient: Client will use GSSAPI as SASL mechanism. 2023-05-24 19:16:08,668|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.Login: TGT valid starting at: Wed May 24 18:49:50 UTC 2023 2023-05-24 19:16:08,669|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.Login: TGT expires: Thu May 25 18:49:50 UTC 2023 2023-05-24 19:16:08,669|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.Login: TGT refresh sleeping until: Thu May 25 15:08:08 UTC 2023 2023-05-24 19:16:08,670|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.ClientCnxn: Opening socket connection to server ozn-lease19-2.ozn-lease19.root.hwx.site/172.27.192.66:2181. Will attempt to SASL-authenticate using Login Context section 'Client' 2023-05-24 19:16:08,670|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.ClientCnxn: Socket connection established, initiating session, client: /10.104.34.66:35414, server: ozn-lease19-2.ozn-lease19.root.hwx.site/172.27.192.66:2181 2023-05-24 19:16:08,674|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO zookeeper.ClientCnxn: Session establishment complete on server ozn-lease19-2.ozn-lease19.root.hwx.site/172.27.192.66:2181, sessionid = 0x30587a0caee02c3, negotiated timeout = 30000 2023-05-24 19:16:08,825|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:08 INFO mapreduce.IntegrationTestImportTsv: Running test testGenerateAndLoad. 2023-05-24 19:16:09,614|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:09 INFO fs.HFileSystem: Added intercepting call to namenode#getBlockLocations so can do block reordering using class org.apache.hadoop.hbase.fs.HFileSystem$ReorderWALBlocks 2023-05-24 19:16:09,620|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:09 INFO fs.HFileSystem: Added intercepting call to namenode#getBlockLocations so can do block reordering using class org.apache.hadoop.hbase.fs.HFileSystem$ReorderWALBlocks 2023-05-24 19:16:09,838|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:09 INFO mapreduce.IntegrationTestImportTsv: The folder where the HFiles will be generated: hdfs://ns1/user/hbase/test-data/7764b218-8933-c8a8-c6b5-f7fe1899edb8/IntegrationTestImportTsv/hfiles 2023-05-24 19:16:09,857|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:09 INFO hbase.HBaseClassTestRule: Test class org.apache.hadoop.hbase.mapreduce.TestImportTsv timeout: 13 mins 2023-05-24 19:16:09,882|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:09 INFO hbase.HBaseCommonTestingUtility: System.getProperty(""hadoop.log.dir"") already set to: /hwqe/hadoopqe/target/test-data/9507b95e-9518-c4c4-916e-8e10663a37ca/hadoop-log-dir so I do NOT create it in target/test-data/d07cb065-ab88-af82-515c-2a86041b88fa 2023-05-24 19:16:09,882|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:09 INFO hbase.HBaseCommonTestingUtility: System.getProperty(""hadoop.tmp.dir"") already set to: /hwqe/hadoopqe/target/test-data/9507b95e-9518-c4c4-916e-8e10663a37ca/hadoop-tmp-dir so I do NOT create it in target/test-data/d07cb065-ab88-af82-515c-2a86041b88fa 2023-05-24 19:16:09,882|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:09 WARN hbase.HBaseCommonTestingUtility: hadoop.tmp.dir property value differs in configuration and system: Configuration=/tmp/hadoop-hrt_qa while System=/hwqe/hadoopqe/target/test-data/9507b95e-9518-c4c4-916e-8e10663a37ca/hadoop-tmp-dir Erasing configuration value by system value. 2023-05-24 19:16:11,948|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:11 INFO client.HBaseAdmin: Operation: CREATE, Table Name: default:IntegrationTestImportTsv, procId: 336 completed 2023-05-24 19:16:11,953|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:11 INFO hbase.Waiter: Waiting up to [60,000] milli-secs(wait.for.ratio=[1]) 2023-05-24 19:16:12,023|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO hbase.HBaseCommonTestingUtility: All regions for table IntegrationTestImportTsv assigned to meta. Checking AM states. 2023-05-24 19:16:12,023|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO hbase.HBaseCommonTestingUtility: All regions for table IntegrationTestImportTsv assigned. 2023-05-24 19:16:12,448|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ZooKeeper: Initiating client connection, connectString=ozn-lease19-4.ozn-lease19.root.hwx.site:2181,ozn-lease19-1.ozn-lease19.root.hwx.site:2181,ozn-lease19-2.ozn-lease19.root.hwx.site:2181 sessionTimeout=30000 watcher=org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$$Lambda$16/1316897284@50feaef5 2023-05-24 19:16:12,448|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ClientCnxnSocket: jute.maxbuffer value is 4194304 Bytes 2023-05-24 19:16:12,449|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ClientCnxn: zookeeper.request.timeout value is 0. feature enabled= 2023-05-24 19:16:12,451|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.Login: Client successfully logged in. 2023-05-24 19:16:12,451|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO client.ZooKeeperSaslClient: Client will use GSSAPI as SASL mechanism. 2023-05-24 19:16:12,452|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.Login: TGT refresh thread started. 2023-05-24 19:16:12,452|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.Login: TGT valid starting at: Wed May 24 18:49:50 UTC 2023 2023-05-24 19:16:12,453|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.Login: TGT expires: Thu May 25 18:49:50 UTC 2023 2023-05-24 19:16:12,453|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ClientCnxn: Opening socket connection to server ozn-lease19-4.ozn-lease19.root.hwx.site/172.27.19.204:2181. Will attempt to SASL-authenticate using Login Context section 'Client' 2023-05-24 19:16:12,453|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.Login: TGT refresh sleeping until: Thu May 25 15:07:41 UTC 2023 2023-05-24 19:16:12,454|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ClientCnxn: Socket connection established, initiating session, client: /10.104.34.66:38096, server: ozn-lease19-4.ozn-lease19.root.hwx.site/172.27.19.204:2181 2023-05-24 19:16:12,457|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ClientCnxn: Session establishment complete on server ozn-lease19-4.ozn-lease19.root.hwx.site/172.27.19.204:2181, sessionid = 0x10bdd60ec040302, negotiated timeout = 30000 2023-05-24 19:16:12,613|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO mapreduce.HFileOutputFormat2: bulkload locality sensitive enabled 2023-05-24 19:16:12,614|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO mapreduce.HFileOutputFormat2: Looking up current regions for table IntegrationTestImportTsv 2023-05-24 19:16:12,680|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO mapreduce.HFileOutputFormat2: Configuring 1 reduce partitions to match current region count for all tables 2023-05-24 19:16:12,681|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO client.ConnectionImplementation: Closing master protocol: MasterService 2023-05-24 19:16:12,683|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|Exception in thread ""main"" java.lang.IllegalArgumentException: Wrong FS: ofs://ozone1/vol1/bucket1/hbase/bulkload/partitions_b5cae401-0fb6-4322-b2bd-892eed7786ef, expected: hdfs://ns1 2023-05-24 19:16:12,683|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:788) 2023-05-24 19:16:12,683|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:647) 2023-05-24 19:16:12,683|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configurePartitioner(HFileOutputFormat2.java:864) 2023-05-24 19:16:12,683|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configureIncrementalLoad(HFileOutputFormat2.java:661) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configureIncrementalLoad(HFileOutputFormat2.java:598) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.ImportTsv.createSubmittableJob(ImportTsv.java:546) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.ImportTsv.run(ImportTsv.java:754) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:81) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.TestImportTsv.doMROnTableTest(TestImportTsv.java:425) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.TestImportTsv.doMROnTableTest(TestImportTsv.java:378) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.generateAndLoad(IntegrationTestImportTsv.java:198) 2023-05-24 19:16:12,684|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.run(IntegrationTestImportTsv.java:232) 2023-05-24 19:16:12,685|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:81) 2023-05-24 19:16:12,685|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.main(IntegrationTestImportTsv.java:263) 2023-05-24 19:16:12,785|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 WARN zookeeper.Login: TGT renewal thread has been interrupted and will exit. 2023-05-24 19:16:12,787|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ZooKeeper: Session: 0x10bdd60ec040302 closed 2023-05-24 19:16:12,787|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:16:12 INFO zookeeper.ClientCnxn: EventThread shut down for session: 0x10bdd60ec040302 2023-05-24 19:17:08,175|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:17:08 WARN zookeeper.Login: TGT renewal thread has been interrupted and will exit. 2023-05-24 19:17:08,176|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:17:08 INFO zookeeper.ZooKeeper: Session: 0x30587a0caee02c2 closed 2023-05-24 19:17:08,176|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:17:08 INFO zookeeper.ClientCnxn: EventThread shut down for session: 0x30587a0caee02c2 2023-05-24 19:17:10,024|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:17:10 WARN zookeeper.Login: TGT renewal thread has been interrupted and will exit. 2023-05-24 19:17:10,024|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:17:10 INFO zookeeper.ZooKeeper: Session: 0x30587a0caee02c3 closed 2023-05-24 19:17:10,024|INFO|MainThread|machine.py:203 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|23/05/24 19:17:10 INFO zookeeper.ClientCnxn: EventThread shut down for session: 0x30587a0caee02c3 2023-05-24 19:17:12,382|INFO|MainThread|machine.py:232 - run()||GUID=b47165ac-c898-410f-bbf9-eaaca57cb34f|Exit Code: 1{noformat}" Leak in ServerCall.setResponse,13541418,Open,Major,,26/Jun/23 14:03,,,"I'm stress testing the RegionServer for TLS and noticing the following leak:   {code:java} ERROR org.apache.hbase.thirdparty.io.netty.util.ResourceLeakDetector: LEAK: RefCnt.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information. Recent access records: Created at:         org.apache.hadoop.hbase.nio.RefCnt.(RefCnt.java:59)         org.apache.hadoop.hbase.nio.SingleByteBuff.(SingleByteBuff.java:55)         org.apache.hadoop.hbase.io.ByteBuffAllocator.allocateOneBuffer(ByteBuffAllocator.java:280)         org.apache.hadoop.hbase.io.ByteBufferListOutputStream.allocateNewBuffer(ByteBufferListOutputStream.java:61)         org.apache.hadoop.hbase.io.ByteBufferListOutputStream.checkSizeAndGrow(ByteBufferListOutputStream.java:90)         org.apache.hadoop.hbase.io.ByteBufferOutputStream.writeInt(ByteBufferOutputStream.java:154)         org.apache.hadoop.hbase.util.ByteBufferUtils.putInt(ByteBufferUtils.java:429)         org.apache.hadoop.hbase.codec.KeyValueCodec$KeyValueEncoder.write(KeyValueCodec.java:61)         org.apache.hadoop.hbase.ipc.CellBlockBuilder.encodeCellsTo(CellBlockBuilder.java:187)         org.apache.hadoop.hbase.ipc.CellBlockBuilder.buildCellBlockStream(CellBlockBuilder.java:223)         org.apache.hadoop.hbase.ipc.ServerCall.setResponse(ServerCall.java:256)         org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:160)         org.apache.hadoop.hbase.ipc.CallRunnerWithContext.run(CallRunnerWithContext.java:74)         org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)         org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) {code}   One thing to note is that due to my stress test Netty is throwing OutOfDirectMemoryError, which extends OutOfMemoryError. I see we have handling for that in CallRunner, not sure if it's related." Add progress display in Hbase hbck tool,13541281,Open,Major,,25/Jun/23 07:11,,,"The current hbck tool does not have any progress display, which makes it impossible for users to know whether there is a problem when use it to fix HBase.In a user's  scenario, it took more than 2 hours to find out that there was a problem." "During SSL handshake error, netty complains that exceptionCaught() was not handled",13531744,Resolved,Major,Fixed,06/Apr/23 13:09,23/Jun/23 02:20,,"I was chaos testing the new native TLS, forcing a certificate to expire and fail handshake. The handshake failure properly causes submitted requests to fail, but I see the following ""unhandled exception"" like message: {code:java} WARN  o.a.h.t.i.n.c.DefaultChannelPipeline - An exceptionCaught() event was fired, and it reached at the tail of the pipeline. It usually means the last handler in the pipeline did not handle the exception. org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException: Received fatal alert: certificate_expired         at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:499)         at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)         at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440)         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)         at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)         at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)         at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788)         at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)         at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)         at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)         at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)         at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)         at java.base/java.lang.Thread.run(Thread.java:833) Caused by: javax.net.ssl.SSLHandshakeException: Received fatal alert: certificate_expired         at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:131)         at java.base/sun.security.ssl.Alert.createSSLException(Alert.java:117)         at java.base/sun.security.ssl.TransportContext.fatal(TransportContext.java:358)         at java.base/sun.security.ssl.Alert$AlertConsumer.consume(Alert.java:293)         at java.base/sun.security.ssl.TransportContext.dispatch(TransportContext.java:204)         at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:172)         at java.base/sun.security.ssl.SSLEngineImpl.decode(SSLEngineImpl.java:736)         at java.base/sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:691)         at java.base/sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:506)         at java.base/sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:482)         at java.base/javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:679)         at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler$SslEngineType$3.unwrap(SslHandler.java:296)         at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1343)         at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler.decodeJdkCompatible(SslHandler.java:1236)         at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1285)         at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:529)         at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:468)         ... 17 common frames omitted{code}" NPE in StoreFileReader.passesGeneralRowPrefixBloomFilter(),13540244,Resolved,Major,Fixed,15/Jun/23 14:16,22/Jun/23 13:54,,"When executing itbll, we encountered the following NPE exception： {code:java} java.lang.NullPointerException at org.apache.hadoop.hbase.regionserver.StoreFileReader.passesGeneralRowPrefixBloomFilter(StoreFileReader.java:352) at org.apache.hadoop.hbase.regionserver.StoreFileReader.passesBloomFilter(StoreFileReader.java:265) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.shouldUseScanner(StoreFileScanner.java:483) at org.apache.hadoop.hbase.regionserver.StoreScanner.selectScannersFrom(StoreScanner.java:467) at org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:320) at org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:289) at org.apache.hadoop.hbase.regionserver.compactions.Compactor.createScanner(Compactor.java:544) at org.apache.hadoop.hbase.regionserver.compactions.Compactor$1.createScanner(Compactor.java:269) at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:358) at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:64) at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:122) at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1176) at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2407) at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:667) at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:716) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) {code} " Introduce hdfs+hbase colocated pod definition,13541034,In Progress,Major,,22/Jun/23 13:18,,,Implement a deployment strategy that supports short-circuit reads by forcing the data node and region server processes to colocate by deployment them as sibling container within the same pod. Introduce HA hdfs+hbase colocated pod definition,13541038,In Progress,Major,,22/Jun/23 13:48,,,Like the hdfs+hbase colocated pod definition but with an HA deployment strategy. New async admin api to invoke coproc on multiple servers,13538508,Resolved,Major,Fixed,02/Jun/23 04:58,20/Jun/23 22:08,,"We can execute regionserver coproc on a given regionserver using: {code:java} CompletableFuture coprocessorService(Function stubMaker, ServiceCaller callable, ServerName serverName); {code} We should also provide an api at admin layer that can invoke the given coproc endpoint on multiple servers, to help execute the given function in parallel across the entire cluster." Meta replication stuck forever if wal it's still reading gets rolled and deleted,13536581,Resolved,Major,Fixed,17/May/23 14:44,20/Jun/23 14:18,2.4.16,"This affects branch-2 based releases only (in master, HBASE-26416 refactored region replication to not rely on the replication framework anymore). Per the original [meta region replicas design|https://docs.google.com/document/d/1jJWVc-idHhhgL4KDRpjMsQJKCl_NRaCLGiH3Wqwd3O8/edit], we use most of the replication framework for communicating changes in the primary replica back to the secondary ones, but we skip storing the queue state in ZK. In the event of a region replication crash, we should let the related replication source thread be interrupted, so that  RegionReplicaReplicationEndpoint would set a new source from the scratch and make sure to update the secondary replicas.   We have run into a situation in one of our customers' cluster where the region replica source faced a long lag (probably because the RSes hosting the secondary replicas were busy and slower in processing the region replication entries), so that the current wal got rolled and eventually deleted whilst the replication source reader was still referring it. In such cases, ReplicationSourceReader only sees the IOException and keeps retrying the read indefinitely, but since the file is now gone, it will just get stuck there forever. In the particular case of FNFE (which I believe would only happen for region replication), we should just raise an exception and let RegionReplicaReplicationEndpoint handle it to reset the region replication source.    " "Introduce build for `kuttl` image, basis for dev/test environment",13534973,Resolved,Major,Fixed,04/May/23 12:00,19/Jun/23 13:36,,Define a starting image for dev and test. Introduce Jenkins PR job for hbase-kustomize,13540226,Resolved,Major,Fixed,15/Jun/23 12:29,16/Jun/23 08:18,,We need something to build off of. Let's start with a clone of what's on hbase-operator-tools. Midkey metadata in root index block would always be ignored by BlockIndexReader.readMultiLevelIndexRoot,13540468,Resolved,Major,Fixed,17/Jun/23 03:10,17/Jun/23 13:38,2.4.17,"After HBASE-27053， checksum is removed from the {{HFileBlock}} {{ByteBuff}} in {{FSReaderImpl.readBlockDataInternal}} once the checksum is verified, so {{HFileBlock.buf}} does not include checksum, but for {{BlockIndexReader.readMultiLevelIndexRoot}}, after read root index entries , it still subtracts the checksum to check if the midkey metadat exists, the midkey metadata would always be ignored: {code:java} public void readMultiLevelIndexRoot(HFileBlock blk, final int numEntries) throws IOException { DataInputStream in = readRootIndex(blk, numEntries); // after reading the root index the checksum bytes have to // be subtracted to know if the mid key exists. int checkSumBytes = blk.totalChecksumBytes(); if ((in.available() - checkSumBytes) < MID_KEY_METADATA_SIZE) { // No mid-key metadata available. return; } midLeafBlockOffset = in.readLong(); midLeafBlockOnDiskSize = in.readInt(); midKeyEntry = in.readInt(); } {code} " Bump snappy-java from 1.1.9.1 to 1.1.10.1,13540431,Resolved,Major,Fixed,16/Jun/23 15:52,16/Jun/23 16:00,, Remove duplicate code for NettyHBaseSaslRpcServerHandler and make the sentByte metrics more accurate,13539619,Resolved,Major,Fixed,12/Jun/23 08:17,17/Jun/23 01:50,2.6.0,"{{NettyHBaseSaslRpcServerHandler.doResponse}} and {{ServerRpcConnection.doRawSaslReply}} are very similar, I think we could replace {{NettyHBaseSaslRpcServerHandler.doResponse}} with {{ServerRpcConnection.doRawSaslReply}}： {code:java} private void doResponse(ChannelHandlerContext ctx, SaslStatus status, Writable rv, String errorClass, String error) throws IOException { // In my testing, have noticed that sasl messages are usually // in the ballpark of 100-200. That's why the initial capacity is 256. ByteBuf resp = ctx.alloc().buffer(256); try (ByteBufOutputStream out = new ByteBufOutputStream(resp)) { out.writeInt(status.state); // write status if (status == SaslStatus.SUCCESS) { rv.write(out); } else { WritableUtils.writeString(out, errorClass); WritableUtils.writeString(out, error); } } NettyFutureUtils.safeWriteAndFlush(ctx, resp); } {code} {code:java} protected final void doRawSaslReply(SaslStatus status, Writable rv, String errorClass, String error) throws IOException { BufferChain bc; // In my testing, have noticed that sasl messages are usually // in the ballpark of 100-200. That's why the initial capacity is 256. try (ByteBufferOutputStream saslResponse = new ByteBufferOutputStream(256); DataOutputStream out = new DataOutputStream(saslResponse)) { out.writeInt(status.state); // write status if (status == SaslStatus.SUCCESS) { rv.write(out); } else { WritableUtils.writeString(out, errorClass); WritableUtils.writeString(out, error); } bc = new BufferChain(saslResponse.getByteBuffer()); } doRespond(() -> bc); } {code} At the same time, {{NettyHBaseSaslRpcServerHandler.doResponse}} sends ByteBuf directly , not the unified {{RpcResponse}} , so it would not handled by the logic in {{NettyRpcServerResponseEncoder.write}}, which would update the {{MetricsHBaseServer.sentBytes}}. Using {{ServerRpcConnection.doRawSaslReply}} uniformly would make the {{MetricsHBaseServer.sentBytes}} more accurate." create-release is broken by recent gitbox changes,13537864,Resolved,Major,Fixed,27/May/23 00:38,16/Jun/23 15:12,,"The error looks like: {noformat} ... GIT_BRANCH [branch-2.5]: -:1: parser error : Space required after the Public Identifier {noformat} but is misleading. What is going on is create-release tries to retrieve the top level POM from the specified branch using a gitbox URL but gitbox is returning an HTML redirect, which is not what is expected. {noformat} ++ read -r -p 'GIT_BRANCH [branch-2.5]: ' REPLY GIT_BRANCH [branch-2.5]: ++ local RETVAL=branch-2.5 ++ '[' -z branch-2.5 ']' ++ echo branch-2.5 + GIT_BRANCH=branch-2.5 + export GIT_BRANCH + local version ++ curl -s 'https://gitbox.apache.org/repos/asf?p=hbase.git;a=blob_plain;f=pom.xml;hb=refs/heads/branch-2.5' ++ parse_version ++ xmllint --xpath '//*[local-name()='\''project'\'']/*[local-name()='\''version'\'']/text()' - -:1: parser error : Space required after the Public Identifier {noformat} {noformat} $ curl -s 'https://gitbox.apache.org/repos/asf?p=hbase.git;a=blob_plain;f=pom.xml;hb=refs/heads/branch-2.5' 302 Found

Found

The document has moved here.

{noformat} The solution is to retrieve content using github URLs (via raw.githubusercontent.com) instead of gitbox URLs." Remove useless content for branch-3,13539116,Resolved,Major,Fixed,07/Jun/23 15:15,15/Jun/23 15:29,,"For example, the ref guide related stuff. Let's alian with branch-2." Set version to 4.0.0-alpha-1-SNAPSHOT on master,13539115,Resolved,Major,Fixed,07/Jun/23 15:14,15/Jun/23 15:28,, Set up jenkins jobs for branch-3,13539305,Resolved,Major,Fixed,08/Jun/23 15:31,15/Jun/23 15:33,, Missing reference guide for 2.5.x stable,13540169,Open,Major,,15/Jun/23 08:51,,2.5.5,"On [https://hbase.apache.org/,] the ""Documentation and API"" dropdown does not provide links for the ""Ref Guide"" and ""Reference Guide (PDF) for the current stable 2.5.x version. The expected location for this ([https://hbase.apache.org/2.5/book.html)] gives a 404. This means users cannot view the docs for the current 2.5.x stable version, since [https://hbase.apache.org/] shows the docs of master (3.0.x)." Add .asf.yaml to hbase-kustomize.git,13540050,Resolved,Major,Fixed,14/Jun/23 13:22,15/Jun/23 11:50,,Establish some basic configurations for this new git repository. Use hedged read to read hlog when log split ,13540122,Open,Major,,15/Jun/23 02:01,,, Add a LICENSE file to hbase-kustomize.git,13540049,Resolved,Major,Fixed,14/Jun/23 13:21,14/Jun/23 13:23,,"Using this for an initial commit, something non-controversial so that we can have an initial commit in place. Some commit history is required before PRs can be opened against a repository, hence doing this a little outside of our normal process." Improving SFT store file layout for S3 and S3-alike object stores,13535035,Open,Major,,04/May/23 17:15,,2.5.4,"Today’s HFile on S3 support lays out ""files"" in the S3 bucket exactly as it does in HDFS, and this is going to be a problem. S3 throttles IO to buckets based on prefix. See [https://aws.amazon.com/premiumsupport/knowledge-center/s3-request-limit-avoid-throttling/] {quote}You can send 3,500 PUT/COPY/POST/DELETE or 5,500 GET/HEAD requests per second per prefix in an Amazon S3 bucket. There are no limits to the number of prefixes that you can have in your bucket. LIST and GET objects don’t share the same limit. The performance of LIST calls depend on the number of Deleted markers present at the top of an object version for a given prefix. {quote} Today this looks like: {noformat} /hbase/data//
///hfile1 /hbase/data//
///hfile2 ... {noformat} Unfortunately by-prefix partitioning is performed by S3 in a black box manner with no API provided to hint it. Customary file separator characters like '/' are not specially considered.  The situation we want to avoid is where the load accounted to one or more hot stores aggregates up to an inopportune choke point where S3 may have auto partitioned at the region, table, or namespace level. Paths to any given store should avoid sharing a common path prefix with those of another. We can continue to represent metadata in a hierarchical manner. Metadata is infrequently accessed compared to data because it is cached, or can be made to be cached, because the size of metadata is a tiny fraction of the size of all data. So a resulting layout might look like: {noformat} /hbase/data//
//file.list //hfile1 //hfile2 ... {noformat} where {{file.list}} is our current manifest based HFile tracking, managed by FileBasedStoreFileTracker. This is simply a relocation of stores to a different path construction while maintaining all of the other housekeeping as-is. The file based store file tracker manifest allows us to make this change easily, and iteratively, supporting in-place migration. It seems straightforward to implement as new version of FileBasedStoreFileTracker with an automatic path to migration. Adapting the HBCK2 support for rebuilding the store file list should also be straightforward if we can version the FileBasedStoreFileTracker and teach it about the different versions. Bucket layouts for the HFile archive should also take the same approach. Snapshots are based on archiving so tackling one takes care of the other. {noformat} /hbase/archive/data//
//file.list //hfile1 //hfile2 ... {noformat} e.g. {noformat} /f572d396fae9206628714fb2ce00f72e94f2258f/7f900f36ebc78d125c773ac0e3a000ad355b8ba1.hfile /f572d396fae9206628714fb2ce00f72e94f2258f/988881adc9fc3655077dc2d4d757d480b5ea0e11.hfile {noformat} This is still not entirely ideal, but is the best we can do. Using cryptographic hashes of store metadata as prefixes distributes the placement of any given store into any potential S3 partition randomly. The probability of a client accessing any particular point in the HBase keyspace has a similar random distribution. These will not be the _same_ distribution, but should be a reasonable approximation. What should happen is hotspots will only impact clients accessing the specific store and region that is hotspotting, like today, and the blast radius is not significantly wider." Cut branch-3,13539114,Resolved,Major,Fixed,07/Jun/23 15:13,08/Jun/23 14:42,, Release 3.0.0-alpha-4,13536483,Resolved,Major,Fixed,17/May/23 03:02,08/Jun/23 14:33,, Finish 3.0.0-alpha-4 release,13539104,Resolved,Major,Fixed,07/Jun/23 14:06,08/Jun/23 14:32,,"# Release the artifacts on repository.apache.org (/) # Move the binaries from dist-dev to dist-release (/) # Add xml to download page(via HBASE-27913) (/) # Push tag 3.0.0-alpha-4RC0 as tag rel/3.0.0-alpha-4 (/) # Release 3.0.0-alpha-4 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12351845 (/) # Add release data on https://reporter.apache.org/addrelease.html?hbase (/) # Send announcement email (/)" Add 3.0.0-alpha-4 to download page,13539102,Resolved,Major,Fixed,07/Jun/23 14:03,07/Jun/23 15:08,, HBase is not starting due to Jersey library conflicts with javax.ws.rs.api jar,13534390,Resolved,Major,Fixed,28/Apr/23 04:29,01/Jun/23 13:10,3.0.0-alpha-3,"With some recent Atlas changes for supporting HTTP based hook support, HBase is not starting because of conflicts between jersey jars and rs-api jar. This Jira is to exclude the javax.ws.rs-api.jar from the HBase classpath. HBase uses shaded jersey jars and hence does not need to use this jar directly. However, it still adds this jar to the CLASSPATH while starting the server. Atlas on the other hand is using a non-shaded version of javax.ws.rs-api jar which causes this conflict and causes the hbase server fail while initializing atlas co-processor. Since hbase is using shaded jersey jar and not using this jar directly, it should be removed from the bundle as it may cause similar conflicts with other client applications potentially using it." log4j configuration file not worked,13538873,Resolved,Major,Not A Bug,06/Jun/23 07:43,08/Jun/23 01:57,,"HBase sets the HBASE_ROOT_LOGGER variable in many startup scripts, and finally places this variable in the startup parameters in the bin/hbase script, ""-Dhbase.root.logger=${HBASE_ROOT_LOGGER:-INFO,console}"". This is really strange as it overrides the log4j configuration, which is not beneficial for users who are not familiar with HBase because they cannot enable debug by modifying the log4j configuration." Bump cryptography from 39.0.1 to 41.0.0 in /dev-support/git-jira-release-audit,13538930,Resolved,Major,Fixed,06/Jun/23 13:47,06/Jun/23 13:59,, Put up 3.0.0-alpha-4RC0,13537928,Resolved,Major,Fixed,28/May/23 15:06,07/Jun/23 14:01,, NotServingRegionException while running IntegrationTestIngest with ChaosMonkey,13538846,Open,Major,,06/Jun/23 02:04,,,"While Running the command: {noformat} hbase org.apache.hadoop.hbase.IntegrationTestIngest --monkey slowDeterministic{noformat} Getting below errors: {noformat} 2023-06-05 08:44:07,362 INFO org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Finished pid=771, ppid=763, state=SUCCESS; CloseRegionProcedure a5882e880b2ea5eaa33bc972ef98ae9a, server=ozn-hbnew19-2.ozn-hbnew19.root.hwx.site,22101,1685953635506 in 12.8940 sec 2023-06-05 08:44:07,431 INFO org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure: Starting pid=763, ppid=731, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=IntegrationTestIngest, region=a5882e880b2ea5eaa33bc972ef98ae9a, REOPEN/MOVE; state=CLOSED, location=ozn-hbnew19-2.ozn-hbnew19.root.hwx.site,22101,1685953635506; forceNewPlan=false, retain=true 2023-06-05 08:44:07,543 ERROR org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable: org.apache.hadoop.hbase.NotServingRegionException: IntegrationTestIngest,182be0c5cdcd5072bb1864cdee4d3d6e-33,1685954003397.e02c6a03f3499091552f84577b27b942. is closing         at org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager$FlushTableSubprocedurePool.waitForOutstandingTasks(RegionServerFlushTableProcedureManager.java:274)         at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.flushRegions(FlushTableSubprocedure.java:115)         at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.acquireBarrier(FlushTableSubprocedure.java:126)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:160)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:46)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-06-05 08:44:07,550 ERROR org.apache.hadoop.hbase.procedure.Procedure: Procedure 'IntegrationTestIngest' execution failed! org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable via ozn-hbnew19-1.ozn-hbnew19.root.hwx.site,22101,1685953632178:org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable: org.apache.hadoop.hbase.NotServingRegionException: IntegrationTestIngest,182be0c5cdcd5072bb1864cdee4d3d6e-33,1685954003397.e02c6a03f3499091552f84577b27b942. is closing         at org.apache.hadoop.hbase.errorhandling.ForeignExceptionDispatcher.rethrowException(ForeignExceptionDispatcher.java:81)         at org.apache.hadoop.hbase.procedure.Procedure.waitForLatch(Procedure.java:382)         at org.apache.hadoop.hbase.procedure.Procedure.call(Procedure.java:204)         at org.apache.hadoop.hbase.procedure.Procedure.call(Procedure.java:67)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable: org.apache.hadoop.hbase.NotServingRegionException: IntegrationTestIngest,182be0c5cdcd5072bb1864cdee4d3d6e-33,1685954003397.e02c6a03f3499091552f84577b27b942. is closing  at org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager$FlushTableSubprocedurePool.waitForOutstandingTasks(RegionServerFlushTableProcedureManager.java:274)         at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.flushRegions(FlushTableSubprocedure.java:115)         at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.acquireBarrier(FlushTableSubprocedure.java:126)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:160)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:46)         ... 4 more 2023-06-05 08:44:07,552 INFO org.apache.hadoop.hbase.procedure.ZKProcedureUtil: Clearing all znodes for procedure IntegrationTestIngestincluding nodes /hbase2/flush-table-proc/acquired /hbase2/flush-table-proc/reached /hbase2/flush-table-proc/abort 2023-06-05 08:44:07,582 INFO org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer: Reassigned 1 regions. 1 retained the pre-restart assignment. 2023-06-05 08:44:07,583 INFO org.apache.hadoop.hbase.master.assignment.RegionStateStore: pid=741 updating hbase:meta row=76a8eaee60cc2aec2af1bbdfba6259a4, regionState=CLOSED 2023-06-05 08:44:07,650 INFO org.apache.hadoop.hbase.master.MasterRpcServices: Client=hbase//10.64.62.16 procedure request for: flush-table-proc 2023-06-05 08:44:07,659 INFO org.apache.hadoop.hbase.procedure.Procedure: Starting procedure 'IntegrationTestIngest' 2023-06-05 08:44:08,160 ERROR org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable: org.apache.hadoop.hbase.NotServingRegionException: IntegrationTestIngest,07507507,1685953771325.6c59d6c5a3b35231b11d5d4c854729f3. is closing         at org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager$FlushTableSubprocedurePool.waitForOutstandingTasks(RegionServerFlushTableProcedureManager.java:274)         at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.flushRegions(FlushTableSubprocedure.java:115)         at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.acquireBarrier(FlushTableSubprocedure.java:126)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:160)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:46)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) 2023-06-05 08:44:08,167 ERROR org.apache.hadoop.hbase.procedure.Procedure: Procedure 'IntegrationTestIngest' execution failed! org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable via ozn-hbnew19-3.ozn-hbnew19.root.hwx.site,22101,1685953632330:org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable: org.apache.hadoop.hbase.NotServingRegionException: IntegrationTestIngest,07507507,1685953771325.6c59d6c5a3b35231b11d5d4c854729f3. is closing         at org.apache.hadoop.hbase.errorhandling.ForeignExceptionDispatcher.rethrowException(ForeignExceptionDispatcher.java:81)         at org.apache.hadoop.hbase.procedure.Procedure.waitForLatch(Procedure.java:382)         at org.apache.hadoop.hbase.procedure.Procedure.call(Procedure.java:204)         at org.apache.hadoop.hbase.procedure.Procedure.call(Procedure.java:67)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable: org.apache.hadoop.hbase.NotServingRegionException: IntegrationTestIngest,07507507,1685953771325.6c59d6c5a3b35231b11d5d4c854729f3. is closing{noformat}" Can't get connection to ZooKeeper,13538790,Resolved,Major,Invalid,05/Jun/23 14:52,05/Jun/23 15:14,1.4.13,"I am using Hbase cluster along with apache kylin, the connection between Edge node and the Hbase cluster is good. following are the logs from Kylin side which shows Error exception: {code:java} java.net.SocketTimeoutException: callTimeout=1200000, callDuration=1275361: org.apache.hadoop.hbase.MasterNotRunningException: Can't get connection to ZooKeeper: KeeperErrorCode = ConnectionLoss for /hbase      at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:178)     at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:4551)     at org.apache.hadoop.hbase.client.HBaseAdmin.getTableDescriptor(HBaseAdmin.java:561)     at org.apache.hadoop.hbase.client.HTable.getTableDescriptor(HTable.java:585)     at org.apache.kylin.storage.hbase.steps.HFileOutputFormat3.configureIncrementalLoad(HFileOutputFormat3.java:328)     at org.apache.kylin.storage.hbase.steps.CubeHFileJob.run(CubeHFileJob.java:101)     at org.apache.kylin.engine.mr.common.MapReduceExecutable.doWork(MapReduceExecutable.java:144)     at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:179)     at org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)     at org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:179)     at org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:750) Caused by: org.apache.hadoop.hbase.MasterNotRunningException: org.apache.hadoop.hbase.MasterNotRunningException: Can't get connection to ZooKeeper: KeeperErrorCode = ConnectionLoss for /hbase     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1618)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1638)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1795)     at org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38)     at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:140)     ... 13 more Caused by: org.apache.hadoop.hbase.MasterNotRunningException: Can't get connection to ZooKeeper: KeeperErrorCode = ConnectionLoss for /hbase     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.checkIfBaseNodeAvailable(ConnectionManager.java:971)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.access$400(ConnectionManager.java:566)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1567)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1609)     ... 17 more Caused by: org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase     at org.apache.zookeeper.KeeperException.create(KeeperException.java:102)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)     at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1111)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:425)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.checkIfBaseNodeAvailable(ConnectionManager.java:960)     ... 20 more {code} Following are the logs from Hbase cluster master NOde which accepts the connection from Edge NOde(Kylin): {code:java} 2023-06-05 10:00:30,336 [myid:0] - INFO [CommitProcessor:0:NIOServerCnxn@1056] - Closed socket connection for client /10.127.2.201:37328 which had sessionid 0x7311c000c 2023-06-05 13:14:48,346 [myid:0] - INFO [PurgeTask:DatadirCleanupManager$PurgeTask@138] - Purge task started. 2023-06-05 13:14:48,346 [myid:0] - INFO [PurgeTask:DatadirCleanupManager$PurgeTask@144] - Purge task completed. 2023-06-05 13:22:39,872 [myid:0] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:NIOServerCnxnFactory@222] - Accepted socket connection from /10.127.2.233:42364 2023-06-05 13:22:39,873 [myid:0] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181:ZooKeeperServer@949] - Client attempting to establish new session at /10.127.2.233:42364 2023-06-05 13:22:39,874 [myid:0] - INFO [CommitProcessor:0:ZooKeeperServer@694] - Established session 0x7311c0022 with negotiated timeout 40000 for client /10.127.2.233:42364 {code} have check all the permission in HDFS and S3. Any leads would be really appreciated." [HBOSS] Open file fails with NumberFormatException for S3AFileSystem,13538438,In Progress,Major,,01/Jun/23 15:26,,1.0.0-alpha2,"In HADOOP-18724 it is shown that the new overloaded setters for double and float can cause type mismatch and end up setting s3a integer values to floats to see what breaks. The wrapper in HBASE-26483 should mimic the hadoop fix and for all double/float values passed in, cast to log and set as integers only. Nothing has ever used the float/double values, so this isn't a regression" Make HBCK be able to report unknown servers,13532564,Resolved,Major,Fixed,13/Apr/23 19:23,01/Jun/23 21:42,,Currently hbck is not reporting unknown servers it would be helpful to report those as inconsistencies so that directly hbck2 schedulerecoveries  option can be used to recover on unknown servers otherwise the taking the action for inconsistencies reported due to unknown servers may corrupt if not done properly. Bump requests from 2.28.1 to 2.31.0 in /dev-support/flaky-tests,13537357,Resolved,Major,Fixed,23/May/23 14:55,23/May/23 15:00,, "org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=895, WAL system stuck?",13538264,Open,Major,,31/May/23 12:37,,2.2.2,"2023-04-15 06:41:23,278 ERROR [regionserver/bdpprd03:16020-longCompactions-0] regionserver.CompactSplit: Compaction failed region=OLAP:XS_USER_BEHAVIOR_RISK,325001600010,1681250348046.3823c66e8cb8bca3bd9eb1757d3c2a1b., storeName=info, priority=9, startTime=1681511184093 *{color:#de350b}org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=895, WAL system stuck?{color}*         at org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:145)         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:731)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:611)         at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullAppendTransaction(WALUtil.java:158)         at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeMarker(WALUtil.java:136)         at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeCompactionMarker(WALUtil.java:70)         at org.apache.hadoop.hbase.regionserver.HStore.writeCompactionWalRecord(HStore.java:1512)         at org.apache.hadoop.hbase.regionserver.HStore.doCompaction(HStore.java:1441)         at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1428)         at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2235)         at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:616)         at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:658)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748)" "Failed to write hbase table,log show [responseTooSlow]",13536832,Open,Major,,19/May/23 07:02,,2.2.2,"*{color:#ff8b00}Failed to write hbase table, read is normal.{color}* *{color:#ff8b00}The server{color} {color:#ff8b00}is normal from hbase web,t{color}{color:#ff8b00}he queue is not blocked either.{color}* *Log:* 2023-05-19 11:42:39,975 WARN  [RpcServer.default.RWQ.Fifo.write.handler=67,queue=4,port=16020] ipc.RpcServer: ({*}{color:#de350b}responseTooSlow{color}{*}): \{""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1684466559818"",""responsesize"":""1713"",""method"":""Multi"",""param"":""region\u003d OLAP:LOAN_RESULT,,1653993471412.a377e202b93cc699fdf71b4f2cf38dcb., for 1 action(s) and 1st row key\u003d110105"",""processingtimems"":1200157,""client"":""10.16.7.117:50726"",""queuetimems"":1,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1} 2023-05-19 11:42:59,553 WARN  [RpcServer.default.RWQ.Fifo.write.handler=14,queue=5,port=16020] ipc.RpcServer: ({*}{color:#de350b}responseTooSlow{color}{*}): \{""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1684466579416"",""responsesize"":""1713"",""method"":""Multi"",""param"":""region\u003d OLAP:LOAN_RESULT,,1653993471412.a377e202b93cc699fdf71b4f2cf38dcb., for 1 action(s) and 1st row key\u003d110105"",""processingtimems"":1200137,""client"":""10.16.7.117:50734"",""queuetimems"":49934,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1} 2023-05-19 11:43:09,966 WARN  [RpcServer.default.RWQ.Fifo.write.handler=82,queue=1,port=16020] ipc.RpcServer: ({*}{color:#de350b}responseTooSlow{color}{*}): \{""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1684466589807"",""responsesize"":""1713"",""method"":""Multi"",""param"":""region\u003d OLAP:LOAN_RESULT,,1653993471412.a377e202b93cc699fdf71b4f2cf38dcb., for 1 action(s) and 1st row key\u003d110105"",""processingtimems"":1200159,""client"":""10.16.7.117:50726"",""queuetimems"":0,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1} 2023-05-19 11:43:19,252 WARN  [RpcServer.default.RWQ.Fifo.write.handler=21,queue=3,port=16020] ipc.RpcServer: ({*}{color:#de350b}responseTooSlow{color}{*}): \{""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1684466599057"",""responsesize"":""1713"",""method"":""Multi"",""param"":""region\u003d OLAP:LOAN_RESULT,,1653993471412.a377e202b93cc699fdf71b4f2cf38dcb., for 1 action(s) and 1st row key\u003d110105"",""processingtimems"":1200195,""client"":""10.16.7.117:50734"",""queuetimems"":39577,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1} 2023-05-19 11:43:39,630 WARN  [RpcServer.default.RWQ.Fifo.write.handler=54,queue=0,port=16020] ipc.RpcServer: ({*}{color:#de350b}responseTooSlow{color}{*}): \{""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1684466619485"",""responsesize"":""1713"",""method"":""Multi"",""param"":""region\u003d OLAP:LOAN_RESULT,,1653993471412.a377e202b93cc699fdf71b4f2cf38dcb., for 1 action(s) and 1st row key\u003d110105"",""processingtimems"":1200145,""client"":""10.16.7.117:50734"",""queuetimems"":0,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1} 2023-05-19 11:43:39,968 WARN  [RpcServer.default.RWQ.Fifo.write.handler=40,queue=4,port=16020] ipc.RpcServer: ({*}{color:#de350b}responseTooSlow{color}{*}): \{""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1684466619791"",""responsesize"":""1713"",""method"":""Multi"",""param"":""region\u003d OLAP:LOAN_RESULT,,1653993471412.a377e202b93cc699fdf71b4f2cf38dcb., for 1 action(s) and 1st row key\u003d110105"",""processingtimems"":1200177,""client"":""10.16.7.117:50734"",""queuetimems"":0,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1}   !屏幕截图 2023-05-29 172911.png!  " If moveAndClose fails HFileArchiver should delete any incomplete archive side changes,13535042,Resolved,Major,Fixed,04/May/23 17:56,25/May/23 23:44,2.5.4,See parent for motivation. "IntegrationTestManyRegions fails with ""Failed to create table""",13537777,Open,Major,,26/May/23 08:38,,,"Running Integration test on Hbase(Configured to run over Ozone) as follows: {noformat} hbase org.apache.hadoop.hbase.IntegrationTestsDriver -regex IntegrationTestManyRegions {noformat} The test fails with the below error: {noformat} 2023-05-25 09:10:15,506|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|23/05/25 09:10:15 INFO zookeeper.ZooKeeper: Session: 0x30587a0caee0917 closed 2023-05-25 09:10:15,507|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|23/05/25 09:10:15 INFO zookeeper.ClientCnxn: EventThread shut down for session: 0x30587a0caee0917 2023-05-25 09:19:40,083|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|23/05/25 09:19:40 ERROR hbase.IntegrationTestManyRegions: Failed to create table 2023-05-25 09:19:40,083|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|org.apache.hadoop.hbase.exceptions.TimeoutIOException: java.util.concurrent.TimeoutException: The procedure 489 is still running 2023-05-25 09:19:40,084|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:188) 2023-05-25 09:19:40,084|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.client.Admin.createTable(Admin.java:349) 2023-05-25 09:19:40,084|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.IntegrationTestManyRegions.testCreateTableWithRegions(IntegrationTestManyRegions.java:111) 2023-05-25 09:19:40,084|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 2023-05-25 09:19:40,084|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 2023-05-25 09:19:40,084|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 2023-05-25 09:19:40,085|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at java.lang.reflect.Method.invoke(Method.java:498) 2023-05-25 09:19:40,085|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) 2023-05-25 09:19:40,085|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) 2023-05-25 09:19:40,085|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) 2023-05-25 09:19:40,085|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) 2023-05-25 09:19:40,085|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) 2023-05-25 09:19:40,086|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) 2023-05-25 09:19:40,086|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) 2023-05-25 09:19:40,086|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) 2023-05-25 09:19:40,086|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) 2023-05-25 09:19:40,086|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) 2023-05-25 09:19:40,086|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) 2023-05-25 09:19:40,086|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) 2023-05-25 09:19:40,087|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) 2023-05-25 09:19:40,087|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) 2023-05-25 09:19:40,087|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) 2023-05-25 09:19:40,087|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) 2023-05-25 09:19:40,087|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) 2023-05-25 09:19:40,087|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) 2023-05-25 09:19:40,088|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at java.util.concurrent.FutureTask.run(FutureTask.java:266) 2023-05-25 09:19:40,088|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at java.lang.Thread.run(Thread.java:750) 2023-05-25 09:19:40,088|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|Caused by: java.util.concurrent.TimeoutException: The procedure 489 is still running 2023-05-25 09:19:40,088|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.waitProcedureResult(HBaseAdmin.java:3460) 2023-05-25 09:19:40,088|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.get(HBaseAdmin.java:3382) 2023-05-25 09:19:40,088|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:182) 2023-05-25 09:19:40,088|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|... 26 more 2023-05-25 09:19:40,089|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|23/05/25 09:19:40 INFO hbase.IntegrationTestManyRegions: Cleaning up after test. 2023-05-25 09:20:52,904|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|23/05/25 09:20:52 INFO client.HBaseAdmin: Operation: DELETE, Table Name: default:IntegrationTestManyRegions, procId: 2490 failed with Not DISABLED; tableName=IntegrationTestManyRegions, state=ENABLED 2023-05-25 09:20:52,921|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|E 2023-05-25 09:20:52,925|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|Time: 699.256 2023-05-25 09:20:52,926|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|There was 1 failure: 2023-05-25 09:20:52,926|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|1) testCreateTableWithRegions(org.apache.hadoop.hbase.IntegrationTestManyRegions) 2023-05-25 09:20:52,933|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|org.apache.hadoop.hbase.TableNotDisabledException: Not DISABLED; tableName=IntegrationTestManyRegions, state=ENABLED 2023-05-25 09:20:52,933|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at java.lang.Thread.getStackTrace(Thread.java:1564) 2023-05-25 09:20:52,934|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130) 2023-05-25 09:20:52,934|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149) 2023-05-25 09:20:52,934|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:186) 2023-05-25 09:20:52,934|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.client.Admin.deleteTable(Admin.java:389) 2023-05-25 09:20:52,935|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|at org.apache.hadoop.hbase.IntegrationTestManyRegions.tearDown(IntegrationTestManyRegions.java:94) 2023-05-25 09:20:52,935|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df| 2023-05-25 09:20:52,935|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|FAILURES!!! 2023-05-25 09:20:52,935|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|Tests run: 1, Failures: 1 2023-05-25 09:20:52,936|INFO|MainThread|machine.py:203 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df| 2023-05-25 09:20:53,283|INFO|MainThread|machine.py:232 - run()||GUID=5079831e-fed2-4115-a0ea-6e82f7cfa8df|Exit Code: 1 2023-05-25 09:20:53,283|INFO|MainThread|machine.py:238 - run()|Command /opt/cloudera/parcels/CDH/bin/hbase org.apache.hadoop.hbase.IntegrationTestsDriver -regex IntegrationTestManyRegions failed after 0 retries 2023-05-25 09:20:53,297|INFO|MainThread|conftest.py:267 - pytest_report_teststatus()|TEST ""test_runIntegrationTestManyRegions"" FAILED in 705.79 seconds{noformat} I tried checking the HMaster logs during the same TS: {noformat} 2023-05-25 09:10:02,290 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-7.ozn-lease19.root.hwx.site,22101,1685005607425 transition on state=OPEN, location=ozn-lease19-7.ozn-lease19.root.hwx.site,22101,1685005607425, table=IntegrationTestManyRegions, region=00967afde53476a802ae025287abef56 to OPENED 2023-05-25 09:10:02,290 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-3.ozn-lease19.root.hwx.site,22101,1685005608921 transition on state=OPEN, location=ozn-lease19-3.ozn-lease19.root.hwx.site,22101,1685005608921, table=IntegrationTestManyRegions, region=daadf5da9520987e5dcbe20cabe1ce80 to OPENED 2023-05-25 09:10:02,290 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-2.ozn-lease19.root.hwx.site,22101,1685005606403 transition on state=OPEN, location=ozn-lease19-2.ozn-lease19.root.hwx.site,22101,1685005606403, table=IntegrationTestManyRegions, region=199e3c7dd843b86d8ad753a1dcc85105 to OPENED 2023-05-25 09:10:02,291 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-5.ozn-lease19.root.hwx.site,22101,1685005607684 transition on state=OPEN, location=ozn-lease19-5.ozn-lease19.root.hwx.site,22101,1685005607684, table=IntegrationTestManyRegions, region=61f7fccb0eefea5e3586b2c4d61e3c83 to OPENED 2023-05-25 09:10:02,291 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-6.ozn-lease19.root.hwx.site,22101,1685005608861 transition on state=OPEN, location=ozn-lease19-6.ozn-lease19.root.hwx.site,22101,1685005608861, table=IntegrationTestManyRegions, region=48840208b5165a994e82bb3dc09eb0ce to OPENED 2023-05-25 09:10:02,292 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-6.ozn-lease19.root.hwx.site,22101,1685005608861 transition on state=OPEN, location=ozn-lease19-6.ozn-lease19.root.hwx.site,22101,1685005608861, table=IntegrationTestManyRegions, region=0cbe633670f5f124a4107250afd2079e to OPENED 2023-05-25 09:10:02,292 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-6.ozn-lease19.root.hwx.site,22101,1685005608861 transition on state=OPEN, location=ozn-lease19-6.ozn-lease19.root.hwx.site,22101,1685005608861, table=IntegrationTestManyRegions, region=5b0f726d4f59fb29fd153d8ea0730948 to OPENED 2023-05-25 09:10:02,292 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-8.ozn-lease19.root.hwx.site,22101,1685005606965 transition on state=OPEN, location=ozn-lease19-8.ozn-lease19.root.hwx.site,22101,1685005606965, table=IntegrationTestManyRegions, region=d8e74d20dcdb38774d44aca7a195811e to OPENED 2023-05-25 09:10:02,293 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-1.ozn-lease19.root.hwx.site,22101,1685005608089 transition on state=OPEN, location=ozn-lease19-1.ozn-lease19.root.hwx.site,22101,1685005608089, table=IntegrationTestManyRegions, region=767d263b1a5519398525c21de6be92fb to OPENED 2023-05-25 09:10:02,293 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-3.ozn-lease19.root.hwx.site,22101,1685005608921 transition on state=OPEN, location=ozn-lease19-3.ozn-lease19.root.hwx.site,22101,1685005608921, table=IntegrationTestManyRegions, region=93d06d0830a5009b8a50f4ff85eb0338 to OPENED 2023-05-25 09:10:02,294 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-1.ozn-lease19.root.hwx.site,22101,1685005608089 transition on state=OPEN, location=ozn-lease19-1.ozn-lease19.root.hwx.site,22101,1685005608089, table=IntegrationTestManyRegions, region=c230ebb6c6fe4f3d59c9015b136108b5 to OPENED 2023-05-25 09:10:02,294 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No matching procedure found for ozn-lease19-7.ozn-lease19.root.hwx.site,22101,1685005607425 transition on state=OPEN, location=ozn-lease19-7.ozn-lease19.root.hwx.site,22101,1685005607425, table=IntegrationTestManyRegions, region=d57326297360ffb56f1fe929c0ed1c1c to OPENED 2023-05-25 09:10:02,316 INFO org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL: Slow sync cost: 424 ms, current pipeline: []{noformat}" Possible NPE while getting cluster status from master,13537581,Open,Major,,25/May/23 03:56,,,"  {noformat} 2023-05-23 13:31:33,840 ERROR [RpcServer.default.FPBQ.Fifo.handler=395,queue=35,port=16000] ipc.RpcServer: Unexpected throwable object  java.lang.NullPointerException     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClusterStatusProtos$ServerTask$Builder.setStatus(ClusterStatusProtos.java:14120)     at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toServerTask(ProtobufUtil.java:3565)     at org.apache.hadoop.hbase.ClusterMetricsBuilder.lambda$toClusterStatus$4(ClusterMetricsBuilder.java:80)     at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)     at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384)     at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)     at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)     at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)     at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)     at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:566)     at org.apache.hadoop.hbase.ClusterMetricsBuilder.toClusterStatus(ClusterMetricsBuilder.java:80)     at org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:980)     at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:387)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) {noformat}" Bump requests from 2.22.0 to 2.31.0 in /dev-support/git-jira-release-audit,13537356,Resolved,Major,Fixed,23/May/23 14:54,23/May/23 14:59,, Avoid always reinit the decompressor in the hot read path,13537420,Open,Major,,24/May/23 03:07,,2.5.4,"When seting ""hbase.block.data.cachecompressed=true"", the cached blocks are decompressed when reading. But we are using pooled decompressors here, which means the decompressor configs should be refreshed as a prepare job before each decompressing, see the line here  [https://github.com/apache/hbase/blob/22526a6339afa230679bcf08fa1c917b04cdac6d/hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java#L99] I have pointed out the lock of Configuration.get problem in HBASE-27672, it should be avoid when reiniting in the hot read path either.  !image-2023-05-24-11-06-48-569.png|width=668,height=286!  " Hbase ImportTsv doesn't take ofs:// as a FS,13537250,Open,Major,,23/May/23 02:46,,,"While running the bulkLoad command: {noformat} hbase org.apache.hadoop.hbase.mapreduce.ImportTsv -Dhbase.fs.tmp.dir=ofs://ozone1/vol1/bucket1/hbase/bulkload -Dimporttsv.columns=HBASE_ROW_KEY,d:c1,d:c2 -Dimporttsv.bulk.output=ofs://ozone1/vol1/bucket1/hbase/test_VerifyHBaseNoWriteBulkloadHDFSQuota/hfiles table_dau3f3374e ofs://ozone1/vol1/bucket1/hbase/test_VerifyHBaseNoWriteBulkloadHDFSQuota/data.tsv{noformat} Getting: {noformat} 2023-05-22 17:01:23,263|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|Exception in thread ""main"" java.lang.IllegalArgumentException: Wrong FS: ofs://ozone1/vol1/bucket1/hbase/bulkload/partitions_72cbb1f1-d9b6-46a4-be39-e27a427c5842, expected: hdfs://ns1{noformat} Complete trace: {noformat} server-resourcemanager-3.1.1.7.1.8.3-339.jar:/opt/cloudera/parcels/CDH-7.1.8-1.cdh7.1.8.p3.40935426/lib/hadoop/libexec/../../hadoop-yarn/.//hadoop-yarn-registry-3.1.1.7.1.8.3-339.jar 2023-05-22 17:01:19,925|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:java.library.path=/opt/cloudera/parcels/CDH-7.1.8-1.cdh7.1.8.p3.40935426/bin/../lib/hadoop/lib/native 2023-05-22 17:01:19,925|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:java.io.tmpdir=/tmp 2023-05-22 17:01:19,925|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:java.compiler= 2023-05-22 17:01:19,925|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:os.name=Linux 2023-05-22 17:01:19,925|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:os.arch=amd64 2023-05-22 17:01:19,926|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:os.version=5.4.0-135-generic 2023-05-22 17:01:19,926|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:user.name=hrt_qa 2023-05-22 17:01:19,926|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:user.home=/home/hrt_qa 2023-05-22 17:01:19,926|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:user.dir=/hwqe/hadoopqe 2023-05-22 17:01:19,926|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:os.memory.free=108MB 2023-05-22 17:01:19,926|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:os.memory.max=228MB 2023-05-22 17:01:19,927|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Client environment:os.memory.total=145MB 2023-05-22 17:01:19,930|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ZooKeeper: Initiating client connection, connectString=ozn-lease16-1.ozn-lease16.root.hwx.site:2181,ozn-lease16-2.ozn-lease16.root.hwx.site:2181,ozn-lease16-3.ozn-lease16.root.hwx.site:2181 sessionTimeout=30000 watcher=org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$$Lambda$16/169226355@454e763 2023-05-22 17:01:19,942|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO common.X509Util: Setting -D jdk.tls.rejectClientInitiatedRenegotiation=true to disable client-initiated TLS renegotiation 2023-05-22 17:01:19,952|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ClientCnxnSocket: jute.maxbuffer value is 4194304 Bytes 2023-05-22 17:01:19,963|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.ClientCnxn: zookeeper.request.timeout value is 0. feature enabled= 2023-05-22 17:01:19,983|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:19 INFO zookeeper.Login: Client successfully logged in. 2023-05-22 17:01:20,003|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO zookeeper.Login: TGT refresh thread started. 2023-05-22 17:01:20,009|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO zookeeper.Login: TGT valid starting at: Mon May 22 13:07:24 UTC 2023 2023-05-22 17:01:20,010|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO zookeeper.Login: TGT expires: Tue May 23 13:07:24 UTC 2023 2023-05-22 17:01:20,010|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO zookeeper.Login: TGT refresh sleeping until: Tue May 23 08:54:46 UTC 2023 2023-05-22 17:01:20,010|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO client.ZooKeeperSaslClient: Client will use GSSAPI as SASL mechanism. 2023-05-22 17:01:20,033|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO zookeeper.ClientCnxn: Opening socket connection to server ozn-lease16-1.ozn-lease16.root.hwx.site/172.27.16.139:2181. Will attempt to SASL-authenticate using Login Context section 'Client' 2023-05-22 17:01:20,039|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO zookeeper.ClientCnxn: Socket connection established, initiating session, client: /10.104.25.105:47830, server: ozn-lease16-1.ozn-lease16.root.hwx.site/172.27.16.139:2181 2023-05-22 17:01:20,045|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:20 INFO zookeeper.ClientCnxn: Session establishment complete on server ozn-lease16-1.ozn-lease16.root.hwx.site/172.27.16.139:2181, sessionid = 0x10b4fe100361851, negotiated timeout = 30000 2023-05-22 17:01:22,655|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:22 INFO mapreduce.HFileOutputFormat2: bulkload locality sensitive enabled 2023-05-22 17:01:22,655|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:22 INFO mapreduce.HFileOutputFormat2: Looking up current regions for table table_dau3f3374e 2023-05-22 17:01:22,733|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:22 INFO mapreduce.HFileOutputFormat2: Configuring 1 reduce partitions to match current region count for all tables 2023-05-22 17:01:23,261|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|23/05/22 17:01:23 INFO client.ConnectionImplementation: Closing master protocol: MasterService 2023-05-22 17:01:23,263|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|Exception in thread ""main"" java.lang.IllegalArgumentException: Wrong FS: ofs://ozone1/vol1/bucket1/hbase/bulkload/partitions_72cbb1f1-d9b6-46a4-be39-e27a427c5842, expected: hdfs://ns1 2023-05-22 17:01:23,263|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:788) 2023-05-22 17:01:23,263|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:647) 2023-05-22 17:01:23,263|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configurePartitioner(HFileOutputFormat2.java:864) 2023-05-22 17:01:23,263|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configureIncrementalLoad(HFileOutputFormat2.java:661) 2023-05-22 17:01:23,264|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configureIncrementalLoad(HFileOutputFormat2.java:598) 2023-05-22 17:01:23,264|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.hbase.mapreduce.ImportTsv.createSubmittableJob(ImportTsv.java:546) 2023-05-22 17:01:23,264|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.hbase.mapreduce.ImportTsv.run(ImportTsv.java:754) 2023-05-22 17:01:23,264|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:81) 2023-05-22 17:01:23,264|INFO|MainThread|machine.py:203 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|at org.apache.hadoop.hbase.mapreduce.ImportTsv.main(ImportTsv.java:767) 2023-05-22 17:01:23,635|INFO|MainThread|machine.py:232 - run()||GUID=427ca366-5f0f-426c-a2e5-0c4e12bdae2d|Exit Code: 1 2023-05-22 17:01:23,635|INFO|MainThread|machine.py:238 - run()|Command /opt/cloudera/parcels/CDH/bin/hbase org.apache.hadoop.hbase.mapreduce.ImportTsv -Dhbase.fs.tmp.dir=ofs://ozone1/vol1/bucket1/hbase/bulkload -Dimporttsv.columns=HBASE_ROW_KEY,d:c1,d:c2 -Dimporttsv.bulk.output=ofs://ozone1/vol1/bucket1/hbase/test_VerifyHBaseNoWriteBulkloadHDFSQuota/hfiles table_dau3f3374e ofs://ozone1/vol1/bucket1/hbase/test_VerifyHBaseNoWriteBulkloadHDFSQuota/data.tsv failed after 0 retries {noformat}" Problem in flakey generated report causes pre-commit run to fail,13536754,Resolved,Major,Fixed,18/May/23 14:57,22/May/23 06:50,,"Have noticed the UT pre-commit run failed on this [latest PR for branch-2|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5241/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt] with the below: {noformat} Thu May 18 10:37:32 AM UTC 2023 cd /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-5241/yetus-jdk8-hadoop2-check/src/hbase-server /opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-5241/yetus-m2/hbase-branch-2-patch-1 --threads=4 -Djava.io.tmpdir=/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-5241/yetus-jdk8-hadoop2-check/src/target -DHBasePatchProcess -PrunAllTests -Dtest.exclude.pattern=**/regionserver.TestMetricsRegionServer.java,**/master.procedure.TestSnapshotProcedureRSCrashes.java,**/security.access.TestAccessController.java,**/conf.TestConfigurationManagerWARNING: package jdk.internal.util.random not in java.base.java,**/io.hfile.bucket.TestPrefetchPersistence.java,**/client.TestFromClientSide3.java,**/replication.TestReplicationMetricsforUI.java,**/io.hfile.bucket.TestBucketCache.java,**/replication.regionserver.TestReplicationValueCompressedWAL.java,**/master.procedure.TestHBCKSCP.java,**/http.TestInfoServersACL.java,**/io.hfile.bucket.TestBucketCachePersister.java,**/replication.TestReplicationKillSlaveRS.java,**/regionserver.TestClearRegionBlockCache.java,**/master.TestUnknownServers.java,**/replication.TestReplicationKillSlaveRSWithSeparateOldWALs.java,**/quotas.TestClusterScopeQuotaThrottle.java,**/io.hfile.TestBlockEvictionOnRegionMovement.java,**/replication.regionserver.TestMetaRegionReplicaReplicationEndpoint.java,**/regionserver.TestRegionReplicas.java,**/coprocessor.TestCoprocessorEndpointTracing.java,**/master.region.TestMasterRegionCompaction.java,**/io.hfile.TestPrefetchRSClose.java -Dsurefire.firstPartForkCount=0.5C -Dsurefire.secondPartForkCount=0.5C clean test -fae .... ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.861 s (Wall Clock) [INFO] Finished at: 2023-05-18T10:37:34Z [INFO] ------------------------------------------------------------------------ [ERROR] Unknown lifecycle phase ""jdk.internal.util.random"". You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1] [ERROR] {noformat} Note the ""{+}**/conf.TestConfigurationManagerWARNING: package jdk.internal.util.random not in java.base.java{+}"" passed as one of the supposedly flakey tests. Looking around our build scripts, I figured we pull the list of flakey from the ""{+}excludes{+}"" artifact generated by the latest ""find flakey"" build. It seems the [latest branch-2 run|https://ci-hbase.apache.org/job/HBase-Find-Flaky-Tests/job/branch-2/1063/artifact/output/excludes] generated this artifact with the wrong name already: {noformat} **/replication.TestReplicationMetricsforUI.java,**/conf.TestConfigurationManagerWARNING: package jdk.internal.util.random not in java.base.java,**/master.region.TestMasterRegionCompaction.java,**/regionserver.TestRegionReplicas.java,**/replication.regionserver.TestReplicationValueCompressedWAL.java,**/coprocessor.TestCoprocessorEndpointTracing.java,**/quotas.TestClusterScopeQuotaThrottle.java,**/replication.TestReplicationKillSlaveRSWithSeparateOldWALs.java,**/client.TestFromClientSide3.java,**/io.hfile.TestBlockEvictionOnRegionMovement.java,**/io.hfile.bucket.TestPrefetchPersistence.java,**/regionserver.TestMetricsRegionServer.java,**/io.hfile.bucket.TestBucketCachePersister.java,**/regionserver.TestClearRegionBlockCache.java,**/master.procedure.TestHBCKSCP.java,**/replication.regionserver.TestMetaRegionReplicaReplicationEndpoint.java,**/security.access.TestAccessController.java,**/io.hfile.bucket.TestBucketCache.java,**/io.hfile.TestPrefetchRSClose.java,**/replication.TestReplicationKillSlaveRS.java,**/master.TestUnknownServers.java,**/http.TestInfoServersACL.java {noformat} Digging deeper, found that the ""find flakey"" build checks the UT output of latest nightly and flakey builds, to parse it and generate the report. In some of the builds, such as [this one|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/812/artifact/output-jdk11-hadoop3/patch-unit-root.txt], results can be malformed, merging test names and WARNING messages in same line: {noformat} [INFO] Running org.apache.hadoop.hbase.conf.TestConfigurationManagerWARNING: package jdk.internal.util.random not in java.base [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.145 s - in org.apache.hadoop.hbase.conf.TestConfigurationManager {noformat} Thought about modifying the python script that generates the flakey report to also consider this malformed pattern when parsing test names." Should fast-fail if unmatched column family exists when using ImportTsv,13535178,Resolved,Major,Fixed,05/May/23 14:03,21/May/23 12:27,2.4.13,"Executing cmd as following: {code:java} //code hbase org.apache.hadoop.hbase.mapreduce.ImportTsv -Dimporttsv.separator=, -Dimporttsv.columns=HBASE_ROW_KEY,temp01_error01:first_name,temp01_error02:last_name test_hbase hdfs:///tmp/hbase_data.csv {code} If We specify a error column family(it does not exists), this operation would not fail until MR job is executed It is better to fast-fail before MR is submitted if we specify a error column family" TLS RPC unit tests are failing in precommit builds,13536461,Open,Major,,16/May/23 21:37,,,"For example: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5240/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt ERROR] Failures: [ERROR] TestSaslTlsIPC>AbstractTestSecureIPC.testSaslNoCommonQop:284 unexpected exception type thrown; expected: but was: [ERROR] Errors: [ERROR] TestSaslTlsIPC.testDifferentConfWithCryptoAES[4: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=true, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testRpcCallWithEnabledKerberosSaslAuthCanonicalHostname[3: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=false, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testRpcCallWithEnabledKerberosSaslAuthCanonicalHostname[4: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=true, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testRpcCallWithEnabledKerberosSaslAuthNoCanonicalHostname[3: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=false, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testRpcCallWithEnabledKerberosSaslAuthNoCanonicalHostname[4: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=true, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testRpcCallWithEnabledKerberosSaslAuth[4: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=true, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testRpcFallbackToSimpleAuth[4: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=true, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testSaslWithCommonQop[4: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=true, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [ERROR] TestSaslTlsIPC.testSaslWithCryptoAES[4: caKeyType=RSA, certKeyType=RSA, keyPassword=[C@1f760b47, acceptPlainText=true, clientTlsEnabled=true] » CertificateExpired NotAfter: Tue May 16 00:00:00 GMT 2023 [WARNING] Flakes: [WARNING] org.apache.hadoop.hbase.security.TestNettyTLSIPCFileWatcher.testReplaceClientAndServerKeystore[1: keyType=RSA, storeFileType=PEM] [ERROR] Run 1: TestNettyTLSIPCFileWatcher.testReplaceClientAndServerKeystore:221 NullPointer [INFO] Run 2: PASS " Attach move replication queue storage from zookeeper to a separated HBase table design doc to git repo,13533577,Resolved,Major,Fixed,21/Apr/23 15:17,23/Apr/23 15:57,, Use a separate WAL provider for hbase:replication table,13531397,Resolved,Major,Fixed,04/Apr/23 07:19,08/Apr/23 02:51,,"TestMultiSlaveReplication fails when using table based replication queue storage The test uses a small wal rolling size for testing more operations {code} // smaller block size and capacity to trigger more operations // and test them conf1.setInt(""hbase.regionserver.hlog.blocksize"", 1024 * 20); conf1.setInt(""replication.source.size.capacity"", 1024); {code} But after moving to table based replication queue storage, the update to hbase:replication tablr will also be append to the same WAL file, so it will make the replicaton worker move forward, and then it will update the hbase:replication table since the offset has been changed, so then it will make the replication work again, and so on... This will make the wal file size reach the configured size easily and trigger unexpected wal rolling, and then fail the test. For fixing the test, we can increase the wal rolling size, or we can use multi wal, to separate the wal files of hbase:replication table along. so it will not mess up the normal wal files. " Reduce the Cardinality for TestFuzzyRowFilterEndToEndLarge,13536103,Resolved,Major,Fixed,14/May/23 14:29,15/May/23 02:57,,"It also timed out on master branch. https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/839/ " TestThriftServerCmdLine fails with org.apache.hadoop.hbase.SystemExitRule$SystemExitInTestException,13536130,Resolved,Major,Fixed,14/May/23 15:37,15/May/23 04:07,,"https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/839/testReport/junit/org.apache.hadoop.hbase.thrift/TestThriftServerCmdLine/health_checks___yetus_jdk11_hadoop3_checks___testRunThriftServer_13_/ {noformat} org.apache.hadoop.hbase.SystemExitRule$SystemExitInTestException at org.apache.hadoop.hbase.TestSecurityManager.checkExit(TestSecurityManager.java:32) at java.base/java.lang.Runtime.exit(Runtime.java:114) at java.base/java.lang.System.exit(System.java:1752) at org.apache.hadoop.hbase.thrift.ThriftServer$2.run(ThriftServer.java:850) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/javax.security.auth.Subject.doAs(Subject.java:361) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1742) at org.apache.hadoop.hbase.thrift.ThriftServer.run(ThriftServer.java:836) at org.apache.hadoop.hbase.thrift.ThriftServerRunner.run(ThriftServerRunner.java:54) {noformat}" Add hadoop 3.3.5 check in our personality script,13536030,Resolved,Major,Fixed,13/May/23 00:52,15/May/23 02:56,, hbase regionserver with phoenix process is java crash.,13536211,Open,Major,,15/May/23 10:44,,2.2.2,"hbase regionserver with phoenix process is java crash.   [hbase@hadoop62 ~]$ *more hs_err_pid97203.log*  # # A fatal error has been detected by the Java Runtime Environment: # #  SIGSEGV (0xb) at pc=0x00007fc60858ad3e, pid=97203, tid=0x00007fbd8291a700 # # JRE version: Java(TM) SE Runtime Environment (8.0_241-b07) (build 1.8.0_241-b07) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.241-b07 mixed mode linux-amd64 ) # Problematic frame: {color:#ff8b00}*# V  [libjvm.so+0x7ddd3e]*{color} # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try ""ulimit -c unlimited"" before starting Java again # # If you would like to submit a bug report, please visit: #   [http://bugreport.java.com/bugreport/crash.jsp] # ---------------  T H R E A D  --------------- Current thread (0x00007fc60329a000):  JavaThread ""RpcServer.default.RWQ.Fifo.write.handler=72,queue=0,port=16020"" daemon [_thread_in_vm, id=98 127, stack(0x00007fbd8281a000,0x00007fbd8291b000)] siginfo: si_signo: 11 (SIGSEGV), si_code: 2 (SEGV_ACCERR), si_addr: 0x00007fbcc3a90000 Registers: RAX=0x00007fbcc3ad11de, RBX=0x00007fc60329a000, RCX=0x00007fbe36e17c40, RDX=0xffffffffffff7dc4 RSP=0x00007fbd82918f88, RBP=0x00007fbd82918fd0, RSI=0x0000000000000000, RDI=0x00007fbcc39d11e6 R8 =0x0000000000080000, R9 =0x0000000000f00018, R10=0x00007fc5f16d63a7, R11=0x00007fc5f16d6358 R12=0x0000000000100000, R13=0x00007fbd82919000, R14=0x0000000000f00018, R15=0x0000000000000000 RIP=0x00007fc60858ad3e, EFLAGS=0x0000000000010282, CSGSFS=0x0000000000000033, ERR=0x0000000000000004   TRAPNO=0x000000000000000e .................... .................... 0x00007fc60858ad2e:   f0 48 89 74 d1 f0 48 8b 74 d0 f8 48 89 74 d1 f8 0x00007fc60858ad3e:   48 8b 34 d0 48 89 34 d1 48 83 c2 04 7e d4 48 83 0x00007fc60858ad4e:   ea 04 7c 93 eb a1 49 f7 c0 01 00 00 00 74 0c 66  Register to memory mapping: RAX=0x00007fbcc3ad11de is pointing into the stack for thread: 0x00007fc603d65000 RBX=0x00007fc60329a000 is a thread RCX= [error occurred during error reporting (printing register info), id 0xb] Stack: [0x00007fbd8281a000,0x00007fbd8291b000],  sp=0x00007fbd82918f88,  free space=1019k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V  [libjvm.so+0x7ddd3e] J 3060  sun.misc.Unsafe.{*}{color:#ff8b00}copyMemory{color}{*}(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007fc5f16d6421 [0x00007fc5f16d6340+0xe1] j  org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36 j  org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69 J 20259 C2 org.apache.phoenix.coprocessor.GlobalIndexRegionScanner.apply(Lorg/apache/hadoop/hbase/client/Put;Lorg/apache/hadoop/hbase/client/P ut;)V (95 bytes) @ 0x00007fc5f4539414 [0x00007fc5f4538d00+0x714] J 32073 C2 org.apache.phoenix.hbase.index.IndexRegionObserver.preBatchMutate(Lorg/apache/hadoop/hbase/coprocessor/ObserverContext;Lorg/apache/ hadoop/hbase/regionserver/MiniBatchOperationInProgress;)V (31 bytes) @ 0x00007fc5f5e8c8ac [0x00007fc5f5e8a6e0+0x21cc] J 31164 C2 org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(Lorg/apache/hadoop/hbase/regionserver/HRegion$BatchOperation;)V (500  bytes) @ 0x00007fc5f4ec0e58 [0x00007fc5f4ec0640+0x818] J 31154 C2 org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(Lorg/apache/hadoop/hbase/regionserver/HRegion$BatchOperation;)[Lorg/apache /hadoop/hbase/regionserver/OperationStatus; (171 bytes) @ 0x00007fc5f5968218 [0x00007fc5f5967ea0+0x378] J 31155 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$Region ActionResult$Builder;Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apache/hadoop/hbase/quotas/OperationQuota;Ljava/util/List;Lorg/apache/ hadoop/hbase/CellScanner;Lorg/apache/hadoop/hbase/quotas/ActivePolicyEnforcement;Z)V (646 bytes) @ 0x00007fc5f53fa1d4 [0x00007fc5f53f9620+0xbb 4] J 20397 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apa che/hadoop/hbase/quotas/OperationQuota;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionAction;Lorg/apache/hadoop/hbase/C ellScanner;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;Ljava/util/List;JLorg/apache/hadoop/hbas e/regionserver/RSRpcServices$RegionScannersCloseCallBack;Lorg/apache/hadoop/hbase/ipc/RpcCallContext;Lorg/apache/hadoop/hbase/quotas/ActivePol icyEnforcement;)Ljava/util/List; (905 bytes) @ 0x00007fc5f4673be8 [0x00007fc5f4673360+0x888] J 20323 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcController;Lorg/apache /hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiRequest;)Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiRespon se; (698 bytes) @ 0x00007fc5f46106c4 [0x00007fc5f460ea60+0x1c64] J 16595 C2 org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(Lorg/apache/hbase/thirdparty/com/ google/protobuf/Descriptors$MethodDescriptor;Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcController;Lorg/apache/hbase/thirdparty/com/g oogle/protobuf/Message;)Lorg/apache/hbase/thirdparty/com/google/protobuf/Message; (221 bytes) @ 0x00007fc5f3d6f870 [0x00007fc5f3d6f5c0+0x2b0] J 23693 C2 org.apache.hadoop.hbase.ipc.RpcServer.call(Lorg/apache/hadoop/hbase/ipc/RpcCall;Lorg/apache/hadoop/hbase/monitoring/MonitoredRPCHan dler;)Lorg/apache/hadoop/hbase/util/Pair; (562 bytes) @ 0x00007fc5f4c620c8 [0x00007fc5f4c61980+0x748] J 21876 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1376 bytes) @ 0x00007fc5f36b62f0 [0x00007fc5f36b5440+0xeb0] J 16563 C2 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(Lorg/apache/hadoop/hbase/ipc/CallRunner;)V (268 bytes) @ 0x00007fc5f3d4db54 [0x 00007fc5f3d4da60+0xf4] J 20398% C2 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run()V (72 bytes) @ 0x00007fc5f4657fd4 [0x00007fc5f4657f60+0x74] v  ~StubRoutines::call_stub V  [libjvm.so+0x6894eb] V  [libjvm.so+0x686db3] V  [libjvm.so+0x687377] V  [libjvm.so+0x6f34ec] V  [libjvm.so+0xa8166b] V  [libjvm.so+0xa81971] V  [libjvm.so+0x90f542] C  [libpthread.so.0+0x7dd5]  start_thread+0xc5" Add hadolint binary to operator-tools yetus environment,13535771,Resolved,Major,Fixed,11/May/23 10:33,15/May/23 09:03,,"Since we're adding dockerfiles via HBASE-27827, let's also have a pre-commit check for them." CI integration for the integration test suite,13534984,In Progress,Major,,04/May/23 12:48,,,"Following HBASE-27836 , we should work out how to get CI running the integration tests, and a cluster to run them against. KinD or minikube maybe?" CI integration for unit test suite,13534982,In Progress,Major,,04/May/23 12:46,,,"We should figure out how to tie at least the unit tests into CI, either via the normal maven lifecycle or as an external thing yetus pre-commit knows about." HMaster.getCompactionState's return result about table compaction state is not quite right ,13535988,Open,Major,,12/May/23 13:30,,2.3.7,"1. The table compaction state should be NONE if all of those regions is online and is not compacting. 2. The Table compaction state should be null if one of those regions is not online and others is not compacting.  null means that the table compaction state we obtained is UNKOWN.   3. The Table compaction state should be minor/major when there are regions which is compacting" Skip family comparing when compare cells inner the store,13532154,Resolved,Major,Fixed,11/Apr/23 09:29,10/May/23 02:53,,"Currently we use CellComparatorImpl to compare cells, it compare row first, then family, then qulifier and so on. If the comparing inner the store, the families are always equal(unless the familyLength is zero for special purpose), so this step could be skipped for better performance." Move stable pointer to 2.5.x,13535445,Resolved,Major,Fixed,09/May/23 02:04,11/May/23 02:28,, NPE in MetricsMasterWrapperImpl.isRunning,13534822,Resolved,Major,Fixed,03/May/23 12:09,04/May/23 15:16,,"{quote} 2023-05-03T05:54:09,312 ERROR [HBase-Metrics2-1 {}] impl.MetricsSourceAdapter(202): Error getting metrics from source Master,sub=Server java.lang.NullPointerException: null at org.apache.hadoop.hbase.master.MetricsMasterWrapperImpl.isRunning(MetricsMasterWrapperImpl.java:143) ~[classes/:?] at org.apache.hadoop.hbase.master.MetricsMasterSourceImpl.getMetrics(MetricsMasterSourceImpl.java:92) ~[hbase-hadoop-compat-3.0.0-alpha-4-SNAPSHOT.jar:?] at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:200) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:183) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:156) ~[hadoop-common-3.2.4.jar:?] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333) ~[?:1.8.0_362] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319) ~[?:1.8.0_362] at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522) ~[?:1.8.0_362] at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:98) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:72) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:222) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:101) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:268) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:239) ~[hadoop-common-3.2.4.jar:?] at sun.reflect.GeneratedMethodAccessor54.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:324) ~[hadoop-common-3.2.4.jar:?] at com.sun.proxy.$Proxy31.postStart(Unknown Source) ~[?:?] at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:193) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:102) ~[hbase-hadoop-compat-3.0.0-alpha-4-SNAPSHOT.jar:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_362] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_362] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) ~[?:1.8.0_362] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) ~[?:1.8.0_362] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_362] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_362] at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] {quote} Found this in the output when running TestAssignmentManager.testAssignSocketTimeout. It should not be related to the failure of the test but anyway, throwing NPE is not good so we need to check whether this is a test issue or a real issue in our code." NPE in ClaimReplicationQueuesProcedure when running TestAssignmentManager.testAssignSocketTimeout,13534820,Resolved,Major,Fixed,03/May/23 12:07,04/May/23 14:55,,"{quote} 2023-05-03T05:56:10,094 ERROR [PEWorker-18 {}] procedure2.ProcedureExecutor(1669): CODE-BUG: Uncaught runtime exception: pid=8, ppid=5, state=RUNNABLE, hasLock=true; org.apache.hadoop.hbase.master.replication.ClaimReplicationQueuesProcedure java.lang.NullPointerException: null at org.apache.hadoop.hbase.master.replication.ClaimReplicationQueuesProcedure.execute(ClaimReplicationQueuesProcedure.java:83) ~[classes/:?] at org.apache.hadoop.hbase.master.replication.ClaimReplicationQueuesProcedure.execute(ClaimReplicationQueuesProcedure.java:48) ~[classes/:?] at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:919) ~[hbase-procedure-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650) ~[hbase-procedure-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396) ~[hbase-procedure-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75) ~[hbase-procedure-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962) ~[hbase-procedure-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[hbase-common-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1989) ~[hbase-procedure-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] {quote} We mock lots of things in this test so not sure this is a test issue or a real issue. Need to dig more. This should be a possible reason that why this test is flaky." TestFromClientSide5.testAppendWithoutWAL is flaky,13534449,Resolved,Major,Fixed,28/Apr/23 11:26,04/May/23 14:31,,"Not sure whether it is also flaky on branch-2.x, but at least on master, when we call Table.getScanner and get the returned ResultScanner, it does not mean that we have finished sending the request to region server, as the actual implementation is asynchronous. If we want a stable result, we need to at least get one row from the scanner." Split TestFuzzyRowFilterEndToEnd,13534441,Resolved,Major,Fixed,28/Apr/23 10:52,04/May/23 14:24,,"The testEndToEnd method has a 3 level nested loop, so it runs extremely slow, especially on a loaded server. I think at least we should move it out to a separated class." Store file archiving is not sufficiently indirected through the store file tracker,13534852,Open,Major,,03/May/23 16:04,,2.5.4,"GCRegionProcedure fails cleaning up old parents after splits. We time out “renaming” files into the archive. On S3, a rename operation is a whole file copy operation. It can take a long time to copy a large hfile. {noformat} [PEWorker-21] backup.HFileArchiver: Failed to archive FileablePath, s3a://[...] java.net.SocketTimeoutException: copyFile(data/default/cluster_test/[...], archive/data/default/cluster_test/[...]) on data/default/cluster_test/[...]: com.amazonaws.SdkClientException: Unable to execute HTTP request: Read timed out {noformat} Once we fail to “rename” the files into the archive we continue to fail because renames on S3 are not atomic. They are an object copy operation which is neither atomic nor automatically rolled back. The incomplete object remains present. The GCRegionProcedure can never complete successfully. {noformat} org.apache.hadoop.fs.FileAlreadyExistsException: Failed to rename s3a://[...] to s3a://[...]; destination file exists {noformat} {noformat} org.apache.hadoop.hbase.backup.FailedArchiveException: Failed to archive/delete all the files for region: ddaf1fb41197254483dcfd1d63e869d0 into s3a://[...]. Something is probably awry on the filesystem. {noformat} Short term mitigations: In HFileArchiver#resolveAndArchiveFile, if moveAndClose of the current file fails, attempt to delete the incomplete archive side file. Also set the recommended default read timeout for S3A to a larger value. Long term: When the file based store file tracker is enabled, the archived files for a store should not longer be moved to a separate path from the live files in the store. Instead whether or not the file is archived or not should be a status bit maintained in the tracker manifest." WalPlayer does not acquire delegation tokens for namenodes,13535018,Resolved,Major,Duplicate,04/May/23 16:04,04/May/23 16:15,,"The WalPlayer does not acquire delegation tokes for namenodes when creating the job. This results in the WalPlayer being unable to authenticate correctly with the namenodes the WALs live on.   {code:java} No HA service delegation token found for logical URI {code}" Backport HBASE-27091 to branch-2,13535006,Open,Major,,04/May/23 14:32,,2.4.17,"HBASE-27091 could be useful to branch-2 as well, creating this task for backporting from master" Support dynamic reinitializing replication peer storage,13533417,Resolved,Major,Fixed,20/Apr/23 15:11,03/May/23 11:52,,"When writing the documentation about how to migrate replication data online, I found out that, the replication related classes do not implement ConfigurationObserver, so we can not use online configuration update to load new replication peer storage..." 10k RpcServer.MAX_REQUEST_SIZE is not enough in ReplicationDroppedTable related tests,13534389,Resolved,Major,Fixed,28/Apr/23 04:12,01/May/23 14:44,,"The request size for regionServerReport is greater than 10k, so it will generate a lot of error messages and slow down the test, and also may fail the test." HBCK throws RejectedExecutionException when closing ZooKeeper resources,13534028,Resolved,Major,Fixed,25/Apr/23 15:49,01/May/23 15:53,2.4.17,"HBCK throws RejectedExecutionException at the end of run, because the order of closing ZooKeeper resources has been swapped in HBASE-27426. In ZKWatcher.java close() method first it shuts down the zkEventProcessor and when it fully shut down, it closes the RecoverableZooKeeper (the ZK client). The watcher receives the close event which cannot be submitted to the event processor and throws exception. I think we need to check whether the executor is able to receive jobs before submitting." Change flatten mode for oss in our pom file,13533576,Resolved,Major,Fixed,21/Apr/23 15:16,28/Apr/23 03:47,2.5.5,"Per the discussion here: https://lists.apache.org/thread/b971svby2js6qgzcbso71dfh8t4mly6j We plan to change the flatten mode to oss instead of default, to retain more sections in our pom file." Split TestReplicationDroppedTables,13534335,Resolved,Major,Fixed,27/Apr/23 15:18,28/Apr/23 03:37,,"It is flaky in pre commit for a long time, usually because of time out. But it always pass for me locally, as well as in nightly job(that's also why it does not in the flaky list It has 4 tests, not sure which one is the criminal, so I think we could split it into 4 standalone tests, so if it still fails, we can find out the actual flaky one." Update ref guide about the changes of the replication storage related concepts,13533072,Resolved,Major,Fixed,18/Apr/23 15:48,25/Apr/23 13:52,,"In the replication internal section, we still list zk as the only storage and do not mention that now we have a peer storage and a queue storage abstraction." REST Info Server improvements,13534122,Open,Major,,26/Apr/23 10:08,,, Encapsulate and centralize totalBufferUsed in ReplicationSourceManager,13532050,Resolved,Major,Fixed,10/Apr/23 13:40,21/Apr/23 13:54,3.0.0-alpha-3," {{ReplicationSourceManager.totalBufferUsed}} is a counter, and is scoped to {{ReplicationSourceManager}}, but it is copied to {{ReplicationSource}} and {{ReplicationSourceWALReader}}, which makes the logic about {{ReplicationSourceManager.totalBufferUsed}} is scattered throughout {{ReplicationSourceManager}},{{ReplicationSource}},{{ReplicationSourceWALReader}} and {{ReplicationSourceShipper}}. It causes duplicated code and would make tracing the buffer usage somewhat difficult when there is problem about {{totalBufferUsed}}. I think we should encapsulate and centralize it in {{ReplicationSourceManager}}." Implement a shell command to disable all peer modification,13531921,Resolved,Major,Fixed,08/Apr/23 03:09,21/Apr/23 01:57,,"This is used to switch peer storage implementation online. We can switch the peer storage like this: 1. Disable all peer modification. 2. Run the migration tool to migrate peer data from one storage to another. 3. Change all the hbase-site.xml files in the cluster. 4. Trigger online configuration change. 5. Enable peer modification." Upgrade vega and its related js libraries,13532332,Resolved,Major,Fixed,12/Apr/23 11:19,18/Apr/23 10:16,2.5.0,"HBase is using Vega, v5.19.1, which was released on 21 Jan, 2021 and is vulnerable to cross-site scripting (XSS), CVE IDs: * [CVE-2023-26486|https://nvd.nist.gov/vuln/detail/CVE-2023-26486] * [CVE-2023-26487|https://nvd.nist.gov/vuln/detail/CVE-2023-26487] This Jira is to upgrade to latest releases: * [https://github.com/vega/vega/releases/tag/v5.24.0] * [https://github.com/vega/vega-lite/releases/tag/v5.6.1] * [https://github.com/vega/vega-embed/releases/tag/v6.21.3]" Downgrade noisy info log in NettyRpcConnection when TLS enabled,13532087,Resolved,Major,Fixed,10/Apr/23 20:30,18/Apr/23 18:35,,"Log: SSL handler added with handshake timeout This logs for every server, so can cause quite a lot of spam for large clusters. I'm not sure it's worth it, we can downgrade to debug." Improve MemcachedBlockCache,13532691,Resolved,Major,Fixed,14/Apr/23 17:57,17/Apr/23 21:19,2.5.4,"MemcachedBlockCache is apparently not used, given the bugs I have found, but provides some useful functionality that we are investigating at $dayjob. Fix it. - Track and log better stats - Fix use of memcached API such that we are not accidentally immediately expiring keys. - Use a default retention period of 30 days, the max per memcached spec - Use set instead of add to store keys - Gracefully handle failures to cache and read timeouts - Add unit tests using jmemcached as a test dependency" Manage static javascript resources programatically,13533063,Open,Major,,18/Apr/23 15:23,,,"Currently, the static JavaScript resources need to be manually managed. That is, if any of these has to be updated, we will be required to download them from web and place them under the appropriate path. This can be cumbersome. See list of JS under hbase-server at [https://github.com/apache/hbase/tree/master/hbase-server/src/main/resources/hbase-webapps/static/js] Need to find a way to manage them with minimal manual effort. Best case would be to manage them as part of build.  " Data is deleted after the compaction and MOB cleaning operation,13532300,Open,Major,,12/Apr/23 08:27,,2.5.3,"I'm trying to save image binaries in the MOB column.   The column option is as follows: {INDEX_BLOCK_ENCODING => 'NONE', MOB_THRESHOLD => '102400', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', IS_MOB => 'true', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536 B (64KB)}   I set the `hbase.master.mob.cleaner.period` as 3600 (1h) and called `major_compact` in the shell,  to test if the compaction works as I expected. As a result, StorefileSize became 0 MB without any other operations being done on the table. Is it possible that the compaction job deletes all the data from the column?   The lost data size was about 150 TB and I am using 2000 region servers. (Data from other columns is fine) File count from the MOB directory decreased from 525K to 78K after the compaction + mob cleaning.   I could not find anything about deleting data from the hbase logs, and it is unlikely that any other process deleted the data. (I wrote the data to the newly build hbase cluster)   I wonder if there can be a reason why all the data is gone.  " FileChangeWatcher improvements,13531588,Resolved,Major,Fixed,05/Apr/23 13:48,09/Apr/23 19:04,,"HBASE-27347 ported FileChangeWatcher from ZK so that we can reload certificates when the keystore/truststore files change. I'd like to make a few improvements: # Add more context to the thread name, so that we can disambiguate when multiple are launched for different cluster connections or paths # We currently launch a separate FileChangeWatcher for each of keystorePath and truststorePath, but in many cases they may be the same path. The runnable which gets called is identical for these, so this just results in extra work for no reason. We should check the configured paths and only launch one FileChangeWatcher if the two paths are identical." Make X509Util config constants public,13531497,Resolved,Major,Not A Problem,04/Apr/23 19:27,10/Apr/23 20:19,,"Most of the config constants in X509Util are public, but some are package private or private. I don't see a huge reason to have this, and it makes it hard to configure without hardcoding strings that hopefully won't change. Let's unify on public." CompoundBloomFilters break with an error rate that is too high,13532084,Open,Major,,10/Apr/23 19:27,,2.5.2,"At my company we're beginning to more heavily utilize the bloom error rate configuration. This is because bloom filters are a nice optimization, but for well distributed workloads with relatively dense data (many rows:host), we've found that they can cause lots of memory/GC pressure unless they can entirely fit in the block cache (and consequently not churn memory that's subject to GC). Because it's easier to estimate the memory requirements of changes in existing bloom filters, rather than net new bloom filters, we wanted to begin with very high bloom error rates (and consequently small bloom filters), and then ratchet down as memory availability allowed. This led to us discovering that bloom filters appear to become corrupt at a relatively arbitrary error rate threshold. Blooms with an error rate of 0.61 work as expected, but produce nonsensical results with an error rate of 0.62. I've pushed this branch with test updates to demonstrate the deficit: [https://github.com/apache/hbase/compare/master...HubSpot:hbase:rmattingly/bloom-error-rate-bug] The test changes confirm that the BloomFilterUtil works as expected, at least with respect to its error rate : size relationship. You can see this in the output of {{{}TestBloomFilterChunk#testBloomErrorRateSizeRelationship{}}}:   {noformat} previousErrorRate=0.01, previousSize=1048568 currentErrorRate=0.05, currentSize=682109 previousErrorRate=0.05, previousSize=682109 currentErrorRate=0.1, currentSize=524284 previousErrorRate=0.1, previousSize=524284 currentErrorRate=0.2, currentSize=366459 previousErrorRate=0.2, previousSize=366459 currentErrorRate=0.4, currentSize=208634 previousErrorRate=0.4, previousSize=208634 currentErrorRate=0.5, currentSize=157826 previousErrorRate=0.5, previousSize=157826 currentErrorRate=0.75, currentSize=65504 previousErrorRate=0.75, previousSize=65504 currentErrorRate=0.99, currentSize=2289 {noformat}   With this in mind, the updates to {{TestCompoundBloomFilter}} tell us that the bug must live somewhere in the {{CompoundBloomFilter}} logic. The output indicates this:   {noformat} 2023-04-10T15:07:50,925 INFO  [Time-limited test] regionserver.TestCompoundBloomFilter(245): Functional bloom has error rate 0.01 and size 1kb ... 2023-04-10T15:07:56,657 INFO  [Time-limited test] regionserver.TestCompoundBloomFilter(245): Functional bloom has error rate 0.61 and size 1kb ... java.lang.AssertionError: False positive is too high: 0.9998533333333334 (greater than 0.65), fake lookup is enabled. Bloom size is 4687kb     at org.junit.Assert.fail(Assert.java:89)     at org.junit.Assert.assertTrue(Assert.java:42)     at org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter.readStoreFile(TestCompoundBloomFilter.java:243) {noformat}   The bloom size change from ~1kb -> 4687kb and total lack of precision is clearly not as intended, and totally inline with what we saw in our HBase clusters that attempted to use high bloom error rates.    " Incorrect ReplicationSourceWALReader. totalBufferUsed may cause replication hang up,13531449,Resolved,Major,Fixed,04/Apr/23 13:42,06/Apr/23 13:43,2.4.17,"When we read a new WAL Entry in {{ReplicationSourceWALReader.readWALEntries}}, we add {{ReplicationSourceWALReader.totalBufferUsed}} by the size of new entry in {{ReplicationSourceWALReader.addEntryToBatch}}, but the whole {{WALEntryBatch}} may not be put to the {{ReplicationSourceWALReader.entryBatchQueue}} because of exception(eg. exception thrown by {{WALEntryFilter.filter}} for following WAL Entry), and the {{ReplicationSourceWALReader.totalBufferUsed}} is not decreased in this case. Because the {{ReplicationSourceWALReader.totalBufferUsed}} is actually scoped to {{ReplicationSourceManager}}, after a long run, replication to all peers may hang up." Add 2.4.17 to download page,13531053,Resolved,Major,Fixed,01/Apr/23 01:03,07/Apr/23 08:23,,need a PR to add rel/2.4.17 to download page. Put up 2.4.17RC0 ,13531052,Resolved,Major,Fixed,01/Apr/23 01:02,06/Apr/23 15:10,,send out vote for 2.4.17RC0 Complete Release 2.4.17,13531051,Resolved,Major,Fixed,01/Apr/23 01:01,07/Apr/23 16:05,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Add xml to download page # Push tag 2.4.17RC0 as tag rel/2.4.17 # Release 2.4.17 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12352760 # Add release data on [https://reporter.apache.org/addrelease.html?hbase] # Send announcement email" STUCK Region-In-Transition state,13531265,Open,Major,,03/Apr/23 11:48,,2.4.11,"One problem we encounter with some regularity is the `STUCK Region-In-Transition state=OPENING`. We have a three server cluster that runs a full HBASE stack: 3 zookeeper nodes, an HBASE master active and standby, 3 region servers, 3 HDFS data nodes. We've managed to reproduce the stuck region in transition state, by rebooting randomly one of the 3 nodes. This is not necessarily the only way it may end up in this state, rather a deterministic way we managed to reproduce it to a certain extent. Also (a) writing data to hbase while the node reboot happens increases the chances of the stuck state being reached as well as (b) if the rebooted node is also the active hbasemaster. Sample logs:   {code:java} [7745.457s][info][gc] GC(12) Pause Young (Normal) (G1 Evacuation Pause) 523M->44M(818M) 12.736ms [10505.454s][info][gc] GC(13) Pause Young (Normal) (G1 Evacuation Pause) 523M->44M(818M) 11.066ms 2023-04-03 11:26:53,208 WARN  [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=b732898573f935b72fb1876c6ff944b3 2023-04-03 11:27:53,208 WARN  [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=78be037bae2fc201707fa511e90dfbbf 2023-04-03 11:27:53,208 WARN  [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=b732898573f935b72fb1876c6ff944b3 2023-04-03 11:28:53,145 INFO  [master/cvp504:16000.Chore.1] master.HMaster: Not running balancer (force=false, metaRIT=false) because 2 region(s) in transition: [state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=78be037bae2fc201707fa511e90dfbbf, state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=b732898573f935b72fb1876c6ff944b3] 2023-04-03 11:28:53,168 WARN  [master/cvp504:16000.Chore.1] janitor.CatalogJanitor: unknown_server=cvp503.sjc.aristanetworks.com,16201,1680499899167/aeris_v2,\x09,1680499940070.78be037bae2fc201707fa511e90dfbbf., unknown_server=cvp503.sjc.aristanetworks.com,16201,1680499899167/aeris_v2,\x12,1680499940070.b732898573f935b72fb1876c6ff944b3. 2023-04-03 11:28:53,208 WARN  [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=78be037bae2fc201707fa511e90dfbbf 2023-04-03 11:28:53,208 WARN  [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=b732898573f935b72fb1876c6ff944b3 2023-04-03 11:29:53,209 WARN  [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=78be037bae2fc201707fa511e90dfbbf 2023-04-03 11:29:53,209 WARN  [ProcExecTimeout] assignment.AssignmentManager: STUCK Region-In-Transition state=OPENING, location=cvp504.sjc.aristanetworks.com,16201,1680509017771, table=aeris_v2, region=b732898573f935b72fb1876c6ff944b3{code}   The stuck state also gets _fixed_ if we kill the pod with the regionserver which has the region with stuck in transition." "bin/hbase --help does not list ""omnibus_tarball"" options",13531437,Open,Major,,04/Apr/23 12:26,,2.4.17,"Launching {{bin/hbase --help}} from the 2.4.17RC0 full distribution tarball, I see a limited set of options. It looks like we do not source hbase-config.sh before printing the help message, which means {{HBASE_HOME}} is not set, and we don't get the extended output." Add support for dump and process metrics servlet in REST InfoServer,13534124,Resolved,Minor,Fixed,26/Apr/23 10:10,01/Mar/24 13:14,,"Unlike other HBase Master/RS Info Servers, HBase REST Server does not provide a way to: * Get debug dump for quick access to stacks, logs etc. * Get process metrics like threads, gc collectors etc. This task is add the above in HBase REST InfoServer." Update downloads.xml for release 2.5.4,13532724,Resolved,Minor,Fixed,15/Apr/23 01:05,15/Apr/23 01:06,, Skip submitting Split/Merge procedure when split/merge is disabled at table level,13538580,Resolved,Minor,Fixed,02/Jun/23 11:26,25/Sep/24 05:50,,"*Scenario* If split/merge is disabled at table level , master will submit a SplitTableRegionProcedure/MergeTableRegionsProcedure , and rollback it as execution fails during pre-checks . *Improvement* Master can check it early and no need to submit SplitTableRegionProcedure/MergeTableRegionsProcedure when split/merge switch is disabled at Table level. *Steps* {code:java} create 'testCreateTableWithMergeDisableParameter', 'f1', {MERGE_ENABLED => false} list_regions 'testCreateTableWithMergeDisableParameter' merge_region 'd21cdc5d488e8036017696c46cffd9b1','6382c8f731a4f0379b6e98ece4b06e3e' {code} {code:java} create 'testcreatetablewithsplitdisableparameter', 'f1', {SPLIT_ENABLED => false} split 'testcreatetablewithsplitdisableparameter','30'{code}  " Update hbase_docker with an extra Dockerfile compatible with mac m1 platfrom,13539111,Resolved,Minor,Fixed,07/Jun/23 14:45,22/May/24 15:51,,"When trying to use the current Dockerfile under ""./dev-support/hbase_docker"" on m1 macs, the docker build fails at the git clone & mvn build stage with below error: {noformat} #0 8.214 qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory {noformat} It turns out for mac m1, we have to explicitly define the platform flag for the ubuntu image. I thought we could add a note in this readme, together with an ""m1"" subfolder containing a modified copy of this Dockerfile that works on mac m1s." Enable PE to load any custom implementation of tests at runtime,13540360,Resolved,Minor,Fixed,16/Jun/23 09:25,15/May/24 21:57,,"Right now to add any custom PE.Test implementation it has to have a compile time dependency of those new test classes in PE, this is to enable PE to load any custom impl of tests at runtime and utilise PE framework for any custom implementations." Enable cache control for logs endpoint and set max age as 0,13534084,Resolved,Minor,Fixed,26/Apr/23 04:47,29/May/23 05:52,,"Not setting the proper header values may cause browsers to store pages within their respective caches. On public, shared, or any other non-private computers, a malicious person may search through the browser cache to locate sensitive information cached during another user's session. /logs endpoint contains sensitive information that an attacker can exploit. Any page with sensitive information needs to have the following headers in response: Cache-Control: no-cache, no-store, max-age=0 Pragma: no-cache Expires: -1" Tooling for parsing/reading the prefetch files list file,13532645,Resolved,Minor,Fixed,14/Apr/23 10:18,02/Nov/23 21:07,3.0.0-alpha-4,"The content of the file defined by hbase.prefetch.file.list.path is encoded. It would be nice to have some extra tool for properly parsing it and print the list in human readable format, for easy of troubleshooting." Directly schedule procedures that do not need to acquire locks,13538677,Open,Minor,,03/Jun/23 13:33,,3.0.0-alpha-3,"Currently, in the procedure scheduler, we will not schedule any other procedures for a given queue if a procedure has held the exclusive lock, even if a procedure does not require any locks. For such procedures that do not require locks, we prefer that they can be executed directly without waiting until the procedure that held the exclusive lock is executed before starting to schedule execution. Otherwise, if the procedure holding the exclusive lock is stuck, the procedure that does not need the lock will also wait forever." expose metaCacheHits in MetricsConnection,13537495,Open,Minor,,24/May/23 14:28,,3.0.0-alpha-3, Remove redundant avro.version property from Kafka connector,13532843,Resolved,Minor,Fixed,17/Apr/23 08:13,17/Apr/23 08:54,connector-1.0.0,"1.7.7 is defined both in the main connectors pom, and in the kafka module. This is not useful." The sleep time in checkQuota of replication WAL reader should be controlled independently ,13537417,Open,Minor,,24/May/23 02:45,,2.5.4,"In theory the sleep time when checking quota failed in replication WAL reader should match the consume ability of the memory. But at the very least we should isolate the configuration here with the sleep time for common circumstances when replicating, e.g. sleep before reading from the head of the WAL, to avoid a little bit larger but reasonable sleep time(e.g. 3s) can make the consume speed always blocked by checking quota or cannot recover the consume speed in a very long time(except there exists long time of low source WAL production peak)." Increases the concurrency of off-peak compactions,13535909,Open,Minor,,12/May/23 03:58,,,"The current off-peak compactions are global comparisons. There can only be one off-peak compact running at a time, which does not make better use of the system resources during the off-peak period. This is not very friendly for clusters with significant peaks and valleys of business. Code： {code:java} private static final AtomicBoolean offPeakCompactionTracker = new AtomicBoolean(); // Normal case - coprocessor is not overriding file selection. if (!compaction.hasSelection()) {  boolean isUserCompaction = priority == Store.PRIORITY_USER;  boolean mayUseOffPeak =    offPeakHours.isOffPeakHour() && offPeakCompactionTracker.compareAndSet(false, true);  try {    compaction.select(this.filesCompacting, isUserCompaction, mayUseOffPeak,      forceMajor && filesCompacting.isEmpty());  } catch (IOException e) {    if (mayUseOffPeak) {      offPeakCompactionTracker.set(false);    }    throw e;  }  assert compaction.hasSelection();  if (mayUseOffPeak && !compaction.getRequest().isOffPeak()) {    // Compaction policy doesn't want to take advantage of off-peak.    offPeakCompactionTracker.set(false);  } }{code}   I think it could be optimized to allow the user to set the number of concurrent off-peak compactions.    " Fix the javadoc for SyncFutureCache,13538678,Resolved,Minor,Fixed,03/Jun/23 13:43,20/Jul/23 13:49,,"It does not have any html markers so spotless messed it up... We should add html markers so it could keep the format after 'spotless:apply' {code} /** * A cache of {@link SyncFuture}s. This class supports two methods * {@link SyncFutureCache#getIfPresentOrNew()} and {@link SyncFutureCache#offer()}. *

* Usage pattern: * * 

 *   SyncFuture sf = syncFutureCache.getIfPresentOrNew();
 *   sf.reset(...);
 *   // Use the sync future
 *   finally: syncFutureCache.offer(sf);
 *
* * Offering the sync future back to the cache makes it eligible for reuse within the same thread * context. Cache keyed by the accessing thread instance and automatically invalidated if it remains * unused for {@link SyncFutureCache#SYNC_FUTURE_INVALIDATION_TIMEOUT_MINS} minutes. */ {code}" Distinguish the mutate types of rpc error in MetricsConnection,13535115,Resolved,Minor,Fixed,05/May/23 07:55,06/Jul/23 02:45,,"There are four mutate types in HBase, including {_}Append{_}, {_}Delete{_}, {_}Increment{_}, and _Put._ However, when rpc error occurs on the client, mutate types are not distinguished in MetricsConnection." listTableNames has different criteria for judging the regular matching of tables in the default namespace,13539994,Open,Minor,,14/Jun/23 07:16,,2.0.0,"There are the following tables under default: order_info, test123 When I execute the following logic (get the table that starts with test), test123 is returned {code:java} String tableNameRegex = ""^(test).*""; TableName[] tns = admin.listTableNames(Pattern.compile(tableNameRegex));{code} When I execute the following logic (get a table that doesn't start with test), the return is order_info, test123 {code:java} String tableNameRegex = ""^(?!test).*""; TableName[] tns = admin.listTableNames(Pattern.compile(tableNameRegex));{code} As you can see, table test123 is returned both times.   When I look at the source code, I find that when I perform a regular match for the table in the default namespace, I perform one step more judgment, resulting in a table starting with test being returned both times. {code:java} boolean matched = pattern.matcher(tableName).matches(); if (!matched && htd.getTableName().getNamespaceAsString().equals(defaultNS)) { matched = pattern.matcher(defaultNS + TableName.NAMESPACE_DELIM + tableName).matches(); }{code}   I think there are problems with this regular matching logic  " The description about hbase.hstore.comactionThreshold is not accurate,13540771,Resolved,Minor,Fixed,20/Jun/23 14:24,05/Jul/23 14:40,2.3.7,"In document hbase-default.xml， The  description about [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/] is not accurate，as follow： !2023-06-20_221700.png! Actually，hbase will run compaction when the number of store files greater than or equal to [hbase.hstore.comactionThreshold|http://hbase.hstore.comactionthreshold/], as follow !2023-06-20_221821.png!  " ClientSideRegionScanner does not adhere to RegionScanner.nextRaw contract,13541180,Resolved,Minor,Fixed,23/Jun/23 13:45,23/Jun/23 18:05,,A follow-on for HBASE-26630 so that we can fix the actual logic in ClientSideRegionScanner so that it works for all ReadTypes and/or when used outside of the context of TableSnapshotInputFormat Record readBlock message in log when it takes too long time,13537580,Resolved,Minor,Fixed,25/May/23 03:29,16/Jun/23 15:35,2.5.3,After HBASE-15160， we can record the readBlock message by TRACE log in org.apache.hadoop.hbase.io.hfile.HFileBlock.FSReaderImpl#readBlockDataInternal， But it record all read block message in TRACE log， some times， we only focus the block read cost too much time.. Stable version outdated on https://hbase.apache.org/downloads.html,13540165,Resolved,Minor,Fixed,15/Jun/23 08:36,15/Jun/23 10:49,2.5.4,"In HBASE-27849, the stable version of HBase was updated to 2.5.x. This updated the [https://downloads.apache.org/hbase/] page. However, the download page ([https://hbase.apache.org/downloads.html)] still refers to 2.4.x as the stable version." Update downloads.xml for release 2.5.5,13539927,Resolved,Minor,Fixed,13/Jun/23 20:03,13/Jun/23 20:07,, [hbase-thirdparty] Include netty-tcnative in hbase-shaded-netty,13538702,Resolved,Minor,Not A Problem,04/Jun/23 14:47,09/Jun/23 13:40,,"At my company, HubSpot, we are starting to use HBase's TLS support in our clusters. I've done some experiments with different TLS implementations to see which has the best performance. I have tested Java 11 without {{{}UseAESCTRInstrinics{}}}, Java 11 with {{{}UseAESCTRInstrinsics{}}}, with and without {{netty-tcnative}} installed, on both {{x86_64}} and {{{}arm64{}}}. I will attach some charts. -I have found that using the {{netty-tcnative}} library gives the best performance overall, and I would like to see it included in HBase by default.- This ticket is for tracking the change to hbase-thirdparty and producing a new version of that. Another ticket will track the inclusion of that new version in HBase, which requires a few code changes." Beautify the output information of the getStats method in ReplicationSource,13538373,Resolved,Minor,Fixed,01/Jun/23 08:38,06/Jun/23 15:01,3.0.0-alpha-3,"When multiple replicationSourceShippers appear in our production environment, the output information of the getStats method is not wrapped and printed   !image-2023-06-01-16-35-08-817.png!" Support dynamic adjustment of flusher count,13535631,Resolved,Minor,Fixed,10/May/23 12:07,06/Jun/23 14:19,3.0.0-alpha-3, xerial's snappy-java requires GLIBC >= 2.32,13536649,Resolved,Minor,Fixed,18/May/23 04:54,26/May/23 00:16,2.5.4,"We need to add a native library load check with a helpful error message if it fails to load due to a too old glibc or similar reason, and disable the unit test if the native library fails to load. {noformat} TestHFileCompressionSnappy.test:54->HFileTestBase.doTest:72 » UnsatisfiedLink /home/apurtell/src/hbase/hbase-compression/hbase-compression-snappy/target/snappy-1.1.9-6406bd03-44b4-4586-a91b-79d213c14062-libsnappyjava.so: /lib/aarch64-linux-gnu/libc.so.6: version `GLIBC_2.32' {noformat} In this case a Debian test VM has ""Debian GLIBC 2.31-13+deb11u6"" installed, which is too old. " Close the L1 victim handler race,13536318,Resolved,Minor,Fixed,15/May/23 21:14,26/May/23 00:04,2.5.4,"When we evict a block from L1 and move it to L2 there is a brief window of time where we have removed the block from the L1 map and yet the victim handler has not completed execution. Some read-your-write use cases can be significantly impacted even though the window is small. Imagine a use case where PRELOAD_DATA_ON_OPEN and CACHE_DATA_ON_WRITE are both enabled to warm cache ahead of access and any miss can be problematic. Perhaps a particularly latency sensitive case with HFiles backed by S3. Victim handling can be made atomic with respect to the unmapping operation with ConcurrentHashMap#computeIfPresent. The upside is there will be no L1+L2 misses during the transition. The downside is if the victim handler takes a long time to execute -- currently they are all very fast, so only a theoretical risk -- then other removals or insertions in L1 can block until it completes. " Only generate SBOM when releasing,13536978,Resolved,Minor,Fixed,21/May/23 11:56,24/May/23 15:30,,"The CycloneDX generation slows down the build so we'd better only generate it when releasing, to speed up the building." balance_rsgroup NullPointerException,13537338,Open,Minor,,23/May/23 13:25,,,"hbase(main):001:0> balance_rsgroup 'default' ERROR: java.io.IOException: Cannot invoke ""org.apache.hadoop.hbase.ServerName.getAddress()"" because ""currentHostServer"" is null         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:466)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) Caused by: java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.hbase.ServerName.getAddress()"" because ""currentHostServer"" is null         at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(RSGroupBasedLoadBalancer.java:320)         at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.balanceCluster(RSGroupBasedLoadBalancer.java:126)         at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.balanceRSGroup(RSGroupAdminServer.java:461)         at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.balanceRSGroup(RSGroupAdminEndpoint.java:301)         at org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:14948)         at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:921)         at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:394)         ... 3 more For usage try 'help ""balance_rsgroup""'" Provide option in HBase UI to disable stack trace for security,13534087,Resolved,Minor,Fixed,26/Apr/23 05:08,21/May/23 12:25,,"Uncaught server exceptions occur when providing parameter values that the server or servlet does not understand. Physical paths, versioning information, stack traces' content, and other data can be gathered and used to help further an attack when improper error handling is present. Applications should always fail safe in their designs. If an application fails to an unknown state, it is likely that an attacker may be able to exploit this indeterminate state to access unauthorized functionality, or worse, create, modify or destroy data. Error messages may also aid in the identification of other attacks such as buffer overflows and SQL injection, and can generally contribute to an overall weaker security posture. For example, if we use a HTTPS web server and explicitly provide Host header with a wrong value, say attackers.com, we get the following response in UI: {code:java} Error 400 Host does not match SNI

HTTP ERROR 400 Host does not match SNI

URI:/tablesDetailed.jsp
STATUS:400
MESSAGE:Host does not match SNI
SERVLET:-
CAUSED BY:org.apache.hbase.thirdparty.org.eclipse.jetty.http.BadMessageException: 400: Host does not match SNI

Caused by:

org.apache.hbase.thirdparty.org.eclipse.jetty.http.BadMessageException: 400: Host does not match SNI
   at org.apache.hbase.thirdparty.org.eclipse.jetty.server.SecureRequestCustomizer.customize(SecureRequestCustomizer.java:279)
   at org.apache.hbase.thirdparty.org.eclipse.jetty.server.SecureRequestCustomizer.customize(SecureRequestCustomizer.java:210)
   at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:483)
   at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732)
   at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479)
   at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.run(HttpChannel.java:439)
   at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883)
   at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034)
   at java.lang.Thread.run(Thread.java:750)
{code}  " Update surefire version to 3.0.0 and use the SurefireForkNodeFactory,13535793,Resolved,Minor,Fixed,11/May/23 12:32,13/May/23 11:05,,"The final surefire version 3.0.0 is released so we can update from 3.0.0-M6 -> 3.0.0. The final version has several fixes and is more stable.   SurefireForkNodeFactory is a new strategy to control how the surefire forked nodes communicate with the main maven process. It uses a tcp channel instead of process pipes. It helps to fix some ""corrupted channel"" messages seen in the s390x build and should be more reliable on all platforms. I have been testing locally on amd64 and s390x and have not had any issues.   Ref:  [https://maven.apache.org/surefire/maven-surefire-plugin/examples/process-communication.html]  " HBaseClassTestRule: system exit not restored if test times out may cause test to hang,13535785,Resolved,Minor,Fixed,11/May/23 12:05,13/May/23 01:12,,"HBaseClassTestRule applies a timeout and a system exit rule to tests. The timeout rule throws an exception if it hits the timeout threshold. Since the timeout rule is applied after the system exit rule, the system exit rule does not see the exception and does not re-enable the default system exit behavior which can cause maven to hang on some tests. I saw the hang happen when certain tests timed out on s390x but it could happen on any platform.   If the org.apache.hadoop.hbase.TestTimeout.infiniteLoop test is enabled and run it will generate a *-jvmRun1.dump file which shows that the org.apache.hadoop.hbase.TestSecurityManager is still enabled:   {quote}# Created at 2023-04-27T15:51:58.947 org.apache.hadoop.hbase.SystemExitRule$SystemExitInTestException         at org.apache.hadoop.hbase.TestSecurityManager.checkExit(TestSecurityManager.java:32)         at java.base/java.lang.Runtime.exit(Runtime.java:114)         at java.base/java.lang.System.exit(System.java:1752)         at org.apache.maven.surefire.booter.ForkedBooter.acknowledgedExit(ForkedBooter.java:381)         at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:178)         at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)         at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495) ...{quote}  " TestListTablesByState is silently failing due to a surefire bug,13535534,Resolved,Minor,Fixed,09/May/23 15:45,11/May/23 15:19,,"Surefire version 3.0.0-M6 has a bug where tests end up being removed from the test results if they fail with a long exception message. See:   https://issues.apache.org/jira/browse/SUREFIRE-2079   org.apache.hadoop.hbase.master.TestListTablesByState is currently failing in CI due to an error. However, it does not show up in the Test Results because of the surefire bug.   If you download the raw test_logs from the build artifacts, you will find the files: /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/output-jdk8-hadoop3/archiver/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestListTablesByState.txt   which contains: {{-----------------------------------------------------------------------}} {{Test set: org.apache.hadoop.hbase.master.TestListTablesByState}} {{-----------------------------------------------------------------------}} {{Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.929 s - in org.apache.hadoop.hbase.master.TestListTablesByState}}   and /home/jenkins/jenkins-home/workspace/HBase_Nightly_master/output-jdk8-hadoop3/archiver/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestListTablesByState-output.txt   which contains exceptions like: {{...}} {{2023-05-04T11:41:56,262 INFO  [RPCClient-NioEventLoopGroup-4-3 {}] client.RawAsyncHBaseAdmin$TableProcedureBiConsumer(2603): Operation: CREATE, Table Name: default:test failed with org.apache.hadoop.hbase.DoNotRetryIOException: Table test should have at least one column family.}} {{        at}} {{...}}   I found this while testing the final surfire 3.0.0 version which fixes the bug and the test then shows up as failing." changed type names to avoid conflicts with built-in types,13535089,Resolved,Minor,Fixed,05/May/23 05:33,08/May/23 15:40,2.5.4,Some compilers will resolve Builder to java.lang.Thread.Builder instead of Builder in pb and cause compilation failure. We should try to avoid conflicts with built-in class names. Update zstd-jni from version 1.5.4-2 -> 1.5.5-2,13534995,Resolved,Minor,Fixed,04/May/23 13:47,05/May/23 06:31,,"A new version (1.5.5-2) of the zstd-jni dependency has been released that includes a fix for an s390x issue which was prevented it from working on common linux distros. The underlying zstd 1.5.5 library also includes a fix for a rare corruption bug.   Refs: https://github.com/luben/zstd-jni/issues/257 https://github.com/facebook/zstd/releases/tag/v1.5.5" Guard Master/RS Dump Servlet behind admin walls,13532478,Resolved,Minor,Fixed,13/Apr/23 10:36,03/May/23 13:01,,"Currently RSDumpServlet and MasterDumpServlet do not require any check for whether the user has privileges to access to instrumentation servlets. This is unlike other servlets like ProfileServlet, ConfServlet, JMXJsonServlet etc. which are guarded by admin checks. Goal of this JIRA is to add similar check for RS and Master Dump Servlet. Post this change only admins will be able to access RSDumpServlet and MasterDumpServlet, if _hadoop.security.instrumentation.requires.admin_ is enabled." Add support for process metrics servlet in REST InfoServer,13534125,Resolved,Minor,Duplicate,26/Apr/23 10:11,03/May/23 10:57,,"Unlike other HBase Master/RS Info Servers, REST Server UI does not provide a way to get process metrics like threads, gc collectors etc. This task is add same in HBase REST." Support option to auto bind to an available port for REST Info Server,13534126,Open,Minor,,26/Apr/23 10:11,,, "Backport ""HBASE-24914 Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig"" to branch-2",13532266,Resolved,Minor,Fixed,12/Apr/23 03:24,14/Apr/23 10:49,2.4.14,"Branch-2/ Branch-2.4/Branch-2.5 also have duplicate code in ReplicationPeerManager#updatePeerConfig newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration()); newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration()); newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration()); newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration());" Move Dockerfile and python-requirements.txt used only by flaky-tests job,13531310,Resolved,Minor,Fixed,03/Apr/23 15:31,04/Apr/23 11:36,3.0.0-alpha-4,"We have a Dockerfile floating around in dev-support. It looks like it's only used by the flaky-test Jenkins job, so move it under that directory. I think that it used to be used in multiple places, as way to package up the dev-support/python-requirements.txt file. However, that too seems to only be used by the flaky-tests job, so move it as well. Update the job for the new invocation form, and remove mentions of python-requirements.txt from the book -- an old, out-dated section about how to format patches for attachment to JIRA." Backport HBASE-27731 (Upgrade commons-validator to version 1.7) to branch-2.5,13531435,Resolved,Minor,Invalid,04/Apr/23 12:09,05/Apr/23 14:04,,"This is so we also fix these CVEs for 2.5 - [CVE-2014-0114|https://nvd.nist.gov/vuln/detail/cve-2014-0114] - [CVE-2019-10086|https://nvd.nist.gov/vuln/detail/cve-2019-10086]  " Migrate javax.el:3.0.1-b08 to jakarta.el-4.0.2,13534151,Resolved,Trivial,Won't Fix,26/Apr/23 13:08,10/Sep/24 16:02,2.4.18,"The javax.el artifact contains a CVE: [CVE-2021-28170. |https://nvd.nist.gov/vuln/detail/CVE-2021-28170]The CVE itself is not a big issue since we're pre-compiling our JSP pages when building HBase, no user input is parsed which reduces the risk considerably. The org.glassfish:javax.el artifact was moved to org.glassfish:jakarta.el, which means a migration to get rid of the CVE." Update getting_started to fix typo,13540306,Resolved,Trivial,Fixed,16/Jun/23 04:29,17/Jun/23 07:43,,There are two commands missing of slashes '/' to start and stop local-regionservers in getting_started.adoc PressureAwareCompactionThroughputController#tune log the opposite of the actual scenario,13533498,Resolved,Trivial,Fixed,21/Apr/23 06:26,23/Apr/23 15:49,1.5.0,"In [https://github.com/apache/hbase/commit/07c71d630cd293ab55ac85e9bfa06033598134c4] ,    the condition of the if statement is incorrectly modified. !image-2023-04-21-14-28-19-766.png!  " [HBCK2] Correct sample usage of -skip with assigns in HBCK2 docs,13533179,Resolved,Trivial,Fixed,19/Apr/23 09:22,19/Apr/23 09:44,, SimpleRpcServer is broken,13448885,Resolved,Blocker,Fixed,07/Jun/22 23:57,12/Jul/22 18:18,2.5.0,"Concerns about SimpleRpcServer are not new, and not new to 2.5.  @chenxu noticed a problem on HBASE-23917 back in 2020. After some simple evaluations it seems quite broken. When I run an async version of ITLCC against a 2.5.0 cluster configured with hbase.rpc.server.impl=SimpleRpcServer, the client almost immediately stalls because there are too many in flight requests. The logic to pause with too many in flight requests is my own. That's not important. Looking at the server logs it is apparent that SimpleRpcServer is quite broken. Handlers suffer frequent protobuf parse errors and do not properly return responses to the client. This is what stalls my test client. Rather quickly all available request slots are full of requests that will have to time out on the client side. Exceptions have three patterns but they all have in common SimpleServerRpcConnection#process. It seems likely the root cause is mismatched expectations or bugs in connection buffer handling in SimpleRpcServer/SimpleServerRpcConnection versus downstream classes that process and parse the buffers. It also seems likely that changes were made to downstream classes like ServerRpcConnection expecting NettyRpcServer's particulars without updating SimpleServerRpcConnection and/or SimpleRpcServer. That said, this is just a superficial analysis. 1) ""Protocol message end-group tag did not match expected tag"" {noformat} 2022-06-07T16:44:04,625 WARN  [Reader=5,bindAddress=buildbox.localdomain,port=8120] ipc.RpcServer: /127.0.1.1:8120 is unable to read call parameter from client 127.0.0.1 org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException: Protocol message end-group tag did not match expected tag.     at org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException.invalidEndTag(InvalidProtocolBufferException.java:129) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0]     at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.checkLastTagWas(CodedInputStream.java:4034) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0]     at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4275) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue.(ClientProtos.java:10520) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue.(ClientProtos.java:10464) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$1.parsePartialFrom(ClientProtos.java:12251) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$1.parsePartialFrom(ClientProtos.java:12245) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto.(ClientProtos.java:9981) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto.(ClientProtos.java:9910) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$1.parsePartialFrom(ClientProtos.java:14097) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$1.parsePartialFrom(ClientProtos.java:14091) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest.(ClientProtos.java:14251) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest.(ClientProtos.java:14190) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$1.parsePartialFrom(ClientProtos.java:15304) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$1.parsePartialFrom(ClientProtos.java:15298) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$Builder.mergeFrom(ClientProtos.java:14860) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$Builder.mergeFrom(ClientProtos.java:14651) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:420) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0]     at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:317) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0]     at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.mergeFrom(ProtobufUtil.java:2638) ~[hbase-client-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processRequest(ServerRpcConnection.java:644) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processOneRpc(ServerRpcConnection.java:444) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection.process(SimpleServerRpcConnection.java:285) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection.readAndProcess(SimpleServerRpcConnection.java:251) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener.doRead(SimpleRpcServer.java:318) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener$Reader.doRunLoop(SimpleRpcServer.java:180) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener$Reader.run(SimpleRpcServer.java:153) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT]     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?] {noformat} 2) ""Protocol message tag had invalid wire type."" {noformat} 2022-06-07T16:44:04,705 WARN [Reader=6,bindAddress=buildbox.localdomain,port=8120] ipc.RpcServer: /127.0.1.1:8120 is unable to read call parameter from client 127.0.0.1 org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException$InvalidWireTypeException: Protocol message tag had invalid wire type. at org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException.invalidWireType(InvalidProtocolBufferException.java:134) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.UnknownFieldSet$Builder.mergeFieldFrom(UnknownFieldSet.java:527) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.GeneratedMessageV3.parseUnknownField(GeneratedMessageV3.java:320) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue.(ClientProtos.java:10700) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue.(ClientProtos.java:10620) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue$1.parsePartialFrom(ClientProtos.java:11481) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue$1.parsePartialFrom(ClientProtos.java:11475) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue.(ClientProtos.java:10520) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue.(ClientProtos.java:10464) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$1.parsePartialFrom(ClientProtos.java:12251) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$1.parsePartialFrom(ClientProtos.java:12245) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto.(ClientProtos.java:9981) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto.(ClientProtos.java:9910) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$1.parsePartialFrom(ClientProtos.java:14097) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$1.parsePartialFrom(ClientProtos.java:14091) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest.(ClientProtos.java:14251) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest.(ClientProtos.java:14190) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$1.parsePartialFrom(ClientProtos.java:15304) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$1.parsePartialFrom(ClientProtos.java:15298) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$Builder.mergeFrom(ClientProtos.java:14860) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$Builder.mergeFrom(ClientProtos.java:14651) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:420) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:317) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.mergeFrom(ProtobufUtil.java:2638) ~[hbase-client-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processRequest(ServerRpcConnection.java:644) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processOneRpc(ServerRpcConnection.java:444) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection.process(SimpleServerRpcConnection.java:285) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection.readAndProcess(SimpleServerRpcConnection.java:251) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener.doRead(SimpleRpcServer.java:318) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener$Reader.doRunLoop(SimpleRpcServer.java:180) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener$Reader.run(SimpleRpcServer.java:153) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?] at java.lang.Thread.run(Thread.java:829) ~[?:?] {noformat} 3) ""While parsing a protocol message, the input ended unexpectedly in the middle of a field."" {noformat} 2022-06-07T16:44:04,885 WARN [Reader=9,bindAddress=buildbox.localdomain,port=8120] ipc.RpcServer: /127.0.1.1:8120 is unable to read call parameter from client 127.0.0.1 org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException: While parsing a protocol message, the input ended unexpectedly in the middle of a field. This could mean either that the input has been truncated or that an embedded message misreported its own length. at org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException.truncatedMessage(InvalidProtocolBufferException.java:107) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readRawLittleEndian64(CodedInputStream.java:4478) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readFixed64(CodedInputStream.java:4167) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.UnknownFieldSet$Builder.mergeFieldFrom(UnknownFieldSet.java:511) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.GeneratedMessageV3.parseUnknownField(GeneratedMessageV3.java:320) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue.(ClientProtos.java:10700) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue.(ClientProtos.java:10620) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue$1.parsePartialFrom(ClientProtos.java:11481) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$QualifierValue$1.parsePartialFrom(ClientProtos.java:11475) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue.(ClientProtos.java:10520) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue.(ClientProtos.java:10464) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$1.parsePartialFrom(ClientProtos.java:12251) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$ColumnValue$1.parsePartialFrom(ClientProtos.java:12245) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto.(ClientProtos.java:9981) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto.(ClientProtos.java:9910) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$1.parsePartialFrom(ClientProtos.java:14097) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutationProto$1.parsePartialFrom(ClientProtos.java:14091) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.CodedInputStream$ByteInputDecoder.readMessage(CodedInputStream.java:4274) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest.(ClientProtos.java:14251) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest.(ClientProtos.java:14190) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$1.parsePartialFrom(ClientProtos.java:15304) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$1.parsePartialFrom(ClientProtos.java:15298) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$Builder.mergeFrom(ClientProtos.java:14860) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MutateRequest$Builder.mergeFrom(ClientProtos.java:14651) ~[hbase-protocol-shaded-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:420) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:317) ~[hbase-shaded-protobuf-4.1.0.jar:4.1.0] at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.mergeFrom(ProtobufUtil.java:2638) ~[hbase-client-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processRequest(ServerRpcConnection.java:644) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processOneRpc(ServerRpcConnection.java:444) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection.process(SimpleServerRpcConnection.java:285) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection.readAndProcess(SimpleServerRpcConnection.java:251) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener.doRead(SimpleRpcServer.java:318) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener$Reader.doRunLoop(SimpleRpcServer.java:180) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.SimpleRpcServer$Listener$Reader.run(SimpleRpcServer.java:153) ~[hbase-server-2.5.1-SNAPSHOT.jar:2.5.1-SNAPSHOT] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?] at java.lang.Thread.run(Thread.java:829) ~[?:?] {noformat}" Revert HBASE-25709,13449645,Resolved,Blocker,Fixed,12/Jun/22 01:41,12/Jun/22 17:40,2.4.11,"HBASE-25709 has caused regression for large rows scan results and since the change has already been released to 2.4.11, creating this Jira to track it's revert." Change the return value of RSGroupInfo.getServers from SortedSet to Set to keep compatibility,13447846,Resolved,Blocker,Fixed,01/Jun/22 05:36,01/Jun/22 16:30,, Fix disallowed compatibility breaks on branch-2.5 and branch-2,13447819,Resolved,Blocker,Fixed,01/Jun/22 02:11,01/Jun/22 02:57,2.5.0,"Change to Public interfaces without deprecation: HTableDescriptor Field DEFAULT_NORMALIZATION_ENABLED of type boolean has been removed from this class. TableDescriptorBuilder Field DEFAULT_NORMALIZATION_ENABLED of type boolean has been removed from this class. RandomRowFilter Field random of type java.util.Random has been removed from this class. A client program may be interrupted by NoSuchFieldError exception. ReplicationLoadSink.ReplicationLoadSink ( long age, long timestamp, long timestampStarted, long totalOpsProcessed ) Access level has been changed from public to private. A client program may be interrupted by IllegalAccessError exception. RSGroupInfo.getServers:()Ljava/util/Set; Return value type has been changed from java.util.Set to java.util.SortedSet. This method has been removed because the return type is part of the method signature. A client program may be interrupted by NoSuchMethodError exception. These changes are not allowed by policy for a minor release so I have committed fixes on my own authority as RM to branch-2.5 and branch-2. Further changes can be pursued on branch-2. " Compaction failures after StoreFileTracker integration,13438483,Resolved,Blocker,Fixed,07/Apr/22 23:30,17/Apr/22 14:57,2.5.0,"[ Currently this has only been tested with branch-2.5 and branch-2. Testing with master next, will update afterward. ] Test cluster of 10 regionservers is configured each RS with 5 flush threads, 5 large compaction threads, and 10 small compaction threads. Hadoop is 3.3.2. Java is 11. HFiles are on HDFS. All the StoreFileTracker implementations, DEFAULT or FILE, exhibit compaction time store writer errors in an ingest heavy use case. Unit tests don't seem to cover whatever this is. Most compactions succeed, but some do not. Those that do not are failing with state or sanity check assertions. Below errors are all from DEFAULT. They seem related... store writer instance usage/close/locking issues during compactions. Warnings like ""writer exists when it should not"": {noformat} 2022-04-07T23:13:11,351 WARN  [regionserver/ip-172-31-63-83:8120-shortCompactions-8] compactions.Compactor: Writer exists when it should not: { hdfs://ip-172-31-58-47.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestLoadCommonCrawl/b518f72941d4427e7e1923407643df67/.tmp/c/29d7b88c4c214ddcbba4f747514a2cf5 } {noformat} Errors like: IllegalStateException thrown from HFileBlockIndex$BlockIndexWriter.shouldWriteBlock: {noformat} 2022-04-07T23:13:11,508 ERROR [regionserver/ip-172-31-63-83:8120-shortCompactions-6] regionserver.CompactSplit: Compaction failed region=IntegrationTestLoadCommonCrawl,,1649373172576.b518f72941d4427e7e1923407643df67., storeName=b518f72941d4427e7e1923407643df67/c, priority=10, startTime=1649373185476 java.lang.IllegalStateException: curInlineChunk is null; has shouldWriteBlock been called with closing=true and then called again? at org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexWriter.shouldWriteBlock(HFileBlockIndex.java:1258) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.writeInlineBlocks(HFileWriterImpl.java:523) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.close(HFileWriterImpl.java:608) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.close(StoreFileWriter.java:377) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.abortWriter(DefaultCompactor.java:84) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.abortWriter(DefaultCompactor.java:76) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:384) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] {noformat} and IllegalStateException thrown from HFileBlock$Writer.expectState: {noformat} 2022-04-07T23:13:11,559 ERROR [regionserver/ip-172-31-63-83:8120-shortCompactions-8] regionserver.CompactSplit: Compaction failed region=IntegrationTestLoadCommonCrawl,,1649373172576.b518f72941d4427e7e1923407643df67., storeName=b518f72941d4427e7e1923407643df67/c, priority=0, startTime=1649373191325 java.lang.IllegalStateException: Expected state: BLOCK_READY, actual state: WRITING at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.expectState(HFileBlock.java:1190) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.getOnDiskSizeWithHeader(HFileBlock.java:1106) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.finishBlock(HFileWriterImpl.java:346) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.checkBlockBoundary(HFileWriterImpl.java:327) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.append(HFileWriterImpl.java:739) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.append(StoreFileWriter.java:301) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:456) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:364) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1138) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2392) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:656) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:702) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] {noformat} and the dreaded ""added a key not lexically larger than previous"": {noformat} 2022-04-07T23:13:14,715 ERROR [regionserver/ip-172-31-63-83:8120-shortCompactions-8] regionserver.CompactSplit: Compaction failed region=IntegrationTestLoadCommonCrawl,de.bao,1649373172576.083eb1ede8bf8c82174f614b06d4741e., storeName=083eb1ede8bf8c82174f614b06d4741e/c, priority=-1, startTime=1649373194643 java.io.IOException: Added a key not lexically larger than previous. ... at org.apache.hadoop.hbase.util.BloomContext.sanityCheck(BloomContext.java:63) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.util.BloomContext.writeBloom(BloomContext.java:54) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.appendGeneralBloomfilter(StoreFileWriter.java:280) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.append(StoreFileWriter.java:299) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:456) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:364) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1138) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2392) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:656) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:702) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] {noformat} and another bloomfilter addition sanity check failure: {noformat} 2022-04-07T23:23:44,001 ERROR [regionserver/ip-172-31-49-8:8120-longCompactions-4] regionserver.CompactSplit: Compaction failed region=IntegrationTestLoadCommonCrawl,com.fc2.blog.idp,1649373775847.9d960338d85e2bb9c68669fad6a89f73., storeName=9d960338d85e2bb9c68669fad6a89f73/c, priority=-1, startTime=1649373823967 java.lang.IllegalStateException: First key in chunk already set: com.filmestipo|/film/1335-algures-hoje-a-noite|1649373441720 at org.apache.hadoop.hbase.io.hfile.CompoundBloomFilterWriter.append(CompoundBloomFilterWriter.java:174) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.util.BloomContext.writeBloom(BloomContext.java:55) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.appendGeneralBloomfilter(StoreFileWriter.java:280) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.append(StoreFileWriter.java:299) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:456) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:364) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1138) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2392) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:656) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:702) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] {noformat} and a NPE in HFileBlock$Writer.getEncodingState: {noformat} 2022-04-07T23:17:26,373 ERROR [regionserver/ip-172-31-63-83:8120-shortCompactions-6] regionserver.CompactSplit: Compaction failed region=IntegrationTestLoadCommonCrawl,com.fc2.blog.idp,1649373315303.2bd16fac0c088fa135a855f0165f1dba., storeName=2bd16fac0c088fa135a855f0165f1dba/c, priority=10, startTime=1649373438988 java.lang.NullPointerException: null at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.getEncodingState(HFileBlock.java:837) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.beforeShipped(HFileBlock.java:831) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.beforeShipped(HFileWriterImpl.java:770) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.beforeShipped(StoreFileWriter.java:309) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:515) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:364) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1138) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2392) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:656) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:702) ~[hbase-server-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] {noformat}" NegativeArraySizeException was encountered during compaction,13444932,In Progress,Critical,,14/May/22 03:45,,2.3.4,"  {code:java} 2022-04-13 12:45:37,122 ERROR [regionserver/xxxxxx:26020-shortCompactions-0] regionserver.CompactSplit: Compaction failed region=XXX:XXX,002CX21205070934507532021052320210523174923,162 8091302516.7d2e05ad63b91843d438d2464a908d49., storeName=7d2e05ad63b91843d438d2464a908d49/info, priority=90, startTime=1649825135950 java.lang.NegativeArraySizeException         at org.apache.hadoop.hbase.CellUtil.cloneQualifier(CellUtil.java:120)         at org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray(ByteBufferKeyValue.java:112)         at org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(CellUtil.java:1335)         at org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(CellUtil.java:1318)         at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.getMidpoint(HFileWriterImpl.java:384)         at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.finishBlock(HFileWriterImpl.java:349)         at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.checkBlockBoundary(HFileWriterImpl.java:328)         at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.append(HFileWriterImpl.java:739)         at org.apache.hadoop.hbase.regionserver.StoreFileWriter.append(StoreFileWriter.java:299)         at org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:410)         at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:333)         at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:65)         at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:126)         at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1544)         at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2288)         at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:619)         at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:661)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) {code}   We encounter the exeception above many times. Usually, it will retry and compact success next time. But sometime it make _getMidpoint return_ a wrong result and then make an abnormal index block  as follow   {code:java} 068c892d122//LATEST_TIMESTAMP/Maximum/vlen=0/seqid=0 1//LATEST_TIMESTAMP/Maximum/vlen=0/seqid=0 068c896a6fc6f155beaddab036a4225ef79_12022011420220114205945/info:q/LATEST_TIMESTAMP/Maximum/vlen=0/seqid=0 {code}   And this index block will lead to an endless loop in _org.apache.hadoop.hbase.regionserver.KeyValueHeap#generalizedSeek_ The cause of this problem is _lastCellOfPreviousBlock_ reference to the cells in read path([HBASE-16372|https://issues.apache.org/jira/browse/HBASE-16372]) I have fixed it and will create a PR for it" TestReplicationValueCompressedWAL.testMultiplePuts is flaky,13447403,Resolved,Critical,Fixed,29/May/22 19:34,29/Aug/23 06:21,2.5.0,"org.apache.hadoop.hbase.replication.regionserver.TestReplicationValueCompressedWAL.testMultiplePuts 
Run 1: TestReplicationValueCompressedWAL.testMultiplePuts:56 Waited too much time for replication Run 2: PASS " FilterList with FuzzyRowFilter and SingleColumnValueFilter evaluated with operator MUST_PASS_ONE doesn't work as expected,13440944,Resolved,Critical,Fixed,21/Apr/22 14:46,29/Jan/23 10:39,2.4.11,"I created test table with two column families by hbase shell:   {code:java} create 'test_table2', 'f1', 'f2' put 'test_table2', '1', 'f1:col1', 'a1' put 'test_table2', '1', 'f2:col2', 'a2' put 'test_table2', '2', 'f1:col1', 'b1' put 'test_table2', '2', 'f2:col2', 'b2' {code}     The table contains of two rows (rowkeys '1' and '2'), tested FuzzyRowFilter selects first row, SingleColumnValueFilter selects no rows, combination of both filters evaluated with MUST_PASS_ONE operator returns surprisingly whole table. I prepared java examples to show this strange behavior.   Code snippet below doesn't work as expected:   {code:java} try (Table table = connection.getTable(TableName.valueOf(""test_table2""))) { Scan scan = new Scan(); scan.addFamily(Bytes.toBytes(""f1"")); scan.addFamily(Bytes.toBytes(""f2"")); Filter fuzzyRowFilter = new FuzzyRowFilter(List.of(new Pair<>(Bytes.toBytes(""1""), new byte[] { 0x00 }))); scan.setFilter(fuzzyRowFilter); System.out.println(""result of fuzzy filter:""); for (Result r : table.getScanner(scan)) { System.out.println(Bytes.toString(r.getRow())); } System.out.println(""result of single column value filter:""); Filter singleColumnValueFilter = new SingleColumnValueFilter(Bytes.toBytes(""f2""), Bytes.toBytes(""col2""), CompareOperator.EQUAL, Bytes.toBytes(""x"")); scan.setFilter(singleColumnValueFilter); for (Result r : table.getScanner(scan)) { System.out.println(Bytes.toString(r.getRow())); } System.out.println(""result of fuzzy or single column value filters:""); FilterList filterList = new FilterList(Operator.MUST_PASS_ONE); filterList.addFilter(fuzzyRowFilter); filterList.addFilter(singleColumnValueFilter); scan.setFilter(filterList); for (Result r : table.getScanner(scan)) { System.out.println(Bytes.toString(r.getRow())); } } {code} Expected result in my opinion is:   {quote}result of fuzzy filter: 1 result of single column value filter: result of fuzzy or single column value filters: 1 {quote} But i am getting (NOT OK): {quote}result of fuzzy filter: 1 result of single column value filter: result of fuzzy or single column value filters: 1 2 {quote}   For tables with one column family or commentig out the line _{color:#000000}scan{color}.addFamily({color:#000000}Bytes{color}.toBytes({color:#067d17}""f1""{color}))_ filter list evaluation is working OK. Similar example with PrefixFilter is working like a charm:   {code:java} try (Table table = connection.getTable(TableName.valueOf(""test_table2""))) { Scan scan = new Scan(); scan.addFamily(Bytes.toBytes(""f1"")); scan.addFamily(Bytes.toBytes(""f2"")); Filter prefixFilter = new PrefixFilter(Bytes.toBytes(""1"")); scan.setFilter(prefixFilter); System.out.println(""result of prefix filter:""); for (Result r : table.getScanner(scan)) { System.out.println(Bytes.toString(r.getRow())); } System.out.println(""result of single column value filter:""); Filter singleColumnValueFilter = new SingleColumnValueFilter(Bytes.toBytes(""f2""), Bytes.toBytes(""col2""), CompareOperator.EQUAL, Bytes.toBytes(""x"")); scan.setFilter(singleColumnValueFilter); for (Result r : table.getScanner(scan)) { System.out.println(Bytes.toString(r.getRow())); } System.out.println(""result of prefix or single column value filters""); FilterList filterList = new FilterList(Operator.MUST_PASS_ONE); filterList.addFilter(prefixFilter); filterList.addFilter(singleColumnValueFilter); scan.setFilter(filterList); for (Result r : table.getScanner(scan)) { System.out.println(Bytes.toString(r.getRow())); } } {code}     Result OK{_}:{_} {quote}result of prefix filter: 1 result of single column value filter: result of prefix or single column value filters 1 {quote}" Upgrade hbase-thirdparty dependency to 4.1.1,13450756,Resolved,Critical,Fixed,18/Jun/22 15:05,22/Jun/22 15:39,,So we can upgrade jackson to 2.13.3 Executing 'mvn install' in sub module directory fails with license-header not found,13449625,Resolved,Critical,Not A Problem,11/Jun/22 13:32,11/Jun/22 16:14,,"This is because we add a spotless:check goal in the verify stage. We need to find a way to locate the license header correctly." All MR UTs are broken because of ClassNotFound,13449222,Resolved,Critical,Fixed,09/Jun/22 12:02,09/Jun/22 17:02,,It seems we must include leveldbjni-all when starting a MiniYARNCluster. "HMaster should exit gracefully, when stopped via hbase-daemon.sh",13439330,Resolved,Critical,Fixed,13/Apr/22 04:11,26/Apr/22 16:26,3.0.0-alpha-2,"Since ShutdownHook is not registered at startup, when HMaster is stopped through hbase-daemon.sh, HMaster cannot exit gracefully,  the threads and services of HMaster cannot be closed normally, and the master local region also cannot be closed normally, which may lead to some inexplicable problems." LocalHBaseCluster.waitOnRegionServer should not call join while interrupted,13438631,Resolved,Critical,Fixed,08/Apr/22 15:42,17/Apr/22 15:38,,"{code} public String waitOnRegionServer(JVMClusterUtil.RegionServerThread rst) { while (rst.isAlive()) { try { LOG.info(""Waiting on "" + rst.getRegionServer().toString()); rst.join(); } catch (InterruptedException e) { LOG.error(""Interrupted while waiting for {} to finish. Retrying join"", rst.getName(), e); Thread.currentThread().interrupt(); } } regionThreads.remove(rst); return rst.getName(); } {code} Now it will retry again without any sleep(actually if the thread is interrupted, sleep will also fail soon), so it could generate bunch of logs and eat all the spaces, like this {noformat} 2022-04-05T12:10:18,854 ERROR [Time-limited test] hbase.LocalHBaseCluster(318): Interrupted while waiting for RS:0;130a8c5b2d31:38109 to finish. Retrying join java.lang.InterruptedException: null at java.lang.Object.wait(Native Method) ~[?:?] at java.lang.Thread.join(Thread.java:1305) ~[?:?] at java.lang.Thread.join(Thread.java:1380) ~[?:?] at org.apache.hadoop.hbase.LocalHBaseCluster.waitOnRegionServer(LocalHBaseCluster.java:316) ~[classes/:?] at org.apache.hadoop.hbase.master.TestRollingRestart.testBasicRollingRestart(TestRollingRestart.java:194) ~[test-classes/:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) ~[junit-4.13.2.jar:4.13.2] at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.run(ParentRunner.java:413) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.Suite.runChild(Suite.java:128) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.Suite.runChild(Suite.java:27) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2] at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) ~[test-classes/:?] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) ~[junit-4.13.2.jar:4.13.2] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] 2022-04-05T12:10:18,858 INFO [Time-limited test] hbase.LocalHBaseCluster(315): Waiting on 130a8c5b2d31,38109,1649159073346 2022-04-05T12:10:18,858 ERROR [Time-limited test] hbase.LocalHBaseCluster(318): Interrupted while waiting for RS:0;130a8c5b2d31:38109 to finish. Retrying join java.lang.InterruptedException: null at java.lang.Object.wait(Native Method) ~[?:?] at java.lang.Thread.join(Thread.java:1305) ~[?:?] at java.lang.Thread.join(Thread.java:1380) ~[?:?] at org.apache.hadoop.hbase.LocalHBaseCluster.waitOnRegionServer(LocalHBaseCluster.java:316) ~[classes/:?] at org.apache.hadoop.hbase.master.TestRollingRestart.testBasicRollingRestart(TestRollingRestart.java:194) ~[test-classes/:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) ~[junit-4.13.2.jar:4.13.2] at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.run(ParentRunner.java:413) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.Suite.runChild(Suite.java:128) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.Suite.runChild(Suite.java:27) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2] at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) ~[test-classes/:?] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) ~[junit-4.13.2.jar:4.13.2] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] {noformat}" project Jenkins nodes need a fail-safe clean up of surefire deferred output,13438196,Open,Critical,,06/Apr/22 14:31,,,"We've had build nodes run out of space a few times now caused by surefire deferred stdout / stderr filling a disk.   Come up with a strategy to make recovery from this automated." Skip generating ref guide when running 'mvn site' on branch other than master,13437881,Resolved,Major,Fixed,05/Apr/22 13:42,29/Apr/22 09:46,, Improve the comments and test coverage for compaction progress implementation,13440052,Open,Major,,17/Apr/22 15:00,,,"When fixing HBASE-26938, we also found the root cause that why sometimes we will get broken compaction progress value, i.e, a negative or more than 100%, it is because multiple compaction can happen at the same time but only use one compaction prorgress, which is not thread safe to track them all. We have fixed this problem in HBASE-26938, but it is suggested to improve the test coverage of this ares so we will not make a mistake in the future again." ExportSnapshot tool supports removing TTL,13439812,Resolved,Major,Fixed,15/Apr/22 09:15,30/Dec/24 14:32,,"In our scenario, we use ExportSnapshot to copy snapshots to cold storage like S3. But when we restored back to HBase cluster, it will be deleted directly because TTL is set. So we need ExportSnapshot tool support removing TTL." TestRetainAssignmentOnRestartSplitWithoutZk infinite loop,13439151,Resolved,Major,Fixed,12/Apr/22 09:55,16/Apr/22 05:29,,"{noformat} 2022-04-05T01:56:10,567 ERROR [Thread-350] server.NIOServerCnxnFactory$1(92): Thread Thread[Thread-350,5,FailOnTimeoutGroup] died java.lang.IllegalThreadStateException: null at java.lang.Thread.start(Thread.java:794) ~[?:?] at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.startWorkers(ProcedureExecutor.java:616) ~[classes/:?] at org.apache.hadoop.hbase.master.HMaster.startProcedureExecutor(HMaster.java:1666) ~[classes/:?] at org.apache.hadoop.hbase.master.TestRetainAssignmentOnRestart$HMasterForTest.access$101(TestRetainAssignmentOnRestart.java:57) ~[test-classes/:?] at org.apache.hadoop.hbase.master.TestRetainAssignmentOnRestart$HMasterForTest.lambda$startProcedureExecutor$0(TestRetainAssignmentOnRestart.java:70) ~[test-classes/:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] 2022-04-05T01:56:10,570 INFO [RS:2;4d77efa4cf73:37349] regionserver.HRegionServer(1179): stopping server 4d77efa4cf73,37349,1649123763933 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running 2022-04-05T01:56:10,570 DEBUG [RS:2;4d77efa4cf73:37349] ipc.AbstractRpcClient(505): Stopping rpc client 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running 2022-04-05T01:56:10,570 INFO [RS:2;4d77efa4cf73:37349] regionserver.HRegionServer(1529): Waiting on 1 regions to close 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running 2022-04-05T01:56:10,570 DEBUG [RS:2;4d77efa4cf73:37349] regionserver.HRegionServer(1533): Online Regions={3b6c92c681d8cf1316520e3a89546fe0=restartTableThree,,1649123769361.3b6c92c681d8cf1316520e3a89546fe0.} 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running 2022-04-05T01:56:10,570 DEBUG [PEWorker-5] procedure2.AbstractProcedureScheduler(158): the scheduler is not running {noformat} After a strange exception then we enter an infinite loop and output a lot of log messages which eat all the spaces..." Update the doc for read replica configuration,13438623,Resolved,Major,Fixed,08/Apr/22 14:59,17/Apr/22 13:49,2.4.11,"The doc for read replica is somewhat outdated： there is no ‘hbase.region.replica.replication.memstore.enabled’ in the code now， which is replaced by per-table property `REGION_MEMSTORE_REPLICATION`, and if we set `REGION_MEMSTORE_REPLICATION` to false,`hbase.region.replica.wait.for.primary.flush` will be ignored." Move minimum hadoop 3 support version to 3.2.3,13458599,Resolved,Major,Fixed,22/Jun/22 15:22,08/Jul/22 10:15,,"Seems the hadoop community will not make newer 3.1.x release so let's move the minimun hadoop 3 versions to 3.2.3, due to security issues." Remove all ref guide stuff on branch other than master,13437882,Resolved,Major,Fixed,05/Apr/22 13:42,22/May/22 07:43,, Support multi-threads cleaner for MOB files,13450383,Open,Major,,16/Jun/22 09:18,,2.4.12,"Just like the muti-threads in hfile cleaner. When there are many tables has MOB files, only one thread for cleaning them is not enough. " Add security headers to Thrift/HTTP server ,13449998,Resolved,Major,Fixed,14/Jun/22 11:16,20/Sep/24 15:17,2.0.6,"In order to further improve HBase exposed service for vulnerability scanners, would be nice to implement additional security headers for the Thrift server when HTTP or HTTPS transport is enabled. Similarly to REST and Web UIs, related tickets are attached." Update httpcomponents to version 5.1,13438183,Resolved,Major,Duplicate,06/Apr/22 13:29,16/Sep/24 06:50,,"HTTPComponents 5 is major rewrite. One of the main improvements is that it uses slf4j for logging, instead of log4j.  " Should use FileStatus to archive expired MOB files instead of construct HStoreFile object,13450411,Open,Major,,16/Jun/22 12:17,,2.4.12,"The MobUtils#removeMobFiles reused codes in HFileArchiver#archiveStoreFiles, which is used to archive compacted files on RSes under normal conditions. In HFileArchiver#archiveStoreFiles, store files are closed and removed, while MOB cleaner should only rename the expired files and no need to build new HStoreFile object before archive and close it after removed. " Config BucketCache as victim handler of LRUCache,13443529,Open,Major,,06/May/22 06:35,,,"Bucket cache is no longer as a victim handler for LRU by HBASE-19357. {noformat} When BC is used, data blocks will be strictly on BC only where as index/bloom blocks are on LRU L1 cache. {noformat} In this situation, the LRU cache's memory is totally on heap. If the index and bloom filters on a region server are big, then a big LRU cache will introduce more GC cost. So we should add a *configuration for user* to choose victim handler. A small LRU cache with a big victim offheap bucket cache can reduce GC cost.   For example: a region server has 5GB index, 80 GB bloom filter, and 256GB DRAM, its configurations can be as follow: {code:xml} export HBASE_REGIONSERVER_OPTS=""-Xms40g -Xmx40g -XX:MaxDirectMemorySize=180g"" {code} {code:xml} hbase.blockcache.victim.handler.enabled true hfile.block.cache.size 0.3 hbase.bucketcache.ioengine   offheap hbase.bucketcache.size 160000 {code}" Move replication peer storage from zookeeper to other storage systems,13449673,Resolved,Major,Fixed,12/Jun/22 13:00,25/Apr/23 13:53,,"This is a more specific issue based on the works which are already done in HBASE-15867. There are several candidates for storing replication peer. 1. A new family of master local region 2. On FileSystem 3. A new family of hbase:meta Either choice has pros and cons. We need to decide which way to go first." "HMaster's ShutdownHook does not take effect, if tablesOnMaster is false",13441811,Resolved,Major,Fixed,26/Apr/22 12:44,02/Aug/22 08:46,1.7.1,"Because we are going to upgrade the HBase kernel version, during the test, I found that the HMaster ShutdownHook of version 1.7.1 and 2.4.9 did not take effect if tablesOnMaster is false. After further confirmation, I found that all versions of HBase 1.x and 2.x have this problem. I analyzed the cause of the problem： Before HBase 3.x, HMaster registered ShutdownHook by calling the run() method of HRegionServer, but the run() method will be blocked on the waitForMasterActive() method of HMaster(before registering the shutdownhook) if tablesOnMaster is false. Eventually, the ShutdownHook of HMaster was not registered successfully. 1. The code path of  HRegionServer's run() method： !image-2022-04-26-21-18-24-884.png!   2.  The preRegistrationInitialization() method will be called first: !image-2022-04-26-21-12-51-843.png! 3. The HMaster's waitForMasterActive() method will be blocked if tablesOnMaster is false: !image-2022-04-26-21-22-38-572.png! Finally, because the default value of tablesOnMaster is false, the ShutdownHook of HMaster was not registered successfully." "When HMaster is stopped, the local region cannot be flushed normally",13444653,Open,Major,,12/May/22 15:52,,3.0.0-alpha-3,"After HBASE-26951, HMaster can be stoped gracefully. For example, the internal threads of HMaster can be closed normally, but I found that the local region of HMaster still cannot be closed normally. The following is my test error message(exception 1): {code:java} Wed May 11 14:48:56 CST 2022 Terminating master 2022-05-11 14:48:56,382 INFO  [shutdown-hook-0] regionserver.ShutdownHook: Shutdown hook starting; hbase.shutdown.hook=true; fsShutdownHook=org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@4f4c789f 2022-05-11 14:48:56,382 INFO  [shutdown-hook-0] master.HMaster: ***** STOPPING master 'emr-header-1.cluster-xxxxx,16000,1652240899395' ***** 2022-05-11 14:48:56,382 INFO  [shutdown-hook-0] master.HMaster: STOPPED: Shutdown hook ...... ...... 2022-05-11 14:48:57,367 ERROR [KeepAlivePEWorker-41] assignment.RegionStateStore: FAILED persisting region=23a692981e91e944d380a8bdf4b50c7e state=OPEN org.apache.hadoop.hbase.ipc.StoppedRpcClientException: Call to address=emr-worker-1.cluster-xxxxx:16020 failed on local exception: org.apache.hadoop.hbase.ipc.StoppedRpcClientException     at java.lang.Thread.getStackTrace(Thread.java:1559)     at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)     at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149)     at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:172)     at org.apache.hadoop.hbase.client.TableOverAsyncTable.put(TableOverAsyncTable.java:214)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:259)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:224)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.persistToMeta(AssignmentManager.java:2034)     at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:297)     at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:57)     at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:953)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1667)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981)     at --------Future.get--------(Unknown Source)     at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)     at java.lang.reflect.Constructor.newInstance(Constructor.java:423)     at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:210)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:388)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:422)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:417)     at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114)     at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:443)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:92)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:614)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.mutate(ClientProtos.java:46147)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.lambda$mutate$0(RawAsyncTableImpl.java:175)     at org.apache.hadoop.hbase.client.ConnectionUtils.call(ConnectionUtils.java:616)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.mutate(RawAsyncTableImpl.java:174)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.voidMutate(RawAsyncTableImpl.java:181)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.lambda$null$8(RawAsyncTableImpl.java:249)     at org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82)     at org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115)     at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68)     at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)     at java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:778)     at java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2140)     at org.apache.hadoop.hbase.util.FutureUtils.addListener(FutureUtils.java:61)     at org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.doCall(AsyncSingleRequestRpcRetryingCaller.java:106)     at org.apache.hadoop.hbase.client.AsyncRpcRetryingCaller.lambda$tryScheduleRetry$0(AsyncRpcRetryingCaller.java:142)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.run(HashedWheelTimer.java:715)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.ImmediateExecutor.execute(ImmediateExecutor.java:34)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:703)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:790)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:503)     at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.ipc.StoppedRpcClientException     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:360)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:440)     ... 23 more 2022-05-11 14:48:57,367 WARN  [KeepAlivePEWorker-41] assignment.RegionRemoteProcedureBase: Failed updating meta, suspend 1secs pid=1793261, ppid=1791968, state=RUNNABLE, hasLock=true; OpenRegionProcedure 23a692981e91e944d380a8bdf4b50c7e, server=emr-worker-2.cluster-xxxx,16020,1652240898881, retry=org.apache.hadoop.hbase.util.RetryCounter@2f42033b; state=OPEN, location=emr-worker-2.cluster-18941,16020,1652240898881, table=usertable, region=23a692981e91e944d380a8bdf4b50c7e; org.apache.hadoop.hbase.ipc.StoppedRpcClientException: Call to address=emr-worker-1.cluster-18941:16020 failed on local exception: org.apache.hadoop.hbase.ipc.StoppedRpcClientException     at java.lang.Thread.getStackTrace(Thread.java:1559)     at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130)     at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149)     at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:172)     at org.apache.hadoop.hbase.client.TableOverAsyncTable.put(TableOverAsyncTable.java:214)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:259)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:224)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.persistToMeta(AssignmentManager.java:2034)     at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:297)     at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:57)     at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:953)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1667)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981)     at --------Future.get--------(Unknown Source)     at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)     at java.lang.reflect.Constructor.newInstance(Constructor.java:423)     at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:210)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:388)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:422)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:417)     at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114)     at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:443)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$300(AbstractRpcClient.java:92)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$RpcChannelImplementation.callMethod(AbstractRpcClient.java:614)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$Stub.mutate(ClientProtos.java:46147)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.lambda$mutate$0(RawAsyncTableImpl.java:175)     at org.apache.hadoop.hbase.client.ConnectionUtils.call(ConnectionUtils.java:616)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.mutate(RawAsyncTableImpl.java:174)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.voidMutate(RawAsyncTableImpl.java:181)     at org.apache.hadoop.hbase.client.RawAsyncTableImpl.lambda$null$8(RawAsyncTableImpl.java:249)     at org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.call(AsyncSingleRequestRpcRetryingCaller.java:82)     at org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.lambda$doCall$7(AsyncSingleRequestRpcRetryingCaller.java:115)     at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68)     at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760)     at java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:778)     at java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2140)     at org.apache.hadoop.hbase.util.FutureUtils.addListener(FutureUtils.java:61)     at org.apache.hadoop.hbase.client.AsyncSingleRequestRpcRetryingCaller.doCall(AsyncSingleRequestRpcRetryingCaller.java:106)     at org.apache.hadoop.hbase.client.AsyncRpcRetryingCaller.lambda$tryScheduleRetry$0(AsyncRpcRetryingCaller.java:142)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.run(HashedWheelTimer.java:715)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.ImmediateExecutor.execute(ImmediateExecutor.java:34)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:703)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:790)     at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:503)     at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.ipc.StoppedRpcClientException     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:360)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:440)     ... 23 more ..... ..... 2022-05-11 14:49:13,232 INFO  [master/emr-header-1:16000] region.MasterRegion: Closing local region {ENCODED => 1595e783b53d99cd5eef43b6debb2682, NAME => 'master:store,,1.1595e783b53d99cd5eef43b6debb2682.', STARTKEY => '', ENDKEY => ''}, isAbort=true 2022-05-11 14:49:13,237 INFO  [master/emr-header-1:16000] regionserver.HRegion: Closing region master:store,,1.1595e783b53d99cd5eef43b6debb2682. 2022-05-11 14:49:13,243 ERROR [master/emr-header-1:16000] regionserver.HRegion: Memstore data size is 139232 in region master:store,,1.1595e783b53d99cd5eef43b6debb2682. 2022-05-11 14:49:13,243 INFO  [master/emr-header-1:16000] regionserver.HRegion: Closed master:store,,1.1595e783b53d99cd5eef43b6debb2682. 2022-05-11 14:49:13,377 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: HMaster Aborted     at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:251)     at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)     at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:144)     at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3209) {code}   Finally HMaster exit due to abort, the local region cache cannot be flushed normally. I also found NPE when HMaster is stopped(exception 2): {code:java} 2022-06-01 00:14:13,180 INFO  [master/emr-header-1:16000] region.RegionProcedureStore: Stopping the Region Procedure Store, isAbort=false 2022-06-01 00:14:13,181 WARN  [master/emr-header-1:16000] master.ActiveMasterManager: Failed get of master address: java.io.IOException: Can't get master address from ZooKeeper; znode data == null 2022-06-01 00:14:13,184 ERROR [RpcServer.priority.RWQ.Fifo.write.handler=0,queue=0,port=16000] ipc.RpcServer: Unexpected throwable object java.lang.NullPointerException     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.reportTransition(AssignmentManager.java:1186)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.updateRegionTransition(AssignmentManager.java:1156)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.reportRegionStateTransition(AssignmentManager.java:1072)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.reportRegionStateTransition(AssignmentManager.java:1117)     at org.apache.hadoop.hbase.master.MasterRpcServices.reportRegionStateTransition(MasterRpcServices.java:1772)     at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:17755)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:385)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:104)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:84){code}" "when “zookeeper.session.timeout” is set to a negative number, HMaster cannot stop normally",13443939,Open,Major,,09/May/22 08:55,,2.2.2,"In hbase- default.xml {code:java}   zookeeper.session.timeout   90000   ZooKeeper session timeout in milliseconds. It is used in two different ways.       First, this value is used in the ZK client that HBase uses to connect to the ensemble.       It is also used by HBase when it starts a ZK server and it is passed as the 'maxSessionTimeout'.       See https://zookeeper.apache.org/doc/current/zookeeperProgrammers.html#ch_zkSessions.       For example, if an HBase region server connects to a ZK ensemble that's also managed       by HBase, then the session timeout will be the one specified by this configuration.       But, a region server that connects to an ensemble managed with a different configuration       will be subjected that ensemble's maxSessionTimeout. So, even though HBase might propose       using 90 seconds, the ensemble can have a max timeout lower than this and it will take       precedence. The current default maxSessionTimeout that ZK ships with is 40 seconds, which is lower than       HBase's.   {code} The impact caused by setting zookeeper.session.timeout to negative number is different in local mode and pseudo-distributed mode.   After starting hbase in local mode, hmaster will replace the sessiontimeout configured in this start master() with the default value of 10000 when it is judged as local mode, so setting zookeeper.session.timeout to a negative number in hbase-site.xml will have no effect on the hbase startup process. {code:java} private int startMaster() {   Configuration conf = getConf();   TraceUtil.initTracer(conf);   try {     // If 'local', defer to LocalHBaseCluster instance.  Starts master     // and regionserver both in the one JVM.     if (LocalHBaseCluster.isLocal(conf)) {       ...       int localZKClusterSessionTimeout;       localZKClusterSessionTimeout = conf.getInt(HConstants.ZK_SESSION_TIMEOUT + "".localHBaseCluster"", 10*1000);       conf.setInt(HConstants.ZK_SESSION_TIMEOUT, localZKClusterSessionTimeout);       LOG.info(""Starting a zookeeper cluster"");       ...       } {code} Take the example of setting zookeeper.session.timeout to -1 in hbase-site.xml to start hbase in local mode normally. {code:java} hadoop@ljq1:~/hbase-2.2.2-ori/bin$ ./start-hbase.sh running master, logging to /home/hadoop/hbase-2.2.2-ori/bin/../logs/hbase-hadoop-master-ljq1.out hadoop@ljq1:~/hbase-2.2.2-ori/bin$ jps 25667 HMaster 21859 Jps{code} {code:java} 2022-05-09 11:16:57,571 INFO [master/ljq1:16000:becomeActiveMaster] master.HMaster: Master has completed initialization 8.179sec{code} However, next, when the hbase shell as a client initiates a request for basic database operations to the started HBase, the zookeeper.session.timeout is negative causing a ConnectionLoss error and any requested operation is invalid as it recreates the conf to load the configuration. {code:java} hadoop@ljq1:~/hbase-2.2.2-ori/bin$ ./hbase shell Use ""help"" to get list of supported commands. Use ""exit"" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell Version 2.2.2, re6513a76c91cceda95dad7af246ac81d46fa2589, Sat Oct 19 10:10:12 UTC 2019 Took 0.0212 seconds                                                             hbase(main):001:0> status ERROR: KeeperErrorCode = ConnectionLoss for /hbase/master For usage try 'help ""status""' Took 34.2850 seconds                                                           hbase(main):002:0> create 'aaaaa','a11111','a222222' ERROR: KeeperErrorCode = ConnectionLoss for /hbase/master For usage try 'help ""create""' Took 33.2029 seconds{code} The log shows that a socket connection was received, but consistently throws a warning that no additional data could be read from the client session and that the client may have closed the socket.   Next, use the official termination method . /stop-hbase.sh to shut down hbase, it will also recreate the conf and load the configuration when shutting down. zookeeper.session.timeout will be negative and the terminal will be stuck in an infinite wait, and eventually the process will have to be terminated by kill -9, which is the official termination method . /stop-hbase.sh to shut down hbase is not effective. {code:java} hadoop@ljq1:~/hbase-2.2.2-ori/bin$ ./stop-hbase.sh stopping hbase.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................force stopping stop-master-command with kill -9 25667{code} Using the official termination method . /stop-hbase.sh when shutting down hbase, the log shows that the stop request was received as well as the socket connection, but still no additional data can be read from the client session, probably with the warning that the client has closed the socket. {code:java} 2022年 05月 09日 星期一 14:35:07 CST Stopping hbase (via master) 2022-05-09 14:35:11,588 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33222 2022-05-09 14:35:12,709 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33224 2022-05-09 14:35:13,810 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33226 2022-05-09 14:35:14,912 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33228 2022-05-09 14:35:16,013 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33230 2022-05-09 14:35:17,115 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33232 2022-05-09 14:35:18,217 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33234 2022-05-09 14:35:19,321 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33236 ... 2022-05-09 14:36:18,846 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxnFactory: Accepted socket connection from /127.0.0.1:33344 2022-05-09 14:36:19,033 WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxn: caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:239) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:203) at java.base/java.lang.Thread.run(Thread.java:829) 2022-05-09 14:36:19,034 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxn: Closed socket connection for client /127.0.0.1:33344 (no session established for client) 2022-05-09 14:36:19,034 WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxn: caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:239) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:203) at java.base/java.lang.Thread.run(Thread.java:829) 2022-05-09 14:36:19,035 INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxn: Closed socket connection for client /127.0.0.1:33342 (no session established for client) 2022-05-09 14:36:19,035 WARN [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:2181] server.NIOServerCnxn: caught end of stream exception EndOfStreamException: Unable to read additional data from client sessionid 0x0, likely client has closed socket at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:239) at org.apache.zookeeper.server.NIOServerCnxnFactory.run(NIOServerCnxnFactory.java:203) at java.base/java.lang.Thread.run(Thread.java:829){code} Although, before finally using kill -9 to force a shutdown, the logs show that the reason for not being able to shut down properly may be because the zookeeper client session timed out and the client session did not receive a message from the server within 0ms and was closing the socket connection and trying to reconnect. {code:java} 2022-05-09 14:55:13,486 INFO [main] zookeeper.ZooKeeper: Initiating client connection, connectString=localhost:2181 sessionTimeout=-1 watcher=org.apache.hadoop.hbase.zookeeper.PendingWatcher@1cf6d1be 2022-05-09 14:55:13,589 INFO [main-SendThread(localhost:2181)] zookeeper.ClientCnxn: Opening socket connection to server localhost/127.0.0.1:2181. Will not attempt to authenticate using SASL (unknown error) 2022-05-09 14:55:13,621 WARN [main-SendThread(localhost:2181)] zookeeper.ClientCnxn: Client session timed out, have not heard from server in 0ms for sessionid 0x0 2022-05-09 14:55:13,622 INFO [main-SendThread(localhost:2181)] zookeeper.ClientCnxn: Client session timed out, have not heard from server in 0ms for sessionid 0x0, closing socket connection and attempting reconnect 2022-05-09 14:55:13,737 INFO [main] zookeeper.ZooKeeper: Session: 0x0 closed 2022-05-09 14:55:13,739 ERROR [main] util.ServerCommandLine: Failed to run java.lang.IllegalArgumentException: Invalid path string ""/hbase/rs//hbase/rs/ljq1,16020,1652066208559"" caused by empty node name specified @10 at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99) at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166) at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1257) at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1249) at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2942) 2022-05-09 14:55:13,747 INFO [main-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x0{code} It can be speculated that the process of shutting down hbase lacks a mechanism to determine and handle the impact of a negative zookeeper.session.timeout, resulting in the process of repeatedly closing the socket connection and trying to reconnect, without actually performing the operation of terminating hbase. And in local mode, the set value of zookeeper.session.timeout in hbase-site.xml is replaced with the default value in the startup phase, while the set value is used in the run phase and shutdown, and this configuration item is used inconsistently in different phases.   In pseudo-distributed mode, when zookeeper.session.timeout is set to a negative number, in the startup hbase phase, unlike the local mode replaces zookeeper.session.timeout with the default value of 10000, which can be checked in time for the exception caused by the negative value of the field. The log shows that the connection is closed after several attempts to reconnect after the client and the collection establish a connection judgment timeout, and then the zookeeper client event thread is closed , further leading to the failure to create the regionserver and the master node exits. The phenomenon observed throughout the process is that at first the Hbase daemons can be started normally, but after a period of time only the process HQuorumPeer remains, and the function cannot be used normally.   To summarize, for the effect of setting zookeeper.session.timeout to a negative number, hbase can be started normally in local mode, but no valid hbase database operations can be initiated, and using the official termination method . /stop-hbase.sh does not work to shut down hbase. In pseudo-distributed mode, hbase can be started normally but some of the daemons exit after a period of time and the functionality cannot be used normally. In both modes, there is a lack of judgment on the impact of negative zookeeper.session.timeout and the related handling mechanism is not perfect, and there is a lack of clear and effective information, which makes it impossible to locate and handle exceptions in time." Upgrade scalatest maven plugin for thread-safety,13449785,Resolved,Major,Fixed,13/Jun/22 11:39,07/Sep/23 09:04,hbase-connectors-1.0.1,"The {{master}} branch on the connectors repo warns when {{--threads}} is issued, the complaint being the scalatest-maven-plugin. Looks like the latest version resolves the complaint. Let's upgrade." Exclude files which are not in source control as much as possible when running spotless,13448831,In Progress,Major,,07/Jun/22 15:04,,,"In HBASE-27084, we added spotless:check to mvn verify stage, but the general format section in spotless will include some files which are not in source control, such as .idea/* or .settings/*, and then fail the 'mvn install'. Although usually it could be fixed by a spotless:apply call, but IDE may regenerate the file and fail the build again. Let's add more exclude patterns to make it work better." The length of compact queue grows too big when the compacting is slow,13442421,Open,Major,,29/Apr/22 02:26,,,"For some system compaction, we set the selectNow to false, so the file selecting will not be done until the compaction running, it brings side effect, if another compacting is slow, we may put lots of compaction to queue, because the filesCompacting of Hstore is empty in the meantime. An example shows at attachments, there are 154 regions and about 2000 hfiles, but the length of compact queue grows to 1391, it cause confusion and may trigger unexpected alarm. My approach is limit the compaction queue count, by compute the filesNotCompating and hbase.hstore.compaction.max." IOException during caching of uncompressed block to the block cache.,13445753,Resolved,Major,Fixed,19/May/22 04:45,16/Jul/22 22:21,2.4.12,"When prefetch to block cache is enabled and blocks are compressed sometimes caching fails with the exception: {noformat} 2022-05-18 21:37:29,597 ERROR [RS_OPEN_REGION-regionserver/x1:16020-2] regionserver.HRegion: Could not initialize all stores for the region=cluster_test,66666666,1652935047946.a57ca5f9e7bebb4855a44523063f79c7. 2022-05-18 21:37:29,598 WARN [RS_OPEN_REGION-regionserver/x1:16020-2] regionserver.HRegion: Failed initialize of region= cluster_test,66666666,1652935047946.a57ca5f9e7bebb4855a44523063f79c7., starting to roll back memstore java.io.IOException: java.io.IOException: java.lang.RuntimeException: Cached block contents differ, which should not have happened.cacheKey:19307adf1c2248ebb5675116ea640712.c3a21f2005abf308e4a8c9759d4e05fe_0 at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1149) at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1092) at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:996) at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:946) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7240) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7199) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7175) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7134) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7090) at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:147) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:100) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException: java.lang.RuntimeException: Cached block contents differ, which should not have happened.cacheKey:19307adf1c2248ebb5675116ea640712.c3a21f2005abf308e4a8c9759d4e05fe_0 at org.apache.hadoop.hbase.regionserver.StoreEngine.openStoreFiles(StoreEngine.java:294) at org.apache.hadoop.hbase.regionserver.StoreEngine.initialize(StoreEngine.java:344) at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:294) at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6375) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1115) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1112) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) ... 3 more Caused by: java.lang.RuntimeException: Cached block contents differ, which should not have happened.cacheKey:19307adf1c2248ebb5675116ea640712.c3a21f2005abf308e4a8c9759d4e05fe_0 at org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.validateBlockAddition(BlockCacheUtil.java:199) at org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.shouldReplaceExistingCacheBlock(BlockCacheUtil.java:231) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.shouldReplaceExistingCacheBlock(BucketCache.java:447) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.cacheBlockWithWait(BucketCache.java:432) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.cacheBlock(BucketCache.java:418) at org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.cacheBlock(CombinedBlockCache.java:60) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.lambda$readBlock$2(HFileReaderImpl.java:1319) at java.util.Optional.ifPresent(Optional.java:159) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1317) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.readAndUpdateNewBlock(HFileReaderImpl.java:942) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:931) at org.apache.hadoop.hbase.io.HalfStoreFileReader$1.seekTo(HalfStoreFileReader.java:171) at org.apache.hadoop.hbase.io.HalfStoreFileReader.getFirstKey(HalfStoreFileReader.java:321) at org.apache.hadoop.hbase.regionserver.HStoreFile.open(HStoreFile.java:477) at org.apache.hadoop.hbase.regionserver.HStoreFile.initReader(HStoreFile.java:490) at org.apache.hadoop.hbase.regionserver.StoreEngine.createStoreFileAndReader(StoreEngine.java:231) at org.apache.hadoop.hbase.regionserver.StoreEngine.lambda$openStoreFiles$0(StoreEngine.java:272) ... 6 more {noformat} " Disable Style/FrozenStringLiteralComment for ruby,13444504,Open,Major,,12/May/22 03:11,,,"By default Style/FrozenStringLiteralComment is enabled in rubocop. If we update a ruby file, rubocop prompts `Missing frozen string literal comment` (see [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt]. To address this warn, we need to add `# frozen_string_literal: true` to the top of the ruby file(see https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3637), which will be added to the top of the `Apache License` and will look strange. I don't think this `FrozenStringLiteralComment` check is very necessary. We can disable it." Move replication queue storage from zookeeper to a separated HBase table,13449672,Resolved,Major,Fixed,12/Jun/22 12:56,15/May/23 14:55,,This is a more specific issue based on the works which are already done in HBASE-15867. Replication Observability Framework,13437260,Resolved,Major,Fixed,01/Apr/22 13:59,20/Apr/23 21:34,,"In our production clusters, we have seen cases where data is present in source cluster but not in the sink cluster and 1 case where data is present in sink cluster but not in source cluster.  We have internal tools where we take incremental backup every day on both source and sink clusters and we compare the hash of the data in both the backups. We have seen many cases where hash doesn't match which means data is not consistent between source and sink for that given day. The Mean Time To Detect (MTTD) these inconsistencies is atleast 2 days and requires lot of manual debugging. We need some tool where we can reduce MTTD and requires less manual debugging. I have attached design doc. Huge thanks to [~bharathv]  to come up with this design at my work place." Server should close scanner if client times out before results are ready,13458624,Resolved,Major,Fixed,22/Jun/22 18:18,12/Jul/22 02:47,,"When heartbeats are enabled, we try to return from a scan before {{clientTimeout / 2}} millis has passed. Previously, this did not account for queue times so could still easily timeout. That problem was handled in HBASE-27048. It's still possible to timeout if heartbeats are disabled, we have queued for longer than \{{ clientTimeout / 2 }} millis and scan is slow, or if the RegionScanner is otherwise delayed in returning. How a scanner timeout is handled by the client depends on the point at which the timeout occurred: * In openScanner(), the call will be retried. We will not have received a scannerId, so cannot close that scanner that may have been open on the server side. * In next(), the timeout will bubble up and fail the scan. In this case we try to close the scanner, but that could be interrupted if server is overwhelmed (close call gets queued and then dropped) or client terminates. Active scanners carry with them a non-trivial amount of memory and resource overhead on the server. In my experience, if a server becomes overwhelmed, client scanners can start to time out. Those scanners live on on the server, contributing to memory and resource pressure. That further slows down the server, etc. This is especially problematic when openScanner times out because of the inherent retries of that call, with a single scanner possibly contributing multiple ""leaked"" scanners on the server before finally failing. We should attempt to close the scanner on the server side when a scan call takes longer than the client timeout to finish. I think this would be a matter of adding something like this to the end of RSRpcServices.scan: {code:java} if (EnvironmentEdgeManager.currentTime() > rpcCall.getDeadline()) {   throw new TimeoutIOException(""Client deadline exceeded, cannot return results""); }{code} We already have a catch of IOException, wherein we close the scanner. The actual exception thrown shouldn't matter much since the client will not receive the response." s390x: Skip tests on unsupported compression libs,13469093,Resolved,Major,Fixed,29/Jun/22 12:18,28/Oct/22 04:50,,"Since https://issues.apache.org/jira/browse/INFRA-21433, there are four s390x Jenkins build nodes available. Could the HBase CI be extended to build on s390x as well? There is an old issue open about adding s390x support to the HBase CI but it has not received any update in quite some time. https://issues.apache.org/jira/browse/HBASE-25192. There was some interest in starting by adding s390x to the nightly builds. Would that still be the best way to start? Let me know if there are any questions. I'm happy to help in any way I can." Add documentation for Replication Observability Framework in hbase book.,13449040,Resolved,Major,Implemented,08/Jun/22 15:54,04/Nov/22 04:36,, Create REPLICATION_SINK_TRACKER table to persist sentinel rows coming from source cluster.,13448175,Resolved,Major,Implemented,02/Jun/22 16:12,04/Nov/22 04:36,,"This work is to create sink tracker table to persist tracker rows coming from replication source cluster.  Create ReplicationMarkerChore to create replication marker rows periodically." Create WAL event tracker table to track all the WAL events.,13437656,Resolved,Major,Implemented,04/Apr/22 15:07,04/Nov/22 04:35,,"Design Doc: [https://docs.google.com/document/d/14oZ5ssY28hvJaQD_Jg9kWX7LfUKUyyU2PCA93PPzVko/edit#] Create wal event tracker table to track WAL events. Whenever we roll the WAL, we will save the WAL name, WAL length, region server, timestamp in a table." Investigate Netty resource usage limits,13449685,Resolved,Major,Done,12/Jun/22 17:55,07/Oct/22 18:46,2.5.0,"We leave Netty level resource limits unbounded. The number of threads to use for the event loop is default 0 (unbounded). The default for io.netty.eventLoop.maxPendingTasks is INT_MAX. We don't do that for our own RPC handlers. We have a notion of maximum handler pool size, with a default of 30, typically raised in production by the user. We constrain the depth of the request queue in multiple ways... limits on number of queued calls, limits on total size of calls data that can be queued (to avoid memory usage overrun, CoDel conditioning of the call queues if it is enabled, and so on. Under load can we pile up a excess of pending request state, such as direct buffers containing request bytes, at the netty layer because of downstream resource limits? Those limits will act as a bottleneck, as intended, and before would have also applied backpressure through RPC too, because SimpleRpcServer had thread limits (""hbase.ipc.server.read.threadpool.size"", default 10), but Netty may be able to queue up a lot more, in comparison, because Netty has been optimized to prefer concurrency. Consider the hbase.netty.eventloop.rpcserver.thread.count default. It is 0 (unbounded). I don't know what it can actually get up to in production, because we lack the metric, but there are diminishing returns when threads > cores so a reasonable default here could be Runtime.getRuntime().availableProcessors() instead of unbounded? maxPendingTasks probably should not be INT_MAX, but that may matter less. The tasks here are: - Instrument netty level resources to understand better actual resource allocations under load. Investigate what we need to plug in where to gain visibility. - Where instrumentation designed for this issue can be implemented as low overhead metrics, consider formally adding them as a metric. - Based on the findings from this instrumentation, consider and implement next steps. The goal would be to limit concurrency at the Netty layer in such a way that performance is still good, and under load we don't balloon resource usage at the Netty layer. If the instrumentation and experimental results indicate no changes are necessary, we can close this as Not A Problem or WontFix. " Backport missing MOB related changes to branch-2,13463005,Resolved,Major,Fixed,23/Jun/22 15:10,05/Oct/22 00:06,2.6.0,"While trying to backport https://issues.apache.org/jira/browse/HBASE-26969 to branch-2 I have found that multiple major MOB related changes are missing. This change is required for FileBased SFT correctness so the changes it depends on should be backported first. Also any improvement to MOB stability is usually welcomed. The missing changes I have found so far: https://issues.apache.org/jira/browse/HBASE-22749 https://issues.apache.org/jira/browse/HBASE-23723 https://issues.apache.org/jira/browse/HBASE-24163 There is also a docs change describing the new MOB functionality. But considering that the book is always generated based on master I think it is safe to skip backporting it. https://issues.apache.org/jira/browse/HBASE-23198 I'm planning to backport these changes one by one until we reach a state where HBASE-26969 can be backported too." Allow sharing connections between AggregationClient instances,13446635,Resolved,Major,Fixed,24/May/22 20:47,24/Jun/22 14:54,,"AggregationClient only has a single constructor which takes a Configuration. The constructor uses the Configuration to create a Connection. However, some of the AggregationClient methods take a Table argument. In those cases it doesn't use the created Connection at all. We should add another constructor which does not create a Connection so that people can use AggregationClient with externally managed Connection." move nightly cluster tests to run on k8s,13443670,Open,Major,,06/May/22 15:34,,, cordon off large ci worker nodes,13443671,Resolved,Major,Fixed,06/May/22 15:36,19/May/22 17:11,,Make sure our node labeling keeps test workloads that off of the new large spec nodes so that they're only used for the nightly k8s based tests Use AsyncConnection in ReplicationSink,13439271,Resolved,Major,Fixed,12/Apr/22 18:27,09/Jul/22 03:32,2.4.11,"We don't need to necessarily rewrite ReplicationSink to work fully async. I think it would simply benefit from ConnectionFactory.createAsyncConnection instead of ConnectionFactory.createConnection. The reasons for this are: * AsyncConnection is the more modern implementation, the only implementation in master, and where most of the efforts will be going forward. * ReplicationSink only does batch calls, and batch calls are done with AsyncProcess. It's likely that the native AsyncTable is better than AsyncProcess for this. ** One specific example, AsyncProcess calls findAllLocationsOrFail sequentially for all actions in a batch. This can take quite a while with the default replication batch size of 5k, if actions are spread across many regions. In AsyncTable, these calls are done in parallel" Possible resource leak while creating new region scanner,13439010,Resolved,Major,Fixed,11/Apr/22 17:12,15/Apr/22 06:16,2.4.11,"We will miss to close the region scanner when RegionObserver#postScannerOpen impl throws exception. https://github.com/apache/hbase/blob/1d8a5bf0e3246a1df11f0aa9215f29e6fbc4ecb1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3203 https://github.com/apache/hbase/blob/1d8a5bf0e3246a1df11f0aa9215f29e6fbc4ecb1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3207" Add snapshot scanner UT with SFT and some cleanups to TestTableSnapshotScanner,13437719,Resolved,Major,Fixed,04/Apr/22 21:28,05/Apr/22 17:11,2.4.11,This is to replicate current TableSapshotScanner UTs to run over an SFT cluster. Just extending current TableSapshotScanner with overrides to setup method. Also applied some fix/cleanups to TableSapshotScanner. HStore should try write WAL compaction marker before replacing compacted files in StoreEngine,13443351,Resolved,Major,Fixed,05/May/22 10:41,10/May/22 19:50,2.5.0,"On HBASE-26064, it seems we altered the order we update different places with the results of a compaction: {noformat} @@ -1510,14 +1149,13 @@ public class HStore implements Store, HeapSize, StoreConfigInformation,        List newFiles) throws IOException {      // Do the steps necessary to complete the compaction.      setStoragePolicyFromFileName(newFiles); -    List sfs = commitStoreFiles(newFiles, true); +    List sfs = storeEngine.commitStoreFiles(newFiles, true);      if (this.getCoprocessorHost() != null) {        for (HStoreFile sf : sfs) {          getCoprocessorHost().postCompact(this, sf, cr.getTracker(), cr, user);        }      } -    writeCompactionWalRecord(filesToCompact, sfs); -    replaceStoreFiles(filesToCompact, sfs); +    replaceStoreFiles(filesToCompact, sfs, true); ... @@ -1581,25 +1219,24 @@ public class HStore implements Store, HeapSize, StoreConfigInformation,          this.region.getRegionInfo(), compactionDescriptor, this.region.getMVCC());    } -  void replaceStoreFiles(Collection compactedFiles, Collection result) -      throws IOException { -    this.lock.writeLock().lock(); -    try { -      this.storeEngine.getStoreFileManager().addCompactionResults(compactedFiles, result); -      synchronized (filesCompacting) { -        filesCompacting.removeAll(compactedFiles); -      } - -      // These may be null when the RS is shutting down. The space quota Chores will fix the Region -      // sizes later so it's not super-critical if we miss these. -      RegionServerServices rsServices = region.getRegionServerServices(); -      if (rsServices != null && rsServices.getRegionServerSpaceQuotaManager() != null) { -        updateSpaceQuotaAfterFileReplacement( -            rsServices.getRegionServerSpaceQuotaManager().getRegionSizeStore(), getRegionInfo(), -            compactedFiles, result); -      } -    } finally { -      this.lock.writeLock().unlock(); +  @RestrictedApi(explanation = ""Should only be called in TestHStore"", link = """", +    allowedOnPath = "".*/(HStore|TestHStore).java"") +  void replaceStoreFiles(Collection compactedFiles, Collection result, +    boolean writeCompactionMarker) throws IOException { +    storeEngine.replaceStoreFiles(compactedFiles, result); +    if (writeCompactionMarker) { +      writeCompactionWalRecord(compactedFiles, result); +    } +    synchronized (filesCompacting) { +      filesCompacting.removeAll(compactedFiles); +    } +    // These may be null when the RS is shutting down. The space quota Chores will fix the Region +    // sizes later so it's not super-critical if we miss these. +    RegionServerServices rsServices = region.getRegionServerServices(); +    if (rsServices != null && rsServices.getRegionServerSpaceQuotaManager() != null) { +      updateSpaceQuotaAfterFileReplacement( +        rsServices.getRegionServerSpaceQuotaManager().getRegionSizeStore(), getRegionInfo(), +        compactedFiles, result); {noformat} While running some large scale load test, we run into File SFT metafiles inconsistency that we believe could have been avoided if the original order was in place. Here the scenario we had: 1) Region R with one CF f was open on RS1. At this time, the given store had some files, let's say these were file1, file2 and file3; 2) Compaction started on RS1; 3) RS1 entered a long GC pause, lost ZK lock. Compaction is still running, though. 4) RS2 opens R. The related File SFT instance for this store then creates a new meta file with file1, file2 and file3. 5) Compaction on RS1 successfully completes the *storeEngine.replaceStoreFiles* call. This updates the in memory cache of valid files (StoreFileManager) and the SFT metafile for  the store engine on RS1 with the compaction resulting file, say file4, removing file1, file2 and file3. Note that the SFT meta file used by RS1 here is different (older) than the one used by RS2. 6) Compaction on RS1 tries to update WAL marker, but fails to do so, as the WAL already got closed when the RS1 ZK lock expired. This triggers a store close in RS1. As part of the store close process, it removes all files it sees as completed compacted, in this case, file1, file2 and file3. 7) RS2 still references file1, file2 and file3. It then gets FileNotFoundException when trying to open any of these files. This situation would had been avoided if the original order of a) write WAL marker, then b) replace store files was kept. " MOB snapshot is broken when FileBased SFT is used,13443984,Resolved,Major,Fixed,09/May/22 13:33,05/Jun/22 23:40,2.5.0,"During snapshot MOB regions are treated like any other region. When a snapshot is taken and hfile references are collected a StoreFileTracker is created to get the current active hfile list. But the MOB region stores are not tracked so an empty list is returned, resulting in a broken snapshot. When this snapshot is cloned the resulting table will have no MOB files or references. The problematic code can be found here: [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifest.java#L313]" StoreFileInfo should set its initialPath in a consistent way,13444207,Resolved,Major,Fixed,10/May/22 16:21,12/May/22 10:29,2.5.0,"Currently, StoreFileInfo provides overloaded public constructors where the related file path can be passed as either a Path or FileStatus instance. This can lead to the StoreFileInfo instances related to the same file entry to have different representations of the file path, which could create problems for functions relying on equality for comparing store files. One example I could find is the StoreEngine.refreshStoreFiles method, which list some files from the SFT, then compares against a list of files from the SFM to decide how it should update SFM internal cache. Here's a sample output from the TestHStore.testRefreshStoreFiles: ------- 2022-05-10T15:06:42,831 INFO [Time-limited test] regionserver.StoreEngine(399): Refreshing store files for org.apache.hadoop.hbase.regionserver.DefaultStoreEngine@69d58ac1 files to add: [file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/6e92c2f5cf1f40f7b8c6b6b34a176fa5, file:/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}] files to remove: [/hbase/hbase-server/target/test-data/e3eac5ce-9bdf-8624-bcec-09c89790d682/TestStoretestRefreshStoreFiles/data/default/table/da6a3cf38941b37cd16438d554b13bbc/family/{*}fa4d5909da644d94873cbfdc6b5a07da{*}] ------- The above will wrongly add it to SFM's list of compacted files, making a valid file potentially eligible for deletion and data loss. I think we can avoid that by always converting Path instances passed in StoreFileInfo constructors to a FileStatus, for consistently build the internal StoreFileInfo path." HBaseInterClusterReplicationEndpoint should honor replication adaptive timeout,13449263,Resolved,Major,Fixed,09/Jun/22 15:25,23/Jun/22 16:58,,"HBASE-23293 introduced replication.source.shipedits.timeout which is adaptive, ReplicationSourceShipper#shipEdits() set the adaptive timeout based on retries. But on CallTimeoutException in HBaseInterClusterReplicationEndpoint#replicate(), it keep retrying the replication after sleep with same timeout value." Hbase SecureBulkload permission regression,13447378,Resolved,Major,Fixed,29/May/22 13:09,31/May/22 10:02,2.5.0,"HBASE-26707 has introduced a bug, where setting the permission of the bulk loaded HFile to 777 is made conditional. However, as discussed in HBASE-15790, that permission is essential for HBase's correct operation." two phase bulkload is broken when SFT is in use.,13446684,Resolved,Major,Fixed,25/May/22 04:13,26/May/22 13:12,2.5.0,"In HBASE-26707 for the SFT case, we are writing files directly to the region location. For that we are using HRegion.regionDir as the staging directory. The problem is that in reality, this dir is pointing to the WAL dir, so for S3 deployments that would be pointing to the hdfs. As the result during the execution of LoadIncrementalHFiles the process failed with the exception: {noformat} 2022-05-24 03:31:23,656 ERROR org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager: Failed to complete bulk load java.lang.IllegalArgumentException: Wrong FS hdfs://ns1//hbase-wals/data/default/employees/4f367b303da4fed7667fff07fd4c6066/department/acd971097924463da6d6e3a15f9527da -expected s3a://hbase at org.apache.hadoop.fs.s3native.S3xLoginHelper.checkPath(S3xLoginHelper.java:224) at org.apache.hadoop.fs.s3a.S3AFileSystem.checkPath(S3AFileSystem.java:1375) at org.apache.hadoop.fs.FileSystem.makeQualified(FileSystem.java:647) at org.apache.hadoop.fs.s3a.S3AFileSystem.makeQualified(S3AFileSystem.java:1337) at org.apache.hadoop.fs.s3a.S3AFileSystem.qualify(S3AFileSystem.java:1363) at org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:3521) at org.apache.hadoop.fs.FileUtil.checkDest(FileUtil.java:511) at org.apache.hadoop.fs.FileUtil.copy(FileUtil.java:397) at org.apache.hadoop.fs.FileUtil.copy(FileUtil.java:387) at org.apache.hadoop.fs.FileUtil.copy(FileUtil.java:337) at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$SecureBulkLoadListener.prepareBulkLoad(SecureBulkLoadManager.java:397) at org.apache.hadoop.hbase.regionserver.HRegion.bulkLoadHFiles(HRegion.java:6994) at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:291) at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:266) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:360) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1879) at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager.secureBulkLoadHFiles(SecureBulkLoadManager.java:266) at org.apache.hadoop.hbase.regionserver.RSRpcServices.bulkLoadHFile(RSRpcServices.java:2453) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45821) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:392) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:140) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:359) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:339) {noformat}" Under compaction mark may leak,13459971,Resolved,Major,Fixed,23/Jun/22 05:05,29/Aug/22 17:25,2.4.12,"HBASE-26249 introduced an under compaction mark to reduce repeatedly compactions for the same stores for a short period of time after bulk loading files. Since the mark adding and removing are in difference threads, {code:java} pool.execute( new CompactionRunner(store, region, compaction, tracker, completeTracker, pool, user)); if (LOG.isDebugEnabled()) { LOG.debug( ""Add compact mark for store {}, priority={}, current under compaction "" + ""store size is {}"", getStoreNameForUnderCompaction(store), priority, underCompactionStores.size()); } underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}  it happens that the concurrently of thread-1 using underCompactionStores.add() and thread-2 which running a CompactionRunner that using underCompactionStores.remove(). If the removing happens before adding, the mark will leak." Non-interactive missing for the hbase-shell,13449893,Patch Available,Major,,14/Jun/22 01:31,,2.4.12,"During test 2.4.12, we found a lot of our integration testing failure for the non-interactive mode in hbase-shell, looks like in 2.4.12, we removed the ""shell.eval_io"" for the non-interactive shell, this caused the input/output handle behavior for shell is the same for interactive and non-interactive which caused unexpected error, for example:   ``` echo -e ""disable_all '.*'\ny"" | hbase shell -n =====Old version 2.4.4===== t1 Disable the above 1 tables (y/n)? 1 tables successfully disabled Took 0.7811 seconds =====New version 2.4.12===== hbase:001:0> disable_all '.*'t1 test_tableDisable the above 2 tables (y/n)? Took 0.5270 seconds NoMethodError: undefined method `chomp' for nil:NilClass command at uri:classloader:/shell/commands/disable_all.rb:41 command_safe at uri:classloader:/shell/commands.rb:49 translate_hbase_exceptions at uri:classloader:/shell/commands.rb:122 command_safe at uri:classloader:/shell/commands.rb:49 .... run at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:427
at classpath:/jar-bootstrap.rb:223}} ```" Add a tool command list_unknownservers,13449260,Resolved,Major,Fixed,09/Jun/22 14:59,22/Aug/22 14:18,3.0.0-alpha-3,"Sometimes, RegionServer will become an unknown server. It is necessary to add a tool command to list unknown servers. !image-2022-06-10-15-49-33-178.png!" Add a config that allows us to configure region-level storage policies,13450589,Resolved,Major,Fixed,17/Jun/22 10:29,22/Aug/22 02:36,," hbase.hregion.block.storage.policy HOT|ALL_SSD|... With this config, we can set region-level storage policies.   We have this config about CF storage policy: {code:java} hbase.hstore.block.storage.policy ALL_SSD {code} But in addition to CF, we also have some other path under region path, such like .splits,  recovered.edits, .tmp . So i want to add a region-level config which could cover the whole path, and if you have any other requirements for the cf directory, you can continue to use the previous hbase.hstore.block.storage.policy to specify them separately." Log archiving fail cause regionserver abort,13450716,In Progress,Major,,18/Jun/22 08:49,,2.3.4,"RegionServer log java.io.IOException: Unable to rename hdfs://clusterA/hbase/WALs/hostmame1,16020,1647853003113/hostmame1%2C16020%2C1647853003113.default.1655296917964 to hdfs://clusterA/hbase/oldWALs/hostmame1,16020,1647853003113/hostmame1%2C16020%2C1647853003113.default.1655296917964 NameNode log [2022-06-15T20:51:49.277+08:00] [INFO] [IPC Server handler 0 on 8021] : Starting log segment at 25945020756 [2022-06-15T20:51:58.050+08:00] [WARN] [IPC Server handler 180 on 8020] : DIR* FSDirectory.unprotectedRenameTo: failed to rename /h base/WALs/hostmame1,16020,1647853003113/hostmame1%2C16020%2C16478530031 13.default.1655296917964 to /hbase/oldWALs/hostmame1,16020,1647853003113/HTYD-clusterA-11-13-112-165.hado op.jd.local%2C16020%2C1647853003113.default.1655296917964 because destination's parent does not exist" Eliminate MOB renames when SFT is enabled,13441182,Resolved,Major,Fixed,22/Apr/22 15:10,19/Aug/22 10:58,2.5.0,"MOB file compaction and flush still relies on renames even when SFT is enabled. My proposed changes are: * when requireWritingToTmpDirFirst is false during mob flush/compact instead of using the temp writer we should create a different writer using a {color:#000000}StoreFileWriterCreationTracker that writes directly to the mob store folder{color} * {color:#000000}these StoreFileWriterCreationTracker should be stored in the MobStore. This would requires us to extend MobStore with a createWriter and a finalizeWriter method to handle this{color} * {color:#000000}refactor {color}MobFileCleanerChore to run on the RS instead on Master to allow access to the {color:#000000}StoreFileWriterCreationTracker{color}s to make sure the currently written files are not cleaned up" Improvements to read-path tracing,13462971,Resolved,Major,Fixed,23/Jun/22 12:19,02/Aug/22 12:10,2.5.0,"Take another pass through tracing of the read path, make adjustments accordingly. One of the major concerns raised previously is that we create a span for every block access. Start by simplifying this to trace events and see what else comes up." [HBCK2] extraRegionsInMeta does not work If RegionInfo is null,13454669,Resolved,Major,Fixed,22/Jun/22 00:07,02/Aug/22 10:29,hbase-operator-tools-1.2.0,"extraRegionsInMeta will not clean/fix meta if info:regioninfo columns is missing.   Somehow, the customer has the following empty row in meta as a stale.  'I1xxxxxx,16332508xxxxx.xxxxf53609cc1ae366b43205dxxxxxxx', 'info:state', 163333223xxxx   And no corresponding table ""I1xxxxxx"" exist.    We use extraRegionsInMeta but it didn't clean. Also, we created same table again and used extraRegionsInMeta after removing HDFS data but the stale row never cleaned. It looks extraRegionsInMeta works only when ""info:regioninfo"" is present.    We need to handle the scenario for other columns I.e info:state, info:server, etc" Release 3.0.0-alpha-3,13450055,Resolved,Major,Fixed,14/Jun/22 15:57,31/Jul/22 12:10,, Set version as 3.0.0-alpha-4-SNAPSHOT in master,13468630,Resolved,Major,Fixed,27/Jun/22 14:54,31/Jul/22 12:10,, Add 3.0.0-alpha-3 to download page,13468628,Resolved,Major,Fixed,27/Jun/22 14:53,31/Jul/22 12:09,, Improvements to low level scanner tracing,13463028,Resolved,Major,Won't Fix,23/Jun/22 18:00,26/Jul/22 19:09,,"Related to HBASE-27153, consider tracer semantic attributes for low level scanner details. Consider https://issues.apache.org/jira/secure/attachment/13006571/W-7665966-Instrument-low-level-scan-details-branch-2.2.patch (from HBASE-24637). This was used to collect detailed metrics of the decisions of ScanQueryMatcher and related classes. {noformat} metrics: [ ""block_read_keys"": 477 ""block_read_ns"": 3427040 ""block_reads"": 13 ""block_seek_ns"": 1606370 ""block_seeks"": 169 ""block_unpack_ns"": 10256 ""block_unpacks"": 13 ""cells_matched"": 165 ""cells_matched__hbase:meta,,1.1588230740__info"": 165 ""column_hint_include"": 148 ""memstore_next"": 72 ""memstore_next_ns"": 136671 ""memstore_seek"": 2 ""memstore_seek_ns"": 631629 ""reseeks"": 36 ""sqm_hint_done"": 17 ""sqm_hint_include"": 74 ""sqm_hint_seek_next_col"": 74 ""store_next"": 276 ""store_next__1c930a35ff8041368a05817adbdcce97"": 40 ""store_next__2644194fdf794815abdc940c183dab88"": 40 ""store_next__32ce31753fb244668f788fb94ab02dff"": 40 ""store_next__61c8423b9d8846c99a61cd2996b5b621"": 116 ""store_next__f4f7878c9fcf40d9902416d5c7a4097a"": 40 ""store_next_ns"": 1891634 ""store_next_ns__1c930a35ff8041368a05817adbdcce97"": 269383 ""store_next_ns__2644194fdf794815abdc940c183dab88"": 299936 ""store_next_ns__32ce31753fb244668f788fb94ab02dff"": 288594 ""store_next_ns__61c8423b9d8846c99a61cd2996b5b621"": 594313 ""store_next_ns__f4f7878c9fcf40d9902416d5c7a4097a"": 439408 ""store_reseek"": 164 ""store_reseek__1c930a35ff8041368a05817adbdcce97"": 32 ""store_reseek__2644194fdf794815abdc940c183dab88"": 32 ""store_reseek__32ce31753fb244668f788fb94ab02dff"": 32 ""store_reseek__61c8423b9d8846c99a61cd2996b5b621"": 36 ""store_reseek__f4f7878c9fcf40d9902416d5c7a4097a"": 32 ""store_reseek_ns"": 2969978 ""store_reseek_ns__1c930a35ff8041368a05817adbdcce97"": 359489 ""store_reseek_ns__2644194fdf794815abdc940c183dab88"": 595115 ""store_reseek_ns__32ce31753fb244668f788fb94ab02dff"": 474642 ""store_reseek_ns__61c8423b9d8846c99a61cd2996b5b621"": 1013188 ""store_reseek_ns__f4f7878c9fcf40d9902416d5c7a4097a"": 527544 ""store_seek"": 5 ""store_seek__1c930a35ff8041368a05817adbdcce97"": 1 ""store_seek__2644194fdf794815abdc940c183dab88"": 1 ""store_seek__32ce31753fb244668f788fb94ab02dff"": 1 ""store_seek__61c8423b9d8846c99a61cd2996b5b621"": 1 ""store_seek__f4f7878c9fcf40d9902416d5c7a4097a"": 1 ""store_seek_ns"": 8862786 ""store_seek_ns__1c930a35ff8041368a05817adbdcce97"": 830421 ""store_seek_ns__2644194fdf794815abdc940c183dab88"": 585899 ""store_seek_ns__32ce31753fb244668f788fb94ab02dff"": 483605 ""store_seek_ns__61c8423b9d8846c99a61cd2996b5b621"": 5958072 ""store_seek_ns__f4f7878c9fcf40d9902416d5c7a4097a"": 1004789 ""versions_hint_include"": 74 ""versions_hint_seek_next_col"": 74 ] {noformat} We can see the differences between seek time and reseek time and we get the counts for same, so we can analyze if SQM is making optimal choices (or less optimal choices) or not, or if behavior has changed; and we can identify particular store file(s) that might be outliers for some reason when hunting for sources of regression. We get the time required to unpack blocks (on average). We get a count of hints supplied by base SQM functionality or filters. We get the relative contributions of query processing time separately from memstore and store files. Perhaps this can be done conditionally for scans that are selected for tracing. Of course there is a performance concern, so it must be done such that the overheads really are conditional on if the path is being actively traced, and measured carefully to decide if it should be committed or not. WDYT [~ndimiduk] [~zhangduo]" TestQuotaThrottle times out,13448391,Resolved,Major,Fixed,03/Jun/22 22:25,26/Jul/22 20:58,2.5.0,"With branch-2.5, TestQuotaThrottle times out. Need to investigate.   h3. Error Message Failed after attempts=7, exceptions: 2022-06-03T11:26:33.418Z, RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/master" The filenum in AbstractFSWAL should be monotone increasing,13445318,Resolved,Major,Fixed,17/May/22 04:49,09/Jun/22 11:41,,"This is the current code {code} /** * retrieve the next path to use for writing. Increments the internal filenum. */ private Path getNewPath() throws IOException { this.filenum.set(EnvironmentEdgeManager.currentTime()); Path newPath = getCurrentFileName(); while (fs.exists(newPath)) { this.filenum.incrementAndGet(); newPath = getCurrentFileName(); } return newPath; } {code} In some tests, we inject our own EnvironmentEdge, it may return the same ts always or even go backwards, the logic here is not rnough to keep the filenum monotone increasing, as we may have already archive the old file." Phoenix PartialIndexRebuilderIT regression on 2.4.11,13442533,Resolved,Major,Invalid,29/Apr/22 14:38,02/May/22 06:20,2.4.11,"We have noticed that using HBase 2.4.11 reliably breaks _PartialIndexRebuilderIT.testConcurrentUpsertsWithRebuild_ and makes _ConcurrentMutationsExtendedIT.testConcurrentUpserts_ very flakey. The same tests run file with earlier versions, including HBase 2.4.10. At best this is a behaviour change in an HBase minor version, at worst this is a plain regression." Server side scanner time limit should account for time in queue,13445462,Resolved,Major,Fixed,17/May/22 16:16,14/Jul/22 23:34,,"When a scan request comes in with a timeout specified and heartbeats/partials allowed, we calculate a time limit for running the scan to be half of that timeout. The idea is to return before the timeout expires. The calculation of that time limit is ""now + timeout / 2"", where now is the point at which the scan is starting to run. What's missed here is the scan may have spent upwards of a few seconds in the IPC queue before being serviced. In this case, the time limit may extend beyond the timeout of the request and the server will not return in time. We should calculate the time limit from ServerCall.getReceiveTime instead to avoid these timeouts." TestReplicationValueCompressedWAL is flaky,13468474,Open,Major,,27/Jun/22 02:41,,,"https://nightlies.apache.org/hbase/HBase-Flaky-Tests/master/3752/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.replication.regionserver.TestReplicationValueCompressedWAL-output.txt {noformat} 2022-06-26T08:41:27,359 DEBUG [RS_REFRESH_PEER-regionserver/jenkins-hbase19:0-0.replicationSource,2.replicationSource.wal-reader.jenkins-hbase19.apache.org%2C44659%2C1656232862372,2] wal.ProtobufLogReader(448): Encountered a malformed edit, seeking back to last good position in file, from 65537 to 65536 java.io.EOFException: Partial PB while reading WAL, probably an unexpected EOF, ignoring. current offset=65537 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:390) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:104) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:92) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:264) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:178) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:103) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:212) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:148) ~[classes/:?] {noformat} Actually, we should still have a lot of edits after this point. This could be a critical problem as we will hang replication forever..." Scanner timeout should take precedence over rpc timeout,13451395,Resolved,Major,Won't Fix,20/Jun/22 19:23,22/Jun/22 11:08,2.4.12,"In the new async client (see AsyncScanSingleRegionRpcRetryingCaller.call()), we ignore hbase.rpc.timeout for scanner next calls. The reason is: {quote}// As we have a call sequence for scan, it is useless to have a different rpc timeout which is // less than the scan timeout. If the server does not respond in time(usually this will not // happen as we have heartbeat now), we will get an OutOfOrderScannerNextException when // resending the next request and the only way to fix this is to close the scanner and open a // new one. {quote} In branch-2's blocking client (i.e. ClientScanner/ScannerCallable) we make use of RpcRetryingCallerImpl, which calculates the timeout for each call based on the smaller of the two: remaining operation timeout or configured rpc timeout. For scans, the operation timeout is dictated by hbase.client.scanner.timeout.period, which should take precedence over the configured rpc timeout per the above comment. We can fix this by using RpcRetryingCallerFactory.newCaller(int) in ClientScanner, passing the scanner timeout period in as the argument. " Allow configuring a separate timeout for meta scans,13447737,Resolved,Major,Fixed,31/May/22 16:35,07/Jul/22 21:16,,"There is a {{hbase.client.meta.operation.timeout}} but it does not apply to meta scans, which are the primary use-case for clients (i.e. through RegionLocator).  Many user-facing clients may want to have low rpc and scan timeouts. However, in periods of meta hotspotting, those timeouts can be way too low for the meta scans. The problem with low timeouts for meta scans is that without a populated MetaCache, user requests cannot succeed. In fact, user requests will continually try to re-scan meta until the MetaCache is populated. So having a lower rpc timeout will cause a situation where meta scans cannot succeed, and thus user requests cannot succeed. In this case I think it'd be preferable to relax the rpc timeout for meta requests so that a few long requests can unblock many faster requests. My suggestion would be to add an {{hbase.client.meta.rpc.timeout}} and ensure that it applies to meta scans. I also think it would be less confusing to have {{hbase.client.meta.operation.timeout}} apply as the scanner timeout period for meta scans." TestSeparateClientZKCluster is flaky,13469487,Resolved,Major,Fixed,30/Jun/22 15:03,08/Jul/22 06:50,,"https://nightlies.apache.org/hbase/HBase-Flaky-Tests/master/3773/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestSeparateClientZKCluster-output.txt {noformat} org.apache.hadoop.hbase.exceptions.MasterStoppedException: null at org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:3177) ~[classes/:?] at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1954) ~[classes/:?] at org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:743) ~[classes/:?] at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) ~[hbase-protocol-shaded-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:385) ~[classes/:?] at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) ~[classes/:?] at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:104) ~[classes/:?] at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:84) ~[classes/:?] {noformat} I think the problem is that, MasterStoppedException is a sub class of DoNotRetryIOException, so when hitting this issue, we will fail immediately. And the client zk syncer is asynchoronous, so it is possible that when we call admin.balance, we haven't synced the new location yet, and it will throw the MasterStoppedException out soon and fail the UT. Let me see how to fix it. " ByteBuffAllocator leak when decompressing blocks near minSizeForReservoirUse,13469509,Resolved,Major,Fixed,30/Jun/22 17:41,04/Jul/22 20:50,2.4.12,"Recently I started testing out BucketCache on some of our new hbase2 clusters. When BucketCache is enabled, it causes all disk reads to use ByteBuffAllocator in an attempt to avoid heap allocations. Without BucketCache enabled, even with ByteBuffAllocator enabled it will not be used for disk reads. At first this was amazing, we had close to 0% heap allocations which drastically reduces CPU and GC time. Over time I noticed that the ByteBuffAllocator pool filled up, and at that point all allocations come from the heap and our heap allocation % goes to 100%. We were using default max buffer count, which was 4096 for a smaller host and 7680 for a larger one. At first I figured we just needed more buffers, so I upped it to 120k. It took longer, but still eventually exhausts the pool. This does not cause an OOM, because I made sure to allocate enough direct memory for max buffer count * buffer size (65k). It just causes the usedBufCount to exceed maxBufCount, resulting in 100% heap allocations going forward. It never recovers from this state until the server is restarted. Some early observations: * Running a major compaction causes a drastic up-tick in used buffers. Major compacting a 1.5GB region could easily expand the usedBufCount by ~10,000. Most of those are never recovered. I could keep compacting the same region over and over, each time increasing the usedBufCount by 5000-15000, until max is reached. * Despite usedBufCount increasing, direct memory usage largely does not increase. This indicates to me that the DirectByteBuffers are being reclaimed by GC, but the Recycler is not being called. ** This was confirmed with a heap dump, which showed really no obvious leak in the typical sense. There were very very few DirectByteBuffers with capacity 66560. * Enabling BucketCache triggers use of ByteBuffAllocator, but I don't think it's related to the actual problem. First of all, compactions skip the cache so that would be odd. Secondly, I disabled hbase.block.data.cacheonread and all other CacheConfig, so the BucketCache is going unused (0 bytes used) and the problem still persists. Digging deeper, I instrumented ByteBuffAllocator in two ways: # I added some trace loggings in getBuffer() and putbackBuffer() so I could see the number of allocations, returns, pool size at the time, and a stacktrace. # I added netty's ResourceLeakDetector to the RefCnt class we use in ByteBuffAllocator. Calling track() on creation of a RefCnt, record() in RefCnt.retain(), and close() in RefCnt.deallocate(). The ResourceLeakDetector immediately picked up leaks on start of the regionserver. I saw leaks coming from both user requests and, as expected, the Compactor.  I collected 21 unique LEAK stacktraces, which is too many to list. But all of them had 2 common roots, so below I post a full stacktrace for 2 examples of those roots: {code:java} Created at: org.apache.hadoop.hbase.nio.RefCnt.(RefCnt.java:58) org.apache.hadoop.hbase.nio.RefCnt.create(RefCnt.java:53) org.apache.hadoop.hbase.nio.ByteBuff.wrap(ByteBuff.java:597) org.apache.hadoop.hbase.io.ByteBuffAllocator.allocate(ByteBuffAllocator.java:350) org.apache.hadoop.hbase.io.hfile.HFileBlock.allocateBuffer(HFileBlock.java:671) org.apache.hadoop.hbase.io.hfile.HFileBlock.unpack(HFileBlock.java:640) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1340) org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$CellBasedKeyBlockIndexReader.loadDataBlockWithScanInfo(HFileBlockIndex.java:331) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:679) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:631) org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.java:315) org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:216) org.apache.hadoop.hbase.regionserver.StoreScanner.seekScanners(StoreScanner.java:417) org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:257) org.apache.hadoop.hbase.regionserver.HStore.createScanner(HStore.java:2152) org.apache.hadoop.hbase.regionserver.HStore.getScanner(HStore.java:2142) org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.initializeScanners(HRegion.java:7211) org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.(HRegion.java:7191) org.apache.hadoop.hbase.regionserver.HRegion.instantiateRegionScanner(HRegion.java:3160) org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:3140) org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:3122) org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:3116) org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2657) org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:807) org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2898) org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45961) org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:392) org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:134) org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:358) org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) {code} and {code:java} Created at: org.apache.hadoop.hbase.nio.RefCnt.(RefCnt.java:58) org.apache.hadoop.hbase.nio.RefCnt.create(RefCnt.java:53) org.apache.hadoop.hbase.nio.ByteBuff.wrap(ByteBuff.java:597) org.apache.hadoop.hbase.io.ByteBuffAllocator.allocate(ByteBuffAllocator.java:350) org.apache.hadoop.hbase.io.hfile.HFileBlock.allocateBuffer(HFileBlock.java:671) org.apache.hadoop.hbase.io.hfile.HFileBlock.unpack(HFileBlock.java:640) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1340) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.readAndUpdateNewBlock(HFileReaderImpl.java:968) org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:957) org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.java:322) org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:216) org.apache.hadoop.hbase.regionserver.StoreScanner.seekScanners(StoreScanner.java:417) org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:324) org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:290) org.apache.hadoop.hbase.regionserver.compactions.Compactor.createScanner(Compactor.java:513) org.apache.hadoop.hbase.regionserver.compactions.Compactor$1.createScanner(Compactor.java:254) org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:333) org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:65) org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:126) org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1510) org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2390) org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:617) org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:659) java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) java.base/java.lang.Thread.run(Thread.java:829) {code} My trace logging gave some insight as well: * It showed very similar stacktraces to above for the allocations * It also confirmed that we are indeed returning many buffers to the pool, coming from calls to Shipper.shipped() in Compactor and ServerCall.setResponse for user requests. * However, the count allocations vs returns further validated the leak. We might have 150k allocations but only 140k returns (as an example). * Similarly, the pool size (buffers.size()) was always less than 1000, sometimes close to 0. Once the usedBufCount > maxBufCount, the pool size shrinks to 0 and stays at 0 forever. Things I've tried: * I've been pouring over the stacktraces, trying to see how we might leak. Certainly we do some extra allocations when unpacking compressed blocks, but it seems like we always release one. I also tried picking through from bottom to top, trying to trace that we're closing everything and it seems like we are. This code is complicated though so I easily could have missed something. * I tried setting COMPRESSION => NONE and compacting a region in that table, it still caused a massive expansion/leak of buffers. * We don't fully use cell block encoding, and I wondered if there were some assumptions about that in regards to when the blocks are released in ServerCall. I enabled cell block encoding for all clients of a cluster and the leak still occurred. It's worth noting our client is version 1.2, which doesn't support cell block encoding for plain Gets. So we aren't fully enabled, but I read through the ServerCall code and it seems like we don't make assumptions. I've tried digging into the stacktraces above and haven't yet found an obvious leak. I tried turning setting COMPRESSION => NONE, but compacting a region in that table still causes a massive leak." disable_peer stuck,13469096,Open,Major,,29/Jun/22 12:29,,,"!image-2022-06-29-20-30-53-545.png!   hbase(main):001:0> list_procedures  PID Name State Submitted Last_Update Parameters  201155 org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure SUCCESS 2022-06-29 17:38:26 +0800 2022-06-29 17:38:29 +0800 [\{""peerId""=>""circe_to_phoebe"", ""type""=>""DISABLE_PEER"", ""targetServer""=>{""hostName""=>""htyd-circe-11-13-109-241.hadoop.jd.local"", ""port""=>16020, ""startCode""=>""1650537882474""}}]  201154 org.apache.hadoop.hbase.master.replication.DisablePeerProcedure WAITING 2022-06-29 17:38:26 +0800 2022-06-29 17:38:26 +0800 [\{""state""=>[1, 2, 3, 8]}, \{""peerId""=>""circe_to_phoebe""}, {}]  201159 org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure RUNNABLE 2022-06-29 17:38:26 +0800 2022-06-29 17:38:26 +0800 [\{""peerId""=>""circe_to_phoebe"", ""type""=>""DISABLE_PEER"", ""targetServer""=>{""hostName""=>""hostname1"", ""port""=>16020, ""startCode""=>""1650537882461""}}]  201158 org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure RUNNABLE 2022-06-29 17:38:26 +0800 2022-06-29 17:38:26 +0800 [\{""peerId""=>""circe_to_phoebe"", ""type""=>""DISABLE_PEER"", ""targetServer""=>{""hostName""=>""hostname2"", ""port""=>16020, ""startCode""=>""1650537882485""}}]  201157 org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure SUCCESS 2022-06-29 17:38:26 +0800 2022-06-29 17:38:30 +0800 [\{""peerId""=>""circe_to_phoebe"", ""type""=>""DISABLE_PEER"", ""targetServer""=>{""hostName""=>""hostname3"", ""port""=>16020, ""startCode""=>""1650537882484""}}]  201156 org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure SUCCESS 2022-06-29 17:38:26 +0800 2022-06-29 17:38:29 +0800 [\{""peerId""=>""circe_to_phoebe"", ""type""=>""DISABLE_PEER"", ""targetServer""=>{""hostName""=>""hostname4"", ""port""=>16020, ""startCode""=>""1650537882482""}}] RS jstack :   !image-2022-06-29-20-53-32-300.png! !image-2022-06-29-20-54-37-919.png!  " Build against Hadoop 3.3.3,13447096,Resolved,Major,Fixed,26/May/22 21:19,27/May/22 21:05,2.5.0,"When building against Hadoop 3.3.3 and any future version of Hadoop incorporating reload4j, the new Enforcer rule we have active in branch-2.5 and up to exclude other logging frameworks besides log4j2 will trigger. We need to add exclusions to prevent that from happening so the build will succeed. Tested with {{mvn clean install assembly:single -DskipTests -Dhadoop-three.version=3.3.3}} on master branch and with {{mvn clean install assembly:single -DskipTests -Dhadoop.profile=3.0 -Dhadoop-three.version=3.3.3}} on branch-2.5. I also needed to exclude leveldbjni-all via hadoop-hdfs to avoid a LICENSE file generation error. hadoop-hdfs is messy and exports this among findbugs and other clutter. Anyway, better to exclude something we do not require than add an unnecessary supplemental model. " Put up 3.0.0-alpha-3RC0,13450158,Resolved,Major,Fixed,15/Jun/22 07:43,27/Jun/22 14:53,, The CPU usage of the regionserver node where the meta table is located is too high,13442071,Reopened,Major,,27/Apr/22 12:21,,2.3.4,"When the read and write pressure is high, the CPU usage of the meta table node is too high !image-2022-04-28-09-59-40-567.png!   !image-2022-04-27-20-24-33-252.png!" ClientZKSyncer.deleteDataForClientZkUntilSuccess should break from the loop when deletion is succeeded,13468390,Resolved,Major,Fixed,25/Jun/22 08:49,26/Jun/22 07:33,,"https://nightlies.apache.org/hbase/HBase-Flaky-Tests/master/3745/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.TestSeparateClientZKCluster-output.txt {noformat} 2022-06-25T04:53:00,316 DEBUG [ClientZKUpdater-/hbase/meta-region-server-1] zksyncer.ClientZKSyncer(200): Failed to delete node from client ZK, will retry later org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/meta-region-server-1 at org.apache.zookeeper.KeeperException.create(KeeperException.java:118) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:1793) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:210) ~[hbase-zookeeper-3.0.0-alpha-3.jar:3.0.0-alpha-3] at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:851) ~[hbase-zookeeper-3.0.0-alpha-3.jar:3.0.0-alpha-3] at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:843) ~[hbase-zookeeper-3.0.0-alpha-3.jar:3.0.0-alpha-3] at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer.deleteDataForClientZkUntilSuccess(ClientZKSyncer.java:198) ~[classes/:?] at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer.access$400(ClientZKSyncer.java:45) ~[classes/:?] at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer$ClientZkUpdater.run(ClientZKSyncer.java:318) ~[classes/:?] {noformat} Not sure if this is the root cause of the flakiness but at least it messes up the output, let's fix it first." Avoid CellUtil.cloneRow in MetaCellComparator,13454575,Resolved,Major,Fixed,21/Jun/22 13:24,24/Jun/22 14:43,,"In HBASE-26981, a flame graph shows that we spend a lot of CPUs in CellUtils.cloneXXX. Since we need to split the row to different parts when comparing, we can not use ByteBuffer compare directly, but as least, we should try to avoid copy the content when the Cell is stored in a ByteBuffer." Make Netty channel bytebuf allocator configurable,13449684,Resolved,Major,Fixed,12/Jun/22 17:47,23/Jun/22 22:25,2.5.0,"Netty supports different strategies for allocating byte buffers for IO and channel modules. We do not allow the site operator to fine tune this but could. It would be particularly useful to allow preference of heap buffers where direct memory may be limited or utilized for other purposes. Support site configuration of the bytebuf allocator that Netty will use for NettyRpcServer channels. Property name is 'hbase.netty.rpcserver.allocator'. Default is no value, which is equivalent to ""pooled"". Valid values are: - ""pooled"": use PooledByteBufAllocator - ""unpooled"": use UnpooledByteBufAllocator - ""heap"": use HeapByteBufAllocator, which is a PooledByteBufAllocator that preferentially allocates buffers on heap wherever possible - : If the value is none of the recognized labels, treat it as a class name implementing org.apache.hbase.thirdparty.io.netty.buffer.ByteBufAllocator. This allows the user to add a custom implementation, perhaps for debugging." TestMultiRespectsLimits.testBlockMultiLimits repeatable failure,13458948,Resolved,Major,Fixed,23/Jun/22 03:02,23/Jun/22 03:09,2.4.12,"[ERROR] org.apache.hadoop.hbase.client.TestMultiRespectsLimits.testBlockMultiLimits Time elapsed: 1.414 s <<< FAILURE! java.lang.AssertionError: exceptions (0) should be greater than 0 at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.assertTrue(Assert.java:42) at org.apache.hadoop.hbase.test.MetricsAssertHelperImpl.assertCounterGt(MetricsAssertHelperImpl.java:191) at org.apache.hadoop.hbase.client.TestMultiRespectsLimits.testBlockMultiLimits(TestMultiRespectsLimits.java:185) A git bisect identified HBASE-26856 as the cause." [hbase-thirdparty] Release hbase-thirdparty 4.1.1,13450732,Resolved,Major,Fixed,18/Jun/22 10:56,24/Jun/22 02:28,, [hbase-thirdparty] Set version as 4.1.2-SNAPSHOT in prep for the next release,13450745,Resolved,Major,Fixed,18/Jun/22 12:46,24/Jun/22 02:28,, Remove otel agent,13463038,Open,Major,,23/Jun/22 20:16,,,"Our tracing implementation doesn’t make any use of runtime reflection or auto-instrumentation, which means that I think we don’t need to jvm agent involved. All it *might* be doing for us is instrumenting Jersey or something like that. We should investigate if this is really necessary/useful." Remove ThreadPool in HBaseInterClusterReplicationEndpoint when use AsyncClusterConnection,13446778,Resolved,Major,Fixed,25/May/22 11:45,22/Jun/22 12:03,3.0.0-alpha-2,"For master branch, {{HBaseInterClusterReplicationEndpoint}} has already to use {{AsyncClusterConnection}} to send to peer cluster, but it still use {{ThreadPoolExecutor}} to call {{AsyncRegionServerAdmin.replicateWALEntry}} synchronously, I think we could remove the {{ThreadPoolExecutor}} and call {{AsyncRegionServerAdmin.replicateWALEntry}} using asynchronous style." TestMultiRespectsLimits consistently failing,13458626,Resolved,Major,Duplicate,22/Jun/22 18:31,23/Jun/22 17:44,2.4.12,"TestMultiRespectsLimits#testBlockMultiLimits is consistently failing: {code:java} Error Messageexceptions (0) should be greater than 0Stacktracejava.lang.AssertionError: exceptions (0) should be greater than 0 at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.assertTrue(Assert.java:42) at org.apache.hadoop.hbase.test.MetricsAssertHelperImpl.assertCounterGt(MetricsAssertHelperImpl.java:191) at org.apache.hadoop.hbase.client.TestMultiRespectsLimits.testBlockMultiLimits(TestMultiRespectsLimits.java:185) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) {code} Reports: [https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/branch-2.4/3377/testReport/junit/org.apache.hadoop.hbase.client/TestMultiRespectsLimits/testBlockMultiLimits/] [https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/branch-2.4/3378/testReport/junit/org.apache.hadoop.hbase.client/TestMultiRespectsLimits/testBlockMultiLimits/] [https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/branch-2.4/3376/testReport/junit/org.apache.hadoop.hbase.client/TestMultiRespectsLimits/testBlockMultiLimits/]  " Add hbase-unsafe as a dependency for a MR job triggered by hbase shell,13453445,Resolved,Major,Fixed,21/Jun/22 06:32,21/Jun/22 20:44,2.4.13,"After HBASE-26523, the use of hbase-thirdparty 4.1.0 introduced an new dependency of hbase-unsafe that wasn't added as part of the MR job triggered by hbase-shell. As such, class not found exception was being emitted when executing in distributed mode. {code} 22/06/21 04:57:15 INFO mapreduce.Job: Task Id : attempt_1655784404826_0011_m_000000_0, Status : FAILED Error: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.unsafe.HBasePlatformDependent at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) at org.apache.hadoop.hbase.util.Bytes.(Bytes.java:129) at org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Generator$GeneratorMapper.setup(IntegrationTestBigLinkedList.java:455) at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:143) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:799) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:347) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:174) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/javax.security.auth.Subject.doAs(Subject.java:423) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:168) {code} This task will add it back as part of the job configuration handled by hbase internally in addHBaseDependencyJars" [hbase-thirdparty] Put up 4.1.1RC0,13450735,Resolved,Major,Fixed,18/Jun/22 10:58,22/Jun/22 10:44,, [HBCK2] Some commands are broken after HBASE-24587,13450053,Resolved,Major,Fixed,14/Jun/22 15:13,21/Jun/22 15:30,,"HBCK2 _replication_ and _filesystem_ commands are broken after HBASE-24587. Trying to pass the _-f_ or _--fix_ options give the below error: {noformat} ERROR: Unrecognized option: -f FOR USAGE, use the -h or --help option 2022-06-14T16:07:32,296 INFO [main] client.ConnectionImplementation: Closing master protocol: MasterService Exception in thread ""main"" java.lang.NullPointerException at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:1083) at org.apache.hbase.HBCK2.run(HBCK2.java:982) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at org.apache.hbase.HBCK2.main(HBCK2.java:1318) {noformat} This is because _getInputList_ calls [here|https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java#L1073] and [here|https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java#L1082] only accept the _-i_/_--inputFiles_, throwing an exception if we pass _-f/--fix_ options. Still need to confirm if any other command is affected by this." Mark ByteBufferUtils as IA.Private,13454569,Resolved,Major,Duplicate,21/Jun/22 12:59,21/Jun/22 13:03,,"As the javadoc says {code} /** * Utility functions for working with byte buffers, such as reading/writing variable-length long * numbers. * @deprecated This class will become IA.Private in HBase 3.0. Downstream folks shouldn't use it. */ {code}" [hbase-thirdparty] Set version as 4.1.1 in master in prep for first RC of 4.1.1,13450733,Resolved,Major,Fixed,18/Jun/22 10:57,18/Jun/22 13:26,, [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 4.1.1,13450734,Resolved,Major,Fixed,18/Jun/22 10:57,18/Jun/22 13:26,, [hbase-thirdparty] Bump checkstyle from 8.28 to 8.29 in /hbase-noop-htrace,13450731,Resolved,Major,Fixed,18/Jun/22 10:53,18/Jun/22 10:54,, [hbase-thirdparty] Bump junit from 4.12 to 4.13.1 in /hbase-noop-htrace,13450730,Resolved,Major,Fixed,18/Jun/22 10:49,18/Jun/22 10:51,, [hbase-thirdparty] Bump dependency versions,13450618,Resolved,Major,Fixed,17/Jun/22 13:25,18/Jun/22 10:46,, [hbase-thirdparty] Bump checkstyle from 8.28 to 8.29 in /hbase-unsafe,13450728,Resolved,Major,Fixed,18/Jun/22 10:41,18/Jun/22 10:44,, Improvement of the pause time between retries in Rpc caller,13439739,Open,Major,,15/Apr/22 01:35,,2.4.2,"We were using the HBase version 2.4.2 and had clients submitting requests to a HBase cluster. We observed an unreasonable delay of 10 seconds in some request of table create. We analyze the log and jstack results and reproduce this issue. The jstack of the client shows that this wierd long delay comes from [https://github.com/apache/hbase/blob/rel/2.4.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java#L168] : {code:java} ""main"" #1 prio=5 os_prio=0 tid=0x00007f027c00b800 nid=0x530d in Object.wait() [0x00007f02853b1000]    java.lang.Thread.State: TIMED_WAITING (on object monitor)         at java.lang.Object.wait(Native Method)         - waiting on <0x00000003d52674f0> (a java.util.concurrent.atomic.AtomicBoolean)         at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:168)         - locked <0x00000003d52674f0> (a java.util.concurrent.atomic.AtomicBoolean)         at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3018)         at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3010)         at org.apache.hadoop.hbase.client.HBaseAdmin.createTableAsync(HBaseAdmin.java:648)         at org.apache.hadoop.hbase.client.HBaseAdmin.createTableAsync(HBaseAdmin.java:4326)         at org.apache.hadoop.hbase.client.Admin.createTable(Admin.java:317)         at edu.jhu.order.mcgray.hb_2_4_2.HBaseGrayClient.createTable(HBaseGrayClient.java:63)         at edu.jhu.order.mcgray.hb_2_4_2.HBaseGrayClientMain.create(HBaseGrayClientMain.java:70)         at edu.jhu.order.mcgray.hb_2_4_2.HBaseGrayClientMain.run(HBaseGrayClientMain.java:157)         at edu.jhu.order.mcgray.hb_2_4_2.HBaseGrayClientMain.main(HBaseGrayClientMain.java:183) {code} This delay of wait comes from the calculation within [https://github.com/apache/hbase/blob/rel/2.4.2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java#L96-L177] , which can be simplified as follows: {code:java} public T callWithRetries(RetryingCallable callable, int callTimeout)   throws IOException, RuntimeException {     // ...     for (int tries = 0;; tries++) {       long expectedSleep;       try {         // do the call ...       } catch (PreemptiveFastFailException e) {         throw e;       } catch (Throwable t) {         ExceptionUtil.rethrowIfInterrupt(t);         Throwable cause = t.getCause();         if (cause instanceof DoNotRetryIOException) {  // line 113           // Fail fast           throw (DoNotRetryIOException) cause;         }         // translateException throws exception when should not retry: i.e. when request is bad.         interceptor.handleFailure(context, t);         t = translateException(t);         if (tries > startLogErrorsCnt) {           // log ...         }         // ...         // If the server is dead, we need to wait a little before retrying, to give         // a chance to the regions to be moved         // get right pause time, start by RETRY_BACKOFF[0] * pauseBase, where pauseBase might be         // special when encountering CallQueueTooBigException, see #HBASE-17114         long pauseBase = (t instanceof CallQueueTooBigException) ? pauseForCQTBE : pause;  // line 151         expectedSleep = callable.sleep(pauseBase, tries); //  line 152         // If, after the planned sleep, there won't be enough time left, we stop now.         long duration = singleCallDuration(expectedSleep);         if (duration > callTimeout) {           // throw exception ...         }       } finally {         interceptor.updateFailureInfo(context);       }       try {         if (expectedSleep > 0) {           synchronized (cancelled) {             if (cancelled.get()) return null;             cancelled.wait(expectedSleep);  // line 168           }         }         if (cancelled.get()) return null;       } catch (InterruptedException e) {         throw new InterruptedIOException(""Interrupted after "" + tries             + "" tries while maxAttempts="" + maxAttempts);       }     }   } {code} Within the retry loop, the `cause` variable represents the reason for the current failed request and it is checked to determine what we should do. For example, the case of DoNotRetryIOException is checked at line 113, and the case of CallQueueTooBigException is checked at line 151. Finally we determine `expectedSleep`, the time we should wait before the next retry. And then we enforce this wait at line 168, unless it is canceled. The comments seems to imply that this retry is due to dead server: {code:java}       // If the server is dead, we need to wait a little before retrying, to give         // a chance to the regions to be moved         // get right pause time, start by RETRY_BACKOFF[0] * pauseBase, where pauseBase might be         // special when encountering CallQueueTooBigException, see #HBASE-17114         long pauseBase = (t instanceof CallQueueTooBigException) ? pauseForCQTBE : pause;  // line 151         expectedSleep = callable.sleep(pauseBase, tries); //  line 152 {code} However, the client log shows that some retries are not due to dead server: {code:java} 2022-04-10 15:44:44,146 INFO  [main] client.RpcRetryingCallerImpl: Call exception, tries=6, retries=16, started=4858 ms ago, cancelled=false, msg=org.apache.hadoop.hbase.PleaseHoldException: Master is initializing         at org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:2729)         at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1985)         at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:705)         at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) , details=, see https://s.apache.org/timeout 2022-04-10 15:44:48,181 INFO  [main] client.RpcRetryingCallerImpl: Call exception, tries=7, retries=16, started=8893 ms ago, cancelled=false, msg=java.io.IOException: java.io.IOException: IOException         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:463)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) Caused by: java.io.UncheckedIOException: java.io.IOException: IOException         at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.lambda$update$7(RegionProcedureStore.java:377)         at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.runWithoutRpcCall(RegionProcedureStore.java:313)         at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.update(RegionProcedureStore.java:364)         at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.insert(RegionProcedureStore.java:323)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:1047)         at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil$NonceProcedureRunnable.submitProcedure(MasterProcedureUtil.java:107)         at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2010)         at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134)         at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1997)         at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:705)         at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395)         ... 3 more Caused by: java.io.IOException: IOException         at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.lambda$update$7(RegionProcedureStore.java:370)         ... 14 more , details=, see https://s.apache.org/timeout 2022-04-10 15:44:58,835 INFO  [main] client.HBaseAdmin: Operation: CREATE, Table Name: default:t4, procId: 22 completed {code} The client has some retries due to dead server (PleaseHoldException: Master is initializing), and then gets some internal error when creating the table and finally gets the table created successfully. We understand that the waiting time for each retry increases exponentially as the retry number grows, according to the retry backoff mechanism. However, since the comments before line 151 does not specify how we should determine the retry pause time, we suspect that the retry time after the successful server startup should be considered separately, regardless of the time used for waiting for server startup. To confirm this hypothesis, we find some RPC retry call implementations in the same version (2.4.2) of HBase: [https://github.com/apache/hbase/blob/rel/2.4.2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RemoteProcedureResultReporter.java#L95-L111] and [https://github.com/apache/hbase/blob/rel/2.4.2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L2453-L2475] . For example, in RemoteProcedureResultReporter, the retry time is calculated separately, after the server startup: {code:java}  while (!server.isStopped()) {       // ...       try {         server.reportProcedureDone(builder.build());         builder.clear();         tries = 0;       } catch (IOException e) {         boolean pause =           e instanceof ServerNotRunningYetException || e instanceof PleaseHoldException;         long pauseTime;         if (pause) {           // Do backoff else we flood the Master with requests.           pauseTime = ConnectionUtils.getPauseTime(INIT_PAUSE_TIME_MS, tries);         } else {           pauseTime = INIT_PAUSE_TIME_MS; // Reset.         }         LOG.info(""Failed procedure report "" + TextFormat.shortDebugString(request) + ""; retry (#"" +           tries + "")"" + (pause ? "" after "" + pauseTime + ""ms delay (Master is coming online...).""             : "" immediately.""),           e);         Threads.sleep(pauseTime);         tries++;       }     } {code} Similarly, we suspect RpcRetryingCallerImpl should consider ServerNotRunningYetException and PleaseHoldException in this way. We followed this thought to write a fix and found that the symptom no longer exists. We had tested this issue and the fix in version 2.4.2 and 2.4.11 and 3.0.0-alpha-2. We believe this issue exists in these versions and our fix is applicable to these versions. P.S. In the latest version (3.0.0-alpha-2), RpcRetryingCallerImpl no longer exists. The issue and fix is applied to AsyncRpcRetryingCaller instead." Set version as 3.0.0-alpha-3 in master in prep for first RC of 3.0.0-alpha-3,13450056,Resolved,Major,Fixed,14/Jun/22 15:57,15/Jun/22 07:43,, TestMultiRespectsLimits.testBlockMultiLimits is flaky,13450064,Open,Major,,14/Jun/22 16:33,,,This test case failed twice in the pre-commit [jdk8|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4493/7/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt] and [jdk11|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4493/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt] checks for PR-4493 HBase site generation should use its own JRuby,13449584,Resolved,Major,Fixed,11/Jun/22 05:26,13/Jun/22 08:49,,"The maven plugin we use to generate the reference guide, {{asciidoctor-maven-plugin}}, does not yet work with JRuby 9.3. Due to a dependency error we currently get a mix of JRuby 9.2 and 9.3 libraries when building the site goal, which fails without an actionable error message. Correcting the dependency to consistently get JRuby 9.3 also results in failure, but due to gem resolution. We originally started overriding the JRuby version to get Aarch64 support. The version that ships with the plugin has this support already. Falling back to JRuby 9.2 for the plugin will mean our reference guide building won't work on M1 systems, but I don't see how we can change that until the plugin updates for JRuby 9.3 changes." [JDK11] Support JDK11 LTS in HBase Connectors,13449818,Open,Major,,13/Jun/22 14:14,,,It seems that we also have some work to do in the hbase-connectors repo. Add spotless:check in mvn verify stage,13448128,Resolved,Major,Won't Fix,02/Jun/22 12:36,11/Jun/22 16:14,,"So mvn install will fail if we violate the format rules, which will make developer pay more attention on fixing the format issue." Vacate the .idea folder in order to simplify spotless configuration,13449192,Resolved,Major,Fixed,09/Jun/22 09:56,10/Jun/22 13:59,2.4.12,"Per discussion on HBASE-27096, spotless configuration is a bit ham-handed. We can simplify its maintenance by ignoring entirely the {{.idea}} directory. Since committing project files there is not workable at the moment, the only functionality present there is {{checkstyle-idea.xml}}. Let's move that to {{dev-support}} and update the book accordingly." HbckChore should produce a report,13448812,Resolved,Major,Fixed,07/Jun/22 13:53,10/Jun/22 13:47,2.4.12,"In the PR for HBASE-26192, it was noted that the HbckChore is kind of a pain to use and test because it maintains a bunch of local state. By contract, the CatalogJanitorChore makes a nice self-contained report. Let's update HbckChore to do the same." Upgrade JRuby to 9.3.4.0,13442084,Resolved,Major,Fixed,27/Apr/22 13:19,11/Jun/22 05:28,2.4.11,"Hbase shell is failing to start on Apple M1 OSX ARM 64 processor architecture. *Error:* {code} Version 2.4.11, r7e672a0da0586e6b7449310815182695bc6ae193, Tue Mar 15 10:31:00 PDT 2022 Took 0.0010 seconds NotImplementedError: fstat unimplemented unsupported or native support failed to load; see https://github.com/jruby/jruby/wiki/Native-Libraries   initialize at org/jruby/RubyIO.java:1015         open at org/jruby/RubyIO.java:1156   initialize at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/input-method.rb:141   initialize at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/context.rb:70   initialize at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:410   initialize at uri:classloader:/irb/hirb.rb:49      
at classpath:/jar-bootstrap.rb:223 {code}   {*}Uname output{*}: {code} Darwin vijays-mbp.lan 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64 {code}" The Region Visualizer display failed,13447144,Resolved,Major,Fixed,27/May/22 06:22,09/Jun/22 11:10,2.5.0,"The `Region Visualizer` display failed. Because the active master hostname is `localhost`. Before the change: !image-2022-05-27-14-22-44-336.png|width=520,height=162! After the change: !image-2022-05-27-14-22-29-015.png|width=562,height=229!" graceful_stop cannot take previous balancer status by incompatibility of hbase shell prompt,13448318,Open,Major,,03/Jun/22 11:01,,2.4.10,"{code:java} graceful_stop.sh --failfast $(hostname -f) 2022-06-03T20:04:34 Set failfast, will exit immediately if any command exits with non-zero status 2022-06-03T20:04:34 Disabling load balancer 2022-06-03T20:04:42 Previous balancer state was hbase:002:0> 2022-06-03T20:04:42 Unloading myregionserver.example.com region(s) 2022-06-03T20:04:46 Unloaded myregionserver.example.com region(s) 2022-06-03T20:04:46 Stopping regionserver on myregionserver.example.com running regionserver, logging to /var/log/hbase/hbase-hbase-regionserver.out stopping regionserver. 2022-06-03T20:04:47 Restoring balancer state to hbase:002:0> {code} You can see wrong previous balancer state {code:java} 2022-06-03T20:04:42 Previous balancer state was hbase:002:0> {code} this should be either of true or false, but it's ""hbase:002:0>"" This is because of the incompatibility of hbase shell prompt behavior. graceful_stop perform `echo 'balance_switch false' | ""$bin""/hbase --config ""${HBASE_CONF_DIR}"" shell -n | tail -1` https://github.com/apache/hbase/blob/d57159f31cb7be4d9ced0d7b95e2c78c43d160a1/bin/graceful_stop.sh#L118 However, hbase shell now always set prompt mode to CUSTOM. https://github.com/apache/hbase/blob/d57159f31cb7be4d9ced0d7b95e2c78c43d160a1/hbase-shell/src/main/ruby/jar-bootstrap.rb#L206 (this breaking change is introduced in https://github.com/apache/hbase/pull/4018 in hbase2.4.10, https://issues.apache.org/jira/browse/HBASE-26469) So the prompt is always shown even when `hbase shell -n` or just piping stdin. {code:java} $ echo ""balance_switch false"" | hbase shell HBase Shell Use ""help"" to get list of supported commands. Use ""exit"" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell Version 2.4.12-xxx Took 0.0022 seconds hbase:001:0> balance_switch false Previous balancer state : false Took 0.4308 seconds => false hbase:002:0> $ echo ""balance_switch false"" | hbase shell -n hbase:001:0> balance_switch false Previous balancer state : false Took 0.5207 seconds => false hbase:002:0> {code} This is incompatible from old version. {code:java} hbase 1.4.x version: $ echo ""balance_switch false"" | hbase shell HBase Shell Use ""help"" to get list of supported commands. Use ""exit"" to quit this interactive shell. Version 1.4.13-xxx balance_switch false false 0 row(s) in 0.3310 seconds $ echo ""balance_switch false"" | hbase shell -n false 0 row(s) in 0.4240 seconds nil {code} {code:java} hbase-2.4.9 $ echo ""balance_switch false"" | bin/hbase shell -n Previous balancer state : false Took 0.4340 seconds false {code} (TODO check old hbase-2 case) In old version, :NULL is used for prompt_mode {code:java} $ echo ""irb_context.prompt_mode"" | hbase shell HBase Shell Use ""help"" to get list of supported commands. Use ""exit"" to quit this interactive shell. Version 1.4.13-xxx irb_context.prompt_mode :NULL {code} But it's now :CUSTOM {code:java} $ echo ""irb_context.prompt_mode"" | hbase shell HBase Shell Use ""help"" to get list of supported commands. Use ""exit"" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell Version 2.4.12-xxx Took 0.0028 seconds hbase:001:0> irb_context.prompt_mode => :CUSTOM hbase:002:0> {code} We should keep using NULL prompt_mode for such case respecting previous behavior?" Regionserver table on Master UI is broken,13448601,Resolved,Major,Fixed,06/Jun/22 14:09,08/Jun/22 00:40,3.0.0-alpha-2,"Playing around with pseudo-distributed mode, I see that we've broken the region servers table." AsyncNonMetaRegionLocator：put Complete CompletableFuture outside lock block,13448685,Resolved,Major,Fixed,07/Jun/22 03:02,07/Jun/22 04:26,2.4.12,"  {code:java} synchronized (tableCache) { tableCache.pendingRequests.remove(req); // fail the request itself, no matter whether it is a DoNotRetryIOException, as we have // already retried several times CompletableFuture future = tableCache.allRequests.remove(req); if (future != null) { future.completeExceptionally(error); } tableCache.clearCompletedRequests(null); // Remove a complete locate request in a synchronized block, so the table cache must have // quota to send a candidate request. toSend = tableCache.getCandidate(); toSend.ifPresent(r -> tableCache.send(r)); } {code} Complete or completeExceptionally in a lock block may cause deadlock. We can put this action outside the lock block to avoid deadlock.  " Terminating standalone process is slow,13448554,Open,Major,,06/Jun/22 10:11,,3.0.0-alpha-2,"Run hbase in standalone mode off of master, terminate the process with ^C. The process takes its sweet time to terminate. Luckily, we have some thread management utility code to inspect this behavior. Jetty takes a little time to shutdown, but does eventually. More problematic is the ZooKeeper client, which appears to not take a hint. In fact, the client attempts to initiate new connections to a service which has already been terminated, making matters worse. {noformat} 2022-06-06T11:59:36,137 INFO [main] util.Threads: Non daemon thread SessionTracker is still alive 2022-06-06T11:59:36,137 INFO [main] util.Threads: java.base@11.0.11/java.lang.Thread.sleep(Native Method) app//org.apache.zookeeper.server.SessionTrackerImpl.run(SessionTrackerImpl.java:151) 2022-06-06T11:59:36,137 INFO [main] util.Threads: Non daemon thread RS:0;192.168.178.157:16020 is still alive 2022-06-06T11:59:36,137 INFO [main] util.Threads: java.base@11.0.11/java.lang.Object.wait(Native Method) java.base@11.0.11/java.lang.Object.wait(Object.java:328) app//org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1529) app//org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1512) app//org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:1791) app//org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:210) app//org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:851) app//org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:843) app//org.apache.hadoop.hbase.regionserver.HRegionServer.deleteMyEphemeralNode(HRegionServer.java:1453) app//org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:969) java.base@11.0.11/java.lang.Thread.run(Thread.java:829) 2022-06-06T11:59:36,137 INFO [main] util.Threads: Non daemon thread Thread-2 is still alive 2022-06-06T11:59:36,138 INFO [main] util.Threads: java.base@11.0.11/jdk.internal.misc.Unsafe.park(Native Method) java.base@11.0.11/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:234) java.base@11.0.11/java.util.concurrent.FutureTask.awaitDone(FutureTask.java:444) java.base@11.0.11/java.util.concurrent.FutureTask.get(FutureTask.java:203) app//org.apache.hadoop.util.ShutdownHookManager.executeShutdown(ShutdownHookManager.java:124) app//org.apache.hadoop.util.ShutdownHookManager$1.run(ShutdownHookManager.java:95) 2022-06-06T11:59:36,392 INFO [SessionTracker] server.SessionTrackerImpl: SessionTrackerImpl exited loop! 2022-06-06T11:59:36,442 INFO [main-SendThread(127.0.0.1:2181)] zookeeper.ClientCnxn: Opening socket connection to server localhost/127.0.0.1:2181. Will not attempt to authenticate using SASL (unknown err or) 2022-06-06T11:59:36,442 INFO [main-SendThread(127.0.0.1:2181)] zookeeper.ClientCnxn: Socket error occurred: localhost/127.0.0.1:2181: Connection refused {noformat} Full session in the attached log." SecureBulkLoadManager will set wrong permission if umask too strict,13442210,Resolved,Major,Fixed,28/Apr/22 03:53,02/Jun/22 22:31,2.4.11,"SecureBulkLoadManager will create baseStagingDir if not exist. start method use  fs.mkdirs(baseStagingDir, PERM_HIDDEN); to create directory with permission -rwx–x–x.BUT if umask is too strict such as 077 ,this directory will create with 0700 so it too strict for GROUP and OTHER user to own execute permission" Make the new framework for region replication could work for SKIP_WAL,13442603,Resolved,Major,Fixed,30/Apr/22 03:54,04/Jun/22 03:08,3.0.0-alpha-2,"For now , the new region replication framework introduced by HBASE-26233 could not work for table which {{DURABILITY}} is {{Durability.SKIP_WAL}}, but the framework does not build on WAL replication, so it should also work for SKIP_WAL, and besides table could be SKIP_WAL, the individual {{Mutation}} could also be SKIP_WAL. " Display the region server state on the Web UI,13445013,Resolved,Major,Fixed,15/May/22 13:14,02/Jun/22 13:38,,"Display the region server state on the Web UI. !image-2022-05-18-14-39-44-208.png|width=729,height=126!" Add protobuf to NOTICE file,13444349,Resolved,Major,Fixed,11/May/22 08:44,02/Jun/22 12:27,,"The spotless formatting removed the protobuf credit from the AbstractByteRange. It is currently not included in the NOTICE file. https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52" Client integration test is failing on branch-2.x,13443661,Resolved,Major,Fixed,06/May/22 15:03,03/Jun/22 12:42,,"It is because we can not start hadoop cluster. The error is {noformat} 22/05/05 20:04:18 INFO service.AbstractService: Service HistoryClientService failed in state STARTED; cause: org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested address; For more details see: http://wiki.apache.org/hadoop/BindException org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested address; For more details see: http://wiki.apache.org/hadoop/BindException at org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:138) at org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC.getServer(HadoopYarnProtoRPC.java:65) at org.apache.hadoop.yarn.ipc.YarnRPC.getServer(YarnRPC.java:54) at org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.serviceStart(HistoryClientService.java:128) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) at org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121) at org.apache.hadoop.mapreduce.v2.hs.JobHistoryServer.serviceStart(JobHistoryServer.java:202) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster$JobHistoryServerWrapper$1.run(MiniMRYarnCluster.java:236) Caused by: java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested address; For more details see: http://wiki.apache.org/hadoop/BindException at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:824) at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:735) at org.apache.hadoop.ipc.Server.bind(Server.java:615) at org.apache.hadoop.ipc.Server$Listener.(Server.java:1179) at org.apache.hadoop.ipc.Server.(Server.java:2983) at org.apache.hadoop.ipc.RPC$Server.(RPC.java:1003) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server.(ProtobufRpcEngine.java:425) at org.apache.hadoop.ipc.ProtobufRpcEngine.getServer(ProtobufRpcEngine.java:346) at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:844) at org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.createServer(RpcServerFactoryPBImpl.java:168) at org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:131) ... 8 more Caused by: java.net.BindException: Cannot assign requested address at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:438) at sun.nio.ch.Net.bind(Net.java:430) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:225) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at org.apache.hadoop.ipc.Server.bind(Server.java:598) ... 16 more {noformat} https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/534/artifact/output-integration/hadoop-2/hadoop_cluster_command.err/*view*/" Run spotless:apply in release scripts when we want to commit something,13448125,Open,Major,,02/Jun/22 12:32,,, NPE occurs when the active master has not yet been elected,13447349,Resolved,Major,Fixed,29/May/22 02:09,31/May/22 18:51,,"When the active master has not yet been elected. We access the master web UI, a NPE will be thrown out. Assertion is now added, but assertion in production is disabled by default. We can use `Preconditions` instead.   Before the change: !image-2022-05-29-10-08-21-637.png|width=268,height=256!   After the change: !image-2022-05-29-10-08-49-672.png|width=263,height=255!" Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped,13446408,Resolved,Major,Not A Bug,23/May/22 15:35,27/May/22 21:54,2.5.0,"In Hbase 2.0-2.4 it is possible to check for a finished compaction by polling  Admin.getLastMajorCompactionTimestamp() for the table under compaction, even when the clock is stopped via EnvironmentEdgeManager. However, in Hbase 2.5 the Admin.getLastMajorCompactionTimestamp() will not be updated even after the compaction is finished, and getCompactionState() returns NONE. I am not even sure that this is bug, however, this has broken one of our Phoenix tests, and may cause problems for others. This is the test code that breaks: [https://github.com/apache/phoenix/blob/8aa825ed88828a99d40fdb68eb2f930981cd8a6b/phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java#L818] Admin.getLastMajorCompactionTimestamp() seems to take the value from the Metrics, so I guess that the metrics no longer get updated somewhere when the clock is stopped. I did not dig deeper than that." "Synchronous API calls for Split, Merge, and Compaction operations for testing",13447604,Open,Major,,31/May/22 04:16,,,"While generally split, merge, and compaction operations are too slow for synchrounous calls, for many tests we do need to wait until these operations are finished to be able to check their results. At least in the Phoenix tests, we also need to to do this while the EnvirenmentEdge clock is stopped. The polling method Admin.getLastMajorCompactionTimestamp() the we used for compactions has stopped working with EnvironmentEdgeManager in 2.5, see HBASE-27058 for details. We've also had similar issues in the past, where new versions made the previous workaround for synchronous operations fail. A longer-term solution for the problem would be having Synchronous API calls for testing, which block on the client side until the requested operation is finished. These could be added as variants to Admin / AsyncAdmin, or could be somewhere else, it doesn't really matter, as these would not be well suited for production use anyway." TestMetaFixed fails reliably with Hadoop 3.2.3 and Hadoop 3.3.2,13441192,Resolved,Major,Duplicate,22/Apr/22 16:02,31/May/22 13:37,2.4.12,"Noticed on build results over on https://github.com/apache/hbase/pull/4305, and reproduces locally with AdoptOpenJDK-11.0.11+9 ." Issue with ZooKeeper configuration on CDP5,13446226,Resolved,Major,Invalid,22/May/22 12:58,27/May/22 21:23,,"Hello everyone, I am new here and in HBase as well, so sorry for my lack of knowledge, I tried to read but the documentation and the environment that I got as a test are confusing me. The explanation is here, I have got Cloudera 5 with Hbase with Kerberos, 2 master nodes, and 3 worker nodes on Ubuntu machines, we have to connect DataStore with special application with checks krb5.conf file and keytab after authentication goes and connect to DS and check the tables the metadata there. When I am trying to push the application to connect the master node zookeeper is failing, when I am trying to connect zookeper node from the same application I can scan and do what I need, but every time the connection goes to 2181 localhost, how to check where is the issue of configuration that masters done will give me access to the data stores?   Here is log from master node:  [2022-05-22 12:26:31.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid [2022-05-22 12:26:31.676Z] [INFO] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.util.RetryCounter  [MasterNode]- Sleeping 1000ms before retry #0... [2022-05-22 12:26:31.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid [2022-05-22 12:26:31.676Z] [INFO] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.util.RetryCounter  [MasterNode]- Sleeping 2000ms before retry #1... [2022-05-22 12:26:31.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid [2022-05-22 12:26:31.676Z] [ERROR] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- ZooKeeper exists failed after 2 attempts [2022-05-22 12:26:31.677Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.ZKUtil  [MasterNode]- hconnection-0x46acd8780x0, quorum=10.2.0.30:2181, baseZNode=/hbase Unable to set watcher on znode (/hbase/hbaseid)  org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid     at org.apache.zookeeper.KeeperException.create(KeeperException.java:99)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)     at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1041)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:222)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:481)     at org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)     at org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:86)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:833)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:623)     at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)     at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)     at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:218)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:119)     at com.bigid.scanner.hbase.HBaseScanner.getDataSourceObjects(HBaseScanner.java:60)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:108)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:105)     at java.base/java.security.AccessController.doPrivileged(Native Method)     at java.base/javax.security.auth.Subject.doAs(Unknown Source)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper.getDataSourceObjects(HadoopUGIConnectorWrapper.java:105)     at com.bigid.scanner.connectors.generic.DataSourceConnectorAdapter.testConnection(DataSourceConnectorAdapter.java:289)     at com.bigid.scanner.core.tasks.legacy.LegacyTestConnectionTask.execute(LegacyTestConnectionTask.java:43)     at com.bigid.scanner.core.TestConnectionTask.execute(TestConnectionTask.java:36)     at com.bigid.scanner.core.TaskExecution.execute(TaskExecution.java:36)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:57)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:20)     at com.bigid.scanner.scannerboot.common.http.managers.TestConnectionSyncManager.lambda$runService$0(TestConnectionSyncManager.java:55)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)     at java.base/java.lang.Thread.run(Unknown Source) [2022-05-22 12:26:31.678Z] [ERROR] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher  [MasterNode]- hconnection-0x46acd8780x0, quorum=10.2.0.30:2181, baseZNode=/hbase Received unexpected KeeperException, re-throwing exception  org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid     at org.apache.zookeeper.KeeperException.create(KeeperException.java:99)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)     at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1041)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:222)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:481)     at org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)     at org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:86)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:833)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:623)     at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)     at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)     at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:218)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:119)     at com.bigid.scanner.hbase.HBaseScanner.getDataSourceObjects(HBaseScanner.java:60)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:108)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:105)     at java.base/java.security.AccessController.doPrivileged(Native Method)     at java.base/javax.security.auth.Subject.doAs(Unknown Source)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper.getDataSourceObjects(HadoopUGIConnectorWrapper.java:105)     at com.bigid.scanner.connectors.generic.DataSourceConnectorAdapter.testConnection(DataSourceConnectorAdapter.java:289)     at com.bigid.scanner.core.tasks.legacy.LegacyTestConnectionTask.execute(LegacyTestConnectionTask.java:43)     at com.bigid.scanner.core.TestConnectionTask.execute(TestConnectionTask.java:36)     at com.bigid.scanner.core.TaskExecution.execute(TaskExecution.java:36)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:57)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:20)     at com.bigid.scanner.scannerboot.common.http.managers.TestConnectionSyncManager.lambda$runService$0(TestConnectionSyncManager.java:55)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)     at java.base/java.lang.Thread.run(Unknown Source) [2022-05-22 12:26:31.678Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.client.ZooKeeperRegistry  [MasterNode]- Can't retrieve clusterId from Zookeeper  org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid     at org.apache.zookeeper.KeeperException.create(KeeperException.java:99)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)     at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1041)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:222)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:481)     at org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)     at org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:86)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:833)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:623)     at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)     at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)     at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:218)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:119)     at com.bigid.scanner.hbase.HBaseScanner.getDataSourceObjects(HBaseScanner.java:60)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:108)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:105)     at java.base/java.security.AccessController.doPrivileged(Native Method)     at java.base/javax.security.auth.Subject.doAs(Unknown Source)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper.getDataSourceObjects(HadoopUGIConnectorWrapper.java:105)     at com.bigid.scanner.connectors.generic.DataSourceConnectorAdapter.testConnection(DataSourceConnectorAdapter.java:289)     at com.bigid.scanner.core.tasks.legacy.LegacyTestConnectionTask.execute(LegacyTestConnectionTask.java:43)     at com.bigid.scanner.core.TestConnectionTask.execute(TestConnectionTask.java:36)     at com.bigid.scanner.core.TaskExecution.execute(TaskExecution.java:36)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:57)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:20)     at com.bigid.scanner.scannerboot.common.http.managers.TestConnectionSyncManager.lambda$runService$0(TestConnectionSyncManager.java:55)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)     at java.base/java.lang.Thread.run(Unknown Source) [2022-05-22 12:26:36.337Z] [INFO] scanner_file - 7a342cd4-cd4f-4a08-ab9f-8214b4f62f09 [poolScheduler-2] com.bigid.scanner.scannerboot.common.services.context.threads.ThreadPoolUpdatesService - Fetching thread pool updates [2022-05-22 12:26:41.675Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase [2022-05-22 12:26:41.676Z] [INFO] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.util.RetryCounter  [MasterNode]- Sleeping 1000ms before retry #0... [2022-05-22 12:26:41.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase [2022-05-22 12:26:41.676Z] [INFO] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.util.RetryCounter  [MasterNode]- Sleeping 2000ms before retry #1... [2022-05-22 12:26:41.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase [2022-05-22 12:26:41.676Z] [ERROR] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- ZooKeeper exists failed after 2 attempts [2022-05-22 12:26:41.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.ZKUtil  [MasterNode]- hconnection-0x46acd8780x0, quorum=10.2.0.30:2181, baseZNode=/hbase Unable to set watcher on znode (/hbase)  org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase     at org.apache.zookeeper.KeeperException.create(KeeperException.java:99)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)     at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1041)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:222)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:481)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.checkIfBaseNodeAvailable(ConnectionManager.java:849)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.access$400(ConnectionManager.java:535)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1435)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1476)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1505)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1711)     at org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38)     at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:124)     at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3601)     at org.apache.hadoop.hbase.client.HBaseAdmin.listTables(HBaseAdmin.java:312)     at org.apache.hadoop.hbase.client.HBaseAdmin.listTables(HBaseAdmin.java:296)     at com.bigid.scanner.hbase.HBaseScanner.getDataSourceObjects(HBaseScanner.java:62)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:108)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:105)     at java.base/java.security.AccessController.doPrivileged(Native Method)     at java.base/javax.security.auth.Subject.doAs(Unknown Source)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper.getDataSourceObjects(HadoopUGIConnectorWrapper.java:105)     at com.bigid.scanner.connectors.generic.DataSourceConnectorAdapter.testConnection(DataSourceConnectorAdapter.java:289)     at com.bigid.scanner.core.tasks.legacy.LegacyTestConnectionTask.execute(LegacyTestConnectionTask.java:43)     at com.bigid.scanner.core.TestConnectionTask.execute(TestConnectionTask.java:36)     at com.bigid.scanner.core.TaskExecution.execute(TaskExecution.java:36)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:57)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:20)     at com.bigid.scanner.scannerboot.common.http.managers.TestConnectionSyncManager.lambda$runService$0(TestConnectionSyncManager.java:55)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)     at java.base/java.lang.Thread.run(Unknown Source) [2022-05-22 12:26:41.676Z] [ERROR] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher  [MasterNode]- hconnection-0x46acd8780x0, quorum=10.2.0.30:2181, baseZNode=/hbase Received unexpected KeeperException, re-throwing exception  org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase     at org.apache.zookeeper.KeeperException.create(KeeperException.java:99)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)     at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1041)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:222)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:481)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.checkIfBaseNodeAvailable(ConnectionManager.java:849)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.access$400(ConnectionManager.java:535)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1435)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1476)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1505)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1711)     at org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38)     at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:124)     at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3601)     at org.apache.hadoop.hbase.client.HBaseAdmin.listTables(HBaseAdmin.java:312)     at org.apache.hadoop.hbase.client.HBaseAdmin.listTables(HBaseAdmin.java:296)     at com.bigid.scanner.hbase.HBaseScanner.getDataSourceObjects(HBaseScanner.java:62)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:108)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:105)     at java.base/java.security.AccessController.doPrivileged(Native Method)     at java.base/javax.security.auth.Subject.doAs(Unknown Source)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper.getDataSourceObjects(HadoopUGIConnectorWrapper.java:105)     at com.bigid.scanner.connectors.generic.DataSourceConnectorAdapter.testConnection(DataSourceConnectorAdapter.java:289)     at com.bigid.scanner.core.tasks.legacy.LegacyTestConnectionTask.execute(LegacyTestConnectionTask.java:43)     at com.bigid.scanner.core.TestConnectionTask.execute(TestConnectionTask.java:36)     at com.bigid.scanner.core.TaskExecution.execute(TaskExecution.java:36)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:57)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:20)     at com.bigid.scanner.scannerboot.common.http.managers.TestConnectionSyncManager.lambda$runService$0(TestConnectionSyncManager.java:55)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)     at java.base/java.lang.Thread.run(Unknown Source) [2022-05-22 12:26:41.676Z] [ERROR] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation  [MasterNode]- Can't get connection to ZooKeeper: KeeperErrorCode = ConnectionLoss for /hbase [2022-05-22 12:26:41.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase [2022-05-22 12:26:41.676Z] [INFO] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.util.RetryCounter  [MasterNode]- Sleeping 1000ms before retry #0... [2022-05-22 12:26:41.676Z] [INFO] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [poolScheduler-7] com.bigid.scanner.scannerboot.common.services.context.threads.ThreadPoolUpdatesService - Fetching thread pool updates [2022-05-22 12:26:41.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase [2022-05-22 12:26:41.676Z] [INFO] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.util.RetryCounter  [MasterNode]- Sleeping 2000ms before retry #1... [2022-05-22 12:26:41.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- Possibly transient ZooKeeper, quorum=10.2.0.30:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase [2022-05-22 12:26:41.676Z] [ERROR] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper  [MasterNode]- ZooKeeper exists failed after 2 attempts [2022-05-22 12:26:41.676Z] [WARN] scanner_file - 12750b5c-c00b-4eb9-8ec0-66a710ed822d [Thread-312] org.apache.hadoop.hbase.zookeeper.ZKUtil  [MasterNode]- hconnection-0x46acd8780x0, quorum=10.2.0.30:2181, baseZNode=/hbase Unable to set watcher on znode (/hbase)  org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase     at org.apache.zookeeper.KeeperException.create(KeeperException.java:99)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)     at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1041)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:222)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:481)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.checkIfBaseNodeAvailable(ConnectionManager.java:849)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.access$400(ConnectionManager.java:535)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStubNoRetries(ConnectionManager.java:1435)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$StubMaker.makeStub(ConnectionManager.java:1476)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionManager.java:1505)     at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getKeepAliveMasterService(ConnectionManager.java:1711)     at org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:38)     at org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithRetries(RpcRetryingCaller.java:124)     at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3601)     at org.apache.hadoop.hbase.client.HBaseAdmin.listTables(HBaseAdmin.java:312)     at org.apache.hadoop.hbase.client.HBaseAdmin.listTables(HBaseAdmin.java:296)     at com.bigid.scanner.hbase.HBaseScanner.getDataSourceObjects(HBaseScanner.java:62)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:108)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper$4.run(HadoopUGIConnectorWrapper.java:105)     at java.base/java.security.AccessController.doPrivileged(Native Method)     at java.base/javax.security.auth.Subject.doAs(Unknown Source)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1693)     at com.bigid.scanner.hadoop.common.HadoopUGIConnectorWrapper.getDataSourceObjects(HadoopUGIConnectorWrapper.java:105)     at com.bigid.scanner.connectors.generic.DataSourceConnectorAdapter.testConnection(DataSourceConnectorAdapter.java:289)     at com.bigid.scanner.core.tasks.legacy.LegacyTestConnectionTask.execute(LegacyTestConnectionTask.java:43)     at com.bigid.scanner.core.TestConnectionTask.execute(TestConnectionTask.java:36)     at com.bigid.scanner.core.TaskExecution.execute(TaskExecution.java:36)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:57)     at com.bigid.scanner.scannerboot.common.services.TestConnectionService.doService(TestConnectionService.java:20)     at com.bigid.scanner.scannerboot.common.http.managers.TestConnectionSyncManager.lambda$runService$0(TestConnectionSyncManager.java:55)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)     at java.base/java.lang.Thread.run(Unknown Source)" Fix undefined local variable error in draining_servers.rb,13444791,Resolved,Major,Fixed,13/May/22 08:41,22/May/22 07:08,3.0.0-alpha-3,"HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards. {quote}   NameError: undefined local variable or method `admin' for main:Object     getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81         addServers at /opt/khp/hbase/bin/draining_servers.rb:88            
at /opt/khp/hbase/bin/draining_servers.rb:146 {quote}   {code:java} for i in [1, 2, 3] a = i end puts a # 3 [4, 5, 6].each do |i| b = i end puts b # undefined local variable or method `b' {code} We can define the admin local variable in the current scope beforehand, and we can still access it after the block.  " Deprecated jetty SslContextFactory cause HMaster startup failure due to multiple certificates in KeyStores,13444524,Resolved,Major,Fixed,12/May/22 06:31,22/May/22 07:01,2.4.11,"When we start hbase 2.4.11 masters with secure configuration (using https), we got this exception and failed to start the cluster {code:java} 2022-05-12 15:06:05,447 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMaster. at org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:2951) at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:253) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:149) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:81) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:152) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2962) Caused by: java.io.IOException: Problem starting http server at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1140) at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:151) at org.apache.hadoop.hbase.regionserver.HRegionServer.putUpWebUI(HRegionServer.java:2230) at org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:689) at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:419) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480) at org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:2944) ... 5 more Caused by: java.lang.IllegalStateException: KeyStores with multiple certificates are not supported on the base class org.apache.hbase.thirdparty.org.eclipse.jetty.util.ssl.SslContextFactory. (Use org.apache.hbase.thirdparty.org.eclipse.jetty.util.ssl.SslContextFactory$Server or org.apache.hbase.thirdparty.org.eclipse.jetty.util.ssl.SslContextFactory$Client instead) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.ssl.SslContextFactory.newSniX509ExtendedKeyManager(SslContextFactory.java:1288) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.ssl.SslContextFactory.getKeyManagers(SslContextFactory.java:1270) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.ssl.SslContextFactory.load(SslContextFactory.java:372) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.ssl.SslContextFactory.doStart(SslContextFactory.java:243) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.SslConnectionFactory.doStart(SslConnectionFactory.java:97) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.AbstractConnector.doStart(AbstractConnector.java:321) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:81) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:234) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:401) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1109) ... 15 more {code} Some knowledge base said using SslContextFactory.Server solves this issue as the exception message said https://kb.vmware.com/s/article/83778 Actually, officially SslContextFactory base constructor deprecated and use either of Server or Client is recommended https://github.com/eclipse/jetty.project/blob/8da83308eeca865e495e53ef315a249d63ba9332/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java#L188-L233 Ref. - https://github.com/eclipse/jetty.project/issues/3464 - https://github.com/eclipse/jetty.project/pull/4386" TestStochasticLoadBalancerRegionReplicaLargeCluster.testRegionReplicasOnLargeCluster is flaky ,13445757,Resolved,Major,Fixed,19/May/22 05:12,21/May/22 16:47,2.5.0,"TestStochasticLoadBalancerRegionReplicaLargeCluster.testRegionReplicasOnLargeCluster . Looks like we can be off by one on either side of an expected value. Any idea what is going on here [~dmanning]? {noformat} org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaLargeCluster.testRegionReplicasOnLargeCluster Time elapsed: 77.779 s <<< FAILURE! java.lang.AssertionError: All servers should have load no less than 60. server=srv1351292323,46522,-3543799643652531264 , load=59 at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.assertTrue(Assert.java:42) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.assertClusterAsBalanced(BalancerTestBase.java:200) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:577) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:544) at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaLargeCluster.testRegionReplicasOnLargeCluster(TestStochasticLoadBalancerRegionReplicaLargeCluster.java:41) {noformat} {noformat} org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaLargeCluster.testRegionReplicasOnLargeCluster Time elapsed: 77.781 s <<< FAILURE! java.lang.AssertionError: All servers should have load no more than 60. server=srv1402325691,7995,26308078476749652 , load=61 at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.assertTrue(Assert.java:42) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.assertClusterAsBalanced(BalancerTestBase.java:198) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:577) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:544) at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaLargeCluster.testRegionReplicasOnLargeCluster(TestStochasticLoadBalancerRegionReplicaLargeCluster.java:41) {noformat}" Ref guide update,13437868,Resolved,Major,Fixed,05/Apr/22 12:30,22/May/22 08:36,,"See the discussion thread on dev list. https://lists.apache.org/thread/ptmwz1lb6o6g6qchcwy3mzg3b0vsm5gh Will open several sub tasks to land all the changes." Let lock wait timeout to improve performance of SnapshotHFileCleaner,13445196,Resolved,Major,Fixed,16/May/22 13:49,20/May/22 22:50,2.4.12,"Currently, hfile cleaner uses the dir scanning threads to get deletable files, by checking all the files under the scanned directories through the cleaner chain. And before scanning a directory, cleaner sorted the subdirectories by consumed spaces, but  we all know getContentSummary is a time consuming operation for HDFS. SnapshotHFileCleaner filters all the unreferenced files of snapshots to delete, and it tries to get write lock of SnapshotManager#takingSnapshotLock before determining the deletable files. [https://github.com/apache/hbase/blob/ad64a9baae2ef8ee56aa3ed6b96cb3d51f5daf0a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java#L195] But when there is any snapshot taking and the cleaner gets the lock failed, all the scanned files will be determined to be none-deletable, and all the dir scanning threads will scan and getContentSummary of other dirs(no files are deletable too) one by one until the snapshot taking lock is released. This is a low efficiency behavior, we should let the clear wait the lock to determine if the files it currently hold are deletable, instead of the meaningless scanning and getContentSummary other/new directories while the lock is acquired by taking snapshot operations. I deployed this optimization in our production environment, and the effect is very obvious.  " TestAsyncTableScanner.testScanWrongColumnFamily is flaky,13445744,Resolved,Major,Fixed,19/May/22 03:21,20/May/22 22:14,2.5.0,"[~ndimiduk] have you seen something like this before? {noformat} [ERROR] org.apache.hadoop.hbase.client.TestAsyncTableScanner.testScanWrongColumnFamily[3: table=raw, scan=batchSmallResultSize] Time elapsed: 0.018 s <<< FAILURE! java.lang.AssertionError: Expected: a collection containing (SpanKind with a name that a string starting with ""SCAN default:async"" and SpanKind with a parentSpanId that ""612b6a689e063c9b"" and SpanData with StatusCode that is and SpanData having Exception with Attributes that Attributes containing [is ->a string ending with ""org.apache.hadoop.hbase.regionserver.NoSuchColumnFamilyException""] and SpanData that hasEnded) but: SpanKind with a name that a string starting with ""SCAN default:async"" name was ""AsyncRegionLocator.getRegionLocation"", SpanKind with a name that a string starting with ""SCAN default:async"" name was ""Region.getScanner"", SpanKind with a name that a string starting with ""SCAN default:async"" name was ""hbase.pb.ClientService/Scan"", SpanKind with a name that a string starting with ""SCAN default:async"" name was ""RpcServer.process"", SpanData having Exception with Attributes that Attributes containing [is ->a string ending with ""org.apache.hadoop.hbase.regionserver.NoSuchColumnFamilyException""] exception attributes Attributes was [ {METADATA => {'hbase.store.file-tracker.impl' => 'DEFAULT'}}}, {NAME => 'cf', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', COMPRESSION => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536 B (64KB)', REPLICATION_SCOPE => '0'} at org.apache.hadoop.hbase.regionserver.HRegion.checkFamily(HRegion.java:7831) at org.apache.hadoop.hbase.regionserver.HRegion.lambda$getScanner$3(HRegion.java:3013) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:185) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:3002) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2997) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2991) at org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:3187) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3544) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45819) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:385) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:104) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:84) >, {METADATA => {'hbase.store.file-tracker.impl' => 'DEFAULT'}}}, {NAME => 'cf', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', COMPRESSION => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536 B (64KB)', REPLICATION_SCOPE => '0'} at org.apache.hadoop.hbase.regionserver.HRegion.checkFamily(HRegion.java:7831) at org.apache.hadoop.hbase.regionserver.HRegion.lambda$getScanner$3(HRegion.java:3013) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:185) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:3002) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2997) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:2991) at org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:3187) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3544) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45819) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:385) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:104) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:84) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:385) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:422) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:417) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.readResponse(NettyRpcDuplexHandler.java:166) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelRead(NettyRpcDuplexHandler.java:196) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:299) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:750) >, ], SpanKind with a name that a string starting with ""SCAN default:async"" name was ""hbase.pb.ClientService/Scan"", SpanKind with a name that a string starting with ""SCAN default:async"" name was ""testScanWrongColumnFamily[3: table=raw, scan=batchSmallResultSize]"" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8) at org.apache.hadoop.hbase.client.TestAsyncTableScanner.assertTraceError(TestAsyncTableScanner.java:150) at org.apache.hadoop.hbase.client.AbstractTestAsyncTableScan.testScanWrongColumnFamily(AbstractTestAsyncTableScan.java:272) {noformat}" Add a tool command list_liveservers,13444075,Resolved,Major,Fixed,10/May/22 00:31,19/May/22 22:51,,"To make it easier for us to query the living region Servers. We can add a command `list_liveservers`. There are already `list_deadServers` and `list_Decommissioned_regionServers`. !image-2022-05-10-08-34-33-711.png|width=457,height=123!  " Add DeleteSortReducer to HFileOutputFormat2,13446122,Open,Major,,20/May/22 21:32,,,"Currently if you want to bulk load Deletes you need to find some way to create KeyValues instead, because HFileOutputFormat2 doesn't support Delete as a map output value class. A savvy user will realize that you can first create your Delete then use {{delete.cellScanner()}} to gain access to the KeyValue's and write out those. This feels a little buried next to the ability to bulk load Puts directly. Additionally, KeyValue is an IA.Private class and in order to make this work you need to at the very least do {{{}job.setMapOutputValueClass(KeyValue.class){}}}. It seems a bit wrong to make the user import an IA.Private class for this. We can make HFileOutputFormat2 directly accept Deletes. It can do the work in a DeleteSortReducer of breaking up the Deletes into KeyValues, like we do with PutSortReducer. We could also use this moment to add support for full row deletes. If DeleteSortReducer sees a Delete without any getFamilyMap() values, it can look up the current families for the table." Disable TestClusterScopeQuotaThrottle,13445299,Resolved,Major,Fixed,17/May/22 02:25,18/May/22 12:52,,"We will inject a special EnvironmentEdge to control the return value of current time, which will mess up the wal filename and then fail the wal archiving. Let's disable it first before we find a suitable solution." The User API and Developer API links are broken on hbase.apache.org,13444442,Resolved,Major,Fixed,11/May/22 16:01,18/May/22 13:24,, Trace a one-shot execution of a Master procedure,13442346,Resolved,Major,Fixed,28/Apr/22 15:18,18/May/22 11:09,2.5.0,"A self-contained effort towards wrangling the stray traces identified in HBASE-26366. This one adds a tracing context to the Master's ProcedureV2 execution. This ties all the spans that result from a procedure execution back to a procedure by name. Maybe in a follow-on issue, we can serialize span context along with procedures and display procedure start/stop/retry events and parent-child hierarchy in tracing visualization." Introduce read all bytes when using pread for prefetch,13443725,Resolved,Major,Fixed,06/May/22 23:47,13/May/22 20:46,2.4.13,"h2. Problem statement When prefetching HFiles from blob storage like S3 and use it with the storage implementation like S3A, we found there is a logical issue in HBase pread that causes the reading of the remote HFile aborts the input stream multiple times. This aborted stream and reopen slow down the reads and trigger many aborted bytes and waste time in recreating the connection especially when SSL is enabled. h2. ROOT CAUSE The root cause of above issue was due to [BlockIOUtils#preadWithExtra|https://github.com/apache/hbase/blob/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443/hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java#L214-L257] is reading an input stream that does not guarrentee to return the data block and the next block header as an option data to be cached. In the case of the input stream read short and when the input stream read passed the length of the necessary data block with few more bytes within the size of next block header, the [BlockIOUtils#preadWithExtra|https://github.com/apache/hbase/blob/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443/hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java#L214-L257] returns to the caller without a cached the next block header. As a result, before HBase tries to read the next block, [HFileBlock#readBlockDataInternal|https://github.com/apache/hbase/blob/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java#L1648-L1664] in hbase tries to re-read the next block header from the input stream. Here, the reusable input stream has move the current position pointer ahead from the offset of the last read data block, when using with the [S3A implementation|https://github.com/apache/hadoop/blob/29401c820377d02a992eecde51083cf87f8e57af/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L339-L361], the input stream is then closed, aborted all the remaining bytes and reopen a new input stream at the offset of the last read data block . h2. How do we fix it? S3A is doing the right job that HBase is telling to move the offset from position A back to A - N, so there is not much thing we can do on how S3A handle the inputstream. meanwhile in the case of HDFS, this operation is fast. Such that, we should fix in HBase level, and try always to read datablock + next block header when we're using blob storage to avoid expensive draining the bytes in a stream and reopen the socket with the remote storage. h2. Draw back and discussion * A known drawback is, when we're at the last block, we will read extra length that should not be a header, and we still read that into the byte buffer array. the size should be always 33 bytes, and it should not a big issue in data correctness because the trailer will tell when the last datablock should end. And we just waste a 33 byte read and that data is not being used. * I don't know if we can use HFileStreamReader but that will change the Prefetch logic a lot, such that this minimum change should be the best. h2. initial result We use YCSB 1 billion records data, and we enable prefetch for the userable. the collected the S3A metrics of {{stream_read_bytes_discarded_in_abort}} to compare the solution, each region server have abort ~290 GB data to be prefetch to bucketcache. * before the change, we have a total of 4235973338472 bytes (~4235GB) has been aborted on a sample region server for about 290GB data. ** the overall time was about 45 ~ 60 mins {code} % grep ""stream_read_bytes_discarded_in_abort"" ~/prefetch-result/prefetch-s3a-jmx-metrics.json | grep -wv ""stream_read_bytes_discarded_in_abort\"":0,"" ""stream_read_bytes_discarded_in_abort"":3136854553, ""stream_read_bytes_discarded_in_abort"":19119241, ""stream_read_bytes_discarded_in_abort"":2131591701471, ""stream_read_bytes_discarded_in_abort"":150484654298, ""stream_read_bytes_discarded_in_abort"":106536641550, ""stream_read_bytes_discarded_in_abort"":1785264521717, ""stream_read_bytes_discarded_in_abort"":58939845642, {code} * After the change, we only have 87100225454 bytes (~87GB) data to be aborted. ** the reason is about the position is way behind the asked target position, then S3A reopen the stream and move the position to the current offset. This is a different problem we will need to look into later. ** the overall time is then cut to 30~38 mins, about 30% faster. {code} % grep ""stream_read_bytes_discarded_in_abort"" ~/fixed-formatted-jmx2.json ""stream_read_bytes_discarded_in_abort"": 0, ""stream_read_bytes_discarded_in_abort"": 87100225454, ""stream_read_bytes_discarded_in_abort"": 67043088, {code}" "Flakey test detector generated garbage, breaks build automation",13445148,Open,Major,,16/May/22 10:43,,2.6.0,"Flakey test automation is injecting nonsense into the mvn invocation used by builds. The skip list includes: {{**/htWtApR.NTIeNsGt:H tAtnp Sielrlveegra.java}}, which causes the build to fail with {noformat} [ERROR] Unknown lifecycle phase ""tAtnp"". You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1] {noformat}" "Backport ""HBASE-27013 Introduce read all bytes when using pread for prefetch"" to branch-2.4",13444910,Resolved,Major,Fixed,13/May/22 20:44,16/May/22 18:23,2.4.13,"Backport HBASE-27013 to branch-2.4, it's required because it's not a clean backport." Serialized procedures which point to users from other Kerberos domains can prevent master startup,13445270,Open,Major,,16/May/22 21:30,,,"We ran into an interesting bug when test teams were running HBase against cloud storage without ensuring that the previous location was cleaned. This resulted in an hbase.rootdir that had: * A valid HBase MasterData Region * A valid hbase:meta * A valid collection of HBase tables * An empty ZooKeeper Through the changes that we've worked on prior, those described in HBASE-24286 were effective in getting every _except_ the Procedures back online without issue. Parsing the existing procedures produced an interesting error: {noformat} java.lang.IllegalArgumentException: Illegal principal name hbase/wrong-hostname.domain@WRONG_REALM: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to hbase/wrong-hostname.domain@WRONG_REALM at org.apache.hadoop.security.User.(User.java:51) at org.apache.hadoop.security.User.(User.java:43) at org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:1418) at org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:1402) at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.toUserInfo(MasterProcedureUtil.java:60) at org.apache.hadoop.hbase.master.procedure.ModifyTableProcedure.deserializeStateData(ModifyTableProcedure.java:262) at org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProcedure(ProcedureUtil.java:294) at org.apache.hadoop.hbase.procedure2.store.ProtoAndProcedure.getProcedure(ProtoAndProcedure.java:43) at org.apache.hadoop.hbase.procedure2.store.InMemoryProcedureIterator.next(InMemoryProcedureIterator.java:90) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.loadProcedures(ProcedureExecutor.java:411) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$400(ProcedureExecutor.java:78) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.load(ProcedureExecutor.java:339) at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.load(RegionProcedureStore.java:285) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:330) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:600) at org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1581) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:835) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2205) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:514) at java.lang.Thread.run(Thread.java:750) {noformat} What's actually happening is that we are storing the {{User}} into the procedure and then relying on UserGroupInformation to parse the {{User}} protobuf into a UGI to get the ""short"" username. When the serialized procedure (whether in the MasterData region over via PV2 WAL files, I think) gets loaded, we end up needing Hadoop auth_to_local configuration to be able to parse that kerberos principal back to a name. However, Hadoop's KerberosName will only unwrap Kerberos principals which match the local Kerberos realm (defined by the krb5.conf's default_realm, [ref|https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/sun/security/krb5/Config.java#L978-L983]) The interesting part is that we don't seem to ever use the user _other_ than to display the {{owner}} attribute for procedures on the HBase UI. There is a method in hbase-procedure which can filter procedures based on Owner, but I didn't see any usages of that method. Given the pushback against HBASE-24286, I assume that, for the same reasons, we would see pushback against fixing this issue. However, I wanted to call it out for posterity. The expectation of users is that HBase _should_ implicitly handle this case." failed to set file permission when node crash,13444973,Open,Major,,14/May/22 10:48,,," in SecureBulkLoadManager#secureBulkLoadHFiles, we have code like that: {code:java} for(Pair el: familyPaths) {               Path stageFamily = new Path(bulkToken, Bytes.toString(el.getFirst()));               if(!fs.exists(stageFamily)) {                 fs.mkdirs(stageFamily);                 fs.setPermission(stageFamily, PERM_ALL_ACCESS);              } } {code} if process crashbefore setpermission， and reboot, we can't setpermission again.   we should make this code like SnapshotScannerHDFSAclHelper#setCommonDirectoryPermission   {code:java}  for (Path path : paths) {       createDirIfNotExist(path);       fs.setPermission(path, new FsPermission(           conf.get(COMMON_DIRECTORY_PERMISSION, COMMON_DIRECTORY_PERMISSION_DEFAULT))) } {code}                " Add metrics for draining region servers,13444826,Resolved,Major,Duplicate,13/May/22 11:29,13/May/22 11:50,,"To facilitate us to query and monitor the draining region servers, add metrics  numDrainingRegionServers and drainingRegionServers. !image-2022-05-13-19-28-40-618.png|width=317,height=165!" Block cache stats (Misses Caching) display error in RS web UI,13443370,Resolved,Major,Fixed,05/May/22 12:08,06/May/22 06:38,,"Block cache stats (Misses Caching) display error in RS web UI. !image-2022-05-05-20-11-47-884.png|width=547,height=303!" MasterFileSystem create directory without permission check,13442674,Resolved,Major,Fixed,01/May/22 07:10,08/May/22 20:30,2.4.12,"Method checkStagingDir and checkSubDir first check if directory is exist ,if not , create it with special permission. If exist then setPermission for this directory. BUT if not exist ,we still need set special permission for this directory" Another case for unnecessary replication suspending in RegionReplicationSink,13440349,Resolved,Major,Fixed,19/Apr/22 09:59,30/Apr/22 03:39,3.0.0-alpha-2,"Besides HBASE-26768, there is another case replication in {{RegionReplicationSink}} would be suspend: For {{RegionReplicationSink}}, when there is a replication error , {{RegionReplicationSink}} invokes {{MemStoreFlusher#requestFlush}} to request a flush, and after receiving the {{FlushAction#START_FLUSH}} or {{FlushAction#CANNOT_FLUSH}} flush marker, it would resume the replication. But when {{MemStoreFlusher}} flushing, it invokes following method {{HRegion.flushcache}} with the {{writeFlushRequestWalMarker}} set to false: {code:java} public FlushResultImpl flushcache(List families, boolean writeFlushRequestWalMarker, FlushLifeCycleTracker tracker) throws IOException { } {code} When {{writeFlushRequestWalMarker}} is set to false, {{HRegion.flushcache}} does not write the {{FlushAction#CANNOT_FLUSH}} flush marker to {{WAL}} when the memstore is empty, just as following {{HRegion.writeFlushRequestMarkerToWAL}} illustrated: {code:java} private boolean writeFlushRequestMarkerToWAL(WAL wal, boolean writeFlushWalMarker) { if (writeFlushWalMarker && wal != null && !writestate.readOnly) { FlushDescriptor desc = ProtobufUtil.toFlushDescriptor(FlushAction.CANNOT_FLUSH, getRegionInfo(), -1, new TreeMap<>(Bytes.BYTES_COMPARATOR)); try { WALUtil.writeFlushMarker(wal, this.getReplicationScope(), getRegionInfo(), desc, true, mvcc, regionReplicationSink.orElse(null)); return true; } catch (IOException e) { LOG.warn(getRegionInfo().getEncodedName() + "" : "" + ""Received exception while trying to write the flush request to wal"", e); } } return false; } {code} so when there is a replication error when the memstore is empty(eg. replicating the {{FlushAction#START_FLUSH}} or {{FlushAction#COMMIT_FLUSH}} ), the replication may suspend until next memstore flush,even though later there are user writes and it could replicate normally. I simulate this problem in the PR , and for {{writeFlushRequestWalMarker}} paramter, it is introduced by HBASE-11580 and just only determines whether or not writing the {{FlushAction#CANNOT_FLUSH}} flush marker to WAL when the memstore is empty, so I think for simplicity, we could set it to true always for {{MemStoreFlusher}}." ReplicationSource#removePeer hangs if we try to remove bad peer.,13440732,Resolved,Major,Fixed,20/Apr/22 16:41,07/May/22 17:48,2.4.11,"ReplicationSource#removePeer hangs if we try to remove bad peer. Steps to reproduce: 1. Set config replication.source.regionserver.abort to false so that it doesn't abort regionserver. 2. Add a dummy peer. 2. Remove that peer. RemovePeer call will hang indefinitely until the test times out. Attached a patch to reproduce the above behavior. I can see following threads in the stack trace: {noformat} ""RS_REFRESH_PEER-regionserver/rushabh-ltmflld:0-0.replicationSource,dummypeer_1"" #339 daemon prio=5 os_prio=31 tid=0x00007f8caa 44a800 nid=0x22107 waiting on condition [0x00007000107e5000] java.lang.Thread.State: TIMED_WAITING (sleeping) at java.lang.Thread.sleep(Native Method) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.sleepForRetries(ReplicationSource.java:511) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:577) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.lambda$startup$4(ReplicationSource.java:633) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$$Lambda$350/89698794.uncaughtException(Unknown Source) at java.lang.Thread.dispatchUncaughtException(Thread.java:1959) {noformat} {noformat} ""RS_REFRESH_PEER-regionserver/rushabh-ltmflld:0-0"" #338 daemon prio=5 os_prio=31 tid=0x00007f8ca82fa800 nid=0x22307 in Object.wait() [0x00007000106e2000] java.lang.Thread.State: TIMED_WAITING (on object monitor) at java.lang.Object.wait(Native Method) at java.lang.Thread.join(Thread.java:1260) - locked <0x0000000799975ea0> (a java.lang.Thread) at org.apache.hadoop.hbase.util.Threads.shutdown(Threads.java:106) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.terminate(ReplicationSource.java:674) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.terminate(ReplicationSource.java:657) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.terminate(ReplicationSource.java:652) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.terminate(ReplicationSource.java:647) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.removePeer(ReplicationSourceManager.java:330) at org.apache.hadoop.hbase.replication.regionserver.PeerProcedureHandlerImpl.removePeer(PeerProcedureHandlerImpl.java:56) at org.apache.hadoop.hbase.replication.regionserver.RefreshPeerCallable.call(RefreshPeerCallable.java:61) at org.apache.hadoop.hbase.replication.regionserver.RefreshPeerCallable.call(RefreshPeerCallable.java:35) at org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} {noformat} ""Listener at localhost/55013"" #20 daemon prio=5 os_prio=31 tid=0x00007f8caf95a000 nid=0x6703 waiting on condition [0x0000700002 544000] java.lang.Thread.State: TIMED_WAITING (sleeping) at java.lang.Thread.sleep(Native Method) at org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.waitProcedureResult(HBaseAdmin.java:3442) at org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.get(HBaseAdmin.java:3372) at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:182) at org.apache.hadoop.hbase.client.Admin.removeReplicationPeer(Admin.java:2861) at org.apache.hadoop.hbase.client.replication.TestBadReplicationPeer.cleanPeer(TestBadReplicationPeer.java:74) at org.apache.hadoop.hbase.client.replication.TestBadReplicationPeer.testWrongReplicationEndpoint(TestBadReplicationPeer.java:66) {noformat} The main thread ""TestBadReplicationPeer.testWrongReplicationEndpoint"" is waiting for Admin#removeReplicationPeer. The refreshPeer thread (PeerProcedureHandlerImpl#removePeer) responsible to terminate peer (#338) is waiting on ReplicationSource thread to be terminated. The ReplicateSource thread (#339) is in sleeping state. Notice that this thread's stack trace is in ReplicationSource#uncaughtException method. When we call ReplicationSourceManager#removePeer, we set sourceRunning flag to false, send an interrupt signal to ReplicationSource thread [here|https://github.com/apache/hbase/blob/branch-2.4/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L668-L674]. In this case ReplicationSource was waiting to read cluster id of the peer and it received an InterruptedException. {noformat} 2022-04-20 08:46:49,679 WARN [RS_REFRESH_PEER-regionserver/rushabh-ltmflld:0-0.replicationSource,dummypeer_1] zookeeper.ZKUtil(228): connection to cluster: dummypeer_1-0x100229efa200009, quorum=127.0.0.1:55599, baseZNode=/1 Unable to set watcher on znode (/1/hbaseid) java.lang.InterruptedException at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:502) at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1529) at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1512) at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:2016) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:212) at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:221) at org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65) at org.apache.hadoop.hbase.zookeeper.ZKClusterId.getUUIDForCluster(ZKClusterId.java:96) at org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.getPeerUUID(HBaseReplicationEndpoint.java:112) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:571) at java.lang.Thread.run(Thread.java:748) {noformat} [ZKClusterId.readClusterIdZNode|https://github.com/apache/hbase/blob/branch-2.4/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKClusterId.java#L69-L72] catches InterruptedException and returns null. ReplicationSource realizes that sourceRunning flag is set to false and it will throw IllegalStateException [here|https://github.com/apache/hbase/blob/branch-2.4/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L561-L565]. Then the control goes to [UncaughtExceptionHandler|https://github.com/apache/hbase/blob/branch-2.4/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L620-L640] and since abortOnError is set to false, it will go into infinite sleep causing the test to hang. " TestRegionProcessRowsWithLocks#testProcessExceptionAndRollBack is broken in branch-1,13443264,Resolved,Major,Fixed,05/May/22 06:44,06/May/22 15:43,1.7.1,"As titled, I found that {{TestRegionProcessRowsWithLocks#testProcessExceptionAndRollBack}} is broken while reviewing the PR for HBASE-26977 ([pre-commit test log here|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4377/7/artifact/out/patch-unit-hbase-server.txt]) with below exceptions: {noformat} [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 10.166 s <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestRegionProcessRowsWithLocks [ERROR] testProcessExceptionAndRollBack(org.apache.hadoop.hbase.regionserver.TestRegionProcessRowsWithLocks) Time elapsed: 5.849 s <<< ERROR! com.google.protobuf.ServiceException: Error calling method hbase.pb.RowProcessorService.Process at org.apache.hadoop.hbase.ipc.CoprocessorRpcChannel.callBlockingMethod(CoprocessorRpcChannel.java:75) at org.apache.hadoop.hbase.protobuf.generated.RowProcessorProtos$RowProcessorService$BlockingStub.process(RowProcessorProtos.java:1631) at org.apache.hadoop.hbase.regionserver.TestRegionProcessRowsWithLocks.incrementCounter(TestRegionProcessRowsWithLocks.java:193) at org.apache.hadoop.hbase.regionserver.TestRegionProcessRowsWithLocks.testProcessExceptionAndRollBack(TestRegionProcessRowsWithLocks.java:173) {noformat} Manually test the single case in my local environment also failed. Using {{git bisect}}, I found the issue was introduced by HBASE-26393 and have been existing for several months (since Oct 23, 2021). The fix is straight forward and I will prepare a PR soon." Chaos Monkey thread dies in ITBLL Chaos GracefulRollingRestartRsAction ,13442179,Resolved,Major,Fixed,27/Apr/22 21:44,05/May/22 18:44,2.4.11,"Run itbll chaos monkey in k8s cluster, found chaos monkey thread died in GracefulRollingRestartRsAction. " Remove ref guide check in pre commit and nightly for branches other than master,13442795,Resolved,Major,Fixed,02/May/22 13:21,05/May/22 10:44,,Our nightly builds are failing after HBASE-26932. Let's fix it. Add the information of EOL releases to our ref guide on master branch,13437871,Resolved,Major,Fixed,05/Apr/22 12:35,05/May/22 10:27,,"This is because we decide to only maintain the documentation for master branch, so we should have all the information in this doc." nightly ITBLL,13443678,Open,Major,,06/May/22 15:41,,, migrate existing nightly test,13443677,Open,Major,,06/May/22 15:40,,,"once we can run a cluster on k8s in the nightly worker node, migrate our existing test to use it." container images for HBase,13443675,Open,Major,,06/May/22 15:40,,,we need container images of the build that got made during the nightly run container images for ZooKeeper,13443674,Open,Major,,06/May/22 15:39,,,we need image(s) for a zk cluster for our nightly cluster run container images for Hadoop,13443673,Open,Major,,06/May/22 15:39,,,we need image(s) for the hadoop cluster we run the nightly tests on top of nightly support scripts for install/setup of single-node k8s env,13443672,Open,Major,,06/May/22 15:38,,,"minikube , kind, something like that." Auto renew scanner lease in TableRecordReader,13443018,Resolved,Major,Not A Problem,03/May/22 19:21,04/May/22 19:53,,"A common problem with hadoop jobs is when the mapper takes too long to process individual inputs. This is especially problematic with TableInputFormat because if you don't process a scanner.next() batch within the scanner timeout period your job will fail with UnknownScannerException. The fix here is usually to reduce Scan.setCaching, so that fewer rows are returned within each batch. This isn't always a great solution because maybe not all batches are uniform in their processing time, or maybe even processing a single row (the smallest caching size) might take a while. We can improve this for users by providing a configurable period at which the TableRecordReader will automatically call scanner.renewLease() unless next() was recently called." Miscellaneous improvements before landing spotless reformat,13437381,Resolved,Major,Fixed,02/Apr/22 05:19,01/May/22 15:15,, Do not add --threads when running 'mvn site',13437384,Resolved,Major,Fixed,02/Apr/22 05:27,29/Apr/22 10:17,,"We will get this in the mvnsite task in our nightly and pre commit jobs {noformat} [WARNING] ***************************************************************** [WARNING] * Your build is requesting parallel execution, but project * [WARNING] * contains the following plugin(s) that have goals not marked * [WARNING] * as @threadSafe to support parallel building. * [WARNING] * While this /may/ work fine, please look for plugin updates * [WARNING] * and/or request plugins be made thread-safe. * [WARNING] * If reporting an issue, report it against the plugin in * [WARNING] * question, not against maven-core * [WARNING] ***************************************************************** [WARNING] The following plugins are not marked @threadSafe in Apache HBase: [WARNING] org.apache.maven.plugins:maven-site-plugin:3.7.1 [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe. [WARNING] ***************************************************************** {noformat}" Adhere to maxAttempts in RawAsyncTableImpl.batch,13441319,Resolved,Major,Not A Problem,24/Apr/22 00:08,25/Apr/22 12:37,,In HBASE-26807 I accidentally removed the call .maxAttempts(maxAttempts) when building the batch call in RawAsyncTableImpl.batch. Need to add it back. Restored table from snapshot that has MOB is inconsistent,13441245,Open,Major,,22/Apr/22 22:58,,3.0.0-alpha-2,"When we restore the table from snapshot and it has MOB files, there are links that do not fit the pattern of HFileLink. I'm not sure to which side effects that might lead, but at least it's not possible to create a snapshot right after the restore: {quote} Version 3.0.0-alpha-3-SNAPSHOT, rcd45cadbc1a42db359ff4e775cbd4b55cfe28140, Fri Apr 22 03:04:25 PM PDT 2022 Took 0.0016 seconds hbase:001:0> list_snapshot list_snapshot_sizes list_snapshots hbase:001:0> list_snapshots SNAPSHOT TABLE + CREATION TIME t1 table_1 (2022-04-22 15:48:04 -0700) 1 row(s) Took 1.0881 seconds => [""t1""] hbase:002:0> restore_snapshot 't1' Took 2.3942 seconds hbase:003:0> snapshot snapshot snapshot_cleanup_enabled snapshot_cleanup_switch hbase:003:0> snapshot 'table_1', 't2' ERROR: org.apache.hadoop.hbase.snapshot.HBaseSnapshotException: Snapshot { ss=t2 table=table_1 type=FLUSH ttl=0 } had an error. Procedure t2 { waiting=[] done=[] } at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.isSnapshotDone(SnapshotManager.java:403) at org.apache.hadoop.hbase.master.MasterRpcServices.isSnapshotDone(MasterRpcServices.java:1325) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:106) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:86) Caused by: org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException via Failed taking snapshot { ss=t2 table=table_1 type=FLUSH ttl=0 } due to exception:Can't find hfile: table_1=1bccf339572b9a4db7475abcf57eeb8f-bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a in the real (hdfs://localhost:8020/hbase2.4/mobdir/data/table_1/1bccf339572b9a4db7475abcf57eeb8f-table_1/1bccf339572b9a4db7475abcf57eeb8f/data/bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a) or archive (hdfs://localhost:8020/hbase2.4/archive/data/table_1/1bccf339572b9a4db7475abcf57eeb8f-table_1/1bccf339572b9a4db7475abcf57eeb8f/data/bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a) directory for the primary table.:org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException: Can't find hfile: table_1=1bccf339572b9a4db7475abcf57eeb8f-bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a in the real (hdfs://localhost:8020/hbase2.4/mobdir/data/table_1/1bccf339572b9a4db7475abcf57eeb8f-table_1/1bccf339572b9a4db7475abcf57eeb8f/data/bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a) or archive (hdfs://localhost:8020/hbase2.4/archive/data/table_1/1bccf339572b9a4db7475abcf57eeb8f-table_1/1bccf339572b9a4db7475abcf57eeb8f/data/bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a) directory for the primary table. at org.apache.hadoop.hbase.errorhandling.ForeignExceptionDispatcher.rethrowException(ForeignExceptionDispatcher.java:82) at org.apache.hadoop.hbase.master.snapshot.TakeSnapshotHandler.rethrowExceptionIfFailed(TakeSnapshotHandler.java:322) at org.apache.hadoop.hbase.master.snapshot.SnapshotManager.isSnapshotDone(SnapshotManager.java:392) ... 6 more Caused by: org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException: Can't find hfile: table_1=1bccf339572b9a4db7475abcf57eeb8f-bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a in the real (hdfs://localhost:8020/hbase2.4/mobdir/data/table_1/1bccf339572b9a4db7475abcf57eeb8f-table_1/1bccf339572b9a4db7475abcf57eeb8f/data/bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a) or archive (hdfs://localhost:8020/hbase2.4/archive/data/table_1/1bccf339572b9a4db7475abcf57eeb8f-table_1/1bccf339572b9a4db7475abcf57eeb8f/data/bee397acc400449ea3a35ed3fc87fea1202204220b9b3b97b4fc42379a7b6455c3dc1613_49a15ec2a84c8489965d1910a05cca3a) directory for the primary table. at org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.concurrentVisitReferencedFiles(SnapshotReferenceUtil.java:232) at org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.concurrentVisitReferencedFiles(SnapshotReferenceUtil.java:195) at org.apache.hadoop.hbase.snapshot.SnapshotReferenceUtil.verifySnapshot(SnapshotReferenceUtil.java:172) at org.apache.hadoop.hbase.master.snapshot.MasterSnapshotVerifier.verifyRegions(MasterSnapshotVerifier.java:204) at org.apache.hadoop.hbase.master.snapshot.MasterSnapshotVerifier.verifySnapshot(MasterSnapshotVerifier.java:117) at org.apache.hadoop.hbase.master.snapshot.TakeSnapshotHandler.process(TakeSnapshotHandler.java:220) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:106) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) For usage try 'help ""snapshot""' Took 1.7477 seconds hbase:004:0> {quote}" Implement a special TestAppender to limit the size of test output,13439159,Resolved,Major,Fixed,12/Apr/22 11:04,21/Apr/22 15:30,,"Recently our build nodes were out of space several times. I've checked some of them, all are because of logging in an infinite loop which makes a very big log output. I've already opened several issues for this, such as HBASE-26858, HBASE-26941, HBASE-26946. So in general, I think we should have a way to limit the total size of a log output. So when we do something wrong in code it will not eat all the space soon and bring down our ci." Compilation of master vs hadoop-3.3.2 fails,13439539,Resolved,Major,Fixed,13/Apr/22 20:51,21/Apr/22 09:55,3.0.0-alpha-2,"We noticed over on HBASE-26907 while adding Hadoop 3.3.2 to our nightly build matrix that we get a compilation failure when setting this as the hadoop.three version. {noformat} [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4305/yetus-general-check/src/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java:[832,29] package org.apache.htrace.core does not exist [INFO] 1 error [INFO] ------------------------------------------------------------- {noformat}" Packaging and Integration Stage can fail with BindingException,13440918,Open,Major,,21/Apr/22 12:42,,,"Following up on a failed [branch-2 nightly build|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/520/], I found an annoying bug in the Packaging and Integration stage. Launching the HDFS cluster used by the test failed, for a really dumb reason. {noformat} 22/04/19 19:58:59 INFO service.AbstractService: Service HistoryClientService failed in state STARTED; cause: org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested address; For more details see: http://wiki.apache.org/hadoop/BindException org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested address; For more details see: http://wiki.apache.org/hadoop/BindException at org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:138) at org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC.getServer(HadoopYarnProtoRPC.java:65) at org.apache.hadoop.yarn.ipc.YarnRPC.getServer(YarnRPC.java:54) at org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.serviceStart(HistoryClientService.java:128) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) at org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121) at org.apache.hadoop.mapreduce.v2.hs.JobHistoryServer.serviceStart(JobHistoryServer.java:202) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster$JobHistoryServerWrapper$1.run(MiniMRYarnCluster.java:236) Caused by: java.net.BindException: Problem binding to [jenkins-hbase3.apache.org:0] java.net.BindException: Cannot assign requested address; For more details see: http://wiki.apache.org/hadoop/BindException at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:824) at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:735) at org.apache.hadoop.ipc.Server.bind(Server.java:615) at org.apache.hadoop.ipc.Server$Listener.(Server.java:1179) at org.apache.hadoop.ipc.Server.(Server.java:2983) at org.apache.hadoop.ipc.RPC$Server.(RPC.java:1003) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server.(ProtobufRpcEngine.java:425) at org.apache.hadoop.ipc.ProtobufRpcEngine.getServer(ProtobufRpcEngine.java:346) at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:844) at org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.createServer(RpcServerFactoryPBImpl.java:168) at org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl.getServer(RpcServerFactoryPBImpl.java:131) ... 8 more Caused by: java.net.BindException: Cannot assign requested address at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:438) at sun.nio.ch.Net.bind(Net.java:430) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:225) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at org.apache.hadoop.ipc.Server.bind(Server.java:598) ... 16 more {noformat}" Replace fully qualified class names with import statements where possible,13440892,Open,Major,,21/Apr/22 09:52,,,"Over on HBASE-26954, it was noticed that our enforcer check missed a class. Turns out, the restrict-imports enforcer-rule only works on import statements. Let's take a pass for fully qualified classes uses outside of import statements and see if we can reduce their number, so as to avoid this type of mistake in the future." Add support to hbase shell to remove coproc by its class name instead of coproc ID,13439897,Open,Major,,15/Apr/22 22:02,,1.7.1,"The syntax for removing coproc is as below:   hbase> alter 't1', METHOD => 'table_att_unset', NAME => 'coprocessor$1' We have to use coproc id to remove a coproc from a given table. Consider the following scenario. Due to some bug in a coproc, we have to remove a given coproc from all the tables in a cluster. Every table can have different set of co-procs. For a given co-proc class, the coproc ID will not be same for all the tables in a cluster. This gets more complex if we want to remove co-proc from all the production clusters. Instead we can pass a co-proc class name to alter table command. So if a table has that co-proc, it will remove otherwise do nothing." TestRaceBetweenSCPAndTRSP is flaky in master branch,13439338,Open,Major,,13/Apr/22 04:32,,,Observed in [pre-commit check|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4341/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt] of HBASE-26943 Rebuild a cluster from an existing root directory may hang,13437277,Open,Major,,01/Apr/22 15:10,,3.0.0-alpha-3,"After HBASE-26245, we can rebuild a cluster from an existing root directory on cloud environment, but we still have a problem,  if we stop the regionservers of the old cluster first, and then stop the masters,  new cluster(rebuild from old cluster's root directory) may hang. This problem is also described in HBASE-26898.   Hang Reason: For example, if RS1 is stopped first, the Master will expire RS1, and will generate a ServerCrashProcedure to reassign the region on RS1 (at the same time, the Master will delete the RS1 node information saved in the local region), and then generate subProcedure TransitRegionStateProcedure for reassignment, that is planned to assign the region to RS2 (RS2 has not been stopped at this time), but then RS2 is stopped, and the Master is also stopped. Rebuild a cluster from an existing root directory(from old cluster on OSS), the Master will recover from the Procedure state and continue to execute the unfinished Procedure. At this time, there is an uncompleted TransitRegionStateProcedure, and the target-RS to be assigned to the region is the RS2 of the old cluster, it will report warn message： {code:java} 2022-04-09 14:44:00,050 INFO  [master/emr-header-1:16000:becomeActiveMaster] procedure.MasterProcedureScheduler: Took xlock for pid=33950, ppid=33615, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED, hasLock=false; TransitRegionStateProcedure table=usertable, region=5c0dac3f7410e8c91e00bcfcdc6e774a, ASSIGN 2022-04-09 14:44:00,241 INFO  [master/emr-header-1:16000:becomeActiveMaster] assignment.AssignmentManager: Attach pid=33950, ppid=33615, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED, hasLock=false; TransitRegionStateProcedure table=usertable, region=5c0dac3f7410e8c91e00bcfcdc6e774a, ASSIGN to state=OFFLINE, location=null, table=usertable, region=5c0dac3f7410e8c91e00bcfcdc6e774a to restore RIT 2022-04-09 14:44:11,678 WARN  [PEWorker-1] assignment.RegionRemoteProcedureBase: Can not add remote operation pid=35353, ppid=33950, state=RUNNABLE, hasLock=true; OpenRegionProcedure 5c0dac3f7410e8c91e00b cfcdc6e774a, server=emr-worker-1.cluster-18871,16020,1649346155842 for region {ENCODED => 5c0dac3f7410e8c91e00bcfcdc6e774a, NAME => 'usertable,user1004,1649256577246.5c0dac3f7410e8c91e00bcfcdc6e774a.', ST ARTKEY => 'user1004', ENDKEY => 'user1008'} to server emr-worker-1.cluster-18871,16020,1649346155842, this usually because the server is alread dead, give up and mark the procedure as complete, the parent  procedure will take care of this. org.apache.hadoop.hbase.procedure2.NoServerDispatchException: emr-worker-1.cluster-18871,16020,1649346155842; pid=35353, ppid=33950, state=RUNNABLE, hasLock=true; OpenRegionProcedure 5c0dac3f7410e8c91e00b cfcdc6e774a, server=emr-worker-1.cluster-18871,16020,1649346155842         at org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher.addOperationToNode(RemoteProcedureDispatcher.java:172)         at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:283)         at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:56)         at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:953)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1667)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1414)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1981) 2022-04-09 14:44:11,689 INFO  [PEWorker-1] procedure2.ProcedureExecutor: Finished pid=35353, ppid=33950, state=SUCCESS, hasLock=false; OpenRegionProcedure 5c0dac3f7410e8c91e00bcfcdc6e774a, server=emr-worker-1.cluster-18871,16020,1649346155842 in 2 mins, 37.672 sec 2022-04-09 14:44:11,697 INFO  [PEWorker-1] procedure2.ProcedureExecutor: Finished pid=33950, ppid=33615, state=SUCCESS, hasLock=false; TransitRegionStateProcedure table=usertable, region=5c0dac3f7410e8c91e00bcfcdc6e774a, ASSIGN in 2 mins, 38.865 sec{code}            " Fix LineLength warnings as much as possible if it can not be fixed by spotless,13437390,Resolved,Major,Fixed,02/Apr/22 05:45,09/Apr/22 15:55,,"One possible problem is the trailing comment, Like this {code} assertTrue(initialRegions .contains(RegionReplicaUtil.getRegionInfoForReplica(mergedRegions.getFirst(), 1))); // this // is // the // replica // of // the // first // region {code} Because of we limited line length, the format will be very strange and still has line length problem if some of the words are too long. Let's move them from trailing to top of the statement." Fix several indentation problems,13437779,Resolved,Major,Fixed,05/Apr/22 08:01,09/Apr/22 15:56,,"hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java hbase-endpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpointTracing.java hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RowResource.java hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRefreshRecoveredReplication.java" "BootstrapNodeManager ""failed to request region server"" warnings",13438481,Open,Major,,07/Apr/22 23:16,,2.6.0,"Warnings from HBASE-26220 (Use P2P communicate between region servers to sync the list for bootstrap node) in normal operation with some write load applied: {noformat} [01]2022-04-07T23:14:21,365 WARN  [BootstrapNodeManager] regionserver.BootstrapNodeManager: failed to request region server ip-172-31-51-4.us-west-2.compute.internal,8120,1649373044119 [01]org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Call to address=ip-172-31-51-4.us-west-2.compute.internal:8120 failed on local exception: org.apache.hadoop.hbase.exceptions.Connectio nClosedException: Connection closed [01]    at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:215) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:387) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:93) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:424) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:419) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:119) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:134) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.cleanupCalls(NettyRpcDuplexHandler.java:207) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelInactive(NettyRpcDuplexHandler.java:215) ~[hbase-client-2.5.0-SNAPSHOT.jar:2.5.0-SNAPSHOT] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:392) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:357) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:81) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelInactive(IdleStateHandler.java:277) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1405) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:901) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannel$AbstractUnsafe$7.run(AbstractChannel.java:813) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:469) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:384) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[hbase-shaded-netty-4.1.0.jar:?] [01]    at java.lang.Thread.run(Thread.java:829) ~[?:?] [01]Caused by: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Connection closed {noformat}" Upgrade surefire plugin to 3.0.0-M6,13437805,Resolved,Major,Fixed,05/Apr/22 10:52,07/Apr/22 03:37,, VerifyReplication should use region startKey to check PeerTable,13437658,Open,Major,,04/Apr/22 15:12,,," [https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java#L199] Here we miss the case: peer table has redundant data, which are all smaller than the source table first rowkey" Rewrite the counting cells part in TestMultiVersions,13437389,Resolved,Major,Fixed,02/Apr/22 05:42,03/Apr/22 15:21,,"We could just use List.size here... {code} for (@SuppressWarnings(""unused"") Cell kv : result.listCells()) { cellCount++; } {code} " Fix missing braces warnings in TestProcedureMember,13437388,Resolved,Major,Fixed,02/Apr/22 05:40,03/Apr/22 15:21,,"Just like DefaultVisibilityExpressionResolver, we have this in TestProcedureMember {code} if (member != null) try { member.close(); } catch (IOException e) { e.printStackTrace(); } {code}" Rewrite the counting rows part in TestFromClientSide4,13437387,Resolved,Major,Fixed,02/Apr/22 05:39,03/Apr/22 15:22,,"Now we add an annotation to the variable declaration in the for loop, it will lead the following result after formatting {code} for (@SuppressWarnings(""unused"") Result row : scanner) { nbRows++; } {code} It looks really strange and checkstyle also reports indentation error. Let's just rewrite it an avoiding using annotation in this way, I do not know what is a better format for this scenario." Fix missing braces warnings in DefaultVisibilityExpressionResolver,13437382,Resolved,Major,Fixed,02/Apr/22 05:23,03/Apr/22 15:22,,"It will cause incorrent indentation warnings, like this {code} if (connection != null) try { connection.close(); } catch (IOException ioe) { LOG.warn(""Failed close of temporary connection"", ioe); } {code}" Potential race condition in WorkerAssigner,13465443,Open,Minor,,24/Jun/22 05:13,,2.4.12,"Multiple SplitWALProcedures share the same WorkerAssigner instance, so there is potential race condition because the suspend and the wake method are not synchronized." Add mob info in web UI,13440649,Reopened,Minor,,20/Apr/22 09:59,,,Add mob store info in web UI. Purge references to ports 60010 and 60030 from the book,13439212,Resolved,Minor,Fixed,12/Apr/22 14:07,21/Nov/24 07:23,3.0.0-alpha-3,Pre-1.0 versions of HBase have been gone for a good long time. Take a pass over the book and update language around specific port numbers and simplify. SteppingSplitPolicy and RegionSplitRestriction can result in illegal split noise,13442811,Open,Minor,,02/May/22 15:16,,,"I set this to minor because I don't think it causes any real harm aside from log noise. But we should probably fix it up. Create a table with splits 0, 1, 2, 3, 4, 5. Then set {{hbase.regionserver.region.split_restriction.type}} to {{KeyPrefix}} and {{hbase.regionserver.region.split_restriction.prefix_length}} to 1. If you do enough writes to these regions, the SteppingSplitPolicy will try to split them. So it will try to split, for example, 1 in half. This is possible without KeyPrefix restriction, but with the restriction the split point will be truncated to value 1. The split will be submitted to the master with splitRow = 1 and that will fail because ""Split row is equal to start key: 1"" Setting up splits in this way, with the restriction, is useful for when you're adding a salt prefix to your rowkeys (i.e to better distribute timestamp rowkeys). " SFT seems to apparently tracking invalid/malformed store files,13444248,Open,Minor,,10/May/22 20:08,,,"Opening this on behalf of [~apurtell] , who first reported this issue on HBASE-26999: When running scale tests using ITLCC, the following errors were observed: {noformat} [00]2022-05-05 15:59:52,280 WARN [region-location-0] regionserver.StoreFileInfo: Skipping hdfs://ip-172-31-58-47.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestLoadCommonCrawl/9eafc10e1b5a25532a4f0adf550828fc/c/9d07757144a7404fac02e161b5bd035e because it is empty. HBASE-646 DATA LOSS? ... [00]2022-05-05 15:59:52,320 WARN [region-location-2] regionserver.StoreFileInfo: Skipping hdfs://ip-172-31-58-47.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestLoadCommonCrawl/5322c54b9a899eae03cb16e956a836d5/c/184b4f55ab1a4dbc813e77aeae1343ae because it is empty. HBASE-646 DATA LOSS? {noformat}   From some discussions in HBASE-26999, it seems that SFT has wrongly tracked an incomplete/unfinished store file.  For further context, follow the [comments thread on HBASE-26999|https://issues.apache.org/jira/browse/HBASE-26999?focusedCommentId=17533508&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17533508]." Introduce a LogRollProcedure,13441411,Open,Minor,,25/Apr/22 05:21,,,"The current log-rolling for all regionservers is based in ZK. Here is an attempt to reimplement it with procedure v2. Here are some requirements about the implementation. The procedure can be introduced as a new feature. It should remain fully compatible with previous implementations. Also, this feature can be disabled by the configuration. Currently we only use the logroll procedure when taking a backup job, so I think all code logic should be implemented in the hbase-backup module as much as possible(I'm not sure if this is the right way to do it. If you have any suggestions, please let me know). Here are some details about the implementation. *LogRollProcedure* The LogRollProcedure is used to roll WAL for all the regionservers in the cluster. It acquires the shared lock of the backup system table. *RSLogRollProcedure* The RSLogRollProcedure is used to schedule a RSLogRollRemoteProcedure for each regionserver. When the subprocedure returns, the RSLogRollProcedure will check the logrolling result in the backup system table. If failed, The RSLogRollProcedure will schedule a new RSLogRollRemoteProcedure to retry. *RSLogRollRemoteProcedure* The RSLogRollRemoteProcedure is used to send the log roll request to the remote server. This is only the first version implementation, any suggestions and feedbacks are appreciated." Add special rpc handlers for bulkload operations,13454552,Resolved,Minor,Fixed,21/Jun/22 11:28,04/Aug/22 07:49,,"Bulkload will consume a lot of resources in the cluster. We try to reduce the impact of bulkload on online services and do simple resource isolation for bulkload. !image-2022-06-22-11-47-26-963.png!" Speed up the loading of table descriptor from filesystem,13448581,Resolved,Minor,Fixed,06/Jun/22 13:09,25/Oct/22 10:05,3.0.0-alpha-3,"If there are a large number of tables in the HBase cluster, it will take a long time to fully load the table descriptor  from filesystem for the first time. In our production cluster, there were 50000 + tables. It took several minutes to load the table descriptor from filesystem. This problem seriously affects the performance of HMaster active/standby switchover. We should support concurrent loading to solve this problem." Brotli compression support,13440078,Resolved,Minor,Fixed,17/Apr/22 23:27,22/Apr/22 23:52,,"I was about to document the compression improvements upcoming in 2.5.0 and realized we lacked support for one of the major compression formats in use today. (Arguably brotli is not often used to compress data at rest, but is widely supported among web browsers and HTTP servers and clients.) Brotli support for Java is provided by Apache 2 licensed [Brotli4j|https://github.com/hyperxpro/Brotli4j] available in Maven central. It is not difficult to add it, so let's add it. There might be some advantage to opting for brotli compression when storing web data given the precomputed static dictionary of such content included in its specification. " The deleted variable cannot be printed out,13443510,Resolved,Minor,Fixed,06/May/22 02:58,15/Nov/22 16:23,,"In the deleteAction method of CleanerChore class, the delete variable cannot be printed out {code:java} LOG.trace(""Finish deleting {} under {}, deleted="", type, dir, deleted); {code}" Update related comments after HMaster can load the live RS infos from local region,13441535,Resolved,Minor,Fixed,25/Apr/22 11:59,25/Oct/22 10:04,3.0.0-alpha-3, Emit source metrics for BlockCacheExpressHitPercent,13468351,Resolved,Minor,Fixed,24/Jun/22 20:36,17/Oct/22 21:31,2.0.0,"[https://github.com/apache/hbase/blob/d447fa01ba36a11d57927b78cce1bbca361b1d52/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheStats.java#L346-L400] {code:java} public double getHitCachingRatio() { double requestCachingCount = getRequestCachingCount(); if (requestCachingCount == 0) { return 0; } return getHitCachingCount() / requestCachingCount; } {code} This code is responsible for the metric {{{}BlockCacheExpressHitPercent{}}}. The metric represents the percentage of requests which were cacheable, but not found in the cache. Unfortunately, since the counters are process-level counters, the ratio is for the lifetime of the process. This makes it less useful for looking at cache behavior during a smaller time period. The underlying counters are {{hitCachingCount}} and {{{}missCachingCount{}}}. Having access to the underlying counters allows for offline computation of the same metric for any given time period. But these counters are not emitted today from {{{}MetricsRegionServerWrapperImpl.java{}}}. Compare this to {{hitCount}} and {{missCount}} which are emitted as metrics {{blockCacheHitCount}} and {{{}blockCacheMissCount{}}}. But these are raw counts for the cache, which include requests that are not cacheable. The cacheable metrics are more interesting, since it can be common to miss on a request which is not cacheable. Interestingly, these metrics are emitted regularly as part of a log line in {{{}StatisticsThread.logStats{}}}. We should emit blockCache{{{}HitCachingCount{}}} and {{blockCacheMissCachingCount}} along with the current metrics." CME in TestRegionNormalizerWorkQueue,13446944,Resolved,Minor,Fixed,26/May/22 05:21,31/May/22 18:38,2.5.0,"FAILURE! - in org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue {noformat} [ERROR] org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.testTake Time elapsed: 0.065 s <<< ERROR! java.util.concurrent.ExecutionException: java.util.ConcurrentModificationException at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928) at org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.testTake(TestRegionNormalizerWorkQueue.java:211) Caused by: java.util.ConcurrentModificationException at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719) at java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742) at org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorkQueue.take(RegionNormalizerWorkQueue.java:192) at org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.lambda$testTake$3(TestRegionNormalizerWorkQueue.java:192) at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640) at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1632) at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175) {noformat} " TestProcedureSchedulerConcurrency.testConcurrentWaitWake is flaky,13447404,Resolved,Minor,Cannot Reproduce,29/May/22 19:35,05/Oct/22 00:13,2.5.0,"This one might be architecture specific. Pending repro on x86_64. org.apache.hadoop.hbase.procedure2.TestProcedureSchedulerConcurrency.testConcurrentWaitWake Run 1: TestProcedureSchedulerConcurrency.testConcurrentWaitWake:60->testConcurrentWaitWake:145->Object.wait:-2 » Interrupted
 Run 2: PASS " TestCoprocessorEndpointTracing.traceAsyncTableEndpoint is flaky,13447402,Resolved,Minor,Cannot Reproduce,29/May/22 19:31,05/Oct/22 00:13,2.5.0,"org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpointTracing.traceAsyncTableEndpoint
 Run 1: TestCoprocessorEndpointTracing.traceAsyncTableEndpoint:210 Expected: a collection containing (SpanKind with a name that a string containing ""COPROC_EXEC"" and SpanKind with a parentSpanId that ""d2a7bb4f52ee70a2"" and SpanData with StatusCode that is ) but: SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""ZKConnectionRegistry.getMetaRegionLocations"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""AsyncRegionLocator.getRegionLocation"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""hbase.pb.RegionServerStatusService/RegionServerReport"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""RpcServer.process"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""hbase.pb.RegionServerStatusService/RegionServerReport"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""Region.getScanner"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""hbase.pb.ClientService/Scan"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""RegionScanner.close"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""RpcServer.process"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""AsyncRegionLocator.getRegionLocation"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""hbase.pb.ClientService/ExecService"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""RpcServer.process"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""AsyncRegionLocator.getRegionLocation"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""SCAN hbase:meta"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""hbase.pb.ClientService/Scan"", SpanKind with a name that a string containing ""COPROC_EXEC"" name was ""traceAsyncTableEndpoint""
 Run 2: PASS" TestMemStoreLAB is flaky,13447401,Resolved,Minor,Cannot Reproduce,29/May/22 19:29,05/Oct/22 00:13,2.5.0,"org.apache.hadoop.hbase.regionserver.TestMemStoreLAB.testLABChunkQueue Run 1: TestMemStoreLAB.testLABChunkQueue » OutOfMemory GC overhead limit exceeded Run 2: TestMemStoreLAB.testLABChunkQueue » OutOfMemory GC overhead limit exceeded Run 3: PASS org.apache.hadoop.hbase.regionserver.TestMemStoreLAB.testLABRandomAllocation Run 1: TestMemStoreLAB.testLABRandomAllocation » OutOfMemory GC overhead limit exceeded Run 2: TestMemStoreLAB.testLABRandomAllocation » OutOfMemory GC overhead limit exceeded Run 3: PASS org.apache.hadoop.hbase.regionserver.TestMemStoreLAB.testLABThreading Run 1: TestMemStoreLAB.testLABThreading:166 » Runtime Deferred Run 2: TestMemStoreLAB.testLABThreading:166 » Runtime Deferred Run 3: PASS " Quotas causes too much load on meta for large clusters,13439041,Resolved,Minor,Fixed,11/Apr/22 20:51,23/Jun/22 20:52,,"We've been upgrading larger clusters to hbase 2, and ran into this issue where two equivalent clusters (one on 1.2 and the other on 2.4.x) running almost identical workloads, but the hbase2 cluster was doing way more meta requests. One of the reasons seems to be from https://issues.apache.org/jira/browse/HBASE-21820, which added an updateQuotaFactors method to the QuotaCache QuotaRefreshChore. This new method  calls MetaTableAcessor.scanMeta for every table in the cluster. This is happening on every regionserver, so if you have many tables and/or many regionservers you can easily start sending lots of traffic to meta. One way to offset this is to reduce frequency of hbase.quota.refresh.period, but this means you are less able to quickly respond to changes in load. We should figure out a caching or notification mechanism that can reduce the need scan meta so much. It seems like we're mainly scanning meta to get a count of total regions per table, which should not be changing so often." SnapshotInfo --snapshot param is marked as required even when trying to list all snapshots,13441226,Resolved,Minor,Fixed,22/Apr/22 20:33,26/Apr/22 14:04,2.4.11,"SnapshotInfo –-list-snapshots lists all existing snapshots and doesn't need any filter, however, --snapshot param is marked as required, causing list to fail if this param is not defined. Also, the help description is a bit confusing about which options should be used together." The batch size of cleaning expired mob files should have an upper bound,13450380,Resolved,Minor,Fixed,16/Jun/22 09:14,17/Jun/22 18:13,2.4.12,"Currently the cleaning logic for expired mob files is adding all the deletable files in one directory to a list in memory and then archiving all the files in the list. But when there are millions of files need to delete, the list will be huge and make great heap memory pressure to the master." The draining region servers metric description is incorrect,13444830,Resolved,Minor,Fixed,13/May/22 11:55,17/May/22 05:20,,"The draining region servers metric description is incorrect. Fixed the description and added unit test." Optimize debug output log of ConstantSizeRegionSplitPolicy class. ,13447811,Resolved,Minor,Fixed,01/Jun/22 00:48,06/Jun/22 05:45,2.4.12,"https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java#L103 https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java#L111 The debug log should be changed to ""Should split because {} size={}, sizeToCheck={}{}""." Add “commons.crypto.stream.buffer.size” configuration ,13448506,Resolved,Minor,Fixed,06/Jun/22 06:21,21/Aug/22 14:38,,Add “commons.crypto.stream.buffer.size” configuration  in hbase when doing encryption through commonsCryptoAES. Add index and bloom filter statistics of LruBlockCache on rs web UI,13442075,Resolved,Minor,Fixed,27/Apr/22 12:26,15/Aug/22 18:15,,"When _CombinedBlockCache_ is configured, _LruBlockCache_ is used for index/bloom/meta block cache, and _BucketCache_ is used for data block cache. Index and bloom filter statistics on rs web UI will be helpful." Splitting region may become RIT for 20 minutes when meta region is moved during split,13450157,Resolved,Minor,Won't Fix,15/Jun/22 07:38,09/Aug/22 08:11,1.4.13,"When meta region is moved during region split, the spitting region may become RIT(Region in Transition) for 20 minutes. And then the RegionServer has the RIT will fail. We are facing the issue during RegionServer rolling restart on HBase 1.4.13. I found that HBase 1.7.1 has the same issue, too. It is OK on HBase 2.4.12. This is the fix." TestUpdateRSGroupConfiguration.testCustomOnlineConfigChangeInRSGroup is flaky,13447405,Resolved,Minor,Fixed,29/May/22 19:37,21/Jul/22 08:26,2.5.0,"org.apache.hadoop.hbase.rsgroup.TestUpdateRSGroupConfiguration.testCustomOnlineConfigChangeInRSGroup Run 1: TestUpdateRSGroupConfiguration.testCustomOnlineConfigChangeInRSGroup:106 expected:<1000> but was:<0> Run 2: PASS" Encryption data contains checksum,13448722,Resolved,Minor,Duplicate,07/Jun/22 07:13,21/Jul/22 10:54,,"in HFileBlockDefaultDecodingContext.prepareDecofing， we decoding data from onDiskBlock. The onDiskBlock contains byte iv length, iv data and encrypted block data if cryptoContext is not null. The encrypted block data contains two part, first part is the real encrypted block data, the second part is checksum. when we the decrypt method(BlockIOUtils.readFullyWithHeapBuffer)，the checkSum will be put into the decryptionStream. if we use others padding mode which likes pkcs5padding, the decrytion will throw an error ""Input Length must be a multiple of 16 when decrypting with a padded cipher"", because of the checkSum is not a multiple of 16. so we need to remove the checksum when we doing decrytion.  why we will not get error when we use AES/CTR/NOPPDING, because CTR is not sensitive about the block size. but the other alg such as CBC or ECB, they are sensitive about block size." IntegrationLoadTestCommonCrawl async load improvements,13448480,Resolved,Minor,Fixed,05/Jun/22 22:41,13/Jul/22 16:02,,"ITLCC improvements: - Use an async client and work stealing executor for parallelism during loads. - Remove the verification read retries, these are not that effective during replication lag anyway. - Increase max task attempts because S3 might throttle. - Implement a side task that exercises Increments by extracting urls from content and updating a cf that tracks referrer counts. These are not validated at this time. It could be possible to log the increments, sum them with a reducer, and then verify the total, but this is left as a future exercise." Improve TestMultiRespectsLimits,13468414,Resolved,Minor,Fixed,25/Jun/22 18:04,12/Jul/22 18:21,,"TestMultiRespectLimits submits puts with empty values due to what appears to be a simple mistake. See https://github.com/apache/hbase/blob/c0e7e98ec71e77a9bfccf8f59e0c7c59aa70c828/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiRespectsLimits.java#L156 Refer to https://issues.apache.org/jira/browse/HBASE-26856?focusedCommentId=17558469&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17558469 for more context. " Displays the number of decommissioned region server for status command,13444976,Resolved,Minor,Fixed,14/May/22 11:29,13/Jul/22 01:35,,"Displays the number of decommissioned region server for status command. !image-2022-05-25-18-01-20-783.png|width=232,height=78!" support commons-crypto version 1.1.0,13449169,Resolved,Minor,Fixed,09/Jun/22 07:41,06/Jul/22 11:22,,"Now the version of Commons-crypto in hbase is 1.0.0,  at its version 1.1.0 , commons-rypto  did some modification in the code level to add the support for AARCH64 and compatible with openssl 1.1.x" WAL value compression minor improvements,13468745,Resolved,Minor,Fixed,27/Jun/22 22:31,28/Jun/22 19:59,, Add namespace column family to UNDELETABLE_META_COLUMNFAMILIES,13468295,Resolved,Minor,Fixed,24/Jun/22 12:50,29/Jun/22 03:03,3.0.0-alpha-1,"If we delete the namespace family from hbase:meta, clusters can also be problematic. So I think we should also add the namespace family to the family list which can not be deleted." graceful_stop.sh should support specifing server port,13468490,Open,Minor,,27/Jun/22 06:27,,,"Right now the graceful_stop.sh script just support specify server hostname, while RS  are not necessarily deployed with default configuration,  the script is unavailable in this situation. graceful_stop.sh is based on org.apache.hadoop.hbase.util.RegionMover, the code of RegionMover support specifing port." "Change Hbase book's description for ""74.7.3. Load Balancing META table load""",13444497,Resolved,Minor,Fixed,11/May/22 23:00,24/Jun/22 18:37,2.4.12,HBASE-26618 involves primary meta region in meta scan. The description in hbase book is inaccurate. Update it accordingly. DeserializationException should be InterfaceAudience.Public,13446627,Resolved,Minor,Not A Problem,24/May/22 20:07,24/Jun/22 14:46,,"It's thrown by numerous methods in InterfaceAudience.Public classes, like TableDescriptorBuilder, Mutation#getCellVisibility, etc." Support unit test pattern matching again,13445733,Resolved,Minor,Fixed,19/May/22 00:34,20/May/22 22:09,2.5.0,"Sometimes we want to run a build with a subset of unit tests to be executed over multiple modules, like: {{mvn clean install -DskipITs -Dtest=Test*Encode*}} which will execute some tests in common, some in server, etc. but not in checkstyle, which fails {noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (default-test) on project hbase-checkstyle: No tests matching pattern ""Test*Encode*"" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1] [ERROR] {noformat} We already set {{failIfNoTests}} to false in the surefire configuration. Apparently {{failIfNoSpecifiedTests}} is also necessary to support the above. When {{failIfNoSpecifiedTests}} is specified in the configuration or on the command line, surefire behaves as expected. This behavior has changed in branch-2.5 and up. Open to suggestions for other solutions." Region Visualizer is blank if master and regionserver are on the same host,13447400,Open,Minor,,29/May/22 19:15,,2.5.0,"This is similar to HBASE-27066 reported by [~tomscut] . HBASE-27066 was applied to branch-2.5 before this test. I have a test configuration where all daemons are running on the same host: the NN, a DN, one ZK peer, a master, a regionserver, the test client (ltt). Go to [http://localhost:8110/master-status,] the UI is functioning normally except the Region Visualizer is empty, even though there is one table active. {noformat} hbase:001:0> list_regions 'cluster_test' SERVER_NAME | REGION_NAME | START_KEY | END_KEY | SIZE | REQ | LOCALITY | --------------------------------------- | --------------------------------------------------------------------- | ---------- | ---------- | ----- | -------- | ---------- | buildbox.localdomain,8120,1653851244365 | cluster_test,,1653804780151.bd73ddb4f821e5242da509d81f708a17. | | 33333333 | 8258 | 0 | 1.0 | buildbox.localdomain,8120,1653851244365 | cluster_test,33333333,1653804780151.0c213c693af504e7da65e9b77e0e01dc. | 33333333 | 66666666 | 8258 | 0 | 1.0 | buildbox.localdomain,8120,1653851244365 | cluster_test,66666666,1653804780151.85cd0bd82ab83afe3effeb0f8615185a. | 66666666 | 99999999 | 8254 | 0 | 1.0 | buildbox.localdomain,8120,1653851244365 | cluster_test,99999999,1653804780151.6996cee2e337abdaa66bcd639aad2a52. | 99999999 | cccccccc | 8254 | 0 | 1.0 | buildbox.localdomain,8120,1653851244365 | cluster_test,cccccccc,1653804780151.c84740760cf19c558353142cd26aae9b. | cccccccc | | 8259 | 0 | 1.0 | 5 rows Took 0.3243 seconds {noformat} !Screen Shot 2022-05-29 at 12.14.03 PM.png! " Fix link for field comments,13448890,Resolved,Minor,Fixed,08/Jun/22 01:21,22/Jun/22 01:33,,Fix link for field `REJECT_BATCH_ROWS_OVER_THRESHOLD` comments. TestReplicationSource.testReplicationSourceInitializingMetric is flaky,13445736,Resolved,Minor,Fixed,19/May/22 01:05,22/Jun/22 12:25,2.5.0,"1 second appears to be not enough time for slow or loaded test hosts: {noformat} TestReplicationSource.testReplicationSourceInitializingMetric Time elapsed: 1.021 s <<< FAILURE! java.lang.AssertionError: Waiting timed out after [1,000] msec at org.junit.Assert.fail(Assert.java:89) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:203) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:135) at org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testReplicationSourceInitializingMetric(TestReplicationSource.java:576) {noformat} " Add a shell command for flushing master local region,13444646,Resolved,Minor,Fixed,12/May/22 15:03,21/Jun/22 05:38,3.0.0-alpha-3,"As the data in the ‘master:store’ table becomes more and more important, it is necessary to add a shell command to manually trigger the flush operation on this table." "In the HFileBlock class, the log printing fspread/fsread cost time unit should be milliseconds",13448907,Resolved,Minor,Fixed,08/Jun/22 03:33,20/Jun/22 16:27,2.3.7,"In the HFileBlock class   {code:java} protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset, long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum, boolean updateMetrics, boolean intoHeap) throws IOException { ... long startTime = EnvironmentEdgeManager.currentTime(); ...  long duration = EnvironmentEdgeManager.currentTime() - startTime; if (updateMetrics) { HFile.updateReadLatency(duration, pread); } ...  LOG.trace(""Read {} in {} ns"", hFileBlock, duration); ... }{code} But Environment EdgeManager.currentTime returns milliseconds.    " when open archiveRetries totalLogSize calculation mistake,13450539,Resolved,Minor,Fixed,17/Jun/22 06:37,20/Jun/22 15:59,2.5.0,"When open archiveRetries archiveLogFile() retrun IOException ""totalLogSize"" calculation mistake" Update the method comments for RegionServerAccounting,13449895,Resolved,Minor,Fixed,14/Jun/22 01:43,17/Jun/22 00:21,,"After HBASE-15787, the return value type of RegionServerAccounting#isAboveHighWaterMark and RegionServerAccounting#isAboveLowWaterMark are no longer boolean." Publish code coverage reports to SonarQube,13438155,Resolved,Minor,Fixed,06/Apr/22 11:18,16/Jun/22 11:48,,"We need to be able to publish code coverage results to SonarQube, it would be useful to create a script to do it." [HBOSS] compile against hadoop 3.3.2+ only,13447542,Resolved,Minor,Fixed,30/May/22 14:40,16/Jun/22 11:36,,"to get openFile and other things to work safely, hboss needs to be changed so it only builds against hadoopp 3.3 only. " add Netty epoll support for aarch64,13449719,Open,Minor,,13/Jun/22 03:27,,,"epoll can only enable on AMD64 server, it should be more smart, can be enable only if the epoll ablitity check is passed!" PerformanceEvaluation support encryption option,13437414,Resolved,Minor,Fixed,02/Apr/22 09:15,11/Jun/22 13:42,,"hbase support tranparent encryption, but encryption option is not in PerformanceEvaluation's options.  we can add an option  `–encryption AES` which looks like `–compression xxx` in PE to support encrytion writing." CellComparator should extend Serializable,13445026,Resolved,Minor,Fixed,15/May/22 18:05,06/Jun/22 21:50,2.4.12,"Prior to HBASE-18945, CellComparator was a class which implemented Serializable. In that jira, an interface was extracted with the intent of making the implementation IA.Private. This broke some downstream consumers, so the new CellComparator interface was made IA.Public in HBASE-19160. One remaining breakage from that change is that if someone is using CellComparator in spark it will fails because it's not serializable. Everything in spark needs to be serializable, and the old CellComprator class used to extend Serializable. There was some small discussion in HBASE-18945 about removing Serializable, but I don't think anyone thought of this use-case. The failure is: Job aborted due to stage failure: Task not serializable: java.io.NotSerializableException: org.apache.hadoop.hbase.CellComparatorImpl We should make CellComparator extend Serializable, or have CellComparatorImpl implement it." Some methods of MasterRegion should be annotated for testing only,13445037,Resolved,Minor,Fixed,16/May/22 00:21,02/Jun/22 14:18,, Lower some DEBUG level logs in ReplicationSourceWALReader to TRACE,13447766,Resolved,Minor,Fixed,31/May/22 18:46,31/May/22 19:56,2.5.0,"See https://issues.apache.org/jira/browse/HBASE-21505?focusedCommentId=17544085&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17544085 {quote} For ReplicationSourceWALReader#addEntryToBatch, empty Edit entry log was changed from TRACE/DEBUG as part of this Jira to improve the visibility apparently: ... One of the clusters where I am running heavy workload, I keep seeing these logs with very high frequency {quote}" Fix typo for metric drainingRegionServers,13445322,Resolved,Minor,Fixed,17/May/22 06:03,22/May/22 07:06,,"Fix typo for metric drainingRegionServers. `draininigRegionServers` -> `drainingRegionServers`.  " The layout of the Web interface is broken,13446910,Open,Minor,,26/May/22 01:36,,,"I deployed a cluster with version 3.0.0-alpha-3-SNAPSHOT. The layout of the Web interface is broken. Version 2.3.2: !image-2022-05-26-09-36-20-478.png|width=895,height=101! {color:#ff0000}Version 3.0.0-alpha-3-SNAPSHOT:{color} !image-2022-05-26-09-35-42-909.png|width=870,height=92!" Add additional comments when using HBASE_TRACE_OPTS with standalone mode,13445924,Resolved,Minor,Fixed,20/May/22 00:05,24/May/22 16:36,2.5.0,"it was a minor problem caused by HBASE-26363 that if operator or developer wants to use HBASE_TRACE_OPTS in standalone, they will need to configure the HBASE_OPTS with appending HBASE_TRACE_OPTS parameter, otherwise, HBASE_TRACE_OPTS will not be used by the HBASE_OPTS and do not load the {{-Dotel.traces.exporter=none -Dotel.metrics.exporter=none}} https://github.com/apache/hbase/blob/master/bin/hbase#L511 {code} HBASE_OPTS=""$HBASE_OPTS -javaagent:$agent_jar"" {code}" hboss doesn't compile against hadoop branch-3.3 now that s3guard is cut,13445170,Resolved,Minor,Fixed,16/May/22 12:38,23/May/22 21:07,,"HBoss doesn't compile against hadoop builds containing HADOOP-17409, ""remove s3guard"", as test setup tries to turn it off. there's no need for s3guard any more, so hboss can just avoid all settings and expect it to be disabled (hadoop 3.3.3. or earlier) or removed (3.4+) (hboss version is 1.0.0-alpha2-SNAPSHOT)" Decrease memory copy when decompress data,13445532,Open,Minor,,18/May/22 02:27,,,"HBase RegionServer use createDecompressionStream in class org.apache.hadoop.hbase.io.compress.Compression, which cause extra memory copy during decompression.We can offer interface for block decompression, like ""void decompress(ByteBuff src, ByteBuff dst);"", and offer default implementation for all algorithms." Optimize the log display of the ZKProcedureUtil.java,13445066,Resolved,Minor,Fixed,16/May/22 03:45,17/May/22 07:31,3.0.0-alpha-3,!image-2022-05-16-11-51-14-326.png! Fix spotless warn for master branch,13444118,Resolved,Minor,Fixed,10/May/22 07:24,11/May/22 06:37,,"Fix spotless warn for master branch. We can see the spotless warn at [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/1/artifact/yetus-general-check/output/branch-spotless.txt].  There are some compile tasks that fail because of this." Optimize log format for PerformanceEvaluation,13443597,Resolved,Minor,Fixed,06/May/22 10:15,11/May/22 05:33,,"The logs in PerformanceEvaluation look a little confusing to new users, we should optimize the format. Before: !image-2022-05-06-18-13-50-763.png|width=787,height=156! After: !image-2022-05-06-18-15-13-913.png|width=674,height=147!" cache region locations when getAllRegionLocations(),13438809,Resolved,Minor,Fixed,10/Apr/22 18:01,22/Apr/22 19:35,2.4.11,"When get all table region locations from meta, we can cache the result." Fix log format for ServerManager,13443856,Resolved,Minor,Fixed,08/May/22 14:29,08/May/22 20:49,,"A space is missing from the ServerManager log. !ServerManagerLog.jpg|width=919,height=128!" HMaster page style display confusion,13438919,Resolved,Minor,Fixed,11/Apr/22 10:58,05/May/22 14:32,2.4.12, Add default implementation for BufferedMutator interface setters,13442510,Resolved,Minor,Fixed,29/Apr/22 12:42,03/May/22 19:13,,"HBASE-20812 added default implementations to a bunch of the ""optional"" methods of Table interface. This is very useful for downstream users who might create delegate table implementations. Some of the BufferedMutator interface methods also have default implementations, but setRpcTimeout, setOperationTimeout, getWriteBufferSize do not." "TestStochasticLoadBalancer has some slow methods, and inconsistent set, reset, unset of configuration",13442437,Resolved,Minor,Fixed,29/Apr/22 05:39,02/May/22 18:47,2.0.0,"Some test ordering issues were exposed by adding new tests in HBASE-22349. I think this is a legitimate issue which is tracked in HBASE-26988. But we can update the tests to be consistent in how they update configuration to reduce confusion, removing the {{unset}} calls. We can also update other configuration values to significantly speed up the long-running methods. Methods that are simply checking for balancer plans do not need to {{runMaxSteps}}. All we need to do is run enough steps to guarantee we will plan to move one region. That can be far fewer than the tens of millions of steps we may be running given {{runMaxSteps}}." Brotli compressor has unexpected behavior during reinitialization,13442595,Resolved,Minor,Fixed,29/Apr/22 23:10,30/Apr/22 16:13,2.5.0,"Due to a copy and paste error in BrotliCompressor#reinit we can reallocate a direct buffer instead of an on heap buffer. Not a functional problem right now but in all other cases the allocation is a heap buffer so could be a future surprise, and is in any case incorrect. " Balancer should reset to default setting for hbase.master.loadbalance.bytable if dynamically reloading configuration,13442431,Resolved,Minor,Fixed,29/Apr/22 04:22,29/Apr/22 22:54,2.0.0,"# Set {{hbase.master.loadbalance.bytable}} to {{true}} in {{hbase-site.xml}} # Start HMaster # Remove {{hbase.master.loadbalance.bytable}} entry in {{hbase-site.xml}} # Dynamically reload configuration for hmaster (https://hbase.apache.org/book.html#dyn_config) *Expected:* load balancing would no longer happen by table *Actual:* load balancing still happens by table *Workaround:* leave the entry in {{hbase-site.xml}} but explicitly set to {{false}} *Note 1*: The steps may only work if the config value is not in {{hbase-default.xml}} so it may be an unlikely scenario. *Note 2*: I see this when running tests added in HBASE-22349, depending on the order of execution of test methods. If {{testSloppyTablesLoadBalanceByTable}} executes before {{testBalanceOfSloppyServers}} there will be a failure. We could apply the workaround to the tests (explicitly set to {{false}}), but it seems better to fix the dynamic reconfiguration behavior. Regardless, I will propose test fixes in HBASE-26989." cache region locations when getAllRegionLocations() for branch-2.4+,13440469,Resolved,Minor,Fixed,19/Apr/22 15:52,30/Apr/22 02:07,2.4.11,backport HBASE-26942 to branch-2.4 and branch-2.5 Add on heap and off heap memstore info in rs web UI,13441499,Resolved,Minor,Fixed,25/Apr/22 10:39,28/Apr/22 15:17,,"There are _Memstore Size_ and _Memstore Limit_ info in rs-status page. The information is a little coarse granularity and confusing: * _Memstore Size_ means memstore data size, but we cannot tell the difference of on heap and off heap memstore data size. * _Memstore Limit_ is off heap memstore limit if off-heap is enabled, otherwise, it is on heap memstore limit.  We should provide more detailed information." Update inmemory_compaction.adoc,13441817,Resolved,Minor,Fixed,26/Apr/22 13:06,28/Apr/22 15:02,,"The default value of _hbase.hregion.compacting.memstore.type_ was changed from _BASIC_ to _DEFAULT_ by [HBASE-20539|https://issues.apache.org/jira/browse/HBASE-20539]. We should update its doc _inmemory_compaction.adoc_ accordingly." StoreFileListFile logs frequent stacktraces at INFO level,13441919,Resolved,Minor,Fixed,26/Apr/22 22:51,28/Apr/22 01:04,2.5.0,"In StoreFileListFile we have: {code} } catch (EOFException e) { // this is normal case, so use info and do not log stacktrace LOG.info(""Failed to load track file {}: {}"", trackFiles[i], e.toString()); } {code} except that we see frequent stacktraces at INFO level from StoreFileListFile and this appear to be the culprit. " Fix java import in admin.rb,13440826,Resolved,Minor,Fixed,21/Apr/22 04:21,21/Apr/22 17:44,,"The java_import for MobCompactPartitionPolicy in admin.rb is missed, which cause an error message for creating table. {code:bash} hbase:006:0> create 't2', {NAME => 'f', IS_MOB => true, MOB_THRESHOLD => 1000000, MOB_COMPACT_PARTITION_POLICY => 'weekly'} ERROR: uninitialized constant Hbase::Admin::MobCompactPartitionPolicy Did you mean?  Hbase::Admin::MOB_COMPACT_PARTITION_POLICY For usage try 'help ""create""' Took 0.6897 seconds hbase:007:0> {code}" Update committer guide around merging from GitHub,13439199,Resolved,Minor,Duplicate,12/Apr/22 13:10,19/Apr/22 14:10,,"The committer guide in [https://hbase.apache.org/book.html#_guide_for_hbase_committers] seems to focus mostly on committing patch files that were uploaded to jira. There are some brief mentions of GitHub, but I think these days GitHub is the primary mode of contributing. Correct me if I'm wrong. If so, I think we should update the docs with instructions from a GitHub-centric workflow.  I'd be happy to update our guide, but I will need help on collecting the basic steps since I don't know how to do it myself yet." Remove some checks in checkstyle,13437386,Open,Minor,,02/Apr/22 05:33,,,"After enableing spotless, maybe we can remove some checks in checkstyle as it is useless now, such as indentation check. The spotless plugin will try its best to format the code, and if checkstyle still think it is not suitable, we have no way to improve. This is an example: {code} public ScreenView transitionToFieldScreen(Screen screen, Terminal terminal) { return new FieldScreenView(screen, terminal, topScreenModel.getCurrentSortField(), topScreenModel.getFields(), fieldDisplayMap, (sortField, fields, fieldDisplayMap) -> { topScreenModel.setSortFieldAndFields(sortField, fields); this.fieldDisplayMap.clear(); this.fieldDisplayMap.putAll(fieldDisplayMap); }, topScreenView); } {code} I think the indentation is very clear to human but checkstyle reports the 'topScreenModel.setSortFieldAndFields(sortField, fields);' should have indentation 6 instead of 8. In the same file, there is another example {code} return new InputModeScreenView(screen, terminal, row, ""add filter #"" + (topScreenModel.getFilters().size() + 1) + "" ("" + (ignoreCase ? ""ignoring case"" : ""case sensitive"") + "") as: [!]FLD?VAL"", topScreenModel.getFilterHistories(), (inputString) -> { if (inputString.isEmpty()) { return topScreenView; } if (!topScreenModel.addFilter(inputString, ignoreCase)) { return goToMessageMode(screen, terminal, row, ""Unacceptable filter expression""); } paging.init(); return topScreenView; }); {code} Checkstyle reports the indentation for ' if (inputString.isEmpty()) {' should be 6 instead of 8, but for me I think the current indentation is more clear for human. So after reviewing all the indentation problem and tweaking the eclipse formatter, I think we could remove the indentation check in our checkstyle config." Update downloads.xml for release 2.4.12,13443807,Resolved,Trivial,Fixed,07/May/22 18:16,07/May/22 18:17,, Fix typos in ZKUtil,13450627,Open,Trivial,,17/Jun/22 14:16,,,"Two typos in hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java: {code:java} * Creates the specified node containing specified data, iff the node does not exist. Does not set * Creates the specified node, iff the node does not exist. Does not set a watch and fails {code} iff -> if" "CallDroppedException message says ""server 0.0.0.0 is overloaded""",13439478,In Progress,Trivial,,13/Apr/22 14:56,,,"This is not a super useful error when seen on the client side. Maybe we can have it pull in the ServerName instead, or at the very least resolve to the hostname.   https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java#L213" Upgrade pyjwt to version 2.4.0 or later for dev-support/git-jira-release-audit,13447278,Resolved,Trivial,Fixed,27/May/22 20:54,31/May/22 18:54,,"Dependabot says Upgrade pyjwt to fix 1 Dependabot alert in dev-support/git-jira-release-audit/requirements.txt Upgrade pyjwt to version 2.4.0 or later. For example: pyjwt>=2.4.0 " Minor compression performance improvements,13444086,Resolved,Trivial,Fixed,10/May/22 02:07,14/May/22 01:31,,"TRACE level logging is expensive enough to warrant removal. They were useful during development but now are just overhead. {noformat} 1270039022 4.07% 127 jbyte_disjoint_arraycopy {noformat} e.g. {noformat} [ 0] jbyte_disjoint_arraycopy [ 1] org.slf4j.impl.Reload4jLoggerAdapter.isTraceEnabled [ 2] org.slf4j.impl.Reload4jLoggerAdapter.trace [ 3] org.apache.hadoop.hbase.io.compress.aircompressor.HadoopCompressor.setInput [ 4] org.apache.hadoop.io.compress.BlockCompressorStream.write [ 5] java.io.OutputStream.write [ 6] com.salesforce.hbase.util.TestUtils.outputStreamTest [ 7] com.salesforce.hbase.util.TestUtils.outputStreamTest [ 8] com.salesforce.hbase.BenchmarkAircompressorLz4.test [ 9] com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_avgt_jmhStub [10] com.salesforce.hbase.jmh_generated.BenchmarkAircompressorLz4_test_jmhTest.test_AverageTime {noformat} Also we unnecessarily create new LZ4 compressor and decompressor instances in the reset() methods." Update javadoc of BucketCache.java,13441952,Resolved,Trivial,Fixed,27/Apr/22 03:18,28/Apr/22 15:14,,"The feature of on-heap Bucket cache was removed by [HBASE-19187|https://issues.apache.org/jira/browse/HBASE-19187]. We should update its javadoc which now is inaccurate and confusing." "Typo in admin.rb ""COMPRESSION_COMPACT_MAJPR""",13438486,Resolved,Trivial,Fixed,07/Apr/22 23:58,08/Apr/22 00:01,,"{noformat} ERROR: uninitialized constant Java::OrgApacheHadoopHbase::HColumnDescriptor::COMPRESSION_COMPACT_MAJPR Did you mean? Java::OrgApacheHadoopHbase::HColumnDescriptor::COMPRESSION_COMPACT_MINOR Java::OrgApacheHadoopHbase::HColumnDescriptor::COMPRESSION_COMPACT_MAJOR Java::OrgApacheHadoopHbase::HColumnDescriptor::COMPRESSION_COMPACT {noformat}" [Documentation] Fix log parameter error and spelling error,13437434,Resolved,Trivial,Fixed,02/Apr/22 11:58,04/Apr/22 12:32,2.4.0,"In ConstantSizeRegionSplitPolicy.isExceedSize(), ''' if (size > sizeToCheck) { LOG.debug(""ShouldSplit because {} size={}, sizeToCheck={}{}"", store.getColumnFamilyName(), StringUtils.humanSize(size), StringUtils.humanSize(sizeToCheck)); return true; } ''' There should be only three parameters, remove last '{}'" hbase-connectors mvn install error,13320811,Closed,Blocker,Duplicate,04/Aug/20 08:56,01/Feb/21 13:42,,"*when maven command-line* mvn -Dspark.version=2.2.2 -Dscala.version=2.11.7 -Dscala.binary.version=2.11 -Dcheckstyle.skip=true -Dmaven.test.skip=true clean install will return error {color:red}[ERROR]{color} [Error] F:\hbase-connectors\spark\hbase-spark\src\main\scala\org\apache\hadoop\hbase\spark\datasources\HBaseTableScanRDD.scala:216: overloaded method value addTaskCompletionListener with alternatives: (f: org.apache.spark.TaskContext => Unit)org.apache.spark.TaskContext (listener: org.apache.spark.util.TaskCompletionListener)org.apache.spark.TaskContext does not take type parameters {color:red}[ERROR] {color}one error found *but use the spark.version=2.4.0 is ok* mvn -Dspark.version=2.4.0 -Dscala.version=2.11.7 -Dscala.binary.version=2.11 -Dcheckstyle.skip=true -Dmaven.test.skip=true clean install *other try* mvn -Dspark.version=3.0.0 -Dscala.version=2.12.12 -Dscala.binary.version=2.12 -Dcheckstyle.skip=true -Dmaven.test.skip=true clean install return error {color:red}[ERROR]{color} [Error] F:\hbase-connectors\spark\hbase-spark\src\main\scala\org\apache\hadoop\hbase\spark\HBaseContext.scala:439: object SparkHadoopUtil in package deploy cannot be accessed in package org.apache.spark.deploy [ERROR] [Error] F:\hbase-connectors\spark\hbase-spark\src\main\scala\org\apache\hadoop\hbase\spark\HBaseContext.scala:487: not found: value SparkHadoopUtil {color:red}[ERROR]{color} two errors found go to the [spark @github|https://github.com/apache/spark/blob/e1ea806b3075d279b5f08a29fe4c1ad6d3c4191a/core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala] define SparkHadoopUtil to private[spark] {code:java} private[spark] class SparkHadoopUtil extends Logging {} {code} " Not able to access Flink 1.7.2 with HBase 2.0.0 included in HDP cluster 3.0.1,13322358,Resolved,Blocker,Invalid,12/Aug/20 20:09,13/Aug/20 10:35,2.0.0,"* I am not able to access Flink 1.7.2 with HDP 3.0.1 * The YARN version is 3.1.1 and HBASE is 2.0.0 * Flink is successfully getting mounted on Yarn and showing it as RUNNING.  * But in actual when I try to test my code, it is showing below error. * The .tgz which I used is  [flink-1.7.2-bin-hadoop27-scala_2.11.tgz|https://archive.apache.org/dist/flink/flink-1.7.2/flink-1.7.2-bin-hadoop27-scala_2.11.tgz] * The reason for the failure is w.r.t HDP 3.0.1, the associated HBase-Client (""org.apache.hbase:hbase-client:2.0.0"")  is still not in sync with Flink-Hbase_2.11-1.7.2 as the HTable.class  constructor is completely removed in this version as those respective classes still uses that and throws below I/O exception. * Please find the logs and screenshots for more info.     ---------**********************************************************--------d--------------------                                           HERE ARE THE LOGS BELOW *org.apache.flink.runtime.client.JobExecutionException: Failed to submit job cbb64a9b4e2e3ad0167eb4ceeb53ac87 (Flink Java Job at Tue Aug 11 10:10:47 CEST 2020) at* org.apache.flink.runtime.jobmanager.JobManager.org$apache$flink$runtime$jobmanager$JobManager$$submitJob(JobManager.scala:1325) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.jobmanager.JobManager$$anonfun$handleMessage$1.applyOrElse(JobManager.scala:447) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LeaderSessionMessageFilter$$anonfun$receive$1.applyOrElse(LeaderSessionMessageFilter.scala:38) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:33) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:28) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:123) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LogMessages$$anon$1.applyOrElse(LogMessages.scala:28) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at akka.actor.Actor$class.aroundReceive(Actor.scala:502) ~[akka-actor_2.11-2.4.20.jar:?] at org.apache.flink.runtime.jobmanager.JobManager.aroundReceive(JobManager.scala:122) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526) ~[akka-actor_2.11-2.4.20.jar:?] at akka.actor.ActorCell.invoke(ActorCell.scala:495) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.run(Mailbox.scala:224) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.exec(Mailbox.scala:234) ~[akka-actor_2.11-2.4.20.jar:?] at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) ~   *[scala-library-2.11.11.jar:?]Caused by: org.apache.flink.runtime.JobException: Creating the input splits caused an error: connection is closed at org.apache.flink.runtime.executiongraph.ExecutionJobVertex.*(ExecutionJobVertex.java:262) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.executiongraph.ExecutionGraph.attachJobGraph(ExecutionGraph.java:810) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.executiongraph.ExecutionGraphBuilder.buildGraph(ExecutionGraphBuilder.java:180) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.jobmanager.JobManager.org$apache$flink$runtime$jobmanager$JobManager$$submitJob(JobManager.scala:1277) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.jobmanager.JobManager$$anonfun$handleMessage$1.applyOrElse(JobManager.scala:447) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LeaderSessionMessageFilter$$anonfun$receive$1.applyOrElse(LeaderSessionMessageFilter.scala:38) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:33) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:28) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:123) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LogMessages$$anon$1.applyOrElse(LogMessages.scala:28) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at akka.actor.Actor$class.aroundReceive(Actor.scala:502) ~[akka-actor_2.11-2.4.20.jar:?] at org.apache.flink.runtime.jobmanager.JobManager.aroundReceive(JobManager.scala:122) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526) ~[akka-actor_2.11-2.4.20.jar:?] at akka.actor.ActorCell.invoke(ActorCell.scala:495) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.run(Mailbox.scala:224) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.exec(Mailbox.scala:234) ~[akka-actor_2.11-2.4.20.jar:?] at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) ~   *[scala-library-2.11.11.jar:?]Caused by: java.io.IOException: connection is closed at org.apache.hadoop.hbase.MetaTableAccessor.getMetaHTable(MetaTableAccessor.java:263) ~[hbase-client-2.0.0.jar:2.0.0] at* org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:761) ~[hbase-client-2.0.0.jar:2.0.0] at org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:680) ~[hbase-client-2.0.0.jar:2.0.0] at org.apache.hadoop.hbase.MetaTableAccessor.scanMetaForTableRegions(MetaTableAccessor.java:675) ~[hbase-client-2.0.0.jar:2.0.0] at org.apache.hadoop.hbase.client.HRegionLocator.listRegionLocations(HRegionLocator.java:156) ~[hbase-client-2.0.0.jar:2.0.0] at org.apache.hadoop.hbase.client.HRegionLocator.getStartEndKeys(HRegionLocator.java:122) ~[hbase-client-2.0.0.jar:2.0.0] at org.apache.flink.addons.hbase.AbstractTableInputFormat.createInputSplits(AbstractTableInputFormat.java:205) ~[flink-hbase_2.11-1.4.2.jar:1.4.2] at org.apache.flink.addons.hbase.AbstractTableInputFormat.createInputSplits(AbstractTableInputFormat.java:44) ~[flink-hbase_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.executiongraph.ExecutionJobVertex.(ExecutionJobVertex.java:248) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.executiongraph.ExecutionGraph.attachJobGraph(ExecutionGraph.java:810) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.executiongraph.ExecutionGraphBuilder.buildGraph(ExecutionGraphBuilder.java:180) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.jobmanager.JobManager.org$apache$flink$runtime$jobmanager$JobManager$$submitJob(JobManager.scala:1277) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.jobmanager.JobManager$$anonfun$handleMessage$1.applyOrElse(JobManager.scala:447) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LeaderSessionMessageFilter$$anonfun$receive$1.applyOrElse(LeaderSessionMessageFilter.scala:38) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:33) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at org.apache.flink.runtime.LogMessages$$anon$1.apply(LogMessages.scala:28) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:123) ~[scala-library-2.11.11.jar:?] at org.apache.flink.runtime.LogMessages$$anon$1.applyOrElse(LogMessages.scala:28) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at akka.actor.Actor$class.aroundReceive(Actor.scala:502) ~[akka-actor_2.11-2.4.20.jar:?] at org.apache.flink.runtime.jobmanager.JobManager.aroundReceive(JobManager.scala:122) ~[flink-runtime_2.11-1.4.2.jar:1.4.2] at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526) ~[akka-actor_2.11-2.4.20.jar:?] at akka.actor.ActorCell.invoke(ActorCell.scala:495) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.run(Mailbox.scala:224) ~[akka-actor_2.11-2.4.20.jar:?] at akka.dispatch.Mailbox.exec(Mailbox.scala:234) ~[akka-actor_2.11-2.4.20.jar:?] at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979) ~[scala-library-2.11.11.jar:?] at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107) ~[scala-library-2.11.11.jar:?]" [Build] branch-1's build seems broken because of pylint,13316738,Resolved,Blocker,Fixed,14/Jul/20 16:38,16/Jul/20 15:19,, regions opened in read only mode failed when replaying the edits due to permission denied WRITE for regionDir,13316270,Open,Blocker,,11/Jul/20 05:27,,,"Open region in read only mode, [HbaseTableSnapshotInputFormat], if RegionDir has  recovered edits files under, (filesUnderRootDir),  when read-only region read the content, it will try to delete the content of recovered edits,  including filesUnderRootDir part {code:java} // code placeholder for (Path file : filesUnderRootDir) { if (!rootFS.delete(file, false)) { LOG.error(""Failed delete of {}"", file); } else { LOG.debug(""Deleted recovered.edits file={}"", file); } } {code} however, read-only mode usually no WRITE access to delete it. {code:java} // code placeholder org.apache.hadoop.security.AccessControlException: Permission denied: user=xxxx, access=WRITE, inode=""/hbase/data/default/TABLENAME/d6777e449ed4d137b6a2f735653a7c3a/recovered.edits"":hbase:hbase:drwxr-xr-x {code} it will throw excption and failed      " Improve HFileOutputFormat2 to avoid always call getTableRelativePath method,13319906,Resolved,Critical,Fixed,29/Jul/20 06:43,03/Aug/20 08:03,3.0.0-alpha-1,"Bulkload use HFileOutputFormat2 to write HFile In the HFileOutputFormat2.RecordWriter in the write method always called the getTableRelativePath method each time This is unnecessary " review Jenkins build artifacts,13324152,Resolved,Critical,Fixed,23/Aug/20 14:20,01/Feb/22 16:04,,"Post move to the ci-hadoop build servers we are now the biggest user of space. That is not a problem in and of itself, but the master node has run out of disk space twice now. As of this snapshot we are using 125GB of storage and the next largest project is only using 20GB. https://paste.apache.org/kyrds We should review our builds for any issues and come up with expectations for what our steady-state disk usage should look like * we are supposed to compress any test logs (usually this gets us 90-99% space savings) * we are supposed to clean up workspaces when jobs are done * we are supposed to keep a fixed window of prior builds (either by days or number of runs) If all of our jobs are currently following these guidelines, another possibility is to push the artifacts we need over to [nightlies.a.o|https://nightlies.apache.org/authoring.html]. Barring that, we should formally request asf infra set up [a plugin for storing artifact on s3|https://plugins.jenkins.io/artifact-manager-s3/]." WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used with multi operation,13326181,Resolved,Critical,Fixed,06/Sep/20 10:22,22/Jul/21 03:10,2.0.0,"After bugfix HBASE-22539, When client use BufferedMutator or multiple mutation , there will be one RpcCall and mutliple FSWALEntry .  At the time RpcCall finish and one FSWALEntry call release() , the remain FSWALEntries may trigger RuntimeException or segmentation fault . We should use RefCnt  instead of AtomicInteger for org.apache.hadoop.hbase.ipc.ServerCall.reference?" HBASE shell update_config doesn't work for master node,13325636,Open,Critical,,01/Sep/20 23:01,,2.3.1,"The helper message says:  Reload a subset of configuration on server 'servername' where servername is host, port plus startcode. For example: host187.example.com,60020,1289493121758 See http://hbase.apache.org/book.html#dyn_config for more details. Here is how you would run the command in the hbase shell: hbase> update_config 'servername'   But the command doesn't update config on master.    " CellComparator perf improvement,13321912,Resolved,Critical,Fixed,11/Aug/20 02:45,28/Dec/20 17:11,2.0.0,"We have multiple perf issues in 2.x versions compared to 1.x. Eg: HBASE-24754, HBASE-24637. The pattern is clear that where ever we do more and more Cell compares, there is some degrade. In HBASE-24754, with an old KVComparator style comparator, we see much better perf for the PutSortReducer. (Again the gain is huge because of large number of compare ops that test is doing). This issue is to address and optimize compares generally in CellComparatorImpl itself." make a drop-in compatible impl of htrace APIs that does not do anything,13320258,Resolved,Critical,Fixed,30/Jul/20 18:46,05/Feb/21 18:56,1.4.0,"htrace-core4 is a retired project and even on the latest version they Shade Jackson databind version 2.4.0 which has the following CVEs: |cve|severity|cvss| |CVE-2017-15095|critical|9.8| |CVE-2018-1000873|medium|6.5| |CVE-2018-14718|critical|9.8| |CVE-2018-5968|high|8.1| |CVE-2018-7489|critical|9.8| |CVE-2019-14540|critical|9.8| |CVE-2019-14893|critical|9.8| |CVE-2019-16335|critical|9.8| |CVE-2019-16942|critical|9.8| |CVE-2019-16943|critical|9.8| |CVE-2019-17267|critical|9.8| |CVE-2019-17531|critical|9.8| |CVE-2019-20330|critical|9.8| |CVE-2020-10672|high|8.8| |CVE-2020-10673|high|8.8| |CVE-2020-10968|high|8.8| |CVE-2020-10969|high|8.8| |CVE-2020-11111|high|8.8| |CVE-2020-11112|high|8.8| |CVE-2020-11113|high|8.8| |CVE-2020-11619|critical|9.8| |CVE-2020-11620|critical|9.8| |CVE-2020-14060|high|8.1| |CVE-2020-14061|high|8.1| |CVE-2020-14062|high|8.1| |CVE-2020-14195|high|8.1| |CVE-2020-8840|critical|9.8| |CVE-2020-9546|critical|9.8| |CVE-2020-9547|critical|9.8| |CVE-2020-9548|critical|9.8|   Our security team is trying to block us from using hbase because of this" CompactingMemStore.timeOfOldestEdit error update,13324746,Resolved,Critical,Fixed,27/Aug/20 03:03,10/Sep/20 16:51,2.2.5,"when use 'flush in memory', update timeOfOldestEdit every flush in memory, cause PeriodicMemStoreFlusher to not take effect, wals not free, constant backlog until maxlogs  triggers forced flush, makes failure recovery slower" CatalogFamilyFormat/MetaTableAccessor.parseRegionInfoFromRegionName incorrectly setEndKey to regionId,13329021,Resolved,Critical,Fixed,23/Sep/20 15:46,27/Sep/20 04:17,,"The return value of RegionInfo.parseRegionName does not contain endKey, but we call setEndKey with fields[2], which is incorrect. It is the region id actually." Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName,13327202,Resolved,Critical,Fixed,12/Sep/20 09:50,14/Sep/20 07:20,,"It will cause resource leak. Th good news is that this method is only used for cluster maintainance, such as assign or unassign region manually, so it is less hurt. Anyway, we should fix it ASAP." The pre commit job fails to archive surefire reports,13321713,Resolved,Critical,Fixed,10/Aug/20 00:56,10/Aug/20 03:21,,"{noformat} 01:59:48 /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2212@tmp/durable-332ef1d8/script.sh: 4: /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2212@tmp/durable-332ef1d8/script.sh: [[: not found 01:59:48 + echo No archived files, skipping compressing. 01:59:48 No archived files, skipping compressing. {noformat} " Should not use AssignmentManager to test whether a table is enabled or not,13328663,Resolved,Major,Fixed,22/Sep/20 01:37,30/Dec/24 12:10,,"Now in our code base sometimes we use AssignmentManager to test whether a table is enabled or not, it is just a delegation to the TableStateManager. Let's use TableStateManager directly." Add 2.2.6 to download page,13327807,Resolved,Major,Fixed,16/Sep/20 07:44,16/Sep/20 12:10,, Refuse to update configuration of default group,13318865,Resolved,Major,Fixed,23/Jul/20 07:49,18/Dec/24 14:09,3.0.0-alpha-1,"In the current scenario, we didn't store the default rsgroup information. But after HBASE-24431 , we have added a config map, which need to be persisted to avoid lossing config of default rsgroup. So refuse to update configuration of default group" AssignRegionHandler uses EventType.M_RS_CLOSE_META instead of EventType.M_RS_OPEN_META for meta region,13315262,Resolved,Major,Fixed,06/Jul/20 23:42,18/Dec/24 14:07,,This results in openMetaRegion always be executed in closeMetaExecutor. Make the cost functions optional for StochastoicBalancer,13326741,Resolved,Major,Fixed,09/Sep/20 21:19,13/Sep/20 09:00,,"StochastoicBalancer takes a long time to generate a plan for larger clusters. We want to make the cost functions optional. hbase.master.balancer.stochastic.regionCountCost: 0 hbase.master.balancer.stochastic.primaryRegionCountCost: 0 hbase.master.balancer.stochastic.tableSkewCost: 0 hbase.master.balancer.stochastic.rackLocalityCost:0 hbase.master.balancer.stochastic.readRequestCost: 0 hbase.master.balancer.stochastic.cpRequestCost: 0 hbase.master.balancer.stochastic.writeRequestCost: 0 hbase.master.balancer.stochastic.regionReplicaHostCostKey: 0 hbase.master.balancer.stochastic.memstoreSizeCost: 0 hbase.master.balancer.stochastic.storefileSizeCost: 0 hbase.master.balancer.stochastic.regionReplicaRackCostKey: 0 hbase.master.balancer.stochastic.serverLocalityCost:0   This will turn off all cost functions To keep some of them, we just need to set some to positive value" API cleanup for 3.0.0,13322869,Open,Major,,15/Aug/20 12:27,,,An umbrella issue to track the removing the deprecated methods. ReplicationSource should clear buffer usage on ReplicationSourceManager upon termination,13320733,Resolved,Major,Fixed,03/Aug/20 19:20,12/Jan/21 23:59,2.2.6,"Following investigations on the issue described by [~elserj] on HBASE-24779, we found out that once a peer is removed, thus killing peers related *ReplicationSource* instance, it may leave *ReplicationSourceManager.totalBufferUsed* inconsistent. This can happen if *ReplicationSourceWALReader* had put some entries on its queue to be processed by *ReplicationSourceShipper,* but the peer removal killed the shipper before it could process the pending entries. When *ReplicationSourceWALReader* thread add entries to the queue, it increments *ReplicationSourceManager.totalBufferUsed* with the sum of the entries sizes. When those entries are read by *ReplicationSourceShipper,* *ReplicationSourceManager.totalBufferUsed* is then decreased. We should also decrease *ReplicationSourceManager.totalBufferUsed* when *ReplicationSource* is terminated, otherwise those unprocessed entries size would be consuming *ReplicationSourceManager.totalBufferUsed __*indefinitely, unless the RS gets restarted. This may be a problem for deployments with multiple peers, or if new peers are added.**" checkAndPut (or checkAndMutate) might return false when the row is mutated successfully,13329775,Open,Major,,28/Sep/20 15:55,,1.2.11,"In the client, when the MutateRequest times out, we retry the operation in org.apache.hadoop.hbase.client.RpcRetryingCallerImpl#callWithRetries. If the server received the request but the client failed to get a response, the server returns processed=false  because the value is already there. So the value false is returned, even though the checkAndPut was successful in the first attempt. It should return true if processed=false because it's already been processed AND it is a retry operation.   Example RpcRetryingCallerImpl inside checkAndPut:                        request client  -------{-}{{-}}o{{-}}{-}--------> server    client  --------------------> server (processing)   client  --------------------> server (processed) (timed out)                         retry request client  -------{-}{{-}}o{{-}}{-}--------> server    client  --------------------> server (processing)   client   ------------------> server (already processed)                        response (processed = false) client  <-----{-}{{-}}o{{-}}{-}------- server   checkAndPut returns false, even though it's successful.   In 2.1.0, I could only reproduce it three times by accident, but it always happened in 1.2.11. In 2.1.0, I could only reproduce it systematically by cleaning the response with the debugger before it got to the hconnection thread. Repro steps * Create a breakpoint in the exception in org.apache.hadoop.hbase.client.RpcRetryingCallerImpl#callWithRetries to make sure we get the exception and retry. * Create an infinite loop to create different rows with checkAndPut. * Start running with the disabled breakpoints. * Enable the breakpoint. * Pause all threads and verify that we are waiting for a response in the IPC thread. Wait for 1-2 minutes. This will cause a timeout. * Continue and verify that an exception is triggered. * Add a breakpoint to verify the response. * Continue and check the response and the returned value." HBase on Cloud Blob FS : Provide config to skip HFile archival while table deletion ,13314977,Open,Major,,04/Jul/20 07:42,,,"When we delete a table as part of delete of table from FS, we do below things 1. Rename to table directory to come under /hbase/.tmp. This is an atomic rename op 2. Go through each of HFiles under every region:cf and archive that one by one. (Rename the file from .tmp path to go to /hbase/archive) 3. Delete the table dir under .tmp dir In case of HDFS this is not a big deal as every rename op is just a meta op (Though the HFiles archival is a costly only as there will be so many calls to NN based the table's regions# and total storesfiles#) But on Cloud blob based FS impl, this is a concerning op. Every rename will be a copy blob op. And we are doing it twice per each of the HFiles in this table ! The proposal here is to provide a config option (default to false) to skip this archival step. We can provide another config to even avoid the .tmp rename? The atomicity of the Table delete can be achieved by HM side procedure and proc WAL. In table delete the 1st step is to delete the table form META anyways " Auto scale RSGroup,13319111,Open,Major,,24/Jul/20 07:45,,3.0.0-alpha-1,"In current use, if RSs go offline or online, we must manually move RSs in or out RSGroups. Now we can configure how many servers rsgroups need base on HBASE-24431 , and then add an AutoScaleChore to periodically check and move servers." Export necessary modules when running under JDK11,13328093,Resolved,Major,Fixed,17/Sep/20 17:06,08/Jun/23 13:33,2.3.0,"Running on JDK11, I noticed this in the debug logging. It looks like netty is using {{sun.misc.Unsafe}} instead of the new location on jdk11. {noformat} 2020-09-17 00:21:53,318 DEBUG org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0: jdk.internal.misc.Unsafe.allocateUninitializedArray(int): unavailable java.lang.IllegalAccessException: class org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0$6 cannot access class jdk.internal.misc.Unsafe (in module java.base) because module java.base does not export jdk.internal.misc to unnamed module @78461bc4 at java.base/jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:361) at java.base/java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:591) at java.base/java.lang.reflect.Method.invoke(Method.java:558) at org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0$6.run(PlatformDependent0.java:335) at java.base/java.security.AccessController.doPrivileged(Native Method) at org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent0.(PlatformDependent0.java:326) at org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent.isAndroid(PlatformDependent.java:289) at org.apache.hbase.thirdparty.io.netty.util.internal.PlatformDependent.(PlatformDependent.java:92) at org.apache.hbase.thirdparty.io.netty.channel.epoll.Native.loadNativeLibrary(Native.java:228) at org.apache.hbase.thirdparty.io.netty.channel.epoll.Native.(Native.java:58) at org.apache.hbase.thirdparty.io.netty.channel.epoll.Epoll.(Epoll.java:39) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.(EpollEventLoop.java:51) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.newChild(EpollEventLoopGroup.java:150) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.newChild(EpollEventLoopGroup.java:35) at org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:84) at org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:58) at org.apache.hbase.thirdparty.io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:47) at org.apache.hbase.thirdparty.io.netty.channel.MultithreadEventLoopGroup.(MultithreadEventLoopGroup.java:59) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.(EpollEventLoopGroup.java:112) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.(EpollEventLoopGroup.java:99) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoopGroup.(EpollEventLoopGroup.java:76) at org.apache.hadoop.hbase.util.NettyEventLoopGroupConfig.(NettyEventLoopGroupConfig.java:58) at org.apache.hadoop.hbase.regionserver.HRegionServer.setupNetty(HRegionServer.java:713) at org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:569) at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:524) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) at org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:3054) at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:236) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3072) {noformat} We should try to make this new API accessible to netty for future compatibility." Another solution for Splittable Meta,13324449,Resolved,Major,Won't Fix,25/Aug/20 11:24,08/Jan/21 13:26,,For implementing splittable meta with a master local region to store the 'root table'. Purge protobuf java 2.5.0 dependency,13318952,Resolved,Major,Fixed,23/Jul/20 13:35,24/Jul/20 03:50,,"On master branch, we have removed the hbase-protocol module so in general, we do not need to depend on protobuf 2.5.0 directl. Especially for hadoop 3.3.0, hadoop will not depend on 2.5.0 any more, we should make sure hbase do not introduce protobuf 2.5.0 too." Clean up peer metrics when disabling peer,13319692,Resolved,Major,Fixed,28/Jul/20 07:35,28/Feb/23 10:43,2.2.5,"  Supposed that we have an peer with id 1,  when execute shell cmd disable_peer  '1'  and enable_peer '1', then i can see the SizeOfLogQueue metric of all regionservers   +1 ,  after 10 times disable_peer ops  , it will increase to 11, and  it will never decrease to 1 in fulture .   I can see the function ReplicationSourceManager.refreshSources(peerId) is called , it will terminate the previous replication source and create a new one.  and found the note  //Do not clear metrics in the bellow code block: {code:java} ReplicationSourceInterface toRemove = this.sources.put(peerId, src); if (toRemove != null) { LOG.info(""Terminate replication source for "" + toRemove.getPeerId()); // Do not clear metrics toRemove.terminate(terminateMessage, null, false); } {code}  this cause the wrong number of sizeOfLogQueue, i think it's a sub issue of (HBASE-23231)" 'Stuck' in static initialization creating RegionInfo instance,13323155,Resolved,Major,Fixed,18/Aug/20 05:45,20/Sep/20 09:29,2.3.1,"We ran into the following deadlocked server in testing. The priority handlers seem stuck across multiple thread dumps. Seven of the ten total priority threads have this state: {code:java} ""RpcServer.priority.RWQ.Fifo.read.handler=5,queue=1,port=16020"" #82 daemon prio=5 os_prio=0 cpu=0.70ms elapsed=315627.86s allocated=3744B defined_classes=0 tid=0x00007f3da0983040 nid=0x62d9 in Object.wait() [0x00007f3d9bc8c000] java.lang.Thread.State: RUNNABLE at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3327) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1491) at org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:3143) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3478) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:44858) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code} The anomalous three are as follows: h3. #1 {code:java} ""RpcServer.priority.RWQ.Fifo.write.handler=0,queue=0,port=16020"" #77 daemon prio=5 os_prio=0 cpu=175.98ms elapsed=315627.86s allocated=2153K defined_classes=14 tid=0x00007f3da0ae6ec0 nid=0x62d4 in Object.wait() [0x00007f3d9c190000] java.lang.Thread.State: RUNNABLE at org.apache.hadoop.hbase.client.RegionInfo.(RegionInfo.java:72) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3327) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1491) at org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2912) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:44856) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318){code} ...which is the creation of the UNDEFINED in RegionInfo here: {color:#808000}@InterfaceAudience.Public{color}{color:#000080}public interface {color}RegionInfo {color:#000080}extends {color}Comparable { RegionInfo {color:#660e7a}UNDEFINED {color}= RegionInfoBuilder.newBuilder(TableName.valueOf({color:#008000}""__UNDEFINED__""{color})).build();   h3. #2 {code:java} ""RpcServer.priority.RWQ.Fifo.read.handler=4,queue=1,port=16020"" #81 daemon prio=5 os_prio=0 cpu=53.85ms elapsed=315627.86s allocated=81984B defined_classes=3 tid=0x00007f3da0981590 nid=0x62d8 in Object.wait() [0x00007f3d9bd8c000] java.lang.Thread.State: RUNNABLE at org.apache.hadoop.hbase.client.RegionInfoBuilder.(RegionInfoBuilder.java:49) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toRegionInfo(ProtobufUtil.java:3231) at org.apache.hadoop.hbase.regionserver.RSRpcServices.executeOpenRegionProcedures(RSRpcServices.java:3755) at org.apache.hadoop.hbase.regionserver.RSRpcServices.lambda$executeProcedures$2(RSRpcServices.java:3827) at org.apache.hadoop.hbase.regionserver.RSRpcServices$$Lambda$173/0x00000017c0e40040.accept(Unknown Source) at java.util.ArrayList.forEach(java.base@11.0.6/ArrayList.java:1540) at java.util.Collections$UnmodifiableCollection.forEach(java.base@11.0.6/Collections.java:1085) at org.apache.hadoop.hbase.regionserver.RSRpcServices.executeProcedures(RSRpcServices.java:3827) at org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:34896) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code} which is here creating meta MetaRegionInfo..   {color:#000080}public static final {color}RegionInfo {color:#660e7a}FIRST_META_REGIONINFO {color}= {color:#000080}new {color}MutableRegionInfo({color:#0000ff}1L{color}, TableName.{color:#660e7a}META_TABLE_NAME{color}, RegionInfo.{color:#660e7a}DEFAULT_REPLICA_ID{color});   h3. #3 {code:java} ""RpcServer.priority.RWQ.Fifo.read.handler=8,queue=1,port=16020"" #85 daemon prio=5 os_prio=0 cpu=0.50ms elapsed=315627.85s allocated=1960B defined_classes=0 tid=0x00007f3da0d851d0 nid=0x62dc in Object.wait() [0x00007f3d9b989000] java.lang.Thread.State: RUNNABLE at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toRegionInfo(ProtobufUtil.java:3231) at org.apache.hadoop.hbase.regionserver.RSRpcServices.executeOpenRegionProcedures(RSRpcServices.java:3755) at org.apache.hadoop.hbase.regionserver.RSRpcServices.lambda$executeProcedures$2(RSRpcServices.java:3827) at org.apache.hadoop.hbase.regionserver.RSRpcServices$$Lambda$173/0x00000017c0e40040.accept(Unknown Source) at java.util.ArrayList.forEach(java.base@11.0.6/ArrayList.java:1540) at java.util.Collections$UnmodifiableCollection.forEach(java.base@11.0.6/Collections.java:1085) at org.apache.hadoop.hbase.regionserver.RSRpcServices.executeProcedures(RSRpcServices.java:3827) at org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:34896) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code} ... which is here in code {color:#000080}if {color}(tableName.equals(TableName.{color:#660e7a}META_TABLE_NAME{color}) && replicaId == defaultReplicaId) { {color:#000080}return {color}RegionInfoBuilder.{color:#660e7a}FIRST_META_REGIONINFO{color}; }   The thread dump does not seem to recognize the above as a deadlock.   ...at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3327) is doing the below: {color:#000080}return this{color}.{color:#660e7a}onlineRegions{color}.get(encodedRegionName); ... where onlineRegions is concurrent Map of String to HRegion.        " make sure the next hbase 1.y release has Hadoop 2.10 as a minimum version,13328855,Resolved,Major,Fixed,22/Sep/20 19:37,14/Jan/21 18:00,,"Our reference guide list of prerequisites still has Hadoop 2.8 and 2.9 listed for HBase 1 releases. * [hadoop 2.8 is EOM|https://lists.apache.org/thread.html/r348f7bc93a522f05b7cce78a911854d128a6b1b8bd8124bad4d06ce6%40%3Cuser.hadoop.apache.org%3E] * [hadoop 2.9 is EOM|https://lists.apache.org/thread.html/r16b14cce9504f7a9d228612c6b808e72d8dd20863c78be51a7e04ed5%40%3Cuser.hadoop.apache.org%3E] The current list in the reference guide for HBase 1.6 is just the 1.5 list copied. we should update it to remove 2.8 and 2.9 and make sure we're no longer doing build/test based on those versions for branch-1." Backport HBASE-16283 to branch-1,13326583,Resolved,Major,Won't Fix,09/Sep/20 03:33,09/Aug/22 07:59,1.4.13, Backport to branch-1 HBASE-20561 The way we stop a ReplicationSource may cause the RS down,13321722,Resolved,Major,Won't Fix,10/Aug/20 03:43,09/Aug/22 07:58,,[HBASE-20561|https://issues.apache.org/jira/browse/HBASE-20561] Clear cached service kerberos ticket in case of SASL failures thrown from server side,13319071,Resolved,Major,Fixed,24/Jul/20 02:13,02/Aug/22 23:41,,"We setup a SASL connection using different mechanisms like Digest, Kerberos from master to RS for various activities like region assignment etc. In case of SASL connect failures, we try to dispose of the SaslRpcClient and try to relogin from the keytab on the client side. However the relogin from keytab method doesn't clear off the service ticket cached in memory unless TGT is about to expire within a timeframe. This actually causes an issue where there is a keytab refresh that happens because of expiry  on the RS server and throws a SASL connect error when Master reaches out to the RS server with the cached service ticket that no longer works with the new refreshed keytab. We might need to clear off the service ticket cached as there could be a credential refresh on the RS server side when handling connect failures" Add load balance logic in hbase-client to distribute read load over meta replica regions.,13330224,Closed,Major,Fixed,30/Sep/20 18:17,21/Nov/20 00:19,3.0.0-alpha-1, Improve performance of SKIP vs SEEK logic,13316788,Closed,Major,Fixed,15/Jul/20 00:27,21/Jul/20 22:51,1.7.0,"In our testing of HBase 1.3 against the current tip of branch-1 we saw a 30% slowdown in scanning scenarios. We tracked it back to HBASE-17958 and HBASE-19863. Both add comparisons to one of the tightest HBase has. [~bharathv]" Document Remote Procedure Execution,13319051,Closed,Major,Fixed,23/Jul/20 22:10,29/Jul/20 14:46,,"The doc in ServerRemoteProcedure, the main class is good. I said I'd give it a tuneup now we've a few impls of this feature. I want to doc in the code rather than in refguide since it devs who would use it." Ignore TestAsyncTableRSCrashPublish,13322199,Closed,Major,Fixed,12/Aug/20 06:47,07/Dec/21 03:07,,"[ERROR] Failures: [ERROR] TestAsyncTableRSCrashPublish.test:94 Waiting timed out after [60,000] msec   I meet this failure many times when runAllTests. And other developers meet this too when vote RC. Let's ignore this first and enable this after parent issue resolved." Direct insert HFiles and Persist in-memory HFile tracking,13318393,Closed,Major,Implemented,21/Jul/20 05:22,24/Dec/21 02:07,3.0.0-alpha-1,"We propose a new feature (a new store engine) to remove the {{.tmp}} directory used in the commit stage for common HFile operations such as flush and compaction to improve the write throughput and latency on object stores. Specifically for S3 filesystems, this will also mitigate read-after-write inconsistencies caused by immediate HFiles validation after moving the HFile(s) to data directory. Please see attached for this proposal and the initial result captured with 25m (25m operations) and 1B (100m operations) YCSB workload A LOAD and RUN, and workload C RUN result. The goal of this JIRA is to discuss with the community if the proposed improvement on the object stores use case makes senses and if we miss anything should be included. Improvement Highlights 1. Lower write latency, especially the p99+ 2. Higher write throughput on flush and compaction 3. Lower MTTR on region (re)open or assignment 4. Remove consistent check dependencies (e.g. DynamoDB) supported by file system implementation" Small Updates to Functionality of Shell IRB Workspace,13320418,Closed,Major,Fixed,31/Jul/20 13:38,18/Aug/20 20:15,3.0.0-alpha-1,"There are a few amendments I want to make to the first patch for shell IRB workspaces: # Hide the new warning: ""irb: warn: can't alias help from irb_help."" # Split Shell::Shell#eval_io into eval_io and exception_handler. This will be a better separation of concerns for both usage and testing. ## Why is this change so important? At the moment, eval_io may raise SystemExit, which would cause the ruby test executor to quit without running all tests. The method eval_io also used to refer to a global variable $fullTraceback, which is a poor separation of concerns. # Allow finding script2run in the load path. While undocumented, the 2.x shell did this, so we may need to do this for compatibility." "Generalize MasterRegistry, etc to support both Master and Regionserver",13327613,Open,Major,,15/Sep/20 08:02,,,"Creating a jira to capture a discussion in [HBASE-11288|https://issues.apache.org/jira/browse/HBASE-11288?focusedCommentId=17194403&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17194403]. The discussion came out of avoiding the master from being part of the read/write path. As per [~andrew.purtell@gmail.com] ""Generalizing the work to ""bootstrap servers"" that could be operating in either of master or regionserver roles seems fine but please let's make that a new JIRA or at least its own subtask."" This is currently a place holder if HBASE-11288 implementation of split meta goes in as it would not make sense to add it otherwise. If it does I will get to implementing this then. " Splittable Meta: Generalize handling of meta regions to support splittable meta,13328959,Open,Major,,23/Sep/20 09:46,,, Edit of log messages around async WAL Replication; checkstyle fixes; and a bugfix,13328304,Closed,Major,Fixed,18/Sep/20 19:43,22/Sep/20 17:14,,"Edit of  logging around region replicas: shortening and adding context. Checkstyle fixes in edited files while I was in there. Bug fix in AssignRegionHandler – was using M_RS_CLOSE_META to open a Region instead of a M_RS_OPEN_META.   Main reason for this issue is making the substantial adjacent  issue HBASE-25055 smaller in size/easier to review." Add ReplicationSource for meta WALs; add enable/disable when hbase:meta assigned to RS,13327962,Closed,Major,Fixed,17/Sep/20 05:32,02/Oct/20 19:35,,Add ReplicationSource that feeds on hbase:meta WAL files. Add enabling this source when hbase:meta is opened and hbase:meta region replicas are configured ON. Disable the source when the hbase:meta Region moves away. Allow configuring WALEntry filters on ReplicationSource,13320964,Closed,Major,Fixed,04/Aug/20 20:54,06/Aug/20 19:37,2.4.0,"The parent issue is about enabling memstore replication of meta Regions. As-is, the ReplicationSource is hardcoded to filter out hbase:meta WALEntries; they are not forwarded for Replication. This issue is all internals making it so can create an instance of ReplicationSource with a different base set of WALEntry filters. We also add a means of filtering WALs by path name." A tool to rewrite corrupted HFiles,13323829,Resolved,Major,Feedback Received,20/Aug/20 20:22,11/Jun/22 20:19,,"Typically I have been dealing with corrupted HFiles (due to loss of hdfs blocks) by just removing them. However, It always seemed wasteful to throw away the entire HFile (which can be hundreds of gigabytes), just because one hdfs block is missing (128MB). I think there's a possibility for a tool that can rewrite an HFile by skipping corrupted blocks. There can be multiple types of issues with hdfs blocks but any of them can be treated as if the block doesn't exist: 1. All the replicas can be lost 2. The block can be corrupted due to some bug in hdfs (I've recently run into HDFS-15186 by experimenting with EC). At the simplest the tool can be a local mapreduce job (mapper only) with a custom HFile reader input that can seek to next DATABLK to skip corrupted hdfs blocks." Table regions details on master GUI display slowly.,13327759,Resolved,Major,Abandoned,16/Sep/20 01:49,11/Jun/22 19:41,2.3.2,"When a table has a large number of regions (e.g.,a single table contains more than 100,000 regions), it takes about 20 to 30 minutes to display the table regions on the master GUI, which is unacceptable to users. After testing, we find that web page rendering takes up the most time,and this can be solved by pagination query." Bulk load performance is degraded in HBase 2 ,13318610,Open,Major,,22/Jul/20 05:02,,2.2.3,"in our Test,It is observed that Bulk load performance is degraded in HBase 2 .  Test Input:  1: Table with 500 region(300 column family) 2:  data =2 TB Data Sample 18600000001201502051000000068110,18600000001,20150205,5,404,735412,2938,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111,111111111111111111111111111111111111111111111111111111111111111111111111111111111 3: Cluster: 7 node(2 master+5 Region Server)  4: No of Container Launched are same in both case HBase 2 took 10% more time then HBase 1.3 where test input is same for both cluster   |Feature|HBase 2.2.3 Time(Sec)|HBase 1.3.1 Time(Sec)|Diff%|Snappy lib:  | |BulkLoad|21837|19686.16|-10.93|Snappy lib: HBase 2.2.3: 1.4 HBase 1.3.1: 1.4|" HBase RSGroup: Table region details under RS Groups are in the onder fromat like HBase 1.x,13323813,Open,Major,,20/Aug/20 17:32,,2.2.3,"HBase RSGroup: Table region details under RS Groups are in the older format like HBase 1.x.   in HBase2, Master UI will contain table details       ||Namespace||Name||State||Regions||Description|| ||OPEN||OPENING||CLOSED||CLOSING||OFFLINE||FAILED||SPLIT||Other|| but under Regroup, table region details are different which are same as in HBase1.x   ||Namespace||Table||Stats||Online Regions||Offline Regions||Failed Regions||Split Regions||Other Regions||Description||" [hbase-thirdparty] Add jersey-hk2 when shading jersey and bump jetty to 9.4.31,13321014,Resolved,Major,Fixed,05/Aug/20 05:58,08/Aug/20 14:04,, Optimize BufferNode Lock,13324828,Patch Available,Major,,27/Aug/20 11:44,,2.2.3,"[https://github.com/apache/hbase/blob/047e0618d290a09a4a269b00548fe17691e31787/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L373] during startup, a large number of OpenRegionProcedures are generated, which are added to the BufferNode. However, the BufferNode has some ""synchronized"" methods, These methods may affect MTTR" reduce invalid subprocedure task,13324792,Patch Available,Major,,27/Aug/20 08:20,,2.2.3,"[https://github.com/apache/hbase/blob/047e0618d290a09a4a269b00548fe17691e31787/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java#L165] [https://github.com/apache/hbase/blob/047e0618d290a09a4a269b00548fe17691e31787/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/RegionServerFlushTableProcedureManager.java#L146]   if involvedRegions is null or empty, rs should skip subprocedure." "Forward port HBASE-22492 ""HBase server doesn't preserve SASL sequence number on the network"" to branch-2+",13324229,Resolved,Major,Duplicate,24/Aug/20 09:31,18/Jan/22 12:17,,Due to RPC Server refactor on branch-2+ the HBASE-22492 can not patch directly from branch-1.x. the RSGroupBasedLoadBalancer#retainAssignment throws NPE,13329107,Resolved,Major,Fixed,24/Sep/20 01:37,19/Oct/20 02:43,2.2.3,"when BaseLoadBalancer# https://github.com/apache/hbase/blob/8bfa2cb2eedcf050b26a28961e1b77dbf3cd8c95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java#L1433 If the result of the BaseLoadBalancer#retainAssignment is null, the RSGroupBasedLoadBalancer#retainAssignment will throw NPE. https://github.com/apache/hbase/blob/8bfa2cb2eedcf050b26a28961e1b77dbf3cd8c95/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java#L206" WAL replay should ignore 0-length files,13327915,Resolved,Major,Fixed,16/Sep/20 19:58,04/Nov/20 16:23,2.3.1,"I overdrove a small testing cluster, filling HDFS. After cleaning up data to bring HBase back up, I noticed all masters -refused to start- abort. Logs complain of seeking past EOF. Indeed the last wal file name logged is a 0-length file. WAL replay should gracefully skip and clean up such an empty file. {noformat} 2020-09-16 19:51:30,297 ERROR org.apache.hadoop.hbase.master.HMaster: Failed to become active master java.io.EOFException: Cannot seek after EOF at org.apache.hadoop.hdfs.DFSInputStream.seek(DFSInputStream.java:1448) at org.apache.hadoop.fs.FSDataInputStream.seek(FSDataInputStream.java:66) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.initInternal(ProtobufLogReader.java:211) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.initReader(ProtobufLogReader.java:173) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:64) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.init(ProtobufLogReader.java:168) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:323) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:305) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:293) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:429) at org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEdits(HRegion.java:4859) at org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsIfAny(HRegion.java:4765) at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1014) at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:956) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7496) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7454) at org.apache.hadoop.hbase.master.region.MasterRegion.open(MasterRegion.java:269) at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:309) at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:104) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:949) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2240) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:622) at java.base/java.lang.Thread.run(Thread.java:834) {noformat}" Reject to add a peer which replicate to itself earlier,13316805,Resolved,Major,Fixed,15/Jul/20 03:15,24/Jul/20 00:11,,"Now there are one check in ReplicationSource#initialize method {code:java} // In rare case, zookeeper setting may be messed up. That leads to the incorrect // peerClusterId value, which is the same as the source clusterId if (clusterId.equals(peerClusterId) && !replicationEndpoint.canReplicateToSameCluster()) { this.terminate(""ClusterId "" + clusterId + "" is replicating to itself: peerClusterId "" + peerClusterId + "" which is not allowed by ReplicationEndpoint:"" + replicationEndpoint.getClass().getName(), null, false); this.manager.removeSource(this); return; } {code} This check should move to AddPeerProcedure's precheck." Generic NamedQueue framework for recent in-memory history,13316354,Resolved,Major,Fixed,12/Jul/20 18:31,22/Jul/20 06:43,,"As per the discussion on parent jira, we should come up with named queue (online ring buffer) to serve recent history for multiple use-cases like slowlog, balancer decision, other region activities e.g flush, compaction, split, merge etc. Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as part of this Jira, the proposal is to refactor slowlog provider to get generic payload for ring buffer and based on event type (slow_log is the only one for now), we can have separate internal in-memory queues. After this refactor, it should be relatively simpler to use the same framework and create more cases like parent Jira (balancer decision in ring buffer)." Bootstrap should not delete the META table directory if it's not partial,13321572,Resolved,Major,Fixed,07/Aug/20 18:03,12/Oct/21 17:57,2.3.0,"this issues were discussed in [PR#2113|https://github.com/apache/hbase/pull/2113] as part of HBASE-24286, and it is a dependencies before we solve HBASE-24286. The changes were introduced in [HBASE-24471 |https://github.com/apache/hbase/commit/4d5efec76718032a1e55024fd5133409e4be3cb8#diff-21659161b1393e6632730dcbea205fd8R70-R89] that partial meta was introduced and `partial` was defined as InitMetaProcedure did not succeed and INIT_META_ASSIGN_META was not completed. {code:java} private static void writeFsLayout(Path rootDir, Configuration conf) throws IOException { LOG.info(""BOOTSTRAP: creating hbase:meta region""); FileSystem fs = rootDir.getFileSystem(conf); Path tableDir = CommonFSUtils.getTableDir(rootDir, TableName.META_TABLE_NAME); if (fs.exists(tableDir) && !fs.delete(tableDir, true)) { LOG.warn(""Can not delete partial created meta table, continue...""); } {code} however, in the cloud use case where HFiles store on S3, WALs store on HDFS, ZK data are stored within the cluster, this partial meta becomes a block when cluster recreate on existing HFiles; Here, Zk data and WALs cannot be retained (HDFS was associated with cloud instance and was terminated together) when cluster recreates on the flushed HFiles, and existing meta are always considered as partial and deleted in `INIT_META_WRITE_FS_LAYOUT` during bootstrap. As a result, the recreate cluster starts with a empty meta table, either the cluster hangs during the master initialization (branch-2) because table states of namespace table cannot be assigned, or starts as a fresh cluster without any region assigned and table opens (may need HBCK to rebuild the meta). Potential solution suggested by Anoop {quote}In case of HM start and the bootstrap we create the ClusterID and write to FS and then to zk and then create the META table FS layout. So in a cluster recreate, we will see clusterID is there in FS and also the META FS layout but no clusterID in zk. Ya seems we can use this as indication for cluster recreate over existing data. In HM start, this is some thing we need to check at 1st itself and track. If this mode is true, later when (if) we do INIT_META_WRITE_FS_LAYOUT , we should not delete the META dir. As part of the Bootstrap when we write that proc to MasterProcWal, we can include this mode (boolean) info also. This is a protobuf message anyways. So even if this HM got killed and restarted (at a point where the clusterId was written to zk but the Meta FS layout part was not reached) we can use the info added as part of the bootstrap wal entry and make sure NOT to delete the meta dir. {quote} In this JIRA, we're going to fix the `partial` definition when we found cluster ID was stored in HFiles but ZK were deleted or fresh on cluster creates." KeyPrefix related split policies should extends SteppingSplitPolicy,13314604,Resolved,Major,Implemented,02/Jul/20 06:28,09/Oct/21 07:39,,"Currently the KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy are extends IncreasingToUpperBoundRegionSplitPolicy, since we had changed the default split policy as SteppingSplitPolicy, I think it is better to change them to extends SteppingSplitPolicy too." Reduce the number builds to keep for our jenkins jobs,13324127,Resolved,Major,Won't Fix,23/Aug/20 03:56,01/Oct/21 14:15,,We eat too much space on the jenkins master node. Correct the description of hbase.offpeak.end.hour,13323553,Open,Major,,19/Aug/20 12:04,,,"The inclusive in description should be exclusive, it will mislead users. OffPeakHours.java {code:java} private static class OffPeakHoursImpl extends OffPeakHours { final int startHour; final int endHour; /** * @param startHour inclusive * @param endHour exclusive */ OffPeakHoursImpl(int startHour, int endHour) { this.startHour = startHour; this.endHour = endHour; } @Override public boolean isOffPeakHour() { return isOffPeakHour(CurrentHourProvider.getCurrentHour()); } @Override public boolean isOffPeakHour(int targetHour) { if (startHour <= endHour) { return startHour <= targetHour && targetHour < endHour; } return targetHour < endHour || startHour <= targetHour; } } {code}  " incorrect value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL,13324648,Open,Major,,26/Aug/20 12:34,,2.2.0,"[HBASE-20886|https://issues.apache.org/jira/browse/HBASE-20886] introduced constants for HBASE_CLIENT_KEYTAB_FILE and HBASE_CLIENT_KERBEROS_PRINCIPAL, however the value for HBASE_CLIENT_KERBEROS_PRINCIPAL is incorrectly assigned as ""hbase.client.keytab.principal"". The correct value should be ""hbase.client.kerberos.principal"". ""hbase.client.keytab.principal"" is inconsistent with the [previous code|https://github.com/apache/hbase/blob/rel/2.1.9/hbase-common/src/main/java/org/apache/hadoop/hbase/AuthUtil.java#L96], so clients migrating to 2.2.0 would need to update their configurations to match the incorrect value." Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature,13318905,Resolved,Major,Fixed,23/Jul/20 11:10,31/Aug/20 02:54,3.0.0-alpha-1,"In HBASE-22738 we allow tables fallback to specific rs groups, If there is no online servers in the table's rsgroup. -But for system tables, if there is no specified fallback rsgroup or the servers in the fallback rsgroup all went down, It is necessary to allow system tables fallback to any rsgroup in order to keey available at all times.- For Availability, refactor design of rsgroup fallback, finally only introduced one config property `hbase.rsgroup.fallback.enable`, allow all table, whether or not system tables, fallback to the default rsgroup first, then fallback to any group if no online servers in default rsgroup." Add new procedure metrics for master UI only,13329826,Open,Major,,29/Sep/20 03:55,,,"We will clear procedure histogram metrics if getting master metrics from path /jmx.However, some metrics in master UI, such as open/close region procedure or TRSP, make sense for a long time, and we should add new metrics, keep it and not clearing even when accessing /jmx." config 'hbase.hregion.memstore.mslab.indexchunksize' not be used,13322998,Resolved,Major,Fixed,17/Aug/20 06:17,27/Aug/20 05:23,2.2.5,"config 'hbase.hregion.memstore.mslab.indexchunksize' not be used, Invalid setting of index chunk size percentage." RegionInfo#containsRange should support check meta table,13316568,Resolved,Major,Fixed,13/Jul/20 22:35,22/Jul/21 10:31,,"Came across this when we were testing the 'split-to-hfile' feature running ITBLL:   {code:java} 2020-07-10 10:16:49,983 INFO org.apache.hadoop.hbase.regionserver.HRegion: Closing region hbase:meta,,1.15882307402020-07-10 10:16:49,997 INFO org.apache.hadoop.hbase.regionserver.HRegion: Closed hbase:meta,,1.15882307402020-07-10 10:16:49,998 WARN org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler: Fatal error occurred while opening region hbase:meta,,1.1588230740, aborting...java.lang.IllegalArgumentException: Invalid range: IntegrationTestBigLinkedList,,1594350463222.8f89e01a5245e79946e22d8a8ab4698b. > IntegrationTestBigLinkedList,\x10\x02J\xA1,1594349535271.be24dc276f686e6dcc7fb9d3f91c8387. at org.apache.hadoop.hbase.client.RegionInfoBuilder$MutableRegionInfo.containsRange(RegionInfoBuilder.java:300) at org.apache.hadoop.hbase.regionserver.HStore.tryCommitRecoveredHFile(HStore.java:1111) at org.apache.hadoop.hbase.regionserver.HRegion.loadRecoveredHFilesIfAny(HRegion.java:5442) at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1010) at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:950) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7490) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7448) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7424) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7382) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7333) at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:135) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)2020-07-10 10:16:50,005 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: ***** ABORTING region server hbasedn149.example.org,16020,1594375563853: Failed to open region hbase:meta,,1.1588230740 and can not recover *****java.lang.IllegalArgumentException: Invalid range: IntegrationTestBigLinkedList,,1594350463222.8f89e01a5245e79946e22d8a8ab4698b. > IntegrationTestBigLinkedList,\x10\x02J\xA1,1594349535271.be24dc276f686e6dcc7fb9d3f91c8387. {code} Seems basic case of wrong comparator. Below passes if I use the meta comparator {code:java} @Test public void testBinaryKeys() throws Exception { Set set = new TreeSet<>(CellComparatorImpl.COMPARATOR); final byte [] fam = Bytes.toBytes(""col""); final byte [] qf = Bytes.toBytes(""umn""); final byte [] nb = new byte[0]; Cell [] keys = { createByteBufferKeyValueFromKeyValue( new KeyValue(Bytes.toBytes(""aaaaa,\u0000\u0000,2""), fam, qf, 2, nb)), createByteBufferKeyValueFromKeyValue( new KeyValue(Bytes.toBytes(""aaaaa,\u0001,3""), fam, qf, 3, nb)), createByteBufferKeyValueFromKeyValue( new KeyValue(Bytes.toBytes(""aaaaa,,1""), fam, qf, 1, nb)), createByteBufferKeyValueFromKeyValue( new KeyValue(Bytes.toBytes(""aaaaa,\u1000,5""), fam, qf, 5, nb)), createByteBufferKeyValueFromKeyValue( new KeyValue(Bytes.toBytes(""aaaaa,a,4""), fam, qf, 4, nb)), createByteBufferKeyValueFromKeyValue( new KeyValue(Bytes.toBytes(""a,a,0""), fam, qf, 0, nb)), }; // Add to set with bad comparator Collections.addAll(set, keys); // This will output the keys incorrectly. boolean assertion = false; int count = 0; try { for (Cell k: set) { assertTrue(""count="" + count + "", "" + k.toString(), count++ == k.getTimestamp()); } } catch (AssertionError e) { // Expected assertion = true; } assertTrue(assertion); // Make set with good comparator set = new TreeSet<>(CellComparatorImpl.META_COMPARATOR); Collections.addAll(set, keys); count = 0; for (Cell k: set) { assertTrue(""count="" + count + "", "" + k.toString(), count++ == k.getTimestamp()); } }{code}" Support CheckAndMutate in Region.batchMutate(),13326405,Resolved,Major,Won't Fix,08/Sep/20 08:37,04/Nov/20 04:56,,"After HBASE-24602, Region.batchMutate() supports Put/Delete/Increment/Append operations, but it doesn't support CheckAndMutate. If we support CheckAndMutate Region.batchMutate(), we can perform Put/Delete/Increment/Append/CheckAndMutate operations atomically, which is very useful for some cases." Add heartbeat for ReplicationServer and dispatch replication sources to ReplicationServer,13329817,Resolved,Major,Incomplete,29/Sep/20 01:33,09/Jul/21 08:22,, Do not assign regions to region server which has not called regionServerReport yet,13327721,Resolved,Major,Fixed,15/Sep/20 19:29,20/May/21 06:53,,"As part of RS start up, RS reports for duty to Master . Master acknowledges the request and adds it to the onlineServers list for further assigning any regions to the RS Once Master acknowledges the reportForDuty and sends back the response, RS does a bunch of stuff like initializing replication sources etc before becoming online. However, sometimes there could be an issue with initializing replication sources when it is unable to connect to peer clusters because of some kerberos configuration and there would be a delay of around 20 mins in becoming online.   Since master considers it online, it tries to assign regions and which fails with ServerNotRunningYet exception, then the master tries to unassign which again fails with the same exception leading the region to FAILED_CLOSE state.   It would be good to have a check to see if the RS is ready to accept the assignment requests before adding it to online servers list which would account for any such delays as described above" Find a way to resolve WALFileLengthProvider#getLogFileSizeIfBeingWritten problem,13316605,Resolved,Major,Done,14/Jul/20 04:08,27/Apr/21 03:17,,"Now we use WALFileLengthProvider#getLogFileSizeIfBeingWritten to get the synced wal length and prevent replicating unacked log entries. But after offload ReplicationSource to new ReplicationServer, we need a new way to resolve this problem." STUCK RIT by hbck2 assigns,13322844,Resolved,Major,Fixed,15/Aug/20 03:08,24/Aug/20 16:23,2.2.3,"If a region has been assign to rs1 and then client assigns region again by ""hbck2 assigns"" 1、if  regionPlan is region to be assign to rs2，the region will be opened on rs1 and rs2. master log: {quote}WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: rit=OPEN, location=rs2, table=tableName, region=reionName reported OPEN on server=rs1 but state has otherwise {quote} 2、if regionPlan is region to be assign to rs1， the TransitRegionStateProcedure and OpenRegionProcedure will stuck. because rs1 is not responding to master rslog: {quote}Receiving OPEN for the region:{}, which we are already trying to OPEN - ignoring this new request for this region. {quote}  " Change default to false for HBASE-15519 per-user metrics,13319061,Resolved,Major,Fixed,24/Jul/20 00:04,03/Aug/20 18:40,2.3.0,"HBASE-15519 added a nice feature to show per-user metrics. It needs a bit of work still – see base of HBASE-15519 for notes but in particular, it can spin up lots of threads, more than makes sense  – but currently it is enabled by default. Here we disable it by setting default for hbase.regionserver.user.metrics.enabled to false." Dynamic master discovery,13319039,Resolved,Major,Fixed,23/Jul/20 19:48,26/Aug/20 16:17,2.4.0,"[~stack]'s idea in the design doc for splittable-meta. We can keep a live list of masters to query by fetching the list of available masters from any of the available masters configured in the seed list. User configured list of masters (""hbase.masters"") would be used as a seed list. The endpoints are refreshed every 5mins or if any of the registry RPCs hit an error (which ever happens first)." Backport HBASE-20417 to branch-1,13320423,Resolved,Major,Fixed,31/Jul/20 14:55,05/Aug/20 11:02,1.4.14,"The wal reader shouldn't keep running with peer disabled. We need to backport HBASE-20417 to branch-1 or do something similar, if backport isn't possible due to differences in the code base." TestLogLevel failing on hadoop-ci (branch-1),13323096,Resolved,Major,Fixed,17/Aug/20 18:58,05/Apr/21 03:50,,"TestLogLevel is failing the branch-1 builds on hadoop-ci. The test needs some improvement. The code seems to be doing the right thing but the error condition the test is expecting varies by JVM or JVM version: {noformat} Expected to find 'Unrecognized SSL message' but got unexpected exception: javax.net.ssl.SSLException: Unsupported or unrecognized SSL message {noformat}" Support MoveCostFunction use a lower multiplier in offpeak hours,13316070,Resolved,Major,Fixed,10/Jul/20 07:01,10/Aug/20 22:52,,"Currently the default multiplier of MoveCostFunction is 7, it should be lower in offpeak hours, thus balancer could do more things." Index rebuilds should record scan timestamp to job counter,13319646,Resolved,Major,Invalid,28/Jul/20 00:12,28/Jul/20 00:12,,"The index tool output tables (PHOENIX_INDEX_TOOL and PHOENIX_INDEX_TOOL_RESULT) are both keyed on the effective scan time of the index rebuild. This makes the table quite difficult to query if you know the index you're interested in but not the exact millisecond it was last rebuilt. Short term: record this timestamp in the Phoenix index rebuild job counters (this JIRA) Longer term: we might want to consider reversing the PK to both cut down on hotspotting and make the table easier to query. " Offload the replication source/sink job to independent Replication Server,13314406,Open,Major,,01/Jul/20 04:36,,,"The basic idea is add a role ""ReplicationServer"" to take the replication source/sink job. HMaster is responsible for scheduling the replication job to different ReplicationServer. [link Design doc|https://docs.google.com/document/d/16kRPVGctFSf__nC3yaVZmAm3GTxIbHefekKC_rMmTw8/edit?usp=sharing] Suggestions are welcomed. Thanks." [hbtop] Support Batch mode,13319331,Resolved,Major,Fixed,26/Jul/20 07:11,11/Sep/20 01:46,,"Similar to Unix's 'top' command, we can support Batch mode that allows us to send hbtop command output to other programs or to a file." Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider,13323351,Resolved,Major,Fixed,18/Aug/20 12:41,28/Aug/20 06:18,,In order to control the return value of getCurrentHour used by unit test. SCP reduce unnecessary get requests,13323873,Open,Major,,21/Aug/20 02:52,,2.2.3,"SCP should reduce unnecessary Get request [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L520] during startup， the tableNam2State of tableStateManager is not loading tableState data form metaTable yet.  if procThread num is 50 and hbase has 10K tables, in the worst case, the master needs to query meta table 500K times(50*10K. and the regions that all SCPs simultaneously check tableState belong to the same table )   i think master can reduce Get request, and AM#loadMeta can load regions and all tables through asynchronous threads. [https://github.com/apache/hbase/blob/65d28da7c22382e040363c607840d5ab6e6b45da/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1532]    " Rename configs that support atypical DNS set ups to put them in hbase.unsafe,13314528,Resolved,Major,Fixed,01/Jul/20 17:08,09/Nov/20 07:16,,"HBASE-18226 added a config for disabling reverse DNS checks {{hbase.regionserver.hostname.disable.master.reversedns}} and the release note calls out that the config is dangerous: {quote}he following config is added by this JIRA: hbase.regionserver.hostname.disable.master.reversedns This config is for experts: don't set its value unless you really know what you are doing. When set to true, regionserver will use the current node hostname for the servername and HMaster will skip reverse DNS lookup and use the hostname sent by regionserver instead. Note that this config and hbase.regionserver.hostname are mutually exclusive. See https://issues.apache.org/jira/browse/HBASE-18226 for more details. Caution: please make sure rolling upgrade succeeds before turning on this feature. {quote} We should make clear the risks of using this config by making sure the name starts with {{hbase.unsafe}}. Rename {{hbase.regionserver.hostname.disable.master.reversedns}} to {{hbase.unsafe.regionserver.hostname.disable.master.reversedns}} but make sure the former is kept with a ""deprecated config name"" warning." Provide an option for do-release-docker to ignore svn ci,13327724,Patch Available,Major,,15/Sep/20 20:22,,,"do-release-docker, when run with -f, tries to checkin CHANGES.md, RELEASENOTES.md and all release tarballs to svn, however if the user doesn't have svn checkin access, the script fails at svn ci step and rest of the steps in *publish-release* are left untouched. Although majority users of the script have access to checkin, we should definitely provide an option to make svn checkin step no-op (similar to dry_run mode) for users without access." [hbase-thirdparty] Remove dev_files,13323507,Resolved,Major,Fixed,19/Aug/20 07:48,24/Aug/20 03:25,,"It only contains a make_rc.sh script, but now we use the create-release scripts from the main repo, so it is useless now." [hbase-thirdparty] Add pre commit support for hbase-thirdparty,13323373,Resolved,Major,Fixed,18/Aug/20 14:43,19/Aug/20 15:49,, [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT,13319777,Resolved,Major,Fixed,28/Jul/20 14:36,24/Aug/20 03:26,, Make retain assignment configurable during SCP,13323411,Resolved,Major,Fixed,18/Aug/20 18:00,01/Feb/21 05:32,2.1.9,"HBASE-23035 change the ""retain"" assignment to round-robin assignment during SCP which will make the failover faster and surely improve the availability, but this will impact the scan performance in non-cloud scenario. This jira will make this assignment plan configurable." Unbounded org.glassfish:javax.el in hbase-server:org.glassfish.web.javax.servlet.jsp,13329043,Open,Major,,23/Sep/20 17:35,,2.2.6,"When I try to build in a fresh environment I see that pulling in hbase-server dependencies will fail. This is because the [javax.servlet.jsp-2.3.2 pom|https://repo1.maven.org/maven2/org/glassfish/web/javax.servlet.jsp/2.3.2/javax.servlet.jsp-2.3.2.pom] specifies a dependency with no upper bound for org.glassfish:javax.el which includes SNAPSHOT dependencies. One solution is to exclude that dependency and explicitly include the }}org.glassfish:javax.el{{ dep. What does the community think of that solution or should we be upgrading some other dependency? {{Failed to execute goal on project hive-hbase-handler: Could not resolve dependencies for project org.apache.hive:hive-hbase-handler:jar:3.1.2-SNAPSHOT: Failed to collect dependencies at org.apache.hbase:hbase-server:jar:tests:2.2.6-SNAPSHOT -> org.glassfish.web:javax.servlet.jsp:jar:2.3.2 -> org.glassfish:javax.el:jar:3.0.1-b06-SNAPSHOT: Failed to read artifact descriptor for org.glassfish:javax.el:jar:3.0.1-b06-SNAPSHOT: Could not transfer artifact org.glassfish:javax.el:pom:3.0.1-b06-SNAPSHOT from/to}}" Preserve mvn site output in precommit jobs,13316776,Open,Major,,14/Jul/20 21:43,,,"It would be nice to see the result of site changes in PRs. This probably balloons the size of archived builds, but we don't (usually) keep PR builds around very long." [hbase-operator-tools] hbck2 filesystem fails against hbase-2.3.x,13320004,Open,Major,,29/Jul/20 15:33,,,"{code:java} 15:23:15.323 [main] INFO org.apache.hadoop.hbase.client.ConnectionImplementation - Closing master protocol: MasterService Exception in thread ""main"" java.lang.NoSuchMethodError: 'org.apache.hadoop.fs.Path org.apache.hadoop.hbase.util.FSUtils.getRootDir(org.apache.hadoop.conf.Configuration)' at org.apache.hbase.FileSystemFsck.(FileSystemFsck.java:49) at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:720) at org.apache.hbase.HBCK2.run(HBCK2.java:631) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at org.apache.hbase.HBCK2.main(HBCK2.java:865) {code}   If build hbase-operator-tools against hbase-2.3.x its fine again. Could try putting pack the method in hbase-2.3.x or its probably worth a new release of hbase-operator-tools (last was 2018 for 1.0.0) but then it wouldn't work against 2.1 (but 2.1 is EOL'd so ok)? Probably wouldn't work against 2.2 then so maybe put back the method for 2.3?" Fan out the edits to root to backup masters,13328188,In Progress,Major,,18/Sep/20 07:15,,, Meta region assignment is blocked when all RS in meta table group are restarted.,13314892,Resolved,Major,Not A Problem,03/Jul/20 13:33,07/Jan/21 11:27,2.2.3,"This issue happened in a test cluster. The issue does not reproduce easily. But we can reproduce it with debug points in code. Steps to reproduce: # Install a HBase cluster with three RS(rs1,rs2 and rs3) and one Master # Create two rsgroups r1 and r2 and move rs1 to r1 and rs2 to r2 {code} add_rsgroup 'r1';add_rsgroup 'r2';move_servers_rsgroup 'r1',['rs1Host:16020'];move_servers_rsgroup 'r2',['rs2Host:16020'] {code} # Create a table t1 {code}create 't1','f1','f2';put't1','r1','f1:c1','v1'{code} # Start debugging master, put debug point in while loop of {code}org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.ServerEventsListenerThread#run{code} method. # Stop rs3 # When debug flow comes, wait around 30 seconds to let the meta be offline and then let the debug flow execute. By now meta will be offline as rs3 is stopped. HMaster UI will hang as meta is offline. # Now start rs3, after start meta should be online and Master UI should open. # No, still master UI hangs, then you have reproduced the issue." [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup,13318682,Resolved,Major,Fixed,22/Jul/20 11:36,06/Jan/21 14:39,2.2.3,"Move a offine RS from default RSGroup to another RSGroup. The error messge says 'Source RSGroup for server xxx does not exist.'. It's confusing. !image-2020-07-22-19-34-42-628.png!" RegexStringComparator in ParseFilter should support case-insensitive regexes,13328875,Resolved,Major,Fixed,22/Sep/20 21:41,21/Dec/20 12:57,1.6.0,"I would like to be able to set CASE_INSENSITIVE to RegexStringComparator (using thrift.)  There doesn't seem (currently) to be a way to do that.  " Release 2.3.2,13327817,Resolved,Major,Fixed,16/Sep/20 08:58,27/Sep/20 09:08,, TransitionRegionStateProcedure of non-meta regions should yield when meta is unavailable,13314752,Open,Major,,02/Jul/20 17:40,,2.3.0,"One observation from HBASE-24526 is that while meta is unavailable, other region movement procedures are getting stuck on meta RPCs. Let's make it so that non-meta transitions check the state of meta before attempting any RPCs. If meta is known unavailable, release the thread back to the scheduler." The methods in AsyncTableRegionLocator should not throw IOException directly,13325111,Resolved,Major,Fixed,29/Aug/20 04:12,04/Dec/20 03:05,,"This is an incompatible change as we changed the method signature. But anyway this is a mistake so we should fix it..." Enhance PerformanceEvaluation to profile meta replica performance.,13330226,Resolved,Major,Fixed,30/Sep/20 18:21,01/Dec/20 06:52,, BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.,13321300,Resolved,Major,Fixed,06/Aug/20 12:49,06/Aug/20 16:03,, Upgrade JQuery to 3.5.1,13325366,Resolved,Major,Fixed,31/Aug/20 17:00,01/Sep/20 17:42,,"JQuery <= 3.5.0 is subject to a known cross site scripting vulnerability. Upgrade our embedded minimized jquery library to 3.5.1. Upgrade embedded jquery-tablesorter while at it. " Add option to avoid aborting RS process upon uncaught exceptions happen on replication source,13322521,Resolved,Major,Fixed,13/Aug/20 11:31,23/Nov/20 19:37,2.4.0,"Currently, we abort entire RS process if any uncaught exceptions happens on ReplicationSource initialization. This may be too extreme on certain deployments, where custom replication endpoint implementations may choose to do so when remote peers are unavailable, but source cluster shouldn't be brought down entirely. Similarly, source reader and shipper threads would cause RS to abort on any runtime exception occurrence while running.  This patch adds configuration option (false by default, to keep the original behaviour), to avoid aborting entire RS processes under these conditions. Instead, if ReplicationSource initialization fails with a RuntimeException, it keeps retrying the source startup. In the case of readers/shippers runtime errors, it refreshes the replication source, terminating current source and its readers/shippers and creating new ones." Some changing of split region by overall region size rather than only one store size,13314401,Resolved,Major,Fixed,01/Jul/20 02:38,23/Nov/20 19:11,2.4.0,"As a distributed cluster, HBase distribute loads in unit of region, so if region grows too big, it will bring some negative effects, such as: 1. Harder to homogenize disk usage(consider locality) 2. Might cost more time on region opening 3. After split, the daughter region might lead to more io cost on compaction in a short time(if write evenly) I tried to introduce a new SteppingAllStoresSizeSplitPolicy in HBASE-24530, but after discussed in comments and related [thread|https://lists.apache.org/thread.html/r08a8103e2532eb667a0fcb4efa8a4117b3f82e6251bc4bd0bc157c26%40%3Cdev.hbase.apache.org%3E], finally we decide to change the existing split policy with a new option that if it should count all store files, and for master it would be true, else false. " [testing] HBaseCluster support ReplicationServer for UTs,13329828,Resolved,Major,Fixed,29/Sep/20 03:58,23/Nov/20 03:02,3.0.0-alpha-1, stuck InitMetaProcedure in finishActiveMasterInitialization,13323864,Open,Major,,21/Aug/20 01:23,,2.2.3,"if procWAL has InitMetaProcedure, and InitMetaProcedure state is finished, and meta znode does not exist， finishActiveMasterInitialization will stuck because during startup，If InitMetaProcedure exists, InitMetaProcedure recreates a new CountDownLatch. master jstack !image-2020-08-21-09-12-33-894.png! master log !masterLog.gif!" Create a ReplicationEndPoint for meta/root replica replication.,13330223,In Progress,Major,,30/Sep/20 18:14,,3.0.0-alpha-1, Backport HBASE-24350 and HBASE-24779 to branch-2.2 & branch-2.3,13326637,Resolved,Major,Fixed,09/Sep/20 09:20,12/Nov/20 10:27,2.2.5,"Backport HBASE-24350 and HBASE-24779 to branch-2.2 & branch-2.3.  HBASE-24779 was written on top of HBASE-24350. Whilst it is possible to manually resolve the conflict to exclude the piece of code introduced by HBASE-24350, ideally we should also include HBASE-24350 in this package of fixes, as it deals with some inconsistencies about table level metrics for replication." WAL archival to be done by a separate thread,13328251,Resolved,Major,Fixed,18/Sep/20 13:34,14/Oct/20 10:28,2.4.0,"Currently we do clean up of logs once we ensure that the region data has been flushed. We track the sequence number and if we ensure that the seq number has been flushed for any given region and the WAL that was rolled has that seq number then those WAL can be archived. When we have around ~50 files to archive (per RS) - we do the archiving one after the other. Since archiving is nothing but a rename operation it adds to the meta operation load of Cloud based FS. Not only that - the entire archival is done inside the rollWriterLock. Though we have closed the writer and created a new writer and the writes are ongoing - we never release the lock until we are done with the archiving. What happens is that during that period our logs grow in size compared to the default size configured (when we have consistent writes happening). So the proposal is to move the log archival to a seperate thread and ensure we can do some kind of throttling or batching so that we don't do archival at one shot. " ReplicationServer support start ReplicationSource internal,13328388,Resolved,Major,Fixed,20/Sep/20 02:57,09/Nov/20 05:27,, Optimize in-memory representation of mapreduce TableSplit objects,13322100,Resolved,Major,Fixed,11/Aug/20 18:41,03/Nov/20 16:05,1.7.0,"It has been observed that when the table has too many regions, MR jobs consume a lot of memory in the client. This is because we keep the region level information in memory and the memory heavy object is TableSplit because of the Scan object as a part of it. However, it looks like the TableInputFormat for single table doesn't need to store the scan object in the TableSplit because we do not use it and all the splits are expected to have the exact same scan object. In TableInputFormat we use the scan object directly from the MR conf." The table.jsp cost long time to load if the table include closed regions,13325117,Resolved,Major,Fixed,29/Aug/20 06:29,01/Nov/20 13:14,,"The reason is that, in order to get the compaction state of table, we need to iterate all regions and call getRegionInfo, the default timeout for rpc is 5000ms, so if there exists closed reigons, this line will be blocked for long time. {code:java} CompactionState compactionState = admin.getCompactionState(table.getName()).get();{code} The solution in this patch is to add compaction state to RegionMetrics, so when getting the compaction state, we could use the in memory state instead of doing rpc. Affect branch-2+, in branch-1 it will display exception stack info immediately." Remove unused credential hbaseqa-at-asf-jira,13320897,Resolved,Major,Fixed,04/Aug/20 16:22,30/Oct/20 17:49,1.7.0,"After move to ci-hadoop, branch-1 precommits are unable to checkout the source tree. https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/view/change-requests/job/PR-2194/1/console {noformat} 04:55:42 Running in /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2194/yetus [Pipeline] { [Pipeline] checkout 04:55:42 No credentials specified 04:55:42 Cloning the remote Git repository > git rev-parse HEAD^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f f9a427c6aff4f01bf06aa458a935249cfd6a5d30 # timeout=10 04:55:41 Cloning repository https://github.com/apache/yetus.git 04:55:41 > git init /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2194/yetus # timeout=10 04:55:41 Fetching upstream changes from https://github.com/apache/yetus.git 04:55:41 > git --version # timeout=10 04:55:41 > git fetch --tags --progress -- https://github.com/apache/yetus.git +refs/heads/*:refs/remotes/origin/* # timeout=10 04:55:44 Checking out Revision 11add70671de39cd96b56e86e40c64c872b9282f (rel/0.11.1) 04:55:42 > git config remote.origin.url https://github.com/apache/yetus.git # timeout=10 04:55:42 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 04:55:42 > git config remote.origin.url https://github.com/apache/yetus.git # timeout=10 04:55:42 Fetching upstream changes from https://github.com/apache/yetus.git 04:55:42 > git fetch --tags --progress -- https://github.com/apache/yetus.git +refs/heads/*:refs/remotes/origin/* # timeout=10 04:55:43 > git rev-parse rel/0.11.1^{commit} # timeout=10 04:55:43 > git rev-parse refs/remotes/origin/rel/0.11.1^{commit} # timeout=10 04:55:44 Commit message: ""YETUS-920. Stage version 0.11.1."" 04:55:44 First time build. Skipping changelog. [Pipeline] } [Pipeline] // dir [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (precommit-run) [Pipeline] withCredentials [Pipeline] // withCredentials [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Declarative: Post Actions) [Pipeline] script [Pipeline] { [Pipeline] step 04:55:45 Archiving artifacts [Pipeline] publishHTML 04:55:45 [htmlpublisher] Archiving HTML reports... {noformat}" Meta table shouldn't be modified as read only,13325840,Resolved,Major,Fixed,03/Sep/20 05:34,29/Oct/20 23:36,2.3.0,"After HBASE-23055, Alter of Meta schema is allowed. After this change meta table can be made Read only table which is not correct as per my view,because it will impact majority  of the functionality of HBase.   alter 'hbase:meta',\{METHOD=>'table_att', READONLY=>true}" Change meta replica count by altering meta table descriptor,13329416,Resolved,Major,Fixed,25/Sep/20 14:00,13/Oct/20 03:59,,"As now we support altering meta table, it will be better to also deal with changing meta replica number using altering meta, i.e, we could unify the logic in MasterMetaBootstrap to ModifyTableProcedure, and another benefit is that we do not need to restart master when changing the replica number for meta." Master manages ReplicationServers,13326439,Resolved,Major,Fixed,08/Sep/20 10:51,28/Oct/20 11:00,3.0.0-alpha-1,"In [HBASE-24683|https://issues.apache.org/jira/browse/HBASE-24683] add an isolated ReplicationServer. What this issue is to do:  # ReplicationServer reports to Master periodically. # Add a basic ReplicationServerManager in Master to manage ReplicationServer." Avoid shows closing region task when create table,13321744,Resolved,Major,Fixed,10/Aug/20 07:45,20/Oct/20 09:24,,"Currently when we create region dir, we new a HRegion and then close it, this step is before the real initialize, so there will exist a closing region task at first, it is strange, and will confuse users." MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll,13314405,Resolved,Major,Fixed,01/Jul/20 04:16,29/Sep/20 05:15,1.4.14,"when use multiwal, any a wal request roll, all wal will be together roll." Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll,13321911,Resolved,Major,Fixed,11/Aug/20 02:42,16/Oct/20 12:43,, ReplicationSourceShipper thread can not be finished,13329910,Resolved,Major,Fixed,29/Sep/20 10:43,14/Oct/20 17:38,2.2.6,"See [Flaky Tests|https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/master/161/console], some UTs about replication failed cause timeout. In [HBaseInterClusterReplicationEndpoint.sleepForRetries|https://github.com/apache/hbase/blob/78ae1f176d4215dcc34067ed25d786a4fcd4d888/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java#L203], InterruptedException is caught but no further processing, the interrupted status of the current thread is cleared. Below is the code comment of Thread.sleep. {code:java} /** * ... * * @throws InterruptedException * if any thread has interrupted the current thread. The * interrupted status of the current thread is * cleared when this exception is thrown. */ public static native void sleep(long millis) throws InterruptedException; {code} So InterruptedException must be processed, otherwise ReplicationSourceShipper thread cannot be terminated in some cases." Remove the force param for unassign since it dose not take effect any more,13322434,Resolved,Major,Fixed,13/Aug/20 02:50,14/Oct/20 02:49,,"Currently unassign region in fact only close it, so not need force param any more. " Procedure Executor doesn't handle burst well,13314767,Open,Major,,02/Jul/20 19:09,,2.2.5,"Currently, Procedure Executor checks for stuck threads every 5 sec. If >50% are stuck, one worker thread is added until maxPoolSize is reached. In a burst scenario, this cannot catch up and causes thread starvation. A smarter algorithm can be used to measure the pressure and step up automatically." Make HBCK2 work for 'root table',13326762,In Progress,Major,,10/Sep/20 00:40,,,"We will also scan catalog table and fix them in HBCK2, we should add support for root too." Cleanup unnecessary usages of MetaTableAccessor,13324281,Open,Major,,24/Aug/20 13:23,,,"For simplify the implementation of splittable meta. In general, MetaTableAccessor can not deal with the catalog information for meta itself, even if we introduce a general root table, we could make it also deal with the catalog information for meta, but then we still need to deal with root... Let's change to use other APIs if possible, for example, when getting all region locations, just use RegionLocator instead of MetaTableAccessor." Attach a design doc to code base,13327217,Open,Major,,12/Sep/20 12:56,,, Improve BlockCache read performance by specifying BlockType,13323750,Resolved,Major,Fixed,20/Aug/20 13:29,21/Aug/20 16:34,,"CombinedBlockCache contains l1Cache and l2Cache. l1Cache stores MetaBlock and l2Cache stores DataBlock. Because getBlock does not know the BlockType, the getBlock of CombinedBlockCache queries l1Cache first, and then l2Cache. But actually querying DataBlock is not necessary to query l1Cache. Therefore, in some cases where BlockType is known, BlockCache read performance can be improved. h2. Code： BlockCache: default call old getBlock {code:java} default Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, boolean repeat, boolean updateCacheMetrics, BlockType blockType) { return getBlock(cacheKey, caching, repeat, updateCacheMetrics); } {code} CombinedBlockCache: {code:java} @Override public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, boolean repeat, boolean updateCacheMetrics, BlockType blockType) { if (blockType == null) { return getBlock(cacheKey, caching, repeat, updateCacheMetrics); } boolean metaBlock = isMetaBlock(blockType); if (metaBlock) { return l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); } else { return l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); } }private boolean isMetaBlock(BlockType blockType) { return blockType.getCategory() != BlockCategory.DATA; } {code} HFileReaderImpl#getCachedBlock call BlockCache#getBlock(XXX, expectedBlockType)" Migrate our jenkins job from Hadoop to hbase,13329719,Resolved,Major,Fixed,28/Sep/20 10:30,10/Oct/20 08:19,,"We(xiaomi) will donate 10 m5.2xlarge machines to ASF so hbase could have dedicated resources for running jenkins jobs. Open issue to migrate our jenkins jobs to the new build machines. " Add MR Counters to WALPlayer; currently hard to tell if it is doing anything,13329789,Resolved,Major,Fixed,28/Sep/20 18:16,30/Sep/20 16:45,,"For example, when WALPlayer runs, it emits this: {code:java} 020-09-28 11:16:05,489 INFO [LocalJobRunner Map Task Executor #0] mapred.Task: Final Counters for attempt_local1916643172_0001_m_000000_0: Counters: 20 File System Counters FILE: Number of bytes read=268891453 FILE: Number of bytes written=1018719 FILE: Number of read operations=0 FILE: Number of large read operations=0 FILE: Number of write operations=0 Map-Reduce Framework Map input records=4375 Map output records=5369 Input split bytes=245 Spilled Records=0 Failed Shuffles=0 Merged Map outputs=0 GC time elapsed (ms)=59 Total committed heap usage (bytes)=518979584 File Input Format Counters Bytes Read=0 File Output Format Counters Bytes Written=0 {code} Change it so it does this: {code:java} 020-09-28 11:16:05,489 INFO [LocalJobRunner Map Task Executor #0] mapred.Task: Final Counters for attempt_local1916643172_0001_m_000000_0: Counters: 20 File System Counters FILE: Number of bytes read=268891453 FILE: Number of bytes written=1018719 FILE: Number of read operations=0 FILE: Number of large read operations=0 FILE: Number of write operations=0 Map-Reduce Framework Map input records=4375 Map output records=5369 Input split bytes=245 Spilled Records=0 Failed Shuffles=0 Merged Map outputs=0 GC time elapsed (ms)=59 Total committed heap usage (bytes)=518979584 org.apache.hadoop.hbase.mapreduce.WALPlayer$Counter CELLS_READ=89574 CELLS_WRITTEN=89572 DELETES=64 PUTS=5305 WALEDITS=4375 File Input Format Counters Bytes Read=0 File Output Format Counters Bytes Written=0 {code}" Per table WAL metrics: appendCount and appendSize,13328854,Resolved,Major,Fixed,22/Sep/20 18:49,24/Sep/20 04:41,1.7.0,"We were trying to drill down into WAL events at a table scope and figured that appendCount and appendSize are not exposed at a table scope. This would be a helpful metric. I ran the WAL benchmark tool with 10 threads and didn't see any measurable performance difference with the attached patch." Support changing region replica count without disabling table,13330185,Resolved,Major,Fixed,30/Sep/20 14:23,08/Oct/20 14:04,, RSGroupBalancer#assignments lost some regionPlans,13329106,Patch Available,Major,,24/Sep/20 01:18,,2.2.3,"https://github.com/apache/hbase/blob/b2f2c79d8fa18fb691e669419004cc5168b0838d/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java#L216 when fallback is enabled, servers does not contain the current group's rs, and contains the rs of other group, region will be assigend to other group, but assignments already contains targetRS, and then assignments.putAll overwrites old entry {code:java} this.internalBalancer.retainAssignment(currentAssignmentMap, candidateList) .forEach((serverName, regionInfos) -> { assignments.computeIfAbsent(serverName, s -> new ArrayList<>()) .addAll(regionInfos); }); {code} the issue exists only in the branch-2." [LOG] Log improvement in Connection#close,13315156,Resolved,Major,Fixed,06/Jul/20 12:46,21/Aug/20 13:48,2.2.3,"We met some customers used hbase connection improperly, some threads call failed since the shared connection closed by one of the threads. It's better to print the details when connection closing." "TransitionRegionStateProcedure should timeout, rollback, retry instead of waiting infinitely on CONFIRMED_OPEN",13328103,Open,Major,,17/Sep/20 17:51,,2.3.2,"Testing 2.3.2RC1 with ITBLL. The region server assigned to open meta locked up due to HBASE-24896. Meanwhile, the master waits indefinitely on a procedure {{pid=176583, ppid=176532, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED; TransitRegionStateProcedure table=hbase:meta, region=1588230740, ASSIGN}}. AssignmentManager needs a way to rescind assignment when a RS fails to complete within a reasonable timeout window, roll back the procedure, and try again with a new target." Migrate flaky reporting jenkins job from Hadoop to hbase,13329720,Resolved,Major,Fixed,28/Sep/20 10:32,28/Sep/20 12:42,, Refactor MetaTableAccessor.addRegionsToMeta and its usage places,13330082,Resolved,Major,Fixed,30/Sep/20 03:50,05/Oct/20 14:39,,"It is used in both CreateTableProcedure and ModifyTableProcedure, but in ModifyTableProcedure, we already have the region info in place so we should not put them again. There is no problem for now as we will close all the regions before doing this in ModifyTableProcedure, but it is still a bit confusing to developers. Let's change it." [HBCK2] Bypassed parent procedures are not updated in store,13327834,Resolved,Major,Fixed,16/Sep/20 09:53,05/Oct/20 14:13,,"See code in [ProcedureExecutor|https://github.com/apache/hbase/blob/master/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java#L980]: {code:java} Procedure current = procedure; while (current != null) { LOG.debug(""Bypassing {}"", current); current.bypass(getEnvironment()); store.update(procedure); // update current procedure long parentID = current.getParentProcId(); current = getProcedure(parentID); } {code}" HFilePrettyPrinter can't seek to the row which is the first row of a hfile,13329880,Resolved,Major,Fixed,29/Sep/20 08:02,04/Oct/20 10:55,2.2.6,"This issue can be reproduced by below steps: * make a hfile contains two rows '000' and '001'; {code:java} D:\bin>hbase hfile -p -f /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd K: 000/f1:a/1601282789548/Put/vlen=4/seqid=4 V: aaaa K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 V: aaaa Scanned kv count -> 2{code} * '001' can be seeked to; {code:java} D:\bin>hbase hfile -e -w 001 -f /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd K: 001/f1:a/1601282792779/Put/vlen=4/seqid=5 Scanned kv count -> 1{code} * but '000' can't be seeked to; {code:java} D:\bin>hbase hfile -e -w 000 -f /hbase/data/default/test2/df76e4acab5398e70be332f6807ec3ba/f1/fda213c556d540a58d29d6bd85931dcd Scanned kv count -> 0{code}  In HFilePrettyPrinter we use ""scanner.seekTo(PrivateCellUtil.createFirstOnRow(this.row))"" to seek to row.But this method will retrurn -1 when the row is the first row of hfile." Remove the deprecated annotation for MetaTableAccessor.getScanForTableName,13330075,Resolved,Major,Fixed,30/Sep/20 03:07,02/Oct/20 15:06,,"The comment says it is only for internal use but MetaTableAccessor is IA.Private, so it is OK to keep this method." Enable table replication fails from 1.x to 2.x if table already exist at peer. ,13326025,Resolved,Major,Fixed,04/Sep/20 06:44,01/Oct/20 08:51,2.2.3,"If source is 1.x and peer is 2.x and a default table is created at source and also at peer, default table descriptors mismatch so the enable table replication fails with error :   {code:java} Table t1 exists in peer cluster 1, but the table descriptors are not same when compared with source cluster. Thus can not enable the table's replication switch.{code} Following are the extra attributes set by default in 2.x: CACHE_DATA_ON_WRITE CACHE_INDEX_ON_WRITE CACHE_BLOOMS_ON_WRITE EVICT_BLOCKS_ON_CLOSE PREFETCH_BLOCKS_ON_OPEN. " Remove ZNodePaths.metaReplicaZNodes,13329627,Resolved,Major,Fixed,27/Sep/20 14:23,29/Sep/20 08:09,,"We have already removed the dependency on this field from client side. Now if we want to remove the META_REPLICAS_NUM field, we must remove the usage of this field first." conf and conn are assigned twice in HBaseReplicationEndpoint and HBaseInterClusterReplicationEndpoint,13329576,Resolved,Major,Fixed,27/Sep/20 02:44,29/Sep/20 00:53,3.0.0-alpha-1,"In [HBaseReplicationEndpoint.init()|https://github.com/apache/hbase/blob/c312760819ed185cab3a0717a1ea0ff6e8c47a23/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java#L109] and  [HBaseInterClusterReplicationEndpoint.init|https://github.com/apache/hbase/blob/c312760819ed185cab3a0717a1ea0ff6e8c47a23/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java#L145] , the latter is a sub-class of the former, conf and conn are assigned twice.  " "When table level quota is set and violated, pre existing ns quota policy not imposed on table.",13319840,Open,Major,,28/Jul/20 20:34,,,"When table level quota is set and violated, pre existing namespace level quota policy not imposed on table.   While removing Quota for a table, in addition to deleting from hbase:quota table, it should be removed from current state in QuotaObserverChore as well." HA masters based on raft,13318596,Open,Major,,22/Jul/20 02:44,,,"For better availability, for moving bootstrap information from zookeeper to our own service so finally we could remove the dependency on zookeeper completely. This has been in my mind for a long time, and since the there is a dicussion in HBASE-11288 about how to storing root table, and also in HBASE-24749, we want to have better performance on a filesystem can not support list and rename well, where requires a storage engine at the bottom to store the storefiles information for meta table, I think it is the time to throw this idea out. The basic solution is to build a raft group to store the bootstrap information, for now it is cluster id(it is on the file system already?) and the root table. For region servers they will always go to the leader to ask for the information so they can always see the newest data, and for client, we enable 'follower read', to reduce the load of the leader(and there are some solutions to even let 'follower read' to always get the newest data in raft). With this solution in place, as long as root table will not be in a format of region(we could just use rocksdb to store it locally), the cyclic dependency in HBASE-24749 has also been solved, as we do not need to find a place to store the storefiles information for root table any more." Remove ReplicationSourceInterface#enqueueLog method and get the new WAL to replicate from ReplicationQueueStorage directly,13316603,Open,Major,,14/Jul/20 04:00,,,"There are two choices for this now. # Start a backgroud thread and keep to read the new WAL from ReplicationQueueStorage. # The default ReplicationQueueStorage is based on ZK. Set watcher on znode and read the WAL when there are zk event. " "serial replication, addReplicationBarrier is writing to rep_barrier family even there is no serial replication peer.",13330254,Open,Major,,30/Sep/20 22:32,,,"We found that there are quite some data in rep_barrier family even there is no serial replication enabled. Checked the code,  it is checking if table has replication enabled. Think there is another check needed (i.e, is there any serial replication peers configured). [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java#L215]  " Admin supports multi region merge,13329824,Open,Major,,29/Sep/20 03:40,,2.2.3,"https://github.com/apache/hbase/blob/68b56beab744e983df0877eec9f576ef884a2807/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java#L889 from masterRpcServices and mergeProc, master supports multi region merge... but admin dont support... we can enhance it" Fetch ReplicationSink servers list from HMaster instead of ZooKeeper,13315131,Resolved,Major,Fixed,06/Jul/20 10:08,29/Sep/20 01:27,, Cleanup of unused RPC APIs in the presence of generic API getLogEntries,13328352,Resolved,Major,Fixed,19/Sep/20 12:30,28/Sep/20 07:26,,"Now that we have generic RPC API *getLogEntries* for any type of ringbuffer use-case regardless of where the ring buffer is running (Master or Regionservers), we should better clean up old use-case specific APIs: GetSlowLogResponses" WAL size in RegionServer UI is wrong,13329323,Resolved,Major,Fixed,25/Sep/20 03:07,28/Sep/20 06:13,,"In MetricsRegionServerWrapperImpl, *walFileSize* is calculated by *provider.getLogFileSize()* twice as follows, which is causing the wrong WAL size in RegionServer UI: {code:java} walFileSize = (provider == null ? 0 : provider.getLogFileSize()) + (provider == null ? 0 : provider.getLogFileSize()); {code}  " NPE while shutdown master node,13327368,Resolved,Major,Duplicate,14/Sep/20 07:08,28/Sep/20 07:46,,"while shutdown the master node, we can see the exception: {code:java} 2020-09-14 06:48:29,530 ERROR [PEWorker-16] procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception: pid=111, ppid=64, state=RUNNABLE, locked=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure java.lang.NullPointerException at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:276) at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:58) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1648) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1395) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:78) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1965) {code}" Promote 2.3.2 RC artifacts in svn,13327822,Resolved,Major,Fixed,16/Sep/20 09:03,25/Sep/20 19:26,, "hbck.jsp page loading fails, logs NPE in master log.",13328573,Resolved,Major,Fixed,21/Sep/20 14:20,27/Sep/20 06:14,2.2.3,"While testing with large data, it is observed that some time hbck page was not accessible and NPE was thrown in log.   【Test step】Excat Steps are not known. Observed this while executing below steps 1: Test data: 9K regions,~300 issues in my test setup 2: run hbck_chore and catalogjanitor_run multiple times  3: Also run balancer so that region movement is happening. 4: Observe that HBCK page not available   2020-09-21 20:05:31,706 WARN [qtp1698322791-94] server.HttpChannel: /hbck.jsp java.lang.NullPointerException at org.apache.hadoop.hbase.generated.master.hbck_jsp.formatServerName(hbck_jsp.java:37) at org.apache.hadoop.hbase.generated.master.hbck_jsp._jspService(hbck_jsp.java:144) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:844)" Avoid reset the backup master root cache every time when syncing,13327061,Resolved,Major,Fixed,11/Sep/20 10:10,21/Sep/20 12:34,,Improve the pull logic to not always reset the cache. Send announce email,13327826,Resolved,Major,Fixed,16/Sep/20 09:06,27/Sep/20 09:01,, Add 2.3.2 to the downloads page,13327825,Resolved,Major,Fixed,16/Sep/20 09:06,26/Sep/20 14:51,, "Found duplicate classes/resources in hbase-protocol-shaded 2.3.2, hbase-protocol 2.3.2",13329583,Open,Major,,27/Sep/20 03:53,,2.3.2,"i want to use hbase client to connector hbase, when i add dependency in pom.xml,   org.apache.hbase hbase-client It will report error when mvn clean install,  [WARNING]Found duplicate and different resources in [org.apche.hbase:hbase-protocol-shaded:2.3.2, org.apche.hbase:hbase-protocol:2.3.2]: [WARNING]AccessControl.proto [WARNING]Admin.proto ……" ReplicationStatisticsChore runs in wrong time unit,13329376,Resolved,Major,Fixed,25/Sep/20 10:27,26/Sep/20 12:05,3.0.0-alpha-1, Update reporter tool with new release,13327823,Resolved,Major,Done,16/Sep/20 09:04,26/Sep/20 18:29,,Reporter tool: [https://reporter.apache.org/addrelease.html?hbase] PerformanceEvaluation with presplit randomWrite test has severe hotspotting,13327132,Open,Major,,11/Sep/20 17:17,,2.3.1,I'm attempting to apply a load to a small distributed cluster (12 RS). I use {{-presplit}} and specify 3 regions per region server. {{randomWrite}} test with {{-nomapred}} and 30 client threads. The result is severe hot-spotting on a single region region (10's of thousands of reqs/sec) and minimal load (high 10's to low 100's reqs/sec) to the others. It seems the split algorithm and the load generator do not agree on an even data distribution. Upgrade Bootstrap to 3.3.7,13328646,Resolved,Major,Fixed,21/Sep/20 21:40,23/Sep/20 22:04,,"Our UI embeds Bootstrap 3.0.0. There are some reported security issues. Upgrade to Bootstrap 3.3.7. " Push signed release tag,13327824,Resolved,Major,Fixed,16/Sep/20 09:05,25/Sep/20 18:10,, Release version 2.3.2 in Jira,13327820,Resolved,Major,Fixed,16/Sep/20 09:02,25/Sep/20 17:35,, """Release"" staged nexus repository",13327819,Resolved,Major,Fixed,16/Sep/20 09:00,25/Sep/20 17:33,, Spin RCs,13327818,Resolved,Major,Fixed,16/Sep/20 08:59,25/Sep/20 16:38,, Refactor Replication: move the default ReplicationSinkService implementation out,13328911,Resolved,Major,Fixed,23/Sep/20 03:41,25/Sep/20 01:33,,"Now the Replication implements both ReplicationSourceService and ReplicationSinkService interface. But most of code is only related to ReplicationSourceService. Meanwhile, there is a bug when HRegionServer#buildServerLoad, as it not consider the case: ReplicationSourceService implementation is different with ReplicationSinkService." Refactor ReplicationSinkManager: reduce code and make it easy to understand,13328487,Resolved,Major,Fixed,21/Sep/20 08:19,25/Sep/20 01:35,,ReplicationSinkManager only used in HBaseReplicationEndpoint. Move its logic to HBaseReplicationEndpoint inside. RegionMover may fail when moving regions in default rsgroup,13329252,Open,Major,,24/Sep/20 16:10,,,"In RegionMover, we get servers from all online servers and then filter the servers from the same rsgroup except default rsgroup.But default rsgroup is not the corner case, we can't move a region in default rsgroup to other rsgroups either." Should not use XXXService.Interface.class.getSimpleName as stub key prefix in AsyncConnectionImpl,13328409,Resolved,Major,Fixed,20/Sep/20 13:13,23/Sep/20 06:45,,"It will just return ""Interface"" for all services. This is not a bug for AsyncConnectionImpl as we have different maps for ClientService and AdminService, but it is still a bit confusing to developers. I suggest either we just use empty string and add a comment to say that the service name is not important here, or change to use XXXService.class.getSimpleName() or XXXService.getDescriptor().getName(), so it is less confusing to developers." Splittable Meta: foward port fixes from hbase-2 branch and stabilize unit tests,13328024,Resolved,Major,Fixed,17/Sep/20 09:36,23/Sep/20 09:45,, Up the container nproc uplimit to 30000,13328805,Resolved,Major,Fixed,22/Sep/20 15:05,22/Sep/20 16:26,,"We (Apache Phoenix team) have recently switched our precommit tests to Dockerized Yetus (mostly adopted from the solution in Hbase) We see  java.lang.OutOfMemoryError: unable to create new native thread errors , while Yetus shows |Max. process+thread count|6833 (vs. ulimit of 12500)| While I couldn't determine what was the job that we shared the Agent with at the time, statistically it was very likely HBase, and an HBase job probably failed with a similar error. Some research has thrown up the official Docker docs:  [https://docs.docker.com/engine/reference/commandline/run/#set-ulimits-in-container-ulimit] According to which it is not possible to set container level nprocs ulimit with Docker. All settings apply to the docker Daemon user instead, and the limit is shared between all containers. Based on this, I think that it makes no sense to set a container (really docker user) nprocs ulimit any lower than the current hard limit of 30000. I have already set PROC_LIMIT=30000 in the Phoenix Yetus personality, but it is only a half solution until some Docker users set lower values, as the later setting will apply as soon as the container is started." fix typo in MasterRegion java doc,13328536,Resolved,Major,Fixed,21/Sep/20 10:42,21/Sep/20 17:02,,The archived HFile will be moved to the global HFile archived directory with the \{@link MasterRegionParams#archivedWalSuffix()} suffix. The archived WAL will be moved to the global WAL archived directory with the \{@link MasterRegionParams#archivedHFileSuffix()} suffix Fix typo in ReplicationProtobufUtil,13328506,Resolved,Major,Fixed,21/Sep/20 09:10,21/Sep/20 16:49,,"It is named as 'ReplicationProtbufUtil', missed an 'o'. It is IA.Private so it is safe to rename it directly." REST Server failes to start without any error message,13325831,Resolved,Major,Fixed,03/Sep/20 02:10,21/Sep/20 00:43,2.2.1,"When I enable security and start rest server, i  see the messages like these: {code:java} SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] 2020-09-03 02:10:57,995 INFO [main] RESTServer: ***** STARTING service 'RESTServer' ***** 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository git://hao-OptiPlex-7050/home/hao/open_source/hbase revision=f93aaf770cce81caacbf22174dfee2860dbb4810 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年 09月 10日 星期二 14:28:27 CST 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with checksum c0f358e344b10713f61037e16fd39f8euse{code} Rest server doesn't start successfully, but it was bad that I can't find any error message indicating that server fails to start and why failure happens. Afer debuging, I found that loginServerPrincipal can throw exception, like: {code:java} java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if security is enabled at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142) at org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149) at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237) at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424) {code}  But these exceptions are caught without any messages printed. {code:java} org.apache.hadoop.hbase.rest.RESTServer.main 423 try { 424 server.run(); 425 server.join(); 426 } catch (Exception e) { 427 System.exit(1); 428 } {code} We need print the failure message to help user config the system." Use FutureUtils.rethrow in AsyncTableResultScanner to better catch the stack trace,13328272,Resolved,Major,Fixed,18/Sep/20 15:23,20/Sep/20 03:36,, Region hole contains wrong regions pair when hole is created by first region deletion,13323810,Resolved,Major,Fixed,20/Aug/20 17:11,30/Aug/20 17:07,2.2.3,"HBCK2 Holes: Wrong region details in HBCK report ,if a region is missing in meta and start key is empty for hole, it reports two region where hole is present. Scenario where first region is missing for eg: in below scenario r1 is missing in meta start key    end key   region empty     10        r1 10           20        r2 20           30        r2 30          empty  r3   In our test hbck report contains two region where first region belongs to different table and second region is r2.  " ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.,13324709,Resolved,Major,Fixed,26/Aug/20 21:09,20/Sep/20 07:02,1.3.2,"One of our customers experienced high latencies (in order of 3-4 minutes) for point lookup query (We use phoenix on top of hbase). We have different threads sharing the same hconnection.  Looks like multiple threads are stuck at the same place. [https://github.com/apache/hbase/blob/branch-1.3/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionManager.java#L1282]  We have set the following configuration parameters to ensure query fails with a reasonable SLAs: 1. hbase.client.meta.operation.timeout 2. hbase.client.operation.timeout 3. hbase.client.scanner.timeout.period But since  userRegionLock can wait for lock indefinitely the call will not fail within SLA." Make RegionInfo#UNDEFINED IA.Private,13323819,Resolved,Major,Fixed,20/Aug/20 18:25,21/Aug/20 16:28,2.3.2,"From review of parent PR, RI#UNDEFINED is for internal use only... note it w/ a IA.Private marking. Also deprecate it so we have option to remove as its loading implicated in the parent issue static load deadlock." ScheduledChore is never triggered when initalDelay > 1.5*period,13327078,Resolved,Major,Fixed,11/Sep/20 11:54,16/Sep/20 10:04,2.2.3,"In our recent tests, ScheduledChore is never triggered when initalDelay > 1.5*period. The cause of the bug is the following: The trigger time for a ScheduleChore must be within an acceptable time window that is 1.5 * period. see [here|https://github.com/apache/hbase/blob/e5ca9adc54f9f580f85d21d38217afa97aa79d68/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java#L234] timeOfLastRun and timeOfThisRun are two variables that record two adjacent trigger time. [The first initialization of timeOfThisRun|https://github.com/apache/hbase/blob/e5ca9adc54f9f580f85d21d38217afa97aa79d68/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java#L273] is when the ScheduleChore is created, it's not a real trigger time. If we set initialDelay > 1.5 period , after initialDelay, the first time when chore is triggered has exceeded the allowed window. Then [cancel the chore and schedule it again|https://github.com/apache/hbase/blob/e5ca9adc54f9f580f85d21d38217afa97aa79d68/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java#L176]. So it's stuck in loop when initialDelay > 1.5 period : 1.  init timeOfThisRun at a wrong time. 2. wait initalDelay 3. chore trigger, but exceeded the allowed window. 4. cancel chore and schedule it again 5. go step 1.  " HBASE-24359 causes replication missed log of some RemoteException,13327013,Resolved,Major,Fixed,11/Sep/20 06:27,16/Sep/20 10:09,2.3.0,"HBASE-24359 broken the logic of handling exception. In branch2, it even causes some RemoteException log missed. [File changed|[https://github.com/apache/hbase/pull/1855/files#diff-1e3f171b19474698601a0752b618af0eL435]] in branch2. !image-2020-09-11-14-30-27-898.png!" Nightly job should skip hadoop-2 integration test for master,13327335,Resolved,Major,Fixed,14/Sep/20 03:26,17/Sep/20 01:12,,Since master does not support hadoop 2.x any more. Introduce a ReplicationSourceController interface and decouple ReplicationSourceManager and ReplicationSource,13326417,Resolved,Major,Fixed,08/Sep/20 09:01,20/Sep/20 02:51,, FastLongHistogram#getCountAtOrBelow method is broken.,13327911,Open,Major,,16/Sep/20 18:46,,1.6.0,"FastLongHistogram#getCountAtOrBelow method is broken. If I revert HBASE-23245 then it works fine. Wrote a small test case in TestHistogramImpl.java : {code:java} @Test public void testAdd1() { HistogramImpl histogram = new HistogramImpl(); for (int i = 0; i < 100; i++) { histogram.update(i); } Snapshot snapshot = histogram.snapshot(); // This should return count as 6 since we added 0, 1, 2, 3, 4, 5 Assert.assertEquals(6, snapshot.getCountAtOrBelow(5)); {code} It fails as below: java.lang.AssertionError: Expected :6 Actual :100 " [HBOSS] TreeLockManager should not define itself as the default implementation for fs.hboss.sync.impl,13328118,Resolved,Major,Fixed,17/Sep/20 19:20,18/Sep/20 08:33,hbase-filesystem-1.0.0-alpha1,"Currently, abstract class TreeLockManager defines itself as the default implementation of fs.hboss.sync.impl. This is wrong, as in the event of fs.hboss.sync.impl omission from the config, it will end up trying to instantiate itself, failing as its abstract: {noformat} 2020-09-16 13:29:48,877 ERROR org.apache.hadoop.hbase.regionserver.HRegion: There was IO error when checking if the bulk load is ok in region wordcount,w,1600262698081.84cb78e467e3c3b40e78c7f07d643d5c.. java.io.IOException: Class referred to by fs.hboss.sync.impl, org.apache.hadoop.hbase.oss.sync.TreeLockManager, is not a valid implementation of org.apache.hadoop.hbase.oss.sync.TreeLockManager at org.apache.hadoop.hbase.oss.sync.TreeLockManager.get(TreeLockManager.java:70) at org.apache.hadoop.hbase.oss.HBaseObjectStoreSemantics.initialize(HBaseObjectStoreSemantics.java:120) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3423) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:158) at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:3483) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3451) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:518) at org.apache.hadoop.fs.Path.getFileSystem(Path.java:361) at org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:818) at org.apache.hadoop.hbase.regionserver.HRegion.bulkLoadHFiles(HRegion.java:6221) at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:291) at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:266) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:360) {noformat}" HBase NodeLabel support,13328190,Open,Major,,18/Sep/20 07:24,,,"We can add a new feature. Similar to Yarn(NodeLabel). Here, the main purpose is to classify nodes with different resources (cpu, memory, etc.) in the cluster so that they can be more efficient when accessing HBase.  " Do not add non shaded protobuf as dependency in TableMapReduceUtil for master,13327941,Resolved,Major,Fixed,17/Sep/20 01:48,17/Sep/20 07:01,,As on master branch we have purged all the non shaded protobuf dependency from hbase. It is hadoop's duty to add their protobuf dependency(shaded or non-shaded). Rebase Splittable Meta Master branch,13327615,Resolved,Major,Fixed,15/Sep/20 08:11,17/Sep/20 09:35,,It's been a while since the branch was rebased and there were significant changes that affected the patch that went in. I've been working on this. HBase nightly client integration test is failing,13327844,In Progress,Major,,16/Sep/20 10:17,,,There are bunch of problems which leads to the failure. Plan to fix it in HBASE-25021 but finally I think we'd better have a separated issue for fixing the problem other than skipping hadoop 2 for master. All executor service should start using guava ThreadFactory,13318525,Resolved,Major,Fixed,21/Jul/20 17:09,12/Aug/20 10:28,,"Currently, we have majority Executor services using guava's ThreadFactoryBuilder while creating fixed size thread pool. There are some executors using our internal hbase-common's Threads class which provides util methods for creating thread factory. Although there is no perf impact, we should let all Executors start using our internal library for using ThreadFactory rather than having external guava dependency (which is nothing more than a builder class). We might have to add a couple more arguments to support full fledged ThreadFactory, but let's do it and stop using guava's builder class. *Update:* Based on the consensus, we should use only guava library and retire our internal code which maintains ThreadFactory creation." Lots of thread pool are changed to non daemon after HBASE-24750 which causes trouble when shutting down,13327816,Resolved,Major,Fixed,16/Sep/20 08:54,16/Sep/20 14:06,,"We replace Threads.newDaemonThreadFactory with guava ThreadFactoryBuilder but miss the setDaemon call, which causes our client integration test to fail because of hbase shell can never quit cleanly. We should add the setDaemon back for those thread factories." Set version as 2.2.7-SNAPSHOT in branch-2.2,13327808,Resolved,Major,Fixed,16/Sep/20 07:45,16/Sep/20 12:16,, Include batch mutatations in client operation timeout tests,13325905,Resolved,Major,Fixed,03/Sep/20 11:28,16/Sep/20 10:39,1.7.0,"While put, get and scan operations are included in client operation timeout test, we should also include batch requests. batch() has different way of handling operation timeout by passing it to AsyncProcessTask and then waiting on async future response." Log RegionTooBusyException details,13326651,Resolved,Major,Fixed,09/Sep/20 10:18,16/Sep/20 10:25,1.3.6,"When we throw RegionTooBusyException, it gets wrapped in RetriesExhaustedWithDetailsException at times and the original source doing batch mutation might not be able to log region name and root cause that comes with RegionTooBusyException as it is wrapped with outer RetriesExhaustedWithDetailsException and outer Exception has it's own way of logging only necessary info, which is quite acceptable. Attaching a sample screenshot. We should at least log details of RegionTooBusyException at server side before we throw it." Avoid invoke Counter using reflection in SnapshotInputFormat,13321437,Resolved,Major,Fixed,07/Aug/20 04:55,15/Sep/20 15:07,,"In TableRecordReaderImpl we invoke Counter increment by reflection This will be called nextKeyValue() in TableSnapshotInputFormat  reflection invoke is very slower than normal method call we can avoid these to improve the read performance" Create simple pattern matching query for retrieving metrics matching the pattern,13326592,Resolved,Major,Fixed,09/Sep/20 05:05,14/Sep/20 14:14,2.2.5,"Currently we allow querying a metric with a specific metric name. But generally say under the MBean sub=Tables under a server we might have 'n' number of tables and we might be interested in a specific metric across all tables. So in such cases giving a simple pattern based query will help so that we can retrieve all metrics that follow that pattern. The other side effect is that we can also reduce the size of the json we pull from the server to the querying client. Which are generally smaller scripts which might not be able to process the big sized response JSON. Thanks [~anoopsamjohn] for the suggestion. " Remove 'hbase.testing.nocluster' config,13327351,Resolved,Major,Fixed,14/Sep/20 05:43,14/Sep/20 13:48,,"It is only used at two places in tests and easy to be removed, so let's just remove it to make our code cleaner." Introduce a special CellComparator for master local region,13324081,Resolved,Major,Fixed,22/Aug/20 15:14,15/Sep/20 13:12,,"As now we have multiple families but they should use different CellComparator. We can call different methods when we are dealing with different families." EOM cleanup,13327264,Resolved,Major,Fixed,13/Sep/20 03:13,13/Sep/20 17:10,,"the [foundation downloads area for the project|https://downloads.apache.org/hbase/] has some versions that shouldn't be present anymore. Also it's missing an EOM marker for 1.3. the ref guide also includes several EOM versions." Migrate all jenkins jobs to the new ci-hadoop.a.o,13320089,Resolved,Major,Fixed,30/Jul/20 01:45,14/Sep/20 03:09,,"Need to open an issue as we need to change the code. We will exclude flaky tests when running pre commit job, so if we move the flaky jobs, we also need to change the url." [hbase-operator-tools] NPE in RegionsMerger#mergeRegions,13326416,Resolved,Major,Fixed,08/Sep/20 09:00,11/Sep/20 09:22,hbase-operator-tools-1.1.0,"RegionsMerger#mergeRegions will call RegionsMerger#getOpenRegions to get all OPEN region for target table. When target table's REPLICATION_SCOPE is '1', RegionsMerger#getOpenRegions may return null.  " "Add document for ""HBASE-24776 [hbtop] Support Batch mode""",13326808,Resolved,Major,Fixed,10/Sep/20 08:08,11/Sep/20 06:42,,"Add a document for the batch mode of hbtop introduced in HBASE-24776 to the ref guide. " Refactor CatalogJanitor,13326689,Resolved,Major,Fixed,09/Sep/20 13:55,10/Sep/20 04:16,,Move the related class to a separated package and also move the internal classes out. Remove OfflineMetaRebuildTestCore,13326316,Resolved,Major,Fixed,07/Sep/20 14:07,09/Sep/20 01:58,,Maybe it is used to test HBCK but is useless now. Let's remove it. MetaFixer fails to fix overlaps when multiple tables have overlaps,13326378,Resolved,Major,Fixed,08/Sep/20 05:43,08/Sep/20 19:04,2.2.3,"MetaFixer fails to fix overlaps when multiple tables have overlaps *Steps to reproduce from UT.* # Create table t1 and t2 with split keys, [""bbb"", ""ccc"", ""ddd"", ""eee""] # Create extra region in both t1 and t2 with start key ""bbb"" and end key ""ddd"" # Run catalog janitor, It will report total 4 overlaps, 2 from each table. # Run MetaFixer, wait for merges to finish. # Run the catalog janitor again and verify report, there should not be any overlap # Overlap still exists. Reproduced!!! *Analysis.* * When I run the same scenario for just one table t1, overlaps are fixed successfully. * Seems problem with MetaFixer#calculateMerges. * I think merges should be calculated within a table. Across the table merge does not have significance. " Move delete region info related methods to RegionStateStore,13326501,Resolved,Major,Fixed,08/Sep/20 14:27,09/Sep/20 15:12,, [HBOSS] UTs failing when running against hadoop 3.3. ,13325068,Resolved,Major,Fixed,28/Aug/20 18:48,09/Sep/20 16:40,hbase-filesystem-1.0.0-alpha1,"Current UTs fail when running against hadoop 3.3. This is because on 3.3, *AbstractAmazonS3* defines additional _doesBucketExistV2_ that's called upon initialization, but UT utility *EmbeddedS3* class is not implementing it." Disassemble the method replicateWALEntry from AdminService to a new interface ReplicationServerService,13326069,Resolved,Major,Fixed,04/Sep/20 11:19,09/Sep/20 07:02,, Move ReplicationBarrier related methods to a separated class,13326227,Resolved,Major,Fixed,07/Sep/20 02:57,07/Sep/20 12:50,, Move meta edit methods from MetaTableAccessor to RegionStateStore,13326223,In Progress,Major,,07/Sep/20 02:13,,,"As now we only support editing meta from master. This can prevent unexpected edits to meta in our code base, and also make the code cleaner. Now we have duplicated methods both in RegionStateStore and MetaTableAccessor." Renaming invalid rsgroup throws NPE instead of proper error message ,13316450,Resolved,Major,Fixed,13/Jul/20 12:18,04/Sep/20 18:06,,"Renaming an rsgroup which is not available in the cluster throwing IOException. Create rsgroup add_rsgroup 'RSG1' rename_rsgroup 'RSG2','RSG3'  " Wrap ConnectionImplemetation#locateRegioninMeta under operation timeout.,13326160,Open,Major,,05/Sep/20 18:35,,1.6.0,"We have config property (hbase.client.operation.timeout and hbase.client.meta.operation.timeout). Description of hbase.client.operation.timeout which is for non meta tables. {noformat} Operation timeout is a top-level restriction (millisecond) that makes sure a blocking operation in Table will not be blocked more than this. In each operation, if rpc request fails because of timeout or other reason, it will retry until success or throw RetriesExhaustedException. But if the total time being blocking reach the operation timeout before retries exhausted, it will break early and throw SocketTimeoutException. {noformat} Most of the operations like get, put, delete are wrapped under this timeout but scan operation is not wrapped in this timeout. We need to wrap scan operations also within operation timeout. More discussion in this PR thread: https://github.com/apache/hbase/pull/2322#discussion_r478687341" Generate CHANGES.md and RELEASENOTES.md for 2.2.6,13315270,Resolved,Major,Fixed,07/Jul/20 01:14,27/Aug/20 00:14,, "Add help output for shell ""magic"" commands",13323832,Open,Major,,20/Aug/20 20:57,,,"The shell has a handful of ""magic"" commands, things like {{help}} and {{debug}}, that exist as commands in the shell, but are not implementations of the command class and have no help documentation of their own. Let's promote them to proper commands, add a new command group, call it ""shell command group"", for example. This makes them discoverable. Give each of them a help documentation string with examples, as we have for the others, i.e., {{help 'help'}}." runCatalogJanitor() API should return -1 to indicate already running status,13324190,Resolved,Major,Fixed,24/Aug/20 06:17,03/Sep/20 11:18,2.2.3,"runCleanerChore() API returns false if hbck chore is already running. This is quite helpful in many cases. runCatalogJanitor() API is not indicating whether scan is already running. Also it is not doing anything in case scan is already running. I think we should return -1 to indicate already running status." Fix dead links in HBase book,13325961,Resolved,Major,Fixed,03/Sep/20 17:10,04/Sep/20 00:26,2.3.0,"1.  -[https://hadoop.apache.org/common/docs/current/api/org/apache/hadoop/io/file/tfile/TFile.html|https://hadoop.apache.org/common/docs/current/api/org/apache/hadoop/io/file/tfile/TFile.html-]- => [https://hadoop.apache.org/docs/current/api/org/apache/hadoop/io/file/tfile/TFile.html] 2. -[https://vimeo.com/26804675|https://vimeo.com/26804675-]- => [https://www.youtube.com/watch?v=DdGKAorSSZ0] 3. -[http://www.cloudera.com/videos/hw10_video_how_stumbleupon_built_and_advertising_platform_using_hbase_and_hadoop|http://www.cloudera.com/videos/hw10_video_how_stumbleupon_built_and_advertising_platform_using_hbase_and_hadoop-]- has been invalid and cannot be found in other website, just remove it. 4. -[https://hadoop.apache.org/core/docs/stable/api/org/apache/hadoop/metrics/package-summary.html]- => [https://hadoop.apache.org/docs/stable/api/org/apache/hadoop/metrics2/package-summary.html]" Add a basic ReplicationServer which only implement ReplicationSink Service,13315130,Resolved,Major,Resolved,06/Jul/20 10:07,04/Sep/20 11:12,, Refactor TestJMXConnectorServer,13323722,Resolved,Major,Fixed,20/Aug/20 11:43,31/Aug/20 02:44,3.0.0-alpha-1,"Two optimization points for TestJMXConnectorServer in this issue: # Just run cluster once, not once per test case. # Use random free port to run ConnectorServer, avoid specifying a fixed port." Remove MetaTableAccessor.tableExists,13325105,Resolved,Major,Fixed,29/Aug/20 03:45,30/Aug/20 11:58,,"At master side, we could make use of TableDescriptors to determine whether a table exists, as it caches all the table descriptors. For other places, we could just make use Admin.tableExists, which is exactly the same with calling MetaTableAccessor.tableExists but avoid exposing meta directly." ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.,13324740,Resolved,Major,Fixed,27/Aug/20 01:47,01/Sep/20 08:35,1.3.6,"The following bug exists only in branch-1 and below. ZKTableStateClientSideReader#isDisabledTable returns false even if table doesn't exists. Below is the code snippet:  {code:title=ZKTableStateClientSideReader.java|borderStyle=solid} public static boolean isDisabledTable(final ZooKeeperWatcher zkw, final TableName tableName) throws KeeperException, InterruptedException { ZooKeeperProtos.Table.State state = getTableState(zkw, tableName); ---> We should check here if state is null or not. return isTableState(ZooKeeperProtos.Table.State.DISABLED, state); } } {code}  " One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator,13325169,Resolved,Major,Fixed,29/Aug/20 18:17,31/Aug/20 15:09,,"Superclass CellComparatorImpl has static initializer META_COMPARATOR which initializes sub-class MetaCellComparator, which could lead to deadlock while loading class (similar in nature to HBASE-24896 , although not that complex). We can break the dependency now before it becomes more complex (Splittable meta work will most likely impact this code path)." Refactor the checkAndMutate code on the server side,13314981,Resolved,Major,Fixed,04/Jul/20 08:39,10/Aug/20 09:59,,# Refactor the checkAndMutate code on the server side by using the CheckAndMutate class (introduced in HBASE-8458) and the CheckAndMutateResult class (introduced in HBASE-24650). [HBOSS] HBaseObjectStoreSemantics.close should call super.close to make sure its own instance always get removed from FileSystem.CACHE,13324807,Resolved,Major,Fixed,27/Aug/20 10:15,01/Sep/20 08:34,hbase-filesystem-1.0.0-alpha1,"This came up when running bulkloads on hbase deployments using HBOSS. The fixes introduced by HBASE-23679 use *_FileSystem.closeAllForUGI(ugi)_* to make sure _*FileSystem*_ instances get cleared for the specific running UGI. Problem is that _*FileSystem.closeAllForUGI*_ does not remove the instance from _*FileSystem.CACHE*_ explicitly, it rather calls _*FileSystem.close*_, which in turn removes itself from _*FileSystem.CACHE*_. In this case, though, our _*FileSystem*_ implementation is _*HBaseObjectStoreSemantics*_, so _*FileSystem.closeAllForUGI*_ closes it, but does not remove it from _*FileSystem.CACHE*_, leading to all attempts to _*FileSystem.get*_ by the same UGI retrieving a closed _*HBaseObjectStoreSemantics*_ instance, ultimately failing as below:   {noformat} 2020-08-26 12:43:57,528 ERROR org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager: Failed to complete bulk load java.io.IOException: Exception while testing a lock         at org.apache.hadoop.hbase.oss.sync.ZKTreeLockManager.isLocked(ZKTreeLockManager.java:312)         at org.apache.hadoop.hbase.oss.sync.ZKTreeLockManager.writeLockAbove(ZKTreeLockManager.java:183)         at org.apache.hadoop.hbase.oss.sync.TreeLockManager.treeReadLock(TreeLockManager.java:282)         at org.apache.hadoop.hbase.oss.sync.TreeLockManager.lock(TreeLockManager.java:449)         at org.apache.hadoop.hbase.oss.HBaseObjectStoreSemantics.exists(HBaseObjectStoreSemantics.java:498)         at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:281)         at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager$1.run(SecureBulkLoadManager.java:266)         at java.security.AccessController.doPrivileged(Native Method)         at javax.security.auth.Subject.doAs(Subject.java:360)         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1856)         at org.apache.hadoop.hbase.regionserver.SecureBulkLoadManager.secureBulkLoadHFiles(SecureBulkLoadManager.java:266)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.bulkLoadHFile(RSRpcServices.java:2445)         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42280)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:418)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) Caused by: java.lang.IllegalStateException: Expected state [STARTED] was [STOPPED] {noformat}" [Flakey Test] TestStochasticLoadBalancer.testMoveCostMultiplier,13323116,Resolved,Major,Fixed,17/Aug/20 21:57,30/Aug/20 15:05,2.3.0,"I've noticed this test has gotten flakey on a couple PRs. The only recent change to the class under test is HBASE-24709. Failure looks like: {noformat} [ERROR] Failures: [ERROR] org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer.testMoveCostMultiplier [ERROR] Run 1: TestStochasticLoadBalancer.testMoveCostMultiplier:304 expected:<3.0> but was:<7.0> [ERROR] Run 2: TestStochasticLoadBalancer.testMoveCostMultiplier:304 expected:<3.0> but was:<7.0> [ERROR] Run 3: TestStochasticLoadBalancer.testMoveCostMultiplier:304 expected:<3.0> but was:<7.0> {noformat}" Optimize FSTableDescriptors.get to not always go to fs when cache miss,13324426,Resolved,Major,Fixed,25/Aug/20 09:37,29/Aug/20 14:52,,"Since in the below getAll method, if fsvisited is true, we will just return what we have in cache. We should also do this in the get method, if fsvisited is true, we do not need to go to fs any more. Another benefit here is that, when executing procedures on master, we do not need to go to meta region any more, we could just check if we have a table descriptor in cache." Use RegionLocator instead of MetaTableAccessor's get regions and locations methods if possible,13325107,Open,Major,,29/Aug/20 03:56,,,For most cases we do not need to get split parent so it is OK to just make use of RegionLocator. Figure why jdk11/hadoop3 tests on branch-2 are blowing the 9hour limit,13324542,Open,Major,,25/Aug/20 20:09,,, Temporarily up the timeout for branch-2 from 9 hours to 12 for build,13324543,Resolved,Major,Fixed,25/Aug/20 20:10,25/Aug/20 20:12,,Want to see where time is being spent that causes the jdk11/hadoop3 build to take so long so temporarily up the build timeout from 9 hours to 12. Create versatile hbase-shell table formatter,13323423,Open,Major,,18/Aug/20 19:13,,3.0.0-alpha-1,"As a user, I would like a simple interface for shell output that can be expressed as a table (ie. output with a fixed number of columns and potentially many rows). To be clear, this new formatter is not specifically for HBase ""tables."" Table is used in the broader sense here. h2. Goals - Do not require more than one output cell loaded in memory at a time - Support many implementations like aligned human-friendly tables, unaligned delimited, and JSON h2. Non-goals - Don't load all the headers into memory at once. ** This may seem like a goal with merit, but we are unlikely to find a use case for this formatter with many columns. For example: since HBase tables aren't relational, our scan output will not have an output column for every HBase column. Instead, each output row will correspond to an HBase cell. ** It's also really useful to have the headers ahead of time, because it allows us to do things like JSON object output (where each row is represented with key-value pairs). h2. Implementation This patch was implemented as a stateful output formatter for data with a fixed number of output columns. Tracking state inside the formatter is an important design feature so that we don't have to feed the formatter all the data at once. This patch comes with three implementations of the table formatter: Aligned, Unaligned, and JSON. h2. Formatter Usage Pattern The verbose way to use the formatter to print a table is as follows: 1. call start_table to reset the formatter's state and pass configuration options 2. call start_row to start writing a row 3. call cell to write a single cell 4. call close_row 5. call close_table Sometimes, it will feel like this is a lot of method calls, but these calls act as ""hooks"" and give each of the formatter implementations a chance to fill out all the content necessary between cells. To cut down on boilerplate, there are shortcut methods like row and single_value_table." Reduce the number of builds to keep for flaky find job,13324144,Resolved,Major,Later,23/Aug/20 12:35,24/Aug/20 01:53,, The postAppend method in SimpleRegionObserver should return result instead of null,13324786,Open,Major,,27/Aug/20 07:27,,1.4.13,"I found this error when testing batch append with SimpleRegionObserver： java.lang.RuntimeException: java.lang.IllegalStateException: actions.getActionCount=2, actionResult.getResultOrExceptionCount=0 for region type: REGION_NAME   The postAppend method in SimpleRegionObserver should return result instead of null.  " Add a command to support archive the earliest log file manually,13321059,Open,Major,,05/Aug/20 09:28,,,"This new command named wal_archive, belong to the group of ""tools"". It is a sync call, if the data related to earliest log file not all persisted, they will be flushed immediately.  Usage: {code:java} wal_archive 'desktop-ud83s84,16020,1596595277350'{code}" balanceRSGroup should skip generating balance plan for disabled table and splitParent region,13324076,Resolved,Major,Fixed,22/Aug/20 14:48,26/Aug/20 06:23,,"now ,we generate balance plan for disabled tables, which is useless {code:java} 2020-08-20,20:47:54,702 WARN [RpcServer.default.RWQ.Fifo.read.handler=310,queue=6,port=22500] org.apache.hadoop.hbase.master.HMaster: Failed balance plan: hri=aa325467924edc865ab2ef6d82f9e2a7, source=tj1-hadoop-staging-st02.kscn,22600,1572403947348, destination=, just skip it org.apache.hadoop.hbase.client.DoNotRetryRegionException: Unexpected state for rit=CLOSED, location=tj1-hadoop-staging-st02.kscn,22600,1572403947348, table=galaxysds:sds_staging_258z, region=aa325467924edc865ab2ef6d82f9e2a7 at org.apache.hadoop.hbase.master.assignment.AssignmentManager.preTransitCheck(AssignmentManager.java:580) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.createMoveRegionProcedure(AssignmentManager.java:635) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:652) at org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1776) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.balanceRSGroup(RSGroupAdminServer.java:486) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.balanceRSGroup(RSGroupAdminEndpoint.java:293) at org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:13890) at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:908) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code}" Clarify patch upgrade compatibility guarantees,13324673,Open,Major,,26/Aug/20 16:04,,1.7.0,"Per the [compatibility|https://hbase.apache.org/book.html#hbase.versioning] guidelines (specifically section ""Client-Server wire protocol compatibility "") which says ""We could only allow upgrading the server first. I.e. the server would be backward compatible to an old client, that way new APIs are OK."" This gives an impression that it is fine to break API compatibility in patch upgrades and expect the users to upgrade server binaries first before upgrading clients. However, when considering a back-port of HBASE-24765, it was noted by [~zhangduo] and [~ndimiduk] that this compatibility shouldn't be broken. Seems like something that should be clarified in the docs." Remove MetaTableAccessor.getRegionCount,13324283,Resolved,Major,Fixed,24/Aug/20 13:31,25/Aug/20 13:46,,"In fact, in the implementation of MetaTableAccessor.getRegionCount we have already switch to use RegionLocator. Let's just use RegionLocator directly in code." RegionReplicaFlushHandler should handle NoServerForRegionException to avoid aborting RegionServer,13323305,Resolved,Major,Fixed,18/Aug/20 09:59,26/Aug/20 07:57,,"Debug flaky test TestRegionReplicaReplicationEndpoint, I found the RS aborted because RegionReplicaFlushHandler flush failed. When create a new table with region replica, the assign order may be: # assign 0002 replica region and trigger primary region flush. # assign 0001 replica region and trigger primary region flush. # assign primary region. But the primary region flush may failed because the primary region not opened now. So it may abort the RS......   {code:java} 2020-08-18 16:56:30,041 INFO [RS_OPEN_REGION-regionserver/hao-OptiPlex-7050:0-0] handler.AssignRegionHandler(141): Opened testRegionReplicaReplicationIgnoresDisabledTables_drop_false_disabledReplication_false,,1597740978463_0002.66e9757a05fbae7623cfea3369fc8354. 2020-08-18 16:56:30,558 INFO [RS_OPEN_REGION-regionserver/hao-OptiPlex-7050:0-0] handler.AssignRegionHandler(141): Opened testRegionReplicaReplicationIgnoresDisabledTables_drop_false_disabledReplication_false,,1597740978463_0001.22ff45423b0f1f0e93794f673449d140. 2020-08-18 16:56:31,192 INFO [RS_OPEN_REGION-regionserver/hao-OptiPlex-7050:0-0] handler.AssignRegionHandler(141): Opened testRegionReplicaReplicationIgnoresDisabledTables_drop_false_disabledReplication_false,,1597740978463.901f9cd06bbf27ef7c2d70b5af725cd2. 2020-08-18 16:58:53,857 ERROR [RS_REGION_REPLICA_FLUSH_OPS-regionserver/hao-OptiPlex-7050:0-0] helpers.MarkerIgnoringBase(159): ***** ABORTING region server hao-optiplex-7050,36368,1597740961432: ServerAborting because an exception was thrown ***** org.apache.hadoop.hbase.client.NoServerForRegionException: No server address listed in hbase:meta for region testRegionReplicaReplicationWithReplicas_10,,1597741128945.0f541dc1a7ca64797c4cf054adb9edfb. containing row at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegionInMeta(ConnectionImplementation.java:926) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegion(ConnectionImplementation.java:784) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.locateRegion(ConnectionUtils.java:140) at org.apache.hadoop.hbase.client.RegionAdminServiceCallable.getRegionLocations(RegionAdminServiceCallable.java:147) at org.apache.hadoop.hbase.client.RegionAdminServiceCallable.getLocation(RegionAdminServiceCallable.java:98) at org.apache.hadoop.hbase.client.RegionAdminServiceCallable.prepare(RegionAdminServiceCallable.java:84) at org.apache.hadoop.hbase.client.FlushRegionCallable.prepare(FlushRegionCallable.java:62) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:105) at org.apache.hadoop.hbase.regionserver.handler.RegionReplicaFlushHandler.triggerFlushInPrimaryRegion(RegionReplicaFlushHandler.java:129) at org.apache.hadoop.hbase.regionserver.handler.RegionReplicaFlushHandler.process(RegionReplicaFlushHandler.java:78) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code} I thought the fix should be assign primary region firstly when enable region replica featue. Will check the implmenation of region replica.  " Fix flaky TestMasterAbortAndRSGotKilled for branch-2.2,13322705,Resolved,Major,Fixed,14/Aug/20 08:38,26/Aug/20 07:56,,"I meet this problem on branch-2.2 too. This case happened because the DelayCloseCP. The event execute order is: # Close regiong. But because the DelayCloseCP, it will close after 10 seconds. # Finish ut and shutdown cluster. # Shutdown master. # Shutdown RS. Call waitOnAllRegionsToClose method. But abortRequested is false now. # Close region and failed because master is down and report master error. Then abort RegionServer and set abortRequested to ture. # waitOnAllRegionsToClose hanged because the online regions cannot be empty.   waitOnAllRegionsToClose(final boolean abort) already consider the abort case but the problem is abortRequested is false when call this method. I thought the fix should be that keep to check the abortRequested in waitOnAllRegionsToClose method internal." On Master restart all servers are assigned to default rsgroup.,13314891,Resolved,Major,Fixed,03/Jul/20 13:19,23/Jul/20 17:28,2.2.3,"Steps to reproduce: # Install a HBase cluster with three RS(rs1,rs2 and rs3) and one Master # Create two rsgroups r1 and r2 and move rs1 to r1 and rs2 to r2 {code:java} add_rsgroup 'r1';add_rsgroup 'r2';move_servers_rsgroup 'r1',['host1:16020'];move_servers_rsgroup 'r2',['host2:16020'] {code} # Restart Master # Run list_rsgroups for hbase shell, all region servers are assigned to default regroup. " ReplicationSink should limit the batch rowcount for batch mutations based on hbase.rpc.rows.warning.threshold,13318733,Resolved,Major,Fixed,22/Jul/20 14:59,27/Jul/20 19:42,,"At times there are quite a large no of WAL Edits to ship as part of Replication and sometimes replication queues accumulate huge list of Edits to process. ReplicationSink at the sink server usually goes through all Edits and creates map of table -> list of rows grouped by clusterIds, and performs batch mutation of all rows per table level. However, there is no limit to no of Rows that are sent as part of batch mutate call. If no of rows > limit threshold defined by hbase.rpc.rows.warning.threshold, we usually get warn ""Large batch operation detected"". If hbase.rpc.rows.size.threshold.reject is turned on, RS will reject the whole batch without processing. We should let Replication Sink honour this threshold value and accordingly keep the size lower per batch mutation call. Replication triggered batch mutations should always be consumed but keeping limit of mutation low enough will let the system function at the same pace and without triggering redundant warnings. This will also restrict exploitation of cpu cycles at the destination server." Fix the connection leaks on getting hbase admin from unclosed connection,13319833,Resolved,Major,Fixed,28/Jul/20 19:44,08/Aug/20 09:08,1.6.0,Observed the significant increase in ZK connection on performance testing on map reduce jobs. Turns out the [TableOutputFormat.checkOutputSpecs()|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java#L182] is not closing the connection it uses to get the hbase admin. It closes the hbase admin but never close the connection to get the admin. Address compaction races in TestFIFOCompactionPolicy,13321900,Resolved,Major,Fixed,10/Aug/20 23:51,11/Aug/20 00:42,1.7.0, Remove the metrics assert in TestClusterRestartFailover,13324354,Resolved,Major,Fixed,25/Aug/20 00:29,26/Aug/20 03:34,,"MetricsMasterSource masterSource = UTIL.getHBaseCluster().getMaster().getMasterMetrics() .getMetricsSource(); metricsHelper.assertCounter(MetricsMasterSource.SERVER_CRASH_METRIC_PREFIX+""SubmittedCount"", 4, masterSource);   Introduced by HBASE-24199. But flaky now as this unit test will restart all clusters. Meanwhile, this metric already tested by TestMasterMetrics. I plan to remove this assert for branch-2.2." Reduce the resource of TestReplicationBase,13324381,Resolved,Major,Fixed,25/Aug/20 05:22,26/Aug/20 03:34,, Remove MetaTableAccessor.getTableRegionsAndLocations in hbase-rest module,13324282,Resolved,Major,Fixed,24/Aug/20 13:28,25/Aug/20 09:20,, MergeTableRegionsProcedure should not call clean merge region,13324239,Resolved,Major,Fixed,24/Aug/20 10:22,25/Aug/20 07:35,,"In MergeTableRegionsProcedure, we will call CatalogJanitor.cleanMergeQualifier to test whether the regions we want to merge still have merge qualifier. If so we will skip merge. But the problem is that, in cleanMergeQualifier, we will call cleanMergeRegion, where we may schedule GCMultipleMergedRegionsProcedure to actually clean the merged regions. I think the intention here is to speed up the cleaning of merged region. CatalogJanitor, we have a alreadyRunning guard to prevent multiple scan at the same time, to prevent scheduling duplicated GCMultipleMergedRegionsProcedure for the same region. But if we call cleanMergeQualifier directly from MergeTableRegionsProcedure, we may schedule duplicated GCMultipleMergedRegionsProcedure as there is no guard to prevent CatalogJanitor to run at the same time. And there is also another problem that, even if you disable CatalogJanitor, which means you want to stop cleaning meta, a call from MergeTableRegionsProcedure could still clean the records in meta... So I think here we should just check the qualifiers. If there are merge qualifiers we just skip merging, without scheduling any procedures." Addendum for HBASE-24898 to deal with Daylight Saving Time,13324378,Resolved,Major,Won't Do,25/Aug/20 04:45,25/Aug/20 13:25,, Replication may loss data when refresh recovered replication sources,13322200,Resolved,Major,Fixed,12/Aug/20 06:52,25/Aug/20 00:05,2.2.5,"See code in [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java#L519]   The WAL enqueued to wrong replication source. {code:java} for (String queueId : previousQueueIds) { ReplicationSourceInterface replicationSource = createSource(queueId, peer); this.oldsources.add(replicationSource); this.queueStorage.getWALsInQueue(this.server.getServerName(), queueId) .forEach(wal -> src.enqueueLog(new Path(wal))); toStartup.add(replicationSource); } {code}" Remove 1.3.6 from download page,13324147,Resolved,Major,Fixed,23/Aug/20 12:49,24/Aug/20 03:18,, Enlarge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic,13323510,Resolved,Major,Fixed,19/Aug/20 08:06,24/Aug/20 03:38,,"Failed many times. But the failed reason are different. The replicated entries number are different. So it means the replication is work and it need more time to replicate all 2500 entries. h3. Error Message Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2499   h3. Error Message Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2481   h3. Error Message Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2491" Speed up some unit tests,13323505,Resolved,Major,Fixed,19/Aug/20 07:41,24/Aug/20 03:38,,"See [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/42/testReport/org.apache.hadoop.hbase.client/TestAsyncTableAdminApi/] [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/61/testReport/junit/org.apache.hadoop.hbase.client/TestSnapshotTemporaryDirectoryWithRegionReplicas//]   These ut are flaky because they take too much time which more than 780 seconds.    Split TestAsyncTableAdminApi/TestAdminShell/TestLoadIncrementalHFiles Reduce region numbers in TestSnapshotTemporaryDirectoryWithRegionReplicas/TestRegionReplicaFailover/TestSCP*" [hbase-thirdparty] Release 3.4.0,13319771,Resolved,Major,Fixed,28/Jul/20 14:31,24/Aug/20 03:33,, EOL 1.3.x release line,13324145,Open,Major,,23/Aug/20 12:45,,, Use asf-ci credentials in pre commit jenkins job,13324176,Resolved,Major,Fixed,24/Aug/20 02:02,24/Aug/20 03:17,,So we can set the build status for PR. Remove all jenkins files for 1.3.x,13324146,Resolved,Major,Fixed,23/Aug/20 12:45,23/Aug/20 14:31,,So we will not build and test it any more. The command regioninfo is not available,13322934,Resolved,Major,Fixed,16/Aug/20 14:50,22/Aug/20 07:04,3.0.0-alpha-1,"In hbase shell mode: #input regioninfo '1588230740' #output ERROR: wrong number of arguments (1 for 0) " Should call setFailure in MergeTableRegionsProcedure when isMergeable returns false,13323918,Resolved,Major,Fixed,21/Aug/20 09:07,21/Aug/20 14:43,, Enlarge MemstoreFlusherChore/CompactionChecker period for unit test,13323655,Resolved,Major,Fixed,20/Aug/20 05:46,21/Aug/20 07:21,,"Too many debug logs when run unit test now.   2020-08-19 01:20:59,899 DEBUG [regionserver/asf909:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. 2020-08-19 01:20:59,899 DEBUG [regionserver/asf909:0.Chore.1] hbase.ScheduledChore(192): MemstoreFlusherChore execution time: 0 ms. 2020-08-19 01:20:59,900 DEBUG [regionserver/asf909:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. 2020-08-19 01:20:59,900 DEBUG [regionserver/asf909:0.Chore.1] hbase.ScheduledChore(192): MemstoreFlusherChore execution time: 0 ms. 2020-08-19 01:20:59,905 DEBUG [regionserver/asf909:0.Chore.1] hbase.ScheduledChore(192): MemstoreFlusherChore execution time: 0 ms. 2020-08-19 01:20:59,905 DEBUG [regionserver/asf909:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms. 2020-08-19 01:21:00,001 DEBUG [regionserver/asf909:0.Chore.1] hbase.ScheduledChore(192): CompactionChecker execution time: 0 ms." Remove Row.compareTo,13322868,Resolved,Major,Fixed,15/Aug/20 12:25,17/Aug/20 11:58,,Which means Row will not extend Comparable any more. Release 2.3.1,13322135,Resolved,Major,Done,11/Aug/20 22:17,21/Aug/20 16:12,, Send announce email,13322142,Resolved,Major,Done,11/Aug/20 22:20,21/Aug/20 16:11,, Turn off the balancer when test region admin api,13323524,Resolved,Major,Fixed,19/Aug/20 09:17,20/Aug/20 05:44,,"For region admin api, we will test move/split/merge/assign/unassign and test the region location right or not. But the balancer may move region to other places and break the UT. So turn off the balancer for TestAsyncRegionAdminApi." Add 2.3.1 to the downloads page,13322141,Resolved,Major,Fixed,11/Aug/20 22:19,20/Aug/20 16:28,, Migrate hbase-connectors testing to ci-hadoop,13322744,Resolved,Major,Fixed,14/Aug/20 11:46,21/Aug/20 09:26,,"Move hbase-connectors GitHub Pull Request build to ci-hadoop Jenkins master. The new job should be based on a Jenkinsfile similarly to the main repository. " A tool to rewrite corrupted HFiles,13323828,Resolved,Major,Duplicate,20/Aug/20 20:20,21/Aug/20 07:17,,"Typically I have been dealing with corrupted HFiles (due to loss of hdfs blocks) by just removing them. However, It always seemed wasteful to throw away the entire HFile (which can be hundreds of gigabytes), just because one hdfs block is missing (128MB). I think there's a possibility for a tool that can rewrite an HFile by skipping corrupted blocks. There can be multiple types of issues with hdfs blocks but any of them can be treated as if the block doesn't exist: 1. All the replicas can be lost 2. The block can be corrupted due to some bug in hdfs (I've recently run into HDFS-15186 by experimenting with EC). At the simplest the tool can be a local mapreduce job (mapper only) with a custom HFile reader input that can seek to next DATABLK to skip corrupted hdfs blocks." Running InitMetaProcedures are missed if Hmaster startup happens after Meta assign,13323858,Open,Major,,21/Aug/20 00:43,,3.0.0-alpha-1,"In HMaster startup, if the InitMetaProcedure was stopped after the meta assign stage, it will have a RegionState assigned to it and will not fall into this if statement: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1044. This means if an InitMetaProcedure is running (in the INIT_META_CREATE_NAMESPACES state), we won't look for any instances of running InitMetaProcedures and won't correctly await until they are done: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1065 The check for running InitMetaProcedures should be moved outside of the if statement and only if it is null should it try to add a new InitMetaProcedure (if there is no RegionState for meta or if meta is offline). This way we will correctly wait for procedures that are running that have passed the INIT_META_ASSIGN_META state (which sets the RegionStates that HMaster is looking at)." InitMetaProcedure create Namespace is not Idempotent,13323857,Open,Major,,21/Aug/20 00:31,,3.0.0-alpha-1,"If InitMetaProcedure is retried after creating at least one namespace directory: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java#L115, it will not be able to recover as the procedure does not check for existence of the directories before attempting to create them. We should check for existence of the directory first and only execute createDirectories if they do not exist. The rest of the procedure looks like it is idempotent. We can additionally optimize to not overwrite the column families." [hbase-thirdparty] Put up 3.4.0RC2,13322980,Resolved,Major,Fixed,17/Aug/20 02:55,20/Aug/20 09:26,, Speed up TestFromClientSide3 by reduce the table regions number,13323135,Resolved,Major,Fixed,18/Aug/20 01:58,20/Aug/20 05:58,,"[https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/52/testReport/junit/org.apache.hadoop.hbase.client/TestFromClientSide3//]   |[testHTableExistsMethodMultipleRegionsMultipleGets|https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/52/testReport/junit/org.apache.hadoop.hbase.client/TestFromClientSide3//testHTableExistsMethodMultipleRegionsMultipleGets]|2 min 58 sec|Regression| |[testHTableExistsMethodMultipleRegionsSingleGet|https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2.2/52/testReport/junit/org.apache.hadoop.hbase.client/TestFromClientSide3//testHTableExistsMethodMultipleRegionsSingleGet]|4 min 20 sec|Passed|   It take too many time and timeout." Ignore... check what fails when zk-based WAL splitter enabled,13321703,Resolved,Major,Not A Problem,09/Aug/20 18:35,19/Aug/20 21:00,,Just want to see that all good if zk wal splitter enabled post HBASE-24632.... Update reporter tool with new release,13322140,Resolved,Major,Done,11/Aug/20 22:19,19/Aug/20 18:25,, Promote RC artifacts in svn,13323597,Resolved,Major,Done,19/Aug/20 18:23,19/Aug/20 18:23,, Push signed release tag,13322138,Resolved,Major,Done,11/Aug/20 22:18,19/Aug/20 18:22,, """Release"" staged nexus repository",13322137,Resolved,Major,Done,11/Aug/20 22:18,19/Aug/20 18:14,, Release version 2.3.1 in Jira,13322139,Resolved,Major,Done,11/Aug/20 22:19,19/Aug/20 18:11,, Spin RCs,13322136,Resolved,Major,Done,11/Aug/20 22:17,19/Aug/20 18:07,, Do not call make_binary_release for hbase-thirdparty in release scripts,13320166,Resolved,Major,Fixed,30/Jul/20 10:57,19/Aug/20 03:29,,As we only public src tarballs for hbase-thirdparty. Remove deprecated methods in RowMutations,13322867,Resolved,Major,Fixed,15/Aug/20 12:24,19/Aug/20 02:40,,Such as add(Put) and add(Delete). Fix hbase-shell access to ModifiableTableDescriptor methods,13322359,Resolved,Major,Fixed,12/Aug/20 20:18,18/Aug/20 20:01,3.0.0-alpha-1,"HBASE-20819 prepared us for HBase 3.x by removing usages of the deprecated HTableDescriptor and HColumnDescriptor classes from the shell. However, it did use two methods from the ModifiableTableDescriptor, which was only public for compatibility/migration and was marked with {{@InterfaceAudience.Private}}. When {{ModifiableTableDescriptor}} was made private last week by HBASE-24507 it broke two hbase-shell commands (*describe* and *alter* when used to set a coprocessor) that were using methods from {{ModifiableTableDescriptor}} (these methods are not present on the general {{TableDescriptor}} interface). This story will remove the two references in hbase-shell to methods on the now-private {{ModifiableTableDescriptor}} class and will find appropriate replacements for the calls." CLUSTER quota ,13323465,Open,Major,,19/Aug/20 03:36,,, Remove ReplicationPeerConfigUpgrader,13322655,Resolved,Major,Fixed,14/Aug/20 03:48,17/Aug/20 13:52,,The comment says it will be removed in 3.x. Flakey test TestStochasticLoadBalancer.testMoveCostMultiplier,13321910,Resolved,Major,Duplicate,11/Aug/20 02:41,18/Aug/20 08:37,,"This test added by HBASE-24709, and it failed on jdk7 reported by Hudson for branch-1, but cant reproduce in my local env, so create this jira to keep tracing." Migrate hbase-operator-tools testing to ci-hadoop,13322743,Resolved,Major,Fixed,14/Aug/20 11:45,17/Aug/20 15:47,,"Move hbase-operator-tools GitHub Pull Request build to ci-hadoop Jenkins master. The new job should be based on a Jenkinsfile similarly to the main repository. " [hbase-operator-tools] Add missing ASF headers,13322925,Resolved,Major,Fixed,16/Aug/20 12:50,17/Aug/20 08:12,hbase-operator-tools-1.1.0,"There are 4 files in hbase-table-reporter module without ASF headers: * hbase-table-reporter/pom.xml * hbase-table-reporter/README.md * hbase-table-reporter/src/main/gnuplot/freq.p * hbase-table-reporter/src/main/gnuplot/histo.p" Backport HBASE-23956: Use less resources running tests to branch-2.2,13321902,Resolved,Major,Fixed,11/Aug/20 00:20,17/Aug/20 06:14,, Backport part of HBASE-24079 and HBASE-24034,13322645,Resolved,Major,Fixed,14/Aug/20 01:11,17/Aug/20 06:14,, Fix the shellcheck download url,13322650,Resolved,Major,Fixed,14/Aug/20 03:11,17/Aug/20 06:14,,"*10:43:08* You are downloading ShellCheck from an outdated URL! *10:43:08* *10:43:08* Please update to the new URL: *10:43:08* [https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz] *10:43:08* *10:43:08* For more information, see: *10:43:08* [https://github.com/koalaman/shellcheck/issues/1871] *10:43:08* *10:43:08* PS: Sorry for breaking your build :( *10:43:08* You are downloading ShellCheck from an outdated URL!" [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.4.0,13319775,Resolved,Major,Fixed,28/Jul/20 14:34,17/Aug/20 03:47,, [hbase-thirdparty] Put up 3.4.0RC1,13321687,Resolved,Major,Fixed,09/Aug/20 14:16,17/Aug/20 02:55,, Fix the flaky job url in hbase-personality.sh,13322435,Resolved,Major,Fixed,13/Aug/20 03:02,13/Aug/20 09:16,,"  I found that the precommit job of branch-2.2 still used the wrong url. See [https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2247/1/console] {code:java} 16:56:14 [Wed Aug 12 08:56:14 UTC 2020 INFO]: Personality: patch unit 16:56:14 [Wed Aug 12 08:56:14 UTC 2020 INFO]: EXCLUDE_TESTS_URL= 16:56:14 [Wed Aug 12 08:56:14 UTC 2020 INFO]: INCLUDE_TESTS_URL= 16:56:14 --2020-08-12 08:56:14-- https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/excludes/ 16:56:14 Resolving builds.apache.org (builds.apache.org)... 195.201.213.130, 2a01:4f8:c0:2cc9::2 16:56:14 Connecting to builds.apache.org (builds.apache.org)|195.201.213.130|:443... connected. 16:56:15 HTTP request sent, awaiting response... 404 16:56:15 2020-08-12 08:56:15 ERROR 404: (no description). 16:56:15 16:56:15 Wget error 8 in fetching excludes file from url https://builds.apache.org/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/excludes/. Ignoring and proceeding.{code}" migrate website generation to new asf jenkins,13322174,Resolved,Major,Fixed,12/Aug/20 03:01,14/Aug/20 03:37,,"Update our website generation so we can use it on the new jenkins ci server * needs a job name that has no spaces (or fix the script to handle paths with spaces) * needs to only run on nodes labeled git-websites (so it will have the creds to push updates) * needs to set editable email notification on failure (details in comment) Also we will need to converte to a pipeline DSL * define tools, namely maven (alternative get [Tool Environment Plugin|https://plugins.jenkins.io/toolenv/]) * set timeout for 4 hours (alternative get [build timeout plugin|https://plugins.jenkins.io/build-timeout/]) * needs to clean worksapce when done (haven't found an alternatiave, maybe it's a default for non-pipeline jobs now?) " Previous RC Release notes are not removed,13316117,Resolved,Major,Fixed,10/Jul/20 10:07,10/Jul/20 16:25,,"The update_releasenotes function does not remove previous RC's Release notes from RELEASENOTES.md file. CHANGES.md does not have this issue. [https://github.com/apache/hbase/blob/master/dev-support/create-release/release-util.sh#L493-L497]" Cleanup RELEASENOTES.md in the wake of HBASE-24711,13316189,Resolved,Major,Fixed,10/Jul/20 16:37,12/Aug/20 16:42,2.3.0,Seems it'll need some manual adjustment. Change the jenkins job urls in our jenkinsfile,13321755,Resolved,Major,Fixed,10/Aug/20 09:23,11/Aug/20 02:17,,"On ci-hadoop.a.o, we have a folder for all the hbase job, so the job url contains an extra 'job/HBase'." Fix error prone error in FlushTableSubprocedure,13322029,Resolved,Major,Fixed,11/Aug/20 14:00,12/Aug/20 02:04,,"{noformat} [ERROR] /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/FlushTableSubprocedure.java:[105,30] error: [ArraysAsListPrimitiveArray] Arrays.asList does not autobox primitive arrays, as one might expect. (see https://errorprone.info/bugpattern/ArraysAsListPrimitiveArray) Did you mean 'families = Bytes.asList(Bytes.toBytes(family));'? [INFO] 1 error {noformat}" Error message is displayed in the UI of table's compaction state if any region of that table is not open.,13316150,Resolved,Major,Fixed,10/Jul/20 12:11,21/Jul/20 07:10,2.2.3,"When a region of a table is in states closed, merging, splitting, etc, the table's compaction state displays error stack trace.   !ErrorMessageinUI.png!" Parallelize make with Yetus ,13316498,Resolved,Major,Fixed,13/Jul/20 16:40,30/Jul/20 17:48,,"Ytetus by default runs a single process make, which is very very slow. Figure out a way to pass {{-j$(nproc)}} to parallelize it. This runs multiple targets in parallel to speed it up." Support flush a single column family of table,13315583,Resolved,Major,Fixed,08/Jul/20 09:02,10/Aug/20 09:40,2.4.0,"This is follow-on work of HBASE-24404, do it as a seprate issue could make it easier to reveiw." Override CSP in our flaky dashboard html,13321913,Resolved,Major,Won't Fix,11/Aug/20 02:46,11/Aug/20 13:42,,"We got this on the new find flaky tests job. {noformat} Refused to apply inline style because it violates the following Content Security Policy directive: ""style-src 'self'"". Either the 'unsafe-inline' keyword, a hash ('sha256-NSQHKKs1VuvATRi81u9VAYWYDZfJrWTnQg5Ag4MxBQU='), or a nonce ('nonce-...') is required to enable inline execution. {noformat}" Refactor ReplicationSourceManager: move logPositionAndCleanOldLogs/cleanUpHFileRefs to ReplicationSource inside,13316602,Resolved,Major,Fixed,14/Jul/20 03:47,11/Aug/20 12:11,,"After this, ReplicationSourceManager should only keep the methods which are used for startup/terminate ReplicationSource. The startup/teminate releated work will be moved to new ReplicationServer. " ASAN and TSAN coverage,13321932,Open,Major,,11/Aug/20 05:30,,native-client-0.1.0,Run the tests with asan and tsan builds. These would eventually be run as a part of nightly test runs. Download Boost when DOWNLOAD_DEPENDENCIES flag is set,13320547,Resolved,Major,Fixed,02/Aug/20 16:00,11/Aug/20 05:19,native-client-0.1.0,HBASE-24539 added a boost dependency on {{dll:program_location}} that is 1_61_0+. However the default boost installed by various package managers across linux distros is different. For ex: the docker that builds on top of ubuntu-16.04 pulls in 1_5x_x version of boost dev and that broke the build. The ask is to bring boost under DOWNLOAD_DEPENDENCIES flag so that we can standardize across versions easily. Some tests involving RS crash fail with NullPointerException after HBASE-24632 in branch-2,13321429,Resolved,Major,Fixed,07/Aug/20 03:04,09/Aug/20 18:29,2.4.0,"After HBASE-24632, in some tests involving RS crash in branch-2, the following NullPointerException is happening repeatedly and the tests finally fail due to timeout: {code:java} 2020-08-06 16:03:43,101 ERROR [RS_LOG_REPLAY_OPS-regionserver/10.0.1.11:0-1] handler.RSProcedureHandler(51): pid=17 java.lang.NullPointerException at org.apache.hadoop.hbase.regionserver.SplitLogWorker.splitLog(SplitLogWorker.java:107) at org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:100) at org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:45) at org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code} It looks like the following tests fail: {code:java} precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.TestSplitRegionWhileRSCrash. 12 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestHBCKSCP. 13 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated. 13 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithMetaWithoutZKCoordinated. 13 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithoutMeta. 13 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicas. 13 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithoutMetaWithoutZKCoordinated. 13 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSplitWALProcedure. 12 min 2 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.TestSplitWALManager. 13 min 4 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithMeta. 13 min 4 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas. 13 min 4 precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.TestSplitWALManager. 12 min 4 precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithMeta. 12 min 4 precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas. 12 min 4 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash. 12 min 5 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.assignment.TestExceptionInAssignRegion. 12 min 5 precommit checks / yetus jdk8 Hadoop2 checks / org.apache.hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicasWithoutZKCoordinated. 13 min 5 precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash. 12 min 5 precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash. 13 min 5 precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.assignment.TestExceptionInAssignRegion. 12 min 5 precommit checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.master.assignment.TestExceptionInUnassignedRegion. 12 min 5 {code}" [hbase-thirdarty] Put up 3.4.0RC0,13319776,Resolved,Major,Fixed,28/Jul/20 14:35,09/Aug/20 14:16,, Add Cell level TTL functionality at HBase Thrift1/Thrift2,13321486,Open,Major,,07/Aug/20 10:09,,,"Setting TTL at cell level can be done via Java Client, Hbase shell, but this funtionalty is missing at thrift server and client. ref ticket : https://issues.apache.org/jira/browse/HBASE-11764" Adding Bulk Operation Support through PySpark,13321353,Open,Major,,06/Aug/20 17:57,,,"Bulk Operations are supported in Scala but not in PySpark, we should add this support with some examples as well similar to the ones done in Scala and Java. " Fix flaky test TestRaceBetweenSCPAndDTP and TestRaceBetweenSCPAndTRSP for branch-2.2,13320993,Resolved,Major,Fixed,05/Aug/20 01:58,06/Aug/20 08:14,,Backport HBASE-23805 and HBASE-24338 Avoid flooding replication source RSes logs when no sinks are available ,13318737,Resolved,Major,Fixed,22/Jul/20 15:18,27/Jul/20 12:25,2.2.5,"On HBaseInterClusterReplicationEndpoint.replicate, if no sinks are returned by ReplicationSinkManager, say remote peer is not available, we log message below and return false to source shipper thread, which then keeps retrying, flooding source RS log with the below messages: {noformat} WARN org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint: No replication sinks found, returning without replicating. The source should retry with the same set of edits. {noformat} This condition could also cause ReplicationSinkManager.chooseSinks to blow an NPE. " RegionMover should deal with unknown (split/merged) regions,13320023,Resolved,Major,Fixed,29/Jul/20 17:36,05/Aug/20 20:14,,"For a cluster with very high load, it is quite common to see flush/compaction happening every minute on each RegionServer. And we have quite high chances of multiple regions going through splitting/merging. RegionMover, while unloading all regions (graceful stop), writes down all regions to a local file and while loading them back (graceful start), ensures to bring every single region back from other RSs. While loading regions back, even if a single region can't be moved back, RegionMover considers load() failure. We miss out on possibilities of some regions going through split/merge process and the fact that not all regions written to local file might even exist anymore. Hence, RegionMover should gracefully handle moving any unknown region without marking load() failed." HBaseTestingUtility.getConnection should be threadsafe,13320332,Resolved,Major,Fixed,31/Jul/20 07:33,04/Aug/20 16:22,,"the current javadoc for getConnection carries a thread safety warning: {code} /** * Get a Connection to the cluster. Not thread-safe (This class needs a lot of work to make it * thread-safe). * @return A Connection that can be shared. Don't close. Will be closed on shutdown of cluster. */ public Connection getConnection() throws IOException { {code} We then ignore that warning across our test base. We should make the method threadsafe since the intention is to share a single Connection across all users of the HTU instance." Fix the precommit error for branch-1,13320987,Resolved,Major,Duplicate,05/Aug/20 01:30,05/Aug/20 01:31,, Fix the precommit error for branch-2.2,13320673,Resolved,Major,Fixed,03/Aug/20 13:23,04/Aug/20 05:53,1.7.0,[https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/view/change-requests/job/PR-2187/2/console] [CCSMap] ChunkPool and Chunk data structure,13320777,Open,Major,,04/Aug/20 04:10,,,"Even CCSMap data structure is very big, so I plan to further divide into small tasks, this is the first one." Make the Table Schema easier to view even there are multiple families,13315837,Resolved,Major,Fixed,09/Jul/20 09:14,02/Aug/20 18:33,,"Currently we display the column family as vertical, it is not easy to view, my proposal is to display them as horizontal." Enhance ACL region initialization,13320180,Open,Major,,30/Jul/20 12:24,,,"RegionServer persist ACL table entries into Zookeeper during ACL region open, {code} private void initialize(RegionCoprocessorEnvironment e) throws IOException { final Region region = e.getRegion(); Configuration conf = e.getConfiguration(); Map> tables = PermissionStorage.loadAll(region); // For each table, write out the table's permissions to the respective // znode for that table. for (Map.Entry> t: tables.entrySet()) { byte[] entry = t.getKey(); ListMultimap perms = t.getValue(); byte[] serialized = PermissionStorage.writePermissionsAsBytes(perms, conf); zkPermissionWatcher.writeToZookeeper(entry, serialized); } initialized = true; } {code} Currently RegionServer send 2 RPC (one to create the table path and another to set the data) for each table sequentially. {code} try { ZKUtil.createWithParents(watcher, zkNode); ZKUtil.updateExistingNodeData(watcher, zkNode, permsData, -1); } catch (KeeperException e) { LOG.error(""Failed updating permissions for entry '"" + entryName + ""'"", e); watcher.abort(""Failed writing node ""+zkNode+"" to zookeeper"", e); } {code} If a cluster have huge number of tables then ACL region open will take time. Example, it took ~9 min to write 60k tables ACL into ZK.  We should send ZK Ops in a single multi() to enhance this." FSHLog - close the current WAL file in a background thread,13315634,Resolved,Major,Fixed,08/Jul/20 13:43,01/Aug/20 17:18,,"We have this as a TODO in code already {code} // It is at the safe point. Swap out writer from under the blocked writer thread. // TODO: This is close is inline with critical section. Should happen in background? if (this.writer != null) { oldFileLen = this.writer.getLength(); try { TraceUtil.addTimelineAnnotation(""closing writer""); this.writer.close(); TraceUtil.addTimelineAnnotation(""writer closed""); this.closeErrorCount.set(0); } {code} This close call in critical section and writes are blocked. Lets move this close call into another WALCloser thread. " [hbase-thirdparty] Ignore module-info and SubmissionPublisher in enforceBytecodeVersion rule,13320164,Resolved,Major,Fixed,30/Jul/20 10:52,31/Jul/20 01:49,,"Got this when releasing thirdparty-3.4.0. {noformat} 10:46:33 [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ hbase-shaded-jersey --- 10:46:33 [INFO] Restricted to JDK 1.8 yet org.glassfish.jersey.core:jersey-common:jar:2.31:compile contains META-INF/versions/11/org/glassfish/jersey/internal/jsr166/SubmissionPublisher$1.class targeted to 55.0 10:46:33 [INFO] Restricted to JDK 1.8 yet jakarta.ws.rs:jakarta.ws.rs-api:jar:2.1.6:compile contains module-info.class targeted to JDK 1.9 10:46:33 [WARNING] Rule 1: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: HBase has unsupported dependencies. HBase requires that all dependencies be compiled with version 1.8 or earlier of the JDK to properly build from source. You appear to be using a newer dependency. You can use either ""mvn -version"" or ""mvn enforcer:display-info"" to verify what version is active. Non-release builds can temporarily build with a newer JDK version by setting the 'compileSource' property (eg. mvn -DcompileSource=1.8 clean package). Found Banned Dependency: org.glassfish.jersey.core:jersey-common:jar:2.31 Found Banned Dependency: jakarta.ws.rs:jakarta.ws.rs-api:jar:2.1.6 Use 'mvn dependency:tree' to locate the source of the banned dependencies. {noformat}" [hbase-thirdparty] Remove assembly plugin for generating src tarballs,13320216,Resolved,Major,Fixed,30/Jul/20 15:11,31/Jul/20 01:45,,"As we will use git archive to generate the src tarballs in release script, we do not need to use assembly any more." [hbase-operator-tools] Merging regions failed when the table is not default namespace,13319507,Resolved,Major,Fixed,27/Jul/20 09:30,29/Jul/20 10:34,hbase-operator-tools-1.1.0,"Suppose there is a table ""test:test_table"", if you want to merge regions and run the command: {code:java} /opt/hbase/bin/hbase org.apache.hbase.RegionsMerger test:test_table 10 {code} Then you will get error: {code:java} [main] ERROR org.apache.hbase.RegionsMerger - Merging regions failed:[main] ERROR org.apache.hbase.RegionsMerger - Merging regions failed:java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute URI: test:test_table at org.apache.hadoop.fs.Path.initialize(Path.java:259) ~[hadoop-common-3.2.0.jar:?] at org.apache.hadoop.fs.Path.(Path.java:217) ~[hadoop-common-3.2.0.jar:?] at org.apache.hadoop.fs.Path.(Path.java:125) ~[hadoop-common-3.2.0.jar:?] at org.apache.hbase.RegionsMerger.getTablePath(RegionsMerger.java:93) ~[hbase-tools-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT] at org.apache.hbase.RegionsMerger.mergeRegions(RegionsMerger.java:163) ~[hbase-tools-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT] at org.apache.hbase.RegionsMerger.run(RegionsMerger.java:237) [hbase-tools-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) [hadoop-common-3.2.0.jar:?] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) [hadoop-common-3.2.0.jar:?] at org.apache.hbase.RegionsMerger.main(RegionsMerger.java:247) [hbase-tools-1.1.0-SNAPSHOT.jar:1.1.0-SNAPSHOT]Caused by: java.net.URISyntaxException: Relative path in absolute URI: test:test_table at java.net.URI.checkPath(URI.java:1823) ~[?:1.8.0_121] at java.net.URI.(URI.java:745) ~[?:1.8.0_121] at org.apache.hadoop.fs.Path.initialize(Path.java:256) ~[hadoop-common-3.2.0.jar:?] ... 8 more {code}" [Shell] processlist command fails with ERROR: Unexpected end of file from server when SSL enabled,13316641,Resolved,Major,Fixed,14/Jul/20 08:23,28/Jul/20 16:13,,"HBase Shell command ""processlist"" fails with ERROR: Unexpected end of file from server when HBase SSL enabled.   Below code is commented since beginning, see HBASE-4368, [https://github.com/apache/hbase/blob/8076eafb187ce32d4a78aef482b6218d85a985ac/hbase-shell/src/main/ruby/hbase/taskmonitor.rb#L85]" Space Quota violation policy Disable does not work at namespace level,13319318,Open,Major,,25/Jul/20 23:36,,2.2.3,The violation policy Disable does not work at namespace level. [hbase-thirdparty] Set version as 3.4.0 in prep for first RC,13319774,Resolved,Major,Fixed,28/Jul/20 14:32,29/Jul/20 02:01,, [hbase-thirdparty] Bump dependencis in hbase-thirdparty,13319736,Resolved,Major,Fixed,28/Jul/20 12:13,28/Jul/20 14:22,, Reimplement the Constraints API and revisit the IA annotations on related classes,13319176,Resolved,Major,Fixed,24/Jul/20 13:40,28/Jul/20 01:30,, Send announce email,13316527,Resolved,Major,Fixed,13/Jul/20 18:33,27/Jul/20 16:54,,Use the template found on https://hbase.apache.org/book.html#hbase.release.announcement to mail the specified lists. Update 2.1 documentation to 2.1.9 and remove direct link from main page,13319025,Resolved,Major,Fixed,23/Jul/20 18:33,23/Jul/20 20:42,,"For the 2.1 release the available documentation points to 2.1.5. Since the release has reached EOL with 2.1.9 the documentation on the website should reflect this and a direct link to 2.1 should be removed.  " Support hadoop 3.3.0,13318949,Resolved,Major,Duplicate,23/Jul/20 13:25,23/Jul/20 13:39,,"A good thing is that, finally hadoop upgraded protobuf and also shaded the protobuf it uses. Let's try to support it, and also we can purge our own dependencies on protobuf 2.5.0. " Incorrect checksum calculation in saveVersion.sh,13316116,Resolved,Major,Fixed,10/Jul/20 09:59,21/Jul/20 08:57,,"The saveVersion.sh file does not parse the srcChecksum correctly during the releasing process when dev-support/create-release/hbase-rm/Dockerfile is used. This results in missing Source Checksum. Master UI displays this: |HBase Source Checksum|(stdin)=|" Log an ERROR if HBaseSaslRpcServer initialisation fails with an uncaught exception,13317459,Resolved,Major,Fixed,17/Jul/20 17:12,20/Jul/20 11:44,2.3.1,"In ServerRpcConnection.saslReadAndProcess, if an uncaught exception happens while initialising HBaseSaslRpcServer, the same gets swallowed inside netty and never explicitly logged on RegionServer logs. With the introduction of pluggable sasl server providers by HBASE-23347, this situation can become more frequent with the addition of custom providers, if those cause HBaseSaslRpcServer to fail, that should be logged in ServerRpcConnection.saslReadAndProces." Distributing ROOT Region load,13316487,Open,Major,,13/Jul/20 15:51,,,"HBASE-11288 'Splittable Meta' progress keeps getting hung up on how to cache the 'root' table – the first table in the hierarchy of lookups locating user-data in a Table Region. The 'root' table is not splittable by design so its load can not be spread about the cluster by splitting the hot Region as we would usually do. This issue is about listing out requirements, sketching possible approaches, and then getting agreement ahead of implementation as subtasks. In particular, an approach that would work whether the Region to be cached is master-based or hosted by a RegionServer (see design attached to HBASE-11288 for elaboration) would be preferred since then we can separate discussion of cache from the HBASE-11288 'split meta' discussion." Turn OFF Canary WebUI as default,13315737,Resolved,Major,Fixed,08/Jul/20 22:22,17/Jul/20 22:59,,"See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message (mentioned in the parent in full but it is 'Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.shaded.org.eclipse.jetty.server.HttpConfiguration$Customizer' in short). This will surprise operators who are used to the canary's previous pure-cli experience. Let me make it so you ask for the canary webui; by default, it does not come up." The sort icons overlap the col name in master UI ,13317344,Resolved,Major,Fixed,17/Jul/20 07:30,17/Jul/20 16:24,,"In tables section, when description not few, the sort icons and col name are overlap." Flaky Test TestRegionReplicas#testVerifySecondaryAbilityToReadWithOnFiles,13316011,Open,Major,,10/Jul/20 00:13,,2.3.0, rename_rsgroup overwriting the existing rsgroup.,13316458,Resolved,Major,Fixed,13/Jul/20 12:50,15/Jul/20 13:23,,"rename_rsgroup overwriting the current rsgroup. Steps: 1)add_rsgroup 'RSG1' and 'RSG2' 2)move_servers_rsgroup 'RSG1',['server1:port'] 3)rename_rsgroup 'RSG1','RSG2'  After performing step3 RSG1 overwriting to RSG2 and region servers added in RSG1 are not available now. Ideally system should show error message Group already exists: RSG2  " Set version to 2.2.6 in branch-2.2 for first RC of 2.2.6,13315272,Resolved,Major,Fixed,07/Jul/20 01:15,16/Jul/20 11:58,, "MetaFixer#fixHoles() does not include the case for read replicas (i.e, replica regions are not created)",13315942,Resolved,Major,Fixed,09/Jul/20 16:25,15/Jul/20 05:38,2.3.0, "Remove the ""cache"" walsById/walsByIdRecoveredQueues from ReplicationSourceManager",13315057,Resolved,Major,Fixed,06/Jul/20 01:25,14/Jul/20 03:45,, create-release should stage PR with documentation changes,13316538,Open,Major,,13/Jul/20 19:26,,,{{create-release}} has all the bits it needs to put together commits (and PRs) with documentation changes for both {{hbase.git}} and {{hbase-site.git}} that accompany a release candidate. Let's automate this as well. Update reporter tool with new release,13316526,Resolved,Major,Fixed,13/Jul/20 18:31,13/Jul/20 18:34,,Register the new release version with date of SVN {{release}} commit (UTC) in https://reporter.apache.org/addrelease.html?hbase Release 2.3.0 version in JIRA,13316525,Resolved,Major,Fixed,13/Jul/20 18:30,13/Jul/20 18:34,, Push signed release tag to git,13316524,Resolved,Major,Fixed,13/Jul/20 18:29,13/Jul/20 18:34,,Create a (signed) tag under {{rel}} from the successful RC tag. Publish staged release artifacts,13316523,Resolved,Major,Fixed,13/Jul/20 18:28,13/Jul/20 18:34,,{{svn mv}} the successful release candidate bits from {{dev}} to {{release}}. Delete the old RCs from {{dev}}. """release"" staged nexus repository",13316522,Resolved,Major,Fixed,13/Jul/20 18:27,13/Jul/20 18:34,,"Release the staged repository of the successful candidate, drop the others." Automate release candidate promotion,13316514,Open,Major,,13/Jul/20 17:35,,,"The {{create-release}} scripts are great for creating a release candidate. Once a candidate vote has passed, it's up to the RM to promote the candidate. Let's upgrade this last step and automate it as well." [Flaky] TestMasterNoCluster.testStopDuringStart on master,13316120,Resolved,Major,Fixed,10/Jul/20 10:12,10/Jul/20 15:14,,"We need to forward port HBASE-24656 to master branch. The test logs from flaky report:  [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/6537/testReport/org.apache.hadoop.hbase.master/TestMasterNoCluster/testStopDuringStart/] [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/6530/testReport/org.apache.hadoop.hbase.master/TestMasterNoCluster/testStopDuringStart/]   2020-07-10 07:08:04,815 DEBUG [Time-limited test-EventThread] zookeeper.ZKWatcher(555): @Before-0x1010270f65d0001, quorum=127.0.0.1:59817, baseZNode=/hbase Received ZooKeeper Event, type=NodeChildrenChanged, state=SyncConnected, path=/hbase/backup-masters 2020-07-10 07:08:04,824 DEBUG [master/asf904:0:becomeActiveMaster] zookeeper.ZKUtil(358): master:44963-0x1010270f65d0000, quorum=127.0.0.1:59817, baseZNode=/hbase Set watcher on existing znode=/hbase/backup-masters/asf904.gq1.ygridcore.net,44963,1594364881716 2020-07-10 07:08:04,827 INFO [Time-limited test] zookeeper.ZKUtil(1809): multi exception: org.apache.zookeeper.KeeperException$NotEmptyException: KeeperErrorCode = Directory not empty; running operations sequentially (runSequentialOnMultiFailure=true);   org.apache.zookeeper.KeeperException$NotEmptyException: KeeperErrorCode = Directory not empty for /hbase/backup-masters at org.apache.hadoop.hbase.master.TestMasterNoCluster.tearDown(TestMasterNoCluster.java:98)" Do the error handling for replication admin failures,13316231,Open,Major,,10/Jul/20 20:21,,,"[listPeerConfigs()|https://github.com/apache/hbase/blob/branch-1/hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java#L295] for getting the list of peers along with their configuration is not a reliable API. It is not very robust to errors, logs FATAL and swallows the [exceptions|https://github.com/apache/hbase/blob/branch-1/hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java#L254]   Snippet: {code:java} catch (KeeperException e) { this.abortable.abort(""Cannot get the list of peers "", e); } catch (ReplicationException e) { this.abortable.abort(""Cannot get the list of peers "", e); } return peers; {code}   The abortable (connection in this case) also doesn't abort the region server and just logs. This makes upstream believe that there is nothing wrong and proceed without any action which is not good.     {code:java} 2020-07-07 23:11:37,857 FATAL [14774961,peer_id] client.ConnectionManager$HConnectionImplementation - Cannot get the list of peersorg.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode = Session expired for /hbase/replication/peersat org.apache.zookeeper.KeeperException.create(KeeperException.java:130)at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1549)at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getChildren(RecoverableZooKeeper.java:312)at org.apache.hadoop.hbase.zookeeper.ZKUtil.listChildrenNoWatch(ZKUtil.java:513)at org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.getAllPeerConfigs(ReplicationPeersZKImpl.java:249)at org.apache.hadoop.hbase.client.replication.ReplicationAdmin.listPeerConfigs(ReplicationAdmin.java:332) {code}    " Add procedure process time statistics UI,13314396,Resolved,Major,Fixed,01/Jul/20 01:32,10/Jul/20 07:14,,"Added in ""Procedures & Locks"" jsp. For the first version UI, we care about the process time of ServerCrashProcedure, TRSP, OpenRegionProcedure and CloseRegionProcedure. Plan to show the avg/P50/P90/min/max process time of these procedures." Fix Empty region in meta with read replica,13315971,Open,Major,,09/Jul/20 18:35,,2.3.0,"Currently, there is a case in CatalogJanitor which checks if the default region info is missing in metaRow, it is reporting it as EmptyRegionInfoList.    For read replica, this entry needs to be dealt with. In hbase-1, this was caused by region server opens an orphan replica region. In hbase-2, it will not happen since checks are added to defend this case. The hback2 fix is still needed for upgrade. Issues could be brought into hbase-2 post upgrade, hbck2 needs to handle it." "When merging a non-empty region with empty regions, skip the reference creation to avoid compaction.",13315944,Open,Major,,09/Jul/20 16:36,,2.3.0,"Note here while I remember, for the case, there is snapshot, hfiles need to be moved to archive directory to avoid breaking snapshot, so at least one check is needed for this improvement." Turn OFF Canary WebUI as default,13315750,Resolved,Major,Duplicate,08/Jul/20 22:45,08/Jul/20 22:54,,"See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up." Turn OFF Canary WebUI as default,13315746,Resolved,Major,Duplicate,08/Jul/20 22:40,08/Jul/20 22:54,,"See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up." Turn OFF Canary WebUI as default,13315742,Resolved,Major,Duplicate,08/Jul/20 22:29,08/Jul/20 22:54,,"See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up." Turn OFF Canary WebUI as default,13315739,Resolved,Major,Duplicate,08/Jul/20 22:25,08/Jul/20 22:54,,"See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up." Turn OFF Canary WebUI as default,13315738,Resolved,Major,Duplicate,08/Jul/20 22:24,08/Jul/20 22:54,,"See parent issue. There is a CLASSPATH issue when running against hadoop3 that needs resolving. Meantime, the canary fails to run with a cryptic message. This will surprise operators. Let me make it so you ask for the canary webui; by default, it does not come up." Refactor ReplicationSource#addHFileRefs method: move it to ReplicationSourceManager,13315058,Resolved,Major,Fixed,06/Jul/20 01:27,08/Jul/20 06:36,, Fix flaky TestWALEntryStream,13315273,Resolved,Major,Duplicate,07/Jul/20 01:17,07/Jul/20 12:16,,"[https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]   Failed 100.0% (13 / 13) recently." Add excludefile and designatedfile options to graceful_stop.sh,13314616,Resolved,Major,Fixed,02/Jul/20 08:11,05/Jul/20 14:07,2.4.0,RegionMover is support excludefile and designatedfile options now. Integrate these two options into graceful_stop.sh. Add Bulk load param details into its responseTooSlow log,13314971,Open,Major,,04/Jul/20 06:59,,,"Right now the log will come like {code} (responseTooSlow): {""call"":""BulkLoadHFile(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$BulkLoadHFileRequest)"",""starttimems"":1593820455043,""responsesize"":2,""method"":""BulkLoadHFile"",""param"":""TODO: class org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$BulkLoadHFileRequest"",......} {code} " [Flakey] TestVerifyReplication.testVerifyRepJob & TestVerifyReplicationAdjunct.testVerifyReplicationWithSnapshotSupport,13314904,Open,Major,,03/Jul/20 14:17,,2.3.0,"Attaching sunfire reports xml for details. For both reports, on high level, I see some hanging threads for ReadOnlyZKClient and Replica not found for a datablock related Exceptions. [^TEST-org.apache.hadoop.hbase.replication.TestVerifyReplication.xml]" "When processing a procedure, the process doing the work should log the pid",13314568,Open,Major,,01/Jul/20 23:37,,,"One thing I'm observing while trying to debug ProcedureV2 work is it's difficult to track an procedure as it's execution moves around the cluster. It would be nice if workers would include the PID (and maybe PPID) in the work they're performing. This probably means including this information as potential metadata in all of our RPC requests, and finding a way to log it uniformly." DIGEST based auth broken for rpc based ConnectionRegistry,13327893,Resolved,Minor,Fixed,16/Sep/20 16:13,07/Feb/24 07:45,1.7.0,"DIGEST-MD5 based sasl auth depends on cluster-ID to obtain tokens. With master registry, we have a circular dependency here because master registry needs an rpcClient to talk to masters (and to get cluster ID) and rpc-Client needs a clusterId if DIGEST based auth is configured. Earlier, there was a ZK client that has its own authentication mechanism to fetch the cluster ID. HBASE-23330, I think doesn't fully fix the problem. It depends on an active connection to fetch delegation tokens for the MR job and that inherently assumes that the active connection does not use a DIGEST auth. It is not clear to me how common it is to use DIGEST based auth in connections." Unable to call HBaseContext From PySpark,13321350,Open,Minor,,06/Aug/20 17:46,,,"I'm able to get the JavaHBaseContext Object From PySpark but not HBaseContext  {code:java} temp = sc._jvm.org.apache.hadoop.hbase.HBaseConfiguration conf = temp.create() hbaseCon = sc._jvm.org.apache.hadoop.hbase.spark.HBaseContext(sc, conf){code} Running the above Code gives me this error   {code:java} AttributeError: 'SparkContext' object has no attribute '_get_object_id' AttributeError Traceback (most recent call last) in engine ----> 1 hbaseCon = sc._jvm.org.apache.hadoop.hbase.spark.HBaseContext(sc, conf) /usr/local/lib/python3.6/site-packages/py4j/java_gateway.py in _call_(self, *args) 1543 1544 args_command = """".join( -> 1545 [get_command_part(arg, self._pool) for arg in new_args]) 1546 1547 command = proto.CONSTRUCTOR_COMMAND_NAME +\ /usr/local/lib/python3.6/site-packages/py4j/java_gateway.py in (.0) 1543 1544 args_command = """".join( -> 1545 [get_command_part(arg, self._pool) for arg in new_args]) 1546 1547 command = proto.CONSTRUCTOR_COMMAND_NAME +\ /usr/local/lib/python3.6/site-packages/py4j/protocol.py in get_command_part(parameter, python_proxy_pool) 296 command_part += "";"" + interface 297 else: --> 298 command_part = REFERENCE_TYPE + parameter._get_object_id() 299 300 command_part += ""\n"" AttributeError: 'SparkContext' object has no attribute '_get_object_id' {code}  " return value of LogRoller.walRollFinished may be wrong,13319914,Open,Minor,,29/Jul/20 07:18,,2.2.6,"The LogRoller.walRollFinished impl is already buggy. This just checks the status of the boolean. Once we start a roll on a WAL, we reset the boolean (Even before patch HBASE-24665). So it is not clearly telling anything abt the roll status. This can return true even while an active wal roll is going on. We might need another boolean in Controller which clearly tracks whether we are ongoing a roll." MobFileCleanerChore uses a new Connection for each table each time it runs,13315250,Resolved,Minor,Fixed,06/Jul/20 22:09,13/Nov/23 15:23,3.0.0-alpha-1,"Currently creating a new connection for every table under MobFileCleanerChore.java where we should theoretically just using the connection from HBase masterservices.      " Wait for connection attempt to succeed before performing operations on ZK,13325378,In Progress,Minor,,31/Aug/20 18:01,,,"{color:#1d1c1d}Creating the connection with ZK  is asynchronous and notified via the passed in watcher about the  successful connection event. When we attempt any operations, we try to create a connection and then perform a read/write ({color}{color:#1d1c1d}[https://github.com/apache/hbase/blob/979edfe72046b2075adcc869c65ae820e6f3ec2d/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java#L323]{color}{color:#1d1c1d}) without really waiting for the notification event ([https://github.com/apache/hbase/blob/979edfe72046b2075adcc869c65ae820e6f3ec2d/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java#L582)]{color}   {color:#1d1c1d}It is possible we get ConnectionLoss errors when we perform operations on ZK without waiting for the connection attempt to succeed{color}" Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig,13323728,Resolved,Minor,Fixed,20/Aug/20 12:30,20/Aug/20 21:45,3.0.0-alpha-1,"In [ReplicationPeerManager.updatePeerConfig|https://github.com/apache/hbase/blob/1164531d5ab519ab58af82ba3849f8fcded3453f/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java#L272], I found duplicate code appearing twice continuously, so remove once. {code:java} newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration()); newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration()); newPeerConfigBuilder.putAllConfiguration(oldPeerConfig.getConfiguration()); newPeerConfigBuilder.putAllConfiguration(peerConfig.getConfiguration()); {code}" "Back-port ""HBASE-20289 Fix comparator for NormalizationPlan"" to branch-1",13325267,Resolved,Minor,Won't Fix,31/Aug/20 05:09,06/Dec/22 05:14,, [Flake Test][branch-1] TestClientOperationInterrupt#testInterrupt50Percent,13327373,Resolved,Minor,Won't Fix,14/Sep/20 07:54,02/Aug/22 09:10,,"Sometimes threads could finish faster before interrupt() gets called. {code} // ... t.start(); } int expectedNoExNum = nbThread / 2; for (int i = 0; i < nbThread / 2; i++) { if (threads.get(i).getState().equals(Thread.State.TERMINATED)) { expectedNoExNum--; } threads.get(i).interrupt(); } {code} So this test could get failed sometimes." Add hedgedReadOpsInCurThread metric,13326367,Closed,Minor,Fixed,08/Sep/20 03:21,11/Sep/20 05:50,,"When adding Hedged Reads metrics at https://issues.apache.org/jira/browse/HBASE-12220, hedgedReadOpsInCurThread was not included. I wonder if there was any reason to not include them. If not, I will provide pull request to include them soon.   Hedged reads use same thread pool for the original read: [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1349-L1357] When the executor is full and rejects the task, it will be executed in current thread, increasing this metric: [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L2913-L2918] This metric is very useful to determine if the hedged reads thread pool (dfs.client.hedged.read.threadpool.size) is undersized." "Pass WALFactory to Replication so it knows of all WALProviders, not just default/user-space",13328332,Closed,Minor,Fixed,19/Sep/20 00:41,22/Sep/20 19:10,,"Small change that passes all WALProviders to ReplicationService rather than just the default/user-space WALProvider. It does this using the WALFactory vessel since it holds all Providers. This change is to be exploited by adjacent sub-task HBASE-25055 in follow-on. This sub-task also exists to make the HBASE-25055 patch smaller and more focused, easier to review." WebUI header bar overlaps page content when window is too narrow,13315475,Open,Minor,,07/Jul/20 19:38,,2.3.0,"It seems the CSS on our WebUI is such that the header will expand down vertically as the content wraps dynamically. However, the page content does not shift down along with it, resulting in the header overlapping the page content." Improve HBase MultiTablieInputFormat support MapReduce multi Scan,13329111,Open,Minor,,24/Sep/20 02:36,,2.1.7,test Follow up work to add client side scan metrics for read replica,13320302,Open,Minor,,31/Jul/20 01:59,,2.5.0,"This is a followup work for HBASE-18436, which adds client metrics for read replica get. Will add metrics for scan as well. This metrics will be used in PE and any interested applications." check if we're impacted by MASSEMBLY-941 and mitigate if needed,13327268,Open,Minor,,13/Sep/20 04:51,,1.8.0,"MASSEMBLY-941 notes a bug starting in version 3.2.0 of the assembly plugin where scripts lose their executable bit. We've had this version since updating to the apache parent pom version 22 in HBASE-23675. We should check our release artifacts to see if we are impacted and if so downgrade the assembly plugin in our poms to 3.1.1." Use GetoptLong or OptionParser in hbase-shell,13319219,Resolved,Minor,Fixed,24/Jul/20 19:23,09/Feb/21 05:16,2.3.0,"Currently, our hbase-shell command line argument parser is custom-rolled. It would be awesome to instead use Ruby's GetoptLong or OptionParser. * [https://ruby-doc.org/stdlib-2.3.0/libdoc/getoptlong/rdoc/GetoptLong.html] * [https://ruby-doc.org/stdlib-2.3.0/libdoc/optparse/rdoc/OptionParser.html] There is a long-standing {{FIXME}} comment in {{bin/hirb.rb}} to address this: [https://github.com/apache/hbase/blob/975cdf7b88f001aa51d83395c663892f3b5ffbdb/bin/hirb.rb#L50]  " table.rb use LocalDateTime to replace Instant,13324173,Resolved,Minor,Fixed,24/Aug/20 01:20,04/Sep/20 18:18,2.2.3,"https://github.com/apache/hbase/blob/9f62a82334574b135f8e220b024981df64fab811/hbase-shell/src/main/ruby/hbase/table.rb#L754 we can use timeZone to improve readability. {code:java} return java.time.LocalDateTime.ofInstant(instant, java.time.ZoneId.systemDefault()).toString {code} " "The TABLE details of backup Master will always be empty, so I think we can consider dropping it",13329682,In Progress,Minor,,28/Sep/20 05:32,,2.3.2,"When the HBase Master is the Backup Master, the table details page on the UI is always empty, so I think it can be deleted." make export snapshot report size can be config,13321816,Resolved,Minor,Fixed,10/Aug/20 15:11,17/Aug/21 00:16,,"current export snapshot will be report ONE MB (1*1024*1024 Bytes), we can make it can be config " `assert` on allocated buffer sizes before making calls to `Unsafe.copyMemory`,13326953,Open,Minor,,10/Sep/20 20:15,,2.3.0,"While investigating a SIGSEGV, I stumbled into our use of {{Unsafe.copyMemory}} for moving data between {{byte[]}}'s and/or {{DirectByteBuffer}}'s. Calls to {{copyMemory}} use an Object, offset API that performs no validation what so ever. I'd like to add {{assert}} statements (disabled by default) before these memory copies." [Flake Test][branch-1] TestExportSnapshotWithTemporaryDirectory,13330090,Resolved,Minor,Fixed,30/Sep/20 04:31,30/Sep/20 10:56,, [Flake Test][branch-1] TestFromClientSide#testCacheOnWriteEvictOnClose,13329874,Resolved,Minor,Fixed,29/Sep/20 07:46,29/Sep/20 16:18,, [Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp,13327413,Resolved,Minor,Fixed,14/Sep/20 11:01,29/Sep/20 06:39,, [Flaky Test] TestRestartCluster#testClusterRestart,13327645,Resolved,Minor,Fixed,15/Sep/20 10:24,28/Sep/20 06:15,, [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer,13327655,Resolved,Minor,Fixed,15/Sep/20 11:05,28/Sep/20 05:50,, Resolve the TODO of AssignmentManager's loadMeta() method.,13327630,Open,Minor,,15/Sep/20 09:17,,2.2.3,All the assignments are blocked until meta is loaded. Better to use a threadpool for visiting the meta regions. Candidate Generator helper getAction method ignoring 0th index region,13324135,Resolved,Minor,Duplicate,23/Aug/20 09:08,15/Mar/21 13:50,,"Balance Candidate generators such as `LocalityBasedCandidateGenerator`, `RegionReplicaCandidateGenerator`,  `RegionReplicaRackCandidateGenerator`, etc uses helper method `getAction` to generate action is ignoring 0th index of `fromRegion` and `toRegion`.  {code:java} protected BaseLoadBalancer.Cluster.Action getAction(int fromServer, int fromRegion, int toServer, int toRegion) { if (fromServer < 0 || toServer < 0) { return BaseLoadBalancer.Cluster.NullAction; } if (fromRegion > 0 && toRegion > 0) { return new BaseLoadBalancer.Cluster.SwapRegionsAction(fromServer, fromRegion, toServer, toRegion); } else if (fromRegion > 0) { return new BaseLoadBalancer.Cluster.MoveRegionAction(fromRegion, fromServer, toServer); } else if (toRegion > 0) { return new BaseLoadBalancer.Cluster.MoveRegionAction(toRegion, toServer, fromServer); } else { return BaseLoadBalancer.Cluster.NullAction; } } {code} Is this unintentional or there is some particular reason? " Add possibility to set different types of L1 cache,13330146,Resolved,Minor,Implemented,30/Sep/20 10:41,28/Feb/21 16:02,,"The feature HBASE-23887 allow speed up to 3 times read performance but maybe it is too complicated. So there are proposals give users possibility to choose type of cache L1. Looks like it needs to change few classes (CombinedBlockCache, InclusiveCombinedBlockCache, CacheConfig) if somebody can code this it would be cool." RegionMonitor support RegionTask count normalize,13329892,Open,Minor,,29/Sep/20 09:01,,,"large count of region task from canary may affect user normal request, meanwhile if region task is few, the  availability monitoring may shake for occasional exception. so , if the task count is large , we will randomly trim tasks for each table, according to the raito of the table region count in whole tasks region count. If the task count is few,  we will repeat tasks" Add support of adding base peer configs via hbase-site.xml for all replication peers.,13319036,Resolved,Minor,Fixed,23/Jul/20 19:27,22/Dec/20 10:07,1.7.0,"Today, if a user needs to apply some common base peer configs to all the replication peers on a given cluster, the only way is to execute update_peer_config via CLI which requires manual intervention and can be tedious in case of large deployment fleet. As part of this JIRA, we plan to add the support to have base replication peer configs as part of hbase-site.xml like hbase.replication.peer.base.config=""k1=v1;k2=v2.."" which can be easily updated and applied as part of a rolling restart. Example below: hbase.replication.peer.base.configs hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123 This will be empty by default, but one can override to have base configs in place. The final peer configuration would be a merge of this newly added base config + whatever users override during the peer creation/update (if any). Related Jira: https://issues.apache.org/jira/browse/HBASE-17543.  HBASE-17543 added the support to add the WALEntryFilters to default endpoint via peer configuration. By this new Jira we are extending the support to update peer configs via hbase-site.xml." Swallow Throwable if catch throw other exception,13326983,Open,Minor,,11/Sep/20 01:56,,2.2.3,"if this.close() throw exception,  will not explain ""throw t"", we will not seem actual error.As shown in the figure below. this is code in hbase master branch. !image-2020-09-11-09-45-06-952.png! this is log in my production environment， actual error is not printing: 2020-09-10 16:38:17,249 | INFO  | RS_OPEN_REGION-regionserve | Open aes_table,,1599722342956.c05438c8c2e3ec250e8fcbf35b49694d. | org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:135)2020-09-10 16:38:17,249 | INFO  | RS_OPEN_REGION-regionserve | Open aes_table,,1599722342956.c05438c8c2e3ec250e8fcbf35b49694d. | org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:135)2020-09-10 16:38:17,254 | INFO  | RS_OPEN_REGION-regionserver | System coprocessor org.apache.hadoop.hbase.hindex.server.regionserver.HIndexRegionCoprocessor loaded, priority=536870911. | org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:165)2020-09-10 16:38:17,254 | INFO  | RS_OPEN_REGION-regionserver | System coprocessor org.apache.hadoop.hbase.security.token.TokenProvider loaded, priority=536870912. | org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:165)2020-09-10 16:38:17,254 | INFO  | RS_OPEN_REGION-regionserver | System coprocessor com.huawei.hadoop.hbase.backup.services.RecoveryCoprocessor loaded, priority=536870913. | org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:165)2020-09-10 16:38:17,254 | WARN  | RS_OPEN_REGION-regionserver | HbaseUserUtilsImpl.initialize: Unexpected: initialization called more than once! | org.apache.ranger.authorization.hbase.HbaseUserUtilsImpl.initiailize(HbaseUserUtilsImpl.java:48)2020-09-10 16:38:17,254 | INFO  | RS_OPEN_REGION-regionserver | System coprocessor org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor loaded, priority=536870914. | org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:165)2020-09-10 16:38:17,254 | WARN  | RS_OPEN_REGION-regionserver | SecureBulkLoadEndpoint is deprecated. It will be removed in future releases. | org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.start(SecureBulkLoadEndpoint.java:75)2020-09-10 16:38:17,255 | WARN  | RS_OPEN_REGION-regionserver | Secure bulk load has been integrated into HBase core. | org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint.start(SecureBulkLoadEndpoint.java:76)2020-09-10 16:38:17,255 | INFO  | RS_OPEN_REGION-regionserver | System coprocessor org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint loaded, priority=536870915. | org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:165)2020-09-10 16:38:17,255 | INFO  | RS_OPEN_REGION-regionserver | System coprocessor org.apache.hadoop.hbase.security.access.ReadOnlyClusterEnabler loaded, priority=536870916. | org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:165)2020-09-10 16:38:17,255 | INFO  | RS_OPEN_REGION-regionserver | System coprocessor org.apache.hadoop.hbase.coprocessor.MetaTableMetrics loaded, priority=536870917. | org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:165)2020-09-10 16:38:17,255 | INFO  | RS_OPEN_REGION-regionserver | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:210)2020-09-10 16:38:17,255 | INFO  | RS_OPEN_REGION-regionserver | Waiting for flushes and compactions to finish for the region aes_table,,1599722342956.c05438c8c2e3ec250e8fcbf35b49694d. | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1812)2020-09-10 16:38:17,255 | INFO  | RS_OPEN_REGION-regionserver | Total wait time for flushes and compaction for the region aes_table,,1599722342956.c05438c8c2e3ec250e8fcbf35b49694d. is: 0ms | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1848)2020-09-10 16:38:17,256 | INFO  | RS_OPEN_REGION-regionserver | Closing region aes_table,,1599722342956.c05438c8c2e3ec250e8fcbf35b49694d. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1676)2020-09-10 16:38:17,337 | WARN  | RS_OPEN_REGION-regionserver | Failed to open region aes_table,,1599722342956.c05438c8c2e3ec250e8fcbf35b49694d., will report to master | org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.cleanUpAndReportFailure(AssignRegionHandler.java:89)java.io.IOException: The new max sequence id 1 is less than the old max sequence id 10 at org.apache.hadoop.hbase.wal.WALSplitUtil.writeRegionSequenceIdFile(WALSplitUtil.java:413) at org.apache.hadoop.hbase.regionserver.HRegion.writeRegionCloseMarker(HRegion.java:1241) at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1781) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1594) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1540) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7484) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7429) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7401) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7359) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7310) at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:145) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)" Display Task completion time and/or processing duration on Web UI,13318542,Resolved,Minor,Fixed,21/Jul/20 18:53,02/Jan/21 19:26,2.3.0,"Our web UI's list ""Tasks"", some of which are really important things an operator wants to know about. We have columns Start Time, Description, State, and Status (which looks more or less identical to Description). We don't have Completion Time or Duration columns. I think it would be nice to see at a glance how long various Tasks are taking." Add RC number to the description in nexus staging repository,13316513,Open,Minor,,13/Jul/20 17:34,,,"Our create-release script pushes release candidate bits to a ""staging"" repository in Apache nexus. It would be nice if the ""description"" field there would say which RC it represents." Add support for java properties to hbase-vote.sh,13328877,Resolved,Minor,Fixed,22/Sep/20 21:48,25/Sep/20 22:22,,A small tweak to {{hbase-vote.sh}} so that it can accept a -D argument. I want this for evaluating branch-2.3 with Hadoop3 and JDK11. refactor valueOf PoolType,13322218,Resolved,Minor,Fixed,12/Aug/20 08:36,19/Aug/20 01:45,, We initialize Filesystems more than once.,13327864,Resolved,Minor,Fixed,16/Sep/20 13:24,24/Nov/20 16:50,2.2.6,"In HFileSystem {code} // Create the default filesystem with checksum verification switched on. // By default, any operation to this FilterFileSystem occurs on // the underlying filesystem that has checksums switched on. this.fs = FileSystem.get(conf); this.useHBaseChecksum = useHBaseChecksum; fs.initialize(getDefaultUri(conf), conf); {code} We call fs.initialize(). Generally the FS would have been created and inited either in the FileSystem.get() call above or even when we try to check {code} FileSystem fs = p.getFileSystem(c); {code} The FS that gets cached in the hadoop-common layer does the init for us. So we doing it again is redundant. " Create a metric to track full region scans RPCs,13327590,Resolved,Minor,Fixed,15/Sep/20 05:48,19/Nov/20 04:27,3.0.0-alpha-1,"A metric that indicates how many of the scan requests were without start row and/or stop row. Generally such queries may be wrongly written or may require better schema design and those may be some queries doing some sanity check to verify if their actual application logic has done the necessary updates and the all that expected rows are processed. We do have some logs at the RPC layer to see what queries take time but nothing as a metric. " Improve insight into replication WAL readers hung on checkQuota,13319567,Resolved,Minor,Fixed,27/Jul/20 16:00,07/Aug/20 22:51,,"Helped a customer this past weekend who, with a large number of RegionServers, has some RegionServers which replicated data to a peer without issues while other RegionServers did not. The number of queue logs varied over the past 24hrs in the same manner. Some spikes in queued logs into 100's of logs, but other times, only 1's-10's of logs were queued. We were able to validate that there were ""good"" and ""bad"" RegionServers by creating a test table, assigning it to a regionserver, enabling replication on that table, and validating if the local puts were replicated to a peer. On a good RS, data was replicated immediately. On a bad RS, data was never replicated (at least, on the order of 10's of minutes which we waited). On the ""bad RS"", we were able to observe that the \{{wal-reader}} thread(s) on that RS were spending time in a Thread.sleep() in a different location than the other. Specifically it was sitting in the {{ReplicationSourceWALReader#checkQuota()}}'s sleep call, _not_ the {{handleEmptyWALBatch()}} method on the same class. My only assumption is that, somehow, these RegionServers got into a situation where they ""allocated"" memory from the quota but never freed it. Then, because the WAL reader thinks it has no free memory, it blocks indefinitely and there are no pending edits to ship and (thus) free that memory. A cursory glance at the code gives me a _lot_ of anxiety around places where we don't properly clean it up (e.g. batches that fail to ship, dropping a peer). As a first stab, let me add some more debugging so we can actually track this state properly for the operators and their sanity." CompactionConfiguration logs unrealistic store file sizes,13329048,Resolved,Minor,Fixed,23/Sep/20 18:10,02/Nov/20 22:02,2.3.2,"I noticed this in the debug logging of a unit test that makes use of a MiniCluster. I'm pretty sure {{8.00 EB}} -- exabytes?? -- is not an accurate reporting of the size of these HFiles. {noformat} 2020-09-22 16:20:57,996 INFO [StoreOpener-5e0b426a952230abb65623fc54869833-1] compactions.CompactionConfiguration(177): size [128 MB, 8.00 EB, 8.00 EB); files [3, 10); ... {noformat}" Git/Jira Release Audit: limit branches when building audit db,13321893,Resolved,Minor,Fixed,10/Aug/20 23:09,29/Oct/20 16:22,3.0.0-alpha-1,"Populating the audit database with release tag information from git is time consuming. Until that's sorted out, give the user a flag for limiting which branches they want to be reviewed." RSGroupInfo's toString() and hashCode() does not take into account configuration map.,13330249,Resolved,Minor,Fixed,30/Sep/20 20:47,23/Oct/20 00:54,2.2.3,RSGroupInfo's toString() and hashcode() methods should include Configurations as well which is added as a part of HBASE-24431. Invalid addFsRegionsMissingInMeta -d,13324181,Open,Minor,,24/Aug/20 03:15,,2.2.3,"[https://github.com/apache/hbase-operator-tools/blob/87878aada3354514050f5a2df11f27b317efd42d/hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java#L436] -d is invalid. addFsRegionsMissingInMeta does not use -d" 'Failed report transition' logs too often,13317261,Open,Minor,,16/Jul/20 22:03,,2.3.0,"The parent issue fixed a backoff that was too aggressive. Now I notice we try too much. Saw 9k logs in 17 seconds of the below type... {code:java} 2020-07-15 14:36:23,104 INFO org.apache.hadoop.hbase.regionserver.HRegionServer: Failed report transition server { host_name: ""X.example.org"" port: 16020 start_code: 1594823099666 } transition { transition_ code: CLOSED region_info { region_id: 1594814749475 table_name { namespace: ""default"" qualifier: ""IntegrationTestBigLinkedList"" } start_key: ""\""\""\""\""\""\""\"" "" end_key: ""#Q\352\f\003"" offline: false split: false replica_id: 0 } proc_id: 81545 }; retry (#8888) after 200805ms delay (Master is coming online...). {code} The delay doesn't seem correct or respected.    " fix replication.stats.thread.period.seconds default setting bug ,13329589,Open,Minor,,27/Sep/20 06:04,,2.2.6,replication.stats.thread.period.seconds is in seconds while default TimeUnit is TimeUnit.MILLISECONDS. Move LogComparator from ReplicationSource to AbstractFSWALProvider#.WALsStartTimeComparator,13329050,Resolved,Minor,Fixed,23/Sep/20 18:11,01/Oct/20 17:20,,"Minor cleanup item noticed playing over in HBASE-18070. ReplicationSource has an inner class named LogComparator which is a pretty generic name for the comparator only it just compares on WAL start time and nothing else. Also, messing in HBASE-18070 I ran into compares that included user-space WALs and hbase:meta WALs. The LogComparator as is barfed on meta WALs. This ticket moves the comparator to AbstractFSWALProvider, where folks will go looking if they need WAL comparators, and it also renames it to more clearly explain what it does (and makes it so it can compare start times even if it a meta WAL).  " "The link of ""Re:(HBASE-451) Remove HTableDescriptor from HRegionInfo"" invalid",13328164,Resolved,Minor,Fixed,18/Sep/20 02:29,30/Sep/20 19:09,,"This link belong to ""184.8.8. Do not edit JIRA comments"" at document." Fix property name added as part of HBASE-24764 in branch-1,13330066,Resolved,Minor,Fixed,30/Sep/20 01:07,30/Sep/20 05:20,,"A new property was added as part of this https://issues.apache.org/jira/browse/HBASE-24764.  Master branch has the name as ""hbase.replication.peer.base.config"" while branch-1 has the name as ""hbase.replication.peer.default.config""   As part of this Jira fix the name in branch-1 to be consistent.   " Fix log line in SimpleRegionNormalizer,13329692,Resolved,Minor,Fixed,28/Sep/20 07:28,28/Sep/20 08:15,1.7.0,"Currently it is logging the string targetRegionSize instead of value LOG.debug(""Table "" + table + "": target region count is "" + targetRegionCount+ "", target region size is targetRegionSize"");" Wrong RIT page number in Master UI,13329362,Resolved,Minor,Fixed,25/Sep/20 08:13,25/Sep/20 10:47,,"In the following picture, there are 71 RIT totally, 10 in per page, so there should be 8 pages, rather than 15 pages: !1.png! !2.png!" Remove the unnecessary System.out.println in MasterRegistry,13328396,Resolved,Minor,Fixed,20/Sep/20 07:45,20/Sep/20 18:24,,"https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java#L328 This line." QuotaRefresherChore doesn't update QuotaCache for user effectively,13328617,Open,Minor,,21/Sep/20 18:28,,,"Currently RegionServer record a user on their first RPC and trigger the QuotaCache refresh, https://github.com/apache/hbase/blob/8a6299bb387aaedcdab05224a462e63cd121fbb0/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L136 And QuotaRefresherChore refresh quota periodically for those users who are recorded by RegionServer on their first RPC,  https://github.com/apache/hbase/blob/8a6299bb387aaedcdab05224a462e63cd121fbb0/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L284   So even though user quota is set but it will be updated when user send RPC. Here each user will get 1 extra RPC in each RegionServer life and same will continue when got restarted.    We can enhance this by doing narrow scan on quota table to get the user specific quota" Display region name instead of encoded region name in HBCK report page.,13328337,Resolved,Minor,Fixed,19/Sep/20 06:09,20/Sep/20 01:24,2.3.1,"In HMaster UI, in HBCK report, holes, overlaps and unknown server display only encoded region names.  In display region encode name does not give any information. like which table, what's the start key etc.  I think it is better to display the region name instead of region encoded name. !image-2020-09-19-11-39-01-755.png!" Hbck chore logs wrong message when loading regions from RS report,13326939,Resolved,Minor,Fixed,10/Sep/20 18:56,16/Sep/20 10:05,2.3.1,"{code:java} LOG.info(""Loaded {} regions from {} regionservers' reports and found {} orphan regions"", numRegions, rsReports.size(), orphanRegionsOnFS.size()); {code} In above log message orphanRegionsOnFS.size() should be replaced with orphanRegionsOnRS.size() as the regions are loaded from RS not form FS" WAL split edits number is negative in RegionServerUI,13327831,Resolved,Minor,Fixed,16/Sep/20 09:45,17/Sep/20 01:54,,!2020-09-16 11-38-13屏幕截图.png! Replace MovedRegionsCleaner with guava cache,13326309,Resolved,Minor,Fixed,07/Sep/20 13:41,19/Sep/20 07:24,,"Chore is a task executed periodically, here a cache with expired time is enough." Fix several problems when starting webUI,13322036,Resolved,Minor,Fixed,11/Aug/20 14:40,10/Sep/20 04:49,2.3.0,"As discussed in the parent issue. There are three problems to be solved： # If we put up webUI while starting Canary, there throw a ClassNotFoundException that shaded class cannot be found # webUI should be showing up only in daemon mode # ServletException throwing when visiting the web page of Canary webUI" Update default URL to KEYS file in `hbase-vote.sh`,13328134,Resolved,Minor,Fixed,17/Sep/20 20:58,18/Sep/20 20:22,3.0.0-alpha-1,"{{hbase-vote.sh}} goes to {{https://www.apache.org/dist/hbase/KEYS}} to find the KEYS file. That URL now gives a redirect to {{https://downloads.apache.org/hbase/KEYS}}. The script doesn't follow the redirect. Let's update the script to point to the new URL." Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter,13325609,Resolved,Minor,Fixed,01/Sep/20 21:07,12/Sep/20 19:55,,"Currently, [WALPrettyPrinter|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java] provides an option to ignore the values in the output, but it prints the whole cell and has no option to ignore some information from the cell. Sometimes, the user may only need the row keys from WAL and it may reduce the size of output from WALPrettyPrinter significantly. We should provide flexibility to output only rowkey from the cell. In addition we should increase the flexibility for providing multiple tables in the table filter. " Fix major compaction interval check logic bug when value of `hbase.hregion.majorcompaction` is below 0,13327286,Open,Minor,,13/Sep/20 11:29,,,"In `RatioBasedCompactionPolicy#shouldPerformMajorCompaction` {code:java} // mcTime can be less than 0 long mcTime = getNextMajorCompactTime(filesToCompact); //this check logic can't handle the condtion that mcTime is less than 0 if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) { return result; } .... // As long as lowTimestamp > 0, the following logic is true, and major compaction will run continually if (lowTimestamp > 0L && lowTimestamp < (now - mcTime)) {code} Am i wrong?, By the way, do hbase allow to set negative values to properties like this? is it necessary to make valid check? " Rest Client throws AbstractMethodError about javax.ws.rs.core.UriBuilder.uri,13326229,Resolved,Minor,Invalid,07/Sep/20 03:11,09/Sep/20 07:21,2.2.5,"Reproduce: 1.Branch:latest master 2.JVM: java version ""1.8.0_151"" 3. OS: MacOS 10.13.1 execute the following command # cd bin # ./hbase rest start then when i visit '127.0.0.1:8080',the following is the the full stack {code:java} ava.lang.AbstractMethodError: javax.ws.rs.core.UriBuilder.uri(Ljava/lang/String;)Ljavax/ws/rs/core/UriBuilder; at javax.ws.rs.core.UriBuilder.fromUri(UriBuilder.java:96) at org.apache.hbase.thirdparty.org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:275) at org.apache.hbase.thirdparty.org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:763) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1651) at org.apache.hadoop.hbase.http.SecurityHeadersFilter.doFilter(SecurityHeadersFilter.java:66) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1638) at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:52) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1638) at org.apache.hadoop.hbase.rest.filter.GzipFilter.doFilter(GzipFilter.java:77) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1638) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:567) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at org.apache.hbase.thirdparty.org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:602) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1610) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1377) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:507) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1580) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1292) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.handle(Server.java:501) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:383) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:556) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:375) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273) at org.apache.hbase.thirdparty.org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) at org.apache.hbase.thirdparty.org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105) at org.apache.hbase.thirdparty.org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:806) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:938) at java.lang.Thread.run(Thread.java:748) {code} Have anyone ever met this problem before？ " Donot merge regions if they are non adjacent in MergeNormalizationPlan.execute,13326245,Resolved,Minor,Fixed,07/Sep/20 06:36,07/Sep/20 12:17,1.6.0,"Currently when we have MergeNormalizationPlan we do a force merge in execute method {code:java} // code placeholder admin.mergeRegions(firstRegion.getEncodedNameAsBytes(), secondRegion.getEncodedNameAsBytes(), true); {code} Since we do not expect these regions to be non adjacent it is better to not force merge and be on safe side." Backport HBASE-20985 to branch-1,13325268,Resolved,Minor,Fixed,31/Aug/20 05:16,03/Sep/20 08:40,, Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner,13325423,Resolved,Minor,Fixed,01/Sep/20 02:09,02/Sep/20 10:14,,"Currently, read point parameter in method StoreFlush#performFlush is useless and can be safely removed. and then method StoreFlush#createScanner can also remove this parameter See below {code:java} // Some comments here /** * Performs memstore flush, writing data from scanner into sink. * @param scanner Scanner to get data from. * @param sink Sink to write data to. Could be StoreFile.Writer. * @param smallestReadPoint Smallest read point used for the flush. * @param throughputController A controller to avoid flush too fast */ protected void performFlush(InternalScanner scanner, CellSink sink, long smallestReadPoint, ThroughputController throughputController) throws IOException {code} Parameter smallestReadPoint is not used in this method. When `smallestReadPoint` is removed, inner method `createScanner` can remove this necessary parameter too " Remove QuotaCache.java SuppressWarnings annotation ,13325879,Patch Available,Minor,,03/Sep/20 09:06,,1.1.13,"map check key exist mistakenly use contains insteadof containsKey cause the warning, while the check logic is removed in master now, the SuppressWarnings should be removed too." Yetus IA Javadoc links are no longer available,13320496,Resolved,Minor,Fixed,01/Aug/20 10:23,31/Aug/20 15:43,,"For HBase doc section ""*HBase API Surface*"", doc references for Apache Yetus InterfaceAudience 0.5.0 are outdated and no longer available: [https://yetus.apache.org/documentation/0.5.0/interface-classification/] InterfaceAudience APIs are quite stable and hence, we can update our doc links to point to [https://yetus.apache.org/documentation/in-progress/interface-classification/] instead of version specific API doc." "Include JVM information on Web UI under ""Software Attributes""",13315715,Resolved,Minor,Fixed,08/Jul/20 19:54,23/Jul/20 17:13,,"It's a small thing, but seems like an omission." Enable journal logging for HBase snapshot operation,13316763,Resolved,Minor,Fixed,14/Jul/20 19:09,21/Jul/20 01:59,1.7.0,"The HBase snapshot operation contains multiple steps like actual snapshot creation, consolidate phase (reading region manifests from HDFS) , verifier phase ( validate the consolidated manifests against the actual number of regions for the table)   Sometimes it happens to be taking time in one of the phases and we don't know exactly which one is taking time unless we have a thread dump at the very same time. The journal logging would definitely help us give more insights into the time taken for each phase" NPE/500 accessing webui on master startup,13318545,Resolved,Minor,Fixed,21/Jul/20 19:09,29/Jul/20 15:00,2.3.0,"I got a 500 error while accessing the master web ui (non-backup master) during startup. {noformat} 2020-07-21 18:56:39,762 WARN org.eclipse.jetty.servlet.ServletHandler: /master-status java.lang.NullPointerException at org.apache.hadoop.hbase.tmpl.master.MasterStatusTmplImpl.renderNoFlush(MasterStatusTmplImpl.java:339) at org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.renderNoFlush(MasterStatusTmpl.java:397) at org.apache.hadoop.hbase.tmpl.master.MasterStatusTmpl.render(MasterStatusTmpl.java:388) at org.apache.hadoop.hbase.master.MasterStatusServlet.doGet(MasterStatusServlet.java:79) at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) ... {noformat} {{MasterStatusTmplImpl.java:339}} appears to align with {{MasterStatusTmpl.jamon:227}}: {noformat} <%if master.getMasterCoprocessorHost().findCoprocessor(""RSGroupAdminEndpoint"") != null && serverManager.getOnlineServersList().size() > 0 %> {noformat}" Backport HBASE-24336 to branch-2.2,13318688,Resolved,Minor,Fixed,22/Jul/20 11:54,30/Jul/20 02:43,2.2.5,HBASE-24336 is applicable to branch-2.2 also. [hbtop] StoreFile size should be rounded off,13319329,Resolved,Minor,Fixed,26/Jul/20 06:38,27/Jul/20 23:38,,"Currently, hbtop doesn't show StoreFile size rounded off, so when it's reached 1GB it will be very ugly as follows: !Screen Shot.png! We should round off StoreFile size." InfoServer support ipv6 host and port,13319429,Resolved,Minor,Fixed,27/Jul/20 03:17,27/Jul/20 17:14,2.1.9,"ipv6 host and port is [ a:::b:c:d]:16010 ipv4 host and port is a.b.c.d:16010 we can use HostAndPort to handle it" Simplify the logic of getRegionInfo in TestFlushFromClient to reduce redundancy code,13321021,Resolved,Minor,Fixed,05/Aug/20 06:43,05/Aug/20 14:42,,"Current logic: {code:java} private List getRegionInfo() { return TEST_UTIL.getHBaseCluster().getLiveRegionServerThreads().stream() .map(JVMClusterUtil.RegionServerThread::getRegionServer) .flatMap(r -> r.getRegions().stream()) .filter(r -> r.getTableDescriptor().getTableName().equals(tableName)) .collect(Collectors.toList()); } {code} The MiniHBaseCluster has similar method to do same thing. So it could just directly call: {code:java} private List getRegionInfo() { return TEST_UTIL.getHBaseCluster().getRegions(tableName); } {code}" Exception on standalone (master) shutdown,13321881,Resolved,Minor,Fixed,10/Aug/20 21:24,12/Aug/20 11:51,3.0.0-alpha-1,"Running HBase ({{master}} branch) in standalone mode, terminating the process results in the following stack traces logged at error. It appears we shutdown the zookeeper client out-of-order with {{shutdown}} of the thread pools. {noformat} 2020-08-10 14:21:46,777 INFO [RS:0;localhost:16020] zookeeper.ZooKeeper: Session: 0x100111361f20001 closed 2020-08-10 14:21:46,778 INFO [RS:0;localhost:16020] regionserver.HRegionServer: Exiting; stopping=localhost,16020,1597094491257; zookeeper connection closed. 2020-08-10 14:21:46,778 ERROR [main-EventThread] zookeeper.ClientCnxn: Error while calling watcher java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@6e61af4b rejected from java.util.concurrent.ThreadPoolExecutor@6a5e365f[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 4] at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063) at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830) at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379) at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112) at java.util.concurrent.Executors$DelegatedExecutorService.submit(Executors.java:678) at org.apache.hadoop.hbase.zookeeper.ZKWatcher.process(ZKWatcher.java:559) at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:535) at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:510) 2020-08-10 14:21:46,778 INFO [shutdown-hook-0] regionserver.ShutdownHook: Starting fs shutdown hook thread. 2020-08-10 14:21:46,779 ERROR [main-EventThread] zookeeper.ClientCnxn: Error while calling watcher java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@7d41da91 rejected from java.util.concurrent.ThreadPoolExecutor@6a5e365f[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 4] at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063) at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830) at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379) at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112) at java.util.concurrent.Executors$DelegatedExecutorService.submit(Executors.java:678) at org.apache.hadoop.hbase.zookeeper.ZKWatcher.process(ZKWatcher.java:559) at org.apache.hadoop.hbase.zookeeper.PendingWatcher.process(PendingWatcher.java:40) at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:535) at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:510) 2020-08-10 14:21:46,780 INFO [main-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x100111361f20001 2020-08-10 14:21:46,780 INFO [shutdown-hook-0] regionserver.ShutdownHook: Shutdown hook finished. {noformat}" Correct the help content of assign and unassign commands in hbase shell,13321976,Resolved,Minor,Fixed,11/Aug/20 10:00,13/Aug/20 10:18,,"Help content in assign.rb: Assign a region. Use with caution. *If region already assigned,* *this command will do a force reassign.* For experts only.   Help content in unassign.rb: Unassign a region. *Unassign will close region in current location and then* *reopen it again.* Pass 'true' to force the unassignment ('force' will clear all in-memory state in master before the reassign. If results in double assignment use hbck -fix to resolve. To be used by experts).   The bold part are not right now, so update them." BulkLoadHFilesTool/LoadIncrementalHFiles should accept -D options from command line parameters,13322830,Resolved,Minor,Fixed,14/Aug/20 23:17,19/Aug/20 11:12,,"Currently, BulkLoadHFilesTool/LoadIncrementalHFiles doesn't accept -D options from command line parameters. It should support them. " RSGRoup: Error message while Table moving table to a RS if one of the region is in closed state.,13324455,Open,Minor,,25/Aug/20 11:40,,2.2.3,"Error message while Table moving table to a RS if one of the region is in closed state. However shell command threw no error after all retry failed and also table is shown under this rsgroup  in UI  Log a89937ba9419f52d8bee0ba53a3e0001 to RSGroup rsg1 2020-08-25 20:02:30,065 ERROR [RpcServer.default.FPBQ.Fifo.handler=49,queue=4,port=16000] rsgroup.RSGroupAdminServer: Move region a89937ba9419f52d8bee0ba53a3e0001 to group failed, will retry, current retry time is 48 org.apache.hadoop.hbase.client.DoNotRetryRegionException: Unexpected state for rit=CLOSED, location=null, table=test1, region=a89937ba9419f52d8bee0ba53a3e0001 at org.apache.hadoop.hbase.master.assignment.AssignmentManager.preTransitCheck(AssignmentManager.java:604) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.createMoveRegionProcedure(AssignmentManager.java:662) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:679) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:309) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:452) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.moveTables(RSGroupAdminEndpoint.java:233) at org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:14933) at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:1018) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:458) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2020-08-25 20:02:30,066 INFO [RpcServer.default.FPBQ.Fifo.handler=49,queue=4,port=16000] rsgroup.RSGroupAdminServer: Moving 4 region(s) to group rsg1, current retry=48" [hbase-thirdparty] Builds without a `clean` phase fail on hbase-shaded-jetty,13322098,Resolved,Minor,Fixed,11/Aug/20 18:39,17/Aug/20 02:59,,"In 3.4.0-rc1 that [~zhangduo] created, I noticed that builds of the project failed on hbase-shaded-jetty when I did not include {{clean}} in my build command. {noformat} [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 3.604 s [INFO] Finished at: 2020-08-11T14:38:45-04:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade (default) on project hbase-shaded-jetty: Error creating shaded jar: duplicate entry: META-INF/services/org.apache.hbase.thirdparty.org.eclipse.jetty.http.HttpFieldPreEncoder -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException {noformat} Poking around, it appears that this is actually to do with the creating of the shaded source jar." Use class access static field or method,13320642,Resolved,Minor,Fixed,03/Aug/20 10:52,23/Aug/20 12:34,,"we should use class to access static field or method ,not instance" clean out-of-date mob files even if the mob is disabled,13324068,Open,Minor,,22/Aug/20 10:41,,,"We may modify the table schema and disable the mob after writing data, then the invalid data will stay there util we find it." Configure a max global timeout for HMaster to wait for RS to check in,13323633,Open,Minor,,19/Aug/20 23:02,,,"As part of the initialization process for active master, it waits for region servers to check in before completing the initialization. Currently it runs into a loop where it waits in the loop for ever when there are no region servers that are reported to it ([https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L1126)]   We should probably have a global max timeout after which the master should give up and abort itself letting other masters to take over as active master . This is especially useful in the cases where the incoming connections to the master are not accepted because of network issue" Remove unnecessary ClassNotFoundException and NoSuchMethodException stack traces from HBase startup logs,13323590,Open,Minor,,19/Aug/20 17:20,,,"During cluster startup there are a couple of places where HBase needs to use reflection to determine what version of Hadoop or protobuf it's using, and then instantiate the right class. If its first guess is wrong, it logs a ClassNotFoundException (for protobuf MessageLite) or NoSuchMethodException (for DFSClient.decryptEncryptedDataEncryptionKey). While this is done at DEBUG level, the exception types and the stack traces can lead to operators thinking something is wrong. Since neither the exception nor the stack trace is actually of interest, we should just log a brief, clear message at DEBUG level about which decision was made and eat the exception without logging it. " 'scandetail' log message is missing when responseTooSlow happens in the rpc that closes the scanner,13323473,Open,Minor,,19/Aug/20 04:23,,1.4.13,"'scandetail' log message is missing when responseTooSlow happens in the rpc that closes the scanner. RSRpcServices.closeScanner is called before logging the slowLog in RPCServer.logResponse. Since closeScanner removes the scanner entry from scanners map, logResponse can't find scanDetails when calling RSRpcServices.getScanDetailsWithId.   I have reproduced it by exhausting the region (no more results in the region), which sets moreResultsInRegion = false and cause to closeScanner in same rpc [https://github.com/apache/hbase/blob/c2e0cf989e4a86169219161d4d889db80288e636/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3235-L3237] At least, this seems the behavior in branch-1.   I think this bug was introduced at https://issues.apache.org/jira/browse/HBASE-17489. Note that this is a completely different case than https://issues.apache.org/jira/browse/HBASE-24282." Sort the constants in `hbase_constants.rb`,13321858,Resolved,Minor,Fixed,10/Aug/20 18:34,11/Aug/20 23:15,,"The list of constant definitions in {{hbase_constants.rb}} is a bit of a mess. Sort them. Breaks out the minor cleanup from HBASE-24627 / [PR#2215|https://github.com/apache/hbase/pull/2215] into it's own ticket." regioninfo#isLast() has a logic error,13315526,Resolved,Minor,Fixed,08/Jul/20 02:28,14/Jul/20 10:25,2.2.3,"[https://github.com/apache/hbase/blob/90f4ff7d7c6997f61dbe40748b5c157879352acb/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfo.java#L771] it should be  {code:java} default boolean isLast() { return Bytes.equals(getEndKey(), HConstants.EMPTY_END_ROW); } {code}" Normalizer should log a successful run at INFO level,13321597,Resolved,Minor,Fixed,07/Aug/20 22:57,10/Aug/20 17:21,3.0.0-alpha-1,"A successful or uneventful Normalizer run gives no indication that it ran at INFO level. I'm thinking a simple summary message like ""Normalizer ran successfully in T. Submitted X plans across Y tables.""" Add more stats in PE for read replica,13321170,Resolved,Minor,Fixed,05/Aug/20 21:03,10/Aug/20 16:59,2.3.1,"Add more stats for read replica PE test. Currently, there is read replica tests in PE, but it does not provide details for how many requests to replica regions, and how many replica results win. Also, want to add a latency histogram for replica reads." The archiveLogFile should be called before decreasing totalLogSize in AbstractFSWAL.cleanOldLogs,13321962,Open,Minor,,11/Aug/20 08:29,,,"As discussed in HBASE-24822, if archiveLogFile failed to rename, then the totalLogSize will not correct." TestReplicationSource.testWALEntryFilter failing in branch-2+,13321596,Resolved,Minor,Cannot Reproduce,07/Aug/20 22:46,11/Aug/20 15:18,,"{noformat} [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 46.497 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource [ERROR] org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testWALEntryFilter Time elapsed: 1.405 s <<< FAILURE! java.lang.AssertionError at org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testWALEntryFilter(TestReplicationSource.java:177) {noformat} Noticed this during HBASE-24779, but didn't fix it. Believe it comes from HBASE-24817. Looks to be that the edit we expect to not be filtered is actually getting filtered because it has no cells (thus, no change and doesn't need to be replicated). Should be a simple fix." Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread,13321261,Resolved,Minor,Won't Fix,06/Aug/20 08:14,11/Aug/20 12:15,, enable_table_replication adding unnecessary entries for super user to ACL table,13316832,Open,Minor,,15/Jul/20 05:25,,2.1.0,"While enabling the table replication for the user table as an hbase user using the ""enable_table_replication"" command, permission has been granted automatically for the hbase user and getting listed in hbase:acl. The same behaviour is applicable to other users too. Issue Replication Steps: ======================== hbase(main):001:0> whoami dhana (auth:SIMPLE) groups: dhana Took 0.0214 seconds hbase(main):002:0> list TABLE 0 row(s) Took 0.4268 seconds => [] hbase(main):003:0> create 'mytab','f1' Created table mytab Took 0.7834 seconds => Hbase::Table - mytab hbase(main):004:0> describe 'mytab' Table mytab is ENABLED mytab COLUMN FAMILIES DESCRIPTION \{NAME => 'f1', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', NEW_VERSION_BEHAVIOR => 'false', KE EP_DELETED_CELLS => 'FALSE', CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL => 'F OREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false', CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'} 1 row(s) Took 0.1319 seconds hbase(main):005:0> scan 'hbase:acl' ROW COLUMN+CELL hbase:acl column=l:dhana, timestamp=1593669605273, value=RWXCA mytab column=l:dhana, timestamp=1593673200269, value=RWXCA 2 row(s) Took 0.0969 seconds hbase(main):006:0> exit hbase(main):001:0> whoami hbase (auth:SIMPLE) groups: hbase Took 0.0271 seconds hbase(main):002:0> scan 'hbase:acl' ROW COLUMN+CELL hbase:acl column=l:dhana, timestamp=1593669605273, value=RWXCA mytab column=l:dhana, timestamp=1593673200269, value=RWXCA 2 row(s) Took 0.5223 seconds hbase(main):003:0> enable_table_replication 'mytab' The replication of table 'mytab' successfully enabled Took 16.0711 seconds hbase(main):004:0> scan 'hbase:acl' ROW COLUMN+CELL hbase:acl column=l:dhana, timestamp=1593669605273, value=RWXCA mytab column=l:dhana, timestamp=1593673200269, value=RWXCA mytab column=l:hbase, timestamp=1593673390976, value=RWXCA <======== 2 row(s) Took 0.0089 seconds  " Add some comments for processlist in hbase shell,13321268,Resolved,Minor,Fixed,06/Aug/20 09:07,07/Aug/20 02:30,,"It is not easy to understand the difference of the options for processlist, so maybe some comments is necessary.  " Port HBASE-22762 Print the delta between phases in the split/merge/compact/flush transaction journals to master branch,13321157,Resolved,Minor,Fixed,05/Aug/20 20:16,06/Aug/20 13:41,, Logging of ppid should be consistent across all occurrences,13314569,Resolved,Minor,Fixed,01/Jul/20 23:39,29/Jul/20 13:42,,Most places we log {{pid}} and {{ppid}} I noticed at least one occurrence of {{parent pid}} instead of {{ppid}}. All this logging should be uniform so that it's easy to grep the logs. RS startup with FSHLog throws NPE after HBASE-21751,13316123,Resolved,Minor,Fixed,10/Jul/20 10:53,03/Aug/20 04:40,2.1.6,"Every RS startup creates this NPE {code} [sync.1] wal.FSHLog: UNEXPECTED java.lang.NullPointerException at org.apache.hadoop.hbase.regionserver.wal.FSHLog$SyncRunner.run(FSHLog.java:582) at java.lang.Thread.run(Thread.java:748) 2020-07-07 10:51:23,208 WARN [regionserver/xxxxx:16020] wal.FSHLog: Failed sync-before-close but no outstanding appends; closing WALjava.lang.NullPointerException {code} the reason is that the Disruptor frameworks starts the Syncrunner thread but the init of the writer happens after that. A simple null check in the Syncrunner will help here . No major damage happens though since we handle Throwable Exception. It will good to solve this. " HBase Shell Commands Survey,13314751,Open,Minor,,02/Jul/20 17:34,,2.3.0,"I am going through all 163 commands in the hbase-shell module and checking a few things: * Functions as advertised * Consistent naming, formatting, and help * Return values ** The majority of the commands still return nil. We can make the shell more powerful by switching some of these commands to return Ruby objects. h3. Acceptance Criteria * The product of this ticket will be a *spreadsheet* with my comments on each command and potentially a design doc or other Jira tickets with the necessary changes found by the survey." Unify hbase-shell ::Shell::Commands::Command#help behavior,13320265,Resolved,Minor,Fixed,30/Jul/20 19:22,31/Jul/20 14:44,2.3.0,"This is a small patch to unify shell help: * Many of the commands use different indentation levels to style the help text. * A few commands printed help instead of returning it, which breaks our pattern. I also added a test to make sure the help text stays consistent after this patch." hbase.rowlock.wait.duration should not be <= 0,13320017,Resolved,Minor,Fixed,29/Jul/20 16:50,30/Jul/20 20:22,1.4.0,"had a cluster fail after upgrade from hbase 1 because all writes to meta failed. master started in maintenance mode looks like (RS hosting meta in non-maint would look similar starting with {{HRegion.doBatchMutate}}): {code} 2020-07-28 17:52:56,553 WARN org.apache.hadoop.hbase.regionserver.HRegion: Failed getting lock, row=some_user_table java.io.IOException: Timed out waiting for lock for row: some_user_table in region 1588230740 at org.apache.hadoop.hbase.regionserver.HRegion.getRowLockInternal(HRegion.java:5863) at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lockRowsAndBuildMiniBatch(HRegion.java:3322) at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4018) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3992) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3923) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3914) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3928) at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4255) at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3047) at org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2827) at org.apache.hadoop.hbase.client.ClientServiceCallable.doMutate(ClientServiceCallable.java:55) at org.apache.hadoop.hbase.client.HTable$3.rpcCall(HTable.java:538) at org.apache.hadoop.hbase.client.HTable$3.rpcCall(HTable.java:533) at org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107) at org.apache.hadoop.hbase.client.HTable.put(HTable.java:542) at org.apache.hadoop.hbase.MetaTableAccessor.put(MetaTableAccessor.java:1339) at org.apache.hadoop.hbase.MetaTableAccessor.putToMetaTable(MetaTableAccessor.java:1329) at org.apache.hadoop.hbase.MetaTableAccessor.updateTableState(MetaTableAccessor.java:1672) at org.apache.hadoop.hbase.MetaTableAccessor.updateTableState(MetaTableAccessor.java:1112) at org.apache.hadoop.hbase.master.TableStateManager.fixTableStates(TableStateManager.java:296) at org.apache.hadoop.hbase.master.TableStateManager.start(TableStateManager.java:269) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1004) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2274) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:583) at java.lang.Thread.run(Thread.java:745) {code} logging roughly 6k times /second. failure was caused by a change in behavior for {{hbase.rowlock.wait.duration}} in HBASE-17210 (so 1.4.0+, 2.0.0+). Prior to that change setting the config <= 0 meant that row locks would succeed only if they were immediately available. After the change we fail the lock attempt without checking the lock at all. workaround: set {{hbase.rowlock.wait.duration}} to a small positive number, e.g. 1, if you want row locks to fail quickly." Move log code out of loop,13320124,Resolved,Minor,Fixed,30/Jul/20 07:01,30/Jul/20 09:51,3.0.0-alpha-1,"In HMaster#normalizeRegions, maybe we shoule move the log code about  submittedPlanProcIds out of loop.   {code:java} public boolean normalizeRegions() throws IOException { ... final List submittedPlanProcIds = new ArrayList<>(); for (TableName table : allEnabledTables) { ... for (NormalizationPlan plan : plans) { long procId = plan.submit(this); submittedPlanProcIds.add(procId); ... } int totalPlansSubmitted = submittedPlanProcIds.size(); if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) { LOG.debug(""Normalizer plans submitted. Total plans count: {} , procID list: {}"", totalPlansSubmitted, submittedPlanProcIds); } } ... } {code}    " Remove unused counter from SplitLogCounters,13319876,Resolved,Minor,Fixed,29/Jul/20 03:14,29/Jul/20 11:53,,remove unused counter from SplitLogCounters Address hbase-shell commands with unintentional return values,13316465,Resolved,Minor,Fixed,13/Jul/20 13:49,29/Jul/20 14:52,2.3.0,"There are a number of commands in hbase-shell that return values that are undocumented or otherwise do not makes sense. The commands that will be addressed by this ticket were found in a survey of all the hbase shell commands, https://issues.apache.org/jira/browse/HBASE-24672. Subtasks: * Fix commands that return the number of printed lines (usually the number 1). ** Affected commands (culprits): is_disabled, balancer, normalize, normalizer_switch, normalizer_enabled, catalogjanitor_switch, catalogjanitor_enabled, cleaner_chore_switch, cleaner_chore_enabled, splitormerge_switch, splitormerge_enabled, clear_deadservers, clear_block_cache ** I am updating these 13 commands to either return a value that makes sense or return nil if a sensible return value doesn't exist. * Fix commands that return true or false as a String ** Affected commands (culprits): balance_switch, snapshot_cleanup_switch, enable_rpc_throttle, disable_rpc_throttle, enable_exceed_throttle_quota, disable_exceed_throttle_quota ** I am updating these 6 commands to return ruby's TrueClass or FalseClass rather than a String" release scripts should check for tools it will at the start of building,13319315,Open,Minor,,25/Jul/20 21:16,,,"I just had a RC build fail *after* going through all the work to build everything because a recent OS upgrade meant that my {{svn}} command had been replaced by a placeholder that provided an error message about how X-Code is no longer providing subversion binaries. getting a new copy of svn installed was easy enough, but if we're going to use subversion we should have an init check similar to what we have for yetus / maven / etc." Investigate Potential to Use Ruby's Help Functionality in Shell,13319197,Open,Minor,,24/Jul/20 16:51,,2.3.0,"Ruby and Interactive Ruby (irb) have functionality for helping users (via introspection). It would be interesting to see if we can hook into this for hbase-shell. * Ruby has a built in method called ""ri"" which lets users explore help text for modules, classes, and methods from RDocs. ** [https://ruby.github.io/rdoc/RI_rdoc.html] * Interactive ruby has a method called ""irb_help"" which gets patched onto the main Object as ""help"" (except in our shell, where we have our own help method). Under the hood, it uses {{Ri}}. ** [https://docs.ruby-lang.org/en/2.3.0/IRB/ExtendCommandBundle.html] ** [https://github.com/ruby/irb/blob/66c4eab4e71b47f3c78ed68727c0bd1c3897591d/lib/irb/cmd/help.rb] At the moment, {{irb_help}}/{{ri}} knows nothing about the HBase shell commands {code:java} hbase> irb_help Enter the method name you want to look up. You can use tab to autocomplete. Enter a blank line to exit. >> list Nothing known about .list {code}" Add hbase.master.balancer.stochastic.moveCost.offpeak to doc as support dynamically change,13318169,Resolved,Minor,Fixed,20/Jul/20 06:13,20/Jul/20 10:02,,"A follow-on task of HBASE-24709, since it is always fail on jdk11 with this doc change. " Meta replicas not cleaned when disabled,13316453,Resolved,Minor,Fixed,13/Jul/20 12:35,14/Jul/20 17:17,2.2.5,"The assignMetaReplicas method works kinda like this: {code:java} void assignMetaReplicas(){ if (numReplicas <= 1) return; //create if needed then assign meta replicas unassignExcessMetaReplica(numReplicas); } {code} Now this unassignExcessMetaReplica method is the one that gets rid of the replicas we no longer need. It closes them and deletes their zNode.  Unfortunately this only happens if we decreased the replica number. If we disabled it, by setting the replica number to 1 assignMetaReplicas returns instantly without cleaning up the no longer needed replicas resulting in replicas lingering around." Source checksum is missing from web ui,13315716,Resolved,Minor,Duplicate,08/Jul/20 20:03,10/Jul/20 16:41,2.3.0,"The web ui has a ""Software Attribute"" section with a table entry called ""HBase Source Checksum"", supposed to be a sha512 checksum according to the description. Instead, the value is just ""(stdin)=""." MultiAction and FailureInfo should be removed,13315135,Resolved,Minor,Fixed,06/Jul/20 10:18,06/Jul/20 11:51,,Just came across MultiAction and FailureInfo which are IA.Private and not being used anywhere on trunk. Both of them are being used on branch-2 though. We should remove them on trunk. [HBOSS] Some code cleanup,13326283,Resolved,Trivial,Fixed,07/Sep/20 09:54,10/Sep/20 09:13,hbase-filesystem-1.0.0-alpha1,This is a cleanup of unused methods/imported classes around several classes of HBOSS project. "Fix typo ""memeber""",13328054,Resolved,Trivial,Fixed,17/Sep/20 12:54,19/Sep/20 06:46,,"Fix typo Memeber -> Member in several comments" Fix empty value of properties 'hbase.replication.source.maxthreads' in hbase-thrift module,13326289,Resolved,Trivial,Fixed,07/Sep/20 10:44,10/Sep/20 04:41,," The value of hbase.replication.source.maxthreads is empty in hbase-thrift test see hbase-thrift/src/test/resources/hbase-site.xml {code:java} hbase.replication.source.maxthreads Default is 10 {code} " log after Generator success when running ITBLL,13326315,Resolved,Trivial,Fixed,07/Sep/20 14:05,08/Sep/20 04:19,,"When I was running ITBLL, there is no output after the Generator finished. We should log this just as the verify stage." [hbase-thirdparty] Bump copyright year in NOTICE,13322107,Resolved,Trivial,Fixed,11/Aug/20 19:28,11/Aug/20 19:30,,"year in NOTICE is 2018, should be 2020" Why Hregion's lock method is not public？,13321991,Resolved,Trivial,Invalid,11/Aug/20 11:30,11/Aug/20 11:40,,"  {code:java} private void lock(final Lock lock) throws RegionTooBusyException, InterruptedIOException { lock(lock, 1); } {code}  " skip empty log cleaner delegate class names (WAS => cleaner.CleanerChore: Can NOT create CleanerDelegate= ClassNotFoundException),13320474,Resolved,Trivial,Fixed,31/Jul/20 22:10,03/Aug/20 20:17,,"2020-07-31 00:19:49,839 WARN [master/ps0753:16000:becomeActiveMaster] cleaner.CleanerChore: Can NOT create CleanerDelegate= java.lang.ClassNotFoundException: at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:264) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.newFileCleaner(CleanerChore.java:173) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.initCleanerChain(CleanerChore.java:155) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.(CleanerChore.java:105) at org.apache.hadoop.hbase.master.cleaner.HFileCleaner.(HFileCleaner.java:139) at org.apache.hadoop.hbase.master.cleaner.HFileCleaner.(HFileCleaner.java:120) at org.apache.hadoop.hbase.master.HMaster.startServiceThreads(HMaster.java:1424) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1025) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2189) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:609) at java.lang.Thread.run(Thread.java:748)   This is the config:   hbase.master.hfilecleaner.plugins    " The current checkcompatibility.py script can not compare master and rel/2.0.0,13387489,Resolved,Blocker,Fixed,03/Jul/21 10:33,03/Jul/21 13:46,,"There are basically two problems. One is the findbugs-maven-plugin, on rel/2.0.0, its version is 3.0.0, and it will lead the below error {noformat} [ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:3.0.0:findbugs (default) on project hbase: Unable to parse configuration of mojo org.codehaus.mojo:findbugs-maven-plugin:3.0.0:findbugs for parameter pluginArtifacts: Cannot assign configuration entry 'pluginArtifacts' with value '${plugin.artifacts}' of type java.util.Collections.UnmodifiableRandomAccessList to property of type java.util.ArrayList -> [Help 1] {noformat} The other is because of opentelemetry. It packs some jar in the fat agent jar, and the name of the directory for holding the extracted jar content still ends .jar, which makes the current script think it is a jar and cause problems. {noformat} java.io.FileNotFoundException: /home/zhangduo/hbase/code/target/compat-check/dst/hbase-assembly/target/dependency/opentelemetry-javaagent-1.0.1-all-jar/META-INF/licenses/okhttp-3.14.9.jar (是一个目录) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at java.io.FileInputStream.(FileInputStream.java:93) at sun.tools.jar.Main.run(Main.java:307) at sun.tools.jar.Main.main(Main.java:1288) ERROR: can't extract '/home/zhangduo/hbase/code/target/compat-check/dst/hbase-assembly/target/dependency/opentelemetry-javaagent-1.0.1-all-jar/META-INF/licenses/okhttp-3.14.9.jar' INFO:root:Results: {} Traceback (most recent call last): File ""./checkcompatibility.py"", line 539, in main() File ""./checkcompatibility.py"", line 535, in main args.compare_warnings)) File ""./checkcompatibility.py"", line 233, in compare_results if compare_tool_results_count(tool_results, check, issue_type, known_count)] File ""./checkcompatibility.py"", line 252, in compare_tool_results_count return tool_results[check][issue_type] > known_count KeyError: 'binary' {noformat} " edit file loss result in data loss when restart hbase cluster,13396086,Open,Blocker,,19/Aug/21 10:12,,,"{{      when i  restart  hbase cluster,i find  edit file loss when wal  repaly .}}         the number of edit files (00000000seqid.tmp to   00000000seqid )  is 31 when split wal to  edit.  But when i read edits to repaly ,i foud the  sum is 30.         i see rename file is sucessful,but i can not find the edit file . {panel:title=/var/log/message     i find  system exception}   ACPI Error: SMBus/IPMI/GenericSerialBus write requires Buffer of length 66, found length 32 (20130517/exfield-389) Aug 16 03:30:41 esgsh6 kernel: ACPI Error: Method parse/execution failed [\_SB_.PMI0._PMM] (Node ffff8810e9eab258), AE_AML_BUFFER_LIMIT (20130517/psparse-536) {panel} #  *rename (00000000seqid.tmp to   00000000seqid is 31*                   i can not find the follwing file , i confirm the edit file (0*000000000001825010*)is not empty.   {panel:title=log} hbase-cmf-hbase-REGIONSERVER-gy11.esgync.local.log.out:2021-08-16 17:56:28,956 INFO org.apache.hadoop.hbase.wal.WALSplitter: Rename hdfs://nameservice1/hbase/data/default/TRAFODION.JAVABENCH2.OE_STOCK_INDEX_300/8a42de414d97b457da88bc4682dd7c52/recovered.edits/0000000000001810650.temp to hdfs://nameservice1/hbase/data/default/TRAFODION.JAVABENCH2.OE_STOCK_INDEX_300/8a42de414d97b457da88bc4682dd7c52/recovered.edits/0*000000000001825010* {panel} **         you can see attachment{color:#999999} {color} *{color:#3366ff}r{color}*{color:#3366ff}*ename_edit.log*{color}     *2.  at replay phase , Reading the edits is 30*    {panel:title=log}       hbase-cmf-hbase-REGIONSERVER-gy11.esgync.local.log.out:2021-08-16 17:56:14,938      INFO org.apache.hadoop.hbase.regionserver.HRegion: after replayRecoveredEdits Maximum sequenceid  1914955 and minimum sequenceid for the region is 1916711, replay the file, path=hdfs://nameservice1/hbase/data/default/TRAFODION.JAVABENCH2.OE_STOCK_INDEX_300/8a42de414d97b457da88bc4682dd7c52/recovered.edits/0000000000001914955,seqid=1916711,*size=30* {panel} **     {code:java} org.apache.hadoop.hbase.regionserver.HRegion NavigableSet files = WALSplitter.getSplitEditFilesSorted(fs, regiondir); if (LOG.isDebugEnabled()) { LOG.debug(""Found "" + (files == null ? 0 : files.size()) + "" recovered edits file(s) under "" + regiondir); } if (files == null || files.isEmpty()) return seqid; long start=System.currentTimeMillis(); for (Path edits: files) { if (edits == null || !fs.exists(edits)) { LOG.warn(""Null or non-existent edits file: "" + edits); continue; } if (isZeroLengthThenDelete(fs, edits)) continue; long maxSeqId; String fileName = edits.getName(); maxSeqId = Math.abs(Long.parseLong(fileName)); if (maxSeqId <= minSeqIdForTheRegion) { if (LOG.isDebugEnabled()) { String msg = ""Maximum sequenceid for this wal is "" + maxSeqId + "" and minimum sequenceid for the region is "" + minSeqIdForTheRegion + "", skipped the whole file, path="" + edits; LOG.info(msg); } continue; } try { seqid = Math.max(seqid, replayRecoveredEdits(edits, maxSeqIdInStores, reporter)); // replay the edits. Replay can return -1 if everything is skipped, only update // if seqId is greater String msg = ""after replayRecoveredEdits Maximum sequenceid "" + maxSeqId + "" and minimum sequenceid for the region is "" + minSeqIdForTheRegion + "", replay the file, path="" + edits +"",seqid=""+seqid+"",size=""+files.size(); LOG.info(msg);{code}  " [create-release] The indent of checkcompatibility.py is broken after HBASE-25473,13387352,Resolved,Blocker,Fixed,02/Jul/21 14:43,03/Jul/21 02:57,,"{noformat} zhangduo@zhangduo-ubuntu:~/hbase/code/dev-support$ ./checkcompatibility.py File ""./checkcompatibility.py"", line 251 return tool_results[check][issue_type] > known_count ^ IndentationError: unindent does not match any outer indentation level {noformat}" JVM core dump in the replication path,13389891,Resolved,Critical,Duplicate,15/Jul/21 18:00,15/Jul/24 22:54,2.3.5,"When replication is turned on, we found the following code dump in the region server.  I checked the code dump for replication. I think I got some ideas. For replication, when RS receives walEdits from remote cluster, it needs to send them out to final RS. In this case, NettyRpcConnection is deployed, calls are queued while it refers to ByteBuffer in the context of replicationHandler (returned to the pool once it returns). Code dump will happen since the byteBuffer has been reused. Needs ref count in this asynchronous processing.   Feel free to take it, otherwise, I will try to work on a patch later.     {code:java} Stack: [0x00007fb1bf039000,0x00007fb1bf13a000],  sp=0x00007fb1bf138560,  free space=1021k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) J 28175 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.write(Ljava/io/OutputStream;Z)I (21 bytes) @ 0x00007fdbbbb2663c [0x00007fdbbbb263c0+0x27c] J 14912 C2 org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.writeRequest(Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelHandlerContext;Lorg/apache/hadoop/hbase/ipc/Call;Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (370 bytes) @ 0x00007fdbbb94b590 [0x00007fdbbb949c00+0x1990] J 14911 C2 org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.write(Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelHandlerContext;Ljava/lang/Object;Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (30 bytes) @ 0x00007fdbb972d1d4 [0x00007fdbb972d1a0+0x34] J 30476 C2 org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.write(Ljava/lang/Object;ZLorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (149 bytes) @ 0x00007fdbbd4e7084 [0x00007fdbbd4e6900+0x784] J 14914 C2 org.apache.hadoop.hbase.ipc.NettyRpcConnection$6$1.run()V (22 bytes) @ 0x00007fdbbb9344ec [0x00007fdbbb934280+0x26c] J 23528 C2 org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(J)Z (106 bytes) @ 0x00007fdbbcbb0efc [0x00007fdbbcbb0c40+0x2bc] J 15987% C2 org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run()V (461 bytes) @ 0x00007fdbbbaf1580 [0x00007fdbbbaf1360+0x220] j  org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run()V+44 j  org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run()V+11 j  org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run()V+4 {code}  " Sum of multiplier of cost functions is not populated properly when we have a shortcut for trigger,13404148,Resolved,Critical,Fixed,29/Sep/21 21:41,11/Nov/21 02:01,,"We have a couple of scenarios that we force balancing: * idle servers * co-hosted regions The code path quit before populating the sum of multiplier of cost functions. This causes wrong value reported in logging. As below, the weighted average is not divide by total weight. This causes inconsistent log among iterations. {quote}2021-09-24 21:46:57,881 INFO org.apache.hadoop.hbase.master.balancer.S*tocha*sticLoadBalancer: Running balancer because at least one server hosts replicas of the same region. 2021-09-24 21:46:57,881 INFO org.apache.hadoop.hbase.master.balancer.S*tocha*sticLoadBalancer: Start S*tocha*sticLoadBalancer.balancer, initial weighted average imbalance=6389.260497305375, functionCost=RegionCountSkewCostFunction : (multiplier=500.0, imbalance=0.06659036267913739); PrimaryRegionCountSkewCostFunction : (multiplier=500.0, imbalance=0.05296760285663541); MoveCostFunction : (multiplier=7.0, imbalance=0.0, balanced); ServerLocalityCostFunction : (multiplier=25.0, imbalance=0.46286750487559114); RackLocalityCostFunction : (multiplier=15.0, imbalance=0.2569525347374165); TableSkewCostFunction : (multiplier=500.0, imbalance=0.3760689783169534); RegionReplicaHostCostFunction : (multiplier=100000.0, imbalance=0.0553889913899139); RegionReplicaRackCostFunction : (multiplier=10000.0, imbalance=0.05854089790897909); ReadRequestCostFunction : (multiplier=5.0, imbalance=0.06969346106898068); WriteRequestCostFunction : (multiplier=5.0, imbalance=0.07834116112410174); MemStoreSizeCostFunction : (multiplier=5.0, imbalance=0.12533769793201735); StoreFileCostFunction : (multiplier=5.0, imbalance=0.06921401085082914);  computedMaxSteps=5577401600 {quote}" DBB got from BucketCache would be freed unexpectedly before RPC completed,13400771,Resolved,Critical,Fixed,13/Sep/21 12:08,17/Sep/21 14:53,2.4.6,"{{DBB}} got from BucketCache would be freed unexpectedly before RPC completed for following two cases: * Case 1: Replacing Block and getting Block execute concurrently. Because of splitting or stream read，two or more read threads may try to cache the same {{Block}} concurrently and one thread read all of the next block header could replace the another one didn't(see HBASE-20447). When replacing {{Block}}，the following {{BucketCache.WriterThread.putIntoBackingMap}} method invokes {{BucketCache.blockEvicted}} in line 916,which free the {{BucketEntry}} directly in line 544, not through the {{RefCount}}. {code:java} 912 private void putIntoBackingMap(BlockCacheKey key, BucketEntry bucketEntry) { 913 BucketEntry previousEntry = backingMap.put(key, bucketEntry); 914 if (previousEntry != null && previousEntry != bucketEntry) { 915 previousEntry.withWriteLock(offsetLock, () -> { 916 blockEvicted(key, previousEntry, false); 917 return null; 918 }); 919 } 920 } 543 void blockEvicted(BlockCacheKey cacheKey, BucketEntry bucketEntry, boolean decrementBlockNumber) { 544 bucketAllocator.freeBlock(bucketEntry.offset()); 545 realCacheSize.add(-1 * bucketEntry.getLength()); 546 blocksByHFile.remove(cacheKey); 547 if (decrementBlockNumber) { 548 this.blockNumber.decrement(); 549 } 550 } {code} Freeing the {{BucketEntry}} directly may cause {{HFileBlock}} returned from {{BucketCache.getBlock}} be freed unexpectedly before RPC completed.HBASE-26155 fixed this problem to some extent, but seems not completely. The {{BucketCache.getBlock}} might be invoked just before {{BucketCache.cacheBlockWithWaitInternal}} and after the {{BucketEntry.isRpcRef}} checking is done. Considering the following sequence: 1. Block1 was cached successfully,the {{RefCnt}} of Block1 is 1. 2. Thread1 caching the same {{BlockCacheKey}} with Block2 satisfied {{BlockCacheUtil.shouldReplaceExistingCacheBlock}}, so Block2 would replace Block1, but thread1 stopping before {{BucketCache.cacheBlockWithWaitInternal}} 3. Thread2 invoking {{BucketCache.getBlock}} with the same {{BlockCacheKey}}, which returned Block1, the {{RefCnt}} of Block1 is 2. 4. Thread1 continues caching Block2, in {{BucketCache.WriterThread.putIntoBackingMap}} , the old Block1 is freed directly which {{RefCnt}} is 2, but the Block1 is still used by Thread2 and the content of Block1 would be overwitten after it is freed, which may cause a serious error. * Case 2: Evicting Block , caching Block and getting Block execute concurrently. Considering the following sequence: 1. Thread1 caching Block1, stopping after {{WriterThread.putIntoBackingMap}}, the {{RefCnt}} of Block1 is 1. 2. Thread2 invoking {{BucketCache.evictBlock}} with the same {{BlockCacheKey}} , but stopping after {{BucketCache.removeFromRamCache}}. 3. Thread3 invoking {{BucketCache.getBlock}} with the same {{BlockCacheKey}}, which returned Block1, the {{RefCnt}} of Block1 is 2. 4. Thread1 continues caching block1,but finding that {{BucketCache.RAMCache.remove}} returning false, so invoking {{BucketCache.blockEvicted}} to free the the Block1 directly which {{RefCnt}} is 2 and the Block1 is still used by Thread3. Case 2 is caused by following line 1014 in {{WriteThread.doDrain}}, which also free the {{BucketEntry}} directly,just like the Case1. {code:java} 1004 boolean existed = ramCache.remove(key, re -> { 1005 if (re != null) { 1006 heapSize.add(-1 * re.getData().heapSize()); 1007 } 1008 }); 1009 if (!existed && bucketEntries[i] != null) { 1010 // Block should have already been evicted. Remove it and free space. 1011 final BucketEntry bucketEntry = bucketEntries[i]; 1012 bucketEntry.withWriteLock(offsetLock, () -> { 1013 if (backingMap.remove(key, bucketEntry)) { 1014 blockEvicted(key, bucketEntry, false); 1015 } 1016 return null; 1017 }); 1018 } 1019 } {code} My Fix in the PR is as following: # We never free the {{BucketEntry}} directly, freeing the {{BucketEntry}} must through {{RefCnt}}. # {{RefCnt#recycler}} just freeing the corresponding {{BucketEntry}} , not including removing the Block from {{BucketCache.backingMap}} or {{BucketCache.ramCache}}. Removing the Block from {{BucketCache.backingMap}} or {{BucketCache.ramCache}} is immediately done in {{BucketCache.evictBlock}}, and in fact this behavior is the same as {{BucketCache.evictBlock}} in branch-1, except that freeing {{BucketEntry}} is delayed until {{RefCnt}} becoming 0. In current branch-2 implementation, removing the Block from {{BucketCache.backingMap}} or {{BucketCache.ramCache}} is done in {{RefCnt#recycler}}, which is something unreasonable: we decreasing the {{RefCnt}} because we removing it from {{BucketCache.backingMap}}, not in reverse that because the {{RefCnt}} decreased to zero we removing it from {{BucketCache.backingMap}}, which may causes the newly added Block with the same {{BlockCacheKey}} be incorrectly evicted from {{BucketCache.backingMap}} or {{BucketCache.ramCache}}. " AbstractFSWALProvider#getArchivedLogPath doesn't look for wal file in all oldWALs directory.,13391149,Resolved,Critical,Fixed,21/Jul/21 14:48,02/Sep/21 19:16,2.4.4,"Below is the code for AbstractFSWALProvider#getArchivedLogPath {code:java} public static Path getArchivedLogPath(Path path, Configuration conf) throws IOException { Path rootDir = CommonFSUtils.getWALRootDir(conf); Path oldLogDir = new Path(rootDir, HConstants.HREGION_OLDLOGDIR_NAME); if (conf.getBoolean(SEPARATE_OLDLOGDIR, DEFAULT_SEPARATE_OLDLOGDIR)) { ServerName serverName = getServerNameFromWALDirectoryName(path); if (serverName == null) { LOG.error(""Couldn't locate log: "" + path); return path; } oldLogDir = new Path(oldLogDir, serverName.getServerName()); } Path archivedLogLocation = new Path(oldLogDir, path.getName()); final FileSystem fs = CommonFSUtils.getWALFileSystem(conf); if (fs.exists(archivedLogLocation)) { LOG.info(""Log "" + path + "" was moved to "" + archivedLogLocation); return archivedLogLocation; } else { LOG.error(""Couldn't locate log: "" + path); return path; } } {code} This method is called from the following places. [AbstractFSWALProvider#openReader|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java#L524] [ReplicationSource#getFileSize|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L399] [WALInputFormat.WALRecordReader#nextKeyValue|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALInputFormat.java#L220] All of the above calls are trying to find the log in archive path after they couldn't locate the wal in walsDir and they are not used for moving a log file to archive directory. But we will look for archive path within serverName directory only if conf key is true. Cc [~zhangduo] " HBase Write should be doomed to hang when cell size exceeds InmemoryFlushSize for CompactingMemStore,13396101,Resolved,Critical,Fixed,19/Aug/21 11:40,01/Sep/21 10:26,2.4.5,"Besides HBASE-26026, there is another case HBase Write would be hang when using {{CompactingMemstore}} : The problem is caused by {{CompactingMemStore.checkAndAddToActiveSize}} and {{CompactingMemStore.shouldFlushInMemory}} : {code:java} 425 private boolean checkAndAddToActiveSize(MutableSegment currActive, Cell cellToAdd, 426 MemStoreSizing memstoreSizing) { 427 if (shouldFlushInMemory(currActive, cellToAdd, memstoreSizing)) { 428 if (currActive.setInMemoryFlushed()) { 429 flushInMemory(currActive); 430 if (setInMemoryCompactionFlag()) { 431 // The thread is dispatched to do in-memory compaction in the background ...... } {code} {{CompactingMemStore.checkAndAddToActiveSize}} invokes following {{CompactingMemStore.shouldFlushInMemory}} firstly , when the size of the {{cellToAdd}} is larger than {{inmemoryFlushSize}}(the default value is 2MB), this {{CompactingMemStore.shouldFlushInMemory}} method always return true and current HBase Write Thread may repeatedly enter {{CompactingMemStore.shouldFlushInMemory}} again and again and never get a chance to add the {{cellToAdd}} .At the same time, because of the MVCC, all the HBase writes after this write would be hang. {code:java} protected boolean shouldFlushInMemory(MutableSegment currActive, Cell cellToAdd, MemStoreSizing memstoreSizing) { long cellSize = MutableSegment.getCellLength(cellToAdd); long segmentDataSize = currActive.getDataSize(); while (segmentDataSize + cellSize < inmemoryFlushSize || inWalReplay) { // when replaying edits from WAL there is no need in in-memory flush regardless the size // otherwise size below flush threshold try to update atomically if (currActive.compareAndSetDataSize(segmentDataSize, segmentDataSize + cellSize)) { if (memstoreSizing != null) { memstoreSizing.incMemStoreSize(cellSize, 0, 0, 0); } // enough space for cell - no need to flush return false; } segmentDataSize = currActive.getDataSize(); } // size above flush threshold return true; } {code} My PR not skip adding the size，it still add the size before really adding the cell to {{currActive}} , but it just change checking {{currActive}} size logic in {{CompactingMemStore.shouldFlushInMemory}} a little to make it similar to normal {{DefaultMemStore}} flushing to disk : it not make sure the size of {{currActive}} strictly less than {{inmemoryFlushSize}} any more, instead, it can tolerate the size of {{currActive}} just crossing the {{inmemoryFlushSize}} boundary at most one cell. Before adding the cell size, we make sure {{currActive}} size less than {{inmemoryFlushSize}} , and after adding cell size to the {{currActive}} size, we check whether its size exceeding {{inmemoryFlushSize}} , if it is , we flush the {{currActive}} in memory. Further more, I also flatten the {{CompactingMemStore.shouldFlushInMemory}} into {{CompactingMemStore.checkAndAddToActiveSize}} and extract the {{flush in memory}} logic into a separate method to make the workflow more readable. " SEEK_NEXT_USING_HINT is ignored on reversed Scans,13397869,Resolved,Critical,Fixed,27/Aug/21 17:22,29/Aug/21 15:09,2.4.5,"It turns out that the {{SEEK_NEXT_USING_HINT}} feature is broken for reversed scans. That's because the implementation hard-codes an assumption that the scan is forward. Here's the mistake: [https://github.com/keyserbrian1/hbase/blob/735bcf85e9b59a71981babe2f5da51978d61d8d3/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java#L740|https://github.com/keyserbrian1/hbase/blob/735bcf85e9b59a71981babe2f5da51978d61d8d3/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java#L740] The bug sneaks past the existing tests because the mistake isn't detectable by looking at the result of a naive reversed scan. Attached is a PR that includes a fix and tests designed to detect if filter hints are actually used." Splitted WAL files are deleted rather than archiving,13397191,Resolved,Critical,Fixed,25/Aug/21 13:51,26/Aug/21 18:44,2.2.7,"When procedure based WAL split is enabled, we are deleting splitted WAL files immediately rather than moving to archive path.  https://github.com/apache/hbase/blob/67e9c6422d6d5b39586ffe529f55b76d8b8939ff/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALRemoteProcedure.java#L99" NullPointerException when set 'hbase.hregion.memstore.mslab.indexchunksize.percent' to zero,13392059,Resolved,Critical,Fixed,27/Jul/21 08:09,05/Aug/21 13:33,2.4.0,"The default value of {{hbase.hregion.memstore.mslab.indexchunksize.percent}} introduced by HBASE-24892 is 0.1, but when we use {{DefaultMemStore}} by default , which has no {{IndexChunk}} and {{ChunkCreator.indexChunksPool}} is useless({{IndexChunk}} is only used by {{CompactingMemStore}}), so we set {{hbase.hregion.memstore.mslab.indexchunksize.percent}} to 0 to save memory space, But after running a while, the {{RegionServer}} throws {{NullPointerException}} and abort: {code:java} Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.regionserver.ChunkCreator$MemStoreChunkPool.access$900(ChunkCreator.java:310) at org.apache.hadoop.hbase.regionserver.ChunkCreator.putbackChunks(ChunkCreator.java:608) at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.recycleChunks(MemStoreLABImpl.java:297) at org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.close(MemStoreLABImpl.java:268) at org.apache.hadoop.hbase.regionserver.Segment.close(Segment.java:149) at org.apache.hadoop.hbase.regionserver.AbstractMemStore.clearSnapshot(AbstractMemStore.java:251) at org.apache.hadoop.hbase.regionserver.HStore.updateStorefiles(HStore.java:1244) at org.apache.hadoop.hbase.regionserver.HStore.access$700(HStore.java:137) at org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.commit(HStore.java:2461) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2963) {code} The problem is caused by line 608 in {{ChunkCreator.putbackChunks}} : {{Chunk.isIndexChunk}} incorrectly returns true for {{DataChunk}} and unexpectedly invokes {{indexChunksPool.putbackChunks}}， while {{indexChunksPool}} is null: {code:java} 594 synchronized void putbackChunks(Set chunks) { 595 // if there is no pool just try to clear the chunkIdMap in case there is something 596 if (dataChunksPool == null && indexChunksPool == null) { 597 this.removeChunks(chunks); 598 return; 599 } 600 601 // if there is a pool, go over all chunk IDs that came back, the chunks may be from pool or not 602 for (int chunkID : chunks) { 603 // translate chunk ID to chunk, if chunk initially wasn't in pool 604 // this translation will (most likely) return null 605 Chunk chunk = ChunkCreator.this.getChunk(chunkID); 606 if (chunk != null) { 607 if (chunk.isFromPool() && chunk.isIndexChunk()) { 608 indexChunksPool.putbackChunks(chunk); {code} For {{DataChunk}} , {{Chunk.isIndexChunk}} return true because {{Chunk.isIndexChunk}} determines the type of {{chunk}} based on {{Chunk.size}} {code:java} boolean isIndexChunk() { return size == ChunkCreator.getInstance().getChunkSize(ChunkCreator.ChunkType.INDEX_CHUNK); } {code} and {{ChunkCreator.getChunkSize}} incorrectly return {{DataChunk}} size when {{ChunkCreator.indexChunksPool}} is null: {code:java} int getChunkSize(ChunkType chunkType) { switch (chunkType) { case INDEX_CHUNK: if (indexChunksPool != null) { return indexChunksPool.getChunkSize(); } case DATA_CHUNK: if (dataChunksPool != null) { return dataChunksPool.getChunkSize(); } else { // When pools are empty return chunkSize; } default: throw new IllegalArgumentException( ""chunkType must either be INDEX_CHUNK or DATA_CHUNK""); } } {code} In my opinion, in addition to erroneous implementation of {{ChunkCreator.getChunkSize}}, we would better not determine the type of {{Chunk}} based on {{Chunk.size}}, because {{hbase.hregion.memstore.mslab.indexchunksize.percent}} is set by user and the size of {{IndexChunk}} and {{DataChunk}} could be the same.Tagged a {{ChunkType}} to {{Chunk}} is a better choice. " New replication gets stuck or data loss when multiwal groups more than 10,13391773,Resolved,Critical,Fixed,26/Jul/21 02:57,27/Jul/21 16:22,1.7.1,"{code:java} void preLogRoll(Path newLog) throws IOException { recordLog(newLog); String logName = newLog.getName(); String logPrefix = DefaultWALProvider.getWALPrefixFromWALName(logName); synchronized (latestPaths) { Iterator iterator = latestPaths.iterator(); while (iterator.hasNext()) { Path path = iterator.next(); if (path.getName().contains(logPrefix)) { iterator.remove(); break; } } this.latestPaths.add(newLog); } } {code} ReplicationSourceManager use _latestPaths_ to track each walgroup's last WALlog and all of them will be enqueue for replication when new replication  peer added。 If we set hbase.wal.regiongrouping.numgroups > 10, says 12, the name of WALlog group will be _regionserver.null0.timestamp_ to _regionserver.null11.timestamp_。*_String.contains_* is used in _preoLogRoll_ to replace old logs in same group, leads when _regionserver.null1.ts_ comes, _regionserver.null11.ts_ may be replaced, and *_latestPaths_ growing with wrong logs*. Replication then partly stuckd as _regionsserver.null1.ts_ not exists on hdfs, and data may not be replicated to slave as _regionserver.null11.ts_ not in replication queue at startup. Because of [ZOOKEEPER-706|https://issues.apache.org/jira/browse/ZOOKEEPER-706], if there is too many logs in zk _/hbase/replication/rs/regionserver/peer_, remove_peer may not delete this znode, and other regionserver can't not pick up this queue for replication failover. " conn.getBufferedMutator(tableName) leaks thread executors and other problems,13389698,Resolved,Critical,Fixed,14/Jul/21 20:21,21/Jul/21 12:08,2.0.0,"TL;DR: {{conn.getBufferedMutator(tableName)}} is dangerous in hbase client 2.4.4 and doesn't match documented behavior in 1.4.13. To work around the problems until fixed do this: {code:java} var mySingletonPool = HTable.getDefaultExecutor(hbaseConf); var params = new BufferedMutatorParams(tableName); params.pool(mySingletonPool); var myMutator = conn.getBufferedMutator(params); {code} And avoid code like this: {code:java} var myMutator = conn.getBufferedMutator(tableName); {code} The full story: My application started leaking threads after upgrading from hbase client 1.4.13 to 2.4.4. So much so that after less than a minute of runtime more that 30k threads are leaked and all available virtual memory on the box (> 50 GB) is consumed. Other processes on the box start crashing with memory allocation errors. Even running {{ls}} at the shell fails with OS resource allocation failures. A thread dump after just a few seconds of runtime shows thousands of threads like this: {code:java} ""htable-pool-0"" #8841 prio=5 os_prio=0 cpu=0.15ms elapsed=7.49s tid=0x00007efb6d2a1000 nid=0x57d2 waiting on condition [0x00007ef8a6c38000] java.lang.Thread.State: TIMED_WAITING (parking) at jdk.internal.misc.Unsafe.park(java.base@11.0.6/Native Method) - parking to wait for <0x00000007e7cd6188> (a java.util.concurrent.SynchronousQueue$TransferStack) at java.util.concurrent.locks.LockSupport.parkNanos(java.base@11.0.6/LockSupport.java:234) at java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill(java.base@11.0.6/SynchronousQueue.java:462) at java.util.concurrent.SynchronousQueue$TransferStack.transfer(java.base@11.0.6/SynchronousQueue.java:361) at java.util.concurrent.SynchronousQueue.poll(java.base@11.0.6/SynchronousQueue.java:937) at java.util.concurrent.ThreadPoolExecutor.getTask(java.base@11.0.6/ThreadPoolExecutor.java:1053) at java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.6/ThreadPoolExecutor.java:1114) at java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.6/ThreadPoolExecutor.java:628) at java.lang.Thread.run(java.base@11.0.6/Thread.java:834) {code}   Note: All the threads are labeled {{htable-pool-0}}. That suggests we're leaking thread executors not just threads. The {{htable-pool}} part indicates the problem is to do with {{HTable.getDefaultExecutor(conf)}} and the only part of my code that interacts with that is a call to {{conn.getBufferedMutator(tableName)}}.   Looking at the hbase client code shows a few problems: 1) Neither 1.4.13 nor 2.4.4's behavior matches the documentation for {{conn.getBufferedMutator(tableName)}} which says: {quote}This BufferedMutator will use the Connection's ExecutorService. {quote} That suggests some singleton thread executor is being used which is not the case.   2) Under 1.4.13 you get a new {{ThreadPoolExecutor}} for every {{BufferedMutator}}. That's probably not what you want but you likely won't notice. I didn't. It's a code path I hadn't profiled much.   3) Under 2.4.4 you get a new {{ThreadPoolExecutor}} for every {{BufferedMutator}} *and* that {{ThreadPoolExecutor}} *is not* cleaned up after the {{Mutator}} is closed. Each completed {{ThreadPoolExecutor}} carries with it one thread which hangs around until a timeout value which defaults to 60 seconds. My application creates one {{BufferedMutator}} for every incoming stream and there are lots of streams, some of them are short lived so my code leaks threads fast under 2.4.4. Here's the part where a new executor is created for every {{BufferedMutator}} (it's similar for 1.4.13): [https://github.com/apache/hbase/blob/branch-2.4/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L420]   The reason for the leak in 2.4.4 is the should-we/shouldn't-we cleanup logic added here: [https://github.com/apache/hbase/blob/branch-2.4/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java#L104] That might be ok if {{pool}} was being initialized there but in the {{conn.getBufferedMutator(tableName)}} code path it's not. {{pool}} is initialized in {{conn.getBufferedMutator}} itself so the executor cleanup code never runs." Replication is stuck due to zero length wal file in oldWALs directory.,13388435,Resolved,Critical,Fixed,08/Jul/21 16:59,16/Jul/21 05:13,1.7.0,"Recently we encountered a case where size of log queue was increasing to around 300 in few region servers in our production environment. There were 295 wals in the oldWALs directory for that region server and the *first file* was a 0 length file. Replication was throwing the following error. {noformat} 2021-07-05 03:06:32,757 ERROR [20%2C1625185107182,1] regionserver.ReplicationSourceWALReaderThread - Failed to read stream of replication entries org.apache.hadoop.hbase.replication.regionserver.WALEntryStream$WALEntryStreamRuntimeException: java.io.EOFException: hdfs:///hbase/oldWALs/ not a SequenceFile at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:112) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReaderThread.run(ReplicationSourceWALReaderThread.java:156) Caused by: java.io.EOFException: hdfs:///hbase/oldWALs/ not a SequenceFile at org.apache.hadoop.io.SequenceFile$Reader.init(SequenceFile.java:1934) at org.apache.hadoop.io.SequenceFile$Reader.initialize(SequenceFile.java:1893) at org.apache.hadoop.io.SequenceFile$Reader.(SequenceFile.java:1842) at org.apache.hadoop.io.SequenceFile$Reader.(SequenceFile.java:1856) at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader$WALReader.(SequenceFileLogReader.java:70) at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.reset(SequenceFileLogReader.java:168) at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.initReader(SequenceFileLogReader.java:177) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:66) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:313) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:277) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:265) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:424) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:352) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.handleFileNotFound(WALEntryStream.java:341) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:359) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:316) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:306) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:207) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:110) ... 1 more {noformat} We fixed similar error via HBASE-25536 but the zero length file was in recovered sources. There were more logs after the above stack trace. {noformat} 2021-07-05 03:06:32,757 WARN [20%2C1625185107182,1] regionserver.ReplicationSourceWALReaderThread - Couldn't get file length information about log hdfs:///hbase/WALs/ 2021-07-05 03:06:32,754 INFO [20%2C1625185107182,1] regionserver.WALEntryStream - Log hdfs:///hbase/WALs/ was moved to hdfs:///hbase/oldWALs/ {noformat} There is a special logic in ReplicationSourceWALReader thread to handle 0 length files but we only look in WALs directory and not in oldWALs directory. {code} private boolean handleEofException(Exception e, WALEntryBatch batch) { PriorityBlockingQueue queue = logQueue.getQueue(walGroupId); // Dump the log even if logQueue size is 1 if the source is from recovered Source // since we don't add current log to recovered source queue so it is safe to remove. if ((e instanceof EOFException || e.getCause() instanceof EOFException) && (source.isRecovered() || queue.size() > 1) && this.eofAutoRecovery) { Path head = queue.peek(); try { if (fs.getFileStatus(head).getLen() == 0) { // head of the queue is an empty log file LOG.warn(""Forcing removal of 0 length log in queue: {}"", head); logQueue.remove(walGroupId); currentPosition = 0; if (batch != null) { // After we removed the WAL from the queue, we should try shipping the existing batch of // entries addBatchToShippingQueue(batch); } return true; } } catch (IOException ioe) { LOG.warn(""Couldn't get file length information about log "" + queue.peek(), ioe); } catch (InterruptedException ie) { LOG.trace(""Interrupted while adding WAL batch to ship queue""); Thread.currentThread().interrupt(); } } return false; } {code}  We need to add logic to look for such 0 length file in oldWALs directory also. How this 0 length files are created ? When the 0 length wal was created, I see the following log messages. There were some datanode problems while creating the wal but assuming optimization, we just chugged along and again rolled the wal once FSHLog#append call failed. {noformat} 2021-07-02 00:18:35,069 WARN [Thread-17] hdfs.DataStreamer - Could not get block locations. Source file ""/hbase/WALs/"" - Aborting... 2021-07-02 00:18:35,072 WARN [10.180.160.244:60020] hdfs.DFSClient - Error while syncing java.io.IOException: Could not get block locations. Source file ""/hbase/WALs/"" - Aborting... at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466) at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670) 2021-07-02 00:18:35,074 WARN [10.180.160.244:60020] wal.FSHLog - pre-sync failed but an optimization so keep going java.io.IOException: Could not get block locations. Source file ""/hbase/WALs/"" - Aborting... at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466) at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670) .... .... 2021-07-02 00:18:57,303 WARN [0020.append-pool8-t1] wal.FSHLog - Append sequenceId=311389, requesting roll of WAL java.io.IOException: Could not get block locations. Source file ""/hbase/WALs/"" - Aborting... at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466) at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670) 2021-07-02 00:18:57,473 WARN [.244:60020.logRoller] wal.ProtobufLogWriter - Failed to write trailer, non-fatal, continuing... java.io.IOException: Could not get block locations. Source file ""/hbase/WALs/"" - Aborting... at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1466) at org.apache.hadoop.hdfs.DataStreamer.processDatanodeError(DataStreamer.java:1251) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:670) {noformat}" Resolve dependency conflicts of hbase-endpoint third-party libraries,13390681,Open,Major,,19/Jul/21 11:29,,2.0.0,"Hi, Our project uses “hbase-endpoint”, but the protobuf version is 2.5 version, which conflicts with 3.0 in our project. I want to merge into a ""hbase-shaded-endpoint"" submission to resolve ""hbase-endpoint"" dependency issue of version 2.0" Allow split when store file count larger than the configured blocking file count,13398382,Resolved,Major,Fixed,31/Aug/21 07:12,30/Dec/24 14:17,1.7.1,"Currently, region will not split when the number of store files is up to the configed blocking count, by `hbase.hstore.blockingStoreFiles`. The relevant codes are as follows,  the CompactSplit#requestSplit() (called by the MemstoreFlusher and CompactionRunner) checks the compaction priority of the region, if the compact priority < PRIORITY_USER, the region will not split. {code:java} public synchronized boolean requestSplit(final Region r) {   // don't split regions that are blocking   HRegion hr = (HRegion)r;   try {     if (shouldSplitRegion() && hr.getCompactPriority() >= PRIORITY_USER) {       byte[] midKey = hr.checkSplit().orElse(null);       if (midKey != null) {         requestSplit(r, midKey);         return true;       }     } .... {code} But the region's compact priority is the minimum of all the stores, when the number of storefiles in a store is larger than the configed `hbase.hstore.blockingStoreFiles`, the compact priority will be a negative number, while PRIORITY_USER = 1. {code:java} public int getStoreCompactionPriority() {   int priority = blockingFileCount - storefiles.size();   return (priority == HStore.PRIORITY_USER) ? priority + 1 : priority; } {code} As a result, when a region size is up to the split limit, but its speed of reducing the number of files through compaction is slower than the speed of generating new files(e.g. compacting L0 files to stripes, bulk load, flush memstore), the region will never split.  The problem is obvious in StripeStoreEngine, though memstore flushing is pending when store file count up to the blocking count, each L0 compaction may generate the stripe count new files to each stripe. And in this scenario, since the store always compact priority to split, the stripe count is larger and larger, the new files generated by compact is more and more, no split in the end. While split can divide the compaction pressure(1 parent compaction + 2 children compaction can be reduced to 2 children compaction). We can add a configuration to enable split when blocking, not only keep the origin behavior but also support flexible control.   " Release 2.3.6,13393124,Resolved,Major,Fixed,02/Aug/21 16:54,02/Aug/21 17:32,,"2.3.6RC3 was voted as 2.3.6 release. Run the release steps listed here for 2.3.6 !image-2021-08-02-09-54-56-469.png!" Add download links for 1.7.1,13391220,Resolved,Major,Fixed,21/Jul/21 23:42,22/Jul/21 16:42,1.7.1, Document HBASE-26070 and upgrade considerations for 1.7.0/1.7.1,13387973,Resolved,Major,Fixed,06/Jul/21 16:18,30/Dec/24 14:15,1.7.0,Document the incompatible serialization problem and upgrade paths for users that are on 1.7.0 and prior releases. Cleanup the broken store files under data directory,13400270,Resolved,Major,Fixed,09/Sep/21 15:37,09/Nov/21 16:19,,"As for some new store file tracker implementation, we allow flush/compaction to write directly to data directory, so if we crash in the middle, there will be broken store files left in the data directory. We should find a proper way to delete these broken files." Remove the deprecated methods in Scan which should be removed in 3.0.0,13389795,Closed,Major,Fixed,15/Jul/21 09:10,16/Jul/21 14:28,, Release 3.0.0,13390946,Open,Major,,20/Jul/21 15:06,,, Dispatch replication sources to ReplicationServer,13388566,Open,Major,,09/Jul/21 08:19,,3.0.0-alpha-1, Introduce a StoreFileTracker to abstract the store file tracking logic,13387614,Resolved,Major,Fixed,05/Jul/21 02:32,06/Aug/21 15:08,,"As mentioned in the parent issue, we could abstract a storefile metadata system, then we could use different backend to store the storefile list, and also it is possible to generalize the migration between different tracking system." Use StoreFileTracker when splitting and merging,13388596,Resolved,Major,Fixed,09/Jul/21 10:35,24/Dec/21 02:10,, Introduce a MigrationStoreFileTracker to support migrating from different store file tracker implementations,13397225,Resolved,Major,Fixed,25/Aug/21 15:58,11/Sep/21 14:48,,"As mentioned in this section in the design doc: https://docs.google.com/document/d/16Nr1Fn3VaXuz1g1FTiME-bnGR3qVK5B-raXshOkDLcY/edit#heading=h.vv41957yf4i" Persist the StoreFileTracker configurations to TableDescriptor when creating table,13398643,Resolved,Major,Fixed,01/Sep/21 10:36,12/Sep/21 13:15,,"As discussed in this section in the design doc: https://docs.google.com/document/d/16Nr1Fn3VaXuz1g1FTiME-bnGR3qVK5B-raXshOkDLcY/edit#heading=h.78r2mdeyquug If we use different SFT implementation at master side and region server side, it is likely to cause data loss, which is a very serious misconfiguration problem. A possible solution is to make sure that master and region server always load the configurations about StoreEngine from the same place. To archive this, a possible way is to always set the StoreEngine configurations to the TableDescriptor, even if user does not explicitly set it when creating a table. And also, when upgrading, we should check whether the existing tables have StoreEngine configurations, if not, we need to set them." Should find a suitable way to let users specify the store file tracker implementation,13398690,Resolved,Major,Fixed,01/Sep/21 13:55,14/Sep/21 08:29,,"Now all the implementations are marked as IA.Private, so there is no safe way for users to specify them. But for simplify, maybe we should not expose the full class name of the implementation classes to users. Just follow the way in WALFactory, to introduce an alias name for the implemention, for example DEFAULT, FILE, REGION, etc. Thoughts?" [Rolling Upgrading] Persist the StoreFileTracker configurations to TableDescriptor for existing tables,13399997,Resolved,Major,Fixed,08/Sep/21 13:27,06/Nov/21 14:20,, Add more checks to prevent misconfiguration on store file tracker,13400029,Resolved,Major,Fixed,08/Sep/21 15:31,15/Sep/21 15:00,,"For example, when creating new tables, if the store file tracker is configured to MigrationStoreFileTracker, we should fail the creation and tell users you should not use this store file tracker for a new table. And when switching the implementation for store file tracker, we should let end users first switch to MigrationStoreFileTracker, and then to the final target store file tracker. If end users configure wrong store file tracker, we should fail the alter table operation." Use store file tracker when snapshoting,13400648,Resolved,Major,Fixed,12/Sep/21 15:29,17/Sep/21 01:41,, Add support for specifying store file tracker when restoring or cloning snapshot,13401425,Resolved,Major,Fixed,15/Sep/21 16:04,16/Dec/21 01:41,,"As discussed in HBASE-26280. https://issues.apache.org/jira/browse/HBASE-26280?focusedCommentId=17414894&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17414894" The region replication framework should not be built upon the general replication framework,13397938,Resolved,Major,Fixed,28/Aug/21 06:59,31/Dec/21 14:59,,"At least, at the source path, where we track the edits, we should not make region replication rely on general replication framework. The difficulty here for switching to a table based storage is that, the WAL system and replication system highly depend on each other. There will be cyclic dependency if we want to store replication peer and queue data in a hbase table. And after HBASE-18070, even meta wal provider will be integrated together with replication system, which makes things more difficult. But in general, for region replication, it is not a big deal to lose some edits, a flush can fix everything, which means we do not so heavy tracking system in the general replication system. We should find a more light-weighted way to do region replication." Use P2P communicate between region servers to sync the list for bootstrap node,13396958,Resolved,Major,Fixed,24/Aug/21 15:09,29/Sep/21 13:33,,"For returning bootstrap nodes to client, we do not need to always track exactly the current live region server. But now, we just set a watcher on zookeeper to watch all the live region servers, on every region server, for large cluster, it will be a big pressure for zookeeper. So here I think, we could let region servers to communicate with each other to sync the available bootstrap node, like a P2P network. Will put a simple design doc soon." "Backport ""HBASE-26220 Use P2P communicate between region servers to sync the list for bootstrap node"" to branch-2",13404025,Resolved,Major,Fixed,29/Sep/21 08:34,10/Oct/21 15:06,, Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache,13400099,Resolved,Major,Fixed,08/Sep/21 22:02,17/Jan/24 14:33,,"Sorry for the vague title, not sure if it'd be better to create individual jiras. I discovered that the following two AdminService endpoints are not covered by AccessController:   * updateConfiguration * clearRegionBlockCache There may be others, I haven't done a full audit. We should add coprocessor hooks for these and wrap with AccessController, especially since they can both have an affect on the cluster." Update ref guide to mention the new store file tracker implementations,13400031,Resolved,Major,Fixed,08/Sep/21 15:36,16/Dec/21 21:08,,"For example, when to use these store file trackers." Deprecate MasterRegistry,13393672,Resolved,Major,Fixed,05/Aug/21 09:37,19/Aug/21 08:31,,"Maybe in some environment we still want to use master as registry endpoint, but this should be controlled at cluster side, not client side.   The implementation of MasterRegistry is almost the same with RpcConnectionRegistry except that it uses getMasters instead of getBootstrapNodes to refresh the ‘bootstrap’ nodes connected to. So we could add configs in server side to control what nodes we want to return to client in getBootstrapNodes, i.e, master or region server, then the RpcConnectionRegistry can fully replace the old MasterRegistry. As part of this change, we deprecate the MasterRegistry. ==== Update ==== We send out an email to mailing list, and there is no objections on not returning masters as registry endpoints, so here we decide to just deprecated MasterRegistry." [hbase-connectors] Pushdown filters in Spark do not work correctly with long types,13396390,Resolved,Major,Fixed,20/Aug/21 14:40,23/Aug/21 08:32,1.0.0,"Reading from an HBase table and filtering on a LONG column does not seem to work correctly. {{Dataset df = spark.read()   .format(""org.apache.hadoop.hbase.spark"")   .option(""hbase.columns.mapping"", ""id STRING :key, v LONG cf:v"")   ...   .load(); df.filter(""v > 100"").show();}} Expected behaviour is to show rows where cf:v > 100, but instead an empty dataset is shown. Moreover, replacing {{""v > 100""}} with {{""v >= 100""}} results in a dataset where some rows have values of v less than 100.  The problem appears to be that long values are decoded incorrectly as integers in {{NaiveEncoder.filter}}: {{case LongEnc | TimestampEnc =>   val in = Bytes.toInt(input, offset1)   val value = Bytes.toInt(filterBytes, offset2 + 1)   compare(in.compareTo(value), ops)}} It looks like that error hasn’t been caught because {{DynamicLogicExpressionSuite}} lack test cases with long values. The erroneous code is also present in the master branch. We have extended the test suite and implemented a quick fix and will PR on GitHub." TableSnapshotInputFormat/TableSnapshotInputFormatImpl should use ReadType.STREAM for scanning HFiles ,13400303,Resolved,Major,Fixed,09/Sep/21 18:34,13/Sep/21 23:40,2.4.6,"After the change in HBASE-17917 that use PREAD ({{ReadType.DEFAULT}}) for all user scan, the behavior of TableSnapshotInputFormat changed from STREAM to PREAD. TableSnapshotInputFormat is supposed to be use with a YARN/MR or other batch engine that should read the entire HFile in the container/executor, with default always to PREAD, we executing a lot more DFSInputStream#seek calls to simply read through the datablock section of the HFile. The goal of this change is to make any downstream using TableSnapshotInputFormat with STREAM scan." Protobuf-java-2.5.0.jar Has Several Security Vulnerabilities，CVE-2015-5237，CVE-2019-15544,13397951,Open,Major,,28/Aug/21 09:22,,2.2.3,"CVE-2019-15544： Vulnerability Description：An issue was discovered in the protobuf crate before 2.6.0 for Rust. Attackers can exhaust all memory via Vec::reserve calls. CVE-2015-5237： Vulnerability Description：protobuf allows remote authenticated attackers to cause a heap-based buffer overflow." Further improvements on ConnectionRegistry implementations,13392557,Open,Major,,29/Jul/21 14:55,,,"(Copied in-line from the attached 'Documentation' with some filler as connecting script) HBASE-23324 Deprecate clients that connect to Zookeeper ^^^ This is always our goal, to remove the zookeeper dependency from the client side.   See the sub-task HBASE-25051 DIGEST based auth broken for MasterRegistry When constructing RpcClient, we will pass the clusterid in, and it will be used to select the authentication method. More specifically, it will be used to select the tokens for digest based authentication, please see the code in BuiltInProviderSelector. For ZKConnectionRegistry, we do not need to use RpcClient to connect to zookeeper, so we could get the cluster id first, and then create the RpcClient. But for MasterRegistry/RpcConnectionRegistry, we need to use RpcClient to connect to the ClientMetaService endpoints and then we can call the getClusterId method to get the cluster id. Because of this, when creating RpcClient for MasterRegistry/RpcConnectionRegistry, we can only pass null or the default cluster id, which means the digest based authentication is broken. This is a cyclic dependency problem. Maybe a possible way forward, is to make getClusterId method available to all users, which means it does not require any authentication, so we can always call getClusterId with simple authentication, and then at client side, once we get the cluster id, we create a new RpcClient to select the correct authentication way. The work in the sub-task, HBASE-26150 Let region server also carry ClientMetaService, is work to make it so the RegionServers can carry a ConnectionRegistry (rather than have the Masters-only carry it as is the case now). Adds a new method getBootstrapNodes to ClientMetaService, the ConnectionRegistry proto Service, for refreshing the bootstrap nodes periodically or on error. The new *RpcConnectionRegistry*  [Created here but defined in the next sub-task]will use this method to refresh the bootstrap nodes, while the old MasterRegistry will use the getMasters method to refresh the ‘bootstrap’ nodes. The getBootstrapNodes method will return all the region servers, so after the first refreshing, the client will go to region servers for later rpc calls. But since masters and region servers both implement the ClientMetaService interface, it is free for the client to configure master as the initial bootstrap nodes. The following sub-task then deprecates MasterRegistry, HBASE-26172 Deprecated MasterRegistry The implementation of MasterRegistry is almost the same with RpcConnectionRegistry except that it uses getMasters instead of getBootstrapNodes to refresh the ‘bootstrap’ nodes connected to. So we could add configs in server side to control what nodes we want to return to client in getBootstrapNodes, i.e, master or region server, then the RpcConnectionRegistry can fully replace the old MasterRegistry. Deprecates the MasterRegistry. Sub-task HBASE-26173 Return only a sub set of region servers as bootstrap nodes For a large cluster which may have thousands of region servers, it is not a good idea to return all the region servers as bootstrap nodes to clients. So we should add a config at server side to control the max number of bootstrap nodes we want to return to clients. I think the default value could be 5 or 10, which is enough. Sub-task HBASE-26174 Make rpc connection registry the default registry on 3.0.0 Just a follow up of HBASE-26172. MasterRegistry has been deprecated, we should not make it default for 3.0.0 any more. Sub-task HBASE-26180 Introduce a initial refresh interval for RpcConnectionRegistry As end users could configure any nodes in a cluster as the initial bootstrap nodes, it is possible that different end users will configure the same machine which makes the machine over load. So we should have a shorter delay for the initial refresh, to let users quickly switch to the bootstrap nodes we want them to connect to. Sub-task HBASE-26181 Region server and master could use itself as ConnectionRegistry This is an optimization to reduce the pressure on zookeeper. For MasterRegistry, we do not want to use it as the ConnectionRegistry for our cluster connection because:     // We use ZKConnectionRegistry for all the internal communication, primarily for these reasons:     // - Decouples RS and master life cycles. RegionServers can continue be up independent of     //   masters' availability.     // - Configuration management for region servers (cluster internal) is much simpler when adding     //   new masters or removing existing masters, since only clients' config needs to be updated.     // - We need to retain ZKConnectionRegistry for replication use anyway, so we just extend it for     //   other internal connections too. The above comments are in our code, in the HRegionServer.cleanupConfiguration method. But since now, masters and regionservers both implement the ClientMetaService interface, we are free to just let the ConnectionRegistry to make use of these in memory information directly, instead of going to zookeeper again. Sub-task HBASE-26182 Allow disabling refresh of connection registry endpoint One possible deployment in production is to use something like a lvs in front of all the region servers to act as a LB, so clients just need to connect to the lvs IP instead of going to the region server directly to get registry information. For this scenario we do not need to refresh the endpoints any more. The simplest way is to set the refresh interval to -1." Implement a new mini cluster class for end users,13388835,Resolved,Major,Fixed,10/Jul/21 15:22,13/Jul/21 07:35,, Skip archived master wals during incremental backups,13403617,Resolved,Major,Fixed,27/Sep/21 17:20,24/Jan/23 13:39,,"I've been reading through the incremental backup implementation in master branch to see how it handled some scenarios our own internal incremental backup process has to handle. One such failure we recently encountered as part of our ongoing hbase2 upgrade is the new $masterlocalwal$ suffixed files in the oldWALs dir. Our parsing of the WAL files assumed that the last part of the file name would be a timestamp, which is not the case for these MasterRegion WALs. I see [IncrementalBackupManager excludes ProcV2Wals|https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java#L104-L117], but I think that was replaced in https://issues.apache.org/jira/browse/HBASE-24408 with a MasterRegion. The new MasterRegion uses normal WALs, but archives them with a suffix ""$masterlocalwal$"". I believe this would fail [around line 222 of IncrementalBackupManager|https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java#L222], because [BackupUtils.getCreationTime|https://github.com/apache/hbase/blob/master/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java#L383-L390] similarly expects the file names to end with a timestamp. Unfortunately I am not set up to run master branch or test the backup/restore functionality, but I wanted to log this because I happened to stumble upon it.  " Add dry run mode to hbase balancer,13392206,Resolved,Major,Fixed,27/Jul/21 21:08,02/Sep/21 02:08,,"It's often rather hard to know how the cost function changes you're making will affect the balance of the cluster, and currently the only way to know is to run it. If the cost decisions are not good, you may have just moved many regions towards a non-ideal balance. Region moves themselves are not free for clients, and the resulting balance may cause a regression. We should add a mode to the balancer so that it can be invoked without actually executing any plans. This will allow an administrator to iterate on their cost functions and used the balancer's logging to see how their changes would affect the cluster. " handleTooBigRequest in NettyRpcServer didn't skip enough bytes,13393625,Resolved,Major,Fixed,05/Aug/21 06:25,05/Aug/21 15:20,,"We found there are always coredump problems after too big requests, the logs are as follows, !error-logs.png|width=1040,height=187!" The potential delay of HDFS RPC in HRegion may cause data inconsistency and some HBase shell commands hanging,13399503,Open,Major,,06/Sep/21 03:34,,2.4.2,"When a RegionServer is initializing a new region, it writes its internal metadata (e.g., WAL) in the HDFS cluster. We find that this write operation can be potentially blocked due to network issues or overloading on HDFS side, and the delay will result in inconsistency to HBase clients and cause multiple HBase APIs to hang as well. *Reproduction*    Steps to reproduce the symptom from scratch: # Start a HDFS cluster (1 NameNode + 2 DataNodes) with the default configuration. # Start a ZooKeeper cluster (3 nodes) with the default configuration. # Start a HBase cluster (1 Master + 2 RegionServers) with the default configuration. # In one of the RegionServers, introduce a delay by invoking `Thread.sleep` when it is creating its third region (alternatively, use a network packet loss injection tool like `tc`) # When the HBase cluster just gets started, the fault has not yet been triggered. We use the default HBase shell by running `bin/hbase shell` in the terminal. In the HBase shell, we repeatedly use the `create` command to create new tables, until the fault is triggered.   When the fault occurs, we observe several symptoms as follows: # The HBase shell running the `create` command hangs, without any log or warning. # If we start another HBase shell and run the `list` command to see all the tables, we can see the table in the result. However, this table has actually not been created yet. Ideally the client should not see this pending table before `create` succeeds.  # If we start another HBase shell and run the `disable` command to disable this table, the HBase shell will hang, without any log or warning. Ideally, we should see some error or warning within a short duration of time, because this table has not been created yet.       The stack trace: {code:java} ""RS_OPEN_REGION-regionserver/razor15:16022-0"" #144 daemon prio=5 os_prio=0 tid=0x00007f4c34ed8000 nid=0x4463 waiting on condition [0x00007f4bfd496000]   java.lang.Thread.State: TIMED_WAITING (sleeping)    at java.lang.Thread.sleep(Native Method)    at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1075)    at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:955)    at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:8081)    at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:8040)    at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:8016)    at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7974)    at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7925)    at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:145)    at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)    at java.lang.Thread.run(Thread.java:748) {code}      Relevant code snippet: {code:java} // file path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java // class: org.apache.hadoop.hbase.regionserver.HRegion public class HRegion implements HeapSize, PropagatingConfigurationObserver, Region { // ...   private long initializeRegionInternals(final CancelableProgressable reporter,       final MonitoredTask status) throws IOException {   // ... if (!isRestoredRegion) {     // ...     if (RegionReplicaUtil.isDefaultReplica(getRegionInfo())) {       // ...       // At and only at the third time of invocation,       // invoke Thread.sleep, to simulate a delay of HDFS RPC       WALSplitUtil.writeRegionSequenceIdFile(getWalFileSystem(), getWALRegionDir(),         nextSeqId - 1);       // ...     }   }   // ...   } // ... } {code} *Fix* We’re not quite sure about the root causes for the inconsistencies or the blocking of other APIs. One potential simple fix is to protect the  `WALSplitUtil.writeRegionSequenceIdFile` operation (or the HDFS RPCs inside it) with timeout. We checked that throwing a timeout exception when the operation takes too long would resolve the aforementioned symptoms.  " Allow users to not start zookeeper and dfs cluster when using TestingHBaseCluster,13393262,Resolved,Major,Fixed,03/Aug/21 12:51,15/Jun/22 06:58,,"Users may start zookeeper and dfs cluster outside TestingHBaseCluster to make different components share the same zookeeper and dfs cluster. We should allow users to not start zookeeper and dfs cluster when using TestingHBaseCluster, and maybe we could provide utility class to let users easily set the configurations to switch to external zookeeper and dfs cluster." Automatic and near real-time healing of locality,13398961,Open,Major,,02/Sep/21 14:18,,,"I’m proposing a somewhat major new tool for quickly and efficiently alleviating latency pains due to locality. This is especially useful in cloud environments, and has been highly impactful at HubSpot, where we run thousands of RegionServers across 40+ multi-zone clusters. Please see the attached design doc for details on the problem, why compactions are not enough to solve the problem, and an overview (with diagram) of the components that make up this new tool. As spec'd, this new feature would require submission of a new tool in the HDFS project. Once we reach consensus on the approach I can create the relevant upstream HDFS JIRA. See the design doc here: [https://docs.google.com/document/d/1GLGzrF1QLyhyOCr2fFw0LCymnyFPT0ktShTaaXn-75A/edit#heading=h.aswo7shg76b6] Note: This issue is an attempt to upstream a tool that has been fully deployed for all clusters in production at HubSpot for about 6 months. It's been very effective for us as currently implemented, but will need to be re-organized and re-designed a bit to fit into the HBase/HDFS projects. As such I'd like feedback on the design before putting in too much effort on porting multiple components into PRs." Write straight into the store directory when Splitting and Merging,13394472,Resolved,Major,Fixed,10/Aug/21 15:30,18/Aug/21 15:53,3.0.0-alpha-1,"As discussed with [~zhangduo] on HBASE-26079, we think there's no actual need for Splits/Merges to make use of temp directories, because the split/merge region files would not be loaded until the new regions are ready to open, meaning the split/merge operation has completed. This would then avoid the need for a FS rename at the end of split/merge operation." Showcase/document a end-to-end tracing integreated with an external sink e.g. Jaeger or zipkin ,13398339,Open,Major,,31/Aug/21 01:49,,2.5.0,"This task/issue was being discussed [in the vote of HBASE-25853|https://lists.apache.org/thread.html/rb36f0b6b179ee5f42cff7bb60de2797f69c450752c993f0b1e0f6118%40%3Cdev.hbase.apache.org%3E] bq. I've not seen anyone report their success at integrating these changes into a telemetry system and showing end-to-end tracing of a service call. As I recall from the last 2.5 discuss thread, we wanted this to be the banner feature for the minor release. Since we don't have this end-to-end confirmation, do we have someone who's volunteered to demonstrate that final proof-of-integration in a timely manner? Perhaps that someone is keen to be release manager for 2.5. What a `service call` mean ? (pending discussion on above email exchange or on this JIRA) e.g. for RPCclient/AbstractRpcClient, it trace at the AbstractRpcClient#callMethod level with a span of `RpcClient.callMethod` . or whenever a connection is closed, it will emit `AsyncConnection.close`" Error when running hbase with mvn package -DskipTests,13391298,Open,Major,,22/Jul/21 09:21,,2.4.1,I run the source code of hbase with mvn package -DskipTests but there are errors when i run it !Screenshot from 2021-07-22 16-20-02.png! Data is present in replicated cluster but not present in primary cluster.,13394940,Resolved,Major,Fixed,12/Aug/21 16:49,08/Sep/21 20:37,1.7.0,"We encountered a case where we are seeing some rows (via Phoenix) in replicated cluster but they are not present in source/active cluster. Triaging further we found memstore rollback logs in few of the region servers. {noformat} 2021-07-28 14:17:59,353 DEBUG [3,queue=3,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,353 DEBUG [,queue=25,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,354 DEBUG [3,queue=3,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,354 DEBUG [,queue=25,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,354 DEBUG [3,queue=3,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,354 DEBUG [,queue=25,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,355 DEBUG [3,queue=3,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,355 DEBUG [,queue=25,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 2021-07-28 14:17:59,356 DEBUG [,queue=25,port=60020] regionserver.HRegion - rollbackMemstore rolled back 23 {noformat} Looking more into logs, found that there were some hdfs layer issues sync'ing wal to hdfs. It was taking around 6 mins to sync wal. Logs below {noformat} 2021-07-28 14:19:30,511 WARN [sync.0] hdfs.DataStreamer - Slow waitForAckedSeqno took 391210ms (threshold=30000ms). File being written: /hbase/WALs/,60020,1626191371499/%2C60020%2C1626191371499.1627480615620, block: BP-958889176--1567030695029:blk_1689647875_616028364, Write pipeline datanodes: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]]. 2021-07-28 14:19:30,589 WARN [sync.1] hdfs.DataStreamer - Slow waitForAckedSeqno took 391148ms (threshold=30000ms). File being written: /hbase/WALs/,60020,1626191371499/%2C60020%2C1626191371499.1627480615620, block: BP-958889176--1567030695029:blk_1689647875_616028364, Write pipeline datanodes: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]]. 2021-07-28 14:19:30,589 WARN [sync.2] hdfs.DataStreamer - Slow waitForAckedSeqno took 391147ms (threshold=30000ms). File being written: /hbase/WALs/,60020,1626191371499/%2C60020%2C1626191371499.1627480615620, block: BP-958889176--1567030695029:blk_1689647875_616028364, Write pipeline datanodes: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]]. 2021-07-28 14:19:30,591 INFO [sync.0] wal.FSHLog - Slow sync cost: 391289 ms, current pipeline: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]] 2021-07-28 14:19:30,591 INFO [sync.1] wal.FSHLog - Slow sync cost: 391227 ms, current pipeline: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]] 2021-07-28 14:19:30,591 WARN [sync.1] wal.FSHLog - Requesting log roll because we exceeded slow sync threshold; time=391227 ms, threshold=10000 ms, current pipeline: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]] 2021-07-28 14:19:30,591 INFO [sync.2] wal.FSHLog - Slow sync cost: 391227 ms, current pipeline: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]] 2021-07-28 14:19:30,591 WARN [sync.2] wal.FSHLog - Requesting log roll because we exceeded slow sync threshold; time=391227 ms, threshold=10000 ms, current pipeline: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]] 2021-07-28 14:19:30,591 WARN [sync.3] hdfs.DataStreamer - Slow waitForAckedSeqno took 391217ms (threshold=30000ms). File being written: /hbase/WALs/,60020,1626191371499/%2C60020%2C1626191371499.1627480615620, block: BP-958889176--1567030695029:blk_1689647875_616028364, Write pipeline datanodes: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]]. 2021-07-28 14:19:30,591 INFO [sync.3] wal.FSHLog - Slow sync cost: 391217 ms, current pipeline: [DatanodeInfoWithStorage[:50010,DS-b5747702-8ab9-4a5e-916e-5fae6e305738,DISK], DatanodeInfoWithStorage[:50010,DS-505dabb0-0fd6-42d9-b25d-f25e249fe504,DISK], DatanodeInfoWithStorage[:50010,DS-6c585673-d4d0-4ec6-bafe-ad4cd861fb4b,DISK]] {noformat} Just to add more details, we also found there was a namenode failover. Might be a contributing factor on why sync's were slow but not sure. {noformat} 2021-07-28 14:19:30,390 WARN [:60020-3] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491727 Client NamenodeProtocolTranslatorPB.mkdirs over /:8020 2021-07-28 14:19:30,390 WARN [:60020-7] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491726 ClientNamenodeProtocolTranslatorPB.mkdirs over /:8020 2021-07-28 14:19:30,391 WARN [20%2C1626191371499,1] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491723 ClientNamenodeProtocolTranslatorPB.getBlockLocations over /:8020 2021-07-28 14:19:30,391 WARN [0.40:60020.logRoller] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491729 ClientNamenodeProtocolTranslatorPB.getFileInfo over /:8020 2021-07-28 14:19:30,391 WARN [MemStoreFlusher.1] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491730 ClientNamenodeProtocolTranslatorPB.getFileInfo over /:8020 2021-07-28 14:19:30,391 WARN [371499.1627480615620] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491731 ClientNamenodeProtocolTranslatorPB.addBlock over /:8020 2021-07-28 14:19:30,391 WARN [c@prod] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491725 ClientNamenodeProtocolTranslatorPB.renewLease over /:8020 2021-07-28 14:19:30,391 WARN [91371499@] retry.RetryInvocationHandler - A failover has occurred since the start of call #8491724 ClientNamenodeProtocolTranslatorPB.getBlockLocations over /:8020 {noformat} We use the default timeout for hbase.regionserver.wal.sync.timeout which is 5 mins. Since the sync took more than 6 minutes (which is more than hbase.regionserver.wal.sync.timeout), the client received an Exception and we rolled back tje mutations in memstore on the primary cluster. But the hdfs sync succeeded +eventually+, the row was present in wal and was eligible for replication. [~bharathv] [~andrew.purtell@gmail.com] [~gjacoby] helped brainstorming for a possible solution. Will update the possible approaches in the comments section." Wrap up 1.7.1 release,13391174,Resolved,Major,Fixed,21/Jul/21 17:20,02/Aug/22 08:44,1.7.1,"- Set branch-1 version to 1.7.2-SNAPSHOT - Update SVN release bits, add download links to 1.7.1 - Remove 1.7.0 from the mirrors - Commit HBASE-26071 in that order." Modify our ref guide to mention the deprecation of HBTU and also how to make use of the new TestingHBaseCluster,13390580,Resolved,Major,Fixed,19/Jul/21 01:33,24/Jun/22 04:45,, Shell scan fails with timestamp,13404203,Closed,Major,Fixed,30/Sep/21 07:19,09/Oct/21 03:27,3.0.0-alpha-2,for removal of _setTimestamp_ in _Scan.java， scan with timestamp doesn't work。_ Remove FirstKeyValueMatchingQualifiersFilter,13389852,Closed,Major,Fixed,15/Jul/21 14:18,25/Jul/21 13:20,,"see HBASE-13347. FirstKeyValueMatchingQualifiersFilter was deprecated in 2.0 and should be removed in 3.0.   " Ameliorate compaction made by bulk-loading files,13398866,Resolved,Major,Fixed,02/Sep/21 06:45,23/Nov/21 08:01,,"HBASE-25213 introduced to trigger compact after bulkload, but if a store needs compaction, each file loaded to this store will add a compaction runner of this store to the compaction queue. Then repeatedly compute for needCompaction and selectFiles for this store, and the compaction of the store may be continuous. We can mark the queued compaction runners for the stores, and avoid repeatedly adding same store compactions to the queue after bulk load files. This method can reduce the pressure during the period just after bulk loading and spread the pressure to other times by the periodic CompactionChecker. For the need of splitting mentioned before, after the completion of compaction, it will trigger split of the region if it needs. So we do not need to trigger split after bulk loading.  " MiniZooKeeperCluster should not be IA.Public,13392783,Resolved,Major,Later,30/Jul/21 14:45,14/Jun/22 12:47,,"End users do not need to test HBase when zookeeper is broken. And if users want to start only a zookeeper cluster, they can just use curator-test, so I do not think we should expose this class as IA.Public." "Backport HBASE-25401 ""Add trace support for async call in rpc client"" to branch-2",13392003,Resolved,Major,Fixed,27/Jul/21 03:35,02/Aug/21 23:47,2.5.0,"[2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit of HBASE-25401 was [https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04]" Update jetty version to fix CVE-2021-34429,13402439,Resolved,Major,Duplicate,21/Sep/21 10:32,02/Jun/22 06:39,," CVE-2021-34429 issue is fixed in Jetty 9.4.43.v20210629 and we are using jetty 9.4.41.v20210516. https://github.com/apache/hbase-thirdparty/blob/c28a235236b9f63ec1d36431e5d1b6c8d4b66d90/pom.xml#L139" Change the way on how we track store file list,13387830,Resolved,Major,Fixed,06/Jul/21 03:55,17/Apr/22 17:33,,"Open a separated jira to track the work since it can not be fully included in HBASE-24749. I think this could be a landed prior to HBASE-24749, as if this works, we could have different implementations for tracking store file list." Fallback support to pure Java compression,13399874,Resolved,Major,Fixed,08/Sep/21 02:08,06/Oct/21 20:17,,"Airlift’s aircompressor (https://search.maven.org/artifact/io.airlift/aircompressor) is an Apache 2 licensed library, for Java 8 and up, available in Maven central, which provides pure Java implementations of gzip, lz4, lzo, snappy, and zstd and Hadoop compression codecs for same, claiming “_they are typically 300% faster than the JNI wrappers_.” (https://github.com/airlift/aircompressor). This library is under active development and up to date releases because it is used by Trino. Proposed changes: * Modify Compression.java such that compression codec implementation classes can be specified by configuration. Currently they are hardcoded as strings. * Pull in aircompressor as a ‘compile’ time dependency so it will be bundled into our build and made available on the server classpath. * Modify Compression.java to fall back to an aircompressor pure Java implementation if schema specifies a compression algorithm, a Hadoop native codec was specified as desired implementation, but the requisite native support is somehow not available." Universal compression support,13399872,Resolved,Major,Fixed,08/Sep/21 01:52,19/Oct/21 21:19,,"Some Hadoop compression codecs became more available in recent Hadoop 3.x releases, addressed by HBASE-25940. This is nice but still requires native platform support, which to state the obvious is not available on all platforms and architectures, even if native libaries for some are bundled into jars. Airlift's aircompressor (https://search.maven.org/artifact/io.airlift/aircompressor) is an Apache 2 licensed library, for Java 8 and up, available in Maven central, which provides pure Java implementations of desirable compression algorithms gzip, lz4, lzo, snappy, and zstd, and Hadoop compression codecs for same, claiming ""_they are typically 300% faster than the JNI wrappers_."" (https://github.com/airlift/aircompressor). This library is under active development and has up to date releases because it is used by Trino. We have another project that depends on universal availability of SNAPPY. I would like to make this change as a general improvement which also satisfies that requirement. (The as yet unnamed project will be contributed later.) It will be a very nice-to-have to have universal ZSTD support available as well. Proposed changes: * Modify Compression.java such that compression codec implementation classes can be specified by configuration. Currently they are hardcoded as strings. * Pull in aircompressor as a 'compile' time dependency so it will be bundled into our build and made available on the server classpath. * Modify Compression.java to fall back to an aircompressor pure Java implementation if schema specifies a compression algorithm, a Hadoop native codec was specified as desired implementation, but the requisite native support is somehow not available. The combination of these changes will provide universal (pure Java) support for these desired and desirable compression codecs while retaining default behavior, which is to load and utilize Hadoop native implementations of same, if native support is available. They will also let you override this default if you wish to chase the claimed benefits of the pure Java alternatives." Store region server list in master local region,13398501,Resolved,Major,Fixed,31/Aug/21 16:08,01/Apr/22 02:05,,"Just a simple idea still need to be polished. For large clusters, ZooKeeper could be a bottle neck, there are some related issues to not track region server list as much as possible, but what if we want to do more, just do not register region server on zk? I think, zookeeper here is act as something like a service registry, we need the list to get all the region servers, and also need to know the changes of the list. But in fact, we could also kill region server from master side, so the latter one could be done by a periodical heartbeat check daemon on master. And for the former one, we could store the list in master local region, so when master restart, it could setup the region server list by load from master local region. And there are mainly two other side effect which are good: 1. We do not need to list the WAL directory on HDFS to find the previous region servers, for scheduling SCP. This could make it possible to restart a new HBase cluster based on only the root directory. 2. For now, region server needs to register to HMaster first, and then put its node on ZooKeeper, if it fails between these two actions, there is no way for HMaster to clean this dead server, as it never expires on ZooKeeper. There should be a related issue. If we just do not store a node on zk, then this problem is also gone. Of course, there will still be lots of other problems, like whether we need another heartbeat call as reportForDuty is a bit heavy as we also report the region list, etc." Reflect out-of-band locality improvements in served requests,13403854,Resolved,Major,Fixed,28/Sep/21 13:26,04/Dec/21 07:37,,"Edit: Description updated to avoid needing to read the full investigation laid out in the comments. Once the LocalityHealer has improved locality of a StoreFile (by moving blocks onto the correct host), the Reader's DFSInputStream and Region's localityIndex metric must be refreshed. Without refreshing the DFSInputStream, the improved locality will not improve latencies. In fact, the DFSInputStream may try to fetch blocks that have moved, resulting in a ReplicaNotFoundException. This is automatically retried, but the retry will temporarily increase long tail latencies relative to configured backoff strategy. In the original LocalityHealer design, I created a new RefreshHDFSBlockDistribution RPC on the RegionServer. This RPC accepts a list of region names and, for each region store, re-opens the underlying StoreFile if the locality has changed. This implementation was complicated both in integrating callbacks into the HDFS Dispatcher and in terms of safely re-opening StoreFiles without impacting reads or caches.  In working to port the LocalityHealer to the Apache projects, I'm taking a different approach: * The part of the LocalityHealer that moves blocks will be an HDFS project contribution * As such, the DFSClient should be able to more gracefully recover from block moves. * Additionally, HBase has some caches of block locations for locality reporting and the balancer. Those need to be kept up-to-date. The DFSClient improvements are covered in HDFS-16261 and HDFS-16262. As such, this issue becomes about updating HBase's block location caches. I considered a few different approaches, but the most elegant one I could come up with was to tie the HDFSBlockDistribution metrics directly to the underlying DFSInputStream of each StoreFile's initialReader. That way, our locality metrics are identically representing the block allocations that our reads are going through. This also means that our locality metrics will naturally adjust as the DFSInputStream adjusts to block moves. Once we have accurate locality metrics on the regionserver, the Balancer's cache can easily be invalidated via our usual heartbeat methods. RegionServers report to the HMaster periodically, which keeps a ClusterMetrics method up to date. Right before each balancer invocation, the balancer is updated with the latest ClusterMetrics. At this time, we compare the old ClusterMetrics to the new, and invalidate the caches for any regions whose locality has changed." Use priority queue in dir scan pool of cleaner,13403783,Resolved,Major,Won't Fix,28/Sep/21 09:35,07/Mar/22 12:29,2.0.0,"DirScanPool used normal LinkedBlockingQueue when creating thread pool, {code:java}  54   private static ThreadPoolExecutor initializePool(int size) {  55     return Threads.getBoundedCachedThreadPool(size, 1, TimeUnit.MINUTES,  56       new ThreadFactoryBuilder().setNameFormat(""dir-scan-pool-%d"").setDaemon(true)  57         .setUncaughtExceptionHandler(Threads.LOGGING_EXCEPTION_HANDLER).build());  58   } {code} which will not priority scan larger directories and delete files there as expected, though CleanerChore#sortByConsumedSpace() before putting directories to the queue. Subdirectories of larger directories and small directories are taken fairly in the queue. We should used priority queue here instead, e.g. PriorityBlockingQueue, to make larger directories be cleaned earlier. " MetricsRegionServer may throws NullPointerException,13393634,Open,Major,,05/Aug/21 07:22,,,"MetricsRegionServer may throws NullPointerException When optional.get() is called.     {code:java} metricRegistry = MetricRegistries.global().get(serverSource.getMetricRegistryInfo()).get();   {code}  " Simple travis build for hbase-filesystem,13398093,Resolved,Major,Fixed,30/Aug/21 01:53,25/Jan/22 01:41,,Noticed that we don't have any kind of precommit checks. Time to make a quick one. Release 3.0.0-alpha-2,13391233,Resolved,Major,Fixed,22/Jul/21 02:34,24/Dec/21 06:21,, RIT counts should be configured when cluster is balancing,13391558,Open,Major,,23/Jul/21 11:44,,,"RIT count was hard code in HMaster.java. it is too slow be balanced when cluster has too many regions! " Implement a region based store file tracker,13399950,Open,Major,,08/Sep/21 10:30,,, Limit max result size of individual Gets,13391952,Resolved,Major,Won't Fix,26/Jul/21 19:18,09/Dec/21 21:58,,"Scans have the ability to have a configured max result size, which causes them to return a partial result once the limit has been reached. MultiGets also can throw MultiActionResultTooLarge if the response size is over a configured quota. Neither of these really accounts for a single Get of a too-large row. Such too-large Gets can cause substantial GC pressure or worse if sent at volume. Currently one can work around this by converting their Get to a single row Scan, but this requires a developer to proactively know about and prepare for the issue by using a Scan upfront or wait for the RegionServer to choke on a large request and only then rewrite the Get for future requests. We should implement the same response size limits for for Get as for Scan, whereby the server returns a partial result to the client for handling." RegionServer dead on hadoop 3.3.1: NoSuchMethodError LocatedBlocks.getLocations(),13395427,Resolved,Major,Not A Problem,16/Aug/21 08:28,03/Dec/21 11:17,,!image-2021-08-16-16-24-32-418.png! hbck2 should support remove deleted meta region,13395432,Resolved,Major,Fixed,16/Aug/21 08:39,03/Dec/21 11:14,,"A large number of regions of deleted tables will enter rit when hbase2.x restarts， and these region will also appear on hbck web page,  we just delete these region in meta table，and change active master。 here is my request: [pull request|https://github.com/apache/hbase-operator-tools/pull/81]" The HStore.snapshot method is never called in main code,13392102,Resolved,Major,Fixed,27/Jul/21 11:41,31/Jul/21 07:29,,"In the comment of HStore.flushCache, we say that HStore.snapshot method must be called first. But actually, we will call memstore.snapshot directly from StoreFlusherImpl.prepare, without holding the write lock. The reason we do not need to hold the write lock is that, we hold HRegion.updatesLock in the upper layer, so it is OK. See HBASE-10087 for more discussion about this. So in general, I think we could remove the snapshot method in HStore. And I do not think we need to hold the write lock when calling clearSnapshot then. As in the HRegion layer, we need to guarantee that there is only one ongoing flush of the region, so before we finish the region, it is already safe to operate on the snapshot of the memstore, especially that the clearSnapshot method itself is thread safe." Master initialization fails if Master Region WAL dir is missing,13400093,Resolved,Major,Fixed,08/Sep/21 20:46,16/Nov/21 21:42,2.4.6,"From a recent branch-2.4 build: {noformat} 2021-09-07 19:31:19,666 ERROR [master/localhost:16000:becomeActiveMaster] master.HMaster(159): ***** ABORTING master localhost,16000,1631057476442: Unhandled exception. Starting shutdown. ***** java.io.FileNotFoundException: File hdfs://localhost:8020/hbase-2.4-wals/MasterData/WALs does not exist. at org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:1059) at org.apache.hadoop.hdfs.DistributedFileSystem.access$1000(DistributedFileSystem.java:131) at org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1119) at org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1116) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:1126) at org.apache.hadoop.hbase.master.region.MasterRegion.open(MasterRegion.java:226) at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:303) at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:104) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:839) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2189) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:512) at java.lang.Thread.run(Thread.java:748) {noformat} If the WAL directory is missing but the Master Region already exists, we will try to list the contents of the Master Region's WAL directory which may or may not exist. If we simply check to make sure the directory exists and then the rest of the initialization code works as expected." High rate logging of BucketAllocatorException: Allocation too big ,13394780,Resolved,Major,Fixed,11/Aug/21 23:46,27/Oct/21 15:17,2.4.5,"These log lines may be printed at high frequency when using a schema that creates large blocks and the bucket cache is enabled. It makes sense to warn about this initially, but the very high rate of warnings when the use case is legit and this is expected does not. Print this once, then not again; or, rate-limit this message to be printed at a more reasonable rate, like once per minute. {noformat} 2021-08-11 23:42:10,902 WARN [main-BucketCacheWriter-0] bucket.BucketCache: Failed allocation for 4842189251414b8a9212f6831462e415_218610843; org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=1049337; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. {noformat} Also, it might be better to log this at INFO given the caveat ""if size seems reasonable and you want it cached"". Reads like an informational message." Balancer gets stuck in cohosted replica distribution,13404190,Resolved,Major,Fixed,30/Sep/21 05:26,11/Nov/21 02:02,,"In production, we found a corner case where balancer cannot make progress when there is cohosted replica. This is repro'ed on master branch using test added in HBASE-26310.  " Backport HBASE-23834 to branch 2.3,13399190,Resolved,Major,Won't Fix,03/Sep/21 10:26,21/Sep/21 17:22,2.3.0,"HBase 2.3 branch is currently on Jetty 9.3, and latest Hadoop 3 (unreleased branches trunk, branch-3.2 and branch-3.1) bumped Jetty to 9.4" Balancer tends to move regions to the server at the end of list,13404181,Resolved,Major,Fixed,30/Sep/21 03:11,03/Nov/21 02:31,,"When we have cohosted replicas, cohosted replica distribution has priority to region count skew. So we won't see region count  getting balanced until the replicas distributed. During this time, master UI shows a drift of regions to the server at the end of list and causes significant overload. This shows a bias of random region pick and needs to be addressed." Repro balancer behavior during iterations,13404183,Resolved,Major,Implemented,30/Sep/21 03:15,03/Nov/21 02:32,,"All existing tests expect balancer to complete in one run. This misses temporary imbalance or inefficiency during iterations on large clusters. Recently we found such issues for cohosted region distribution. To repro the problem and validate fixes, we need a test to simulate multiple iterations." Add HBase Thrift API to get all table names along with whether it is enabled or not,13401303,Resolved,Major,Fixed,15/Sep/21 08:48,18/Oct/21 14:37,2.2.7,"When loading Hue HBase page, hue will firstly get all the table names in one thrift call, then hue will send a request as a new connection to Hbase thrift server for each table to check if the table is enabled or not. When the number of table becomes big, for example a few hundreds. Hue will have the chance to fail to show the table list, and it shows an error message on Hue web UI ""Api Error: Unable to authenticate"". In Hbase thrift server log, we can see error message, below is an example from test environment: ====================================== 2020-07-02 21:54:01,025 INFO org.apache.hadoop.hbase.thrift.ThriftHttpServlet: Failed to authenticate with HTTP/[...]@HADOOP.COM kerberos principal 2020-07-02 21:54:01,025 ERROR org.apache.hadoop.hbase.thrift.ThriftHttpServlet: Kerberos Authentication failed org.apache.hadoop.hbase.thrift.HttpAuthenticationException: java.lang.reflect.UndeclaredThrowableException ...... Caused by: java.lang.reflect.UndeclaredThrowableException ...... Caused by: org.apache.hadoop.hbase.thrift.HttpAuthenticationException: Kerberos authentication failed: ...... Caused by: GSSException: Failure unspecified at GSS-API level (Mechanism level: Request is a replay (34)) ...... Caused by: KrbException: Request is a replay (34) ====================================== ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ My current understanding of the cause is Hue sends requests too fast so that it has the chance to send 2 requests with the same Kerberos authenticator (timestamp is same). So Hbase thrift server will think this is a replay attack. We came up with this assumption based on tcpdump observation and this document, https://web.mit.edu/kerberos/krb5-latest/doc/basic/rcache_def.html If HBase Thrift server can have an API call that Hue can call it once and get all table names with whether is enabled or not, we can avoid above issue." Do not store meta region location as permanent state on zookeeper,13394818,Resolved,Major,Fixed,12/Aug/21 05:03,17/Aug/21 11:07,,"As it breaks one of our design rules https://hbase.apache.org/book.html#design.invariants.zk.data We used to think hbase should be recovered automatically when all the data on zk (except the replication data) are cleared, but obviously, if you clear the meta region location, the cluster will be in trouble, and need to use operation tools to recover the cluster. So here, along with the ConnectionRegistry improvements, we should also consider move the meta region location off zookeeper." jenkins script for caching artifacts should verify cached file before relying on it,13394280,Resolved,Major,Fixed,09/Aug/21 20:53,09/Oct/21 05:27,2.5.0,"Nightly builds of branch-2 have been failing on the ""Packaging and Integration"" stage since 2021-07-22, commit 8bc180c7737bbd1792851004625c552896bf57c6. The first failing build was https://ci-hadoop.apache.org/blue/organizations/jenkins/HBase%2FHBase%20Nightly/detail/branch-2/304/pipeline/12" The default value of 'hbase.hregion.memstore.mslab.indexchunksize.percent' should be 0,13392076,Open,Major,,27/Jul/21 09:41,,2.4.0,"The default value of {{hbase.hregion.memstore.mslab.indexchunksize.percent}} introduced by HBASE-24892 is 0.1, but we use {{DefaultMemStore}} by default , which has no IndexChunk and {{ChunkCreator.indexChunksPool}} is useless(IndexChunk is only used by {{CompactingMemStore}} and {{CellChunkMap}}, ), so the {{hbase.hregion.memstore.mslab.indexchunksize.percent}} should be 0 by default to save memory space. Only when we use {{CompactingMemStore}} and {{CellChunkMap}}, it is meaningful to set {{hbase.hregion.memstore.mslab.indexchunksize.percent}} by user. Howerver, because existing bug in {{ChunkCreator}}, it depends on HBASE-26142" Limit count and size of L0 files compaction in StripeCompactionPolicy,13397750,Resolved,Major,Fixed,27/Aug/21 08:56,09/Sep/21 10:32,,"When selecting L0 files in the stripe store file manager to compact, they all will be selected. This is the key problem. No file count control and no compaction size control for L0 files compactions now. If the compaction size is large, e.g. some TBs, then the L0 compaction will need a lot of time to complete.  Since L0 files not only contains the recently flushed files, bulk loaded files will also be put into L0. And what's more, when opening a daughter region, if the parent stripes can not be rebuild in the daughter, all the files will be put to L0. So when there are large enough files in L0, there will exists a quite long compaction for all the L0 files. If the compaction speed less than the file flush speed to L0, larger compactions afterwards. This is a big problem especially in bulkloading files.   " Publish the test logs for our nightly jobs to nightlies.apache.org,13404226,Resolved,Major,Fixed,30/Sep/21 08:21,07/Oct/21 15:45,,To save spaces on jenkins build machine. Backport HBASE-25451 Upgrade commons-io to 2.8.0,13402420,Resolved,Major,Won't Fix,21/Sep/21 08:43,08/Oct/21 11:13,,"Upgrade commons-io due to CVE-2021-29425. HBASE-25451 was originally merged to branch-2 and master." Upgrade commons-io to 2.8.0 in hbase-connectors,13404319,Resolved,Major,Fixed,30/Sep/21 14:27,01/Oct/21 08:34,,Upgrade commons-io in hbase-connectors to 2.8.0 due to CVE-2021-29425. Region server and master could use itself as ConnectionRegistry,13394021,Resolved,Major,Fixed,07/Aug/21 12:43,20/Aug/21 07:58,,"As they already cached everything for connection registry in memory, the cluster connection can fetch the in memory data directly instead of go to zookeeper again. This is an optimization to reduce the pressure on zookeeper. For MasterRegistry, we do not want to use it as the ConnectionRegistry for our cluster connection because:     // We use ZKConnectionRegistry for all the internal communication, primarily for these reasons:     // - Decouples RS and master life cycles. RegionServers can continue be up independent of     //   masters' availability.     // - Configuration management for region servers (cluster internal) is much simpler when adding     //   new masters or removing existing masters, since only clients' config needs to be updated.     // - We need to retain ZKConnectionRegistry for replication use anyway, so we just extend it for     //   other internal connections too. The above comments are in our code, in the HRegionServer.cleanupConfiguration method. But since now, masters and regionservers both implement the ClientMetaService interface, we are free to just let the ConnectionRegistry to make use of these in memory information directly, instead of going to zookeeper again." "Backport ""HBASE-26181 Region server and master could use itself as ConnectionRegistry"" to branch-2",13403042,Resolved,Major,Fixed,24/Sep/21 03:50,05/Oct/21 14:11,,"We have no AsyncClusterConnection on branch-2, so although there is a backport in the title of this issue, we need to reimplement the approach." Upgrade commons-io to 2.11.0 in hbase-filesystem,13404323,Resolved,Major,Fixed,30/Sep/21 14:42,06/Oct/21 09:10,,Upgrade commons-io in hbase-filesystem to 2.11.0 due to CVE-2021-29425. Add preRequestCompaction method for AccessController,13400452,Resolved,Major,Fixed,10/Sep/21 12:20,03/Oct/21 14:38,, BucketCache could not free BucketEntry which restored from persistence file,13403120,Resolved,Major,Fixed,24/Sep/21 10:57,29/Sep/21 13:55,2.4.6,"HBASE-21957 reserved a {{BucketEntry}} ctor which has no {{RefCnt#recycler}}, and when {{BucketCache}} is restored from a persistence file, it use this no {{RefCnt#recycler}}, {{BucketEntry}} ctor. But from HBASE-21957, {{BucketEntry}} is freed through {{RefCnt#recycler}} , so this no {{RefCnt#recycler}} {{BucketEntry}} could not be freed even if corresponding {{HFileBlock}} is evicted from {{BucketCache}}." Hbase scan setMaxResultsPerColumnFamily not giving right results,13401847,Resolved,Major,Fixed,17/Sep/21 10:13,29/Sep/21 08:48,2.1.9,"scan.setMaxResultsPerColumnFamily(1) is giving less number of row keys vs when it is not set in the scan, on a table that has multiple column families and multiple qualifier or multiple versions for each cell  Docs for setMaxResultsPerColumnFamily: {code:java} /** * Set the maximum number of values to return per row per Column Family * @param limit the maximum number of values returned / row / CF */{code}" Shell 'load' command behavior has changed,13400103,Open,Major,,08/Sep/21 23:20,,2.4.5,"After upgrade fro 2.3.x to 2.4.x, we noticed that the behavior of the shell's {{load}} command has changed. Given a file of commands, i.e. {noformat} $ echo 'list' > /tmp/file {noformat} 2.3.x: {noformat} $ hbase shell hbase(main):001:0> load '/tmp/file' TABLE TestTable 1 row(s) Took 0.3076 seconds => true hbase(main):002:0> {noformat} branch-2.4: {noformat} $ hbase shell hbase:001:0> load '/tmp/file' Traceback (most recent call last): NameError (undefined local variable or method `list' for main:Object) {noformat}" Balancer run is improperly triggered by accuracy error of double comparison,13403207,Resolved,Major,Fixed,24/Sep/21 19:09,26/Sep/21 15:49,,"{code:java} protected synchronized boolean areSomeRegionReplicasColocated(Cluster c) { regionReplicaHostCostFunction.init(c); if (regionReplicaHostCostFunction.cost() > 0) { return true; } regionReplicaRackCostFunction.init(c); if (regionReplicaRackCostFunction.cost() > 0) { return true; } {code} The values are in double data type. Balancer could get stuck in constant runs and unnecessary moves. {code:java} 2021-09-24 12:02:41,943 INFO org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer: Running balancer because at least one server hosts replicas of the same region. 2021-09-24 12:01:42,878 INFO org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer: Finished computing new moving plan. Computation took 2400001 ms to try 3048341 different iterations.  Found a solution that moves 81 regions; Going from a computed imbalance of 1.7429830473781883E-4 to a new imbalance of 1.6169961756947032E-4.  {code}  we should use COST_EPSILON instead of 0 for double comparison.    " Backport backup/restore to branch-2,13403628,Open,Major,,27/Sep/21 17:35,,,"I was discussing this great feature with [~rda3mon] on Slack. His company is using this on their fork of hbase 2.1. We're working on upgrading to 2.4 now, and have our own home grown backup/restore system which is not as sophisticated as the native solution. If this solution was backported to branch-2, we would strongly consider adopting it as we finish up our upgrade. It looks like this was originally cut from 2.0 due to release timeline pressures: https://issues.apache.org/jira/browse/HBASE-19407, and now suffers from a lack of community support. This might make sense since it only exists in 3.x, which is not yet released. It would be great to backport this to branch-2 so that it reach a wider audience and adoption" Fix TestHTableTracing.testTableClose for nightly build of branch-2,13403595,Resolved,Major,Fixed,27/Sep/21 16:08,28/Sep/21 16:27,2.5.0,"after merging HBASE-26141, sometime isn't right with the last testTableClose when we close the table and the connection, need to figure out why it's not working in the unit test with the jdk8 and hadoop 3 profile https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/351/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/ https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/352/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/ {code} [ERROR] org.apache.hadoop.hbase.client.TestHTableTracing.testTableClose Time elapsed: 0.001 s <<< ERROR! java.lang.IllegalStateException: GlobalOpenTelemetry.set has already been called. GlobalOpenTelemetry.set must be called only once before any calls to GlobalOpenTelemetry.get. If you are using the OpenTelemetrySdk, use OpenTelemetrySdkBuilder.buildAndRegisterGlobal instead. Previous invocation set to cause of this exception. at io.opentelemetry.api.GlobalOpenTelemetry.set(GlobalOpenTelemetry.java:83) at io.opentelemetry.sdk.testing.junit4.OpenTelemetryRule.before(OpenTelemetryRule.java:95) at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.Throwable at io.opentelemetry.api.GlobalOpenTelemetry.set(GlobalOpenTelemetry.java:91) at io.opentelemetry.api.GlobalOpenTelemetry.get(GlobalOpenTelemetry.java:61) at io.opentelemetry.api.GlobalOpenTelemetry.getTracer(GlobalOpenTelemetry.java:110) at org.apache.hadoop.hbase.trace.TraceUtil.getGlobalTracer(TraceUtil.java:71) at org.apache.hadoop.hbase.trace.TraceUtil.createSpan(TraceUtil.java:95) at org.apache.hadoop.hbase.trace.TraceUtil.createSpan(TraceUtil.java:78) at org.apache.hadoop.hbase.trace.TraceUtil.lambda$trace$1(TraceUtil.java:176) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:180) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:176) at org.apache.hadoop.hbase.client.ConnectionImplementation.close(ConnectionImplementation.java:2110) at org.apache.hadoop.hbase.client.ConnectionImplementation.finalize(ConnectionImplementation.java:2149) at java.lang.System$2.invokeFinalize(System.java:1273) at java.lang.ref.Finalizer.runFinalizer(Finalizer.java:102) at java.lang.ref.Finalizer.access$100(Finalizer.java:34) at java.lang.ref.Finalizer$FinalizerThread.run(Finalizer.java:217) {code}" Use reservoir sampling when selecting bootstrap nodes,13403041,Resolved,Major,Fixed,24/Sep/21 03:47,28/Sep/21 15:44,,"In the current implementation, we need to copy all the region servers out to a new array list, shuffle the list, and then get the first several elements. We could use reservoir sampling to reduce the overhead here." OOME in VerifyReplication for the table contains rows with 10M+ cells,13398192,Resolved,Major,Fixed,30/Aug/21 10:22,28/Sep/21 15:45,,"We have a table that contains rows with 10M+ cells. When we run VerifyReplication for that table, we got OOME. VerifyReplication cannot be complete without OOME even though we provide 31GB heap for each mapper despite of RS can handle such get request. {code:java} org.apache.hadoop.mapred.YarnChild: Error running child : java.lang.OutOfMemoryError at java.lang.AbstractStringBuilder.hugeCapacity(AbstractStringBuilder.java:161) at java.lang.AbstractStringBuilder.newCapacity(AbstractStringBuilder.java:155) at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:125) at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448) at java.lang.StringBuilder.append(StringBuilder.java:136) at org.apache.hadoop.hbase.client.Result.compareResults(Result.java:844) at org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier.map(VerifyReplication.java:184) at org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier.map(VerifyReplication.java:95) at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:146) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:787) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:341) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158) {code} The interesting thing is always failing at AbstractStringBuilder.hugeCapacity(AbstractStringBuilder.java:161) in Result.compareResults. This is an application-side OOME and caused by the max size of Java array, so we cannot avoid this error whatever heap size we use. {code:java} private int hugeCapacity(int minCapacity) { if (Integer.MAX_VALUE - minCapacity < 0) { // overflow throw new OutOfMemoryError(); } return (minCapacity > MAX_ARRAY_SIZE) ? minCapacity : MAX_ARRAY_SIZE; } {code} When we see Result.compareResults, it generates a string representation of all cells in 2 results for the exception message. This could be a very large string despite cells in the result could consist from multiple byte arrays and are well optimized in the heap. (Repeated rowkeys in string, 4 chars for 1 byte if it cannot be represented by ascii char, long timestamp(8 bytes) vs string timestamp(13 bytes so far), and so on.) {code:java} public static void compareResults(Result res1, Result res2) throws Exception { if (res2 == null) { throw new Exception(""There wasn't enough rows, we stopped at "" + Bytes.toStringBinary(res1.getRow())); } if (res1.size() != res2.size()) { throw new Exception(""This row doesn't have the same number of KVs: "" + res1.toString() + "" compared to "" + res2.toString()); } Cell[] ourKVs = res1.rawCells(); Cell[] replicatedKVs = res2.rawCells(); for (int i = 0; i < res1.size(); i++) { if (!ourKVs[i].equals(replicatedKVs[i]) || !CellUtil.matchingValue(ourKVs[i], replicatedKVs[i]) || !CellUtil.matchingTags(ourKVs[i], replicatedKVs[i])) { throw new Exception(""This result was different: "" + res1.toString() + "" compared to "" + res2.toString()); } } } {code} In VerifyReplication, the exception thrown is never used. So this message is useless and a white elephant for VerifyReplication and us. Can we provide a version that produces lightweight message (or returns boolean instead of exception, but I think it's confusing similar method that returns boolean and another throws exception)? (Such hot row can have mutations often and be considered as inconsistent due to timing issues, so difficult to avoid this OOME by just a luck) {code:java} try { Result.compareResults(value, currentCompareRowInPeerTable); context.getCounter(Counters.GOODROWS).increment(1); if (verbose) { LOG.info(""Good row key: "" + delimiter + Bytes.toStringBinary(value.getRow()) + delimiter); } } catch (Exception e) { logFailRowAndIncreaseCounter(context, Counters.CONTENT_DIFFERENT_ROWS, value); } try { Result sourceResult = sourceTable.get(new Get(row.getRow())); Result replicatedResult = replicatedTable.get(new Get(row.getRow())); Result.compareResults(sourceResult, replicatedResult); if (!sourceResult.isEmpty()) { context.getCounter(Counters.GOODROWS).increment(1); if (verbose) { LOG.info(""Good row key (with recompare): "" + delimiter + Bytes.toStringBinary(row.getRow()) + delimiter); } } return; } catch (Exception e) { LOG.error(""recompare fail after sleep, rowkey="" + delimiter + Bytes.toStringBinary(row.getRow()) + delimiter); } {code} VerifyReplication with the patch that changes the message to include rowkey only can handle our table without OOME and even smaller heap." Recovered ReplicationSource not terminated,13404059,Open,Major,,29/Sep/21 12:18,,1.2.6,"Recovered ReplicationSource not terminated after replicated all wal. after all task done, it just remove source，but does not terminate it. so some resources(such as zk connection)  in replication endpoint leaks. {code:java} //代码占位符 if (replicationQueueInfo.isQueueRecovered()) { // use synchronize to make sure one last thread will clean the queue synchronized (workerThreads) { Threads.sleep(100);// wait a short while for other worker thread to fully exit boolean allOtherTaskDone = true; for (ReplicationSourceWorkerThread worker : workerThreads.values()) { if (!worker.equals(this) && worker.isAlive()) { allOtherTaskDone = false; break; } } if (allOtherTaskDone) { manager.closeRecoveredQueue(this.source); LOG.info(""Finished recovering queue "" + peerClusterZnode + "" with the following stats: "" + getStats()); } } }{code}" "Due to many procedures reload from master:store, hmaster takes too much time to initialize",13403694,Open,Major,,28/Sep/21 03:35,,2.3.5,"      when the hbase restart, we found hmaster takes much time to initialize. we add some logs for jars and found it's stuck in reloading procedure form master:store in ProcedureExecutor's init method   {panel:title=1. the ProcedureExecutor logs only have} 2021-09-24 11:22:13 [master/fx-hd-sc-hbase-backup-0:16000:becomeActiveMaster] INFO org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(569) -Starting 30 core workers (bigger of cpus/4 or 16) with max (burst) worker count=300 2021-09-24 11:22:13 [master/fx-hd-sc-hbase-backup-0:16000:becomeActiveMaster] INFO org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(589) -Recovered RegionProcedureStore lease in 1 msec and don't have logs for load: [https://github.com/apache/hbase/blob/cbebf85b3cfefc443ac8592908e8a6e95b020611/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java#L602]   {panel} 2. we add some logs like that(org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore#load):   {code:java} // code placeholder loader.setMaxProcId(maxProcId); LOG.info(""there are {} procedures load from master:store"", procs.size()); ProcedureTree tree = ProcedureTree.build(procs); loader.load(tree.getValidProcs()); loader.handleCorrupted(tree.getCorruptedProcs()); {code} and grep log found that: 2021-09-24 11:23:16 [master/fx-hd-sc-hbase-backup-0:16000:becomeActiveMaster] INFO org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.load(294) -there are 3357861 procedures load form master:store 3. we add some logs (org.apache.hadoop.hbase.procedure2.ProcedureExecutor#restoreLocks())  {code:java} // code placeholder private void restoreLocks() { Set restored = new HashSet<>(); Deque> stack = new ArrayDeque<>(); AtomicInteger num = new AtomicInteger(); procedures.values().forEach(proc -> { for (;;) { LOG.info(""this is num {}"", num.incrementAndGet()); if (restored.contains(proc.getProcId())) { restoreLocks(stack, restored); return; } if (!proc.hasParent()) { restoreLock(proc, restored); restoreLocks(stack, restored); return; } stack.push(proc); proc = procedures.get(proc.getParentProcId()); } }); } {code} found when the num added to 16W， it's spended about 20 minutes. 4. By viewing the metadata of the hfile, the Earliest time is 28th June (the picture is attachments ). 5. review the souce code, the master:store ttl is default value（HConstants.FOREVER） [https://github.com/apache/hbase/blob/fd3fdc08d1cd43eb3432a1a70d31c3aece6ecabe/hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java#L82] and the scan for maste:store don't have filter too. [https://github.com/apache/hbase/blob/cbebf85b3cfefc443ac8592908e8a6e95b020611/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L263]   so we have some questions: 1. Is it reasonable to set master:store ttl is HConstants.FOREVER? 2. can we keep a small number for master:store by deleting some historical procedure? Look forward to your reply! thanks!        " Add tracing support for HTable and sync connection on branch-2,13392025,Resolved,Major,Fixed,27/Jul/21 03:59,25/Sep/21 23:46,2.5.0,"Split from HBASE-25853, the original change of HBASE-22120 does not include tracing support for sync client, if we decide to support it in branch-2, we will need to come up our own solution. this change should cover mainly the classes of HTable, ConnectionImplementation, and HRegionLocator * RPC and IPC tracing supported by HBASE-26125 * WAL tracing supported by HBASE-26131" Improve data structure and algorithm for BalanceClusterState to improve computation speed for large cluster,13393987,Resolved,Major,Fixed,07/Aug/21 00:16,25/Sep/21 13:50,,"With ~800 node and ~500 regions per node on our large production cluster, balancer cannot complete within hours even after we just add 2% servers after maintenance.  The unit tests with larger number of regions are taking longer and longer with changes to balancer with recent changes too, evident with the increment of the time limit recent PR's included. It is time to replace some of the data structure for better time complexity including: int[][] regionsPerServer; // serverIndex -> region list int[][] regionsPerHost; // hostIndex -> list of regions int[][] regionsPerRack; // rackIndex -> region list // serverIndex -> sorted list of regions by primary region index ArrayList> primariesOfRegionsPerServer; // hostIndex -> sorted list of regions by primary region index int[][] primariesOfRegionsPerHost; // rackIndex -> sorted list of regions by primary region index int[][] primariesOfRegionsPerRack; Areas of algorithm improvement include: # O(n ) to O(1) time to  lookup or update per server/host/rack for every move test iteration.(n = number of regions per server/host/rack). # O(n ) to O(1) time for reserse lookup of region index from primary index. # Recomputation of primaryRegionCountSkewCostFunction reduced from O(n ) to O(1)  " Improve Performance of HBCK when specifying a subset of tables,13399864,Resolved,Major,Fixed,07/Sep/21 23:08,24/Sep/21 21:39,hbase-operator-tools-1.1.0,"On clusters with a large number of tables, listing all table directories from the filesystem can take a lot of time (especially on S3). We should avoid listing all the tables if we pass in a subset of the tables" the initialization of master could not be completed when hbase:namesapce' region is not online,13401496,Open,Major,,16/Sep/21 02:50,,2.3.5,"hbase cluster unexpected shuts down and then restart, we sometimes find the master can't not initialize becouse of that it is stuck in isRegionOnline methad for Hbase:namespace。we found the master and meta table think the hbase:namespace region is online but it's regionserver is dead by viewing logs of master，isRegionOnline print log for this every one minute and don't do Nothing, I think we can remove record form assignmentManager's RegionState and assign hbase:namespace to another regionserver, in order to make hbase cluster recover without human intervention。i came to ask your advice, what do you think? {panel:title=the logs of master} 2021-09-02 18:32:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. 2021-09-02 18:33:01 [master/fx-hd-sc-hbase-master-0:16000.Chore.1] INFO org.apache.hadoop.hbase.ChoreService.scheduleChore(157) -Chore ScheduledChore name=fx-hd-sc-hbase-master-0.fx-hd-sc.fx-ns.svc.cluster.xjht,16000,1630401705440-ClusterStatusChore, period=60000, unit=MILLISECONDS is enabled. 2021-09-02 18:33:01 [master/fx-hd-sc-hbase-master-0:16000.Chore.1] INFO org.apache.hadoop.hbase.ScheduledChore.run(172) -Chore: fx-hd-sc-hbase-master-0.fx-hd-sc.fx-ns.svc.cluster.xjht,16000,1630401705440-ClusterStatusChore missed its start time 2021-09-02 18:33:41 [ProcExecTimeout] INFO org.apache.hadoop.hbase.master.assignment.AssignmentManager.periodicExecute(1334) -Found 0 OPEN regions on dead servers and 177568 OPEN regions on unknown servers 2021-09-02 18:33:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. 2021-09-02 18:34:31 [qtp780802740-4192] INFO http.requests.master.write(60) -15.22.70.168 - - [02/Sep/2021:10:34:31 +0000] ""GET //15.22.70.168:1601/master-status HTTP/1.1"" 200 54124  2021-09-02 18:34:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. 2021-09-02 18:34:51 [qtp780802740-4202] INFO http.requests.master.write(60) -15.22.70.168 - - [02/Sep/2021:10:34:51 +0000] ""GET //15.22.70.168:1601/master-status HTTP/1.1"" 200 54122  2021-09-02 18:35:41 [ProcExecTimeout] INFO org.apache.hadoop.hbase.master.assignment.AssignmentManager.periodicExecute(1334) -Found 0 OPEN regions on dead servers and 177568 OPEN regions on unknown servers 2021-09-02 18:35:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. 2021-09-02 18:36:20 [qtp780802740-4192] INFO http.requests.master.write(60) -15.22.70.168 - - [02/Sep/2021:10:36:20 +0000] ""GET //15.22.70.168:1601/master-status HTTP/1.1"" 200 54122  2021-09-02 18:36:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. 2021-09-02 18:36:57 [RSProcedureDispatcher-pool4-t23] WARN org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher.scheduleForRetry(323) -request to fx-hd-sc-hbase-slave-15.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1630405458162 failed due to org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to fx-hd-sc-hbase-slave-15.fx-hd-sc.fx-ns.svc.cluster.xjht/172.49.9.38:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=6192,methodName=ExecuteProcedures], waitTime=600008, rpcTimeout=600000, try=7, retrying... 2021-09-02 18:37:42 [ProcExecTimeout] INFO org.apache.hadoop.hbase.master.assignment.AssignmentManager.periodicExecute(1334) -Found 0 OPEN regions on dead servers and 177568 OPEN regions on unknown servers 2021-09-02 18:37:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. 2021-09-02 18:38:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined. 2021-09-02 18:38:49 [zk-event-processor-pool1-t1] INFO org.apache.hadoop.hbase.security.token.ZKSecretWatcher.nodeDeleted(94) -Node deleted id=168 2021-09-02 18:39:42 [ProcExecTimeout] INFO org.apache.hadoop.hbase.master.assignment.AssignmentManager.periodicExecute(1334) -Found 0 OPEN regions on dead servers and 177568 OPEN regions on unknown servers 2021-09-02 18:39:46 [master/fx-hd-sc-hbase-master-0:16000:becomeActiveMaster] WARN org.apache.hadoop.hbase.master.HMaster.isRegionOnline(1229) -hbase:namespace,,1477036226969.c0b2d4af686dc6b1c98dd9c866fe7607. is NOT online; state=\{c0b2d4af686dc6b1c98dd9c866fe7607 state=OPEN, ts=1630577738198, server=fx-hd-sc-hbase-slave-10.fx-hd-sc.fx-ns.svc.cluster.xjht,16020,1628591903870}; ServerCrashProcedures=false. Master startup cannot progress, in holding-pattern until region onlined.   {panel:title=the code of master} https://github.com/apache/hbase/blob/fd3fdc08d1cd43eb3432a1a70d31c3aece6ecabe/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1214 {panel}   {panel}  " Create an option to reintroduce BlockCache to mapreduce job,13400305,Resolved,Major,Fixed,09/Sep/21 18:49,22/Sep/21 16:45,2.4.6,"In HBASE-21498 (see [this commit|https://github.com/apache/hbase/commit/27a0f205c52f83fe7500ee2ffc6cf6582f565a63#diff-8a3e39e6df1afe47811fc17702da598fe0d80496d66e579bea4bd224c6d8da03R218], it change the behavior that only region server can initialize on-heap BlockCache/LruBlockCache, this should be the right change for HMaster. Other downstream dependency that uses getScanner from a file-based region and read HStore/HFile lost the BlockCache for caching INDEX/LEAF_INDEX (at least still a problem with HBase-2.4) after this change (it worked before) and caused performance impact with 2x slower. One way to bring back the performance is to allow non-RS and non-HMaster can use a compact version of blockcache with smaller memory and less hbase internal configuration. Or if we can find a way to cache or skip reading the same {{LEAF_INDEX}} when scanning the DATA block with HFile. " Revisit the usage of MetaTableLocator when HRegionServer.TEST_SKIP_REPORTING_TRANSITION is true,13401697,Resolved,Major,Fixed,16/Sep/21 16:10,21/Sep/21 16:28,,"Since now we can not assign meta without HMaster, the code here is already meaningless. We should revisit the usage and see if we can remove it." Remove MetaTableLocator usages in non-migration code,13401422,Resolved,Major,Fixed,15/Sep/21 15:24,21/Sep/21 15:59,,"After HBASE-26193, we store the meta region location in master local region and zookeeper is just a mirror, but in our code base, sometimes we still get the location from zookeeper. We should change them all to use the data from master local region, i.e, by reading from meta location cache or assignment manager." Allow HashTable/SyncTable to perform rawScan when comparing cells,13400427,Resolved,Major,Fixed,10/Sep/21 10:37,10/Sep/21 16:17,2.2.7,"We had noticed some of our customers having inconsistent results when running HashTable/SyncTable in scenarios described previously by HBASE-21596. As discussed on HBASE-21596, one alternative to avoid such inconsistencies, is to set 'NEW_VERSION_BEHAVIOUR' introduced by HBASE-15968. That, however, does rely on the order of operations, which can't be guaranteed when standard replication (not serial replication) is being used, which is the case on the majority of our customers. A possible workaround is to place delete markers to every single cell version returned on a raw scan, and setting a high value to the scan number of versions to be read." TestTableMapReduceUtil failure in branch-2,13400299,Resolved,Major,Fixed,09/Sep/21 17:46,13/Sep/21 03:10,,"  {code:java} [ERROR] org.apache.hadoop.hbase.mapreduce.TestTableMapReduceUtil.testInitCredentialsForCluster3  Time elapsed: 8.122 s  <<< ERROR! org.apache.hadoop.security.KerberosAuthException: Login failure for user: hsun/localhost@EXAMPLE.COM from keytab /Users/hsun/work/hbase-hs/hbase-1/hbase-mapreduce/target/test-data/b12f4926-d8ec-1129-0101-1ba76e65f3c2/keytab javax.security.auth.login.LoginException: java.lang.IllegalArgumentException: Illegal principal name hsun/localhost@EXAMPLE.COM: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to hsun/localhost@EXAMPLE.COM at org.apache.hadoop.security.UserGroupInformation.loginUserFromKeytab(UserGroupInformation.java:1104) at org.apache.hadoop.hbase.mapreduce.TestTableMapReduceUtil.testInitCredentialsForCluster3(TestTableMapReduceUtil.java:233) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) Caused by: javax.security.auth.login.LoginException: java.lang.IllegalArgumentException: Illegal principal name hsun/localhost@EXAMPLE.COM: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to hsun/localhost@EXAMPLE.COM at org.apache.hadoop.security.UserGroupInformation$HadoopLoginModule.commit(UserGroupInformation.java:224) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at javax.security.auth.login.LoginContext.invoke(LoginContext.java:755) at javax.security.auth.login.LoginContext.access$000(LoginContext.java:195) at javax.security.auth.login.LoginContext$4.run(LoginContext.java:682) at javax.security.auth.login.LoginContext$4.run(LoginContext.java:680) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:680) at javax.security.auth.login.LoginContext.login(LoginContext.java:588) at org.apache.hadoop.security.UserGroupInformation.loginUserFromKeytab(UserGroupInformation.java:1095) ... 25 more Caused by: java.lang.IllegalArgumentException: Illegal principal name hsun/localhost@EXAMPLE.COM: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to hsun/localhost@EXAMPLE.COM at org.apache.hadoop.security.User.(User.java:50) at org.apache.hadoop.security.User.(User.java:43) at org.apache.hadoop.security.UserGroupInformation$HadoopLoginModule.commit(UserGroupInformation.java:222) ... 37 more Caused by: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to hsun/localhost@EXAMPLE.COM at org.apache.hadoop.security.authentication.util.KerberosName.getShortName(KerberosName.java:401) at org.apache.hadoop.security.User.(User.java:48) ... 39 more {code}  " Start an in process HRegionServer in maintenance mode,13397858,Resolved,Major,Fixed,27/Aug/21 15:59,03/Sep/21 09:08,,"So HMaster do not need to carry regions in maintenance mode, then we can finally decouple HMaster and HRegionServer." Merger of backup:system table with hbase:meta table,13400633,Open,Major,,12/Sep/21 13:48,,,To Be filled Add an option to use region location from meta table in TableSnapshotInputFormat,13399301,Resolved,Major,Fixed,03/Sep/21 16:40,09/Sep/21 17:55,2.3.6,"TableSnapshotInputFormat currently calculates block locality of a region to decide the best location to run the task. While this works for a small scale table snapshot, we found that for a table snapshot with many regions, the locality calculation takes too much time.  In the case of a table with high locality, we can use region location from meta table to decide a snapshot region's location. Add an option to support it." Add support to run balancer overriding current config,13393767,Open,Major,,05/Aug/21 19:41,,,"At times we want a one-time run for balancer with specific aggressive configs such as recovering from a failure of half cluster. Currently some config are loaded dynamically but some don't. And it could be error prone when we try to restore the configs. With a dry run feature coming, we want to let user run a dry run with the overriding config to choose the config and then run it. The implementation becomes more straightforward if we allow overidding configs for both config and actual runs." Fix some obvious bugs in MultiByteBuff.put,13395030,Resolved,Major,Fixed,13/Aug/21 06:41,07/Sep/21 15:58,2.4.5,"MultiByteBuff.put(int destOffset, ByteBuff src, int srcOffset, int length) has some obvious bugs: * It seems mix up {{items}} in {{src}} {{MutiByteBuff}} and {{items}} in the {{dest}} {{MultiByteBuff}} , just as line 749 and line 754 illustrated. The logic is only right when src {{ByteBuff}} is also a {{MultiByteBuff}} and byte size of every {{ByteBuffer}} in {{src.items}} has exactly the same size as every {{ByteBuffer}} in the {{dest.items}},but looking the usage of this method in the hbase project, obviously the assumption is not right. {code:java} 746 public MultiByteBuff put(int offset, ByteBuff src, int srcOffset, int length) { 747 checkRefCount(); 748 int destItemIndex = getItemIndex(offset); 749 int srcItemIndex = getItemIndex(srcOffset); 750 ByteBuffer destItem = this.items[destItemIndex]; 751 offset = offset - this.itemBeginPos[destItemIndex]; 752 753 ByteBuffer srcItem = getItemByteBuffer(src, srcItemIndex); 754 srcOffset = srcOffset - this.itemBeginPos[srcItemIndex]; ... {code} * If src is {{SingleByteBuff}} and its remaining space is fewer than length，when remaining space is exhausted, this {{MultiByteBuff.put}} method would not throw any exception and continue to put src {{ByteBuff}} once again from position 0 because following {{MultiByteBuff.getItemByteBuffer}} ignores index paramter for {{SingleByteBuff}} . Obviously, this behavior is much strange and unexpected. {code:java} private static ByteBuffer getItemByteBuffer(ByteBuff buf, int index) { return (buf instanceof SingleByteBuff) ? buf.nioByteBuffers()[0] : ((MultiByteBuff) buf).items[index]; } {code} Why seems tests is OK with too much bugs? Because in normal cases, we just use {{SingleByteBuff}} not {{MultiByteBuff}}." updateRSGroupConfig operation should be authorized by AccessController ,13397642,Resolved,Major,Fixed,26/Aug/21 19:24,07/Sep/21 14:18,,Currently there is no ACL check for Admin#updateRSGroupConfig() operation. AccessController should implement MasterObserver#preUpdateRSGroupConfig(). Add an updateConfiguration rpc method in MasterService,13397861,Resolved,Major,Later,27/Aug/21 16:18,28/Aug/21 14:20,,"Concurrently it is only in AdminService which is for region server only, but we still need to have the updateConfiguration method to update the configuration for HMaster." Expose some IA.LimitedPrivate interface in TestingHBaseCluster,13392772,Resolved,Major,Fixed,30/Jul/21 14:04,02/Sep/21 09:18,,"For example, the coprocessor related interfaces such as Region, Store, etc. And for tags, since there is no way to get it at client side, we need to expose some server side interfaces to allow users get them." Backport HBASE-25811 for fixing nightly tests with error of `NoClassDefFoundError: io/opentelemetry/api/GlobalOpenTelemetry`,13393576,Resolved,Major,Fixed,04/Aug/21 21:04,27/Aug/21 16:12,2.5.0,"see nightly error [https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/313/artifact/output-integration/hadoop-2/mr-importtsv.err/*view*/] {code:java} Caused by: java.lang.NoClassDefFoundError: io/opentelemetry/api/GlobalOpenTelemetry at org.apache.hadoop.hbase.trace.TraceUtil.getGlobalTracer(TraceUtil.java:33) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:398) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:328) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$200(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:589) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$BlockingStub.get(ClientProtos.java:45761) at org.apache.hadoop.hbase.client.ClientServiceCallable.doGet(ClientServiceCallable.java:50) at org.apache.hadoop.hbase.client.HTable$1.rpcCall(HTable.java:377) at org.apache.hadoop.hbase.client.HTable$1.rpcCall(HTable.java:372) at org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:108) ... 32 more Caused by: java.lang.ClassNotFoundException: io.opentelemetry.api.GlobalOpenTelemetry at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:418) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355) at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ... 43 more {code}" "Backport HBASE-25778 ""The tracinig implementation for AsyncConnectionImpl.getHbck is incorrect"" to branch-2",13392022,Resolved,Major,Fixed,27/Jul/21 03:40,26/Aug/21 18:29,2.5.0,"17/17 commits of HBASE-22120, original commit [{{f36e153}}|https://github.com/apache/hbase/commit/f36e1539648bbaee84c626fd54d1605baebf3c5a]" "Backport HBASE-23762 ""Add documentation on how to enable and view tracing with OpenTelemetry"" to branch-2",13392021,Resolved,Major,Fixed,27/Jul/21 03:39,26/Aug/21 16:43,2.5.0,"16/17 commits of HBASE-22120, original commit [{{be4503d}}|https://github.com/apache/hbase/commit/be4503d9f82f044fbfce21c8a42d0b1684607238]" "Backport HBASE-25733 ""Upgrade opentelemetry to 1.0.1"" to branch-2",13392020,Resolved,Major,Fixed,27/Jul/21 03:39,26/Aug/21 02:32,2.5.0,"15/17 commits of HBASE-22120, original commit [{{b714889}}|https://github.com/apache/hbase/commit/b71488998970a3353086a34736ed1edab527f673]" "Backport HBASE-25732 ""Change the command line argument for tracing after upgrading opentelemtry to 1.0.0"" to branch-2",13392019,Resolved,Major,Fixed,27/Jul/21 03:39,25/Aug/21 16:02,2.5.0,"14/17 commits of HBASE-22120, original commit [{{8df9beb}}|https://github.com/apache/hbase/commit/8df9bebdd367d52a32b08c18a7cf4f9c2d712071]" "Backport HBASE-25723 ""Temporarily remove the trace support for RegionScanner.next"" to branch-2",13392018,Resolved,Major,Fixed,27/Jul/21 03:37,25/Aug/21 00:46,2.5.0,"13/17 commits of HBASE-22120, original commit [{{7f90c22}}|https://github.com/apache/hbase/commit/7f90c2201f6a17d2e2d031505c35ae7c2b1ed7ea]" "Backport HBASE-25616 ""Upgrade opentelemetry to 1.0.0"" to branch-2",13392017,Resolved,Major,Fixed,27/Jul/21 03:37,24/Aug/21 21:09,2.5.0,"12/17 commits of HBASE-22120, original commits [{{8399293}}|https://github.com/apache/hbase/commit/8399293e21127df3ffdcb757242e4cb5964c7e99]" "Backport HBASE-25617 ""Revisit the span names"" to branch-2",13392016,Resolved,Major,Fixed,27/Jul/21 03:37,24/Aug/21 04:05,2.5.0,"_11/17 commits of HBASE-22120, original commit [{{8d68f8c}}|https://github.com/apache/hbase/commit/8d68f8cd1c8613be1b499eaa99f46806b2743294]_" "Backport HBASE-25591 ""Upgrade opentelemetry to 0.17.1"" to branch-2",13392015,Resolved,Major,Fixed,27/Jul/21 03:37,23/Aug/21 15:57,2.5.0,"10/17 commits of HBASE-22120, original commit f6ff519dd0c7fe0e3ae3c175eefee27a26a065a4" "Backport HBASE-25535 ""Set span kind to CLIENT in AbstractRpcClient"" to branch-2",13392014,Resolved,Major,Fixed,27/Jul/21 03:37,20/Aug/21 03:14,2.5.0,"9/17 commits of HBASE-22120, original commit [{{bb8c496}}|https://github.com/apache/hbase/commit/bb8c4967f8ce2c89ebaf1ddc5d8a1bf55f1e20d3]" "Backport HBASE-25484 ""Add trace support for WAL sync"" to branch-2",13392012,Resolved,Major,Fixed,27/Jul/21 03:37,19/Aug/21 16:16,2.5.0,"8/17 commits of HBASE-22120, original commit 2be2c63f0d3917a243b74af9754cbfc805b858d1" "Backport HBASE-25455 ""Add trace support for HRegion read/write operation"" to branch-2",13392010,Resolved,Major,Fixed,27/Jul/21 03:36,18/Aug/21 05:38,2.5.0,"7/17 commits of HBASE-22120, original commit 03e12bfa4ad62ecc6eee6a2c68d431bea2d5c473" "Backport HBASE-25481 ""Add host and port attribute when tracing rpc call at client side"" to branch-2",13392009,Resolved,Major,Fixed,27/Jul/21 03:36,17/Aug/21 16:25,2.5.0,"6/17 commits of HBASE-22120, original commit ae2c62ffaad5ba4c976b0a79c10a365edf2844fd" "Backport HBASE-25454 ""Add trace support for connection registry"" to branch-2",13392007,Resolved,Major,Fixed,27/Jul/21 03:36,17/Aug/21 00:30,2.5.0,"5/17 commits of HBASE-22120, original commit [dcb78bd4bda4a4ae13d863df8aec266031e5bc93|https://github.com/apache/hbase/commit/dcb78bd4bda4a4ae13d863df8aec266031e5bc93] and merged conflicts after rebasing on HBASE-26150 (branch-2 commit [620806e3fb27947fa3b36f24921060e328f4b39d|https://github.com/apache/hbase/commit/620806e3fb27947fa3b36f24921060e328f4b39d]) with commit [63d4970de451bf234f2ddbda949995b1420e525b|https://github.com/apache/hbase/commit/63d4970de451bf234f2ddbda949995b1420e525b]" "Backport HBASE-23898 ""Add trace support for simple apis in async client"" to branch-2",13392006,Resolved,Major,Fixed,27/Jul/21 03:36,05/Aug/21 03:34,2.5.0,"4/17 commits of HBASE-22120, original commit https://github.com/apache/hbase/commit/805b2ae2ad0f6325515d46043ff01e4e2c7a9f59" "Backport HBASE-25424 ""Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk"" to branch-2",13392004,Resolved,Major,Fixed,27/Jul/21 03:35,03/Aug/21 23:09,,"[3/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit of HBASE-25424 was [https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d]" "Backport HBASE-25373 ""Remove HTrace completely in code base and try to make use of OpenTelemetry"" to branch-2",13392002,Resolved,Major,Fixed,27/Jul/21 03:34,29/Jul/21 20:09,2.3.5,"[1/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], backporting HBASE-25373 Remove HTrace completely in code base and try to make use of OpenTelemetry We will need to remove some unimplemented tracing in AsyncRequestFutureImpl#getNewMultiActionRunnable that master branch does not have it and also upstream in master does not implement TraceRunnable with OpenTelemetry plugin the original commit on master is https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef " TableMRUtil#initCredentialsForCluster should use specified conf for UserProvider,13395641,Resolved,Major,Fixed,17/Aug/21 09:00,01/Sep/21 12:58,,"{code:java} /** * Obtain an authentication token, for the specified cluster, on behalf of the current user * and add it to the credentials for the given map reduce job. * * @param job The job that requires the permission. * @param conf The configuration to use in connecting to the peer cluster * @throws IOException When the authentication token cannot be obtained. */ public static void initCredentialsForCluster(Job job, Configuration conf) throws IOException { UserProvider userProvider = UserProvider.instantiate(job.getConfiguration()); if (userProvider.isHBaseSecurityEnabled()) { try { Connection peerConn = ConnectionFactory.createConnection(conf); try { TokenUtil.addTokenForJob(peerConn, userProvider.getCurrent(), job); } finally { peerConn.close(); } } catch (InterruptedException e) { LOG.info(""Interrupted obtaining user authentication token""); Thread.interrupted(); } } } {code} TableMapReduceUtil#initCredentialsForCluster uses job's configuration instead of conf in argument for UserProvider. This causes that token is not obtained for secure cluster in case of job's configuration contains hbase.security.authentication=simple. Because userProvider.isHBaseSecurityEnabled() checks that hbase.security.authentication is kerberos. If conf is configured for secure cluster, hbase.security.authentication is kerberos and it's natural to use conf for UserProvider instead of job's configuration in this method. " Avoid trim the error stack trace when running UT with maven,13398477,Resolved,Major,Fixed,31/Aug/21 14:05,01/Sep/21 07:27,2.4.5,"When running HBase unit test with maven, if there is failed test，I always find that the error stack trace was trimmed, which make it is hard to locate the root cause. Just see the following stack trace as an example: {code:java} [INFO] Running org.apache.hadoop.hbase.regionserver.TestHStore [ERROR] Tests run: 32, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 34.516 s <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestHStore [ERROR] org.apache.hadoop.hbase.regionserver.TestHStore.testCompactingMemStoreWriteLargeCellAndSmallCellConcurrently Time elapsed: 0.44 s <<< FAILURE! java.lang.AssertionError at org.apache.hadoop.hbase.regionserver.TestHStore.doWriteTestLargeCellAndSmallCellConcurrently(TestHStore.java:1919) at org.apache.hadoop.hbase.regionserver.TestHStore.testCompactingMemStoreWriteLargeCellAndSmallCellConcurrently(TestHStore.java:1819) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) .... {code} There is no {{Assert}} in {{TestHStore.java:1919}}, the {{AssertionError}} is thrown by method called by {{TestHStore.doWriteTestLargeCellAndSmallCellConcurrently}}, the error stack trace which actually throws {{AssertionError}} is trimmed by {{maven-surefire-plugin}} because of the default setting, just see [trimStackTrace|http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace] . If I turned off the {{trimStackTrace}}, the whole stack trace is displayed, which is convenient to locate the root cause: {code:java} [ERROR] org.apache.hadoop.hbase.regionserver.TestHStore.testCompactingMemStoreWriteLargeCellAndSmallCellConcurrently Time elapsed: 0.44 s <<< FAILURE! java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertTrue(Assert.java:53) at org.apache.hadoop.hbase.regionserver.TestHStore$MyCompactingMemStore3.flushInMemory(TestHStore.java:2267) at org.apache.hadoop.hbase.regionserver.CompactingMemStore.tryFlushInMemoryAndCompactingAsync(CompactingMemStore.java:460) at org.apache.hadoop.hbase.regionserver.CompactingMemStore.checkAndAddToActiveSize(CompactingMemStore.java:446) at org.apache.hadoop.hbase.regionserver.TestHStore$MyCompactingMemStore3.checkAndAddToActiveSize(TestHStore.java:2238) at org.apache.hadoop.hbase.regionserver.CompactingMemStore.preUpdate(CompactingMemStore.java:317) at org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:149) at org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:122) at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:730) at org.apache.hadoop.hbase.regionserver.TestHStore.doWriteTestLargeCellAndSmallCellConcurrently(TestHStore.java:1919) at org.apache.hadoop.hbase.regionserver.TestHStore.testCompactingMemStoreWriteLargeCellAndSmallCellConcurrently(TestHStore.java:1819) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ..... {code}" TestWALRecordReader#testWALRecordReaderActiveArchiveTolerance doesn't read archived WAL file. ,13398671,Open,Major,,01/Sep/21 13:05,,,"TestWALRecordReader#testWALRecordReaderActiveArchiveTolerance is testing the following scenario. 1. Create a new WAL file 2. Write 2 KVs to WAL file. 3. Close the WAL file. 4. Instantiate WALInputFormat#WALKeyRecordReader with the WAL created in step 1. 5. Read the first KV. 6. Archive the WAL file in oldWALs directory via rename operation. 7. Read the second KV. This will test that WALKeyRecordReader will encounter FNFE since the WAL file is not longer present in the original location and it will handle the FNFE by opening the WAL file from archived location. In step#7, the test is expecting that it will encounter FNFE and it will open a new reader but in reality, it is not encountering FNFE. I think the reason is, during rename operation, HDFS just changes the internal metadata for the file name. The InodeID, hdfs blocks and block locations remains the same. While reading the first KV, DFSInputStream caches all the HDFS blocks and location data so it doesn't have to go to namenode to re-resolve the file name. Cc [~zhangduo]" ServerTestHBaseCluster interface for testing coprocs,13391429,Open,Major,,22/Jul/21 19:48,,3.0.0-alpha-1,"The new TestingHBaseCluster introduced in HBASE-26080 provides a clean way for downstream developers writing features using the HBase client APIs to test their code. Its inner minicluster class, HBaseTestingUtil, was left unexposed with an interface audience of Phoenix, because coprocessors might need access to the internals of HBase itself to be tested. Occasionally, a developer outside of HBase and Phoenix might need the same access to the internals. One way to do this would be to introduce a new interface, ServerTestHBaseCluster, that extends TestingHBaseCluster and exposes the HBaseTestingUtil, with an interface audience of COPROC, REPLICATION (for custom endpoints), PHOENIX." conn.getBufferedMutator(tableName) leaks thread executors and other problems (for master branch),13390993,Resolved,Major,Fixed,20/Jul/21 20:13,30/Aug/21 17:24,3.0.0-alpha-1,This is same as HBASE-26088  but created separate ticket for master branch. Return incorrect result for a scan rpc call when readType switch from pread to stream,13398212,Open,Major,,30/Aug/21 12:05,,,"Scan's default readType is PREAD, and there is a readType transform from PREAD to STREAM when a long scan is executed. E.G. I ask for result of 'count table', and now it will return immediately before the RPC get real data because of this transform, so the result returned maybe incorrect. Although, we can explicitly use STREAM instead of PREAD to avoid this transform. I am still confused, how can we judge whether transform is called? How can I trust my result is real when we allow transform occur?" We could start RegionServerTracker before becoming active master,13398019,Resolved,Major,Fixed,29/Aug/21 13:02,30/Aug/21 04:23,,"The direct reason is that, after decoupling, HMaster does not extends HRegionServer, so we do not have RegionServerAddressTracker now, so for backup masters we do not have a way to get all the region server which means it can not serve as connection registry any more, so we need to find a way to let backup masters to also have a way to get the region server list. But in general, since we already have a class in HMaster which is used to track region servers, we'd better reuse it. And after this change, the backup masters could also be used as the fallback servers for getting region server list in HBASE-26220, which could also reduce the load of active master. And this could also speed up the active master start process as we could save one zookeeper scan when becoming active master." VerifyReplication should obtain token for peerQuorumAddress too,13395637,Resolved,Major,Fixed,17/Aug/21 08:42,26/Aug/21 10:07,2.3.6,"VerifyReplication accepts peerQuorumAddress itself via command parameter instead of getting it from peerid of source cluster. [https://github.com/apache/hbase/commit/b322d0a3e552dc228893408161fd3fb20f6b8bf1#diff-0307194efcf6a3ad4a4d73bd4b6ef34a9be5c436c8e970ca97fa146b2f0aa486] https://issues.apache.org/jira/browse/HBASE-21201  {code:java} if (peerId != null) { assert peerConfigPair != null; Configuration peerClusterConf = peerConfigPair.getSecond(); // Obtain the auth token from peer cluster TableMapReduceUtil.initCredentialsForCluster(job, peerClusterConf); } {code}  In this patch, credential for job is obtained when peerid is provided only. Thus we cannot get the benefit of HBASE-21201 for secure hbase cluster as a destination. {code:java} hbase VerifyReplication \ -D verifyrep.peer.hbase.regionserver.kerberos.principal=secure-hbase-b/_HOST@EXAMPLE.COM \ -D verifyrep.peer.hbase.master.kerberos.principal=secure-hbase-b/_HOST@EXAMPLE.COM \ ... \ secure-hbase-b-1.example.com,secure-hbase-b-2.example.com,secure-hbase-b-3.example.com:2181:/hbase-b \ table {code} Assume this execution, VerifyReplication should obtain token from secure-hbase-b-1.example.com,secure-hbase-b-2.example.com,secure-hbase-b-3.example.com:2181:/hbase-b using hbase.regionserver.kerberos.principal=secure-hbase-b/_HOST@EXAMPLE.COM and hbase.master.kerberos.principal=secure-hbase-b/_HOST@EXAMPLE.COM, so that VerifyReplication mapper can scan from the secure cluster B." Move HRegionServer.abort(String) to Abortable as a default method,13396465,Resolved,Major,Fixed,21/Aug/21 08:09,28/Aug/21 15:07,,"So after decouple HMaster and HRegionServer, we do not need to implement it again in HMaster." Forward port HBASE-26223 test code to branch-2.4+,13397636,Resolved,Major,Fixed,26/Aug/21 18:45,27/Aug/21 08:50,, Add heartbeat for ReplicationServer,13388565,Open,Major,,09/Jul/21 08:18,,3.0.0-alpha-1, The backup master status page should use ActiveMasterManager instead of MasterAddressTracker,13396464,Resolved,Major,Fixed,21/Aug/21 08:01,25/Aug/21 08:51,,"On master we already have ActiveMasterManager for tracking active master and backup masters, so we do not need to use MasterAddressTracker." Introduce a initial refresh interval for RpcConnectionRegistry,13394020,Resolved,Major,Fixed,07/Aug/21 12:42,25/Aug/21 11:03,,"So we can get the new list soon once we connect to the cluster. As end users could configure any nodes in a cluster as the initial bootstrap nodes, it is possible that different end users will configure the same machine which makes the machine over load. So we should have a shorter delay for the initial refresh, to let users quickly switch to the bootstrap nodes we want them to connect to." Make RpcConnection with transient/non-Singleton SaslClientAuthenticationProviders with repsecting the passing configuration object ,13397614,Open,Major,,26/Aug/21 17:02,,2.4.5,"When a RPC connection was created from any table connection (e.g. via {{ConnectionFactory.createConnection(conf)}}), the [SaslClientAuthenticationProviders|(https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java#L99-L101] that matches different authentication selector per-user/TOKEN as the [singleton object|https://github.com/apache/hbase/blob/735bcf85e9b59a71981babe2f5da51978d61d8d3/hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/SaslClientAuthenticationProviders.java#L72-L83] and reuses for any followup connection creation. If user want to create another connection with a different configuration key that the authentication selector may use, e.g. [if one want to switch between secure and non-secure connection|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/BuiltInProviderSelector.java#L109-L111], it cannot be done because of the cached singleton instance of AuthenticationProviders. the goal of this JIRA is to allow the RpcConnection and AuthenticationProviders align with whatever passing configuration object " Introduce a ConnectionRegistryEndpoint interface,13396462,Resolved,Major,Fixed,21/Aug/21 07:53,25/Aug/21 11:20,,So the special RegionServerRegistry could still be used after we make HMaster not extends HRegionServer. Refactor AnnotationReadingPriorityFunction,13396461,Resolved,Major,Fixed,21/Aug/21 07:50,25/Aug/21 10:38,,"Since master does not carry regions any more, MasterAnnotationReadingPriorityFunction does not need run the logic to find out scanner id or region id to determine the priority. Let's introduce a RSAnnotationReadingPriorityFunction, move the special logic from AnnotationReadingPriorityFunction to it." Backport HBASE-26204 to branch-2: VerifyReplication should obtain token for peerQuorumAddress too,13397059,Resolved,Major,Duplicate,25/Aug/21 04:11,26/Aug/21 10:01,, Return only a sub set of region servers as bootstrap nodes,13393674,Resolved,Major,Fixed,05/Aug/21 09:38,24/Aug/21 15:43,,"For some large clusters we may have thousands of region servers, I do not think we need to return all the region servers as bootstrap nodes. For me I think ten servers is enough for a client usually?" Allow disabling refresh of connection registry endpoint,13394025,Resolved,Major,Fixed,07/Aug/21 13:19,24/Aug/21 06:21,,"One possible deployment in production is to use something like a lvs in front of all the region servers to act as a LB, so client just need to connect to the lvs IP instead of go to the region server directly to get registry information. For this scenario we do not need to refresh the endpoints any more. The simplest way is to set the refresh interval to -1." Report flaky jenkins job should have the ability to submit flaky tests manually,13397039,Open,Major,,25/Aug/21 02:28,,,"Recently our pre commit result is very unstable due to some flaky tests, such as TestReplicationDroppedTable, but it never fails in nightly builds so we never include it in the flaky list. I think our find flaky jenkins job should allow submitting tests manually." Make rpc connection registry the default registry on 3.0.0,13393678,Resolved,Major,Fixed,05/Aug/21 10:02,20/Aug/21 07:57,, Support RegionCoprocessor on CompactionServer,13389774,Resolved,Major,Fixed,15/Jul/21 07:39,21/Aug/21 02:24,,"We have two kinds of RegionCoprocessor: CoreCoprocessor or not. 1.The CoreCoprocessor(AccessController, TokenProvider, SecureBulkLoadEndpoint...),  They have RegionEnvironmentForCoreCoprocessors which expose RegionServerServices. And they involve authorization, permission, etc, We don't need to support these CoreCoprocessor on compactionServer 2. Not CoreCoprocessor: They have RegionEnvironment which do not expose RegionServerServices, only offer Connection/ OnlineRegions, We can propose RegionEnvironmentOnCS, offer Connection, but the OnlineRegions may leave to discuss" JVM crash when displaying RPC params by MonitoredRPCHandler,13389623,Resolved,Major,Fixed,14/Jul/21 12:47,18/Aug/21 07:00,2.0.0,"It is the same problem as HBASE-25981. The reason here is MonitoredRPCHandlerImpl uses the shallow copy of call param to displaying RPC info, but the param contains offheap request data. Thought when calling toMap() there is state checking for the monitored RPC, only RUNNING RPCs can read and display params, the state is ENUM type and like a constant in clone(). So there exists circumstances that the state in the clone MonitoredRPCHandler is RUNNING, but the param still refers to the cloned MonitoredRPCHandler, whose state changed to be not RUNNING and param referred offheap ByteBuffer is released. " Add UT for masterless mode,13395854,In Progress,Major,,18/Aug/21 10:53,,,"It is not used in code any more and there is no UT to make sure it works. Let's just remove it as it is only designed to be used in tests. ==== Update ==== This is used in hbase-connector, so we'd better add a UT in hbase to confirm that it still works." Undo 'HBASE-25165 Change 'State time' in UI so sorts (#2508)' in favor of HBASE-24652,13395556,Resolved,Major,Fixed,16/Aug/21 20:39,16/Aug/21 20:53,,"The below change by me does not actually work and I found an old issue that does the proper job that was neglected. I'm undoing the below in favor of HBASE-24652.   kalashnikov:hbase.apache.git stack$ git show d07d181ea4a9da316659bb21fd4fffc979b5f77a commit d07d181ea4a9da316659bb21fd4fffc979b5f77a Author: Michael Stack Date: Thu Oct 8 09:10:30 2020 -0700 HBASE-25165 Change 'State time' in UI so sorts (#2508) Display startcode in iso8601. Signed-off-by: Nick Dimiduk " Support configuration override for remote cluster of HFileOutputFormat locality sensitive,13394994,Resolved,Major,Fixed,13/Aug/21 02:30,16/Aug/21 17:35,1.8.0,"We introduced support to generate hfile with good locality for a remote cluster even in HBASE-25608. I realized we need to override other configurations for the remote cluster in addition to the zookeeper cluster key. For example, read from a non-secure cluster and write hfiles for a secure cluster. In this case, we use TableInputFormat for non-secure cluster with hbase.security.authentication=simple in job configuration. So HFileOutputFormat failed to connect to remote secure cluster because requires hbase.security.authentication=kerberos in job conf.   Thus let's introduce configuration override for remote-cluster-aware HFileOutputFormat locality-sensitive feature.   -Another example is to read from a secure cluster (A) and write hfiles for another secure cluster (B) and we use different principal for each cluster.- -For instance, we use cluster-a/_HOST@EXAMPLE.COM for A and cluster-b/_HOST@EXAMPLE.COM for B.- -Then we need to override MASTER_KRB_PRINCIPAL and REGIONSERVER_KRB_PRINCIPAL using cluster-b/_HOST@EXAMPLE.COM to connect cluster B.- ^ This is not truth, we use token based digest auth in mapper/reducer, so principal difference for kerberos should be fine" Introduce a ReplicationServerSourceManager to simplify HReplicationServer,13394874,Resolved,Major,Done,12/Aug/21 10:35,17/Aug/21 08:29,3.0.0-alpha-2, Backport HBASE-26196 to branch-1,13395585,Open,Major,,17/Aug/21 02:25,,, Annotate shaded generated protobuf as InterfaceAudience.Private,13394810,Open,Major,,12/Aug/21 03:39,,,"Annotate generated shaded protobufs as InterfaceAudience.Private. It might not be able to add the annotation to each class; at a minimum update the doc on our story around shaded internal protobufs. See the prompting mailing list discussion here: [https://lists.apache.org/thread.html/r9e6eb11106727d245f6eb2a5023823901637971d6ed0f0aedaf8d149%40%3Cdev.hbase.apache.org%3E] So far the consensus has it that the shaded generated protobuf should be made IA.Private.  Will wait on it to settle." Support favoredNodes when do compaction offload,13388521,Resolved,Major,Fixed,09/Jul/21 02:57,16/Aug/21 10:43,,"1.If we have favoredNodes for region, We use this policy  2.If we not have favoredNodes, we add the regionServer request compaction as favoredNodes when do compact on compaction server, to guarantee locality" JVM crash when scan,13392688,Resolved,Major,Fixed,30/Jul/21 07:44,12/Aug/21 09:24,3.0.0-alpha-1,"There are scanner close caused regionserver JVM coredump problems on our production clusters. {code:java} Stack: [0x00007fca4b0cc000,0x00007fca4b1cd000], sp=0x00007fca4b1cb0d8, free space=1020k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x7fd314] J 2810 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007fdae55a9e61 [0x00007fdae55a9d80+0xe1] j org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36 j org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69 j org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39 j org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31 j org.apache.hadoop.hbase.KeyValueUtil.appendKeyTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+43 J 14724 C2 org.apache.hadoop.hbase.regionserver.StoreScanner.shipped()V (51 bytes) @ 0x00007fdae6a298d0 [0x00007fdae6a29780+0x150] J 21387 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices$RegionScannerShippedCallBack.run()V (53 bytes) @ 0x00007fdae622bab8 [0x00007fdae622acc0+0xdf8] J 26353 C2 org.apache.hadoop.hbase.ipc.ServerCall.setResponse(Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;Lorg/apache/hadoop/hbase/CellScanner;Ljava/lang/Throwable;Ljava/lang/String;)V (384 bytes) @ 0x00007fdae7f139d8 [0x00007fdae7f12980+0x1058] J 26226 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1554 bytes) @ 0x00007fdae959f68c [0x00007fdae959e400+0x128c] J 19598% C2 org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(Ljava/util/concurrent/BlockingQueue;Ljava/util/concurrent/atomic/AtomicInteger;)V (338 bytes) @ 0x00007fdae81c54d4 [0x00007fdae81c53e0+0xf4] {code} There are also scan rpc errors when coredump happens at the handler, !scan-error.png|width=585,height=235! I found some clue in the logs, that some blocks may be replaced when its nextBlockOnDiskSize less than the newly one in the method    {code:java} public static boolean shouldReplaceExistingCacheBlock(BlockCache blockCache, BlockCacheKey cacheKey, Cacheable newBlock) { if (cacheKey.toString().indexOf(""."") != -1) { // reference file LOG.warn(""replace existing cached block, cache key is : "" + cacheKey); return true; } Cacheable existingBlock = blockCache.getBlock(cacheKey, false, false, false); if (existingBlock == null) { return true; } try { int comparison = BlockCacheUtil.validateBlockAddition(existingBlock, newBlock, cacheKey); if (comparison < 0) { LOG.warn(""Cached block contents differ by nextBlockOnDiskSize, the new block has "" + ""nextBlockOnDiskSize set. Caching new block.""); return true; ......{code}   And the block will be replaced if it is not in the RAMCache but in the BucketCache. When using    {code:java} private void putIntoBackingMap(BlockCacheKey key, BucketEntry bucketEntry) { BucketEntry previousEntry = backingMap.put(key, bucketEntry); if (previousEntry != null && previousEntry != bucketEntry) { ReentrantReadWriteLock lock = offsetLock.getLock(previousEntry.offset()); lock.writeLock().lock(); try { blockEvicted(key, previousEntry, false); } finally { lock.writeLock().unlock(); } } } {code} to replace the old block, to avoid previous bucket entry mem leak, the previous bucket entry will be force released regardless of RPC references to it.   {code:java} void blockEvicted(BlockCacheKey cacheKey, BucketEntry bucketEntry, boolean decrementBlockNumber) { bucketAllocator.freeBlock(bucketEntry.offset()); realCacheSize.add(-1 * bucketEntry.getLength()); blocksByHFile.remove(cacheKey); if (decrementBlockNumber) { this.blockNumber.decrement(); } } {code} I used the check of RPC reference before replace bucket entry, and it works, no coredumps until now.   That is: {code:java} public void cacheBlockWithWait(BlockCacheKey cacheKey, Cacheable cachedItem, boolean inMemory, boolean wait) { if (cacheEnabled) { if (backingMap.containsKey(cacheKey) || ramCache.containsKey(cacheKey)) { if (BlockCacheUtil.shouldReplaceExistingCacheBlock(this, cacheKey, cachedItem)) { BucketEntry bucketEntry = backingMap.get(cacheKey); if (bucketEntry != null && bucketEntry.isRpcRef()) { // avoid replace when there are RPC refs for the bucket entry in bucket cache return; } cacheBlockWithWaitInternal(cacheKey, cachedItem, inMemory, wait); } } else { cacheBlockWithWaitInternal(cacheKey, cachedItem, inMemory, wait); } } } {code}  " Add owner of replication queue for ReplicationQueueInfo,13389356,Resolved,Major,Done,13/Jul/21 08:59,12/Aug/21 09:17,3.0.0-alpha-1,"The current ReplicationQueueInfo only has queueId, which is not enough to distinguish queues in ReplicationServer,  so we need to add the RS holding the queue for ReplicationQueueInfo." Implement #toString for RowMutations,13394734,Open,Major,,11/Aug/21 17:27,,2.4.5,"We annoyingly discovered recently the absence of a meaningful {{toString}} method on {{o.a.h.h.client.RowMutations}}. We should add it. More ambitious: we should also perform an audit of the user data objects in this package to ensure that they all have basic POJO methods like {{toString}}, {{equals}}, and {{hashCode}}." Let region server also carry ClientMetaService,13392559,Resolved,Major,Fixed,29/Jul/21 14:58,05/Aug/21 10:02,,"Usually region server will be deployed on machines which are more powerful than masters, so it will be good to let region servers carries more load. h2. Background This is preliminary work needed for one of the [splittable meta designs|https://docs.google.com/document/d/11ChsSb2LGrSzrSJz8pDCAw5IewmaMV0ZDN1LrMkAj4s/edit#heading=h.90th11txi153]. We want to hide the implementation of ROOT from the client side, by adding new methods in ClientMetaService for locating meta Regions. One of the concerns is that the original implementation of the Master Registery over in HBASE-18095 puts master inline in the normal read/write path, which is not always a good choice. This issue aims to move the ConnectionRegistry off of the masters. In this issue, we let the region server implement the ClientMetaService interface, so the client could also get the cluster id, active master, meta region location, etc. from RegionServers (and not just Masters as it is currently). We introduce a new method getBootstrapNodes in ClientMetaService, for refreshing the bootstrap nodes periodically or on error. The new RpcConnectionRegistry will use this method to refresh the bootstrap nodes, while the old MasterRegistry will use the getMasters method to refresh the ‘bootstrap’ nodes. The getBootstrapNodes method will return all the region servers, so after the first refreshing, the client will go to region servers for later rpc calls. But since masters and region servers both implement the ClientMetaService interface, it is free for the client to configure master as the initial bootstrap nodes." Size of the Result object while querying huge data from HBASE table,13394142,Open,Major,,09/Aug/21 06:53,,1.1.13,"  I am trying to query hbase table with rowkeys. We have the following structure * index table which has rowkeys of the actual table * actual table which contains json data in compressed format. When i am trying to query hbase, i have to scan first index table for rowkeys using scan with some filters which will results to byte array.(row keys). Once we obtained rowkeys, we are invoking listofGets() in Table object. Once obtained we are iterating the object and prepare a list which contains compressed json objects. Here we are not sure about the size and number of the objects. In case of number of objects is huge we may result in OOM. Do we have any options to return Iterator or buffering the results so that we can avoid OOM.  {{for (byte[] rowkey : indexTableOutput) { Get get = new Get(rowkey).addFamily(Bytes.toBytes(columnFamilty)).setMaxVersions(MAX_VERSIONS); listOfget.add(get); }}} The above piece of code which is used to retrieve the keys from index table.  {{TableName tableName = TableName.valueOf(""table1"");Table tableObj = conn.getTable(tableName); Result[] results = tableObj.get(listOfget);}} From the above piece of code we have few queries. Any help would be appreciated. * If we have a huge number of data, Result[] will contain all the results? * How to return a iterator kind of object so that we can leave it to consumer because keeping all the data and doing processing will result in OOM * Any other options to return a limited data so that consumer do processing and continue I could find a resultscanner is returning for scan objects. But couldn't find any other options for list of Get's. Here we know the exact keys from index table." TestRequestTooBigException spends too much time to finish,13394011,Resolved,Major,Fixed,07/Aug/21 10:10,07/Aug/21 15:24,,"In the test we set max request value to 10k, so we do not need to test with a 800MB put..." Exclude javax.servlet:servlet-api in hbase-shaded-testing-util,13392578,Resolved,Major,Fixed,29/Jul/21 17:32,02/Aug/21 12:16,2.4.0,"{noformat} [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.515 s <<< FAILURE! - in org.apache.hbase.shaded.TestShadedHBaseTestingUtility [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed: 19.513 s <<< ERROR! java.io.IOException: Shutting down at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterMultiple exceptions at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: java.io.IOException: Problem starting http server at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException: Multiple exceptions at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: java.lang.NoSuchMethodError: javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter; at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 {noformat} The hadoop-common and hadoop-mapreduce-client-app dependencies are leaking javax.servlet:servlet-api:2.5." Update dependencies in hbase-filesystem,13393158,Resolved,Major,Fixed,02/Aug/21 22:59,03/Aug/21 10:41,hbase-filesystem-1.0.0-alpha1,"hbase-filesystem still has some old dependencies. Notably aws-java-sdk is at 1.11.525 whereas hadoop is all the way at 1.11.1026. We're also still building HBase 2 against 2.1.4 instead of anything newer. Bump up the relevant dependencies to something more current and make sure the code still works." SystemExitWhenAbortTimeout initialization exception when regionserver exits due to abort method,13393006,Open,Major,,02/Aug/21 06:52,,2.1.4,"We encountered a problem in the production environment. When the regionserver was shut down due to abort, the SystemExitWhenAbortTimeout could not be created correctly. {noformat} 2021-07-31 10:14:36,792 WARN [regionserver/xxx-hbase48:16020] regionserver.HRegionServer: Initialize abort timeout task failed java.lang.IllegalAccessException: Class org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of class org.apache.hadoop.hbase.regionserver.HRegionServer$SystemExitWhenAbortTimeout with modifiers ""private"" at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102) at java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296) at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288) at java.lang.reflect.Constructor.newInstance(Constructor.java:413) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1046) at java.lang.Thread.run(Thread.java:748){noformat}    " Update fails with DoNotRetryIOException while the region is being split,13392120,Open,Major,,27/Jul/21 13:13,,2.4.4,"While inserting records into HBase, I'm getting following exceptions on the client side: {noformat} 2021-07-27 12:07:33,986 WARN [hconnection-0x6d4081cd-shared-pool-158] o.a.h.h.c.AsyncRequestFutureImpl - id=1, table=ris:ris-updates, attempt=1/16, failureCount=9ops, last exception=org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError on worker008,16020,1627053306686, tracking started Tue Jul 27 12:07:33 UTC 2021; NOT retrying, failed=9 -- final attempt! 2021-07-27 12:07:34,008 ERROR [Thread-4] o.a.hadoop.hbase.client.BatchErrors - Exception occurred! Exception details: [org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError, org.apache.hadoop.hbase.DoNotRetryIOException: java.lang.ExceptionInInitializerError]; Actions: [{""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE5z\\x04P\\xF9\\xD3\\xD9\\x00\\x00\\x00\\x00"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":117,""tag"":[],""timestamp"":""1627387651450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387651450""}]},""ts"":""1627387651450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE5z\\x04P\\xF9\\xD1\\xB0\\x00\\x00\\x00\\x01"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":117,""tag"":[],""timestamp"":""1627387651450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387651450""}]},""ts"":""1627387651450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE5z\\x04P\\xF9\\xD2\\xD0\\x00\\x00\\x00\\x02"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":125,""tag"":[],""timestamp"":""1627387651450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387651450""}]},""ts"":""1627387651450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE5z\\x06 \\x01\\x07\\xF8\\x00\\x01\\x00\\x00\\x00\\x00\\xA5\\x02\\x94g\\x00\\x01\\x00\\x00\\x00\\x03"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":175,""tag"":[],""timestamp"":""1627387651450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387651450""}]},""ts"":""1627387651450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE9b\\x04P\\xF9\\xD3\\xD9\\x00\\x00\\x00\\x00"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":125,""tag"":[],""timestamp"":""1627387652450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387652450""}]},""ts"":""1627387652450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE9b\\x06 \\x01\\x07\\xF8\\x00\\x01\\x00\\x00\\x00\\x00\\xA5\\x00\\x84U\\x00\\x01\\x00\\x00\\x00\\x01"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":75,""tag"":[],""timestamp"":""1627387652450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387652450""}]},""ts"":""1627387652450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE9b\\x04P\\xF9\\xD1\\xB0\\x00\\x00\\x00\\x02"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":110,""tag"":[],""timestamp"":""1627387652450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387652450""}]},""ts"":""1627387652450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE9b\\x06 \\x01\\x07\\xF8\\x00\\x01\\x00\\x00\\x00\\x00\\xA5\\x02\\x94g\\x00\\x01\\x00\\x00\\x00\\x03"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":171,""tag"":[],""timestamp"":""1627387652450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387652450""}]},""ts"":""1627387652450""}, {""totalColumns"":2,""row"":""\\x00\\x03\\x00\\x00\\x01z\\xE7\\xDC\\xE9b\\x04P\\xF9\\xD3\\xD9\\x00\\x00\\x00\\x04"",""families"":{""-"":[{""qualifier"":""mrt"",""vlen"":115,""tag"":[],""timestamp"":""1627387652450""},{""qualifier"":""source"",""vlen"":11,""tag"":[],""timestamp"":""1627387652450""}]},""ts"":""1627387652450""}] 2021-07-27 12:07:34,015 ERROR [Thread-4] n.r.g.r.a.AbstractApp - Error: org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 9 actions: java.lang.ExceptionInInitializerError: 9 times, servers with issues: worker008,16020,1627053306686 at org.apache.hadoop.hbase.client.BatchErrors.makeException(BatchErrors.java:54) at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.getErrors(AsyncRequestFutureImpl.java:1196) at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:451) at org.apache.hadoop.hbase.client.HTable.put(HTable.java:549){noformat} There are no errors logged on the regionserver: {noformat} 2021-07-27 12:07:32,811 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] handler.UnassignRegionHandler: Close 625d2ac4331542df877e44fa06489ca1 2021-07-27 12:07:32,811 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] regionserver.HRegion: Closing region ris:ris-updates,\x00\x03\x00\x00\x01z\xE6/M:\x04P\xF9\xD0j\x00\x00\x00\x01,1627382439537.625d2ac4331542df877e44fa06489ca1. 2021-07-27 12:07:32,811 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] regionserver.HRegion: Flushing 625d2ac4331542df877e44fa06489ca1 1/1 column families, dataSize=77.13 KB heapSize=122.04 KB 2021-07-27 12:07:33,088 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] regionserver.DefaultStoreFlusher: Flushed memstore data size=77.13 KB at sequenceid=88678485 (bloomFilter=true), to=hdfs://dune/hbase/data/ris/ris-updates/625d2ac4331542df877e44fa06489ca1/.tmp/-/2bc2db2278054d6399fdf618fca0f260 2021-07-27 12:07:33,093 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] regionserver.HStore: Added hdfs://dune/hbase/data/ris/ris-updates/625d2ac4331542df877e44fa06489ca1/-/2bc2db2278054d6399fdf618fca0f260, entries=600, sequenceid=88678485, filesize=21.4 K 2021-07-27 12:07:33,094 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] regionserver.HRegion: Finished flush of dataSize ~77.13 KB/78981, heapSize ~122.02 KB/124952, currentSize=0 B/0 for 625d2ac4331542df877e44fa06489ca1 in 283ms, sequenceid=88678485, compaction requested=true 2021-07-27 12:07:33,105 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] regionserver.HRegion: Closed ris:ris-updates,\x00\x03\x00\x00\x01z\xE6/M:\x04P\xF9\xD0j\x00\x00\x00\x01,1627382439537.625d2ac4331542df877e44fa06489ca1. 2021-07-27 12:07:33,106 INFO [RS_CLOSE_REGION-regionserver/worker008:16020-0] handler.UnassignRegionHandler: Closed 625d2ac4331542df877e44fa06489ca1 2021-07-27 12:07:35,413 WARN [StoreFileOpener---1] hfile.BlockCacheUtil: Caching an already cached block: 9bcfcba754cf4084817bb6aee7ce0492.625d2ac4331542df877e44fa06489ca1_420326799. This is harmless and can happen in rare cases (see HBASE-8547) {noformat} And on the master: {noformat} 2021-07-27 12:07:32,655 INFO [PEWorker-16] procedure.MasterProcedureScheduler: Took xlock for pid=118449, state=RUNNABLE:SPLIT_TABLE_REGION_PREPARE; SplitTableRegionProcedure table=ris:ris-updates, parent=625d2ac4331542df877e44fa06489ca1, daughterA=43206debd9f16952acb6632130b64e36, daughterB=d317ec8cb2eb18dbd3cf92cf4b5b85d9 2021-07-27 12:07:32,655 INFO [PEWorker-16] procedure.MasterProcedureScheduler: Took xlock for pid=118449, state=RUNNABLE:SPLIT_TABLE_REGION_PREPARE; SplitTableRegionProcedure table=ris:ris-updates, parent=625d2ac4331542df877e44fa06489ca1, daughterA=43206debd9f16952acb6632130b64e36, daughterB=d317ec8cb2eb18dbd3cf92cf4b5b85d9 2021-07-27 12:07:32,655 INFO [PEWorker-16] procedure.MasterProcedureScheduler: Took xlock for pid=118449, state=RUNNABLE:SPLIT_TABLE_REGION_PREPARE; SplitTableRegionProcedure table=ris:ris-updates, parent=625d2ac4331542df877e44fa06489ca1, daughterA=43206debd9f16952acb6632130b64e36, daughterB=d317ec8cb2eb18dbd3cf92cf4b5b85d9 2021-07-27 12:07:32,656 INFO [PEWorker-16] procedure2.ProcedureExecutor: Initialized subprocedures=[{pid=118450, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_CLOSE; TransitRegionStateProcedure table=ris:ris-updates, region=625d2ac4331542df877e44fa06489ca1, UNASSIGN}] 2021-07-27 12:07:32,656 INFO [PEWorker-16] procedure.MasterProcedureScheduler: Took xlock for pid=118450, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_CLOSE; TransitRegionStateProcedure table=ris:ris-updates, region=625d2ac4331542df877e44fa06489ca1, UNASSIGN 2021-07-27 12:07:32,657 INFO [PEWorker-16] assignment.RegionStateStore: pid=118450 updating hbase:meta row=625d2ac4331542df877e44fa06489ca1, regionState=CLOSING, regionLocation=worker008,16020,1627053306686 2021-07-27 12:07:32,660 INFO [PEWorker-16] procedure2.ProcedureExecutor: Initialized subprocedures=[{pid=118451, ppid=118450, state=RUNNABLE; CloseRegionProcedure 625d2ac4331542df877e44fa06489ca1, server=worker008,16020,1627053306686}] 2021-07-27 12:07:33,106 INFO [PEWorker-3] assignment.RegionStateStore: pid=118450 updating hbase:meta row=625d2ac4331542df877e44fa06489ca1, regionState=CLOSED 2021-07-27 12:07:33,108 INFO [PEWorker-3] procedure2.ProcedureExecutor: Finished subprocedure pid=118451, resume processing ppid=118450 2021-07-27 12:07:33,108 INFO [PEWorker-3] procedure2.ProcedureExecutor: Finished pid=118451, ppid=118450, state=SUCCESS; CloseRegionProcedure 625d2ac4331542df877e44fa06489ca1, server=worker008,16020,1627053306686 in 447 msec 2021-07-27 12:07:33,109 INFO [PEWorker-7] procedure2.ProcedureExecutor: Finished subprocedure pid=118450, resume processing ppid=118449 2021-07-27 12:07:33,109 INFO [PEWorker-7] procedure2.ProcedureExecutor: Finished pid=118450, ppid=118449, state=SUCCESS; TransitRegionStateProcedure table=ris:ris-updates, region=625d2ac4331542df877e44fa06489ca1, UNASSIGN in 452 msec 2021-07-27 12:07:33,118 INFO [PEWorker-10] assignment.SplitTableRegionProcedure: pid=118449 splitting 5 storefiles, region=625d2ac4331542df877e44fa06489ca1, threads=5 2021-07-27 12:07:35,072 INFO [PEWorker-10] procedure2.ProcedureExecutor: Initialized subprocedures=[{pid=118452, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ris:ris-updates, region=43206debd9f16952acb6632130b64e36, ASSIGN}, {pid=118453, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ris:ris-updates, region=d317ec8cb2eb18dbd3cf92cf4b5b85d9, ASSIGN}] 2021-07-27 12:07:35,072 INFO [PEWorker-12] procedure.MasterProcedureScheduler: Took xlock for pid=118453, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ris:ris-updates, region=d317ec8cb2eb18dbd3cf92cf4b5b85d9, ASSIGN 2021-07-27 12:07:35,072 INFO [PEWorker-2] procedure.MasterProcedureScheduler: Took xlock for pid=118452, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ris:ris-updates, region=43206debd9f16952acb6632130b64e36, ASSIGN 2021-07-27 12:07:35,073 INFO [PEWorker-12] assignment.TransitRegionStateProcedure: Starting pid=118453, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=ris:ris-updates, region=d317ec8cb2eb18dbd3cf92cf4b5b85d9, ASSIGN; state=SPLITTING_NEW, location=worker008,16020,1627053306686; forceNewPlan=false, retain=false 2021-07-27 12:07:35,073 INFO [PEWorker-2] assignment.TransitRegionStateProcedure: Starting pid=118452, ppid=118449, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=ris:ris-updates, region=43206debd9f16952acb6632130b64e36, ASSIGN; state=SPLITTING_NEW, location=worker008,16020,1627053306686; forceNewPlan=false, retain=false 2021-07-27 12:07:35,223 INFO [master2:16000] balancer.BaseLoadBalancer: Reassigned 2 regions. 2 retained the pre-restart assignment. 2021-07-27 12:07:35,223 INFO [PEWorker-5] assignment.RegionStateStore: pid=118453 updating hbase:meta row=d317ec8cb2eb18dbd3cf92cf4b5b85d9, regionState=OPENING, regionLocation=worker008,16020,1627053306686 2021-07-27 12:07:35,223 INFO [PEWorker-13] assignment.RegionStateStore: pid=118452 updating hbase:meta row=43206debd9f16952acb6632130b64e36, regionState=OPENING, regionLocation=worker008,16020,1627053306686 2021-07-27 12:07:35,224 INFO [PEWorker-5] procedure2.ProcedureExecutor: Initialized subprocedures=[{pid=118454, ppid=118453, state=RUNNABLE; OpenRegionProcedure d317ec8cb2eb18dbd3cf92cf4b5b85d9, server=worker008,16020,1627053306686}] 2021-07-27 12:07:35,224 INFO [PEWorker-13] procedure2.ProcedureExecutor: Initialized subprocedures=[{pid=118455, ppid=118452, state=RUNNABLE; OpenRegionProcedure 43206debd9f16952acb6632130b64e36, server=worker008,16020,1627053306686}] 2021-07-27 12:07:35,421 INFO [PEWorker-14] assignment.RegionStateStore: pid=118452 updating hbase:meta row=43206debd9f16952acb6632130b64e36, regionState=OPEN, openSeqNum=88678489, regionLocation=worker008,16020,1627053306686 2021-07-27 12:07:35,423 INFO [PEWorker-14] procedure2.ProcedureExecutor: Finished subprocedure pid=118455, resume processing ppid=118452 2021-07-27 12:07:35,423 INFO [PEWorker-14] procedure2.ProcedureExecutor: Finished pid=118455, ppid=118452, state=SUCCESS; OpenRegionProcedure 43206debd9f16952acb6632130b64e36, server=worker008,16020,1627053306686 in 198 msec 2021-07-27 12:07:35,423 INFO [PEWorker-1] procedure2.ProcedureExecutor: Finished pid=118452, ppid=118449, state=SUCCESS; TransitRegionStateProcedure table=ris:ris-updates, region=43206debd9f16952acb6632130b64e36, ASSIGN in 351 msec 2021-07-27 12:07:35,666 INFO [PEWorker-11] assignment.RegionStateStore: pid=118453 updating hbase:meta row=d317ec8cb2eb18dbd3cf92cf4b5b85d9, regionState=OPEN, openSeqNum=88678489, regionLocation=worker008,16020,1627053306686 2021-07-27 12:07:35,668 INFO [PEWorker-11] procedure2.ProcedureExecutor: Finished subprocedure pid=118454, resume processing ppid=118453 2021-07-27 12:07:35,668 INFO [PEWorker-11] procedure2.ProcedureExecutor: Finished pid=118454, ppid=118453, state=SUCCESS; OpenRegionProcedure d317ec8cb2eb18dbd3cf92cf4b5b85d9, server=worker008,16020,1627053306686 in 443 msec 2021-07-27 12:07:35,669 INFO [PEWorker-9] procedure2.ProcedureExecutor: Finished subprocedure pid=118453, resume processing ppid=118449 2021-07-27 12:07:35,669 INFO [PEWorker-9] procedure2.ProcedureExecutor: Finished pid=118453, ppid=118449, state=SUCCESS; TransitRegionStateProcedure table=ris:ris-updates, region=d317ec8cb2eb18dbd3cf92cf4b5b85d9, ASSIGN in 596 msec 2021-07-27 12:07:35,669 INFO [PEWorker-15] procedure2.ProcedureExecutor: Finished pid=118449, state=SUCCESS; SplitTableRegionProcedure table=ris:ris-updates, parent=625d2ac4331542df877e44fa06489ca1, daughterA=43206debd9f16952acb6632130b64e36, daughterB=d317ec8cb2eb18dbd3cf92cf4b5b85d9 in 3.0160 sec 2021-07-27 12:09:05,065 INFO [master/master2:16000.Chore.1] balancer.BaseLoadBalancer: Start Generate Balance plan for cluster. 2021-07-27 12:10:58,943 INFO [master:store-WAL-Roller] wal.AbstractFSWAL: Rolled WAL /hbase/MasterData/WALs/master2,16000,1627034030675/master2%2C16000%2C1627034030675.master2%2C16000%2C1627034030675.regiongroup-0.1627386958285 with entries=60, filesize=30.97 KB; new WAL /hbase/MasterData/WALs/master2,16000,1627034030675/master2%2C16000%2C1627034030675.master2%2C16000%2C1627034030675.regiongroup-0.1627387858617 2021-07-27 12:12:00,780 INFO [master:store-Flusher] regionserver.HRegion: Flushing 1595e783b53d99cd5eef43b6debb2682 1/1 column families, dataSize=26.98 KB heapSize=32.55 KB 2021-07-27 12:12:01,416 INFO [master:store-Flusher] regionserver.DefaultStoreFlusher: Flushed memstore data size=26.98 KB at sequenceid=1068044 (bloomFilter=true), to=hdfs://dune/hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682/.tmp/proc/b47b99aa8f544dc6badd73f8450d6390 2021-07-27 12:12:01,418 INFO [master:store-Flusher] regionserver.StoreFileReader: Loaded Delete Family Bloom (CompoundBloomFilter) metadata for b47b99aa8f544dc6badd73f8450d6390 2021-07-27 12:12:01,421 INFO [master:store-Flusher] regionserver.StoreFileReader: Loaded Delete Family Bloom (CompoundBloomFilter) metadata for b47b99aa8f544dc6badd73f8450d6390 2021-07-27 12:12:01,421 INFO [master:store-Flusher] regionserver.HStore: Added hdfs://dune/hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682/proc/b47b99aa8f544dc6badd73f8450d6390, entries=8, sequenceid=1068044, filesize=5.8 K 2021-07-27 12:12:01,422 INFO [master:store-Flusher] regionserver.HRegion: Finished flush of dataSize ~26.98 KB/27626, heapSize ~32.53 KB/33312, currentSize=0 B/0 for 1595e783b53d99cd5eef43b6debb2682 in 642ms, sequenceid=1068044, compaction requested=true 2021-07-27 12:14:05,276 INFO [master/master2:16000.Chore.2] balancer.BaseLoadBalancer: Start Generate Balance plan for cluster. 2021-07-27 12:14:05,373 INFO [PEWorker-8] procedure.MasterProcedureScheduler: Took xlock for pid=118456, state=RUNNABLE:GC_REGION_PREPARE; GCRegionProcedure table=ris:ris-updates, region=625d2ac4331542df877e44fa06489ca1 2021-07-27 12:14:05,396 INFO [PEWorker-8] hbase.MetaTableAccessor: Deleted ris:ris-updates,\x00\x03\x00\x00\x01z\xE6/M:\x04P\xF9\xD0j\x00\x00\x00\x01,1627382439537.625d2ac4331542df877e44fa06489ca1. 2021-07-27 12:14:05,397 INFO [PEWorker-8] procedure2.ProcedureExecutor: Finished pid=118456, state=SUCCESS; GCRegionProcedure table=ris:ris-updates, region=625d2ac4331542df877e44fa06489ca1 in 25 msec {noformat}" Reimplement MasterAddressTracker to also cache backup master addresses,13392563,Resolved,Major,Fixed,29/Jul/21 15:23,31/Jul/21 07:51,,"Now it will fetch backup master addresses every time, which is not a very good idea if we want to expose the data to client." Support passing a customized Configuration object when creating TestingHBaseCluster,13390809,Resolved,Major,Fixed,20/Jul/21 03:00,31/Jul/21 07:30,,"As per the discussion thread on dev list. https://lists.apache.org/thread.html/r13939d06641624dc01dd1a17b7f1e1f2faf4840d1fc0900b86143254%40%3Cdev.hbase.apache.org%3E" Cleanup the deprecated methods in HBTU related classes and format code,13390582,Resolved,Major,Fixed,19/Jul/21 01:34,29/Jul/21 02:19,,"As it is now IA.LimitedPrivate, we should clean it up before the final 3.0.0 release, to make the interface cleaner." Restore fields dropped by HBASE-25986 to public interfaces,13391989,Resolved,Major,Fixed,26/Jul/21 23:59,27/Jul/21 00:10,2.4.5, Replication is stuck due to zero length wal file in oldWALs directory [master/branch-2],13389954,Resolved,Major,Fixed,16/Jul/21 05:12,23/Jul/21 16:44,2.4.5,Clone of the parent issue for branch-2/master. Resolving the parent as the issue is fixed in 1.7.1 and the jira needs to be in a resolved state for release notes curation. The HStore.commitFile and HStore.moveFileIntoPlace almost have the same logic,13391710,Resolved,Major,Fixed,25/Jul/21 08:42,26/Jul/21 13:55,,"We should unify them and only have single entry point for committing storefiles. This is good for implementing HBASE-26067." Polish TestAsyncNonMetaRegionLocator,13391737,Resolved,Major,Fixed,25/Jul/21 14:40,26/Jul/21 10:12,,"It creates a Connection in constructor but only close it in AfterClass method, which leaks Connections and make the code a bit ugly." Formatter to convert from epoch time to human readable date format.,13391894,Open,Major,,26/Jul/21 12:57,,,"In shell, we have custom formatter to convert from bytes to Long/Int for long/int data type values. Many times we store the epoch timestamp (event creation, updation time) as long in our table columns. Even after converting this column to Long, the date is not in a human readable format. We still have to convert this long into date using some bash shell tricks and it is not convenient to do for many columns. We can introduce a new format method called +toLongDate+ which signifies that we want to convert the bytes to long first and then to date. Please let me know if any such functionality already exists and I am not aware of." add option to disable scanMetrics in TableSnapshotInputFormat,13391161,Resolved,Major,Fixed,21/Jul/21 16:02,22/Jul/21 19:23,2.3.5,"When running spark job with TableSnapshotInputFormat, we found that scan is very slower. We found that scanMetrics is hardcoded as enabled, spark's  newAPIHadoopRDD uses DummyReporter in hadoop, which causes the following exception and 80% cpu time is spent on this exception handling.  Need to provide an option to disable scanMetrics. java.base@11.0.5/java.lang.Throwable.fillInStackTrace(Native Method) java.base@11.0.5/java.lang.Throwable.fillInStackTrace(Throwable.java:787) => holding Monitor(java.util.MissingResourceException@258206255}) java.base@11.0.5/java.lang.Throwable.(Throwable.java:292) java.base@11.0.5/java.lang.Exception.(Exception.java:84) java.base@11.0.5/java.lang.RuntimeException.(RuntimeException.java:80) java.base@11.0.5/java.util.MissingResourceException.(MissingResourceException.java:85) java.base@11.0.5/java.util.ResourceBundle.throwMissingResourceException(ResourceBundle.java:2055) java.base@11.0.5/java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1689) java.base@11.0.5/java.util.ResourceBundle.getBundleImpl(ResourceBundle.java:1593) java.base@11.0.5/java.util.ResourceBundle.getBundle(ResourceBundle.java:1284) app//org.apache.hadoop.mapreduce.util.ResourceBundles.getBundle(ResourceBundles.java:37) app//org.apache.hadoop.mapreduce.util.ResourceBundles.getValue(ResourceBundles.java:56) => holding Monitor(java.lang.Class@545605549}) app//org.apache.hadoop.mapreduce.util.ResourceBundles.getCounterGroupName(ResourceBundles.java:77) app//org.apache.hadoop.mapreduce.counters.CounterGroupFactory.newGroup(CounterGroupFactory.java:94) app//org.apache.hadoop.mapreduce.counters.AbstractCounters.getGroup(AbstractCounters.java:227) app//org.apache.hadoop.mapreduce.counters.AbstractCounters.findCounter(AbstractCounters.java:154) app//org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl$DummyReporter.getCounter(TaskAttemptContextImpl.java:110) app//org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl.getCounter(TaskAttemptContextImpl.java:76) org.apache.hadoop.hbase.mapreduce.TableRecordReaderImpl.updateCounters(TableRecordReaderImpl.java:311) org.apache.hadoop.hbase.mapreduce.TableSnapshotInputFormat$TableSnapshotRegionRecordReader.nextKeyValue(TableSnapshotInputFormat.java:167)" In branch-1 L2 BC should not be the victimhandler of L1 BC when using combined BC,13389963,Resolved,Major,Fixed,16/Jul/21 06:04,23/Jul/21 02:38,1.7.0,"Currently in branch-1, the block cache initialisation is: {code:java} LruBlockCache l1 = getL1(conf); // blockCacheDisabled is set as a side-effect of getL1Internal(), so check it again after the call. if (blockCacheDisabled) return null; BlockCache l2 = getL2(conf); if (l2 == null) { GLOBAL_BLOCK_CACHE_INSTANCE = l1; } else { boolean useExternal = conf.getBoolean(EXTERNAL_BLOCKCACHE_KEY, EXTERNAL_BLOCKCACHE_DEFAULT); boolean combinedWithLru = conf.getBoolean(BUCKET_CACHE_COMBINED_KEY, DEFAULT_BUCKET_CACHE_COMBINED); if (useExternal) { GLOBAL_BLOCK_CACHE_INSTANCE = new InclusiveCombinedBlockCache(l1, l2); } else { if (combinedWithLru) { GLOBAL_BLOCK_CACHE_INSTANCE = new CombinedBlockCache(l1, l2); } else { // L1 and L2 are not 'combined'. They are connected via the LruBlockCache victimhandler // mechanism. It is a little ugly but works according to the following: when the // background eviction thread runs, blocks evicted from L1 will go to L2 AND when we get // a block from the L1 cache, if not in L1, we will search L2. GLOBAL_BLOCK_CACHE_INSTANCE = l1; } } l1.setVictimCache(l2); } {code} As the code above, L2 will always be the victimhandler of L1, no matter if we use combined blockcache or not. But as logic (in master & branch-2) L2 should not be the victimhandler of L1 when using combined BC. We should set the victimhandler only when we use InclusiveConbinedBC or we do not use CombinedBC." MOB compaction with missing files catches incorrect exception,13391156,Resolved,Major,Fixed,21/Jul/21 15:38,22/Jul/21 08:16,3.0.0-alpha-1,"The MOB compaction catches FileNotFoundException when {{hbase.unsafe.mob.discard.miss}} is true to handle missing MOB cells. The FNFE is wrapped in DoNotRetryIOException so the compaction fails for the given region. {noformat} 2021-07-21 13:51:05,880 WARN org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor: hbase.unsafe.mob.discard.miss=true. This is unsafe setting recommended only when first upgrading to a version with the distributed mob compaction feature on a cluster that has experienced MOB data corruption. 2021-07-21 13:51:05,880 WARN org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor: hbase.unsafe.mob.discard.miss=true. This is unsafe setting recommended only when first upgrading to a version with the distributed mob compaction feature on a cluster that has experienced MOB data corruption. 2021-07-21 13:51:05,880 INFO org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor: Compact MOB=true optimized configured=false optimized enabled=false maximum MOB file size=1073741824 major=true store=[table=IntegrationTestIngestWithMOB family=test_cf region=3a2ee81f9244c39ba61d694e616c1a89] 2021-07-21 13:51:05,880 INFO org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor: Compact MOB=true optimized configured=false optimized enabled=false maximum MOB file size=1073741824 major=true store=[table=IntegrationTestIngestWithMOB family=test_cf region=7a96f55bb9ae04500a06cbaef02da6a3] 2021-07-21 13:51:05,888 INFO org.apache.hadoop.hbase.regionserver.RSRpcServices: Compacting IntegrationTestIngestWithMOB,77777777,1626787996628.c71cad04514b17ee86a407490bd27424. 2021-07-21 13:51:05,891 INFO org.apache.hadoop.hbase.regionserver.RSRpcServices: Compacting IntegrationTestIngestWithMOB,88888888,1626787996628.8fd002bda07755decda67b7084d1e0f6. 2021-07-21 13:51:05,895 ERROR org.apache.hadoop.hbase.regionserver.HMobStore: The mob file 1bbd886460827015e5d605ed44252251202107200e5065290b424e38992f5556d9943b6a_7a96f55bb9ae04500a06cbaef02da6a3 could not be found in the locations [hdfs://example.com:8020/hbase/mobdir/data/default/IntegrationTestIngestWithMOB/e9b5d936e7f55a4f1c3246a8d5ce5 3c2/test_cf, hdfs://example.com:8020/hbase/archive/data/default/IntegrationTestIngestWithMOB/e9b5d936e7f55a4f1c3246a8d5ce53c2/test_cf] or it is corrupt 2021-07-21 13:51:05,895 INFO org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController: 7a96f55bb9ae04500a06cbaef02da6a3#test_cf#compaction#1 average throughput is 0.07 MB/second, slept 0 time(s) and total slept time is 0 ms. 1 active operations remaining, total limit is 10.00 MB/second 2021-07-21 13:51:05,908 INFO org.apache.hadoop.hbase.regionserver.RSRpcServices: Compacting IntegrationTestIngestWithMOB,dddddddd,1626787996628.53186ca5008e3a964eee5f96ee3f1b26. 2021-07-21 13:51:05,997 ERROR org.apache.hadoop.hbase.regionserver.CompactSplit: Compaction failed Request=regionName=IntegrationTestIngestWithMOB,11111111,1626787996628.7a96f55bb9ae04500a06cbaef02da6a3., storeName=test_cf, fileCount=1, fileSize=110.6 M (110.6 M), priority=1, time=1626875465819 java.io.IOException: Mob compaction failed for region: 7a96f55bb9ae04500a06cbaef02da6a3 at org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.performCompaction(DefaultMobStoreCompactor.java:575) at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:327) at org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.compact(DefaultMobStoreCompactor.java:227) at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:126) at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1407) at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2183) at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:633) at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:675) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.DoNotRetryIOException: java.io.FileNotFoundException: File does not exist: hdfs://example.com:8020/hbase/archive/data/default/IntegrationTestIngestWithMOB/e9b5d936e7f55a4f1c3246a8d5ce53c2/test_cf/1bbd886460827015e5d605ed44252251202107200e5065290b424e38992f5556d9943b6a_7a96f55bb9ae04500a06cbaef02da6a3 at org.apache.hadoop.hbase.regionserver.HMobStore.readCell(HMobStore.java:438) at org.apache.hadoop.hbase.regionserver.HMobStore.resolve(HMobStore.java:328) at org.apache.hadoop.hbase.regionserver.HMobStore.resolve(HMobStore.java:307) at org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.performCompaction(DefaultMobStoreCompactor.java:366) ... 10 more Caused by: java.io.FileNotFoundException: File does not exist: hdfs://example.com:8020/hbase/archive/data/default/IntegrationTestIngestWithMOB/e9b5d936e7f55a4f1c3246a8d5ce53c2/test_cf/1bbd886460827015e5d605ed44252251202107200e5065290b424e38992f5556d9943b6a_7a96f55bb9ae04500a06cbaef02da6a3 at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1500) at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1493) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1508) at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:442) at org.apache.hadoop.hbase.regionserver.StoreFileInfo.(StoreFileInfo.java:140) at org.apache.hadoop.hbase.regionserver.StoreFileInfo.(StoreFileInfo.java:104) at org.apache.hadoop.hbase.regionserver.HStoreFile.(HStoreFile.java:220) at org.apache.hadoop.hbase.mob.CachedMobFile.create(CachedMobFile.java:49) at org.apache.hadoop.hbase.mob.MobFileCache.openFile(MobFileCache.java:220) at org.apache.hadoop.hbase.regionserver.HMobStore.readCell(HMobStore.java:399) ... 13 more 2021-07-21 13:51:06,013 INFO org.apache.hadoop.hbase.regionserver.HRegion: Starting compaction of test_cf in IntegrationTestIngestWithMOB,77777777,1626787996628.c71cad04514b17ee86a407490bd27424. {noformat}" Parallel scheduling of getClusterstatus interface will lead to linear growth of HMaster memory,13391542,Open,Major,,23/Jul/21 11:05,,1.3.1,"when Mapreduce job and Spark job use TableInputFormat.getSplits  will call getclusterstatus ,and when running more ten job, HMaster memory is very high，Of course, the region quantity itself is a reason  " Hmaster dead after a few second when i run hbase,13391304,Resolved,Major,Not A Problem,22/Jul/21 09:42,22/Jul/21 11:31,3.0.0-alpha-1,first hmaster runs but after a few seconds hmaster shuts down  SIGSEGV in AsyncFSWAL consume,13387403,Resolved,Major,Duplicate,02/Jul/21 21:48,22/Jul/21 05:22,,"Seems related to the parent issue. Its happened a few times on one of our clusters here. Below are two examples. Need more detail but perhaps the call has timed out, the buffer has thus been freed, but the late consume on the other side of the ringbuffer doesn't know that and goes ahead (Just speculation).   {code:java} #  SIGSEGV (0xb) at pc=0x00007f8b3ef5b77c, pid=37631, tid=0x00007f61560ed700 RAX=0x00000000ffffdf6e is an unknown valueRBX=0x00007f8a38d7b6f8 is an oopjava.nio.DirectByteBuffer - klass: 'java/nio/DirectByteBuffer'RCX=0x00007f60e2767898 is pointing into metadataRDX=0x0000000000000de7 is an unknown valueRSP=0x00007f61560ec6f0 is pointing into the stack for thread: 0x00007f8b3017b800RBP=[error occurred during error reporting (printing register info), id 0xb] Stack: [0x00007f6155fed000,0x00007f61560ee000],  sp=0x00007f61560ec6f0,  free space=1021kNative frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)J 23901 C2 java.util.stream.MatchOps$1MatchSink.accept(Ljava/lang/Object;)V (44 bytes) @ 0x00007f8b3ef5b77c [0x00007f8b3ef5b640+0x13c]J 16165 C2 java.util.ArrayList$ArrayListSpliterator.tryAdvance(Ljava/util/function/Consumer;)Z (79 bytes) @ 0x00007f8b3d67b344 [0x00007f8b3d67b2c0+0x84]J 16160 C2 java.util.stream.MatchOps$MatchOp.evaluateSequential(Ljava/util/stream/PipelineHelper;Ljava/util/Spliterator;)Ljava/lang/Object; (7 bytes) @ 0x00007f8b3d67bc9c [0x00007f8b3d67b900+0x39c]J 17729 C2 org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALActionListener.visitLogEntryBeforeWrite(Lorg/apache/hadoop/hbase/wal/WALKey;Lorg/apache/hadoop/hbase/wal/WALEdit;)V (10 bytes) @ 0x00007f8b3fc39010 [0x00007f8b3fc388a0+0x770]J 29991 C2 org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.appendAndSync()V (261 bytes) @ 0x00007f8b3fd03d90 [0x00007f8b3fd039e0+0x3b0]J 20773 C2 org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.consume()V (474 bytes) @ 0x00007f8b40283728 [0x00007f8b40283480+0x2a8]J 15191 C2 org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL$$Lambda$76.run()V (8 bytes) @ 0x00007f8b3ed69ecc [0x00007f8b3ed69ea0+0x2c]J 17383% C2 java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V (225 bytes) @ 0x00007f8b3d9423f8 [0x00007f8b3d942260+0x198]j  java.util.concurrent.ThreadPoolExecutor$Worker.run()V+5j  java.lang.Thread.run()V+11v  ~StubRoutines::call_stubV  [libjvm.so+0x66b9ba]  JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*)+0xe1aV  [libjvm.so+0x669073]  JavaCalls::call_virtual(JavaValue*, KlassHandle, Symbol*, Symbol*, JavaCallArguments*, Thread*)+0x263V  [libjvm.so+0x669647]  JavaCalls::call_virtual(JavaValue*, Handle, KlassHandle, Symbol*, Symbol*, Thread*)+0x57V  [libjvm.so+0x6aaa4c]  thread_entry(JavaThread*, Thread*)+0x6cV  [libjvm.so+0xa224cb]  JavaThread::thread_main_inner()+0xdbV  [libjvm.so+0xa22816]  JavaThread::run()+0x316V  [libjvm.so+0x8c4202]  java_start(Thread*)+0x102C  [libpthread.so.0+0x76ba]  start_thread+0xca {code}   This one is from a month previous and has a deeper stack... we're trying to read a Cell...   {code:java} Stack: [0x00007fa1d5fb8000,0x00007fa1d60b9000],  sp=0x00007fa1d60b7660,  free space=1021kNative frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)J 30665 C2 org.apache.hadoop.hbase.PrivateCellUtil.matchingFamily(Lorg/apache/hadoop/hbase/Cell;[BII)Z (59 bytes) @ 0x00007fcc2d29eeb2 [0x00007fcc2d29e7c0+0x6f2]J 25816 C2 org.apache.hadoop.hbase.CellUtil.matchingFamily(Lorg/apache/hadoop/hbase/Cell;[B)Z (28 bytes) @ 0x00007fcc2a0430f8 [0x00007fcc2a0430e0+0x18]J 17236 C2 org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALActionListener$$Lambda$254.test(Ljava/lang/Object;)Z (8 bytes) @ 0x00007fcc2b40bc68 [0x00007fcc2b40bc20+0x48]J 13735 C2 java.util.ArrayList$ArrayListSpliterator.tryAdvance(Ljava/util/function/Consumer;)Z (79 bytes) @ 0x00007fcc2b7d936c [0x00007fcc2b7d92c0+0xac]J 17162 C2 java.util.stream.MatchOps$MatchOp.evaluateSequential(Ljava/util/stream/PipelineHelper;Ljava/util/Spliterator;)Ljava/lang/Object; (7 bytes) @ 0x00007fcc29bc05e8 [0x00007fcc29bbfe80+0x768]J 16934 C2 org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALActionListener.visitLogEntryBeforeWrite(Lorg/apache/hadoop/hbase/wal/WALKey;Lorg/apache/hadoop/hbase/wal/WALEdit;)V (10 bytes) @ 0x00007fcc2bb313f8 [0x00007fcc2bb30c60+0x798]J 30732 C2 org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.appendAndSync()V (261 bytes) @ 0x00007fcc2ae5a420 [0x00007fcc2ae59d60+0x6c0]J 22203 C2 org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.consume()V (474 bytes) @ 0x00007fcc2a987420 [0x00007fcc2a987200+0x220]J 16857 C2 org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL$$Lambda$126.run()V (8 bytes) @ 0x00007fcc2b0bf28c [0x00007fcc2b0bf260+0x2c]J 13721% C2 java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V (225 bytes) @ 0x00007fcc2b7d77c0 [0x00007fcc2b7d7240+0x580]j  java.util.concurrent.ThreadPoolExecutor$Worker.run()V+5j  java.lang.Thread.run()V+11v  ~StubRoutines::call_stub {code}" Set version as 3.0.0-alpha-2-SNAPSHOT in master,13390824,Resolved,Major,Fixed,20/Jul/21 04:24,20/Jul/21 15:05,, Add 3.0.0-alpha-1 to download page,13390823,Resolved,Major,Fixed,20/Jul/21 04:23,20/Jul/21 15:05,, TestingHBaseCluster should support running MapReduce jobs,13390992,Open,Major,,20/Jul/21 20:06,,3.0.0-alpha-1,"The existing HBaseTestingUtility optionally allows users to start a mini-YARN cluster for the purpose of running MapReduce jobs, such as testing applications that use HBase's MapReduce integration. The new TestingHBaseCluster is a cleaner interface than HBTU, but exposes less functionality, and in particular does not seem to allow for starting a YARN minicluster. This would make it difficult to use in some common circumstances, such as testing Phoenix's index builds, which use MapReduce. Many downstream projects that depend on HBase may also have batch logic done as MapReduce or other kinds of YARN jobs." "Copy HBTU to hbase-testing-util, rename the HBTU related classes in hbase-server and mark them as IA.LimitedPrivate",13388838,Resolved,Major,Fixed,10/Jul/21 15:31,19/Jul/21 13:01,,"See the discussions in the parent issue on why we want to do this. This is the final decision: https://issues.apache.org/jira/browse/HBASE-13126?focusedCommentId=17358108&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17358108 Maybe a possible way is that, we mark HBTU as deprecated and introduce another class for end users to use. And on the next major release, we just introduce a another class in hbase-server for our internal usage, and copy the whole HBTU related classes to hbase-testing-util module, and keep them there for a whole major release, and then we remove them when the next major release is out. So end users will have plenty of time to change their code." Put up 3.0.0-alpha-1RC0,13387170,Resolved,Major,Fixed,02/Jul/21 01:35,20/Jul/21 04:21,, Support MOB when do compaction offload,13389373,Resolved,Major,Fixed,13/Jul/21 11:33,15/Jul/21 06:21,, Mark LocalHBaseCluster as IA.Private,13388885,Resolved,Major,Fixed,11/Jul/21 14:06,13/Jul/21 07:49,,"It is not for end users to use directly in code, we just use it when starting hbase in local mode." Tooling to auto-convert 1.7.0 serialized tables to 1.7.1 compatible tables,13387972,Resolved,Major,Fixed,06/Jul/21 16:16,08/Jul/21 04:19,1.7.0,"As discussed in the parent issue, 1.7.0 introduced an incompatible table serialization change. We need tooling that auto converts these into 1.7.1 compatible table descriptors and table states." testLogLevelByHttps/testLogLevelByHttpsWithSpnego consistently failing on branch-1,13388428,Resolved,Major,Fixed,08/Jul/21 16:25,09/Jul/21 05:47,1.7.0,"In prep-ing for 1.7.1, I noticed that this test has been consistently failing on branch-1 forever. {noformat} Regression health checks / yetus jdk8 hadoop2 checks / org.apache.hadoop.hbase.http.log.TestLogLevel.testLogLevelByHttpsWithSpnego Failing for the past 1 build (Since Failed#145 ) Took 0.79 sec. Error Message Expected to find 'Unexpected end of file from server' but got unexpected exception:java.net.SocketException: Connection reset at java.net.SocketInputStream.read(SocketInputStream.java:210) at java.net.SocketInputStream.read(SocketInputStream.java:141) at java.io.BufferedInputStream.fill(BufferedInputStream.java:246) at java.io.BufferedInputStream.read1(BufferedInputStream.java:286) at java.io.BufferedInputStream.read(BufferedInputStream.java:345) at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:743) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:678) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:702) at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1593) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498) at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480) at org.apache.hadoop.security.authentication.client.KerberosAuthenticator.authenticate(KerberosAuthenticator.java:189) at org.apache.hadoop.security.authentication.client.AuthenticatedURL.openConnection(AuthenticatedURL.java:347) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.connect(LogLevel.java:268) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.process(LogLevel.java:284) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.doGetLevel(LogLevel.java:227) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.sendLogLevelRequest(LogLevel.java:123) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.run(LogLevel.java:107) at org.apache.hadoop.hbase.http.log.TestLogLevel.getLevel(TestLogLevel.java:349) at org.apache.hadoop.hbase.http.log.TestLogLevel.access$000(TestLogLevel.java:68) at org.apache.hadoop.hbase.http.log.TestLogLevel$1.run(TestLogLevel.java:325) at org.apache.hadoop.hbase.http.log.TestLogLevel$1.run(TestLogLevel.java:322) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1844) at org.apache.hadoop.hbase.http.log.TestLogLevel.testDynamicLogLevel(TestLogLevel.java:322) at org.apache.hadoop.hbase.http.log.TestLogLevel.testDynamicLogLevel(TestLogLevel.java:277) at org.apache.hadoop.hbase.http.log.TestLogLevel.testLogLevelByHttpsWithSpnego(TestLogLevel.java:451) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) Stacktrace java.lang.AssertionError: Expected to find 'Unexpected end of file from server' but got unexpected exception:java.net.SocketException: Connection reset at java.net.SocketInputStream.read(SocketInputStream.java:210) at java.net.SocketInputStream.read(SocketInputStream.java:141) at java.io.BufferedInputStream.fill(BufferedInputStream.java:246) at java.io.BufferedInputStream.read1(BufferedInputStream.java:286) at java.io.BufferedInputStream.read(BufferedInputStream.java:345) at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:743) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:678) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:702) at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1593) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498) at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480) at org.apache.hadoop.security.authentication.client.KerberosAuthenticator.authenticate(KerberosAuthenticator.java:189) at org.apache.hadoop.security.authentication.client.AuthenticatedURL.openConnection(AuthenticatedURL.java:347) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.connect(LogLevel.java:268) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.process(LogLevel.java:284) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.doGetLevel(LogLevel.java:227) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.sendLogLevelRequest(LogLevel.java:123) at org.apache.hadoop.hbase.http.log.LogLevel$CLI.run(LogLevel.java:107) at org.apache.hadoop.hbase.http.log.TestLogLevel.getLevel(TestLogLevel.java:349) at org.apache.hadoop.hbase.http.log.TestLogLevel.access$000(TestLogLevel.java:68) at org.apache.hadoop.hbase.http.log.TestLogLevel$1.run(TestLogLevel.java:325) at org.apache.hadoop.hbase.http.log.TestLogLevel$1.run(TestLogLevel.java:322) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1844) at org.apache.hadoop.hbase.http.log.TestLogLevel.testDynamicLogLevel(TestLogLevel.java:322) at org.apache.hadoop.hbase.http.log.TestLogLevel.testDynamicLogLevel(TestLogLevel.java:277) at org.apache.hadoop.hbase.http.log.TestLogLevel.testLogLevelByHttpsWithSpnego(TestLogLevel.java:451) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) at org.apache.hadoop.hbase.http.log.TestLogLevel.exceptionShouldContains(TestLogLevel.java:479) at org.apache.hadoop.hbase.http.log.TestLogLevel.testLogLevelByHttpsWithSpnego(TestLogLevel.java:456) Caused by: java.net.SocketException: Connection reset at org.apache.hadoop.hbase.http.log.TestLogLevel.getLevel(TestLogLevel.java:349) at org.apache.hadoop.hbase.http.log.TestLogLevel.access$000(TestLogLevel.java:68) at org.apache.hadoop.hbase.http.log.TestLogLevel.testDynamicLogLevel(TestLogLevel.java:322) at org.apache.hadoop.hbase.http.log.TestLogLevel.testDynamicLogLevel(TestLogLevel.java:277) at org.apache.hadoop.hbase.http.log.TestLogLevel.testLogLevelByHttpsWithSpnego(TestLogLevel.java:451) Standard Output Connecting to https://localhost:34625/logLevel?log=org.apache.hadoop.hbase.http.log.TestLogLevel Submitted Log Name: org.apache.hadoop.hbase.http.log.TestLogLevel Log Class: org.apache.commons.logging.impl.Log4JLogger Effective level: DEBUG Connecting to https://localhost:34625/logLevel?log=org.apache.hadoop.hbase.http.log.TestLogLevel&level=DEBUG Submitted Log Name: org.apache.hadoop.hbase.http.log.TestLogLevel Log Class: org.apache.commons.logging.impl.Log4JLogger Submitted Level: DEBUG Setting Level to DEBUG ... Effective level: DEBUG Connecting to http://localhost:42799/logLevel?log=org.apache.hadoop.hbase.http.log.TestLogLevel Standard Error 2021-07-08 13:56:31,715 INFO [main] hbase.ResourceChecker(178): after: http.log.TestLogLevel#testErrorLogLevel Thread=17 (was 13) Potentially hanging thread: NioProcessor-3 sun.nio.ch.EPollArrayWrapper.epollWait(Native Method) sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269) sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93) sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86) sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97) org.apache.mina.transport.socket.nio.NioProcessor.select(NioProcessor.java:72) org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:1077) org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) Potentially hanging thread: Keep-Alive-Timer java.lang.Thread.sleep(Native Method) sun.net.www.http.KeepAliveCache.run(KeepAliveCache.java:172) java.lang.Thread.run(Thread.java:748) Potentially hanging thread: NioProcessor-2 sun.nio.ch.EPollArrayWrapper.epollWait(Native Method) sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269) sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93) sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86) sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97) org.apache.mina.transport.socket.nio.NioProcessor.select(NioProcessor.java:72) org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:1077) org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) Potentially hanging thread: NioProcessor-1 sun.nio.ch.EPollArrayWrapper.epollWait(Native Method) sun.nio.ch.EPollArrayWrapper.poll(EPollArrayWrapper.java:269) sun.nio.ch.EPollSelectorImpl.doSelect(EPollSelectorImpl.java:93) sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:86) sun.nio.ch.SelectorImpl.select(SelectorImpl.java:97) org.apache.mina.transport.socket.nio.NioProcessor.select(NioProcessor.java:72) org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:1077) org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) - Thread LEAK? -, OpenFileDescriptor=280 (was 279) - OpenFileDescriptor LEAK? -, MaxFileDescriptor=1048576 (was 1048576), SystemLoadAverage=513 (was 428) - SystemLoadAverage LEAK? -, ProcessCount=7 (was 7), AvailableMemoryMB=2522 (was 2579), ConnectionCount=0 (was 0) 2021-07-08 13:56:31,737 INFO [main] hbase.ResourceChecker(150): before: http.log.TestLogLevel#testLogLevelByHttpsWithSpnego Thread=17, OpenFileDescriptor=280, MaxFileDescriptor=1048576, SystemLoadAverage=513, ProcessCount=7, AvailableMemoryMB=2521, ConnectionCount=0 2021-07-08 13:56:31,744 INFO [Time-limited test] http.HttpRequestLog(69): Http request log for http.requests... is not defined 2021-07-08 13:56:31,748 INFO [Time-limited test] http.HttpServer(881): Added global filter 'safety' (class=org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter) 2021-07-08 13:56:31,748 INFO [Time-limited test] http.HttpServer(881): Added global filter 'clickjackingprevention' (class=org.apache.hadoop.hbase.http.ClickjackingPreventionFilter) 2021-07-08 13:56:31,749 INFO [Time-limited test] http.HttpServer(739): ASYNC_PROFILER_HOME environment variable and async.profiler.home system property not specified. Disabling /prof endpoint. 2021-07-08 13:56:31,749 INFO [Time-limited test] http.HttpServer(881): Added global filter 'SpnegoFilter' (class=org.apache.hadoop.security.authentication.server.AuthenticationFilter) 2021-07-08 13:56:31,801 INFO [Time-limited test] http.HttpServer(1112): Jetty bound to port 34625 2021-07-08 13:56:31,803 INFO [Time-limited test] log.Slf4jLog(67): jetty-6.1.26 2021-07-08 13:56:31,848 INFO [Time-limited test] log.Slf4jLog(67): Started SslSocketConnectorSecure@localhost:34625 2021-07-08 13:56:32,154 WARN [NioProcessor-2] protocol.KerberosProtocolHandler(241): KDC cannot accommodate requested option (13) 2021-07-08 13:56:32,154 WARN [NioProcessor-2] protocol.KerberosProtocolHandler(242): KDC cannot accommodate requested option (13) 2021-07-08 13:56:32,287 WARN [NioProcessor-1] protocol.KerberosProtocolHandler(241): KDC cannot accommodate requested option (13) 2021-07-08 13:56:32,287 WARN [NioProcessor-1] protocol.KerberosProtocolHandler(242): KDC cannot accommodate requested option (13) 2021-07-08 13:56:32,338 INFO [Time-limited test] log.Slf4jLog(67): Stopped SslSocketConnectorSecure@localhost:0 2021-07-08 13:56:32,445 INFO [Time-limited test] http.HttpRequestLog(69): Http request log for http.requests... is not defined 2021-07-08 13:56:32,445 INFO [Time-limited test] http.HttpServer(881): Added global filter 'safety' (class=org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter) 2021-07-08 13:56:32,445 INFO [Time-limited test] http.HttpServer(881): Added global filter 'clickjackingprevention' (class=org.apache.hadoop.hbase.http.ClickjackingPreventionFilter) 2021-07-08 13:56:32,446 INFO [Time-limited test] http.HttpServer(739): ASYNC_PROFILER_HOME environment variable and async.profiler.home system property not specified. Disabling /prof endpoint. 2021-07-08 13:56:32,447 INFO [Time-limited test] http.HttpServer(881): Added global filter 'SpnegoFilter' (class=org.apache.hadoop.security.authentication.server.AuthenticationFilter) 2021-07-08 13:56:32,448 INFO [Time-limited test] http.HttpServer(1112): Jetty bound to port 42799 2021-07-08 13:56:32,448 INFO [Time-limited test] log.Slf4jLog(67): jetty-6.1.26 2021-07-08 13:56:32,483 INFO [Time-limited test] log.Slf4jLog(67): Started SslSocketConnectorSecure@localhost:42799 2021-07-08 13:56:32,506 WARN [1853592968@qtp-1232647843-0] log.Slf4jLog(89): EXCEPTION javax.net.ssl.SSLException: Unsupported or unrecognized SSL message at sun.security.ssl.SSLSocketInputRecord.handleUnknownRecord(SSLSocketInputRecord.java:440) at sun.security.ssl.SSLSocketInputRecord.decode(SSLSocketInputRecord.java:175) at sun.security.ssl.SSLTransport.decode(SSLTransport.java:110) at sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1197) at sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1106) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:398) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:370) at org.mortbay.jetty.security.SslSocketConnector$SslConnection.run(SslSocketConnector.java:708) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582) 2021-07-08 13:56:32,510 WARN [1853592968@qtp-1232647843-0] log.Slf4jLog(89): EXCEPTION javax.net.ssl.SSLException: Unsupported or unrecognized SSL message at sun.security.ssl.SSLSocketInputRecord.handleUnknownRecord(SSLSocketInputRecord.java:440) at sun.security.ssl.SSLSocketInputRecord.decode(SSLSocketInputRecord.java:175) at sun.security.ssl.SSLTransport.decode(SSLTransport.java:110) at sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1197) at sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1106) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:398) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:370) at org.mortbay.jetty.security.SslSocketConnector$SslConnection.run(SslSocketConnector.java:708) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582) 2021-07-08 13:56:32,511 INFO [Time-limited test] log.Slf4jLog(67): Stopped SslSocketConnectorSecure@localhost:0 REST API CloudBees CI Client Master 2.263.4.2-rolling {noformat}" Remove HStore.compactRecentForTestingAssumingDefaultPolicy and DefaultCompactor.compactForTesting,13387958,Resolved,Major,Fixed,06/Jul/21 14:45,07/Jul/21 14:02,,We should try our best to not include testing code in normal code. The last assertion in TestHStore.testRefreshStoreFilesNotChanged is wrong,13387942,Resolved,Major,Fixed,06/Jul/21 13:29,07/Jul/21 06:57,,"The number of call times will not be reset so the last assertion should not be 0, and why it could pass now is because we pass null to the verification while we will never call this method with null..." The page for hbase on downloads.apache.org is incorrect,13387639,Resolved,Major,Fixed,05/Jul/21 05:40,07/Jul/21 01:37,,"It still says that 2.2.x is our stable release line. We need to change this file https://dist.apache.org/repos/dist/release/hbase/HEADER.html" StripeStoreFileManager does not need to throw IOException for most methods,13387638,Resolved,Major,Fixed,05/Jul/21 05:33,05/Jul/21 14:31,,"All the operations are in memory only, expect getSplitPoint. We just throw IOException when we do some checks in code and the checks fail. In general, I think it is better to throw RuntimeException other than IOException, " Add TableDescriptor attribute 'COMPACTION_OFFLOAD_ENABLED',13387028,Resolved,Major,Fixed,01/Jul/21 11:24,06/Jul/21 14:21,, Remove reflections used to access Hadoop 2 API in FanOutOneBlockAsyncDFSOutputHelper,13386940,Resolved,Major,Fixed,01/Jul/21 03:24,02/Jul/21 09:02,,"Remove the reflections used to access Hadoop 2 APIs in HBase 3.x. There are still a number of reflections we can't remove now." Set version as 3.0.0-alpha-1 in master in prep for first RC of 3.0.0-alpha-1,13387082,Resolved,Major,Fixed,01/Jul/21 14:47,01/Jul/21 23:51,, Add download links for 2.4.5,13392834,Resolved,Minor,Fixed,30/Jul/21 23:35,30/Jul/21 23:35,, Master UI hbck should provide a JSON formatted output option,13394817,Resolved,Minor,Fixed,12/Aug/21 05:03,08/Apr/24 21:45,,"It used to be possible to get hbck's verdict of cluster status from the command line, especially useful for headless deployments, i.e. without requiring a browser with sufficient connectivity to load a UI, or scrape information out of raw HTML, or write regex to comb over log4j output. The hbck tool's output wasn't particularly convenient to parse but it was straightforward to extract the desired information with a handful of regular expressions. HBCK2 has a different design philosophy than the old hbck, which is to serve as a collection of small and discrete recovery and repair functions, rather than attempt to be a universal repair tool. This makes a lot of sense and isn't the issue at hand. Unfortunately the old hbck's utility for reporting the current cluster health assessment has not been replaced either in whole or in part. Instead: {quote} HBCK2 is for fixes. For listings of inconsistencies or blockages in the running cluster, you go elsewhere, to the logs and UI of the running cluster Master. Once an issue has been identified, you use the HBCK2 tool to ask the Master to effect fixes or to skip-over bad state. Asking the Master to make the fixes rather than try and effect the repair locally in a fix-it tool's context is another important difference between HBCK2 and hbck1. {quote} Developing custom tooling to mine logs and scrape UI simply to gain a top level assessment of system health is unsatisfying. There should be a convenient means for querying the system if issues that rise to the level of _inconsistency_, in the hbck parlance, are believed to be present. It would be relatively simple to bring back the experience of invoking a command line tool to deliver a verdict. This could be added to the hbck2 tool itself but given that hbase-operator-tools is a separate project an intrinsic solution is desirable. An option that immediately comes to mind is modification of the Master's hbck.jsp page to provide a JSON formatted output option if the HTTP Accept header asks for text/json. However, looking at the source of hbck.jsp, it makes more sense to leave it as is and implement a convenient machine parseable output format elsewhere. This can be trivially accomplished with a new servlet. Like hbck.jsp the servlet implementation would get a reference to HbckChore and present the information this class makes available via its various getters. The machine parseable output is sufficient to enable headless hbck status checking but it still would be nice if we could provide operators a command line tool that formats the information for convenient viewing in a terminal. That part could be implemented in the hbck2 tool after this proposal is implemented." Supports revoke @ns specified permission,13396064,In Progress,Minor,,19/Aug/21 08:29,,2.3.4,"The current version does not support reclaiming the specified permissions，Only all permissions of @NS can be reclaimed。 Supports revoke @ns specified permission :revoke 'bobsmith', '@ns1', 'WRCA' !1.jpeg!" let hbase.mapreduce.bulkload.assign.sequenceNumbers take effect in SecureBulkLoadManager.secureBulkLoadHFiles,13397396,Resolved,Minor,Won't Fix,26/Aug/21 03:11,17/Jan/23 06:17,,"HBASE-10958 Call Flush before BulkLoad to obtain the latest sequenceID to prevent data loss during replay. '_hbase.mapreduce.bulkload.assign.sequenceNumbers_' controls whether to flush before BulkLoad, but we pass true to whether to flush in *SecureBulkLoadManager*. If we bulkload frequently we flush a lot of small files. Can we make 'hbase.mapreduce.bulkload.assign.sequenceNumbers' work in SecureBulkLoadManager? This passes -1 to sequenceId, we won't loss data. SecureBulkLoadManager.java.  secureBulkLoadHFiles {code:java} // code placeholder return region.bulkLoadHFiles(familyPaths, true, new SecureBulkLoadListener(fs, bulkToken, conf), request.getCopyFile(), clusterIds, request.getReplicate()); {code} Hregion.java {code:java} // code placeholder public Map> bulkLoadHFiles(Collection> familyPaths, boolean assignSeqId, BulkLoadListener bulkLoadListener, boolean copyFile, List clusterIds, boolean replicate) {code}  " [branch-2.4] Flaky tests,13399299,Resolved,Minor,Fixed,03/Sep/21 16:24,06/Oct/22 17:26,2.4.6,"Findings listed below. Address on/with subtasks. org.apache.hadoop.hbase.namequeues.TestSlowLogAccessor.testHigherSlowLogs [~vjasani] {quote} {noformat} java.lang.AssertionError: Waiting timed out after [7,000] msec at org.junit.Assert.fail(Assert.java:89) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:203) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:137) at org.apache.hadoop.hbase.HBaseCommonTestingUtility.waitFor(HBaseCommonTestingUtility.java:253) at org.apache.hadoop.hbase.namequeues.TestSlowLogAccessor.testHigherSlowLogs(TestSlowLogAccessor.java:211) {noformat} {quote} org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStreamFSHLog.testSizeOfLogQueue [~shahrs87] {quote} {noformat} java.lang.AssertionError: expected:<1> but was:<2> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testSizeOfLogQueue(TestBasicWALEntryStream.java:701) {noformat} {quote} org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe.testScanAfterDeletingSpecifiedRow (committer no longer active) {quote} {noformat} java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hbase.client.TestFromClientSide3.testScanAfterDeletingSpecifiedRow(TestFromClientSide3.java:206) {noformat} {quote} org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testReplicationSourceInitializingMetric [~sandeep.pal] {quote} {noformat} java.lang.AssertionError: Waiting timed out after [1,000] msec at org.junit.Assert.fail(Assert.java:89) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:203) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:137) at org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testReplicationSourceInitializingMetric(TestReplicationSource.java:583) {noformat} {quote} org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions.testCellPermissionwithVersions [~apurtell] {quote} {noformat} java.lang.AssertionError: expected:<1> but was:<2> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:181) at org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions.testCellPermissionwithVersions(TestCellACLWithMultipleVersions.java:243) {noformat} {quote} org.apache.hadoop.hbase.client.TestMasterAddressRefresher " update error message when executing deleteall with ROWPREFIXFILTER in meta table,13400405,Resolved,Minor,Fixed,10/Sep/21 08:55,16/Mar/22 12:31,2.4.11,"ROWPREFIXFILTER doesn't work when execute deleteall with table hbase:meta。   {code:java} def _deleteall_internal(row, column = nil, timestamp = org.apache.hadoop.hbase.HConstants::LATEST_TIMESTAMP, args = {}, all_version = true) # delete operation doesn't need read permission. Retaining the read check for # meta table as a part of HBASE-5837. if is_meta_table? raise ArgumentError, 'Row Not Found' if _get_internal(row).nil? end if row.is_a?(Hash) _deleterows_internal(row, column, timestamp, args, all_version) else d = _createdelete_internal(row, column, timestamp, args, all_version) @table.delete(d) end end {code}   If we allow ROWPREFIXFILTER of deleteall on hbase:meta, we should fix the check condition, If we don't allow, we should modify the exception message.    " MetricsHBaseServer should record all kinds of Exceptions,13393694,Resolved,Minor,Fixed,05/Aug/21 11:41,24/Mar/22 11:11,2.4.11,"We can define a kind of Exception such as OtherExcpetions to record exceptions doesn't in the following kinds of exceptions. Only debug those exceptions by LOG.debug(""Unknown exception type"", throwable); is not helpful to find errors. {code:java} if (throwable != null) { if (throwable instanceof OutOfOrderScannerNextException) { source.outOfOrderException(); } else if (throwable instanceof RegionTooBusyException) { source.tooBusyException(); } else if (throwable instanceof UnknownScannerException) { source.unknownScannerException(); } else if (throwable instanceof ScannerResetException) { source.scannerResetException(); } else if (throwable instanceof RegionMovedException) { source.movedRegionException(); } else if (throwable instanceof NotServingRegionException) { source.notServingRegionException(); } else if (throwable instanceof FailedSanityCheckException) { source.failedSanityException(); } else if (throwable instanceof MultiActionResultTooLarge) { source.multiActionTooLargeException(); } else if (throwable instanceof CallQueueTooBigException) { source.callQueueTooBigException(); } else if (throwable instanceof QuotaExceededException) { source.quotaExceededException(); } else if (throwable instanceof RpcThrottlingException) { source.rpcThrottlingException(); } else if (LOG.isDebugEnabled()) { LOG.debug(""Unknown exception type"", throwable); } } {code} !RequestTooBigException.png|width=787,height=336!    " Better logging in CanaryTool,13396792,Resolved,Minor,Fixed,24/Aug/21 00:21,30/Jun/22 15:38,,CanaryTool logs currently don't indicate which mode they pertain to – they should at least make note of that. Make it easier to orchestrate rolling upgrades,13403164,Open,Minor,,24/Sep/21 14:10,,,"In order to orchestrate rolling upgrades, we need a way to query VersionInfo on a per-server basis. Currently I can see version exposed in two ways: * One can hit the /dump endpoint, but this creates a ton of extra output and is not machine parseable. * One can call Admin.getClusterMetrics() with Option.HBASE_VERSION, but the resulting response only has a single getHBaseVersion() which only represents the version for the active HMaster We could make it a lot easier to orchestrate rolling upgrades if we exposed the VersionInfo details for all servers in the cluster. At a minimum I think we could add it to the /jmx response, but it would also be very helpful to add it to Admin." Add support for reloading balancer configs with BalanceRequest,13399028,Open,Minor,,02/Sep/21 21:46,,,"It's currently a pain to iterate on balancer configs. You need to make changes in hbase-site.xml, then find the full ServerName for the active HMaster, then execute {{update_configuration ''}}in the shell, then run the balancer. Finding the ServerName is actually quite annoying. The best way I've found is to look at the JMX dump and find {{tag.serverName}}, but that takes a bunch of steps.  We can make this a good deal more convenient by adding direct support for reloading the balancer configs into the {{balance}} command. This could look something like: {{shell> balance \{RELOAD_CONFIGS => true}}} Alternatively, we could add another string arg like: {{shell> balance 'reload_config'}} Either way, we'd add a new {{BalanceRequest$Builder#setReloadConfig(boolean)}}." Avoid merging regions if tables has not reached the state where regions are not split because of number of regions,13388297,Resolved,Minor,Not A Problem,08/Jul/21 06:04,24/Feb/22 13:28,1.7.0,"we have a table on a cluster with 100 regions with default split policy (SteppingSplitPolicy). This is a small table and will not get loaded with too much data. Now if region size of table is smaller than the normalizer target region size than there are chances that normalizer will consider the regions for merges. But since the number of regions are small split policy will trigger split on next flush. This is a continuous loop and our cluster will be busy in these two actions. We plan to consider number of regions and number of regionservers in creating plans for normalizer." Clean shared state pollution to avoid flaky tests.,13396514,Open,Minor,,22/Aug/21 03:44,,,"h4. PR Link:[https://github.com/apache/hbase/pull/3615]  h2. What is the purpose of this change * This PR cleans the state polluted by {{org.apache.hadoop.hbase.monitoring.TestTaskMonitor.testDoNotPurgeRPCTask}}. * It may be better to clean state pollutions so that some other tests won't fail in the future due to the shared state pollution. h2. Reproduce the test failure * Run the test twice in the same JVM. h2. Expected result: * The tests should run successfully when multiple tests that use this state are run in the same JVM. h2. Actual result: * We get the failure: {{[ERROR] Failures: [ERROR] testDoNotPurgeRPCTask:144 RPC Tasks have been purged! expected:<10> but was:<20>}} h2. Why the test fails * Each time this test runs,10 RPCtasks are created and added to the ArrayList {{rpcTasks}}, but {{rpcTasks}} is not completely purged when the test ends. So next time the test starts, the remaining RPC tasks lead to an assertion failure. h2. Fix * Clean all tasks when the test ends. * Another solution is to create a new {{TaskMonitor}} each time to avoid pollution similar to the other tests (e.g., {{testTaskMonitorBasics}}, {{testTasksGetAbortedOnLeak}}) in {{TestTaskMonitor}}. [Create a new TaskMonitor each time to avoid flaky tests. LALAYANG/hbase#1|https://github.com/LALAYANG/hbase/pull/1]" MapReduceBackupCopyJob.BackupDistCp.getKey() splicing strings in a loop,13393614,Open,Minor,,05/Aug/21 03:51,,,"MapReduceBackupCopyJob.BackupDistCp.getKey() concatenates strings in a loop, should consider using StringBuilder to concatenate string." Downgrading is complicated by refusal to assign system tables to lower version,13403210,Open,Minor,,24/Sep/21 19:46,,,"I was doing some rolling downgrades of test clusters and keep getting into a state where my automation gets stuck trying to drain the final RegionServer in the cluster. At this point that RegionServer hosts 3 regions: meta, quota, namespace. The HMaster is outputting logs like: ""Passed destination servername is null/empty so choosing a server at random"". I's very hard to understand what's happening based on that log, so you really have to look at the code. Tracking down that log line, it becomes somewhat clear that you are getting trapped by AssignmentManager.getExcludedServersForSystemTable(). Looking at the code, you can see comments related to ""hbase.min.version.move.system.tables"" config, but the comments are very unclear. What should I set this to? This setting was added in https://issues.apache.org/jira/browse/HBASE-22923 which focuses mostly on RSGroup, but this issue is affecting clusters that do not use RSGroup. The release note also is not super clear. It would be great to clarify the docs to help the operator know what to change this to, or perhaps make the config itself more intuitive. For example, could we just make it an allowlist of versions that can hold system tables? At that point my path is clear: add the version I'm downgrading to to the allowlist. This issue is also exacerbated by the fact that by the time you've realized this you're in a somewhat tricky situation where there's only 1 RegionServer left and your only way around it is to force stop it or to push a new config and rolling restart your HMasters. It would be great if this setting were able to be updated via Admin or at the very least reloadable with ConfigurationObserver." Move NavigableSet add operation to writer thread in BucketCache,13403982,Resolved,Minor,Fixed,29/Sep/21 02:29,01/Oct/21 13:27,,We currently use a ConcurrentSkipList to store blocks by HFile in bucket cache. The average time complexity of the add function is O(logn). We can move this time costly to the writer threads to reduce the response latency of read requests. I have tested the time cost of function cacheBlock in BucketCache and attached the metrics screenshots. Fix TestMaster#testMoveRegionWhenNotInitialized with hbase.min.version.move.system.tables,13394250,Resolved,Minor,Fixed,09/Aug/21 14:43,12/Aug/21 09:02,,"In order to protect meta region movement unexpectedly during upgrade with rsGroup enabled, it is good practice to keep hbase.min.version.move.system.tables in hbase-default for specific branch so that the use-case for the specific version of HBase is well under control. However, TestMaster#testMoveRegionWhenNotInitialized would fail because it would not find server to move meta to. We should fix this.   {code:java} INFO [Time-limited test] master.HMaster(2029): Passed destination servername is null/empty so choosing a server at random java.lang.UnsupportedOperationExceptionjava.lang.UnsupportedOperationException at java.util.AbstractList.add(AbstractList.java:148) at java.util.AbstractList.add(AbstractList.java:108) at org.apache.hadoop.hbase.master.HMaster.move(HMaster.java:2031) at org.apache.hadoop.hbase.master.TestMaster.testMoveRegionWhenNotInitialized(TestMaster.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) {code}  " StochasticLoadBalancer metrics should update even if balancer doesn't run,13399017,Resolved,Minor,Fixed,02/Sep/21 20:01,29/Sep/21 13:26,,"Currently we only update StochasticLoadBalancerMetrics at the very end of a balancer run, once a plan has been found. In fact, we update the metrics based on that plan even if we don't end up executing the plan, which seems incorrect.  Regardless of whether the balancer decides to run or not, cluster costs are changing all the time. Since we don't update these metrics any other time, operators miss out on important information about the balance of their cluster over time.  I briefly looked into it and it would be relatively trivial to add another call to updateStochasticCosts at the beginning of the balanceTable method, before we determine if the cluster is in need of balancing. This would be an improvement but would still miss cases where the balancer is disabled or unable to run due to regions in transition, etc. It would be good if we could make it so updateStochasticCosts get called periodically regardless of whether the balancer is enabled or can run." Store configuration loss when use update_config,13399946,Resolved,Minor,Fixed,08/Sep/21 10:09,22/Sep/21 11:33,,"When use update_config shell command, some store configuration is loss. When initialize store, the conf is set by: {code:java} this.conf = new CompoundConfiguration() .add(confParam) .addBytesMap(region.getTableDescriptor().getValues()) .addStringMap(family.getConfiguration()) .addBytesMap(family.getValues()); {code} when change configuration, the conf is set by: {code:java} this.conf = new CompoundConfiguration() .add(conf) .addBytesMap(getColumnFamilyDescriptor().getValues()); {code}" Provide getConfiguration method for Region and Store interface,13400196,Resolved,Minor,Fixed,09/Sep/21 09:09,22/Sep/21 03:43,,"In [HBASE-26261|https://issues.apache.org/jira/browse/HBASE-26261],  [~zhangduo] suggest that we should provide getConfiguration method for Region and Store interface" RegionServer ignored a procedure dute to repeatedly opening which lead region stuck in RIT,13400914,Open,Minor,,14/Sep/21 03:44,,2.3.5,"       when hbase cluster shut down Suddenlly,  there are some repeatedly opening regions and cause them to stuck in RTI。we found org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler#process() directly return when handle repeatedly opening regions， and don't report to master,  master unable to  process next status for this procedure， and regions stuck in RIT。so can we  do like this: #  AssignRegionHandler report the region is online if regionserver found the region is online, # or AssignRegionHandler report the region is failed online if regionserver found the region is online, let Hmater to retry。 please give some suggestions, thanks ! {code:java} // code placeholder Region onlineRegion = rs.getRegion(encodedName); if (onlineRegion != null) { LOG.warn(""Received OPEN for the region:{}, which is already online"", regionName); // Just follow the old behavior, do we need to call reportRegionStateTransition? Maybe not? // For normal case, it could happen that the rpc call to schedule this handler is succeeded, // but before returning to master the connection is broken. And when master tries again, we // have already finished the opening. For this case we do not need to call // reportRegionStateTransition any more. return; } {code}  " Add Admin and shell method to dynamically update master configurations,13401932,Open,Minor,,17/Sep/21 22:09,,,"It's possible to update master configuration by using update_config '', or use update_all_config to update all regionservers and masters. The former is annoying because you need to find the master's full servername. Unlike regionservers, this is sort of hard to find. The latter is not great because it has to iterate ALL servers in the cluster, which might take a while for large clusters and not be what you want generally. We should add an option to reload all master configurations. I could imagine this as a update_master_config, or maybe update_all_config 'master'. Shell used for illustration here, but this all applies to Admin interface as well." Update downloads.xml for release 2.4.6,13400892,Resolved,Minor,Fixed,13/Sep/21 23:42,14/Sep/21 00:09,, Improve computation complexity for primaryRegionCountSkewCostFunctio,13398101,Resolved,Minor,Fixed,30/Aug/21 03:27,08/Sep/21 22:53,,Recomputation of primaryRegionCountSkewCostFunction can be reduced from O(n ) to O(1) by only incrementing the destination and decrementing the source instead of full recompute. "Revert 26240, Apply InterfaceAudience.Private to BalanceResponse$Builder",13400439,Resolved,Minor,Fixed,10/Sep/21 11:46,10/Sep/21 15:13,, Improve developer docs for InterfaceAudience of public experimental APIs,13400034,Open,Minor,,08/Sep/21 15:42,,,"Per [https://lists.apache.org/thread.html/re7736008a7619029bf34ed81f5931c537281d22788719f2dcf37f0c0%40%3Cdev.hbase.apache.org%3E,] our InterfaceAudience.Public restrictions intentionally deviate from the default yetus docs, and we would like to keep it that way. It was acknowledged that there may be a reason to expose early access to certain APIs that may need to evolve in breaking ways. The suggested approach is to annotate these as InterfaceAudience.LimitedPrivate. We should update developer docs to clarify both points." Better logging in RSGroupInfoManagerImpl,13393152,Resolved,Minor,Fixed,02/Aug/21 21:49,07/Sep/21 14:20,, Reduce log level of CompactionProgress notice to DEBUG,13394740,Resolved,Minor,Fixed,11/Aug/21 18:06,27/Aug/21 17:17,,Reduce log level of CompactionProgress notice to DEBUG pending resolution of underlying issue. Avoids noise in the logs at WARN level which can be an issue for operations. Those warnings are not currently actionable. Allow AuthUtil automatic renewal to be disabled,13396407,Resolved,Minor,Fixed,20/Aug/21 17:09,24/Aug/21 00:26,,"Talking with [~bbende] who was looking at some ""spam"" in the NiFi log where AuthUtil was complaining that it couldn't renew the UGI. This is did not cause him problems (NiFi could always read/write to HBase), but it generated a lot of noise in the NiFi log. NiFi is special in that it's managing renewals on its own (for all services it can communicate with), rather than letting each client do it on its own. Specifically, one way they do this is by doing a keytab-based login via JAAS, constructing a UGI object from that JAAS login, and then invoking HBase in a normal UGI.doAs(). The problem comes in that AuthUtil _thinks_ that it is capable of renewing this UGI instance on its own. AuthUtil can determine that the current UGI came from a keytab, and thus thinks that it can renew it. However, this actually fails because the LoginContext inside UGI *isn't* actually something that UGI can renew (remember: because NiFI did it directly via JAAS and not via UGI) {noformat} 2021-08-19 17:32:19,438 ERROR [Relogin service.Chore.1] org.apache.hadoop.hbase.AuthUtil Got exception while trying to refresh credentials: loginUserFromKeyTab must be done first java.io.IOException: loginUserFromKeyTab must be done first at org.apache.hadoop.security.UserGroupInformation.reloginFromKeytab(UserGroupInformation.java:1194) at org.apache.hadoop.security.UserGroupInformation.checkTGTAndReloginFromKeytab(UserGroupInformation.java:1125) at org.apache.hadoop.hbase.AuthUtil$1.chore(AuthUtil.java:206) {noformat} After talking with Bryan about this: we don't see a good way for HBase to detect this specific ""A UGI instance, but not created by UGI"" case because the LoginContext inside UGI is private. It is great that AuthUtil will automatically try to renew keytab logins, even if not using {{hbase.client.keytab.file}} and {{hbase.client.keytab.principal}}, so I don't want to break that functionality. NiFi is unique in this case that it is fully managing the renewals, so I think the best path forward is to add an option which lets NiFi disable AuthUtil since it knows it can safely do this. This should affect any others users (but also give us an option if AuthUtil ever does cause problems)." TestTableSnapshotScanner.testMergeRegion error message is misleading.,13394233,Resolved,Minor,Fixed,09/Aug/21 13:06,20/Aug/21 09:47,2.4.5,"In case of any exception thrown, this test wrongly reports a FNFE: {noformat} ...      } catch (Exception e) {        LOG.error(""scan snapshot error"", e);       Assert.fail(""Should not throw FileNotFoundException"");        Assert.assertTrue(e.getCause() != null);        Assert.assertTrue(e.getCause().getCause() instanceof FileNotFoundException);      } finally { ...{noformat}  " config hbase.regions.slop is used for stochastic load balancer.,13395995,Open,Minor,,18/Aug/21 23:40,,,"The config is used to initialize StochasiticLoadBalancer for the field slop. But the field is not used anywhere as of now. There is a related Jira that removed it from Stochastic Balancer https://issues.apache.org/jira/browse/HBASE-9310    We can clean up the code." Correct regex in hbase-personality.sh,13393745,Resolved,Minor,Fixed,05/Aug/21 15:57,09/Aug/21 09:19,,"When activating the Hadoop profile in hbase-personality.sh the regex also accepts branch-1 while it should only set the Hadoop profile for branch-2. https://github.com/apache/hbase/blob/master/dev-support/hbase-personality.sh#L151 " Configurable disallowlist for live editing of loglevels,13392940,Resolved,Minor,Fixed,01/Aug/21 13:33,05/Aug/21 03:12,,"We currently use log4j/slf4j for audit logging in AccessController. This is convenient but presents a security/compliance risk because we allow live-editing of logLevels via the UI. One can simply set the logger to OFF and then perform actions un-audited. We should add a configuration for setting certain log levels to read-only" table list in master ui has a minor bug,13393193,Resolved,Minor,Fixed,03/Aug/21 05:09,04/Aug/21 12:46,2.4.5,"!image-2021-08-03-20-20-25-352.png|width=931,height=162!" Provide exception metric for quota exceeded and throttling,13392605,Resolved,Minor,Fixed,29/Jul/21 19:53,02/Aug/21 09:54,,We should add metrics for QuotaExceededException and RpcThrottlingException. This is something we've found very useful to track as it helps us identify bad access patterns in clients.  "when “hbase.mob.compaction.threads.max” is set to a negative number, HMaster cannot start normally ",13391360,Resolved,Minor,Fixed,22/Jul/21 13:44,30/Jul/21 11:44,2.2.0,"In hbase-default.xml：   {code:java}      hbase.mob.compaction.threads.max      1             The max number of threads used in MobCompactor.         {code}   When the value is set to a negative number, such as -1, Hmaster cannot start normally. The log file will output:   {code:cpp} 2021-07-22 18:54:13,758 ERROR [master/JavaFuzz:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.IllegalArgumentException at java.util.concurrent.ThreadPoolExecutor.(ThreadPoolExecutor.java:1314) at org.apache.hadoop.hbase.mob.MobUtils.createMobCompactorThreadPool(MobUtils.java:880) at org.apache.hadoop.hbase.master.MobCompactionChore. (MobCompactionChore.java:51)   at org.apache.hadoop.hbase.master.HMaster.initMobCleaner(HMaster.java:1278)   at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1161) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2112) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:580) at java.lang.Thread.run(Thread.java:748) 2021-07-22 18:54:13,760 ERROR [master/JavaFuzz:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint] 2021-07-22 18:54:13,760 ERROR [master/JavaFuzz:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master javafuzz,16000,1626951243154: Unhandled exception. Starting shutdown. ***** java.lang.IllegalArgumentException      at java.util.concurrent.ThreadPoolExecutor.(ThreadPoolExecutor.java:1314)   at org.apache.hadoop.hbase.mob.MobUtils.createMobCompactorThreadPool(MobUtils.java:880)      at org.apache.hadoop.hbase.master.MobCompactionChore.(MobCompactionChore.java:51)   at org.apache.hadoop.hbase.master.HMaster.initMobCleaner(HMaster.java:1278)   at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1161)   at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2112) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:580)   at java.lang.Thread.run(Thread.java:748) 2021-07- 22 18:54:13,760 INFO  [master/JavaFuzz:16000:becomeActiveMaster] regionserver.HRegionServer: ***** STOPPING region server 'javafuzz,16000,1626951243154' *****{code}   In MobUtils.java(package org.apache.hadoop.hbase.mob)  This method from version 2.2.0 to version 2.4.4 is the same {code:java}   public static ExecutorService createMobCompactorThreadPool(Configuration conf) {     int maxThreads = conf.getInt(MobConstants.MOB_COMPACTION_THREADS_MAX,         MobConstants.DEFAULT_MOB_COMPACTION_THREADS_MAX);      if (maxThreads == 0) { maxThreads = 1;       }      final SynchronousQueue queue = new SynchronousQueue<>(); ThreadPoolExecutor pool = new ThreadPoolExecutor(1, maxThreads, 60, TimeUnit.SECONDS, queue,       Threads.newDaemonThreadFactory(""MobCompactor""), new RejectedExecutionHandler() {   @Override public void rejectedExecution(Runnable r, ThreadPoolExecutor executor) {            try {              // waiting for a thread to pick up instead of throwing exceptions.              queue.put(r);            } catch (InterruptedException e) {              throw new RejectedExecutionException(e);            }          }        });      ((ThreadPoolExecutor) pool).allowCoreThreadTimeOut(true);      return pool;    }{code} When MOB_COMPACTION_THREADS_MAX is set to 0, mobUtil will set it to 1. But the program does not take into account that it is set to a negative number. When it is set to a negative number, the initialization of the ThreadPoolExecutor will fail and an IllegalArgumentException will be thrown, making HMaster fail to start. Sometimes users will use -1 as the value of the default item in the configuration file. Therefore, it is best to modify the source code, when the value is negative, also set its _maxThread_ to 1. Only need to modify      if (maxThreads == 0) { to      if (maxThreads <= 0) {  " tablelist show pages in masterPage,13392709,Open,Minor,,30/Jul/21 09:34,,,"When the number of tables is large, the display length of the master page is too long, and it needs to be displayed in pages.   Table list supports paging and retrieval： !image-2021-07-30-20-27-56-468.png! !image-2021-07-30-20-29-30-347.png!  " Allow custom opts for hbck in hbase bin,13392139,Resolved,Minor,Fixed,27/Jul/21 13:51,28/Jul/21 05:09,,"https://issues.apache.org/jira/browse/HBASE-15145 made it so that when you execute {{hbase hbck}}, the regionserver or JAAS opts are added automatically to the command line. This is problematic in some cases depending on what regionserver opts have been set. For instance, one might configure a jmx port for the regionserver but then hbck will fail due to a port conflict if run on the same host as a regionserver. Another example would be that a regionserver might define an {{-Xms}} value which is significantly more than hbck requires.   We should make it possible for users to define their own HBASE_HBCK_OPTS which take precedence over the server opts added by default." Backport HBASE-26146 to branch-2.4,13392225,Resolved,Minor,Invalid,27/Jul/21 23:50,28/Jul/21 05:05,, "HBase ""delete"" cannot delete data versions smaller than the specified timestamp",13391018,Resolved,Minor,Not A Problem,21/Jul/21 01:14,21/Jul/21 08:41,2.1.0,"When I use 'delete' to delete a piece of data, I set a value larger than the timestamp of the data, and then the operation does not take effect. But 'deleteall' is feasible. Is this difference designed on purpose?" "Cell TTL set to -1 should mean never expire, the same as CF TTL",13386931,Open,Minor,,01/Jul/21 02:32,,,"We met a user who took it for granted that setting the cell TTL to -1 is the same as the CF TTL, which means that it will never expire. However, if the cell TTL is set to -1, the cell will expire immediately. In fact, if the cell TTL is not set, it means that it will never expire, but he just set it...... We should unify the meaning of cell TTL and CF TTL on the value of -1." L1 miss metric is incorrect when using CombinedBlockCache,13389053,Resolved,Minor,Fixed,12/Jul/21 08:56,16/Jul/21 05:38,,"In CombinedBlockCache getBlock method {code:java} public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, boolean repeat, boolean updateCacheMetrics) { // TODO: is there a hole here, or just awkwardness since in the lruCache getBlock // we end up calling l2Cache.getBlock. // We are not in a position to exactly look at LRU cache or BC as BlockType may not be getting // passed always. return l1Cache.containsBlock(cacheKey)? l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); } {code} If L1 does not contains cacheKey, it will never check it in L1, so that L1 miss metrics is always 0." TestHRegionReplayEvents do not pass in branch-2 and throws NullPointerException,13389385,Resolved,Minor,Fixed,13/Jul/21 12:14,15/Jul/21 02:09,2.3.5,"HBASE-26013 the patch checked in in branch-2 is different with master. There is no problem with master. " Minor cleanups to reduce checkstyle warnings on backup code,13395592,Open,Trivial,,17/Aug/21 02:56,,3.0.0-alpha-2,"As suggested in this PR --> [https://github.com/apache/hbase/pull/3359#pullrequestreview-716511415] Created this issue to clean up Backup classes to reduce checkstyle warnings." Review deprecated WALProcedureStore usage in Backup,13395589,Open,Trivial,,17/Aug/21 02:43,,3.0.0-alpha-2,`WALProcedureStore` stands deprecated. Review its usage in Backup/Restore Set BalanceRequest$Builder to InterfaceAudience.Private,13398272,Resolved,Trivial,Fixed,30/Aug/21 16:36,09/Sep/21 19:17,2.5.0,"In the original implementation, we created the BalanceRequest Builder with InterfaceAudience.Public. This builder should only be used internally, so we should reduce the visibility to Private." Fix typo for file 'hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java',13398437,Resolved,Trivial,Fixed,31/Aug/21 10:38,09/Sep/21 04:24,,"Fix typo for file 'hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java' {code:bash} hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:1823: mulitple ==> multiple hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:3562: compatiblity ==> compatibility hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:3864: supportted ==> supported {code}" Negative time is logged while waiting on regionservers,13396908,Resolved,Trivial,Fixed,24/Aug/21 10:44,25/Aug/21 14:59,,"On Master startup when waiting on RegionServers to report in the log message displays a negative time for the lastChange time.   {noformat} 2021-07-30 06:49:02,882 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=1502ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-1502ms 2021-07-30 06:49:03,693 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:04,384 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=3004ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-3004ms 2021-07-30 06:49:04,694 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:05,694 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:05,886 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=4506ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-4506ms 2021-07-30 06:49:06,695 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:07,389 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=6009ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-6009ms 2021-07-30 06:49:07,695 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:08,700 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:08,891 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=7511ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-7511ms 2021-07-30 06:49:09,701 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:10,393 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=9013ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-9013ms 2021-07-30 06:49:10,701 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:11,702 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:11,896 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=10516ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-10516ms 2021-07-30 06:49:12,702 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:13,398 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=12018ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-12018ms 2021-07-30 06:49:13,703 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:14,703 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:14,900 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=13520ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-13520ms 2021-07-30 06:49:15,704 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:16,402 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=0; waited=15022ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=-15022ms 2021-07-30 06:49:16,704 WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2021-07-30 06:49:16,778 INFO org.apache.hadoop.hbase.master.ServerManager: Registering regionserver=example.com,16020,1627627573364 2021-07-30 06:49:16,803 INFO org.apache.hadoop.hbase.master.ServerManager: Waiting on regionserver count=1; waited=15423ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=0ms {noformat}" [create-release] Use cmd-line defined env vars,13392580,Resolved,Trivial,Fixed,29/Jul/21 17:42,04/Aug/21 16:23,,Minor item. The create-release scripts allows defining some of the variables used on the command line but not all. Fix. 2.3.5 listed on website downloads page but row intends to be for 2.3.6,13393160,Resolved,Trivial,Fixed,02/Aug/21 23:35,03/Aug/21 12:44,,"Typo on downloads.html. Row is for 2.3.6 but still says 2.3.5. Missed in HBASE-26162. PR coming." Rectify the expired TODO comment in CombinedBC,13391031,Resolved,Trivial,Fixed,21/Jul/21 02:39,30/Jul/21 13:48,,"In the method getBlock in CombinedBC, there is a TODO comment as follows: {code:java} @Override public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching, boolean repeat, boolean updateCacheMetrics) { // TODO: is there a hole here, or just awkwardness since in the lruCache getBlock // we end up calling l2Cache.getBlock. // We are not in a position to exactly look at LRU cache or BC as BlockType may not be getting // passed always. boolean existInL1 = l1Cache.containsBlock(cacheKey); if (!existInL1 && updateCacheMetrics && !repeat) { // If the block does not exist in L1, the containsBlock should be counted as one miss. l1Cache.getStats().miss(caching, cacheKey.isPrimary(), cacheKey.getBlockType()); } return existInL1 ? l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); } {code} The TODO comment is expired. While in CombinedBC, L2 is not the victim handler of L1." Upgrade hbase version in hbase-operator-tools to 2.4.4,13388008,Resolved,Trivial,Fixed,06/Jul/21 20:20,07/Jul/21 15:54,hbase-operator-tools-1.2.0, DELETE endpoint in REST API does not support deleting binary row keys/columns,13555137,Resolved,Blocker,Fixed,23/Oct/23 05:53,17/Nov/23 21:09,2.4.17,"h2. Notes This is the first time I have raised an issue in the ASF Jira. Please let me know if there's anything I need to adjust on the issue to fit in with your development flow. I have marked the priority as ""blocker"" because this issue blocks me as a user of the HBase REST API from deploying an effective solution for our setup. Please feel free to change this if the Priority field has another meaning to you. I have also chosen 2.4.17 as the affected version because this is the version I am running, however looking at the source code on GitHub in the default branch, I think many other versions would be affected. h2. Description of Issue The DELETE operation in the [HBase REST API|https://hbase.apache.org/1.2/apidocs/org/apache/hadoop/hbase/rest/package-summary.html#operation_delete] requires specifying row keys and column families/offsets in the URI (i.e. as UTF-8 text). This makes it impossible to specify a delete operation via the REST API for a binary row key or column family/offset, as single bytes with a decimal value greater than 127 are not valid in UTF-8. Percent-encoding these ""high"" values does not work around the issue, as the HBase REST API uses Java's {{URLDecoder.Decode(percentEncodedString, ""UTF-8"")}} function, which replaces any percent-encoded byte in the range {{%80}} to {{%FF}} with the [replacement character|https://en.wikipedia.org/wiki/Specials_(Unicode_block)#Replacement_character]. Even if this were not the case, the row-key is ultimately [converted to a byte array|https://github.com/apache/hbase/blob/rel/2.4.17/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RowSpec.java#L60-L100] using UTF-8 encoding, wherein code points >127 are encoded across multiple bytes, corrupting the user-supplied row key. h2. Proposed Solution I do not believe it is possible to allow encoding of arbitrary bytes in the URL for the DELETE endpoint without breaking compatibility for any users who may have been unknowingly UTF-8 encoding their binary row keys. Even if it were possible, the syntax would likely be terse. Instead, I propose a new version of the DELETE endpoint that would accept row keys and column families/offsets in the request _body_ (using Base64 encoding for the JSON and XML formats, and bare binary for protobuf). This new endpoint would follow the same conventions as the PUT operations, except that cell values would not need to be specified (unless the user is performing a check-and-delete operation). As an additional benefit, using the request body could potentially allow for deleting multiple rows in a single request, which would drastically improve the efficiency of my use case." Remove the xml-maven-plugin in root pom on branch-3,13562272,Resolved,Blocker,Fixed,19/Dec/23 03:34,20/Dec/23 08:12,,"We only generate ref guide on master branch, so we have already deleted related resources on other branches. But on branch-3, we still have xml=maven-plugin for including hbase-default.xml in ref guide so it will fail the build. Let's remove this plugin." Race between RegionRemoteProcedureBase and rollback operation could lead to ROLLEDBACK state be persisent to procedure store,13560942,Resolved,Critical,Fixed,07/Dec/23 06:22,09/Dec/23 14:18,,"And then cause load procedures failure. This is because we do not execute RegionRemoteProcedureBase.persistAndWake method in PEWorker, so even if we hold the procedureExecutionLock in rollback, they could be executed concurrently. So it is possible that in rollback, we set the state to ROLLEDBACK and delete the procedure, and then in persistAndWake, we persist the ROLLEDBACK state to procedure store." Document spark.hadoopRDD.ignoreEmptySplits issue for Spark Connector,13559238,Open,Critical,,23/Nov/23 20:04,,,"For Spark 3.2.0+ the connector needs spark.hadoopRDD.ignoreEmptySplits=false to work correctly. This crucial piece of information is not documented either in the README, or in the main Hbase connector section. " There could be holes in stack ids when loading procedures,13558399,Resolved,Critical,Fixed,17/Nov/23 11:46,22/Nov/23 02:48,,"Found this when implementing HBASE-28199, as after HBASE-28199 we will suspend procedures a lot, so a missed scenario has been covered and it will fail some UTs with corrupted procedures when loading. I think this issue should be fixed separately as it affects all active branches. Let me try to implement a UT first." AsyncFSWAL may hang,13558162,Open,Critical,,16/Nov/23 04:01,,,"Saw this in the UT environment before when checking why TestClusterScopeQuotaThrottle. And when implementing HBASE-28199, it is very easy to reproduce the problem while executing some other UTs, like TestAdmin, and the problem disappear after chaning to use FSHLog. Need to dig more as now AsyncFSWAL is the default implementation." RecoveredReplicationSource quit when there are still unfinished groups,13554261,Resolved,Critical,Fixed,16/Oct/23 14:46,20/Oct/23 04:07,,Need to dig more but it seems to related to how we deal with RecoveredReplicationSource and queue. HRegionServer should implement isStopping method,13553086,Resolved,Critical,Fixed,06/Oct/23 07:21,07/Oct/23 08:11,,"Should be a missing part of HBASE-25288, because we have a default implementation in the Server interface so it does not introduce any compilation errors..." Unable to get table state error when table is being initialized,13554440,Open,Major,,17/Oct/23 15:58,,2.4.17,"When executing commands to create a table, I noticed the following ERROR in HMaster {code:java} 2023-10-17 06:41:47,118 ERROR [master/hmaster:16000.Chore.1] master.TableStateManager: Unable to get table uuidf68fb89ec7f4435597d69fb7b099d8e7 state org.apache.hadoop.hbase.TableNotFoundException: No state found for uuidf68fb89ec7f4435597d69fb7b099d8e7         at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:155)         at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:92)         at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:419)         at org.apache.hadoop.hbase.master.assignment.AssignmentManager.getRegionStatesCount(AssignmentManager.java:2341)         at org.apache.hadoop.hbase.master.HMaster.getClusterMetricsWithoutCoprocessor(HMaster.java:2616)         at org.apache.hadoop.hbase.master.HMaster.getClusterMetricsWithoutCoprocessor(HMaster.java:2537)         at org.apache.hadoop.hbase.master.balancer.ClusterStatusChore.chore(ClusterStatusChore.java:47)         at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:158)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)         at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)         at org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:107)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:750){code} h1. Reproduce Due to the thread interleaving, it might need to run the following command sequence multiple times to reproduce 1 HM, 2 RS, HDFS 2.10.2 cluster {code:java} create 'uuid49bb410e0a0c40ffb070d17787b4cad7', {NAME => 'uuid66e57e5195e04956a78f789b2a25ec01', VERSIONS => 1, COMPRESSION => 'GZ', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true'}, {NAME => 'uuid119181eed72a43ccb66fabe37f84d2c0', VERSIONS => 1, COMPRESSION => 'GZ', BLOOMFILTER => 'NONE', IN_MEMORY => 'true'}, {NAME => 'uuidc2d4931eaf4c429db0e55514fb12e767', VERSIONS => 3, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'false'}, {NAME => 'uuidc9802bbfbe434411ae68bb8388d499b6', VERSIONS => 3, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'false'}, {NAME => 'uuidc85e117d0ca144719fc53d30b189a343', VERSIONS => 3, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'false'} create 'uuid094dd5bf47eb47d69148b63e73ce0e7c', {NAME => 'uuid76ccbd96fbdc418b95ed9971ff423b2d', VERSIONS => 1, COMPRESSION => 'GZ', BLOOMFILTER => 'ROW', IN_MEMORY => 'true'}, {NAME => 'uuid36835d3faff04838bd02d6226557d7c8', VERSIONS => 1, COMPRESSION => 'GZ', BLOOMFILTER => 'NONE', IN_MEMORY => 'false'}, {NAME => 'uuid37752598d1bb405eb39a3e17c04d7e60', VERSIONS => 1, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'false'} create 'uuidf68fb89ec7f4435597d69fb7b099d8e7', {NAME => 'uuidb235288b1d304fe1a62adb63968d9eee', VERSIONS => 1, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'false'}, {NAME => 'uuidf348f8849e724b3fa231fc2bb459be2d', VERSIONS => 1, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'true'}, {NAME => 'uuid81341a87083e49d7a0d8aff7b1ccf16a', VERSIONS => 3, COMPRESSION => 'GZ', BLOOMFILTER => 'ROW', IN_MEMORY => 'false'}, {NAME => 'uuid24db0d3c67c347d3a4c18af90facec2d', VERSIONS => 1, COMPRESSION => 'NONE', BLOOMFILTER => 'ROW', IN_MEMORY => 'true'}, {NAME => 'uuid7ecf10315f444cfd9c5698695f9054d9', VERSIONS => 1, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'false'} enable 'uuid094dd5bf47eb47d69148b63e73ce0e7c' create_namespace 'uuidc1066f82d7834f698d335dd04fa7ad3e' alter 'uuid094dd5bf47eb47d69148b63e73ce0e7c', {NAME => 'enaJvIGYBk', BLOOMFILTER => 'ROWCOL', IN_MEMORY => false} disable 'uuidf68fb89ec7f4435597d69fb7b099d8e7' {code} I have attached the full logs. h1. Root Cause The ERROR message is thrown because of the thread interleaving between (1) T1: creating the table and (2) T2: Chore thread calculating TABLE_TO_REGIONS_COUNT. Here's how it happens in detail # User issues a create table request, it puts the table name into tableDescriptors. # Chore thread is trying to calculate TABLE_TO_REGIONS_COUNT by iterating all tables from {*}getTableDescriptors().getAll(){*}. This also includes the table which is being created but the table state is not created yet. # It tries to fetch the table state and throws an ERROR. IMO, this is a normal and correct process which shouldn't incur ERROR level message. It could be avoided by properly handling the thread interleaving between table updates and chore threads. I am trying to fix it. Any help would be appreciated! " HDFS erasure coding support for table data dirs,13559050,Resolved,Major,Fixed,22/Nov/23 15:02,05/Feb/24 13:52,,"[Erasure coding|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs/HDFSErasureCoding.html] (EC) is a hadoop-3 feature which can drastically reduce storage requirements, at the expense of locality. At my company we have a few hbase clusters which are extremely data dense and take mostly write traffic, fewer reads (cold data). We'd like to reduce the cost of these clusters, and EC is a great way to do that since it can reduce replication related storage costs by 50%. It's possible to enable EC policies on sub directories of HDFS. One can manually set this with {{{}hdfs ec -setPolicy -path /hbase/data/default/usertable -policy xxxx{}}}. This can work without any hbase support. One problem with that is a lack of visibility by operators into which tables might have EC enabled. I think this is where HBase can help. Here's my proposal: * Add a new TableDescriptor and ColumnDescriptor field ERASURE_CODING_POLICY * In ModifyTableProcedure preflightChecks, if ERASURE_CODING_POLICY is set, verify that the requested policy is available and enabled via DistributedFileSystem. getErasureCodingPolicies(). * During ModifyTableProcedure, add a new state for MODIFY_TABLE_SYNC_ERASURE_CODING_POLICY. ** When adding or changing a policy, use DistributedFileSystem. setErasureCodingPolicy to sync it for the data and archive dir of that table (or column in table) ** When removing the property or setting it to empty, use DistributedFileSystem. unsetErasureCodingPolicy to remove it from the data and archive dir. Since this new API is in hadoop-3 only, we'll need to add a reflection wrapper class for managing the calls and verifying that the API is available. We'll similarly do that API check in preflightChecks." Upgrade zookeeper to a newer version,13554141,Resolved,Major,Fixed,15/Oct/23 13:52,02/Nov/23 01:40,,"See this discussion thread: https://lists.apache.org/thread/gl3lx2btg59ysocsspn8pjq77w0sl3op I prefer we upgrade zookeeper version to 3.8.x for HBase 2.6+." Release 3.0.0-beta-1,13562073,Resolved,Major,Fixed,16/Dec/23 08:07,19/Jan/24 10:35,,"We have passed a 10B ITBLL run after HBASE-28199 gets in, so I think it is time to cut the 3.0.0-beta-1 now. There are still some improvments such as HBASE-28240, which will target to 3.0.0-beta-2." hbck -o should not allow bypassing pre transit check by default,13553940,Resolved,Major,Fixed,13/Oct/23 01:36,21/Nov/24 07:38,2.4.17,"When operator uses hbck assigns or unassigns with ""-o"", the override will also skip pre transit checks. While this is one of the intentions with ""-o"", the primary purpose should still be to only unattach existing procedure from RegionStateNode so that newly scheduled assign proc can take exclusive region level lock. We should restrict bypassing preTransitCheck by only providing it as site config. If bypassing preTransitCheck is configured, only then any hbck ""-o"" should be allowed to bypass this check, otherwise by default they should go through the check.   It is important to keep ""unset of the procedure from RegionStateNode"" and ""bypassing preTransitCheck"" separate so that when the cluster state is bad, we don't explicitly deteriorate it further e.g. if a region was successfully split and now if operator performs ""hbck assigns \{region} -o"" and if it bypasses the transit check, master would bring the region online and it could compact store files and archive the store file which is referenced by daughter region. This would not allow daughter region to come online. Let's introduce hbase site config to allow bypassing preTransitCheck, it should not be doable only by operator using hbck alone.   ""-o"" should mean ""override"" the procedure that is attached to the RegionStateNode, it should not mean forcefully skip any region transition validation checks." Bump jruby to 9.4.8.0 to fix snakeyaml CVE,13560965,Resolved,Major,Fixed,07/Dec/23 09:43,16/Aug/24 05:25,,"As a follow up of HBASE-28249, we want to bump to latest 9.4.x line here.  This release line drops critical snakeyaml CVE ({*}org.yaml : snakeyaml : 1.33{*} having [CVE-2022-1471|https://nvd.nist.gov/vuln/detail/CVE-2022-1471]) from our classpath with following change along with several other bugs/fixes:  * The Psych YAML library is updated to 5.1.0. This version switches the JRuby extension to SnakeYAML Engine, avoiding CVEs against the original SnakeYAML and updating YAML compatibility to specification version 1.2. [#6365|https://github.com/jruby/jruby/issues/6365], [#7570|https://github.com/jruby/jruby/issues/7570], [#7626|https://github.com/jruby/jruby/pull/7626] NOTE: JRuby 9.4.x targets Ruby 3.1 compatibility instead of Ruby 2.6 which 9.3.x were having!" NPE when flushing a non-existing column family,13556797,Resolved,Major,Fixed,05/Nov/23 04:37,26/Sep/24 08:20,2.4.17,"Flush a columnfamily that doesn't exist in the table will cause NPE ERROR in both shell and the HMaster logs. h1. Reproduce Start up HBase 2.5.9 cluster, executing the following commands with hbase shell in HMaster node will lead to NPE. (Can be reproduced determinstically) {code:java} create 'table', {NAME => 'cf1', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'ROWCOL'}, {NAME => 'cf2', VERSIONS => 4, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL'} incr 'table', 'row1', 'cf1:cell', 2 flush 'table', 'cf3'{code} The shell outputs {code:java} hbase:006:0> create 'table', {NAME => 'cf1', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'ROWCOL'}, {NAME => 'cf2', VERSIONS => 4, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL'} Created table table Took 2.1238 seconds                                                                                                                                 => Hbase::Table - table hbase:007:0>  hbase:008:0> incr 'table', 'row1', 'cf1:cell', 2 COUNTER VALUE = 2 Took 0.0131 seconds                                                                                                                                 hbase:009:0>  hbase:010:0> flush 'table', 'cf3' ERROR: java.io.IOException: java.lang.NullPointerException  at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:479)  at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)  at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)  at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) Caused by: org.apache.hadoop.hbase.errorhandling.ForeignException$ProxyThrowable: java.lang.NullPointerException  at org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager$FlushTableSubprocedurePool.waitForOutstandingTasks(RegionServerFlushTableProcedureManager.java:274)  at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.flushRegions(FlushTableSubprocedure.java:115)  at org.apache.hadoop.hbase.procedure.flush.FlushTableSubprocedure.acquireBarrier(FlushTableSubprocedure.java:126)  at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:160)  at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:46)  at java.util.concurrent.FutureTask.run(FutureTask.java:266)  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)  at java.lang.Thread.run(Thread.java:750) For usage try 'help ""flush""' Took 12.1713 seconds                                                         {code}   According to the _flush (flush.rb)_ command specification, user can flush a specific column family. {code:java} Flush all regions in passed table or pass a region row to flush an individual region or a region server name whose format is 'host,port,startcode', to flush all its regions. You can also flush a single column family for all regions within a table, or for an specific region only. For example:   hbase> flush 'TABLENAME'   hbase> flush 'TABLENAME','FAMILYNAME' {code} In the above case, *cf3* an incorrect input (non-existing column family). If user tries to flush it, the expected output is: # HBase rejects this operation # returns a prompt saying the column family doesn't exist {_}""{_}{_}{+}ERROR: Unknown CF...{+}"".{_}   In 2.6.0, the flush command would stuck and run into NPE {code:java} java.lang.NullPointerException: null         at org.apache.hadoop.hbase.regionserver.HRegion.logFatLineOnFlush(HRegion.java:2724) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2640) ~[hbase-server-2.6.0.jar:2.6.0]         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2587) ~[hbase-server-2.6.0.jar:2.6.0] {code} h1. Root Cause There's a missing check for the whether the target flushing columnfamily exists." Decouple RIT list management from TRSP invocation,13554330,Open,Major,,17/Oct/23 01:52,,2.5.6,"Operators bypassed some in progress TRSPs leading to a state where some regions were persistently in transition but hidden. Because the master builds its list of regions in transition by tracking TRSP, the bypass of TRSP removed the regions from the RIT list. Although I can see from reading the code this is the expected behavior, it is surprising for operators and should be changed. Operators expect that regions that should be open but are not appear the master's RIT list, provided by /rits.jsp, the output of the shell's 'rit' command, and in ClusterStatus. We should only remove a region from the RIT map when assignment reaches a suitable terminal state." Introduce table metric for blockedRequestCount,13559623,Open,Major,,27/Nov/23 23:04,,2.4.17,"If compaction is disabled temporarily to allow stabilizing hdfs load, we can forget re-enabling the compaction. This can result into flushes getting delayed for ""hbase.hstore.blockingWaitTime"" time (90s). While flushes do happen eventually after waiting for max blocking time, it is important to realize that any cluster cannot function well with compaction disabled for significant amount of time.   We would also block any write requests until region is flushed (90+ sec, by default): {code:java} 2023-11-27 20:40:52,124 WARN  [,queue=18,port=60020] regionserver.HRegion - Region is too busy due to exceeding memstore size limit. org.apache.hadoop.hbase.RegionTooBusyException: Above memstore limit, regionName=table1,1699923733811.4fd5e52e2133df1e347f32c646f23ab4., server=server-1,60020,1699421714454, memstoreSize=1073820928, blockingMemStoreSize=1073741824     at org.apache.hadoop.hbase.regionserver.HRegion.checkResources(HRegion.java:4200)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3264)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:3215)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:967)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:895)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2524)     at org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36812)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2432)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291) {code}   Delayed flush logs: {code:java} LOG.warn(""{} has too many store files({}); delaying flush up to {} ms"", region.getRegionInfo().getEncodedName(), getStoreFileCount(region), this.blockingWaitTime); {code} Suggestion: Introduce regionserver metric (MetricsRegionServerSource) for the num of flushes getting delayed due to too many store files." Master should recover if meta region state is inconsistent,13557378,Open,Major,,09/Nov/23 19:38,,2.4.17,"During active master initialization, before we set master as active (i.e. {_}setInitialized(true){_}), we need both meta and namespace regions online. If the region state of meta or namespace is inconsistent, active master can get stuck in the initialization step: {code:java} private boolean isRegionOnline(RegionInfo ri) { RetryCounter rc = null; while (!isStopped()) { ... ... ... // Check once-a-minute. if (rc == null) { rc = new RetryCounterFactory(Integer.MAX_VALUE, 1000, 60_000).create(); } Threads.sleep(rc.getBackoffTimeAndIncrementAttempts()); } return false; } {code} In one of the recent outage, we observed that meta was online on a server, which was correctly reflected in meta znode, but the server starttime was different. This means that as per the latest transition record, meta was marked online on old server (same server with old start time). This kept active master initialization waiting forever and some SCPs got stuck in initial stage where they need to access meta table before getting candidate for region moves. The only way out of this outage is for operator to schedule recoveries using hbck for old server, which triggers SCP for old server address of meta. Since many SCPs were stuck, the processing of new SCP too was taking some time and manual restart of active master triggered failover, and new master was able to complete SCP for old meta server, correcting the meta assignment details, which eventually marked master as active and only after this, we were able to see real large num of RITs that were hidden so far. We need to let master recover from this state to avoid manual intervention." Fix the miss count in one of CombinedBlockCache getBlock implementations,13556949,Resolved,Major,Fixed,06/Nov/23 21:28,09/Nov/23 10:55,2.4.17,"In one of the CombinedBlockCache.getBlock(getBlock(cacheKey,cachingrepeat,updateCacheMetrics) we always compute a miss in L1 if the passed block is of type DATA. We should compute the miss in one of the caches only, not both." Expose region cached size over JMX metrics and report in the RS UI,13560895,Resolved,Major,Fixed,06/Dec/23 23:03,14/Dec/23 21:55,2.4.17,"With large file based bucket cache, the prefetch executor can take long time to complete cache all of the dataset. It would be useful to report how much % of regions data is already cached, in order to give an idea of how much work prefetch executor has done. This PRs adds jmx metrics for region cache % and also reports the same in the RS UI ""Store File Metrics"" tab as below: !Screenshot 2023-12-06 at 22.58.17.png|width=658,height=114!" "Split the queueCallTime, processCallTime and totalCallTime according to queue type when using RWQueueRpcExecutor",13559459,Open,Major,,26/Nov/23 16:16,,2.5.0,"When using RWQueueRpcExecutor, in order to monitor the running status of the read and write queues separately, it is necessary to monitor the queueTime and processingTime of the request according to the queue type. In this way, the queue's queueCallTime, processCallTime and totalCallTime  metrics are split according to the read and write queue types. So Add the following metrics： # queueReadCallTime # processReadCallTime # totalReadCallTime # queueWriteCallTime # processWriteCallTime # totalWriteCallTime # queueScanCallTime # processScanCallTime # totalScanCallTime   These metrics are important references for subsequent modification of parameters hbase.ipc.server.callqueue.read.ratio and hbase.ipc.server.callqueue.scan.ratio." Add release manager for 2.6 in ref guide,13559908,Resolved,Major,Fixed,29/Nov/23 14:04,20/May/24 21:03,, Release 2.6.0,13559904,Resolved,Major,Done,29/Nov/23 14:02,20/May/24 21:04,, Add 2.6.0 to downloads page,13559913,Resolved,Major,Fixed,29/Nov/23 14:07,20/May/24 21:03,, Set version to 2.6.1-SNAPSHOT for branch-2.6,13559914,Resolved,Major,Done,29/Nov/23 14:07,17/May/24 13:58,, Put up 2.6.0RC0,13559911,Resolved,Major,Done,29/Nov/23 14:05,17/May/24 13:57,, Set version as 2.6.0 in branch-2.6 in prep for first RC,13559910,Resolved,Major,Done,29/Nov/23 14:05,17/May/24 13:57,, Run ITBLL for branch-2.6,13559909,Resolved,Major,Done,29/Nov/23 14:04,17/May/24 13:57,, Auto create configured namespaces,13560506,Open,Major,,04/Dec/23 15:11,,,"During startup, the HMaster will create the default and system namespaces automatically. To simplify the management of common namespaces, it would be beneficial to offer a configuration option that operators can use to ensure that additional namespaces are created during startup. This would eliminate the need to wrap createTable calls in checkAndCreateNamespace or provide separate cluster bootstrap functionality to guarantee that the namespace is created." CreateTableProcedure and DeleteTableProcedure should sleep a while before retrying,13553817,Resolved,Major,Fixed,12/Oct/23 08:41,22/Apr/24 01:23,2.4.14,"create a table, but it failed when execute CREATE_TABLE_WRITE_FS_LAYOUT, then will try again and again, will write too many proc record to master:store, we find num of the master WAL in oldWALs more than 13000..   Q: should add a  suspend time logic for create table proc retry? i see TransitRegionStateProcedure has the logic..   --------------------------------------------------------------- sorry, i upload screenshot failed, just copy to here {code:java} // 2023-10-12 12:34:35,360 | INFO  | RegionOpenAndInit-themis:a-pool-0 | Closing region themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1688) 2023-10-12 12:34:35,360 | INFO  | RegionOpenAndInit-themis:a-pool-0 | Closed themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1900) 2023-10-12 12:34:35,360 | INFO  | PEWorker-1 | Region directories are created at hdfs://hacluster/hbase/.tmp for table themis:a | org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:346) 2023-10-12 12:34:35,362 | WARN  | PEWorker-1 | Retriable error trying to create table=themis:a state=CREATE_TABLE_WRITE_FS_LAYOUT | org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:159) java.io.IOException: Unable to move table from temp=hdfs://hacluster/hbase/.tmp/data/themis/a to hbase root=hdfs://hacluster/hbase/data/themis/a         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.moveTempDirectoryToHBaseRoot(CreateTableProcedure.java:391)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:350)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:318)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:121)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:75)         at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188)         at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:922)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962)         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:221)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1988) 2023-10-12 12:34:35,387 | INFO  | PEWorker-1 | pid=917, state=RUNNABLE:CREATE_TABLE_WRITE_FS_LAYOUT, locked=true; CreateTableProcedure table=themis:a execute state=CREATE_TABLE_WRITE_FS_LAYOUT | org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:102) 2023-10-12 12:34:35,414 | INFO  | RegionOpenAndInit-themis:a-pool-0 | creating {ENCODED => 513d3d5b4d3ad5c8f13bacea4a888d69, NAME => 'themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69.', STARTKEY => '', ENDKEY => ''}, tableDescriptor='themis:a', {NAME => 'f1', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', COMPRESSION => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}, regionDir=hdfs://hacluster/hbase/.tmp | org.apache.hadoop.hbase.regionserver.HRegion.createHRegion(HRegion.java:7906) 2023-10-12 12:34:35,432 | INFO  | RegionOpenAndInit-themis:a-pool-0 | Waiting for flushes and compactions to finish for the region themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1911) 2023-10-12 12:34:35,432 | INFO  | RegionOpenAndInit-themis:a-pool-0 | Total wait time for flushes and compaction for the region themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. is: 0ms | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1946) 2023-10-12 12:34:35,432 | INFO  | RegionOpenAndInit-themis:a-pool-0 | Closing region themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1688) 2023-10-12 12:34:35,432 | INFO  | RegionOpenAndInit-themis:a-pool-0 | Closed themis:a,,1697025107991.513d3d5b4d3ad5c8f13bacea4a888d69. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1900) 2023-10-12 12:34:35,432 | INFO  | PEWorker-1 | Region directories are created at hdfs://hacluster/hbase/.tmp for table themis:a | org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:346) 2023-10-12 12:34:35,434 | WARN  | PEWorker-1 | Retriable error trying to create table=themis:a state=CREATE_TABLE_WRITE_FS_LAYOUT | org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:159) java.io.IOException: Unable to move table from temp=hdfs://hacluster/hbase/.tmp/data/themis/a to hbase root=hdfs://hacluster/hbase/data/themis/a         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.moveTempDirectoryToHBaseRoot(CreateTableProcedure.java:391)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:350)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.createFsLayout(CreateTableProcedure.java:318)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:121)         at org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:75)         at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188)         at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:922)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962)         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:221)         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1988) 2023-10-12 12:34:35,469 | INFO  | PEWorker-1 | pid=917, state=RUNNABLE:CREATE_TABLE_WRITE_FS_LAYOUT, locked=true; CreateTableProcedure table=themis:a execute state=CREATE_TABLE_WRITE_FS_LAYOUT | org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:102) {code} {code:java} //hdfs dfs -ls /hbase/oldWALs | grep 'masterlocal' |wc -l 13398 {code}   analysis: this was beacuse {color:#ff0000}*i delete namespace dir in HDFS directly*{color}...but {color:#ff0000}*did not delete from hbase:namespce*{color}, so when i want to create a table in this namespce will hang.... it's a operation error... but if some logic failed in CreateTableProcedure, i think will cause this issue again..." Region reopen procedure should support some sort of throttling,13559048,Resolved,Major,Fixed,22/Nov/23 14:48,04/Dec/23 14:47,,"The mass reopening of regions caused by a table descriptor modification can be quite disruptive. For latency/error sensitive workloads, like our user facing traffic, we need to be very careful about when we modify table descriptors, and it can be virtually impossible to do it painlessly for busy tables. It would be nice if we supported configurable batching/throttling of reopenings so that the amplitude of any disruption can be kept relatively small." It's impossible to re-enable the quota table if it gets disabled,13556438,Resolved,Major,Fixed,01/Nov/23 20:11,07/Apr/24 14:12,,"HMaster.enableTable tries to read the quota table. If you disable the quota table, this fails. So then it's impossible to re-enable it. The only solution I can find is to delete the table at this point, so that it gets recreated at startup, but this results in losing any quotas you had defined.  We should fix enableTable to not check quotas if the table in question is hbase:quota." Tailing the WAL is very slow if there are multiple peers.,13556453,Resolved,Major,Fixed,01/Nov/23 22:46,07/Nov/23 20:10,2.0.0,"Noticed in one of our production clusters which has 4 peers. Due to sudden ingestion of data, the size of log queue increased to a peak of 506. We have configured log roll size to 256 MB. Most of the edits in the WAL were from a table for which replication is disabled.  So all ReplicationSourceWALReader thread had to do was to replay the WAL and NOT replicate them. Still it took 12 hours to drain the queue. Took few jstacks and found that ReplicationSourceWALReader was waiting to acquire rollWriterLock [here|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java#L1231] {noformat} ""regionserver/,1"" #1036 daemon prio=5 os_prio=0 tid=0x00007f44b374e800 nid=0xbd7f waiting on condition [0x00007f37b4d19000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00007f3897a3e150> (a java.util.concurrent.locks.ReentrantLock$FairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:837) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:872) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1202) at java.util.concurrent.locks.ReentrantLock$FairSync.lock(ReentrantLock.java:228) at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:290) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.getLogFileSizeIfBeingWritten(AbstractFSWAL.java:1102) at org.apache.hadoop.hbase.wal.WALProvider.lambda$null$0(WALProvider.java:128) at org.apache.hadoop.hbase.wal.WALProvider$$Lambda$177/1119730685.apply(Unknown Source) at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) at java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1361) at java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:126) at java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:499) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:486) at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) at java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:152) at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.util.stream.ReferencePipeline.findAny(ReferencePipeline.java:536) at org.apache.hadoop.hbase.wal.WALProvider.lambda$getWALFileLengthProvider$2(WALProvider.java:129) at org.apache.hadoop.hbase.wal.WALProvider$$Lambda$140/1246380717.getLogFileSizeIfBeingWritten(Unknown Source) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:260) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:172) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:222) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:157) {noformat}  All the peers will contend for this lock during every batch read. Look at the code snippet below. We are guarding this section with rollWriterLock if we are replicating the active WAL file. But in our case we are NOT replicating active WAL file but still we acquire this lock only to return OptionalLong.empty(); {noformat} /** * if the given {@code path} is being written currently, then return its length. *

* This is used by replication to prevent replicating unacked log entries. See * https://issues.apache.org/jira/browse/HBASE-14004 for more details. */ @Override public OptionalLong getLogFileSizeIfBeingWritten(Path path) { rollWriterLock.lock(); try { ... ... } finally { rollWriterLock.unlock(); } {noformat} We can check the size of log queue and if it is greater than 1 then we can return early without acquiring the lock." Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction.,13559833,Open,Major,,29/Nov/23 06:37,,2.2.6,"    There is a table and the Stripe Compaction strategy is applied. Each region has an average value of 40G and is divided into 8 Stripes. Each Stripe is 5G. The business deletes a large amount of data. Manually triggering major compaction on the entire table and a single region does not work and cannot be selected.     After reading the source code, the merging strategy applied under each Stripe is ExploringCompactionPolicy. This strategy has a key point. It filters the Store file list of a single Stripe. In the candidate file list, as long as there is a file that is too large in size and meets the condition, fileSize > (totalFileSize - fileSize) * (hbase.hstore.compaction.ratio default value 1.2), files will not be filtered out to participate in major compaction.     It is necessary to support a forced merging mechanism. For scenarios where a large amount of data is deleted, or where bulkload exists, you can explicitly pass in a parameter such as foreMajor when manually triggering the major, and then perform forced Major Compaction in Stripe units to support the data. Clean up.     " Rebase CacheAwareBalance related commits into master branch,13556596,Resolved,Major,Fixed,02/Nov/23 23:26,30/Nov/23 15:00,2.4.17, Possible data loss in WAL after RegionServer crash,13561876,Resolved,Major,Fixed,14/Dec/23 16:06,12/Mar/24 13:02,,"We recently had a production incident: # RegionServer crashes, but local DataNode lives on # WAL lease recovery kicks in # Namenode reconstructs the block during lease recovery (which results in a new genstamp). It chooses the replica on the local DataNode as the primary. # Local DataNode reconstructs the block, so NameNode registers the new genstamp. # Local DataNode and the underlying host dies, before the new block could be replicated to other replicas. This leaves us with a missing block, because the new genstamp block has no replicas. The old replicas still remain, but are considered corrupt due to GENSTAMP_MISMATCH. Thankfully we were able to confirm that the length of the corrupt blocks were identical to the newly constructed and lost block. Further, the file in question was only 1 block. So we downloaded one of those corrupt block files and hdfs {{hdfs dfs -put -f}} to force that block to replace the file in hdfs. So in this case we had no actual data loss, but it could have happened easily if the file was more than 1 block or the replicas weren't fully in sync prior to reconstruction. In order to avoid this issue, we should avoid writing WAL blocks too the local datanode. We can use CreateFlag.NO_WRITE_LOCAL for this. Hat tip to [~weichiu] for pointing this out. During reading of WALs we already reorder blocks so as to avoid reading from the local datanode, but avoiding writing there altogether would be better." move_servers_namespaces_rsgroup is not changing the new rs group in namespace description,13553800,Open,Major,,12/Oct/23 07:40,,,"{noformat} hbase:024:0> list_rsgroups NAME                                                          SERVER / TABLE  rs1                                                          server hostname2:16020                                                               table hbase:meta                                                               table hbase:acl                                                               table hbase:namespace                                                               table hbase:rsgroup  default                                                      server hostname3:16020                                                               table ns_R:ta  tenant_group1  tenant_group                                                 server hostname1:16020                                                               table ns:tb1                                                               table ns:tab                                                               table ns:t2 4 row(s) Took 0.0129 seconds hbase:025:0> move_servers_namespaces_rsgroup 'rs1',['hostname1:16020'], ['ns'] Took 0.0302 seconds hbase:026:0> list_rsgroups NAME                                                          SERVER / TABLE  rs1                                                          server hostname1:16020                                                               server hostname2:16020                                                               table ns:tb1                                                               table ns:tab                                                               table hbase:meta                                                               table hbase:acl                                                               table ns:t2                                                               table hbase:namespace                                                               table hbase:rsgroup  default                                                      server hostname2:16020                                                               table ns_R:ta  tenant_group1  tenant_group 4 row(s) Took 0.0140 seconds hbase:027:0> describe_namespace 'ns' DESCRIPTION {NAME => 'ns', hbase.rsgroup.name => 'tenant_group'} Quota is disabled Took 0.0093 seconds hbase:028:0> {noformat}" "Bump up jetty-server, jetty-http to 9.4.53.v20231009",13562753,Resolved,Major,Fixed,22/Dec/23 16:13,05/Jan/24 18:34,,Bump up jetty-server to 9.4.53.v20231009 to avoid CVE CVE-2023-36478 Region Canary can take lot more time If any region (except the first region) starts with delete markers,13557981,Resolved,Major,Fixed,14/Nov/23 23:34,12/Feb/24 17:17,,"In CanaryTool.java, Canary reads only the first row of the region using [Get|https://github.com/apache/hbase/blob/23c41560d58cc1353b8a466deacd02dfee9e6743/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L520C33-L520C33] for any region of the table. Canary uses [Scan with FirstRowKeyFilter for table scan|https://github.com/apache/hbase/blob/23c41560d58cc1353b8a466deacd02dfee9e6743/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L530] If the said region has empty start key (This will only happen when region is the first region for a table) With -[HBASE-16091|https://issues.apache.org/jira/browse/HBASE-16091]- RawScan was [implemented|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L519-L534] to improve performance for regions which can have high number of delete markers. Based on currently implementation, [RawScan is only enabled|https://github.com/apache/hbase/blob/23c41560d58cc1353b8a466deacd02dfee9e6743/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L519] if region has empty start-key (or region is first region for the table). RawScan doesn't work for rest of the regions in the table except first region. Also If the region has all the rows or majority of the rows with delete markers, Get Operation can take a lot of time. This is can cause timeouts for CanaryTool. " Flaky test: TestFanOutOneBlockAsyncDFSOutput (Part 2),13562488,Resolved,Major,Fixed,20/Dec/23 15:52,22/Dec/23 09:11,,"The following test sometimes fails for me when running locally with Maven: TestFanOutOneBlockAsyncDFSOutput.testRecover() I can't really figure out the reason, but it's probably a side effect of the preceding test: testConnectToDatanodeFailed(). This test also restarts one of the datanodes in the MiniDFS cluster just like testRecover() and it somehow causes the failure. {noformat} java.lang.AssertionError: flush should fail at org.junit.Assert.fail(Assert.java:89) at org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput.testRecover(TestFanOutOneBlockAsyncDFSOutput.java:154) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method){noformat} The flush() call is testRecover() should fail, because we restart one of the DN in the DFS cluster which is expected to brake connection. It succeeds though if the preceding test already restarted a DN. No matter which DN we restart, even if they're different, the error occurs. I also tried to add CLUSTER.waitDatanodeFullyStarted() at the end of testConnectToDatanodeFailed(), looks like it made the tests slightly more stable, but didn't help fully." Flaky test: TestTableShell,13561409,Resolved,Major,Fixed,11/Dec/23 15:22,19/Dec/23 20:46,,"The test is running the following Ruby commands: {noformat} # Instert test data @test_table.put(1, ""x:a"", 1) @test_table.put(2, ""x:raw1"", 11) @test_table.put(2, ""x:raw1"", 11) @test_table.put(2, ""x:raw1"", 11) @test_table.put(2, ""x:raw1"", 11) {noformat} And validate the versions with: {noformat} args = { VERSIONS => 10, RAW => true } # Since 4 versions of row with rowkey 2 is been added, we can use any number >= 4 for VERSIONS to scan all 4 versions. num_rows = 0 @test_table._scan_internal(args) do # Raw Scan num_rows += 1 end # 5 since , 1 from row key '1' and other 4 from row key '4' assert_equal(num_rows, 5, 'Num rows scanned without RAW/VERSIONS are not 5') {noformat} Which sometimes (almost always on fast machines) fails, because it only finds 3 versions out of 4. I believe this due to commands are running too fast and inserts data with same timestamp, so HBase cannot distinguish them. I'd like to add some sleep between puts to fix it." New Splittable Meta,13557430,Open,Major,,10/Nov/23 06:14,,,This issue is used to try to land to solution on splittable meta. Infinite waiting on lock acquisition by snapshot can result in unresponsive master,13562279,Resolved,Major,Fixed,19/Dec/23 05:39,23/Jan/24 02:42,2.4.17,"When a region is stuck in transition for significant time, any attempt to take snapshot on the table would keep master handler thread in forever waiting state. As part of the creating snapshot on enabled or disabled table, in order to get the table level lock, LockProcedure is executed but if any region of the table is in transition, LockProcedure could not be executed by the snapshot handler, resulting in forever waiting until the region transition is completed, allowing the table level lock to be acquired by the snapshot handler. In cases where a region stays in RIT for considerable time, if enough attempts are made by the client to create snapshots on the table, it can easily exhaust all handler threads, leading to potentially unresponsive master. Attached a sample thread dump. Proposal: The snapshot handler should not stay stuck forever if it cannot take table level lock, it should fail-fast. !image.png!" Finish 3.0.0-beta-1 release,13562076,Resolved,Major,Fixed,16/Dec/23 08:11,19/Jan/24 10:35,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Add xml to download page(via HBASE-28265) # Push tag 3.0.0-beta-1RC0 as tag rel/3.0.0-beta-1 # Release 3.0.0-beta-1 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12353291 # Add release data on https://reporter.apache.org/addrelease.html?hbase # Send announcement email" Enhance ByteBufferUtils.readVLong to read more bytes at a time,13561557,Resolved,Major,Fixed,12/Dec/23 14:22,16/Jan/24 14:17,,"Currently, ByteBufferUtils.readVLong is used to decode rows in all data block encodings in order to read the memstoreTs field. For a data block encoding like prefix, ByteBufferUtils.readVLong can surprisingly occupy over 50% of the CPU time in BufferedEncodedSeeker.decodeNext (which can be quite a hot method in seek operations).   Since memstoreTs will typically require at least 6 bytes to store, we could look to vectorize the read path for readVLong to read 8 bytes at a time instead of a single byte at a time (like in https://issues.apache.org/jira/browse/HBASE-28025) in order to increase performance.   Attached is a CPU flamegraph of a region server process which shows that we spend a surprising amount of time in decoding rows from the DBE in ByteBufferUtils.readVLong." Add 3.0.0-beta-1 to download page,13562075,Resolved,Major,Fixed,16/Dec/23 08:08,16/Jan/24 04:10,, MOB HFiles are expired earlier than their reference data,13562867,Resolved,Major,Fixed,25/Dec/23 14:28,13/Jan/24 09:59,2.5.0,"I have observed that mob HFiles are expired earlier than their reference data. Upon reviewing the relevant code, it was observed that the standard expired timestamp is not accurately set. The issue arises from the fact that if we do not set the calendar to the MILLISECOND level, a three-digit random number is appended to the end of the expired timestamp, leading to inaccuracies. For instance, if we write mob data to a Time-To-Live (1 day) table at 22:00 on 12/20/2023, and the ExpiredMobFileCleaner begins to work at 20:00 on 12/21/2023, the timestamp of the mob HFile will be parsed as 1703001600000, and the StandardExpiredTS is calculated as 1703001600314 with the three-digit random number as MILLISECOND. Consequently, the StandardExpiredTS >= MobHfileTS, thus indicating that the mob HFile should be expired. However, it is observed that this mob HFile only exists for 22 hours, which is less than the specified one-day-time threshold." Put up 3.0.0-beta-1RC0,13562074,Resolved,Major,Fixed,16/Dec/23 08:08,14/Jan/24 09:03,, Add sun.net.dns and sun.net.util to the JDK11+ module exports in the hbase script,13561149,Resolved,Major,Fixed,08/Dec/23 13:16,09/Jan/24 17:23,,"As noted in HBASE-28247, HBase can run into module permission issues that are not handled in the current JDK11 options in the hbase startup script. The surefire test config also includes some JDK17 specific options, we should also add those as needed. We are not yet aware of any additional JVM options required by Java 21. " Evaluate using hbase-shaded-client-byo-hadoop for Spark connector,13559020,Resolved,Major,Done,22/Nov/23 12:11,09/Jan/24 07:44,,"Since 3.2 Spark now uses hadoop-client-api and hadoop-client-runtime. While we don't actually specify what HBase libraries are needed on the Spark client side for the connector, at least the Cloudera docs specify the classes provided by ""hbase mapredcp"" which includes the full unshaded Hadoop JAR set. Investigate whether  *hbase-shaded-client-byo-hadoop* and the *hbase-client-api* and *hbase-client-runtime* is enough for the connector, and if yes, document how to set the Spark classpath. Alternatively, if *hbase-shaded-client-byo-hadoop*  is not enough, check if *hbase-shaded-mapreduce* plus the above two shaded Hadoop client JAR provides everything needed." Document Spark classpath requirements for the Spark connector,13559026,Open,Major,,22/Nov/23 12:21,,,"The README for the Spark connector details the classpath requirements for the HBase server side, but does not talk about how to set up the Spark classpath for HBase. The Cloudera docs [https://docs.cloudera.com/cdp-private-cloud-base/7.1.9/accessing-hbase/topics/hbase-configure-spark-connector.html] suggest using ""hbase mapredcp"" It is, however inconsistent, as ""hbase mapredcp"" includes the unshaded hadoop libraries, while the example command line omits the hadoop libraries (and seem to depend on the on the existing Hadoop JARs on the Spark classpath). Figure this out, and update the documentation. UPDATE: SPARK-33618 has reverted to using unshaded Hadoop. We only have to document the `hbase mapredcp` option. " Move minimum hadoop 3 support to 3.3.x for 2.6+,13562679,Resolved,Major,Fixed,22/Dec/23 06:36,06/Jan/24 09:20,,"Hadoop 3.2.x is EOL https://lists.apache.org/thread/43q19c7nlgqop94ow03cdrdqlmdfd8s9" Bump jruby to 9.3.13.0 and related joni and jcodings to 2.2.1 and 1.0.58 respectively,13560964,Resolved,Major,Fixed,07/Dec/23 09:40,03/Jan/24 14:28,,"Given branch-2 including branch-2.6 is already on 9.3.9.0, we should bump to at least 9.3.13.0. This will fix the bundled *org.bouncycastle : bcprov-jdk18on : 1.71* having [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] from our classpath for the least. As a follow up can try to bump to latest 9.4.x line. Otherwise I can try to work directly on HBASE-28250 as well, although this may not be straight forward and would require some good testing. Please let me know what others think." Use threadpool to create ref file as part of MergeTableRegionsProcedure,13556187,Open,Major,,31/Oct/23 06:10,,, The shouldPerformMajorCompaction in StripeCompactionPolicy is not implemented and does not periodically trigger the major of the table,13562987,Open,Major,,27/Dec/23 07:26,,,"shouldPerformMajorCompaction in StripeCompactionPolicy is not implemented, always returns false, HRegionServer -> CompactionChecker -> chore() -> s.shouldPerformMajorCompaction() is always false,  and the s.triggerMajorCompaction(); cannot be called, This causes the forceMajor variable to be false all the time." "After triggering a Major Compaction, clearing the force flag has no effect.",13562290,Open,Major,,19/Dec/23 08:43,,2.2.6,"In the HStore.java class, in the requestCompaction method, after manually triggering Major Compaction, this.forceMajor is set to true. When clearing the force flag, execute the following code: {code:java} this.forceMajor = this.forceMajor && !request.isMajor(); {code} However, when the table is applied to a Stripe Compaction strategy (other compaction policy may have similar problems), request.isMajor() is always false, because in CompactionRequestImpl the setIsMajor method is not always called. We need to check the calling status of the setIsMajor method. Otherwise, after a major is manually triggered, forceMajor will always be true, and subsequent periodic compactions will also be forced to a major compaction." Remove rename-pdf step in root pom on branch-3,13562840,Resolved,Major,Fixed,25/Dec/23 01:05,26/Dec/23 01:50,,"We do not generate ref guide on branches other than master, so this step will fail the release build..." PrefetchExecutor should not run for files from CFs that have disabled BLOCKCACHE,13559081,Resolved,Major,Fixed,22/Nov/23 17:36,28/Nov/23 14:56,2.4.17,"HFilePReadReader relies on the return of CacheConfig.shouldPrefetchOnOpen return to decide if it should run the PrefetchExecutor for the files. Currently, CacheConfig.shouldPrefetchOnOpen returns true if ""hbase.rs.prefetchblocksonopen"" is set to true at the config, OR PREFETCH_BLOCKS_ON_OPEN is set to true at CF level. There's also the CacheConfig.shouldCacheDataOnRead, which returns true if both hbase.block.data.cacheonread is set to true at the config AND BLOCKCACHE is set to true at CF level. If BLOCKCACHE is set to false at CF level, HFilePReadReader will still run the PrefetchExecutor to read all the file's blocks from the FileSystem, but then would find out the given block shouldn't be cached. I believe we should change CacheConfig.shouldPrefetchOnOpen to return true only if CacheConfig.shouldCacheDataOnRead is also true." BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated,13558728,Resolved,Major,Fixed,20/Nov/23 16:00,29/Nov/23 12:51,2.4.17,"We add blocks to BucketCache.blocksByHFile on doDrain before we actually had successfully added the block to the cache. We may still fail to cache the block if it is too big to fit any of the configured bucket sizes, or if we fail to write it in the ioengine and reach the tolerated io errors threshold. In such cases, the related block would remain in the BucketCache.blocksByHFile indefinitely." Create a jmx metrics to expose the oldWALs directory size,13558394,Resolved,Major,Fixed,17/Nov/23 11:21,08/Dec/23 10:47,2.4.17,Create a jmx metrics that can return the size of the old WALs in bytes. PrefetchExecutor should stop once cache reaches capacity,13555249,Resolved,Major,Fixed,23/Oct/23 21:50,23/Nov/23 21:33,2.6.0,"The prefetch executor runs a full scan on regions in the background once regions are opened, if the ""hbase.rs.prefetchblocksonopen"" property is set to true. However, if the store file size is much larger than the cache capacity, we should interrupt the prefetch once it has reached the cache capacity, otherwise it would just be triggering evictions of little value, since we don't have any sense of block priority at that point. It's better to stop the read, and let client reads cause the eviction of LFU blocks and cache the most accessed blocks." Put the cached time at the beginning of the block; run cache validation in the background when retrieving the persistent cache,13554865,Resolved,Major,Fixed,20/Oct/23 00:01,24/Oct/23 09:08,2.6.0,"In HBASE-28004, we added a ""cached time"" long at the end of each block on the bucket cache. We also record the cached time in the backing map we persist to disk periodically, in order to retrieve the cache upon crashes/restarts. The persisted backing map includes the last modification time of the cache itself. On restarts, once we read the backing map from the persisted file, we compare the last modification time of the cache recorded there against the last modification time of the cache. If those differ, it means the cache has been updated after the backing map has been persisted, so the backing map might not be accurate. We then iterate though the backing map entires and compare the entries cached time against the related block in the cache, and if those differ, we remove the entry from the map. Currently this validation is made at RS initialisation time, but with caches as large as 1.6TB/30M+ blocks, it can last to an hour, meaning the RS is useless over that time. This PR changes this validation to be performed in the background, whilst direct accesses to a block in the cache would also perform the ""cached time"" comparison. This PR also moves the ""cached time"" to the beginning of the block in the cache, instead of the end. We noticed that with the ""cached time"" at the end we can fail to ensure consistency at some conditions. Consider the following: 1) A block B1 of size S gets allocated at offset 0 with cached time T1; 2) The backing map is persisted, containing B1 at offset 0 and cached time T1; 3) B1 is evicted. It's offset in the cache is now free, however its contents are still there, including the cached time T1 at its end; 4) A new block B2 of size S/2 gets allocated at offset 0 with cached time T2; 5) RS crashes before the backing map gets saved, so the persisted backing map still has only the reference to B1, but not B2; 6) At restart, we run the validation. Because B2 was half the size of B1, we haven't overridden B1 cached time from the cache, so we will successfully validate B1, although its content is now half overridden by B2. " TestSimpleRegionNormalizer fails 100% of times on flaky dashboard,13552619,Resolved,Major,Fixed,02/Oct/23 10:14,03/Oct/23 07:37,, Attach the design doc to dev-support/design-docs,13562820,Resolved,Major,Fixed,24/Dec/23 07:22,24/Dec/23 14:11,, Resource leak for memstore and flush,13562835,Open,Major,,24/Dec/23 16:43,,3.0.0-beta-2," {code:java} 2023-12-16T23:44:13,992 ERROR [RpcServer.default.FPBQ.Fifo.handler=22,queue=1,port=16020] util.ResourceLeakDetector: .hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2845) org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2718) org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2692) org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2683) org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1850) org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1660) org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1615) org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1598) org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:132) org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:750) 2023-12-17T15:07:59,111 ERROR [regionserver/core-1-1:16020-longCompactions-0] util.ResourceLeakDetector: .java:45) java.lang.reflect.Constructor.newInstance(Constructor.java:423) org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:61) org.apache.hadoop.hbase.util.ReflectionUtils.newInstance(ReflectionUtils.java:98) org.apache.hadoop.hbase.regionserver.HStore.getMemstore(HStore.java:377) org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:283) org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6904) org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1173) org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1170) java.util.concurrent.FutureTask.run(FutureTask.java:266) java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) java.util.concurrent.FutureTask.run(FutureTask.java:266) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:750) {code} " Phase II: Suspend TRSP and SCP when they can not get region node lock immediately,13560569,Resolved,Major,Fixed,05/Dec/23 02:30,24/Dec/23 07:21,, The warmup of the region failed because the HFile was archived due to the execution of a compaction.,13562833,Open,Major,,24/Dec/23 16:10,,,"During the execution of warmUpRegion in HRegionServer, the process of loading HFiles begins with the identification of the HFiles that need to be loaded, followed by the actual loading process. If an HFile is moved or deleted before it is loaded, the loading process will fail due to the missing HFile, leading to the failure of the entire warmUpRegion process. The reason an HFile might be moved before being loaded is that the region has not been closed yet. While the source RegionServer is still operational, if a compaction or split occurs, the original HFiles can be archived. The logs are as followed: {code:java} 2023-12-16T22:47:00,989 ERROR [RpcServer.default.FPBQ.Fifo.handler=7,queue=1,port=16020] regionserver.HRegion: Could not initialize all stores for the region=itbll,\xE9x\xD4\xFD\xF3\xB6E8,1702703598150.4eb5a64755a98500833e3daae883d3a3. 2023-12-16T22:47:00,990 ERROR [RpcServer.default.FPBQ.Fifo.handler=7,queue=1,port=16020] regionserver.RSRpcServices: Failed warmup of itbll,\xE9x\xD4\xFD\xF3\xB6E8,1702703598150.4eb5a64755a98500833e3daae883d3a3. java.io.IOException: java.io.IOException: java.io.FileNotFoundException: File does not exist: hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/6dc12f7a46914e89a4e97d2d90a23e8d         at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1207) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.initializeWarmup(HRegion.java:1231) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.warmupHRegion(HRegion.java:7841) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.RSRpcServices.warmupRegion(RSRpcServices.java:2014) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:35678) ~[hbase-protocol-shaded-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:437) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] Caused by: java.io.IOException: java.io.FileNotFoundException: File does not exist: hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/6dc12f7a46914e89a4e97d2d90a23e8d         at org.apache.hadoop.hbase.regionserver.StoreEngine.openStoreFiles(StoreEngine.java:289) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.initialize(StoreEngine.java:339) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:300) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6904) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1173) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1170) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_372]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_372]         at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_372]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_372]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_372]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_372] Caused by: java.io.FileNotFoundException: File does not exist: hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/6dc12f7a46914e89a4e97d2d90a23e8d         at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1606) ~[hadoop-hdfs-client-3.2.4.jar:?]         at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1599) ~[hadoop-hdfs-client-3.2.4.jar:?]         at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) ~[hadoop-common-3.2.4.jar:?]         at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1614) ~[hadoop-hdfs-client-3.2.4.jar:?]         at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:458) ~[hadoop-common-3.2.4.jar:?]         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.getReferencedFileStatus(StoreFileInfo.java:399) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.computeHDFSBlocksDistributionInternal(StoreFileInfo.java:352) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.computeHDFSBlocksDistribution(StoreFileInfo.java:346) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.initHDFSBlocksDistribution(StoreFileInfo.java:690) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.open(HStoreFile.java:381) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.HStoreFile.initReader(HStoreFile.java:512) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.createStoreFileAndReader(StoreEngine.java:226) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.StoreEngine.lambda$openStoreFiles$0(StoreEngine.java:267) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_372]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_372]         at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_372]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_372]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_372]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_372] {code} {code:java} 2023-12-16T22:46:56,451 INFO [regionserver/core-1-4:16020-shortCompactions-0] regionserver.HStore: Starting compaction of [hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/139a3688cfac4f32b29feb48b62f8ce9, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/a9285dad2eb44a7d8a0bbeb49232b434, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/6dc12f7a46914e89a4e97d2d90a23e8d, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/e54ec6ddb95d4651920951cc30a9432b, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/4521b2df0a4b4191a1736b99453db6dd] into tmpdir=hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/.tmp, totalSize=2.4 M 2023-12-16T22:46:56,451 DEBUG [regionserver/core-1-4:16020-shortCompactions-0] compactions.Compactor: Compacting 6dc12f7a46914e89a4e97d2d90a23e8d, keycount=70891, bloomtype=ROWPREFIX_FIXED_LENGTH, size=1.5 M, encoding=FAST_DIFF, compression=LZ4, seqNum=1567586 2023-12-16T22:47:00,567 DEBUG [StoreCloser-itbll,\xE9x\xD4\xFD\xF3\xB6E8,1702703598150.4eb5a64755a98500833e3daae883d3a3.-1] regionserver.HStore: Moving the files [hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/139a3688cfac4f32b29feb48b62f8ce9, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/a9285dad2eb44a7d8a0bbeb49232b434, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/6dc12f7a46914e89a4e97d2d90a23e8d, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/e54ec6ddb95d4651920951cc30a9432b, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/4521b2df0a4b4191a1736b99453db6dd, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/d9c9d500d36f46f295ede09f857ab1aa, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/e79f2c8de1b3497e9cd2419abd96cde0, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/1cd3513db5204235b89abc0c8ea90754] to archive 2023-12-16T22:47:00,580 DEBUG [StoreCloser-itbll,\xE9x\xD4\xFD\xF3\xB6E8,1702703598150.4eb5a64755a98500833e3daae883d3a3.-1] backup.HFileArchiver: Archived from FileableStoreFile, hdfs://master-1-1:9000/v3/hbase/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/6dc12f7a46914e89a4e97d2d90a23e8d to hdfs://master-1-1:9000/v3/hbase/archive/data/default/itbll/4eb5a64755a98500833e3daae883d3a3/tiny/6dc12f7a46914e89a4e97d2d90a23e8d {code} " Yield SCP and TRSP when they are blocked,13557459,Resolved,Major,Fixed,10/Nov/23 08:47,24/Dec/23 14:11,, "Change zookeeper.zone.parent and restart hbase cluster, hmaster will be stuck waiting for hbase:meta online ",13562588,Open,Major,,21/Dec/23 10:42,,2.2.7,"In our scenario, we usually change zookeeper.zone.parent=/hbase-unsecure to /hbase-secure when enabling kerberos authentication. after restart the hbase cluster, we will almost certainly be stuck on master initalization.  we can see hmaster stuck in waiting for the InitMetaProcedure finish !image-2023-12-21-18-34-33-586.png|width=1221,height=220! In the regionserver log, we find the regionserver receive duplicate open meta region request, and it does not respond to hmaster the second time. so the hmaster wait the procedure in a long time. !image-2023-12-21-18-36-36-282.png|width=1527,height=163! We suspect that both the servercrash procedure and hmaster startup trigger the procedure for the online meta table. !image-2023-12-21-18-41-55-819.png|width=714,height=331!   hmaster log this, so it will send a assign meta request to regionserver !image-2023-12-21-18-42-47-764.png|width=720,height=30!   So any suggestions to avoid this?  " Fix broken ruby scripts and clean up logging,13562249,Resolved,Major,Fixed,18/Dec/23 18:17,22/Dec/23 09:10,3.0.0-alpha-4,"Some of the ruby scripts are broken in 3.x as they are referencing non-existent classes, these were deprecated earlier and removed in 3.x: * {{org.apache.hadoop.hbase.client.HBaseAdmin}} * {{org.apache.hadoop.hbase.HTableDescriptor}} Following 4 scripts are failing: {code:java} NameError: missing class name org.apache.hadoop.hbase.client.HBaseAdmin method_missing at org/jruby/javasupport/JavaPackage.java:253

at region_status.rb:50 {code} {code:java} {NameError: missing class name org.apache.hadoop.hbase.HTableDescriptor method_missing at org/jruby/javasupport/JavaPackage.java:253
at replication/copy_tables_desc.rb:30 {code} {code:java} NameError: missing class name org.apache.hadoop.hbase.client.HBaseAdmin method_missing at org/jruby/javasupport/JavaPackage.java:253
at draining_servers.rb:28 {code} {code:java} NameError: missing class name org.apache.hadoop.hbase.client.HBaseAdmin method_missing at org/jruby/javasupport/JavaPackage.java:253
at shutdown_regionserver.rb:27 {code}" Fix spotless error on branch-2.5,13562072,Resolved,Major,Fixed,16/Dec/23 07:51,17/Dec/23 13:41,, Review the usage of RegionStates.getOrCreateServer,13555937,Resolved,Major,Fixed,29/Oct/23 11:35,16/Dec/23 12:15,,"It failed two times in this PR. https://github.com/apache/hbase/pull/5475 Filed an issue to track this problem." create-release should run spotless,13562088,Open,Major,,16/Dec/23 18:33,,,Before committing generated files like CHANGES.md and RELEASENOTES.md we should run 'mvn spotless:apply' first to ensure what is committed is formatted per our rules and will not be modified when someone invokes spotless later. hbck should report previously reported regions with null region location,13554325,Resolved,Major,Fixed,16/Oct/23 23:04,25/Oct/23 23:55,2.5.6,"Operators bypassed some in progress TRSPs leading to a state where some regions were persistently in transition but hidden. Because the master builds its list of regions in transition by tracking TRSP, the bypass of TRSP removed the regions from the RIT list. This was expected, but I will propose a change to RIT tracking on another issue. The online hbck chore also did not report the inconsistency. This was not expected. HBASE-28144 was another issue related to this incident, already fixed. Ensure that hbck will report as inconsistent regions where previously a location was reported but now the region location is null, if it is not expected to be offline." Bump jackson version to 2.15.2 ,13560815,Resolved,Major,Fixed,06/Dec/23 13:16,14/Dec/23 18:16,,"We should bump jackson to 2.15.2 as it is already move to this in hbase-thirdparty in HBASE-28093  Also 2.14.1 has [sonatype-2022-6438.|https://github.com/FasterXML/jackson-core/issues/861]" Sync internal protobuf version for hbase to be same as hbase-thirdparty,13560831,Resolved,Major,Fixed,06/Dec/23 14:29,14/Dec/23 17:20,,hbase-thirdparty 4.1.5 uses protobuf 3.24.3 while hbase is still on 3.21.12. This Jira is to sync internal protobuf version for hbase to be same as hbase-thirdparty. The configs for using meta replica can conflict,13557668,Open,Major,,13/Nov/23 07:53,,2.5.6,"The config of ""hbase.locator.meta.replicas.mode"" can surpass switching off reading from meta replica by ""hbase.meta.replicas.use"". UTs by setting hbase.meta.replicas.use=false and hbase.locator.meta.replicas.mode=LoadBalance can recur the problem." Phase I: Suspend TRSP and SCP when updating meta,13557698,Resolved,Major,Fixed,13/Nov/23 10:34,04/Dec/23 09:01,, ProcedureTestingUtility.restart is broken sometimes after HBASE-28199,13560818,Resolved,Major,Fixed,06/Dec/23 13:34,13/Dec/23 14:05,,"In ProcedureTestingUtility.restart, we will reuse the same ProcedureExecutor, so when restarting, we need to make sure that all procedures are not executed and then clear the scheduler. But after HBASE-28199, we may add procedures back to scheduler after a CompletableFuture is completed, so even if all the PEWorker are terminated we could still add things to scheduler, which may break some tests. We need to find a way to deal with this." The snapshot operation encountered an NPE and failed.,13560571,Resolved,Major,Fixed,05/Dec/23 02:38,12/Dec/23 15:21,3.0.0-beta-1,"Executing a merge region before the snapshot operation is completed will result in an NPE error for the snapshot operation and cause it to fail Triggering logic # Execute the snapshot command. # Merge regions before the snapshot is completed. # After the merge is completed, the two parent regions will be cleaned up. # An NPE will be reported when the snapshot operation is performed on that parent region. The log is as follow: {code:java} 2023-11-20T23:26:07,061 ERROR [PEWorker-13] procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception: pid=238720, ppid=238714, state=RUNNABLE, hasLock=true; SnapshotRegionProcedure c47539f1d6032ba1a037f5279c22baa0 java.lang.NullPointerException: null         at org.apache.hadoop.hbase.master.procedure.SnapshotRegionProcedure.execute(SnapshotRegionProcedure.java:160) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.master.procedure.SnapshotRegionProcedure.execute(SnapshotRegionProcedure.java:58) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:921) ~[hbase-procedure-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1649) ~[hbase-procedure-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1395) ~[hbase-procedure-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75) ~[hbase-procedure-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1961) ~[hbase-procedure-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[hbase-common-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1988) ~[hbase-procedure-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] {code}" [SFT] Add description for specifying SFT impl during snapshot recovery,13561136,Resolved,Major,Fixed,08/Dec/23 12:04,11/Dec/23 10:19,4.0.0-alpha-1,"HBASE-26286 added an option to clone_snapshot command that allows for specifying the SFT implementation during the snapshot recovery. This really useful when recovering snapshots imported from clusters not using the same SFT impl as the one where we are cloning it. Without this, the cloned/restore table will get created with the the SFT impl of its original cluster, requiring extra conversion steps using the MIGRATION tracker. This also fix formatting for the ""Bulk Data Generator Tool"", which is currently displayed as a sub-topic of the SFT chapter. It should have it's own chapter." HBCK2 filesystem command to fix version file fails when Master in not up,13561267,In Progress,Major,,10/Dec/23 10:47,,hbase-operator-tools-1.2.0,"Recently while fixing an issue for a customer, I observed that the hbase master keeps restarting because of missing hbase version file. When trying to fix the issue using the hbck2 filesystem -f command, it kept trying to connect to the hbase master as a pre-check for supported hbase versions, but as the master was not up, the command never progressed beyond the connection creation step. It seems unnecessary to check supported versions in filesystem command as it is all offline checks. " Include shaded netty-all in hbase-shaded-mapreduce,13559712,Resolved,Major,Invalid,28/Nov/23 13:23,08/Dec/23 19:01,2.4.17,"Since ZooKeeper TLS connection is supported within HBase, we need netty-all on the classpath. It's already present in hbase-shaded-client and we need it in hbase-shaded-mapreduce for MR clients too. netty-all is already included in pom.xml, but only with test-scope, so shading plugin doesn't add it to the jar. Patch will override it to compile-scope." [JDK17] JVM crashes intermittently on aarch64,13558155,Resolved,Major,Fixed,16/Nov/23 02:59,06/Dec/23 20:13,,"The crash is related to the C1 JIT compiler. It's crashing while trying to compile RegionServerMetricsWrapperRunnable. See [https://github.com/adoptium/adoptium-support/issues/951] for a bit more details (no resolution yet). I'm going to experiment with breaking up the run() method a bit to see if it can play nicer with the compiler. The recommendation from the adoptium folks was to try disabling the C1 compiler, which I'd rather not do." Do not need to maintain rollback step when root procedure does not support rollback,13558789,Resolved,Major,Fixed,21/Nov/23 04:01,02/Dec/23 13:15,,"In HBASE-28210, we need to synchronized on RootProcedureState when updating procedure store, which will decrease the performance a lot when there are lots of sub procedures for a procedure, such as SCP, so it will impact MTTR. But actually, SCP does not support rollback, so I do not think we need to maintain this information. If so, I think we do not need the synchronization added in HBASE-28210, at least for SCP then. This could get the performance back." The flush table operation encountered an NPE and failed.,13559817,Resolved,Major,Fixed,29/Nov/23 03:49,04/Dec/23 09:00,3.0.0-beta-1,"Executing a merge region before the flush table is completed will result in an NPE error for the flush table and cause it to fail Triggering logic # Execute the flush table command. # Merge regions before the flush is completed. # After the merge is completed, the two parent regions will be cleaned up. # An NPE will be reported when the flush operation is performed on that parent region." Leak in ExportSnapshot during verifySnapshot on S3A,13559625,Resolved,Major,Fixed,27/Nov/23 23:15,01/Dec/23 13:56,,"Each S3AFileSystem creates an S3AInstrumentation and various metrics sources, with no real way to disable that. In HADOOP-18526, a bug was fixed so that these are not leaked. But in order to use that, you must call S3AFileSystem.close() when done. In ExportSnapshot, ever since HBASE-12819 we set fs.impl.disable.cache to true. It looks like that was added in order to prevent conflicting calls to close() between mapper and main thread when running in a single JVM. When verifySnapshot is enabled, SnapshotReferenceUtil.verifySnapshot iterates all storefiles (could be many thousands) and calls SnapshotReferenceUtil.verifyStoreFile on them. verifyStoreFile makes a number of static calls which end up in CommonFSUtils.getRootDir, which does Path.getFileSystem(). Since the FS cache is disabled, every single call to Path.getFileSystem() creates a new FileSystem instance. That FS is short lived, and gets GC'd. But in the case of S3AFileSystem, this leaks all of the metrics stuff. We have two easy possible fixes: # Only set fs.impl.disable.cache when running hadoop in local mode, since that was the original problem. # When calling verifySnapshot, create a new Configuration which does not include the fs.impl.disable.cache setting. I tested out #2 in my environment and it fixed the leak." Update branch-2 version to 2.7-SNAPSHOT,13559906,Resolved,Major,Fixed,29/Nov/23 14:03,30/Nov/23 20:20,, Graceful shutdown of active hmaster,13557941,Open,Major,,14/Nov/23 17:19,,,"We recently had an operational incident due to bad interplay between an ongoing maintenance of regionservers, and a new maintenance of hmasters. We'd been running a rolling restart of regionservers. Someone unknowingly started a rolling restart of hmasters. This caused long RITs on a few clusters, what happened was: * regionserver restart executed a region move * hmaster saw it and started TSRP, sending request to RS to close region * immediately after, the hmaster stopped due to that rolling restart * the regionserver saw the close request, closed the region, and tried to report state back to the hmaster. * This spammed tons of failures for the next 30+ secs while the new hmaster became active. * Finally the new hmaster started up and recovered the state and the RIT finished. Long RITs are really painful and effectively downtime for hbase. I think we should have a shutdown hook on the hmaster which: * Sets state so new move requests are rejected * Waits for any existing move TSRP to finish * Shuts down" Setup jenkins job for branch-2.6,13559907,Resolved,Major,Done,29/Nov/23 14:03,30/Nov/23 01:04,, Bump cryptography from 41.0.4 to 41.0.6 in /dev-support/git-jira-release-audit ,13559813,Resolved,Major,Fixed,29/Nov/23 03:04,29/Nov/23 03:05,, Create branch-2.6,13559905,Resolved,Major,Done,29/Nov/23 14:02,29/Nov/23 17:49,, Add a check for getQueueStorage().hasData() in the getDeletableFiles method of ReplicationLogCleaner,13559127,Resolved,Major,Fixed,23/Nov/23 01:32,24/Nov/23 02:40,3.0.0,"There are a large number of oldwal files in the oldwal directory, and the default value of hbase.master.logcleaner.ttl is 10 minutes. Upon observation, it has been noticed that no oldwal files have been cleared. Through analyzing the source code, it has been discovered that the following logic contains a problem. When LogCleaner executes the checkAndDeleteFiles method, it calls the getDeletableFiles method of ReplicationLogCleaner. One of the logics in this method is that if canFilter is false, it will directly return Collections.emptyList(), which means that the wal data filtered out by TimeToLiveLogCleaner will be filtered out. This in turn leads to the files under oldwal not being able to be cleared." Use x86_64 protoc 2.5.0 on Aarch64 Mac,13558181,Resolved,Major,Duplicate,16/Nov/23 08:09,16/Nov/23 16:29,2.4.17,"Hbase as a profile for building on Aarch64 Linux, but it doesn't work on Mac. We have solved the same problem on Phoenix by using x86_64 in this case via emulation." Security Vulnerability - Action Required: “Incorrect Permission Assignment for Critical Resource” vulnerability in some components of org.apache.hbase,13557893,Open,Major,,14/Nov/23 12:24,,1.1.2," I think the method org.apache.hadoop.mapreduce.filecache.ClientDistributedCacheManager.checkPermissionOfOther(FileSystem fs, Path path, FsAction action, Map statCache) may have an “Incorrect Permission Assignment for Critical Resource”vulnerability which is vulnerable in in some components of org.apache.hbase. It shares similarities to a recent CVE disclosure _CVE-2017-3166_ in the project _""apache/hadoop""_ project. The influencing components are listed below: # org.apache.hbase:hbase-shaded-server in the versions of 1.1.13;1.2.5~1.2.7;1.3.0~1.3.2. # org.apache.hbase:hbase-shaded-mapreduce in the versions of 2.0.0-alpha3 # org.apache.hbase:hbase-shaded-client in the versions of 1.1.2~1.1.9;1.3.2 The source vulnerability information is as follows:  !https://mail.google.com/mail/u/0?ui=2&ik=35947afd70&attid=0.1&permmsgid=msg-f:1782522681557497681&th=18bccaef464fb751&view=fimg&fur=ip&sz=s0-l75-ft&attbid=ANGjdJ_bBS_0CMiL9kNUgnr95IJelNJAQJp906nnAonpFswrxMbSt1EVV1S2q6kq_ur-YE-1H49gOCjMGqFYtm5xBOS_EBOZci8ukIw2Hn8kM-9OIKVIxXrlhcRm6LA&disp=emb&realattid=ii_lmt56kbv0|width=1,height=1!!https://mail.google.com/mail/u/0?ui=2&ik=35947afd70&attid=0.2&permmsgid=msg-f:1782522681557497681&th=18bccaef464fb751&view=fimg&fur=ip&sz=s0-l75-ft&attbid=ANGjdJ-8wPNUdQ35WBKaadck2X1lP34blTQ_qiyhu5T7l0G8T4cboSCiFNgfxaCQZZsK-Pm3ebzj4JSWBs558OxWHJPM1uJqKlMvPMhpx9J0TiojhC85DNqeLu3dr2Q&disp=emb&realattid=ii_lmt6415i0|width=1,height=1!!https://mail.google.com/mail/u/0?ui=2&ik=35947afd70&attid=0.0.1&permmsgid=msg-f:1782522681557497681&th=18bccaef464fb751&view=fimg&fur=ip&sz=s0-l75-ft&attbid=ANGjdJ9XERxykP1zaB9Codaz3lisQ9gKwLHXnEIHP4p4oUcINmdFEWTJAWeDMfayncBsWIBj_kc2cAKHx4c7InMtKL98nDb2Dnt3TpfGLQCcJhdFsSBhemVA14CI0rA&disp=emb&realattid=ii_loxzzieb0|width=1,height=1! *Vulnerability Detail:* *CVE Identifier:* CVE-2017-3166 {*}Description{*}: In Apache Hadoop versions 2.6.1 to 2.6.5, 2.7.0 to 2.7.3, and 3.0.0-alpha1, if a file in an encryption zone with access permissions that make it world readable is localized via YARN's localization mechanism, that file will be stored in a world-readable location and can be shared freely with any application that requests to localize that file. *Reference:*[ |http://goog_608275719/] [https://nvd.nist.gov/vuln/detail/CVE-2017-3166] {*}Patch{*}: [https://github.com/apache/hadoop/commit/a47d8283b136aab5b9fa4c18e6f51fa799d91a29] *Vulnerability Description:* The vulnerability is present in the class  org.apache.hadoop.mapreduce.filecache.ClientDistributedCacheManager  of method  checkPermissionOfOther(FileSystem fs, Path path, FsAction action, Map statCache)  , which is responsible for checking the permissions of other files in the distributed cache.. {*}But t{*}{*}he check snippet is similar to the vulnerable snippet for CVE-2017-3166{*} and may have the same consequence as CVE-2017-3166: {*}a file in an encryption zone with access permissions  will be stored in a world-readable location and can be freely shared with any application that requests the file to be localized{*}. Therefore, maybe you need to fix the vulnerability with much the same fix code as the CVE-2017-3166 patch.      Considering the potential risks it may have, I am willing to cooperate with you to verify, address, and report the identified vulnerability promptly through responsible means. If you require any further information or assistance, please do not hesitate to reach out to me. Thank you and look forward to hearing from you soon.  " Add Endpoint and Method Name to COPROC_EXEC Spans,13557827,Open,Major,,14/Nov/23 06:29,,,"If we assume parentBased=on, then it's enough to add this information on the client side. However, we may want to also add this on the server side for stochastic tracing. We could call these: _db.hbase.endpoint.name_ _db.hbase.endpoint.method_ or  _db.hbase.coprocessor.name_ _db.hbase.coprocessor.method_" Enrich trace span information,13557825,Open,Major,,14/Nov/23 06:13,,2.5.6,"As I'm working on adding usable Trace data to Phoenix, I find that HBase trace spans are missing crucial information. This an umbrella ticket to track those issues, and add crucial information that is needed for interpreting trace data. The goal is to add the most useful data while keeping the Span data as compact as possible." Update plugin for SBOM generation to 2.7.10,13557423,Resolved,Major,Fixed,10/Nov/23 04:50,10/Nov/23 14:23,,Update the CycloneDX Maven plugin for SBOM generation to 2.7.10 Meta browser can happen NPE when the server or target server of region is null,13557035,Resolved,Major,Fixed,07/Nov/23 14:10,10/Nov/23 14:26,2.4.13,"Reproduction Steps: 1. We create a new table with many regions , for example:  {code:java} //代码占位符 create 't01' , 'info' , SPLITS => Array(1..999).map{|e|e.to_s}{code} 2. At the same time, we scan meta entries of this table on meta browser by hbase UI 3. We would get NPE if those regions is initializing and the server or target server is null" RpcLogDetails' Message can become corrupt before log is consumed,13555234,Resolved,Major,Fixed,23/Oct/23 19:20,09/Nov/23 18:15,,"The RpcLogDetails class represents a slow (or large) log event which will later be consumed by the SlowLogQueueService. Right now the RpcLogDetails' param field points to the slow call's Message, and this Message is backed by a CodedInputStream which may be overwritten before the given log is consumed. This overwriting of the Message may result in slow query payloads for which the metadata derived post-consumption is inaccurate. To solve this bug I think we need to copy the Message in the RpcLogDetails constructor. I have this bug reproduced in a QA environment and will test out this idea and open a PR shortly if the test results are promising." Narrow the netty3 dependency scope,13556841,Open,Major,,06/Nov/23 03:47,,,"Netty 3 has a bunch of CVEs and will never be fixed. In HBase, we poll in netty 3 dependency through hadoop, and till hadop 3.3.6, the dependency is still there. The only place for hadoop 3.1.x where we depend on netty 3 is in MR's ShuffleHandler. https://issues.apache.org/jira/browse/HADOOP-15327 So I think at least wecould narrow the dependency scope for netty 3 to test scope, as it is only used in tests we start a MiniMRCluster." Add hbase-connectos 1.0.1 to download page,13554480,Resolved,Major,Fixed,17/Oct/23 23:53,30/Oct/23 01:34,,need a PR to add hbase-connectors rel/1.0.1 to download page. Release hbase-connectors 1.0.1,13554477,Resolved,Major,Fixed,17/Oct/23 23:53,30/Oct/23 01:36,, Complete release hbase-connectors 1.0.1,13554478,Resolved,Major,Fixed,17/Oct/23 23:53,30/Oct/23 01:35,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Add xml to download page # Push tag 1.0.1RC as tag rel/1.0.1 # Release 1.0.1 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12345436 # Add release data on [https://reporter.apache.org/addrelease.html?hbase] # Send announcement email" ITBLL verify failed and found undefined nodes and nodes which lost big or tiny families.,13555599,Open,Major,,26/Oct/23 07:00,,3.0.0-beta-1,"Itbll verify failed, indicating possible data loss. The related log is as follows: {code:java} 2023-10-26T07:41:31,306 ERROR [main] test.IntegrationTestBigLinkedList$Verify: Found an undefined node. Undefined count=3044 2023-10-26T07:41:31,306 ERROR [main] test.IntegrationTestBigLinkedList$Verify: Found nodes which lost big or tiny families, count=2 2023-10-26T07:42:30,927 ERROR [main] util.AbstractHBaseTool: Error running command-line tool java.lang.RuntimeException: Verify.run failed with return code: 1         at org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Loop.runVerify(IntegrationTestBigLinkedList.java:1548) ~[hbase-it-3.0.0-beta-1-SNAPSHOT-tests.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Loop.run(IntegrationTestBigLinkedList.java:1583) ~[hbase-it-3.0.0-beta-1-SNAPSHOT-tests.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) ~[hadoop-common-3.2.4.jar:?]         at org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList.runTestFromCommandLine(IntegrationTestBigLinkedList.java:1955) ~[hbase-it-3.0.0-beta-1-SNAPSHOT-tests.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:150) ~[hbase-it-3.0.0-beta-1-SNAPSHOT-tests.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:151) ~[hbase-common-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT]         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) ~[hadoop-common-3.2.4.jar:?]         at org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList.main(IntegrationTestBigLinkedList.java:1998) ~[hbase-it-3.0.0-beta-1-SNAPSHOT-tests.jar:3.0.0-beta-1-SNAPSHOT] {code} Found undefined nodes {code:java} 2023-10-26 07:36:37,408 ERROR [main] org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Verify: Extras on ref without a def, ref=sJb\x8Au\xF7f\x9F\x86\xA4\x8C\x86U\xB6\x003, refPrevEqualsKey=true, key=\xF3\x0D\xF8u\xDD\xC3x\x80\x06\x82\x5C\x05.$\x1Fm, ref row date=Thu Oct 26 05:10:55 CST 2023, jobStr=Job: job_1698234646442_0014 Task: attempt_1698234646442_0014_m_000001_0, ref row count=26900714, ref row regionLocation=region=itbll,\xF2\xB0 \xC4\x9B\xA5\xE2\xE6,1698235151498.7fad6bc476873f19853d4988f6483a24., hostname=core-1-4.c-cf1f2d22f666ed69.cn-hangzhou.emr.aliyuncs.com,16020,1698276181696, seqNum=1554082, key row regionLocation=region=itbll,\xF2\xB0 \xC4\x9B\xA5\xE2\xE6,1698235151498.7fad6bc476873f19853d4988f6483a24., hostname=core-1-4.c-cf1f2d22f666ed69.cn-hangzhou.emr.aliyuncs.com,16020,1698276181696, seqNum=1554082 2023-10-26 07:36:37,408 ERROR [main] org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Verify: LinkedListError: key=\xF3\x0D\xF8u\xDD\xC3x\x80\x06\x82\x5C\x05.$\x1Fm, reference(s)=sJb\x8Au\xF7f\x9F\x86\xA4\x8C\x86U\xB6\x003 {code} Found nodes which lost big or tiny families {code:java} 2023-10-26 07:41:15,638 ERROR [main] org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Verify: LinkedListError: key=\xF3\x0E\x02\xC2\x14\xD9E-\x06\xAF\x9D\xEE\xBD\xB4*\x86, lost big or tiny families 2023-10-26 07:41:26,324 ERROR [main] org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList$Verify: LinkedListError: key=\xF3\x0D\xF8&\x13\xE3S\xA2\x06\x82\x5C""mH\xEBL, lost big or tiny families {code}" Put up hbase-connectors 1.0.1RC0 ,13554479,Resolved,Major,Fixed,17/Oct/23 23:53,28/Oct/23 00:30,,send out vote for hbase-connectors 1.0.1 Upgrade ZooKeeper for CVE-2023-44981,13555560,Resolved,Major,Duplicate,25/Oct/23 23:59,26/Oct/23 16:28,,"CVE-2023-44981 is a high scoring (9.1/10) authentication bypass vulnerability in ZooKeeper related to SASL quorum authentication. The bug is fixed in versions 3.7.2, 3.8.3, and 3.9.1. Upgrade ZK versions on all active branches. At least 3.7.2." Remove ServerManager's rsAdmins map,13553690,Resolved,Major,Fixed,11/Oct/23 13:02,24/Oct/23 02:56,2.5.5,"On 2.x [the ServerManager registers admins in a HashMap|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java]. This can result in thread safety issues — we recently observed an exception which caused a region to be indefinitely stuck in transition until we could manually intervene. We saw the following exception in the HMaster logs: {code:java} 2023-10-11 02:20:05.213 [RSProcedureDispatcher-pool-325] ERROR org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher: Unexpected error caught, this may cause the procedure to hang forever     java.lang.ClassCastException: class java.util.HashMap$Node cannot be cast to class java.util.HashMap$TreeNode (java.util.HashMap$Node and java.util.HashMap$TreeNode are in module java.base of loader 'bootstrap')         at java.util.HashMap$TreeNode.moveRootToFront(HashMap.java:1900) ~[?:?]         at java.util.HashMap$TreeNode.treeify(HashMap.java:2016) ~[?:?]         at java.util.HashMap.treeifyBin(HashMap.java:768) ~[?:?]         at java.util.HashMap.putVal(HashMap.java:640) ~[?:?]         at java.util.HashMap.put(HashMap.java:608) ~[?:?]         at org.apache.hadoop.hbase.master.ServerManager.getRsAdmin(ServerManager.java:723){code}" Update downloads.xml for release 2.5.6,13555026,Resolved,Major,Fixed,21/Oct/23 02:14,21/Oct/23 02:15,, Make use of assertThrows in TestShadeSaslAuthenticationProvider,13555079,Open,Major,,21/Oct/23 18:34,,,"This JIRA isa to address review comments as given in https://github.com/apache/hbase/pull/5434 and make use of assertThrows in TestShadeSaslAuthenticationProvider instead of fail. CC: [~zhangduo]" Bump urllib3 from 1.26.17 to 1.26.18 in /dev-support/git-jira-release-audit,13554804,Resolved,Major,Fixed,19/Oct/23 15:19,19/Oct/23 15:21,, HMaster crashes due to NPE at AsyncFSWAL.closeWriter,13554685,Open,Major,,19/Oct/23 04:13,,2.4.17,"I am testing the upgrade process of HMaster, when starting up the new version HMaster 2.4.17, it crashed immediately with the following exception. {code:java} 2023-10-17 21:03:35,892 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master hmaster,16000,1697576576301: Unhandled exception. Starting shutdown. ***** org.apache.hadoop.hbase.FailedCloseWALAfterInitializedErrorException: Failed close after init wal failed.         at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:167)         at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:62)         at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:295)         at org.apache.hadoop.hbase.master.region.MasterRegion.createWAL(MasterRegion.java:200)         at org.apache.hadoop.hbase.master.region.MasterRegion.bootstrap(MasterRegion.java:220)         at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:348)         at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:104)         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:855)         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2193)         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:528)         at java.lang.Thread.run(Thread.java:750) Caused by: java.io.IOException: java.lang.NullPointerException         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.shutdown(AbstractFSWAL.java:979)         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.close(AbstractFSWAL.java:1006)         at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:165)         ... 10 more Caused by: java.lang.NullPointerException         at java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)         at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.closeWriter(AsyncFSWAL.java:743)         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doShutdown(AsyncFSWAL.java:800)         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:951)         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:946)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         ... 1 more {code} h1. Reproduce It happens non-deterministically, around 2 out of 1802 tests. It might require an exception when HMaster interacts with the HDFS cluster since I noticed the following warning before the NPE exception {code:java} 2023-10-17 21:03:35,857 WARN  [master/hmaster:16000:becomeActiveMaster] asyncfs.FanOutOneBlockAsyncDFSOutputHelper: create fan-out dfs output /hbase/MasterData/WALs/hmaster,16000,1697576576301/hmaster%2C16000%2C1697576576301.1697576615700 failed, retry = 0 org.apache.hadoop.ipc.RemoteException(java.io.IOException): File /hbase/MasterData/WALs/hmaster,16000,1697576576301/hmaster%2C16000%2C1697576576301.1697576615700 could only be replicated to 0 nodes instead of minReplication (=1).  There are 1 datanode(s) running and no node(s) are excluded in this operation.         at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.chooseTarget4NewBlock(BlockManager.java:1832)         at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.chooseTargetForNewBlock(FSDirWriteFileOp.java:265)         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2586)         at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:889)         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:517)         at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:528)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:498)         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1038)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1003) {code} This remote excpetion might lead to a NULL writer and it further causes NPE to crash the HMaster. h1. Root Cause When invoking *inflightWALClosures.put(path.getName(), writer);* the writer is still null, this leads to an NPE which is not handled by HMaster and causes the crash. {code:java} hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncFSWAL.java private void closeWriter(AsyncWriter writer, Path path) {     inflightWALClosures.put(path.getName(), writer); // NPE     closeExecutor.execute(() -> {       try {         writer.close();       } catch (IOException e) {         LOG.warn(""close old writer failed"", e);       } finally {         // call this even if the above close fails, as there is no other chance we can set closed to         // true, it will not cause big problems.         markClosedAndClean(path);         inflightWALClosures.remove(path.getName());       }     });   }{code} I haven't figured out the exact reason why writer is NULL. Will keep digging the root cause. Any help is appreciated!   I have attached the full logs from HMaster." Fix hbase-connectors for release scripts ,13554498,Open,Major,,18/Oct/23 04:55,,hbase-connectors-1.0.1,"During the release for hbase-connectors 1.0.1 HBASE-28161, I found several issues 1. CHANGELOG.md was being used but our release script is using CHANGES.md to create new changes, see https://github.com/apache/hbase/blob/master/dev-support/create-release/release-util.sh#L578-L584 2. the do-release.sh script isn't working because of due 1/, I hacked it to make it work, but this would bring a backward compatible issues because no matter what the archive https://archive.apache.org/dist/hbase/hbase-connectors-1.0.0/ does not have the CHANGES.md for hbase-connectors. Proposing to fix it after the releases, " Add scala-parser-combinators dependency to connectors for Spark 3.4,13553155,Resolved,Major,Fixed,06/Oct/23 14:43,09/Oct/23 16:50,connector-1.0.0,The Spark connector doesn't compile with Spark 3.4 because of a missing scala-parser-combinators dependency. Intra-process client connections cause netty EventLoop deadlock,13554297,Open,Major,,16/Oct/23 19:44,,,"We've had a few operational incidents over the past few months where our HMaster stops accepting new connections, but can continue processing requests from existing ones. Finally I was able to get heap and thread dumps to confirm what's happening. The core trigger is HBASE-24687, where the MobFileCleanerChore is not using ClusterConnection. I've prodded the linked PR to get that resolved and will take it over if I don't hear soon. In this case, the chore is using the NettyRpcClient to make a local rpc call to the same NettyRpcServer in the process. Due to [NettyEventLoopGroupConfig|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/util/NettyEventLoopGroupConfig.java#L98], we use the same EventLoopGroup for both the RPC Client and the RPC Server. What happens rarely is that the local client for MobFileCleanerChore gets assigned to RS-EventLoopGroup-1-1. Since we share the EventLoopGroupConfig, and [we don't specify a separate parent group|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServer.java#L155], that group is also the group which processes new connections. What we see in this case is that RS-EventLoopGroup-1-1 gets hung in Socket.accept. Since the client side is on the same EventLoop, it's tasks get stuck in a queue waiting for the executor. So the client can't send the request that the server Socket is waiting for. Further, the client/chore gets stuck waiting on BlockingRpcCallback.get(). We use an HWT TimerTask to cancel overdue requests, but it only gets scheduled [once NettyRpcConnection.sendRequest0 is executed|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java#L371]. But sendRequest0 [executes on the EventLoop|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java#L393], and thus gets similarly stuck. So we never schedule a timeout and the chore gets stuck forever. While fixing HBASE-24687 will fix this case, I think we should improve our netty configuration here so we can avoid problems like this if we ever do intra-process RPC calls again (there may already be others, not sure)." TestZooKeeper could hang forever,13554251,Open,Major,,16/Oct/23 14:08,,,"Recently saw this several times in pre commit result. Checked the log output, it is stuck in testRegionServerSessionExpired. When replaying the edit for meta region, in the end we need to flush the memstore, and the flush is stuck which causes the test to timeout. This is the last log message for opening hbase:meta {noformat} 2023-10-15T14:37:46,704 INFO [RS_OPEN_META-regionserver/2c0085825d5f:0-0 {event_type=M_RS_OPEN_META, pid=9}] regionserver.HRegion(2885): Flushing 1588230740 4/4 column families, dataSize=74 B heapSize=1.22 KB {noformat} And when the test timed out, we saw this {noformat} 2023-10-15T14:47:57,360 WARN [RS_OPEN_META-regionserver/2c0085825d5f:0-0 {event_type=M_RS_OPEN_META, pid=9}] regionserver.HStore(846): Failed flushing store file for 1588230740/ns, retrying num=0 java.nio.channels.ClosedChannelException: null at org.apache.hadoop.hdfs.ExceptionLastSeen.throwException4Close(ExceptionLastSeen.java:73) ~[hadoop-hdfs-client-3.2.4.jar:?] at org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:153) ~[hadoop-hdfs-client-3.2.4.jar:?] at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:57) ~[hadoop-common-3.2.4.jar:?] at java.io.DataOutputStream.write(DataOutputStream.java:107) ~[?:1.8.0_352] at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.finishBlockAndWriteHeaderAndData(HFileBlock.java:1045) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.writeHeaderAndData(HFileBlock.java:1032) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.writeInlineBlocks(HFileWriterImpl.java:539) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.close(HFileWriterImpl.java:615) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.StoreFileWriter.close(StoreFileWriter.java:377) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.StoreFlusher.finalizeWriter(StoreFlusher.java:70) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:74) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:828) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:1969) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:3012) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2720) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsIfAny(HRegion.java:5458) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1032) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:966) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7774) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7729) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7704) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7663) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7619) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:138) ~[classes/:?] at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) ~[classes/:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_352] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_352] at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_352] {noformat} It is stuck on writing data to HDFS... Not sure what is the root cause, need to dig more..." Replace scala.util.parsing.json with org.json4s.jackson which used in Spark too,13554109,Resolved,Major,Fixed,14/Oct/23 17:48,16/Oct/23 07:58,connector-1.0.0,"In https://issues.apache.org/jira/browse/HBASE-28137 to support Spark 3.4 the scala-parser-combinators was added as direct dependency to HBase Spark Connector. This was needed as Spark 3.4 is not using scala-parser-combinators and it is not inherited as transitive dependency. But this solution has a disadvantage. As the HBase Spark Connector assembly jar does not include any 3rd party libraries the scala-parser-combinators must be added to the spark classpath for HBase Spark Connector to work. A much better solution is to replace scala.util.parsing.json with org.json4s.jackson which is used by Spark core, see https://github.com/apache/spark/blob/branch-3.4/core/pom.xml#L279-L280." AbstractWALProvider may miss the WAL which is under creation in getWALs method,13553284,Resolved,Major,Fixed,08/Oct/23 11:24,13/Oct/23 14:30,,"Found this problem when analysis HBASE-28114. In the AbstractFSWALProvider implementation, if wal field is null, we will acquire the creation lock so we can get the WAL instance which is under creation, so we will not miss the WAL instance, and also will not get an uninitialized WAL instance. We should try to do the same for remote WAL, otherwise the logic in WALEntryStream, where we rely on the return value of getWALs to test whether a WAL file is currently being written, will be broken." Specify -Xms for tests,13553084,Resolved,Major,Fixed,06/Oct/23 07:04,12/Oct/23 07:20,,"The default -Xms value is JVM dependent, but the host memory size is usually included in the calculation. -Xms in turn is used to calculate some GC parameters, for example NewSize and OldSize, which affect the behaviour of tests. As the memory consumption on the tests is not dependent on the host VM size, we could set -Xms for the tests explictly, and enjoy more consistent test results." Bump gitpython from 3.1.35 to 3.1.37 in /dev-support/flaky-tests,13553790,Resolved,Major,Fixed,12/Oct/23 06:53,12/Oct/23 07:03,, TestSyncTimeRangeTracker fails with OOM with small -Xms values,13553029,Resolved,Major,Fixed,05/Oct/23 15:53,11/Oct/23 13:24,2.4.17,"Edit2: It's not the OS, it's the -Xms value determined from the host memory size. Edit: It's related to the OS and it's default java 8 , not to the processor architecture. This test seems to be cutting real close to the heap size. On ARM, it consistently fails on my RHEL8.8 Aarch64 VM with Java 8. {noformat} mvn test -P runDevTests -Dtest.build.data.basedirectory=/ram2G -Dhadoop.profile=3.0 -fn -B -Dtest=TestSyncTimeRangeTracker* -pl hbase-server ... [ERROR] org.apache.hadoop.hbase.regionserver.TestSyncTimeRangeTracker.testConcurrentIncludeTimestampCorrectness  Time elapsed: 1.969 s  <<< ERROR! java.lang.OutOfMemoryError: Java heap space {noformat} It seems that Java on ARM has some higher memory overhead than x86_64. Simply bumping -Xmx from the default 2200m to 2300m allows it to pass.  {noformat} mvn test -P runDevTests -Dtest.build.data.basedirectory=/ram2G -Dhadoop.profile=3.0 -fn -B -Dtest=TestSyncTimeRangeTracker* -pl hbase-server -Dsurefire.Xmx=2300m ... [INFO] Running org.apache.hadoop.hbase.regionserver.TestSyncTimeRangeTracker [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.395 s - in org.apache.hadoop.hbase.regionserver.TestSyncTimeRangeTracker {noformat} However, the real solution should be reducing the memory usage for this test.  " Bump gitpython from 3.1.35 to 3.1.37 in /dev-support/git-jira-release-audit,13553791,Resolved,Major,Fixed,12/Oct/23 07:03,12/Oct/23 07:04,, Canary publish read failure fails with NPE if region location is null,13553443,Resolved,Major,Fixed,09/Oct/23 22:26,11/Oct/23 04:55,2.5.5,"Region with null server name causes canary failures while publishing read failure i.e. while updating perServerFailuresCount map: {code:java} 2023-10-09 15:24:11 [CanaryMonitor-1696864805801] ERROR tool.Canary(1480): Sniff region failed! java.util.concurrent.ExecutionException: java.lang.NullPointerException at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at org.apache.hadoop.hbase.tool.CanaryTool$RegionMonitor.run(CanaryTool.java:1478) at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.NullPointerException at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1837) at org.apache.hadoop.hbase.tool.CanaryTool$RegionStdOutSink.incFailuresCountDetails(CanaryTool.java:327) at org.apache.hadoop.hbase.tool.CanaryTool$RegionStdOutSink.publishReadFailure(CanaryTool.java:353) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.readColumnFamily(CanaryTool.java:548) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.read(CanaryTool.java:587) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:502) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:470) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ... 1 more {code}" Upgrade avro version to 1.11.3,13552642,Resolved,Major,Fixed,02/Oct/23 13:41,09/Oct/23 15:01,,"Dependabot has an alert about https://nvd.nist.gov/vuln/detail/CVE-2023-39410 But it says that it can not upgrade the dependencies automatically. Let's update it manually." Disable table may hang when SCP create TRSP but DTP didn't set tableState to disabling,13553232,Open,Major,,07/Oct/23 09:25,,2.4.17,"Consider the following case： 1. RegionServer stop or abort, ServerCrashProcedure start running; 2. Now, DisableTableProcedure start running but not set tableState to disabling; 3. ServerCrashProcedure create TransitStateProcedure with success, but can not running because of xLock had hold by DisableTableProcedure ; 4. DisableTable Procedure UnassignProcedure RPC fails because server is down." Is there plan or timeline that HBase java client will fully support JDK 17?,13553318,Resolved,Major,Invalid,09/Oct/23 02:39,09/Oct/23 02:44,,"We are using JDK 17 as our application programing platform,  but we found HBase document said java client only well supported {*}JDK 8{*}, may I ask whether there is any plan or timeline *JDK 17* can be supported by HBase java client? [https://hbase.apache.org/book.html#basic.prerequisites] Thanks." Do not retry refreshSources when region server is already stopping,13552738,Resolved,Major,Fixed,03/Oct/23 12:17,07/Oct/23 08:10,,"Found this when debugging HBASE-28114, it is designed to retry forever but when aborting a region server, we will stop the rpc client, and it will retry a lot of times and output a lot of logs, which even cause the Jenkins job OOM… I think we should throw the exception out directly and give up retry when aborting the region server. ==== Updated ==== It turns out that the problem is the retry when initialize new shipper failed. We should stop retrying when region server is already stopped. " list_quota_table_sizes returns a table whose quota is not set,13552590,Open,Major,,01/Oct/23 19:35,,2.4.17,"When using HBase cluster 2.4.17, I noticed that the list_quota_table_sizes sometimes could return a table whose quota is not set. h1. Reproduce {_}This bug cannot be reproduced deterministically{_}. The probability for its manifestation is 1.1% (Keep executing the commands, and it occurs two times out of 178 repeatedly executions). Start up HBase 2.4.17 cluster (2.10.2 HDFS, 1 HMaster, 2 RS) Executing the following commands, {code:java} create_namespace 'uuidef8e6005b9e74092927a4b335424f7c5' create 'uuid80d6aa3495094cd7b4018d3ab3fe9db8', {NAME => 'uuid07f904a09baf414d903b2818d3091f28', VERSIONS => 2, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true'}, {NAME => 'uuida60aaa69834e4f0596b5b3b3c12b2cb8', VERSIONS => 4, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true'}, {NAME => 'uuid085c0991aa1c4d4ea145767e7e7bf60c', VERSIONS => 4, COMPRESSION => 'GZ', BLOOMFILTER => 'NONE', IN_MEMORY => 'true'}, {NAME => 'uuid1d9a2bc405c64708b9e471ae14794741', VERSIONS => 2, COMPRESSION => 'NONE', BLOOMFILTER => 'ROW', IN_MEMORY => 'false'} create 'uuid5cafa12ce5034015bb597428b294a40d', {NAME => 'uuid7d9efb39ac94472b90dc60ed3723cdf9', VERSIONS => 2, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'true'}, {NAME => 'uuidde273134b6434fc584990554cfa64b10', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true'} clone_table_schema 'uuid80d6aa3495094cd7b4018d3ab3fe9db8', 'uuidb8e2393af3314726890b70ef5871a9d0' drop 'uuid5cafa12ce5034015bb597428b294a40d' truncate 'uuidb8e2393af3314726890b70ef5871a9d0' compaction_state 'uuid80d6aa3495094cd7b4018d3ab3fe9db8' truncate_preserve 'uuidb8e2393af3314726890b70ef5871a9d0' drop 'uuidb8e2393af3314726890b70ef5871a9d0' truncate 'uuid80d6aa3495094cd7b4018d3ab3fe9db8' alter 'uuid80d6aa3495094cd7b4018d3ab3fe9db8', {NAME => 'uuida60aaa69834e4f0596b5b3b3c12b2cb8', METHOD => 'delete'} disable 'uuid80d6aa3495094cd7b4018d3ab3fe9db8' incr 'uuid80d6aa3495094cd7b4018d3ab3fe9db8', 'uuid863efa8e4f1f44888af0ed139effba33', 'uuid085c0991aa1c4d4ea145767e7e7bf60c:NONE', 3 drop 'uuid80d6aa3495094cd7b4018d3ab3fe9db8' wal_roll 'hregion2,16020' wal_roll 'hregion1,16020' create 'uuid4323f716aea24b5fa001f0722cdc66f9', {NAME => 'uuidd64032ff2e7340fb8832a16430fc14c1', VERSIONS => 3, COMPRESSION => 'GZ', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'false'}, {NAME => 'uuidc4be1958501543ac86661793a4c144cb', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'ROW', IN_MEMORY => 'true'}, {NAME => 'uuid0c7961e7f67a464387f9f5ce428f08d1', VERSIONS => 4, COMPRESSION => 'NONE', BLOOMFILTER => 'ROW', IN_MEMORY => 'false'}, {NAME => 'uuida9f7a62b76fa4560834cc5789d5abf3a', VERSIONS => 2, COMPRESSION => 'NONE', BLOOMFILTER => 'ROW', IN_MEMORY => 'false'} major_compact 'uuid4323f716aea24b5fa001f0722cdc66f9', 'uuid0c7961e7f67a464387f9f5ce428f08d1' incr 'uuid4323f716aea24b5fa001f0722cdc66f9', 'uuidffb29730a2fb4f5f8c18f0c1bc254402', 'uuida9f7a62b76fa4560834cc5789d5abf3a:cc', 3 alter 'uuid4323f716aea24b5fa001f0722cdc66f9', {NAME => 'uuida9f7a62b76fa4560834cc5789d5abf3a', METHOD => 'delete'} update_config 'hregion1,16020' {code} Then execute read command in hbase shell {code:java} list_quota_table_sizes TABLE  SIZE uuid4323f716aea24b5fa001f0722cdc66f9 5133 1 row(s) Took 0.0278 seconds {code} uuid4323f716aea24b5fa001f0722cdc66f9 is not set in the quota table but it still appears in in list_quota_table_sizes results also with a strange value: 5133.  h1. Thoughts The root cause might be related to how *quota* table reacts when a new table is created. I am still investigating the root cause (Injecting logs to MasterQuotaManager to understand why it also records this table)." Reject requests at RPC layer when RegionServer is aborting,13552647,Resolved,Major,Fixed,02/Oct/23 14:15,05/Oct/23 13:06,,"We recently had an operational incident where the RegionServer got aborted, but failed to exit within a reasonable timeframe. We're going to tune hbase.regionserver.abort.timeout much lower than the 20m default, but even with that it makes little sense to accept requests when the server is aborting. In our case, the server was impaired and not processing requests. The call queue was full, so NettyRpcServer kept trying and failing to add requests to the queue. This results in CallQueueTooBigException, which is not a meta cache clearing exception. It continued throwing these exceptions for multiple minutes until we finally manually killed the server. I'd like to add a check in ServerRpcConnection.processRequest, where we check if regionServer.isAborted() and throw a RegionServerAbortedException rather than attempt to enqueue the request." Bump urllib3 from 1.26.5 to 1.26.17 in /dev-support/git-jira-release-audit,13553076,Resolved,Major,Fixed,06/Oct/23 06:10,06/Oct/23 06:11,, TestTableShell times out when run in background,13553003,Open,Major,,05/Oct/23 11:59,,2.4.17,"When starting maven in the backround, TestTableShell hangs. *mvn test -P runDevTests -Dtest.build.data.basedirectory=/ram2G -fn -pl hbase-shell -B:* pass *nohup mvn test -P runDevTests -Dtest.build.data.basedirectory=/ram2G -fn -pl hbase-shell -B* pass *nohup mvn test -P runDevTests -Dtest.build.data.basedirectory=/ram2G -fn -pl hbase-shell -B &* hangs   Tests run via maven shouldn't behave differently depending on whether maven runs in the foreground or background. Technically, the test doesn't hang forver, it times out after 10000 seconds and fails." CatalogReplicaMode.LOAD_BALANCE introduces a client dependency on the active master,13552943,Open,Major,,05/Oct/23 00:38,,2.4.17,"This only a 2.x releases, and only usages of MetaTableAccessor. It's hard to trace all of the overloads of the scanMeta method in there, but it is at the very least exposed to clients via RegionLocator.getAllRegionLocations(). The code in AsyncTable and normal ConnectionImplementation meta scans (i.e. looking up a single location) both use a CatalogReplicaLoadBalanceSelector which fetches the meta locations from the ConnectionRegistry. Those do not have a dependency on master unless you define the RpcConnectionRegistry to hit master. The way MetaTableAccessor works is to call getMetaTable(conn) to get an HTable, then table.getDescriptor() and parses the getRegionReplication() method. The call to getDescriptor() hits the active HMaster. We should fix MetaTableAccessor to use the same connection registry based lookup of meta replicas." Add metrics around automatic switching from PREAD to STREAM,13552745,Open,Major,,03/Oct/23 13:02,,,"Unless specifically configured, scans start with ReadType.DEFAULT. In which case, they start as PREAD until hbase.storescanner.pread.max.bytes, then are converted to STREAM. We've sometimes found evidence of trySwitchToStream taking a good amount of time in profiles. This is because switching to STREAM involves opening a new DFSInputStream which requires hitting the namenode for block locations. Recently I did a perf test of various scan sizes and our default max bytes threshold (4 blocks). I found that there is much more downside to switching to STREAM too early, than there is in staying in PREAD too long. When the scan size is around the switchover threshold (4-8 blocks), overall throughput is reduced by over 50%. When the scan size is much larger than the threshold (20+ blocks), staying in PREAD too long only reduces throughput by < 10%. These results are in our environment where we use only SSD and have 100% locality, so ""seeks"" are not relevant, disk IO is very fast, and needing to block to send network requests to the namenode can have an outsized impact. Others may have different constraints, but metrics can help make informed decisions. I'd like a metric for switchesToStreamCount, and a histogram of bytesReadAfterStreamSwitch." rpcservice should perform some important admin operation to priority ADMIN_QOS,13560032,Open,Minor,,30/Nov/23 09:32,,2.5.0,"some important admin operations should be admin priority,like compactionSwitch,rollWALWriter,updateConfiguration. these operations called by admin should be considered a higher priority operation and given to the priority queue, but is currently considered to have the same priority as read or write requests. If the handle is occupied, the operations cannot be execute successful. For example, in our scenario, some abnormal phoenix sql is killed by controlling the amount of data that scan can filter with dynamic parameters. Abnormal sql often results in a full handle. In this case, the configuration cannot be dynamically modified to implement emergency traffic limiting. {code:java} @Override @QosPriority(priority = HConstants.ADMIN_QOS) public UpdateConfigurationResponse updateConfiguration( RpcController controller, UpdateConfigurationRequest request) throws ServiceException {{code}  " mobStore directory do not set storage policy like normal store directory,13555523,Open,Minor,,25/Oct/23 16:39,,2.5.6,"We set block storage policy for store directory only in the HStore, but mobStore path is generate in the HMobStore. I write a test case to describe this bug in TestHRegionFileSystem. {code:java} @Test public void testMobStoreStoragePolicy() throws Exception { TEST_UTIL = new HBaseTestingUtil(); Configuration conf = TEST_UTIL.getConfiguration(); TEST_UTIL.startMiniCluster(); Table table = TEST_UTIL.createTable(TABLE_NAME, FAMILIES); assertEquals(""Should start with empty table"", 0, TEST_UTIL.countRows(table)); HRegionFileSystem regionFs = getHRegionFS(TEST_UTIL.getConnection(), table, conf); try (Admin admin = TEST_UTIL.getConnection().getAdmin()) { ColumnFamilyDescriptorBuilder cfdA = ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]); cfdA.setValue(HStore.BLOCK_STORAGE_POLICY_KEY, ""ONE_SSD""); cfdA.setMobEnabled(true); cfdA.setMobThreshold(2L); admin.modifyColumnFamily(TABLE_NAME, cfdA.build()); while ( TEST_UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager().getRegionStates() .hasRegionsInTransition() ) { Thread.sleep(200); LOG.debug(""Waiting on table to finish schema altering""); } // flush memstore snapshot into 3 files for (long i = 0; i < 3; i++) { Put put = new Put(Bytes.toBytes(i)); put.addColumn(FAMILIES[0], Bytes.toBytes(i), Bytes.toBytes(i)); put.addColumn(FAMILIES[0], Bytes.toBytes(i + ""qf""), Bytes.toBytes(i + ""value"")); table.put(put); admin.flush(TABLE_NAME); } // there should be 3 files in store dir FileSystem fs = TEST_UTIL.getDFSCluster().getFileSystem(); Path storePath = regionFs.getStoreDir(Bytes.toString(FAMILIES[0])); Path mobStorePath = MobUtils.getMobFamilyPath(conf, TABLE_NAME, Bytes.toString(FAMILIES[0])); FileStatus[] storeFiles = CommonFSUtils.listStatus(fs, storePath); FileStatus[] mobStoreFiles = CommonFSUtils.listStatus(fs, mobStorePath); assertNotNull(storeFiles); assertEquals(3, storeFiles.length); assertNotNull(mobStoreFiles); assertEquals(3, mobStoreFiles.length); for (FileStatus status : storeFiles) { assertEquals(""ONE_SSD"", ((HFileSystem) regionFs.getFileSystem()).getStoragePolicyName(status.getPath())); } for (FileStatus status : mobStoreFiles) { assertEquals(""ONE_SSD"", ((HFileSystem) regionFs.getFileSystem()).getStoragePolicyName(status.getPath())); } } finally { table.close(); TEST_UTIL.deleteTable(TABLE_NAME); TEST_UTIL.shutdownMiniCluster(); } }{code} Also we can get storage policy in shell like this: {code:java} root@hbase-master:/usr/local/hadoop# ./bin/hdfs storagepolicies -getStoragePolicy -path /hbase/data/default/member/a645c7c2b31371449331a4e4106b073b/info The storage policy of /hbase/data/default/member/a645c7c2b31371449331a4e4106b073b/info: BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]} root@hbase-master:/usr/local/hadoop# ./bin/hdfs storagepolicies -getStoragePolicy -path /hbase/mobdir/data/default/member/288b5f8af920a8190cc07bad277debb5/info The storage policy of /hbase/mobdir/data/default/member/288b5f8af920a8190cc07bad277debb5/info is unspecified {code}" Fix broken link to replication documentation,13557682,Resolved,Minor,Fixed,13/Nov/23 09:21,13/Nov/23 10:42,3.0.0-alpha-4,The site link to the Replication section of the book has a broken link. Provide option to skip wal while using TableOutputFormat,13562232,Resolved,Minor,Fixed,18/Dec/23 15:37,14/Nov/24 09:25,,"If we have replication setup between clusters A <-> B, during production incidents where HFiles get corrupted (e.g. via hdfs missing blocks) on cluster A, we can use CopyTable job to copy the data from B In those cases considering the data is being copied from B to A via CopyTable, it doesn't make sense to write to WALs on A using TableOutputFormat (since the mutations being copied already exist on B). We can add a config to customise durability ([https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Durability.java]) within TableOutputFormat so that an operator can use it to skip WAL writes" Correcting spelling errors or annotations with non-standard spelling,13561552,Resolved,Minor,Fixed,12/Dec/23 13:54,23/Apr/24 17:59,,Modify some spelling errors or non-standard spelling comments pointed out by Typo "compact_rs not support hostname,port",13561771,Open,Minor,,14/Dec/23 03:07,,2.2.7,"hbase:010:0> compact_rs 'hadoop-222-149.hfb.odeon.cn,60020' ERROR: begin 28, end 27, length 33 Should have something to do with ServerName.ValueOf()，It has changed from HBASE-24305. {code:java} public static ServerName valueOf(final String serverName) { int firstSep = serverName.indexOf(SERVERNAME_SEPARATOR); int lastSep = serverName.lastIndexOf(SERVERNAME_SEPARATOR); String hostname = serverName.substring(0, firstSep); int port = Integer.parseInt(serverName.substring(firstSep + 1, lastSep)); long startCode = Long.parseLong(serverName.substring(lastSep + 1)); return valueOf(hostname, port, startCode); } {code}" Move ProfileServlet to support async-profiler 2.x only,13560775,Open,Minor,,06/Dec/23 08:58,,,"async-profiler 2.0 has been out since March 2021 now. This issue/PR is about supporting its new features and removing the 1.x functionality." Region Server Logs getting spammed with warning when storefile has no reader,13553337,Resolved,Minor,Fixed,09/Oct/23 06:57,18/Feb/24 20:44,,"Hbase tables which have IS_MOB set as TRUE and table metrics is enabled, there are warning logs getting generated ""StoreFile has a null Reader on hbase region server. After setting IS_MOB as false for a table, this logs are not visible. " Add slow sync log rolling test in TestAsyncLogRolling,13556985,Resolved,Minor,Fixed,07/Nov/23 06:57,29/Jan/24 18:47,,"There is a test for slow sync log rolling in `TestLogRolling`, but not in `TestAsyncLogRolling`, so add it in `TestAsyncLogRolling`." "Memstore flushRequest can be blocked by a delayed flush scheduled by PeriodicMemstoreFlusher, RegionTooBusyExceptions for up to 5 minutes",13561742,Resolved,Minor,Duplicate,13/Dec/23 23:12,13/Dec/23 23:45,2.0.0,"*Steps to reproduce:* # Make an edit to a region. # Wait 1 hour + 10 seconds (default value of {{hbase.regionserver.optionalcacheflushinterval}} plus {{hbase.regionserver.flush.check.period}}.) # Make a very large number of edits to the region (i.e. >= 1GB, pressure the memstore.) *Expected:* Memstore pressure leads to flushes. *Result:* The PeriodicMemstoreFlusher has scheduled a refresh with a random delay of 0-5 minutes (default for {{hbase.regionserver.periodicmemstoreflusher.rangeofdelayseconds}}.) Memstore pressure flushes are blocked by the scheduled delayed flush. Client receives 0-5 minutes of {{RegionTooBusyExceptions}} until the delayed flush executes. *Logs:* 2023-12-13 06:00:13,573 INFO regionserver.HRegionServer - MemstoreFlusherChore requesting flush of because has an old edit so flush to free WALs after random delay 166761 ms 2023-12-13 06:00:53,219 DEBUG regionserver.HRegion - Flush requested on 2023-12-13 06:01:47,694 WARN regionserver.HRegion - Region is too busy due to exceeding memstore size limit. org.apache.hadoop.hbase.RegionTooBusyException: Over memstore limit=1.0 G, regionName=, server= at org.apache.hadoop.hbase.regionserver.HRegion.checkResources ... repeats ... 2023-12-13 06:01:52,223 WARN regionserver.HRegion - Region is too busy due to exceeding memstore size limit. org.apache.hadoop.hbase.RegionTooBusyException: Over memstore limit=1.0 G, regionName=, server= at org.apache.hadoop.hbase.regionserver.HRegion.checkResources ... 2023-12-13 06:03:00,340 INFO regionserver.HRegion - Flushing 1/1 column families, dataSize=534.77 MB heapSize=1.00 GB 2023-12-13 06:03:09,634 INFO regionserver.HRegion - Finished flush of dataSize ~534.77 MB/560744948, heapSize ~1.00 GB/1073816296, currentSize=0 B/0 for in 9294ms, sequenceid=21310753, compaction requested=false Note also this is the same cause as discussed in HBASE-16030 conversation https://issues.apache.org/jira/browse/HBASE-16030?focusedCommentId=15340153&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15340153" Add java.base/sun.net.dns and java.base/sun.net.util export to jdk11 JVM test flags,13560940,Resolved,Minor,Fixed,07/Dec/23 06:09,09/Jan/24 17:26,2.4.17,"While testing with JDK17 we have found that we need to add {noformat} --add-exports java.base/sun.net.dns=ALL-UNNAMED --add-exports java.base/sun.net.util=ALL-UNNAMED {noformat} on top of what is already defined in _hbase-surefire.jdk11.flags_ , otherwise RS and Master startup fails in the Hadoop security code. While this does not affect the test suite (at least not the commonly run tests), I consider hbase-surefire.jdk11.flags to be an unoffical resource to getting HBase to run on newer JDK versions. " Release script should use github instead of gitbox,13562830,Open,Minor,,24/Dec/23 14:28,,,"Now gitbox will redirect everything to github, so fetching the pom content from gitbox does not work any more. Even if I use -L to let curl follow 302, it will return html instead of the actual pom content. Let's change to use github in the script." Add option in RegionMover.java to isolate one or more regions on the RegionSever,13554686,Resolved,Minor,Fixed,19/Oct/23 04:20,27/Oct/23 09:39,2.4.17,"Sometime one or more HBase regions on RS are under high load. This can lead to resource starvation for other regions hosted on the RS. It might be necessary to isolate one or more regions on the RS so that region with heavy load doesn't impact other regions hosted on the same RS. RegionMover.java class provides a way to load/unload the regions from the specific RS. It would be a good to have an option to pass list of region hash that should be left (or moved) on the RS and put the RS in the draining/decommission mode so HMaster doesn't assign new regions on the RS. Ex. {code:java} --isolateRegionIds regionHash1,regionHash2,regionHash3{code}" HRegionServer encountered NPE while executing getBootstrapNodes,13562834,Open,Minor,,24/Dec/23 16:28,,3.0.0-beta-2,"When the HRegionServer has just started, and the bootstrapNodeManager has not been initialized yet, handling the client's GetBootstrapNodesRequest by calling the bootstrapNodeManager's getBootstrapNodes method results in a NPE exception. The logs are as followed: {code:java} 2023-12-17T15:25:31,984 ERROR [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16020] ipc.RpcServer: Unexpected throwable object java.lang.NullPointerException: null at org.apache.hadoop.hbase.regionserver.HRegionServer.getBootstrapNodes(HRegionServer.java:3632) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] at org.apache.hadoop.hbase.HBaseRpcServicesBase.getBootstrapNodes(HBaseRpcServicesBase.java:304) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] at org.apache.hadoop.hbase.shaded.protobuf.generated.RegistryProtos$ClientMetaService$2.callBlockingMethod(RegistryProtos.java:6737) ~[hbase-protocol-shaded-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:437) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) ~[hbase-server-3.0.0-beta-1-SNAPSHOT.jar:3.0.0-beta-1-SNAPSHOT] {code} " ClientSideRegionScanner appears not to shutdown MobFileCache,13559736,Resolved,Minor,Fixed,28/Nov/23 16:21,22/Dec/23 15:25,2.5.5,"As far as I can tell from the code, and also what I see in jstack, ClientSideRegionScanner doesn't appear to shutdown it's MobFileCache. After doing a lot of scanning of a snapshot, application threads are polluted with a lot of MobFileCache ScheduledThreadPoolExecutors that never seem to get cleaned up." [Flaky test] Fix 'test_list_decommissioned_regionservers' in TestAdminShell2.java,13562515,Resolved,Minor,Fixed,20/Dec/23 22:02,21/Dec/23 14:01,,"See flaky board: [https://nightlies.apache.org/hbase/HBase-Find-Flaky-Tests/master/1345/output/dashboard.html] Failed : [14675|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14675]  [14676|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14676]  [14677|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14677]  [14678|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14678]  [14679|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14679]  [14680|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14680]  [14681|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14681]  [14682|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14682]  [14683|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14683]  [14684|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14684]  [14685|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14685]  [14686|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14686]  [14687|https://ci-hbase.apache.org//job/HBase-Flaky-Tests/job/master/14687] " FileSystem.getFileStatus can not get the correct file length for files which are being written,13562749,Open,Minor,,22/Dec/23 15:32,,,"When reading from a opening WAL file in replication, we will use FileSystem.getFileStatus to get the file length and then use it to calculate the trailer's position. But if a file is being written, you can not get the correct length from namenode, you could even get a 0 if the file has only one block(for most WAL files). This will not lead to real data loss as we do not rely on the file length to determine whether we should read the file, but since it will mess up the trailer's position, it may lead to incorrect metrics, like un cleanly closed wal files, and fail some UTs, and also output some confusing logs. We should find a way to make it better." region_status.rb is broken,13562311,Open,Minor,,19/Dec/23 10:30,,2.5.7,"{{region_status.rb}} which is broken by all ends on all active branches. Need to thoroughly fix it as it has multiple errors. Not sure who uses it though as this is broken in branch-2 as well. We should maybe deprecate and remove it. CC: [~zhangduo]" set start row as prefix if a scan with PrefixFilter,13557448,Open,Minor,,10/Nov/23 07:50,,3.0.0-alpha-4,"If a scan with PrefixFilter, we can set start row as the prefix. This will help reduce filtered data." Alter table to set TTL using hbase shell failed when ttl string is not match format,13556503,Resolved,Minor,Fixed,02/Nov/23 09:48,06/Nov/23 09:09,2.4.14,"create 'test','f1' alter 'test',\{NAME=>'f1',TTL=>'111x'}   {code:java} hbase:001:0> alter 'test',{NAME=>'f1',TTL=>'111x'} ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: TTL for column family f1 must be positive. Set hbase.table.sanity.checks to false at conf or table descriptor if you want to bypass sanity checks     at org.apache.hadoop.hbase.util.TableDescriptorChecker.warnOrThrowExceptionForFailure(TableDescriptorChecker.java:321)     at org.apache.hadoop.hbase.util.TableDescriptorChecker.sanityCheck(TableDescriptorChecker.java:165)     at org.apache.hadoop.hbase.master.HMaster$14.run(HMaster.java:2666)     at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:132)     at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2660)     at org.apache.hadoop.hbase.master.HMaster.modifyTable(HMaster.java:2698)     at org.apache.hadoop.hbase.master.MasterRpcServices.modifyTable(MasterRpcServices.java:1554)     at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:477)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349)For usage try 'help ""alter""'{code} it is misleading..   we need tell user wether theire command is wrong.. some times we copy some string which may have some invisible characters， we need let user to check it" Support overriding the HFileOutputFormat2 RecordWriter's outputDir,13556104,Open,Minor,,30/Oct/23 15:05,,,"Currently when the HFileOutputFormat2 creates a RecordWriter, it derives the output directory from the OutputCommitter. This is generally the desired behavior, but we have a use case where it would be helpful to explicitly override it. The use-case is essentially a variant of the MultiTableHFileOutputFormat behavior. But rather than having one job that output data for a number of tables, we would like to have one job subdivide its output so that it can be bulk-loaded over the course of multiple distcp+LoadIncrementalHFiles runs. This is helpful when an individual table's data needs to be sent to multiple clusters, or for when loading the data in chunks is needed for reliability and stability.  Adding a path override configuration option to the MultiTableHFileOutputFormat would allow us to extend the output format and create multiple RecordWriters, each configured with separate output directories. " "When specifying the wrong BloomFilter type while creating a table in HBase shell, an error will occur.",13553649,Resolved,Minor,Fixed,11/Oct/23 08:17,25/Oct/23 07:21,2.5.5,"Executing the following command in HBase shell, specifying the wrong BoolFilter type, will prompt ""ERROR: uninitialized constant Java::OrgApacheHadoopHbaseRegionserver::StoreFile::BloomType"". {code:java} create 'zx',{NAME=>'0', BLOOMFILTER=>'TEST'} {code} !image-2023-10-11-16-14-31-219.png!" Backport HBASE-28155 to branch-2.x,13554954,Open,Minor,,20/Oct/23 14:18,,,"The code on branch-2.x are different, and since we have a small sleep before quiting RecoveredReplicationSource, so it is less hurt. So file a separated issue." HBaseContext.bulkLoad doesn't work with ROWPREFIX_FIXED_LENGTH bloom filter,13554675,Open,Minor,,19/Oct/23 01:42,,1.0.0,"HBaseContext.bulkLoad throws IllegalArgumentException for bloom type set to ROWPREFIX_FIXED_LENGTH in FamilyHFileWriteOptions as the key ""RowPrefixBloomFilter.prefix_length"" is not set in Configuration.   Here's my suggestion to fix it: https://github.com/apache/hbase-connectors/commit/89a268711ff4e2cd349b3f78961b8ac6bb895c28" Build fails with Hadoop 3.3.5 and higher,13554453,Resolved,Minor,Duplicate,17/Oct/23 18:55,17/Oct/23 20:38,2.4.17,"https://issues.apache.org/jira/browse/HADOOP-15983 changed dependencies and that makes our {{check-jar-contents-for-stuff-with-hadoop}} check fail: Excerpt: {noformat} [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents-for-stuff-with-hadoop) @ hbase-shaded-with-hadoop-check-invariants --- [ERROR] Found artifact with unexpected contents: '/home/lars/Downloads/hbase/hbase-2.4.17-src/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-2.4.17.jar' Please check the following and either correct the build or update the allowed list with reasoning. com/ com/sun/ com/sun/jersey/ com/sun/jersey/json/ com/sun/jersey/json/impl/ com/sun/jersey/json/impl/reader/ com/sun/jersey/json/impl/reader/JsonXmlEvent$Attribute.class com/sun/jersey/json/impl/reader/JsonXmlStreamReader$1.class com/sun/jersey/json/impl/reader/XmlEventProvider$1.class com/sun/jersey/json/impl/reader/NaturalNotationEventProvider.class com/sun/jersey/json/impl/reader/XmlEventProvider.class com/sun/jersey/json/impl/reader/XmlEventProvider$ProcessingInfo.class com/sun/jersey/json/impl/reader/StartElementEvent.class com/sun/jersey/json/impl/reader/CharactersEvent.class com/sun/jersey/json/impl/reader/JacksonRootAddingParser$1.class com/sun/jersey/json/impl/reader/EndElementEvent.class com/sun/jersey/json/impl/reader/JsonXmlStreamReader.class com/sun/jersey/json/impl/reader/StaxLocation.class com/sun/jersey/json/impl/reader/JsonNamespaceContext.class com/sun/jersey/json/impl/reader/JsonXmlEvent.class com/sun/jersey/json/impl/reader/JacksonRootAddingParser.class com/sun/jersey/json/impl/reader/StartDocumentEvent.class com/sun/jersey/json/impl/reader/MappedNotationEventProvider.class com/sun/jersey/json/impl/reader/EndDocumentEvent.class com/sun/jersey/json/impl/reader/JsonFormatException.class com/sun/jersey/json/impl/reader/XmlEventProvider$CachedJsonParser.class com/sun/jersey/json/impl/reader/JacksonRootAddingParser$State.class com/sun/jersey/json/impl/JaxbRiXmlStructure.class com/sun/jersey/json/impl/ImplMessages.class com/sun/jersey/json/impl/JSONMarshallerImpl.class com/sun/jersey/json/impl/NameUtil.class com/sun/jersey/json/impl/FilteringInputStream.class com/sun/jersey/json/impl/JaxbProvider.class [....] {noformat} I'm afraid I'm a bit at a loss with the current Maven build system as to what the actual fix would be. I tested it against 2.4.17 as well as master as of today. Master already fails in an earlier step ({{Found Banned Dependency: org.bouncycastle:bcprov-jdk15on:jar:1.52}}) which I assume is a separate issue but I further assume that it would also fail at this step if it were to get this far." Make the connection idle timeout configurable for the embedded HTTP servers,13553219,Resolved,Minor,Fixed,07/Oct/23 05:54,12/Oct/23 10:44,3.0.0-alpha-4,The Jetty Server may be slow HTTP denial of service attacks in hbase master web ui due to the default value of jetty connector idle timeout is 30000. This may cause such an attack. HBase backup: allow direct DistCP flag,13553375,Open,Minor,,09/Oct/23 10:12,,,"HBase docs recommend that backups are done to cloud storage such as S3. Internally, backup and restore relies on DistCP to copy files to backup storage. DistCP's docs mention the ""-direct"" parameter: > Useful for avoiding potentially very expensive temporary file rename operations when the destination is an object store  It looks useful to allow specifying this parameter for HBase backups, similar to how the YARN queue is also exposed." Sync jvm11 module flags from hbase-surefire.jdk11.flags to bin/hbase,13561946,Resolved,Trivial,Fixed,15/Dec/23 07:01,09/Jan/24 17:32,2.4.17,"All the JDK11 seems to be coming from the runtime code, and we have found that the missing options are required for the runtime when testing JDK 17. Only the JDK17 ""--add-opens java.base/jdk.internal.util.random=ALL-UNNAMED"" is known to be used by the test code, and probably not by the runtime. Specifically, these ones are missing: java.base/java.io=ALL-UNNAMED (pending in HBASE-28259. If that one doesn't add it to surefire, we need to add that here) java.base/java.util=ALL-UNNAMED java.base/java.util.concurrent=ALL-UNNAMED " Add java.base/java.io=ALL-UNNAMED open to jdk11_jvm_flags,13561802,Resolved,Trivial,Fixed,14/Dec/23 08:54,05/Jan/24 11:04,2.4.17,"hbase shell 2023-12-13T23:49:50.846+08:00 [main] WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable." Update downloads.xml for release 2.5.7,13562832,Resolved,Trivial,Fixed,24/Dec/23 14:57,24/Dec/23 15:02,, Remove mention of MasterRegistry being the default,13558020,Open,Trivial,,15/Nov/23 08:28,,,"As mentioned in HBASE-26149 the configuration.adoc file still mentions that the master based connection registry will be the default in 3.0.0. It is my understanding that this is not correct anymore." Upgrade asciidoctor,13339946,Closed,Blocker,Fixed,11/Nov/20 09:48,12/Nov/20 15:19,2.4.0,"JRuby upgrade broke the site build as asciidoc depends on JRuby. https://ci-hadoop.apache.org/job/HBase/job/hbase_generate_website/89/" [hbase-thirdparty] Add JerseyFlowSubscriber to ignoreClass in maven enforcer plugin,13342083,Resolved,Blocker,Fixed,23/Nov/20 09:17,23/Nov/20 11:51,,"{noformat} 08:23:56 [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ hbase-shaded-jersey --- 08:23:56 [INFO] Adding ignore: module-info 08:23:56 [INFO] Adding ignore: **.glassfish.jersey.internal.jsr166.SubmissionPublisher* 08:23:56 [INFO] Restricted to JDK 1.8 yet org.glassfish.jersey.core:jersey-common:jar:2.32:compile contains META-INF/versions/11/org/glassfish/jersey/internal/jsr166/JerseyFlowSubscriber$1.class targeted to 55.0 08:23:56 [WARNING] Rule 1: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: HBase has unsupported dependencies. HBase requires that all dependencies be compiled with version 1.8 or earlier of the JDK to properly build from source. You appear to be using a newer dependency. You can use either ""mvn -version"" or ""mvn enforcer:display-info"" to verify what version is active. Non-release builds can temporarily build with a newer JDK version by setting the 'compileSource' property (eg. mvn -DcompileSource=1.8 clean package). Found Banned Dependency: org.glassfish.jersey.core:jersey-common:jar:2.32 Use 'mvn dependency:tree' to locate the source of the banned dependencies. {noformat}" TestCurrentHourProvider fails if the latest timezone changes are not present,13345403,Resolved,Blocker,Fixed,10/Dec/20 23:22,04/Mar/21 02:15,2.4.1,"According to [this link|https://www.oracle.com/java/technologies/tzdata-versions.html], a few timezones underwent changes in October of this year. For environments that do not have these latest updates, TestCurrentHourProvider will fail since information for certain time zones is out of date. Example: On an environment running jdk8, this test fails for timezones America/Dawson, America/Whitehorse, Canada/Yukon, and Antarctica/Casey (all of which were affected by the latest changes described at the above link). It seems that if timezone information on a particular environment is not up to date with the latest changes, this shouldn't indicate a failure of CurrentHourProvider, especially since this test specifically tests the functionality of CurrentHourProvider and using EnvironmentEdgeManager to mock time." we should add security checks for setTableStateInMeta and fixMeta,13347244,Resolved,Blocker,Fixed,22/Dec/20 03:59,07/Jan/21 13:39,,setTableStateInMeta and fixMeta can be accessed only through Admin rights hbase arm version regionserver cpu too high and not exit when connecting zk session timeout ,13345041,Open,Blocker,,09/Dec/20 10:19,,1.2.0,"when we use hbase1.2.0 on arm , regionserver not exit when connecting zk session timeout. and regionserver cpu is too high about 3000% " Upgrade hbase-thirdparty dependency to 3.4.1,13342106,Resolved,Blocker,Fixed,23/Nov/20 11:24,02/Dec/20 01:37,, Create table very slowly if there are multi regions,13337629,Open,Blocker,,28/Oct/20 10:10,,2.2.6,"Run the same UT TestRegionReplicaFailover on my local PC, mvn clean test -Dtest=TestRegionReplicaFailover, branch-2.2 takes 8 mins but branch-2.3 only needs 2 mins.    I found the problem is related to procedure schedule. See the below log: 2020-10-21 13:52:28,097 INFO  [PEWorker-1] procedure2.ProcedureExecutor(1427): Finished pid=296, ppid=45, state=SUCCESS; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure in 1.6250sec 2020-10-21 13:52:28,538 INFO  [PEWorker-3] procedure2.ProcedureExecutor(1427): Finished pid=45, ppid=20, state=SUCCESS; TransitRegionStateProcedure table=testLotsOfRegionRepli2, region=50703895da3cb8c942d3197600d549bc, ASSIGN in 59.4330sec   The real assign procedure only cost 1.6 seconds but the TransitRegionStateProcedure cost 59.4 seconds. The pid=45 procedure was initialized at 2020-10-21 13:51:28,666. It was added to TableQueue at 2020-10-21 13:51:28,789. But took xlock to run at 2020-10-21 13:52:24,761. See the below log: {color:#ff0000}2020-10-21 13:51:28,789{color} DEBUG [PEWorker-4] procedure.MasterProcedureScheduler(352): Add TableQueue(testLotsOfRegionRepli2, xlock=true (20) sharedLock=0 size=25) to run queue because: pid=45, ppid=20, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=testLotsOfRegionRepli2, region=50703895da3cb8c942d3197600d549bc, ASSIGN has the excusive lock access {color:#ff0000}2020-10-21 13:52:24,761{color} INFO  [PEWorker-2] procedure.MasterProcedureScheduler(737): Took xlock for pid=45, ppid=20, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=testLotsOfRegionRepli2, region=50703895da3cb8c942d3197600d549bc, ASSIGN   But when I tried this UT on another PC, it only cost 2 mins, which is the same with branch-2.3. It is weird.   Marked this as blocker for release 2.2.7.   If you are interested for this, please run ""mvn clean test -Dtest=TestRegionReplicaFailover"" and comment the cost time here. Thanks.  " Regionserver crash by YouAreDeadException,13339937,Open,Blocker,,11/Nov/20 09:36,,2.1.0,"Hbase cluster is enabled kerberos; This problem occurs during cluster running, not during startup. So the Kerberos configuration should be fine hmaster log: {code:java} 2020-10-31 08:27:02,594 INFO org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure: Dispatch pid=32630, ppid=32629, state=RUNNABLE:REGION_TRANSITION_DISPATCH, locked=true; UnassignProcedure table=dm_sn_sa:t_agent_relation_info, region=66e7cf0d6ad81f90b5aeca2c74f26af6, server=cc1,16020,15988329396742020-10-31 08:27:02,594 INFO org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure: Dispatch pid=32630, ppid=32629, state=RUNNABLE:REGION_TRANSITION_DISPATCH, locked=true; UnassignProcedure table=dm_sn_sa:t_agent_relation_info, region=66e7cf0d6ad81f90b5aeca2c74f26af6, server=cc1,16020,15988329396742020-10-31 08:27:02,712 WARN org.apache.hadoop.hbase.master.procedure.RSProcedureDispatcher: Failed dispatch to server=cc1,16020,1598832939674 try=0javax.security.sasl.SaslException: Call to cc1/192.168.68.94:16020 failed on local exception: javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)] [Caused by javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)]] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:221) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:390) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:95) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:410) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:406) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:103) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:118) at org.apache.hadoop.hbase.ipc.BufferCallBeforeInitHandler.userEventTriggered(BufferCallBeforeInitHandler.java:92) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:304) at org.apache.hbase.thirdparty.io.netty.channel.ChannelInboundHandlerAdapter.userEventTriggered(ChannelInboundHandlerAdapter.java:108) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:304) at org.apache.hbase.thirdparty.io.netty.channel.ChannelInboundHandlerAdapter.userEventTriggered(ChannelInboundHandlerAdapter.java:108) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.userEventTriggered(ByteToMessageDecoder.java:366) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireUserEventTriggered(AbstractChannelHandlerContext.java:304) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.userEventTriggered(DefaultChannelPipeline.java:1426) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:326) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeUserEventTriggered(AbstractChannelHandlerContext.java:312) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireUserEventTriggered(DefaultChannelPipeline.java:924) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.failInit(NettyRpcConnection.java:179) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.access$500(NettyRpcConnection.java:71) at org.apache.hadoop.hbase.ipc.NettyRpcConnection$2.operationComplete(NettyRpcConnection.java:247) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:502) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:476) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:415) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:152) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.saslNegotiate(NettyRpcConnection.java:201) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.access$800(NettyRpcConnection.java:71) at org.apache.hadoop.hbase.ipc.NettyRpcConnection$3.operationComplete(NettyRpcConnection.java:273) at org.apache.hadoop.hbase.ipc.NettyRpcConnection$3.operationComplete(NettyRpcConnection.java:261) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:502) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:495) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:474) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:415) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:540) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setSuccess0(DefaultPromise.java:529) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:101) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:84) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.fulfillConnectPromise(AbstractEpollChannel.java:610) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.finishConnect(AbstractEpollChannel.java:648) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:524) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:417) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:328) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:905) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748)Caused by: javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)] at com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:211) at org.apache.hadoop.hbase.security.AbstractHBaseSaslRpcClient.getInitialResponse(AbstractHBaseSaslRpcClient.java:131) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler$1.run(NettyHBaseSaslRpcClientHandler.java:109) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler$1.run(NettyHBaseSaslRpcClientHandler.java:105) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1875) at org.apache.hadoop.hbase.security.NettyHBaseSaslRpcClientHandler.handlerAdded(NettyHBaseSaslRpcClientHandler.java:105) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.callHandlerAdded(AbstractChannelHandlerContext.java:953) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:610) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:181) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:360) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.addFirst(DefaultChannelPipeline.java:339) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.saslNegotiate(NettyRpcConnection.java:200) ... 19 moreCaused by: GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt) at sun.security.jgss.krb5.Krb5InitCredential.getInstance(Krb5InitCredential.java:147) at sun.security.jgss.krb5.Krb5MechFactory.getCredentialElement(Krb5MechFactory.java:122) at sun.security.jgss.krb5.Krb5MechFactory.getMechanismContext(Krb5MechFactory.java:187) at sun.security.jgss.GSSManagerImpl.getMechanismContext(GSSManagerImpl.java:224) at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:212) at sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:179) at com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:192) ... 32 more {code}   regionserver log:   {code:java} 2020-10-31 08:27:05,135 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: ***** ABORTING region server cc1,16020,1598832939674: org.apache.hadoop.hbase.YouAreDeadException: Server REPORT rejected; currently processing cc1,16020,1598832939674 as dead server2020-10-31 08:27:05,135 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: ***** ABORTING region server cc1,16020,1598832939674: org.apache.hadoop.hbase.YouAreDeadException: Server REPORT rejected; currently processing cc1,16020,1598832939674 as dead server at org.apache.hadoop.hbase.master.ServerManager.checkIsDead(ServerManager.java:366) at org.apache.hadoop.hbase.master.ServerManager.regionServerReport(ServerManager.java:253) at org.apache.hadoop.hbase.master.MasterRpcServices.regionServerReport(MasterRpcServices.java:490) at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:13139) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) *****org.apache.hadoop.hbase.YouAreDeadException: org.apache.hadoop.hbase.YouAreDeadException: Server REPORT rejected; currently processing cc1,16020,1598832939674 as dead server at org.apache.hadoop.hbase.master.ServerManager.checkIsDead(ServerManager.java:366) at org.apache.hadoop.hbase.master.ServerManager.regionServerReport(ServerManager.java:253) at org.apache.hadoop.hbase.master.MasterRpcServices.regionServerReport(MasterRpcServices.java:490) at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:13139) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:99) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:89) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:361) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.getRemoteException(ProtobufUtil.java:338) at org.apache.hadoop.hbase.regionserver.HRegionServer.tryRegionServerReport(HRegionServer.java:1227) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1024) at java.lang.Thread.run(Thread.java:748)Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.YouAreDeadException): org.apache.hadoop.hbase.YouAreDeadException: Server REPORT rejected; currently processing cc1,16020,1598832939674 as dead server at org.apache.hadoop.hbase.master.ServerManager.checkIsDead(ServerManager.java:366) at org.apache.hadoop.hbase.master.ServerManager.regionServerReport(ServerManager.java:253) at org.apache.hadoop.hbase.master.MasterRpcServices.regionServerReport(MasterRpcServices.java:490) at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:13139) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:387) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:95) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:410) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:406) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:103) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:118) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.readResponse(NettyRpcDuplexHandler.java:162) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelRead(NettyRpcDuplexHandler.java:192) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:359) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:345) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:337) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:323) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:297) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:359) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:345) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:337) at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:359) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:345) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:337) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1408) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:359) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:345) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:930) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:796) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:427) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:328) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:905) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ... 1 more2020-10-31 08:27:05,139 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer: RegionServer abort: loaded coprocessors are: [org.apache.hadoop.hbase.security.access.AccessController, org.apache.hadoop.hbase.security.token.TokenProvider, org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint] {code}    " TestMasterRegionOnTwoFileSystems is failing after HBASE-25065,13335381,Resolved,Blocker,Fixed,14/Oct/20 10:21,22/Oct/20 02:55,2.4.0,"After HBASE-25065, we are having a test case failure with TestMasterRegionOnTwoFileSystems. The reason is that we manually trigger a WAL roll on the master region. As part of the WAL roll we expect the Master region's WAL will also be moved from region oldWAL dir to the global oldWAL directory. This happens after afterRoll() method in AbstractWALRoller. Since now the WAL archival is asynchronous the afterRoll() method does not find any WAL file to be moved in the local region oldWAL dir. So the movement to global oldWAL dir does not happen. The test case checks for the file in the oldWAL dir and since it is not found the test timesout. WE need a way to fix this. " about hbase introduced fasterxml‘s jackson versions and vulnerabilities ,13336690,Resolved,Blocker,Duplicate,22/Oct/20 10:40,22/Oct/20 14:26,,"a lot of hbase component use htrace-core4, this htrace-core4 shaded fasterxml jackson(version 2.4.0) [INFO] | +- org.apache.hbase.thirdparty:hbase-shaded-miscellaneous:jar:2.2.1:compile [INFO] | +- org.slf4j:slf4j-api:jar:1.7.29:compile [INFO] | +- commons-io:commons-io:jar:2.6:compile [INFO] | +- {color:#ff0000}org.apache.htrace:htrace-core4:jar:4.2.0-incubating:compile{color} [INFO] | +- org.apache.commons:commons-crypto:jar:1.0.0:compile [INFO] | +- com.github.stephenc.findbugs:findbugs-annotations:jar:1.3.9-1:compile [INFO] | +- log4j:log4j:jar:1.2.17:compile [INFO] | - org.apache.yetus:audience-annotations:jar:0.5.0:compile   as you known fasterxml  jackson component is frequently coming out new vulnerabilities, like   CVE-2016-7051、CVE-2016-3720、CVE-2018-5968、CVE-2018-11307、CVE-2018-7489、CVE-2019-14893、CVE-2019-14379、CVE-2020-14195、CVE-2020-14061、CVE-2020-8840、CVE-2019-14540、CVE-2020-10968、CVE-2020-11619、CVE-2019-17531、CVE-2019-16943、CVE-2020-14062、CVE-2020-14060、CVE-2020-11111、CVE-2019-16942、CVE-2020-9546、CVE-2020-9548、CVE-2019-12384、CVE-2020-10673、CVE-2020-24750、CVE-2019-16335、CVE-2019-14439、CVE-2020-10969、CVE-2020-11112、CVE-2019-12086、CVE-2019-20330、CVE-2019-17267、CVE-2020-9547、CVE-2020-11113、CVE-2020-10672、CVE-2020-11620、CVE-2020-24616、CVE-2018-19362、CVE-2018-19361、CVE-2018-19360、CVE-2018-14721、CVE-2018-14720、CVE-2018-14719、CVE-2018-14718、CVE-2018-1000873、CVE-2017-7525、CVE-2017-17485、CVE-2017-15095，CVE-2019-12814 htrace-core4 is closed 4 years ago,  what about this component's vulnerabilities, did hbase have plan to do with this？      " c++库编译不通过,13347921,Open,Critical,,26/Dec/20 08:25,,,"我用自己在msys下编译了thrift0.13.0版本的lib库和compiler，用生成的compiler用当前github上最新的thrift2中的hbase.thrift文件生成了c++连接hbase的代码，然后在windows下用QtCreator建立了一个测试工程尝试编译，出现了两个错误： 1.  {code:java} struct TKeepDeletedCells { enum type { FALSE = 0, //此处报错：error: expected identifier before numeric constant TRUE = 1, TTL = 2 }; };{code} 错误堆栈： {code:java} In file included from D:/Apps/Qt/Qt5.12.9/Tools/mingw730_64/x86_64-w64-mingw32/include/windef.h:8:0, from D:/Apps/Qt/Qt5.12.9/Tools/mingw730_64/x86_64-w64-mingw32/include/windows.h:69, from D:/Apps/Qt/Qt5.12.9/Tools/mingw730_64/x86_64-w64-mingw32/include/winsock2.h:23, from ..\..\TestBoost\include/thrift/transport/PlatformSocket.h:26, from ..\..\TestBoost\include/thrift/Thrift.h:23, from ..\..\TestBoost\hbase-thrift2-13\Hbase_types.h:12, from ..\..\TestBoost\hbase-thrift2-13\Hbase_constants.h:10, from ..\..\TestBoost\hbase-thrift2-13\Hbase_constants.cpp:7: ..\..\TestBoost\hbase-thrift2-13\Hbase_types.h:151:17: error: expected identifier before numeric constant enum type { FALSE = 0, TRUE = 1, TTL = 2 }; ^{code} 错误原因：windef.h引用了头文件minwindef.h，其中对TRUE，FALSE进行了宏定义，导致此处不是一个有效的变量名 {code:java} #ifndef FALSE #define FALSE 0 #endif #ifndef TRUE #define TRUE 1 #endif{code} 我在struct TKeepDeletedCells前增加了 {code:java} #UNDEF TRUE #UNDEF FALSE{code} 规避该问题 2. D:\Apps\Qt\Qt5.12.9\Tools\mingw730_64\lib\gcc\x86_64-w64-mingw32\7.3.0\include\c++\bits\stl_function.h:386: error: undefined reference to `apache::hadoop::hbase::thrift2::TServerName::operator<(apache::hadoop::hbase::thrift2::TServerName const&) const' thrift生成的TServerName定义只给出了操作符定义，并未实现 bool operator<(const TServerName &) const; 导致调用报错，不过我并未找到在哪里调用的<操作符，不过TServerName被放到了std:vector中，可能是vector中的函数调用了它 我增加了该操作符的实现就可以编译通过了 {code:java} bool operator<(const TServerName &rhs) const { return startCode < rhs.startCode; }; {code}  " Nightly build setup failure with Ruby version,13341372,Resolved,Critical,Resolved,18/Nov/20 15:23,05/Apr/21 03:46,1.7.0,"Nightly builds are failing on branch-2.2 and branch-1 in Docker setup phase. {noformat} Step 28/33 : RUN gem install rubocop:'<= 0.81' ---> Running in ca2c6ed8ee8a Building native extensions. This could take a while... ERROR: Error installing rubocop: parallel requires Ruby version >= 2.5. Successfully installed jaro_winkler-1.5.4 The command '/bin/sh -c gem install rubocop:'<= 0.81'' returned a non-zero code: 1 ERROR: Docker failed to build yetus/hbase:e5c0a9422c. {noformat}" Old WALs archive fails in procedure based WAL split,13347835,Resolved,Critical,Fixed,25/Dec/20 07:06,07/Jan/21 10:34,2.2.6,"If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. Steps to Reproduce: * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to different fs instances. * Start HBase with multiple RS.  * Create a couple of tables and some rows in them so that the RSs get assigned with some regions.  * Take any RS with non-zero number of regions offline.  * Check master logs for ""Wrong FS"" error as shown in the screenshot attached.   " Non-daemon thread in ZKWatcher,13340365,Resolved,Critical,Fixed,12/Nov/20 21:50,14/Jan/21 02:01,,ZKWatcher spawns an ExecutorService which doesn't mark its threads as daemons which will prevent clean shut downs. postScannerFilterRow impacts Scan performance a lot in HBase 2.x,13340327,Resolved,Critical,Fixed,12/Nov/20 19:18,18/Dec/20 16:43,,"In our test we observed Scan performance is degraded by more than 60% in HBase-2.x as compared to 1.3.x.  As per the flamegraph report, RS spent 31% of the time in postScannerFilterRow, however the coprocessors (AccessController, VisibilityController & ConstraintProcessor) does nothing in that hook. HBASE-14489 added the logic to avoid the call to postScannerFilterRow when not needed which is not working as expected in HBase 2.x. AccessController, VisibilityController & ConstraintProcessor override the postScannerFilterRow with dummy (same as RegionObserver) implementation, so RegionCoprocessorHost.hasCustomPostScannerFilterRow will be TRUE and call the hook for all configured CPs while processing each row . Suppose we have configured 5 region CPs and there are 1 M rows in table, then there will be 1 * 5 M dummy call to postScannerFilterRow during whole table scan. We need to remove postScannerFilterRow hook from these CPs as these are not doing anything. Another problem is in RegionCoprocessorHost.hasCustomPostScannerFilterRow init logic, currently it is always TRUE even though we remove postScannerFilterRow hook from AccessController, VisibilityController & ConstraintProcessor, because we are finding postScannerFilterRow until it is found (we look in configured CP's super class also) or clazz is NULL. https://github.com/apache/hbase/blob/035c192eb665469ce0c071db86c78f4a873c123b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java#L301 Supper class of Object (super class of AccessController) will be NULL, so RegionCoprocessorHost.hasCustomPostScannerFilterRow will be set as TRUE https://github.com/apache/hbase/blob/035c192eb665469ce0c071db86c78f4a873c123b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java#L279" add security check for some APIs in RSRpcServices,13347669,Resolved,Critical,Fixed,24/Dec/20 02:11,07/Jan/21 13:46,,"  ||API||Severity||symptom|| |clearRegionBlockCache|Severe|The API will call LruBlockCache.evictBlocksByHfileName, who is declared as an expensive operation(see its comments), thus non-amin may result Dos| |clearSlowLogsResponses|Normal|clears queue records from ringbuffer| |updateConfiguration|Normal|non-admin user can make RS reload configutation from disk by this API. | |updateRegionFavoredNodesMapping|Normal|Non-admin user can change the region's best storage location by this api| |stopServer|low|stopServer on RS is slient, which make client think he/she success shutdown RS. Add preRpcCheck ont only make client receive the failed message, but also prevent the non-admin user stop the RS, even the hbase.coprocessor.regionserver.classes are not configured.|  " setRegionStateInMeta need security check,13348545,Resolved,Critical,Fixed,31/Dec/20 03:39,01/Jan/21 06:51,,[Viraj Jasani|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=vjasani]  it seems that we miss setRegionStateInMeta  update_all_config should not be executed by non-admin user!!!,13346983,Resolved,Critical,Duplicate,20/Dec/20 04:50,31/Dec/20 04:44,,!image-2020-12-20-12-50-23-433.png! list_regions make potential sensitive information disclosure,13346714,Open,Critical,,18/Dec/20 05:01,,,"I found that I can get other users' region information which is not expected.   For example i create a table as sysadmin, then I can read the region information as user1. !image-2020-12-18-13-00-20-126.png!   I have found that list_regions is introduced by https://issues.apache.org/jira/browse/HBASE-14925   we can also get the region info by rest     !image-2020-12-18-13-07-00-777.png!   i think if we expose more informaiton, we will be in more danger case, and even be attacked by others.   " Legacy comparator in Hfile trailer will fail to load,13345078,Resolved,Critical,Fixed,09/Dec/20 13:13,15/Dec/20 18:34,2.3.2,"HBASE-24968 moved MetaCellComparator out from CellComparatorImpl to avoid the deadlock issue. But this introduced compatibility issue, old hfile with comparator class as ""org.apache.hadoop.hbase.CellComparator$MetaCellComparator"" will fail to open due to ClassNotFoundException. Also we should also handle the case when comparator class is ""org.apache.hadoop.hbase.CellComparatorImpl$MetaCellComparator"", which was case before HBASE-24968.  " hbase2.x the performance is lower than hbase 1.x ？,13343511,Open,Critical,,01/Dec/20 09:54,,2.0.2,"Recently we found that the newly built production hbase cluster is running a bit slow , the hadoop version is Hbase2.0.2 ( HDP3.1.1) and it has 100 nodes.Then we begin to do load & query performance verification between Hbase2.0.2 ( HDP3.1.1) & Hbase1.2.0 ( CDH5.13.3 ) test environment （4nodes）, found that : put data based on hbase2.0 is much slower than hbase1.x (the former is almost half of the latter), I use BufferedMutator and BufferedMutatorParams term for batch put to improve efficiency. More confusing is the performance of the production environment is worse than my test environment Some of the codes are as follows: ----------------------------------------------------------------------- {color:#4C9AFF}List mutator = new ArrayList<>(); BufferedMutator table = null; BufferedMutatorParams params = new BufferedMutatorParams(TableName.valueOf(fileHbRule.getHbaseTableName())); params.writeBufferSize(fileHbRule.getFlushBuffer().intValue()*1024*1024); table = connection.getBufferedMutator(params); mutator.add(p); if(totalCnts % 5000 == 0 ) { table.mutate(mutator); mutator.clear(); }{color} ----------------------------------------------------------------------- The file to put is a text format file: 2 million rows comma-separated text file, each row records 110 columns, total size is about 1G. In addition to the main parameter configuration such as heap memory, I kept the default parameter values ??for most of the hbase services. The load program is designed for single thread. The following is the progress information : ----------------------- Hbase1.2.0 ( CDH5.13.3 ) -------------------------------------------- 2020-12-01 16:48:18 inserted: 100000 2020-12-01 16:48:36 inserted: 200000 2020-12-01 16:48:52 inserted: 300000 2020-12-01 16:49:08 inserted: 400000 2020-12-01 16:49:23 inserted: 500000 2020-12-01 16:49:39 inserted: 600000 2020-12-01 16:49:56 inserted: 700000 2020-12-01 16:50:12 inserted: 800000 2020-12-01 16:50:29 inserted: 900000 2020-12-01 16:50:45 inserted: 1000000 2020-12-01 16:51:01 inserted: 1100000 2020-12-01 16:51:17 inserted: 1200000 2020-12-01 16:51:34 inserted: 1300000 2020-12-01 16:51:49 inserted: 1400000 2020-12-01 16:52:05 inserted: 1500000 2020-12-01 16:52:21 inserted: 1600000 2020-12-01 16:52:40 inserted: 1700000 2020-12-01 16:52:57 inserted: 1800000 2020-12-01 16:53:19 inserted: 1900000 2020-12-01 16:53:42 inserted: 2000000 2020-12-01 16:53:48 inserted: 2000000 imp finished ok! --job finished-- -----------------------Hbase.2.0.2 ( HDP3.1.1)--------------------------------------------- 2020-12-01 17:25:24 inserted: 100000 2020-12-01 17:26:03 inserted: 200000 2020-12-01 17:26:39 inserted: 300000 2020-12-01 17:27:13 inserted: 400000 2020-12-01 17:27:47 inserted: 500000 2020-12-01 17:28:23 inserted: 600000 2020-12-01 17:29:03 inserted: 700000 2020-12-01 17:29:40 inserted: 800000 2020-12-01 17:30:15 inserted: 900000 2020-12-01 17:30:51 inserted: 1000000 2020-12-01 17:31:27 inserted: 1100000 2020-12-01 17:32:03 inserted: 1200000 2020-12-01 17:32:39 inserted: 1300000 2020-12-01 17:33:14 inserted: 1400000 2020-12-01 17:33:50 inserted: 1500000 2020-12-01 17:34:25 inserted: 1600000 2020-12-01 17:35:01 inserted: 1700000 2020-12-01 17:35:38 inserted: 1800000 2020-12-01 17:36:14 inserted: 1900000 2020-12-01 17:36:51 inserted: 2000000 2020-12-01 17:36:55 inserted: 2000000 imp finished ok! --job finished-- returnCode=0 In addition, we also did some benchmark tests on the production cluster.The delay is seem to be a bit high. The detailed report is in the attachment. Are there any key points that I have not done configuration? or，, this version has performance defects ?" Add Increment/Append support to RowMutations,13338767,Resolved,Critical,Fixed,04/Nov/20 05:05,26/Nov/20 19:09,,"Currently, RowMutations supports only Put and Delete. Supporting Increment/Append in RowMutations would be helpful for some use cases." Upgrading HBase from 2.2.0 to 2.3.x fails because of “Message missing required fields: state”,13338539,Resolved,Critical,Fixed,03/Nov/20 03:14,05/Nov/20 17:44,2.2.0,"When we upgraded HBASE cluster from 2.2.0-RC0 to 2.3.0 or 2.3.3, the HMaster on upgraded node failed to start. The error message is shown below:  {code:java} 2020-11-02 23:04:01,998 ERROR [master/2c4006997f99:16000:becomeActiveMaster] master.HMaster: Failed to become active masterorg.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException: Message missing required fields: state           at org.apache.hbase.thirdparty.com.google.protobuf.UninitializedMessageException.asInvalidProtocolBufferException(UninitializedMessageException.java:79)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.checkMessageInitialized(AbstractParser.java:68)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:120)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:125)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:48)           at org.apache.hbase.thirdparty.com.google.protobuf.Any.unpack(Any.java:228)           at org.apache.hadoop.hbase.procedure2.ProcedureUtil$StateSerializer.deserialize(ProcedureUtil.java:124)           at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.deserializeStateData(RegionRemoteProcedureBase.java:352)           at org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure.deserializeStateData(OpenRegionProcedure.java:72)           at org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProcedure(ProcedureUtil.java:294)           at org.apache.hadoop.hbase.procedure2.store.ProtoAndProcedure.getProcedure(ProtoAndProcedure.java:43)           at org.apache.hadoop.hbase.procedure2.store.InMemoryProcedureIterator.next(InMemoryProcedureIterator.java:90)           at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore$1.load(RegionProcedureStore.java:194)           at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore$2.load(WALProcedureStore.java:474)           at org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.finish(ProcedureWALFormatReader.java:151)           at org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:103)           at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:465)           at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.tryMigrate(RegionProcedureStore.java:184)           at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:257)           at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)           at org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1572)           at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:950)           at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2240)           at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:622)           at java.lang.Thread.run(Thread.java:748)2020-11-02 23:04:01,998 ERROR [master/2c4006997f99:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master 2c4006997f99,16000,1604358237412: Unhandled exception. Starting shutdown. *****org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException: Message missing required fields: state           at org.apache.hbase.thirdparty.com.google.protobuf.UninitializedMessageException.asInvalidProtocolBufferException(UninitializedMessageException.java:79)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.checkMessageInitialized(AbstractParser.java:68)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:120)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:125)           at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:48)           at org.apache.hbase.thirdparty.com.google.protobuf.Any.unpack(Any.java:228)           at org.apache.hadoop.hbase.procedure2.ProcedureUtil$StateSerializer.deserialize(ProcedureUtil.java:124)           at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.deserializeStateData(RegionRemoteProcedureBase.java:352)           at org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure.deserializeStateData(OpenRegionProcedure.java:72)           at org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProcedure(ProcedureUtil.java:294)           at org.apache.hadoop.hbase.procedure2.store.ProtoAndProcedure.getProcedure(ProtoAndProcedure.java:43)           at org.apache.hadoop.hbase.procedure2.store.InMemoryProcedureIterator.next(InMemoryProcedureIterator.java:90)           at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore$1.load(RegionProcedureStore.java:194)           at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore$2.load(WALProcedureStore.java:474)           at org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormatReader.finish(ProcedureWALFormatReader.java:151)           at org.apache.hadoop.hbase.procedure2.store.wal.ProcedureWALFormat.load(ProcedureWALFormat.java:103)           at org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore.load(WALProcedureStore.java:465)           at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.tryMigrate(RegionProcedureStore.java:184)           at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:257)           at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)           at org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1572)           at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:950)           at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2240)           at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:622)           at java.lang.Thread.run(Thread.java:748)2020-11-02 23:04:01,999 INFO  [master/2c4006997f99:16000:becomeActiveMaster] regionserver.HRegionServer: ***** STOPPING region server '2c4006997f99,16000,1604358237412' *****2020-11-02 23:04:01,999 INFO  [master/2c4006997f99:16000:becomeActiveMaster] regionserver.HRegionServer: STOPPED: Stopped by master/2c4006997f99:16000:becomeActiveMaster2020-11-02 23:04:02,814 INFO  [2c4006997f99:16000.splitLogManager..Chore.1] hbase.ScheduledChore: Chore: SplitLogManager Timeout Monitor was stopped2020-11-02 23:04:03,652 INFO  [master/2c4006997f99:16000] ipc.NettyRpcServer: Stopping server on /252.17.1.2:160002020-11-02 23:04:03,658 INFO  [master/2c4006997f99:16000] regionserver.HRegionServer: Stopping infoServer2020-11-02 23:04:03,871 INFO  [master/2c4006997f99:16000] handler.ContextHandler: Stopped o.e.j.w.WebAppContext@6136998b{/,null,UNAVAILABLE}{file:/hbase/hbase-webapps/master}2020-11-02 23:04:03,877 INFO  [master/2c4006997f99:16000] server.AbstractConnector: Stopped ServerConnector@60d1b21f{HTTP/1.1,[http/1.1]}{0.0.0.0:16010}2020-11-02 23:04:03,878 INFO  [master/2c4006997f99:16000] handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@aa004a0{/static,file:///hbase/hbase-webapps/static/,UNAVAILABLE}2020-11-02 23:04:03,878 INFO  [master/2c4006997f99:16000] handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@5965844d{/logs,file:///hbase/logs/,UNAVAILABLE}2020-11-02 23:04:03,888 INFO  [master/2c4006997f99:16000] regionserver.HRegionServer: aborting server 2c4006997f99,16000,16043582374122020-11-02 23:04:03,889 INFO  [master/2c4006997f99:16000] regionserver.HRegionServer: stopping server 2c4006997f99,16000,1604358237412; all regions closed.2020-11-02 23:04:03,889 INFO  [master/2c4006997f99:16000] hbase.ChoreService: Chore service for: master/2c4006997f99:16000 had [] on shutdown2020-11-02 23:04:03,890 INFO  [master/2c4006997f99:16000] region.RegionProcedureStore: Stopping the Region Procedure Store, isAbort=true2020-11-02 23:04:03,894 WARN  [master/2c4006997f99:16000] master.ActiveMasterManager: Failed get of master address: java.io.IOException: Can't get master address from ZooKeeper; znode data == null2020-11-02 23:04:03,894 INFO  [master/2c4006997f99:16000] region.MasterRegion: Closing local region {ENCODED => 1595e783b53d99cd5eef43b6debb2682, NAME => 'master:store,,1.1595e783b53d99cd5eef43b6debb2682.', STARTKEY => '', ENDKEY => ''}, isAbort=true2020-11-02 23:04:03,901 INFO  [master/2c4006997f99:16000] regionserver.HRegion: Closing region master:store,,1.1595e783b53d99cd5eef43b6debb2682.2020-11-02 23:04:03,903 INFO  [master/2c4006997f99:16000] regionserver.HRegion: Closed master:store,,1.1595e783b53d99cd5eef43b6debb2682.2020-11-02 23:04:03,903 INFO  [master/2c4006997f99:16000] hbase.ChoreService: Chore service for: 2c4006997f99:16000.splitLogManager. had [] on shutdown2020-11-02 23:04:03,904 INFO  [master:store-WAL-Roller] wal.AbstractWALRoller: LogRoller exiting.2020-11-02 23:04:03,998 INFO  [ReadOnlyZKClient-252.17.1.5:2181@0x0432f3aa] zookeeper.ZooKeeper: Session: 0x10138d353e5001b closed2020-11-02 23:04:03,998 INFO  [ReadOnlyZKClient-252.17.1.5:2181@0x0432f3aa-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x10138d353e5001b2020-11-02 23:04:04,098 INFO  [master/2c4006997f99:16000] zookeeper.ZooKeeper: Session: 0x10138d353e50018 closed2020-11-02 23:04:04,098 INFO  [master/2c4006997f99:16000] regionserver.HRegionServer: Exiting; stopping=2c4006997f99,16000,1604358237412; zookeeper connection closed.2020-11-02 23:04:04,098 INFO  [main-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x10138d353e500182020-11-02 23:04:04,099 ERROR [main] master.HMasterCommandLine: Master exitingjava.lang.RuntimeException: HMaster Aborted           at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:244)           at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)           at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)           at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)           at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3072) {code}   It can be reproduced through the following steps: # Start up a cluster of version 2.2.0-RC0 with 3 nodes # Use hbase pe to write data.  # {code:java} /hbase/bin/hbase pe --nomapred --oneCon=true --valueSize=10 --rows=100 sequentialWrite 1 {code} # Stop the cluster: ## using the graceful_stop.sh to stop all regionservers. ## Then run stop-hbase.sh #  Upgrade the node to branch-2.3 # After upgraded, as the log, hbase--master-2c4006997f99.log, suggested, HMaster failed to start." Master fails to initialize when creating rs group table,13339359,Resolved,Critical,Fixed,08/Nov/20 03:37,13/Nov/20 08:26,,"Saw this when setup TestRSGroupsKillRS {noformat} 2020-11-07 16:29:54,565 ERROR [master/e476f4f509a7:0:becomeActiveMaster] helpers.MarkerIgnoringBase(159): Failed to become active master java.lang.AssertionError at org.apache.hadoop.hbase.master.assignment.RegionStateNode.setProcedure(RegionStateNode.java:198) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.createAssignProcedure(AssignmentManager.java:647) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.lambda$null$6(AssignmentManager.java:878) at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485) at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:272) at java.util.HashMap$EntrySpliterator.forEachRemaining(HashMap.java:1699) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:546) at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260) at java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:505) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.createAssignProcedures(AssignmentManager.java:879) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.createRoundRobinAssignProcedures(AssignmentManager.java:759) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.createRoundRobinAssignProcedures(AssignmentManager.java:775) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.processOfflineRegions(AssignmentManager.java:1513) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1012) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2116) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:515) at java.lang.Thread.run(Thread.java:748) {noformat}" Support scan on a specific replica,13339879,Resolved,Critical,Fixed,11/Nov/20 03:16,12/Nov/20 13:36,,"This is a missing part of the client library for sync client on branch-2, and it is necessary when implementing meta replicas read." Add 2.3.4 to the downloads page,13346852,Resolved,Major,Fixed,18/Dec/20 18:34,23/Jan/21 03:26,, TestClientOperationTimeout.testScanTimeout is flaky,13337090,Resolved,Major,Fixed,25/Oct/20 12:54,30/Dec/24 12:13,, allow specifying binary row key range to pre-split regions,13344144,Open,Major,,04/Dec/20 04:13,,,"Currently, spark hbase connector use `String` to specify regionStart and regionEnd, but we often have serialized binary row key,  I made a little patch at [https://github.com/apache/hbase-connectors/pull/72/files] to always treat the `String` in ISO_8859_1, so we can put raw bytes into the String object and get it unchanged. This has a drawback,  if your row key is really Unicode strings beyond ISO_8859_1 charset, you should convert it to UTF-8 encoded bytes and then encapsulate it in ISO_8859_1 string. This is a limitation of Spark option interface which allows only string to string map. {code:java} import java.nio.charset.StandardCharsets; df.write() .format(""org.apache.hadoop.hbase.spark"") .option(HBaseTableCatalog.tableCatalog(), catalog) .option(HBaseTableCatalog.newTable(), 5) .option(HBaseTableCatalog.regionStart(), new String(""你好"".getBytes(StandardCharsets.UTF_8), StandardCharsets.ISO_8859_1)) .option(HBaseTableCatalog.regionEnd(), new String(""世界"".getBytes(StandardCharsets.UTF_8), StandardCharsets.ISO_8859_1)) .mode(SaveMode.Append) .save(); {code}" Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3,13347465,Resolved,Major,Fixed,23/Dec/20 02:01,06/Jan/21 03:43,,Having trouble running RM builds from gcp. Downloads of artifacts are having connection reset. Apparently mvn 3.6.1 gets a better http wagon downloader. Doesn't seem to help in this particular case but let me get this in anyways. HBase test mini cluster is working only with Hadoop 2.8.0 - 3.0.3,13330389,Resolved,Major,Cannot Reproduce,01/Oct/20 14:31,20/Sep/24 11:33,2.2.3,"Running HBaseTestingUtility.startMiniCluster() on HBase 2.2.3 works only with hadoop version range 2.8.0 - 3.0.3, for example with 2.4.1 the following exception occurs:   {code:java} 21:49:04,124 [RS:0;71af2d647bb3:35715] ERROR org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper [] - Couldn't properly initialize access to HDFS internals. Please update your WAL Provider to not make use of the 'asyncfs' provider. See HBASE-16110 for more information.21:49:04,124 [RS:0;71af2d647bb3:35715] ERROR org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper [] - Couldn't properly initialize access to HDFS internals. Please update your WAL Provider to not make use of the 'asyncfs' provider. See HBASE-16110 for more information.java.lang.NoSuchMethodException: org.apache.hadoop.hdfs.DFSClient.beginFileLease(long, org.apache.hadoop.hdfs.DFSOutputStream) at java.lang.Class.getDeclaredMethod(Class.java:2130) ~[?:1.8.0_242] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createLeaseManager(FanOutOneBlockAsyncDFSOutputHelper.java:198) ~[hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.(FanOutOneBlockAsyncDFSOutputHelper.java:274) [hbase-server-2.2.3.jar:2.2.3] at java.lang.Class.forName0(Native Method) ~[?:1.8.0_242] at java.lang.Class.forName(Class.java:264) [?:1.8.0_242] at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.load(AsyncFSWALProvider.java:136) [hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.wal.WALFactory.getProviderClass(WALFactory.java:136) [hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.wal.WALFactory.getProvider(WALFactory.java:175) [hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.wal.WALFactory.(WALFactory.java:198) [hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.regionserver.HRegionServer.setupWALAndReplication(HRegionServer.java:1871) [hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.regionserver.HRegionServer.handleReportForDutyResponse(HRegionServer.java:1589) [hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.handleReportForDutyResponse(MiniHBaseCluster.java:157) [hbase-server-2.2.3-tests.jar:2.2.3] at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1001) [hbase-server-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.runRegionServer(MiniHBaseCluster.java:184) [hbase-server-2.2.3-tests.jar:2.2.3] at org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.access$000(MiniHBaseCluster.java:130) [hbase-server-2.2.3-tests.jar:2.2.3] at org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer$1.run(MiniHBaseCluster.java:168) [hbase-server-2.2.3-tests.jar:2.2.3] at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_242] at javax.security.auth.Subject.doAs(Subject.java:360) [?:1.8.0_242] at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1536) [hadoop-common-2.4.1.jar:?] at org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs(User.java:341) [hbase-common-2.2.3.jar:2.2.3] at org.apache.hadoop.hbase.MiniHBaseCluster$MiniHBaseClusterRegionServer.run(MiniHBaseCluster.java:165) [hbase-server-2.2.3-tests.jar:2.2.3] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242] {code} Also upon failure during maven run it would be great if the actual exception would be displayed, not just that ""Master not initialized after 200000ms"".  " Protobuf Mesage Incompatibility Detector,13343143,Open,Major,,29/Nov/20 04:37,,2.2.6,"Regarding the issue HBASE-25238. caused by the incompatibility of protobuf message, we have created a static checker which keeps track of the proto file change, and detect potential incompatibility: # Add/delete required field, which is exactly the case reported in HBASE-25238. # The tag number of a field has been changed, as described in HDFS-9788. Also, the [protobuf guidelines |https://developers.google.com/protocol-buffers/docs/proto]suggests _each field in the message definition has a *unique number*. These numbers are used to identify your fields in the [message binary format|https://developers.google.com/protocol-buffers/docs/encoding], and should not be changed once your message type is in use_.  # A  required field has been changed to optional, or an optional field has been changed to required. According to the guidelines in [protobuf official website|https://developers.google.com/protocol-buffers/docs/proto], _*Required Is Forever* You should be very careful about marking fields as {{required}}. If at some point you wish to stop writing or sending a required field, it will be problematic to change the field to an optional field - old readers will consider messages without this field to be incomplete and may reject or drop them unintentionally. You should consider writing application-specific custom validation routines for your buffers instead._ We have applied our checker on the frequently maintained HBASE versions: rel/1.4.3, rel/1.6.0, rel/2.2.6, rel/2.3.3, and master, and we found 37 potential problems as attached, which includes the one found in HBASE-25238.   " Support splitting a region into N parts at a time,13338807,Resolved,Major,Duplicate,04/Nov/20 10:13,03/Jun/24 22:16,,"In the current reference file format, only one parent region split into two references can be recorded. At this time, if you want to continue splitting the daughter region, you must wait until the majorCompaction is over and the reference file is deleted before you can continue to split the region. If the reference file can point to other refenrence files, which data has not been moved from the parentRegion to the region under the corresponding folder, thereby establishing a multi-level reference. At this time, a tree structure is formed. Only the root contains physical data, and the region on the leaf node region is serving." There is no limit on the table name length when creating a table,13347245,Patch Available,Major,,22/Dec/20 04:00,,2.2.3,"It occurs Exeception(ERROR：java.util.concurrent.ExecutionExceptionjava.io.IOExpcetionException in createDir) because of 8000 bytes length limits on HDFS directory name if the length of HBase table name misses validation when creating. So,we decide to verify the length of table name when creating a table.IllegalArgumentExcetion will be thrown when length is larger than 8000 bytes." Use Address instead of InetSocketAddress in RpcClient implementation,13343102,Resolved,Major,Fixed,28/Nov/20 13:08,07/Dec/20 14:05,, Improve InetSocketAddress usage discipline,13340890,Resolved,Major,Fixed,16/Nov/20 18:14,04/Dec/20 18:26,,"We sometimes cache InetSocketAddress in data structures in an attempt to optimize away potential nameservice (DNS) lookups. This is, in general, an anti-pattern, because once an InetSocketAddress is resolved, resolution is never attempted again. The ideal pattern for connect() is ISA instantiation just before the connect() call, with no reuse of the ISA instance. For bind() we presume the local identity won't change while the process is live so usage and caching can be relaxed in that case. If I can restate my proposal for a usage convention for InetSocketAddress, it would be this: Network identities should be bound late. This means addresses should be resolved at the last possible moment. Also, network identity mappings can change, so our code should not inappropriately cache them; otherwise we might miss a change and fail to operate normally. I have reviewed the code for InetSocketAddress usage and in my opinion sometimes we are caching ISA acceptably, and in other cases we are not. Correct cases: * We cache ISA for RPC connections, so we don't potentially do a lookup for every Call. However, we resolve the address earlier than we need to. The code can be improved by moving resolution to just before where we connect(). * Use of ISA with bind. Typical uses like bindAddress, listenerAddress, initialIsa, or localAddress. ** (There is no harm to keep direct use of ISA for bind() but these could all be replaced with Address and on-demand create of ISA just before bind(). * ClusterStatusPublisher in master. * Netty integration. Netty accepts and supplies ISA, no choice there, but we want to resolve at channel create time and cache for lifetime of the channel anyway. If a remote host goes away and is replaced with a new identity, a new channel/connection will be created with a new resolution just before connect() via higher layer error handling. Incorrect cases that can be fixed: * RPC stubs. Remote clients may be recycled and replaced with new instances where the network identities (DNS name to IP address mapping) have changed--. HBASE-14544 attempts to work around DNS instability in data centers of years past in a way that, in my opinion, is the wrong thing to do in the modern era. In modern datacenters, in public cloud, and especially in kubernetes environments, DNS mappings are dynamic and subject to frequent change. It is just never the right thing to do to cache them. I intend to propose a revert of HBASE-14544. Reverting this simplifies some code a bit. That is the only reason: this is in my opinion some legacy that can be dropped, one fewer configuration variable (yay!), but if this part of the proposal is controversial it can be skipped. * RPC stubs again. When looking up the IP address of the remote host when creating a stub key we also make a key even if the resolution fails. This is the wrong thing to do. If we can't resolve the remote address, we can't contact the server. Making a stub that can't communicate is pointless. Throw an exception instead. * Favored nodes. Although the HDFS API requires InetSocketAddress, we don't have to make up a list right away and cache them forever. We can use Address to record the list of favored nodes and convert from Address to InetSocketAddress on demand (when we go to create the HFile). This will allow us to resolve datanode hostnames just before they are needed. In public cloud, kubernetes, and or some private datacenter service deployment options, datanode servers may have their network identities (DNS name -> IP address mapping) changed over time. We can and should avoid inappropriate caching that may cause us to indefinitely use an incorrect address when contacting a favored node.  * Sometimes we use ISA when Address is just as good. For example, the dead servers list. If we are going to pay some attention to ISA usage discipline, let's remove the cases where we use ISA as a host and port pair but do not need to do so. Address works just as well and doesn't present an opportunity for misuse. Another example would be the RPC client concurrentCounterCache. ** We could do a lot more substitutions than what is proposed. All of the ISA uses with bind() are okay as is but could also be updated. Incorrect cases that cannot be fixed: * hbase-external-blockcache: We have to resolve all of the memcached locations up front because the memcached client constructor requires ISA instances. So we have to hope that the network identities (DNS name -> IP address mapping) does not change for any in the list. This is beyond our control. While in this area it is trivial to add new client connect metrics for number of potential nameservice lookups (whenever we instantiate an ISA) and number of failed nameservice lookups (if the instantiated ISA is unresolved). While in this area I also noticed we often directly access a field in ConnectionId where there is also a getter, so good practice is to use the getter instead." Super Split Meta,13345376,Open,Major,,10/Dec/20 20:22,,,"Currently, the hbase:meta Table is made of one Region only. It is not splittable. We would like to make it so the hbase:meta table can be split just as we for user-space tables as they grow in size. Why split the hbase:meta table? {quote}A single Region _hbase:meta_ Table hotspots as cluster size grows. At extreme, hotspotting brings on special-casing with deploys dedicating nodes solely to the hosting of the single _hbase:meta_ Region to better carry the higher load (but also to isolate _hbase:meta_ if heavily trafficked neighbor Regions). Splitting, currently disallowed, will enable distributing the _hbase:meta_ Table Regions, and thereby load, across the cluster. A splittable _hbase:meta_ table will also alleviate concerns enlarging the _hbase:meta_ table whether by adding more meta data per Region entry -- e.g. keeping the list of Region HFiles in the _hbase:meta_ table -- or running with more, smaller Regions rather than a few large Regions. {quote} This is not the first issue to concern itself with meta splitting (HBASE-11288, HBASE-24950). By aggreement. -- see the base of HBASE-11288 -- this issue supplants all previous JIRAs and design efforts. It is a reset. We start by listing requirements in the attached Super Split Meta Design." Add a cost function to move the daughter regions of a recent split to different region servers ,13337479,Resolved,Major,Duplicate,27/Oct/20 17:20,19/Oct/23 23:07,,"In HBase, hotspot regions are easily formed whenever there is skew and there is high write volume. Few regions grow really fast which also becomes the bottleneck on the few region servers. It would be beneficial to add a cost function to move the regions after the split to differetn region servers. In this way the writes to hot key range will be distributed to multiple region servers. " Make MasterRpcServices not extends RSRpcServices and also HMaster not extends HRegionServer,13340771,Resolved,Major,Fixed,16/Nov/20 07:50,13/Sep/21 02:05,, s390x support for HBase CI,13335754,Resolved,Major,Duplicate,16/Oct/20 10:48,20/Oct/22 11:53,,"Hi All, As I understand that currently CI available for HBase ( to validate any code updates ) is : https://ci-hadoop.apache.org/job/HBase/ and as can be seen most of the deployment here is on amd64 and ppc64le. Wanted to know your views/comments/suggestions for extending CI of HBase on s390x . 1) If the community will be willing to add - vm's/slaves ( s390x based ) to their current above CI. 2) Use an externally hosted jenkins CI - for running HBase build on s390x and link the results of the build to the above CI. Please let me know your thoughts. Regards, Aditi" MobFileCompactionChore is closing the master's shared cluster connection,13334460,Resolved,Major,Fixed,08/Oct/20 16:48,20/Oct/20 05:24,3.0.0-alpha-1,"Code which is doing so in MobFileCompactionChore {code:java} try (Connection conn = master.getConnection(); Admin admin = conn.getAdmin();) { {code} As master uses this connection to read the meta or other system tables, so none of the meta operations through master will work. Symptoms in master logs:- {code:java} s, events=841, succcessCount=123, totalEvents=12824192, totalSuccessCount=1891300 2020-10-05 16:34:25,062 INFO org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor: Unable to get remote Address 2020-10-05 16:34:25,062 ERROR org.apache.hadoop.hbase.master.normalizer.RegionNormalizerChore: Failed to normalize regions. java.io.IOException: connection is closed at org.apache.hadoop.hbase.MetaTableAccessor.getMetaHTable(MetaTableAccessor.java:241) at org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:797) at org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:768) at org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:727) at org.apache.hadoop.hbase.MetaTableAccessor.fullScanTables(MetaTableAccessor.java:215) at org.apache.hadoop.hbase.master.TableStateManager.getTablesInStates(TableStateManager.java:189) at org.apache.hadoop.hbase.master.HMaster.normalizeRegions(HMaster.java:1821) at org.apache.hadoop.hbase.master.normalizer.RegionNormalizerChore.chore(RegionNormalizerChore.java:48) at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:188) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) at org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code} Symptoms at the client:- {code:java} RpcRetryingCaller{globalStartTime=1602099132430, pause=100, maxAttempts=11}, java.io.IOException: java.io.IOException: connection is closed        at org.apache.hadoop.hbase.MetaTableAccessor.getMetaHTable(MetaTableAccessor.java:241)        at org.apache.hadoop.hbase.MetaTableAccessor.getTableState(MetaTableAccessor.java:1116)        at org.apache.hadoop.hbase.master.TableStateManager.readMetaState(TableStateManager.java:258)        at org.apache.hadoop.hbase.master.TableStateManager.isTablePresent(TableStateManager.java:175)        at org.apache.hadoop.hbase.master.HMaster.getTableDescriptors(HMaster.java:3277)        at org.apache.hadoop.hbase.master.HMaster.listTableDescriptors(HMaster.java:3221)        at org.apache.hadoop.hbase.master.MasterRpcServices.getTableDescriptors(MasterRpcServices.java:1064)        at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)        at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:418)        at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)        at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)        at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318{code}" "Client app getting ""Failed to load SIMPLE, KERBEROS, and DIGEST authentication providers. Classpath is not sane."" errors",13343138,Resolved,Major,Incomplete,29/Nov/20 00:16,29/Nov/20 00:36,2.3.0,"Application is ran from Spring jar, hbase-client jar is included. But looks like ServiceLoader.load is unable to load providers for SaslClientAuthenticationProvider I get lot of stack traces like this in log file: {noformat} 2020-11-29T00:08:37.019Z, RpcRetryingCaller{globalStartTime=1606608514899, pause=100, maxAttempts=6}, java.io.IOException: Call to hostname/xx.xx.xx.xx:16020 failed on local exception: java.io.IOException: java.lang.IllegalStateException: Failed to load SIMPLE, KERBEROS, and DIGEST authentication providers. Classpath is not sane. at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:145) at org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source) Caused by: java.io.IOException: Call to hostname/xx.xx.xx.xx:16020 failed on local exception: java.io.IOException: java.lang.IllegalStateException: Failed to load SIMPLE, KERBEROS, and DIGEST authentication providers. Classpath is not sane. at java.base/jdk.internal.reflect.GeneratedConstructorAccessor101.newInstance(Unknown Source) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Unknown Source) at java.base/java.lang.reflect.Constructor.newInstance(Unknown Source) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:225) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:378) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:89) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:409) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:405) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:117) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:132) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:422) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:316) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$200(AbstractRpcClient.java:89) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:572) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$BlockingStub.scan(ClientProtos.java:45390) at org.apache.hadoop.hbase.client.ScannerCallable.openScanner(ScannerCallable.java:332) at org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:242) at org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:58) at org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:396) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:370) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107) ... 4 more Caused by: java.io.IOException: java.lang.IllegalStateException: Failed to load SIMPLE, KERBEROS, and DIGEST authentication providers. Classpath is not sane. at org.apache.hadoop.hbase.ipc.IPCUtil.toIOE(IPCUtil.java:159) ... 17 more Caused by: java.lang.IllegalStateException: Failed to load SIMPLE, KERBEROS, and DIGEST authentication providers. Classpath is not sane. at org.apache.hadoop.hbase.security.provider.BuiltInProviderSelector.configure(BuiltInProviderSelector.java:97) at org.apache.hadoop.hbase.security.provider.SaslClientAuthenticationProviders.instantiateSelector(SaslClientAuthenticationProviders.java:116) at org.apache.hadoop.hbase.security.provider.SaslClientAuthenticationProviders.instantiate(SaslClientAuthenticationProviders.java:190) at org.apache.hadoop.hbase.security.provider.SaslClientAuthenticationProviders.getInstance(SaslClientAuthenticationProviders.java:78) at org.apache.hadoop.hbase.ipc.RpcConnection.(RpcConnection.java:103) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.(NettyRpcConnection.java:97) at org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:76) at org.apache.hadoop.hbase.ipc.NettyRpcClient.createConnection(NettyRpcClient.java:39) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:350) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:419) ... 16 more {noformat}  I got this problem after changing client version from 2.1.9 to 2.3.0 (I've upgraded server to 2.3.0) When I switch back to 2.1.9 client, it works without errors. " [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous,13341642,Resolved,Major,Won't Fix,19/Nov/20 18:05,11/Jun/22 17:54,,"We are again having classpath versioning issues related to Guava in our branch-1 based application. Hadoop 3, HBase 2, Phoenix 5, and other projects deal with Guava cross-version incompatibilities, as they manifest on a combined classpath with other components, via shading. I propose to do a global search and replace of all direct uses of Guava in our branch-1 code base and refer to Guava as provided in hbase-thirdparty's hbase-shaded-miscellaneous. This will protect HBase branch-1 from Guava cross-version vagaries just like the same technique protects branch-2 and branch-2 based releases. There are a couple of Public or LimitedPrivate interfaces that incorporate Guava's HostAndPort and Service that will be indirectly impacted. We are about to release a new minor branch-1 version, 1.7.0, and this would be a great opportunity to introduce this kind of change in a manner consistent with semantic versioning and our compatibility policies." 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml,13348082,Closed,Major,Fixed,28/Dec/20 08:18,14/Jan/21 02:25,2.0.1,"I think this parameter is not suitable for in hbase-default.xml, because in this case, HDFS explicitly set to ""dfs.client.read.shortcircuit=true"", hbase rely on HDFS configuration, the parameters in hbase service still is false.Must be explicitly in hbase-site.xml is set to ""dfs.client.read.shortcircuit=true"" to take effect.The same goes for the parameter 'dfs.domain.socket.path', which is already covered in the specific change." Write HBCK tools to rebuild the tracking,13345911,Closed,Major,Won't Fix,14/Dec/20 17:37,24/Dec/21 02:08,,"{color:#000000}support online region repairing, and maybe offline repairing as well {color}" Cleanup unused/unneeded temporarily HFiles ,13345910,Closed,Major,Won't Fix,14/Dec/20 17:36,24/Dec/21 02:08,,Cleanup records and write a new cleaner to move unneeded files from data directory into archives (other than compaction) Migrate hbase:storefile system table into editable meta,13345908,Closed,Major,Won't Fix,14/Dec/20 17:34,24/Dec/21 02:07,,"{color:#000000}editable meta supported by HBASE-23055 allow us to write new column family to hbase:meta, such that we will introduce a new column family cf:storefile to hbase:meta with different trackable columns to served as the in-memory tracking of e.g. `storefiles` and `compactedfile` in StoreFileManager.{color}" Integration with direct insert into data/cf directory,13345906,Closed,Major,Won't Fix,14/Dec/20 17:33,24/Dec/21 02:07,,"Utilizes direct insert compactor, file writer, committer and etc while constructing the PersistedStoreEngine" Support Snapshot related operation with direct insert HFiles into data/CF directory,13345904,Closed,Major,Won't Fix,14/Dec/20 17:26,24/Dec/21 02:07,,"{color:#000000}Support restore snapshot, clone snapshot with direct insert into data directory{color}" Support split and merge region with direct insert into CF directory,13345903,Closed,Major,Abandoned,14/Dec/20 17:25,19/Aug/21 09:12,,{color:#000000}Support region SPLIT and MERGE with direct insert HFiles into column family directory{color} Direct insert compacted HFiles into data directory.,13345902,Closed,Major,Fixed,14/Dec/20 17:24,28/Jul/21 18:36,,"{color:#000000}when performing compaction, write directly to the data directory {color}" "Flush directly into data directory, skip rename when committing flush",13345901,Closed,Major,Fixed,14/Dec/20 17:23,11/Jun/21 21:26,,"{color:#000000}When flushing memstore snapshot to HFile, we write it directly to the data directory.{color}" Introduce PersistedStoreEngine and PersistedStoreFileManager,13345905,Closed,Major,Fixed,14/Dec/20 17:30,16/Mar/21 03:51,3.0.0-alpha-1,"Create a new wrapper store engine on top of the default store engine, as well as, introducing a new store file manager that keep tracking path of HFiles of user tables into a hbase self-managed system table (further will have a different tasks to merge into meta table and check throughput do not change much)" "Support dynamic update configurations about tracing, e.g. OpenTelemetry",13346987,Open,Major,,20/Dec/20 06:23,,,"It is necessary to update configurations which are relevant to HTrace without restart the RS, such as the sampler of HTrace." Data loss can happen if a cloned table loses original split region(delete table),13336295,Closed,Major,Fixed,20/Oct/20 13:18,24/Oct/20 15:22,,"Steps to reproduce are as follows: 1. Create a table and put some data into the table: {code:java} create 'test1','cf' put 'test1','r1','cf','v1' put 'test1','r2','cf','v2' put 'test1','r3','cf','v3' put 'test1','r4','cf','v4' put 'test1','r5','cf','v5' {code} 2. Take a snapshot for the table: {code:java} snapshot 'test1','snap_test' {code} 3. Clone the snapshot to another table {code:java} clone_snapshot 'snap_test','test2' {code} 4. Split the original table {code:java} split 'test1','r3' {code} 5. Drop the original table {code:java} disable 'test1' drop 'test1' {code} After that, we see the error like the following in RS log when opening the regions of the cloned table: {code:java} 2020-10-20 13:32:18,415 WARN org.apache.hadoop.hbase.regionserver.HRegion: Failed initialize of region= test2,,1603200595702.bebdc4f740626206eeccad96b7643261., starting to roll back memstore java.io.IOException: java.io.IOException: java.io.FileNotFoundException: Unable to open link: org.apache.hadoop.hbase.io.HFileLink locations=[hdfs://:8020/hbase/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/.tmp/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/mobdir/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/archive/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89] at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1095) at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:943) at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:899) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7246) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7204) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7176) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7134) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7085) at org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:283) at org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:108) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException: java.io.FileNotFoundException: Unable to open link: org.apache.hadoop.hbase.io.HFileLink locations=[hdfs://:8020/hbase/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/.tmp/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/mobdir/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/archive/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89] at org.apache.hadoop.hbase.regionserver.HStore.openStoreFiles(HStore.java:590) at org.apache.hadoop.hbase.regionserver.HStore.loadStoreFiles(HStore.java:557) at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:303) at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:5731) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1059) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1056) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) ... 3 more Caused by: java.io.FileNotFoundException: Unable to open link: org.apache.hadoop.hbase.io.HFileLink locations=[hdfs://:8020/hbase/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/.tmp/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/mobdir/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89, hdfs://:8020/hbase/archive/data/default/test1/349b766b1b38e21f627ed4e441ae643c/cf/b6e39865710345c8998dec0bcc94cc89] at org.apache.hadoop.hbase.io.FileLink$FileLinkInputStream.tryOpen(FileLink.java:322) at org.apache.hadoop.hbase.io.FileLink$FileLinkInputStream.(FileLink.java:126) at org.apache.hadoop.hbase.io.FileLink$FileLinkInputStream.(FileLink.java:117) at org.apache.hadoop.hbase.io.FileLink.open(FileLink.java:429) at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:125) at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:107) at org.apache.hadoop.hbase.regionserver.StoreFileInfo.open(StoreFileInfo.java:261) at org.apache.hadoop.hbase.regionserver.HStoreFile.open(HStoreFile.java:368) at org.apache.hadoop.hbase.regionserver.HStoreFile.initReader(HStoreFile.java:476) at org.apache.hadoop.hbase.regionserver.HStore.createStoreFileAndReader(HStore.java:703) at org.apache.hadoop.hbase.regionserver.HStore.lambda$openStoreFiles$1(HStore.java:573) ... 6 more {code}" Revisit the implementation and usage of RegionStates.include,13336315,Closed,Major,Fixed,20/Oct/20 15:22,22/Oct/20 14:18,,"After several round of refactoring and fixing, the method has been used in lots of places and the implementation looks really confusing. As in the first if condition for testing RegionStateNode and RegionInfo state, we will always return false when split is true, which means we will always filter out split parent, as a split parent, is split = true and also offline = true. I think the reason why there is no problem is that, only in EnableTableProcedure we call this method with offline = true, and EnableTableProcedure does not need to deal with split parent... And now since we found a problem in HBASE-25206, where we need to get split parent when deleting a table, I think it is time to revisit this method and make logic less confusing." Document how to enable the meta replica load balance mode for the client and clean up around hbase:meta read replicas,13340877,Closed,Major,Fixed,16/Nov/20 17:08,20/Nov/20 23:50,2.4.0,Need to document how to enable meta replica Load Balance mode for clients. "Check-in ""Enable memstore replication..."" design",13340652,Closed,Major,Fixed,14/Nov/20 17:11,21/Nov/20 16:56,,Add the design doc under dev-support/design-docs warmupRegion frustrates registering WALs on the catalog replicationsource,13330666,Closed,Major,Fixed,03/Oct/20 08:36,07/Oct/20 18:22,,"Writing a test for HBASE-25145 I noticed that the warmupRegion call triggered by the Master on Region move mess-up registering hbase:meta ReplicationSource. Add accommodation." WALReader quits if nothing to replicate (and won't restart),13330485,Closed,Major,Not A Problem,02/Oct/20 03:25,05/Oct/20 18:23,,"Noticed by [~huaxiangsun] in his review of HBASE-25055 ""Add ReplicationSource for meta WALs; add enable/disable w…"" {quote}bq. Eventually, the meta wal file will be gced and there is no more logs in the queue. In that case, the walReader thread will quit. When the meta region is moved back, it does not seem that walReader thread will be restarted. So it seems that something is broken. {quote} This issue is about writing a test to run the above scenario and fix any probs. found." Release a hbase-thirdparty with hbase-shaded-miscellaneous suitable for branch-1,13341878,Resolved,Major,Not A Problem,21/Nov/20 01:55,11/Jun/22 17:55,, [hbck2] Add an 'adoption service' for 'Orphaned Regions',13334095,Open,Major,,07/Oct/20 00:28,,,"The 'HBCK Report' has a section for 'Orphaned Regions', regions in the filesystem that are no longer referenced by the running hbase. They should have been cleaned up as part of normal processing but for whatever reason, they were not. Usually these are dessicated directories with nothing in them but sometimes they might have an hfile or two. They could have content in recovered.edits directory too. The ""HBCK Report"" page outline how to run the bulk load tool. This will pick up any hfiles in the 'Orphan Region' if there is worry that they have been dropped mistakenly. For the content under 'recovered.edits', the WALPlayer has just been adjusted so it can pick up this content (See over in HBASE-22976). The 'adoption service' would be run over an orphan region and it would apply the 'bulk load' if hfiles found and the WALPlayer if 'recovered.edits' found... it would then clean up the region directory on successful load after leaving audit so the 'orphan' was cleaned-up. hbck2 tool would run the adoption service at first. Once we had some experience and confidence that the adoption service was running smoothly, we'd consider integrating it into the catalogjanitor. The 'adoption service' first gets mention in the body of HBASE-21745" Filter out more invalid encoded name in isEncodedRegionName(byte[] regionName) ,13344650,Resolved,Major,Fixed,07/Dec/20 20:04,20/Jan/21 18:55,,"{code:java} public static boolean isEncodedRegionName(byte[] regionName) { // If not parseable as region name, presume encoded. TODO: add stringency; e.g. if hex. return parseRegionNameOrReturnNull(regionName) == null && regionName.length <= MD5_HEX_LENGTH; } Right now, if it passes in an table name, it still thinks it is a encoded region name and will result in unnecessary registry query for meta regions. This can be avoided if table names can be filtered out early in this method.{code}" [hbase-operator-tools] HBase metadata repair tool,13334137,Open,Major,,07/Oct/20 09:04,,hbase-operator-tools-1.1.0,"_HBCK2_ versions should be able to work across multiple hbase-2 releases. It will fail with a complaint if it is unable to run. There is no {{HbckService}} in versions of hbase before 2.0.3 and 2.1.1. _HBCK2_ will not work against these versions. When using HBase version 2.0.0 or 2.1.0 How to fix the metadata issue?  " [hbase-thirdparty] Update jersey version in hbase-thirdparty,13339703,Resolved,Major,Fixed,10/Nov/20 10:30,11/Nov/20 02:09,, [hbase-thirdparty] Bump dependencis in hbase-thirdparty,13339706,Resolved,Major,Fixed,10/Nov/20 10:36,11/Nov/20 02:11,, [hbase-thirdparty] Update jetty version in hbase-thirdparty,13339672,Resolved,Major,Fixed,10/Nov/20 07:36,10/Nov/20 10:15,,The master branch of hbase-thirdparty is on Jetty 9.4.31. The latest 9.4.x is Jetty 9.4.34. We should update to the latest. Undo meta replica specialization inside of the region replica framework,13340649,Resolved,Major,Fixed,14/Nov/20 16:37,31/Dec/21 14:59,,"Filing an issue to capture a [~zhangduo] suggestion made in PR that was then carried to a comment over in the design document attached to HBASE-18070 only it is deserving of its own issue. {quote}  I do not like that we have a specialized implementation for meta replica inside the region replica framework. They are almost the same so they should share the same code base. I think this enhancement could also be applied to normal RegionReplicaReplicationEndpoint, what we need is the config for the max distance between different secondary replicas. For normal region replicas, the value will be small, which means we will soon block the replication if any replicas are slow, to save memory. For meta replicas, we could have a large default value to let the good replicas catch up fast. {quote}   Lets use this issue to fill out more on what [~zhangduo] suggests above." Avoid the failed meta replica region temporarily in Load Balance mode,13343393,Reopened,Major,,30/Nov/20 19:37,,2.5.0,"This is a follow-up enhancement with Stack, Duo. With the newly introduced meta replica LoadBalance mode, if there is something wrong with one of meta replica regions, the current logic is that it keeps trying until the meta replica region is onlined again or it reports error, i.e, there is no HA at LoadBalance mode. HA can be implemented if it reports timeout with one meta replica region and tries another meta replica region." [Umbrella]Fast split regions and lightweight compaction with stripe store engine,13341322,Open,Major,,18/Nov/20 12:24,,3.0.0-alpha-2,"In our company MeiTuan, we have encountered a problem, that is a production cluster with about more than 10000 regions set off the split switch by some mistakes. And more than 10000 regions are larger than 600GB before we can do something to split them. Because online real time R+W QPS of each RS is higher than 80000 (8000+ per region), if we just switch on split, the IO pressure brought by compactions will influence the availabilities, and all large regions need repeatedly compactions until the size of child regions are normal. Different with the normal circumstances, we used stripe store engine in this cluster, after looking through docs of https://issues.apache.org/jira/browse/HBASE-7667 ,  we have implemented a fast split region method using the similar ideas of HFileLink and move store files between regions when compacting. Actually, this idea has already been mentioned in HBASE-7667 , it said that `region splits become marvelously simple (if we could move files between regions, no references would be needed)`. We have implemented the ideas and practiced them on that cluster. The fact results show that, a region of about 600G can  be splitted to  75G*8 regions in about five minutes, with less than 5G total rewrite size(all are L0) in the whole process, while normal continuous split needs 600G*3=1800G. By using movement of store files, the rewritten size is less than 50G(two stripe size, because the rebuild of HFileLinks to stripes may insert some files to L0.).I have attached two pictures about a RS before and after splitting all the regions using this method. This idea can not only be used in stripe store engine, but also default store engine, and the store movement methods are very benefit to region MERGE.  " Compress the surefire report for flaky tests jenkins job,13335987,Resolved,Major,Not A Problem,19/Oct/20 02:44,10/Oct/21 12:49,,"There is a TODO in it for compressing the report. Let's address it." Support AES-192 and AES-256 in DefaultCipherProvider,13341394,Open,Major,,18/Nov/20 16:58,,,"The DefaultCipherProvider currently supports AES-128. In some security policies (such as the Application Security and Development STIG), AES-256 is required in certain situations. I want to add AES-192 and AES-256 support. I quickly tried to implement this as part of HBASE-25263, but after 1-2 days I realized that it worths a separate task in Jira. The main challenge is that the key length and the algorithm needs to be decoupled in the code, and also some more tests need to be added to make sure we are backward-compatible and also supporting AES-192 and AES-256. Beside defining a new algorithm and key on the Java API, I also want to make the usage of e.g. AES-256 in the shell, like: {code:java} create 'test', {NAME => 'cf', ENCRYPTION => 'AES-256', ENCRYPTION_KEY => 'mysecret'} {code}   Also we should support AES-192 and AES-256 in master encryption keys. And we need to document how the users can configure / use it." Add trace support for HRegion read/write operation,13348447,Resolved,Major,Fixed,30/Dec/20 10:00,18/Jan/21 02:19,, Add trace support for connection registry,13348446,Resolved,Major,Fixed,30/Dec/20 09:59,01/Jan/21 15:04,, Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk,13347031,Resolved,Major,Fixed,20/Dec/20 14:47,24/Dec/20 10:37,,"According to the document of OpenTelemetry, for all the modules which could be depended by downstream users, we should only depend on opentelemetry-api. But the open telemetry propagator must be initialized programmatically, so we need to have a module to implement the code and introduce dependency on opentelemetry-sdk, and we need to call it before doing anything when starting master, regionserver, and so on." Add trace support for async call in rpc client,13346330,Resolved,Major,Fixed,16/Dec/20 10:27,23/Dec/20 03:52,,For verifying that OpenTelemetry can deal with async operations. Remove HTrace completely in code base and try to make use of OpenTelemetry,13344855,Resolved,Major,Fixed,08/Dec/20 14:56,16/Dec/20 09:55,, hbase.rsgroup.fallback.enable should support dynamic configuration ,13341021,Resolved,Major,Fixed,17/Nov/20 10:26,23/Nov/20 19:28,2.4.0,Use update_config command to control the switch of RSGroup fallback. [branch-1] Masters in-memory serverHoldings map is not cleared during hbck repair,13330260,Resolved,Major,Fixed,01/Oct/20 00:20,28/Jun/21 21:05,1.7.0,"{color:#1d1c1d}Incase of repairing overlaps, hbck  essentially calls the closeRegion RPC on RS followed by offline RPC on Master to offline all the overlap regions that would be merged into a new region. {color} {color:#1d1c1d}However the offline RPC doesn’t remove it from the serverHoldings map unless the new state is MERGED/SPLIT ([https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java#L719]) b{color}{color:#1d1c1d}ut the new state in this case is OFFLINE. {color} {color:#1d1c1d}This is actually intended to match with the META entries and would be removed later when the region is online on a different server. However, in our case , the region would never be online on a new server, hence the region info is never cleared from the map that is used by balancer and SCP for incorrect reeassignment.{color} {color:#1d1c1d}We might need to tackle this by removing the entries from the map when hbck actually deletes{color}{color:#1d1c1d} the meta entries for this region which kind of matches the in-memory map’s expectation with the META state.{color}" [HBOSS] TreeLockManager should log warnings about lock contention periodically,13342668,Resolved,Major,Fixed,25/Nov/20 17:50,30/Nov/20 15:10,hbase-filesystem-1.0.0-alpha1,"While performing some internal tests with hboss, [~psomogyi] noticed that *TreeLockManager* class logs too frequently when it is waiting on parent write lock. {noformat} 2020-10-26 17:35:41,719 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,720 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,721 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,723 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,724 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,725 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,726 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,728 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,729 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 2020-10-26 17:35:41,730 WARN org.apache.hadoop.hbase.oss.sync.TreeLockManager: Blocked waiting for some parent write lock, waiting: /s3a/hbase/hbase-dl/db1/hbase/data/default/test1/.tabledesc/.tableinfo.0000000001 {noformat} In 4 seconds on a single RegionServer this WARN was logged 1767 times. This modifies current logging logic, to calculate the time spent trying to acquire locks on individual nodes, then warning only given a configurable threshold is exhausted." Metrics recording a time duration should use System.nanoTime(),13330640,Open,Major,,02/Oct/20 22:07,,,I was looking around in our table metrics and noticed that scan time is collected using {{EnvironmentEdgeManager.currentTime()}}. This isn't a stable way to measure a duration of time on the jvm. We should convert all these occurrences to use {{TimeUnit.NANOSECONDS.toMillis(System.nanoTime())}} instead. Remove table on master related code in balancer implementation,13340776,Resolved,Major,Fixed,16/Nov/20 08:06,20/Apr/21 13:37,,This could be a start of the HBASE-15549 feature branch. Corrupted hfiles append timestamp every time the region is trying to open,13336241,Open,Major,,20/Oct/20 08:31,,,"When the RS crashed, we replay WALs to generate recover edits or HFile directly. If the replaying WAL RS crashed again, the file just writing to may be corrupted. In some cases, we may want to move on(e.g. in the case of sink to hfile as we have WAL and replaying the WAL again is OK), and move the file with extra timestamp as suffix.But if the region is opened again, the corrupted file can't be opened, and renamed with an extra timestamp again.After some round like this, the file name will be too long to rename.The log is like this: {code:java} org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.hdfs.protocol.FSLimitException$PathComponentTooLongException): The maximum path component name limit of 6537855 8b0444c27a9d21fb0f4e4293f.1602831270772.1602831291050.1602831296855.1602831408803.1602831493989.1602831584077.1602831600838.1602831659805.1602831736374.1602831738002.1 602831959867.1602831979707.1602832095288.1602832103908.1602832538224.1602833079431 in directory /hbase/XXX/data/default/IntegrationTestBigLinkedList/aa376ec f026a5e63d0703384e34ec6aa/meta/recovered.hfiles is exceeded: limit=255 length=256 at org.apache.hadoop.hdfs.server.namenode.FSDirectory.verifyMaxComponentLength(FSDirectory.java:1230) at org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.verifyFsLimitsForRename(FSDirRenameOp.java:98) at org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.unprotectedRenameTo(FSDirRenameOp.java:191) at org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.renameTo(FSDirRenameOp.java:493) at org.apache.hadoop.hdfs.server.namenode.FSDirRenameOp.renameToInt(FSDirRenameOp.java:62) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.renameTo(FSNamesystem.java:3080) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.rename(NameNodeRpcServer.java:1113) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.rename(ClientNamenodeProtocolServerSideTranslatorPB.java:665) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:523) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:916) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:862) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1716) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2742) at org.apache.hadoop.ipc.Client.call(Client.java:1504) at org.apache.hadoop.ipc.Client.call(Client.java:1435) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:232) at com.sun.proxy.$Proxy17.rename(Unknown Source) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.rename(ClientNamenodeProtocolTranslatorPB.java:504) at sun.reflect.GeneratedMethodAccessor45.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:249) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:107) at com.sun.proxy.$Proxy18.rename(Unknown Source) at sun.reflect.GeneratedMethodAccessor45.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:372) at com.sun.proxy.$Proxy21.rename(Unknown Source) at org.apache.hadoop.hdfs.DFSClient.rename(DFSClient.java:1996) at org.apache.hadoop.hdfs.DistributedFileSystem.rename(DistributedFileSystem.java:605) at org.apache.hadoop.fs.FilterFileSystem.rename(FilterFileSystem.java:226) {code} " Move RegionLocationFinder to hbase-balancer,13335322,Resolved,Major,Fixed,14/Oct/20 02:58,10/Apr/21 13:13,, [Upgrade]Incompatibility in reading RS report from 2.1 RS when Master is upgraded to a version containing HBASE-21406,13338398,Resolved,Major,Fixed,02/Nov/20 11:40,05/Nov/20 16:53,2.3.0,"While upgrading to a version having HBASE-21406 and following the upgrade process suggested in HBASE-21075, after Master is upgraded, the following exception is observed while reading the rs report from old region servers : {code:java} 2020-11-02 18:25:30,303 WARN [RS-EventLoopGroup-1-2] ipc.RpcServer: /x.x.x.x:16000 is unable to read call parameter from client x.x.x.x org.apache.hbase.thirdparty.com.google.protobuf.UninitializedMessageException: Message missing required fields: load.replLoadSink.timestampStarted, load.replLoadSink.totalOpsProcessed at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.newUninitializedMessageException(AbstractMessage.java:477) at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerReportRequest$Builder.build(RegionServerStatusProtos.java:2411) at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerReportRequest$Builder.build(RegionServerStatusProtos.java:2349) at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processRequest(ServerRpcConnection.java:654) at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processOneRpc(ServerRpcConnection.java:458) at org.apache.hadoop.hbase.ipc.ServerRpcConnection.saslReadAndProcess(ServerRpcConnection.java:351) at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:92) at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:68) at org.apache.hadoop.hbase.ipc.NettyRpcServerRequestDecoder.channelRead(NettyRpcServerRequestDecoder.java:62) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:321) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:295) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:792) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:475) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748){code} A similar exception is observed when running *status 'replication'* command using old client (2.1.x)." [branch-2.2] Fix the ruby problem for pre-commit,13347088,Resolved,Major,Fixed,21/Dec/20 07:09,11/Apr/21 09:10,2.2.6,*00:33:07* ERROR: Error installing rubocop:*00:33:07* parallel requires Ruby version >= 2.4.*00:33:08* Successfully installed jaro_winkler-1.5.4 Optionally abort requests in progress after deciding a region should close,13336605,Resolved,Major,Fixed,22/Oct/20 00:44,03/Nov/20 23:25,,"After deciding a region should be closed, the regionserver will set the internal region state to closing and wait for all pending requests to complete, via a rendezvous on the region lock. In closing state the region will not accept any new requests but requests in progress will be allowed to complete before the close action takes place. In our production we see outlier wait times on this lock in excess of several minutes. During close when there are requests in flight the regionserver is subject to any conceivable reason for delay, like full scans over large regions, expensive filtering hierarchies, bugs, or store level performance problems like slow HDFS. The regionserver should interrupt requests in progress to facilitate smaller/shorter close times on an opt-in basis. Optionally, via configuration parameter -- which would be a system wide default set in hbase-site.xml in common practice but could be overridden in table schema for per table settings -- interrupt requests in progress holding the region lock rather than wait for completion of all operations in flight. Send back NotServingRegionException(""region is closing"") to the clients of the interrupted operations, like we do after the write lock is acquired. The client will transparently relocate the region data and resubmit the aborted requests per normal retry policy. This can be less disruptive than waiting for very long times for a region to close in extreme outlier cases (e.g. 50 minutes). In such extreme cases it is better to abort the regionserver if the close lock cannot be acquired in a reasonable amount of time, because the region cannot be made available again until it has closed. After waiting for all requests to complete then we flush the region's memstore and finish the close. The flush portion of the close process is out of scope of this proposal. Under normal conditions the flush portion of the close completes quickly. It is specifically waits on the close lock that has been an occasional issue in our production that causes difficulty achieving 99.99% availability." Remove deprecated fields in HConstants which should be removed in 3.0.0,13334790,Resolved,Major,Fixed,10/Oct/20 09:55,03/Apr/21 15:15,, [branch-1] Fix the broken pre-commit,13341791,Resolved,Major,Fixed,20/Nov/20 13:08,21/Nov/20 07:20,,"{code} Archive JUnit-formatted test results [2020-11-20T02:58:50.501Z] Recording test results [2020-11-20T02:58:50.641Z] No test report files were found. Configuration error? {code} branch-1's pre-commit keeps failing with error above, we need to fix it." Update reporter tool with new release,13346850,Resolved,Major,Fixed,18/Dec/20 18:34,23/Jan/21 10:00,,Reporter tool: [https://reporter.apache.org/addrelease.html?hbase] "Backport HBASE-24776 ""[hbtop] Support Batch mode"" to branch-1",13339458,Resolved,Major,Fixed,09/Nov/20 08:28,20/Mar/21 02:18,,Backport parent issue to branch-1. Rack awareness in region_mover,13336503,Resolved,Major,Fixed,21/Oct/20 15:17,12/Jan/21 23:57,,"region_mover should provide an option to ensure while unloading all regions, all destination servers are selected from different racks and not the one where server (where region_mover unload is getting executed) belongs to. This might be helpful option if we want to avail rack downtime (or rack upgrade) by stopping all Regionservers that belong to same rack for few hours. Without this option, we don't have any control over which destination server is selected and hence, some regions might keep bouncing from server A to B in the same rack all the way until they are finally moved to RS that belongs to separate rack." Move more balancer related classes to hbase-balancer,13335319,Resolved,Major,Invalid,14/Oct/20 02:50,09/Mar/21 06:31,, Make ModifyTableProcedure support changing meta replica count,13334192,Resolved,Major,Fixed,07/Oct/20 13:46,13/Oct/20 02:15,,And also make it compatible with the old way where we use a Configuration to set the replica number. Sort broken after Change 'State time' in UI,13344609,Resolved,Major,Fixed,07/Dec/20 15:52,03/Mar/21 08:33,,"Sort broken after Change 'State time' in UI: Looks like jquery tablesorter unable to parse the iso8601 date format hence not sorting. We might need to add parser-date-iso8601.min.js to support sorting of iso8601 date format." There is no limit on the column family length when creating a table,13346969,Resolved,Major,Fixed,20/Dec/20 00:58,03/Mar/21 06:48,2.2.3,"Table can be created successfully when the length of column family is larger than 127 bytes,however,it occurs exception when putting data into the table(ERROR：Family > 127). So,We decide to verify the length of column family when creating a table.IllegalArgumentException will be thrown when length is larger than 127 bytes." "When openRegion fails during initial verification(before initializing and setting seq num), exception is observed during region close.",13344721,Resolved,Major,Fixed,08/Dec/20 05:29,03/Mar/21 00:36,2.2.3,"When openRegion fails during initial verification(before initializing and setting seq num), exception is observed during region close:   2020-12-03 16:34:47,133 ERROR [RS_OPEN_REGION-regionserver/AAAAAAAAAA:16040-0] handler.OpenRegionHandler: Failed open of region=ns2:testtable4,00000000000000000000150000,1606912406234.cd386135276b7d3c57416df3666e4aea.2020-12-03 16:34:47,133 ERROR [RS_OPEN_REGION-regionserver/blrphispra01054:16040-0] handler.OpenRegionHandler: Failed open of region=ns2:testtable4,00000000000000000000150000,1606912406234.cd386135276b7d3c57416df3666e4aea.java.io.IOException: The new max sequence id 1 is less than the old max sequence id 7134 at org.apache.hadoop.hbase.wal.WALSplitUtil.writeRegionSequenceIdFile(WALSplitUtil.java:418) at org.apache.hadoop.hbase.regionserver.HRegion.writeRegionCloseMarker(HRegion.java:1253) at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1793) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1606) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1552) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7522) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7467) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7439) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7397) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7348) at org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:286) at org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:111) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)  " TagRewriteCell's getSerializedSize() method gets the size wrong,13345626,Open,Major,,12/Dec/20 03:12,,3.0.0-alpha-1,"We found that the serialized size of Cell is inconsistent with the size actually written to ByteBuffer when the tag is empty. {code:java} Cell originalCell = ExtendedCellBuilderFactory.create(CellBuilderType.DEEP_COPY) .setRow(Bytes.toBytes(""row"")) .setFamily(Bytes.toBytes(""family"")) .setQualifier(Bytes.toBytes(""qualifier"")) .setTimestamp(HConstants.LATEST_TIMESTAMP) .setType(KeyValue.Type.Maximum.getCode()) .setValue(Bytes.toBytes(""value"")) .build(); ByteBuffer byteBuffer = ByteBuffer.allocate(100); Cell cell = PrivateCellUtil.createCell(originalCell, """".getBytes()); int lengthWritten = KeyValueUtil.appendTo(cell, byteBuffer, 0, true); System.out.println(""Cell serializedSize: "" + cell.getSerializedSize()); System.out.println(""Bytes written to ByteBuffer: "" + lengthWritten); ByteArrayOutputStream output = new ByteArrayOutputStream(100); PrivateCellUtil.writeCell(cell, output, true); System.out.println(""Bytes written to OutputStream: "" + output.size()); {code} Run the above code to see the following output   {code:java} Cell serializedSize: 45 Bytes written to ByteBuffer: 43 Bytes written to OutputStream: 45 {code}    " [HBCK2] Regenerate missing table descriptors by hbck2,13340990,Resolved,Major,Fixed,17/Nov/20 07:51,21/Dec/20 12:52,hbase-operator-tools-1.0.0,"We just have been in a situation, when we saw many ServerCrashProcedure to be blocked, because of the AssignProcedure is blocked because of the missing .tabledesc files. {code:java} java.io.IOException: Missing table descriptor for dd0676f57bdbff5d04ab735b7daf5e9b {code}   In our case it was OK for us to get rid of these tables and we were able to use {{setRegionState}} to move all these regions to {{FAILED_OPEN}} state, then disable and drop the tables. But this took a lot of time and we might not always have the option to drop these tables. HBCK 1 had a functionality (\{{fixTableOrphans}}) to regenerate the table descriptors ""according to the memory cache or hdfs table directory structure"". We should investigate if we can implement something like this with hbck2. We might not always be able to reproduce the table configurations, but we can probably make a ""basic"" one." MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number,13347243,Resolved,Major,Fixed,22/Dec/20 03:55,15/Jan/21 06:04,2.4.0,"Before create or alter table, we will do sanityCheck in TableDescriptorChecker. If MAX_FILESIZE or MEMSTORE_FLUSHSIZE < 0, use maxFileSizeLowerLimit or flushSizeLowerLimit instead to pass check. But the real value in TableDescriptor is still < 0, and we can see negative values ​​on the UI. However in flush and split logic, MAX_FILESIZE and MEMSTORE_FLUSHSIZE will judge whether it's value <= 0 , if true, change to default value. This does not affect flush and split. !image-2020-12-22-11-46-38-967.png!" Migrate HBase-Thirdparty-PreCommit jenkins job from Hadoop to hbase,13330337,Resolved,Major,Fixed,01/Oct/20 11:01,02/Oct/20 09:47,, HBase doesn't update and remove the peer config from hbase.replication.source.custom.walentryfilters if the config is already set on the peer. ,13345378,Resolved,Major,Fixed,10/Dec/20 20:48,22/Dec/20 10:08,,"Currently, we cannot update the peer-based config even if we change the value of the config. Secondly, once the configuration is added, there is no smooth way to remove the peer config. " Adding StoreContext,13339083,Resolved,Major,Fixed,05/Nov/20 19:55,14/Jan/21 18:57,2.3.4,Adding StoreContext which contains the metadata about the HStore. This meta data can be used across the HFileWriter/Readers and other HStore consumers without the need of passing around the complete store and exposing its internals. This is a refactoring change which cleans up the existing code so that the following commits can leverage the context for a more maintainable code. [hbase-operator-tools] Add a repair tool for moving stale regions dir not present in meta away from table dir,13339758,Resolved,Major,Fixed,10/Nov/20 13:48,25/Jan/21 18:20,hbase-operator-tools-1.0.0,"This adds a new tool under *hbase-tools* module, that allows for moving aways regions dirs existing under table's hdfs dir, but not in meta. This is useful in cases where the region is not present in meta, but still has data on hdfs, yet no holes in the table region chain is detected. On such cases, the existing *HBCK2 addFsRegionsMissingInMeta* command isn't ideal, as it would bring the region back in meta and cause overlaps. This tool performs the following actions: 1) Identifies regions in hdfs but not in meta using *HBCK2.reportTablesWithMissingRegionsInMeta*; 2) For each of these regions, sidelines the related dir to a temp folder; 3) Bulkload hfiles from each sidelined region to the related table; Sidelined regions are never removed from temp folder. Operators should remove those manually, after they certified on data integrity. " Release 2.3.4,13346845,Resolved,Major,Fixed,18/Dec/20 18:34,25/Jan/21 20:37,, Send announce email,13346853,Resolved,Major,Fixed,18/Dec/20 18:34,24/Jan/21 20:49,, Release version 2.3.4 in Jira,13346848,Resolved,Major,Fixed,18/Dec/20 18:34,22/Jan/21 23:42,, Spin RCs,13346846,Resolved,Major,Fixed,18/Dec/20 18:34,22/Jan/21 22:51,, """Release"" staged nexus repository",13346847,Resolved,Major,Fixed,18/Dec/20 18:34,22/Jan/21 22:50,, Promote 2.3.4 RC artifacts in svn,13346849,Resolved,Major,Fixed,18/Dec/20 18:34,22/Jan/21 22:50,, Push signed release tag,13346851,Resolved,Major,Fixed,18/Dec/20 18:34,22/Jan/21 22:48,, Add trace support for scan operation,13348445,Open,Major,,30/Dec/20 09:59,,, Run a correctness test with ITBLL,13346855,Resolved,Major,Fixed,18/Dec/20 18:43,16/Jan/21 17:35,, Add BYTE unit in PrettyPrinter.Unit ,13347520,Resolved,Major,Fixed,23/Dec/20 08:16,15/Jan/21 05:50,3.0.0-alpha-1,"Currently only TTL supports PrettyPrinter, and MAX_FILESIZE is not human readable： !image-2020-12-23-16-12-42-210.png! This issue add a new unit 'BYTE' to pretty print value of size, such as MAX_FILESIZE, MEMSTORE_FLUSHSIZE.   " Provide a VM-based release environment,13344899,Resolved,Major,Fixed,08/Dec/20 18:58,14/Jan/21 19:24,3.0.0-alpha-1,"In order to make running releases more smooth and ""clean-room"" on my macOS dev machine, I put together a Vagrant environment for running release builds. In particular, docker IO on macOS is terribly slow, so slow that going through the virtualization kernel extensions is an accelerant. Of course, YMMV. I've used this on all of the 2.3.x release I've done. Maybe other RMs like it, maybe they don't. I'll post up a patch as a point of reference." HBaseAdmin#getRegion() needs to filter out non-regionName and non-encodedRegionName,13344088,Resolved,Major,Fixed,03/Dec/20 19:30,14/Jan/21 17:50,2.3.3,"I was running shell command to major compact meta table. The implementation is wrong because it tries to search the meta table with meta table name. This also results in an unnecessary scan of meta table.    majorCompactRegion() is calling HBaseAdmin#getRegion() which basically scan meta table itself. This command is being used by operator quite often, we need to correct it.   This applies to split/flush command as well, which calls getRegion() with tableName as an input.   The solution is that getRegion() needs to filter out non-regionName and non-encodedRegionName, this will save a query of meta table and a heavy scan of meta table. If meta table size is large, the overhead is huge." SlowDelete & SlowPut metric value should use updateDelete & updatePut ,13347280,Resolved,Major,Fixed,22/Dec/20 06:46,08/Jan/21 12:23,," !image-2020-12-22-14-44-26-030.png! SlowDelete & SlowPut metric value should use updateDelete & updatePut API like this !image-2020-12-22-14-45-48-727.png! " Add maven enforcer rule to ban VisibleForTesting imports,13342743,Resolved,Major,Fixed,26/Nov/20 03:02,09/Jan/21 08:41,,"https://github.com/google/error-prone/blob/master/annotations/src/main/java/com/google/errorprone/annotations/RestrictedApi.java This is a better choice if you want to restrict the usage of a special API." Mark all meta znode related methods as deprecated,13335426,Open,Major,,14/Oct/20 14:15,,,We still need this method for backward compatility so let's mark them as deprecated first remoteProc is suspended due to OOM ERROR,13347910,Resolved,Major,Fixed,26/Dec/20 03:49,06/Jan/21 18:27,2.2.3,"https://github.com/apache/hbase/blob/0f868da05d7ffabe4512a0cae110ed097b033ebf/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L317 If resource leakage occurs due to other components or reasons, BufferNode#dispatch() may fail. and then TimeoutExecutorThread will exit the while (running.get()), and some procs will stuck... !image-2020-12-26-11-49-38-018.png! " Forgetting to unbuffer streams results in many CLOSE_WAIT sockets when loading files,13340764,Resolved,Major,Fixed,16/Nov/20 06:48,06/Jan/21 18:55,2.4.0,"HBASE-9393 found seek+read will leave many CLOSE_WAIT sockets without stream unbuffer, which can free sockets and file descriptors held by the stream.  In our cluster RSes with about one hundred thousand store files, we found the number of  CLOSE_WAIT sockets increases with the number of regions opened, and can up to the operating system open files limit 1000000.   {code:java} 2020-11-12 20:19:02,452 WARN  [1282990092@qtp-220038608-1 - Acceptor0 SelectChannelConnector@0.0.0.0:16030] mortbay.log: EXCEPTION java.io.IOException: Too many open files         at sun.nio.ch.ServerSocketChannelImpl.accept0(Native Method)         at sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:422)         at sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:250)         at org.mortbay.jetty.nio.SelectChannelConnector$1.acceptChannel(SelectChannelConnector.java:75)         at org.mortbay.io.nio.SelectorManager$SelectSet.doSelect(SelectorManager.java:686)         at org.mortbay.io.nio.SelectorManager.doSelect(SelectorManager.java:192)         at org.mortbay.jetty.nio.SelectChannelConnector.accept(SelectChannelConnector.java:124)         at org.mortbay.jetty.AbstractConnector$Acceptor.run(AbstractConnector.java:708)         at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582) {code}   {code:java} [hbase@gha-data-hbase-cat0053 hbase]$ ulimit -SHn 1000000 {code}     The reason of the problem is, when store file opened,  {code:java} private void open() throws IOException { fileInfo.initHDFSBlocksDistribution(); long readahead = fileInfo.isNoReadahead() ? 0L : -1L; ReaderContext context = fileInfo.createReaderContext(false, readahead, ReaderType.PREAD); fileInfo.initHFileInfo(context); StoreFileReader reader = fileInfo.preStoreFileReaderOpen(context, cacheConf); if (reader == null) { reader = fileInfo.createReader(context, cacheConf); fileInfo.getHFileInfo().initMetaAndIndex(reader.getHFileReader()); } ....{code} only createReader() unbuffered the stream. In initMetaAndIndex(), using the stream to read blocks, so it needs to unbuffer() the socket , too. We can just add try before fileInfo.initHFileInfo(context); and finally unbuffer() the stream at the end of the open() function. We fixed it on our cluster, the number of CLOSE_WAIT reduced to about 0.     " public static method MultiTableHFileOutputFormat.configureIncrementalLoad actually cannot be invoked outside hbase package,13347856,Open,Major,,25/Dec/20 09:14,,2.4.0,"*MultiTableHFileOutputFormat* provides a public static method _configureIncrementalLoad_ to configure reducer for multi table hfile output.  See this. [https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/MultiTableHFileOutputFormat.java#L92] However the *TableInfo* in the parameter is NOT a public class, which makes it impossible to invoke *MultiTableHFileOutputFormat*._configureIncrementalLoad_ in other project.  Is there any alternative for the use case? For now I have to create another class in +org.apache.hadoop.hbase.mapreduce+ package to invoke the *MultiTableHFileOutputFormat*._configureIncrementalLoad._" Upgrade error prone to 2.4.0,13343322,Resolved,Major,Fixed,30/Nov/20 14:15,07/Jan/21 02:00,, Backport HBASE-25287 to branch-1,13346437,Resolved,Major,Fixed,16/Dec/20 21:27,06/Jan/21 21:21,, "The parameter ""hbase.bucketcache.size"" is misdescribed",13348098,Resolved,Major,Fixed,28/Dec/20 09:54,03/Jan/21 17:30,2.0.0,"You can see that the description of this configuration is outdated {quote} hbase.bucketcache.size A float that EITHER represents a percentage of total heap memory size to give to the cache (if < 1.0) OR, it is the total capacity in megabytes of BucketCache. Default: 0.0 {quote} !image-2020-12-28-17-53-32-575.png!  " Update refguide RC section; point at the dev-tools/create-releases/README.txt rather than repeat its content,13347441,Resolved,Major,Fixed,22/Dec/20 21:06,02/Jan/21 19:35,,Edit of the RC-making section of the refguide. Upgrade commons-io to 2.8.0,13348214,Resolved,Major,Fixed,29/Dec/20 03:28,31/Dec/20 09:44,,And remove the deprecated closeQuietly method reference in our code base. Use MatcherAssert.assertThat instead of org.junit.Assert.assertThat,13348215,Resolved,Major,Fixed,29/Dec/20 03:29,30/Dec/20 03:31,,The latter one has been deprecated after upgrading to junit 4.13. Add a filter with containing semantic,13347812,Open,Major,,25/Dec/20 03:35,,3.0.0-alpha-1,"Say we want to check whether a cell value is within a set of values. If the size of the set is 1000, we need to create 1000 SingleColumnValueFilter with CompareOperator.EQUAL and wrap them with a FilterListWithOR. The scan performance of these filters would be very bad. But if we have a set filter, we just need to create only one filter with 1000 values.  And the containing operation could be implemented as O(1) or O(log( n )). This `SetFilter` is general and useful in my opinion, so would the community consider to implement a `SetFilter`?" create-release fails download of artifacts on gcp,13347651,Open,Major,,23/Dec/20 21:14,,,"Noticed this running test release-candidate builds up on gcp. The build fails as we fail to download artifacts (""Connection reset""). For example: {code} 2020-12-23T16:49:05Z Command FAILED. Check full logs for details. 16:49:05 [ERROR] Failed to execute goal on project hbase-metrics: Could not resolve dependencies for project org.apache.hbase:hbase-metrics:jar:2.4.1-rm_test_gcp: Failed to collect dependencies at io.dropwizard.metrics:metrics-core:jar:3.2.6: Failed to read artifact descriptor for io.dropwizard.metrics:metrics-core:jar:3.2.6: Could not transfer artifact io.dropwizard.metrics:metrics-core:pom:3.2.6 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/io/dropwizard/metrics/metrics-core/3.2.6/metrics-core-3.2.6.pom: Connection reset -> [Help 1] {code} If I rerun, we usually move beyond the above but might fail later on another artifact. HBASE-25438 updates the mvn used building to 3.6.3 which is supposed to have a better wagon plugin but it doesn't seem to help (I tried turning off wagon pooling and upping retries but probably no good when the connection reset) This looks related... trying it. https://stackoverflow.com/questions/65349648/why-does-my-maven-dependency-fetching-fail-with-a-connection-reset-when-running I'm on debian when above happens: " "After droped the table, using snapshot recovery to cause data consistency problems",13347105,Resolved,Major,Duplicate,21/Dec/20 08:57,22/Dec/20 08:51,,"We discovered a consistency problem during use HBase. The cause of the problem should be that after the table is dropped, when the snapshot is restored, in some cases the wal log will be applied, thereby the wal log of the dropped table restored to the restored table, because their region id are the same. Steps to reproduce 1. Create a tablea 2. Make a snapshot1 3. Insert some records r1 4. Drop the table 5. Restore snapshot 1 6. Down RS or move the region, etc., wal is reapplied You may see the data r1 in the snapshot1 table. The problem is not a stable recurrence, but there is a certain probability that it can recur." Backport HBASE-25383 to branch-1,13347297,In Progress,Major,,22/Dec/20 08:00,,, Refresh in-memory table-info cache in HBase,13347148,Open,Major,,21/Dec/20 13:34,,,"In HBASE-25297 we intorduced the feature in hbck2 to fix orphan tables by generating the missing .tableinfo file. If the table descriptor can not be found in the tableinfo cache of the master, then hbck2 will generate a new file with default table configurations. In this case hbck2 could re-trigger a refresh of the in-memory table info cache of the master node. We would need to add a new master RPC API to refresh the cache for a given table. Alternatively we should also test if a table disable / enable would do the same." Remove deprecated methods in RpcServer implementation,13346916,Resolved,Major,Fixed,19/Dec/20 11:44,20/Dec/20 04:01,, "After droped the table, using snapshot recovery to cause data consistency problems",13347092,Open,Major,,21/Dec/20 07:30,,,"We discovered a consistency problem during use HBase. The cause of the problem should be that after the table is dropped, when the snapshot is restored, in some cases the wal log will be applied, thereby the wal log of the dropped table restored to the restored table, because their region id are the same. Steps to reproduce: 1. Create a table 2. Make a snapshot1 3. Insert some records r1 4. Drop the table 5. Restore snapshot 1 6. Down RS or move the region, etc., wal is reapplied You may see the data r1 in the snapshot1 table. The problem is not a stable recurrence, but there is a certain probability that it can recur.   it looks like the problem: https://issues.apache.org/jira/browse/HBASE-23741 It will still appear after we apply the relevant patch  " [branch-2.2] Fix the ruby problem for pre-commit,13347087,Resolved,Major,Duplicate,21/Dec/20 07:07,21/Dec/20 07:26,2.2.6,*00:33:07* ERROR: Error installing rubocop:*00:33:07* parallel requires Ruby version >= 2.4.*00:33:08* Successfully installed jaro_winkler-1.5.4 Backup/Restore hbase cell tags.,13338877,Resolved,Major,Fixed,04/Nov/20 17:51,17/Dec/20 07:43,,"In PHOENIX-6213 we are planning to add cell tags for Delete mutations. After having a discussion with hbase community via dev mailing thread, it was decided that we will pass the tags via an attribute in Mutation object and persist them to hbase via phoenix co-processor. The intention of PHOENIX-6213 is to store metadata in Delete marker so that while running Restore tool we can selectively restore certain Delete markers and ignore others. For that to happen we need to persist these tags in Backup and retrieve them in Restore MR jobs (Import/Export tool). Currently we don't persist the tags in Backup. " TestRSGroupsFallback.testFallback is flaky,13342811,Resolved,Major,Fixed,26/Nov/20 10:54,16/Dec/20 21:25,,"Like in CI test results of PR [https://github.com/apache/hbase/pull/2699] failed UTs site is [https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2699/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt]   In this unit test, it checks if all table regions assigned after balance, and then assert for the RS group of regions. But balance() uses aync move, and will throttle move regions, sleeping between all the table regions are moved to its RSGroup. If waiting time is not longer than the region movement duration, the assertion will be fail." [Flakey Tests] branch-2 TestRegionMoveAndAbandon,13346249,Resolved,Major,Fixed,16/Dec/20 04:58,16/Dec/20 18:40,,Looks to be same as 'HBASE-25389 [Flakey Tests] branch-2 TestMetaShutdownHandler (#2773)' One-liner seems to shut this flakey down (I'm running unit tests locally.. it has failed a few times on me). Cookie and Referrer policy vulnerabilities reported by scanner tool,13346393,Open,Major,,16/Dec/20 17:02,,,"Vulnerability scanner has reported the following: 1.Cookies with missing, inconsistent or contradictory properties i)cookie without SameSite attribute * https://:/region.jsp Remediation: To ensure that the cookies configuration complies with the applicable standards, Setting Same-Site attribute to Set-Cookie HTTP response header Plan: Make Same-Site Configurable   2.Insecure Referrer Policy URLs where Referrer policy configuration is insecure: * https://:/rs-status * https://:/region.jsp * https://:/ * https://:/conf * https://:/logLevel * https://:/logs/ Remediation: Consider setting Referrer-Policy header to 'strict-origin-when-cross-origin' or a stricter value Plan: Make Referrer-Policy header Configurable." [Flakey Tests] branch-2 TestMetaShutdownHandler,13345706,Resolved,Major,Fixed,12/Dec/20 21:42,15/Dec/20 17:54,,"I see this in local runs fail regularly. We kill the server hosting meta and then check it came up in a new location after waiting on recovery. In the test, when it fails, the assert on new location fails because we have not waited for the CRASH to happen. Here is excerpt from log: {code} 2020-12-11 13:20:27,298 INFO [Listener at localhost/62149] master.TestMetaShutdownHandler(111): Deleted the znode for the RegionServer hosting hbase:meta; waiting on SSH ... 2020-12-11 13:20:27,310 INFO [Listener at localhost/62149] master.TestMetaShutdownHandler(122): Past wait on RIT ... 2020-12-11 13:20:27,351 DEBUG [RegionServerTracker-0] procedure2.ProcedureExecutor(1048): Stored pid=9, state=RUNNABLE:SERVER_CRASH_START; ServerCrashProcedure stack.XXX.example.com,62201,1607721618377, splitWal=true, meta=true {code} The first line is where we remove the ephemeral node for the regionserver carrying hbase:meta. The second line is supposed to log AFTER SCP is done (it calls it SSH in this old test above). Notice how the 3rd line, after the 2nd, is first mention of SCP being queued." [Flakey Tests] branch-2 TestShadedHBaseTestingUtility,13346446,Open,Major,,16/Dec/20 22:11,,,"Odd. TestShadedHBaseTestingUtility fails reliably if run with lots of concurrency; when I run on its own, its fine. Failure says: {code} java.io.IOException: Shutting down at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterMultiple exceptions at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: java.io.IOException: Problem starting http server at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException: Multiple exceptions at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) Caused by: java.lang.NoSuchMethodError: javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter; at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) {code} In test run log, I see this kinda stuff: {code} 2020-12-16 13:14:57,649 INFO [Listener at localhost/52473] http.HttpServer (HttpServer.java:openListeners(1137)) - Jetty bound to port 52491 2020-12-16 13:14:57,654 INFO [Listener at localhost/52473] server.Server (Server.java:doStart(375)) - jetty-9.4.34.v20201102; built: 2020-11-02T14:15:39.302Z; git: e46af88704a893fc12cb0e3bf46e2c7b48a009e7; jvm 1.8.0_102-b14 2020-12-16 13:14:57,765 INFO [Listener at localhost/52473] http.HttpServer (HttpServer.java:start(1083)) - HttpServer.start() threw a MultiException MultiException[java.lang.NoSuchMethodError: javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;, java.lang.NoSuchMethodError: javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/ servlet/Filter;, java.lang.NoSuchMethodError: javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;, java.lang.NoSuchMethodError: javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/ servlet/Filter;] at org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException.ifExceptionThrow(MultiException.java:122) at org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.doStart(Server.java:413) at org.apache.hbase.thirdparty.org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1078) at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:150) at org.apache.hadoop.hbase.regionserver.HRegionServer.putUpWebUI(HRegionServer.java:2200) at org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:687) at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:414) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:132) at org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:239) at org.apache.hadoop.hbase.LocalHBaseCluster.(LocalHBaseCluster.java:181) at org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:245) at org.apache.hadoop.hbase.MiniHBaseCluster.(MiniHBaseCluster.java:115) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1177) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1140) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1104) at org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:745) Suppressed: java.lang.NoSuchMethodError: javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter; .... {code} Our [~ndimiduk] ran into same issue when testing w/ hbase-downstreamer... (reported to me offlist). " [Flakey Tests] branch-2 TestShutdownBackupMaster,13343916,Resolved,Major,Fixed,03/Dec/20 06:21,05/Dec/20 22:26,2.4.0,"Making this as a sub-issue of parent issue which fails similar to how we are failing now. Currently, I see that that TestShutdownBackupMaster test passes usually but it is warped in how it completes. It will do all retries just before the test timesout at 13minutes max...: e.g. you'll see this... 2020-12-02 22:07:34,200 DEBUG [master/stack:0:becomeActiveMaster] client.ConnectionImplementation(1009): locateRegionInMeta parentTable='hbase:meta', attempt=44 of 46 failed; retrying after sleep of 46 ... so we'll do all the retries and then complete so the test looks like it 'succeeded' but it actually ran for Total time: 12:41 min... and the log is full of thread dumps because the cluster won't go down (The time is spent in the test shutdown). Often though, we won't complete the retries in time and the test fails. It is in the flakey list. Rather, we are supposed to fail out fast when we are shutting down. Below is the type of retry we see.   {code:java} 2020-12-02 10:53:35,540 INFO [Listener at localhost/61609] util.JVMClusterUtil(348): Shutdown of 2 master(s) and 2 regionserver(s) complete 2020-12-02 10:53:35,548 DEBUG [master/stack:0:becomeActiveMaster] client.ConnectionImplementation(1009): locateRegionInMeta parentTable='hbase:meta', attempt=2 of 46 failed; retrying after sleep of 46 org.apache.hadoop.hbase.DoNotRetryIOException: hconnection-0x1afa7f5b closed at org.apache.hadoop.hbase.client.ConnectionImplementation.checkClosed(ConnectionImplementation.java:630) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegion(ConnectionImplementation.java:815) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.locateRegion(ConnectionUtils.java:138) at org.apache.hadoop.hbase.client.ConnectionImplementation.relocateRegion(ConnectionImplementation.java:803) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.relocateRegion(ConnectionUtils.java:138) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegionInMeta(ConnectionImplementation.java:933) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegion(ConnectionImplementation.java:823) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.locateRegion(ConnectionUtils.java:138) at org.apache.hadoop.hbase.client.HRegionLocator.getRegionLocation(HRegionLocator.java:64) at org.apache.hadoop.hbase.client.RegionLocator.getRegionLocation(RegionLocator.java:70) at org.apache.hadoop.hbase.client.RegionLocator.getRegionLocation(RegionLocator.java:59) at org.apache.hadoop.hbase.client.RegionServerCallable.prepare(RegionServerCallable.java:223) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:105) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:383) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:357) at org.apache.hadoop.hbase.master.TableNamespaceManager.get(TableNamespaceManager.java:141) at org.apache.hadoop.hbase.master.TableNamespaceManager.isTableAvailableAndInitialized(TableNamespaceManager.java:278) at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:103) at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:63) at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:249) at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1224) at org.apache.hadoop.hbase.master.TestShutdownBackupMaster$MockHMaster.initClusterSchemaService(TestShutdownBackupMaster.java:68) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1021) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2082) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:506){code} See how a master is trying to become active and it won't relent trying to become active master even though this cluster is shutting down? See how we retry but the check for close of the connection is coming back with a DoNotRetryIOException? The exception is being swallowed. We keep going. Fix looks simple enough.      " Update create-release scripts; rotted,13343917,Resolved,Major,Fixed,03/Dec/20 06:27,04/Dec/20 17:11,,"A few things noticed when trying to run them just now:  * Some of the packages referenced are no longer available (the jdk and the gpg).  * Some stuff that was checked in to test gpg works only makes sense in non-docker context" CopyTable and Coprocessor based export tool should backup and restore cell tags.,13345707,Open,Major,,12/Dec/20 22:23,,,"In HBASE-25246 we added support for Mapreduce based Export/Import tool to backup/restore cell tags. Mapreduce based export tool is not the only tool that takes snapshot or backup of a given table. We also have Coprocessor based Export and CopyTable tools which takes backup of a given table. We need to add support for the above 2 tools to save cell tags to file." RegionServer ignored a procedure (closeRegionProcedure) due to duplicate pid which lead region to stuck in RIT.,13345304,Resolved,Major,Won't Fix,10/Dec/20 13:56,14/Dec/20 09:53,2.2.3,"Analysis: 1. After Hmaster failover, master in-memory proc-id was reset. 2. Upon new DisableTable client request, Master dispatched a closeRegionProcedure to RS and suspended the proc. 3. But RS ignored the current CloseRegionProcedure request without doing anything since RS had already executed a procedure with same id. Since no UnAssignRegionHandler was created at Step-3, so RS did not send any reportRegionStateTransition to HM. And at HMaster side the procedure remain in suspended state because we awake the suspended procedure on reportRegionStateTransition. So region stuck in RIT forever until unless we restart HM or RS.   Observed following log RS side while trying to disable table 't2': {code:java} 2020-12-08 10:18:23,216 | WARN | RpcServer.priority.RWQ.Fifo.read.handler=164,queue=2,port=21302 | Received procedure pid=13, which already executed, just ignore it | org.apache.hadoop.hbase.regionserver.HRegionServer.submitRegionProcedure(HRegionServer.java:4146){code} This pid=13 was already used by RS for opening hbase:namespace: {code:java} 2020-12-08 10:11:40,793 | INFO | RS_OPEN_PRIORITY_REGION-regionserver/a.b.c.d:efg-0 | Post open deploy tasks for hbase:namespace,,1607152197100.cffc166aa75ee4ddf8a210ca02da1ea1., pid=13, masterSystemTime=1607393499851 | org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2422){code} So the region of table='t2' was stuck in RIT because the closeRegionProcedure was stuck master side indefinitely: {code:java} 2020-12-08 10:18:23,039 | INFO | PEWorker-15 | Updated tableName=t2, state=DISABLING in hbase:meta | org.apache.hadoop.hbase.MetaTableAccessor.updateTableState(MetaTableAccessor.java:1770) 2020-12-08 10:18:23,040 | INFO | PEWorker-15 | Set t2 to state=DISABLING | org.apache.hadoop.hbase.master.procedure.DisableTableProcedure.setTableStateToDisabling(DisableTableProcedure.java:296) 2020-12-08 10:18:23,042 | INFO | PEWorker-15 | Initialized subprocedures=[{pid=12, ppid=11, state=RUNNABLE:REGION_STATE_TRANSITION_CLOSE; TransitRegionStateProcedure table=t2, region=213e5f89d48161a93b226ba2717b14fd, UNASSIGN}] | org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1704) 2020-12-08 10:18:23,045 | INFO | PEWorker-2 | Took xlock for pid=12, ppid=11, state=RUNNABLE:REGION_STATE_TRANSITION_CLOSE; TransitRegionStateProcedure table=t2, region=213e5f89d48161a93b226ba2717b14fd, UNASSIGN | org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.waitRegions(MasterProcedureScheduler.java:737) 2020-12-08 10:18:23,047 | INFO | PEWorker-2 | pid=12 updating hbase:meta row=213e5f89d48161a93b226ba2717b14fd, regionState=CLOSING, regionLocation=100-112-24-246,21302,1607392837508 | org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateUserRegionLocation(RegionStateStore.java:217) 2020-12-08 10:18:23,055 | INFO | PEWorker-2 | Initialized subprocedures=[{pid=13, ppid=12, state=RUNNABLE; CloseRegionProcedure 213e5f89d48161a93b226ba2717b14fd, server=100-112-24-246,21302,1607392837508}] | org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1704){code}" Move hbase-downstreamer under hbase-connectors,13345597,Open,Major,,11/Dec/20 21:11,,,"The [hbase-downstreamer |https://github.com/saintstack/hbase-downstreamer] project lives in my personal github. I used to use it trying out hbase release candidates from the perspective of a user's application. Subsequently [~busbey] has used it (and fixed it) from time to time testing as has our [~ndimiduk]. Just recently Nick found a bug trying hbase-downstreamer on an RC: HBASE-25384. In the dev thread, ""[VOTE] First release candidate for HBase 2.4.0 (RC1) is available"", its suggested that hbase-downstreamer move into hbase. This issue is about making this move. Was going to move it under the hbase-connectors project. That seems like best place as I look across the pantheon of sub-projects. Presuming you good with this move [~busbey].... since you made contribs... You too [~ndimiduk]." Replacing Producer implementation with an extension of MockProducer on testing side in hbase-connectors,13345685,Resolved,Major,Fixed,12/Dec/20 14:39,12/Dec/20 20:53,,"Currently it is implementing the Producer interface and makes it harder to upgrade kafka version if the interface changes. Instead extending MockProducer and overriding just the send method is enough for the test." Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage ,13344693,Resolved,Major,Fixed,08/Dec/20 01:52,11/Dec/20 00:29,,"The test {{TestClassFinder#testClassFinderDefaultsToOwnPackage}} compares two sets from {{allClassesFinder.findClasses}}. However, the function {{allClassesFinder.findClasses}} does not return the deterministic order result. From code trace, the root cause is at {{ClassFinder.findClassesFromJar}} and {{ClassFinder.findClassesFromFiles}}. They use {{HashSet}} to store {{classes}} and {{listFiles}} to get file array. However, {{HashSet}} and {{listFiles}} do not guarantee that order, and the assertion can fail if the order differs." meta replica regions are assigned to the same region server during SCP.,13344153,Resolved,Major,Invalid,04/Dec/20 05:45,11/Dec/20 22:37,2.4.0,"When running 2.4.0 RC1 with meta replica enabled, during SCP, meta replica regions are assigned to the same region server. I think the reason is that SCP uses round robin algo to assign meta replicas and do not exclude  region servers hosting replica regions. This is not a new issue." one NPE,13342742,Resolved,Major,Fixed,26/Nov/20 02:56,11/Dec/20 09:18,,"* getData can return null at  [https://github.com/apache/hbase/blob/1726160839368df14602da1618e3538955b25f74/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java#L615] or [https://github.com/apache/hbase/blob/1726160839368df14602da1618e3538955b25f74/hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java#L619] all its caller have null checker except at [https://github.com/apache/hbase/blob/1726160839368df14602da1618e3538955b25f74/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java#L467] We shoud add null check for pontential NPEs." Exclude ZooKeeper from hadoop-common transitive dependency for Hadoop2 profile,13345387,Open,Major,,10/Dec/20 21:51,,2.3.0,"During RC validation process for both 2.3.0 and 2.4.0, using [~stack]'s [hbase-downstreamer|https://github.com/saintstack/hbase-downstreamer] project, we see a failure: {noformat} Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 8.955 sec <<< FAILURE! - in org.hbase.downstreamer.TestHBaseMiniCluster testSpinUpMiniHBaseCluster(org.hbase.downstreamer.TestHBaseMiniCluster) Time elapsed: 8.922 sec <<< ERROR! java.lang.NoClassDefFoundError: org/apache/zookeeper/common/X509Exception$SSLContextException at org.hbase.downstreamer.TestHBaseMiniCluster.testSpinUpMiniHBaseCluster(TestHBaseMiniCluster.java:21) Caused by: java.lang.ClassNotFoundException: org.apache.zookeeper.common.X509Exception$SSLContextException at org.hbase.downstreamer.TestHBaseMiniCluster.testSpinUpMiniHBaseCluster(TestHBaseMiniCluster.java:21) {noformat}" [create-release] Fix double .asc,13344919,Resolved,Major,Fixed,08/Dec/20 20:13,10/Dec/20 00:55,,"We are signing the signature file when we run the create-release which results in *.jar.asc.asc files up in maven repository. It looks to be this line in release-util.sh maven_deploy: - declare -a mvn_goals=(clean install) + declare -a mvn_goals=(clean)      " Fix typo in ban-jersey section of the enforcer plugin in pom.xml,13344854,Resolved,Major,Fixed,08/Dec/20 14:54,09/Dec/20 13:54,,"{code} >org.glassfish.jersey.containers:** >org.glassfish.jersey.core:** {code} Need to remove the extra '>'. This was introduced when we shaded jetty and jersey." Improve performance of HFileLinkCleaner by using ReadWriteLock instead of synchronize,13344356,Resolved,Major,Fixed,05/Dec/20 13:42,08/Dec/20 14:09,,"HFileLinkCleaner uses synchronized method isFileDeletable, as a result, to cross the cleaner chain, all files will be processed serially. It may block the fork-join thread which scans out some archived files." hbase-vote.sh mvn invocation broken with empty MVN_PROPERTIES variable,13344658,Resolved,Major,Duplicate,07/Dec/20 21:18,07/Dec/20 22:00,,"When no value is specified for {{MVN_PROPERTIES}}, the {{mvn}} invocation is broken, passing in an explicit empty string argument, that is interpreted by maven as a phase specification." The stub in AsyncConnectionImpl.rsStubs and adminSubs never gets cleaned up,13343104,Open,Major,,28/Nov/20 13:52,,,"Currently there is no way for us to remove the unused stub in these two maps, and after HBASE-25292, things get worse as we will use ServerName directly as the stub key which means every time a region server restarts, we will have a new entry in the map. In the past, since the name only contains host and port(and ip address if hostnameCanChange is true), so we will not have too many entris in these two maps unless we replaced the current region servers with new ones, but it could still be limited to the machines we have. So here I propose that we just use host and port directly as now we will do a resolve when connecting, to get the old behavior back. And maybe we should also find a way to cleanup these two maps." [Flakey Tests] branch-2 TestMetaRegionLocationCache.testStandByMetaLocations,13344307,Resolved,Major,Fixed,04/Dec/20 23:41,05/Dec/20 22:10,,"This just happened to me running tests locally. I see it in the current flakies list [https://ci-hadoop.apache.org/job/HBase/job/HBase-Flaky-Tests/job/branch-2/310/testReport/junit/org.apache.hadoop.hbase.client/TestMetaRegionLocationCache/testStandByMetaLocations/]   It looks like a simple timing issue. Let me put up a simple patch to see if it helps." Have the create-release script do uploads in parallel rather than serially,13344287,Open,Major,,04/Dec/20 19:22,,,Suggestion from parent issue. Hopefully will make the RC'making go much faster. create-release scripts releasedocmaker step should be optional,13344272,Open,Major,,04/Dec/20 17:40,,,"The create-release scripts assume, when invoking releasedocmaker and performing surgery on CHANGES.md and RELEASENOTES.md during the 'tag' stage, that the current RC step is RC0. The entirety of the generated CHANGES.md and RELEASENOTES.md files are stitched in at the head, just below the ASF notice. If we are at a RC step that is not zero, wouldn't this duplicate all CHANGES.md and RELEASENOTES.md content for the release? There would be all the content added for RC0, then the same content (with delta) added for RC1, and so on. For this reason the releasedocmaker invocation should itself be optional. For RC steps > 0, assume the RM has updated CHANGES.md and RELEASENOTES.md to reflect the delta. " "[Flakey Tests] branch-2 TestRefreshRecoveredReplication.testReplicationRefreshSource:141 Waiting timed out after [60,000] msec",13343687,Resolved,Major,Fixed,02/Dec/20 04:32,02/Dec/20 18:03,,"This one fails for me most times running locally. I added some debug (see the PR). In the test we look for old replication source to be non-zero long after it has been processed. The test gets stuck waiting. See here is where the table becomes available, after which we start expecting the old source replication queue to be non-zero. {{ 2020-12-01 20:02:52,400 INFO [Listener at localhost/56996] regionserver.TestRefreshRecoveredReplication(136): Available testReplicationRefreshSource}}  But see here where the replication source has been removed before we get to the 'available' line above: {{2020-12-01 20:02:50,768 INFO [ReplicationExecutor-0.replicationSource,2-kalashnikov.attlocal.net,56950,1606881738045.replicationSource.shipperkalashnikov.attlocal.net%2C56950%2C1606881738045,2-kalashnikov.attlocal.net,56950,1606881738045] regionserver.ReplicationSourceManager(463): Done with the recovered queue 2-kalashnikov. attlocal.net,56950,1606881738045}}{{ }}" "The scan command gives a row, but get does not have this row.",13343721,Resolved,Major,Not A Problem,02/Dec/20 09:40,03/Dec/20 07:58,1.2.11,"Hbase version：1.1.2   We used Hbase as a real-time database and then used hive external tables for our queries, but found that there was a problem with the data query for one table.   {code:java} // sql, result id in (12045075, 12045076,...) SELECT id FROM t1 LIMIT 10 // not result SELECT id FROM t1 WHERE id = '12045075' LIMIT 10 // create table CREATE EXTERNAL TABLE `t1`( `__key` string COMMENT '', `id` string COMMENT '主键ID') COMMENT '' ROW FORMAT SERDE 'org.apache.hadoop.hive.hbase.HBaseSerDe' STORED BY 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' WITH SERDEPROPERTIES ( 'hbase.columns.mapping'=':key,f:id', 'serialization.format'='1') TBLPROPERTIES ( 'COLUMN_STATS_ACCURATE'='{\""BASIC_STATS\"":\""true\""}', 'hbase.table.name'='t1', 'numFiles'='0', 'numRows'='0', 'rawDataSize'='0', 'totalSize'='0', 'transient_lastDdlTime'='1606804842'){code} During this period, I added space or like, but the cause of the problem could not be verified. I began to suspect that it was hbase. {code:java} // hbase table desc describe 't1' Table t1 is ENABLED t1, {TABLE_ATTRIBUTES => {METADATA => {'COMPACTION_ENABLED' => 'true'}} COLUMN FAMILIES DESCRIPTION {NAME => 'f', BLOOMFILTER => 'ROW', VERSIONS => '1', IN_MEMORY => 'false', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', TTL => '6 04800 SECONDS (7 DAYS)', COMPRESSION => 'SNAPPY', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'} // scan row scan 't1', {COLUMNS => 'f:id', LIMIT => 10} // result ROW COLUMN+CELL 12044083 column=f:id, timestamp=1606293182000, value=12044083 12044084 column=f:id, timestamp=1606293183000, value=12044084 12044085 column=f:id, timestamp=1606293185000, value=12044085 12044086 column=f:id, timestamp=1606293190000, value=12044086 12044087 column=f:id, timestamp=1606293192000, value=12044087 12044088 column=f:id, timestamp=1606293197000, value=12044088 12044089 column=f:id, timestamp=1606293198000, value=12044089 12044090 column=f:id, timestamp=1606293204000, value=12044090 12044091 column=f:id, timestamp=1606293207000, value=12044091 12044092 column=f:id, timestamp=1606293208000, value=12044092 // get row, not result get 't1', ""12044083"" , {COLUMNS => 'f:id'}{code} First of all, only row and ID queries will have this problem, and other column queries are normal.Now I think we have reason to suspect that there are invisible escape characters or something in the data, but how do I know? The worst part is that I've used the Java API to make the call, and the returned data doesn't find any invisible escape characters on the row or ID.    " Backport HBASE-25246 to branch-1,13343832,Open,Major,,02/Dec/20 17:55,,, [Flakey Tests] branch-2 TestReadReplicas#testVerifySecondaryAbilityToReadWithOnFiles,13343413,Resolved,Major,Fixed,30/Nov/20 21:44,01/Dec/20 07:04,,"This test fails for me locally every time. Looking at TestReadReplicas, a few do a reset of the cluster after some configuration. Let me just break these out to be their own test. When I do this, the test that fails for me starts passing." [hbase-thirdparty] 3.4.2 release,13343648,Resolved,Major,Won't Fix,01/Dec/20 20:42,02/Dec/20 01:38,, [hbase-thirdparty] Add max java version enforcer rule,13343640,Open,Major,,01/Dec/20 19:35,,,See HBASE-25320 where a release of hbase-thirdparty failed when used in a jdk8 built. ThreadLocal pooling leads to NullPointerException,13341561,Resolved,Major,Fixed,19/Nov/20 11:14,30/Nov/20 12:04,3.0.0-alpha-1,"We got NPE after setting {{hbase.client.ipc.pool.type}} to {{thread-local}}: {noformat} 20/11/18 01:53:04 ERROR yarn.ApplicationMaster: User class threw exception: java.lang.NullPointerException java.lang.NullPointerException at org.apache.hadoop.hbase.ipc.AbstractRpcClient.close(AbstractRpcClient.java:496) at org.apache.hadoop.hbase.client.ConnectionImplementation.close(ConnectionImplementation.java:1944) at org.apache.hadoop.hbase.mapreduce.TableInputFormatBase.close(TableInputFormatBase.java:660) {noformat} The root cause of the issue is probably at {{PoolMap.ThreadLocalPool.values()}}: {code:java} public Collection values() { List values = new ArrayList<>(); values.add(get()); return values; } {code} It adds {{null}} into the collection if the current thread does not have any resources which leads to NPE later. I traced the usages of values() and it should return every resource, not just that one which is attached to the caller thread." Fix ErrorProne error which causes nightly to fail,13343170,Resolved,Major,Fixed,29/Nov/20 14:47,30/Nov/20 08:19,,"{noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project hbase-server: Compilation failure [ERROR] /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java:[7536,38] error: [ArrayToString] Calling toString on an array does not provide useful information [ERROR] (see https://errorprone.info/bugpattern/ArrayToString) [ERROR] Did you mean 'fail(""the qualifier "" + Arrays.toString(q1) + "" should be "" + v1 + "" or "" + v2 + "", but "" + q1Value);'? [ERROR] -> [Help 1] {noformat} " Detector,13343407,Resolved,Major,Duplicate,30/Nov/20 20:53,30/Nov/20 21:48,, RSGroupInfoManagerImpl#moveServers return is not set of servers moved,13342501,Resolved,Major,Fixed,25/Nov/20 03:01,30/Nov/20 03:41,2.2.6,The method works on move_servers_rsgroup. What the method actually returns is all the destination rsgroup servers. It should return the moved servers. The sort icons not shown after Upgrade JQuery to 3.5.1,13342169,Resolved,Major,Fixed,23/Nov/20 16:32,29/Nov/20 13:56,,"The sort icons not shown after Upgrade JQuery to 3.5.1: Upgrade has changes on tablesorter class values. Need to change in hbase.css accordingly. header changed to tablesorter-header headerSortUp changed to tablesorter-headerAsc headerSortDown changed to tablesorter-headerDesc" [hbase-connectors] Run package phase on spark modules,13338426,Resolved,Major,Fixed,02/Nov/20 13:33,30/Nov/20 13:44,hbase-connectors-1.0.1,The precommit job fails if a change is made in the spark module because the protobuf generator plugin runs in package phase. "'hbase master stop' shuts down the cluster, not the master only",13338517,Resolved,Major,Fixed,02/Nov/20 23:24,27/Nov/20 11:06,,"This is confusing (an operator at place-of-employment shut down a massive cluster mistakenly thinking he was shutting down the master only). If I run 'hbase master --help', it says unsupported and then dumps out: {code:java} org.apache.hbase.thirdparty.org.apache.commons.cli.UnrecognizedOptionException: Unrecognized option: --help at org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.processOption(Parser.java:383) at org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.parse(Parser.java:210) at org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.parse(Parser.java:88) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:89) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2945) Usage: Master [opts] start|stop|clear start Start Master. If local mode, start Master and RegionServer in same JVM stop Start cluster shutdown; Master signals RegionServer shutdown clear Delete the master znode in ZooKeeper after a master crashes where [opts] are: --minRegionServers= Minimum RegionServers needed to host user tables. --localRegionServers= RegionServers to start in master process when in standalone mode. --masters= Masters to start in this process. --backup Master should start in backup mode{code}   ... so the 'help' is clear that its the cluster that goes down, not just the master – but that is hardly compensates for the unexpected behavior.   'hbase master stop' is actually what is used internally you run stop-hbase.sh.   Stopping the cluster when your run 'hbase master stop' is actually very old behavior. Its still confusing though. We could change this. If I run 'hbase regionserver stop', it does this: {code:java} System.err.println( ""To shutdown the regionserver run "" + ""hbase-daemon.sh stop regionserver or send a kill signal to "" + ""the regionserver pid"");{code} I'd think we could make improvement here. We could do something like the RS output if user types 'hbase master stop' at a minimum requiring operator add a '–force' flag if they want the cluster to go down or point them to a new hbase cluster stop/hbase cluster start or point them at stop-hbase.sh.  Should also change mode so 'hbase master stop' stops the master and not the cluster (there was no stopMaster when the 'hbase master stop' was added originally – but there is one now).  " Improve remote address handling in hbase-client,13343101,Open,Major,,28/Nov/20 13:06,,,This is a follow-up of HBASE-25292. [hbase-thirdparty] Release 3.4.1,13339872,Resolved,Major,Fixed,11/Nov/20 02:39,27/Nov/20 16:00,, [hbase-thirdparty] Put up 3.4.1RC0,13339875,Resolved,Major,Fixed,11/Nov/20 02:40,27/Nov/20 16:00,, Change encryption key generation algorithm used in the HBase shell,13339690,Resolved,Major,Fixed,10/Nov/20 09:09,26/Nov/20 16:24,,"This PR is a follow-up of HBASE-25181 (#2539), where several issues were discussed on the PR: 1. Currently we use {{PBKDF2WithHmacSHA1}} key generation algorithm to generate a secret key for HFile / WalFile encryption, when the user is defining a string encryption key in the hbase shell. This algorithm is not secure enough and not allowed in certain environments (e.g. on FIPS compliant clusters). We are changing it to {{PBKDF2WithHmacSHA384}}. It will not break backward-compatibility, as even the tables created by the shell using the new algorithm will be able to load (e.g. during bulkload / replication) the HFiles serialized with the key generated by an old algorithm, as the HFiles themselves already contain the key necessary for their decryption. Smaller issues to be fixed: 2. Improve the documentation e.g. with the changes introduced by HBASE-25181 and also by some points discussed on the Jira ticket of HBASE-25263. 3. In {{EncryptionUtil.createEncryptionContext}} the various encryption config checks should throw {{IllegalStateExceptions}} instead of {{RuntimeExceptions}}. 4. Test cases in {{TestEncryptionTest.java}} should be broken down into smaller tests. 5. {{TestEncryptionDisabled.java}} should use {{ExpectedException}} JUnit rule to validate exceptions." [branch-1] Fix two methods removed problems reported by compat-check,13340695,Resolved,Major,Fixed,15/Nov/20 10:18,24/Nov/20 14:20,,"{code} hbase-server-1.6.0.jar, RpcServerInterface.class package org.apache.hadoop.hbase.ipc RpcServerInterface.refreshAuthManager ( PolicyProvider p1 ) [abstract] : void hbase-server-1.6.0.jar, Store.class package org.apache.hadoop.hbase.regionserver Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, boolean p4, boolean p5, boolean p6 ) [abstract] : StoreFile.Writer Store.createWriterInTmp ( long p1, Compression.Algorithm p2, boolean p3, boolean p4, boolean p5, boolean p6, TimeRangeTracker p7 ) [abstract] : StoreFile.Writer {code} These two removed methods may be problematic, let's review them again." Scan#setRowPrefixFilter Unexpected behavior,13341046,Resolved,Major,Fixed,17/Nov/20 12:50,24/Nov/20 14:11,,"e.g. startRow : ""112"" rowPrefixFilter : ""11"" The Result of this scan might contains : ""111"", which unexpected. {code:java} public Scan setRowPrefixFilter(byte[] rowPrefix) { if (rowPrefix == null) { setStartRow(HConstants.EMPTY_START_ROW); setStopRow(HConstants.EMPTY_END_ROW); } else { this.setStartRow(rowPrefix); this.setStopRow(calculateTheClosestNextRowKeyForPrefix(rowPrefix)); } return this; } {code}  Scan#setRowPrefixFilter achieves this function by setting startRow and stopRow, ignoring the situation that startRow may have been set." Enable configuration based enable/disable of Unsafe package usage,13339099,Open,Major,,06/Nov/20 01:05,,,"We need a provide away for clients to disable Unsafe package usage . Currently there is no way for clients to specify that they don't want to use Unsafe conversion for Bytes conversion. As a result there could be some issues with missing methods of Unsafe when client is on JDK 11 . So the clients can disable Unsafe package use and use normal conversion if they want to. Also we use static references to Unsafe Availability in Bytes class assuming that the Unsafe availability is set during class loading and no one can ever override it later. Now that we plan to expose a util for clients to override the availability if required, we need to avoid the static references for computing the availability whenever we do the comparisions" Upgrading HBase from 2.2.0/2.3.3 to master(3.0.0) fails because HMaster “Failed to become active master”,13338542,Open,Major,,03/Nov/20 04:29,,2.2.0,"When we upgraded HBASE cluster from 2.2.0/2.3.3 to master(c303f9d329d578d31140e507bdbcbe3aa097042b),  the HMaster on upgraded node failed to start. The error message is shown below: {code:java} 2020-11-03 02:52:27,809 ERROR [master/65cddff041f6:16000:becomeActiveMaster] master.HMaster: Failed to become active masterjava.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILEDat org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:379)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:319)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1362)at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1137)at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2245)at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:626)at java.lang.Thread.run(Thread.java:748)Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 2 actions: RetriesExhaustedException: 2 times, servers with issues:at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.makeError(BufferedMutatorOverAsyncBufferedMutator.java:107)at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.internalFlush(BufferedMutatorOverAsyncBufferedMutator.java:122)at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.close(BufferedMutatorOverAsyncBufferedMutator.java:166)at org.apache.hadoop.hbase.master.TableNamespaceManager.migrateNamespaceTable(TableNamespaceManager.java:93)at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:123)at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:61)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:249)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1360)... 4 more2020-11-03 02:52:27,810 ERROR [master/65cddff041f6:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: []2020-11-03 02:52:27,810 ERROR [master/65cddff041f6:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master 65cddff041f6,16000,1604371935915: Unhandled exception. Starting shutdown. *****java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILEDat org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:379)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:319)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1362)at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1137)at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2245)at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:626)at java.lang.Thread.run(Thread.java:748)Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 2 actions: RetriesExhaustedException: 2 times, servers with issues:at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.makeError(BufferedMutatorOverAsyncBufferedMutator.java:107)at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.internalFlush(BufferedMutatorOverAsyncBufferedMutator.java:122)at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.close(BufferedMutatorOverAsyncBufferedMutator.java:166)at org.apache.hadoop.hbase.master.TableNamespaceManager.migrateNamespaceTable(TableNamespaceManager.java:93)at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:123)at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:61)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:249)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1360)... 4 more2020-11-03 02:52:27,810 INFO  [master/65cddff041f6:16000:becomeActiveMaster] regionserver.HRegionServer: ***** STOPPING region server '65cddff041f6,16000,1604371935915' *****2020-11-03 02:52:27,810 INFO  [master/65cddff041f6:16000:becomeActiveMaster] regionserver.HRegionServer: STOPPED: Stopped by master/65cddff041f6:16000:becomeActiveMaster2020-11-03 02:52:27,811 INFO  [master/65cddff041f6:16000] regionserver.HRegionServer: Stopping infoServer2020-11-03 02:52:27,823 INFO  [master/65cddff041f6:16000] handler.ContextHandler: Stopped o.e.j.w.WebAppContext@47e4d9d0{/,null,UNAVAILABLE}{file:/hbase/hbase-webapps/master}2020-11-03 02:52:27,839 INFO  [master/65cddff041f6:16000] server.AbstractConnector: Stopped ServerConnector@2098d37d{HTTP/1.1,[http/1.1]}{0.0.0.0:16010}2020-11-03 02:52:27,839 INFO  [master/65cddff041f6:16000] handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@303a5119{/static,file:///hbase/hbase-webapps/static/,UNAVAILABLE}2020-11-03 02:52:27,839 INFO  [master/65cddff041f6:16000] handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@38548b19{/logs,file:///hbase/logs/,UNAVAILABLE}2020-11-03 02:52:27,844 INFO  [master/65cddff041f6:16000] regionserver.HRegionServer: aborting server 65cddff041f6,16000,16043719359152020-11-03 02:52:27,850 INFO  [master/65cddff041f6:16000] regionserver.HRegionServer: stopping server 65cddff041f6,16000,1604371935915; all regions closed.2020-11-03 02:52:27,851 INFO  [master/65cddff041f6:16000] hbase.ChoreService: Chore service for: master/65cddff041f6:16000 had [ScheduledChore name=FlushedSequenceIdFlusher, period=10800000, unit=MILLISECONDS] on shutdown2020-11-03 02:52:27,857 INFO  [master/65cddff041f6:16000] master.ServerManager: Writing .lastflushedseqids file at: file:/var/lib/hbase/.lastflushedseqids2020-11-03 02:52:27,874 INFO  [master/65cddff041f6:16000] assignment.AssignmentManager: Stopping assignment manager2020-11-03 02:52:27,875 INFO  [master/65cddff041f6:16000] procedure2.RemoteProcedureDispatcher: Stopping procedure remote dispatcher2020-11-03 02:52:27,877 INFO  [master/65cddff041f6:16000] procedure2.ProcedureExecutor: Stopping2020-11-03 02:52:27,882 INFO  [master/65cddff041f6:16000] region.RegionProcedureStore: Stopping the Region Procedure Store, isAbort=true2020-11-03 02:52:27,883 INFO  [master/65cddff041f6:16000] store.LocalRegion: Closing local region {ENCODED => 1595e783b53d99cd5eef43b6debb2682, NAME => 'master:store,,1.1595e783b53d99cd5eef43b6debb2682.', STARTKEY => '', ENDKEY => ''}, isAbort=true2020-11-03 02:52:27,888 INFO  [master/65cddff041f6:16000] regionserver.HRegion: Closing region master:store,,1.1595e783b53d99cd5eef43b6debb2682.2020-11-03 02:52:27,889 ERROR [master/65cddff041f6:16000] regionserver.HRegion: Memstore data size is 26957 in region master:store,,1.1595e783b53d99cd5eef43b6debb2682.2020-11-03 02:52:27,890 INFO  [master/65cddff041f6:16000] regionserver.HRegion: Closed master:store,,1.1595e783b53d99cd5eef43b6debb2682.2020-11-03 02:52:27,890 INFO  [master/65cddff041f6:16000] hbase.ChoreService: Chore service for: master/65cddff041f6:16000.splitLogManager. had [ScheduledChore name=SplitLogManager Timeout Monitor, period=1000, unit=MILLISECONDS] on shutdown2020-11-03 02:52:27,890 INFO  [master:store-WAL-Roller] wal.AbstractWALRoller: LogRoller exiting.2020-11-03 02:52:27,892 INFO  [master/65cddff041f6:16000] flush.MasterFlushTableProcedureManager: stop: server shutting down.2020-11-03 02:52:27,894 INFO  [master/65cddff041f6:16000] ipc.NettyRpcServer: Stopping server on /252.17.1.2:160002020-11-03 02:52:28,058 INFO  [ReadOnlyZKClient-252.17.1.5:2181@0x3e505444] zookeeper.ZooKeeper: Session: 0x10139a450ef001b closed2020-11-03 02:52:28,058 INFO  [ReadOnlyZKClient-252.17.1.5:2181@0x3e505444-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x10139a450ef001b2020-11-03 02:52:28,166 INFO  [master/65cddff041f6:16000] zookeeper.ZooKeeper: Session: 0x10139a450ef0018 closed2020-11-03 02:52:28,166 INFO  [main-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x10139a450ef00182020-11-03 02:52:28,166 INFO  [master/65cddff041f6:16000] regionserver.HRegionServer: Exiting; stopping=65cddff041f6,16000,1604371935915; zookeeper connection closed.2020-11-03 02:52:28,168 ERROR [main] master.HMasterCommandLine: Master exitingjava.lang.RuntimeException: HMaster Abortedat org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:244)at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3077) {code} It can be reproduced through the following steps: # Start up a cluster of version 2.2.0 (rel/2.2.0)/2.3.3(branch-2.3) with 3 nodes # Use hbase pe to write data. {code:java}  /hbase/bin/hbase pe --nomapred --oneCon=true --valueSize=10 --rows=100 sequentialWrite{code} # Stop the cluster:   ## Using the graceful_stop.sh to stop all regionservers. ## Then run stop-hbase.sh # Upgrade the node to master(c303f9d329d578d31140e507bdbcbe3aa097042b) # After upgrading, as the log, hbase--master-eca51d951598.log, suggested, HMaster failed to start." Support start/stop replication server by scripts,13341727,Open,Major,,20/Nov/20 07:09,,3.0.0-alpha-1, "upgrading hbase from 2.0.6 to 2.1.1, HMaster failed to become active because it cannot find hbase:namespace table",13339632,Open,Major,,10/Nov/20 00:12,,2.0.6,"When we upgraded HBASE cluster from 2.0.6 to 2.1.1, the HMaster on upgraded node failed to start. Some stack trace in the error log: {code:java} 2020-11-06 02:01:26,420 WARN [PEWorker-12] assignment.RegionTransitionProcedure: Failed transition, suspend 1secs pid=12, ppid=9, state=RUNNABLE:REGION_TRANSITION_QUEUE, locked=true; AssignProcedure table=TestTable, region=37d62d2c1934da269a592e0e5cbca82a; rit=OFFLINE, location=null; waiting on rectified condition fixed by other Procedure or operator intervention org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: TestTable at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215) at org.apache.hadoop.hbase.master.assignment.AssignProcedure.assign(AssignProcedure.java:194) at org.apache.hadoop.hbase.master.assignment.AssignProcedure.startTransition(AssignProcedure.java:205) at org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:355) at org.apache.hadoop.hbase.master.assignment.RegionTransitionProcedure.execute(RegionTransitionProcedure.java:97) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:957) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1835) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1595) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1200(ProcedureExecutor.java:80) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2140) {code} Seems it's caused by not able to find hbase:namespace table after upgrade:  {code:java} 2020-11-06 02:01:26,791 ERROR [master/399fd6ca0c6d:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [] 2020-11-06 02:01:26,791 ERROR [master/399fd6ca0c6d:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master 399fd6ca0c6d,16000,1604628075265: Unhandled exception. Starting shutdown. ***** java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILED at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:345) at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:291) at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1253) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1031) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2254) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:583) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.TableNotFoundException: hbase:namespace at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegionInMeta(ConnectionImplementation.java:864) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegion(ConnectionImplementation.java:759) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.locateRegion(ConnectionUtils.java:131) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegion(ConnectionImplementation.java:745) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.locateRegion(ConnectionUtils.java:131) at org.apache.hadoop.hbase.client.ConnectionImplementation.locateRegion(ConnectionImplementation.java:716) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.locateRegion(ConnectionUtils.java:131) at org.apache.hadoop.hbase.client.ConnectionImplementation.getRegionLocation(ConnectionImplementation.java:594) at org.apache.hadoop.hbase.client.ConnectionUtils$ShortCircuitingClusterConnection.getRegionLocation(ConnectionUtils.java:131) at org.apache.hadoop.hbase.client.HRegionLocator.getRegionLocation(HRegionLocator.java:72) at org.apache.hadoop.hbase.client.RegionServerCallable.prepare(RegionServerCallable.java:223) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:105) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:386) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:360) at org.apache.hadoop.hbase.master.TableNamespaceManager.get(TableNamespaceManager.java:142) at org.apache.hadoop.hbase.master.TableNamespaceManager.isTableAvailableAndInitialized(TableNamespaceManager.java:279) at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:104) at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:63) at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:226) at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1251) ... 4 more {code} Attached the error log file.  [^hmaster.log]   Steps to reproduce:  # Start up a cluster of version 2.0.6 with 3 nodes # Use hbase pe to write data.  {code:java} /hbase/bin/hbase pe --nomapred --oneCon=true --valueSize=10 --rows=100 sequentialWrite 1{code} # Stop the cluster:   ## using the graceful_stop.sh to stop all regionservers. ## Then run stop-hbase.sh # Upgrade the node to 2.1.1 5. After upgrading HMaster failed to start.      " ui throws NPE,13341745,Resolved,Major,Fixed,20/Nov/20 09:11,23/Nov/20 05:32,2.2.3,"https://github.com/apache/hbase/blob/eca904e0fb438461a8da3f37cea3eaf496988be9/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L3624 if rs has invalid znode, and restart master, ui will throw NPE. i encountered this problem during the upgrade. workaround: restart HBase." [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.4.1,13339874,Resolved,Major,Fixed,11/Nov/20 02:40,23/Nov/20 12:25,, [meta replicas] ArrayIndexOutOfBoundsException in ZKConnectionRegistry,13340367,Resolved,Major,Fixed,12/Nov/20 21:53,16/Nov/20 17:02,HBASE-18070,"ITBLL Testing HBASE-18070 feature, [~huaxiangsun] found this: {code:java} 2020-11-12 19:48:12,358 ERROR org.apache.hadoop.hbase.util.FutureUtils: Unexpected error caught when processing CompletableFuturejava.lang.ArrayIndexOutOfBoundsException: Index 3 out of bounds for length 3     at org.apache.hadoop.hbase.client.ZKConnectionRegistry.lambda$getMetaRegionLocation$2(ZKConnectionRegistry.java:180)     at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68)     at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859)     at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:837)     at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)     at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)     at org.apache.hadoop.hbase.client.ZKConnectionRegistry.lambda$getAndConvert$0(ZKConnectionRegistry.java:78)     at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68)     at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859)     at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:837)     at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)     at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)     at org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$ZKTask$1.exec(ReadOnlyZKClient.java:174)     at org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient.run(ReadOnlyZKClient.java:342)    at java.base/java.lang.Thread.run(Thread.java:834) {code} The code has been this way a long time but his running with four replicas seems to have revealed a race exposed by using replicaid as index." branch-1 docker mode for yetus fails,13341867,Resolved,Major,Duplicate,20/Nov/20 22:14,21/Nov/20 01:43,,"{noformat} 15:30:41 Step 28/33 : RUN gem install rubocop:'<= 0.81' 15:30:41 ---> Running in 21103fb7944c 15:30:42 Building native extensions. This could take a while... 15:30:43 [91mERROR: Error installing rubocop: 15:30:43 parallel requires Ruby version >= 2.5. 15:30:43 [0mSuccessfully installed jaro_winkler-1.5.4 15:30:44 The command '/bin/sh -c gem install rubocop:'<= 0.81'' returned a non-zero code: 1 15:30:44 ERROR: Docker failed to build yetus/hbase:b249092a5f. {noformat}" HBASE-18070 makes for NPEs in some hbase-backup tests on master,13341735,Open,Major,,20/Nov/20 08:23,,,Let me work on this as a distinct issue. The hbase-backup tests are complex/massive so need to do some study. Its the jdk8 runs that fail. [https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2643/] jdk11 passes.  All pass locally too. Add integration test for meta replica load balance mode,13338748,Open,Major,,04/Nov/20 00:52,,,We need to create an integration test which has meta replica load balance mode enabled and make sure its correctness. Follow-on: defend against read replicas being enabled for server-side clients ,13340942,Open,Major,,17/Nov/20 00:29,,,A nice aid for operators would be to spend some time on ensuring that at least 'LoadBalance' is not set for the clients that on the serverside inside Master in particular. Currently our only defense is documentation. An operator might set them for client-side and server-side by mistake. Defend server-side clients against this possibility to avoid Master making decisions based off stale state. "Follow-on tasks that came of ""HBASE-18070 Enable memstore replication for meta replica""",13341872,Open,Major,,20/Nov/20 23:10,,,"The HBASE-18070 _Enable memstore replication for meta replica_ turned up _follow-ons:_ tests, doc, guardrails and enhancements. Let me give them their own issue so they do not crowd the original and so I can resolve the original against the version that carries the first implementation of the enhancement (Want to avoid the alternative of an issue that stays open for ever)." The log in SimpleLoadBalancer#onConfigurationChange is wrong,13341532,Resolved,Major,Fixed,19/Nov/20 08:59,19/Nov/20 17:05,2.2.7,"[https://github.com/apache/hbase/blob/8c1e4763b3e11d4553e5a59e620ab30e3b2047e9/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java#L139] current overallSlop should be ""overallSlop""" 'Unknown table hbase:quota' happens when desc table in shell if quota disabled,13341207,Resolved,Major,Fixed,18/Nov/20 04:33,19/Nov/20 10:02,3.0.0-alpha-1, Add master UI to show ReplicationServer,13341514,Open,Major,,19/Nov/20 07:32,,, [testing] Clean up resources after tests in rsgroup_shell_test.rb,13340774,Resolved,Major,Fixed,16/Nov/20 08:03,18/Nov/20 07:26,3.0.0-alpha-1,"In rsgroup_shell_test.rb, some tests don't remove rsgroups and drop tables, messing up adding new tests." Upgrade Bootstrap to 3.4.1,13339670,Resolved,Major,Fixed,10/Nov/20 07:25,17/Nov/20 16:17,,"HBase UI is currently using bootstrap 3.3.7. This version is vulnerable to 4 medium CVEs (CVE-2018-14040, CVE-2018-14041, CVE-2018-14042, and CVE-2019-8331). Details on all the bootstrap versions and vulnerabilities is here: [https://snyk.io/vuln/npm:bootstrap] Upgrading to bootstrap 4 would be nice, but potentially more work to do. To avoid these CVE issues, we should at least upgrade to the latest bootstrap 3, which is 3.4.1 currently." Refactor the locate WAL logic in ReplicationSource,13340947,Open,Major,,17/Nov/20 01:09,,,"When cluster replication enabled and one RegionServer crashed, its WALs will be move from WALs dir to oldWALs dir and its replication queue will moved to other RegionServer's replication queue.   HDFS layout (WAL Storage) /hbase/WALs/RS1/1.log /hbase/WALs/RS1/2.log /hbase/WALs/RS1/3.log ZooKeeper layout (Replication queue storage) /hbase/replication/rs/RS1/peerId/1.log /hbase/replication/rs/RS1/peerId/2.log /hbase/replication/rs/RS1/peerId/3.log   Failover finished: HDFS layout (WAL Storage) /hbase/.oldWALs/1.log /hbase/.oldWALs/2.log /hbase/.oldWALs/3.log ZooKeeper layout (Replication queue storage) /hbase/replication/rs/RS2/peerId-RS1/1.log /hbase/replication/rs/RS2/peerId-RS1/2.log /hbase/replication/rs/RS2/peerId-RS1/3.log   And if enabled hbase.separate.oldlogdir.by.regionserver, the HDFS layout may be: HDFS layout (WAL Storage) /hbase/.oldWALs/RS1/1.log /hbase/.oldWALs/RS1/2.log /hbase/.oldWALs/RS1/3.log   Then if RS2 crashed, the HDFS layout will not change but ZooKeeper layout may changed. ZooKeeper layout (Replication queue storage) /hbase/replication/rs/RS3/peerId-RS1-RS2/1.log /hbase/replication/rs/RS3/peerId-RS1-RS2/2.log /hbase/replication/rs/RS3/peerId-RS1-RS2/3.log   So even the replication queue was transfered many times, the HDFS layout never change.   Another case is master-cluster disaster, the failover work not finished. Then ReplicationSyncUp tool can start replication source to replicate the WAL data. The HDFS layout need to consider two more case: /hbase/WALs/RS1/1.log /hbase/WALs/RS1/2.log /hbase/WALs/RS1/3.log or /hbase/WALs/RS1-splitting/1.log /hbase/WALs/RS1-splitting/2.log /hbase/WALs/RS1-splitting/3.log" fix typo in StripeStoreFileManager java doc,13339890,Resolved,Major,Fixed,11/Nov/20 05:33,14/Nov/20 17:48,,See StripeCompactionPolicy on how the stripes are determined; this class doesn't care. Deprecated master carrys regions related methods and configs,13339327,Resolved,Major,Fixed,07/Nov/20 14:36,12/Nov/20 14:25,,"And also mention that this feature will be removed in 3.0.0. This is the first step to undo master carrys regions." Add SSL keystore type and truststore related configs for HBase RESTServer,13339782,Resolved,Major,Fixed,10/Nov/20 15:22,12/Nov/20 11:47,,"The RESTServer currently relies on the following parameters to configure SSL on the REST API: * {{hbase.rest.ssl.enabled}} * {{hbase.rest.ssl.keystore.store}} * {{hbase.rest.ssl.keystore.password}} * {{hbase.rest.ssl.keystore.keypassword}} * {{hbase.rest.ssl.exclude.cipher.suites}} * {{hbase.rest.ssl.include.cipher.suites}} * {{hbase.rest.ssl.exclude.protocols}} * {{hbase.rest.ssl.include.protocols}} In this patch I want to introduce the following new parameters: * {{hbase.rest.ssl.keystore.type}} * {{hbase.rest.ssl.truststore.store}} * {{hbase.rest.ssl.truststore.password}} * {{hbase.rest.ssl.truststore.type}} If any of the new the parameter is not provided, then we should fall-back to the current behaviour (e.g. assuming JKS keystore/truststore types, or no passwords, or no custom trust store file)." Need to throw the original exception in HRegion#openHRegion,13340101,Resolved,Major,Fixed,12/Nov/20 01:50,12/Nov/20 09:57,,"{code:java} protected HRegion openHRegion(final CancelableProgressable reporter) throws IOException { try { ...... } catch(Throwable t) { // By coprocessor path wrong region will open failed, // MetricsRegionWrapperImpl is already init and not close, // add region close when open failed this.close(); // This may throw IOException too. throw t; } return this; } {code} https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L8144 this.close() may throw IOException too. The original exception will not be recorded." [hbase-thirdparty] Set version as 3.4.1 in prep for first RC,13339873,Resolved,Major,Fixed,11/Nov/20 02:40,11/Nov/20 03:29,, Add options for disabling column family encryption and choosing hash algorithm for wrapped encryption keys.,13335168,Resolved,Major,Fixed,13/Oct/20 08:40,09/Nov/20 20:32,2.3.2,"Currently we are using MD5 hash algorithm to store a hash for encryption keys. This hash is needed to verify the secret key of the subject. (e.g. making sure that the same secret key is used during encrypted HFile / WalFile read and write). The MD5 algorithm is considered weak, and can not be used in some (e.g. FIPS compliant) clusters. However, currently it is not possible to use different hash algorithm, or to disable the whole column family encryption globally on the cluster. In this patch: * I introduce a backward compatible way of specifying the hash algorithm. This enable us to use newer and/or more secure hash algorithms like SHA-384 or SHA-512 (which are FIPS compliant). * I added a configuration parameter to globally enable / disable the column family encryption feature. (enabled by default for backward compatibility). This is handy if someone wants to operate an HBase cluster making sure that uses are only relying on other (e.g. HDFS based) encryption mechanisms." Remove MirroringTableStateManager,13339410,Resolved,Major,Fixed,09/Nov/20 02:19,09/Nov/20 13:37,, Do not use round robin assignment when processing offline regions,13339383,Resolved,Major,Implemented,08/Nov/20 14:25,09/Nov/20 14:32,,"This is just a simple hack to fix the master start up, which could be applied to both master and branch-2. Will do other more general fixes in follow-on issues." "After upgrading HBase from 2.1.1 to 2.2.0, table cannot be read and HMaster crashes",13339629,Open,Major,,09/Nov/20 23:57,,2.1.1,"When we upgraded HBASE cluster from 2.1.1 to 2.2.0, we failed to read data by using HBase shell command, and later HMaster crashes.  Commandline error message:   {code:java} HBase ShellUse ""help"" to get list of supported commands.Use ""exit"" to quit this interactive shell.For Reference, please visit: http://hbase.apache.org/2.0/book.html#shellVersion 2.2.0, r3ec693241f2edb0cf78e71739874f2323a86bf1e, Tue Nov  3 02:12:43 UTC 2020Took 0.0043 secondshbase(main):001:0> listTABLETestTable1 row(s)Took 0.5663 seconds=> [""TestTable""]hbase(main):002:0> scan 'TestTable'ROW                                            COLUMN+CELL ERROR: Unknown table TestTable! For usage try 'help ""scan""' Took 0.1510 secondshbase(main):003:0> {code} Log file:     {code:java} 2020-11-07 04:03:57,346 ERROR [master/bff37223dfc6:16000:becomeActiveMaster] master.HMaster: Failed to become active masterjava.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILEDat org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:366)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:312)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1344)at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1122)at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2353)at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:598)at java.lang.Thread.run(Thread.java:748)Caused by: java.io.IOException: Timedout 300000ms waiting for namespace table to be assigned and enabled: tableName=hbase:namespace, state=ENABLEDat org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:108)at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:63)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:248)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1342)... 4 more2020-11-07 04:03:57,347 ERROR [master/bff37223dfc6:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: []2020-11-07 04:03:57,347 ERROR [master/bff37223dfc6:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master bff37223dfc6,16000,1604721496292: Unhandled exception. Starting shutdown. *****java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILEDat org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:366)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:312)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1344)at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1122)at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2353)at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:598)at java.lang.Thread.run(Thread.java:748)Caused by: java.io.IOException: Timedout 300000ms waiting for namespace table to be assigned and enabled: tableName=hbase:namespace, state=ENABLEDat org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:108)at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:63)at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:248)at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1342)... 4 more2020-11-07 04:03:57,348 INFO  [master/bff37223dfc6:16000:becomeActiveMaster] regionserver.HRegionServer: ***** STOPPING region server 'bff37223dfc6,16000,1604721496292' *****2020-11-07 stopping=bff37223dfc6,16000,1604721496292; zookeeper connection closed.2020-11-07 04:03:57,612 INFO  [main-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x1014e7bdcf800002020-11-07 04:03:57,620 ERROR [main] master.HMasterCommandLine: Master exitingjava.lang.RuntimeException: HMaster Abortedat org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:244)at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140)at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3198) {code}   Steps to reproduce:  # ** Start up a cluster of version 2.1.1 with 3 nodes # Use hbase pe to write data.    {code:java} /hbase/bin/hbase pe --nomapred --oneCon=true --valueSize=10 --rows=100 sequentialWrite 1{code}   # Stop the cluster by:  ## run “bash stop-hbase.sh” to shutdown the master. ## Set the property hbase.procedure.upgrade-to-2-2 to true in hbase-site.xml ## Start the master again and wait until the Master quits  # Upgrade the node to 2.2.0 # After upgrading, try to read the data TestTable, the error message shows. Then, after a while, Master crashes.      " Rewrite TestMultiLogThreshold to remove the LogDelegate in RSRpcServices,13339328,Resolved,Major,Fixed,07/Nov/20 14:37,08/Nov/20 14:23,, The client zk syncer should deal with meta replica count change,13337123,Resolved,Major,Fixed,26/Oct/20 03:00,06/Nov/20 04:15,,"The failure of TestSeparateClientZKCluster is because that, we start the zk syncer before we initialize meta region, and after HBASE-25099, we will scan zookeeper to get the meta znodes directly instead of checking the config, so we will get an empty list since there is no meta location on zk yet, thus we will sync nothing. But changing the order can not solve everything, as after HBASE-25099, we can change the meta replica count without restartinig master, so the zk syncer should have the ability to know the change and start to sync the location for the new replicas." Fixing hacky test in TestCoprocessorInterface,13339084,Open,Major,,05/Nov/20 20:13,,2.3.2,The coprocessor was not being initialized in the region/store as the regionServices was set as null. The test was using an explicit setter in the region for populating the coprocessor after region initialization. This code path was exercised only by tests. This commit removes the back door entry for the test to set the coprocessor host explicitly and now the same is being set through the regular store initialization code path. This also allows the use of the storecontext otherwise the test would fail with the storecontext having a null coprocessor RegionInfo.isOffline is now a duplication with RegionInfo.isSplit,13336399,Resolved,Major,Fixed,21/Oct/20 03:55,04/Nov/20 16:12,,"The only place, where we set it to true is in splitRegion, and at the same time we will set split to true. So in general, I suggest that we deprecated isOffline and isSplitParent in RegionInfo, only leave the isSplit method. And in RegionInfoBuilder, we deprecated setOffline and only leave the setSplit method. This could make our code base cleaner. And for serialization compatibility, we'd better still keep the split and offline fields in the actual RegionInfo datastructure for a while." hbase_generate_website is failing due to incorrect jdk and maven syntax,13338809,Resolved,Major,Fixed,04/Nov/20 10:16,04/Nov/20 14:46,,"While waiting for HBase download page to reflect new release and during an offline syncup with [~ndimiduk] , realized that generate website is failing for quite some time now, e.g https://ci-hadoop.apache.org/job/HBase/job/hbase_generate_website/80/ {code:java} Obtained dev-support/jenkins-scripts/generate-hbase-website.Jenkinsfile from git https://gitbox.apache.org/repos/asf/hbase.git Running in Durability level: PERFORMANCE_OPTIMIZED org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed: WorkflowScript: 40: Tool type ""maven"" does not have an install of ""Maven (latest)"" configured - did you mean ""maven_latest""? @ line 40, column 15. maven 'Maven (latest)' ^ WorkflowScript: 42: Tool type ""jdk"" does not have an install of ""JDK 1.8 (latest)"" configured - did you mean ""jdk_1.8_latest""? @ line 42, column 13. jdk ""JDK 1.8 (latest)"" ^ {code} We might have to apply fix similar to HBASE-25204 to generate website specific Jenkinsfile." Release 2.3.3,13337139,Resolved,Major,Fixed,26/Oct/20 06:29,04/Nov/20 15:46,,"Sub-tasks involved: # Spin RCs # ""Release"" staged nexus repository # Release version 2.3.3 in Jira # Promote 2.3.3 RC artifacts in svn # Update reporter tool with new release # Push signed release tag # Add 2.3.3 to the downloads page # Send announce email" Cleanup the deprecated methods in TimeRange,13338424,Resolved,Major,Fixed,02/Nov/20 13:28,04/Nov/20 03:12,, Support lazy loading operation for editing tableSchema config,13338802,Open,Major,,04/Nov/20 10:00,,,"Currently, when “alter” is used to modify the tableSchema, the region will be reopened immediately to load the meta information in .tabledesc. Now add a lazy loading modification command, there is no need to reopen the region immediately, and then load it when a region move or other region behavior occurs." Try enlarge the flaky test timeout for branch-2.2,13335975,Open,Major,,19/Oct/20 01:05,,,"Now there are too many flaky tests to run. And the flaky test job cannot finished in 2 hours. Then these tests will be marked flaky again.   See [https://ci-hadoop.apache.org/job/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/124/artifact/dashboard.html]" Remove the usage of MetaTableAccessor in hbase-balancer,13335327,Open,Major,,14/Oct/20 03:06,,,"Let's try to find a way to move MTA to hbase-server. Putting it in hbase-balancer is a bit weird (Why is the MetaTableAccessor in the balancer module?). MetaTableAccessor (MTA) is in hbase-balancer because the favored nodes (FN) feature wants to write to meta. The FN feature (HBASE-7932 which arrived in hbase-0.96.0) I believe is unused. The idea of maintaining locality across a crash is a good one but having to enable a different balancer to default to enable FN operation has made it so the feature has been let rot. HBASE-21014 makes an appeal for integrating FN into the default stochastic balancer. HBASE-15531 is an old effort that actually tried to integrate FN into stochastic balancer but stalled out." Create an hbase-tool module and move here standalone tools bundled with core,13335672,Resolved,Major,Won't Fix,15/Oct/20 20:17,03/Nov/20 20:10,,"HBASE-23933 is about moving balancer classes to a new hbase-balancer module as an effort at shrinking the size of the hbase-server module -- it is too big. This issue is about creating a hbase-tool module into which we'd move standalone tools that ship with hbase core such as the bulkloadtool and the canary and all related supporting and test classes. I do not see this making much of a dent in the size of hbase-server. This issue is offered as a small improvement. (Aside, I'd move some favored node 'tool' classes that are currently in limbo here at least until we rule on whether to finish or remove if this module was put in place -- see HBASE-25185)." Auto-fix 'Unknown Server',13330429,Open,Major,,01/Oct/20 18:52,,,"Addressing reports of 'Unknown Server' has come up in various conversations lately. This issue is about fixing instances of 'Unknown Server' automatically as part of the tasks undertaken by CatalogJanitor when it runs. First though, would like to figure a definition for 'Unknown Server' and a list of ways in which they arise. We need this to figure how to do safe auto-fixing. Currently an 'Unknown Server' is a server found in hbase:meta that is not online (no recent heartbeat) and that is not mentioned in the dead servers list. In outline, I'd think CatalogJanitor could schedule an expiration of the RS znode in zk (if exists) and then an SCP if it finds an 'Unknown Server'. Perhaps it waits for 2x or 10x the heartbeat interval just-in-case (or not). The SCP would clean up any references in hbase:meta by reassigning Regions assigned the 'Unknown Server' after replaying any WALs found in hdfs attributed to the dead server. As to how they arise:  * A contrived illustration would be a large online cluster crashes down with a massive backlog of WAL files – zk went down for some reason say. The replay of the WALs look like it could take a very long time  (lets say the cluster was badly configured and a bug and misconfig made it so each RS was carrying hundreds of WALs and there are hundreds of servers). To get the service back online, the procedure store and WALs are moved aside (for later replay with WALPlayer). The cluster comes up. meta is onlined but refers to server instances that are no longer around. Can schedule an SCP per server mentioned in the 'HBCK Report' by scraping and scripting hbck2 or, better, catalogjanitor could just do it.  * HBASE-24286 HMaster won't become healthy after after cloning... describes starting a cluster over data that is hfile-content only. In this case the original servers used manufacture the hfile cluster data are long dead yet meta still refers to the old servers. They will not make the 'dead servers' list. Let this issue stew awhile. Meantime collect how 'Unknown Server' gets created and best way to fix.  " Remove owner related methods in TableDescriptor/TableDescriptorBuilder,13334787,Resolved,Major,Fixed,10/Oct/20 09:50,02/Nov/20 13:24,,"They have been marked as deprecated long ago. Let's remove them." Maximize sleep for checking meta and namespace regions availability,13337616,Resolved,Major,Fixed,28/Oct/20 09:20,28/Oct/20 17:11,,"The isRegionOnline method in HMaster is used on Master startup to check the availability of hbase:meta and hbase:namespace tables. I've run into an issue when namespace was not online and Master was just waiting there. I've used HBCK2 to fix the cluster but the initialization was not completed because RetryCounterFactory was already waiting for 10+ hours. Since Master is waiting in an idle state it makes no harm to check the region availability more frequently and limit the maximum sleep time." Normalizer support for hot config reloading,13334723,Resolved,Major,Fixed,09/Oct/20 21:05,30/Oct/20 22:33,2.4.0,Give operators some agility by letting the normalizer be reconfigured without process restart. Fix PreCommit builds for branch-1.4,13338114,Resolved,Major,Duplicate,30/Oct/20 16:55,30/Oct/20 17:21,1.4.13,"When applying HBASE-24200 to branch-1.4, we noticed that the PR build failed. Looks like it's broken currently." "Update book section ""Submitting Patches"" to exclusively describe a Github workflow",13338159,Open,Major,,30/Oct/20 22:55,,3.0.0-alpha-1,"Per this [discuss thread|https://lists.apache.org/thread.html/r091e883c4075eb13a8df22a3298029fac66b97f1b6b0e2c8debc39e2%40%3Cdev.hbase.apache.org%3E], we have dropped support for receiving patches via Jenkins. Our section on [Submitting Patches|https://hbase.apache.org/book.html#submitting.patches] could use an update. Remove old content, add instructions for creating a Github PR against our repository (or link to Github's own documentation)." Failure in refguide is causing build failures,13338152,Open,Major,,30/Oct/20 21:56,,2.3.3,"Recent runs on branch-2.3 Nightly have been failing. Looks like this is due to an issue in the refguide. https://ci-hadoop.apache.org/view/HBase/job/HBase/job/HBase%20Nightly/job/branch-2.3/" "Backport HBASE-24368 ""Let HBCKSCP clear 'Unknown Servers', even if RegionStateNode has RegionLocation == null""",13337404,Resolved,Major,Fixed,27/Oct/20 11:13,28/Oct/20 16:20,, YouAreDeadException should be moved to hbase-server module,13335986,Resolved,Major,Fixed,19/Oct/20 02:35,28/Oct/20 07:09,,"Since it will be thrown from the region server reports, it will not be propagated to client, we should move this class to hbase-server." MasterStoppedException should be moved to hbase-client module,13334807,Resolved,Major,Fixed,10/Oct/20 13:20,28/Oct/20 07:08,,"Since it will be thrown from the HMaster.checkInitialized which will be called in a rpc call method, which means it will be propagated to client, we should move this class to hbase-client." Optimize in-memory representation for HBase map reduce table splits for MultiTableInputFormat,13337716,Open,Major,,28/Oct/20 17:45,,,"It has been observed that when the table has too many regions, MR jobs consume a lot of memory in the client. This is because we keep the region level information in memory and the memory heavy object is TableSplit because of the Scan object as a part of it. There is a jira [HBASE-24859|https://issues.apache.org/jira/projects/HBASE/issues/HBASE-24859] which fix this single table TableInputFormat because we do not use the scan object from TableSplit in this case. However, it looks like we can do some optimization in case of MultiTableInputFormat as well since each split is not required to have memory heavy scan object." "Backport HBASE-24369 ""Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately"" to branch-2.2",13337212,Resolved,Major,Fixed,26/Oct/20 13:14,27/Oct/20 05:51,, "Backport HBASE-24246 ""Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration"" to branch-2.2",13337226,Resolved,Major,Fixed,26/Oct/20 14:12,26/Oct/20 20:17,, Nightly job failed as the name of jdk and maven changed,13336195,Resolved,Major,Fixed,20/Oct/20 05:29,20/Oct/20 09:35,,"See  [https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/85/console] [https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/103/console]   org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed: WorkflowScript: 508: Tool type ""maven"" does not have an install of ""Maven (latest)"" configured - did you mean ""maven_latest""? @ line 508, column 19. maven 'Maven (latest)' ^ WorkflowScript: 510: Tool type ""jdk"" does not have an install of ""JDK 1.8 (latest)"" configured - did you mean ""jdk_1.8_latest""? @ line 510, column 17. jdk ""JDK 1.8 (latest)""  " Change the reference url to flaky list in our jenkins jobs,13336192,Resolved,Major,Fixed,20/Oct/20 04:59,20/Oct/20 09:17,,"Nightly Flaky tests PreCommit personality" Do not publish workspace in flaky find job,13335915,Resolved,Major,Fixed,18/Oct/20 06:15,20/Oct/20 04:47,,"As said in the parent issue. And I tried to use the publishHTML target on jenkins job configuration page, the help message for reportDir is {noformat} The path to the HTML report directory relative to the workspace. {noformat} For the reportFiles is {noformat} The file(s) to provide links inside the report directory {noformat} I think this clearly means that the plugin will publish all the files under reportDir, the reportFiles is just the index page." TestMasterFailover.testSimpleMasterFailover is flaky ,13333799,Resolved,Major,Fixed,05/Oct/20 21:28,25/Oct/20 09:44,3.0.0-alpha-1,"{noformat} [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 32.996 s <<< FAILURE! - in org.apache.hadoop.hbase.master.TestMasterFailover [ERROR] org.apache.hadoop.hbase.master.TestMasterFailover.testSimpleMasterFailover Time elapsed: 12.317 s <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<2> at org.apache.hadoop.hbase.master.TestMasterFailover.testSimpleMasterFailover(TestMasterFailover.java:133) {noformat} Looks like this test depends on metrics to be updated as a source of side-effect used to verify the test. Seems like it should retry the check a few times, or maybe we need a last-updated monotonic value that the test can check before and after it expects a change to be visible." JVMMetrics tag.processName regression between hbase-1.3 and hbase-2.x+ versions,13335713,Open,Major,,16/Oct/20 05:44,,2.0.0,"The regression is caused by https://issues.apache.org/jira/browse/HBASE-15160. In order to monitor the FS latencies and pread latencies we have added the MetricsIO as part of metrics. Since we account this at the HFileBlock layer, we have created a static MetricIO variable at HFile.java so that we can use that metrics in a static way. Internally the MEtricIO creates a MetricsIOWrapperImpl that in turns registers the metrics with the BaseSource. The flow is as follows, {code} this(CompatibilitySingletonFactory.getInstance(MetricsRegionServerSourceFactory.class) .createIO(wrapper), wrapper); {code} The createIO -> inturn creates a MetricsIOSourceImpl where the Metrics_Name is 'IO'. The BaseSourceImpl registers a singleton JVMMetrics {code} synchronized void init(String name) { ....... DefaultMetricsSystem.initialize(HBASE_METRICS_SYSTEM_NAME); JvmMetrics.initSingleton(name, """"); ........ } {code} The name passed here is 'IO'. This is where the processName gets set with 'IO'. All other metrics that we create in the HRS and master is not static level metrics whereas all are instance level metrics. So the very first time we create either Master metrics or Region server metrics so then the metrics would have had the processName as either RegionServer or master. But pls note am note very sure on this now like if at all are we creating a metric based on the actual process name like it was during the hbase-1.x time. In other words my doubt is even if we solve this 'IO' process case do we really get back the processName as 'Master' or 'RegionServer' as in https://issues.apache.org/jira/browse/HBASE-12328. " Cleanup the /tmp/std*deferred files generated by surefire,13333331,Resolved,Major,Won't Fix,04/Oct/20 14:34,18/Oct/20 03:44,,"It is very easy to eat a lot of spaces and make the new jenkins node full. Surefire plugin should clean these files but obviously, if the process does not quit normally,it has no way to delete the files. So we have to do it by our own. Either an extra jenkins pipeline stage, or just a cron job?" Try create table with 100 regions for branch-2.2 nightly job's hadoop integration test,13334919,Resolved,Major,Won't Fix,12/Oct/20 03:21,15/Oct/20 07:31,,"It still failed now. [https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/88/execution/node/171/log/]   [https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/88//artifact/output-integration/hadoop-2.log]   It failed when create table with 1000 regions. And not import the example TSV to HDFS." Validate earlier coprocessors against HBase 3.0+,13335289,Open,Major,,13/Oct/20 21:37,,3.0.0-alpha-1,"we should do something similar to HBASE-20656 but for the coprocessor APIs folks may be using from hbase 2. Probably a good idea to make sure the check against HBase 1 coprocessors still works, presuming we still support any HBase 1 by the time we expect HBase 3." Update documentation about meta region replica,13334746,Resolved,Major,Fixed,10/Oct/20 00:44,13/Oct/20 02:16,, Unify WAL name timestamp parsers,13334745,Resolved,Major,Fixed,10/Oct/20 00:40,12/Oct/20 15:04,,"Turns out there are two methods for extracting timestamp from WAL filename. Fix. Spotted by [~zhangduo]  in review of HBASE-22976...  " Remove the hadoop 3.3.0 personality hadoopcheck for branch-2.2/branch-2.3,13334923,Resolved,Major,Duplicate,12/Oct/20 04:19,13/Oct/20 02:30,2.2.6,"For branch-2.2, see [https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/88/execution/node/163/log/]  It will fail when run ""mvn clean install -DskipTests -DHBasePatchProcess -Dhadoop-three.version=3.3.0 -Dhadoop.profile=3.0"".   For branch-2.3, see HBASE-23834. HBase failed to start on hadoop 3.3.0 because the jetty problem." Update Hadoop compatibility guidelines in book re: Hadoop 3.3.0,13335066,Open,Major,,12/Oct/20 18:26,,3.0.0-alpha-1,Discussion raised on HBASE-25144 indicated that the book need an explicit mention of Hadoop 3.3.0. Work out what that update is and apply it. Remove the constructors of HBaseConfiguration,13334791,Resolved,Major,Fixed,10/Oct/20 09:56,11/Oct/20 15:15,3.0.0-alpha-1,As they have been marked as deprecated long ago. No need timelineservice for branch-2.2 nightly job's hadoop integration test,13334774,Resolved,Major,Fixed,10/Oct/20 08:16,12/Oct/20 03:17,,"[https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/86/execution/node/171/log/]   /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_branch-2.2/component/dev-support/hbase_nightly_pseudo-distributed-test.sh --single-process --working-dir output-integration/hadoop-2 --hbase-client-install hbase-client hbase-install hadoop-2/bin/hadoop {color:#ff0000}hadoop-2/share/hadoop/yarn/timelineservice{color} hadoop-2/share/hadoop/yarn/test/hadoop-yarn-server-tests-2.8.5-tests.jar hadoop-2/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.8.5-tests.jar hadoop-2/bin/mapred   branch-2.2 still use hadoop 2.8.5 and hadoop 2.8.5 doesn't have timelineservice. The dev-support/hbase_nightly_pseudo-distributed-test.sh not consider this timelineservice and only consider 5 paramerters. But branch-2.3+ use 2.10.x hadoop, so they consider 6 parameters.   And for hadoop-3, the timelineservice is not used, too. See [https://github.com/apache/hbase/blob/master/dev-support/hbase_nightly_pseudo-distributed-test.sh#L286]      " supporting hbase on aarch64 platform,13334755,Open,Major,,10/Oct/20 02:51,,,"HBase release 2.3.2 on September 21, 2020.   I download a new version and test on my machine. At first, I found that the fire-flame on x86 platform and aarch64 platform were inconsistent. On X86 platform netty use epoll, but on aarch64 platform netty use nio. Further I find out the code judge if use epoll make the difference. It do not consider aarch64 platform. Beside is the code: {color:#4c9aff}return epollEnabled && JVM.isLinux() && JVM.isAmd64();{color} When i add the aarch64 judge branch, i found regionserver can not start because of native lib libnetty-transport-native-epoll.so could not be loaded.   I check the third party jar package about HBase-2.3.2, and get the following table. |third party jar info of HBase-2.3.2|latest jar package info| |third party jar package|release time|lib in jar package do not support aarch64 platform|latest version|release time|Supporting aarch64？| |commons-crypto-1.0.0.jar|2016/7/26|libcommons-crypto.so|commons-crypto-1.1.0.jar|2020/8/28|Yes| |jline-2.11.jar|2013/5/19|libjansi.so|jline-2.14.6.jar|2018/3/26|No| |leveldbjni-all-1.8.jar|2013/10/17|libleveldbjni.so|leveldbjni-all-1.8.jar|2013/10/17|No| |netty-all-4.0.23.Final.jar|2014/8/15|libnetty-transport-native-epoll.so|netty-all-4.1.52.Final.jar|2020/9/8|Yes| |snappy-java-1.0.5.jar|2013/5/17|libsnappyjava.so|snappy-java-1.1.7.7.jar|2020/8/26|Yes|   According to the table above, we can get the following conclusions: 1、third party jar package is now supporting aarch64 platform(apache hadoop is now release 3.3.0 to support aarch64, more and more bigdata component is now supporting aarch64 platform); 2、we now have only leveldbjni-all and jline packages do not support aarch64 platform.   I wish HBase community can support aarch64 platform on hbase in not far future." Make flaky tests run more aggressively,13334177,Resolved,Major,Fixed,07/Oct/20 12:39,10/Oct/20 08:19,, Remove ZNodePaths.namespaceZNode,13334769,Resolved,Major,Fixed,10/Oct/20 07:24,10/Oct/20 08:17,3.0.0-alpha-1,"In HBASE-21154, had removed the dependency on  ZNodePaths.namespaceZNode, so remove this field." Increase the timeout value for nightly jobs,13334178,Resolved,Major,Fixed,07/Oct/20 12:41,10/Oct/20 00:39,,"The new hbase node is m5.2xlarge, which means it has 8 cores and 32 GB memory, while the old H node has 16 or 24 cores, 100GB memory, so it will spend more time to finish the nightly jobs. Since the new nodes are exclusive for HBase only, we are free to increase the timeout value." Refactor AccessController and VisibilityController,13334103,Resolved,Major,Fixed,07/Oct/20 02:09,08/Oct/20 08:12,,"After HBASE-24602, the batchMutate() related coprocessor methods of RegionObserver are called when increment/append operations are performed. We can refactor AccessController and VisibilityController to make use of that." The new hbase jenkins node has something wrong when running UTs,13330373,Resolved,Major,Fixed,01/Oct/20 13:48,07/Oct/20 12:33,, Migrate HBase-Operator-Tools-PreCommit jenkins job from Hadoop to hbase,13330333,Resolved,Major,Fixed,01/Oct/20 10:39,02/Oct/20 09:48,, Migrate HBase-Connectors-PreCommit jenkins job from Hadoop to hbase,13330332,Resolved,Major,Fixed,01/Oct/20 10:34,02/Oct/20 09:54,, Migrate HBase Nightly jenkins job from Hadoop to hbase,13330287,Resolved,Major,Fixed,01/Oct/20 05:45,01/Oct/20 06:49,, Migrate flaky test jenkins job from Hadoop to hbase,13330286,Resolved,Major,Fixed,01/Oct/20 05:44,01/Oct/20 06:43,, Migrate HBase PreCommit jenkins job from Hadoop to hbase,13330288,Resolved,Major,Later,01/Oct/20 05:48,07/Oct/20 12:37,, Add extra logging at info level to HFileCorruptionChecker in order to report progress,13330533,Resolved,Major,Fixed,02/Oct/20 11:02,06/Oct/20 07:45,,"Currently there's no progress reporting in HFileCorruptionChecker: neither in the logs nor in stdout. It only creates a report about the entire operation at the end of the process and emits some warning messages is corruption is found. Adding some logging about the progress would be beneficial for long running checks indicating that the process is running healthy." Set java.io.tmpdir to project build directory to avoid writing std*deferred files to /tmp,13333720,Resolved,Major,Fixed,05/Oct/20 12:48,06/Oct/20 00:48,, Should store the regionNames field in state data for ReopenTableRegionsProcedure,13330558,Resolved,Major,Fixed,02/Oct/20 13:22,05/Oct/20 10:29,,"We add this field in HBASE-22460 to make use of ReopenTableRegionsProcedure for reopening user specified regions, but we do not serialize it in the state data, so once master restart and we are still in the first state, we will miss the regionNames and reopen all the regions." Upgrade yetus to 0.12.0,13333250,Resolved,Major,Duplicate,04/Oct/20 13:01,06/Oct/20 12:20,,Catch up with the newest version. Flaky Test Dashboard scripts are blocked,13333798,Open,Major,,05/Oct/20 21:23,,,"The Flaky Test Dashboard hosted on ci-hadoop is no longer usable by humans because the browser blocks its scripts from executing. No images are loaded and none of the javascript functions work. https://ci-hadoop.apache.org/view/HBase/job/HBase/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/dashboard.html" TestMasterRegionCompaction is flaky,13333801,Open,Major,,05/Oct/20 21:34,,3.0.0-alpha-1,"{noformat} [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 10.298 s <<< FAILURE! - in org.apache.hadoop.hbase.master.region.TestMasterRegionCompaction [ERROR] org.apache.hadoop.hbase.master.region.TestMasterRegionCompaction.test Time elapsed: 10.269 s <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<4> at org.apache.hadoop.hbase.master.region.TestMasterRegionCompaction.test(TestMasterRegionCompaction.java:136) {noformat} This test uses calls to {{Thread.sleep}} of fixed durations instead of the {{waitFor}} pattern of retries. It's looking for side-effects of a background thread that may not be scheduled on precisely the cadence that the test expects, especially in an overloaded test environment." Scan metrics are not reported to Hadoop MapReduce counters,13330560,Open,Major,,02/Oct/20 13:23,,1.2.0,"I setup a MapReduce job that scans HBase table with scan metrics enabled via Java API: {code:java} Scan scan = ...; scan.setScanMetricsEnabled(true); // Or via attribute scan.setAttribute( Scan.SCAN_ATTRIBUTES_METRICS_ENABLE, Bytes.toBytes(true)); TableMapReduceUtil.initTableMapperJob(...); job.waitForCompletion(true) {code} I expect HBase scan related counters to appear with current values in Hadoop web UI after job starts or in CLI after job ends alongside other counters such as CPU_MILLISECONDS. But no metrics were displayed. I can clearly see that scan is performed and mappers got non-zero inputs. The JAR version is  1.2.0-cdh5.16.1." Improve the experience of using the Master webpage by change the loading process of snapshot list to asynchronous,13347689,Resolved,Minor,Fixed,24/Dec/20 04:51,25/Dec/20 02:33,3.0.0-alpha-1,"Background: When there are many snapshots, loading the master webpage is very slow, which affects the experience. (Our cluster has more than 3000  snapshots, and it takes about 10 seconds to load the master webpage each time)   1. The snapshot list is not in the master memory, hdfs need to be scanned when loading 2. Changing the process of loading  snapshots to asynchronous can improve the experience    " HBase UI: sorting order by start key or end key is not considering empty start key/end key,13346376,Resolved,Minor,Fixed,16/Dec/20 14:35,16/Dec/23 14:14,2.2.3,"HBase UI: sorting order by start key or end key is not considering empty start key/end key. Steps: 1: Open any table page having multiple regions 2:  click on sort button of start key/end key 3: Observed that sorting doesn't consider start and end key." Remove HStore#getStoreHomedir,13335962,Resolved,Minor,Fixed,18/Oct/20 20:27,03/Apr/21 15:56,3.0.0-alpha-1,The {{getStoreHomedir}} methods from {{HStore}} were deprecated way back and should get removed. "Remove RpcSchedulerFactory#create(Configuration, PriorityFunction)",13335958,Resolved,Minor,Fixed,18/Oct/20 20:03,21/Oct/20 13:42,3.0.0-alpha-1,"The {{create(Configuration, PriorityFunction)}} method in {{RpcSchedulerFactory}} was deprecated a while ago. As it is not used anymore, even in implementing classes, we should be able to safely remove the method." [Metrics] Add metrics for Call in IPC response queue,13337129,Open,Minor,,26/Oct/20 03:58,,,"Add metrics for response queue. E.g., number of Call/RpcResponse in queue, size of Call/RpcResponse in queue." Allow hbase-connector to be used with Apache Spark 3.0 ,13342375,Resolved,Minor,Fixed,24/Nov/20 14:08,01/Feb/21 21:27,,"Currently hbase-spark connector only works with Spark 2.x. Apache Spark 3.0 has been relesead in June 2020. This addresses the changes needed to run the connector with Spark 3.0 and also to be able to compile the connector using Spark 3.0 as a dependency." Instantiate BucketCache before RS creates a their ephemeral node when rolling-upgrade,13338006,Resolved,Minor,Won't Fix,30/Oct/20 06:12,09/Aug/22 08:02,1.4.13,"We observed many clients couldn't get information on region locations for tens of seconds during rolling-upgrade from 1.2.x to 1.4.x, and all requests to regions moved by graceful restart failed.   The reason is that # Since HBASE-17931, system tables are assigned to RS with highest version # Since HBASE-12034, bucket cache initialization process has moved from RS instantiation to RS initialization process after reporting to master, moreover an ephemeral node for RS is created before bucket cache creation. # when using offheap bucketcache, it takes too much time to allocate memory for it (18 seconds for 31GB in our case) [https://github.com/apache/hbase/blob/branch-1.4/hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferArray.java#L52-L72] # Once ephemeral nodes created, a master try to move system regions to RS with highest version when first RS restart of whole rolling-restart process. but, by 3) the RS is not ready for serving system regions yet. moving system regions keep failing until 3) is finished.   I think this could happen only in branch-1, because an ephemeral node is created after creating block caches in hbase 2.x. there is no need to create block caches after ephemeral node creation at all.   I verified this issue could be resolved by just changing their creation order." Profiling servlet ensure output directory exists and is writable,13330623,Resolved,Minor,Cannot Reproduce,02/Oct/20 20:02,10/Mar/22 14:42,2.3.0,"When the profiling servlet runs async-profiler when the output path ({{/tmp/prof-output}}) doesn't exist or isn't writable by the {{hbase}} process, it will sit in a refresh loop indefinitely. The servlet should check that the output path is writable, or even make an attempt to create the output directory, and inform the user of the situation, rather than attempting and silently failing to generate the flame graph." Redundant Reference file in bottom region of split,13342278,Resolved,Minor,Fixed,24/Nov/20 05:45,05/Nov/21 10:21,2.0.0,"When we split a region ranges from (,), the bottom region should contain keys of(,split key), and the top region should contain keys of [split key, ). Currently, if we do the following operations: # put rowkeys 100,101,102,103,104,105 to a table, and flush the memstore to make a hfile with rowkeys 100,101,102,103,104,105; # put rowkeys 200,201,202,203,204,205 to the table, and flush the memstore to make a hfile with rowkeys 200,201,202,203,204,205; # split the table region, using split key 200; # then the bottom region will has two Reference files, while the top region only has one. But we expect the bottom region has only one Reference file as the the top region. That's because when generating Reference files in child region,  the bottom region used the `PrivateCellUtil.createLastOnRow(splitRow)` cell to compare to first keys in the hfiles, while the top region used `PrivateCellUtil.createFirstOnRow(splitRow)` cell to compare to last keys in the hfiles. `LastOnRow(splitRow)` means the maximum row generated by the split row, while `FirstOnRow(splitRow)` means the minimus row generated by the split row. The split row should be in the top region. And we should use `FirstOnRow(splitRow)` compare to hfile first and last keys in both bottom and top region.  Though the redundant Reference file will not be read by the bottom region, the compaction of the redundant Reference file will result in empty file if only this redundant Reference file participates in a compaction.        " Change 'State time' in UI so sorts,13334308,Resolved,Minor,Fixed,07/Oct/20 23:28,24/Jul/21 20:05,,"Here is a minor issue. I had an issue w/ crashing servers. The servers were auto-restarted on crash. To find the crashing servers, I was sorting on the 'Start time' column in the Master UI. This basically worked but the sort is unreliable as the date we display starts with days-of-the-week. This issue is about moving to display start time in iso8601 which is sortable (and occupies less real estate). Let me add some images." Add option to toggle CACHE_BLOCKS in count.rb,13340356,Resolved,Minor,Fixed,12/Nov/20 21:03,24/Nov/20 15:14,,"A trick I've found myself doing a couple of times (hat-tip to [~psomogyi]) is to edit table.rb so that the `count` shell command will not instruct RegionServers to not cache any data blocks. This is a quick+dirty way to force a table to be loaded into block cache (i.e. for performance testing). We can easily add another option to avoid having to edit the ruby files." Improve SizeCachedKV variants initialization,13335420,Resolved,Minor,Fixed,14/Oct/20 13:43,24/Nov/20 16:48,,Currently in SizeCachedKV we get the rowlength and Key length from the buffers. This can be optimized because we can pass the keylen and row len while actually creating the cell while reading the cell from the block. Some times we see that the SizeCachedKV takes the max width in a flame graph - considering the fact we also do a sanity check on the created KV. Make REST Client connection and socket time out configurable,13344895,Resolved,Minor,Fixed,08/Dec/20 18:24,15/Mar/21 23:49,2.3.4,"Currently there is no way to configure connection and socket timeout for REST client, https://github.com/apache/hbase/blob/7d0a687e5798a2f4ca3190b409169f7e17a75b34/hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/client/Client.java#L102" NPE while running balance_rsgroup if any split region is present.,13341221,Open,Minor,,18/Nov/20 05:30,,2.2.3," NPE is thrown in below scenario: 1: Create rsgroup pgroup 2: Add two RS to pgroup 3: create two table with 15 region each 4: kill 1 RS and start again 5: disable t1 6: run balancer and balance_rsgroup 'pgroup' and observe it is working fine 7: now split one of the region of t2 8: run balance_rsgroup 'pgroup' and observe NPE:   ERROR: java.io.IOException at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:517) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) Caused by: java.lang.NullPointerException at java.util.TreeMap.put(TreeMap.java:563) at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(RSGroupBasedLoadBalancer.java:347) at org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.balanceCluster(RSGroupBasedLoadBalancer.java:140) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.balanceRSGroup(RSGroupAdminServer.java:531) at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint$RSGroupAdminServiceImpl.balanceRSGroup(RSGroupAdminEndpoint.java:302) at org.apache.hadoop.hbase.protobuf.generated.RSGroupAdminProtos$RSGroupAdminService.callMethod(RSGroupAdminProtos.java:16306) at org.apache.hadoop.hbase.master.MasterRpcServices.execMasterService(MasterRpcServices.java:1023) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:458)    " Redo the getMidPoint() in HFileWriterImpl to get rid of the double comparison process,13344391,Resolved,Minor,Fixed,06/Dec/20 03:15,10/Feb/21 16:32,,"There is a TODO like this ""TODO: Redo so only a single pass over the arrays rather than one to  compare and then a second composing midpoint."" in getMidpoint()  of class ​HFileWriteImpl​   The old logic compares the left byte array and the right byte array twice：  # A comparison is performed before composing MinimumMidpointArray # During composing of MinimumMidpointArray, bytes were comparing again   My optimization  combines them into one" ref guide for 2.2.z builds needs to be updated to include 2.2 specific details,13330393,Open,Minor,,01/Oct/20 14:58,,,"for example, it's currently missing a column for 2.2 in the hadoop compat matrix." Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time,13342457,Resolved,Minor,Fixed,24/Nov/20 19:30,20/Jan/21 12:52,,"We have metrics for number of RITs as well as number of RITs above a certain threshold, but we don't have any way of keeping track of the region hashes of those RITs. It would be beneficial to emit those region hashes as a metric, as well as log them, so that we don't accidentally lose this information for debugging the RIT at a later tiime." Procedures table Id under master web UI gets word break to single character,13346403,Resolved,Minor,Fixed,16/Dec/20 17:55,19/Dec/20 20:42,,"Under master web UI -> Procedures & Locks, *Procedures table* columns Errors and Parameters occupy larger width making Id and others word break more. Specially on Id where it breaks to single characters.   Planning to make word break only on Errors and Parameters columns leaving the others normal in this table. So that we dont have to apply any changes on width/padding to get this fixed." Refactor MultiVersionConcurrencyControl: replace readWaiters.notifyAll() with WriteEntry.notify(),13347678,Resolved,Minor,Won't Fix,24/Dec/20 03:16,15/Jan/21 11:20,,"[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java#L217]  here the notifyAll() wake up all thread, even the read point no big enough, bring extra thread switch [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java#L143]  WriteEntry object can be thread local to reuse" [github]rename HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf,13341888,Resolved,Minor,Duplicate,21/Nov/20 06:49,13/Jan/21 17:55,,"use git pull to obtain an exception, because filename has ':' !image-2020-11-21-14-48-23-794.png! workaround:git config core.protectNTFS false [~stack] i think we can ranme filename... ." Configure where IntegrationTestImportTsv generates HFiles,13342070,Resolved,Minor,Fixed,23/Nov/20 08:31,05/Jan/21 09:49,,"Currently IntegrationTestImportTsv is generating HFiles under the working directory of the hdfs user executing the tool, before bulkloading it into HBase. Assuming you encrypt the HBase root directory within HDFS (using HDFS Transparent Encryption), you can bulkload HFiles only if they sit in the same encryption zone in HDFS as the HBase root directory itself. When IntegrationTestImportTsv is executed against a real distributed cluster and the working directory of the current user (e.g. /user/hbase) is not in the same encryption zone as the HBase root directory (e.g. /hbase/data) then you will get an exception:   {code:java} ERROR org.apache.hadoop.hbase.regionserver.HRegion: There was a partial failure due to IO when attempting to load d : hdfs://mycluster/user/hbase/test-data/22d8460d-04cc-e032-88ca-2cc20a7dd01c/IntegrationTestImportTsv/hfiles/d/74655e3f8da142cb94bc31b64f0475cc org.apache.hadoop.ipc.RemoteException(java.io.IOException): /user/hbase/test-data/22d8460d-04cc-e032-88ca-2cc20a7dd01c/IntegrationTestImportTsv/hfiles/d/74655e3f8da142cb94bc31b64f0475cc can't be moved into an encryption zone. {code}   In this ticket I make it configurable where the IntegrationTestImportTsv generates the HFiles. From now, one can execute this integration test on HDFS Transparent Encryption enabled clusters, like: {code:java} ./bin/hbase org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv -D IntegrationTestImportTsv.generatedHFileFolder=//testdata{code}" Slow metric value can be configured,13347284,Resolved,Minor,Fixed,22/Dec/20 06:53,06/Jan/21 07:18,,"The slow time in MetricsRegionServer is hard code (value :1000) it's should be configured when some cluster is sensitived" Followup jira to address the client handling issue when chaning from meta replica to non-meta-replica at the server side.,13340929,Resolved,Minor,Fixed,16/Nov/20 22:10,05/Jan/21 17:24,,"[https://github.com/apache/hbase/pull/2643]   {quote} With my operator hat on, I'd assume that LOAD_BALANCE with 1 replica count works like no read replicas configured (logic wise at-least, even though the code paths are different). {quote}If the server side does not support meta replica, the client side cannot be configured to support this mode {quote} Since clients are usually long running (meaning we may not be able to restart client or they using cached HBase connection) and meta replica count can be altered on the service side on the fly, I'd expect client to work across these changes without any configuration changes. WDYT? {quote}" Make retry pause time configurable for regionserver short operation RPC (reportRegionStateTransition/reportProcedureDone),13345094,Resolved,Minor,Fixed,09/Dec/20 14:27,29/Dec/20 17:10,,"Currently initPauseTime is hard coded as 1000, https://github.com/apache/hbase/blob/c853c99b209cb2dfefb8d15595d9a9a5469e24fa/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L2440 But in case of ServerNotRunningYetException/PleaseHoldException/CallQueueTooBigException RegionServer may wait for a long time (In our case it was ~7 min). Currently we calculate pause time based on the number of retries and RETRY_BACKOFF. So in a failure case RS will wait max 200 sec and wait will be always 200 sec if retries further goes beyond 13. We should make it configurable." Some minor improvements in rpc implementation,13346920,Resolved,Minor,Fixed,19/Dec/20 12:17,20/Dec/20 03:44,,"To cleanup the warnings and checkstyle issues, remove unnecessary references and so on." Flaky Test,13346796,Open,Minor,,18/Dec/20 14:20,,2.3.2,"Hello, we are a group of researchers interested in understanding methods to reduce costs associated with Test Flakiness [1]. We developed an approach to detect flaky tests, dubbed Shaker [2]. Shaker spawns stressor tasks in the running environment (e.g., tasks that consume lots of cpu or memory) to identify if perturbations can make tests fail. We ran Shaker on hbase project and found the following likely flaky tests: * org.apache.hadoop.hbase.io.hfile.bucket.TestVerifyBucketCacheFile.testRetrieveFromFile - failed 5 times in 12 reruns. org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testBackgroundEvictionThread - failed 4 times in 12 reruns. org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.testTake - failed 1 time in 12 reruns. [Denini|https://github.com/denini08], [Leopoldo|https://github.com/leopoldomt] and [Marcelo|https://github.com/damorim]. [1] [https://hackernoon.com/flaky-tests-a-war-that-never-ends-9aa32fdef359]   [2] D. Silva, L. Teixeira and M. d’Amorim, ""Shake It! Detecting Flaky Tests Caused by Concurrency with Shaker,"" _2020 IEEE International Conference on Software Maintenance and Evolution (ICSME)_, Adelaide, Australia, 2020, pp. 301-311, [https://ieeexplore.ieee.org/document/9240694/]." The log in move_servers_rsgroup is incorrect,13344486,Resolved,Minor,Fixed,07/Dec/20 04:33,16/Dec/20 04:33,2.4.0,"Assuming that server1 belongs to the default group, execute the command:   {code:java} move_servers_rsgroup 'test',['server1:16020'] {code} We can see log:   {code:java} Moving 10 region(s) to group test, current retry=0 ...... All regions from server(s) [server1,16020,1607067542905] moved to target group test. {code} The target group should be the source group in log: test -> default.   https://github.com/apache/hbase/blob/7d0a687e5798a2f4ca3190b409169f7e17a75b34/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java#L1027        " [create-release] Add timestamping to log output,13345111,Resolved,Minor,Fixed,09/Dec/20 16:45,10/Dec/20 00:54,,"Add a timestamp when we output a status message. Without it is more difficult figuring where the time is being spent building. Updated the README too adding some setup text copied from the head of the script. The README is better place for this." "Quoting in hbase-vote script fails build with empty """"",13344315,Resolved,Minor,Fixed,05/Dec/20 00:59,09/Dec/20 19:33,2.4.1,"HBASE-25085 added support for maven options to be passed into the hbase-vote script. However, with the quoting on my machine it fails if I do not pass in any maven opts: * Signature: ok * Checksum : ok * Rat check (1.8.0_92): failed - mvn clean apache-rat:check """" * Built from source (1.8.0_92): failed - mvn clean install -DskipTests """" * Unit tests pass (1.8.0_92): failed - mvn package -P runAllTests """" -Dsurefire.rerunFailingTestsCount=3 Notice the """" and the build failed due to unknown lifecycle """"" Add builder method to create Tags.,13342432,Resolved,Minor,Fixed,24/Nov/20 17:18,08/Dec/20 12:56,,"In PHOENIX-6213 phoenix project is using Cell Tag feature to add some metadata for delete mutations. We are adding Cell Tags in co-processor but we need some util methods available in +PrivateCellUtil+ class.  Below are the methods we need in phoenix. 1. +PrivateCellUtil#createCell(Cell cell, List tags)+ method has an api which will accept an existing Cell and list of tags to create a new cell.  But RawCellBuilder has a builder method which doesn't have any method which accepts a cell. I need to explicitly convert my input cell by extracting all fields and use the builder methods (like setRow, setseFamily, etc) and then use the build method.   2. +PrivateCellUtil.getTags(Cell cell)+ returns a list of existing tags which I want to use and add a new tag. But RawCell#getTags() returns Iterator  which then I have to iterate over them and depending on whether they are byte buffer backed or array backed, I need to convert them to List since RawCellBuilder#setTags accepts List of Tags. We are already doing this conversion in PrivateCellUtil#getTags method. All these conversion utility methods needs to be duplicated in phoenix project also.   Is it reasonable to make PrivateCellUtil method LimitedPrivate with HBaseInterfaceAudience as COPROC ?" Remove processingServers in DeadServer as we can get this information by Procedure of master,13340477,Resolved,Minor,Fixed,13/Nov/20 09:57,25/Nov/20 07:24,,"We can directly get the servers in processing through proceduces in master as long as proceduce is a instance of `ServerCrashProcedure` *Our final goal is to remove class `DeadServer`*, the next step is to remove the deadServers attributes in DeadServer and then we can freely delete the class " Embedded zookeeper server not clean up the old data,13338027,Resolved,Minor,Fixed,30/Oct/20 08:35,03/Dec/20 09:29,,"The size of zookeeper data dir keeps increasing. I checked the source code and found the zookeeper data cleanup manager is not started by hbase. The standalone zookeeper server runs the data cleanup manager but hbase does not. I suggest add the code below at the beginning of org.apache.hadoop.hbase.zookeeper.HQuorumPeer.runZKServer(): {code:java} // Start and schedule the the purge task DatadirCleanupManager purgeMgr=new DatadirCleanupManager( zkConfig.getDataDir(), zkConfig.getDataLogDir(), zkConfig.getSnapRetainCount(), zkConfig.getPurgeInterval()); purgeMgr.start(); {code} I've been running this code in my hbase cluster for quite a long time without problem." "API compatibilty checker fails with ""Argument list too long"" on Mac OS",13343891,Open,Minor,,03/Dec/20 02:47,,2.4.0,"While working on the 2.4.0 RC I hit a stumbling block where the argument list passed to javap by the API compatibility checker is too large for Mac OS. Attempted execution of the forked process fails with ""Argument list too long""." Method parameter and member variable are duplicated in checkSplittable() of SplitTableRegionProcedure,13343139,Resolved,Minor,Fixed,29/Nov/20 01:28,30/Nov/20 12:47,3.0.0-alpha-1,"We input a 'this.bestSplitRow' as 'splitRow' of checkSplittable() {code:java} private void checkSplittable(final MasterProcedureEnv env, final RegionInfo regionToSplit, final byte[] splitRow) {code} But this private method could used 'bestSplitRow' directly" Remove unnecessary array to list conversion in SplitLogManager,13342320,Resolved,Minor,Fixed,24/Nov/20 09:53,27/Nov/20 00:37,,"{code:java} public static List getFileList(final Configuration conf, final List logDirs, final PathFilter filter) throws IOException { List fileStatus = new ArrayList<>(); .... FileStatus[] a = new FileStatus[fileStatus.size()]; //list to array return fileStatus.toArray(a); } public List getWALsToSplit(ServerName serverName, boolean splitMeta) throws IOException { List logDirs = master.getMasterWalManager().getLogDirs(Collections.singleton(serverName)); FileStatus[] fileStatuses = SplitLogManager.getFileList(this.conf, logDirs, splitMeta ? META_FILTER : NON_META_FILTER); LOG.info(""{} WAL count={}, meta={}"", serverName, fileStatuses.length, splitMeta); //array convert to list which is just contrary to the logic of getFileList return Lists.newArrayList(fileStatuses); {code} After judge the logic, there seems no need to make such a conversion. " Fix potential NPE when the zookeeper path of RegionServerTracker does not exist when start,13342305,Resolved,Minor,Fixed,24/Nov/20 08:58,25/Nov/20 07:40,," !image-2020-11-24-16-56-04-411.png! !image-2020-11-24-16-58-04-621.png! " Remove unused class ClusterSchemaException,13342327,Resolved,Minor,Fixed,24/Nov/20 10:15,25/Nov/20 07:28,,"Currently, ClusterSchemaException is useless, so we can freely delete it" Bulkload split hfile too many times due to unreasonable split point,13340442,Resolved,Minor,Fixed,13/Nov/20 07:13,25/Nov/20 07:29,,"[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFilesTool.java#L688] if hfile span multi regions, for example A,B,C,D,E,F(the start key of these regions are in ascending order), we should use region C endkey to split, not region A. In this way, we can get equal .top and .bottom hfiles, reduce time complexity of split from O( n ) to O(logn),decrease invoke of {{bulkLoad}} rpc to regionserver ,and also avoid write amplification during {{copyHFileHalf}}" Should request Compaction when bulkLoadHFiles is done,13336683,Resolved,Minor,Fixed,22/Oct/20 10:19,25/Nov/20 00:05,, Enhance balancer to make sure no meta primary/replica regions are going to be assigned to one same region server.,13334048,Open,Minor,,06/Oct/20 18:55,,,"Region replica has enhancement in balancer that primary region and its replicas are not going to be assigned to the same region server. Today, there is only one meta region, so this enhancement is still enough. With split meta coming in, it needs to make sure that no meta regoin/replicas is going to be assigned to the same region server in order to avoid hotspot issue." Followup jira to encap all meta replica mode/selector processing into CatalogReplicaModeManager,13338884,Open,Minor,,04/Nov/20 18:20,,,"This is follow up with Stack's comments in [https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0.] {quote} h4. *[saintstack|https://github.com/saintstack]* [6 days ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r514558880]  Member Yeah, said this before but in follow-on, would be good to shove all this stuff into a CatalogReplicaMode class. Internally this class would figure which policy to run. It would have a method that took a Scan that allowed decorating the Scan w/ whatever the mode needed to implement its policy. Later.   [!https://avatars1.githubusercontent.com/u/62515050?s=60&v=4|width=28,height=28!|https://github.com/huaxiangsun]  h4. *[huaxiangsun|https://github.com/huaxiangsun]* [6 days ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r514587250]  Author Member Now I thought about it, it makes sense. Maybe a CatalogReplicaModeManager class which encaps mode and selector? Let me create a followup jira after this is merged.   {quote}" "Followup jira to create single thread ScheduledExecutorService in AsyncConnImpl, and schedule all these periodic tasks",13338887,Open,Minor,,04/Nov/20 18:41,,,"This is a followup Jira for comments in [https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0.]  {quote} h4. *[saintstack|https://github.com/saintstack]* [18 hours ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517040579] Member So, implements Stoppable rather than do what the likes of AuthUtil does where it does createDummyStoppable and then has an internal do-nothing Stoppable? Makes sense. Perhaps add comment that it is a do-nothing stop required by ScheduledChore impls. s/isStopped/stopped/  [!https://avatars1.githubusercontent.com/u/62515050?s=60&v=4|width=28,height=28!|https://github.com/huaxiangsun] h4. *[huaxiangsun|https://github.com/huaxiangsun]* [18 hours ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517042290] Author Member Will do.  [!https://avatars2.githubusercontent.com/u/45484?s=60&v=4|width=28,height=28!|https://github.com/ndimiduk] h4. *[ndimiduk|https://github.com/ndimiduk]* [17 hours ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517057141] Member Maybe in the future we can put a default empty implementation on the interface, and then implementers who don't need it can ignore it.  [!https://avatars3.githubusercontent.com/u/4958168?s=60&u=fc28b222c03c02201d705b025a5293d6c471f7b3&v=4|width=28,height=28!|https://github.com/Apache9] h4. *[Apache9|https://github.com/Apache9]* [17 hours ago|https://github.com/apache/hbase/pull/2584/commits/d99c2b0ccfd2a57150e984742d097d1e1fcc47b0#r517057999] Member Maybe we could just use a ScheduledExecutorService at client side, the ChoreService is designed to be used at server side I believe. Anyway, not a blocker for now. {quote}" Remove class DeadServer ,13341778,Open,Minor,,20/Nov/20 11:52,,,"This issue is following issue [HBASE-25282|https://issues.apache.org/jira/browse/HBASE-25282] We can directly use instance of ServerCrashProcedure to replace the role DeadServer plays" remove EOM branches from test personality file,13340730,Open,Minor,,15/Nov/20 23:05,,,while getting the PR together for HBASE-25083 I noticed our yetus personality in the default branch still has logic for branch-2.0 and branch-2.1. remove it. gson format of RpcServer.logResponse is abnormal,13338579,Resolved,Minor,Fixed,03/Nov/20 07:53,05/Nov/20 14:58,2.2.6,"It will turn ‘=’ into ‘\u003d’. ipc.RpcServer(550): (responseTooSlow): {""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1604389131993"",""responsesize"":""64"",""method"":""Multi"",""param"":""region{color:#ff0000}\u003d{color} test,,1604389129684.8812226d0f8942b24892c79e3c393b26., for 10 action(s) and 1st row key{color:#ff0000}\u003d{color}11"",""processingtimems"":20,""client"":""172.1.0.3:61264"",""queuetimems"":0,""multi.servicecalls"":0,""class"":""MiniHBaseClusterRegionServer"",""multi.mutations"":10}" Move HMaster inner classes out,13339127,Resolved,Minor,Fixed,06/Nov/20 08:27,07/Nov/20 12:30,,A simple refactoring to make HMaster file smaller. It is about 4k lines for now. Delete dev-support/jenkins_precommit_jira_yetus.sh,13337959,Resolved,Minor,Fixed,29/Oct/20 22:53,02/Nov/20 21:22,,"We no longer accept contributions via patches attached to Jira. As such, this script in dev-support can be deleted." [branch-1] Fix Java 11 runtime issue in UnsafeAccess,13337755,Resolved,Minor,Fixed,28/Oct/20 22:18,29/Oct/20 21:42,,When running tests with Java 11 UnsafeAccess is observed to throw NoSuchMethodErrors. Some of our methods accept 'int' parameters and use them as parameters to Unsafe methods which should take 'long'. Not an issue on branch-2 and up. Use try-with-resources statement in snapshot package,13337547,Resolved,Minor,Fixed,28/Oct/20 01:52,28/Oct/20 16:21,,Using try-with-resources statement makes the code simpler. [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level,13335569,Resolved,Minor,Fixed,15/Oct/20 08:45,26/Oct/20 03:03,,Add *checkAndPut* and *checkAndDelete* table latency metrics. Add support for row prefix and type in the WAL Pretty Printer and some minor fixes,13335911,Resolved,Minor,Fixed,18/Oct/20 04:57,23/Oct/20 07:38,,"Currently, the WAL Pretty Printer has an option to filter the keys with an exact match of row. However, it is super useful sometimes to have a row key prefix instead of an exact match. The prefix can act as a full match filter as well due to the nature of the prefix. Secondly, we are not having the cell type in the WAL Pretty Printer in any of the branches. Lastly, the option rowkey only options prints additional stuff as well. " [branch-1] getNumOpenConnections is not effective,13335918,Resolved,Minor,Fixed,18/Oct/20 07:00,19/Oct/20 03:01,,"In MetricsHBaseServerWrapperImpl {code} @Override public int getNumOpenConnections() { if (!isServerStarted() || this.server.connectionList == null) { return 0; } return server.connectionList.size(); } {code} But connectionList is created by Collections.synchronizedList(new LinkedList()); So each connectionList.size() will compete for the mutex, we can easily replace it with another parameter *numConnections*, as for metrics, it is enough." While emitting the memstore read based metrics use # instead of _ while emitting them metric,13330276,Resolved,Minor,Won't Fix,01/Oct/20 04:46,01/Oct/20 05:07,,"We do have table names with '_' in it. so it should be '#' that we use as the seperator when we emit the metric out. Usually _ is used for all other metric detail but here since we do that grouping of the metric based on table and store name - it is better we use another seperator instead of '_' for these metrics. " Add CLI support to remove a particular configuration from ReplicationPeerConfig.,13336358,Resolved,Minor,Not A Problem,20/Oct/20 18:39,20/Oct/20 19:23,,"Currently, there is no easy way to remove a configuration from ReplicationPeerConfig after it is being set. This can come in handy at multiple instances when we want to remove a particular configuration when it's not needed anymore or it is causing unexpected behavior. For eg in case there is a need to remove a walFilter (hbase.replication.source.custom.walentryfilters) configuration. As part of this Jira we want to add that support.  " Running an hbase-shell command in non-interactive mode should not complain about missing files when it fails to talk to the cluster.,13336334,Open,Minor,,20/Oct/20 16:27,,,"if you script out some shell commands, then run them via the shell in non-interactive mode we sometimes give an erroneous ""I couldn't find that file"" response when the master(s) are in a bad state instead of revealing the underlying cluster issue. e.g. {code} tmpfile=$(mktemp) echo ""balance_switch false"" > $tmpfile echo ""exit"" >> $tmpfile $HBASE_BIN --config $CONF_DIR shell -n $tmpfile RET=$? rm $tmpfile exit $RET {code} as an example, with a master stuck trying to initialize as active the failure might look like {code} ++ mktemp + tmpfile=/tmp/tmp.dMHTj0nVXx + echo balance_switch true + echo exit + bin/hbase --config /etc/hbase/conf shell -n /tmp/tmp.dMHTj0nVXx LoadError: no such file to load -- /tmp/tmp.dMHTj0nVXx load at org/jruby/RubyKernel.java:974
at /some/path/to/lib/hbase/bin/hirb.rb:186 + RET=1 + rm /tmp/tmp.dMHTj0nVXx + exit 1 {code} which is very confusing. the shell should report something related to an issue talking to the cluster rather than a problem with the passed script." Assert format is incorrect in HFilePerformanceEvaluation class.,13335049,Resolved,Minor,Fixed,12/Oct/20 16:12,16/Oct/20 06:45,,"[HFilePerformanceEvaluation |https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java#L518] The format of expected and actual is interchanged. {code:java} PerformanceEvaluationCommons.assertValueSize(c.getValueLength(), ROW_LENGTH); {code} The first argument should be expected and second should be actual. " Add Hadoop-3.3.0 to personality hadoopcheck,13330441,Resolved,Minor,Fixed,01/Oct/20 20:37,13/Oct/20 21:21,,"Now that Hadoop 3.3.0 is released, let's figure out where it goes in our testing matrix. Start by adding it to precommit checks." Remove branch-1.3 from precommit and docs,13330439,Resolved,Minor,Fixed,01/Oct/20 20:32,05/Oct/20 18:52,3.0.0-alpha-1,"Following the [announcement|https://lists.apache.org/thread.html/r9552e9085aaac2a43f8b26b866d34825a84a9be7f19118ac560d14de%40%3Cuser.hbase.apache.org%3E] to EOL branch-1.3, update the precommit script to not consider this branch any longer, and refresh mentions of this branch in the doc." Convert the internal seperator while emitting the memstore read metrics to #,13330289,Resolved,Minor,Fixed,01/Oct/20 05:55,01/Oct/20 13:00,,"Convert the '_' seperator while forming the metric for memstore reads and mixed reads to '#'. This will avoid cases where the column family itself might have '_' in them." [Documentation] fix duplicate conf entry,13340963,Resolved,Trivial,Fixed,17/Nov/20 03:48,17/Nov/20 10:06,,"[hbase.rolling.restart|https://hbase.apache.org/book.html#hbase.rolling.restart] {panel:title=HBase 2.0+ can no longer read Sequence File based WAL file.} HBase can no longer read the deprecated WAL files written in the Apache Hadoop Sequence File format. The hbase.regionserver.hlog.reader.impl and hbase.regionserver.hlog.reader.impl configuration entries should be set to use the Protobuf based WAL reader / writer classes. This implementation has been the default since HBase 0.96, so legacy WAL files should not be a concern for most downstream users. {panel} It should be: ""The _hbase.regionserver.hlog.reader.impl_ and _hbase.regionserver.hlog.writer.impl_ ""..." Remove SingletonCoprocessorService,13335956,Resolved,Trivial,Fixed,18/Oct/20 19:45,21/Oct/20 17:06,3.0.0-alpha-1,"SingletonCoprocessorService is targeted for removal in 3.0.0. It seems that we don't depend on it anymore, so let's remove it." Some notes on RawCell,13347074,Resolved,Trivial,Fixed,21/Dec/20 04:24,21/Dec/20 16:09,,Add a few notes to RawCell on what it is. Hbase connector with apache spark,13342382,Resolved,Trivial,Invalid,24/Nov/20 14:30,27/Nov/20 16:23,,"Apache Spark 3.0 has been relesead in June 2020. This addresses the changes needed to run the connector with Spark 3.0 and also to be able to compile the connector using Spark 3.0 as a dependency." [Documentation] Fix spelling error in sync_replication.adoc,13344496,Resolved,Trivial,Fixed,07/Dec/20 06:41,07/Dec/20 14:13,3.0.0-alpha-1,"h2. 99. Operation and maintenance {quote}Case.3 How to operate when active cluster crashed If the active cluster has been crashed (it may be not reachable now), so let’s just transit the standby cluster to DOWNGRANDE_ACTIVE state, and after that, we should redirect all the requests from client to the DOWNGRADE_ACTIVE cluster. {quote} It should be: ""so let’s just transit the standby cluster to *DOWNGRADE_ACTIVE* state.""  " [Documentation] Fix spelling error,13343999,Resolved,Trivial,Fixed,03/Dec/20 11:40,03/Dec/20 13:56,,"[164.8.1. Understanding the output|https://hbase.apache.org/book.html#_understanding_the_output] {quote}This could also happen if replication is manually paused (via hbase shell disable_peer command, for example), but date keeps getting ingested in the source cluster tables.{quote} It should be: ""but *_data_* keeps getting ingested in the source cluster tables.""" Document deprecation of HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY,13335952,Resolved,Trivial,Fixed,18/Oct/20 19:20,21/Oct/20 07:20,3.0.0-alpha-1,HBASE-24359 deprecated HConstants#REPLICATION_DROP_ON_DELETED_TABLE_KEY. It should also be noted down in Javadoc when it was deprecated and when it is expected to be removed. Snapshot working dir does not retain ACLs after snapshot commit phase,13550500,Resolved,Blocker,Fixed,13/Sep/23 10:26,30/Sep/23 18:49,,"TestSnapshotScannerHDFSAclController is failing 100% on flaky dashboard.   After snapshot is committed from working dir to final destination (under /.hbase-snapshot dir), if the operation was atomic rename, the working dir (e.g. /hbase/.hbase-snapshot/.tmp) no longer preserves ACLs that were derived from snapshot parent dir (e.g. /hbase/.hbase-snapshot) while creating first working snapshot dir. Hence, for new working dir, we should ensure that we preserve ACLs from snapshot parent dir. This would ensure that final snapshot commit dir has the expected ACLs regardless of whether we perform atomic rename of non-atomic copy operation in the snapshot commit phase.  " Replication stuck after switching to new WAL but the queue is empty,13548121,Resolved,Blocker,Fixed,22/Aug/23 01:13,28/Sep/23 01:07,2.5.5,"When the speed of consuming replication WALs is high, and there are something wrong when creating new WAL, the swith of replcation source reader to new WAL in the queue may happen before the new WAL is created, then the replcation will stuck since it can not consume the new WALs soon afterwards anymore. Restarting the RS that replication stucking can make the replication recover.    " TestShadeSaslAuthenticationProvider fails for branch-2.x,13551581,Resolved,Blocker,Fixed,21/Sep/23 20:30,24/Sep/23 13:51,,"{{org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider}} is failing consistently in branch-2.x This could be a code bug as well!   For branch-2: * Nightly failing: [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/885/testReport/] For branch-2.5 * PR failing: [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5422/3/testReport/] * Nightly failing: [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/405/testReport/] For branch-2.4 * PR failing:[ [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5423/3/testReport/] * Nightly failing: [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/619/testReport/]   StackTrace copied from failed test case: {code:java} java.lang.Exception: Unexpected exception, expected but was at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:30) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=4, exceptions: 2023-09-21T17:53:07.490Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:52:04.943Z, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=4, exceptions: 2023-09-21T17:53:06.869Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:06.862Z, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Call to address=6a87b11f0f42:38383 failed on local exception: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Connection closed 2023-09-21T17:53:06.975Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:06.862Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:07.182Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:06.862Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:07.489Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:06.862Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:08.215Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:52:04.943Z, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=4, exceptions: 2023-09-21T17:53:07.597Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:07.591Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:07.703Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:07.591Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:07.909Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:07.591Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:08.215Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:07.591Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.057Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:52:04.943Z, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=4, exceptions: 2023-09-21T17:53:08.422Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:08.416Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:08.530Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:08.416Z, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Call to address=6a87b11f0f42:38383 failed on local exception: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Connection closed 2023-09-21T17:53:08.748Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:08.416Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.056Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:08.416Z, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Call to address=6a87b11f0f42:38383 failed on local exception: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Connection closed 2023-09-21T17:53:09.990Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:52:04.943Z, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=4, exceptions: 2023-09-21T17:53:09.362Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.469Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.683Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.990Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:141) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:390) at org.apache.hadoop.hbase.client.HTable.lambda$get$0(HTable.java:363) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:363) at org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:235) at org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider$3.run(TestShadeSaslAuthenticationProvider.java:230) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/javax.security.auth.Subject.doAs(Subject.java:423) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1762) at org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:230) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:19) ... 18 more Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=4, exceptions: 2023-09-21T17:53:09.362Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.469Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.683Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer 2023-09-21T17:53:09.990Z, RpcRetryingCaller{globalStartTime=2023-09-21T17:53:09.357Z, pause=100, maxAttempts=4}, java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:141) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:390) at org.apache.hadoop.hbase.client.HTable.lambda$get$0(HTable.java:363) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:363) at org.apache.hadoop.hbase.MetaTableAccessor.getTableState(MetaTableAccessor.java:1141) at org.apache.hadoop.hbase.client.ConnectionImplementation.getTableState(ConnectionImplementation.java:2235) at org.apache.hadoop.hbase.client.ConnectionImplementation.isTableDisabled(ConnectionImplementation.java:742) at org.apache.hadoop.hbase.client.RegionServerCallable.prepare(RegionServerCallable.java:214) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:101) ... 37 more Caused by: java.io.IOException: Call to address=6a87b11f0f42:38383 failed on local exception: java.io.IOException: Connection reset by peer at java.base/jdk.internal.reflect.GeneratedConstructorAccessor69.newInstance(Unknown Source) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:239) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:391) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:425) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:420) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.cleanupCalls(NettyRpcDuplexHandler.java:212) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.exceptionCaught(NettyRpcDuplexHandler.java:229) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:346) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:325) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireExceptionCaught(AbstractChannelHandlerContext.java:317) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.exceptionCaught(DefaultChannelPipeline.java:1377) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:346) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:325) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireExceptionCaught(DefaultChannelPipeline.java:907) at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.handleReadException(AbstractNioByteChannel.java:125) at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:177) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ... 1 more Caused by: java.io.IOException: Connection reset by peer at java.base/sun.nio.ch.FileDispatcherImpl.read0(Native Method) at java.base/sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39) at java.base/sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:276) at java.base/sun.nio.ch.IOUtil.read(IOUtil.java:233) at java.base/sun.nio.ch.IOUtil.read(IOUtil.java:223) at java.base/sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:356) at org.apache.hbase.thirdparty.io.netty.buffer.PooledByteBuf.setBytes(PooledByteBuf.java:259) at org.apache.hbase.thirdparty.io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1132) at org.apache.hbase.thirdparty.io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:357) at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:151) ... 8 more {code}   Also note the test class code is not same between master and branch-2.x * [https://github.com/apache/hbase/blob/master/hbase-examples/src/test/java/org/apache/hadoop/hbase/security/provider/example/TestShadeSaslAuthenticationProvider.java] * [https://github.com/apache/hbase/blob/branch-2/hbase-examples/src/test/java/org/apache/hadoop/hbase/security/provider/example/TestShadeSaslAuthenticationProvider.java]  This issue could be related to HBASE-28101" Connection attributes can become corrupted on the server side,13546202,Resolved,Blocker,Fixed,05/Aug/23 01:13,23/Aug/23 18:22,,"In ServerRpcConnection.processOneRpc, it calls processConnectionHeader and then immediately calls callCleanupIfNeeded. The parsing of the ByteBuff into the ConnectionHeader does not copy the bytes. We keep a reference to ConnectionHeader for later use, but since the underlying ByteBuff gets released in callCleanupIfNeeded, later requests can override the memory locations that the ConnectionHeader points at. The unit tests we added dont catch this possibly because they don't send enough requests to corrupt the buffers. It happens pretty quickly in a deployed cluster. We need to copy the List from the ConnectionHeader into a Map before the buffer is released. This probably means we should remove getConnectionHeader from the RpcCall interface and instead add getConnectionAttributes." Region server getting crashed during write - A fatal error has been detected by the Java Runtime Environment,13549363,Resolved,Critical,Duplicate,01/Sep/23 07:01,27/Sep/24 02:59,2.4.14,"In our production environment, Region server JVM is getting crashed randomly with the following error logs. {code:java} Stack: [0x0000fffdd32d8000,0x0000fffdd34d8000],  sp=0x0000fffdd34d6000,  free space=2040k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) v  ~StubRoutines::jshort_disjoint_arraycopy J 98497 C2 org.apache.hadoop.hbase.io.ByteBufferListOutputStream.write(Ljava/nio/ByteBuffer;II)V (53 bytes) @ 0x0000ffff8cc9a154 [0x0000ffff8cc9a040+0x114] C  [ld-linux-aarch64.so.1+0x40018]  _rtld_global+0x0 [error occurred during error reporting (printing native stack), id 0xb] {code}   We are using HBase 2.4.14. " AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking,13545152,Resolved,Critical,Fixed,27/Jul/23 14:50,29/Mar/24 07:46,,"h2. What happened There is no value checking for parameter {{hbase.regionserver.logroll.multiplier}} when {{hbase.wal.provider}} is set to {{multiwal}}. This may cause improper calculations and crashes the system like division by 0. h2. Buggy code In {{AbstractFSWAL.java}}, there is no value checking for {{logRollSize and this variable is directly used while calculating the value of maxLogFiles in the method calculateMaxLogFiles}}. When logRollSize is mistakenly set to 0, the code would cause division by 0 and throw {{ArithmeticException}} to crash the system. {noformat}      private int calculateMaxLogFiles(Configuration conf, long logRollSize) {     Pair globalMemstoreSize = MemorySizeUtil.getGlobalMemStoreSize(conf);     return (int) ((globalMemstoreSize.getFirst() * 2) / logRollSize);   }{noformat} h2. How to reproduce (1) set hbase.regionserver.logroll.multiplier=0.0 and hbase.wal.provider=multiwal (2) run org.apache.hadoop.hbase.wal.TestWALMethods#testGetSplitEditFilesSorted you should observe the following failure: {noformat} java.lang.ArithmeticException: / by zero at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.calculateMaxLogFiles(AbstractFSWAL.java:466) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.(AbstractFSWAL.java:594) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.(AsyncFSWAL.java:141)        . . .{noformat} For an easy reproduction, run the reproduce.sh in the attachment. We are happy to provide a patch if this issue is confirmed." BucketCache causes ArithmeticException due to improper blockSize value checking ,13544681,Resolved,Critical,Fixed,24/Jul/23 16:43,29/Mar/24 07:45,,"h2. What happened There is no value checking for parameter {{{}hbase.blockcache.minblocksize{}}}. This may cause improper calculations and crashes the system like division by 0. h2. Buggy code In {{{}BucketCache.java{}}}, there is no value checking for {{blockSize}} and this variable is directly used to calculate the {{{}blockNumCapacity{}}}. When {{blockSize}} is mistakenly set to 0, the code would cause division by 0 and throw ArithmeticException to crash the system. {noformat}   public BucketCache(String ioEngineName, long capacity, int blockSize, int[] bucketSizes,     int writerThreadNum, int writerQLen, String persistencePath, int ioErrorsTolerationDuration,     Configuration conf) throws IOException {     ...     long blockNumCapacity = capacity / blockSize;     ...{noformat} h2. How to reproduce (1) set hbase.blockcache.minblocksize=0 (2) run org.apache.hadoop.hbase.io.hfile.TestCacheConfig#testBucketCacheConfigL1L2Setup you should observe the following failure: {noformat} java.lang.ArithmeticException: / by zero     at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.(BucketCache.java:282)     at org.apache.hadoop.hbase.io.hfile.BlockCacheFactory.createBucketCache(BlockCacheFactory.java:238)     at org.apache.hadoop.hbase.io.hfile.BlockCacheFactory.createBlockCache(BlockCacheFactory.java:110)     at org.apache.hadoop.hbase.io.hfile.TestCacheConfig.testBucketCacheConfigL1L2Setup(TestCacheConfig.java:325)         ...{noformat} For an easy reproduction, run the reproduce.sh in the attachment. We are happy to provide a patch if this issue is confirmed." ByteBuffAllocator causes ArithmeticException due to improper poolBufSize value checking,13544680,Resolved,Critical,Fixed,24/Jul/23 16:41,29/Mar/24 07:47,,"h3. What happened There is no value checking for parameter {{{}hbase.server.allocator.buffer.size{}}}. This may cause improper calculations and crashes the system like division by 0. h3. Buggy code In {{{}ByteBuffAllocator.java{}}}, there is no value checking for {{poolBufSize}} and this variable is directly used to calculate the {{{}bufsForTwoMB{}}}. When {{poolBufSize}} is mistakenly set to 0, the code would cause division by 0 and throw ArithmeticException to crash the system. {noformat} public static ByteBuffAllocator create(Configuration conf, boolean reservoirEnabled) {     int poolBufSize = conf.getInt(BUFFER_SIZE_KEY, DEFAULT_BUFFER_SIZE);     if (reservoirEnabled) {     . . .     int bufsForTwoMB = (2 * 1024 * 1024) / poolBufSize;     . . .{noformat} h3. How to reproduce # set hbase.server.allocator.buffer.size=0 run #  org.apache.hadoop.hbase.io.hfile.bucket.TestBucketCacheRefCnt#testInBucketCache # you should observe the following failure: {noformat} java.lang.ArithmeticException: / by zero     at org.apache.hadoop.hbase.io.ByteBuffAllocator.create(ByteBuffAllocator.java:174)     at org.apache.hadoop.hbase.io.hfile.bucket.TestBucketCacheRefCnt.testInBucketCache(TestBucketCacheRefCnt.java:224)     . . .{noformat} For an easy reproduction, run the reproduce.sh in the attachment. We are happy to provide a patch if this issue is confirmed." Adding debug message and assertion for failed BlockCache creation,13544249,Open,Critical,,20/Jul/23 08:07,,,"h2. What happened After setting {{{}hfile.block.cache.size=1.1175870895385742E-8{}}}, running test {{org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting#testLruBlockCache}} results in a {{{}NullPointerException{}}}. h2. Where's the bug In the test {{{}org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting#testLruBlockCache{}}}: {code:java}     BlockCache blockCache = BlockCacheFactory.createBlockCache(this.conf);     logPerBlock(blockCache);     addDataAndHits(blockCache, 3); {code} Here the returned blockCache could be null, but is directly used as the parameter of {{logPerBlock}} without checking. h2. How to reproduce # Set {{hfile.block.cache.size=1.1175870895385742E-8}} # Run {{org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting#testLruBlockCache}} and the following exception should be observed: {code:java} java.lang.NullPointerException at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.logPerBlock(TestBlockCacheReporting.java:147) at org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting.testLruBlockCache(TestBlockCacheReporting.java:100) {code} {{}}" Missing null check in TestHFile,13545161,Open,Critical,,27/Jul/23 15:22,,,"h2. What happened After setting {{{}hbase.lru.blockcache.hard.capacity.limit.factor=-0.4921875{}}}, running test {{{}org.apache.hadoop.hbase.io.hfile.TestHFile#testReaderWithAdaptiveLruCombinedBlockCache{}}}results in a null pointer exception. h2. Where's the problem In the test: {noformat}       cachedBlock = combined.getBlock(key, false, false, true);       try { ...       } finally {         cachedBlock.release();       }{noformat} However, cacheBlock might not be initialized properly and could be null, causing an unhandled NullPointerException. h2. How to reproduce # set {{hbase.lru.blockcache.hard.capacity.limit.factor}} to {{-0.4921875 }} # run {{org.apache.hadoop.hbase.io.hfile.TestHFile#testReaderWithAdaptiveLruCombinedBlockCache}} you should observe {noformat} java.lang.NullPointerException     at org.apache.hadoop.hbase.io.hfile.TestHFile.testReaderCombinedCache(TestHFile.java:1052)     at org.apache.hadoop.hbase.io.hfile.TestHFile.testReaderWithAdaptiveLruCombinedBlockCache(TestHFile.java:1011){noformat} For an easy reproduction, run the reproduce.sh in the attachment. We are happy to provide a patch if this issue is confirmed." Should check the return value of protobuf Message.mergeDelimitedFrom,13551347,Resolved,Critical,Fixed,20/Sep/23 07:04,24/Sep/23 08:20,,"Found this problem while upgrading thirdparty dependencies. The javadoc of mergeDelimitedFrom says {code} /** * Like {@link #mergeFrom(InputStream)}, but does not read until EOF. Instead, the size of the * message (encoded as a varint) is read first, then the message data. Use {@link * MessageLite#writeDelimitedTo(OutputStream)} to write messages in this format. * * @return true if successful, or false if the stream is at EOF when the method starts. Any * other error (including reaching EOF during parsing) causes an exception to be thrown. * @throws InvalidProtocolBufferException the bytes read are not syntactically correct * according to the protobuf wire format specification. The data is corrupt, incomplete, * or was never a protobuf in the first place. * @throws IOException an I/O error reading from the stream */ {code} So we should not ignore the return value, otherwise we may get an incomplete message." org.apache.hadoop.hbase.TestHBaseTestingUtility failed when setting call queue read ratio to a large value,13544247,Open,Critical,,20/Jul/23 08:00,,,"h2. What happened {{org.apache.hadoop.hbase.TestHBaseTestingUtility#testMiniZooKeeperWithMultipleServers}} failed when trying to run with {{hbase.ipc.server.callqueue.read.ratio=1782718229}} h2. How to reproduce # set {{hbase.ipc.server.callqueue.read.ratio=1782718229}} # run {{org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler#testCallQueueInfo}} you should observe the following failure: {code:java} java.lang.AssertionError: expected:<10> but was:<9> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:647) at org.junit.Assert.assertEquals(Assert.java:633) at org.apache.hadoop.hbase.ipc.TestSimpleRpcScheduler.testCallQueueInfo(TestSimpleRpcScheduler.java:176) {code}" HCommon get local file system fails with a casting error,13544256,Resolved,Critical,Duplicate,20/Jul/23 08:49,14/Sep/23 18:39,,"h2. What happened After setting {{{}fs.file.impl=org.apache.hadoop.fs.RawLocalFileSystem{}}}, trying to acquire local file system using the {{getLocal}} in {{org.apache.hadoop.fs}} fails with {{java.lang.ClassCastException}} h2. Where's the bug In the function {{getLocal}} of {{FileSystem}} in HCommon: {code:java}   public static LocalFileSystem getLocal(Configuration conf)     throws IOException {     return (LocalFileSystem)get(LocalFileSystem.NAME, conf);   } {code} the returned file system is directly casted to LocalFileSystem without checking. If the user set the implementation of the local filesystem to be Raw rather than Checksum, this type cast would fail. h2. How to reproduce # Set {{fs.file.impl=org.apache.hadoop.fs.RawLocalFileSystem}} # Run {{org.apache.hadoop.hbase.TestHBaseTestingUtility#testMiniDFSCluster}} and the following exception should be observed: {code:java} java.lang.ClassCastException: class org.apache.hadoop.fs.RawLocalFileSystem cannot be cast to class org.apache.hadoop.fs.LocalFileSystem (org.apache.hadoop.fs.RawLocalFileSystem and org.apache.hadoop.fs.LocalFileSystem are in unnamed module of loader 'app') at org.apache.hadoop.fs.FileSystem.getLocal(FileSystem.java:441) at org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:550) at org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:536) at org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:510) at org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:524) at org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:737) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:682) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:665) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:653) at org.apache.hadoop.hbase.TestHBaseTestingUtility.testMiniDFSCluster(TestHBaseTestingUtility.java:377) {code}" Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec ,13545153,Resolved,Critical,Incomplete,27/Jul/23 14:54,27/Jul/23 15:01,,"When {{hbase.client.default.rpc.codec}} is set to {{org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec}} the method {{createRpcClientRTEDuringConnectionSetup}} gives a NoSuchMethodException for the provided default codec value. Since there was an exception, the code inside try block is not executed which contained the below code line {noformat} try (AbstractRpcClient client = createRpcClientRTEDuringConnectionSetup(clientConf)) {       rpcServer.start();       . . .     }{noformat} When finally block is executed which contains {noformat} finally {       rpcServer.stop();     }{noformat} The method {{rpcServer.stop()}} eventually makes call to {{{}executor.shutdown(){}}}. A null pointer exception is returned as {{rpcServer.scheduler.executor}} was never instantiated, which happens inside {{rpcServer.start()}} {noformat} java.lang.NullPointerException     at org.apache.hadoop.hbase.ipc.FifoRpcScheduler.stop(FifoRpcScheduler.java:71)     at org.apache.hadoop.hbase.ipc.SimpleRpcServer.stop(SimpleRpcServer.java:441)     at org.apache.hadoop.hbase.ipc.AbstractTestIPC.testRTEDuringConnectionSetup(AbstractTestIPC.java:194)     . . .{noformat}" "ITBLL's RollingBatchSuspendResumeRsAction runs the ""suspendRs"" method to perform the action, but it inadvertently uses the ""waitForRegionServerToStop"" method to check if it was executed successfully.",13547183,Resolved,Major,Fixed,14/Aug/23 06:14,13/Jan/25 13:58,2.7.0,"When running ITBLL, a problem occurs that ultimately results in all region servers being suspended. The following is the ITBLL running command： {code:java} hbase org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList -DIntegrationTestBigLinkedList.table=itbll -m slowDeterministic Loop 10 10 10000000 /tmp/biglinkedlist 100 {code} I have summarized the process as follows: # The Action RollingBatchSuspendResumeRsAction in ITBLL will execute the ""sudo -u hbase ps ux | grep proc_regionserver | grep -v grep | tr -s ' ' | cut -d ' ' -f2 | xargs kill -s SIGSTOP"" command to suspend the RegionServer process. # This command will pause the RegionServer process, rather than kill it. # The Action uses the waitForServiceToStop method to check if the execution was successful, using the ""sudo -u hbase ps ux | grep proc_regionserver | grep -v grep | tr -s ' ' | cut -d ' ' -f2"" command. # The waitForServiceToStop method used to check if the execution was successful does not match the suspendRs, causing ITBLL to not resume the RegionServer process and ultimately resulting in all RegionServer processes being suspended. Therefore, ITBLL fails to run. {code:java} 2023-07-21 11:18:23,103 WARN  [ChaosMonkey-2] policies.Policy (DoActionsOncePolicy.java:runOneIteration(51)) - Exception occurred during performing action: java.io.IOException: Timed-out waiting for service to stop: core-1-3,16020,1689908619650         at org.apache.hadoop.hbase.DistributedHBaseCluster.waitForServiceToStop(DistributedHBaseCluster.java:282)         at org.apache.hadoop.hbase.DistributedHBaseCluster.waitForRegionServerToStop(DistributedHBaseCluster.java:131)         at org.apache.hadoop.hbase.chaos.actions.Action.suspendRs(Action.java:200)         at org.apache.hadoop.hbase.chaos.actions.RollingBatchSuspendResumeRsAction.perform(RollingBatchSuspendResumeRsAction.java:97)         at org.apache.hadoop.hbase.chaos.policies.DoActionsOncePolicy.runOneIteration(DoActionsOncePolicy.java:48)         at org.apache.hadoop.hbase.chaos.policies.PeriodicPolicy.run(PeriodicPolicy.java:41)         at org.apache.hadoop.hbase.chaos.policies.CompositeSequentialPolicy.run(CompositeSequentialPolicy.java:42)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:750) {code}" RSProcedureDispatcher to abort executing request after configurable retries,13548911,Resolved,Major,Resolved,29/Aug/23 03:26,13/Feb/25 23:41,2.4.17,"In a recent incident, we observed that RSProcedureDispatcher continues executing region open/close procedures with unbounded retries even in the presence of known failures like GSS initiate failure:   {code:java} 2023-08-25 02:21:02,821 WARN [ispatcher-pool-40777] procedure.RSProcedureDispatcher - request to rs1,61020,1692930044498 failed due to java.io.IOException: Call to address=rs1:61020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(javax.security.sasl.SaslException): GSS initiate failed, try=0, retrying... {code}     If the remote execution results in IOException, the dispatcher attempts to schedule the procedure for further retries:   {code:java}     private boolean scheduleForRetry(IOException e) {       LOG.debug(""Request to {} failed, try={}"", serverName, numberOfAttemptsSoFar, e);       // Should we wait a little before retrying? If the server is starting it's yes.       ...       ...       ...       numberOfAttemptsSoFar++;       // Add some backoff here as the attempts rise otherwise if a stuck condition, will fill logs       // with failed attempts. None of our backoff classes -- RetryCounter or ClientBackoffPolicy       // -- fit here nicely so just do something simple; increment by rsRpcRetryInterval millis *       // retry^2 on each try       // up to max of 10 seconds (don't want to back off too much in case of situation change).       submitTask(this,         Math.min(rsRpcRetryInterval * (this.numberOfAttemptsSoFar * this.numberOfAttemptsSoFar),           10 * 1000),         TimeUnit.MILLISECONDS);       return true;     } {code}     Even though we try to provide backoff while retrying, max wait time is 10s:   {code:java} submitTask(this, Math.min(rsRpcRetryInterval * (this.numberOfAttemptsSoFar * this.numberOfAttemptsSoFar), 10 * 1000), TimeUnit.MILLISECONDS); {code}     This results in endless loop of retries, until either the underlying issue is fixed (e.g. krb issue in this case) or regionserver is killed and the ongoing open/close region procedure (and perhaps entire SCP) for the affected regionserver is sidelined manually. {code:java} 2023-08-25 03:04:18,918 WARN  [ispatcher-pool-41274] procedure.RSProcedureDispatcher - request to rs1,61020,1692930044498 failed due to java.io.IOException: Call to address=rs1:61020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(javax.security.sasl.SaslException): GSS initiate failed, try=217, retrying... 2023-08-25 03:04:18,916 WARN  [ispatcher-pool-41280] procedure.RSProcedureDispatcher - request to rs1,61020,1692930044498 failed due to java.io.IOException: Call to address=rs1:61020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(javax.security.sasl.SaslException): GSS initiate failed, try=193, retrying... 2023-08-25 03:04:28,968 WARN  [ispatcher-pool-41315] procedure.RSProcedureDispatcher - request to rs1,61020,1692930044498 failed due to java.io.IOException: Call to address=rs1:61020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(javax.security.sasl.SaslException): GSS initiate failed, try=266, retrying... 2023-08-25 03:04:28,969 WARN  [ispatcher-pool-41240] procedure.RSProcedureDispatcher - request to rs1,61020,1692930044498 failed due to java.io.IOException: Call to address=rs1:61020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(javax.security.sasl.SaslException): GSS initiate failed, try=266, retrying...{code}   While external issues like ""krb ticket expiry"" requires operator intervention, it is not prudent to fill up the active handlers with endless retries while attempting to execute RPC on only single affected regionserver. This eventually leads to overall cluster state degradation, specifically in the event of multiple regionserver restarts resulting from any planned activities. One of the resolutions here would be: # Configure max retries as part of ExecuteProceduresRequest request (or it could be part of RemoteProcedureRequest) # This retry count should be used by RSProcedureDispatcher while scheduling request failures for further retries # After exhausting retries, mark the failure to the remote call, and bubble up the failure to parent procedure. If the series of above mentioned calls result into aborting active master, we should clearly log the FATAL/ERROR msg with the underlying root cause (e.g. GSS initiate failure in this case), which can help operator to either fix the krb ticket expiry or abort the regionserver, which would lead to SCP performing the heavy task of WAL splitting recoveries, however this would not prevent other procedures as well as active handlers from getting stuck executing remote calls without any conditional termination." Reduce frequency of saving backing map in persistence cache,13548541,Resolved,Major,Abandoned,24/Aug/23 16:55,27/Jan/25 11:34,,"Currently we always write the whole cache mapping into the persistent map file. This is not a lightweight operation, on a full 1.6TB cache with ten millions of block, this can grow as much as 10GB. In the current persistent cache implementation, we flush it to disk every 1s. If we raise the ""checkpoint"" period, we risk lose more cache events in the event of a recovery. This proposes reduce the frequency needed to save the backing map as follows: 1) Save every block addition/eviction into a single file in disk; 2) Checkpoint at higher intervals, consolidating all transactions into the larger map file; 3) In the event of failure, recovery would consist of loading the latest map file, then applying all the transactions files sequentially;" Deadlock when opening mob files,13548768,Reopened,Major,,28/Aug/23 04:28,,2.5.5,"The hashcode of mob file name is used in MobFileCache to lock the cached mob files, but hashcode may be repeated and the IdLock is not reentrant. Then when opening a not cached file with evicting the opened by LRU, the repeated hashcode files will bring deadlock. [^mobdeadlock.js]" Add documentation to HBase book,13549665,Resolved,Major,Fixed,05/Sep/23 12:46,06/Sep/23 10:53,, Bump cryptography from 41.0.0 to 41.0.3 in /dev-support/git-jira-release-audit,13547155,Resolved,Major,Fixed,14/Aug/23 03:12,14/Aug/23 03:15,, Bump certifi from 2022.12.07 to 2023.7.22 in /dev-support/git-jira-release-audit,13547154,Resolved,Major,Fixed,14/Aug/23 03:12,14/Aug/23 03:14,, Replace javax.servlet.jsp dependency with tomcat-jasper,13550298,Resolved,Major,Fixed,12/Sep/23 02:40,07/Nov/24 11:43,,"*Problem Statement* HBase has to explicitly depends on org.glassfish:javax.el:jar:3.0.1-b08 as this dependency is needed by javax.servlet.jsp. This direct dependency was added due to https://issues.apache.org/jira/browse/HBASE-18831 mvn dependency tree shows below {code:java} [INFO] | +- org.glassfish.web:javax.servlet.jsp:jar:2.3.2:compile [INFO] | | \- org.glassfish:javax.el:jar:3.0.1-b08:compile {code} org.glassfish:javax.el:jar:3.0.1-b08:compile has [https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250] We have ton of Jiras and HBase around glass fish and issues caused due to it. With this Jira I plan to completely remove org.glassfish:javax.el:jar:3.0.1-b08 from our dependency tree. Also org.glassfish:javax.el is EOL and needs migration to jakarta-el which is not trivial. See [https://mvnrepository.com/artifact/org.glassfish/javax.el] *Proposed Solution* This Jira aims to replace javax.servlet.jsp dependency with tomcat-jasper (as javax.servlet.jsp strictly needs glassfish) and this requires minimal change wrt to migrating to jakarta-el. Also, we use javax.servlet.jsp to generate/build JSP and same can be achieved via tomcat-jasper. CC: [~zhangduo]   " NullPointerException authorizing connection on regionserver startup,13550893,Open,Major,,15/Sep/23 21:10,,,"When a RegionServer starts up, the HRegionServer constructor calls createRpcServices() which creates RSRpcServices, which uses RpcServerFactory to create a NettyRpcServer. The NettyRpcServer constructor binds the process to the given regionserver port. At this point it is able to accept requests. Later in the HRegionServer constructor, it calls rpcServices.start(zooKeeper). This calls NettyRpcServer.start(), which initializes the AuthManager. Since there is a period of time where the server can accept requests but AuthManager is not initialized, if you have authentication enabled you will receive NullPointerExceptions (see below). These will clear up once the server starts. We should fix the flow here to avoid these errors. {code:java} 2023-09-15T20:47:35,300 [RS-EventLoopGroup-1-3] WARN org.apache.hadoop.hbase.ipc.NettyRpcServer: Connection xxx.xxx.xxx.xxx:49402; caught unexpected downstream exception. java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.security.authorize.ServiceAuthorizationManager.authorize(org.apache.hadoop.security.UserGroupInformation, java.lang.Class, org.apache.hadoop.conf.Configuration, java.net.InetAddress)"" because ""this.authManager"" is null         at org.apache.hadoop.hbase.ipc.RpcServer.authorize(RpcServer.java:654) ~[hbase-server-2.5-hubspot-20230913.131903-57.jar:2.5-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.ServerRpcConnection.authorizeConnection(ServerRpcConnection.java:381) ~[hbase-server-2.5-hubspot-20230913.131903-57.jar:2.5-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processOneRpc(ServerRpcConnection.java:362) ~[hbase-server-2.5-hubspot-20230913.131903-57.jar:2.5-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:89) ~[hbase-server-2.5-hubspot-20230913.131903-57.jar:2.5-hubspot-SNAPSHOT] {code}" Add request attribute support to BufferedMutator,13545344,Resolved,Major,Fixed,28/Jul/23 19:13,08/Oct/24 12:23,,In https://issues.apache.org/jira/browse/HBASE-27657 we added support for specifying connection and request attributes. One oversight was including support for doing so via the BufferedMutator class. We should add such support in a follow up PR. [hbase-thirdparty] Bump hbase.stable.version to 2.4.17 in hbase-noop-htrace,13551422,Resolved,Major,Fixed,20/Sep/23 14:56,21/Sep/23 14:48,, Incremental backups should be forbidden after deleting backups,13550679,Open,Major,,14/Sep/23 11:34,,,"Imagine I have a set of backups (Full1, Incr2, Incr3), delete the last backup (Incr3), and then create a new incremental backup (Incr4). This backup history will now show: Full1, Incr2, Incr4. However, restoring Incr4 will not contain the data that was captured in Incr3, effectively leading to data loss. This will certainly surprise some users. I suggest to add some internal bookkeeping to prevent incremental backups in case the most recent backup was deleted." The RSGroupAdminEndpoint is causing the hbase:meta region to be unable to come online.,13544204,Open,Major,,20/Jul/23 02:48,,2.1.1,"When I use RSGroupAdminEndpoint and restart both master before restarting the regionserver, I encounter a syscall:getsockopt(..) issue that prevents the hbase:meta region from coming online, resulting in a service exception. {code:java} 2023-07-10 16:32:22,282 INFO  [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-ysl104-qax.com,16000,1688977910162] rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread: Updating default servers. 2023-07-10 16:32:22,299 INFO  [PEWorker-8] procedure.ServerCrashProcedure: Start pid=2, state=RUNNABLE:SERVER_CRASH_START, locked=true; ServerCrashProcedure server=ysl102-qax.com,16020,1688977249460, splitWal=true, meta=false 2023-07-10 16:32:22,400 INFO  [PEWorker-10] master.SplitLogManager: hdfs://HACluster/home/hbase/WALs/ysl102-qax.com,16020,1688977249460-splitting dir is empty, no logs to split. 2023-07-10 16:32:22,411 INFO  [PEWorker-10] master.SplitLogManager: Finished splitting (more than or equal to) 0 bytes in 0 log files in [hdfs://HACluster/home/hbase/WALs/ysl102-qax.com,16020,1688977249460-splitting] in 0ms 2023-07-10 16:32:22,521 INFO  [PEWorker-10] procedure2.ProcedureExecutor: Finished pid=2, state=SUCCESS; ServerCrashProcedure server=ysl102-qax.com,16020,1688977249460, splitWal=true, meta=false in 326msec 2023-07-10 16:32:22,941 INFO  [RegionServerTracker-0] master.RegionServerTracker: RegionServer ephemeral node deleted, processing expiration [ysl104-qax.com,16020,1688977251592] 2023-07-10 16:32:22,941 INFO  [RegionServerTracker-0] master.ServerManager: Processing expiration of ysl104-qax.com,16020,1688977251592 on ysl104-qax.com,16000,1688977910162 2023-07-10 16:32:23,069 INFO  [PEWorker-12] procedure.ServerCrashProcedure: Start pid=3, state=RUNNABLE:SERVER_CRASH_START, locked=true; ServerCrashProcedure server=ysl104-qax.com,16020,1688977251592, splitWal=true, meta=true 2023-07-10 16:32:23,126 INFO  [PEWorker-12] master.SplitLogManager: hdfs://HACluster/home/hbase/WALs/ysl104-qax.com,16020,1688977251592-splitting dir is empty, no logs to split. 2023-07-10 16:32:23,135 INFO  [PEWorker-12] master.SplitLogManager: Finished splitting (more than or equal to) 0 bytes in 0 log files in [hdfs://HACluster/home/hbase/WALs/ysl104-qax.com,16020,1688977251592-splitting] in 0ms 2023-07-10 16:32:23,174 INFO  [PEWorker-12] procedure2.ProcedureExecutor: Initialized subprocedures=[{pid=4, ppid=3, state=RUNNABLE:REGION_TRANSITION_QUEUE; AssignProcedure table=hbase:meta, region=1588230740}] 2023-07-10 16:32:23,206 INFO  [PEWorker-15] procedure.MasterProcedureScheduler: Took xlock for pid=4, ppid=3, state=RUNNABLE:REGION_TRANSITION_QUEUE; AssignProcedure table=hbase:meta, region=1588230740 2023-07-10 16:32:23,325 INFO  [PEWorker-15] assignment.AssignProcedure: Starting pid=4, ppid=3, state=RUNNABLE:REGION_TRANSITION_QUEUE, locked=true; AssignProcedure table=hbase:meta, region=1588230740; rit=OFFLINE, location=ysl104-qax.com,16020,1688977251592; forceNewPlan=false, retain=true 2023-07-10 16:32:23,476 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:24,477 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:25,478 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:26,479 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:26,665 INFO  [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-ysl104-qax.com,16000,1688977910162] client.RpcRetryingCallerImpl: Call exception, tries=6, retries=46, started=4175 ms ago, cancelled=false, msg=Call to YSL104-QAX.COM/10.59.12.104:16020 failed on connection exception: org.apache.hbase.thirdparty.io.netty.channel.AbstractChannel$AnnotatedConnectException: syscall:getsockopt(..) failed: Connection refused: YSL104-QAX.COM/xx.xx.xx.104:16020, details=row 'hbase:rsgroup' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=ysl104-qax.com,16020,1688977251592, seqNum=-1 2023-07-10 16:32:27,480 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:28,481 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:29,482 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:30,483 WARN  [master/YSL104-QAX:16000] assignment.AssignmentManager: No servers available; cannot place 1 unassigned regions. 2023-07-10 16:32:30,899 INFO  [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-ysl104-qax.com,16000,1688977910162] client.RpcRetryingCallerImpl: Call exception, tries=7, retries=46, started=8409 ms ago, cancelled=false, msg=Connection closed, details=row 'hbase:rsgroup' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=ysl104-qax.com,16020,1688977251592, seqNum=-1 2023-07-10 16:32:31,025 INFO  [RpcServer.default.FPBQ.Fifo.handler=198,queue=18,port=16000] master.ServerManager: Registering regionserver=ysl103-qax.com,16020,1688977946684 2023-07-10 16:32:31,064 INFO  [RegionServerTracker-0] master.RegionServerTracker: RegionServer ephemeral node created, adding [ysl103-qax.com,16020,1688977946684] 2023-07-10 16:32:31,439 INFO  [RpcServer.default.FPBQ.Fifo.handler=198,queue=18,port=16000] master.ServerManager: Registering regionserver=ysl102-qax.com,16020,1688977947399 2023-07-10 16:32:31,467 INFO  [RegionServerTracker-0] master.RegionServerTracker: RegionServer ephemeral node created, adding [ysl102-qax.com,16020,1688977947399] 2023-07-10 16:32:32,934 INFO  [RpcServer.default.FPBQ.Fifo.handler=198,queue=18,port=16000] master.ServerManager: Registering regionserver=ysl104-qax.com,16020,1688977948804 2023-07-10 16:32:32,965 INFO  [RegionServerTracker-0] master.RegionServerTracker: RegionServer ephemeral node created, adding [ysl104-qax.com,16020,1688977948804] 2023-07-10 16:32:41,041 INFO  [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-ysl104-qax.com,16000,1688977910162] client.RpcRetryingCallerImpl: ption: hbase:meta,,1 is not online on ysl104-qax.com,16020,1688977948804     at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3316)     at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3293)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1431)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2449)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) , details=row 'hbase:rsgroup' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=ysl104-qax.com,16020,1688977251592, seqNum=-1 2023-07-10 16:32:51,123 INFO  [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-ysl104-qax.com,16000,1688977910162] client.RpcRetryingCallerImpl: ption: hbase:meta,,1 is not online on ysl104-qax.com,16020,1688977948804     at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3316)     at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3293)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1431)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2449)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) , details=row 'hbase:rsgroup' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=ysl104-qax.com,16020,1688977251592, seqNum=-1 2023-07-10 16:33:01,212 INFO  [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-ysl104-qax.com,16000,1688977910162] client.RpcRetryingCallerImpl: ption: hbase:meta,,1 is not online on ysl104-qax.com,16020,1688977948804     at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3316)     at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3293)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1431)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2449)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) , details=row 'hbase:rsgroup' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=ysl104-qax.com,16020,1688977251592, seqNum=-1 {code}" rpc read handler can get stuck on LruBlockCache#getBlock,13546781,Open,Major,,10/Aug/23 07:42,,3.0.0-alpha-4,"In our production, we found lots of read handlers got stuck on LruBlockCache#getBlock. This may be caused by a bug in jdk8 ConcurrentHashMap. To make common fast, I think we'd better get and check it before call ConcurrentHashMap#computeIfPresent.     ""RpcServer.priority.RWQ.Fifo.scan.handler=190,queue=57,port=60020"" #1807 daemon prio=5 os_prio=0 cpu=9703.28ms elapsed=88160.93s tid=0x00007f38d338a800 nid=0x8f4 waiting for monitor entry [0x00007f0af4baa000]    java.lang.Thread.State: BLOCKED (on object monitor)         at java.util.concurrent.ConcurrentHashMap.computeIfPresent(ConcurrentHashMap.java:1760)         - waiting to lock <0x00007f2fc6495fe0> (a java.util.concurrent.ConcurrentHashMap$Node)         at org.apache.hadoop.hbase.io.hfile.LruBlockCache.getBlock(LruBlockCache.java:538)         at org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.getBlock(CombinedBlockCache.java:88)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.getCachedBlock(HFileReaderImpl.java:1124)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1300)         at org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$CellBasedKeyBlockIndexReader.loadDataBlockWithScanInfo(HFileBlockIndex.java:331)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:679)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:631)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.java:315)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:216)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.backwardSeek(StoreFileScanner.java:561)         at org.apache.hadoop.hbase.regionserver.ReversedKeyValueHeap.backwardSeek(ReversedKeyValueHeap.java:117)         at org.apache.hadoop.hbase.regionserver.ReversedStoreScanner.backwardSeek(ReversedStoreScanner.java:134)         at org.apache.hadoop.hbase.regionserver.ReversedStoreScanner.seekAsDirection(ReversedStoreScanner.java:94)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(StoreScanner.java:821)         at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:727)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:155)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:7515)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:7683)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:7447)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3403)         - locked <0x00007f2ff1fc8f40> (a org.apache.hadoop.hbase.regionserver.ReversedRegionScannerImpl)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3662)         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45253)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:447)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:136)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)    Locked ownable synchronizers:         - None" Missing fields in Scan.toJSON,13552493,Resolved,Major,Fixed,29/Sep/23 20:54,19/Mar/24 14:35,,Let's do an audit and add whatever's missing. I noticed getLimit is missing at least. oldWALs naming can be incompatible with HBase backup,13550561,Resolved,Major,Fixed,13/Sep/23 16:19,07/Oct/23 01:40,,"I am testing HBase backup functionality, and noticed following warning when running ""hbase backup create incremental ..."":   {noformat} 23/09/13 15:44:10 WARN org.apache.hadoop.hbase.backup.util.BackupUtils: Skip log file (can't parse): hdfs://hdfsns/hbase/hbase/oldWALs/hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.regiongroup-0.1694609969312{noformat} It appears in my setup, the oldWALs are indeed given names that seem to break ""ServerName.valueOf(s)"" in ""BackupUtils#parseHostFromOldLog(Path p)"":     {noformat} user@hadoop-client-769bc9946-xqrt2:/$ hdfs dfs -ls hdfs:///hbase/hbase/oldWALs Found 42 items -rw-r--r--   1 hbase hbase     775421 2023-09-13 13:14 hdfs:///hbase/hbase/oldWALs/hbase-master-0.minikube-shared%2C16000%2C1694609954719.hbase-master-0.minikube-shared%2C16000%2C1694609954719.regiongroup-0.1694609957984$masterlocalwal$ -rw-r--r--   1 hbase hbase      26059 2023-09-13 13:29 hdfs:///hbase/hbase/oldWALs/hbase-master-0.minikube-shared%2C16000%2C1694609954719.hbase-master-0.minikube-shared%2C16000%2C1694609954719.regiongroup-0.1694610867894$masterlocalwal$ ... -rw-r--r--   1 hbase hbase     242479 2023-09-13 14:16 hdfs:///hbase/hbase/oldWALs/hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.regiongroup-0.1694609969312 -rw-r--r--   1 hbase hbase       4364 2023-09-13 14:16 hdfs:///hbase/hbase/oldWALs/hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.regiongroup-0.1694610188654 ... -rw-r--r--   1 hbase hbase      70802 2023-09-13 13:15 hdfs:///hbase/hbase/oldWALs/hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.meta.1694609970025.meta -rw-r--r--   1 hbase hbase         93 2023-09-13 13:04 hdfs:///hbase/hbase/oldWALs/hbase-region-0.hbase-region.minikube-shared.svc.cluster.local%2C16020%2C1694609964681.meta.1694610188627.meta ...{noformat} I'd say this is not a bug in the backup system, but rather in whatever gives the oldWAL files its name. I'm however not that familiar with HBase code to find where these files are created. Any pointers are appreciated. Given that this causes some logs to be missed during backup, I guess this can lead to data loss in a backup restore?  " Read all compressed bytes to a byte array before submitting them to decompressor,13547686,Resolved,Major,Fixed,17/Aug/23 08:20,27/Aug/23 07:07,, RSProcedureDispatcher to fail-fast for krb auth failures,13549029,Resolved,Major,Fixed,29/Aug/23 17:18,29/Sep/23 05:20,,"As discussed on the parent Jira, let's mark the remote procedures fail when we encounter SaslException (GSS initiate failed) as this belongs to the category of known IOException where we are certain that the request has not yet reached to the target regionserver yet. This should help release dispatcher threads for other ExecuteProceduresRemoteCall executions.   Example log: {code:java} 2023-08-25 02:21:02,821 WARN [ispatcher-pool-40777] procedure.RSProcedureDispatcher - request to rs1,61020,1692930044498 failed due to java.io.IOException: Call to address=rs1:61020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(javax.security.sasl.SaslException): GSS initiate failed, try=0, retrying... {code}" Bump gitpython from 3.1.30 to 3.1.32 in /dev-support/git-jira-release-audit,13547152,Resolved,Major,Fixed,14/Aug/23 02:49,14/Aug/23 03:11,, Implement cache aware load balancer,13545313,Resolved,Major,Fixed,28/Jul/23 14:21,16/Oct/23 11:56,,"HBase uses ephemeral cache to cache the blocks by reading them from the slow storages and storing them to the bucket cache. This cache is warmed up everytime a region server is started. Depending on the data size and the configured cache size, the cache warm up can take anywhere between a few minutes to few hours. Doing this everytime the region server starts can be a very expensive process. To eliminate this, HBASE-27313 implemented the cache persistence feature where the region servers periodically persist the blocks cached in the bucket cache. This persisted information is then used to resurrect the cache in the event of a region server restart because of normal restart or crash. This feature aims at enhancing this capability of HBase to enable the balancer implementation considers the cache allocation of each region on region servers when calculating a new assignment plan and uses the region/region server cache allocation info reported by region servers which takes into account to calculate the percentage of HFiles cached for each region on the hosting server, and then use that as another factor when deciding on an optimal, new assignment plan.   A design document describing the balancer can be found at https://docs.google.com/document/d/1A8-eVeRhZjwL0hzFw9wmXl8cGP4BFomSlohX2QcaFg4/edit?usp=sharing" Enhance region metrics to include prefetch ratio for each region,13545311,Resolved,Major,Fixed,28/Jul/23 14:20,26/Dec/23 10:02,, Enhance prefetch executor to record region prefetch information along with the list of hfiles prefetched,13545278,Resolved,Major,Fixed,28/Jul/23 11:03,26/Dec/23 10:02,2.6.0,"HBASE-27313 implemented the prefetch persistence feature where it persists the list of hFiles prefetched in the bucket cache. This information is used to reconstruct the cache in the event of a server restart/crash. Currently, only the list of hFiles is persisted. However, for the new PrefetchAwareLoadBalancer (work in progress) to work, we need the information about how much a region is prefetched on a region server. This Jira introduces an additional map in the prefetch executor to maintain the information about how much a region has been prefetched on that region server. The size of region server prefetched is calculated as the total size of all hFiles prefetched for that region." HBase Master/RS JVM metrics populated incorrectly,13542821,Resolved,Major,Fixed,07/Jul/23 15:14,23/Jan/24 16:51,2.0.0-alpha-4,"HBase Master/RS JVM metrics populated incorrectly due to regression causing ambari metrics system to not able to capture them. Based on my analysis the issue is relevant for all release post 2.0.0-alpha-4 and seems to be caused due to HBASE-18846. Have been able to compare the JVM metrics across 3 versions of HBase and attaching results of same below: HBase: 1.1.2 {code:java} { ""name"" : ""Hadoop:service=HBase,name=JvmMetrics"", ""modelerType"" : ""JvmMetrics"", ""tag.Context"" : ""jvm"", ""tag.ProcessName"" : ""RegionServer"", ""tag.SessionId"" : """", ""tag.Hostname"" : ""HOSTNAME"", ""MemNonHeapUsedM"" : 196.05664, ""MemNonHeapCommittedM"" : 347.60547, ""MemNonHeapMaxM"" : 4336.0, ""MemHeapUsedM"" : 7207.315, ""MemHeapCommittedM"" : 66080.0, ""MemHeapMaxM"" : 66080.0, ""MemMaxM"" : 66080.0, ""GcCount"" : 3953, ""GcTimeMillis"" : 662520, ""ThreadsNew"" : 0, ""ThreadsRunnable"" : 214, ""ThreadsBlocked"" : 0, ""ThreadsWaiting"" : 626, ""ThreadsTimedWaiting"" : 78, ""ThreadsTerminated"" : 0, ""LogFatal"" : 0, ""LogError"" : 0, ""LogWarn"" : 0, ""LogInfo"" : 0 }, {code} HBase 2.0.2 {code:java} { ""name"" : ""Hadoop:service=HBase,name=JvmMetrics"", ""modelerType"" : ""JvmMetrics"", ""tag.Context"" : ""jvm"", ""tag.ProcessName"" : ""IO"", ""tag.SessionId"" : """", ""tag.Hostname"" : ""HOSTNAME"", ""MemNonHeapUsedM"" : 203.86688, ""MemNonHeapCommittedM"" : 740.6953, ""MemNonHeapMaxM"" : -1.0, ""MemHeapUsedM"" : 14879.477, ""MemHeapCommittedM"" : 31744.0, ""MemHeapMaxM"" : 31744.0, ""MemMaxM"" : 31744.0, ""GcCount"" : 75922, ""GcTimeMillis"" : 5134691, ""ThreadsNew"" : 0, ""ThreadsRunnable"" : 90, ""ThreadsBlocked"" : 3, ""ThreadsWaiting"" : 158, ""ThreadsTimedWaiting"" : 36, ""ThreadsTerminated"" : 0, ""LogFatal"" : 0, ""LogError"" : 0, ""LogWarn"" : 0, ""LogInfo"" : 0 }, {code} HBase: 2.5.2 {code:java} { ""name"": ""Hadoop:service=HBase,name=JvmMetrics"", ""modelerType"": ""JvmMetrics"", ""tag.Context"": ""jvm"", ""tag.ProcessName"": ""IO"", ""tag.SessionId"": """", ""tag.Hostname"": ""HOSTNAME"", ""MemNonHeapUsedM"": 192.9798, ""MemNonHeapCommittedM"": 198.4375, ""MemNonHeapMaxM"": -1.0, ""MemHeapUsedM"": 773.23584, ""MemHeapCommittedM"": 1004.0, ""MemHeapMaxM"": 1024.0, ""MemMaxM"": 1024.0, ""GcCount"": 2048, ""GcTimeMillis"": 25440, ""ThreadsNew"": 0, ""ThreadsRunnable"": 22, ""ThreadsBlocked"": 0, ""ThreadsWaiting"": 121, ""ThreadsTimedWaiting"": 49, ""ThreadsTerminated"": 0, ""LogFatal"": 0, ""LogError"": 0, ""LogWarn"": 0, ""LogInfo"": 0 }, {code} It can be observed that 2.0.x onwards the field ""tag.ProcessName"" is populating as ""IO"" instead of expected ""RegionServer"" or ""Master"". Ambari relies on this field process name to create a metric 'jvm.RegionServer.JvmMetrics.GcTimeMillis' etc. See [code.|https://github.com/apache/ambari/blob/2ec4b055d99ec84c902da16dd57df91d571b48d6/ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java#L722] But post 2.0.x the field is getting populated as 'IO' and hence a metric with name 'jvm.JvmMetrics.GcTimeMillis' is created instead of expected 'jvm.RegionServer.JvmMetrics.GcTimeMillis', thus mixing up the metric with various other metrics coming from rs, master, spark executor etc. running on same host. *Expected* Field ""tag.ProcessName"" should be populated as ""RegionServer"" or ""Master"" instead of ""IO"". *Actual* Field ""tag.ProcessName"" is populating as ""IO"" instead of expected ""RegionServer"" or ""Master"" causing incorrect metric being published by ambari and thus mixing up all metrics and raising various alerts around JVM metrics." TestClusterScopeQuotaThrottle is still failing with broken WAL writer,13547805,Resolved,Major,Fixed,18/Aug/23 01:35,14/Jan/24 07:25,,"{noformat} 2023-08-17T10:47:31,026 WARN [regionserver/jenkins-hbase19:0.logRoller {}] asyncfs.FanOutOneBlockAsyncDFSOutputHelper(515): create fan-out dfs output /user/jenkins/test-data/bb8017fa-92f5-92c9-2f1d-aa9b90cf4b80/WALs/jenkins-hbase19.apache.org,43363,1692269230784/jenkins-hbase19.apache.org%2C43363%2C1692269230784.meta.1692433272886.meta failed, retry = 0 org.apache.hadoop.ipc.RemoteException: File /user/jenkins/test-data/bb8017fa-92f5-92c9-2f1d-aa9b90cf4b80/WALs/jenkins-hbase19.apache.org,43363,1692269230784/jenkins-hbase19.apache.org%2C43363%2C1692269230784.meta.1692433272886.meta could only be written to 0 of the 1 minReplication nodes. There are 2 datanode(s) running and 2 node(s) are excluded in this operation. at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.chooseTarget4NewBlock(BlockManager.java:2276) at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.chooseTargetForNewBlock(FSDirWriteFileOp.java:294) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2820) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:910) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:577) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:549) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:518) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1086) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1035) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:963) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1762) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2960) at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1612) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1558) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1455) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:231) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:118) ~[hadoop-common-3.2.4.jar:?] at com.sun.proxy.$Proxy41.addBlock(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.addBlock(ClientNamenodeProtocolTranslatorPB.java:520) ~[hadoop-hdfs-client-3.2.4.jar:?] at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:433) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:166) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:158) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:96) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:362) ~[hadoop-common-3.2.4.jar:?] at com.sun.proxy.$Proxy42.addBlock(Unknown Source) ~[?:?] at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:361) ~[classes/:?] at com.sun.proxy.$Proxy45.addBlock(Unknown Source) ~[?:?] at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:361) ~[classes/:?] at com.sun.proxy.$Proxy45.addBlock(Unknown Source) ~[?:?] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:492) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$300(FanOutOneBlockAsyncDFSOutputHelper.java:120) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$7.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:569) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$7.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:564) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) ~[hadoop-common-3.2.4.jar:?] at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:577) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:54) ~[hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:183) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:167) ~[classes/:?] at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:114) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:241) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:247) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:104) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriterInternal(AbstractFSWAL.java:1050) ~[classes/:?] at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$rollWriter$9(AbstractFSWAL.java:1082) ~[classes/:?] at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:1082) ~[classes/:?] at org.apache.hadoop.hbase.wal.AbstractWALRoller$RollController.rollWal(AbstractWALRoller.java:311) ~[classes/:?] at org.apache.hadoop.hbase.wal.AbstractWALRoller.run(AbstractWALRoller.java:212) ~[classes/:?] {noformat} Need to dig more." Corrupt HFile data is mishandled in several cases,13549777,Resolved,Major,Fixed,06/Sep/23 11:20,21/Sep/23 10:09,2.5.2,"While riding over a spat of HDFS data corruption issues, we've observed several places in the read path that do not fall back to HDFS checksum appropriately. These failures manifest during client reads and during compactions. Sometimes failure is detected by the fallback {{verifyOnDiskSizeMatchesHeader}}, sometimes we attempt to allocate a buffer with a negative size, and sometimes we read through to a failure from block decompression. After code study, I think that all three cases arise from using a block header that was read without checksum validation. Will post up the stack traces in the comments. Not sure if we'll want a single patch or multiple." Implement truncate_region command to truncate region directly from FS,13549724,Resolved,Major,Fixed,05/Sep/23 23:08,31/Oct/23 10:45,2.5.6,"One of our users has brought up a use-case where they need to truncate a region to delete data within a specific range. There are two scenarios to consider: * In the first scenario, the region boundaries involve a time range defined through pre-splitting, and user is looking to efficiently clean old date data. If HBase can directly truncate the region from the file system and then the user can merge the empty region with adjacent regions to effectively eliminate it which will be more optimized compared to deleting the data using Delete API. * In another case, if the HFile for that region becomes corrupted for some reason, user want to get rid of the HFile and reload the entire region to avoid consistency issues and ensure performance. we can do this by taking the region offline and taking write lock to avoid the consideration of race conditions involving Region In Transition (RITs), region re-opening, and merge/split scenarios. " Performance improvement for scan over several stores. ,13549217,Resolved,Major,Fixed,31/Aug/23 05:06,07/Sep/23 02:19,2.5.5,"During the fix of HBASE-19863, an additional check for fake cells that trigger reseek was added.  It comes that this check produces unnecessary reseeks because matcher.compareKeyForNextColumn should be used only with indexed keys. Later  [~larsh] suggested doing a simple check for OLD_TIMESTAMP and it looks like a better solution." Add TLS settings to ZooKeeper client,13548266,Resolved,Major,Fixed,22/Aug/23 16:36,05/Sep/23 09:44,2.4.17,"ZooKeeper supports TLS connection from its clients. Currently the only way to set up HBase for this is to add the following Java properties to the HBase process: {noformat}       -Dzookeeper.clientCnxnSocket=org.apache.zookeeper.ClientCnxnSocketNetty         -Dzookeeper.client.secure=true         -Dzookeeper.ssl.keyStore.location=/path/to/keystore.jks         -Dzookeeper.ssl.keyStore.password=password         -Dzookeeper.ssl.trustStore.location=/path/to/truststore.jks         -Dzookeeper.ssl.trustStore.password=password {noformat} KeyStore is only needed if ZooKeeper server wants client certificate to be provided. I'd like to add these options to hbase-site.xml in the following way: {noformat} hbase.zookeeper.property.clientCnxnSocket hbase.zookeeper.property.client.secure hbase.zookeeper.property.ssl.keyStore.location hbase.zookeeper.property.ssl.keyStore.password or hbase.zookeeper.property.ssl.keyStore.passwordPath ...{noformat} It will follow the way that we already do for ZooKeeper clientPort and quorum settings. (""hbase.zookeeper.property.clientPort"", ""hbase.zookeeper.quorum"")" Persistent cache map can get corrupt if crash happens midway through the write,13545732,Resolved,Major,Fixed,01/Aug/23 15:18,23/Aug/23 15:57,2.6.0,"HBASE-27686 added a background thread for periodically saving the cache index map, together with a list of completed cached files so that we can recover the cache state in case of crash or restart. Problem is that the cache index can become few GB large (a sample case with 1.6TB of used bucket cache would map to between 8GB to 10GB indexes), and these writes take few seconds to complete, causing any RS crash very likely to leave a corrupt index file that can't be recovered when the RS starts again. Worse, since we store the list of cached files on a separate file, this also leads to cache inconsistencies, with files in the list of cached files never cached once the RS is restarted, even though we have no cache index for those and every read ends up going to the FS. This task aims to refactor the cache persistent as follows: 1) Write both the list of completely cached files and the cache indexes in a single file, so that we can have this synced atomically; 2) When writing the persistent cache file, use a temp name first, then once the write is successfully finished, rename it to the actual name. This way, if crash happens whilst the persistent cache is still being written, the temp file would be corrupt, but we could still recover from the last successful sync, and we would only lose the caching ops since the last sync." Limit max count of rows filtered per scan request.,13551602,Open,Major,,22/Sep/23 02:37,,3.0.0,"In some scenarios, when users do not understand the impact of the filters they set, it may lead to a large number of rows being filtered, causing very high CPU usage and system load, which may affect the requests of others. Therefore, we need to have the defensive capability to detect and kill such abnormal requests." Netty SSL throughput improvement,13547720,Resolved,Major,Fixed,17/Aug/23 12:15,14/Dec/23 13:19,,"Digging into HBASE-27947, I discovered an area for optimization in netty's SslHandler. I submitted that upstream to [https://github.com/netty/netty/issues/13549,] and submitted a PR for their review [https://github.com/netty/netty/pull/13551.]  It's likely we will need changes in HBase to integrate this, including updating hbase-thirdparty once the change is released, and adding support for calling SslHandler.setWrapDataSize. This issue encapsulates that work." Client metrics are missing response and request size data when using netty,13547017,Resolved,Major,Fixed,11/Aug/23 20:47,24/Oct/23 14:35,,CallStats.setResponseSizeBytes and setRequestSizeBytes are only called in BlockingRpcConnection. So the rpcCallResponseSizeBytes_ and rpcCallRequestSizeBytes_ values are all zeroes when using netty (our default). We might need to add some calls to it in NettyRpcDuplexHandler. [hbase-thirdparty] Bump thirdparty dependencies,13551167,Resolved,Major,Fixed,19/Sep/23 02:40,19/Sep/23 06:39,,"protobuf 3.21.12 -> 3.24.3 netty 4.1.87.Final -> 4.1.97.Final guava 31.1-jre -> 32.1.2-jre error_prone 2.18.0 -> 2.21.1 jetty 9.4.50.v20221201 -> 9.4.52.v20230823 jersey 2.38 -> 2.40 javassist 3.25.0-GA -> 3.29.2-GA jackson 2.14.1 -> 2.15.2" Provide the switch to avoid reopening regions in the alter sync command,13552475,Resolved,Major,Invalid,29/Sep/23 16:52,01/Dec/23 22:26,2.0.0-alpha-1,"As part of the sub-task, as HBase 2 supports both Async and Sync API, this task is to add this support/feature to HBase 2's Sync API." Port the switch to avoid reopening regions in the alter async in HBase 2,13552478,Resolved,Major,Invalid,29/Sep/23 16:59,01/Dec/23 22:25,2.0.0-alpha-1,"As part of the sub-task, as HBase 2 supports both Async and Sync API, this task is to port the feature added in HBase 3 alter(async default) layer to HBase 2's async side. There is a separate sub-task for adding it to HBase 2's sync side." Add documentation section for the Cache Aware balancer function,13551251,Resolved,Major,Fixed,19/Sep/23 15:03,02/Nov/23 16:47,, Reduce seeks from beginning of block in StoreFileScanner.seekToPreviousRow,13548462,Resolved,Major,Fixed,24/Aug/23 04:01,09/Nov/23 15:17,,"Currently, for non-RIV1 DBE encodings, each call to [StoreFileScanner.seekToPreviousRow|https://github.com/apache/hbase/blob/89ca7f4ade84c84a246281c71898543b6161c099/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java#L493-L506] (a common operation in reverse scans) results in two seeks:  # Seek from the beginning of the block to before the given row to find the prior row # Seek from the beginning of the block to the first cell of the prior row So if there are ""N"" rows in a block, a reverse scan through each row results in seeking past summation from i=1 to N (2(i-1)) rows.   This is a particularly expensive operation for tall tables that have many rows in a block.   By introducing a state variable ""previousRow"" to StoreFileScanner, I believe that we could modify the seeking algorithm to be: # Seek from the beginning of the block to before the given row to find the prior row # Seek from the beginning of the block to before the row that is before the row that was just seeked to (i.e. 2 rows back). _Save_ this as a hint for where the prior row is in ""previousRow"" # Reseek from ""previousRow"" (2 rows back from start) to 1 row back from start (to the actual previousRow) Then the rest of the calls where a ""previousRow"" is present, you just need to seek to the beginning of the block once instead of twice, i.e.  # seek from the beginning of the block to right before the beginning of your ""previousRow"" marker. Save this as the new ""previousRow"" marker # Reseek to the next row (i.e. your previous ""previousRow"" marker)   If there are ""N"" rows in a block, a reverse scan from row N to row 0 results in seeking past approximately summation from i=1 to N (i-1) rows i.e. 50% less than the current behavior.   See the attached diagrams for the current and proposed behavior.     " TLSv1.3-compatible cipher suites are not used by default,13552485,Resolved,Major,Fixed,29/Sep/23 18:52,09/Nov/23 01:14,2.5.5,"The X509Util class has a system for choosing the cipher suites to support on TLS connections, if {{hbase.rpc.tls.ciphersuites}} is not provided. It also allows you choose what protocol you want via the {{hbase.rpc.tls.enabledProtocols}} config. If {{hbase.rpc.tls.enabledProtocols}} is set to {{{}TLSv1.3{}}}, and {{hbase.rpc.tls.ciphersuites}} is not set, the user of X509Util cannot form any working TLS connections. This is because all the cipher suites chosen by X509Utils are pre-TLSv1.3 suites, and so are rejected during connection handshakes. [TLSv1.3 requires or suggests support|https://www.rfc-editor.org/rfc/rfc8446#section-9.1] for these suites, none of which are shared in common with TLSv1.2: * {{TLS_AES_256_GCM_SHA384}} * {{TLS_CHACHA20_POLY1305_SHA256}} * {{TLS_AES_128_GCM_SHA256}} Of these, the intersection of [BoringSSL|https://github.com/google/boringssl/blob/master/ssl/test/runner/cipher_suites.go] and [Java 11+|https://docs.oracle.com/en/java/javase/11/docs/specs/security/standard-names.html#jsse-cipher-suite-names] support {{TLS_AES_128_GCM_SHA256}} and {{{}TLS_AES_256_GCM_SHA384{}}}, so those should be added to the defaults in X509Util. BoringSSL and the JVM are the two crypto providers used here.  " Configurably use scanner timeout as rpc timeout for scanner next calls,13550700,Resolved,Major,Fixed,14/Sep/23 13:31,09/Nov/23 22:37,,"In the AsyncTable implementation, scanner next() calls use ""hbase.client.scanner.timeout.period"" as the rpc timeout. The reason is described in comments, and makes a lot of sense: {code:java} // As we have a call sequence for scan, it is useless to have a different rpc timeout which is // less than the scan timeout. If the server does not respond in time(usually this will not // happen as we have heartbeat now), we will get an OutOfOrderScannerNextException when // resending the next request and the only way to fix this is to close the scanner and open a // new one. {code} The branch-2 HTable implementation still uses the old behavior – the next() call passes the read rpc timeout as the rpc timeout, and uses the scanner timeout period as the operation timeout. This can lead to the above behavior. It would be nice to provide users a migration path to AsyncTable's behavior, in the form of a config flag which causes HTable to use ""hbase.client.scanner.timeout.period"" as rpc timeout for next() calls like AsyncTable does." LogRoller stuck by FanOutOneBlockAsyncDFSOutputHelper.createOutput waitting get future all time,13552410,Patch Available,Major,,29/Sep/23 09:43,,2.2.7,"We found this problem in our production. LogRoller stuck by FanOutOneBlockAsyncDFSOutputHelper.createOutput waitting get future all time !image-2023-09-29-17-23-04-560.png|width=566,height=191! Check the regionserver's log, the regionServer do sasl negotiate with two dataNode, but just one check complete. Another do nothing after connected with dn. {code:java} 518415 2023-04-17 14:17:25,434 INFO io.transwarp.guardian.client.cache.PeriodCacheUpdater: Fetch change version: 0 518416 2023-04-17 14:17:29,092 DEBUG org.apache.hadoop.hbase.ScheduledChore: RefreshCredentials execution time: 0 ms. 518417 2023-04-17 14:17:29,768 DEBUG org.apache.hadoop.hbase.ScheduledChore: CompactionChecker execution time: 0 ms. 518418 2023-04-17 14:17:29,768 DEBUG org.apache.hadoop.hbase.ScheduledChore: CompactionThroughputTuner execution time: 0 ms.518419 2023-04-17 14:17:29,768 DEBUG org.apache.hadoop.hbase.ScheduledChore: MemstoreFlusherChore execution time: 0 ms. 518420 2023-04-17 14:17:29,768 DEBUG org.apache.hadoop.hbase.ScheduledChore: gy-dmz-swrzjzcc-gx-2-19,60020,1677341424491-Hea       pMemoryTunerChore execution time: 0 ms. 518421 2023-04-17 14:17:39,375 DEBUG org.apache.hadoop.hbase.regionserver.LogRoller: WAL AsyncFSWAL gy-dmz-swrzjzcc-gx-2-19%       2C60020%2C1677341424491:(num 1681711899342) roll requested 518422 2023-04-17 14:17:39,389 DEBUG org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper: SASL client        doing general handshake for addr = 10.179.157.10/10.179.157.10, datanodeId = DatanodeInfoWithStorage[10.179.157.10:50       010,DS-4815c34a-8d0c-42b9-b56c-529d2732d956,DISK] 518423 2023-04-17 14:17:39,391 DEBUG org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper: SASL client        doing general handshake for addr = 10.179.157.29/10.179.157.29, datanodeId = DatanodeInfoWithStorage[10.179.157.29:50       010,DS-509f84fe-2e88-403e-87b5-f4765e49094f,DISK] 518424 2023-04-17 14:17:39,392 DEBUG org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper: Verifying QO       P, requested QOP = [auth], negotiated QOP = auth 518425 2023-04-17 14:17:39,743 DEBUG org.apache.hadoop.hbase.ScheduledChore: MemstoreFlusherChore execution time: 0 ms. 518426 2023-04-17 14:17:39,743 DEBUG org.apache.hadoop.hbase.ScheduledChore: CompactionChecker execution time: 0 ms. 518427 2023-04-17 14:17:49,977 DEBUG org.apache.hadoop.hbase.ScheduledChore: CompactionChecker execution time: 0 ms. 518428 2023-04-17 14:17:49,977 DEBUG org.apache.hadoop.hbase.ScheduledChore: MemstoreFlusherChore execution time: 0 ms. 518429 2023-04-17 14:17:55,492 INFO {code} FanOutOneBlockAsyncDFSOutputHelper.createOutput will connect and trySaslNegotiate to dataNode. In Sasl authentication mode, SaslNegotiateHandler will be used to handle authentication. If datanode is shut down, SaslNegotiateHandler.channelInactive do not  call back to promise and cause future to be stuck forever. {code:java} @Override public void handlerAdded(ChannelHandlerContext ctx) throws Exception { ctx.write(ctx.alloc().buffer(4).writeInt(SASL_TRANSFER_MAGIC_NUMBER)); sendSaslMessage(ctx, new byte[0]); ctx.flush(); step++; } @Override public void channelInactive(ChannelHandlerContext ctx) throws Exception { saslClient.dispose(); } {code} So SaslNegotiateHandler.channelInactive should call promise.tryFailure to avoid future stuck forever.    " Adding capability to move_servers_rsgroup for all servers without explicitly passing servers,13548765,Open,Major,,28/Aug/23 03:35,,,"In case of requirement for moving entire servers from a region server to a destination server, currently hbase client has to get list of servers from a rs group and then pass these servers for movement as below. {code:bash} hbase> move_servers_rsgroup 'dest',['server1:port','server2:port'] {code} However idea should be to move all servers by specifying source and destination rs group and the list servers can be handled internally be hbase code instead of hbase client code/shell. Expected: {code:bash} hbase> move_all_servers_rsgroup 'dest','src' {code}" Align TestShadeSaslAuthenticationProvider between different branches,13551781,Resolved,Major,Fixed,24/Sep/23 13:42,25/Oct/23 12:37,,"The testNegativeAuthentication method is completely different between master/branch-3 and branch-2.x, we should try to align the test for these branches." [HBCK2] extraRegionsInMeta need supoort delete extra regions when table not exist,13552270,Open,Major,,28/Sep/23 07:52,,2.4.14,"Some times, we delete one table dir on hdfs, we need use hbck2 to fix region info in hbase:meta... but some times, we use hbase shell delete the table state uncarefully，just like execute: deleteall 'hbase:meta','t1,xxx' (it not prevented...) then the table state lose when we want to use extraRegionsInMeta to remove these unuseful regions in meta...but it failed,beacuse the table is not exist.. I think we should support do extraRegionsInMeta when table not exists...or there are other method to fix it?" Add more comments to explain why replication log queue could never be empty for normal replication queue,13552141,Resolved,Major,Fixed,27/Sep/23 08:14,20/Oct/23 14:37,,"In HBASE-28037, [~Xiaolin Ha] found that there could be a very small window that even for a normal replication source, its queue could be empty. This is because we will only enqueue the wal file to the queue in postLogRoll, where the old WAL writer has already been closed, so if the replication is fast enough, we could reach the end of the queue before enqueuing the new wal file. The code for branch-2+ has been refactored a lot so we opened a new issue for fixing this." Modify the way of acquiring the RegionStateNode lock in checkOnlineRegionsReport to tryLock,13552101,Resolved,Major,Fixed,26/Sep/23 23:49,19/Oct/23 15:41,,"HBase Cluster description: *1 master and 5 region servers* During the execution of itbll process, when ChaosMonkey performs RestartRandomRsAction, it triggers this issue. The steps for the RestartRandomRsAction operation are as follows.{*}：{*} # stop node-3, node-2, node-4。 # then stop the node-5 that holds the meta node. # start node-3 # then stop node-1。 # start node-2, node-4, node-5, node-1。 *Fault description:* 1. The RegionServer nodes, including node-2, node-4, node-5, and node-1, are unable to come online. Observing the RegionServer logs, the reportForDuty operation consistently times out. The log is as follows: {code:java} 2023-09-21T08:05:30,251 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 2023-09-21T08:05:43,581 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 2023-09-21T08:05:59,591 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 2023-09-21T08:06:21,601 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 2023-09-21T08:06:55,611 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 2023-09-21T08:07:53,620 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 2023-09-21T08:09:39,631 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 2023-09-21T08:13:01,642 INFO  [regionserver/core-1-2:16020] regionserver.HRegionServer: reportForDuty to master=master-1-1,16000,1695254395517 with port=16020, startcode=1695254725874 {code} 2. The master thread is blocked. * All two RpcServer.priority.RWQ.Fifo.write.handler threads are blocked on RegionStateNode.lock {code:java} ""RpcServer.priority.RWQ.Fifo.write.handler=1,queue=0,port=16000"" #67 daemon prio=5 os_prio=0 tid=0x00007f6ae3caf800 nid=0xea405 waiting on condition [0x00007f6aa1dcd000]    java.lang.Thread.State: WAITING (parking)     at sun.misc.Unsafe.park(Native Method)     - parking to wait for  <0x00000004e3c8e6f0> (a java.util.concurrent.locks.ReentrantLock$NonfairSync)     at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)     at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)     at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)     at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)     at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)     at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)     at org.apache.hadoop.hbase.master.assignment.RegionStateNode.lock(RegionStateNode.java:323)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.checkOnlineRegionsReport(AssignmentManager.java:1401)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.reportOnlineRegions(AssignmentManager.java:1363)     at org.apache.hadoop.hbase.master.MasterRpcServices.regionServerReport(MasterRpcServices.java:639)     at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:17395)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:437)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) {code} * 20 PEWorker threads are blocked on RegionStateStore.updateRegionLocation. {code:java} ""PEWorker-1"" #133 daemon prio=5 os_prio=0 tid=0x00007f6acdcf9800 nid=0xea5bc waiting on condition [0x00007f6a9d799000]    java.lang.Thread.State: WAITING (parking)     at sun.misc.Unsafe.park(Native Method)     - parking to wait for  <0x00000004e4cc8e58> (a java.util.concurrent.CompletableFuture$Signaller)     at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)     at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1707)     at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323)     at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1742)     at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)     at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:182)     at org.apache.hadoop.hbase.client.TableOverAsyncTable.put(TableOverAsyncTable.java:213)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:259)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:224)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.regionClosedAbnormally(AssignmentManager.java:2076)     at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:305)     at org.apache.hadoop.hbase.master.assignment.RegionRemoteProcedureBase.execute(RegionRemoteProcedureBase.java:57)     at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:921)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread$$Lambda$610/726348606.call(Unknown Source)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1989) {code} * All four KeepAlivePEWorker threads are blocked. KeepAlivePEWorker-17 18 19 are blocked on RegionStateStore.updateRegionLocation {code:java} ""KeepAlivePEWorker-17"" #381 daemon prio=5 os_prio=0 tid=0x000056260b75d000 nid=0xeffb0 waiting on condition [0x00007f6a94339000]    java.lang.Thread.State: WAITING (parking)     at sun.misc.Unsafe.park(Native Method)     - parking to wait for  <0x00000004ebf83440> (a java.util.concurrent.CompletableFuture$Signaller)     at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)     at java.util.concurrent.CompletableFuture$Signaller.block(CompletableFuture.java:1707)     at java.util.concurrent.ForkJoinPool.managedBlock(ForkJoinPool.java:3323)     at java.util.concurrent.CompletableFuture.waitingGet(CompletableFuture.java:1742)     at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908)     at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:182)     at org.apache.hadoop.hbase.client.TableOverAsyncTable.put(TableOverAsyncTable.java:213)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:259)     at org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateRegionLocation(RegionStateStore.java:224)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.transitStateAndUpdate(AssignmentManager.java:1982)     at org.apache.hadoop.hbase.master.assignment.AssignmentManager.regionOpening(AssignmentManager.java:1997)     at org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.openRegion(TransitRegionStateProcedure.java:279)     at org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.executeFromState(TransitRegionStateProcedure.java:434)     at org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.executeFromState(TransitRegionStateProcedure.java:111)     at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188)     at org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.execute(TransitRegionStateProcedure.java:398)     at org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.execute(TransitRegionStateProcedure.java:111)     at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:921)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread$$Lambda$610/726348606.call(Unknown Source)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1989) {code} * KeepAlivePEWorker-20 are blocked on RegionStateNode.lock {code:java} ""KeepAlivePEWorker-20"" #388 daemon prio=5 os_prio=0 tid=0x000056260b847800 nid=0xf02da waiting on condition [0x00007f6a92e25000]    java.lang.Thread.State: WAITING (parking)     at sun.misc.Unsafe.park(Native Method)     - parking to wait for  <0x00000004e3c8d990> (a java.util.concurrent.locks.ReentrantLock$NonfairSync)     at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)     at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)     at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)     at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)     at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)     at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)     at org.apache.hadoop.hbase.master.assignment.RegionStateNode.lock(RegionStateNode.java:323)     at org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.assignRegions(ServerCrashProcedure.java:551)     at org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.executeFromState(ServerCrashProcedure.java:243)     at org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.executeFromState(ServerCrashProcedure.java:68)     at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188)     at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:921)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread$$Lambda$610/726348606.call(Unknown Source)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)     at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1989) {code}" Deal with the replication queue empty problem for sync replication,13552143,Resolved,Major,Not A Problem,27/Sep/23 08:20,20/Oct/23 14:38,,"For sync replication, when the peer state changed from ACTIVE to DOWNGRADE_ACTIVE or STANDBY, the special replication group(which contains a timestamp in it) could also be empty, and this is acceptable. We should deal with this too." NPE for the region state: Failed to become active master (HMaster),13551758,Resolved,Major,Fixed,23/Sep/23 20:58,07/Oct/23 08:11,2.4.17,"When starting up HBase cluster (2.4.17), I met NPE and it prevents HMaster from starting up. I have to restart the HMaster. My cluster contains 1 HMaster, 2 RS (HBase-2.4.17) and 1 Hadoop node (2.10.2). {code:java} 2023-09-18 14:17:35,931 INFO  [PEWorker-1] procedure2.ProcedureExecutor: Rolled back pid=1, state=ROLLEDBACK, exception=org.apache.hadoop.hbase.exceptions.TimeoutIOException via ProcedureExecutor:org.apache.hadoop.hbase.exceptions.TimeoutIOException: Operation timed out after 1.0010 sec; InitMetaProcedure table=hbase:meta exec-time=1.4660 sec 2023-09-18 14:17:35,931 INFO  [master/hmaster:16000:becomeActiveMaster] master.HMaster: Wait for region servers to report in: status=null, state=RUNNING, startTime=1695046655931, completionTime=-1 2023-09-18 14:17:35,932 INFO  [master/hmaster:16000:becomeActiveMaster] master.ServerManager: Waiting on regionserver count=2; waited=0ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=0ms 2023-09-18 14:17:37,438 INFO  [master/hmaster:16000:becomeActiveMaster] master.ServerManager: Waiting on regionserver count=2; waited=1505ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=1505ms 2023-09-18 14:17:38,941 INFO  [master/hmaster:16000:becomeActiveMaster] master.ServerManager: Waiting on regionserver count=2; waited=3009ms, expecting min=1 server(s), max=NO_LIMIT server(s), timeout=4500ms, lastChange=3009ms 2023-09-18 14:17:40,445 INFO  [master/hmaster:16000:becomeActiveMaster] master.ServerManager: Finished waiting on RegionServer count=2; waited=4513ms, expected min=1 server(s), max=NO_LIMIT server(s), master is running 2023-09-18 14:17:40,452 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.NullPointerException         at org.apache.hadoop.hbase.master.HMaster.isRegionOnline(HMaster.java:1229)         at org.apache.hadoop.hbase.master.HMaster.waitForMetaOnline(HMaster.java:1218)         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:968)         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2193)         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:528)         at java.lang.Thread.run(Thread.java:750) 2023-09-18 14:17:40,453 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [org.apache.hadoop.hbase.quotas.MasterQuotasObserver] {code} h1. Root Cause From the stack trace, the rs variable is NULL and it's directly used without checking. {code:java} // hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /**    * @return True if region is online and scannable else false if an error or shutdown (Otherwise we    *         just block in here holding up all forward-progess).    */   private boolean isRegionOnline(RegionInfo ri) {     RetryCounter rc = null;     while (!isStopped()) { // NPE line       RegionState rs = this.assignmentManager.getRegionStates().getRegionState(ri);       if (rs.isOpened()) {         if (this.getServerManager().isServerOnline(rs.getServerName())) {           return true;         }       }       // Region{code} I am not sure what causes the *rs* to be null but maybe we can add a check to make sure this NPE is captured and properly handled. Restart the HMaster and this exception will disappear. I have attached the full log from HMaster for this case. I run into this exception when using HBase 2.4.17 but I think it might also happen in the latest branch since the code of isRegionOnline is the same. h1. Fix This bug happens rarely. I think we can add a simple check to know whether rs is null and then decide whether to keep waiting or directly shutdown the HMaster. I assume that if HMaster wait for more time, it will get correct responses from regionservers. I have a simple PR to fix it. https://github.com/apache/hbase/pull/5432" [hbase-thirdparty] Release hbase-thirdparty 4.1.5,13551166,Resolved,Major,Fixed,19/Sep/23 02:38,06/Oct/23 14:01,,"Netty 4.1.97.Final is out, which includes our TLS improvements https://github.com/netty/netty/pull/13551 contributed by [~bbeaudreault]. Let's upgrade the dependencies and make a new thirdparty release." [hbase-thirdparty] Put up hbase-thirdparty 4.1.5RC0,13551168,Resolved,Major,Fixed,19/Sep/23 02:41,06/Oct/23 14:01,, Make sync replication also work with FSHLog,13543162,Resolved,Major,Fixed,11/Jul/23 14:31,30/Sep/23 08:27,, TableRequests metrics broken after altering table,13552492,Open,Major,,29/Sep/23 20:46,,,"Alerting a table reopens all regions. I noticed after altering one of my tables that afterwards the TableRequests metrics no longer update. They seem stuck at whatever they were prior. I'm thinking this has something to do with the refactor done in https://issues.apache.org/jira/browse/HBASE-27681, which attempts to deregister metrics when a table is removed from the server. I think when it gets re-registered the new metrics aren't linked to whatever the jmx adapter is looking at. [~tianhang] FYI" procedureWAL can not delete after bypass procedure recurisive,13546633,Open,Major,,09/Aug/23 06:41,,2.2.7,"We found 1.2T logs in /hbase1/MasterProcWALs, because WALProcedureStore can not delete wal logs after bypass parent procedure recurisive.  When bypass TRSP recurisive, TRSP and ORP/CRP will run on race. TRSP call store.delete for ORP/CRP, then ORP/CRP release lock and call store.update to override delete.    {code:java} 1. OPR bypassing and upd wal EntryType=PROCEDURE_WAL_UPDATE pid=241, ppid=240, state=RUNNABLE, bypass=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure submittedTime=1691398235997, lastUpdate=1691398236007 stackIndexes=[2] 2. TRSP bypassing and upd wal by OPR EntryType=PROCEDURE_WAL_UPDATE pid=240, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED, bypass=true; TransitRegionStateProcedure table=t4, region=57f33b87c08a532869d4eaf9b16e9162, ASSIGN submittedTime=1691398235706, lastUpdate=1691398235997 stackIndexes=[0, 1] 3. TRSP bypassing and upd wal by self EntryType=PROCEDURE_WAL_UPDATE pid=240, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED, bypass=true; TransitRegionStateProcedure table=t4, region=57f33b87c08a532869d4eaf9b16e9162, ASSIGN submittedTime=1691398235706, lastUpdate=1691398235997 stackIndexes=[0, 1] 4. ORP running, get lock and upd wal EntryType=PROCEDURE_WAL_UPDATE pid=241, ppid=240, state=RUNNABLE, bypass=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure submittedTime=1691398235997, lastUpdate=1691398236007 stackIndexes=[2] 6. TRSP bypassing, set status and upd wal EntryType=PROCEDURE_WAL_UPDATE pid=240, state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_OPENED, bypass=true; TransitRegionStateProcedure table=t4, region=57f33b87c08a532869d4eaf9b16e9162, ASSIGN submittedTime=1691398235706, lastUpdate=1691398251253 stackIndexes=[0, 1] 7. ORP running end, upd wal EntryType=PROCEDURE_WAL_UPDATE pid=241, ppid=240, state=SUCCESS, bypass=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure submittedTime=1691398235997, lastUpdate=1691398251253 stackIndexes=[2, 3] 8. TRSP running end, delete wal for child EntryType=PROCEDURE_WAL_DELETE pid=240, state=SUCCESS, bypass=true; TransitRegionStateProcedure table=t4, region=57f33b87c08a532869d4eaf9b16e9162, ASSIGN submittedTime=1691398235706, lastUpdate=1691398251260 stackIndexes=[0, 1, 4] 9. TRSP release lock and upd wal EntryType=PROCEDURE_WAL_UPDATE pid=240, state=SUCCESS, bypass=true; TransitRegionStateProcedure table=t4, region=57f33b87c08a532869d4eaf9b16e9162, ASSIGN submittedTime=1691398235706, lastUpdate=1691398251260 stackIndexes=[0, 1, 4] 10. ORP release lock and upd wal EntryType=PROCEDURE_WAL_UPDATE pid=241, ppid=240, state=SUCCESS, bypass=true; org.apache.hadoop.hbase.master.assignment.OpenRegionProcedure submittedTime=1691398235997, lastUpdate=1691398251253 stackIndexes=[2, 3] 11. TRSP delete wal in compled EntryType=PROCEDURE_WAL_DELETE EntryType=PROCEDURE_WAL_DELETE {code}    " Bump org.xerial.snappy:snappy-java from 1.1.10.1 to 1.1.10.4,13551988,Resolved,Major,Fixed,26/Sep/23 07:21,26/Sep/23 07:42,, NPE in QuotaCache if Table is dropped from cluster,13551470,Resolved,Major,Fixed,21/Sep/23 01:36,25/Sep/23 17:35,2.4.17,"When running HBase-2.4.17, I met a NPE in regionserver log. h1. Reproduce Config HBase cluster: 1 HMaster, 2 RS, 2.10.2 Hadoop. Execute the following commands in the HMaster node using hbase shell,  {code:java} create 'uuidd9efa97f93a442b686adae6d9f7bb2e9', {NAME => 'uuid099cbece77834a83a52bb0611c3ea080', VERSIONS => 3, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'false'}, {NAME => 'uuidbc1bea73952749329d7f025aab382c4e', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'ROW', IN_MEMORY => 'false'}, {NAME => 'uuidff292310d9dc450697af2bb25d9f3e98', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'NONE', IN_MEMORY => 'false'}, {NAME => 'uuid449de028da6b4d35be0f187ebec6c3be', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'ROW', IN_MEMORY => 'false'}, {NAME => 'uuidc0840c98f9d348a18f2d454c7a503b65', VERSIONS => 2, COMPRESSION => 'GZ', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'false'} create_namespace 'uuidec797633f5dd4ab9b96276135aeda9e2' create 'uuiddeb610fded9744889840ecd03dd18739', {NAME => 'uuid30a0f625ad454605908b60c932957ff0', VERSIONS => 1, COMPRESSION => 'GZ', BLOOMFILTER => 'ROW', IN_MEMORY => 'true'} incr 'uuidd9efa97f93a442b686adae6d9f7bb2e9', 'uuid46ddc3d3557e413e915e2393ae72c082', 'uuidbc1bea73952749329d7f025aab382c4e:JZycbUSpbDQmwgXinp', 1 flush 'uuidd9efa97f93a442b686adae6d9f7bb2e9', 'uuid449de028da6b4d35be0f187ebec6c3be' drop 'uuiddeb610fded9744889840ecd03dd18739' put 'uuidd9efa97f93a442b686adae6d9f7bb2e9', 'uuidf4704cae4d1e4661bd7664d26eb6b31b', 'uuidbc1bea73952749329d7f025aab382c4e:JZycbUSpbDQmwgXinp', 'XlPpFGvSYfcEXWXgwARytlSeiaSuHJFqpirMmLduqGnpdXLlHJWBumraXiifQSvHqNHmTcyzLQIvuQrkujPghfdtRkhOkgKEJHsAuAiMMeWZjdTHNZqhkOdJBOzsRYUXKOCNKeSxEDWgnKgsFDHMtxdnKKudBuceOgYmCrdaPXMclKkZKCIEiFDcdoAEJGKXYVfOjb' disable 'uuidd9efa97f93a442b686adae6d9f7bb2e9' drop 'uuidd9efa97f93a442b686adae6d9f7bb2e9' create 'uuid9d05a5cb34e64910ac90675186e7d0d4', {NAME => 'uuid1ce512a5997b4efea3bdead2e7f723c3', VERSIONS => 2, COMPRESSION => 'NONE', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'true'}, {NAME => 'uuid0b1baaa4275e46b2a3a1d11d6540fc30', VERSIONS => 2, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'true'} put 'uuid9d05a5cb34e64910ac90675186e7d0d4', 'uuid552e42ade4c14099a1d8643bea1616d4', 'uuid1ce512a5997b4efea3bdead2e7f723c3:l', 1 drop 'uuid9d05a5cb34e64910ac90675186e7d0d4'{code} The exception will be thrown in either RS1 or RS2 {code:java} 2023-09-19 20:29:28,268 INFO  [RS_OPEN_REGION-regionserver/hregion2:16020-2] handler.AssignRegionHandler: Opened uuid9d05a5cb34e64910ac90675186e7d0d4,,1695155367072.f59a0693a9469f9e1f131bf2aac1486d. 2023-09-19 20:29:29,205 ERROR [regionserver/hregion2:16020.Chore.1] hbase.ScheduledChore: Caught error java.lang.NullPointerException         at org.apache.hadoop.hbase.quotas.QuotaCache$QuotaRefresherChore.updateQuotaFactors(QuotaCache.java:378)         at org.apache.hadoop.hbase.quotas.QuotaCache$QuotaRefresherChore.chore(QuotaCache.java:224)         at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:158)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)         at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)         at org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:107)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:750){code} h1. Root Cause The NPE is thrown at function: updateQuotaFactors() {code:java} private void updateQuotaFactors() {   // Update machine quota factor   ClusterMetrics clusterMetrics;   try {     clusterMetrics = rsServices.getConnection().getAdmin()       .getClusterMetrics(EnumSet.of(Option.SERVERS_NAME, Option.TABLE_TO_REGIONS_COUNT));   } catch (IOException e) {     LOG.warn(""Failed to get cluster metrics needed for updating quotas"", e);     return;   }  int rsSize = clusterMetrics.getServersName().size();   if (rsSize != 0) {     // TODO if use rs group, the cluster limit should be shared by the rs group     machineQuotaFactor = 1.0 / rsSize;   }  Map tableRegionStatesCount =     clusterMetrics.getTableRegionStatesCount();  // Update table machine quota factors   for (TableName tableName : tableQuotaCache.keySet()) {     double factor = 1;     try { // BUGGY LINE       long regionSize = tableRegionStatesCount.get(tableName).getOpenRegions();       if (regionSize == 0) {         factor = 0;       } else {         int localRegionSize = rsServices.getRegions(tableName).size();         factor = 1.0 * localRegionSize / regionSize;       }     } catch (IOException e) {       LOG.warn(""Get table regions failed: {}"", tableName, e);     }     tableMachineQuotaFactors.put(tableName, factor);   } } {code} At line 378: the *tableRegionStatesCount.get(tableName)* return null and thus it runs into NPE. The tableName leading to NPE is '{*}uuidd9efa97f93a442b686adae6d9f7bb2e9{*}', which is disabled and dropped by the user. {code:java} long regionSize = tableRegionStatesCount.get(tableName).getOpenRegions(); {code} The root cause is that when updating the quota factors, it iterates {*}tableQuotaCache.keySet(){*}, which might contain a table that has been dropped (Outdated cache).  h1. Fix Maybe we can add a check to make sure the table still exists in the system (Tmp solution). I have attached the full regionserver log and a simple fix. This bug should also happen in *2.5.5* since the related code in QuotaCache remains the same (But I only tested 2.4.17).  " [hbase-thirdparty] Add shaded netty tcnative module,13550365,Resolved,Major,Fixed,12/Sep/23 12:47,26/Sep/23 14:09,,"From HBASE-28008, we need to provide some default module that includes shaded netty-tcnative so that users can easily get deployed with it if they want to." Snapshot corruptions due to non-atomic rename within same filesystem,13548440,Resolved,Major,Fixed,23/Aug/23 21:35,28/Aug/23 02:42,,"Sequence of events that can lead to snapshot corruptions: # Create snapshot using admin command # Active master triggers async snapshot creation # If the snapshot operation doesn't complete within 5 min, client gets exception {code:java} org.apache.hadoop.hbase.snapshot.SnapshotCreationException: Snapshot 'T1_1691888405683_1691888440827_1' wasn't completed in expectedTime:600000 ms   {code} # Client initiates snapshot deletion after this error # In the snapshot completion/commit phase, the files are moved from tmp to final dir. # Snapshot delete and snapshot commit operations can cause corruption by leaving incomplete metadata: * [Snapshot commit] create ""/hbase/.hbase-snapshot/T1_1691888405683_1691888440827_1/.snapshotinfo"" * [Snapshot delete from client]  delete ""/hbase/.hbase-snapshot/T1_1691888405683_1691888440827_1/.snapshotinfo"" * [Snapshot commit]  create ""/hbase/.hbase-snapshot/T1_1691888405683_1691888440827_1/data-manifest""   The changes introduced by HBASE-21098 performs atomic rename for hbase 1 but not for hbase 2 {code:java} public static void completeSnapshot(Path snapshotDir, Path workingDir, FileSystem fs, FileSystem workingDirFs, final Configuration conf) throws SnapshotCreationException, IOException { LOG.debug( ""Sentinel is done, just moving the snapshot from "" + workingDir + "" to "" + snapshotDir); URI workingURI = workingDirFs.getUri(); URI rootURI = fs.getUri(); if ( (!workingURI.getScheme().equals(rootURI.getScheme()) || workingURI.getAuthority() == null || !workingURI.getAuthority().equals(rootURI.getAuthority()) || workingURI.getUserInfo() == null //always true for hdfs://{cluster} || !workingURI.getUserInfo().equals(rootURI.getUserInfo()) || !fs.rename(workingDir, snapshotDir)) //this condition isn't even evaluated due to short circuit above && !FileUtil.copy(workingDirFs, workingDir, fs, snapshotDir, true, true, conf) // non-atomic rename operation ) { throw new SnapshotCreationException(""Failed to copy working directory("" + workingDir + "") to completed directory("" + snapshotDir + "").""); } } {code} whereas for hbase 1 {code:java} // check UGI/userInfo if (workingURI.getUserInfo() == null && rootURI.getUserInfo() != null) { return true; } if (workingURI.getUserInfo() != null && !workingURI.getUserInfo().equals(rootURI.getUserInfo())) { return true; } {code} this causes shouldSkipRenameSnapshotDirectories() to return false if workingURI and rootURI share the same filesystem, which would always lead to atomic rename: {code:java} if ((shouldSkipRenameSnapshotDirectories(workingURI, rootURI) || !fs.rename(workingDir, snapshotDir)) && !FileUtil.copy(workingDirFs, workingDir, fs, snapshotDir, true, true, conf)) { throw new SnapshotCreationException(""Failed to copy working directory("" + workingDir + "") to completed directory("" + snapshotDir + "").""); } {code}  " Compaction queue should dedupe or consolidate queued requests,13551938,Open,Major,,25/Sep/23 19:04,,,"We had a compaction storm due to a huge bulkload. We ended up in a state where each regionserver had hundreds of compactions queued, despite only serving < 100 regions each. As writes continued, flushes happened, triggering minor compactions that got added to the queue as well. This results in a situation where we can never catch up on compactions because we keep compacting the same regions over and over. It would be good if the compaction queue could automatically consolidate or deduplicate requests. For example, if a region has 5 compactions queued, just run 1 major compaction and clear the other 5 from the queue." Upgrade BouncyCastle to fix CVE-2023-33201,13550938,Resolved,Major,Fixed,16/Sep/23 19:38,23/Sep/23 17:24,,"HBase has a dependency on BouncyCastle 1.70 which is vulnerable with [CVE-2023-33201|https://nvd.nist.gov/vuln/detail/CVE-2023-33201] Advisory: [https://github.com/bcgit/bc-java/wiki/CVE-2023-33201] This JIRA's goal is to fix the following: * Upgrade to v1.76, the latest version. ** This requires  bcprov-jdk15on to be replaced with bcprov-jdk18on ** See [https://www.bouncycastle.org/latest_releases.html] *** {quote}*Java Version Details* With the arrival of Java 15. jdk15 is not quite as unambiguous as it was. The *jdk18on* jars are compiled to work with *anything* from Java 1.8 up. They are also multi-release jars so do support some features that were introduced in Java 9, Java 11, and Java 15. If you have issues with multi-release jars see the jdk15to18 release jars below. *Packaging Change (users of 1.70 or earlier):* BC 1.71 changed the jdk15on jars to jdk18on so the base has now moved to Java 8. For earlier JVMs, or containers/applications that cannot cope with multi-release jars, you should now use the jdk15to18 jars. {quote} * Exclude bcprov-jdk15on from everywhere else to avoid conflicts with bcprov-jdk18on" Bump cryptography from 41.0.3 to 41.0.4 in /dev-support/git-jira-release-audit,13551666,Resolved,Major,Fixed,22/Sep/23 13:25,22/Sep/23 13:26,, ConnectionFactory.createConnection does not work with anything except ThreadPoolExecutor,13548111,Open,Major,,21/Aug/23 21:33,,,"This looks like a regression where [{{org.apache.hadoop.hbase.client.ConnectionFactory#createConnection(org.apache.hadoop.conf.Configuration, java.util.concurrent.ExecutorService)}}|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionFactory.java#L161] even though supports {{ExecutorService}} but has stopped working for {{ForkJoinPool}} and throws {{java.lang.ClassCastException: java.util.concurrent.ForkJoinPool cannot be cast to java.util.concurrent.ThreadPoolExecutor}}, possibly due to HBASE-22244 I have been able to write a UT to verify the same and ran it on a branch not having above-mentioned change (HBASE-22244) i.e. branch-2.1 where the test passes while for branch-2, having this change, the test fails with following: {code:java} [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.client.TestConnectionFactoryExecService [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 16.635 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestConnectionFactoryExecService [ERROR] org.apache.hadoop.hbase.client.TestConnectionFactoryExecService.testConnectionWithFJP Time elapsed: 0.268 s <<< ERROR! java.io.IOException: java.lang.reflect.UndeclaredThrowableException at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$1(ConnectionFactory.java:235) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:218) at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:160) at org.apache.hadoop.hbase.client.TestConnectionFactoryExecService.testConnectionWithFJP(TestConnectionFactoryExecService.java:83) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.reflect.UndeclaredThrowableException at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1956) at org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs(User.java:320) at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$1(ConnectionFactory.java:232) ... 29 more Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$null$0(ConnectionFactory.java:233) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1938) ... 31 more Caused by: java.lang.ClassCastException: java.util.concurrent.ForkJoinPool cannot be cast to java.util.concurrent.ThreadPoolExecutor at org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:294) at org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:281) ... 39 more [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestConnectionFactoryExecService.testConnectionWithFJP:83 » IO java.lang.reflect.UndeclaredThrowableException [INFO] [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0 {code} Also it worth noting that the issue does not exist in master, i think its because of HBASE-21723 which removes `ConnectionImplementation` from master.     " Rewrite hbck2 documentation using GPT,13547962,Open,Major,,19/Aug/23 19:53,,,"Just a thought, could we re-write the operator tools [README.md|https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md] using GPT and make it better? A sample paragraph re-written by ChatGPT is as follows: Original: {quote} h3. Some General Principals When making repair, make sure hbase:meta is consistent first before you go about fixing any other issue type such as a filesystem deviance. Deviance in the filesystem or problems with assign should be addressed after the hbase:meta has been put in order. If hbase:meta is out of whack, the Master cannot make proper placements when adopting orphan filesystem data or making region assignments. Other general principles to keep in mind include a Region can not be assigned if it is in _CLOSING_ state (or the inverse, unassigned if in _OPENING_ state) without first transitioning via {_}CLOSED{_}: Regions must always move from {_}CLOSED{_}, to {_}OPENING{_}, to {_}OPEN{_}, and then to {_}CLOSING{_}, {_}CLOSED{_}. When making repair, do fixup of a table-at-a-time. Also, if a table is {_}DISABLED{_}, you cannot assign a Region. In the Master logs, you will see that the Master will report that the assign has been skipped because the table is {_}DISABLED{_}. You may want to assign a Region because it is currently in the _OPENING_ state and you want it in the _CLOSED_ state so it agrees with the table's _DISABLED_ state. In this situation, you may have to temporarily set the table status to {_}ENABLED{_}, just so you can do the assign, and then set it back again after the unassign. _HBCK2_ has facility to allow you do this. See the _HBCK2_ usage output. What follows is a mix of notes and prescription that comes of experience running hbase-2.x so far. The root issues that brought on states described below has been fixed in later versions of hbase so upgrade if you can so as to avoid scenarios described. {quote} Re-written using ChatGPT: {quote}*Some Basic Principles* Ensure hbase:meta's consistency before attempting to fix any other type of problem, such as filesystem deviations. Issues related to filesystem or assignment should be addressed once hbase:meta is sorted out. If hbase:meta is awry, the Master cannot accurately allocate orphan filesystem data or region assignments. Remember that a Region cannot be assigned if it is in a CLOSING state (or conversely, unassigned if in an OPENING state) without going through a CLOSED state first. Regions must always progress from CLOSED, to OPENING, to OPEN, to CLOSING, and then back to CLOSED. Make repairs table-by-table. Additionally, if a table is DISABLED, you cannot assign a Region. The Master logs will indicate that the assignment has been bypassed due to the table's DISABLED status. You might want to assign a Region because it is currently in the OPENING state, but you want it in the CLOSED state to match the DISABLED state of the table. In such cases, you might need to briefly change the table status to ENABLED to make the assignment, then switch it back after the unassignment. HBCK2 provides a facility for this. Please refer to the HBCK2 usage output. The following notes and instructions come from the experience of running hbase-2.x so far. The underlying issues causing the states described below have been resolved in later versions of hbase, so upgrading is recommended to avoid these scenarios. {quote}   Is this worth the effort? Or do others feel current doc is good and does not need any refinement? It may require some effort, as we may only start with first commit with untouched document generated by ChatGPT, but then the draft would need to be worked upon, based on some proofreading by the contributor and reviewers. Curious to know how others feel. Also, Apache has some guidelines around using of generative ai tools at [https://www.apache.org/legal/generative-tooling.html]    " NPE in QuotaCache if Table is dropped from cluster,13543454,Resolved,Major,Duplicate,13/Jul/23 16:33,21/Sep/23 12:39,,"{code:java} java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.hbase.client.RegionStatesCount.getOpenRegions()"" because the return value of ""java.util.Map.get(Object)"" is null at org.apache.hadoop.hbase.quotas.QuotaCache$QuotaRefresherChore.updateQuotaFactors(QuotaCache.java:378) ~[hbase.jar] at org.apache.hadoop.hbase.quotas.QuotaCache$QuotaRefresherChore.chore(QuotaCache.java:224) ~[hbase.jar] at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:161) ~[hbase.jar] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?] at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) ~[?:?] at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) ~[?:?] at org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:107) ~[hbase.jar] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?] {code}   This is on 2.5.2, so the line numbers don't perfectly match with current branch-2. But the problem is [here|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaCache.java#L376]. We may have cached a TableName in tableQuotaCache, and the table may have since been dropped from the cluster. In which case, tableRegionStatesCount which comes from ClusterMetrics, will not have that table. We need to protect the lookup with a containsKey or null check, rather than directly call getOpenRegions() on the result. It probably makes sense to remove the tableName from the tableQuotaCache in this case. While here, I think catching IOException in that block no longer makes sense. We can probably remove after verifying." Add connection and request attributes to slow log,13543968,Resolved,Major,Fixed,18/Jul/23 14:41,19/Sep/23 20:01,,These can help users diagnose slow requests by pushing identifying information into the log. It might make sense to union them into a single field or put them in separate fields. Improving checking and failure handling for configuration-exercised code,13551469,Open,Major,,21/Sep/23 01:15,,2.5.5,"This Jira issue is an umbrella of multiple improvement/fixes on checking and error handling for configuration-exercised code in HBase. We have opened PRs with fixes to each of the issue under this umbrella. " HBase backup repair stuck after failed delete due to missing S3 credentials,13551442,Open,Major,,20/Sep/23 17:09,,,"I was experimenting what happens if a user were to execute `hbase backupe delete` without providing S3 credentials. I started with a backup present in a S3 bucket.   {noformat} hbase backup history {ID=backup_1695226626227,Type=FULL,Tables={foo:bar},State=COMPLETE,Start time=Wed Sep 20 16:17:09 UTC 2023,End time=Wed Sep 20 16:17:42 UTC 2023,Progress=100%} {noformat} I tried to delete this without providing S3 credentials, it failed (as expected).     {noformat} hbase backup delete -l backup_1695226626227 23/09/20 16:18:46 ERROR org.apache.hadoop.hbase.backup.impl.BackupAdminImpl: Delete operation failed, please run backup repair utility to restore backup system integrity java.nio.file.AccessDeniedException: s3a://backuprestore-experiments/hbase/backup_1695226626227: org.apache.hadoop.fs.s3a.auth.NoAuthWithAWSException: No AWS Credentials provided by TemporaryAWSCredentialsProvider SimpleAWSCredentialsProvider EnvironmentVariableCredentialsProvider IAMInstanceCredentialsProvider : com.amazonaws.SdkClientException: Unable to load AWS credentials from environment variables (AWS_ACCESS_KEY_ID (or AWS_ACCESS_KEY) and AWS_SECRET_KEY (or AWS_SECRET_ACCESS_KEY))     at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:215)     at org.apache.hadoop.fs.s3a.Invoker.onceInTheFuture(Invoker.java:190)     at org.apache.hadoop.fs.s3a.Listing$ObjectListingIterator.next(Listing.java:651)     at org.apache.hadoop.fs.s3a.Listing$FileStatusListingIterator.requestNextBatch(Listing.java:430)     at org.apache.hadoop.fs.s3a.Listing$FileStatusListingIterator.(Listing.java:372)     at org.apache.hadoop.fs.s3a.Listing.createFileStatusListingIterator(Listing.java:143)     at org.apache.hadoop.fs.s3a.Listing.getFileStatusesAssumingNonEmptyDir(Listing.java:264)     at org.apache.hadoop.fs.s3a.S3AFileSystem.innerListStatus(S3AFileSystem.java:3369)     at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$null$22(S3AFileSystem.java:3346)     at org.apache.hadoop.fs.s3a.Invoker.once(Invoker.java:122)     at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$listStatus$23(S3AFileSystem.java:3345)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.invokeTrackingDuration(IOStatisticsBinding.java:547)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.lambda$trackDurationOfOperation$5(IOStatisticsBinding.java:528)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.trackDuration(IOStatisticsBinding.java:449)     at org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2480)     at org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2499)     at org.apache.hadoop.fs.s3a.S3AFileSystem.listStatus(S3AFileSystem.java:3344)     at org.apache.hadoop.hbase.backup.util.BackupUtils.listStatus(BackupUtils.java:522)     at org.apache.hadoop.hbase.backup.util.BackupUtils.cleanupHLogDir(BackupUtils.java:430)     at org.apache.hadoop.hbase.backup.util.BackupUtils.cleanupBackupData(BackupUtils.java:411)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.deleteBackup(BackupAdminImpl.java:229)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.deleteBackups(BackupAdminImpl.java:142)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$DeleteCommand.executeDeleteListOfBackups(BackupCommands.java:627)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$DeleteCommand.execute(BackupCommands.java:578)     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134)     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169)     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) Caused by: org.apache.hadoop.fs.s3a.auth.NoAuthWithAWSException: No AWS Credentials provided by TemporaryAWSCredentialsProvider SimpleAWSCredentialsProvider EnvironmentVariableCredentialsProvider IAMInstanceCredentialsProvider : com.amazonaws.SdkClientException: Unable to load AWS credentials from environment variables (AWS_ACCESS_KEY_ID (or AWS_ACCESS_KEY) and AWS_SECRET_KEY (or AWS_SECRET_ACCESS_KEY))     at org.apache.hadoop.fs.s3a.AWSCredentialProviderList.getCredentials(AWSCredentialProviderList.java:216)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.getCredentialsFromContext(AmazonHttpClient.java:1269)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.runBeforeRequestHandlers(AmazonHttpClient.java:845)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:794)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:781)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:755)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:715)     at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:697)     at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:561)     at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:541)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5456)     at com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:6432)     at com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:6404)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5441)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5403)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5397)     at com.amazonaws.services.s3.AmazonS3Client.listObjectsV2(AmazonS3Client.java:971)     at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$listObjects$12(S3AFileSystem.java:2715)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.invokeTrackingDuration(IOStatisticsBinding.java:547)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.lambda$trackDurationOfOperation$5(IOStatisticsBinding.java:528)     at org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:468)     at org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:431)     at org.apache.hadoop.fs.s3a.S3AFileSystem.listObjects(S3AFileSystem.java:2706)     at org.apache.hadoop.fs.s3a.S3AFileSystem$ListingOperationCallbacksImpl.lambda$listObjectsAsync$0(S3AFileSystem.java:2342)     at org.apache.hadoop.fs.s3a.impl.CallableSupplier.get(CallableSupplier.java:87)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)     at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)     at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)     at java.base/java.lang.Thread.run(Thread.java:829) Caused by: com.amazonaws.SdkClientException: Unable to load AWS credentials from environment variables (AWS_ACCESS_KEY_ID (or AWS_ACCESS_KEY) and AWS_SECRET_KEY (or AWS_SECRET_ACCESS_KEY))     at com.amazonaws.auth.EnvironmentVariableCredentialsProvider.getCredentials(EnvironmentVariableCredentialsProvider.java:49)     at org.apache.hadoop.fs.s3a.AWSCredentialProviderList.getCredentials(AWSCredentialProviderList.java:177)     ... 28 more Delete command FAILED. Please run backup repair tool to restore backup system integrity 23/09/20 16:18:46 ERROR org.apache.hadoop.hbase.backup.BackupDriver: Error running command-line tool java.nio.file.AccessDeniedException: s3a://backuprestore-experiments/hbase/backup_1695226626227: org.apache.hadoop.fs.s3a.auth.NoAuthWithAWSException: No AWS Credentials provided by TemporaryAWSCredentialsProvider SimpleAWSCredentialsProvider EnvironmentVariableCredentialsProvider IAMInstanceCredentialsProvider : com.amazonaws.SdkClientException: Unable to load AWS credentials from environment variables (AWS_ACCESS_KEY_ID (or AWS_ACCESS_KEY) and AWS_SECRET_KEY (or AWS_SECRET_ACCESS_KEY))     at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:215)     at org.apache.hadoop.fs.s3a.Invoker.onceInTheFuture(Invoker.java:190)     at org.apache.hadoop.fs.s3a.Listing$ObjectListingIterator.next(Listing.java:651)     at org.apache.hadoop.fs.s3a.Listing$FileStatusListingIterator.requestNextBatch(Listing.java:430)     at org.apache.hadoop.fs.s3a.Listing$FileStatusListingIterator.(Listing.java:372)     at org.apache.hadoop.fs.s3a.Listing.createFileStatusListingIterator(Listing.java:143)     at org.apache.hadoop.fs.s3a.Listing.getFileStatusesAssumingNonEmptyDir(Listing.java:264)     at org.apache.hadoop.fs.s3a.S3AFileSystem.innerListStatus(S3AFileSystem.java:3369)     at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$null$22(S3AFileSystem.java:3346)     at org.apache.hadoop.fs.s3a.Invoker.once(Invoker.java:122)     at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$listStatus$23(S3AFileSystem.java:3345)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.invokeTrackingDuration(IOStatisticsBinding.java:547)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.lambda$trackDurationOfOperation$5(IOStatisticsBinding.java:528)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.trackDuration(IOStatisticsBinding.java:449)     at org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2480)     at org.apache.hadoop.fs.s3a.S3AFileSystem.trackDurationAndSpan(S3AFileSystem.java:2499)     at org.apache.hadoop.fs.s3a.S3AFileSystem.listStatus(S3AFileSystem.java:3344)     at org.apache.hadoop.hbase.backup.util.BackupUtils.listStatus(BackupUtils.java:522)     at org.apache.hadoop.hbase.backup.util.BackupUtils.cleanupHLogDir(BackupUtils.java:430)     at org.apache.hadoop.hbase.backup.util.BackupUtils.cleanupBackupData(BackupUtils.java:411)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.deleteBackup(BackupAdminImpl.java:229)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.deleteBackups(BackupAdminImpl.java:142)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$DeleteCommand.executeDeleteListOfBackups(BackupCommands.java:627)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$DeleteCommand.execute(BackupCommands.java:578)     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134)     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169)     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) Caused by: org.apache.hadoop.fs.s3a.auth.NoAuthWithAWSException: No AWS Credentials provided by TemporaryAWSCredentialsProvider SimpleAWSCredentialsProvider EnvironmentVariableCredentialsProvider IAMInstanceCredentialsProvider : com.amazonaws.SdkClientException: Unable to load AWS credentials from environment variables (AWS_ACCESS_KEY_ID (or AWS_ACCESS_KEY) and AWS_SECRET_KEY (or AWS_SECRET_ACCESS_KEY))     at org.apache.hadoop.fs.s3a.AWSCredentialProviderList.getCredentials(AWSCredentialProviderList.java:216)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.getCredentialsFromContext(AmazonHttpClient.java:1269)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.runBeforeRequestHandlers(AmazonHttpClient.java:845)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:794)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:781)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:755)     at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:715)     at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:697)     at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:561)     at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:541)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5456)     at com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:6432)     at com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:6404)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5441)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5403)     at com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:5397)     at com.amazonaws.services.s3.AmazonS3Client.listObjectsV2(AmazonS3Client.java:971)     at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$listObjects$12(S3AFileSystem.java:2715)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.invokeTrackingDuration(IOStatisticsBinding.java:547)     at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.lambda$trackDurationOfOperation$5(IOStatisticsBinding.java:528)     at org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:468)     at org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:431)     at org.apache.hadoop.fs.s3a.S3AFileSystem.listObjects(S3AFileSystem.java:2706)     at org.apache.hadoop.fs.s3a.S3AFileSystem$ListingOperationCallbacksImpl.lambda$listObjectsAsync$0(S3AFileSystem.java:2342)     at org.apache.hadoop.fs.s3a.impl.CallableSupplier.get(CallableSupplier.java:87)     at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)     at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)     at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)     at java.base/java.lang.Thread.run(Thread.java:829) Caused by: com.amazonaws.SdkClientException: Unable to load AWS credentials from environment variables (AWS_ACCESS_KEY_ID (or AWS_ACCESS_KEY) and AWS_SECRET_KEY (or AWS_SECRET_ACCESS_KEY))     at com.amazonaws.auth.EnvironmentVariableCredentialsProvider.getCredentials(EnvironmentVariableCredentialsProvider.java:49)     at org.apache.hadoop.fs.s3a.AWSCredentialProviderList.getCredentials(AWSCredentialProviderList.java:177)     ... 28 more {noformat} At this point, I cannot start a new backup because a failed delete command is present:     {noformat} hbase backup \   -libjars /opt/hadoop/share/hadoop/tools/lib/hadoop-aws-3.3.6-1-lily.jar,/opt/hadoop/share/hadoop/tools/lib/aws-java-sdk-bundle-1.12.367.jar \ -Dfs.s3a.access.key=... \   -Dfs.s3a.secret.key=... \   -Dfs.s3a.session.token=... \    create incremental s3a://backuprestore-experiments/hbase -t foo:bar  Found failed backup DELETE coommand.  Backup system recovery is required. 23/09/20 16:31:16 ERROR org.apache.hadoop.hbase.backup.BackupDriver: Error running command-line tool java.io.IOException: Failed backup DELETE found, aborted command execution     at org.apache.hadoop.hbase.backup.impl.BackupCommands$Command.execute(BackupCommands.java:167)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$CreateCommand.execute(BackupCommands.java:309)     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134)     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169)     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) {noformat} However, backup is unable to complete.     {noformat} hbase backup repair REPAIR status: no failed sessions found. Checking failed delete backup operation ... Found failed DELETE operation for: backup_1695226626227 Running DELETE again ... 23/09/20 16:34:13 WARN org.apache.hadoop.hbase.backup.impl.BackupSystemTable: Could not restore backup system table. Snapshot snapshot_backup_system does not exists. 23/09/20 16:34:13 ERROR org.apache.hadoop.hbase.backup.BackupDriver: Error running command-line tool java.io.IOException: There is no active backup exclusive operation     at org.apache.hadoop.hbase.backup.impl.BackupSystemTable.finishBackupExclusiveOperation(BackupSystemTable.java:645)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$RepairCommand.repairFailedBackupDeletionIfAny(BackupCommands.java:721)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$RepairCommand.execute(BackupCommands.java:681)     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134)     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169)     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) {noformat} The core issue seems to be the assumption that there is a ""backup exclusive operation"" for each failed delete command. A good feature would also be to allow the repair command to delete the pending delete. Though I guess that in some cases that may not result in a reliable state if data was already partially deleted. The workaround in this case would be to delete the delete commands from the backup table I guess?  " "protobuf-java core and lite versions prior to 3.21.7, 3.20.3, 3.19.6 and 3.16.3 is vulnerable to CVE-2022-3509",13551318,Open,Major,,20/Sep/23 04:57,,2.4.13,"protobuf-java 3.23.2  causing increasing disk usage. Because of this we are not in position to upgrade protobuf to latest version. we are currently using hbase 2.4.13 which uses protobuf version older than 3.23.2 which is vulnerable to cve. is there any latest hbase and hadoop version available which is using protobuf version 3.23.2? " The size that is checked against the maxfilesize threshold is the uncompressed size of the HFile,13551324,Open,Major,,20/Sep/23 05:32,,,"HBase server is configured to use Snappy compression.when doing bulkload in HBase, the size that is checked against the maxfilesize threshold is the uncompressed size of the HFile, not the compressed size. HFileOutputFormat2.class   {code:java} //代码占位符 new RecordWriter() { .... @Override public void write(ImmutableBytesWritable row, V cell) throws IOException { ... } } {code} !image-2023-09-20-12-09-49-959.png!  " Make entryReader field final in ReplicationSourceShipper class,13551010,Resolved,Major,Fixed,18/Sep/23 06:57,19/Sep/23 00:11,,"In HBASE-28076 we noticed that while shutting down. the entryReader field could be null and cause NPE. The code is a bit different on master and branch-3, and after reviewing, I think" Clarify scanner timeout docs in book,13551274,Open,Major,,19/Sep/23 18:37,,,"There is a bit more nuance to scanner timeouts than is covered in [https://hbase.apache.org/book.html#config_timeouts]. As of HBASE-28085, one can enable a config to have similar semantics between AsyncTable and Table, and prepare for 3.0 release. We should improve these docs a bit." [hbase-thirdparty] Also relocate the proto files in protobuf-java,13551194,Resolved,Major,Fixed,19/Sep/23 07:53,19/Sep/23 13:32,, [hbase-thirdparty] Bump maven plugin versions,13551171,Resolved,Major,Fixed,19/Sep/23 03:03,19/Sep/23 06:32,, HMaster snapshot file clean thread and the snapshot request handler thread encountered a deadlock,13549304,Resolved,Major,Fixed,31/Aug/23 15:17,19/Sep/23 06:31,3.0.0-beta-1,"HMaster encountered a deadlock when runing ITBLL test. The handler thread of HMaster holds the synchronized lock of SnapshotManager and competes for the readLock of takingSnapshotLock. {code:java} Thread 57 (RpcServer.default.FPBQ.Fifo.handler=22,queue=1,port=16000):   State: WAITING   Blocked count: 14   Waited count: 206   Waiting on java.util.concurrent.locks.ReentrantReadWriteLock$FairSync@a7a58d4   Stack:     sun.misc.Unsafe.park(Native Method)     java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)     java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)     java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:967)     java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1283)     java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:727)     org.apache.hadoop.hbase.master.snapshot.SnapshotManager.takeSnapshot(SnapshotManager.java:675)     org.apache.hadoop.hbase.master.MasterRpcServices.snapshot(MasterRpcServices.java:1765)     org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)     org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:437)     org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)     org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)     org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) {code} The Master Snapshot cleaning thread holds the writeLock of takingSnapshotLock to compete for the synchronized lock of SnapshotManager. {code:java} Thread 5405 (hfile_cleaner-dir-scan-pool-2): State: BLOCKED Blocked count: 50535 Waited count: 92200 Blocked on org.apache.hadoop.hbase.master.snapshot.SnapshotManager@21a16019 Blocked by 57 (RpcServer.default.FPBQ.Fifo.handler=22,queue=1,port=16000) Stack: org.apache.hadoop.hbase.master.snapshot.SnapshotManager.isTakingAnySnapshot(SnapshotManager.java:655) org.apache.hadoop.hbase.master.snapshot.SnapshotFileCache.getUnreferencedFiles(SnapshotFileCache.java:197) org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner.getDeletableFiles(SnapshotHFileCleaner.java:78) org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteFiles(CleanerChore.java:375) org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$traverseAndDelete$1(CleanerChore.java:483) org.apache.hadoop.hbase.master.cleaner.CleanerChore$$Lambda$788/1121007598.act(Unknown Source) org.apache.hadoop.hbase.master.cleaner.CleanerChore.deleteAction(CleanerChore.java:565) org.apache.hadoop.hbase.master.cleaner.CleanerChore.traverseAndDelete(CleanerChore.java:483) org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$traverseAndDelete$2(CleanerChore.java:495) org.apache.hadoop.hbase.master.cleaner.CleanerChore$$Lambda$794/1250580839.run(Unknown Source) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:750){{}} {code}" Add hadoop 3.3.6 in hadoopcheck,13550826,Resolved,Major,Fixed,15/Sep/23 10:38,17/Sep/23 09:15,,"Just noticed that we still list 3.3.5 as the newest hadoop version in pre commit check. Let's add 3.3.6." Too long namespace/table/column name cause CreateTableProcedure stuck,13551107,Open,Major,,18/Sep/23 16:06,,2.4.13,"Too long namespace/table/column name cause CreateTableProcedure stuck Due to the limitations of DFSConfigKeys.DFS_NAMENODE_MAX_COMPONENT_LENGTH_KEY, we cannot create directory if the the length of compoent exceeds this value. 1. Too long table name cause CreateTableProcedure is Running always and it would not end 2. We can create namespace if namespace is too long, however we will encounter the same problem as situation 1 if we create table with this namespace 3. we will also encounter the same problem as situation 1 if we create table with long column family name. Although HBase requires that the length of column family cannot exceed the Byte.MAX_VALUE, We may still fail if we set the value of DFSConfigKeys.DFS_NAMENODE_MAX_COMPONENT_LENGTH_KEY to be less than Byte.MAX_VALUE" hbck2 should support change region state of meta,13546797,Resolved,Major,Won't Fix,10/Aug/23 09:08,18/Sep/23 12:14,hbase-operator-tools-1.2.0,"The region state of meta is stored in zk, if the state is wrong, we need a way to change it." HBaseTestingUtility failed to start MiniHbaseCluster in case of Hadoop3.3.1,13549488,Resolved,Major,Fixed,03/Sep/23 12:35,15/Sep/23 11:10,,"Note: My test env is *Hadoop3.3.1* & Hbase2.5.5-hadoop3. And if I switch to *Hadoop3.1.4* or \{*}Hadoop3.2.4{*}, the test will be ok. I attached the source code and pom file.   I just want to use *HBaseTestingUtility::startMiniHBaseCluster* to launch a mini hbase cluster in case of Hadoop.3.3.1, but failed with the following exception: {code:java} master.HMaster (MarkerIgnoringBase.java:error(159)) - Failed to become active master org.apache.hadoop.hbase.FailedCloseWALAfterInitializedErrorException: Failed close after init wal failed.     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:167)     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:62)     at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:300)     at org.apache.hadoop.hbase.master.region.MasterRegion.createWAL(MasterRegion.java:217)     at org.apache.hadoop.hbase.master.region.MasterRegion.bootstrap(MasterRegion.java:240)     at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:398)     at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:132)     at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:942)     at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2405)     at org.apache.hadoop.hbase.master.HMaster.lambda$null$0(HMaster.java:565)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177)     at org.apache.hadoop.hbase.master.HMaster.lambda$run$1(HMaster.java:562)     at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException: java.lang.NullPointerException     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.shutdown(AbstractFSWAL.java:1012)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.close(AbstractFSWAL.java:1039)     at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:165)     ... 13 more Caused by: java.lang.NullPointerException     at java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011)     at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.closeWriter(AsyncFSWAL.java:718)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doShutdown(AsyncFSWAL.java:775)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:984)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$2.call(AbstractFSWAL.java:979)     at java.util.concurrent.FutureTask.run(FutureTask.java:266)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     ... 1 more {code} Does that mean Hbase2.5.5-hadoop3 not be compatible with Hadoop3.3.1? Or only the integration testing is not work well with Hadoop3.3.1?" [HBoss] add support for AWS v2 SDK,13549276,In Progress,Major,,31/Aug/23 11:37,,,"HBoss doesn't compile against a version of hadoop built with the AWS v2 SDK, which HADOOP-18703 will do on hadoop trunk within a few days. I think the solution here is probably some profile to build against different sdk/hadoop versions" Debian hbase package,13550745,Open,Major,,14/Sep/23 19:37,,,"Hi team, There doesn't seem to be an hbase package in debian any longer. Our instructions on how to use bigtable on our product depend on hbase. I am build-from-source logic into the installer, but would prefer to install a package with apt-get instead. Can assist with generating debian/rules C.J." Unhandled TableExistsException and NamespaceExistException in BackupSystemTable,13550407,Resolved,Major,Fixed,12/Sep/23 19:36,13/Sep/23 15:44,,"Most backup-related operations instantiate a BackupSystemTable object. The first thing it does is check that the {{backup}} namespace and backup-related tables exist, and create them if not. One way in which this can be triggered is via LoadIncrementalHFiles, which can load files with a configurable number of threads. When bulkLoadHFile is called, a preCommitHFile hook is triggered which does the above. With a certain level of concurrency, one can easily trigger a race condition on creating the namespace or tables. This exception bubbles up and fails the bulkload. We should catch TableExistsException and NamespaceExistException in BackupSystemTable initialization so that these do not cause client pain." Add support for tcnative,13546183,Resolved,Major,Fixed,04/Aug/23 18:41,12/Sep/23 12:49,,"In investigating HBASE-27947, tcnative can make a big impact on throughput over built-in jdk SSL support. We need three things to make it work: # In X509Util, if Openssl.isAvailable() (meaning tcnative is on the classpath): ## Use SslProvider.OPENSSL_REFCNT ## Update default ciphers to remove CBC ciphers, which do not work with tcnative. We can either pull the ciphers from OpenSsl.availableJavaCipherSuites() or simply use the default GCM ciphers we already have defined. # Our netty is shaded, so one can't simply put the tcnative jar on the classpath. We might need to provide an hbase-shaded-netty-tcnative module which one can optionally include in their deployment. We will have to decide which of the many tcnative modules to provide a shaded version for." Bump gitpython from 3.1.34 to 3.1.35 in /dev-support/flaky-tests,13550332,Resolved,Major,Fixed,12/Sep/23 08:42,12/Sep/23 08:52,, Bump gitpython from 3.1.32 to 3.1.34 in /dev-support/flaky-tests,13550326,Resolved,Major,Fixed,12/Sep/23 08:20,12/Sep/23 08:42,, Bump gitpython from 3.1.32 to 3.1.35 in /dev-support/git-jira-release-audit,13550327,Resolved,Major,Fixed,12/Sep/23 08:21,12/Sep/23 08:45,, Limit the maximum allocation when reading an HFileBlock,13550379,Open,Major,,12/Sep/23 14:45,,,"During PR discussion on HBASE-28065 we observe that the value of {{onDiskSizeWithoutHeader}} is read and used before its portion of an HFile has had its checksum validated. A method parameter is also provided which is used when the caller knows what size to expect based on some other source. While there are guards in place that limit the range of values this field can take, that range remains large, something like {{[33,Integer.MAX_VALUE)}}. We propose further limiting the range of this value to safeguard the region server from an excessively large allocation. Conversation is in https://github.com/apache/hbase/pull/5384/files#r1322947549" [hbase-connectors] CVE-2020-15250 in org.glassfish:javax.el:jar:3.0.1-b08,13550302,Open,Major,,12/Sep/23 03:07,,,"This is a direct dependency in https://github.com/apache/hbase-connectors/blob/master/pom.xml *Version Affected* [3.0-b01,3.0.1-b12] *Issue* org.glassfish:javax.el:jar:3.0.1-b08:compile cause vulnerability as mentioned in https://mvnrepository.com/artifact/org.glassfish/javax.el/3.0.1-b08" Add support for quotas on atomic operations,13550274,Open,Major,,11/Sep/23 21:13,,,"Atomic operations (CheckAndMutate, Increment, etc) are especially costly since they include both a random read and a write, and that occurs within a lock which can cause contention with other atomic reads. We find that HBase can only a serve a fraction of the atomic operations that it can of normal reads or writes. We should provide a separate quota for this so that one can tune it low while still allowing much higher normal read and write volume." Hbase 2.4.13 vulnerable to CVE-2022-26612,13549932,Open,Major,,07/Sep/23 13:26,,2.4.13,"hbase 2.4.13 uses hadoop-common-2.10.0.jar which is vulnerable to CVE-2022-26612. when replaced hadoop-common-2.10.0.jar with 3.2.3, getting version incompatible issue and as result hbase shell command failed. is there any hbase version which is compatible with hadoop-common 3.2.3 or above? or is there any hbase version available where the above CVE addressed?  " [hbase-operator-tools] Add spotless for hbase-operator-tools,13543664,Resolved,Major,Fixed,15/Jul/23 21:05,05/Sep/23 14:08,,"HBase code repo has spotless plugin to check and fix spotless issues seamlessly, making it easier for developers to fix issue in case the builds fails due to code formatting. The goal of this Jira is to integrate spotless with hbase-operator-tools. * As a 1st step will try to add a plugin to run spotless check via maven * Next will fix all spotless issues as part of same task or another (as community suggests) * Finally will integrate the same to pre-commit build to not let PRs wit spotless issues get in. (Would need some support/direction on how to do this as I am not much familiar with the Jenkins and related code.)" [HBCK2] Running assigns/unassigns command with large number of files/regions throws CallTimeoutException,13542441,Resolved,Major,Fixed,04/Jul/23 16:50,06/Sep/23 17:23,,"While trying to run assigns command with a huge list of region, it fails with CTE. Even on trying to run it by breaking input into multiple files, it still fails and have to blindly submit same command again and again until no error. Exception seen as described above is as follows:  {code:java} Exception in thread ""main"" java.io.IOException: org.apache.hbase.thirdparty.com.google.protobuf.ServiceException: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to address=SOME_HOST_NAME:SOME_PORT_NUMBER failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=0,methodName=Assigns], waitTime=90142ms, rpcTimeout=90000ms at org.apache.hadoop.hbase.client.HBaseHbck.assigns(HBaseHbck.java:146) at org.apache.hbase.HBCK2.assigns(HBCK2.java:454) at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:1070) at org.apache.hbase.HBCK2.run(HBCK2.java:1028) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at org.apache.hbase.HBCK2.main(HBCK2.java:1367) Caused by: org.apache.hbase.thirdparty.com.google.protobuf.ServiceException: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to address=SOME_HOST_NAME:SOME_PORT_NUMBER failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=0,methodName=Assigns], waitTime=90142ms, rpcTimeout=90000ms at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:340) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$200(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:594) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$HbckService$BlockingStub.assigns(MasterProtos.java) at org.apache.hadoop.hbase.client.HBaseHbck.assigns(HBaseHbck.java:141) ... 6 more Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to address=SOME_HOST_NAME:SOME_PORT_NUMBER failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=0,methodName=Assigns], waitTime=90142ms, rpcTimeout=90000ms at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:222) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:390) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:424) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:419) at org.apache.hadoop.hbase.ipc.Call.setTimeout(Call.java:107) at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:134) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.run(HashedWheelTimer.java:715) at org.apache.hbase.thirdparty.io.netty.util.concurrent.ImmediateExecutor.execute(ImmediateExecutor.java:34) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:703) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:790) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:503) at java.lang.Thread.run(Thread.java:750) Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=0,methodName=Assigns], waitTime=90142ms, rpcTimeout=90000ms at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:135) ... 6 more {code} The same issue should be valid for most of the command like unassigns, bypass etc. *Proposed fixed* * This can be fixed by introducing batching of the list of region passed via commandline or specified via -i arg " Use correct units in RegionLoad#getStoreUncompressedSizeMB(),13549342,Resolved,Major,Fixed,31/Aug/23 23:35,05/Sep/23 10:09,2.5.5,"When I run a snippet of code like this: {code:java} Map regionLoadMap = admin .getClusterStatus() .getLoad( ServerName.parseServerName( ""my-server.my-company.net,60020,1693513660506"" ) ) .getRegionsLoad(); for (byte[] startKey : regionLoadMap.keySet()) { RegionLoad regionLoad = regionLoadMap.get(startKey); LOG.info(""Region {}: {}"", Bytes.toStringBinary(startKey), regionLoad); } {code} I get logs like this: {noformat} Region ,,1659484033280.2b89407a1223720344bed425bf3c29b0.: numberOfStores=1, numberOfStorefiles=3, storeRefCount=0, storefileUncompressedSizeMB=17998848, lastMajorCompactionTimestamp=1693211464712, storefileSizeMB=5895, compressionRatio=0.0003, memstoreSizeMB=1, readRequestsCount=118899553, writeRequestsCount=731192, rootIndexSizeKB=9, totalStaticIndexSizeKB=10413, totalStaticBloomSizeKB=6592, totalCompactingKVs=0, currentCompactedKVs=0, compactionProgressPct=NaN, completeSequenceId=78093096, dataLocality=1.0{noformat} The {{storefileUncompressedSizeMB}} is vastly larger than the {{{}storefileSizeMB{}}}, so much more that it's not believable. I checked the store files in question in this instance. Adding up the uncompressed size reported in the HFile trailers sums to 5895 MiB, exactly 1024 times less than the reported 17998848. The reason for the misreporting is that {{RegionLoad#getStoreUncompressedSizeMB()}} converts the value from a {{Size}} object wrong.  " [hbase-operator-tools] Add spotless in hbase-operator-tools pre-commit check,13543666,Resolved,Major,Fixed,15/Jul/23 21:08,05/Sep/23 13:29,, An exception was thrown by org.apache.hadoop.hbase.io.asyncfs.FanOutBlockAsyncDFSOutputHelper$4.operationComplete(),13549577,Open,Major,,04/Sep/23 14:43,,2.4.17,"When I try running hbase using the code *./start-hbase.sh* , the terminal doesn't show an error or failure but logs do show it. Here I am dropping the link to the entire log file [log file|[http://justpaste.it/aqyjh|https://justpaste.it/aqyjh]] . I have tried some forums and reading documentation but nothing helped. Hadoop is compatible with Hbase version asHbase created a folder in Hadoop named */hbase* in the root directory of Hadoop and the directory does contain couple of directories (.hbck, .tmp, MasterData, WALs, archive, etc) and 2 files (hbase.id, hbase.version). So I don't think compatibility between Hadoop and Hbase is the issue here. Everything is running locally, literally everything as I am just testing some stuff. Also when I try doing *bin/hbase shell* , then the shell starts but anything I do in the shell for example if I type {*}status{*}, in the shell, I get the error which is same if I type any other code as ""Error: KeeperErrorCode = ConnectionLoss for /hbase/master"". I have uploaded two files of hbase which are the only two files I have altered to from the pre-built version of Apache. If you need any more information, please let me know." [hbase-operator-tools] Run spotless:apply and fix any existing spotless issues,13549289,Resolved,Major,Fixed,31/Aug/23 13:38,31/Aug/23 16:02,, [hbase-connectors] Add spotless in hbase-connectors pre commit check,13549185,Resolved,Major,Fixed,30/Aug/23 17:09,31/Aug/23 11:51,, ServerCrashProcedure seems to fail when using Hadoop3.3.1+,13549176,Open,Major,,30/Aug/23 15:33,,,"HBase Cluster Issue with Server Crash Procedure After Region Server Goes Down We are running an HBase cluster with version 2.5.5 (HBase jar sourced from the [HBase download page|https://hbase.apache.org/downloads.html] under hadoop3-bin) paired with Hadoop version 3.3.2. When a region server went down and initiated a serverCrashProcedure, we encountered an exception. This exception prevented our cluster from recovering. Below is a snippet of the exception: {code:java} 2023-08-28 21:02:52,163 INFO [RS_LOG_REPLAY_OPS-regionserver/HOSTNAME_HERE:16020-1] wal.WALSplitter (WALSplitter.java:splitWAL(300)) - Splitting hdfs://hbase:8020/hbase/WALs/HOSTNAME_HERE,16020,1693214237545-splitting/HOSTNAME_HERE%2C16020%2C1693214237545.1693214243056, size=15.7 K (16082bytes) 2023-08-28 21:02:52,163 INFO [RS_LOG_REPLAY_OPS-regionserver/HOSTNAME_HERE:16020-1] util.RecoverLeaseFSUtils (RecoverLeaseFSUtils.java:recoverDFSFileLease(86)) - Recover lease on dfs file hdfs://hbase:8020/hbase/WALs/HOSTNAME_HERE,16020,1693214237545-splitting/HOSTNAME_HERE%2C16020%2C1693214237545.1693214243056 2023-08-28 21:02:52,164 INFO [RS_LOG_REPLAY_OPS-regionserver/HOSTNAME_HERE:16020-1] util.RecoverLeaseFSUtils (RecoverLeaseFSUtils.java:recoverLease(175)) - Recovered lease, attempt=0 on file=hdfs://hbase:8020/hbase/WALs/HOSTNAME_HERE,16020,1693214237545-splitting/HOSTNAME_HERE%2C16020%2C1693214237545.1693214243056 after 0ms 2023-08-28 21:02:52,167 INFO [RS_LOG_REPLAY_OPS-regionserver/HOSTNAME_HERE:16020-1] wal.WALSplitter (WALSplitter.java:splitWAL(423)) - Processed 0 edits across 0 Regions in 4 ms; skipped=0; WAL=hdfs://hbase:8020/hbase/WALs/HOSTNAME_HERE,16020,1693214237545-splitting/HOSTNAME_HERE%2C16020%2C1693214237545.1693214243056, size=15.7 K, length=16082, corrupted=false, cancelled=false 2023-08-28 21:02:52,167 ERROR [RS_LOG_REPLAY_OPS-regionserver/HOSTNAME_HERE:16020-1] handler.RSProcedureHandler (RSProcedureHandler.java:process(53)) - pid=5848252 java.lang.NoSuchMethodError: 'org.apache.hadoop.hdfs.protocol.DatanodeInfo[] org.apache.hadoop.hdfs.protocol.LocatedBlock.getLocations()' at org.apache.hadoop.hbase.fs.HFileSystem$ReorderWALBlocks.reorderBlocks(HFileSystem.java:428) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:367){code} Upon investigation, this seems to be a consequence of the changes introduced in Hadoop 3.3.1 under HDFS-15255. The getLocations method of LocatedBlock has been modified from returning a DatanodeInfo[] to a DatanodeStorageInfo[]. However, HBase 2.5.5 still references DatanodeInfo[] in HFileSystem.java:428, leading to the aforementioned exception. You can view the relevant HBase code [here of hbase code|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java#L428]. A potential solution we identified is to rebuild HBase using a patch available at this repository. This appears to rectify the issue.(at least for now). [https://github.com/aplio/hbase/tree/monkeypatch/fix-serverClashProcedure-caused-by-hbase-3-dataNodeInfo-change]   This issue helped us investigate and fix. https://issues.apache.org/jira/browse/HBASE-26198   I'd like to submit a PR to the HBase documentation stating that Hadoop 3.3.1 and later versions are not compatible with HBase (specifically version 2.5.5), provided that this bug is confirmed (or if my observations are accurate)." Region (un)assignment should have a more direct timeout,13543604,Open,Major,,14/Jul/23 19:37,,,"h3. Problem We've observed a few cases in which region (un)assignment can hang for significant, and sometimes seemingly indefinite, periods of time. This results in unpredictably long downtime which must be remediated via manually initiated ServerCrashProcedures. h3. Example 1 If a RS is unable to communicate with the NameNode and it is asked to close a region then its RS_CLOSE_REGION thread will get stuck awaiting a NN failover. Due to several default configurations of options like: * hbase.hstore.flush.retries.number * hbase.server.pause * dfs.client.failover.max.attempts * dfs.client.failover.sleep.base.millis * dfs.client.failover.max.attempts this region unassignment attempt will hang for approximately 30 minutes before it allows the failure to bubble up and automatically trigger a ServerCrashProcedure. One can tune the aforementioned options to reduce the TTR here, but it's not a very obvious/direct solution. h3. Example 2 In rare cases our public cloud provider may supply us with machines that have degraded hardware. If we're unable to catch this degradation prior to startup, then we've observed that the degraded RegionServer process may come online; as a result it will be assigned regions which can often never actually be successfully opened. If the RegionServer's assignment handling fails to intentionally fail, then there will never be outside intervention; the assignment will be stuck hanging indefinitely. I've written [a unit test|https://github.com/apache/hbase/compare/master...HubSpot:hbase:rsit-opening-repro] which reproduces this behavior. On this same branch is a unit test demonstrating that a timeout placed on the AssignRegionHandler helps to fast fail and reliably trigger the necessary ServerCrashProcedure. h3. Proposal I want to propose that we add optional and configurable timeouts to the AssignRegion and UnassignRegion event handlers. This would allow us to much more intentionally & clearly prevent long running retries for these downtime inducing procedures and could consequently improve our reliability in both examples." Sort on store file size on hmaster page is broken.,13548546,Resolved,Major,Invalid,24/Aug/23 18:10,25/Aug/23 15:27,2.5.2,"An image is worth 1000 words. !Screenshot 2023-08-24 at 11.08.54 AM.png!" Rebase HBASE-27389 branch with master and fix conflicts,13548364,Resolved,Major,Fixed,23/Aug/23 09:55,23/Aug/23 12:56,, hbck2 bypass should provide an option to bypass existing top N procedures,13548295,Open,Major,,22/Aug/23 22:46,,,"For the degraded cluster state where several SCPs and underlying TRSPs are stuck due to network issues, it becomes difficult to resolve RITs and recover regions from SCPs. In order to bypass stuck procedures, we need to extract and then provide list of proc ids from list_procedures or procedures.jsp page. If we could provide an option to bypass initial N procedures that are listed on the procedures.jsp page, that would be really helpful. Implementation steps: # Similar to BypassProcedureRequest, provide BypassTopNProcedureRequest with only attribute value as N # MasterRpcServices to provide new API:  # {code:java} bypassProcedure(RpcController controller, MasterProtos.BypassTopNProcedureRequest request) {code} # Hbck to provide utility to consume this master rpc # HBCK2 to use new hbck utility for bypassing top N requests   For this new option, top N procedures matter, hence they should follow the sorting order similar to the one followed by procedures.jsp." Create metric for region in transition count per table.,13548293,Open,Major,,22/Aug/23 22:06,,,Currently we have ritCount and ritCountOverThreshold metric for the whole cluster. It would be nice to have the ritCount and ritCountOverThreshold metric per table. It helps in debugging failed queries for a given table due to RIT. Enhance ByteBufferUtils.findCommonPrefix to compare 8 bytes each time,13547312,Resolved,Major,Fixed,14/Aug/23 22:01,21/Aug/23 08:26,2.5.4,"Currently, the `ByteBufferUtils.findCommonPrefix family of methods compare two buffers a single byte at a time. In reviewing the patch for HBASE-28012, [~zhangduo] suggested that the ByteBufferUtils.findCommonPrefix methods could be enhanced to compare 8 bytes at a time like the ByteBufferUtils.compareToUnsafe family of methods already does (which was added in HBASE-12345)" Sync the hbck2 README page and hbck2 command help output,13543905,Resolved,Major,Fixed,18/Jul/23 08:30,20/Aug/23 18:31,,"There are major differences in the hbck2 [README.md|https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md] and the command help output, hence we should sync them across for all commands. Ideally, it should be same as the output of hbck2 help command for ease of maintenance.  Also few new commands like {{recoverUnknown}} and {{regionInfoMismatch}} are missing, making users unaware of existence of those." Avoid CellUtil.cloneRow in BufferedEncodedSeeker,13546612,Resolved,Major,Fixed,09/Aug/23 02:06,15/Aug/23 15:26,2.5.4,"A RegionServer running a workload that consisted of mostly reverse (and some forward) scans of thousands of tall (36 byte rows) under moderate read pressure (based on block bytes scanned) saw near 100% CPU usage. We noticed that the high CPU usage tended to correlate with more reverse scan quantity and the throughput of the server running more reverse scans was vastly lower than expectation.    A flame graph of the Region Server at 100% CPU usage. Analysis of the flamegraph reveals that each seek for a reverse scan (which has more seeks than the forward seek path) has 2 CellUtil.cloneRow rowkey copies per seek. These CellUtil#cloneRow calls can be removed from this code path for off-heap cells in a similar fashion to HBASE-27146" Make TestClusterScopeQuotaThrottle run faster,13547653,Resolved,Major,Fixed,17/Aug/23 03:59,18/Aug/23 01:34,,"-The test always times out and it has several test methods. Let's split the test into several smaller tests, so we can find out which one is the criminal.- Finally I found that, the problem is we does not limit the operation timeout, just set the max retry number, but after some new improvements come in, sometimes we may get a 6 min sleep time and n doubt we will get a test timeout... I changed the test a bit to set operation timeout on the Table instance we use, so it will fail immediately when we hit the quota throttling, and now the tests could finish very soon. I think we could add another E2E tests to make sure that the refilling works as expected." Downgrade or remove noisy log in AsyncRequestFutureImpl,13547874,Open,Major,,18/Aug/23 13:21,,,"In manageLocationError we construct a message which indicates that we failed to get a location for a particular action. We both log.error() that message, and also add it to an IOException which is set onto the final result array if retries are exhausted. This is redundant and very noisy, because those exceptions will often end up getting printed up the stack. We should remove the log, or at least downgrade to debug. One way it may be useful is if you are trying to inspect location failures for individual retries, which would not bubble up if they succeed. In that case you can enable debug loggin." Adding unit test for FileNotFoundException when split a wal in SplitLogWorker,13547783,Open,Major,,17/Aug/23 21:09,,3.0.0,"In HBase-20583, it is proposed a buggy situation in which an FileException would not be handled in SplitLogWorker. However, in HBase-20583, the test patch is still missed. And in our reproduction, it needs sophisticated situation to trigger that and we would like to add a unit test path for it The submitted patch containing the unit test and the explanation of the unit test are in the git pull: https://github.com/apache/hbase/pull/5358" Transient underlying HDFS failure causes permanent replciation failure between 2 HBase Clusters,13546743,Open,Major,,10/Aug/23 02:30,,2.0.0,"We are doing systematic testing in HBase stable release 2.0.0 and found transient underlying HDFS failure may cause some flaky behaviors in replication between HBase clusters.  We just utilize the fundamental setup in TestReplicationBase.java, in which we start the first cluster with 2 slaves and the second cluster with 4 slaves. Then it sets the second cluster to be the slave cluster for the first cluster to test replication.   {code:java} ... utility1.startMiniCluster(2);     utility2.startMiniCluster(4); ...    hbaseAdmin.addReplicationPeer(""2"", rpc); ...{code} After all setup are done, we just run runSimplePutdeleteTest() in TestReplicationBase.java in which we just add one row to the common topic in the first cluster and then check that row is successfully replicated to the common topic in the second cluster. However, when there is one transient HDFS failure happening, this test becomes flaky.  In hbaseAdmin.addReplicationPeer(“2”,rpc) during setup, the zknodes for the two regionservers in the first cluster are changed first to reflect the adding cluster 2 as replication peer:   {code:java} 2023-08-03 10:19:55,137 DEBUG [Time-limited test-EventThread] zookeeper.ZKUtil(355): regionserver:40051-0x189bbc4c84c0005, quorum=localhost:62113, baseZNode=/1 Set watcher on existing znode=/1/replication/peers/2 2023-08-03 10:19:55,137 DEBUG [Time-limited test-EventThread] zookeeper.ZKUtil(355): regionserver:40693-0x189bbc4c84c0004, quorum=localhost:62113, baseZNode=/1 Set watcher on existing znode=/1/replication/peers/2 {code} After that, the ZKWatcher at each regionserver will sense that and make corresponding state changes in HBase implementation in this stack trace:    {code:java} at org.apache.hadoop.hbase.util.CommonFSUtils.getRootDir(CommonFSUtils.java:367) at org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.init(HBaseInterClusterReplicationEndpoint.java:160)        at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.getReplicationSource(ReplicationSourceManager.java:509)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.addSource(ReplicationSourceManager.java:263) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.peerListChanged(ReplicationSourceManager.java:626) at org.apache.hadoop.hbase.replication.ReplicationTrackerZKImpl$PeersWatcher.nodeChildrenChanged(ReplicationTrackerZKImpl.java:191) at org.apache.hadoop.hbase.zookeeper.ZKWatcher.process(ZKWatcher.java:481) at org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:530) at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:505){code} However, in CommonFSUtils#getRootDir(), it would call getFileSystem() to step into the HDFS interface in which an IOException could possibly be thrown because of underlying HDFS failures.   {code:java} public static Path getRootDir(final Configuration c) throws IOException { Path p = new Path(c.get(HConstants.HBASE_DIR)); FileSystem fs = p.getFileSystem(c);  return p.makeQualified(fs.getUri(), fs.getWorkingDirectory()); }{code} When the IOException is thrown, it would be catched in ReplicationSourceManager#peerListChanged() and just print one error log. Note that this failure is permanent and there is no recovery mechanism present to retry. So there will be permanent divergence between zknodes states and HBase states. It is worth noting that the state changes in HBase implementation for the two regionservers are performed concurrently and highly-separately in two eventThread so there could be the situation that the addingPeer for one regionServer is successful while the other is failed.  Afterwards when we run runSimplePutdeleteTest() to add one row to the first cluster, the flaky behavior emerges. If the regionserver that successfully added the peer took charge of the row, the second cluster could view the changes and the test would pass. However, if the regionserver that failed to add cluster 2 as the replication peer took charge of it, then the second cluster would not sense the new row and fail the test.  We saw these as problematic because it would cause the permanent divergence between the metadata in zknodes and the real states in HBase implementation and the flaky behavior is really bad. We are not sure what is the best place to mitigate the issue. One potential fix we just tried is to just retry nodeChildrenChanged() afterwards with a backoff period and it could successfully fix the problem.  Any comments and suggestions would be appreciated. Updated: the patch is proposed here: https://github.com/apache/hbase/pull/5356    " Fix secure related tests,13547274,Resolved,Major,Fixed,14/Aug/23 14:47,17/Aug/23 02:50,, DefaultMetricsSystemInitializer should be called during HMaster or HRegionServer creation,13547538,Open,Major,,16/Aug/23 11:31,,,"Concern is the jvm metrics somehow started populating with process name as IO instead of expected RegionServer/Master. See https://issues.apache.org/jira/browse/HBASE-27966 for RCA and a stop-gap fix. But this does not fix the problem, just hides it. We should be able to figure out why the metrics is getting initialized in BaseSourceImpl instead of during HMaster/RS process creation. We may need to refactor/move the code around to fix the same. See review comments of [https://github.com/apache/hbase/pull/5323] for more details. CC: [~zhangduo]   " [hbase-connectors] Run spotless:apply on code base,13546125,Resolved,Major,Fixed,04/Aug/23 10:06,16/Aug/23 10:47,, [hbase-connectors] Manually fix javadoc messed due to spotless,13546127,Open,Major,,04/Aug/23 10:15,,,Need to manually fix fomat related issue caused to spotless. Listed in review comments of https://github.com/apache/hbase-connectors/pull/120 [hbase-operator-tools] Add spotless plugin to hbase-operator-tools,13543665,Resolved,Major,Fixed,15/Jul/23 21:06,16/Aug/23 10:34,, Remove netty 3 dependency in the pom file for hbase-endpoint,13547162,Resolved,Major,Fixed,14/Aug/23 03:44,14/Aug/23 08:15,,"We have this in the hadoop-3.0 profile, which is not necessary and will trigger dependabot warnings about security problem. Hadoop mini cluster will pull in the necessary dependencies. {code} io.netty netty 3.6.2.Final test {code}" Bump gitpython from 3.1.30 to 3.1.32 in /dev-support/flaky-tests,13547151,Resolved,Major,Fixed,14/Aug/23 02:47,14/Aug/23 03:11,, Some tests are failing everytime on the flaky dashboard,13545557,Open,Major,,31/Jul/23 15:16,,,"TestClusterScopeQuotaThrottle TestSecureNettyRpcServer TestVerifyReplicationSecureClusterCredentials" Remove InterfaceStability.Stable from HTable,13545163,Resolved,Major,Fixed,27/Jul/23 15:31,04/Aug/23 12:55,,"HTable is InterfaceAudience.Private, but the InterfaceStability.Stable annotation was not removed when that was changed. Based on our compatibility guidelines, IS.Stable only applies to IA.Public classes. This annotation is confusing to new developers who might work on modifying HTable Reference: https://hbase.apache.org/book.html#_interface_classifications" Document netty memory tunings,13546184,Open,Major,,04/Aug/23 18:57,,,"Netty can work pretty well out of the box, but you can protect your deployment from edge cases by tuning a few knobs: {code:java} -Dorg.apache.hbase.thirdparty.io.netty.maxDirectMemory By default, netty will use your -XX:MaxDirectMemorySize as the limit for its own off-heap memory usage. If you use any other off-heap memory features of hbase, this could cause a problem. For example, ByteBuffAllocator, BucketCache, or off-heap memstore. You should set netty's maxDirectMemory explicitly, and make sure to offset HBASE_OFFHEAPSIZE accordingly. Otherwise you risk OOM if netty comes under heavy load. -Dorg.apache.hbase.thirdparty.io.netty.tryReflectionSetAccessible=true If you are running java9 or greater, the above maxDirectMemory setting will not take effect unless you also set this. Java9+ has extra security features which would typically cause a reflective setAccessible call to fail. But HBase uses a variety of --add-opens calls to enable access to Unsafe libraries, and these will also enable setAccessible to work for netty. Setting this to true will enable the feature which allows your custom maxDirectMemory to be be honored.{code}   We will be adding further protections in HBASE-27947 which we can also document here, but those have not been finalized yet." Scan result wrong when using filterlist and specifing scan colums,13543405,Open,Major,,13/Jul/23 09:30,,2.4.14,"When I run these tests in hbase shell. like this: select cq1 from t1 where cq1<='2' and cq2>='5' select cq1 from t1 where cq1<='2' or cq2>='5' all these results is  is different from expectations...the results is different with MySQL and others DB... {code:java} // Test create 't1',{NAME=>'cf1'} put 't1','r1','cf1:cq1','1' put 't1','r1','cf1:cq2','2' put 't1','r2','cf1:cq1','2' put 't1','r2','cf1:cq2','3' put 't1','r3','cf1:cq1','3' put 't1','r3','cf1:cq2','4' put 't1','r4','cf1:cq1','4' put 't1','r4','cf1:cq2','5' java_import org.apache.hadoop.hbase.filter.SingleColumnValueFilter java_import org.apache.hadoop.hbase.util.Bytes java_import org.apache.hadoop.hbase.filter.CompareFilter java_import org.apache.hadoop.hbase.filter.FilterList filter1=SingleColumnValueFilter.new(Bytes::toBytes('cf1'),Bytes::toBytes('cq1'),CompareFilter::CompareOp::LESS_OR_EQUAL,Bytes::toBytes('2')) filter2=SingleColumnValueFilter.new(Bytes::toBytes('cf1'),Bytes::toBytes('cq2'),CompareFilter::CompareOp::GREATER_OR_EQUAL,Bytes::toBytes('5')) filterList1=FilterList.new(FilterList::Operator::MUST_PASS_ONE,filter1,filter2) filterList2=FilterList.new(FilterList::Operator::MUST_PASS_ALL,filter1,filter2) scan 't1',{COLUMNS=>['cf1:cq1'],FILTER =>filter1} scan 't1',{COLUMNS=>['cf1:cq2'],FILTER =>filter2} scan 't1',{COLUMNS=>['cf1:cq1'],FILTER =>filterList1} scan 't1',{COLUMNS=>['cf1:cq1'],FILTER =>filterList2} {code} !image-2023-07-13-17-34-03-488.png! when setFilterIfMissing.... it also wrong   {code:java} java_import org.apache.hadoop.hbase.filter.SingleColumnValueFilter java_import org.apache.hadoop.hbase.util.Bytes java_import org.apache.hadoop.hbase.filter.CompareFilter java_import org.apache.hadoop.hbase.filter.FilterList filter1=SingleColumnValueFilter.new(Bytes::toBytes('cf1'),Bytes::toBytes('cq1'),CompareFilter::CompareOp::LESS_OR_EQUAL,Bytes::toBytes('2')) filter1::setFilterIfMissing(true) filter2=SingleColumnValueFilter.new(Bytes::toBytes('cf1'),Bytes::toBytes('cq2'),CompareFilter::CompareOp::GREATER_OR_EQUAL,Bytes::toBytes('5')) filter2::setFilterIfMissing(true) filterList1=FilterList.new(FilterList::Operator::MUST_PASS_ONE,filter1,filter2) filterList2=FilterList.new(FilterList::Operator::MUST_PASS_ALL,filter1,filter2) scan 't1',{COLUMNS=>['cf1:cq1'],FILTER =>filter1} scan 't1',{COLUMNS=>['cf1:cq2'],FILTER =>filter2} scan 't1',{COLUMNS=>['cf1:cq1'],FILTER =>filterList1} scan 't1',{COLUMNS=>['cf1:cq1'],FILTER =>filterList2}  {code}   !image-2023-08-04-17-54-04-346.png! !image-2023-08-04-17-54-57-967.png!  " Tunable hdfs readahead for STREAM reads,13545862,Open,Major,,02/Aug/23 13:30,,,"In HBASE-27896 we disabled HDFS readahead for ReadType.PREAD. In our environment this had a huge impact on disk IO (and network IO if low locality). The default HDFS readahead is 4mb, which is way larger than many scans might actually need. In our case, we have clusters serving millions of scans and those are almost all < 1mb. I can think of two options, but open to others: # Set the readahead to whatever the scan.setMaxResultSize is, or some multiple of block size. # Simply make it configurable, and let operators configure it on a per table basis. It may make sense to do both." "Add Get, Mutate, and Multi operations to slow log params",13545423,Open,Major,,30/Jul/23 13:30,,,"In https://issues.apache.org/jira/browse/HBASE-27536 we added the ability to include Scan operations in the slow log params. It would be useful to include more operations too. Beyond just showing the shape of the request to slow log readers, this would also ensure that operation attributes can be inferred. There are a few complications to consider for some operation types: * Mutate: ** we should probably strip the columns from these puts. Otherwise we might produce unpredictably large slow log payloads, and there are potentially security concerns to consider * Multi ** we should also consider stripping columns from these requests ** (configurably?) limiting the number of operations that can be included. For example, maybe we only want to include 5 operations on a slow log payload for a 100 operation MultiRequest for the sake of brevity  ** we may want to deduplicate operation attributes. I'm not really sure how we'd do this without the output being misleading" Empty Increments in batch calls are too expensive,13545340,Open,Major,,28/Jul/23 18:35,,,"When an Increment is submitted via table.increment, we have a check which throws an exception if the Increment is empty. There is no such check when Increment is submitted through table.batch(). When this Increment makes its way to the server, it makes it all the way down past taking a row lock before the first check as to whether the Increment has any columns in it. Finally when we go to fetch the current cells from the table for atomic update, the fact that getFamilyMap() is empty starts to matter. Even still, beyond that I think we might still end up writing a somewhat useless WALEdit. The big issue here is the row lock, as this causes contention under certain hotspot access patterns which greatly exacerbate the hotspot. On the server side, we should check for whether the Increment is empty before even attempting to serve it. On the client side, we should probably also iterate the batch and check for emptiness." Introduce an AdaptiveFastPathRWRpcExecutor to make the W/R/S separations fit various workloads ,13542512,Open,Major,,05/Jul/23 09:18,,,"We currently use the FastPathRWQueueRpcExecutor. But the numbers of read/write handlers are fixed, which make the RegionServer performance not so good in our prod env. The logic of it is described below: * The basic architecture is same as FastPathRWRpcExecutor. * Introduced a float shared_ratio (0, 1.0), to indicate the ratio of the number of shared handlers. (for example, when we set the ratio to 0.2, if we have 100 handlers, 50 for write, 25 for get, 25 for scan, there will be 10 + 5 + 5 shared handlers and 40 isolated handlers for write, 20 for get and 20 for scan). * Shared handler could run all the three kinds of requests. * Shared handler will be shared only when it is idle. * Shared handler is also bounded to a kind of RPCQueue, it will process the requests in that queue first. This improvement will improve the resource utility under various workloads and guarantee a level of R/W/S isolation for requests processing at the same time." CompactionServer cause the loss of HFile references in snapshot,13543539,Open,Major,,14/Jul/23 10:27,,,"We encountered an issue with the loss of HFile references in the snapshot after enabling the CompactionServer feature in our cluster. The relevant log fragment is approximately as follows: {code:java} File does not exist: /.../.tmp/data/default/......../b72cab4efb074defb1bd9acd9087891f File does not exist: /....../archive/data/default/........../b72cab4efb074defb1bd9acd9087891f File does not exist: /....../data/default/......./b72cab4efb074defb1bd9acd9087891f {code} From the displayed HDFS logs, we observed that this HFile 'b72cab4efb074defb1bd9acd9087891f' was renamed by the CompactionServer and RegionServer, and eventually deleted by the HMaster. {code:java} 2022-07-13,00:50:01,727 INFO FSNamesystem.audit:   cmd=rename   operator=CompactionServer src=/...../data/default/...../b72cab4efb074defb1bd9acd9087891f dst=/....../archive/data/default/....../b72cab4efb074defb1bd9acd9087891f 2022-07-13,00:51:23,802 INFO FSNamesystem.audit:   cmd=rename  operator=RegionServer src=/....../archive/data/default/....../b72cab4efb074defb1bd9acd9087891f dst=/....../archive/data/default/....../b72cab4efb074defb1bd9acd9087891f.1657644683801  2022-07-13,01:51:57,823 INFO FSNamesystem.audit:         cmd=delete      operator=HMaster src=/....../archive/data/default/....../b72cab4efb074defb1bd9acd9087891f.1657644683801 {code}   Based on HBASE-26722 and HBASE-22163, we understand that if a region A on RS1 is not closed, and another RS2 (in this case, CompactionServer) opens the same region A, it may trigger an ""archived"" state. Consequently, when RS1 closes this region, it will be archived again, resulting in the deletion of the HFile from the archived directory. As a result, the snapshot will lose its reference to the HFile.  " TableReplicationQueueStorage.hasData does not work as expected,13543030,Resolved,Major,Fixed,10/Jul/23 14:48,11/Jul/23 13:47,,"We want to check the table existence, but Admin.getDescriptor will throw exception instead of returning null, so the method is broken..." MetaRWQueueRpcExecutor should extend FastPathRWQueueRpcExecutor,13543185,Open,Major,,11/Jul/23 19:23,,,"Introduced in HBASE-22280, MetaRWQueueRpcExecutor protects the cluster from a case where heavy read volume to meta causes a delay in writes to meta. Delay in writes to meta can affect RIT time, among other things.  At the end of the comments in HBASE-22280, some concerns were raised about a perf regression in throughput for meta. Reverting to FastPathRWQueueRpcExecutor fixed the regression, and we've also noticed in other testing that fast path is a somewhat universally good optimization. We should change MetaRWQueueRpcExecutor to extend it so that one can take advantage of the isolation it provides and the speed of fast path." Adds a switch for compaction's delay selection feature,13542662,Open,Major,,06/Jul/23 08:50,,,"When the compact pressure is high, delayed selection can cause the metric of compact queue length to continuously increase incorrectly. We should provide an option to disable this feature if the user values metric accuracy more. See HBASE-26987 for more detail." Replication stuck when switch to new reader,13542620,Open,Major,,06/Jul/23 03:08,,2.4.17,"After creating new reader for next WAL, it immediately seek() to the  currentPositionOfEntry, but this position may be spill over the length of current WAL. {code:java} WARN  [RpcServer.default.FPRWQ.Fifo.read.handler=101,queue=1,port=16020.replicationSource.wal-reader.XXXXXXX] regionserver.ReplicationSourceWALReader: Failed to read stream of replication entries java.io.EOFException: Cannot seek after EOF         at org.apache.hadoop.hdfs.DFSInputStream.seek(DFSInputStream.java:1488)         at org.apache.hadoop.fs.FSDataInputStream.seek(FSDataInputStream.java:62)         at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.seekOnFs(ProtobufLogReader.java:495)         at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.seek(ReaderBase.java:138)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.seek(WALEntryStream.java:399)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:341)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.handleFileNotFound(WALEntryStream.java:328)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:347)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:310)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:300)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:176)         at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:102)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.tryAdvanceStreamAndCreateWALBatch(ReplicationSourceWALReader.java:260)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:142) {code}" Fix ChaosMonkey documentation code block rendering,13547852,Resolved,Minor,Fixed,18/Aug/23 10:53,21/Aug/23 18:06,,"The code blocks in document for ChaosMonkey isnot rendered correctly. Fix them and also add few more example. See  * [https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/developer.adoc#1054-chaosmonkey-without-ssh] or * [https://hbase.apache.org/book.html#_chaosmonkey_without_ssh]" RSProcedureDispatcher to log the request details during retries,13548913,Resolved,Minor,Fixed,29/Aug/23 03:43,11/Jun/24 19:19,,"As of today, RSProcedureDispatcher only logs the exception details for the given RPC request, however it does not log any other details. We should log: * whether the request is for region open/close * proc id, proc class names * region name   Sample log without any of the above mentioned details: {code:java} 2023-08-25 02:21:02,821 WARN [ispatcher-pool-40777] procedure.RSProcedureDispatcher - request to rs1,61020,1692930044498 failed due to java.io.IOException: Call to address=rs1:61020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(javax.security.sasl.SaslException): GSS initiate failed, try=0, retrying... {code}" Synchronous replication should check if the file system supports truncate API,13544031,Open,Minor,,18/Jul/23 21:03,,,"Ok. I missed this but I was just told that the synchronous replication leverages the truncate() FS API. https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/SyncReplicationReplayWALManager.java#L282 Ozone does not implement truncate so calling this method on the WAL FS will result in an exception. It would be a better user experience to alert user that this is not supported from the start." Change the label from InterfaceAudience.Private to InterfaceAudience.LimitedPrivate for org.apache.hadoop.hbase.Server.java ,13542755,Open,Minor,,07/Jul/23 04:05,,2.4.4,"Currently the class org.apache.hadoop.hbase.Server.java is marked InterfaceAudience.Private. {{{}This prevents in getting shared zookeeper watcher (ZKWatcher) instances from org.apache.hadoop.hbase.regionserver.RegionServerServices.java (extends org.apache.hadoop.hbase.Server.java{}}}{{{}) using the method getZooKeeper().{}}}   {{This creates a problem in writing custom Coprocessors because now we don't have a shared ZKWatcher instance.}}   {{The proposed solution is to use the InterfaceAudience.LimitedPrivate. }}" Add hbase.normalizer.merge.merge_request_max_number_of_regions property to limit max number of regions in a merge request for merge normalization,13550045,Resolved,Minor,Fixed,08/Sep/23 13:46,28/Sep/23 08:06,2.4.0,"In our production environment, while investigating an issue, we observed that the Noramlizer had scheduled one single merge procedure to an RS providing 27K+ empty regions of a table (this was a result of a failed copy table job that left 27K+ empty regions of the table) to merge. This action led the procedure to go to stuck state and eventually the procedure framework bailed out after ~40mins. This was happening with each normalizer run until we deleted the table manually. Logs Normalizer triggers a merge procedure normalizer.RegionNormalizerWorker - NormalizationTarget[regionInfo=\{ENCODED => 6e8606335a62f6bafceb017dc7edfdf5, NAME => 'TEST.TEST_TABLE,XXXX.', STARTKEY => 'XXXX', ENDKEY => 'YYYY'},{*}regionSizeMb=0{*}], NormalizationTarget[regionInfo=\{ENCODED => 79607df308d7618e632abe8a12c1bf6b, NAME => 'TEST.TEST_TABLE,XXXX', STARTKEY => 'XXYY', ENDKEY => 'YYZZ'},{*}regionSizeMb=0]{*}]] resulting in *pid 21968356* procedure immediately gets stuck procedure2.ProcedureExecutor - Worker *stuck* PEWorker-56(pid=21968356), run time 12.4850 sec Finally fails after ~40 mins procedure2.ProcedureExecutor - Worker *stuck* PEWorker-56(pid=21968356), run time *40 mins, 58.055 sec* Bails out with RuntimeException procedure2.ProcedureExecutor - force=false java.lang.UnsupportedOperationException: pid=21968356, state=FAILED:MERGE_TABLE_REGIONS_UPDATE_META, locked=true, exception=java.lang.{*}RuntimeException via CODE-BUG: Uncaught runtime exception{*}: pid=21968356, state=RUNNABLE:MERGE_TABLE_REGIONS_UPDATE_META, locked=true; MergeTableRegionsProcedure table=TEST.TEST_TABLEXXXX, {*}regions={*}{*}[269a1b168af497cce9ba6d3d581568f2{*} . . . . *27K+ regions printed here]*" introduce a ConnectionLimitHandler to limit the number of concurrent connections to the Server,13542840,Open,Minor,,07/Jul/23 19:24,,3.0.0-alpha-4,"The unreasonable retries of the client cause the hbase server to fail to accept and create new connections, and thus hang up. We can consider introducing a ConnectionLimitHandler similar to Cassandra in our NettyRpcServer to protect the hbase servers.   ERROR [master:store-WAL-Roller] master.HMaster: ***** ABORTING master hmaster,60000,1679921578648: IOE in log roller ***** java.net.SocketException: Call From hmaster/hmaster to namenode:9000 failed on socket exception: java.net.SocketException: Too many open files; For more details see: [http://wiki.apache.org/hadoop/SocketException] java.io.IOException: Too many open files at java.base/sun.nio.ch.Net.accept(Native Method) at java.base/sun.nio.ch.ServerSocketChannelImpl.implAccept(ServerSocketChannelImpl.java:425) at java.base/sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:391) at org.apt java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:376) at jdk.proxy2/jdk.proxy2.$Proxy24.getFileInfo(Unknown Source) at jdk.internal.reflect.GeneratedMethodAccessor139.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:376) at jdk.proxy2/jdk.proxy2.$Proxy24.getFileInfo(Unknown Source) at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:1753) at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1617) at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1614) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1629) at org.apache.hadoop.fs.FileSystem.exists(FileSystem.java:1713) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.getNewPath(AbstractFSWAL.java:582) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:843) at org.apache.hadoop.hbase.wal.AbstractWALRoller$RollController.rollWal(AbstractWALRoller.java:268) at org.apache.hadoop.hbase.wal.AbstractWALRoller.run(AbstractWALRoller.java:187) Caused by: java.net.SocketException: Too many open files at java.base/sun.nio.ch.Net.socket0(Native Method) at java.base/sun.nio.ch.Net.socket(Net.java:524) at java.base/sun.nio.ch.SocketChannelImpl.(SocketChannelImpl.java:146) at java.base/sun.nio.ch.SocketChannelImpl.(SocketChannelImpl.java:129) at java.base/sun.nio.ch.SelectorProviderImpl.openSocketChannel(SelectorProviderImpl.java:77) at java.base/java.nio.channels.SocketChannel.open(SocketChannel.java:192) at org.apache.hadoop.net.StandardSocketFactory.createSocket(StandardSocketFactory.java:62) at org.apache.hadoop.ipc.Client$Connection.setupConnection(Client.java:656) at org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:812) at org.apache.hadoop.ipc.Client$Connection.access$3800(Client.java:413) at org.apache.hadoop.ipc.Client.getConnection(Client.java:1636) at org.apache.hadoop.ipc.Client.call(Client.java:1452)" add JvmPauseMonitor in hbase-client,13542905,Open,Minor,,09/Jul/23 08:14,,3.0.0-alpha-4,"Many of our users integrate hbase-client in some frameworks such as SpringBoot, and JvmPauseMonitor will help to find GC problems." "Web UI of Thrift, REST and RegionServer are partially broken",13552361,Open,Minor,,28/Sep/23 22:53,,2.3.7,"If I go to Web UI of: * Thrift * REST * RegionServer I saw that UI is partialy overlapped (see screnshots)." Move snapshot storage from filesystem to a separated HBase table,13552182,Open,Minor,,27/Sep/23 13:04,,,"As we know, rename and list are very expensive operations on object storage. Currently, the snapshot in hbase relies on these two operations. For example, when taking snapshot, we first write snapshot description and data manifest file to a temporary directory ,then commit it by a rename operation. When list all snapshots, we will scan the snapshot directory to find all completed snapshots. So maybe we can try to introduce a new snapshot storage, using hbase table to store it. Here are a few points from which maybe we can gain benefits: 1. make hbase easier to deploy on object storage, like s3 2. will make snapshots faster and more lightweight. In the current filesystem-based snapshot implementation, when consolidating snapshot manifest, we will first list all region manifests with a thread pool, read content and then delete them. When the number of regions is large, this process may take a lot of time. In comparison, the read and write operations of hbase tables are more lightweight than the read and write operations of hdfs files. 3. more likely to reduce hdfs small files" [hbase-examples] MultiThreadedClientExample throws java.lang.ClassCastException,13544896,Resolved,Minor,Fixed,26/Jul/23 05:53,26/Sep/23 07:20,,"Tried using run() method call of [https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/MultiThreadedClientExample.java|https://github.com/apache/hbase/blob/master/hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/MultiThreadedClientExample.java.] Following the stack trace of error during runtime {code:java} Exception in thread ""main"" java.io.IOException: java.lang.reflect.UndeclaredThrowableException     at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$1(ConnectionFactory.java:235)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:218)     at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:160)     at org.apache.hadoop.hbase.client.example.MultiThreadedClientExample.run(MultiThreadedClientExample.java:136)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)     at .runMultiThreadedRWOps(xxxxxx)     at .main(xxxxxx) Caused by: java.lang.reflect.UndeclaredThrowableException     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1780)     at org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs(User.java:328)     at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$1(ConnectionFactory.java:232)     ... 8 more Caused by: java.lang.reflect.InvocationTargetException     at sun.reflect.GeneratedConstructorAccessor16.newInstance(Unknown Source)     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)     at java.lang.reflect.Constructor.newInstance(Constructor.java:423)     at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$null$0(ConnectionFactory.java:233)     at java.security.AccessController.doPrivileged(Native Method)     at javax.security.auth.Subject.doAs(Subject.java:422)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1762)     ... 10 more Caused by: java.lang.ClassCastException: java.util.concurrent.ForkJoinPool cannot be cast to java.util.concurrent.ThreadPoolExecutor     at org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:283)     at org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:270)     ... 17 more {code} Reason: due to HBASE-22244 Make use of MetricsConnection in async client following changes {code:java} // thread executor shared by all Table instances created // by this connection private volatile ExecutorService batchPool = null; got modified to private volatile ThreadPoolExecutor batchPool = null; {code} ExecutorService got changed to ThreadPoolExecutor. ExecutorService is compatible with ForkJoinPool however ThreadPoolExecutor is not compatible." NPE on initialization error in RecoveredReplicationSourceShipper,13550368,Resolved,Minor,Fixed,12/Sep/23 13:14,14/Sep/23 23:57,2.4.17,"When we run into problems starting RecoveredReplicationSourceShipper, we try to stop the reader thread which we haven't initialized yet, resulting in an NPE. {noformat} ERROR org.apache.hadoop.hbase.replication.regionserver.ReplicationSource: Unexpected exception in redacted currentPath=hdfs://redacted java.lang.NullPointerException         at org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSourceShipper.terminate(RecoveredReplicationSourceShipper.java:100)         at org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSourceShipper.getRecoveredQueueStartPos(RecoveredReplicationSourceShipper.java:87)         at org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSourceShipper.getStartPosition(RecoveredReplicationSourceShipper.java:62)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.lambda$tryStartNewShipper$3(ReplicationSource.java:349)         at java.util.concurrent.ConcurrentHashMap.compute(ConcurrentHashMap.java:1853)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.tryStartNewShipper(ReplicationSource.java:341)         at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:601)         at java.lang.Thread.run(Thread.java:750) {noformat} A simple null check should fix this." Drop duplicate test class TestShellRSGroups.java,13549828,Resolved,Minor,Fixed,06/Sep/23 18:47,16/Sep/23 15:24,,"Just noticed that {{TestShellRSGroups.java}} is at {{hbase-shell/src/test/rsgroup/org/apache/hadoop/hbase/client/rsgroup/TestShellRSGroups.java,}} but ideally it should be at {{hbase-shell/src/test/java/org/apache/hadoop/hbase/client/rsgroup/TestShellRSGroups.java}} instead. Also because of same misplacement spotless skipped this file. Also need to run spotless for the same." Failed backups block backup merges,13550663,Open,Minor,,14/Sep/23 09:52,,,"I was doing some experiments with HBase backup, and came to the following situation:   {noformat} user@hadoop-client-769bc9946-g6p59:/$ hbase backup history {ID=backup_1694682979468,Type=INCREMENTAL,Tables={foo:bar,foo:baz},State=COMPLETE,Start time=Thu Sep 14 09:16:20 UTC 2023,End time=Thu Sep 14 09:16:45 UTC 2023,Progress=100%} {ID=backup_1694682942306,Type=INCREMENTAL,Tables={foo:bar,foo:baz},State=COMPLETE,Start time=Thu Sep 14 09:15:43 UTC 2023,End time=Thu Sep 14 09:16:11 UTC 2023,Progress=100%} {ID=backup_1694682906267,Type=INCREMENTAL,Tables={foo:bar,foo:baz},State=COMPLETE,Start time=Thu Sep 14 09:15:08 UTC 2023,End time=Thu Sep 14 09:15:34 UTC 2023,Progress=100%} {ID=backup_1694682869991,Type=INCREMENTAL,Tables={foo:bar,foo:baz},State=COMPLETE,Start time=Thu Sep 14 09:14:31 UTC 2023,End time=Thu Sep 14 09:14:58 UTC 2023,Progress=100%} {ID=backup_1694681054166,Type=INCREMENTAL,Tables={foo:bar,foo:baz},State=FAILED,Start time=Thu Sep 14 08:44:16 UTC 2023,Failed message=REPAIR status: repaired after failure: backup_1694681054166,Progress=0%} {ID=backup_1694681006360,Type=FULL,Tables={foo:bar,foo:baz},State=COMPLETE,Start time=Thu Sep 14 08:43:27 UTC 2023,End time=Thu Sep 14 08:43:56 UTC 2023,Progress=100%} {noformat} Even though I was able to create new incremental backups, I am not able to merge the old backups, due to the failed (& repaired) backup:     {code:java} # Failed incremental + completed incremental user@hadoop-client-769bc9946-g6p59:/$ hbase backup merge backup_1694681054166,backup_1694682869991 23/09/14 09:17:57 ERROR org.apache.hadoop.hbase.backup.BackupDriver: Error running command-line tool java.io.IOException: Backup image backup_1694681054166 can not be merged becuase of its state: FAILED     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.checkIfValidForMerge(BackupAdminImpl.java:664)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.mergeBackups(BackupAdminImpl.java:619)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$MergeCommand.execute(BackupCommands.java:834)     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134)     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169)     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) {code}     {code:java} # Completed full backup + failed incremental user@hadoop-client-769bc9946-g6p59:/$ hbase backup merge backup_1694681006360,backup_1694681054166 23/09/14 09:19:40 ERROR org.apache.hadoop.hbase.backup.BackupDriver: Error running command-line tool java.io.IOException: FULL backup image can not be merged for:  backup_1694681006360     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.checkIfValidForMerge(BackupAdminImpl.java:659)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.mergeBackups(BackupAdminImpl.java:619)     at org.apache.hadoop.hbase.backup.impl.BackupCommands$MergeCommand.execute(BackupCommands.java:834)     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134)     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169)     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199)     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) {code}     I'm not sure why merging a failed backup is not possible, given that it is possible to create new incremental backups on top of it. Either the data in that failed backup is reliable (meaning it should be merge-able), or not reliable (meaning it should not be possible to execute incremental backups on top of it). If I were to delete the failed backup, all other incremental backups would also be deleted. This made me assume failed backups still keep track of reliable data." Update tech details of backup,13550387,Open,Minor,,12/Sep/23 16:01,,,"The [technical details|https://hbase.apache.org/book.html#br.technical.details] of HBase backup mention that the backup works by copying WALs which are converted to HFiles during the restore process. However, the code seems to imply that WALs are already converted to HFiles during the backup process. (See IncrementalTableBackupClient#convertWALsToHFiles.) I suspect the docs still describe the old behavior, which (I suspect) was changed in HBase-14141. Knowing this also confirms that bulk-imported HFiles are also backed-up using the same mechanism (see IncrementalTableBackupClient#handleBulkLoad) - something I managed to test with experimentation, but wasn't explained in the backup docs. In short, this section in the docs requires an update." Removing the useless parameters from ProcedureExecutor.loadProcedures,13549166,Resolved,Minor,Fixed,30/Aug/23 14:47,31/Aug/23 13:58,2.4.13,"In this method, parameter abortOnCorruption is useless, so it is recommended to remove it" Record the replication start timestamp for tables/peers,13548119,Open,Minor,,22/Aug/23 01:06,,2.5.5,"Currently, the peer info showed on the UI miss the start timestamp for the replications, we need the start timestamp (e.g. the create time of the peer, the time when tables added to peers) to distinguish if the replication is continuous or discontinuous." some syntax errors detected by IDEA in pom.xml,13543879,Resolved,Minor,Fixed,18/Jul/23 03:54,13/Aug/23 10:07,2.2.7,"When I open the project by IDEA,  there are some syntax error detected in pom.xml, which can confuse developers. Has anyone else meet this?  It seems does not affect compilation, but I don't know why the red highlight comes here, annoying... !image-2023-07-18-11-54-47-997.png|width=840,height=171!   !image-2023-07-18-11-55-15-582.png|width=445,height=110!" The logStats about LruBlockCache is not accurate,13546372,Resolved,Minor,Fixed,07/Aug/23 14:15,09/Aug/23 17:53,2.4.13,"LruBlockCache.logStats would print info, as follow: {code:java} //代码占位符 INFO  [LruBlockCacheStatsExecutor] hfile.LruBlockCache: totalSize=2.42 MB, freeSize=3.20 GB, max=3.20 GB, blockCount=14, accesses=31200, hits=31164, hitRatio=99.88%, , cachingAccesses=31179, cachingHits=31156, cachingHitsRatio=99.93%, evictions=426355, evicted=0, evictedPerRun=0.0 {code} I think the description about *totalSize=2.42 MB* is not accurate, It actually represents the used size of BlockCache." Broken build because of cycloneDX,13542305,Resolved,Minor,Duplicate,03/Jul/23 13:07,03/Jul/23 13:11,,"[INFO] CycloneDX: Resolving Dependencies [ERROR] An error occurred attempting to read POM org.codehaus.plexus.util.xml.pull.XmlPullParserException: UTF-8 BOM plus xml decl of ISO-8859-1 is incompatible (position: START_DOCUMENT seen getActiveMaster() { return tracedFuture( () -> this . call( (c, s, d) -> s.getActiveMaster(c, GetActiveMasterRequest.getDefaultInstance(), d), GetActiveMasterResponse::hasServerName, ""getActiveMaster()"") .thenApply(resp -> ProtobufUtil.toServerName(resp.getServerName())), getClass().getSimpleName() + "".getClusterId""); }" The javadoc about RegionProcedureStore.delete is incorrect,13549162,Resolved,Trivial,Fixed,30/Aug/23 13:59,31/Aug/23 13:58,2.4.13,"As shown in the following figure. !image-2023-08-30-21-54-59-999.png!   Actually, we would fill the {color:#ff0000}*proc:d*{color} column with an empty byte array when calling RegionProcedureStore.delete(). !image-2023-08-30-21-57-32-393.png!      " NPE in AddPeerProcedure recovery,13544552,Resolved,Trivial,Fixed,23/Jul/23 13:26,28/Jul/23 15:20,4.0.0-alpha-1,"AddPeerProcedure will restore syncReplicationPeerLock when replayed in master recovery, however the replicationPeerManager has not been initialized when replay procedure, which will cause a nullPointerException and master to abort. {code:java} @Override protected void afterReplay(MasterProcedureEnv env) { // ...... if (peerConfig.isSyncReplication()) { if (!env.getReplicationPeerManager().tryAcquireSyncReplicationPeerLock()) { throw new IllegalStateException( ""Can not acquire sync replication peer lock for peer "" + peerId); } } } {code}" NPE in MigrateReplicationQueueFromZkToTableProcedure recovery,13544215,Resolved,Trivial,Fixed,20/Jul/23 04:56,22/Jul/23 13:28,3.0.0-alpha-4,"MigrateReplicationQueueFromZkToTableProcedure will restore the disabled state of replication log cleaner barrier when replayed in master recovery, {code:java} @Override protected void afterReplay(MasterProcedureEnv env) { if (getCurrentState() == getInitialState()) { // do not need to disable log cleaner or acquire lock if we are in the initial state, later // when executing the procedure we will try to disable and acquire. return; } if (!env.getReplicationPeerManager().getReplicationLogCleanerBarrier().disable()) { throw new IllegalStateException(""can not disable log cleaner, this should not happen""); } } {code} however the replicationPeerManager has not been initialized when replay procedure, which will cause a nullPointerException and master to abort. Maybe better to add a check after the initialization of replicationPeerManager to determine whether replication log cleaner barrier needs to be disabled ?" Bytes.toInt(byte[] bytes)-why set default offset as zero,13368286,Open,Blocker,,29/Mar/21 05:55,,,"As we know, when using Bytes.tobytes(int), the method convert the int value to byte-array with big endian. So, when we try to extract the right int-value from byte-array, we use method 'Bytes.toInt(byte[] bytes)',  and int the method, it sets the offset as zero.   it shows like this  /** * Converts a byte array to an int value * @param bytes byte array * @return the int value */ public static int toInt(byte[] bytes) { return toInt(bytes, 0, SIZEOF_INT); } My question is :  why don't we set the offset as (bytes.length - SIZEOF_INT)?   Recently, we have long-value stored in hbase, as we try to extract, we decode the byte-array as int-value, it leads some incorrect-value like 0.   The usage of decoding-int-value from long-value-byte-array is wrong, I'm just curious about the start point of setting offset as 0  " HBASE-24260 breaks JDK7 compilation in branch-1,13350793,Resolved,Blocker,Duplicate,07/Jan/21 03:27,07/Jan/21 08:31,,"Found in PR-2799. {code} public static String getZKQuorum(Configuration conf) { String port = Integer.toString(conf.getInt(HConstants.ZOOKEEPER_CLIENT_PORT, 2181)); String[] serverHosts = conf.getStrings(HConstants.ZOOKEEPER_QUORUM, ""localhost""); for (int i = 0; i < serverHosts.length; i++) { serverHosts[i] = serverHosts[i] + "":"" + port; } return String.join("","", serverHosts); } {code} Fails to compile {quote} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project hbase-it: Compilation failure [ERROR] /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2799/src/hbase-it/src/main/java/org/apache/hadoop/hbase/chaos/ChaosUtils.java:[46,18] cannot find symbol [ERROR] symbol: method join(java.lang.String,java.lang.String[]) [ERROR] location: class java.lang.String {quote} because String.join() is only available since JDK8. CC: [~lokiore] [~ndimiduk]" Fix NPE in ReplicationSourceManager as well as avoid permanently unreplicated data due to EOFException from WAL,13360193,Resolved,Critical,Fixed,22/Feb/21 21:48,03/Mar/21 19:41,,"There seems to be a major issue with how we handle the EOF exception from WALEntryStream.  Problem: When we see EOFException, we try to handle it and remove it from the log queue, but we never try to ship the existing batch of entries. *This is a permanent data loss in replication.*   Secondly, we do not stop the reader on encountering the EOFException and thus if EOFException was on the last WAL, we still try to process the WALEntry stream and ship the empty batch with lastWALPath set to null. This is the reason of NPE as below which *crash* the region server.  {code:java} 2021-02-16 15:33:21,293 ERROR [,60020,1613262147968] regionserver.ReplicationSource - Unexpected exception in ReplicationSourceWorkerThread, currentPath=nulljava.lang.NullPointerExceptionat org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.logPositionAndCleanOldLogs(ReplicationSourceManager.java:193)at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.updateLogPosition(ReplicationSource.java:831)at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.shipEdits(ReplicationSource.java:746)at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.run(ReplicationSource.java:650)2021-02-16 15:33:21,294 INFO [,60020,1613262147968] regionserver.HRegionServer - STOPPED: Unexpected exception in ReplicationSourceWorkerThread {code}    " Handle the NoNode exception in remove log replication and avoid RS crash,13359121,Resolved,Critical,Fixed,17/Feb/21 18:30,27/Feb/21 00:00,1.7.0,"Should not crash the region server it there is a NoNode exception while removing the log We should look into the excpetion and if it is NoNode we shouldn't crash. There might be a possiblity the node was deleted as part of peer tear down. {code:java} @Override public void removeLog(String queueId, String filename) { try { String znode = ZKUtil.joinZNode(this.myQueuesZnode, queueId); znode = ZKUtil.joinZNode(znode, filename); ZKUtil.deleteNode(this.zookeeper, znode); } catch (KeeperException e) { this.abortable.abort(""Failed to remove wal from queue (queueId="" + queueId + "", filename="" + filename + "")"", e); } } {code} This was the exception observed on region servers: {code:java} 2021-02-16 20:11:58,567 FATAL [95922885,xyz_peer] regionserver.HRegionServer - ABORTING region server regionserver-111,60020,1613495922885: Failed to remove wal from queue (queueId=xyz_peer, filename=regionserver-111%2C60020%2C1613495922885.1613505863058) org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase/replication/rs/regionserver-111,60020,1613495922885/xyz_peer/regionserver-111%2C60020%2C1613495922885.16135058630 58 at org.apache.zookeeper.KeeperException.create(KeeperException.java:114) at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:890) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:238) at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1341) at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1330) at org.apache.hadoop.hbase.replication.ReplicationQueuesZKImpl.removeLog(ReplicationQueuesZKImpl.java:142) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.cleanOldLogs(ReplicationSourceMana ger.java:232) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.cleanOldLogs(ReplicationSourceMana ger.java:222) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.logPositionAndCleanOldLogs(Replica tionSourceManager.java:198) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.updateLogP osition(ReplicationSource.java:831) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.shipEdits( ReplicationSource.java:746) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$ReplicationSourceShipperThread.run(Replic ationSource.java:650) {code}" Upgrade Thrift jar to fix CVE-2020-13949,13358273,Resolved,Critical,Fixed,12/Feb/21 05:57,25/Mar/21 20:14,,"There is potential DoS when processing untrusted Thrift payloads, https://seclists.org/oss-sec/2021/q1/140" Nightly client integration test is failing after upgrading to log4j2,13366581,Resolved,Critical,Fixed,21/Mar/21 14:42,23/Mar/21 06:56,,In hbase_nightly_pseudo-distributed-test.sh we still uses log4j.properties which is for log4j1. meta replica state is not respected during active master switch,13362684,Resolved,Critical,Fixed,05/Mar/21 19:31,18/Mar/21 18:38,2.0.6,"We saw this warning in master log. WARN org.apache.hadoop.hbase.master.assignment.AssignmentManager: No RegionStateNode for hbase:meta,,1_0003 but reported as up on server1.example.com,16020,1614958467735; closing...   The root cause is that meta replica regions are in zookeeper, and these state are not iterated by the new active master so it loses track." Scan#setSmall blindly sets ReadType as PREAD,13362908,Resolved,Critical,Fixed,08/Mar/21 04:15,08/Mar/21 08:36,,"setSmall(boolean small) takes a boolean param and it might get called with false also. But with out considering that, we set read type as PREAD. Phoenix clones Scan object and do newScan.setSmall(scan.isSmall()); So this makes ALL types of scans from phoenix as PREAD type now. (Even full table scan)" Nightly build uses JDK11 for branch-2.2,13351133,Resolved,Critical,Fixed,08/Jan/21 17:41,11/Jan/21 01:44,2.2.7,"Nightly build for branch-2.2 is using JDK11 accidentally. Yetus tries to set JAVA_HOME to JDK8 but the path does not exist and it falls back to JDK11. {noformat} [2021-01-07T19:11:14.729Z] WARNING: JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 does not exist. Dockermode: attempting to switch to another. [2021-01-07T19:11:14.729Z] WARNING: Setting /usr/lib/jvm/java-11-openjdk-amd64 as the JAVA_HOME. {noformat} With JDK11 there are a lot of compilation errors." Fix error prone problems on branch-2.2,13350664,Resolved,Critical,Fixed,06/Jan/21 12:34,07/Jan/21 17:34,2.2.7,"Nightly builds on branch-2.2 do not succeed for more than a month. General checks show a few error prone warnings. These were already corrected on branch-2.3+ (HBASE-23753). A recent error prone upgrade to 2.4.0 on branch-2.2 requires these code fixes. {noformat} [ERROR] /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_branch-2.2/component/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:[1347,18] error: [ProtoFieldNullComparison] Protobuf fields cannot be null. (see https://errorprone.info/bugpattern/ProtoFieldNullComparison) Did you mean 'if ((!proto.getCellList().isEmpty() && !values.isEmpty()) ||'? [ERROR] /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_branch-2.2/component/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfoBuilder.java:[122,9] error: [ComparableType] Type of Comparable (RegionInfo) is not the same as implementing class (MutableRegionInfo). (see https://errorprone.info/bugpattern/ComparableType) [INFO] 2 errors {noformat}" WAL can't be cleaned in some scenes,13348901,Resolved,Major,Fixed,04/Jan/21 09:26,11/Jan/21 02:51,2.2.6,"phoenix jira : https://issues.apache.org/jira/browse/PHOENIX-5250 it's still open!" Improve the shell's 'status replication' command output,13367407,Resolved,Major,Fixed,25/Mar/21 02:04,31/Dec/24 01:55,2.4.2,"The output of the shell's 'status ""replication""' command could use some cleaning up. The basic format is: version VERSION N live servers SERVER_1: SOURCE: PeerID=PEERID, AgeOfLastShippedOp=160347, SizeOfLogQueue=49, TimeStampsOfLastShippedOp=Thu Mar 25 01:55:21 UTC 2021, Replication Lag=161013 SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Mar 25 01:49:53 UTC 2021 ... Issues: - Per line format is KEY=VALUE, ... . Most KEYs are CamelCase but some have spaces. Should all be camel case for consistency. - Age is printed as long and timestamp is string (local TZ) format. I think the string formatting of the timestamp makes it difficult to read. Lets just print timestamps as longs. Or provide a non-default option for string formatted timestamps. - There is no sense of effective rate or bandwidth. Each source and sink line emitted should provide some sense of current workload: rpcs/sec, bytes/sec, cells/sec... something. " Size of log queue metric is incorrect in branch-1/branch-2,13366177,Resolved,Major,Fixed,18/Mar/21 20:36,19/Mar/21 23:18,1.7.0,"In HBASE-25539 I did some refactoring for adding a new metric ""oldestWalAge"" and tried to consolidate update to all the metrics related to ReplicationSource class (size of log queue and oldest wal age) at one place.  In that refactoring introduced one bug where I am decrementing twice from size of log queue metric whenever we remove a wal from Replication source queue.  " release hbase-operator-tools 1.1.0,13359745,Resolved,Major,Fixed,20/Feb/21 07:12,21/Feb/21 22:30,, release script generated vote template has incorrect staging area,13358441,Resolved,Major,Fixed,13/Feb/21 03:59,30/Dec/24 12:35,,"I noticed while making the hbase-thirdparty 3.5.0 RC0 that the generated vote email showed the location of the RC using just the version and RC number: https://dist.apache.org/repos/dist/dev/hbase/3.5.0RC0/ The correct location needs to include the project name when the release is for something other than the main project, e.g.: https://dist.apache.org/repos/dist/dev/hbase/hbase-thirdparty-3.5.0RC0/" Offload the compaction job to independent Compaction Server,13368535,Open,Major,,30/Mar/21 07:04,,,"The basic idea is add a role ""CompactionServer"" to take the Compaction job. HMaster is responsible for scheduling the compaction job to different CompactionServer. [design doc|https://docs.google.com/document/d/1exmhQpQArAgnryLaV78K3260rKm64BHBNzZE4VdTz0c/edit?usp=sharing] Suggestions are welcomed. Thanks." Basic benchmark to show the impact on performance for tracing,13363713,Resolved,Major,Fixed,11/Mar/21 03:26,01/Apr/21 16:02,, "Add ""2.4 Documentation"" to the website",13357981,Resolved,Major,Fixed,10/Feb/21 17:09,02/Sep/22 10:03,3.0.0-alpha-1,Docs from the 2.4.0 build should be slotted into the website. Remove deprecated methods in ReplicationPeerConfig,13353654,Resolved,Major,Fixed,21/Jan/21 06:17,24/Jan/21 15:37,3.0.0-alpha-1,HBASE-19576 introduce ReplicationPeerConfigBuilder to set the value of ReplicationPeerConfig. The deprecated methods in ReplicationPeerConfig should be removed in 3.x. Optimize TableName.valueOf from O(n) to O(1). We can get benefits when the number of tables in the cluster is greater than dozens,13352394,Patch Available,Major,,15/Jan/21 03:17,,1.2.12,"Now, TableName.valueOf will try to find TableName Object in cache linearly(code show as below). So it is too slow when we has  thousands of tables on cluster. {code:java} // code placeholder for (TableName tn : tableCache) { if (Bytes.equals(tn.getQualifier(), qns) && Bytes.equals(tn.getNamespace(), bns)) { return tn; } }{code} I try to store the object in the hash table, so it can look up more quickly. code like this {code:java} // code placeholder TableName oldTable = tableCache.get(nameAsStr);{code}   In our cluster which has tens thousands of tables. (Most of that is KYLIN table).  We found that in the following two cases, the TableName.valueOf method will severely restrict our performance.   Common premise: tens of thousands table in cluster cause: TableName.valueOf with low performance. (because we need to traverse all caches linearly)   Case1. Replication premise1: one of table write with high qps, small value, Non-batch request. cause too much wal entry premise2: deserialize WAL Entry includes calling the TableName.valueOf method. Cause: Replicat Stuck. A lot of WAL files pile up.   Case2. Active Master Start up NamespaceStateManager init should init all RegionInfo, and regioninfo init will call TableName.valueOf.  It will cost some time if TableName.valueOf is slow.  " Setting wrong data block encoding through ColumnFamilyDescriptorBuilder#setValue leading to servers down,13368456,Open,Major,,29/Mar/21 19:03,,,"Setting wrong data block encoding using ColumnFamilyDescriptorBuilder#setValue instead of using ColumnFamilyDescriptorBuilder#setDataBlockEncoding leading to region servers down eventually kill master also. This is possible from Phoenix where all the column family properties passed to descriptors using ColumnFamilyDescriptorBuilder#setValue. {noformat} Failed to open region my_case_sensitive_table,,1617040355998.d8a1df22970075b8863d5c39b2c1e08c., will report to master java.io.IOException: java.lang.IllegalArgumentException: No enum constant org.apache.hadoop.hbase.io.encoding.DataBlockEncoding.SDFS at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1134) at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1076) at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:973) at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:925) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7346) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7304) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7276) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7234) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7185) at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:133) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.IllegalArgumentException: No enum constant org.apache.hadoop.hbase.io.encoding.DataBlockEncoding.SDFS at java.lang.Enum.valueOf(Enum.java:238) at org.apache.hadoop.hbase.io.encoding.DataBlockEncoding.valueOf(DataBlockEncoding.java:31) at org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder$ModifyableColumnFamilyDescriptor.lambda$getDataBlockEncoding$2(ColumnFamilyDescriptorBuilder.java:806) at org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder$ModifyableColumnFamilyDescriptor.lambda$getStringOrDefault$0(ColumnFamilyDescriptorBuilder.java:708) at org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder$ModifyableColumnFamilyDescriptor.getOrDefault(ColumnFamilyDescriptorBuilder.java:716) at org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder$ModifyableColumnFamilyDescriptor.getStringOrDefault(ColumnFamilyDescriptorBuilder.java:708) at org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder$ModifyableColumnFamilyDescriptor.getDataBlockEncoding(ColumnFamilyDescriptorBuilder.java:805) at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:269) at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:5816) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1098) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1095) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) ... 3 more {noformat}" The delayed FlushRegionEntry should be removed when we need a non-delayed one,13362832,Resolved,Major,Fixed,07/Mar/21 07:56,18/Mar/21 19:15,,"The regionserver periodically check all the regions, if one not flushed for long time, then it will create a delayed FlushRegionEntry, the delay range is 0~300s. During the delay time, if many data are written to the region suddenly, we can not do the flush immediately due to the existing one in regionsInQueue, then the RegionTooBusyException will occur. It is better to improve the logic here, that the delayed entry should be replaced by the non-delayed one." Provide a switch that allows avoiding reopening all regions when modifying a table to prevent RIT storms.,13356638,Resolved,Major,Fixed,04/Feb/21 04:06,01/Dec/23 20:10,3.0.0-alpha-1,"Under normal circumstances, modifying a table will cause all regions belonging to the table to enter RIT. Imagine the following two scenarios： # Someone entered the wrong configuration （e.g. negative 'hbase.busy.wait.multiplier.max' value） when altering the table, causing thousands of online regions to fail to open, leading to online accidents. # Modify the configuration of a table, but this modification is not urgent, the regions are not expected to enter RIT immediately. -'alter_lazy' is a new command to modify a table without reopening any online regions except those regions were assigned by other threads or split etc.-   Provide an optional lazy_mode for the alter command to modify the TableDescriptor without the region entering the RIT. The modification will take effect when the region is reopened." Support separate child regions to different region servers,13352901,Resolved,Major,Fixed,17/Jan/21 14:42,18/Mar/21 19:41,,"Hot/Large regions can be splitted automatically by some split policies. But children regions will be both on the RS which owns the parent region. We can support dividing child regions from the master side, maybe add a step at the last of SplitTableRegionProcedure." BUG - HBase native client memory leak - threads keep running after connection is closed,13358830,Closed,Major,Incomplete,16/Feb/21 09:49,23/Jun/22 20:39,,"Hello everyone,  First of all, thank you for creating such an amazing product I'm trying to implement an open-source PHP-extension based on HBase native client. It seems more promising performance-wise than Thrifts we're currently using In terms of PHP-fpm, we need to be able to open and close connection multiple times in one process, and here's when the library leaks memory Calling 'Close' methods on Table and Clients is not enough for closing all of the threads. A simple program   {code:java} int main() {     zoo_set_debug_level( (ZooLogLevel)4);     google::SetCommandLineOption(""GLOG_minloglevel"", ""0"");     std::shared_ptr conf = std::make_shared();     conf->Set(hbase::ZKUtil::kHBaseZookeeperQuorum_, ""quorum"");     conf->Set(hbase::ZKUtil::kHBaseZookeeperClientPort_, ""2181"");     conf->Set(hbase::ZKUtil::kHBaseZnodeParent_, ""/hbase-unsecure"");     createClient(conf);       int i = 0;     while (true) {         i++;         std::cout << ""Slept "" << i << std::endl;         sleep(5);     }     return 0; } void createClient(const std::shared_ptr& conf) {     std::cout << ""opening "" << std::endl << std::endl << std::endl;     auto tn = std::make_shared(folly::to(""table""));     auto client = std::make_unique(*conf);     auto table = client->Table(*tn);     std::cout << ""closing "" << std::endl << std::endl << std::endl;     table->Close();     client->Close(); } {code}   Logs : {code:java} [julia@fdf346c7aa2b myhbase]$ ./myhbase opening WARNING: Logging before InitGoogleLogging() is written to STDERR I0216 08:54:44.391023  5259 location-cache.cc:77] Connecting to ZooKeeper. Quorum:quorum 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@726: Client environment:zookeeper.version=zookeeper C client 3.4.8 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@730: Client environment:host.name=fdf346c7aa2b 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@737: Client environment:os.name=Linux 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@738: Client environment:os.arch=5.8.1-1.el7.elrepo.x86_64 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@739: Client environment:os.version=#1 SMP Tue Aug 11 12:01:11 EDT 2020 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@747: Client environment:user.name=(null) 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@755: Client environment:user.home=/home/julia 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@log_env@767: Client environment:user.dir=/usr/src/hbase/myhbase 2021-02-16 08:54:44,391:5259(0x7fa88b38d3c0):ZOO_INFO@zookeeper_init@800: Initiating client connection, host=quorum sessionTimeout=90000 watcher=(nil) sessionId=0 sessionPasswd= context=(nil) flags=0 2021-02-16 08:54:44,400:5259(0x7fa88b38d3c0):ZOO_DEBUG@start_threads@221: starting threads... 2021-02-16 08:54:44,400:5259(0x7fa7a77fe700):ZOO_DEBUG@do_io@367: started IO thread 2021-02-16 08:54:44,400:5259(0x7fa7a6ffd700):ZOO_DEBUG@do_completion@459: started completion thread closing I0216 08:54:44.400823  5259 client.cc:56] called destructor on Client 2021-02-16 08:54:44,400:5259(0x7fa7a77fe700):ZOO_INFO@check_events@1728: initiated connection to server [192.168.197.12:2181] 2021-02-16 08:54:44,403:5259(0x7fa7a77fe700):ZOO_INFO@check_events@1775: session establishment complete on server [192.168.197.12:2181], sessionId=0x27640b8a9bd0932, negotiated timeout=60000 2021-02-16 08:54:44,403:5259(0x7fa7a77fe700):ZOO_DEBUG@check_events@1781: Calling a watcher for a ZOO_SESSION_EVENT and the state=ZOO_CONNECTED_STATE 2021-02-16 08:54:44,403:5259(0x7fa7a6ffd700):ZOO_DEBUG@process_completions@2132: Calling a watcher for node [], type = -1 event=ZOO_SESSION_EVENT I0216 08:54:44.403533  5259 table.cc:50] called destructor on Table Slept 1 Slept 2 Slept 3 Slept 4 Slept 5 2021-02-16 08:55:04,421:5259(0x7fa7a77fe700):ZOO_WARN@zookeeper_interest@1570: Exceeded deadline by 19ms 2021-02-16 08:55:04,421:5259(0x7fa7a77fe700):ZOO_DEBUG@zookeeper_process@2218: Got ping response in 0 ms Slept 6 Slept 7 Slept 8 Slept 9 2021-02-16 08:55:24,436:5259(0x7fa7a77fe700):ZOO_WARN@zookeeper_interest@1570: Exceeded deadline by 14ms 2021-02-16 08:55:24,436:5259(0x7fa7a77fe700):ZOO_DEBUG@zookeeper_process@2218: Got ping response in 0 ms Slept 10 Slept 11 Slept 12 {code} As you can see, after calling destructors on Table and Client, a connection to Zookeeper is still open, no other destructors are called. If I'm calling createClient()  function multiple times, I can see consumed memory is growing and being released only after the program exits   Best regards, Julia" Close region may stuck when region is compacting and skipped most cells read,13368325,Resolved,Major,Fixed,29/Mar/21 08:28,06/Mar/23 06:24,1.7.1,"We found in our cluster about stop region stuck. The region is compacting, and its store files has many TTL expired cells. Close region state marker(HRegion#writestate.writesEnabled) is not checked in compaction, because most cells were skipped.  !RS-region-state.png|width=698,height=310!   !Master-UI-RIT.png|width=693,height=157!   HBASE-23968 has encountered similar problem, but the solution in it is outer the method InternalScanner#next(List result, ScannerContext scannerContext), which will not return if there are many skipped cells, for current compaction scanner context. As a result, we need to return in time in the next method, and then check the stop marker.      " Should not use a byte array as a key of HashMap or an element of HashSet,13358474,Open,Major,,13/Feb/21 13:16,,,"I sometimes face the code where we use a byte array as a key of HashMap (ConcurrentHashMap) or an element of HashSet, which could cause very confusing bugs. The following code is an example where we use a byte array as a key of HashMap: https://github.com/apache/hbase/blob/326835e8372cc83092e0ec127650438ff153476a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceIdAccounting.java#L94 In Java, we can't use a byte array as a key of HashMap or an element of HashSet directly. One solution for it is to use TreeMap (ConcurrentSkipListMap) or TreeSet (ConcurrentSkipListSet) with Bytes.BYTES_COMPARATOR instead of HashMap and HashSet as follows: {code} Map map1 = new TreeMap<>(Bytes.BYTES_COMPARATOR); Map map2 = new ConcurrentSkipListMap<>(Bytes.BYTES_COMPARATOR); Set set1 = new TreeSet<>(Bytes.BYTES_COMPARATOR); Set set2 = new ConcurrentSkipListSet<>(Bytes.BYTES_COMPARATOR); {code} We should fix the existing ones in this Jira. " Document suggested settings for PressureAwareCompactionThroughputController,13362353,Open,Major,,04/Mar/21 17:59,,2.3.0,"After upgrading a cluster to 2.3, we noticed that compactions were taking much longer. We tracked this down to the {{PressureAwareCompactionThroughputController}}, which became default as part of our upgrade. Our default configuration settings set the lower bound: 50MB/s, upper bound: 100MB/s. These settings make sense if you have a 1gbit NIC (~120 MB/s). For a 10gbit NIC, they’re quite inadequate. Let's document this component explicitly and mention it as a call-out in the section on upgrading. Bonus points if we can provide suggested configuration values for the common networking configurations." "When unconfigured, PressureAwareCompactionThroughputController should sniff NIC speed and use appropriate settings",13362357,Open,Major,,04/Mar/21 18:01,,,"After upgrading a cluster to 2.3, we noticed that compactions were taking much longer. We tracked this down to the PressureAwareCompactionThroughputController, which became default as part of our upgrade. Our default configuration settings set the lower bound: 50MB/s, upper bound: 100MB/s. These settings make sense if you have a 1gbit NIC (~120 MB/s). For a 10gbit NIC, they’re quite inadequate. Suggestion: instead of using fixed values as the default for these configurations, we should sniff the NIC speed and configure for an optimal value according to available bandwidth." "[JDK17] reflective access Field.class.getDeclaredField(""modifiers"") not supported",13352682,Resolved,Major,Fixed,16/Jan/21 15:06,24/Jan/23 15:27,2.3.3,"The reflective access {code:java} Field.class.getDeclaredField(""modifiers"") {code} in HFileSystem.java:334 leads to a warning (and probably error?):   {code:java} java.lang.NoSuchFieldException: modifiers at java.base/java.lang.Class.getDeclaredField(Class.java:2417) at org.apache.hadoop.hbase.fs.HFileSystem.addLocationsOrderInterceptor(HFileSystem.java:334) at org.apache.hadoop.hbase.fs.HFileSystem.addLocationsOrderInterceptor(HFileSystem.java:291) at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:96) at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465) at org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3330) at org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:565) at org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:554) at org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:527) at org.apache.hadoop.hbase.HBaseTestingUtility.getDefaultRootDirPath(HBaseTestingUtility.java:1415) at org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1446) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1157) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1144) at foo.Main.main(Main.java:11) {code} when running the following code:   {code:java} public static void main(String[] args) throws Exception { HBaseTestingUtility utility = new HBaseTestingUtility(HBaseConfiguration.create()); utility.startMiniCluster(StartMiniClusterOption.builder().numRegionServers(3).build()); }{code} From my knowledge this results from the more restrictive reflection protection of java.base classes in the newer java versions.   Related to HBASE-22972  " Sync WAL stuck when prepare flush cache will prevent flush cache and cause OOM,13368861,Resolved,Major,Won't Fix,31/Mar/21 11:52,07/Mar/22 12:27,1.4.13,"We call HRegion#doSyncOfUnflushedWALChanges when preparing to flush cache. But this WAL sync may stuck, and abort the flush of cache.  !prepare-flush-cache-stuck.png|width=519,height=246! If we cannot aware of this problem in time, RS will OOM kill. I think we should force abort RS when sync stuck in preparing, like in committing snapshots.    " RoundRobinTableInputFormat,13358241,Resolved,Major,Fixed,11/Feb/21 21:24,12/Mar/21 05:23,,"[~huaxiang] figured we needed a round robin on the result returned out TableInputFormat to better distribute task on a production cluster at our place-of-employ. This seems to be an old problem. See this helpful, old Flipkart blog: https://tech.flipkart.com/is-data-locality-always-out-of-the-box-in-hadoop-not-really-2ae9c95163cb" StochasticBalancer CostFunctions needs a better way to evaluate region count distribution,13361946,Open,Major,,02/Mar/21 19:57,,,"Currently CostFunctions including RegionCountSkewCostFunctions, PrimaryRegionCountSkewCostFunctions and all load cost functions calculate the unevenness of the distribution by getting the sum of deviation per region server. This simple implementation works when the cluster is small. But when the cluster get larger with more region servers and regions, it doesn't work well with hot spots or a small number of unbalanced servers. The proposal is to use the standard deviation of the count per region server to capture the existence of a small portion of region servers with overwhelming load/allocation. TableSkewCostFunction uses the sum of the max deviation region per server for all tables as the measure of unevenness. It doesn't work in a very common scenario in operations. Say we have 100 regions on 50 nodes, two on each. We add 50 new nodes and they have 0 each. The max deviation from the mean is 1, compared to 99 in the worst case scenario of 100 regions on a single server. The normalized cost is 1/99 = 0.011 < default threshold of 0.05. Balancer wouldn't move.  The proposal is to use the standard deviation of the count per region server to detect this scenario, generating a cost of 3.1/31 = 0.1 in this case. Patch is in test and will follow shortly." StochasticBalancer improvement for large scale clusters,13367662,Open,Major,,25/Mar/21 17:10,,,"h2. Findings on a large scale cluster (100,000 regions on 300 nodes) * Balancer starts and stops before getting a plan * Adding new racks doesn’t trigger balancer * Balancer stops leaving some racks at 50% lower region counts * Regions for large tables don’t get evenly distributed * Observability is poor * Too many knobs makes tuning empirical and takes many experiments h2. Improvements made and being made * Cost function enhancement to capture outliers especially table skew. https://issues.apache.org/jira/browse/HBASE-25625?filter=-2  * Explain why balancer stops https://issues.apache.org/jira/browse/HBASE-25666 will back port too https://issues.apache.org/jira/browse/HBASE-24528 h2. More proposals * minCostNeedBalance for each cost function instead of weights. We want to trigger balancing if any factor is out of balancer instead of trying to combine the factors in arbitrary weights. This makes operation and configuration much easier. * Simulated annealing to lower minCostNeedBalance periodically to unstuck the balancer from sub-optimum then gradually increase to keep the system stable. Also add cost of move as a counter measure for the decision [https://opensourcelibs.com/lib/tempest] * Orchestrated scheduling of compaction, normalizer and balancer * PID approach [https://www.amazon.com/dp/1449361692/ref=rdr_ext_tmb]" Adding replication peer should handle the undeleted queue exception,13365090,Resolved,Major,Won't Fix,14/Mar/21 19:06,02/Aug/22 09:05,,"Currently, if we try to add a peer and there is a replication queue existing for that peer, it doesn't let the replication peer created.  Instead, we should delete the queue and proceed with the creating of replication peer. Any queue without no corresponding replication peer is useless anyway. So, we shouldn't wait for cleaner to come and clean it before creating the peer.    {code:java} org.apache.hadoop.hbase.replication.ReplicationException: undeleted queue for peerId: xyz_peerid, replicator: hostname.fakeaddress.com,60020,1607576586258, queueId: xyz_peerid java.lang.RuntimeException: org.apache.hadoop.hbase.replication.ReplicationException: undeleted queue for peerId: xyz_peerid, replicator: hostname.fakeaddress.com,60020,1607576586258, queueId: xyz_peerid {code}" The configured loggers in log4j2.xml will always be created,13368565,Closed,Major,Fixed,30/Mar/21 07:53,09/Apr/21 03:48,,"No matter whether they are referenced. So we will always create RFA log files even if we are using console appender, and since the default location for http request log is /var/log/hbase, we do not always have permission to create directory at this place so it may cause failure for UTs. We need to find a way to fix this problem." Need to initialize SLF4JBridgeHandler in jul-to-slf4j for redirecting jul to slf4j,13367506,Closed,Major,Fixed,25/Mar/21 08:58,03/Apr/21 15:05,,"When testing HBASE-22120 with logging exporter, the trace log messages were all redirected to console... They use jul to log the spans and we have jul-to-slf4j on classpath. Then I found out that we need to call SLF4JBridgeHandler.install... Let me find a way to do this." Bound LoadBalancer's RegionLocationFinder cache,13361715,Resolved,Major,Won't Fix,02/Mar/21 00:29,11/Jun/22 23:39,1.6.0,"We have a large table in production that causes the balancer's RegionLocationFinder cache to consume 4 GB of heap, which, among other factors, triggered OOMEs, and made us aware of this problem. RegionLocationFinder embeds a cache backed by Guava's CacheLoader. The RegionLocationFinder cache comes to consume heap for RegionInfos for all table regions and all HDFS block locations of all store files for all regions of all tables. The only limit we pass to the CacheBuilder is an expiration time of 14400000 milliseconds for individual cache entries. That's 4 hours. That's much too long; however, the cache also periodically refreshes itself, where the need for a refresh is checked whenever BaseLoadBalancer calls RegionLocationFinder's setClusterMetrics() method, which defeats the expiration based limit anyway. We should be bounding this cache with effective resource controls. Time based expiry is fine but the periodic refresh logic must be removed to make it effective. Implement size based limits too. CacheBuilder#maximumSize will limit by number cache entries. This might be fine but CacheBuilder#maximumWeight would be better, where weight is something determined by the API user. In this case it can be an estimate of the heap size of the hash map entries kept in the cache. Default should remain unbounded. Specific bounds should be supported by new site configuration options. " ZK watcher threads are daemonized; reconsider,13352132,Resolved,Major,Not A Problem,14/Jan/21 02:09,11/Jun/22 21:10,,"On HBASE-25279 there was some discussion and difference of opinion about having ZK watcher pool threads be daemonized. This is not necessarily a problem but should be reconsidered. Daemon threads are subject to abrupt termination during JVM shutdown and therefore may be interrupted before state changes are complete or resources are released. As long as ZK watchers are properly closed by shutdown logic the pool threads will be terminated in a controlled manner and the JVM will exit. " Add a switch for server/table queryMeter,13366241,Resolved,Major,Fixed,19/Mar/21 04:25,19/Mar/21 23:38,, "when the cluster has many tables, UI can't be opened quickly",13349031,Open,Major,,05/Jan/21 01:53,,3.0.0-alpha-1,"my cluster has 60+K tables, and UI is opened slowly. From the following code, we can reduce steps of class conversion rsgroup.jsp https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/rsgroup.jsp#L439 snapshot.jsp https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/resources/hbase-webapps/master/snapshot.jsp#L42 RegionStates.java https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L538 RSStatusTmpl.jamon https://github.com/apache/hbase/blob/600be60a4bd4d3b3e9652027a0cb8bdd32016c6b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon#L47" "Backport ""HBASE-25681 Add a switch for server/table queryMeter"" to branch-2 and branch-1",13366467,Resolved,Major,Fixed,20/Mar/21 05:32,07/Apr/21 18:12,, release hbase-thirdparty 3.5.0,13357154,Resolved,Major,Fixed,05/Feb/21 18:39,21/Feb/21 22:52,,"make a release for hbase-thirdparty off of the current master branch. Since HBASE-24802 adds a new dependency artifact we should increment the minor version number, which gives us a proposed version of 3.5.0." [hbase-thirdparty] Update jetty version to fix CVE-2020-27218,13356913,Resolved,Major,Fixed,05/Feb/21 06:07,06/Feb/21 22:27,,"CVE-2020-27218 obseved in 9.4.0.RC0 to 9.4.34.v20201102, 10.0.0.alpha0 to 10.0.0.beta2, and 11.0.0.alpha0 to 11.0.0.beta2. Currently we are using 9.4.34.v20201102, https://github.com/apache/hbase-thirdparty/blob/a8e3629618642fd50daa31cc027bc674ab659711/pom.xml#L139 " "After hbase-thirdparty 3.4.1 release, set next dev version",13352402,Resolved,Major,Fixed,15/Jan/21 04:38,18/Jan/21 13:59,hbase-thirdparty-3.4.2, hbase thirdparty jdk bytecode enforcement shouldn't check test dependencies,13357440,Resolved,Major,Fixed,08/Feb/21 04:11,09/Feb/21 06:56,hbase-thirdparty-3.5.0,"while staging a 3.5.0 RC the build failed when deploying a staged nexus repo for the hbase-noop-htrace module because the test dependency on hbase 2 fails the maven enforcer check for jdk7 compatibility. since the jdk compatibility for the artifacts we generate in hbase-thirdparty isn't impacted by test scope dependency or optional dependencies, we shouldn't check them in the enforcer rule." Support hbase rpc compression for remote rpc only,13362686,Open,Major,,05/Mar/21 19:38,,2.3.4,"The purpose of Rpc compression is to save network bandwidth. For local communication (both hbase client and RS are on the same node), rpc compression is unnecessary as local communication is memory copy only and does not go through nic. Rpc compression for local communication will be a waste of cpu computation power as compress/decompress is cpu intensive. " Fix HBASE-22492 on branch-2 (SASL GapToken),13359258,Resolved,Major,Fixed,18/Feb/21 09:31,26/Feb/21 13:07,2.2.6,"The issue is also exist on branch-2. {noformat} 17:27:41.556 [pool-1-thread-8] WARN org.apache.hadoop.hbase.client.ScannerCallable - Ignore, probably already closed. Current scan: {""startRow"":""19999999"",""stopRow"":"""",""batch"":20,""cacheBlocks"":true,""totalColumns"":0,""maxResultSize"":""2097152"",""families"":{},""caching"":2147483647,""maxVersions"":1,""timeRange"":[""0"",""9223372036854775807""]} on table: cluster_test javax.security.sasl.SaslException: Call to XXX/172.27.162.2:22101 failed on local exception: javax.security.sasl.SaslException: Gap token at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:224) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:383) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:89) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:414) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:410) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:117) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:132) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.cleanupCalls(NettyRpcDuplexHandler.java:203) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.exceptionCaught(NettyRpcDuplexHandler.java:220) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:302) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:281) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireExceptionCaught(AbstractChannelHandlerContext.java:273) at org.apache.hbase.thirdparty.io.netty.channel.ChannelInboundHandlerAdapter.exceptionCaught(ChannelInboundHandlerAdapter.java:143) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:302) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:381) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:324) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:296) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) at org.apache.hbase.thirdparty.io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:714) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:650) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:576) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:748) Caused by: javax.security.sasl.SaslException: Gap token at com.sun.security.sasl.gsskerb.GssKrb5Base.checkMessageProp(GssKrb5Base.java:142) at com.sun.security.sasl.gsskerb.GssKrb5Base.unwrap(GssKrb5Base.java:81) at org.apache.hadoop.hbase.security.SaslUnwrapHandler.channelRead0(SaslUnwrapHandler.java:52) at org.apache.hadoop.hbase.security.SaslUnwrapHandler.channelRead0(SaslUnwrapHandler.java:33) at org.apache.hbase.thirdparty.io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ... 20 common frames omitted {noformat} The is can be reproduced with the attached code. {{hbase.rpc.protection}} must be set to {{integrity}} or {{privacy}}." "Shell commands should accept ""hbase:meta"" as an alias for the encoded region name",13361699,In Progress,Major,,01/Mar/21 22:10,,2.3.0,"Simple one: the shell should accept the alias ""meta"" in place of the encoded region name. It's a little silly to have to say {{> move '1588230740', 'host, port,startcode'}}." Utility to identify git commit / Jira fixVersion discrepancies for RC preparation,13352475,Open,Major,,15/Jan/21 12:29,,,"As part of RC preparation,  we need to identify all git commits that landed on release branch, however their corresponding Jira is either not resolved yet or does not contain expected fixVersions. Only when we have git commits and corresponding Jiras with expected fixVersion resolved, we get all such Jiras included in auto-generated CHANGES.md as per Yetus changelog generator. Proposal of this Jira is to provide such script that can be useful for all upcoming RC preparations and list down all Jiras where we need manual intervention. This utility script should use Jira API to retrieve individual fields and use git log to loop through commit history. The script should identify these issues: # commit is reverted as per commit message # commit does not contain Jira number format HBASE-XXXX in message # Jira does not have expected fixVersion # Jira has expected fixVersion, but it is not yet resolved It can take inputs as: # First commit hash to start excluding commits from history # Fix Version # JIRA Project Name # Path of project's working dir # Jira server url The script should also identify all Jiras that are marked resolved with given fixVersion but have no commit present with Jira number included. RC preparation also needs to find this diff because we don't want to provide extra Jira in CHANGELOG without any corresponding commits present on git (unless it is svn checkin and fixVersion is relevant)." [Branch-2 and Master]Handle the NoNode exception in remove log replication in a better way then just log WARN,13361279,Open,Major,,26/Feb/21 21:39,,2.5.0,"Currently, when we see the NoNodeException in the replication source while removing a log from ZK, we swallow that exception and log WARN.    In certain cases, we might have the peer removed and corresponding logs removing as well but the replication source continuous to run because of an RPC failure or anything.  In stead of just log WARN we should check if the peer is removed, if it is the case, we should terminate the source or try to execute the removePeer workflow again.   This would prevent the orphaned source execution infinitely. " Regionserver cannot exit completely ,13362288,Resolved,Major,Won't Fix,04/Mar/21 11:35,02/Dec/21 09:43,1.4.7,"When regionserver abort by some errors, the process cannot exit completely. Error logs and jstack of regionserver process are as follows,   !1614857532776-image.png|width=823,height=364! * !1614845335795-image.png|width=532,height=330!" Support parallel balance RSGroups,13352900,Resolved,Major,Won't Fix,17/Jan/21 14:36,04/Nov/21 12:05,,"When we call balanceRSGroup(), it waits for the lock of balancer, which may be occupied by the overall cluster balance(). Sometimes the balance of cluster will take a long time because it need to compute the costs or act the balance region plans.  In RSGroup, we don't need to block a balance of one group due to other group balances.  All group are mini clusters, and the balance of their regions should support concurrently execution and reduce the race conditions between them." RegionServer JVM crash when append wal entry,13368048,Open,Major,,27/Mar/21 03:57,,2.2.6,"Region Server JVM crash when append wal entry,  JVM crash log: # # A fatal error has been detected by the Java Runtime Environment: # # EXCEPTION_ACCESS_VIOLATION (0xc0000005) at pc=0x00000000027af93f, pid=17992, tid=0x0000000000002d54 # # JRE version: Java(TM) SE Runtime Environment (8.0_202-b08) (build 1.8.0_202-b08) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.202-b08 mixed mode windows-amd64 compressed oops) # Problematic frame: # J 10214 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.getFamilyLength()B (9 bytes) @ 0x00000000027af93f [0x00000000027af860+0xdf] " Upgrade opentelemetry to 1.0.0,13361340,Resolved,Major,Fixed,27/Feb/21 09:56,10/Mar/21 07:29,, Revisit the span names,13361397,Resolved,Major,Fixed,28/Feb/21 01:35,08/Mar/21 15:15,,"We use getSimpleName for most cases but still have some places where we use getName, let's change them to getSimpleName as well." Upgrade opentelemetry to 0.17.1,13359869,Resolved,Major,Fixed,21/Feb/21 05:52,26/Feb/21 09:28,, Set span kind to CLIENT in AbstractRpcClient,13354976,Resolved,Major,Fixed,27/Jan/21 16:13,28/Jan/21 15:00,, Add trace support for WAL sync,13351113,Resolved,Major,Fixed,08/Jan/21 16:02,22/Jan/21 02:18,,I think this is the most important part for WAL operations. Other things such as append and operation in background thread is a nice to have. Add host and port attribute when tracing rpc call at client side,13351003,Resolved,Major,Fixed,08/Jan/21 03:32,08/Jan/21 09:12,, Fix or stop warning about already cached block,13362725,Resolved,Major,Fixed,05/Mar/21 22:37,31/Aug/21 16:28,2.3.0,"Our logs have as a fairly common occurrence: {noformat} 2021-03-05 22:24:31,034 WARN [StoreFileOpener-foo-1] hfile.BlockCacheUtil: Caching an already cached block: blah.bub. This is harmless and can happen in rare cases (see HBASE-8547) {noformat} If this is really harmless, why do we log? If it's not actually harmless, let's take another pass at fixing this situation." Explain why balancer is skipping runs,13365323,Resolved,Major,Fixed,15/Mar/21 18:54,04/Jun/21 22:27,,"Balancer needs to find the balance of keeping cluster balanced and stable. There is a configuration minCostNeedBalance as the threshold of imbalance to try to balance. Since we use a single score to combine all the factors we consider, it is hard for operation to understand why balancer is ""stuck"". We should add to master-status UI to show balancer is skipping runs and explain all factors considered, such as the weight and cost of all cost functions.  " HBase Connectors pom should include nexus staging repo management,13358505,Resolved,Major,Fixed,13/Feb/21 22:32,24/Aug/21 09:08,,"The current RC creation scripts rely on project poms having a plugin configured to handle nexus staging repository closing / dropping. The hbase-connectors project is currently missing this plugin, which makes it so that a RM has to go manually close the staging repository and then copy the location into the generated vote text. the needed plugin config is: {code} apache-release org.sonatype.plugins nexus-staging-maven-plugin 1.6.8 true https://repository.apache.org/ apache.releases.https {code}" NORMALIZER_TARGET_REGION_SIZE needs a unit in its name,13363389,Resolved,Major,Fixed,09/Mar/21 22:58,04/Aug/21 15:23,2.3.0,"On a per-table basis, the normalizer can be configured with a specific region size target via {{NORMALIZER_TARGET_REGION_SIZE}}. This value is used in a context where size values are in the megabyte scale. However, this configuration name does not mention ""megabyte"" or ""mb"" anywhere, so it's very easy for an operator to get the configured value wrong by many orders of magnitude." Link to the filter on hbase:meta from user tables panel on master page,13367430,Resolved,Major,Fixed,25/Mar/21 04:44,28/Mar/21 03:38,,"This is follow-on to the parent issue that added nice filtering mechanism on hbase:meta table. Parent allows finding all Regions in Table XYZ with state OPENING or FAILED_CLOSED. The user table panel on the master home page has counts of Regions in each state. The opening and closing counts actually have links under them but they are useless currently as they only show RITs that are CLOSING or OPENING; good but not comprehensive enough. This PR adds links under all counts so you can see all CLOSING Regions whether RIT or not; useful when doing fixup on a corrupt cluster. Adds a bit of help text that tells users about the filter-on-meta feature too. Here is how the panel currently looks: !image-2021-03-24-21-41-11-393.png! Here is what it looks like now with the bit of help text !image-2021-03-24-21-42-16-355.png! When you click on the CLOSED number -- '1' in this case -- this where you go to: !image-2021-03-24-21-43-24-426.png! i..e. lists all Regions in the TestTable that are in the CLOSED state (not very pretty with the 'Table Stats' and 'Table Regions' preamble but better than what was there before). " Release 2.2.7,13356151,Resolved,Major,Done,02/Feb/21 09:43,03/Aug/21 12:03,,"As discussed in [https://s.apache.org/7rqow] , the stable pointer had been moved to 2.3.x and the final release for 2.2.x will be 2.2.7." Specify and document the criteria for moving the 'stable' pointer,13366786,Open,Major,,22/Mar/21 17:09,,,"We can consider reported experience with new code lines released ahead of where the stable pointer currently points, when and if it happens but this should not be a formal criteria because it has nothing directly to do with our PMC or project. We need a criteria for deciding when new code lines are sufficiently stable as to warrant moving the 'stable' pointer that we as project and PMC can achieve and implement effectively. IMHO ""one of our project devs has it running"" does not meet that requirement, because this depends on third party organizations (a dev's employer, and such) and idiosyncratic criteria. Collect and document requirements, test scenarios, and success (and failure) criteria." Misleading Range metrcis ,13355345,Open,Major,,29/Jan/21 05:52,,2.3.0,"Found some cases that max value is included in a smaller range, which is confusing. Please see the attach file. The max is 7032, however, it cannot be found in the timeRange report. The issue is that it is included in the 1000~3000 range. In this case, the time range should be 1000 - infinite. " Change ChoreService and ScheduledChore to IA.Private,13353559,Resolved,Major,Fixed,20/Jan/21 15:39,22/Jul/21 16:00,,"Follow up issue for HBASE-25509. We are not providing a general scheduling library, so these two classes should not be IA.Public. User can just use other more powerful scheduling libraries." Persistent IllegalReferenceCountException at scanner open when using TinyLfuBlockCache,13367704,Resolved,Major,Fixed,25/Mar/21 20:33,21/Jun/21 07:53,2.4.2,"Persistent scanner open failure with offheap read path enabled. Not sure how it happened. Test scenario was HBase 1 cluster replicating to HBase 2 cluster. ITBLL as data generator at source, calm policy only. Scanner open errors on sink HBase 2 cluster later during ITBLL verify phase. Sink schema settings bloom=ROW encoding=FAST_DIFF compression=NONE. {noformat} Caused by: org.apache.hbase.thirdparty.io.netty.util.IllegalReferenceCountException: refCnt: 0, decrement: 1 at org.apache.hbase.thirdparty.io.netty.util.internal.ReferenceCountUpdater.toLiveRealRefCnt(ReferenceCountUpdater.java:74) at org.apache.hbase.thirdparty.io.netty.util.internal.ReferenceCountUpdater.release(ReferenceCountUpdater.java:138) at org.apache.hbase.thirdparty.io.netty.util.AbstractReferenceCounted.release(AbstractReferenceCounted.java:76) at org.apache.hadoop.hbase.nio.ByteBuff.release(ByteBuff.java:79) at org.apache.hadoop.hbase.io.hfile.HFileBlock.release(HFileBlock.java:429) at org.apache.hadoop.hbase.io.hfile.CompoundBloomFilter.contains(CompoundBloomFilter.java:109) at org.apache.hadoop.hbase.regionserver.StoreFileReader.checkGeneralBloomFilter(StoreFileReader.java:433) at org.apache.hadoop.hbase.regionserver.StoreFileReader.passesGeneralRowBloomFilter(StoreFileReader.java:322) at org.apache.hadoop.hbase.regionserver.StoreFileReader.passesBloomFilter(StoreFileReader.java:251) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.shouldUseScanner(StoreFileScanner.java:491) at org.apache.hadoop.hbase.regionserver.StoreScanner.selectScannersFrom(StoreScanner.java:471) at org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:249) at org.apache.hadoop.hbase.regionserver.HStore.createScanner(HStore.java:2177) at org.apache.hadoop.hbase.regionserver.HStore.getScanner(HStore.java:2168) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.initializeScanners(HRegion.java:7172) {noformat} Bloom filter type on all files here is ROW, block encoding is FAST_DIFF: {noformat} hbase:017:0> describe ""IntegrationTestBigLinkedList"" Table IntegrationTestBigLinkedList is ENABLED IntegrationTestBigLinkedList COLUMN FAMILIES DESCRIPTION {NAME => 'big', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'FAST_DIF F', COMPRESSION => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '1'} {NAME => 'meta', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'FAST_DI FF', COMPRESSION => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '1'} {NAME => 'tiny', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'FAST_DI FF', COMPRESSION => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '1'} {noformat}" Support conditional update in MultiRowMutationEndpoint,13368079,Resolved,Major,Duplicate,27/Mar/21 09:59,27/Mar/21 10:00,,"In some use cases, I think it will be useful that we can perform conditional update in MultiRowMutationEndpoint. In this Jira, we can add support conditional update in MultiRowMutationEndpoint." Add metric for age of oldest wal in region server replication queue.,13351805,Resolved,Major,Duplicate,12/Jan/21 15:59,08/Feb/21 19:08,,We have seen cases recently where we have wal from 2018 timestamp in our recovered replication queue. We came across this un replicated wal while debugging something else. We need to have metrics for the oldest wal in the replication queue and have alerts if it exceeds some threshold. Clearly 2 years old wal is not desirable. "[create-release] checkcompatibility.py failing with ""KeyError: 'binary'""",13350811,Resolved,Major,Fixed,07/Jan/21 06:46,08/Jan/21 22:48,,"Below is excerpt from log of RC0 2.3.4 build this afternoon when we try to do the compatibility check (inside docker create-release build). It had failed for me previously on another run of different versions. The failure is unfortunately cryptic. {code} 2021-01-07T01:08:34Z generate_api_report start INFO:root:Source revision: rel/2.3.3 INFO:root:Destination revision: 2.3.4RC0 INFO:root:Filtering classes using 1 annotation(s): INFO:root: org.apache.yetus.audience.InterfaceAudience.Public INFO:root:Downloading Java ACC... INFO:root:Java ACC version: 2.4 INFO:root:Removing scratch dir /home/vagrant/hbase-rm/output/hbase/target/compat-check INFO:root:Creating empty scratch dir /home/vagrant/hbase-rm/output/hbase/target/compat-check INFO:root:Checking out 5f7fe66efbdfc1c0b3262c0677f17e4055ba94cd in /home/vagrant/hbase-rm/output/hbase/target/compat-check/src INFO:root:Checking out ec79612b9ac6afd73fa8fc7f7f5c8d3bac277679 in /home/vagrant/hbase-rm/output/hbase/target/compat-check/dst INFO:root:Building in /home/vagrant/hbase-rm/output/hbase/target/compat-check/src INFO:root:Building in /home/vagrant/hbase-rm/output/hbase/target/compat-check/dst INFO:root:Will check compatibility between original jars: /home/vagrant/hbase-rm/output/hbase/target/compat-check/src/hbase-shaded/hbase-shaded-client-byo-hadoop/target/original-hbase-shaded-client-byo-hadoop-2.3.3.jar /home/vagrant/hbase-rm/output/hbase/target/compat-check/src/hbase-external-blockcache/target/hbase-external-blockcache-2.3.3.jar /home/vagrant/hbase-rm/output/hbase/target/compat-check/src/hbase-shaded/hbase-shaded-client/target/original-hbase-shaded-client-2.3.3.jar /home/vagrant/hbase-rm/output/hbase/target/compat-check/src/hbase-zookeeper/target/hbase-zookeeper-2.3.3.jar /home/vagrant/hbase-rm/output/hbase/target/compat-check/src/hbase-common/target/hbase-common-2.3.3.jar .... /home/vagrant/hbase-rm/output/hbase/target/compat-check/dst/hbase-shaded/hbase-shaded-testing-util-tester/target/hbase-shaded-testing-util-tester-2.3.4.jar /home/vagrant/hbase-rm/output/hbase/target/compat-check/dst/hbase-archetypes/hbase-shaded-client-project/target/hbase-shaded-client-project-2.3.4.jar /home/vagrant/hbase-rm/output/hbase/target/compat-check/dst/hbase-protocol/target/hbase-protocol-2.3.4.jar INFO:root:Annotations are: ['org.apache.yetus.audience.InterfaceAudience.Public'] INFO:root:Annotations path: /home/vagrant/hbase-rm/output/hbase/target/compat-check/annotations.txt INFO:root:Results: {} Traceback (most recent call last): File ""./hbase/dev-support/checkcompatibility.py"", line 530, in main() File ""./hbase/dev-support/checkcompatibility.py"", line 526, in main args.compare_warnings)) File ""./hbase/dev-support/checkcompatibility.py"", line 232, in compare_results if tool_results[check][issue_type] > known_count] {code}" Exclude CHANGES and RELEASENOTES files from source control,13353316,Open,Major,,19/Jan/21 16:18,,,"Over on the thread [Project management (JIRA fix version tracking) is in crisis |https://lists.apache.org/thread.html/r8db075fd974de32a90174be2db106ef710cf38cfde9ea9071fda4152%40%3Cdev.hbase.apache.org%3E], one of the suggested improvements to our process is to remove the CHANGES and RELEASENOTES files from version control. To accomplish this, we'll need to * delete existing files from existing branches * modify the release automation to not commit this files * find someplace to deliver these files on the web" Server+table counters on each scan #nextRaw invocation becomes a bottleneck when heavy load,13365995,Resolved,Major,Fixed,18/Mar/21 05:36,18/Mar/21 18:48,2.3.2,"On a heavily loaded server mostly doing reads/scan, I saw that 90+% of handlers were BLOCKED in this fashion in thread dumps: {code} ""RpcServer.default.FPBQ.Fifo.handler=117,queue=17,port=16020"" #161 daemon prio=5 os_prio=0 tid=0x00007f748757f000 nid=0x73e9 waiting for monitor entry [0x00007f74783e0000] java.lang.Thread.State: BLOCKED (on object monitor) at java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1674) - waiting to lock <0x00007f7647e3cc38> (a java.util.concurrent.ConcurrentHashMap$Node) at org.apache.hadoop.hbase.regionserver.MetricsTableQueryMeterImpl.getOrCreateTableMeter(MetricsTableQueryMeterImpl.java:80) at org.apache.hadoop.hbase.regionserver.MetricsTableQueryMeterImpl.updateTableReadQueryMeter(MetricsTableQueryMeterImpl.java:90) at org.apache.hadoop.hbase.regionserver.RegionServerTableMetrics.updateTableReadQueryMeter(RegionServerTableMetrics.java:89) at org.apache.hadoop.hbase.regionserver.MetricsRegionServer.updateReadQueryMeter(MetricsRegionServer.java:274) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6742) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3319) - locked <0x00007f896c0165a0> (a org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3566) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:44858) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {code} It kept up for good periods of time. I saw it to a leser extent on other servers, with less load. These RS had 400+ Regions a good few of which were serving out scan reads; the server was doing ~1M hits a second. In this scenario, I saw the above bottleneck. Looking at it, it came in w/ when the parent issue feature was added. There are these read counts and then there were also write counts. The write counts are mostly batch-based. Let me do same thing here for the read.... update the central server+table count after scan is done rather than per invocation of #nextRaw." Support conditional update in MultiRowMutationEndpoint,13368078,Resolved,Major,Fixed,27/Mar/21 09:59,30/Mar/21 14:21,,"In some use cases, I think it will be useful that we can perform conditional update in MultiRowMutationEndpoint. In this Jira, we can add support conditional update in MultiRowMutationEndpoint." Complete the work on moving all the balancer related classes to hbase-balancer module,13363176,Resolved,Major,Fixed,09/Mar/21 06:21,31/May/21 15:35,,"This is the follow up issue of HBASE-23933, where we set up the new hbase-balancer module and moved several classes into it." Region Servers should give some indication that short-circuit reads are configured properly and working,13353833,Open,Major,,21/Jan/21 19:56,,2.3.0,"Going through the exercise of confirming short-circuit reads turns out to be quite a chore. 2.3.0 added a new metric, but metrics only get tickled when there's traffic that happens to use the feature. This is not very convenient for an operator who has taken a cluster out of service for maintenance. It would be nice if the rs process could perform some test and emitted some confirmation of the status of this otherwise transparent feature. After confirmation, it could light up a boolean metric value and/or add mention of it to the info page." It is better for ReplicationTracker.getListOfRegionServers to return ServerName instead of String,13356921,Resolved,Major,Fixed,05/Feb/21 06:30,07/Feb/21 11:15,, Honor TableDescriptor settings earlier in normalization,13354860,Resolved,Major,Fixed,27/Jan/21 08:39,25/May/21 15:24,2.4.2,"-Table can be enabled and disabled merge/split in TableDescriptor, we should judge before calculating the plan.- The normalizer configuration can be set by table level. For example, hbase.normalizer.min.region.count can be set by ""alter ‘table’, CONFIGURATION=>\{'hbase.normalizer.min.region.count' => '5'}"". If the table is not set, then use the global configuration which is set in hbase-site.xml." "When the table is turned on normalize, the first region may not be merged even the size is 0",13352454,Resolved,Major,Fixed,15/Jan/21 10:01,25/May/21 00:27,2.4.1,"Suppose a table has 8 regions, the sizes are [0, 10, 1, 0, 9, 0, 12, 0], the average region size is 4, and split is disabled. The current Normalizer can only get three merge plans (use size to represent region): [1, 0], [9, 0],[12, 0] It can not merge the first region, even it's size is 0." Add a new command to update the configuration of all RSs in a RSGroup,13366294,Resolved,Major,Fixed,19/Mar/21 09:23,21/May/21 17:20,2.5.0,Now we support hot update a subset of configuration on a server or all server. Sometimes we may be necessary to hot update the configuration according to a rsgroup. HMaster should abort if ReplicationLogCleaner is not able to delete oldWALs.,13361215,Resolved,Major,Fixed,26/Feb/21 15:48,06/May/21 15:30,1.6.0,"In our production cluster, we encountered an issue where the number of files within /hbase/oldWALs directory were growing exponentially from about 4000 baseline to 150000 and growing at the rate of 333 files per minute. On further investigation we found that ReplicatonLogCleaner thread was getting aborted since it was not able to talk to zookeeper. Stack trace below {noformat} 2021-02-25 23:05:01,149 WARN [an-pool3-thread-1729] zookeeper.ZKUtil - replicationLogCleaner-0x3000002e05e0d8f, quorum=zookeeper-0:2181,zookeeper-1:2181,zookeeper-2:2181,zookeeper-3:2181,zookeeper-4:2181, baseZNode=/hbase Unable to get data of znode /hbase/replication/rs org.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode = Session expired for /hbase/replication/rs at org.apache.zookeeper.KeeperException.create(KeeperException.java:130) at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1229) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getData(RecoverableZooKeeper.java:374) at org.apache.hadoop.hbase.zookeeper.ZKUtil.getDataNoWatch(ZKUtil.java:713) at org.apache.hadoop.hbase.replication.ReplicationQueuesClientZKImpl.getQueuesZNodeCversion(ReplicationQueuesClientZKImpl.java:87) at org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner.loadWALsFromQueues(ReplicationLogCleaner.java:99) at org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner.getDeletableFiles(ReplicationLogCleaner.java:70) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteFiles(CleanerChore.java:262) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.access$200(CleanerChore.java:52) at org.apache.hadoop.hbase.master.cleaner.CleanerChore$3.act(CleanerChore.java:413) at org.apache.hadoop.hbase.master.cleaner.CleanerChore$3.act(CleanerChore.java:410) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.deleteAction(CleanerChore.java:481) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.traverseAndDelete(CleanerChore.java:410) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.access$100(CleanerChore.java:52) at org.apache.hadoop.hbase.master.cleaner.CleanerChore$1.run(CleanerChore.java:220) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) 2021-02-25 23:05:01,149 WARN [an-pool3-thread-1729] master.ReplicationLogCleaner - ReplicationLogCleaner received abort, ignoring. Reason: Failed to get stat of replication rs node 2021-02-25 23:05:01,149 DEBUG [an-pool3-thread-1729] master.ReplicationLogCleaner - org.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode = Session expired for /hbase/replication/rs 2021-02-25 23:05:01,150 WARN [an-pool3-thread-1729] master.ReplicationLogCleaner - Failed to read zookeeper, skipping checking deletable files {noformat}   {quote} 2021-02-25 23:05:01,149 WARN [an-pool3-thread-1729] master.ReplicationLogCleaner - ReplicationLogCleaner received abort, ignoring. Reason: Failed to get stat of replication rs node {quote}   This line is more scary where HMaster invoked Abortable but just ignored and HMaster was doing it business as usual. We have max files per directory configuration in namenode which is set to 1M in our clusters. If this directory reached that limit then that would have brought down the whole cluster. We shouldn't ignore Abortable and should crash the Hmaster if Abortable is invoked.  " [hbck2] Add hbase-operator-tools command for scheduleSCPsForUnknownServers,13363910,Resolved,Major,Fixed,11/Mar/21 17:14,23/Apr/21 07:50,, Add a basic CompactionServer which only keep heartbeat with HMaster,13368553,Resolved,Major,Fixed,30/Mar/21 07:32,23/Apr/21 02:41,,"Add a basic compaction server which can report status to master, to reduce duplicated code introduce AbstractServer as base class of HRegionserver and HCompactionserver introduce AbstractRpcServices as base class of RSRpcServices and CSRpcServices" RegionServer aborted due to ClassCastException,13368598,Resolved,Major,Fixed,30/Mar/21 09:14,08/Apr/21 11:05,2.2.6,"{color:#000000}Observed RegionServer crash while writing huge data concurrently through YCSB tool, {noformat} 2021-03-29 14:35:37,860 | ERROR | RpcServer.priority.RWQ.Fifo.write.handler=19,queue=3,port=RS_PORT | ***** ABORTING region server RS_IP,RS_PORT,1616999325078: The coprocessor org.apache.hadoop.hbase.coprocessor.MetaTableMetrics threw java.lang.ClassCastException: java.util.HashMap$Node cannot be cast to java.util.HashMap$TreeNode ***** | org.slf4j.helpers.MarkerIgnoringBase.error(MarkerIgnoringBase.java:159) java.lang.ClassCastException: java.util.HashMap$Node cannot be cast to java.util.HashMap$TreeNode at java.util.HashMap$TreeNode.moveRootToFront(HashMap.java:1835) at java.util.HashMap$TreeNode.treeify(HashMap.java:1951) at java.util.HashMap.treeifyBin(HashMap.java:772) at java.util.HashMap.putVal(HashMap.java:644) at java.util.HashMap.put(HashMap.java:612) at java.util.HashSet.add(HashSet.java:220) at org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.registerAndMarkMeter(MetaTableMetrics.java:200) at org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.regionMetricRegisterAndMark(MetaTableMetrics.java:173) at org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.registerAndMarkMetrics(MetaTableMetrics.java:106) at org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.prePut(MetaTableMetrics.java:91) at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$23.call(RegionCoprocessorHost.java:948) at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$23.call(RegionCoprocessorHost.java:945) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:581) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:655) at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.prePut(RegionCoprocessorHost.java:945) {noformat} This problem occured only once in my test cluster. Discussed offline with [~pankajkumar] it looks like race condition in MetaTableMetrics.metrics.{color}" Failure to instantiate WALCellCodec leaks socket in replication,13367298,Resolved,Major,Fixed,24/Mar/21 16:45,29/Mar/21 19:21,2.0.6,"I was looking at an HBase user's cluster with [~danilocop] where they saw two otherwise identical clusters where one of them was regularly had sockets in CLOSE_WAIT going from RegionServers to a distributed storage appliance. After a lot of analysis, we eventually figured out that these sockets in CLOSE_WAIT were directly related to an FSDataInputStream which we forgot to close inside of the RegionServer. The subtlety was that only one of these HBase clusters was set up to do replication (to the other cluster). The HBase cluster experiencing this problem was shipping edits to a peer, and had previously been using Phoenix. At some point, the cluster had Phoenix removed from it. What we found was that replication still had WALs to ship which were for Phoenix tables. Phoenix, in this version, still used the custom WALCellCodec; however, this codec class was missing from the RS classpath after the owner of the cluster removed Phoenix. When we try to instantiate the Codec implementation via ReflectionUtils, we end up throwing an UnsupportedOperationException which wraps a NoClassDefFoundException. However, in WALFactory, we _only_ close the FSDataInputStream when we catch an IOException.  Thus, replication sits in a ""fast"" loop, trying to ship these edits, each time leaking a new socket because of the InputStream not being closed. There is an obvious workaround for this specific issue, but we should not leak this inside HBase. Approximate, 2.1.x stack trace which lead us to this is below. {noformat} 2021-03-11 18:19:20,364 ERROR org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader: Failed to read stream of replication entries java.io.IOException: Cannot get log reader at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:366) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:303) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:291) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:427) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:354) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:302) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:293) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:174) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:100) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:192) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:138) Caused by: java.lang.UnsupportedOperationException: Unable to find org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec at org.apache.hadoop.hbase.util.ReflectionUtils.instantiateWithCustomCtor(ReflectionUtils.java:47) at org.apache.hadoop.hbase.regionserver.wal.WALCellCodec.create(WALCellCodec.java:106) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.getCodec(ProtobufLogReader.java:301) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.initAfterCompression(ProtobufLogReader.java:311) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:81) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.init(ProtobufLogReader.java:168) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:321) ... 10 more Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:264) at org.apache.hadoop.hbase.util.ReflectionUtils.instantiateWithCustomCtor(ReflectionUtils.java:43) ... 16 more {noformat}" Reimplement TestCurrentHourProvider to not depend on unstable TZs,13362200,Resolved,Major,Fixed,04/Mar/21 02:14,20/Mar/21 18:06,,"Because TestCurrentHourProvider is not timezone independent we are subject to vagaries of timezones around the world and the management of TZ data of each test server and dev box. This is not something we want to take on, IMHO. Reimplement to be independent of TZ or remove. " Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor ,13356538,Resolved,Major,Fixed,03/Feb/21 17:00,10/Mar/21 10:56,2.3.4,"While using snapshots for data migration, if the source cluster has non-default definition for *hbase.hregion.max.filesize*, table being snapshotted doesn't have *MAX_FILESIZE* attribute set, then if snapshot is exported to a separate cluster with different value for *hbase.hregion.max.filesize*, any cloned table will not respect the original value. In cases where the original cluster had a much larger value set to *hbase.hregion.max.filesize* then the destination cluster, restoring snapshot can trigger a storm of splits. This Jira introduces an optional configuration (disabled by default) that allows for the *hbase.hregion.max.filesize* value to be saved within the table *MAX_FILESIZE* descriptor at snapshot creation time.  " Backport to branch-2.2: [HBASE-25548 Optionally allow snapshots to preserve cluster's max filesize config by setting it into table descriptor],13363521,Resolved,Major,Fixed,10/Mar/21 11:18,18/Mar/21 15:51,2.2.6,"Cherry pick of HBASE-25548 had some conflicts, so a new PR to branch-2.2 is needed." Balancer should check region plan source to avoid misplace region groups,13361583,Resolved,Major,Fixed,01/Mar/21 11:31,16/Mar/21 16:37,,"Currently, balancer generates all group plans firstly, and then execute overall plans. When there are table regions movement between groups but after the groups plans generating and before executing, balancer may misplace the region to the old group. But this is not serious problem, next balancer will fix it.  If we add a check before executing balance plans, we can avoid the problem. " TestLruBlockCache.testBackgroundEvictionThread is flaky,13360099,Resolved,Major,Fixed,22/Feb/21 12:29,16/Mar/21 14:56,,"As the test result in [https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2700/2/testReport/org.apache.hadoop.hbase.io.hfile/TestLruBlockCache/precommit_checks___yetus_jdk11_hadoop3_checks___testBackgroundEvictionThread/] It fails because background EvictionThread used the weak reference of LRUBlockCache, when the cache object is cleared by garbage collector, NO block eviction will be triggered by LruBlockCache#runEviction().  ." [hbck2] Schedule SCP for all unknown servers,13359366,Resolved,Major,Fixed,18/Feb/21 15:42,11/Mar/21 17:13,,"Add a command to HBCK2 that schedules SCPs for _unknown servers_. This command is useful when a new installation of HBase is pointing to a previously used HBase root directory where the hbase:meta table is populated. This will contain references to RegionServers from the previous installation and SCP will not be created against these servers and the regions won't be assigned to the new server. The scheduleRecoveries command in HBCK2 could be used to initiate a SCP one-by-one for the unknown servers, however, collecting the list of servers could be difficult on a large cluster. I'm proposing to add a command to HBCK2 that will schedule SCPs for all the unknown servers in the cluster." Add units and round off region size to 2 digits after decimal,13363392,Resolved,Major,Fixed,09/Mar/21 23:03,13/Apr/21 16:15,2.3.0,"Normalizer logs progress and includes details regarding region count and target size. The size values are logged without units, and floating point numbers are logged without a specified precision, which can result in scientific notation. Clean up the formatting of these log messages to make them easily readable." Support specifying a base split policy class in KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy,13368157,Resolved,Major,Won't Fix,28/Mar/21 07:57,11/Apr/21 12:35,,"Basically, I think we can use KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy along with other split policies. In this Jira, we will support specifying a base split policy class in KeyPrefixRegionSplitPolicy and DelimitedKeyPrefixRegionSplitPolicy to use them with different split policies." Try ignore the ExportSnapshot related unit tests for branch-2.2,13360893,Resolved,Major,Fixed,25/Feb/21 07:51,11/Apr/21 07:02,, Add a new option in PE to indicate the current number of rows in the test table,13363443,Open,Major,,10/Mar/21 07:32,,,"When we have written 100000 rows in TestTable with 10 preSplits. Then we want to test asyncRandomRead, with 10 threads, per thread read 1000 rows. But the range of all read keys is in [0, 10000], all in the first region. It may cause hotspot problem, and the result is not accurate. We can use --size and --rows in randomRead and randomSeekScan at the same time, so that the range of reading reaches the entire data set. But asyncRandomRead, scanRangeXX, sequentialRead and all the write still have hot spot problem. This issue add a new option ""initRows"" to solve this problem." Make an hbase-wal module,13368514,Resolved,Major,Won't Fix,30/Mar/21 04:34,06/Apr/21 21:03,,Extract an hbase-wal module upon which hbase-server can depend; makes hbase-server smaller and maybe we could do an hbase-wal standalone... This is an experiment. Port failure to close InputStream to 1.x,13368481,Resolved,Major,Fixed,29/Mar/21 23:57,02/Apr/21 18:03,,Port the parent issue (replication not closing a socket) to branch-1 Adding audit log for execMasterService,13357473,Resolved,Major,Fixed,08/Feb/21 08:50,31/Mar/21 23:17,,"Hi: I have found that in APIs, like execProcedure and execProcedureWithRet, have audit log to record who execute the master service. The log can be like: {code:java} LOG.info(master.getClientIdAuditPrefix() + "" procedure request for: "" + desc.getSignature()); {code} But it seems that we forget to audit execMasterService. We should add one." update download area for 2.3.4 as new stable build,13354520,Resolved,Major,Fixed,25/Jan/21 20:19,25/Jan/21 20:36,," * update the stable symlink to point to 2.3.4 * Remove the 2.3.3 release from downloads.a.o" Disable reverse DNS lookup for SASL Kerberos client connection,13365194,Resolved,Major,Fixed,15/Mar/21 09:19,17/Mar/21 04:07,1.4.13,"In some unusual network environment that forward DNS lookup is supported, but revers isn't, we can configure the HBase cluster by deploying/etc/hosts which support reverse lookup for all nodes in the cluster or hbase.unsafe.regionserver.hostname.disable.master.reversedns=true which is introduced in HBASE-18226(See also HBASE-12954, HBASE-24667). Our network environment is also unusual and doesn't provide a reverse lookup. Thus, we configure the HBase cluster by deploying /etc/hosts. Assume our DNS setup is {code:java} master1.example.com A 12.34.56.1 master2.example.com A 12.34.56.2 master3.example.com A 12.34.56.3 regionserver1.example.com A 12.34.56.4 regionserver2.example.com A 12.34.56.5 regionserver3.example.com A 12.34.56.6 {code} We deploy the following /etc/hosts for the HBase cluster nodes by our deployment system. {code:java} 12.34.56.1 master1.example.com master1 12.34.56.2 master2.example.com master2 12.34.56.3 master3.example.com master3 12.34.56.4 regionserver1.example.com regionserver1 12.34.56.5 regionserver2.example.com regionserver2 12.34.56.6 regionserver3.example.com regionserver3 {code} (We don't use hbase.unsafe.regionserver.hostname.disable.master.reversedns=true for now) So all nodes in the cluster have stable reverse lookup for the IPs in the cluster, and the HBase cluster deployed in this way is quite stable and we can expand the cluster easily without any modification on the client-side. Now we need to introduce Kerberos SASL secured cluster for security reasons. We tried to construct in the same way as is, i.e. deploy /etc/hosts for the HBase cluster nodes. However, this won't work well because the HBase client does a reverse lookup to get principal for Kerberos. (hbase.unsafe.regionserver.hostname.disable.master.reversedns=true won't work as well as) Thus we need to deploy /etc/hosts to all application servers, which contains all nodes of the HBase cluster to be connected. This is quite terrible for our cluster operation and application server setup. We, the HBase cluster manager, need to take care of application server setup and deployment. We must provide all master and region server lists. It's much more complicated when applications access multiple HBase clusters... We, the HBase cluster manager, cannot expand the cluster unless the latest /etc/hosts are deployed to all application servers. If we expand the cluster before deployment, the application is unable to connect and got an error Assume their own Kerberos principal is their FQDN i.e. master1.example.com for example, and the cluster is aware of their FQDN. So all clients can connect cluster nodes using the FQDN for Kerberos principal. Could we provide an advanced unsafe option to disable DNS reverse lookup for clients using Kerberos SASL like hbase.unsafe.regionserver.hostname.disable.master.reversedns and other config? Let's say `hbase.unsafe.client.kerberos.hostname.disable.reversedns` and if this is true, client uses InetAddress.getHostname() for Kerberos principal instead of InetAddress.getCanonicalHostName()." Backport HBASE-25665 to branch-1,13365701,Resolved,Major,Fixed,17/Mar/21 04:27,29/Mar/21 20:04,,Backport [https://github.com/apache/hbase/commit/ebb0adf50009fc133af0cfb0bdce4dfbb81d4fbf] for https://issues.apache.org/jira/browse/HBASE-25665 to branch-1 Shrink size of hbase-server module,13365903,Open,Major,,17/Mar/21 17:49,,,"Umbrella issue for shrinking the size of the hbase-server module. Its too big (see recent notes by [~zhangduo] that hbase-server size was making findbugs OOME). Suggested candidate subtasks: hbase-io hbase-xtra-unit-tests <= Move large hbase-server tests out of hbase-server and into this module hbase-region HBASE-25190 was about an hbase-tool module" Remove RowProcessor,13368070,Resolved,Major,Fixed,27/Mar/21 07:49,27/Mar/21 22:40,,"As RowProcessor is deprecated, we can remove it in this Jira." NPE getting metrics from standby masters (MetricsMasterWrapperImpl.getMergePlanCount),13367394,Resolved,Major,Fixed,25/Mar/21 00:00,25/Mar/21 02:10,2.4.2,"2021-03-24 23:26:15,828 ERROR [Timer for 'HBase' metrics system] impl.MetricsSourceAdapter: Error getting metrics from source Master,sub=Server java.lang.NullPointerException at org.apache.hadoop.hbase.master.MetricsMasterWrapperImpl.getMergePlanCount(MetricsMasterWrapperImpl.java:58) at org.apache.hadoop.hbase.master.MetricsMasterSourceImpl.getMetrics(MetricsMasterSourceImpl.java:90) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:200) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.snapshotMetrics(MetricsSystemImpl.java:419) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.sampleMetrics(MetricsSystemImpl.java:406) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.onTimerEvent(MetricsSystemImpl.java:381) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$4.run(MetricsSystemImpl.java:368) at java.base/java.util.TimerThread.mainLoop(Timer.java:556) at java.base/java.util.TimerThread.run(Timer.java:506) " Test failure: TestVerifyBucketCacheFile.testRetrieveFromFile,13367047,Resolved,Major,Fixed,23/Mar/21 16:15,25/Mar/21 05:59,2.3.4,"Saw this test failure from 2.3 nightly. https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/190/testReport/junit/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/health_checks___yetus_jdk8_hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_371a67ec_/ h1. Regression health checks / yetus jdk8 hadoop2 checks / org.apache.hadoop.hbase.io.hfile.bucket.TestVerifyBucketCacheFile.testRetrieveFromFile[1: blockSize=16,384, bucketSizes=[I@371a67ec] Failing for the past 1 build (Since [!https://ci-hadoop.apache.org/static/e247241e/images/16x16/red.png! #190|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/190/] ) [Took 0.32 sec.|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/190/testReport/junit/org.apache.hadoop.hbase.io.hfile.bucket/TestVerifyBucketCacheFile/health_checks___yetus_jdk8_hadoop2_checks___testRetrieveFromFile_1__blockSize_16_384__bucketSizes__I_371a67ec_/history]   h3. Stacktrace java.lang.AssertionError at org.apache.hadoop.hbase.io.hfile.bucket.TestVerifyBucketCacheFile.testRetrieveFromFile(TestVerifyBucketCacheFile.java:136)" ReplicationSourceWALReader log and handle exception immediately without retrying,13357693,Resolved,Major,Fixed,09/Feb/21 07:14,25/Mar/21 06:18,2.2.6,"In [this piece of code about retrying in ReplicationSourceWALReader#run|https://github.com/apache/hbase/blob/0353909bc268e3ff3def098963d021e973f1f153/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L151], sleep time increases with the number of retries, if an exception happens that cannot be recovered by itself, error logs will appear after 12 hours (300 retries by default)." NPE when getting metrics of backup master,13350980,Resolved,Major,Duplicate,07/Jan/21 23:14,25/Mar/21 16:50,2.4.0,Getting NullPointerException in MetricsMasterWrapperImpl.getMergePlanCount() when getting metrics via JMX on backup master. It appears due to the fact that regionNormalizerManager is null in backup masters as it's only initialized by HMaster.finishActiveMasterInitialization(). Bulkload replication HFileRefs cannot be cleared in some cases where set exclude-namespace/exclude-table-cfs,13359759,Resolved,Major,Fixed,20/Feb/21 09:01,25/Mar/21 14:55,2.2.6,"In [ReplicationSource#addHFileRefs|https://github.com/apache/hbase/blob/ed90a14995acd87111d2b9849f07d84418ca43d4/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L264], we may add unwanted hfiles to the _HFileRefs_ if a peer is set _replicate_all_ true and set _exclude-namespace/exclude-table-cfs_. These unwanted _HFileRefs_ will not be replicated to remote cluster and not be cleared. Two problems are caused by this bug: # The metric sizeOfHFileRefsQueue cannot be zeroed. # Referenced HFiles cannot be deleted by _ReplicationHFileCleaner._" asyncprofiler2.0 no longer supports svg; wants html,13366451,Resolved,Major,Fixed,20/Mar/21 00:20,23/Mar/21 04:35,,"asyncprofiler2.0 is out. Its a nice tool. Unfortunately, it dropped the svg formatting option that we use in our servlet. Now it wants you to pass html. Lets fix. Old -o on asyncprofiler1.x -o fmt output format: summary|traces|flat|collapsed|svg|tree|jfr New -o asyncprofiler 2.x -o fmt output format: flat|traces|collapsed|flamegraph|tree|jfr If you pass svg to 2.0, it does nothing ... If you run the command hbase is running you see: {code} /tmp/prof-output$ sudo -u hbase /usr/lib/async-profiler/profiler.sh -e cpu -d 10 -o svg -f /tmp/prof-output/async-prof-pid-8346-cpu-1x.svg 8346 [ERROR] SVG format is obsolete, use .html for FlameGraph {code} At a minimum can make it so the OUTPUT param supports HTML. Here is current enum state: {code} enum Output { SUMMARY, TRACES, FLAT, COLLAPSED, SVG, TREE, JFR } {code}" Use CustomRequestLog instead of Slf4jRequestLog for jetty,13366510,Resolved,Major,Fixed,20/Mar/21 14:43,23/Mar/21 03:33,,Slf4jRequestLog has been deprecated and replaced by Slf4jRequestLogWriter. Move generic classes from hbase-server to hbase-common,13365904,Resolved,Major,Won't Fix,17/Mar/21 17:51,23/Mar/21 20:35,,"There's a bunch of classes that are not hbase-server specific on cursory review that could live in hbase-common... not many, about 3% of src/main/java but move them out. {code} rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/SslRMIClientSocketFactorySecure.java (99%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/SslRMIServerSocketFactorySecure.java (99%) rename {hbase-server/src/main/java/org/apache/hadoop/hbase => hbase-common/src/main/java/org/apache/hadoop/hbase/healthcheck}/HealthCheckChore.java (93%) rename {hbase-server/src/main/java/org/apache/hadoop/hbase => hbase-common/src/main/java/org/apache/hadoop/hbase/healthcheck}/HealthChecker.java (86%) rename {hbase-server/src/main/java/org/apache/hadoop/hbase => hbase-common/src/main/java/org/apache/hadoop/hbase/healthcheck}/HealthReport.java (94%) rename {hbase-server/src/test/java/org/apache/hadoop/hbase => hbase-common/src/test/java/org/apache/hadoop/hbase/healthcheck}/TestNodeHealthCheckChore.java (86%) delete mode 100644 hbase-server/src/main/java/org/apache/hadoop/hbase/DaemonThreadFactory.java rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/security/SecurityUtil.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/ConfigurationUtil.java (99%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/DirectMemoryUtils.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/GetJavaProperty.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/HBaseConfTool.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/HashedBytes.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/IdReadWriteLock.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/JvmVersion.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/KeyRange.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/LossyCounting.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/ManualEnvironmentEdge.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/MunkresAssignment.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/NettyEventLoopGroupConfig.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/RollingStatCalculator.java (99%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/ShutdownHookManager.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/SortedList.java (100%) rename {hbase-server => hbase-common}/src/main/java/org/apache/hadoop/hbase/util/StealJobQueue.java (100%) rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestConfigurationUtil.java (100%) rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestIdReadWriteLock.java (100%) rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestLossyCounting.java (100%) rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java (95%) rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestSortedList.java (100%) rename {hbase-server => hbase-common}/src/test/java/org/apache/hadoop/hbase/util/TestStealJobQueue.java (100%) {code}" HBase replication should have a metric to represent if the source is stuck getting initialized,13362003,Resolved,Major,Fixed,03/Mar/21 04:13,23/Mar/21 05:57,1.7.0,"There can be situation when the cluster is not able to talk to peer cluster ZK, in that case, yes the logQueue will be accumulating but without digging into the logs, we cannot know what's the reason of loqQueue getting accumulating on the source.  Since the replication source doesn't even start the shipper in this case, it is good to have a dedicated metric if the RS cannot talk to the peer's ZK at all.    {code:java} 2021-03-03 04:02:10,704 DEBUG [peerId] zookeeper.RecoverableZooKeeper - Possibly transient ZooKeeper, quorum=zookeeper-0.zookeeper-a.fakeAddress:2181,zookeeper-1.zookeeper-a.fakeAddress:2181,zookeeper-2.zookeeper-a.fakeAddress:2181,zookeeper-3.zookeeper-a.fakeAddress:2181,zookeeper-4.zookeeper-a.fakeAddress:2181, exception=org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode = AuthFailed for /hbase/hbaseid2021-03-03 04:02:10,704 DEBUG [peerId] zookeeper.RecoverableZooKeeper - Possibly transient ZooKeeper, quorum=zookeeper-0.zookeeper-a.fakeAddress:2181,zookeeper-1.zookeeper-a.fakeAddress:2181,zookeeper-2.zookeeper-a.fakeAddress:2181,zookeeper-3.zookeeper-a.fakeAddress:2181,zookeeper-4.zookeeper-a.fakeAddress:2181, exception=org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode = AuthFailed for /hbase/hbaseidorg.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode = AuthFailed for /hbase/hbaseid at org.apache.zookeeper.KeeperException.create(KeeperException.java:126) at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1119) at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:284) at org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:469) at org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65) at org.apache.hadoop.hbase.zookeeper.ZKClusterId.getUUIDForCluster(ZKClusterId.java:96) at org.apache.hadoop.hbase.replication.HBaseReplicationEndpoint.getPeerUUID(HBaseReplicationEndpoint.java:104) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:306) {code}" Support HFileOutputFormat locality sensitive even destination cluster is different from source cluster,13360930,Resolved,Major,Fixed,25/Feb/21 10:18,17/Mar/21 04:49,1.7.0,"Sometimes, we want to perform MR job which is source cluster and destination cluster is different like following for data migration, batch job and so on.   {code:java} Configuration conf = HBaseConfiguration.createClusterConf(HBaseConfiguration.create(), sourceClusterKey); final Job job = Job.getInstance(conf, jobName); // ... FileOutputFormat.setOutputPath(job, new Path(outputPath)); Scan scan = createScanner(); TableMapReduceUtil.initTableMapperJob( sourceTableName, scan, Mapper.class, ImmutableBytesWritable.class, Put.class, job); try (Connection con = ConnectionFactory.createConnection(destinationClusterKey); Table table = con.getTable(destinationTableName); RegionLocator regionLocator = con.getRegionLocator(destinationTableName)) { HFileOutputFormat2.configureIncrementalLoad(job, table, regionLocator); } return job.waitForCompletion(true) ? 0 : 1; {code} HFileOutputFormat2 doesn't create locality-sensitive hfiles. We got following exception {code:java} 2021-02-24 19:55:48,298 WARN [main] org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2: there's something wrong when locating rowkey: xxxxxxxxxxxx org.apache.hadoop.hbase.TableNotFoundException: Table 'table' was not found, got: XXXX. at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegionInMeta(ConnectionManager.java:1302) at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegion(ConnectionManager.java:1181) at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegion(ConnectionManager.java:1165) at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegion(ConnectionManager.java:1122) at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getRegionLocation(ConnectionManager.java:957) at org.apache.hadoop.hbase.client.HRegionLocator.getRegionLocation(HRegionLocator.java:74) at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2$1.write(HFileOutputFormat2.java:216) at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2$1.write(HFileOutputFormat2.java:167) at org.apache.hadoop.mapred.ReduceTask$NewTrackingRecordWriter.write(ReduceTask.java:558) at org.apache.hadoop.mapreduce.task.TaskInputOutputContextImpl.write(TaskInputOutputContextImpl.java:89) at org.apache.hadoop.mapreduce.lib.reduce.WrappedReducer$Context.write(WrappedReducer.java:105) at org.apache.hadoop.hbase.mapreduce.PutSortReducer.reduce(PutSortReducer.java:78) at org.apache.hadoop.hbase.mapreduce.PutSortReducer.reduce(PutSortReducer.java:43) at org.apache.hadoop.mapreduce.Reducer.run(Reducer.java:171) at org.apache.hadoop.mapred.ReduceTask.runNewReducer(ReduceTask.java:627) at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:389) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:164) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:158) {code} Because it creates connection using task configuration which is configured for source cluster. Thus, it tried to connect to the source cluster and get locations for the table that should exist in the destination. {code:java} InetSocketAddress[] favoredNodes = null; if (conf.getBoolean(LOCALITY_SENSITIVE_CONF_KEY, DEFAULT_LOCALITY_SENSITIVE)) { HRegionLocation loc = null; String tableName = Bytes.toString(tableNameBytes); if (tableName != null) { try (Connection connection = ConnectionFactory.createConnection(conf); RegionLocator locator = connection.getRegionLocator(TableName.valueOf(tableName))) { loc = locator.getRegionLocation(rowKey); } catch (Throwable e) { LOG.warn(""Something wrong locating rowkey {} in {}"", Bytes.toString(rowKey), tableName, e); loc = null; } } if (null == loc) { LOG.trace(""Failed get of location, use default writer {}"", Bytes.toString(rowKey)); } else { LOG.debug(""First rowkey: [{}]"", Bytes.toString(rowKey)); InetSocketAddress initialIsa = new InetSocketAddress(loc.getHostname(), loc.getPort()); if (initialIsa.isUnresolved()) { LOG.trace(""Failed resolve address {}, use default writer"", loc.getHostnamePort()); } else { LOG.debug(""Use favored nodes writer: {}"", initialIsa.getHostString()); favoredNodes = new InetSocketAddress[] { initialIsa }; } } } wl = getNewWriter(tableNameBytes, family, conf, favoredNodes); {code} HFileOutputFormat2 should be aware of destination cluster correctly when source and destination is different for proper location-sensitive HFile generation" Backport HBASE-25608 to branch-1,13365709,Resolved,Major,Fixed,17/Mar/21 05:24,22/Mar/21 15:57,, Support nonce operations for Increment/Append in RowMutations and CheckAndMutate,13366084,Resolved,Major,Fixed,18/Mar/21 13:19,21/Mar/21 14:44,,"Currently, we support nonce operations for single Increment/Append operations but don't support for Increment/Append in RowMutations and CheckAndMutate. We should support it." Backport HBASE-25608 to branch-2,13365708,Resolved,Major,Fixed,17/Mar/21 05:24,18/Mar/21 19:02,, Result#compareResults should compare tags.,13361682,Resolved,Major,Fixed,01/Mar/21 19:33,12/Mar/21 05:53,1.7.0,"Today +Result#compareResults+ compares the 2 cells based on following parameters. {noformat} for (int i = 0; i < res1.size(); i++) { if (!ourKVs[i].equals(replicatedKVs[i]) || !CellUtil.matchingValue(ourKVs[i], replicatedKVs[i])) { throw new Exception(""This result was different: "" + res1.toString() + "" compared to "" + res2.toString()); } {noformat} row, family, qualifier, timestamp, type, value. We also need to compare tags to determine if both cells are equal or not.    " Typo in docs vs code: hbase.mob.[file.]compaction.chore.period,13365650,Resolved,Major,Fixed,16/Mar/21 22:30,17/Mar/21 04:00,3.0.0-alpha-1,"I might be missing something here, but after trying to disable mob compaction chore, and failed at it by setting hbase.mob.file.compaction.chore.period to 0, I realized docs and the code differ. Code: https://github.com/apache/hbase/search?q=hbase.mob.compaction.chore.period Docs: https://github.com/apache/hbase/search?q=hbase.mob.file.compaction.chore.period Looks like only a portion of the docs, still confusing." Remove RSGroup test addition made in parent; depends on functionality not in old branches,13365624,Resolved,Major,Fixed,16/Mar/21 20:07,16/Mar/21 20:20,,TestRSGroupShell fails 100% of the time. See https://ci-hadoop.apache.org/view/HBase/job/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.3/lastSuccessfulBuild/artifact/output/dashboard.html move_namespaces_rsgroup should change hbase.rsgroup.name config in NamespaceDescriptor,13351644,Resolved,Major,Fixed,12/Jan/21 04:59,18/Jan/21 11:15,,"move_namespaces_rsgroup command just move tables in this namespace to new rsgroup。when we create a table in this namespace，it deploy on old rs group。 it maka some misunderstand for users。 move_namespaces_rsgroup should make the tables deployed on new rsgroup " Fix spotbugs warning in RoundRobinTableInputFormat,13364343,Resolved,Major,Fixed,12/Mar/21 11:37,15/Mar/21 15:19,,"RoundRobinTableInputFormat.roundRobin(List) makes inefficient use of keySet iterator instead of entrySet iterator, https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3043/2/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html" CandidateGenerator may miss some region balance actions,13362507,Resolved,Major,Fixed,05/Mar/21 05:29,15/Mar/21 13:49,2.0.0,"{color:#172b4d}In codes of CandidateGenerator#getAction()，valid region index are greater or equal to zero. Currently only regions with greater than zero indexes can get balance actions.{color} {code:java} protected BaseLoadBalancer.Cluster.Action getAction(int fromServer, int fromRegion, int toServer, int toRegion) { if (fromServer < 0 || toServer < 0) { return BaseLoadBalancer.Cluster.NullAction; } if (fromRegion > 0 && toRegion > 0) { return new BaseLoadBalancer.Cluster.SwapRegionsAction(fromServer, fromRegion, toServer, toRegion); } else if (fromRegion > 0) { return new BaseLoadBalancer.Cluster.MoveRegionAction(fromRegion, fromServer, toServer); } else if (toRegion > 0) { return new BaseLoadBalancer.Cluster.MoveRegionAction(toRegion, toServer, fromServer); } else { return BaseLoadBalancer.Cluster.NullAction; } }{code}  " Fix spotbugs warnings after upgrading spotbugs to 4.x,13363694,Resolved,Major,Fixed,11/Mar/21 02:11,12/Mar/21 07:05,, "On largish cluster, ""CleanerChore: Could not delete dir..."" makes master log unreadable",13358375,Resolved,Major,Fixed,12/Feb/21 16:36,12/Mar/21 05:41,,"Looking at a running master on a largish cluster, the master log is full of spew to this effect: {{ 2021-02-10 23:16:49,330 INFO [dir-scan-pool4-thread-206391] cleaner.CleanerChore: Could not delete dir under hdfs://web2-dfs:8020/hbase/archive/data/default/crawl_graph. might be transient; we'll retry. if it keeps happening, use following exception when asking on mailing list. org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.fs.PathIsNotEmptyDirectoryException): `/hbase/archive/data/default/crawl_graph is non empty': Directory is not empty at org.apache.hadoop.hdfs.server.namenode.FSDirDeleteOp.delete(FSDirDeleteOp.java:116) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:2962) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.delete(NameNodeRpcServer.java:1092) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.delete(ClientNamenodeProtocolServerSideTranslatorPB.java:681) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:523) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:869) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:815) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1875) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2675) at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1499) at org.apache.hadoop.ipc.Client.call(Client.java:1445) at org.apache.hadoop.ipc.Client.call(Client.java:1355) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:228) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116) at com.sun.proxy.$Proxy19.delete(Unknown Source) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.delete(ClientNamenodeProtocolTranslatorPB.java:621) at sun.reflect.GeneratedMethodAccessor39.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:422) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:165) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:157) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:359) at com.sun.proxy.$Proxy20.delete(Unknown Source) at sun.reflect.GeneratedMethodAccessor39.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:372) at com.sun.proxy.$Proxy21.delete(Unknown Source) at sun.reflect.GeneratedMethodAccessor39.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:372) at com.sun.proxy.$Proxy21.delete(Unknown Source) at org.apache.hadoop.hdfs.DFSClient.delete(DFSClient.java:1572) at org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:880) at org.apache.hadoop.hdfs.DistributedFileSystem$19.doCall(DistributedFileSystem.java:877) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hdfs.DistributedFileSystem.delete(DistributedFileSystem.java:887) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$null$4(CleanerChore.java:441) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.deleteAction(CleanerChore.java:466) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$traverseAndDelete$5(CleanerChore.java:441) at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774) at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750) at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488) at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$traverseAndDelete$5(CleanerChore.java:443) at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774) at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:750) at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488) at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$traverseAndDelete$5(CleanerChore.java:443) at org.apache.hadoop.hbase.util.FutureUtils.lambda$addListener$0(FutureUtils.java:68) at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:774) at java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:792) at java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2153) at org.apache.hadoop.hbase.util.FutureUtils.addListener(FutureUtils.java:61) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.traverseAndDelete(CleanerChore.java:427) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$null$2(CleanerChore.java:420) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)}} It goes on and on. " Document normalizer features NORMALIZER_TARGET_REGION_SIZE and NORMALIZER_TARGET_REGION_COUNT,13363390,Open,Major,,09/Mar/21 23:00,,2.3.0,The normalizer can be configured for specific behavior via table properties {{NORMALIZER_TARGET_REGION_SIZE}} and {{NORMALIZER_TARGET_REGION_COUNT}}. Neither of these are mentioned in the book. "Unable rename error occurred in AbstractFSWAL, causing regionserver to crash",13364052,Open,Major,,12/Mar/21 08:27,,2.1.0,"The error is as follows： [ERROR] - org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:631) - Cache flush failed for region test_2,00000000000000000293601280,1614762174258.030beae347d51a5fb6782f6cb025f763. [ERROR] - org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:631) - Cache flush failed for region test_2,00000000000000000293601280,1614762174258.030beae347d51a5fb6782f6cb025f763.java.io.IOException: WAL has been closed at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doShutdown(AsyncFSWAL.java:698) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.shutdown(AbstractFSWAL.java:817) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.LogRoller.abort(LogRoller.java:143) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.LogRoller.run(LogRoller.java:201) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at java.lang.Thread.run(Thread.java:834) ~[?:?][17:11:59:664] [INFO] - org.apache.hadoop.hbase.regionserver.HRegion.logFatLineOnFlush(HRegion.java:2636) - Flushing 1/1 column families, dataSize=127.76 MB heapSize=136.99 MB[17:11:59:665] [WARN] - org.apache.hadoop.hbase.regionserver.HRegion.doAbortFlushToWAL(HRegion.java:2652) - Received unexpected exception trying to write ABORT_FLUSH marker to WAL:java.io.IOException: Cannot append; log is closed, regionName = test_2,00000000000000000377487360,1614762174258.146bbdf3caa203124cd039e48dd3e344. at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(AbstractFSWAL.java:962) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(AsyncFSWAL.java:563) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullAppendTransaction(WALUtil.java:156) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeFlushMarker(WALUtil.java:85) at org.apache.hadoop.hbase.regionserver.HRegion.doAbortFlushToWAL(HRegion.java:2649) at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2599) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2465) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439) at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361) at java.base/java.lang.Thread.run(Thread.java:834) [17:11:59:665] [ERROR] - org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:631) - Cache flush failed for region test_2,00000000000000000377487360,1614762174258.146bbdf3caa203124cd039e48dd3e344.java.io.IOException: Cannot append; log is closed, regionName = test_2,00000000000000000377487360,1614762174258.146bbdf3caa203124cd039e48dd3e344. at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(AbstractFSWAL.java:962) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(AsyncFSWAL.java:563) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullAppendTransaction(WALUtil.java:156) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeFlushMarker(WALUtil.java:85) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2588) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2465) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at java.lang.Thread.run(Thread.java:834) ~[?:?][17:11:59:665] [INFO] - org.apache.hadoop.hbase.regionserver.HRegion.logFatLineOnFlush(HRegion.java:2636) - Flushing 1/1 column families, dataSize=126.24 MB heapSize=135.36 MB[17:11:59:665] [WARN] - org.apache.hadoop.hbase.regionserver.HRegion.doAbortFlushToWAL(HRegion.java:2652) - Received unexpected exception trying to write ABORT_FLUSH marker to WAL:java.io.IOException: Cannot append; log is closed, regionName = test_2,00000000000000000587202560,1614762174258.c958379b0ac4a008cb4d75223683377a. at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(AbstractFSWAL.java:962) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(AsyncFSWAL.java:563) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullAppendTransaction(WALUtil.java:156) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeFlushMarker(WALUtil.java:85) at org.apache.hadoop.hbase.regionserver.HRegion.doAbortFlushToWAL(HRegion.java:2649) at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2599) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2465) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439) at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361) at java.base/java.lang.Thread.run(Thread.java:834) [17:11:59:665] [ERROR] - org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:631) - Cache flush failed for region test_2,00000000000000000587202560,1614762174258.c958379b0ac4a008cb4d75223683377a.java.io.IOException: Cannot append; log is closed, regionName = test_2,00000000000000000587202560,1614762174258.c958379b0ac4a008cb4d75223683377a. at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(AbstractFSWAL.java:962) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(AsyncFSWAL.java:563) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullAppendTransaction(WALUtil.java:156) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeFlushMarker(WALUtil.java:85) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2588) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2465) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at java.lang.Thread.run(Thread.java:834) ~[?:?][17:11:59:666] [WARN] - org.apache.hadoop.hbase.regionserver.HRegion.doAbortFlushToWAL(HRegion.java:2652) - Received unexpected exception trying to write ABORT_FLUSH marker to WAL:java.io.IOException: Cannot append; log is closed, regionName = test_2,00000000000000000125829120,1614762174258.b14f5ec6e23e1390b2daf0f83be84ee0. at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(AbstractFSWAL.java:962) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(AsyncFSWAL.java:563) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullAppendTransaction(WALUtil.java:156) at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeFlushMarker(WALUtil.java:85) at org.apache.hadoop.hbase.regionserver.HRegion.doAbortFlushToWAL(HRegion.java:2649) at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2599) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2465) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439) at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361) at java.base/java.lang.Thread.run(Thread.java:834) [17:11:59:666] [ERROR] - org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:631) - Cache flush failed for region test_2,00000000000000000125829120,1614762174258.b14f5ec6e23e1390b2daf0f83be84ee0.java.io.IOException: Cannot append; log is closed, regionName = test_2,00000000000000000125829120,1614762174258.b14f5ec6e23e1390b2daf0f83be84ee0. at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(AbstractFSWAL.java:962) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(AsyncFSWAL.java:563) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullAppendTransaction(WALUtil.java:156) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeFlushMarker(WALUtil.java:85) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2588) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2465) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2439) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2329) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:612) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:581) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:361) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at java.lang.Thread.run(Thread.java:834) ~[?:?][17:11:59:813] [ERROR] - org.apache.hadoop.hbase.regionserver.HRegionServer.abort(HRegionServer.java:2376) - ***** ABORTING region server node017,16020,1614750431707: IOE in log roller *****java.io.IOException: Unable to rename hdfs://buc-001/hbase/WALs/node017,16020,1614750431707/node017%2C16020%2C1614750431707.1614762525711 to hdfs://buc-001/hbase/oldWALs/node017%2C16020%2C1614750431707.1614762525711 at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.archiveLogFile(AbstractFSWAL.java:651) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.cleanOldLogs(AbstractFSWAL.java:627) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:767) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at org.apache.hadoop.hbase.regionserver.LogRoller.run(LogRoller.java:190) ~[hbase-server-2.1.0-cdh6.3.0.jar:?] at java.lang.Thread.run(Thread.java:834) ~[?:?] Has anyone encountered a similar problem？？？" NPE when init RegionMover,13356962,Resolved,Major,Fixed,05/Feb/21 07:36,05/Feb/21 08:37,,"When use graceful_stop.sh or command ""${HBASE_HOME}/bin/hbase org.apache.hadoop.hbase.util.RegionMover -h"", we can get NPE: {code:java} Exception in thread ""main"" java.lang.NullPointerExceptionException in thread ""main"" java.lang.NullPointerException at org.apache.hadoop.hbase.master.RackManager.(RackManager.java:46) at org.apache.hadoop.hbase.util.RegionMover.(RegionMover.java:128) at org.apache.hadoop.hbase.util.RegionMover.main(RegionMover.java:792) {code}" "Add client detail to scan name so when lease expires, we have clue on who was scanning",13356079,Resolved,Major,Fixed,02/Feb/21 00:42,08/Feb/21 22:42,2.3.2,"On a busy cluster, seeing a bunch of this: {code} regionserver.RSRpcServices: Scanner -5594731657924732088 lease expired on region hbase:meta,,1.1588230740 {code} Trying to figure out originator is a little tough; there isn't enough in for in the above. scanid is a long but scan name is a string.. perhaps add in the client ip+port as scan id prefix? Or add the info to the value -- probably better -- and dump it out when we get one of these expirations?" Possible Resource Leak in CatalogJanitor,13363106,Resolved,Major,Fixed,08/Mar/21 22:17,10/Mar/21 09:25,2.4.3,"We noticed a possible resource leak [here|https://github.com/apache/hbase/blob/53128fe7c17e6220113884fbad69d75c59ed56b7/hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java#L411]. {{close()}} is never called on {{inStream}}. I'll submit a pull request to fix it." Regionserver crash occasionally due to SIGSEGV,13362084,Open,Major,,03/Mar/21 12:08,,2.1.0,"Regionserver had a problem which is JVM crash after running for a period of time. From the error dump logs, the main reason is due to SIGSEGV singal.  BTW, from the start of the regionserver to the crash, there is no error record in the hbase log After many crash, there are some common points. # Thread is AsyncFSWAL-0. # Problematic frame is v  ~StubRoutines::jshort_disjoint_arraycopy # Error method is org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter$OutputStreamWrapper.write. jdk:  Oracle jdk-1.8_181 os: CentOS Linux release 7.4.1708 (Core) hbase: 2.1.0-cdh6.3.0   {code:java} # JRE version: Java(TM) SE Runtime Environment (8.0_181-b13) (build 1.8.0_181-b13) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.181-b13 mixed mode linux-amd64 ) # Problematic frame:# v  ~StubRoutines::jshort_disjoint_arraycopy {code}   {code:java} ---------------  T H R E A D  --------------- Current thread (0x00007f4758820800):  JavaThread ""AsyncFSWAL-0"" daemon [_thread_in_Java, id=17396, stack(0x00007f36f0aa3000,0x00007f36f0ae4000)] siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0x00007f36bc3dd93a Stack: [0x00007f36f0aa3000,0x00007f36f0ae4000],  sp=0x00007f36f0ae2310,  free space=252kNative frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) v  ~StubRoutines::jshort_disjoint_arraycopy J 13350 C2 org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter$OutputStreamWrapper.write(Ljava/nio/ByteBuffer;II)V (34 bytes) @ 0x00007f475f113fd1 [0x00007f475f113cc0+0x311] J 16839 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.write(Ljava/io/OutputStream;Z)I (21 bytes) @ 0x00007f475f4329dc [0x00007f475f432960+0x7c] J 12594 C2 org.apache.hadoop.hbase.regionserver.wal.WALCellCodec$EnsureKvEncoder.write(Lorg/apache/hadoop/hbase/Cell;)V (27 bytes) @ 0x00007f475ef80414 [0x00007f475ef7fc20+0x7f4] VM Arguments: jvm_args:  -Dproc_regionserver -XX:OnOutOfMemoryError=kill -9 %p  -Djava.net.preferIPv4Stack=true -Xms33285996544 -Xmx33285996544 -Xmx64g -Xms32g -Xmn6g -Xss256k  -XX:MaxPermSize=384m -XX:SurvivorRatio=6 -XX:+UseParNewGC -XX:ParallelGCThreads=10 -XX:+UseConcMarkSweepGC  -XX:ParallelCMSThreads=16 -XX:+CMSParallelRemarkEnabled -XX:+UseCMSCompactAtFullCollection -XX:+UseCMSInitiatingOccupancyOnly  -XX:CMSInitiatingOccupancyFraction=70 -XX:CMSMaxAbortablePrecleanTime=500 -XX:CMSFullGCsBeforeCompaction=5 -XX:+CMSClassUnloadingEnabled  -XX:+HeapDumpOnOutOfMemoryError -XX:+HeapDumpOnOutOfMemoryError  -XX:HeapDumpPath=/log/tmp/hbase/hbase_hbase-REGIONSERVER-58f025f30c5505722d8dee21c92b9469_pid15967.hprof -XX:OnOutOfMemoryError=/opt/cloudera/cm-agent/service/common/killparent.sh -Dhbase.log.dir=/log/hbase -Dhbase.log.file=hbase-cmf-hbase-REGIONSERVER-spbsjzy05.log.out -Dhbase.home.dir=/opt/cloudera/parcels/CDH-6.3.0-1.cdh6.3.0.p0.1279813/lib/hbase -Dhbase.id.str= -Dhbase.root.logger=INFO,RFA -Djava.library.path=/opt/cloudera/parcels/CDH-6.3.0-1.cdh6.3.0.p0.1279813/lib/hadoop/lib/native:/opt/cloudera/parcels/CDH-6.3.0-1.cdh6.3.0.p0.1279813/lib/hbase/lib/native/Linux-amd64-64 -Dhbase.security.logger=INFO,RFAS  java_command: org.apache.hadoop.hbase.regionserver.HRegionServer start {code}  " Upgrade spotbugs to 4.x,13360892,Resolved,Major,Fixed,25/Feb/21 07:48,10/Mar/21 07:00,, Support setting scan ReadType to be STREAM at cluster level,13358841,Resolved,Major,Fixed,16/Feb/21 10:58,10/Mar/21 07:59,2.0.0,"We have the config 'hbase.storescanner.use.pread' at cluster level to set ReadType to be PRead if not explicitly specified in Scan object. Same way we can have a way to make scan as STREAM type at cluster level (if not specified at Scan object level) We do not need any new configs or so. We have the config 'hbase.storescanner.pread.max.bytes' which specifies when to switch read type to stream and it defaults to 4 * HFile block size. If one config this value as <= 0 means user need the switch when scanner is created itself. With such a handling we can support it. So every scan need not set the read type. The issue is in Cloud storage based system using Stream reads might be better. We introduced this PRead based scan with tests on HDFS based storage. In my customer case, Azure storage in place and WASB driver been used. We have a read ahead mechanism there (Read an entire Block of a blob in one REST call) and buffer that in WASB driver. This helps a lot wrt longer scans. Ya with config 'hbase.storescanner.pread.max.bytes' we can make the switch to happen early but better to go with 1.x way where the scan starts with Stream read itself." Set switch compaction after bulkload default as false,13362202,Resolved,Major,Fixed,04/Mar/21 02:33,09/Mar/21 04:19,, Create table with rsgroup info in branch-2,13351381,Resolved,Major,Fixed,11/Jan/21 07:10,06/Mar/21 05:16,,"Currently we need to create table and then move it to desired RSGroup which cost HM assignment twice, considering table with many regions it will be huge. We have a use case where user want to create table with rsgroup. HBASE-22695 already implemented this feature in master branch but not ported to branch-2 because master and branch-2 implementations are different. This JIRA aims to implement this feature in branch-2. But unlike master branch, rsgroup information from TableDescriptor is used only while creating the table to keep the changes minimum. " Fix normalizer and TestSimpleRegionNormalizerOnCluster in branch-1 after HBASE-25592 HBASE-23932,13363158,Resolved,Major,Fixed,09/Mar/21 04:49,09/Mar/21 06:13,1.7.0,"On branch-1 run {{mvn test -Dtest=TestSimpleRegionNormalizerOnCluster}} It fails. It appears to be due to some problems in the refactoring related to HBASE-25592 and HBASE-23932.   {code:java} [INFO] Running org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 131.753 s <<< FAILURE! - in org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster [ERROR] testRegionNormalizationSplitOnCluster(org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster) Time elapsed: 60.107 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 60000 milliseconds at org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster.testRegionNormalizationSplitOnCluster(TestSimpleRegionNormalizerOnCluster.java:132) [ERROR] testRegionNormalizationMergeOnCluster(org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster) Time elapsed: 60.117 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 60000 milliseconds at org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster.testRegionNormalizationMergeOnCluster(TestSimpleRegionNormalizerOnCluster.java:199) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestSimpleRegionNormalizerOnCluster.testRegionNormalizationMergeOnCluster:199 » TestTimedOut [ERROR] TestSimpleRegionNormalizerOnCluster.testRegionNormalizationSplitOnCluster:132 TestTimedOut [INFO] [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0 {code}" Backporting HBASE-24885 to branch-2.2,13360896,Resolved,Major,Fixed,25/Feb/21 08:01,09/Mar/21 10:06,2.2.6,"On a 2.2 HBase cluster we just hit the very same ""HBCK2 assigns"" issue already fixed in HBASE-24885. This improvement would be very useful on branch-2.2 too. I'll submit a PR soon." ChoreService should be LimitedPrivate(COPROC),13363126,Resolved,Major,Duplicate,09/Mar/21 00:39,09/Mar/21 02:18,2.4.2,"ChoreService is marked Public and is in hbase-common but is not part of our public client API. We aren't providing a library for scheduling chores and such; we are providing a client library for accessing remote HBase service. As part of the server framework, where it could be useful for coprocessors, it makes more sense to expose it as supported for that purpose. I believe this was the intent of marking it Public. However I argue it should be LimitedPrivate(COPROC) instead, which is the appropriate classification for server internal components we want to expose to plug ins. " Possible Resource Leak in HeterogeneousRegionCountCostFunction,13361951,Resolved,Major,Fixed,02/Mar/21 20:17,08/Mar/21 14:51,1.6.0,"We noticed a possible resource leak [here|https://github.com/apache/hbase/blob/b522d2a33e31fbe70c341ea7068428ada8d51bc0/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java#L225]. close() is called on {{reader}} at line 228 but if an I/O error occurs at line 225, {{reader}} remains open since the exception isn't caught locally. I'll submit a pull request to fix it." Scan use prefix filter someValue case cause p99 very high,13362916,Open,Major,,08/Mar/21 05:41,,2.2.3,"There is some thing Wrong with the UseCase: use client scan API : scan(prefix, null, _caching, new FilterList(new PrefixFilter(prefix))); i find if there is a Space at the prefix end,there may be has a big filteredReadRequestCount in the regionserver which has the table region : !image-2021-03-08-13-37-40-574.png! so when the request the get P99 may be has a high value: !image-2021-03-08-13-40-06-900.png! so i want to know why  a Space at the prefix end can cause this issue" Expose drainingServers as cluster metric,13348988,Resolved,Major,Fixed,04/Jan/21 18:49,04/Mar/21 07:31,1.6.0,"Due to some reason, we had significantly high number of servers put in decommissioned mode and for significant time, they continued being in the same state serving no regions at all. This put heavy load on rest of live servers and it was too late before one could recognize the issues with improper balancing of the cluster. And as expected, balancing such cluster with/without *runMaxSteps* can bring up sudden spike of RITs in proportion to the degree of imbalanced regions in the cluster. Although running into such situation is rare, we can take some precautions by exposing metric. We should expose list of draining RegionServers as jmx metrics just like we expose _*liveRegionServers*_ and _*deadRegionServers*_. Such metric can help configure alerts with threshold on % of total RS that are allowed to go in draining mode (e.g during rolling upgrades) in any circumstances." 50% reading performance degradation 2.4.1 over 1.6.0,13361467,Open,Major,,28/Feb/21 19:45,,,"I have found performance issues. YCSB tests show:  *Operations per second (batch 1000)* | |*1.4.13*|*1.6.0*|*2.2.6*|*2.4.1*|*comments*| |INSERTS|68|68|75|76|< this is fine| |GETS|92|100|72|48|< 50% less than 1.6.0| |FLUSHED GETS|126|141|120|108|< not good| |GET+INSERT|69|71|68|66| |   GETS - means gets right after inserts. FLUSHED GETS - after flush and major compation All numbers are average of 3 runs. For example GETS 2.4.1 => (45 + 49 + 50) / 3 = 48 got from: — run 01 hdl300_LRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 108 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 45 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 76 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 66 — run 02 hdl300_LRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 109 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 49 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 77 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 66 — run 03 hdl300_LRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 108 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 50 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 76 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 65 But always were 4 runs (not 3). First run for warm up and excluded from aggregation (usually it is faster then all runs later). All test done with AdaptiveLRU (https://issues.apache.org/jira/browse/HBASE-23887) This is because: # RS on old LRU just often fall under pressure. # It is faster than current version (much faster when server powerful). For example on my PC (AMD Ryzen 7 2700X Eight-Core Processor, 32 GB MEM, SSD)  this is current version LRU (1.4.13): -- --- run 01 hdl300_oldLRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 116 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 76 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 67 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 65 --- run 02 hdl300_oldLRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 115 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 81 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 66 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 67 --- run 03 hdl300_oldLRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 116 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 82 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 66 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 66 This is new version (1.4.13): – run 01 hdl300_newLRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 128 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 93 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 67 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 70 — run 02 hdl300_newLRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 126 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 93 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 68 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 69 — run 03 hdl300_newLRU_thr30_reg100 — thr30 cnt100000 tim300 num0 max1 bch1000 reg100 fget ops= 125 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 get ops= 91 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 ins ops= 68 thr30 cnt100000 tim300 num0 max1 bch1000 reg100 upd ops= 67 All test done with the same params: hbase.cluster.distributed true hbase.tmp.dir ./tmp/hb hbase.rootdir /tmp/hbase hbase.unsafe.stream.capability.enforce false zookeeper.session.timeout 120000 hbase.rpc.timeout 120000 hbase.regionserver.handler.count 300 hbase.regionserver.metahandler.count 30 hbase.regionserver.maxlogs 200 hbase.hregion.memstore.flush.size 1342177280 hbase.hregion.memstore.block.multiplier 6 hbase.hstore.compactionThreshold 2 hbase.hstore.blockingStoreFiles 200 hbase.regionserver.optionalcacheflushinterval 18000000 hbase.regionserver.thread.compaction.large 12 hbase.regionserver.wal.enablecompression true hbase.server.compactchecker.interval.multiplier 200 hbase.rest.threads.min 8 hbase.rest.threads.max 150 hbase.thrift.minWorkerThreads 200 hbase.regionserver.thread.compaction.small 6 hbase.ipc.server.read.threadpool.size 60 hbase.lru.cache.heavy.eviction.count.limit 0 hbase.lru.cache.heavy.eviction.mb.size.limit 200 hbase.lru.cache.heavy.eviction.overhead.coefficient 0.01   hbase.wal.provider multiwal hbase.regionserver.throughput.controller org.apache.hadoop.hbase.regionserver.throttle.NoLimitThroughputController And everywhere export HBASE_HEAPSIZE=22G ZK is separate (downloaded from apache site) because RS just falls when use build-in ZK. Full logs in an attachment. Every one can repeat the tests. I used modificated YCSB (added batchsize) [https://github.com/pustota2009/YCSB.git] It is possible just: 1. Download and set up ZK [https://www.apache.org/dyn/closer.lua/zookeeper/zookeeper-3.6.2/apache-zookeeper-3.6.2-bin.tar.gz] 2. Download and set up HBase ([https://hbase.apache.org/downloads.html)] 3. Tune HBase (with params above) 4. Download [^scripts.zip] (there are YCSB and scripts) into hbase dir - the same level where bin, conf, log etc 5. Execute run-4-tests-30t-LRU.sh.   It will works about 1,5 hours and collect the results into hdl300_LRU_thr30_reg100.res and results_agg.txt Maybe somebody would interested to investigate the cause this degradation and fix it.  " The master local region is constantly major compact,13362558,Resolved,Major,Not A Problem,05/Mar/21 09:52,05/Mar/21 11:35,2.3.4,"In [MasterRegionFlusherAndCompactor.compact|https://github.com/apache/hbase/blob/830d2895b27fa0cf39a28d3af9673a4126ea8258/hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFlusherAndCompactor.java#L164], we call region.compact(true) constantly like recursion. This caused a lot of logs to be flushed." Add switch for compaction after bulkload,13360594,Resolved,Major,Fixed,24/Feb/21 11:27,04/Mar/21 02:24,,"when compaction after bulkload is enable,  if bulkload is continuous,  considerable compaction event will be triggered, which increase load, bring about  performance impact" Add detailed logs about which time zone is failing in TestCurrentHourProvider,13361437,Resolved,Major,Duplicate,28/Feb/21 13:25,04/Mar/21 02:43,,"https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2986/4/testReport/org.apache.hadoop.hbase.regionserver.compactions/TestCurrentHourProvider/precommit_checks___yetus_jdk11_hadoop3_checks___testWithEnvironmentEdge/ It passed for me locally and no one touches it recently, not sure why it is failing. Digging." ExportSnapshot chmod flag uses value as decimal,13361213,Resolved,Major,Fixed,26/Feb/21 15:42,02/Mar/21 10:51,2.0.0,"ExportSnapshot reads the chmod flag as a decimal value. In HBase 1 the value is handled as octal as an operator expects it. As an example -chmod 755 will result in the following permission: {noformat} --wxrw--wt 3 hbase hbase 13314534 2021-02-25 12:38 /tmp/chmod755/archive/data/default/cluster_test/045e4c368075d2c6d947cba7140c443a/test_cf/f7d5156d44974e7da8c983f08512f6a0 {noformat} This bug was introduced in HBase 2.0.0 with the migration to Apache CLI. Workaround: Use the decimal representation. 755 -> 493 " Release scripts should include in the vote email the git hash that the RC tag points to,13358516,Resolved,Major,Fixed,14/Feb/21 05:24,03/Mar/21 00:22,,"the git tags for release candidates are not protected, so they could change after a RM posts a release candidate. the vote text should include the git hash that the RC tag points to at the time of the vote so a change can easily be seen." Increase timeout value for pre commit,13361485,Resolved,Major,Fixed,01/Mar/21 01:44,01/Mar/21 06:18,,"A full jdk8 build on our pre commit machines still can not finish within 7 hours after upgrading to the newest jdk8. Let's increase the timeout value for now. Later we could see if it is possible to make the tests run faster, by set reuseForks to true or something." Upgrade java version in pre commit docker file,13361326,Resolved,Major,Fixed,27/Feb/21 08:42,27/Feb/21 13:32,, Remove search hadoop references in book,13360446,Resolved,Major,Fixed,23/Feb/21 21:46,25/Feb/21 16:57,,Remove references to this newly-owned domain. Fix broken TestReplicationShell on master,13360470,Resolved,Major,Fixed,24/Feb/21 01:55,25/Feb/21 00:40,,"It is introduced by HBASE-25522, where we removed the deprecated methods in ReplicationPeerConfig but they are still referenced in shell." [HBCK2] New check to prevent assign of already opened regions,13360902,Open,Major,,25/Feb/21 08:15,,hbase-operator-tools-1.1.0,"Currently, if we don't have HBASE-24885 on the cluster and we use HBCK2 assigns command to assign an already OPEN region (even without the --override flag), then it can cause a stuck Region-In-Transition and a wrong OPENING state in the meta (or even a double assignment of the same region on two RS). This happens because the HBase master RPC endpoint doesn't check if the region is already opened or not. The issue was fixed in HBASE-24885, but it still remain a problem in previous HBase versions (2.2 and also 2.3.0 and 2.3.1. ) We could add some mechanism into HBCK2 to do a check and don't execute the assign command if the region is OPEN in the meta. (we could also add a 'force' flag to bypass this check). The new check should run only if HBASE-24885 is not present yet on the cluster (we could validate the cluster version)" TestFromClientSide5.testScanMetrics is flaky,13360278,Resolved,Major,Fixed,23/Feb/21 08:17,24/Feb/21 06:50,2.3.4,"In some PRs, I got the following errors in UT results. {code:java} [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.client.TestFromClientSide5.testScanMetrics[0] [ERROR] Run 1: TestFromClientSide5.testScanMetrics:1018 Did not count the result bytes expected:<60> but was:<120> [ERROR] Run 2: TestFromClientSide5.testScanMetrics:1036 Did not count the result bytes expected:<60> but was:<180> [ERROR] Run 3: TestFromClientSide5.testScanMetrics:951 » MasterRegistryFetch Exception making... [INFO] [ERROR] org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor5.testScanMetrics[1] [ERROR] Run 1: TestFromClientSideWithCoprocessor5>TestFromClientSide5.testScanMetrics:1036 Did not count the result bytes expected:<60> but was:<120> [ERROR] Run 2: TestFromClientSideWithCoprocessor5>TestFromClientSide5.testScanMetrics:951 » IO [ERROR] Run 3: TestFromClientSideWithCoprocessor5>TestFromClientSide5.testScanMetrics:951 » IO [INFO] {code} I read the code further and found that this UT is flaky. {code:java} // check byte counters scan2 = new Scan(); scan2.setScanMetricsEnabled(true); scan2.setCaching(1); try (ResultScanner scanner = ht.getScanner(scan2)) { int numBytes = 0; for (Result result : scanner.next(1)) { for (Cell cell : result.listCells()) { numBytes += PrivateCellUtil.estimatedSerializedSizeOf(cell); } } scanner.close(); ScanMetrics scanMetrics = scanner.getScanMetrics(); assertEquals(""Did not count the result bytes"", numBytes, scanMetrics.countOfBytesInResults.get()); } {code} In the code above, it is to check scanMetrics.countOfBytesInResults, but just get only ONE row by scanner.next(1) . A total of 3 rows are inserted into the table, and scanner prefetch from server in advance until maxCacheSize is exceeded, see [here|https://github.com/apache/hbase/blob/5fa15cfde3d77e77ffb1f09d60dce4db264f3831/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableResultScanner.java#L94]. So if scanner prefetch more than one row before closing scanner, the UT fails. we can reproduce this problem steadily by sleeping before scanner.close()." Add metric for age of oldest wal.,13355458,Resolved,Major,Fixed,29/Jan/21 15:18,22/Feb/21 23:01,1.6.0,"In our production clusters, we have seen multiple cases where some of the wals are lingering in zk replication queues for months and we have no insight into it. Recently we fixed one case where wal was getting stuck if it is 0 size and from old sources. HBASE-25536. It would be helpful if we can have some metric which will tell us the age of oldest wal and we can add an alert for monitoring purpose." Revisit put/delete/increment/append related RegionObserver methods,13358471,Resolved,Major,Fixed,13/Feb/21 11:55,22/Feb/21 01:34,,"After HBASE-24602, increment/append operations are performed in HRegion.batchMutate(). Accordingly, we should make some changes for the increment/append related RegionObserver methods." "HBase filesystem repo should have a ""release"" maven profile",13358439,Resolved,Major,Fixed,13/Feb/21 03:19,20/Feb/21 07:36,,"Trying to run a RC for the hbase-filesystem project fails in dryrun because there isn't a ""release"" profile and the RC creation scripts require one." HBase operator tools pom should include nexus staging repo management,13358499,Resolved,Major,Fixed,13/Feb/21 18:40,20/Feb/21 07:24,,"The current RC creation scripts rely on project poms having a plugin configured to handle nexus staging repository closing / dropping. The hbase-operator-tools project is currently missing this plugin, which makes it so that a RM has to go manually close the staging repository and then copy the location into the generated vote text. the needed plugin config is: {code} apache-release org.sonatype.plugins nexus-staging-maven-plugin 1.6.8 true https://repository.apache.org/ apache.releases.https {code}" "In WALEntryStream, set the current path to null while dequeing the log",13356036,Resolved,Major,Fixed,01/Feb/21 19:33,18/Feb/21 06:30,1.6.0, HBase filesystem pom should include nexus staging repo management,13358500,Resolved,Major,Fixed,13/Feb/21 18:46,15/Feb/21 12:40,hbase-filesystem-1.0.0-alpha1,"The current RC creation scripts rely on project poms having a plugin configured to handle nexus staging repository closing / dropping. The hbase-filesystem project is currently missing this plugin, which makes it so that a RM has to go manually close the staging repository and then copy the location into the generated vote text. the needed plugin config is: {code} apache-release org.sonatype.plugins nexus-staging-maven-plugin 1.6.8 true https://repository.apache.org/ apache.releases.https {code}" Compilation error in branch-2 after HBASE-25364,13358388,Resolved,Major,Fixed,12/Feb/21 17:50,13/Feb/21 16:12,,"{code:java} [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /D:/code/apache/forked/hbaseBranch2/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java:[737,12] cannot find symbol symbol: method getCell(byte[],byte[],byte[]) location: class org.apache.hadoop.hbase.io.hfile.TestHFile [ERROR] /D:/code/apache/forked/hbaseBranch2/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java:[738,13] cannot find symbol symbol: method getCell(byte[],byte[],byte[]) location: class org.apache.hadoop.hbase.io.hfile.TestHFile [ERROR] /D:/code/apache/forked/hbaseBranch2/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java:[744,12] cannot find symbol symbol: method getCell(byte[],byte[],byte[]) location: class org.apache.hadoop.hbase.io.hfile.TestHFile [ERROR] /D:/code/apache/forked/hbaseBranch2/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java:[745,13] cannot find symbol symbol: method getCell(byte[],byte[],byte[]) location: class org.apache.hadoop.hbase.io.hfile.TestHFile [INFO] 4 errors {code}" Hbase connector with apache spark,13356714,Resolved,Major,Invalid,04/Feb/21 09:39,12/Feb/21 09:08,,Hbase connector with apache HRegionFileSystem.loadRegionInfoFileContent throws IOException occasionally,13358242,Open,Major,,11/Feb/21 21:49,,2.1.4,"We invoked HRegionFileSystem.loadRegionInfoFileContent to read .regioninfo from hdfs, but get an exception occasionally {code:java} Caused by: java.io.IOException: read=3, wanted=4 at org.apache.hadoop.hbase.client.RegionInfo.parseFrom(RegionInfo.java:743) at org.apache.hadoop.hbase.regionserver.HRegionFileSystem.loadRegionInfoFileContent(HRegionFileSystem.java:856){code}" "test fails on AArch64, Fedora 33, but build worked",13358132,Resolved,Major,Invalid,11/Feb/21 09:49,11/Feb/21 16:41,,"[jw@cn06 hbase]$ [jw@cn06 hbase]$ mvn install [INFO] Scanning for projects... [INFO] ------------------------------------------------------------------------ [INFO] Detecting the operating system and CPU architecture [INFO] ------------------------------------------------------------------------ [INFO] os.detected.name: linux [INFO] os.detected.arch: aarch_64 [INFO] os.detected.version: 5.8 [INFO] os.detected.version.major: 5 [INFO] os.detected.version.minor: 8 [INFO] os.detected.release: fedora [INFO] os.detected.release.version: 33 [INFO] os.detected.release.like.fedora: true [INFO] os.detected.classifier: linux-aarch_64 [INFO] ------------------------------------------------------------------------ [INFO] Reactor Build Order: [INFO] [INFO] Apache HBase [pom] [INFO] Apache HBase - Checkstyle [jar] [INFO] Apache HBase - Annotations [jar] [INFO] Apache HBase - Build Configuration [pom] [INFO] Apache HBase - Logging [jar] [INFO] Apache HBase - Shaded Protocol [jar] [INFO] Apache HBase - Common [jar] [INFO] Apache HBase - Metrics API [jar] [INFO] Apache HBase - Metrics Implementation [jar] [INFO] Apache HBase - Hadoop Compatibility [jar] [INFO] Apache HBase - Client [jar] [INFO] Apache HBase - Zookeeper [jar] [INFO] Apache HBase - Replication [jar] [INFO] Apache HBase - Balancer [jar] [INFO] Apache HBase - Resource Bundle [jar] [INFO] Apache HBase - HTTP [jar] [INFO] Apache HBase - Asynchronous FileSystem [jar] [INFO] Apache HBase - Procedure [jar] [INFO] Apache HBase - Server [jar] [INFO] Apache HBase - MapReduce [jar] [INFO] Apache HBase - Testing Util [jar] [INFO] Apache HBase - Thrift [jar] [INFO] Apache HBase - Shell [jar] [INFO] Apache HBase - Coprocessor Endpoint [jar] [INFO] Apache HBase - Backup [jar] [INFO] Apache HBase - Integration Tests [jar] [INFO] Apache HBase - Rest [jar] [INFO] Apache HBase - Examples [jar] [INFO] Apache HBase - Shaded [pom] [INFO] Apache HBase - Shaded - Client (with Hadoop bundled) [jar] [INFO] Apache HBase - Shaded - Client [jar] [INFO] Apache HBase - Shaded - MapReduce [jar] [INFO] Apache HBase - External Block Cache [jar] [INFO] Apache HBase - HBTop [jar] [INFO] Apache HBase - Assembly [pom] [INFO] Apache HBase - Shaded - Testing Util [jar] [INFO] Apache HBase - Shaded - Testing Util Tester [jar] [INFO] Apache HBase Shaded Packaging Invariants [pom] [INFO] Apache HBase Shaded Packaging Invariants (with Hadoop bundled) [pom] [INFO] Apache HBase - Archetypes [pom] [INFO] Apache HBase - Exemplar for hbase-client archetype [jar] [INFO] Apache HBase - Exemplar for hbase-shaded-client archetype [jar] [INFO] Apache HBase - Archetype builder [pom] [INFO] [INFO] -----------------------< org.apache.hbase:hbase >----------------------- [INFO] Building Apache HBase 3.0.0-SNAPSHOT [1/43] [INFO] --------------------------------[ pom ]--------------------------------- [INFO] [INFO] --- build-helper-maven-plugin:3.0.0:bsh-property (negate-license-bundles-property) @ hbase --- [INFO] ... [INFO] Running org.apache.hadoop.hbase.TestTagRewriteCell [INFO] Running org.apache.hadoop.hbase.TestSerialization [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.48 s - in org.apache.hadoop.hbase.TestTagRewriteCell [INFO] Running org.apache.hadoop.hbase.TestIPv6NIOServerSocketChannel [INFO] Running org.apache.hadoop.hbase.TestNodeHealthCheckChore [INFO] Running org.apache.hadoop.hbase.TestCheckTestClasses [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.344 s - in org.apache.hadoop.hbase.TestIPv6NIOServerSocketChannel [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.514 s - in org.apache.hadoop.hbase.executor.TestExecutorService [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.847 s - in org.apache.hadoop.hbase.quotas.TestSpaceQuotaOnNonExistingTables [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.807 s - in org.apache.hadoop.hbase.TestExecutorStatusChore [INFO] Running org.apache.hadoop.hbase.TestServerMetrics [INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.907 s - in org.apache.hadoop.hbase.TestSerialization [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.993 s - in org.apache.hadoop.hbase.TestServerMetrics [INFO] Running org.apache.hadoop.hbase.TestHDFSBlocksDistribution [INFO] Running org.apache.hadoop.hbase.protobuf.TestReplicationProtobuf [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.71 s - in org.apache.hadoop.hbase.TestHDFSBlocksDistribution [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.372 s - in org.apache.hadoop.hbase.protobuf.TestReplicationProtobuf [INFO] Running org.apache.hadoop.hbase.TestFSTableDescriptorForceCreation [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.057 s - in org.apache.hadoop.hbase.TestFSTableDescriptorForceCreation [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.474 s - in org.apache.hadoop.hbase.TestCheckTestClasses [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.145 s - in org.apache.hadoop.hbase.TestNodeHealthCheckChore [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestCurrentHourProvider.testWithEnvironmentEdge:66 expected:<11> but was:<12> [INFO] [ERROR] Tests run: 1051, Failures: 1, Errors: 0, Skipped: 4 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache HBase 3.0.0-SNAPSHOT: [INFO] [INFO] Apache HBase ....................................... SUCCESS [ 6.367 s] [INFO] Apache HBase - Checkstyle .......................... SUCCESS [ 1.735 s] [INFO] Apache HBase - Annotations ......................... SUCCESS [ 2.214 s] [INFO] Apache HBase - Build Configuration ................. SUCCESS [ 0.253 s] [INFO] Apache HBase - Logging ............................. SUCCESS [ 1.163 s] [INFO] Apache HBase - Shaded Protocol ..................... SUCCESS [02:10 min] [INFO] Apache HBase - Common .............................. SUCCESS [01:40 min] [INFO] Apache HBase - Metrics API ......................... SUCCESS [ 8.002 s] [INFO] Apache HBase - Metrics Implementation .............. SUCCESS [ 8.758 s] [INFO] Apache HBase - Hadoop Compatibility ................ SUCCESS [ 22.949 s] [INFO] Apache HBase - Client .............................. SUCCESS [ 55.422 s] [INFO] Apache HBase - Zookeeper ........................... SUCCESS [ 32.489 s] [INFO] Apache HBase - Replication ......................... SUCCESS [ 15.342 s] [INFO] Apache HBase - Balancer ............................ SUCCESS [ 9.921 s] [INFO] Apache HBase - Resource Bundle ..................... SUCCESS [ 0.400 s] [INFO] Apache HBase - HTTP ................................ SUCCESS [ 36.334 s] [INFO] Apache HBase - Asynchronous FileSystem ............. SUCCESS [ 43.088 s] [INFO] Apache HBase - Procedure ........................... SUCCESS [02:38 min] [INFO] Apache HBase - Server .............................. FAILURE [06:06 min] [INFO] Apache HBase - MapReduce ........................... SKIPPED [INFO] Apache HBase - Testing Util ........................ SKIPPED [INFO] Apache HBase - Thrift .............................. SKIPPED [INFO] Apache HBase - Shell ............................... SKIPPED [INFO] Apache HBase - Coprocessor Endpoint ................ SKIPPED [INFO] Apache HBase - Backup .............................. SKIPPED [INFO] Apache HBase - Integration Tests ................... SKIPPED [INFO] Apache HBase - Rest ................................ SKIPPED [INFO] Apache HBase - Examples ............................ SKIPPED [INFO] Apache HBase - Shaded .............................. SKIPPED [INFO] Apache HBase - Shaded - Client (with Hadoop bundled) SKIPPED [INFO] Apache HBase - Shaded - Client ..................... SKIPPED [INFO] Apache HBase - Shaded - MapReduce .................. SKIPPED [INFO] Apache HBase - External Block Cache ................ SKIPPED [INFO] Apache HBase - HBTop ............................... SKIPPED [INFO] Apache HBase - Assembly ............................ SKIPPED [INFO] Apache HBase - Shaded - Testing Util ............... SKIPPED [INFO] Apache HBase - Shaded - Testing Util Tester ........ SKIPPED [INFO] Apache HBase Shaded Packaging Invariants ........... SKIPPED [INFO] Apache HBase Shaded Packaging Invariants (with Hadoop bundled) SKIPPED [INFO] Apache HBase - Archetypes .......................... SKIPPED [INFO] Apache HBase - Exemplar for hbase-client archetype . SKIPPED [INFO] Apache HBase - Exemplar for hbase-shaded-client archetype SKIPPED [INFO] Apache HBase - Archetype builder ................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 16:45 min [INFO] Finished at: 2021-02-11T10:44:56+01:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test (default-test) on project hbase-server: There are test failures. [ERROR] [ERROR] Please refer to /data/jw/apache/hbase/hbase-server/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :hbase-server [jw@cn06 hbase]$ " BLOCKSIZE needs to support pretty print,13353241,Resolved,Major,Fixed,19/Jan/21 10:22,09/Feb/21 15:28,2.5.0,"HBASE-25439 added a new unit in PrettyPrint.Unit, the BLOCKSIZE in CF should also support this feature." Terminate threads of oldsources while RS is closing,13357481,Resolved,Major,Fixed,08/Feb/21 09:33,09/Feb/21 09:26,2.2.6, "Drop ""2.2 Documentation"" from the website",13357982,Open,Major,,10/Feb/21 17:12,,3.0.0-alpha-1,2.2 is EOL. Let's remove the docs. "Leak of ESTABLISHED sockets when compaction encountered ""java.io.IOException: Invalid HFile block magic""",13352243,Resolved,Major,Fixed,14/Jan/21 12:16,09/Feb/21 06:18,2.4.1,"Recently, we found socket leaks on our production cluster. The leaked sockets are in ESTABLISHED state. We found this happened on RS who owned a particular region from our analysis of metrics monitor and logs. RS without this region works normally.  On the RS who owns the particular region, we found Exceptions as follows, {code:java} java.io.IOException: java.io.IOException: Could not seek StoreFileScanner[org.apache.hadoop.hbase.ioo .HalfStoreFileReader$1@5388be2f, cur=null] to key org.apache.hadoop.hbase.CellUtil$FirstOnRowDeleteFF amilyCell@25aa56fd         at org.apache.hadoop.hbase.regionserver.StoreScanner.parallelSeek(StoreScanner.java:1128)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekScanners(StoreScanner.java:437)         at org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:329)         at org.apache.hadoop.hbase.regionserver.StoreScanner.(StoreScanner.java:302)         at org.apache.hadoop.hbase.regionserver.compactions.Compactor.createScanner(Compactor.java:88 06)         at org.apache.hadoop.hbase.regionserver.compactions.StripeCompactor$StripeInternalScannerFacc tory.createScanner(StripeCompactor.java:82)         at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:316)         at org.apache.hadoop.hbase.regionserver.compactions.StripeCompactor.compact(StripeCompactor.. java:120)         at org.apache.hadoop.hbase.regionserver.compactions.StripeCompactionPolicy$SplitStripeCompacc tionRequest.execute(StripeCompactionPolicy.java:662)         at org.apache.hadoop.hbase.regionserver.StripeStoreEngine$StripeCompaction.compact(StripeStoo reEngine.java:114)         at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1461)         at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2121)         at org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.doCompaction(Comm pactSplitThread.java:519)         at org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitt Thread.java:555)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:745) Caused by: java.io.IOException: Could not seek StoreFileScanner[org.apache.hadoop.hbase.io.HalfStoree FileReader$1@5388be2f, cur=null] to key org.apache.hadoop.hbase.CellUtil$FirstOnRowDeleteFamilyCell@@ 25aa56fd         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:229)         at org.apache.hadoop.hbase.regionserver.handler.ParallelSeekHandler.process(ParallelSeekHandd ler.java:56)         at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129)         ... 3 more Caused by: java.io.IOException: Invalid HFile block magic: \x00\x00\x00\x00\x00\x00\x00\x00         at org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:159)         at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:171)         at org.apache.hadoop.hbase.io.hfile.HFileBlock.createFromBuff(HFileBlock.java:333) at org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl.readBlockDataInternal(HFileBlockk .java:1753)         at org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl.readBlockData(HFileBlock.java:155 52)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:539)         at org.apache.hadoop.hbase.io.hfile.HFileScannerImpl.readAndUpdateNewBlock(HFileScannerImpl.. java:737)         at org.apache.hadoop.hbase.io.hfile.HFileScannerImpl.seekTo(HFileScannerImpl.java:726)         at org.apache.hadoop.hbase.io.HalfStoreFileReader$1.seekTo(HalfStoreFileReader.java:161)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.javaa :315)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:211)         ... 5 more {code} The count of established sockets is always increasing, see picture, !increasing-of-established-sockets-image.png|width=833,height=390!   !problem-region-move-logs.png|width=942,height=319! !errorlogs.png|width=722,height=411!            " Remove unused parameter named peerId in the constructor method of CatalogReplicationSourcePeer,13357504,Resolved,Major,Fixed,08/Feb/21 11:16,08/Feb/21 20:32,2.4.2, hbase 3.0.0 example source not usable due to hbase-asyncfs-3.0.0-SNAPSHOT jar not found,13354738,Resolved,Major,Invalid,26/Jan/21 18:43,05/Feb/21 22:03,,"tried to run maven on the example client pom for hbase 3.0.0.  [ERROR] Failed to execute goal on project hbase-examples: Could not resolve dependencies for project org.apache.hbase:hbase-examples:jar:3.0.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.hbase:hbase-asyncfs:jar:3.0.0-SNAPSHOT, org.apache.hbase:hbase-replication:jar:3.0.0-SNAPSHOT: Failure to find org.apache.hbase:hbase-asyncfs:jar:3.0.0-SNAPSHOT in https://repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of apache.snapshots has elapsed or updates are forced -> [Help 1]   I can't seem to find this jar and the link that points to the jar is dead. " Fix the build problem for branch-2.2,13356152,Resolved,Major,Fixed,02/Feb/21 09:44,03/Feb/21 12:34,2.2.7, Compilation failed due to conflict of plugin dependent packages,13351477,Resolved,Major,Not A Problem,11/Jan/21 13:28,01/Feb/21 17:21,3.0.0-alpha-1,"Compile the project fails, error messages are as follow. My maven version is 3.6.3 {code:java} [ERROR] Failed to execute goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile (compile-protoc) on project hbase-protocol-shaded: Execution compile-protoc of goal org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile failed: A required class was missing while executing org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile: org/codehaus/plexus/util/io/InputStreamFacade [ERROR] ----------------------------------------------------- [ERROR] realm =    plugin>org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1 [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy [ERROR] urls[0] = file:/Users/haxl/.m2/repository/org/xolstice/maven/plugins/protobuf-maven-plugin/0.6.1/protobuf-maven-plugin-0.6.1.jar [ERROR] urls[1] = file:/Users/haxl/.m2/repository/org/codehaus/plexus/plexus-utils/1.1/plexus-utils-1.1.jar [ERROR] Number of foreign imports: 1 [ERROR] import: Entry[import  from realm ClassRealm[project>org.apache.hbase:hbase:3.0.0-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]] [ERROR] [ERROR] ----------------------------------------------------- [ERROR] : org.codehaus.plexus.util.io.InputStreamFacade [ERROR] -> [Help 1] [ERROR] {code}" The metadata of the table and family should not be an empty string,13354803,Resolved,Major,Fixed,27/Jan/21 03:18,29/Jan/21 15:37,,"If the metadata of the table is set to null, the metadata will be removed. The code is: [https://github.com/apache/hbase/blob/b07549febb462b072792659051c64bb54d122771/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L721] But if set metadata as empty string, serious errors may occur. Some metadata is number, it will throw a NumberFormatException when converting empty string to a number. If the exception is thrown when the region is initialized, all regions of the table will be in RIT. The following command can reproduced this issue. *Note: Please execute in the test environment.* {code:java} alter 'test_table', CONFIGURATION => {'hbase.rs.cachecompactedblocksonwrite.threshold' => ''} {code}  " Remove 0 length wal file from logQueue if it belongs to old sources.,13355218,Resolved,Major,Fixed,28/Jan/21 15:13,29/Jan/21 12:33,1.6.0,"In our production clusters, we found one case where RS is not removing 0 length file from replication queue (in memory one not the zk replication queue) if the logQueue size is 1. Stack trace below: {noformat} 2021-01-28 14:44:18,434 ERROR [,60020,1609950703085] regionserver.ReplicationSourceWALReaderThread - Failed to read stream of replication entries org.apache.hadoop.hbase.replication.regionserver.WALEntryStream$WALEntryStreamRuntimeException: java.io.EOFException: hdfs://hbase/oldWALs/%2C60020%2C1606126266791.1606852981112 not a SequenceFile at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:110) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReaderThread.run(ReplicationSourceWALReaderThread.java:147) Caused by: java.io.EOFException: hdfs://hbase/oldWALs/%2C60020%2C1606126266791.1606852981112 not a SequenceFile at org.apache.hadoop.io.SequenceFile$Reader.init(SequenceFile.java:1934) at org.apache.hadoop.io.SequenceFile$Reader.initialize(SequenceFile.java:1893) at org.apache.hadoop.io.SequenceFile$Reader.(SequenceFile.java:1842) at org.apache.hadoop.io.SequenceFile$Reader.(SequenceFile.java:1856) at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader$WALReader.(SequenceFileLogReader.java:70) at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.reset(SequenceFileLogReader.java:168) at org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogReader.initReader(SequenceFileLogReader.java:177) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:66) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:313) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:277) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:265) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:424) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:338) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:304) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:295) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:198) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:108) ... 1 more {noformat} The wal in question is of length 0 (verified via hadoop ls command) and is from recovered sources. There is just 1 log file in the queue (verified via heap dump).  We have logic to remove 0 length log file from queue when we encounter EOFException and logQueue#size is greater than 1. Code snippet below. {code:java|title=ReplicationSourceWALReader.java|borderStyle=solid} // if we get an EOF due to a zero-length log, and there are other logs in queue // (highly likely we've closed the current log), we've hit the max retries, and autorecovery is // enabled, then dump the log private void handleEofException(IOException e) { if ((e instanceof EOFException || e.getCause() instanceof EOFException) && logQueue.size() > 1 && this.eofAutoRecovery) { try { if (fs.getFileStatus(logQueue.peek()).getLen() == 0) { LOG.warn(""Forcing removal of 0 length log in queue: "" + logQueue.peek()); logQueue.remove(); currentPosition = 0; } } catch (IOException ioe) { LOG.warn(""Couldn't get file length information about log "" + logQueue.peek()); } } } {code} This size check is valid for active sources where we need to have atleast one wal file which is the current wal file but for recovered sources where we don't add current wal file to queue, we can skip the logQueue#size check." Region normalizer chore thread is getting killed,13353788,Resolved,Major,Fixed,21/Jan/21 15:21,29/Jan/21 18:05,1.6.0,"Region normalizer chore thread is getting killed when the region is not found on any server. As per the method {code:java} // code placeholder /** * @param serverName * @return ServerLoad if serverName is known else null */ public ServerLoad getLoad(final ServerName serverName) { return this.onlineServers.get(serverName); } {code}  So ideally we should check for the returned null in SimpleRegionNormalizer      " ServerManager affects MTTR of HMaster,13352214,Resolved,Major,Fixed,14/Jan/21 09:46,28/Jan/21 14:59,3.0.0-alpha-1,"https://github.com/apache/hbase/blob/3488c44a21612aae1835fc3e91a4a12ed2abb8b7/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java#L925 If a cluster has N+W regions, this removeDeletedRegionFromLoadedFlushedSequenceIds takes a long time... !image-2021-01-14-17-44-16-091.png! !image-2021-01-14-17-44-42-181.png! " "[hbase-operator-tools]Fix OOME ""unable to create new native thread"" on UTs",13354651,Resolved,Major,Fixed,26/Jan/21 11:44,27/Jan/21 21:02,hbase-operator-tools-1.0.0,"Have noticed some UTs sporadically failing with OOME ""unable to create new native thread"". This does happen when running locally. Talked to [~psomogyi] and he was suggesting some environment changes to be set on docker personality script. Opening this one to try having this fixed." "Backup not using parameters such as bandwidth, workers, etc while exporting snapshot",13351932,Resolved,Major,Fixed,13/Jan/21 07:00,26/Jan/21 06:40,3.0.0-alpha-1,"  {code:java} // code placeholder $ sudo /etc/init.d/yak master hbase backup create Please make sure that backup is enabled on the cluster. To enable backup, in hbase-site.xml, set: hbase.backup.enable=true hbase.master.logcleaner.plugins=YOUR_PLUGINS,org.apache.hadoop.hbase.backup.master.BackupLogCleaner hbase.procedure.master.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager hbase.procedure.regionserver.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager hbase.coprocessor.region.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.BackupObserver and restart the clusterUsage: hbase backup create [options] type ""full"" to create a full backup image ""incremental"" to create an incremental backup image backup_path Full path to store the backup imageOptions: -b Bandwidth per task (MapReduce task) in MB/s -d Enable debug loggings -q Yarn queue name to run backup create command on -s Backup set to backup, mutually exclusive with -t (table list) -t Table name list, comma-separated. -w Number of parallel MapReduce tasks to execute {code} Parameters -b, -q, -w are not being used when creating a export snapshot request  {code:java} // code placeholder for (TableName table : backupInfo.getTables()) { // Currently we simply set the sub copy tasks by counting the table snapshot number, we can // calculate the real files' size for the percentage in the future. // backupCopier.setSubTaskPercntgInWholeTask(1f / numOfSnapshots); int res; String[] args = new String[4]; args[0] = ""-snapshot""; args[1] = backupInfo.getSnapshotName(table); args[2] = ""-copy-to""; args[3] = backupInfo.getTableBackupDir(table); String jobname = ""Full-Backup_"" + backupInfo.getBackupId() + ""_"" + table.getNameAsString(); if (LOG.isDebugEnabled()) { LOG.debug(""Setting snapshot copy job name to : "" + jobname); } conf.set(JOB_NAME_CONF_KEY, jobname); LOG.debug(""Copy snapshot "" + args[1] + "" to "" + args[3]); res = copyService.copy(backupInfo, backupManager, conf, BackupType.FULL, args); // if one snapshot export failed, do not continue for remained snapshots if (res != 0) { LOG.error(""Exporting Snapshot "" + args[1] + "" failed with return code: "" + res + "".""); throw new IOException(""Failed of exporting snapshot "" + args[1] + "" to "" + args[3] + "" with reason code "" + res); } conf.unset(JOB_NAME_CONF_KEY); LOG.info(""Snapshot copy "" + args[1] + "" finished.""); } {code}" WALKey Extended Attributes don't serialize to ReplicationSink,13353870,Resolved,Major,Fixed,21/Jan/21 23:29,25/Jan/21 16:38,1.5.0,"HBASE-22622 introduced extended attributes on the WALKey object and protobuf, and HBASE-22623 created a coprocessor hook, preWALAppend, so that coprocessors can create and insert their own extended attributes. These attributes are readable on the source-side, such as in a custom ReplicationEndpoint. However, in branch-1 ReplicationProtbufUtil doesn't correctly populate the extended attributes on the WALKey protobuf. (In 2.1+, HBASE-20625 incidentally fixes this as part of a larger refactoring of WALCellCodec logic.) This means that a custom ReplicationSink can't read extended attributes on a WALKey." Implement more detailed tracing in HBase,13353882,Open,Major,,22/Jan/21 02:20,,,This is a follow up issue of HBASE-22120. ChoreService.cancelChore will not call ScheduledChore.cleanup which may lead to resource leak,13352380,Resolved,Major,Fixed,15/Jan/21 00:57,20/Jan/21 15:38,, add get_namespace_rsgroup command,13351633,Resolved,Major,Fixed,12/Jan/21 03:35,19/Jan/21 10:00,, At a glance git branch release history tool,13352540,Open,Major,,15/Jan/21 18:39,,,"We do not have a single source of truth as to what are active branches and what was the most recent release by version number made from each branch. If we had such a resource, then committers could refer to it whenever merging PRs or cherry picking commits backward. When merging a PR into a branch or committing a cherry pick it is important that the committer, at that time, go to JIRA and update fix versions on the corresponding issue, so that at the next release the change will be correctly included in the change log. Perhaps something can be created that takes the union of git branch listing and reporter.a.o release version history. " [branch-2.4] Restore method removed by HBASE-25277 to LP(CONFIG) coprocessors,13352064,Resolved,Major,Fixed,13/Jan/21 17:54,13/Jan/21 18:13,2.4.1,"We can't do this in a patch release on a LimitedPrivate interface: {code} - @Override - public boolean postScannerFilterRow(final ObserverContext e, - final InternalScanner s, final Cell curRowCell, final boolean hasMore) throws IOException { - // 'default' in RegionObserver might do unnecessary copy for Off heap backed Cells. - return hasMore; - } {code}" IntegrationTestMTTR fails with TableNotFoundException,13351972,Resolved,Major,Fixed,13/Jan/21 10:18,13/Jan/21 19:04,,"Admin.getDescriptor() fails beacuse table doesn't exist.   {noformat} org.apache.hadoop.hbase.TableNotFoundException: IntegrationTestMTTR at java.lang.Thread.getStackTrace(Thread.java:1559) at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130) at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:149) at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:172) at org.apache.hadoop.hbase.client.AdminOverAsyncAdmin.getDescriptor(AdminOverAsyncAdmin.java:163) at org.apache.hadoop.hbase.mttr.IntegrationTestMTTR.setupTables(IntegrationTestMTTR.java:236) at org.apache.hadoop.hbase.mttr.IntegrationTestMTTR.setUp(IntegrationTestMTTR.java:179) {noformat}    " HBase code download is failing on windows with invalid path error,13352039,Resolved,Major,Fixed,13/Jan/21 15:47,13/Jan/21 17:52,,"git pull command is failing with ""error: invalid path"" {noformat} Host1 MINGW64 /d/hbase (master) $ git pull error: invalid path 'dev-support/design-docs/HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf' Updating 2e96a5b2d3..dfefff7e59{noformat} This problem is coming only on windows machines. Tried on windows 7 and windows 10 both have problem. Searched on net, seems no any easy solution. Problem is because file HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf has colon in its name. To fix the problem we should remove the colon : from file name" Enable error prone check in pre commit,13350902,Resolved,Major,Fixed,07/Jan/21 13:58,13/Jan/21 08:43,,"This has been a pain in the past as the output is not stable, but in HBASE-25333, we found that some checks in error prone is really useful. So here I think we need to find a way to try to enable it again in pre commit. Maybe we could only check for ERROR level problems as it will cause compilation error." False-positive findbugs issue on branch-2.2,13351694,Resolved,Major,Fixed,12/Jan/21 09:15,13/Jan/21 08:07,2.2.7,"Findbugs reports a false-positive issue. new org.apache.hadoop.hbase.rest.client.Client(Cluster, String, Optional, Optional) may fail to clean up java.io.InputStream Try-with-resource block is used so the resource is cleaned up but findbugs thinks it otherwise. I tried to reproduce the problem locally and using the same docker container nightly test is using but findbugs did not report the problem for me. Since branch-2.2 will be EOL soon I'd like to just add SuppressWarning to ignore the false-positive findbugs warning. " Clean up mess made by broken create-release in CHANGES.md,13351150,Resolved,Major,Fixed,08/Jan/21 18:53,08/Jan/21 19:12,,"Running the 2.3.4RC build, the parent issue made a mess in CHANGES.md and RELEASENOTES.md on branch-2.3. Clean up the mess." set the loadMeta log level to debug.,13351019,Resolved,Major,Fixed,08/Jan/21 06:39,08/Jan/21 14:10,2.2.3,"https://github.com/apache/hbase/blob/2444d268901644d90def3fca39505627ff956b40/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java#L167 test 100w Regions, the log level is info, it takes more than 250 seconds to load metadata. The log is debug. It takes more than 100 seconds to load metadata." Update HBase version to 2.5.0 in branch-2 pom.xml,13350853,Resolved,Major,Fixed,07/Jan/21 10:08,12/Jan/21 04:51,, Move RegionScannerImpl out of HRegion,13350791,Resolved,Major,Fixed,07/Jan/21 03:14,08/Jan/21 09:58,,To make HRegion a little smaller. [git-jira-audit] improve performance of --parse-release-tags,13351169,Resolved,Major,Fixed,08/Jan/21 21:29,08/Jan/21 22:44,,"The {{--parse-release-tags}} flag is necessary for the more useful reports. With this mode enabled, execution time of building the audit database skyrockets. I found a python profiler, which points to {{apply_git_tag}} function being used in a tight loop." [create-release] changes.md update broken,13351143,Resolved,Major,Fixed,08/Jan/21 18:24,08/Jan/21 20:39,,"Adding logging broke the changes/releasenotes in create-release. A run last night failed w/ the below. {code} 2021-01-08T07:23:23Z update_releasenotes start JIRA returns HTTP error 400: 400. Aborting. - Please ensure that specified authentication, projects, fixVersions etc. are correct. - The value '2021-01-08T07:23:23Z HBASE' does not exist for the field 'project'. 2021-01-08T07:24:01Z update_releasenotes stop (38 seconds) {code}" [connectors] Purge use of VisibleForTesting,13350945,Resolved,Major,Fixed,07/Jan/21 18:31,11/Jan/21 13:52,hbase-connectors-1.0.1,HBASE-24640 purged VisibleForTesting from the main repository but hbase-connector still uses this annotation in KafkaBridgeConnection which is marked as IA.Private. TestRollingRestart is broken,13351189,Open,Major,,09/Jan/21 01:54,,,"https://ci-hadoop.apache.org/job/HBase/job/HBase-Find-Flaky-Tests/job/master/lastSuccessfulBuild/artifact/output/dashboard.html It fails almost 100%." Fix assembly of the hbase-shaded-testing-util*.jar; can't unzip on case-insensitive fs,13351134,Open,Major,,08/Jan/21 17:41,,,"See parent issue. We add exclusion of hbase-shaded-testing-utility.* because unzip fails on case-insensitive fs because the jar has a META-INF/LICENSE and then a directory to hold aggregated licenses at META-INF/license. This issue is about reorg'ing the jar; e.g. name the license dir as 'licenses' instead." [filesystem] Purge use of VisibleForTesting,13350928,Resolved,Major,Fixed,07/Jan/21 16:48,07/Jan/21 17:26,hbase-filesystem-1.0.0-alpha1,HBASE-24640 purged VisibleForTesting from the main repository but hbase-filesystem still uses this annotation in a few classes. After replacing these we can remove the hbase-thirdparty dependency. Add unitest for HBASE-25445 - SplitWALRemoteProcedure failed to archive split WAL,13350769,Resolved,Major,Duplicate,07/Jan/21 00:50,07/Jan/21 11:03,2.2.6,"If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance. Steps to Reproduce: * Configure 'hbase.wal.dir' and 'hbase.rootdir' so that they point to different fs instances. * Start HBase with multiple RS.  * Create a couple of tables and some rows in them so that the RSs get assigned with some regions.  * Take any RS with non-zero number of regions offline.  * Check master logs for ""Wrong FS"" error as shown in the screenshot attached.   " HRegion methods cleanup,13348729,Resolved,Major,Fixed,02/Jan/21 14:52,07/Jan/21 02:19,,Narrow down the public interface to make easier for tracing. Purge 'news' from hbase.apache.org home page; its not being updated,13350194,Open,Major,,05/Jan/21 19:24,,,"Let me remove the 'News' section. The lastest event is from july of 2019, a long time ago. There is less going on -- not to mention covid. " Possible race in AsyncConnectionImpl between getChoreService and close,13348669,Resolved,Major,Fixed,01/Jan/21 15:05,05/Jan/21 13:49,,"On branch HBASE-22120, spotbugs reported a high priority error about this problem, but the problem also exists on master. Let's fix it." hbase-thriftpy2.transport.base.TTransportException,13349126,Open,Major,,05/Jan/21 08:43,,,"  fname, mtype, rseqid = self._iprot.read_message_begin() File ""thriftpy2/protocol/cybin/cybin.pyx"", line 429, in cybin.TCyBinaryProtocol.read_message_begin File ""thriftpy2/protocol/cybin/cybin.pyx"", line 60, in cybin.read_i32 File ""thriftpy2/transport/buffered/cybuffered.pyx"", line 65, in thriftpy2.transport.buffered.cybuffered.TCyBufferedTransport.c_read File ""thriftpy2/transport/buffered/cybuffered.pyx"", line 69, in thriftpy2.transport.buffered.cybuffered.TCyBufferedTransport.read_trans File ""thriftpy2/transport/cybase.pyx"", line 61, in thriftpy2.transport.cybase.TCyBuffer.read_trans File ""/Users/daniel/opt/miniconda3/lib/python3.8/site-packages/thriftpy2/transport/socket.py"", line 131, in read raise TTransportException(type=TTransportException.END_OF_FILE, thriftpy2.transport.base.TTransportException: TTransportException(type=4, message='TSocket read 0 bytes')    " Add 2.4.1 to the downloads page,13354748,Resolved,Minor,Fixed,26/Jan/21 19:20,26/Jan/21 19:22,, "ArrayIndexOutOfBoundsException thrown when table CF name is ""#""",13355842,Patch Available,Minor,,01/Feb/21 07:40,,,"ArrayIndexOutOfBoundsException will be thrown when CF name is ""#"", https://github.com/apache/hbase/blob/a04ea7ea4493f5bc583b4d08a2a6a88e7c6b8c54/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java#L340 {noformat} 2021-01-30 00:11:14,172 | ERROR | HBase-Metrics2-1 | Error getting metrics from source RegionServer,sub=Tables | org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:202) java.lang.ArrayIndexOutOfBoundsException: 1 at org.apache.hadoop.hbase.regionserver.MetricsTableSourceImpl.addGauge(MetricsTableSourceImpl.java:336) at org.apache.hadoop.hbase.regionserver.MetricsTableSourceImpl.snapshot(MetricsTableSourceImpl.java:321) at org.apache.hadoop.hbase.regionserver.MetricsTableAggregateSourceImpl.getMetrics(MetricsTableAggregateSourceImpl.java:98) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:200) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:183) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:156) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319) at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522) at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:67) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:222) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:101) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:268) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:239) at sun.reflect.GeneratedMethodAccessor31.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:324) at com.sun.proxy.$Proxy7.postStart(Unknown Source) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:193) at org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:109) {noformat}" Support multiple tables as input in generateMissingTableDescriptorFile command in HBCK2,13361192,Resolved,Minor,Fixed,26/Feb/21 13:33,24/Feb/23 11:37,,"Currently 'generateMissingTableDescriptorFile' command in HBCK2 supports only 1 TableName as input. HBCK's _fixOrphanTables()_ had a support for fixing the missing .tableinfo files for a list of tables and it also supported fixing the missing descriptor for all tables if no tables were specified. It looks like a convinient  enhancement to have in generateMissingTableDescriptorFile command of HBCK2." Backport HBASE-25705 to branch-1,13368690,Resolved,Minor,Won't Fix,30/Mar/21 16:55,09/Aug/22 08:05,1.4.13, Use javac --release option for supporting cross version compilation,13350517,Resolved,Minor,Fixed,05/Jan/21 20:22,18/May/22 23:30,3.0.0-alpha-3,"See https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/ {quote} the Java compiler’s --release parameter, which was introduced via JEP 247 (""Compile for Older Platform Versions""), added to the platform also in JDK 9. In contrast to the more widely known pair of --source and --target, the --release switch will ensure that only byte code is produced which actually will be usable with the specified Java version. For this purpose, the JDK contains the signature data for all supported Java versions (stored in the $JAVA_HOME/lib/ct.sym file). {quote} Using one JDK (i.e. Java 11) to build Java 8-and-up and Java 11-and-up compatible release artifacts would reduce some sources of accidental complexity, assuming the --release parameter actually works as advertised. To produce Java 8-and-up compatible artifacts, supply --release=8. To produce Java 11-and-up compatible release artifacts, supply --release=11. Maven activations based on JDK version and command line defined profiles can control what --release parameter, if any, should be passed to the compiler. " Thread pools should release unused resources,13356278,Resolved,Minor,Fixed,02/Feb/21 19:06,09/Dec/21 01:21,1.7.0,"On this [PR|https://github.com/apache/hbase/pull/2909] [~stack] rightly pointed out that the thread pool just spins up threads that remain idle for 99.999% of time. Java's [ThreadPoolExecutor|https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/ThreadPoolExecutor.html] lets us tune some configurations like the following for releasing the unused resources * corePoolSize * keepAliveTimeMs * allowCoreThreadTimeOut Current code makes it difficult to pass along these configurations to the executor service. Refactor and fix the defaults for low-priority thread pools to release resources quicker." There is a problem with the SPLITS_FILE in the HBase shell statement,13361071,Resolved,Minor,Fixed,26/Feb/21 02:06,07/Mar/21 14:10,2.0.1,"The Ruby script here has a problem passing in a null value: hbase-shell/src/main/ruby/hbase/admin.rb {code:java} if arg.key?(SPLITS_FILE) splits_file = arg.delete(SPLITS_FILE) unless File.exist?(splits_file) raise(ArgumentError, ""Splits file #{splits_file} doesn't exist"") end arg[SPLITS] = [] File.foreach(splits_file) do |line| arg[SPLITS].push(line.chomp) end tdb.setValue(SPLITS_FILE, arg[SPLITS_FILE]){code}" "Excessive logging of ""hbase.zookeeper.useMulti is deprecated. Default to true always.""",13359429,Resolved,Minor,Fixed,18/Feb/21 19:12,31/Aug/21 16:40,2.4.1,"Log line printed frequently, can be as often as once per second: {noformat} 21:56:46.381 WARN [RS_REFRESH_PEER-regionserver/ip-172-31-51-4:8120-0.replicationSource, 1.replicationSource.shipperip-172-31-51-4.us-west-2.compute.internal%2C8120%2C1613596855628.ip-172-31-51-4.us-west-2.compute.internal%2C8120%2C1613596855628.default,1] org.apache.hadoop.hbase.zookeeper.ZKUtil - hbase.zookeeper.useMulti is deprecated. Default to true always. {noformat} The old configuration in place had hbase.zookeeper.useMulti set to true. This is the default and while I understand this setting is deprecated, constantly warning about it, especially when it conforms to the default, is log spam. Warn about this once over the lifetime of the replication source. " Non-idempotent test in TestReplicationHFileCleaner,13366230,Resolved,Minor,Fixed,19/Mar/21 02:57,14/Aug/21 03:33,,"The test *{{org.apache.hadoop.hbase.master.cleaner.TestReplicationHFileCleaner.testIsFileDeletable}}* is not idempotent and fail if run twice in the same JVM, because it pollutes some states shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test. h3. Detail Running {{TestReplicationHFileCleaner.testIsFileDeletable}} twice would result in the second run failing due to the following assertion error: {noformat} java.lang.AssertionError: Cleaner should allow to delete this file as there is no hfile reference node for it in the queue. {noformat} The root cause is that the a hfile reference is added during the first test run, which doesn't get removed upon test exits. Therefore, in the second test run , {{cleaner.isFileDeletable(fs.getFileStatus(file)))}} would return {{false}}, resulting in the assertion error.   PR link: https://github.com/apache/hbase/pull/2984" Add detailed RIT info in JSON format for consumption as metrics,13350767,Resolved,Minor,Fixed,07/Jan/21 00:43,05/Aug/21 01:08,2.3.7,"In HBase 2.1+, there is a RIT jsp page that was added as part of HBASE-21410. There are some additional RIT details that would be helpful to have in one place: * RIT Start Time * RIT Duration (ms) * Server * Procedure Type This info can be added to the table under the {{/rit.jsp}} page, and we can also add a button on that page to view info as JSON, for easy parsing into metrics, etc. This JSON dump can be served as a servlet. We may also consider different ways of grouping the JSON results, such as by state, table, or server name, and/or adding counts of RIT by state or server name. !Screen Shot 2021-07-27 at 10.34.45.png! !Screen Shot 2021-07-27 at 10.34.53.png!" "The client frequently exceeds the quota, which causes the meta table scan to be too high",13362480,Open,Minor,,05/Mar/21 03:50,,2.3.4," When the client scan operation, the server frequently returns RpcThrottlingException, which will cause the meta table request to become high.    /hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java {code:java} // code placeholder @Override public T callWithRetries(RetryingCallable callable, int callTimeout) throws IOException, RuntimeException { List exceptions = new ArrayList<>(); tracker.start(); context.clear(); for (int tries = 0;; tries++) { long expectedSleep; try { // bad cache entries are cleared in the call to RetryingCallable#throwable() in catch block // callable.prepare() reload force reload of server location callable.prepare(tries != 0); interceptor.intercept(context.prepare(callable, tries)); return callable.call(getTimeout(callTimeout)); } catch (PreemptiveFastFailException e) { throw e; } catch (Throwable t) { ExceptionUtil.rethrowIfInterrupt(t); Throwable cause = t.getCause(); if (cause instanceof DoNotRetryIOException) { // Fail fast throw (DoNotRetryIOException) cause; } // translateException throws exception when should not retry: i.e. when request is bad. interceptor.handleFailure(context, t); t = translateException(t); {code}       !image-2021-03-05-12-00-33-522.png! !image-2021-03-05-12-01-08-769.png!  " Enhance znode parent validation when add_peer,13368045,Resolved,Minor,Fixed,27/Mar/21 03:34,11/Jul/21 13:16,2.2.3,"If the znode parent end with empty string, add_peer command has no validation. It should be enhanced. Command example: add_peer '1', CLUSTER_KEY => ""10.244.225.186:2181:/hbase "", STATE => ""ENABLED"" It causes enable_table_replication  execute failed with folloing error. {quote}2021-03-27 09:59:47,738 DEBUG [ReadOnlyZKClient-10.244.225.186:2181@0x5817f1ca-SendThread(10.244.225.186:2181)] zookeeper.ClientCnxn: Reading reply sessionid:0x106fe808733000a, packet:: clientPath:/hbase /hbaseid serverPath:/hbase /hbaseid finished:false header:: 1,4  replyHeader:: 1,44,-101  request:: '/hbase /hbaseid,F  response::2021-03-27 09:59:47,738 DEBUG [ReadOnlyZKClient-10.244.225.186:2181@0x5817f1ca-SendThread(10.244.225.186:2181)] zookeeper.ClientCnxn: Reading reply sessionid:0x106fe808733000a, packet:: clientPath:/hbase /hbaseid serverPath:/hbase /hbaseid finished:false header:: 1,4  replyHeader:: 1,44,-101  request:: '/hbase /hbaseid,F  response::2021-03-27 09:59:47,755 WARN  [main] client.ConnectionImplementation: Retrieve cluster id failedjava.util.concurrent.ExecutionException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hbase /hbaseid at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908) at org.apache.hadoop.hbase.client.ConnectionImplementation.retrieveClusterId(ConnectionImplementation.java:603) at org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:313) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$0(ConnectionFactory.java:230) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) {quote}" RegionInfo.parseFrom(DataInputStream) sometimes fails to read the protobuf magic marker,13365827,Resolved,Minor,Fixed,17/Mar/21 12:50,18/Mar/21 18:58,2.4.1,"The RegionInfo class uses {code:java} DataInputStream.read(byte[lengthOfPBMagic]) {code} to read the protobuf magic marker from the beginning of the stream. The code in RegionInfo assumes that the passed byte buffer will be filled, but the DataInputStream class only guarantees that it will read at most lengthOfPBMagic bytes. This sometimes causes errors stating that region info file could not be parsed. The fix is to simply issue multiple read calls until lengthOfPBMagic bytes have been read. " Convert proto to RSGroupInfo is costly,13368083,Resolved,Minor,Fixed,27/Mar/21 10:18,29/Mar/21 19:01,2.2.3,"Convert RSGroupProtos.RSGroupInfo to RSGroupInfo is costly if the RSGroup has too many RSs and tables.  We can use parallelStream to handle the HBaseProtos.ServerName list and TableProtos.TableName list in ProtubufUtil#toGroupInfo as blow. {quote}Collection
addresses = proto.getServersList() .parallelStream() .map(server -> Address.fromParts(server.getHostName(), server.getPort())) .collect(Collectors.toList()); Collection tables = proto.getTablesList() .parallelStream() .map(tableName -> ProtobufUtil.toTableName(tableName)) .collect(Collectors.toList()); {quote} Get the RSGroupInfo which has 9 RS and 20k tables, the time cost reduced from 6038 ms to 684 ms." Backport HBASE-25705 to branch-2,13368628,Resolved,Minor,Fixed,30/Mar/21 11:23,28/May/21 11:38,2.4.2, Rename method completeCompaction to refreshStoreSizeCount,13362549,Resolved,Minor,Fixed,05/Mar/21 09:20,06/Mar/21 10:51,, Improve SimpleRegionNormalizer#getAverageRegionSizeMb,13351015,Resolved,Minor,Fixed,08/Jan/21 06:26,12/Apr/21 22:20,2.4.0,"If the table is set NormalizerTargetRegionSize, we take NormalizerTargetRegionSize as avgRegionSize and return it. So the totalSizeMb of table is not always calculated." "Frequent replication ""Encountered a malformed edit"" warnings",13357194,Resolved,Minor,Fixed,06/Feb/21 00:55,23/Feb/21 22:57,2.4.1,"A sequence of two log lines are frequently printed at WARN level when replication is active. Can be several times per minute per regionserver when taking writes with replication active. These can appear after a WAL roll or after the log archiver moves a WAL file. Is this an off-by one error? (Will have to look at the code.) If this is expected and harmless, WARN level logging is the wrong thing to do, it will trigger operator concern. The first: {noformat} 2021-02-05 16:42:27,269 WARN [RS_REFRESH_PEER-regionserver/HOST:8120-0.replicationSource,1.replicationSource.wal-reader.HOST%2C8120%2C1612570567906,1] wal.ProtobufLogReader: Encountered a malformed edit, seeking back to last good position in file, from 134220988 to 134220987 java.io.EOFException: Partial PB while reading WAL, probably an unexpected EOF, ignoring. current offset=134220988 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:370) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:97) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:85) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:263) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:176) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:220) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:137) {noformat} The second: {noformat} 2021-02-05 16:42:27,271 WARN [RS_REFRESH_PEER-regionserver/HOST:8120-0.replicationSource,1.replicationSource.wal-reader.HOST%2C8120%2C1612570567906,1] wal.ProtobufLogReader: Encountered a malformed edit, seeking back to last good position in file, from 134220988 to 134220987 java.io.EOFException: Partial PB while reading WAL, probably an unexpected EOF, ignoring. current offset=134220988 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:370) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:97) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:85) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:263) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:184) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:220) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:137) {noformat}" "When restoring a table, create a namespace if it does not exist",13368250,Resolved,Minor,Fixed,29/Mar/21 01:17,29/Mar/21 19:07,2.0.0,"It does not seem to have been taken into account that the namespace of the table to be restored does not exist in the target environment, and if the namespace does not exist, it will simply throw an error (NamespaceNotFoundException ), which is unfriendly." "During the recovery process, an error is thrown if there is an incremental backup of data that has not been updated",13368362,Resolved,Minor,Fixed,29/Mar/21 11:57,29/Mar/21 18:57,2.0.0,"The error is shown below: 19:49:24.213 [main] ERROR org.apache.hadoop.hbase.backup.RestoreDriver - Error while running restore backup java.io.IOException: Can not restore from backup directory (check Hadoop and HBase logs) at org.apache.hadoop.hbase.backup.mapreduce.MapReduceRestoreJob.run(MapReduceRestoreJob.java:110) ~[hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.util.RestoreTool.incrementalRestoreTable(RestoreTool.java:202) ~[hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:178) ~[hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:221) ~[hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:258) ~[hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:520) ~[hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:179) [hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:220) [hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:256) [hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) [hadoop-common-3.1.1.3.0.1.0-187.jar:?] at org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:228) [hbase-backup-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT] Caused by: java.io.IOException: No input paths specified in job" [hbtop] Add some javadoc,13366457,Resolved,Minor,Fixed,20/Mar/21 02:20,27/Mar/21 08:37,, [branch-1] UnsupportedOperationException in DumpClusterStatusAction,13367735,Resolved,Minor,Fixed,26/Mar/21 00:14,26/Mar/21 21:16,1.7.0,"2021-03-26 00:09:59,443 ERROR [main] util.AbstractHBaseTool: Error running command-line tool java.lang.UnsupportedOperationException at java.util.Collections$UnmodifiableCollection.addAll(Collections.java:1067) at org.apache.hadoop.hbase.chaos.actions.DumpClusterStatusAction.collectKnownRegionServers(DumpClusterStatusAction.java:67) at org.apache.hadoop.hbase.chaos.actions.DumpClusterStatusAction.init(DumpClusterStatusAction.java:49) at org.apache.hadoop.hbase.chaos.policies.PeriodicRandomActionPolicy.init(PeriodicRandomActionPolicy.java:70) at org.apache.hadoop.hbase.chaos.monkies.PolicyBasedChaosMonkey.start(PolicyBasedChaosMonkey.java:127) at org.apache.hadoop.hbase.IntegrationTestBase.startMonkey(IntegrationTestBase.java:199) at org.apache.hadoop.hbase.IntegrationTestBase.setUpMonkey(IntegrationTestBase.java:189) at org.apache.hadoop.hbase.IntegrationTestBase.setUp(IntegrationTestBase.java:170) at org.apache.hadoop.hbase.IntegrationTestBase.doWork(IntegrationTestBase.java:152) at org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:106) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.test.IntegrationTestBigLinkedList.main(IntegrationTestBigLinkedList.java:1990) [" Backport changes from HBASE-24418 to branch-1,13360069,Resolved,Minor,Fixed,22/Feb/21 10:33,24/Mar/21 19:38,,"Backport _""HBASE-24418 Consolidate Normalizer implementations""_ to branch-1" graceful_stop.sh fails to unload regions when ran at localhost,13360085,Resolved,Minor,Fixed,22/Feb/21 11:48,20/Mar/21 20:49,1.4.13,"We usually use graceful_stop.sh from the Master to restart RegionServers. However, in some scenarios we may not have privileges to restart remote RegionServers (it uses ssh). But we can still use graceful_stop.sh on the same host we want to restart. In order to detect the execution at localhost, graceful_stop.sh uses /bin/hostname. [https://github.com/apache/hbase/blob/cfbae4d3a37e7ac4d795461c3e19406a2786838d/bin/graceful_stop.sh#L106-L110] When RegionMover strips the host to not include it in the list of target hosts, we filter it out by checking all RegionServer hosts in the cluster: [https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java#L382-L384] [https://github.com/apache/hbase/blob/cfbae4d3a37e7ac4d795461c3e19406a2786838d/hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionMover.java#L692] But the list of RegionServer hosts returned by Admin#getRegionServers are FDQN, while the hostname provided from graceful_stop.sh is not FDQN, making the comparison fail. Same happens for branch-1 region_mover.rb, which is the place I reproduced in my environment:  [https://github.com/apache/hbase/blob/f9a91488b2c39320bed502619bf7adb765c79de6/bin/region_mover.rb#L305] [https://github.com/apache/hbase/blob/f9a91488b2c39320bed502619bf7adb765c79de6/bin/region_mover.rb#L175] [https://github.com/apache/hbase/blob/f9a91488b2c39320bed502619bf7adb765c79de6/bin/region_mover.rb#L186-L192]   This can be fixed just by using ""/bin/hostname -f"" in the graceful_stop.sh script. Will provide patch soon." TestCurrentHourProvider fails 100% in branch-2.3,13365630,Resolved,Minor,Fixed,16/Mar/21 20:34,16/Mar/21 22:20,2.3.4, !image-2021-03-16-13-34-29-412.png! Wrong log regarding current active master at ZKLeaderManager#waitToBecomeLeader,13365746,Resolved,Minor,Fixed,17/Mar/21 08:14,18/Mar/21 15:53,,"{code} byte[] currentId = ZKUtil.getDataAndWatch(watcher, leaderZNode); if (currentId != null && Bytes.equals(currentId, nodeId)) { .... } else { LOG.info(""Found existing leader with ID: {}"", Bytes.toStringBinary(nodeId)); leaderExists.set(true); } {code} Existing id, read from ZK, is currentId. But by mistake we log 'nodeId' which is the this master's node id." Dependency manage log4j in hbase-connectors,13366369,Resolved,Minor,Fixed,19/Mar/21 14:15,19/Mar/21 14:53,,"HBase-connectors has many dependencies which might get different versions of log4j transitively. To ensure we always use the same version we should ""dependency manage"" it in the main pom.xml file." Make graceful_stop localhostname compare match even if fqdn,13364701,Reopened,Minor,,12/Mar/21 17:40,,,The hostname to operate on will be fqdn usually. Internal to the graceful_stop script it tries to check if we are running locally but the compare is of a fqdn to what 'hostname' returns; the latter usually returns name only. Allow name-only and fqdn match. While here cleanup doc around 'hostname' passed to graceful_stop. Add row info in Exception when cell size exceeds maxCellSize,13360252,Resolved,Minor,Fixed,23/Feb/21 06:41,15/Mar/21 22:52,,"When cell size exceeds maxCellSize(default is 10M), client will get a DoNotRetryIOException, code as below: {code:java} private void checkCellSizeLimit(final HRegion r, final Mutation m) throws IOException { if (r.maxCellSize > 0) { CellScanner cells = m.cellScanner(); while (cells.advance()) { int size = PrivateCellUtil.estimatedSerializedSizeOf(cells.current()); if (size > r.maxCellSize) { String msg = ""Cell with size "" + size + "" exceeds limit of "" + r.maxCellSize + "" bytes""; LOG.debug(msg); throw new DoNotRetryIOException(msg); } } } } {code} There is no row related information, which makes troubleshooting difficult." Expose HBCK report as metrics,13362539,Resolved,Minor,Fixed,05/Mar/21 08:38,11/Mar/21 07:54,,"Currently, we have a HBCK Report page in master UI to show the problems of HBCK Chore report and CatalogJanitor Consistency report. We can expose these problems as metrics, so we can configure an alert." Improve storeFile.jsp performance on really large files,13362707,Open,Minor,,05/Mar/21 21:27,,2.3.0,"Since HBASE-7171, we have a nice UI for clicking down into the details of an hfile on a regions server. When the store file is really large, the performance of this page is quite bad. It can take several minutes to summarize a 30-50gb hfile. We can do better." Reduce MTTR for region server,13363260,Open,Minor,,09/Mar/21 12:19,,1.4.13,"I some cases in our production that, the machine that runs region server is not functioning well(I could not ssh to that machine, but it respond ping requests), the Region Server process is still running but could not process client requests. It lasts for more than 30 minutes util I remove the znode of that Region Server from ZK manually. That RS is totally unavailable during that time. I guess Region Server  still heartbeats to ZK so that the ephemeral node of the RS is not removed by ZK, master does not find that this RS has down.   I think hbase needs a better failure detection except for watching the existence of the ephemeral node created by RS.  One thing comes to my mind is running a failure detection( like  The φ Accrual Failure Detector [https://www.semanticscholar.org/paper/The-%CF%86-Accrual-Failure-Detector-Hayashibara-D%C3%A9fago/65c40c79e30c1ef33c97a22a3d52cc9f0415a477])  service on master which pings RS periodically so that the master could know the RS is down asap.   Any ideas?    " Improve normalizer code in line with HBASE-23932,13360013,Resolved,Minor,Fixed,22/Feb/21 06:33,23/Feb/21 05:12,, Improve performance of table.jsp,13361281,Open,Minor,,26/Feb/21 22:09,,2.3.4,"Loading table.jsp for a table with hundreds of thousands of regions takes more than 10 seconds. This page renders a complete listing of all table regions in one go. We should have this JSP support pagination of the table regions list, with a default size of something more reasonable (100? 1000?), and controls for adjusting the page size. table.jsp already supports something like this for browsing meta table entries." Backport TestZKSecretWatcher improvement to branch-2.2,13360378,Resolved,Minor,Fixed,23/Feb/21 16:41,26/Feb/21 18:47,2.2.7,"TestZKSecretWatcher.testKeyUpdate failed on branch-2.2 nightly. Branch-2.3+ has some test stabilization made in HBASE-23899 which improved this test too. {noformat} Error Message expected null, but was: Stacktrace java.lang.AssertionError: expected null, but was: at org.apache.hadoop.hbase.security.token.TestZKSecretWatcher.testKeyUpdate(TestZKSecretWatcher.java:185) {noformat}" Should validate Puts in RowMutations,13358473,Resolved,Minor,Fixed,13/Feb/21 12:28,22/Feb/21 02:11,,"Currently, we don't validate the key value sizes of Puts in RowMutations. We should do that." Adding region count and average region size in a table at regionserver level,13358285,Resolved,Minor,Fixed,12/Feb/21 07:17,13/Feb/21 04:05,1.6.0,Currently we have these two metrics - regionCount and avgRegionSize in branch-2+. Adding them to branch-1. These will give better insight into whether we should enable region normalizer on a table or not. Add a python example of using the thrift proxy in thrift-over-http mode,13352311,Resolved,Minor,Fixed,14/Jan/21 16:32,13/Feb/21 03:40,,add an example that shows using the thrift proxy with over-http enabled More readable Competition Time,13356681,Resolved,Minor,Fixed,04/Feb/21 07:21,08/Feb/21 21:14,,"Should add duration to Completion Time. Make it more readable !https://internal-api-lark-file.f.mioffice.cn/api/image/keys/img_44a98ccd-4576-4971-900e-3d27dd1263el?message_id=6925292609535492204! to !image-2021-02-04-15-21-00-019.png!" "When configuration ""hadoop.security.authorization"" is set to false, the system will still try to authorize an RPC and raise AccessDeniedException",13356145,Resolved,Minor,Fixed,02/Feb/21 08:45,07/Feb/21 15:42,,"In method processOneRpc(Bytebuffer buf) in RpcServer.java (branch-1), ServerRpcConnection.java (branch-2, master), if connectionHeadRead is set to false, the method authorizeConnection() will be invoked whatever the boolean authorize is true or false. {code:java} if (!authorizeConnection()) { // Throw FatalConnectionException wrapping ACE so client does right thing and closes // down the connection instead of trying to read non-existent retun. throw new AccessDeniedException(""Connection from "" + this + "" for service "" + connectionHeader.getServiceName() + "" is unauthorized for user: "" + ugi); } {code} In method authorizeConnection() {code:java} if (ugi != null && ugi.getRealUser() != null && (authMethod != AuthMethod.DIGEST)) { ProxyUsers.authorize(ugi, this.getHostAddress(), conf); }{code} ProxyUsers.authorize() will raise AuthorizationException." PerfTestCompactionPolicies is failing because of NPE,13356221,Resolved,Minor,Fixed,02/Feb/21 14:55,04/Feb/21 19:29,3.0.0-alpha-1,"PerfTestCompactionPolicies is failing because of NPE as {code:java} s.getRegionInfo(){code} mock is missing. " Dedicated merge dispatch threadpool on master,13354529,Resolved,Minor,Fixed,25/Jan/21 20:59,02/Feb/21 19:17,1.7.0,"Over the weekend we ran into an issue of running normalizer on a table with ~400k regions and we noticed the master was bottlenecked on merge dispatcher code that runs on a single threaded thread-pool that was meant for all master table operations (opcode: MASTER_TABLE_OPERATIONS). Having a dedicated thread-pool helped us dispatch merges at a faster rate. " Minor improvement to Profiler Servlet doc,13354745,Resolved,Minor,Fixed,26/Jan/21 19:09,27/Jan/21 00:15,3.0.0-alpha-1,"Minor cleanup to the Profiler Servlet Background and Prerequisites sections, http://hbase.apache.org/book.html#_prerequisites_2" Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint,13350943,Resolved,Minor,Fixed,07/Jan/21 18:11,20/Jan/21 06:05,,"When a table from a previous test is too slow to close, it can cause problems for subsequent tests. Implementing a retry-and-wait function in this test class during table enablement will prevent issues where a single peerID is being used by two tests at once." Improve unit test for HBASE-25445 : SplitWALRemoteProcedure failed to archive split WAL,13350894,Resolved,Minor,Fixed,07/Jan/21 13:37,17/Jan/21 11:07,2.2.6,"As part of HBASE-25445, the UT testWALArchiveWIthDifferentWalAndRootFS was added which can be further improved in terms of code formatting and assertions. " fix comment error of admin.rb,13351628,Resolved,Minor,Fixed,12/Jan/21 03:19,13/Jan/21 19:27,, stable release channel point to 2.3.3 while the description is still saying 2.2.z is stable line,13351351,Open,Minor,,11/Jan/21 02:21,,,"Under hbase download site, The description says ""The 2.2.z series is the current stable release line"". However, the stable release channel is already point to 2.3.3   !image-2021-01-11-10-18-45-476.png! !image-2021-01-11-10-21-33-672.png!" Update git-jira-audit fallback_actions file with recent exceptions,13350757,Resolved,Minor,Fixed,06/Jan/21 22:51,07/Jan/21 17:45,3.0.0-alpha-1,I recently ran the git/Jira audit tool ; we have some new ill-formed commits to handle manually. Fix comment error,13349202,Resolved,Minor,Fixed,05/Jan/21 13:32,05/Jan/21 14:46,,There is a comment error in file append.rb [create-release] Use release:prepare tagging and setting version numbers,13350545,Open,Minor,,05/Jan/21 23:43,,,"Our [~ndimiduk] fingered release:prepare as alternative for our explicit tagging and updating to next version. This issue is about adding this to create-release. See https://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html (And from Nick in PR: ""In other projects, I used to use release:prepare to apply version change to the poms and create a release tag. A little configuration of the plugin lets you specify these details, it worked pretty well. I was never brave enough to let the plugin push changes though ; i always verified and pushed manually."")" [UI]RIT time(ms) on Master UI page dispalys incorrect occasionally,13351410,Open,Trivial,,11/Jan/21 09:31,,2.2.3,"The ‘’RIT time(ms)' on Master UI page displays incorrect occasionally.  If the Master page refreshed before the TRSP submitted, the RIT time is current time since rs.getStamp() = zero.   !image-2021-01-11-17-32-21-975.png!" Print split policy in use on Region open (as well as split policy vitals),13363974,Resolved,Trivial,Fixed,12/Mar/21 00:49,15/Mar/21 21:13,,"On Region open, add to the open message the split and flush policies in place; they are printed no where else. For split policy, list vitals like split size for the Region; for the likes of ConstantSizeSplitPolicy there can be high variance in size so dump out what we've figured." [Documentation] Add a comment when using Secure HTTP (HTTPS) for the Web UI,13351685,Resolved,Trivial,Fixed,12/Jan/21 08:39,30/Jan/21 22:14,2.0.0,"When I configured https for the HBase web UI according to the document(set {{hbase.ssl.enabled}} to {{true}} in _hbase-site.xml_), there are the following errors: {quote}2021-01-29 11:25:19,360 ERROR [main] master.HMasterCommandLine: Master exiting2021-01-29 11:25:19,360 ERROR [main] master.HMasterCommandLine: Master exitingjava.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMaster.  at org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:2910) at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:236) at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:140) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2921)Caused by: java.io.IOException: Problem starting http server at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1006) at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:100) at org.apache.hadoop.hbase.regionserver.HRegionServer.putUpWebUI(HRegionServer.java:2015) at org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:627) at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:472) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.master.HMaster.constructMaster(HMaster.java:2903) ... 5 moreCaused by: java.lang.IllegalStateException: no valid keystore {quote} According to the following link (https://community.cloudera.com/t5/Community-Articles/Enable-HTTPS-SSL-for-HBASE-Master-UI/ta-p/247031), I found that SSL certificate and SSL configuration are required. In the configuration document of hbase, we do not need to write a detailed configuration process, but we need to be reminded: only modifying the parameters according to the configuration steps will not take effect. I think we need to add hints to the document(Please prepare SSL certificate and ssl configuration file in advance)： {quote} h3. 59.1. Using Secure HTTP (HTTPS) for the Web UI A default HBase install uses insecure HTTP connections for Web UIs for the master and region servers. To enable secure HTTP (HTTPS) connections instead, set {{hbase.ssl.enabled}} to {{true}} in _hbase-site.xml(Please prepare SSL certificate and ssl configuration file in advance)_. {quote}" Simplify UTs using DummyServer,13366331,Resolved,Trivial,Fixed,19/Mar/21 11:51,22/Mar/21 15:55,3.0.0-alpha-1, Added ignored test for async connection that runs retries just so can check how long it takes and that retrying is happening,13357619,Resolved,Trivial,Fixed,08/Feb/21 20:04,15/Mar/21 21:17,,"There's an old @Ignored test in TestClientNoCluster that has been useful from time to time figuring how long N retries takes and reproducing certain production 'Connection rejected', etc., stack traces. This issue adds an @Ignored method for the async connection case so can do similar for async (I needed it just now because it looked like retries at a certain juncture were not happening -- turns out they are... this addition helped me prove this the case)." [Documentation] Fix format error in security.adoc,13363412,Resolved,Trivial,Fixed,10/Mar/21 02:33,10/Mar/21 08:36,3.0.0-alpha-1,"h3. 60.6. Configure the Thrift Gateway to Use the {{doAs}} Feature ... *To enable the {{doAs}} feature*, add the following to the _hbase-site.xml_ file for every Thrift gateway:   !image-2021-03-10-10-36-30-765.png! The symbol “<” is missing after ""ture""." Increase timeout for HBase-Flaky-Tests on branch-2.2,13360384,Resolved,Trivial,Fixed,23/Feb/21 17:07,26/Feb/21 09:04,2.2.7,"The flaky test list got horrible on branch-2.2 and the HBase-Flaky-Tests can't finish in the 2 hours timeout so the list keeps increasing. Change the timeout on this branch to 4 hours so the job could finish." May throw StringIndexOutOfBoundsException when construct illegal tablename error,13352427,Resolved,Trivial,Fixed,15/Jan/21 07:52,08/Feb/21 21:40,1.2.12,"When call Method: {code:java} // code placeholder TableName.isLegalTableQualifierName(final byte[] qualifierName, int start, int end) {code} We want to construct quelifier String to print pretty error message. So we call method:  {code:java} // code placeholder Bytes.toString(final byte[] b, int off, int len) Bytes.toString(qualifierName, start, end) {code} But the param is wrong, we shoud pass *${Length}* instead of *${end index}* to *Bytes.toString third param*." Ensure MOB compaction works in optimized mode after snapshot clone,13281116,Resolved,Blocker,Fixed,23/Jan/20 05:27,08/Apr/20 19:20,,"How does code handle snapshot naming convention for MOB files. " Let CPEPs also use our shaded protobuf,13283347,Resolved,Blocker,Fixed,05/Feb/20 01:22,18/Apr/20 01:39,,"See this discussion thread: https://lists.apache.org/thread.html/abd60a8985a4898bae03b2c3c51d43a6b83d67c00caff82ba9ab2712%40%3Cdev.hbase.apache.org%3E" Data loss when WAL split to HFile enabled,13281641,Resolved,Blocker,Fixed,27/Jan/20 06:30,23/Mar/20 15:24,2.3.0,"Very simple steps as below, 1. Create table with 1 region 2. Insert 1 record 3. Flush the table 4. Scan table and observe timestamp of the inserted row 5. Insert same row key with same timestamp as previously inserted but with different value 6. Kill -9 RS where table region is online 7. Start RS Scan the table and check the result, latest cell must be returned. Thanks [~sreenivasulureddy] for finding this issue. " TestQuotasShell is broken,13294878,Resolved,Blocker,Fixed,30/Mar/20 01:58,31/Mar/20 02:01,,"{noformat} =============================================================================== ^[[41;37;1mFailure^[[0m: is not true. test_can_set_and_remove_quota(Hbase::SpaceQuotasTest) src/test/ruby/hbase/quotas_test.rb:183:in `block in test_can_set_and_remove_quota' 180: define_test 'can set and remove quota' do 181: command(:set_quota, TYPE => SPACE, LIMIT => '1G', POLICY => NO_INSERTS, TABLE => @test_name) 182: output = capture_stdout{ command(:list_quotas) } ^[[41;37;1m => 183: assert(output.include?(""LIMIT => 1G""))^[[0m 184: assert(output.include?(""VIOLATION_POLICY => NO_INSERTS"")) 185: assert(output.include?(""TYPE => SPACE"")) 186: assert(output.include?(""TABLE => #{@test_name}"")) =============================================================================== {noformat} At least on branch-2.1." Make hbase-rest use our shaded protobuf,13291265,Resolved,Blocker,Fixed,12/Mar/20 09:15,26/Mar/20 13:37,,"This is a strange one, we also use protobuf in hbase-rest and it is a non shaded version..." Increment proto conversion is broken,13284422,Resolved,Blocker,Fixed,10/Feb/20 22:14,12/Feb/20 01:18,1.1.11,"While converting the request back to Increment using ProtobufUtil.toIncrement we incorrectly use the optimization to avoid copying the byte array(HBaseZeroCopyByteString#zeroCopyGetBytes) on a BoundedByteString. The optimization was only meant for LiteralByteString where it is safe to use the backing byte array, however it ends up being used to BoundedByteString which is a subclass of LiteralByteString. This essentially breaks increments since we end up creating wrong cells on the server side. " We still reference the hard coded meta descriptor in some places when listing table descriptors,13282838,Resolved,Blocker,Fixed,02/Feb/20 13:32,04/Feb/20 03:07,, Switch central repo to https on branch-1,13279698,Resolved,Blocker,Fixed,15/Jan/20 23:35,17/Jan/20 14:23,1.6.0,"Maven central started enforcing https [1] today and branch-1 builds are failing presumably due to an older maven version. Maven 3.2.3 [2] and later already switched the defaults, so not every one might run into this problem, depending on what mvn they are using. Jenkins jobs are hitting this, so they are likely using an older version. [1] https://blog.sonatype.com/central-repository-moving-to-https [2] https://issues.apache.org/jira/browse/MNG-5672" Move the unsupported procedure type check before migrating to RegionProcedureStore,13277736,Resolved,Blocker,Fixed,06/Jan/20 17:03,16/Jan/20 15:10,2.2.2,"Per [discussion|https://lists.apache.org/thread.html/c5f960e6cf3c89ffbf8f8302afb121462a08fd9a89d384c6795a7b81%40%3Cdev.hbase.apache.org%3E] on the list, let's figure out how to make the upgrade from a v2.1 procedure store less error-prone. Could be a simple as documenting runbook steps to execute during the rolling upgrade, but it would be nice if the software could roll over the data versions gracefully." Disable output stream capability enforcement when running in standalone mode,13295120,Resolved,Critical,Won't Fix,31/Mar/20 00:26,14/May/20 21:37,2.3.0,"{noformat} $ JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home mvn clean install -DskipTests $ JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home ./bin/hbase master start {noformat} gives {noformat} 2020-03-30 17:12:43,857 ERROR [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.io.IOException: cannot get log writer at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61) at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297) at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256) at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273) at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587) at org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2231) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:621) at java.lang.Thread.run(Thread.java:748) Caused by: org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: hflush at org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:71) at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:169) at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:166) at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:105) ... 18 more {noformat}" Findbugs is OOM on master,13289359,Resolved,Critical,Fixed,04/Mar/20 00:45,24/Jul/20 13:13,,Happens after merging of HBASE-22514. Old config hbase.hstore.compactionThreshold is ignored,13284889,Resolved,Critical,Fixed,12/Feb/20 18:26,14/May/20 16:59,2.0.0,"In 2.x we added new name 'hbase.hstore.compaction.min' for this. Still for compatibility we allow the old config name and honor that in code {code} minFilesToCompact = Math.max(2, conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY, /*old name*/ conf.getInt(""hbase.hstore.compactionThreshold"", 3))); {code} But if hbase.hstore.compactionThreshold alone is configured by user, there is no impact of that. This is because in hbase-default.xml we have the new config with a value of 3. So the call conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY) always return a value 3 even if it is not explicitly configured by customer and instead used the old key." HMaster does not restart when rsgroup is enabled and /hbase/WALs is moved,13292433,Resolved,Critical,Won't Fix,18/Mar/20 10:08,21/Apr/20 20:41,2.2.3,"HMaster does not restart when rsgroup is enabled and /hbase/WALs is moved HMaster restarts properly if rsgroup is not enabled even if /hbase/WALs is moved. Steps to reproduce: # start the cluster # create a table do some put, delete # kill all the region servers and master # move WALs directory for backup (-mv /hbase/WALs /hbase/WALs2) # start the cluster # Master start fails, initialization keep failing {code:java} 2020-03-18 11:42:55,369 ERROR [ActiveMasterInitializationMonitor-1584511075369] master.HMaster: Master failed to complete initialization after 900000ms. Please consider submitting a bug report including a thread dump of this process. {code}          " HBCK2 feature negotiation to check what commands are supported,13293483,Resolved,Critical,Fixed,24/Mar/20 08:42,16/Apr/20 09:27,,"Each HBase version is shipped with a specific version of HBCK2 therefore we can check the HBCK2 version and decide if the given command is supported in that version or not. It is not that easy to decide if the command is supported or not when dealing with back-ported features. It the conclusion of this I would recommend using feature negotiation to check what commands are supported on the server side instead of comparing versions." Find a way to handle the corrupt recovered hfiles,13277330,Resolved,Critical,Fixed,03/Jan/20 09:08,22/Mar/20 15:07,2.3.0,"Copy the comment from PR review.   If the file is a corrupt HFile, an exception will be thrown here, which will cause the region to fail to open. Maybe we can add a new parameter to control whether to skip the exception, similar to recover edits which has a parameter ""hbase.hregion.edits.replay.skip.errors"";   Regions that can't be opened because of detached References or corrupt hfiles are a fact-of-life. We need work on this issue. This will be a new variant on the problem -- i.e. bad recovered hfiles. On adding a config to ignore bad files and just open, thats a bit dangerous as per @infraio .... as it could mean silent data loss." PBType which is marked as IA.Public references protobuf Message,13291517,Resolved,Critical,Fixed,13/Mar/20 09:42,26/Mar/20 02:39,,This is a very critical problem as we leak protobuf in our user facing public API? Set suitable forkCount when running pre commit,13289374,Resolved,Critical,Won't Fix,04/Mar/20 02:23,17/Mar/20 00:04,,Our pre commit and flaky test list is a mess now. We need to fix this soon. Executing all the UTs in 3 hours and getting a stable result is much better then executing random UTs in 1 hour and get a random result... NPE HFilesOutputSink,13279148,Resolved,Critical,Duplicate,13/Jan/20 18:18,10/Mar/20 05:53,2.3.0,"Enabling the new split to hfiles feature, HBASE-23286, running branch-2 tip, I see this out on RegionServers: {code} 2020-01-13 17:37:08,204 INFO org.apache.hadoop.hbase.wal.OutputSink: 3 split writer threads finished 2020-01-13 17:37:08,233 INFO org.apache.hadoop.hbase.wal.WALSplitter: Processed 1007 edits across 0 regions cost 284 ms; edits skipped=76; WAL=hdfs://nameservice1/hbase/genie/WALs/hbasedn101.example.org,16020,1578934806382-splitting/hbasedn101.example.org%2C16020%2C1578934806382.1578937008832, size=128.5 M, length=134708720, corrupted=false, progress failed=true 2020-01-13 17:37:08,234 WARN org.apache.hadoop.hbase.regionserver.SplitLogWorker: log splitting of WALs/hbasedn101.example.org,16020,1578934806382-splitting/hbasedn101.example.org%2C16020%2C1578934806382.1578937008832 failed, returning error java.io.IOException: java.lang.NullPointerException at org.apache.hadoop.hbase.wal.BoundedRecoveredHFilesOutputSink.writeRemainingEntryBuffers(BoundedRecoveredHFilesOutputSink.java:173) at org.apache.hadoop.hbase.wal.BoundedRecoveredHFilesOutputSink.close(BoundedRecoveredHFilesOutputSink.java:140) at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:339) at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:181) at org.apache.hadoop.hbase.regionserver.SplitLogWorker.splitLog(SplitLogWorker.java:105) at org.apache.hadoop.hbase.regionserver.SplitLogWorker.lambda$new$0(SplitLogWorker.java:84) at org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:70) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.wal.BoundedRecoveredHFilesOutputSink.configContextForNonMetaWriter(BoundedRecoveredHFilesOutputSink.java:225) at org.apache.hadoop.hbase.wal.BoundedRecoveredHFilesOutputSink.createRecoveredHFileWriter(BoundedRecoveredHFilesOutputSink.java:213) at org.apache.hadoop.hbase.wal.BoundedRecoveredHFilesOutputSink.append(BoundedRecoveredHFilesOutputSink.java:117) at org.apache.hadoop.hbase.wal.BoundedRecoveredHFilesOutputSink.lambda$writeRemainingEntryBuffers$3(BoundedRecoveredHFilesOutputSink.java:155) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) {code} It is a bit odd because log says there were zero regions. Not sure what that was about." Split failure may cause region hole and data loss when use zk assign,13279574,Resolved,Critical,Fixed,15/Jan/20 12:15,11/Feb/20 15:36,1.4.8,"to mock this case, I add a sleep code in SplitTransactionImpl.excute after the PONR and before openDaughters: {code:java} public PairOfSameType execute(final Server server, final RegionServerServices services, User user) throws IOException { this.server = server; this.rsServices = services; useZKForAssignment = server == null ? true : ConfigUtil.useZKForAssignment(server.getConfiguration()); if (useCoordinatedStateManager(server)) { std = ((BaseCoordinatedStateManager) server.getCoordinatedStateManager()) .getSplitTransactionCoordination().getDefaultDetails(); } PairOfSameType regions = createDaughters(server, services, user); if (this.parent.getCoprocessorHost() != null) { if (user == null) { parent.getCoprocessorHost().preSplitAfterPONR(); } else { try { user.getUGI().doAs(new PrivilegedExceptionAction() { @Override public Void run() throws Exception { parent.getCoprocessorHost().preSplitAfterPONR(); return null; } }); } catch (InterruptedException ie) { InterruptedIOException iioe = new InterruptedIOException(); iioe.initCause(ie); throw iioe; } } } //sleep here!!! try { Thread.sleep(1000 * 60 * 60); } catch (InterruptedException e) { e.printStackTrace(); } regions = stepsAfterPONR(server, services, regions, user); transition(SplitTransactionPhase.COMPLETED); return regions; } {code} so the split transaction will hang. then i try to reproduce this problem: 1.Create a test table and move it into a test rsgroup, there is only 1 RS in the test group 2.Trigger a region split 3.The split transaction step after the PONR and sleep, regioninfo in meta has been updated 4.Kill the RS process to mock machine crash 5.ServerCrashProcedure cleanup SPLITING_NEW region, the daughter regions will be deleted 6.ServerCrashProcedure try to assign the parent region, because RS is down and assign fails, the region status is set to FAILED_OPEN and put back into regionsInTransition. But at this time, due to RS crash, the node of the region under ZK region-in-transition no longer exist 7.CatalogJanitor thread is blocked due to RIT 8.Switch active master 9.The CatalogJanitor thread on the new master executes normally and the parent region is cleaned up because split = true && offline = true in the meta table 10.We have a hole in the test table and loss data.   I modified the code when ServerCrashProcedure cleans up the child regions, it will update the parent regioninfo in the meta table, and this problem is no longer reproduced. I will upload the patch later." FileSystem instance leaks due to bulk loads with Kerberos enabled,13278786,Resolved,Critical,Fixed,10/Jan/20 19:52,14/Jan/20 00:09,,"Spent the better part of a week chasing an issue on HBase 2.x where the number of DistributedFileSystem instances on the heap of a RegionServer would grow unbounded. Looking at multiple heap-dumps, it was obvious to see that we had an immense number of DFS instances cached (in FileSystem$Cache) for the same user, with the unique number of Tokens contained in that DFS's UGI member (one hbase delegation token, and two HDFS delegation tokens – we only do this for bulk loads). For the user's clusters, they eventually experienced 10x perf degradation as RegionServers spent all of their time in JVM GC (they were unlucky to not have RegionServers crash outright, as this would've, albeit temporarily, fixed the issue). The problem seems to be two-fold with changes by HBASE-15291 being largely the cause. This issue tried to close FileSystem instances which were being leaked – however, it did this by instrumenting the method {{SecureBulkLoadManager.cleanupBulkLoad(..)}}. Two big issues with this approach: # It relies on clients to call this method (client's hanging up will leak resources in RegionServers) # This method is only called on the RegionServer hosting the first Region of the table which was bulk-loaded into. For multiple RegionServers, they are left to leak resources. HBASE-21342 later tried to fix an issue where FS objects were now being closed prematurely via reference-counting (which appears to work fine), but does not address the other two issues above. Point #2 makes debugging this issue harder than normal because it doesn't manifest on a single node instance :) Through all of this, I (re)learned the dirty history of UGI and how its caching doesn't work so great HADOOP-6670. I see trying to continue to leverage the FileSystem$CACHE as a potentially dangerous thing (we've been back here multiple times already). My opinion at this point is that we should cleanly create a new FileSystem instance during the call to {{SecureBulkLoadManager#secureBulkLoadHFiles(..)}} and close it in a finally block in that same method. This both simplifies the lifecycle of a FileSystem instance in the bulk-load codepath but also helps us avoid future problems with UGI and FS caching. The one downside is that we pay the penalty to create a new FileSystem instance, but I'm of the opinion that we cross that bridge when we get there. Thanks for [~jdcryans] and [~busbey] for their help along the way." Release 1.4.13,13281765,Resolved,Major,Fixed,27/Jan/20 17:21,06/Mar/20 03:00,1.4.13,over due for 1.4.13. I'll try to use the release manager scripts this time. "The ""HBase Nightly"" job may exhaust all executors - and create a deadlock",13292163,Resolved,Major,Fixed,17/Mar/20 11:03,30/Mar/20 08:45,,"What seems to happen is: * the job needs more and more executors to run * in case there are several of them launched in parallel (different branches) say 5 * they take up all available executors labeled ""Hadoop"" and then they wait for more indefinetly I've killed a few builds...see my notes here: https://the-asf.slack.com/archives/C7M1AFYLS/p1584442366000900" Region History Redo,13282477,Open,Major,,30/Jan/20 20:56,,,"My initial thought is mainly to extend the HBase shell(gradually extend to CLI and UI) to allow the use of {code:java} where {code} to get the necessary information and allow passing history as an additional parameter to get the history. We can configure how many transitions we want to store so that anything (ZK or small data structure in the table region itself or maybe something else) that is used for state management is not exploded. As pointed by [~andrew.purtell@gmail.com] need to be watchful of mistakes done in the past: HBASE-533 " Disable table may hang when regionserver stop or abort.,13277354,Resolved,Major,Fixed,03/Jan/20 11:25,06/Jan/20 07:25,2.2.2,"ServerCrashProcedure will skip regions when table disabling and no procedure with regions, and when DisableTableProcedure to close this region it will never success." Netty SASL implementation does not wait for challenge response causing TestShadeSaslAuthenticationProvider failures,13286865,Resolved,Major,Fixed,21/Feb/20 18:26,13/Apr/20 15:07,2.3.0,"TestShadeSaslAuthenticationProvider now fails deterministically with the following exception.. {noformat} java.lang.Exception: Unexpected exception, expected but was at org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233) {noformat} The test now fails a different place than before merging HBASE-18095 because the RPCs are also a part of connection setup. We might need to rewrite the test.. " "Enable ""Split WAL to HFile"" by default",13277332,Open,Major,,03/Jan/20 09:12,,2.3.0, TestSyncTimeRangeTracker fails quite easily and allocates a very expensive array.,13283135,Resolved,Major,Not A Problem,04/Feb/20 03:00,14/May/20 23:21,,I see this test fail a lot in my environments. It also uses such a large array that it seems particularly memory wasteful and difficult to get good contention in the test as well. The RSGroup shell test is missing,13283967,Resolved,Major,Fixed,07/Feb/20 15:36,08/Feb/20 14:58,,"We exclude the rsgroup_shell_test.rb in TestShell, but never introduce a TestRSGroupShell to include it..." Spotbugs warning complain on master build,13291664,Resolved,Major,Fixed,14/Mar/20 00:14,03/Mar/23 09:45,3.0.0-alpha-1,"Spotbugs currently complains on every master build with an extant warning related: {code} Return value of putIfAbsent is ignored, but node is reused in org.apache.hadoop.hbase.master.assignment.RegionStates.createRegionStateNode(RegionInfo) {code}" Shell tests broken,13291613,Open,Major,,13/Mar/20 16:54,,3.0.0-alpha-1,"The shell tests in the master seem to be broken. When running {{mvn clean install -pl hbase-shell -PrunClientTests}} it reports the following errors: {code} [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.client.TestTableShell [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 66.561 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestTableShell [ERROR] org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests Time elapsed: 63.222 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details. at org.apache.hadoop.hbase.client.TestTableShell.testRunShellTests(TestTableShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests failed. Check output file for details. [INFO] Running org.apache.hadoop.hbase.client.TestQuotasShell [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 362.723 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestQuotasShell [ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests Time elapsed: 360.415 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details. at org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests(TestQuotasShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests failed. Check output file for details. [INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.653 s - in org.apache.hadoop.hbase.client.TestRSGroupShell [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 155.249 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAdminShell [ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests Time elapsed: 151.904 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details. at org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests(TestAdminShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests failed. Check output file for details. [INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.684 s - in org.apache.hadoop.hbase.client.TestShellNoCluster [INFO] Running org.apache.hadoop.hbase.client.TestReplicationShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 113.892 s - in org.apache.hadoop.hbase.client.TestReplicationShell [INFO] Running org.apache.hadoop.hbase.client.TestShell [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 35.646 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestShell [ERROR] org.apache.hadoop.hbase.client.TestShell.testRunShellTests Time elapsed: 32.328 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details. at org.apache.hadoop.hbase.client.TestShell.testRunShellTests(TestShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests failed. Check output file for details. [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell2 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 141.174 s - in org.apache.hadoop.hbase.client.TestAdminShell2 [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestAdminShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell unit tes... [ERROR] TestQuotasShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell unit te... [ERROR] TestShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell unit tests fa... [ERROR] TestTableShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell unit tes... [INFO] [ERROR] Tests run: 8, Failures: 0, Errors: 4, Skipped: 0 {code} Following the output from the master nightly: {code} [INFO] Running org.apache.hadoop.hbase.client.TestShellNoCluster [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.688 s - in org.apache.hadoop.hbase.client.TestShellNoCluster [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell2 [INFO] Running org.apache.hadoop.hbase.client.TestTableShell [INFO] Running org.apache.hadoop.hbase.client.TestReplicationShell [INFO] Running org.apache.hadoop.hbase.client.TestQuotasShell [INFO] Running org.apache.hadoop.hbase.client.TestRSGroupShell [INFO] Running org.apache.hadoop.hbase.client.TestAdminShell [INFO] Running org.apache.hadoop.hbase.client.TestShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.029 s - in org.apache.hadoop.hbase.client.TestRSGroupShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.433 s - in org.apache.hadoop.hbase.client.TestTableShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 48.12 s - in org.apache.hadoop.hbase.client.TestShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 139.982 s - in org.apache.hadoop.hbase.client.TestReplicationShell [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 150.555 s - in org.apache.hadoop.hbase.client.TestAdminShell2 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 175.274 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAdminShell [ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests Time elapsed: 171.848 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details. at org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests(TestAdminShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests failed. Check output file for details. [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 187.392 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAdminShell [ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests Time elapsed: 0.12 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) test_exists?_should_return_true_when_a_table_exists is already defined in Hbase::AdminHelpersTest at org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests(TestAdminShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) test_exists?_should_return_true_when_a_table_exists is already defined in Hbase::AdminHelpersTest [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 199.313 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAdminShell [ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests Time elapsed: 0.085 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) test_exists?_should_return_true_when_a_table_exists is already defined in Hbase::AdminHelpersTest at org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests(TestAdminShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) test_exists?_should_return_true_when_a_table_exists is already defined in Hbase::AdminHelpersTest [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 357.884 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestQuotasShell [ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests Time elapsed: 354.48 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) Shell unit tests failed. Check output file for details. at org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests(TestQuotasShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) Shell unit tests failed. Check output file for details. [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 370.594 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestQuotasShell [ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests Time elapsed: 0.082 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) test_limit_space_errors_on_non_Hash_argument is already defined in Hbase::SpaceQuotasTest at org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests(TestQuotasShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) test_limit_space_errors_on_non_Hash_argument is already defined in Hbase::SpaceQuotasTest [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 382.238 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestQuotasShell [ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests Time elapsed: 0.062 s <<< ERROR! org.jruby.embed.EvalFailedException: (RuntimeError) test_limit_space_errors_on_non_Hash_argument is already defined in Hbase::SpaceQuotasTest at org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests(TestQuotasShell.java:40) Caused by: org.jruby.exceptions.RaiseException: (RuntimeError) test_limit_space_errors_on_non_Hash_argument is already defined in Hbase::SpaceQuotasTest [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] org.apache.hadoop.hbase.client.TestAdminShell.testRunShellTests [ERROR] Run 1: TestAdminShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell unit tes... [ERROR] Run 2: TestAdminShell.testRunShellTests:40 » EvalFailed (RuntimeError) test_exists?_s... [ERROR] Run 3: TestAdminShell.testRunShellTests:40 » EvalFailed (RuntimeError) test_exists?_s... [INFO] [ERROR] org.apache.hadoop.hbase.client.TestQuotasShell.testRunShellTests [ERROR] Run 1: TestQuotasShell.testRunShellTests:40 » EvalFailed (RuntimeError) Shell unit te... [ERROR] Run 2: TestQuotasShell.testRunShellTests:40 » EvalFailed (RuntimeError) test_limit_sp... [ERROR] Run 3: TestQuotasShell.testRunShellTests:40 » EvalFailed (RuntimeError) test_limit_sp... {code} It seems that Ruby thinks that the test methods are defined twice." Backport HBASE-23146 (Support CheckAndMutate with multiple conditions) to branch-1,13290224,Resolved,Major,Won't Fix,06/Mar/20 23:32,02/Aug/22 09:04,,"Backport HBASE-23146 (Support CheckAndMutate with multiple conditions) to branch-1, including updates to REST (HBASE-23924) and Thrift (HBASE-23925). " Backport HBASE-17115 (HMaster/HRegion Info Server does not honour admin.acl) to 1.x,13282279,Resolved,Major,Won't Fix,29/Jan/20 22:53,02/Aug/22 09:04,, Use less resources running tests,13290844,Resolved,Major,Fixed,10/Mar/20 15:40,29/Apr/20 22:44,,"Our tests can create thousands of threads all up in the one JVM. Using less means less memory, less contention, likelier passes, and later, more possible parallelism. I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to see what it does as it runs (this test puts up 4 clusters with replication between). It peaks at 2k threads. After some configuration and using less HDFS, its possible to get it down to ~800 threads and about 1/2 the memory-used. HDFS is a main offender. DataXceivers (Server and Client), jetty threads, Volume threads (async disk 'worker' then another for cleanup...), image savers, ipc clients -- new thread per incoming connection w/o bound (or reuse), block responder threads, anonymous threads, and so on. Many are not configurable or boundable or are hard-coded; e.g. each volume gets 4 workers regardless. Biggest impact was just downing the count of data nodes. TODO: a follow-on that turns down DN counts in all tests. I've been using Java Flight Recorder during this study. Here is how you get a flight recorder for the a single test run: \{code:java} MAVEN_OPTS="" -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"" mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 \{code} i.e. start recording on mvn launch, bound the size of the recording, and have the test run in the mvn context (DON'T fork). Useful is connecting to the running test at the same time from JDK Mission Control. We do the latter because the thread reporting screen is overwhelmed by the count of running threads and if you connect live, you can at least get a 'live threads' graph w/ count as the test progresses. Useful. When the test finishes, it dumps a .jfr file which can be opened in JDK MC. I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC Version 7, the non-commercial latest. Works pretty well. Let me put up a patch for tests that cuts down thread counts where we can. Let me put up a patch that does first pass on curtailing resource usage." Split TestFromClientSide; it takes too long to complete timing out,13290922,Resolved,Major,Fixed,10/Mar/20 21:55,06/Jul/22 10:20,1.7.0,The TestFromClientSide test was parameterized recently so we'd run full sweet with one of three registries. Test now often takes longer than max 13 minutes allowed. Split the test. [Documentation] Doc the dead servers multicast feature,13285518,Closed,Major,Not A Problem,15/Feb/20 17:31,24/Jun/22 19:09,,Setting a config on master enables the multicast feature where master will udp broadcast to all listeners -- clients -- when it learns of dead servers. Clients that get notification react by redoing their region locations cache which helps them be more response when servers die. This feature has been around for years but probably goes unknown since no mention in documentation. This issue is about adding a basic paragraph on what it does and how to use it. The original issue has a nice release note that could serve as the basis for this paragraph. See HBASE-7590 [Flakey Test] TestAsyncTableRSCrashPublish times out VPN enabled,13285516,Closed,Major,Fixed,15/Feb/20 17:09,24/Jun/22 19:08,,"This is an odd one. If I put up VPN on my local machine, this TestAsyncTableRSCrashPublish test times out. If I take down the VPN, the test passes. This is actually an awkward issue to trace since the udp multicast stuff doesn't log much about its operation. Digging, the VPN adds a utun8 network interface to my box. When this eighth interface comes on line, the TestAsyncTableRSCrashPublish test will select this new interface, which is ipv4, for the master to publish events on, but the clients will choose the seventh utun interface, which is ipv6, for listening. If no vpn, both pick an en?? interface and all just works. I've messed around with the test and tried having the master add the networkinterface its chosen to the configuration, and then had the clients use same network interface, but somehow clients insist on listening on ipv6. No matter how I mess -- even insisting on ipv4 on client and server (see coming attached code), the clients don't get the master broadcast. Attached code is my hacking trying to make sense of this. Let me make a trivial subtask to add the logging at least in case someone runs into this in prod, they'll have a chance for figuring out mismatched networking (currently there is no way to figure w/o changing code). " Generate CHANGES.md and RELEASENOTES.md for 2.1.10,13294228,Closed,Major,Fixed,26/Mar/20 15:43,31/Mar/20 15:12,, Put up 2.1.10RC0,13294229,Closed,Major,Fixed,26/Mar/20 15:43,30/Mar/20 01:57,, Put up 2.1.10RC1,13295278,Closed,Major,Fixed,31/Mar/20 14:53,08/Apr/20 03:38,, Add 2.1.10 to download page,13294230,Closed,Major,Fixed,26/Mar/20 15:43,08/Apr/20 11:57,, Set version as 2.1.10 in branch-2.1 in prep for first RC of 2.1.10,13294227,Closed,Major,Fixed,26/Mar/20 15:43,27/Mar/20 18:08,, Release 2.1.10,13294226,Closed,Major,Fixed,26/Mar/20 15:43,11/Apr/20 06:23,, Add 2.1.9 to download page,13285732,Closed,Major,Fixed,17/Feb/20 09:56,18/Feb/20 02:32,, Put up 2.1.9RC0,13285730,Closed,Major,Fixed,17/Feb/20 09:56,17/Feb/20 09:57,, Generate CHANGES.md and RELEASENOTES.md for 2.1.9,13284122,Closed,Major,Fixed,09/Feb/20 09:29,10/Feb/20 03:26,, Set version as 2.1.9 in branch-2.1 in prep for first RC of 2.1.9,13284121,Closed,Major,Fixed,09/Feb/20 09:20,10/Feb/20 01:32,, Set version as 2.1.10-SNAPSHOT in branch-2.1,13285733,Closed,Major,Fixed,17/Feb/20 09:57,18/Feb/20 05:51,, Release 2.1.9,13284120,Closed,Major,Fixed,09/Feb/20 09:14,29/Feb/20 02:31,, Make branch-2.1 EOM,13294231,Closed,Major,Fixed,26/Mar/20 15:43,20/May/20 14:57,, Periodic 2.1.x releases,13288423,Closed,Major,Fixed,29/Feb/20 02:23,01/May/20 12:37,,"A parent issue to track all the 2.1.x release issues, will be closed once 2.1.x is EOL." Revert binary incompatible change and remove reflection,13279397,Closed,Major,Fixed,14/Jan/20 16:52,24/Jan/20 21:02,2.1.9,Based on the feedback from Sean on the branch-1 [backport|https://github.com/apache/hbase/pull/1034] of HBASE-23622 the introduced binary incompatible change in {{ByteRangeUtils}} should be reverted. Also the reflection parts in {{CommonFSUtils}} should be removed. Dynamically turn on RingBuffer for slow/large RPC logs,13289872,Open,Major,,05/Mar/20 17:15,,1.7.0,Make hbase.regionserver.slowlog.buffer.enabled dynamically configurable and accordingly turn on/off RingBuffer in RegionServers to start/stop storing complete slow RPC logs for operator to retrieve. Move HBaseClusterManager.CommandProvider and it's different implementations as seperate class/interface,13277362,Open,Major,,03/Jan/20 12:03,,,"HBaseClusterManager.CommandProvider and it's implementations are private to HBaseClusterManager and hbase-it package.  If any one wants to do custom implementations of ClusterManager Interface, they cant's use this code as it is not visible outside the hbase-it package.  This Jira is also dependents on [HBASE-23639|https://issues.apache.org/jira/browse/HBASE-23639]" ZNodeClearer#clear() throws IllegalArgumentException ,13278400,Patch Available,Major,,09/Jan/20 08:24,,2.1.5,"Precondition: hbase.balancer.tablesOnMaster = true hbase.balancer.tablesOnMaster.systemTablesOnly = true In case of master-rs collocation HBASE_ZNODE_FILE is overwritten by regionserver process in HRegionServer#handleReportForDutyResponse() here is how it looks on master server: [hadoop@master-node data]$ cat hbase-hadoop-master.znode /hbase/rs/master-node,16000,1578371505720 When ZNodeClearer#clear(), the rsZNode is also splicing with the contents of the file, causing an exception： java.lang.IllegalArgumentException: Invalid path string ""/hbase/rs//hbase/rs/master-node,16000,1578371503003"" caused by empty node name specified @10         at org.apache.zookeeper.common.PathUtils.validatePath(PathUtils.java:99)         at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:851)         at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:166)         at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1259)         at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNodeFailSilent(ZKUtil.java:1251)         at org.apache.hadoop.hbase.ZNodeClearer.clear(ZNodeClearer.java:188)         at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:144)         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)         at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3117)  " Bump netty version to 4.1.45.Final in hbase-thirdparty,13283250,Resolved,Major,Fixed,04/Feb/20 13:51,06/Feb/20 11:03,thirdparty-3.2.0,We do have a new netty version 4.1.45.Final which we could update to. [Flakey Tests] Re-enable TestCustomSaslAuthenticationProvider#testNegativeAuthentication,13294036,Resolved,Major,Duplicate,25/Mar/20 22:42,20/Jan/22 14:57,,See parent issue which disables flakey test. This task is to reenable once flakey-ness has been cleared. [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState,13283283,Resolved,Major,Fixed,04/Feb/20 16:51,31/Dec/21 14:06,1.7.0,"{{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}} fails with {noformat} java.lang.IllegalArgumentException: Wrong FS: file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1, expected: hdfs://localhost:44609 at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110) at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90) {noformat}" lack of HMaster parameters in the SnapshotLogCleaner leads to NLP,13277632,Open,Major,,06/Jan/20 06:20,,1.2.11,"NullPointException occurs when the SnapshotCleaner calls the init function to initialize the HMaster parameter. Similar to the construction method of HFileCleaner, because the construction method of LogCleaner did not have HMaster parameter, leading to errors. Therefore, the construction method of LogCleaner solves the problem by adding HMaster parameters. The Log: {code:java} java.lang.NullPointerExceptionjava.lang.NullPointerException at org.apache.hadoop.hbase.master.snapshot.SnapshotLogCleaner.init(SnapshotLogCleaner.java:74) at org.apache.hadoop.hbase.master.cleaner.TestSnapshotAndLogCleaner.testSnapshotLogCleaning(TestSnapshotAndLogCleaner.java:68){code}" [HBCK2] Expose Multi-Region merge feature via hbck2,13284454,Open,Major,,11/Feb/20 00:49,,,"HBase Master can do multi-region merge from: 2.0.6,2.1.6,2.2.1,2.3.0,3.0.0 HBASE-22827 aims at exposing the feature via shell from: 2.3.0 & 3.0.0 Let's use this Jira to track, exposing the access to the multi-region merge feature from hbck2 for the versions where shell feature isn't available but the master supports the multi merge feature & hbck service supports mergeRegions api: i.e. 2.1.9+, 2.2.4+ and of course 2.3.0+,3.0.0+ where both shell/hbck2 would be able to do the task for us." HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jetty version mismatch,13284966,Resolved,Major,Fixed,13/Feb/20 03:52,12/Oct/20 05:53,,"HBase master branch is currently on Jetty 9.3, and latest Hadoop 3 (unreleased branches trunk, branch-3.2 and branch-3.1) bumped Jetty to 9.4 to address a vulnerability CVE-2017-9735. (1) Jetty 9.3 and 9.4 are quite different (there are incompatible API changes) and HBase won't start on the latest Hadoop 3. (2) In any case, HBase should update its Jetty dependency to address the vulnerability. Fortunately for HBase, updating to Jetty 9.4 requires no code change other than the maven version string. More tests are needed to verify if HBase can run on older Hadoop versions if its Jetty is updated." Add documentation on how to enable and view tracing with OpenTelemetry,13282093,Resolved,Major,Fixed,29/Jan/20 00:54,09/Apr/21 04:05,3.0.0-alpha-1, Add trace support for simple apis in async client,13287763,Resolved,Major,Fixed,26/Feb/20 14:49,18/Jan/21 03:12,,"The asynchronous hbase client framework (HBASE-16833) was added in HBase 2.0 and doesn't have HTrace traces. Let's add the OpenTracing traces as part of the OT migration project. ===== Update ===== Use OpenTelemetry to implement tracing in async client. And first we will implement tracing for simple APIs, such as get, put and so on. Will file a separated issue to implement trace support for scan related API as it much more complicated." [SimpleRpcServer] Subsequent requests will have no response in case of request IO mess up,13288586,Open,Major,,01/Mar/20 19:35,,,"Code in SimpleServerRpcConnection#readAndProcess work like this {code:java} public int readAndProcess() throws IOException, InterruptedException {   …   if (data == null) {     …     initByteBuffToReadInto(dataLength);     …   }   count = channelDataRead(channel, data);   if (count >= 0 && data.remaining() == 0) { // count==0 if dataLength == 0     process();   }   return count; } {code} In case of request IO mess up, _data.remaining()_ may be greater than 0, so _process()_ method will not be executed. There are some cleanup operations in _process()_ {code:java} private void process() throws IOException, InterruptedException { data.rewind(); try { .. } finally { dataLengthBuffer.clear(); // Clean for the next call data = null; // For the GC this.callCleanup = null; } } {code} If _process()_ not executed, variable _data_ will always not null, and _data.remaining()_ will always be greater than 0, so _process()_ will never be executed again, and subsequent requests will have no response, this has been occured in our product env." HBase Bad Substitution ERROR on hadoop-functions.sh,13295380,Open,Major,,31/Mar/20 23:52,,2.2.3,"Any Time i make a call to hbase (e.g. ""hbase version"" or ""hbase-daemon.sh start master"", i receive this error message: */usr/hdeco/hadoop/bin/../libexec/hadoop-functions.sh: line 2366: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_USER: bad substitution* */usr/hdeco/hadoop/bin/../libexec/hadoop-functions.sh: line 2461: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_OPTS: bad substitution*   ""hbase version"" does provide version information after this error message, but i am unable to start the hbase master, so i am unable to use hbase further.   I have never posted in any forum before, so let me know if more information is needed." Stop WALProcedureStore after migration finishes,13279654,Resolved,Major,Duplicate,15/Jan/20 18:29,15/Jan/20 22:09,2.3.0,WALProcedureStore is left up with its sync thread running in background though we are done with after starting it inside the migration method. Add stop when done. Address feedback on HBASE-23055 Alter hbase:meta.,13278769,Resolved,Major,Won't Fix,10/Jan/20 17:47,18/Jan/20 00:00,2.3.0,Good feedback on HBASE-23055 came in after merge from [~zhangduo]. Opening this issue to address it. [OpenTracing] Declare HTrace is unusable in the user doc,13282073,Resolved,Major,Fixed,28/Jan/20 22:40,24/Feb/20 17:49,,"The trace doesn't work at all in HBase 2.0 and above after HBASE-18601 (the trace doesn't get picked up at the server side). We should make a note in the user doc stating it is # unusable # deprecated in HBase 2.x because HTrace is in Attic. # removed from HBase 3.0 and above." Provide documentation for running Yetus with HBase,13295085,Resolved,Major,Fixed,30/Mar/20 20:44,23/Nov/20 19:52,,"A colleague asked how to use Yetus with HBase, so I wrote up a little how-to doc. Maybe it's useful to someone else?" Change nightly poll from cron @daily to pollSCM @daily; i.e. run nightly if a change ONLY,13292570,Resolved,Major,Fixed,18/Mar/20 21:34,18/Mar/20 21:48,,"Change build on branch-1.3, 1.4, 2.1, and feature branches HBASE-23162-branch-1 and HBASE-22114-branch-1 to be pollSCM @daily -- i.e. poll once a day and if change run nightly -- rather than build every night regardless. See https://lists.apache.org/thread.html/r5dca2cacc123f2e5719c622add6853ac62b56b2a77885fe0b2eb53c3%40%3Cdev.hbase.apache.org%3E for dev list discussion on downing our nightly load." [flakey test] TestVerifyBucketCacheFile,13291412,Resolved,Major,Fixed,12/Mar/20 19:28,06/May/20 05:07,3.0.0-alpha-1,"I see sporadic failures in this test class. Sometimes a failure on {{assertTrue(file.delete())}}, an inconsistent annoyance. However, this one looks more sinister. {noformat} 2020-03-12 12:11:35,059 ERROR [Time-limited test] bucket.BucketCache(312): Can't restore from file[/Users/ndimiduk/repos/apache/hbase/hbase-server/target/test-data/5e5c5f5f-d5c2-94b2-8ce9-cf561f4f19f7/bucket.persistence] because of java.io.IOException: Mismatch of checksum! The persistent checksum is ���&#20;B&#16;k�&#3;��2�Ӏk, but the calculate checksum is �o���r��w��c��4 at org.apache.hadoop.hbase.io.hfile.bucket.PersistentIOEngine.verifyFileIntegrity(PersistentIOEngine.java:55) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.parsePB(BucketCache.java:1158) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(BucketCache.java:1106) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.(BucketCache.java:310) at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.(BucketCache.java:258) at org.apache.hadoop.hbase.io.hfile.bucket.TestVerifyBucketCacheFile.testRetrieveFromFile(TestVerifyBucketCacheFile.java:116) {noformat}" [HBCK2] Add mergeRegions method to hbck service,13284511,In Progress,Major,,11/Feb/20 07:36,,,Let's add the mergeRegions method to the hbck service so that hbck2 can use it from the client side. New L1 cache : AdaptiveLRU,13287155,Resolved,Major,Fixed,24/Feb/20 08:17,15/Feb/21 15:18,,"Hi! I first time here, correct me please if something wrong. All latest information is here: [https://docs.google.com/document/d/1X8jVnK_3lp9ibpX6lnISf_He-6xrHZL0jQQ7hoTV0-g/edit?usp=sharing] I want propose how to improve performance when data in HFiles much more than BlockChache (usual story in BigData). The idea - caching only part of DATA blocks. It is good becouse LruBlockCache starts to work and save huge amount of GC. Sometimes we have more data than can fit into BlockCache and it is cause a high rate of evictions. In this case we can skip cache a block N and insted cache the N+1th block. Anyway we would evict N block quite soon and that why that skipping good for performance. --- Some information below isn't  actual ---     Example: Imagine we have little cache, just can fit only 1 block and we are trying to read 3 blocks with offsets: 124 198 223 Current way - we put the block 124, then put 198, evict 124, put 223, evict 198. A lot of work (5 actions). With the feature - last few digits evenly distributed from 0 to 99. When we divide by modulus we got: 124 -> 24 198 -> 98 223 -> 23 It helps to sort them. Some part, for example below 50 (if we set *hbase.lru.cache.data.block.percent* = 50) go into the cache. And skip others. It means we will not try to handle the block 198 and save CPU for other job. In the result - we put block 124, then put 223, evict 124 (3 actions). See the picture in attachment with test below. Requests per second is higher, GC is lower.   The key point of the code: Added the parameter: *hbase.lru.cache.data.block.percent* which by default = 100   But if we set it 1-99, then will work the next logic:     {code:java} public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean inMemory) {    if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())       if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)  return;     ... // the same code as usual } {code}   Other parameters help to control when this logic will be enabled. It means it will work only while heavy reading going on. hbase.lru.cache.heavy.eviction.count.limit - set how many times have to run eviction process that start to avoid of putting data to BlockCache hbase.lru.cache.heavy.eviction.bytes.size.limit - set how many bytes have to evicted each time that start to avoid of putting data to BlockCache By default: if 10 times (100 secunds) evicted more than 10 MB (each time) then we start to skip 50% of data blocks. When heavy evitions process end then new logic off and will put into BlockCache all blocks again.   Descriptions of the test: 4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem. 4 RegionServers 4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF) Total BlockCache Size = 48 Gb (8 % of data in HFiles) Random read in 20 threads   I am going to make Pull Request, hope it is right way to make some contribution in this cool product.    " Backport HBASE-22285 (MergeToNormalize) to branch-1,13291011,Resolved,Major,Won't Do,11/Mar/20 07:53,28/Jan/21 05:30,1.7.0,A normalizer which merges very small size regions with adjacent regions (MergeToNormalize) [OpenTracing] Add traces in Procedure V2,13287760,Resolved,Major,Won't Fix,26/Feb/20 14:32,22/Jan/21 02:28,,"Procedure V2 (HBASE-12439) was added in Hbase 2.0 and doesn't have HTrace integrated. As part of the OpenTracing migration project, we'll add traces in Procedure V2 calls." [OpenTracing] Migrate hbase shell and scripts from HTrace to OpenTracing,13282085,Resolved,Major,Won't Fix,28/Jan/20 23:55,22/Jan/21 02:28,, Use errorProne profile for pre commit verification,13280130,Resolved,Major,Duplicate,17/Jan/20 13:20,13/Jan/21 14:43,,"Many times we ran into the problem that the pre-commit verification was successful but after the commit landed on the branch errorProne failed in the Nightly builds. We should already use errorProne profile during the pre-commit builds to prevent similar build failures." Update of errorprone generated failures,13282064,Resolved,Major,Fixed,28/Jan/20 21:50,29/Jan/20 02:55,,Parent issue updated hbase-thirdparty which updated errorprone. The nightly compile started failing with 'compile'/errorprone complaints. All look good. Let me fix. [OpenTracing] Migrate from HTrace to OpenTracing (Java code),13282077,Resolved,Major,Won't Fix,28/Jan/20 22:49,24/Dec/20 02:40,3.0.0-alpha-1, [OpenTracing] Add OpenTracing dependency and helper methods,13282076,Resolved,Major,Won't Fix,28/Jan/20 22:48,24/Dec/20 02:38,3.0.0-alpha-1, [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty,13284010,Resolved,Major,Won't Fix,07/Feb/20 20:57,20/Dec/20 14:48,,"JaegerTracing pulls in lots of dependencies. Some, like libthrift (0.13.0) conflicts the one ships in HBase (0.12.0). Additionally, not everyone may want to use Jaeger. I propose to shade JaegerTracing and its dependencies into an uber jar, place it as a hbase-thirdparty artifact. As an added benefit, this makes the management of tracers in the HBase's dependency tree much easier. Finally, we can follow the same suit and provide Zipkin tracer support in the future." Backport [HBASE-21874 Bucket cache on Persistent memory] to branch-2.2,13281460,Resolved,Major,Fixed,24/Jan/20 18:31,27/Jan/20 09:10,2.2.2,"We had patch for backporting HBASE-21874 into branch-2.2 attached to that original jira, but it never went through and per discussions there, decided to close it and open later a separate Jira for the backport." Make our core coprocessors use shaded protobuf,13283350,Resolved,Major,Fixed,05/Feb/20 01:39,23/Mar/20 00:48,, PreCommit-HBASE-Build ignores the `ATTACHMENT_ID` provided by PreCommit-Admin,13287357,Resolved,Major,Won't Fix,24/Feb/20 22:27,30/Oct/20 22:48,,"It appears that we've dropped the parameter {{ATTACHMENT_ID}} from our {{PreCommit-HBASE-Build}} job. (It may be the case that Yetus's {{test-patch}} doesn't support specifying what attachment id to test.) The result, I believe, is that when a Jira issue has patches attached for more than one branch, we only get precommit testing on the patch for master." Coverage for Assign and Unassign of Regions on RegionServer on failure,13292550,Resolved,Major,Fixed,18/Mar/20 19:32,25/Oct/20 10:13,,"Looking at 'HBASE-23984 [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown', and at UnassignRegionHandler, AssignRegionHandler, CloseRegionHandler, and the work that is done inline w/ request vs that which to the side in executors, we need more coverage and specification of what happens around the edges. This coverage would be more to see if holes in our handling currently in a unit test case context before we see it out on clusters. HBASE-23984 addresses holes where UnassignRegionHandler and AssignRegionHandler could skip out w/o clearing Regions from the RegionServer#regionsInTransitionInRS Map of Regions In Transition if failed open or close because the RegionServer is aborting. Other holes seem lurking. On exception, we were leaving entries in the RegionServer# submittedRegionProcedure map added by HBASE-2204; not the end of the world but they should be cleared on error? HBASE-23984 adds clearning from submittedRegionProcedure but then procedures even if failed get added to the cache of procedures... so if we try to run the procedure again against this server it won't be scheduled. interesting stuff. This issue is about adding tests that fail assign/unassign/close on the RegionServer side making sure RS state is left in a good condition on fail. " [JDK11] build with -PerrorProne silently fails,13287639,Resolved,Major,Won't Fix,26/Feb/20 00:08,21/Oct/20 19:11,,"Build seems to simply stop at {{hbase-protocol-shaded}} without explanation. Dropping {{-PerrorProne}} allows the build to proceed, at least locally." "Backport HBASE-22978(with sub-tasks), HBASE-24718, HBASE-24528 to branch-1",13289863,Resolved,Major,Fixed,05/Mar/20 16:46,16/Oct/20 06:52,1.7.0, Separate a hbase-balancer or hbase-assignment module,13289704,Resolved,Major,Fixed,05/Mar/20 05:33,29/Apr/20 03:59,,"Open an issue here. After we merge hbase-rsgroup back to hbase-server, the hbase-server even makes findbugs OOM... So I think we should try to move out classes to make the module smaller..." Improve performance of move_servers_rsgroup and move_tables_rsgroup by using async region move API,13292969,Resolved,Major,Fixed,20/Mar/20 15:40,09/Oct/20 19:12,,"Currently move_servers_rsgroup and move_tables_rsgroup commands and APIs are taking lot of time. In my test environment, to move a server with 100 regions it takes around 137 seconds. Similarly it takes around same time to move a table with 100 regions to other group. The time taken in rsgroup meta update is negligible. Almost all the time is taken in region moment. This is happening because region is moved serially using getAssignmentManager().move(region) API API getAssignmentManager().moveAsync(regionplan) can be used to move the regions in parallel to improve the performance of region group move servers and tables commands and APIs " Fix javadoc for JDK11,13290876,Resolved,Major,Fixed,10/Mar/20 17:38,08/Oct/20 04:47,2.3.0,Javadoc build fails with JDK11. See if this can be fixed to pass on both 8 and 11. [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException,13294499,Resolved,Major,Fixed,27/Mar/20 15:56,07/Apr/20 23:24,,"This fails for me locally sporadically. {code} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide ------------------------------------------------------------------------------- Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<< FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync Time elapsed: 0.325 s <<< ERROR! java.lang.NullPointerException {code} Log pinpoints the problem a little better {code} Exception in thread ""testTable.asyncPrefetcher"" java.lang.NullPointerException at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183) at java.lang.Thread.run(Thread.java:748) java.lang.NullPointerException at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174) at java.lang.Thread.run(Thread.java:748) java.lang.NullPointerException at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174) at java.lang.Thread.run(Thread.java:748) 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268] hbase.TestServerSideScanMetricsFromClientSide(202): FAIL java.lang.NullPointerException at org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174) at java.lang.Thread.run(Thread.java:748) {code} It didn't make sense to me since complaint was about a 'lock' that is created as a final data member. But then this issue happened for my compañero, [~ndimiduk]... and he saw that the call is from a Thread inner class in this class's grandparent that is set running on construction; i.e. the lock *could* be null at the time of reference." Backport HBASE-22480 to branch-2.1,13290345,Patch Available,Major,,08/Mar/20 05:18,,2.0.6,"My HBase 2.0/2.1 cluster experienced severe performance drop after running reversed scans for weeks plus 1~2 major compaction. When debug into regionserver logs, it appears the bucket cache is full for every ~100 ms and its eviction can't work properly because ref count has become negative:  {code:java} (every ~100 ms) Free started because ""Full!"" This block AAA is still referred by -1 readers. Can not be freed now This block BBB is still referred by -2 readers. Can not be freed now This block CCC is still referred by -3 readers. Can not be freed now ... This block ... is still referred by (negative number) readers. Can not be freed now {code} There have been patch HBASE-22480 by [~binlijin] addressing this ref count problem in 2.2+. I'd like to backport it to 2.1 (understand that 2.0 is EOL)  " Release 2.3.0,13292524,Resolved,Major,Done,18/Mar/20 16:49,25/Sep/20 16:24,, "Add document for ""HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs""",13277464,Resolved,Major,Fixed,04/Jan/20 07:36,11/Sep/20 06:41,,Add the new feature of hbtop in HBASE-23065 to the ref guide. [Flakey Tests] Disable TestClusterScopeQuotaThrottle#testUserNamespaceClusterScopeQuota,13293379,Resolved,Major,Fixed,23/Mar/20 20:40,23/Mar/20 20:46,,"testUserNamespaceClusterScopeQuota in TestClusterScopeQuotaThrottle is just spewing: {code} 2020-03-23 13:33:23,996 INFO [Listener at localhost/50281] hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore, period=1800000, unit=MILLISECONDS is enabled. 2020-03-23 13:33:25,000 INFO [Listener at localhost/50281] hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore, period=1800000, unit=MILLISECONDS is enabled. 2020-03-23 13:33:26,002 INFO [Listener at localhost/50281] hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore, period=1800000, unit=MILLISECONDS is enabled. 2020-03-23 13:33:27,003 INFO [Listener at localhost/50281] hbase.ChoreService(157): Chore ScheduledChore name=QuotaRefresherChore, period=1800000, unit=MILLISECONDS is enabled. {code} If I run it standalone it passes. Fails in nightly currently. Rather than spend time on this, disabling for now. It came in a good while ago as part of HBASE-21820" NettyRpcClientConfigHelper will not share event loop by default which is incorrect,13291672,Resolved,Major,Fixed,14/Mar/20 03:42,26/Aug/20 07:55,, [Flakey Tests] A couple of fixes and cleanups,13293366,Resolved,Major,Fixed,23/Mar/20 18:56,23/Mar/20 23:29,,"Here's a few cleanups and flakey fixes accumulated in last few days: {code} hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupMajorCompactionTTL.java Remove spurious assert. Just before this it waits an arbitrary 10 seconds. Compactions could have completed inside this time. The spirit of the test remains. hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java Get log cleaner to go down promptly; its sticking around. See if this helps with TestMasterShutdown hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java We get a rare NPE trying to sync. Make local copy of SyncFuture and see if that helps. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java Compaction may have completed when not expected; allow for it. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestBlockEvictionFromClient.java Add wait before testing. Compaction may not have completed. Let compaction complete before progressing and then test for empty cache. hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java Less resources. hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestDefaultLoadBalancer.java Less resources. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java Wait till online before we try and do compaction (else request is ignored) hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java Disable test that tests for timeout that fails randomly w/ mockito complaint on some mac os x's. {code}" [Flakey Tests] Misc fixes and debug; fix BindException in Thrift tests; add waits on quota table to come online; etc.,13295057,Resolved,Major,Fixed,30/Mar/20 17:29,14/Aug/20 00:49,,"Some fixes that have accumulated over last few days. Fixes for weird NPE on construction of ClientAsyncPrefetchScanner, catches for unexpected, test-killing exceptions in RSProcedureDispatcher and in CompactSplit; add waits on quota table to come on line and regionservers to go down before proceeding; add retry if BindException in thrift tests; disabled a few flakies; etc. Add some debug too. {code} hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java Refactor to avoid NPE timing issue referencing lock during Construction. hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java Comment hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java Refactor. Catch NPE during startup and return it instead as failed initialization. hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java Catch IndexOutOfBounds exception and convert to non-split request. hbase-server/src/test/java/org/apache/hadoop/hbase/TestCachedClusterId.java Make less furious. Make it less flakie. hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java Debug. Catch exception to log, then rethrow. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java Guess that waiting longer on compaction to succeed may help make this less flakey. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java Be explicit about timestamping to avoid concurrent edit landing server-side and messing up test expectation. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMasterRegistry.java Add wait on meta before proceeding w/ test. hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java Be explicit that edits are distinct. hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCacheRefCnt.java Add @Ignore on RAM test... Fails sporadically. hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java Add wait for all RegionServers going down before proceeding; was messing up RS accounting. hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java Make balancer test sloppier; less restrictive; would fail on occasion by being just outside test limits. hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java Add wait on quota table coming up; helps make this less flakie. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java Be explicity about timestamps; see if helps w/ flakie failure. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java Catch and ignore if issue in shutdown; don't care if after test. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java Comment. hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Add retry to see if helps w/ odd failure; grant hasn't propagated? hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java Explicit w/ timestamps so no accidental overlap of puts. hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java Hack to deal w/ BindException on startup. hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThrift2ServerCmdLine.java Use loopback. hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java Disable flakie test. {code}" [Flakey Tests] TestMasterAbortAndRSGotKilled fails in teardown,13291665,Resolved,Major,Fixed,14/Mar/20 00:18,20/Mar/20 22:29,2.3.0,"Its failing with decent frequency of late in shutdown of cluster. Seems basic. There is an unassign/move going on. Test just checks Master can come back up after being killed. Does not check move is done. If on subsequent cluster shutdown, if the move can't report the Master because its shutting down, then the move fails, we abort the server, and then we get a wonky loop where we can't close because server is aborting. At the root, there is a misaccounting when the unassign close fails where we don't cleanup references in the regionserver local RIT accounting. Deeper than this, close code is duplicated in three places that I can see; in RegionServer, in CloseRegionHandler, and in UnassignRegionHandler. Let me fix this issue and the code dupe. Details: From https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2/5733/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestMasterAbortAndRSGotKilled-output.txt Here is the unassign handler failing because master went down earlier (Its probably trying to talk to the old Master location) {code} ***** ABORTING region server asf905.gq1.ygridcore.net,32989,1584000644108: Failed to close region ede67f9f661acc1241faf468b081d548 and can not recover ***** Cause: java.io.IOException: Failed to report close to master: ede67f9f661acc1241faf468b081d548 at org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:125) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code} ... then the cluster shutdown tries to close the same Region... but fails because we are aborting because of above.... {code} 2020-03-12 08:11:16,600 ERROR [RS_CLOSE_REGION-regionserver/asf905:0-0] helpers.MarkerIgnoringBase(159): ***** ABORTING region server asf905.gq1.ygridcore.net,32989,1584000644108: Unrecoverable exception while closing region hbase:namespace,,1584000652744.78f4ae5beda711a9bebad0b6b8376cc9., still finishing close ***** java.io.IOException: Aborting flush because server is aborted... at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2545) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2530) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2504) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2495) at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1650) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1552) at org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:110) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code} .... And the RS keeps looping trying to close the Region even though we're aborted and there is handling in RS close Regions to deal with abort. Trouble seems to be because when UnassignRegionHandler fails its region close, it does not unregister the Region with rs.getRegionsInTransitionInRS().remove(encodedNameBytes, Boolean.FALSE); " Address thread safety issue with Map used in BufferCallBeforeInitHandler.,13290676,Resolved,Major,Won't Fix,09/Mar/20 23:48,01/Jun/20 09:03,,"id2Call is a HashMap and has a call back method that accesses it that can be run via an executor as well as another method accessing it that can be run from a different thread. id2Call should likely be a ConcurrentHashMap to be shared like this." TestFromClientSide3 and subclasses often fail on testScanAfterDeletingSpecifiedRowV2.,13285052,Open,Major,,13/Feb/20 11:10,,,"This test method fails a fair amount on me with something like: TestFromClientSide3WoUnsafe>TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2:236 expected:<3> but was:<2> I had a hunch that it might be due to interference from other test methods running first so I tried changing the table name for just this method to be unique - still fails. However, when I just run testScanAfterDeletingSpecifiedRowV2 on it's own without the methods, it does not seem to fail so far. " [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits,13285528,Resolved,Major,Fixed,15/Feb/20 22:36,13/Apr/20 20:34,2.3.0,Fails 12-25% of the time in the GCE build. TestChoreService is very sensitive to resources.,13284698,Resolved,Major,Not A Problem,12/Feb/20 01:01,11/May/20 20:19,,More details following. TestReplicationEndpoint appears to fail a lot in my attempts for a clean test run locally.,13284677,Resolved,Major,Not A Problem,11/Feb/20 21:56,11/May/20 20:24,,"This test is failing for me like 30-40% of the time. Fail seems to usually be as below. I've tried increasing the wait timeout but that does not seem to help at all. {code} [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 105.145 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.TestReplicationEndpoint[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 105.145 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.TestReplicationEndpoint[ERROR] org.apache.hadoop.hbase.replication.TestReplicationEndpoint.testInterClusterReplication  Time elapsed: 38.725 s  <<< FAILURE!java.lang.AssertionError: Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2476 at org.junit.Assert.fail(Assert.java:89) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:203) at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:137) at org.apache.hadoop.hbase.replication.TestReplicationEndpoint.testInterClusterReplication(TestReplicationEndpoint.java:235){code}" [Flakey Tests] Allow that server may not yet be cleared from DeadServers in TestHBCKSCP,13291228,Resolved,Major,Fixed,12/Mar/20 06:01,10/Aug/20 01:18,,"Fails 4/11 times in branch-2 flakey-test runs. Fails at line #157 where we check to see if server still in dead server list. It may not have cleared yet. Thats ok. Let the test pass. We've already asserted server is cleared from meta, the point of HBCKSCP." Switch back to ZKConnectionRegistry by default at least in test,13287433,Resolved,Major,Won't Fix,25/Feb/20 07:23,24/Jul/20 13:14,,"For now, MasterRegistry can not deal with master restart, as it can not load the new master address automatically. I see there is a invalidateConnection method in HBaseTestingUtilities but it needs a very big refactoring to make all the UTs work like this. So here I suggest we switch back to ZKConnectionRegistry by default, and open a new feature branch to finish the TODOs and the refactoring on UTs. As now it is already a big problem for me as I want to merge a feature branch back to master but the state of UTs are a mess." [flakey test] TestTableOutputFormatConnectionExhaust,13292085,Resolved,Major,Fixed,17/Mar/20 00:13,19/Mar/20 04:57,2.3.0,"Hit this during master startup sequence in the test. {noformat} 2020-03-16 23:40:37,298 ERROR [StoreOpener-1588230740-1] conf.Configuration(2980): error parsing conf hbase-site.xml com.ctc.wstx.exc.WstxEOFException: Unexpected EOF in prolog at [row,col,system-id]: [1,0,""file:/home/vagrant/repos/hbase/hbase-mapreduce/target/test-classes/hbase-site.xml""] at com.ctc.wstx.sr.StreamScanner.throwUnexpectedEOF(StreamScanner.java:687) at com.ctc.wstx.sr.BasicStreamReader.handleEOF(BasicStreamReader.java:2220) at com.ctc.wstx.sr.BasicStreamReader.nextFromProlog(BasicStreamReader.java:2126) at com.ctc.wstx.sr.BasicStreamReader.next(BasicStreamReader.java:1181) at org.apache.hadoop.conf.Configuration$Parser.parseNext(Configuration.java:3277) at org.apache.hadoop.conf.Configuration$Parser.parse(Configuration.java:3071) at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2964) at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2930) at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2805) at org.apache.hadoop.conf.Configuration.get(Configuration.java:1199) at org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1253) at org.apache.hadoop.conf.Configuration.getBoolean(Configuration.java:1659) at org.apache.hadoop.hbase.HBaseConfiguration.checkDefaultsVersion(HBaseConfiguration.java:70) at org.apache.hadoop.hbase.HBaseConfiguration.addHbaseResources(HBaseConfiguration.java:84) at org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:98) at org.apache.hadoop.hbase.io.crypto.Context.(Context.java:44) at org.apache.hadoop.hbase.io.crypto.Encryption$Context.(Encryption.java:64) at org.apache.hadoop.hbase.io.crypto.Encryption$Context.(Encryption.java:61) at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:228) at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:5890) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1096) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1093) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) 2020-03-16 23:40:37,301 ERROR [master/bionic:0:becomeActiveMaster] regionserver.HRegion(1137): Could not initialize all stores for the region=hbase:meta,,1.1588230740 {noformat} Looking at the file under {{target/test-classes}}, it looks like this is a file written by YARN. {noformat} yarn.log-aggregation.file-formatsTFilefalseyarn-default.xml hbase.master.mob.ttl.cleaner.period86400falsehbase-default.xml dfs.namenode.resource.check.interval5000falsehdfs-default.xml mapreduce.jobhistory.client.thread-count10falsemapred-default.xml ... {noformat} My guess is that we have something in the MR framework unconfigured, it's writing these temporary job files to some default (like the first class path location or something??) and parallel test runs are stomping on each other." Snapshot owner cannot delete snapshot when ACL is enabled and Kerberos is not enabled,13287724,Resolved,Major,Fixed,26/Feb/20 11:10,23/Apr/20 03:15,2.2.3,"When ACL is enabled and Kerberos is not enabled, the snapshot owner cannot delete the snapshot. This is because the owner of the snapshot cannot be taken during permission verification. By investigation, found that only after HBase has enabled security authentication, the owner will be set when doing snapshot. SnapshotManager#takeSnapshotInternal {code:title=SnapshotManager.java|borderStyle=solid} RpcServer.getRequestUser().ifPresent(user -> { if (User.isHBaseSecurityEnabled(master.getConfiguration())) { builder.setOwner(user.getShortName()); } }); {code}  " Fail fast when bulkLoadHFiles method catch some IOException,13292824,Resolved,Major,Fixed,20/Mar/20 03:56,02/Apr/20 15:31,,"In production environment, we usually do bulkload huge amount hfile . It reasonable  fail fast when any  IOException occur   hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java {code:java} public Map> bulkLoadHFiles(Collection> familyPaths, boolean assignSeqId, BulkLoadListener bulkLoadListener, boolean copyFile, List clusterIds, boolean replicate) throws IOException { ...... try { this.writeRequestsCount.increment(); // There possibly was a split that happened between when the split keys // were gathered and before the HRegion's write lock was taken. We need // to validate the HFile region before attempting to bulk load all of them List ioes = new ArrayList<>(); List> failures = new ArrayList<>(); for (Pair p : familyPaths) { byte[] familyName = p.getFirst(); String path = p.getSecond(); HStore store = getStore(familyName); if (store == null) { IOException ioe = new org.apache.hadoop.hbase.DoNotRetryIOException( ""No such column family "" + Bytes.toStringBinary(familyName)); ioes.add(ioe); } else { try { store.assertBulkLoadHFileOk(new Path(path)); } catch (WrongRegionException wre) { // recoverable (file doesn't fit in region) failures.add(p); } catch (IOException ioe) { // unrecoverable (hdfs problem) ioes.add(ioe); } } } // validation failed because of some sort of IO problem. if (ioes.size() != 0) { IOException e = MultipleIOException.createIOException(ioes); LOG.error(""There were one or more IO errors when checking if the bulk load is ok."", e); throw e; } {code}" refactor loadBalancer implements for rsgroup balance by table to achieve overallbalanced,13290343,Resolved,Major,Fixed,08/Mar/20 03:24,25/Mar/20 04:07,2.2.0," now can not achieve overallbalanced when use rsgroup balancer and by table is on, because balance every table actually use the clusterload only contain one table's load. we should use clusterload contain all this rsgroup table's load to balance overall    hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java {code:java} public boolean balance(boolean force) throws IOException { ...... boolean isByTable = getConfiguration().getBoolean(""hbase.master.loadbalance.bytable"", false); Map>> assignments = this.assignmentManager.getRegionStates() .getAssignmentsForBalancer(tableStateManager, this.serverManager.getOnlineServersList(), isByTable); for (Map> serverMap : assignments.values()) { serverMap.keySet().removeAll(this.serverManager.getDrainingServersList()); } //Give the balancer the current cluster state. this.balancer.setClusterMetrics(getClusterMetricsWithoutCoprocessor()); this.balancer.setClusterLoad(assignments); List plans = new ArrayList<>(); for (Entry>> e : assignments.entrySet()) { List partialPlans = this.balancer.balanceCluster(e.getKey(), e.getValue()); if (partialPlans != null) { plans.addAll(partialPlans); } } {code} now do refactor: # add method 'balanceTable' in interface LoadBalancer # SimpleLoadBalancer and StochasticLoadBalancer do the real 'balanceTable' , and 'balanceTable' is not support in BaseLoadBalancer and RSGroupBasedLoadBalancer # RSGroupBasedLoadBalancer invoke balanceCluster , and pass GroupClusterLoad to internal balacer by group # internal balancer balance cluster invoke 'balanceTable' " Update license for jetty-client,13292083,Resolved,Major,Fixed,17/Mar/20 00:03,12/Apr/20 10:05,3.0.0-alpha-1,"After HBASE-22103, compiling on Haddop 3.3.0 has the following error: {{mvn clean install -Dhadoop.profile=3.0 -Dhadoop.version=3.3.0-SNAPSHOT -DskipTests -Dmaven.javadoc.skip=true}} {noformat} This product includes Jetty :: Asynchronous HTTP Client licensed under the Apache Software License - Version 2.0. ERROR: Please check ^^^^^^^^^^^^ this License for acceptability here: https://www.apache.org/legal/resolved If it is okay, then update the list named 'non_aggregate_fine' in the LICENSE.vm file. If it isn't okay, then revert the change that added the dependency. More info on the dependency: org.eclipse.jetty jetty-client 9.4.20.v20190813 {noformat} This is caused by YARN-8778 which added dependency on org.eclipse.jetty.websocket:websocket-client, and the Jetty 9.4 update in HADOOP-16152. {noformat} [INFO] +- org.apache.hadoop:hadoop-mapreduce-client-core:jar:3.3.0-SNAPSHOT:compile [INFO] | +- org.apache.hadoop:hadoop-yarn-client:jar:3.3.0-SNAPSHOT:compile [INFO] | | +- org.eclipse.jetty.websocket:websocket-client:jar:9.4.20.v20190813:compile [INFO] | | | +- org.eclipse.jetty:jetty-client:jar:9.4.20.v20190813:compile [INFO] | | | \- org.eclipse.jetty.websocket:websocket-common:jar:9.4.20.v20190813:compile [INFO] | | | \- org.eclipse.jetty.websocket:websocket-api:jar:9.4.20.v20190813:compile {noformat} Propose: update hbase-resource-bundle/src/main/resources/supplemental-models.xml to update the license text for jetty-client." [regression] Increase RESTServer buffer size back to 64k,13293574,Resolved,Major,Fixed,24/Mar/20 14:41,27/Mar/20 16:14,2.2.0,HBASE-14492 is not longer present in our current releases after HBASE-12894. Unfortunately our RESTServer is not extending HttpServer which means that {{DEFAULT_MAX_HEADER_SIZE}} is not being set and HTTP requests with a very large header can still cause connection issues for clients. A quick fix is just to add the settings to the {{HttpConfiguration}} configuration object. A long term solution should be to re-factor services that create an HTTP server and normalize all configuration settings across all of them. Add modules to mapreduce job classpaths,13294219,Resolved,Major,Fixed,26/Mar/20 15:10,27/Mar/20 16:03,2.1.10,"Modularization of hbase-server introduced new top-level modules that are missing from MapReduce jobs' classpath. CompactionTool job in MapReduce mode required ReplicationUtils class which is moved to the hbase-replication module." Literate builder API for version management in schema,13278783,Resolved,Major,Fixed,10/Jan/20 19:21,01/Apr/20 12:07,,"Lars designed the combination of VERSIONS, TTL, MIN_VERSIONS, and KEEP_DELETED_CELLS with a maximum of flexibility. There is a lot of nuance regarding their usage. Almost all combinations of these four settings make sense for some use cases (exceptions are MIN_VERSIONS > 0 without TTL, and KEEP_DELETED_CELLS=TTL without TTL). There should be a way to make the behavior with TTL easier to conceive when creating the schema. This could take the form of a literate builder API for ColumnDescriptor or an extension to an existing one. Let me give you a motivating example: We may want to retain all versions for a given TTL, and then only a specific number of versions after that interval elapses. This can be achieved with VERSIONS=INT_MAX, TTL=_retention_interval_, KEEP_DELETED_CELLS=TTL, MIN_VERSIONS=_num_versions_ . This is not intuitive though because VERSIONS has been used to specify the number of versions to retain (_num_versions_ in this example) since HBase version 0.1, so this is going to be a source of confusion - I've seen it in practice. A literate builder API, by way of the way we design its method names, could let a user describe more or less in speaking language how they want version retention to work, and internally the builder API could set the low level schema attributes. " Set version as 2.2.5-SNAPSHOT in branch-2.2,13292864,Resolved,Major,Fixed,20/Mar/20 08:12,20/Mar/20 08:22,, Regions Stuck in RIT in OPEN state,13295190,Resolved,Major,Cannot Reproduce,31/Mar/20 08:07,30/Jun/20 11:58,,"Observed few regions stuck in RIT in OPEN state in a cluster restart scenario. Analysis: 1. All RS were killed abruptly. 2. HMaster start SCP and initiated region assignments {noformat} 2020-03-24 22:27:08,821 | INFO | PEWorker-20 | Initialized subprocedures=[ {pid=49703, ppid=46611, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6, ASSIGN},...] | org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1697) {noformat} But HMaster failover happens before it complete. 4. New active master load the previous procedures and restore to RIT {noformat} 2020-03-24 22:30:04,815 | INFO | master/HM-IP:HM-PORT:becomeActiveMaster | Attach pid=49703, ppid=46611, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6, ASSIGN to rit=OFFLINE, location=null, table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6 to restore RIT | org.apache.hadoop.hbase.master.assignment.AssignmentManager.lambda$setupRIT$0(AssignmentManager.java:280) --- 2020-03-24 22:32:52,153 | WARN | ProcExecTimeout | STUCK Region-In-Transition rit=OPEN, location=RS-IP,RS-Port,1585057875346, table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6 | org.apache.hadoop.hbase.master.assignment.AssignmentManager.handleRegionOverStuckWarningThreshold(AssignmentManager.java:1340) --- 2020-03-24 22:41:51,837 | WARN | master/HM-IP:HM-PORT.Chore.1 | unknown_server=RS-IP,RS-Port,1585057875346/usertable01,user10268,1585053943990.871858cf2ef25a9e0e6b4f022a16ebc9.,.... | org.apache.hadoop.hbase.master.CatalogJanitor.scan(CatalogJanitor.java:181) {noformat} Region assignment was slow as we are testing with huge number of regions per RS, so RIT WARN message logged. 5. Finally region was assigned HM log: {noformat} 2020-03-24 22:42:26,386 | INFO | PEWorker-11 | Took xlock for pid=49703, ppid=46611, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6, ASSIGN | org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.waitRegions(MasterProcedureScheduler.java:737) 2020-03-24 22:42:26,446 | INFO | PEWorker-11 | Starting pid=49703, ppid=46611, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6, ASSIGN; rit=OPEN, location=null; forceNewPlan=true, retain=false | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:189) 2020-03-24 22:42:26,717 | INFO | PEWorker-17 | pid=49703 updating hbase:meta row=75a79e978362d6f4ee1a3e27dfc5d4b6, regionState=OPENING, regionLocation=RS-IP,RS-Port,1585060304365 | org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateUserRegionLocation(RegionStateStore.java:201) 2020-03-24 22:42:27,439 | INFO | PEWorker-19 | pid=49703 updating hbase:meta row=75a79e978362d6f4ee1a3e27dfc5d4b6, regionState=OPEN, openSeqNum=5, regionLocation=RS-IP,RS-Port,1585060304365 | org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateUserRegionLocation(RegionStateStore.java:201) 2020-03-24 22:42:27,701 | INFO | PEWorker-19 | Finished subprocedure pid=73705, resume processing parent pid=49703, ppid=46611, state=RUNNABLE:REGION_STATE_TRANSITION_CONFIRM_OPENED, locked=true; TransitRegionStateProcedure table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor.countDownChildren(ProcedureExecutor.java:1837) 2020-03-24 22:42:27,821 | INFO | PEWorker-15 | Finished pid=49703, ppid=46611, state=SUCCESS; TransitRegionStateProcedure table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6, ASSIGN in 15mins, 18.888sec | org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1427) {noformat} RS Log: {noformat} 2020-03-24 22:42:27,230 | INFO | RS_OPEN_REGION-regionserver/RS-IP:RS-Port-34 | Open usertable18,user29616,1585055007688.75a79e978362d6f4ee1a3e27dfc5d4b6. | org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:123) 2020-03-24 22:42:27,241 | INFO | StoreOpener-75a79e978362d6f4ee1a3e27dfc5d4b6-1 | Created cacheConfig: cacheDataOnRead=true, cacheDataOnWrite=false, cacheIndexesOnWrite=false, cacheBloomsOnWrite=false, cacheEvictOnClose=false, cacheDataCompressed=false, prefetchOnOpen=false for family {NAME => 'family', VERSIONS => '1', EVICT_BLOCKS_ON_CLOSE => 'false', NEW_VERSION_BEHAVIOR => 'false', KEEP_DELETED_CELLS => 'FALSE', CACHE_DATA_ON_WRITE => 'false', DATA_BLOCK_ENCODING => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', REPLICATION_SCOPE => '0', BLOOMFILTER => 'ROW', CACHE_INDEX_ON_WRITE => 'false', IN_MEMORY => 'false', CACHE_BLOOMS_ON_WRITE => 'false', PREFETCH_BLOCKS_ON_OPEN => 'false', COMPRESSION => 'NONE', BLOCKCACHE => 'true', BLOCKSIZE => '65536'} with blockCache=LruBlockCache{blockCount=0, currentSize=5.74 MB, freeSize=7.64 GB, maxSize=7.65 GB, heapSize=5.74 MB, minSize=7.27 GB, minFactor=0.95, multiSize=3.63 GB, multiFactor=0.5, singleSize=1.82 GB, singleFactor=0.25} | org.apache.hadoop.hbase.io.hfile.CacheConfig.(CacheConfig.java:174) 2020-03-24 22:42:27,242 | INFO | StoreOpener-75a79e978362d6f4ee1a3e27dfc5d4b6-1 | size [128 MB, 8.00 EB, 8.00 EB); files [6, 10); ratio 1.200000; off-peak ratio 5.000000; throttle point 1610612736; major period 604800000, major jitter 0.500000, min locality to compact 0.000000; tiered compaction: max_age 9223372036854775807, incoming window min 6, compaction policy for tiered window org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy, single output for minor true, compaction window factory org.apache.hadoop.hbase.regionserver.compactions.ExponentialCompactionWindowFactory | org.apache.hadoop.hbase.regionserver.compactions.CompactionConfiguration.(CompactionConfiguration.java:147) 2020-03-24 22:42:27,243 | INFO | StoreOpener-75a79e978362d6f4ee1a3e27dfc5d4b6-1 | Store=family, memstore type=DefaultMemStore, storagePolicy=HOT, verifyBulkLoads=false, parallelPutCountPrintThreshold=50, encoding=NONE, compression=NONE | org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:335) 2020-03-24 22:42:27,252 | INFO | RS_OPEN_REGION-regionserver/RS-IP:RS-Port-34 | Opened 75a79e978362d6f4ee1a3e27dfc5d4b6; next sequenceid=5 | org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1067) 2020-03-24 22:42:27,254 | INFO | RS_OPEN_REGION-regionserver/RS-IP:RS-Port-34 | Post open deploy tasks for usertable18,user29616,1585055007688.75a79e978362d6f4ee1a3e27dfc5d4b6., openProcId=73705, masterSystemTime=1585060947225 | org.apache.hadoop.hbase.regionserver.HRegionServer.postOpenDeployTasks(HRegionServer.java:2379) 2020-03-24 22:42:27,320 | INFO | RS_OPEN_REGION-regionserver/RS-IP:RS-Port-34 | Opened usertable18,user29616,1585055007688.75a79e978362d6f4ee1a3e27dfc5d4b6. | org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:141) {noformat} 6. Evn though region was opened successfully but still the region in RIT, in OPEN state {noformat} 2020-03-24 22:49:05,432 | WARN | ProcExecTimeout | STUCK Region-In-Transition rit=OPEN, location=RS-IP,RS-Port,1585060304365, table=usertable18, region=75a79e978362d6f4ee1a3e27dfc5d4b6 | org.apache.hadoop.hbase.master.assignment.AssignmentManager.handleRegionOverStuckWarningThreshold(AssignmentManager.java:1340) {noformat} This WARN message keep occuring in HM log. HBase version: 2.2.3" BoundedRecoveredHFilesOutputSink should read the table descriptor directly,13281625,Resolved,Major,Fixed,27/Jan/20 01:45,07/Mar/20 11:44,,Read from meta or filesystem? hbck2 assigns command should accept one or more files containing a list of region names,13289622,Resolved,Major,Fixed,04/Mar/20 19:43,17/Jun/20 10:08,hbase-operator-tools-1.0.0,"Currently, *assigns* command accepts a list of region names as parameter. When dealing with a very large number of regions, though, passing all regions encoded name as the command parameters becomes too much overhead for the CLI. We should accept a path to one or more file that contains these encoded regions, one per line. That way, this command tails nicely into an operator's incantation using grep/sed over log files." Add a metric to show the locality of ssd in table.jsp,13293466,Resolved,Major,Fixed,24/Mar/20 07:41,15/Jun/20 14:00,,"If a hdfs block has a replica on local hdd and a replica on remote ssd, then the local one is first priority, so i think it is useful to show the locality of ssd, especially when use the ONE_SSD storagy policy.  " get_slowlog_responses filters with AND/OR operator support,13289878,Resolved,Major,Fixed,05/Mar/20 17:47,30/May/20 08:39,2.3.0,"As of now, get_slowlog_responses support filters for various fields but tries to match either of multiple filters i.e. default operator is ""OR"". We can support user provided ""AND"" operator so that only entries that match all the filters can be returned as result." [Flakey Tests] TestSecureExport.testVisibilityLabels fails with SaslException,13291747,Open,Major,,14/Mar/20 20:59,,,"It fails on one of the three hosts I'm using to run tests. It fails every time. Here is the complaint: {code} java.io.IOException: Failed on local exception: java.io.IOException: javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Bad file descriptor (Write failed))]; Host Details : local host is: ""stack.example.org/X.X.X.X""; destination host is: ""localhost"":61294; at org.apache.hadoop.hbase.coprocessor.TestSecureExport.lambda$testVisibilityLabels$7(TestSecureExport.java:422) at org.apache.hadoop.hbase.coprocessor.TestSecureExport.testVisibilityLabels(TestSecureExport.java:426) {code} (Line numbers are a little off because I've been messing around in code... trying to figure how to get it to pass). I'm going to just disable the failing test in sub-issue until someone has a chance to look at it. This is an old one but its stopping me make progress on test stability on one of my machines and figuring this sort of failure is of low priority for myself at the moment at least." Document maven invocation with JDK11,13292280,Resolved,Major,Fixed,17/Mar/20 21:39,09/Jun/20 22:34,3.0.0-alpha-1,This is not obvious at the moment. Add some docs to ease dev setup. Consider JDK11 in our support matrix,13292073,Resolved,Major,Fixed,16/Mar/20 21:33,08/Jun/20 16:32,,Let's figure out how we present our JDK11 story to eager users and operators. "When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting in frequent gc and eventual failure",13294074,Reopened,Major,,26/Mar/20 03:34,,2.0.1,"When the data directory is set to EC, during the continuous load process, regionserver is found down ,to view the log: regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below the heap occupancy alarm watermark (0.95) regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap occupancy alarm watermark (0.95) [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine (eg GC): pause of approximately 1254ms GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms In particular, GC pauses occurred 283 times in half an hour. The memory analysis found that most of the memory footprint was generated by HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer See HDFS-14308，but after the fix, hbase did not return to normal." Extend HBASE-16209 strategy (Provide an ExponentialBackOffPolicy sleep between failed region open requests) to region close and split requests,13294519,Resolved,Major,Fixed,27/Mar/20 17:47,06/Jun/20 02:42,1.6.0,"In HBASE-16209 we provide an ExponentialBackOffPolicy sleep between failed region open requests. This should be extended to also apply to region close and split requests. Will reduce the likelihood of FAILED_CLOSE transitions in production by being more tolerant of temporary regionserver loading issues, e.g. CallQueueTooBigException." HBase shell list_peers command is displayed incorrectly,13292372,Open,Major,,18/Mar/20 06:48,,,"In 2.X version, I found hbase shell list_peers command displays java object id not the human readable peer messages {code:java} hbase(main):002:0> list_peers PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME STATE REPLICATE_ALL NAMESPACES TABLE_CFS BANDWIDTH SERIAL 0 row(s) Took 0.3336 seconds => # {code}" Update docs re: Hadoop compatibility of 2.3.x release,13283046,Resolved,Major,Not A Problem,03/Feb/20 21:07,02/Jun/20 23:07,,Update the [book|http://hbase.apache.org/book.html#hadoop] regarding our Hadoop compatibility for the 2.3 release lines. """Packaging and Integration"" check fails",13294042,Resolved,Major,Fixed,25/Mar/20 23:29,04/Apr/20 00:02,2.3.0,"Looks like this is running with Hadoop 2.8.5, despite HBASE-23986 {noformat} [2020-03-24T09:14:00.930Z] ++ ls -1 /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz [2020-03-24T09:14:00.930Z] ++ head -n 1 [2020-03-24T09:14:00.930Z] + artifact=/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz [2020-03-24T09:14:00.930Z] + tar --strip-components=1 -xzf /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz -C hadoop-2 [2020-03-24T09:14:06.186Z] + /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh --single-process --working-dir output-integration/hadoop-2 --hbase-client-install hbase-client hbase-install hadoop-2/bin/hadoop hadoop-2/share/hadoop/yarn/test/hadoop-yarn-server-tests-2.8.5-tests.jar hadoop-2/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.8.5-tests.jar hadoop-2/bin/mapred [2020-03-24T17:50:28.859Z] Sending interrupt signal to process [2020-03-24T17:50:30.005Z] Sending interrupt signal to process [2020-03-24T17:50:42.558Z] + echo '(x) {color:red}-1 client integration test{color} [2020-03-24T17:50:42.558Z] --Failed when running client tests on top of Hadoop 2. [see log for details|https://builds.apache.org/job/HBase%20Nightly/job/master/1677//artifact/output-integration/hadoop-2.log]. (note that this means we didn'\''t run on Hadoop 3)' [2020-03-24T17:50:42.558Z] + exit 2 [2020-03-24T17:50:42.866Z] script returned exit code 2 {noformat}" [hbase-thirdparty] Make release 3.2.0,13280898,Resolved,Major,Fixed,22/Jan/20 04:23,28/Jan/20 06:17,2.3.0,"Update the dependencies in hbase-thirdparty. In particular, pb goes from 3.7 to 3.11 with a few perf improvements. Would like to update the hbase-thirdparty to include in the coming hbase-2.3.0." Balancer keeps balancing indefinitely ,13290871,Open,Major,,10/Mar/20 17:16,,2.0.2,"Before raising this issue - am not sure if this got fixed directly or indirectly in other latest versions of hbase. The steps are 1) Create a cluster and create some tables. (assume we have RS 1,2,3, 4 and 5) 2) After the table creation and some ops done, the cluster was restarted. Due to this some regions are in RIT. the RIT in progress was to be assigned to RS 3. 3) After the cluster comes back RS 3 and 4 are stopped. (RS 3 will have newer timestamp) 4) Now the master that comes up sees there are some RIT in place and tries to load the entries to process the procedures again. As part of this the RegionStateStore is populated with the old RS 3 hostname. (older timestamp). This adds to the ServerStateNode creating a RS 3 with old timestamp as one server. 5) Now after the master restarts and all regions assigned, the balancer infinitely tries to balance the region to the RS 3 (old timestamp server) thinking it is part of the cluster. 6)the other problem is the MoveProcedure has the target as RS 3 (with old timestamp) but the AM realizes that it is a down server and move it to the one of the active server. But this is not recorded anywhere. I will continue to check the latest code if this case is valid. " [Flakey Tests] Test TestSplitTransactionOnCluster Again,13282314,Resolved,Major,Fixed,30/Jan/20 06:18,23/May/20 02:51,,Parent fix had the test failures in GCE go from 35% to 4%. Let me see if can clear the remaining fails. Replicate slow/large RPC calls to HDFS,13289868,Resolved,Major,Fixed,05/Mar/20 17:02,20/May/20 10:51,1.7.0,We should provide capability to replicate complete slow and large RPC logs to HDFS or create new system table in addition to Ring Buffer. This way we don't lose any of slow logs and operator can retrieve all the slow/large logs. Replicating logs to HDFS / creating new system table should be configurable. Backport HBASE-8868 to branch-2.2,13295138,Resolved,Major,Fixed,31/Mar/20 02:38,14/Apr/20 22:00,,There's just a trivial conflict in import. The relocated hadoop-thirdparty protobuf breaks HBase asyncwal,13284944,Resolved,Major,Fixed,13/Feb/20 00:33,17/Apr/20 19:10,3.0.0-alpha-1,"Hadoop trunk (3.3.0) shaded protobuf and moved it to hadoop-thirdparty. As the result, hbase asyncwal fails to compile because asyncwal uses the Hadoop's protobuf objects. The following command {code} mvn clean install -Dhadoop.profile=3.0 -Dhadoop.version=3.3.0-SNAPSHOT {code} fails with the following error: {noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure: [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[361,44] cannot access org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.MessageOrBuilder not found [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[362,14] cannot access org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3 [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.GeneratedMessageV3 not found [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[366,16] cannot access org.apache.hadoop.thirdparty.protobuf.ByteString [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.ByteString not found [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[375,12] cannot find symbol [ERROR] symbol: method writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream) [ERROR] location: variable proto of type org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java:[702,81] incompatible types: org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.DataTransferEncryptorMessageProto cannot be converted to com.google.protobuf.MessageLite [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[314,66] incompatible types: org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.BlockOpResponseProto cannot be converted to com.google.protobuf.MessageLite [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[330,81] cannot access org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.ProtocolMessageEnum not found [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[380,10] cannot find symbol [ERROR] symbol: method writeDelimitedTo(org.apache.hbase.thirdparty.io.netty.buffer.ByteBufOutputStream) [ERROR] location: variable proto of type org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.OpWriteBlockProto [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputHelper.java:[422,77] cannot access org.apache.hadoop.thirdparty.protobuf.Descriptors [ERROR] class file for org.apache.hadoop.thirdparty.protobuf.Descriptors not found [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java:[323,64] incompatible types: org.apache.hadoop.hdfs.protocol.proto.DataTransferProtos.PipelineAckProto cannot be converted to com.google.protobuf.MessageLite [ERROR] /Users/weichiu/sandbox/hbase/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/SyncReplicationWALProvider.java:[209,68] invalid method reference [ERROR] non-static method get() cannot be referenced from a static context {noformat}" Optionally reject multi() requests with very high no of rows,13292895,Resolved,Major,Fixed,20/Mar/20 10:58,25/Apr/20 12:07,,"As part of multi() request, RegionServer might receive requests with higher rows than row size threshold defined by hbase.rpc.rows.warning.threshold, and we provide warning log. To improve CPU consumption, we should introduce a config that would let RegionServer reject such requests other than providing warning log. This is an attempt to not let any client overburden CPU computation available to RegionServers." `hbase.hstore.flusher.count` setting to 0 breaks HMaster,13279996,Resolved,Major,Fixed,16/Jan/20 22:43,15/May/20 01:40,,"Summary  The configuration parameter `hbase.hstore.flusher.count` allows `0` (which turns out to be a bad value after I understand the source code). When we set `hbase.hstore.flusher.count` to 0, HMaster will fail in 200,000 ms without any error message, but ``` java.lang.RuntimeException: Master not initialized after 200000ms ```   There’s no messages pinpointing `hbase.hstore.flusher.count` being the root cause.   0 means `MemStoreFlusher` is not alive. During the initialization time of HMaster, `isHealthy()` will be called and it will try to check if `MemStoreFlusher` is alive or not.  However, since we set `hbase.hstore.flusher.count` to 0, there will be no flusher created at the first place, which cause`isHealthy()` to return false. As a consequence, HRegionServer does not enter its main loop.   *How To Reproduce*    The version of HBase: 2.2.3   # Set the value of configuration parameter `hbase.hstore.flusher.count` to `0` in “conf/hbase-site.xml” # Start hbase by running “bin/start-hbase.sh” # Wait for 3-4 minutes # Open the log file “logs/hbase-- master -.log”" Wrong combination of hlog reader and writer could crash regionserver,13290911,Patch Available,Major,,10/Mar/20 20:47,,,"*Problem* I found out that there two configuration parameters: `hbase.regionserver.hlog.reader.impl` and `hbase.regionserver.hlog.writer.impl` which should be used as a pair. There are two options for the reader: `ProtobufLogReader` and `SecureProtobufLogReader`. And four options for the writer: `ProtobufLogWriter`, `SecureProtobufLogWriter`, `AsyncProtobufLogWriter` and `SecureAsyncProtobufLogWriter`. Using the wrong combination of the reader and the writer will throw an exception. For example, if setting the writer to SecureProtobufLogWriter and setting the reader to ProtobufLogReader(default value), an exception will be thrown: {code:java} java.io.IOException: Got unknown writer class: SecureProtobufLogWriter at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.initInternal(ProtobufLogReader.java:224) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.initReader(ProtobufLogReader.java:173) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.init(ReaderBase.java:65) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.init(ProtobufLogReader.java:168) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:321) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:303) at org.apache.hadoop.hbase.wal.WALFactory.createReader(WALFactory.java:291) at org.apache.hadoop.hbase.wal.LogRecoveredEditsOutputSink.deleteOneWithFewerEntries(LogRecoveredEditsOutputSink.java:109) at org.apache.hadoop.hbase.wal.LogRecoveredEditsOutputSink.closeWriter(LogRecoveredEditsOutputSink.java:240) at org.apache.hadoop.hbase.wal.LogRecoveredEditsOutputSink$2.call(LogRecoveredEditsOutputSink.java:196) at org.apache.hadoop.hbase.wal.LogRecoveredEditsOutputSink$2.call(LogRecoveredEditsOutputSink.java:192) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748){code} The current description of these two parameters (in the `hbase-default.xml`) doesn’t tell the users anything about which combination is right or not.   *Improvement* We can add some more information in the description of these two parameters in `hbase-default.xml` to tell the users about the correct combinations. I upload a patch for improving the description." Harden small and medium tests for lots of parallel runs with re-used jvms.,13285491,Resolved,Major,Won't Fix,15/Feb/20 07:38,14/May/20 23:20,, [flakey test] TestRegionReplicaFailover.testSecondaryRegionKill fails.,13295059,Resolved,Major,Fixed,30/Mar/20 17:44,14/May/20 04:12,2.3.0,"Run into the following error locally: {code:java} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover ------------------------------------------------------------------------------- Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 97.391 s <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.testSecondaryRegionKill  Time elapsed: 28.682 s  <<< FAILURE! java.lang.AssertionError: Failed verification of row :0         at org.junit.Assert.fail(Assert.java:89)         at org.junit.Assert.assertTrue(Assert.java:42)         at org.apache.hadoop.hbase.HBaseTestingUtility.verifyNumericRows(HBaseTestingUtility.java:2407)         at org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.testSecondaryRegionKill(TestRegionReplicaFailover.java:240)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)         at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)         at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)         at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)         at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)         at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)         at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)         at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)         at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.lang.Thread.run(Thread.java:748) {code}" Master async shutdown rpc call may not complete,13294544,Open,Major,,27/Mar/20 19:22,,,"Debugging the parent issue and discussion over in the adjacent test fix issue HBASE-24052 and in its PR exposes a problem calling shutdown asynchronously. The shutdown runs inline with the rpc call which should change (as suggested by [~bharathv]). Quoting from a Bharath comment in the the HBASE-24052 PR: bq. I think internally it is masking the problem of ""shutdown()"" implementation being synchronous on the server side. Ideally, I'd think it should be async on the server side too, meaning the rpc call just sets a flag (startShuttingDown = true) which is read by multiple running threads and they begin the tear down rather than doing it in the context of the rpc thread. We already do this partially but the main driver of master shutdown still runs in the rpc context." Exclude H2 from the build workers pool,13295358,Resolved,Major,Won't Fix,31/Mar/20 21:10,13/May/20 20:48,,"Tracking INFRA-20025, H2 keeps coming up as impacted. Let's exclude it from our build workers while Infra investigates the hardware." Track sensitive resources to ensure they are closed and assist devs in finding leaks.,13288589,Resolved,Major,Information Provided,01/Mar/20 20:27,11/May/20 20:23,,"Closing some objects is quite critical. Issues with leaks can be quite slippery and nasty and growy. Maintaining close integrity is an embarrassing sport for humans. In the past, those 3 thoughts led me to start tracking objects in tests to alert of leaks. Even with an alert though, the job of tracking down all of the leaks just based on what leaked was beyond my skill. If it's beyond even one devs skill that is committing, that tends to end up trouble. So I added the stack trace for the origin of the object. Things can still get a bit tricky to track down in some cases, but now I had the start of a real solution to all of the whack-a-mole games I spent too much time playing. " Enable all tests to be run in parallel on reused JVMs.,13283291,Resolved,Major,Information Provided,04/Feb/20 17:14,11/May/20 20:13,,"I'd like to be able to run HBase tests in under 30-40 minutes on good parallel hardware. It will require some small changes / fixes for that wish to come true." [Flakey Test] TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer,13283812,Resolved,Major,Fixed,07/Feb/20 01:21,14/Feb/20 16:41,2.3.0,Reproduces locally from time to time. Not much to go on here. Looks like the test is trying to do some fancy HBase cluster initialization order on top of a mini-cluster. Failure seems related to trying to start the HBase master before HDFS is fully initialized. [flakey test] client.TestAsyncRegionAdminApi messed up compaction state.,13294578,Resolved,Major,Fixed,28/Mar/20 00:02,02/Apr/20 15:20,2.3.0,"{code:java} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi ------------------------------------------------------------------------------- Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 268.838 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[0]  Time elapsed: 50.471 s  <<< FAILURE! java.lang.AssertionError: expected: but was:         at org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:415)         at org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:364) Another case found during local test: ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi ------------------------------------------------------------------------------- Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 224.399 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[1]  Time elapsed: 30.861 s  <<< FAILURE! java.lang.AssertionError         at org.junit.Assert.fail(Assert.java:87)         at org.junit.Assert.assertTrue(Assert.java:42)         at org.junit.Assert.assertTrue(Assert.java:53)         at org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:444)         at org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:363)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)         at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)         at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)         at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)         at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)         at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)         at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)         at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)         at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)         at org.junit.runners.ParentRunner.run(ParentRunner.java:413)         at org.junit.runners.Suite.runChild(Suite.java:128)         at org.junit.runners.Suite.runChild(Suite.java:27)         at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)         at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)         at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)         at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)         at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) {code}" "Add hbck2 command to ""completebulkload"" a batch of orphaned regions",13289646,Open,Major,,04/Mar/20 22:09,,,"Cleaning up a cluster with a bunch of messed up region assignments and state, hbck2 gets us to the point where meta and hdfs agree on split points, but some regions are left orphaned in hdfs. The current solution is to manually loop through the list of orphans and invoke {{completebulkload}} one-by-one. Let's add this as an action that hbck2 and do on the operator's behalf." [hbase-thirdparty] Add nexus-staging-maven-plugin to apache-release profile,13281844,Resolved,Major,Fixed,28/Jan/20 05:34,24/Apr/20 18:11,,"Parent issue added use of nexus-staging-maven-plugin manipulating maven.apache.org repos. Add plugin reference over in hbase-thirdparty so when we make RCs using create-release from hbase core, the repo manipulation 'works' (failed when I made the 2.3.0RC0." Get `-PrunSmallTests` passing on JDK11,13284642,Resolved,Major,Fixed,11/Feb/20 18:37,21/Apr/20 23:02,,"Start with the small tests, shaking out issues identified by the harness. So far it seems like {{-Dhadoop.profile=3.0}} and {{-Dhadoop-three.version=3.3.0-SNAPSHOT}} maybe be required." Support metrics for region traffic,13280359,Patch Available,Major,,19/Jan/20 07:10,,3.0.0-alpha-1,"I think we need some metrics to measure the amount of traffic being read and written to each region, which can help us more clearly analyze how much network resources are consumed by each region. putBytes/getBytes/scanBytes/deleteBytes/incrementBytes/appendBytes/bulkLoadBytes " Add documentation about the CECPs changes,13283351,Resolved,Major,Fixed,05/Feb/20 01:41,18/Apr/20 01:36,, Add JDK11 compilation and unit test support to Jira attached patch precommit,13286305,Resolved,Major,Won't Fix,19/Feb/20 19:01,17/Apr/20 21:11,,We already test against multiple JDK versions in a handful of places. Let's get JDK11 added to the mix. Applies to Jira attached-patch pre-commit. Nightlies reporting OutOfMemoryError: unable to create new native thread,13294548,Resolved,Major,Fixed,27/Mar/20 19:36,17/Apr/20 20:29,,"Seeing this kind of thing in nightly... {code} java.lang.RuntimeException: java.lang.OutOfMemoryError: unable to create new native thread at org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83) Caused by: java.lang.OutOfMemoryError: unable to create new native thread at org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper.beforeClass(TestMultithreadedTableMapper.java:83) {code} Chatting w/ Nick and Huaxiang, doing the math, we are likely oversubscribing our docker container. It is set to 20G (The hosts are 48G). Fork count is 0.5C on a 16 CPU machine which is 8 *2.8G our current forked jvm size. Add the maven 4G and we could be over the top. Play w/ downing the fork size (in earlier study we didn't seem to need this much RAM when running a fat long test). Let me also take th ms off the mvn allocation to see if that helps." Document new RegionProcedureStore operation and migration,13279688,Resolved,Major,Fixed,15/Jan/20 22:34,16/Apr/20 17:47,2.3.0,"Add a few notes to the refguide on the new RegionProcedureStore, how it works (A 'Region' but buried in the Master with dedicated flushing/compacting threads and archivers for WAL and hfile), how it differs from WALPS, and note it auto-migrates and there should be new issue moving on to the new store. Mention the configuration. Mention it is on WALFS even though it is a 'Region', etc." HBase Thrift bindings generating broken code,13285786,Open,Major,,17/Feb/20 13:46,,2.2.3,"Generated perl thrift bindings are broken: {code:java} $ thrift --gen perl src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift $ cd gen-perl $ perl -I . -Tc Hbase/Hbase.pm Subroutine new redefined at /Library/Perl/5.18/Thrift/Exception.pm line 38. Bareword ""Thrift::TMessageType::CALL"" not allowed while ""strict subs"" in use at Hbase/Hbase.pm line 9897. BEGIN not safe after errors--compilation aborted at Hbase/Hbase.pm line 12163. {code}   Tested from build from source of both HBase 2.1.2 and HBase 2.2.3 using both Thrift 0.12 and 0.13.  " Make MasterRegistry the default registry impl,13277604,Resolved,Major,Fixed,06/Jan/20 01:55,27/Jan/20 21:36,3.0.0-alpha-1,"Now that we are close to getting the registry implementation patch in, the idea here is to make it the default implementation in 3.0.0 and this means - No known bugs with the implementation - No known performance issues - Entire nightly test suite is green (and without flakes). " Up the default fork count to make builds complete faster; make count relative to CPU count,13282502,Resolved,Major,Fixed,31/Jan/20 00:39,13/Apr/20 23:29,,"Tests take a long time. Our fork count running all tests are conservative -- 1 (small) for first part and 5 for second part (medium and large). Rather than hardcoding we should set the fork count to be relative to machine size. Suggestion here is 0.75C where C is CPU count. This ups the CPU use on my box. Looking up at jenkins, it seems like the boxes are 24 cores... at least going by my random survey. The load reported on a few seems low though this not representative (looking at machine/uptime). More parallelism willl probably mean more test failure. Let me take a look see." ConcurrentModificationException occurred in ReplicationSourceManager while refreshing the peer,13294701,Resolved,Major,Fixed,28/Mar/20 10:14,09/Apr/20 23:44,,"Peer update failed with ConcurrentModificationException, {noformat} 2020-03-28 11:36:49,770 | WARN | RpcServer.default.FPBQ.Fifo.handler=49,queue=4,port=hm_port | Refresh peer peer1 for UPDATE_CONFIG on rs_host,rs_port,1585228936395 failed | org.apache.hadoop.hbase.master.replication.RefreshPeerProcedure.complete(RefreshPeerProcedure.java:114) java.util.ConcurrentModificationException via szvphispra08478,21302,1585228936395:java.util.ConcurrentModificationException: at org.apache.hadoop.hbase.procedure2.RemoteProcedureException.fromProto(RemoteProcedureException.java:124) at org.apache.hadoop.hbase.master.MasterRpcServices.lambda$reportProcedureDone$4(MasterRpcServices.java:2576) at java.util.ArrayList.forEach(ArrayList.java:1257) at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1082) at org.apache.hadoop.hbase.master.MasterRpcServices.reportProcedureDone(MasterRpcServices.java:2571) at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:15341) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) Caused by: java.util.ConcurrentModificationException: at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:909) at java.util.ArrayList$Itr.next(ArrayList.java:859) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.refreshSources(ReplicationSourceManager.java:399) at org.apache.hadoop.hbase.replication.regionserver.PeerProcedureHandlerImpl.updatePeerConfig(PeerProcedureHandlerImpl.java:123) at org.apache.hadoop.hbase.replication.regionserver.RefreshPeerCallable.call(RefreshPeerCallable.java:68) at org.apache.hadoop.hbase.replication.regionserver.RefreshPeerCallable.call(RefreshPeerCallable.java:34) at org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:47) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat}" Update test-patch.sh path for git-checkout use-cases to account for the new module layout in Yetus,13286298,Open,Major,,19/Feb/20 18:29,,,"It was noticed over on HBASE-23779 that we support running Yetus pre-commit/test-patch.sh directly out of a git checkout/source tarball. However, not all usages of this form of Yetus have been upgraded to the new maven layout. It appears we make this assumption in: * The Jenkins job configuration on [PreCommit-HBASE-Build|https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/configure] * {{dev-support/Jenkinsfile_GitHub}} * {{dev-support/hbase_nightly_yetus.sh}}" Run maven with more than default single thread (--threads=0.5C),13284157,Resolved,Major,Later,09/Feb/20 17:41,09/Apr/20 04:27,,See tail of parent task where we made commits to hbase-personality trying to make maven run more furiously on nightly builds by upping the maven thread count (the --threads flag ... see https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3). The effort was abandoned because it unsettled the build. This issue separates messing with the maven threads flag from the broader topic the parent covers. [Flakey Tests] teardown fails because JmxCacheBuster wants to read ClusterId from closed fs,13294854,Resolved,Major,Fixed,29/Mar/20 18:16,01/Apr/20 17:38,,"I've seen this a few times. There may be an issue already but couldn't turn it up. In teardown, we fail because of below access: {code} 2020-03-28 22:01:47,484 WARN [HBase-Metrics2-1] master.CachedClusterId(105): Error fetching cluster ID java.io.IOException: Filesystem closed at org.apache.hadoop.hdfs.DFSClient.checkOpen(DFSClient.java:468) at org.apache.hadoop.hdfs.DFSClient.getFileInfo(DFSClient.java:1650) at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1523) at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1520) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1520) at org.apache.hadoop.fs.FileSystem.exists(FileSystem.java:1627) at org.apache.hadoop.hbase.util.FSUtils.getClusterId(FSUtils.java:578) at org.apache.hadoop.hbase.master.CachedClusterId.attemptFetch(CachedClusterId.java:103) at org.apache.hadoop.hbase.master.CachedClusterId.getFromCacheOrFetch(CachedClusterId.java:140) at org.apache.hadoop.hbase.master.HMaster.getClusterId(HMaster.java:3839) at org.apache.hadoop.hbase.master.MetricsMasterWrapperImpl.getClusterId(MetricsMasterWrapperImpl.java:68) at org.apache.hadoop.hbase.master.MetricsMasterSourceImpl.getMetrics(MetricsMasterSourceImpl.java:112) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:200) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:183) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:156) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:333) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:319) at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522) at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:66) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:223) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:101) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:268) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$1.postStart(MetricsSystemImpl.java:239) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl$3.invoke(MetricsSystemImpl.java:320) at com.sun.proxy.$Proxy13.postStart(Unknown Source) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:193) at org.apache.hadoop.metrics2.impl.JmxCacheBuster$JmxCacheBusterRunnable.run(JmxCacheBuster.java:109) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {code} Its hadoop metrics system. Its still up trying to work." Add ut for root dir and wal root dir are different,13293439,Resolved,Major,Fixed,24/Mar/20 03:47,25/Mar/20 03:29,, Add ut for loading the corrupt recovered hfiles,13293149,Resolved,Major,Fixed,22/Mar/20 08:43,22/Mar/20 15:06,, shadedjars check does not propagate --hadoop-profile,13292263,Resolved,Major,Fixed,17/Mar/20 19:30,24/Mar/20 16:36,2.3.0,"After HBASE-23829, we see the {{shadedjars}} check fail on JDK11 stages. From the log {noformat} Tue Mar 17 00:14:24 UTC 2020 cd /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1296/yetus-jdk11-hadoop3-check/src /opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1296/yetus-m2/hbase-branch-2-patch-1 clean verify -fae --batch-mode -pl hbase-shaded/hbase-shaded-check-invariants -am -Dtest=NoUnitTests -DHBasePatchProcess -Prelease -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true ... [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (hadoop3-profile-required) @ hbase --- [INFO] Adding ignore: module-info [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed with message: HBase with JDK11 requires Hadoop3. Activate the profile with `-Dhadoop.profile=3.0`. {noformat} " [Flakey Tests] TestSlowLogRecorder.testOnlieSlowLogConsumption:178->confirmPayloadParams:97 expected: but was:,13291425,Resolved,Major,Fixed,12/Mar/20 21:07,19/Mar/20 10:17,2.3.0,"I see this occasionally on a linux vm. [~vjasani] .. you might have an idea why this is going on (this is your test I believe and a recent addition). If you have stuff I can try, shout. Here is fail: {code} org.junit.ComparisonFailure: expected: but was: at org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.confirmPayloadParams(TestSlowLogRecorder.java:97) at org.apache.hadoop.hbase.regionserver.slowlog.TestSlowLogRecorder.testOnlieSlowLogConsumption(TestSlowLogRecorder.java:178) {code} Here is log: {code} 2020-03-12 17:02:06,266 INFO [Time-limited test] hbase.ResourceChecker(179): after: regionserver.slowlog.TestSlowLogRecorder#testOnlineSlowLogWithDisableConfig Thread=7 (was 7), OpenFileDescriptor=226 (was 226), MaxFileDescriptor=131072 (was 131072), SystemLoadAverage=353 (was 353), ProcessCount=195 (was 195), AvailableMemoryMB=7037 (was 7027) - AvailableMemoryMB LEAK? - 2020-03-12 17:02:06,281 INFO [Time-limited test] hbase.ResourceChecker(151): before: regionserver.slowlog.TestSlowLogRecorder#testOnlieSlowLogConsumption Thread=7, OpenFileDescriptor=226, MaxFileDescriptor=131072, SystemLoadAverage=353, ProcessCount=195, AvailableMemoryMB=7036 2020-03-12 17:02:06,317 DEBUG [Time-limited test] slowlog.TestSlowLogRecorder(111): Initially ringbuffer of Slow Log records is empty 2020-03-12 17:02:06,326 INFO [Time-limited test] hbase.Waiter(183): Waiting up to [3,000] milli-secs(wait.for.ratio=[1]) 2020-03-12 17:02:06,528 INFO [Time-limited test] hbase.Waiter(183): Waiting up to [3,000] milli-secs(wait.for.ratio=[1]) 2020-03-12 17:02:06,630 INFO [Time-limited test] hbase.Waiter(183): Waiting up to [3,000] milli-secs(wait.for.ratio=[1]) 2020-03-12 17:02:06,732 INFO [Time-limited test] hbase.Waiter(183): Waiting up to [3,000] milli-secs(wait.for.ratio=[1]) {code}" Retrieve online large RPC logs,13289866,Resolved,Major,Fixed,05/Mar/20 16:57,01/Apr/20 14:48,2.3.0,"Similar to online slow RPC response logs, we should also provide get and clear of large RPC logs which should be stored in the online RingBuffer. Many of slow response logs would also turn out to be large response logs for RegionServers." Thrift support for get and clear slow_log APIs,13289864,Resolved,Major,Fixed,05/Mar/20 16:51,23/Mar/20 18:18,2.3.0,Provide thrift support for get_slowlog_responses() and clear_slowlog_responses() Admin APIs. Fix a couple more test failures from nightly run,13282056,Resolved,Major,Fixed,28/Jan/20 20:59,03/Feb/20 18:18,1.6.0,"After merging the patches HBASE-23731 and HBASE-23647, nightly run found the following issues. TestFromClientSideWithCoprocessor - This was a bug in the test itself, PR runs missed it somehow. TestCustomSaslAuthenticationProvider - This was written pre master registry. Has to be updated. It was never run as a part of the test suite. TestSnapshotScannerHDFSAclController: Cluster restart did not reset the cached connection state   [~ndimiduk] FYI because this is a blocker for 2.3.0 too, I tagged it accordingly. Will submit a PR shortly." TestFromClientSide flakey after junit upgrade,13281317,Resolved,Major,Fixed,24/Jan/20 01:18,27/Jan/20 21:51,HBASE-18095,"The cluster shutdown and restart between parameterized runs causes a thread leak with stacks like follows. {noformat} 2020-01-22 09:52:10,900 WARN [LeaseRenewer:hostname@localhost:62252] impl.LeaseRenewer(438): Failed to renew lease for [DFSClient_NONMAPREDUCE_-1123200667_19] for 73 seconds. Will retry shortly ... java.net.ConnectException: Call From xxxxx/xxxx to localhost:62252 failed on connection exception: java.net.ConnectException: Connection refused; For more details see: http://wiki.apache.org/hadoop/ConnectionRefused at sun.reflect.GeneratedConstructorAccessor64.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:801) at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:732) at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1493) at org.apache.hadoop.ipc.Client.call(Client.java:1435) at org.apache.hadoop.ipc.Client.call(Client.java:1345) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:227) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:116) at com.sun.proxy.$Proxy29.renewLease(Unknown Source) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.renewLease(ClientNamenodeProtocolTranslatorPB.java:613) at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:409) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:346) at com.sun.proxy.$Proxy30.renewLease(Unknown Source) at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:372) at com.sun.proxy.$Proxy33.renewLease(Unknown Source) at sun.reflect.GeneratedMethodAccessor34.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:372) at com.sun.proxy.$Proxy33.renewLease(Unknown Source) at org.apache.hadoop.hdfs.DFSClient.renewLease(DFSClient.java:560) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer.renew(LeaseRenewer.java:395) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer.run(LeaseRenewer.java:415) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer.access$600(LeaseRenewer.java:76) at org.apache.hadoop.hdfs.client.impl.LeaseRenewer$1.run(LeaseRenewer.java:307) at java.lang.Thread.run(Thread.java:748) {noformat} While the issue existed even before, it looks like junit 4.12 somehow was masking it. Upgrade to 4.13 made it worse.  The host:port refers to already shutdown hdfs cluster, so ideally this thread shouldn't be there in the first place. A culprit could be leaking filesystem / dfsclient objects." Fix default master addr hostname in master registry,13283616,Resolved,Major,Fixed,06/Feb/20 02:14,10/Feb/20 22:39,1.6.0,"Currently, master RPC server (*not* info server) always binds to the address endpoint to which the default hostname of the server resolves to. However, master registry picks the default end point to connect to as ""localhost:16000"" when ""hbase.masters"" are not configured. This is leading to a mismatch because the server may not be listening on the loopback address. This is a problem only in the scripts (single proc/pseudo distributed modes) because these are the cases in which ""hbase.masters"" is not populated by default. The fix is to pick the service endpoint the same way the RPC server does it." Make AsyncFSWAL can run on EC cluster,13294166,Resolved,Major,Fixed,26/Mar/20 10:24,07/Apr/20 15:56,,We need to enable replicate when creating the file. [Flakeys] TestRSGroupsBasics#testClearNotProcessedDeadServer fails most of the time,13281312,Resolved,Major,Fixed,24/Jan/20 00:40,24/Jan/20 00:46,,"Asserts a dead server but the dead server can be cleaned up because the ServerCrashProcedure completes before the assert can run. Fails for me locally nearly every time I run it. In flakies list, it shows as failing 55% of the time: https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2/lastSuccessfulBuild/artifact/dashboard.html" [Flakey Tests] TestClusterRestartFailover & TestClusterRestartFailoverSplitWithoutZk,13281482,Resolved,Major,Fixed,24/Jan/20 20:25,25/Jan/20 02:32,, [Flakey Tests] Caused by: org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: hflush and hsync,13281792,Resolved,Major,Fixed,27/Jan/20 20:01,28/Jan/20 17:45,,"Tests that use the new RegionProcedureStoreTestBase utility fail in branch-2 nightlies complaining... {code} Error Message cannot get log writer Stacktrace java.io.IOException: cannot get log writer Caused by: org.apache.hadoop.hbase.util.CommonFSUtils$StreamLacksCapabilityException: hflush and hsync {code} They are using local fs which doesn't have support for above. Only shows when you run the tests with hadoop3 profile. Let me do for these tests what was done over in HBASE-19289 It has been going on for a while now, probably since the move to region procedure store (the old wal procedure store had turned off the checks for sync/hflush). {code} health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestHFileProcedurePrettyPrinter.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStore.testLoad health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStore.testCleanup health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreCompaction.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreMigration.testMigrateWithUnsupportedProcedures health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreMigration.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestRegionProcedureStoreWALCleaner.test health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.procedure2.store.region.TestWALProcedurePrettyPrinter.test {code}" Move core to hbase-thirdparty 3.2.0,13281850,Resolved,Major,Fixed,28/Jan/20 06:02,28/Jan/20 06:10,,Move core to use just-released 3.2.0 hbase-thirdparty. The change has already been through build courtesy of https://github.com/apache/hbase/pull/1086 Flaky tests due to ZK client name resolution delays,13282243,Resolved,Major,Fixed,29/Jan/20 17:52,02/Feb/20 00:32,3.0.0-alpha-1,"[~ndimiduk] and I ran into this issue (separately) and we noticed that there are some performance issues with name resolution in the Zookeeper client. Since we use ZK heavily in the unit tests, this often manifests as the following issues 1. Test time outs starting the mini cluster (Master failed to start....) 2. InterruptedException (because the tests timeout) 3. Flaky tests because a subset of the cluster fails to start for whatever reason (replication tests especially because they spawn multiple clusters). 4. ConnectionLoss to znode /hbase/xyzz.. JVM pause? I have strong feeling that this is a possible cause for many of our flaky tests in Jenkins. Luckily, it looks like the following workaround to switch to an IP address instead of hostname makes it much quicker. There are some related discussions in the ZK community (ZOOKEEPER-1666 and related jiras). {code:java} --- a/hbase-common/src/main/resources/hbase-default.xml +++ b/hbase-common/src/main/resources/hbase-default.xml @@ -72,7 +72,7 @@ possible configurations would overwhelm and obscure the important. hbase.zookeeper.quorum - localhost + 127.0.0.1 Comma separated list of servers in the ZooKeeper ensemble (This config. should have been named hbase.zookeeper.ensemble). For example, ""host1.mydomain.com,host2.mydomain.com,host3.mydomain.com"". {code} Until we figure out the actual root cause and a dependency upgrade (if needed), we should consider making this hostname to IP switch for more stable builds." [Flakey Tests] TestRegionReplicasWithRestartScenarios#testWhenRestart,13282312,Resolved,Major,Fixed,30/Jan/20 06:09,31/Jan/20 16:50,,"Fails about 35% of the time in the GCE build. Let me attach a picture from current flakies dashboard for branch-2. The test starts a cluster of three RS w/ 3 region replicas. It then stops a server, starts a new one, and then expects that the remaining three nodes do not have instances where two region replicas have landed on a single server. It fails sporadically (reproducible locally) because when the SCP runs its assign, sometimes timing has it so Master knows of two servers only. Making the new start before the old one is stopped (instead of other way around) seems to fix the test -- there'll be three servers up when SCP runs." Edit of test classifications,13282504,Resolved,Major,Fixed,31/Jan/20 00:47,03/Feb/20 18:35,,"Our test classifications have drifted. You can see for yourself running each of the small/medium and large test suites. See test complete times. See how even some large tests should be small and vice versa. The more small tests we can run inside the single JVM, the faster we'll get through the build. Tests that are Medium start their own JVM for each test. Tests that are Medium but only last a second or two are expensive and should be aggregated with other single, short tests to amortize the JVM startup. Anyways, let me edit the test categories and try and clean them up some." [Flakey Test] TestMasterNotCarryTable.testMasterMemStoreLAB,13283078,Resolved,Major,Fixed,04/Feb/20 01:30,04/Feb/20 01:36,,"Interesting one. Fails only if Master gets chance to become active -- which doesn't happen when all is easy-going. If struggling under load, it can become active and then test asserting NO ChunkCreator instance in Master fails because we want ChunkCreator now since ProcedureRegionStore was added: i.e. "" // always initialize the MemStoreLAB as we use a region to store procedure now."" Here is error I've seen {code} [ERROR] Failures: [ERROR] TestMasterNotCarryTable.testMasterMemStoreLAB:94 expected null, but was: {code}" [Flakey Tests] ERROR [Time-limited test] balancer.HeterogeneousRegionCountCostFunction(199): cannot read rules file located at ' /tmp/hbase-balancer.rules ',13283150,Resolved,Major,Fixed,04/Feb/20 05:49,05/Feb/20 00:42,,"We can't find the balancer rules we just read in the HeterogeneousRegionCountCostFunction test in high load conditions {code} 2020-02-03 20:51:00,774 ERROR [Time-limited test] balancer.HeterogeneousRegionCountCostFunction(199): cannot read rules file located at ' /tmp/hbase-balancer.rules ':File /tmp/hbase-balancer.rules does not exist 2020-02-03 20:51:00,774 WARN [Time-limited test] balancer.HeterogeneousRegionCountCostFunction(155): cannot load rules file, keeping latest rules file which has 1 rules {code} Test then goes on to fail with: {code} org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerHeterogeneousCost.testOneGroup Time elapsed: 15.223 s <<< FAILURE! junit.framework.AssertionFailedError: Host rs0 should be below 0.0% at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerHeterogeneousCost.testWithCluster(TestStochasticLoadBalancerHeterogeneousCost.java:209) at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerHeterogeneousCost.testHeterogeneousWithCluster(TestStochasticLoadBalancerHeterogeneousCost.java:160) at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerHeterogeneousCost.testOneGroup(TestStochasticLoadBalancerHeterogeneousCost.java:102) {code} Instead, have tests write rules to local test dir." [Flakey Test] TestRaceBetweenSCPAndDTP,13283631,Resolved,Major,Fixed,06/Feb/20 06:00,07/Feb/20 21:13,,Waits a second and then goes to grab an SCP that may not have started yet. [Flakey Test] TestReplicator#testReplicatorWithErrors: AssertionError: We did not replicate enough rows expected:<10> but was:<7>,13284027,Resolved,Major,Fixed,07/Feb/20 22:26,10/Feb/20 17:46,,"I've seen this fail. Here is the latest: {code} [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 21.044 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.regionserver.TestReplicator [ERROR] org.apache.hadoop.hbase.replication.regionserver.TestReplicator.testReplicatorWithErrors Time elapsed: 7.139 s <<< FAILURE! java.lang.AssertionError: We did not replicate enough rows expected:<10> but was:<7> at org.apache.hadoop.hbase.replication.regionserver.TestReplicator.testReplicatorWithErrors(TestReplicator.java:158) {code} In test logs there are a few (in groups of three) of these: {code} 4247 2020-02-07 13:50:29,070 WARN [RS_REFRESH_PEER-regionserver/localhost:0-1.replicationSource,testReplicatorWithErrors.replicationSource.shipperlocalhost%2C49531%2C1581112194639,testReplicatorWithErrors] regionserver. ReplicationSourceShipper(223): org.apache.hadoop.hbase.replication.regionserver.TestReplicator$FailureInjectingReplicationEndpointForTest threw unknown exception: 4248 java.lang.ClassCastException: org.apache.hbase.thirdparty.com.google.protobuf.ServiceException cannot be cast to java.io.IOException 4249 at org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.parallelReplicate(HBaseInterClusterReplicationEndpoint.java:361) 4250 at org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.replicate(HBaseInterClusterReplicationEndpoint.java:404) 4251 at org.apache.hadoop.hbase.replication.regionserver.TestReplicator$ReplicationEndpointForTest.replicate(TestReplicator.java:228) 4252 at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.shipEdits(ReplicationSourceShipper.java:188) 4253 at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.run(ReplicationSourceShipper.java:118) {code} Let me fix this and see if it makes TestReplicator stable again." [Flakey Test] AbstractTestAsyncTableRegionReplicasRead family of tests fails with no breadcrumbs on why,13284087,Resolved,Major,Fixed,08/Feb/20 17:44,10/Feb/20 17:02,,"Running locally w/ upped forkcount and maven threading > 1, the set of tests that are derived from AbstractTestAsyncTableRegionReplicasRead fail near each time often the only ones failed (Get and Scan tests). They don't give clues why died. The xml has no info in it and no -output.txt is dropped. The .txt just says failed startup. I've tried giving the forked jvms more RAM, messed w/ file counts.... Removing all of the custom setup seems to be a breakthrough. Let me put up a patch." TestSnapshotScannerHDFSAclController is flakey,13284240,Resolved,Major,Fixed,10/Feb/20 10:04,10/Feb/20 17:43,,See  [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2/lastSuccessfulBuild/artifact/dashboard.html]  Reconcile Hadoop version,13285822,Resolved,Major,Fixed,17/Feb/20 17:02,18/Mar/20 17:01,3.0.0-alpha-1,"I followed the HBase book http://hbase.apache.org/book.html#maven.build.hadoop and wanted to build HBase (master) on top of Hadoop 3.2/3.3 but tests failed right away. Build: {code} mvn clean install -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.1 -DskipTests {code} Test: {code} mvn test -Dtest=TestHelloHBase -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.1 {code} {noformat} [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.296 s <<< FAILURE! - in org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase [ERROR] org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase Time elapsed: 1.284 s <<< ERROR! java.lang.NoClassDefFoundError: org/apache/hadoop/hdfs/protocol/HdfsConstants$StoragePolicySatisfierMode at org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54) Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hdfs.protocol.HdfsConstants$StoragePolicySatisfierMode at org.apache.hbase.archetypes.exemplars.shaded_client.TestHelloHBase.beforeClass(TestHelloHBase.java:54) {noformat} Adding mvn -X parameter, I was able to tell that it was because the hbase-server module includes hadoop-distcp and hadoop-dfs-client 3.1.2 (the default Hadoop 3 dependency version) while it uses version 3.2.1 of other hadoop jars . The classpath conflict (the storage policy satisfier is a new feature in Hadoop 3.2) failed the test. This is reproducible on any Hadoop version 3.2 and above. It looks to me the version of hadoop-distcp and hadoop-hdfs-client should be specified at the top level pom (they are specified in hbase-server/pom.xml)." [Flakey Test] TestReplicationEndpointWithMultipleWAL#testInterClusterReplication improvements,13285857,Resolved,Major,Fixed,17/Feb/20 21:12,21/Feb/20 18:29,,This one fails in an odd way about 15% of the time where it replicates 2499 edits of 2500.... And seemingly always these numbers. Odd. [Flakey Test] Stabilizations and Debug,13287803,Resolved,Major,Fixed,26/Feb/20 17:32,28/Feb/20 21:42,,Bunch of test stabilization and extra debug. This set of changes make it so local 'test' runs pass about 20% of the time (where before they didn't) when run on a linux vm and on a mac. Dockerfiles reusing stale apt sources info,13291438,Resolved,Major,Fixed,12/Mar/20 22:52,13/Mar/20 00:29,2.3.0,"We're seeing failed builds on jenkins that look like {noformat} [2020-03-12T21:27:06.369Z] ---> 368a6d22e8da [2020-03-12T21:27:06.369Z] Step 41/62 : RUN DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y bash=4.4.18-2ubuntu1.2 build-essential=12.4ubuntu1 curl=7.58.0-2ubuntu3.8 diffutils=1:3.6-1 git=1:2.17.1-1ubuntu0.5 rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1 wget=1.19.4-1ubuntu2.2 [2020-03-12T21:27:12.818Z] ---> Running in fe5d7602e278 [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/gcc-7-base_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/cpp-7_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libcc1-0_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libgomp1_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libitm1_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libatomic1_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libasan4_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/liblsan0_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libtsan0_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libubsan0_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libcilkrts5_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libmpx2_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-8/libquadmath0_8.3.0-6ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libgcc-7-dev_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/gcc-7_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/libstdc++-7-dev_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/g/gcc-7/g++-7_7.4.0-1ubuntu1~18.04.1_amd64.deb 404 Not Found [IP: 91.189.88.174 80] [2020-03-12T21:27:20.643Z] E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? {noformat} Logs from earlier in the docker build pipeline show use of a cached layer containing apt repository sources, while the earlier layer is bring rebuilt. {noformat} [2020-03-12T21:27:06.368Z] Step 3/62 : RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y ca-certificates=20180409 curl=7.58.0-2ubuntu3.8 locales=2.27-3ubuntu1 [2020-03-12T21:27:06.368Z] ---> Using cache [2020-03-12T21:27:06.368Z] ---> 04ad316a4951 {noformat} Thus, I suspect the later layer has stale repository info. Seems a best practice is that anyone one does {{apt-get install}}, one must first {{apt-get update}} in the same layer. I was hoping to avoid repetitive {{update}} invocations and save some bandwidth... premature optimizations, and all that." Add necessary validations to HRegion.checkAndMutate() and HRegion.checkAndRowMutate(),13293078,Resolved,Major,Fixed,21/Mar/20 08:41,22/Mar/20 03:16,,"Need to check that the following are fulfilled: # The mutation type should be Put or Delete in HRegion.checkAndMutate(). # The specified row should match the row of the Put/Delete/RowMutations in HRegion.checkAndMutate() and HRegion.checkAndRowMutate()." Fix missing jdk8 dependencies in hbase-assembly/hadoop-two-compat,13295116,Resolved,Major,Fixed,31/Mar/20 00:15,02/Apr/20 16:56,2.3.0,"Trying to launch a standalone master out of binary tarball, doesn't start. {noformat} $ JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home ~/tmp/packaging_and_integration/hbase-install/bin/hbase master start 2020-03-30 17:14:21,831 INFO [main] master.HMaster: STARTING service HMaster 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: Source code repository file:///Users/ndimiduk/tmp/packaging_and_integration/unpacked_src_tarball revision=Unknown 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: Compiled by ndimiduk on Mon Mar 30 14:59:17 PDT 2020 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: From source with checksum c13d259fe1832de6fef3f5d192e6651d3ca0b52599c64ef19eaa87c6bdbd3956cc51fda3c3dc917b47add5a633c9058a6968df24ddce88f85c345681763cd568 Exception in thread ""main"" java.lang.NoClassDefFoundError: com/ctc/wstx/io/InputBootstrapper at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149) at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3062) Caused by: java.lang.ClassNotFoundException: com.ctc.wstx.io.InputBootstrapper at java.net.URLClassLoader.findClass(URLClassLoader.java:382) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 2 more {noformat}" Unwrap the real user to properly dispatch proxy-user auth'n,13280421,Resolved,Major,Fixed,19/Jan/20 17:21,22/Jan/20 09:18,2.3.0,Currently {{TestSecureRESTServer}} fails consistently on branch-2 and should be fixed. Up flakey history from 5 to 10,13286127,Resolved,Major,Fixed,19/Feb/20 00:30,19/Feb/20 00:33,,Also change the second and first part fort counts to be 1C rather than hardcoded 3. Simplify CommonFSUtils after upgrading to hadoop 2.10.0,13292117,Resolved,Major,Fixed,17/Mar/20 07:04,26/Mar/20 10:16,2.3.0,"As now the builder is always presented, we do not need to use reflection for most of methods any more." [Flakey Test] TestStochasticLoadBalancerRegionReplicaSameHosts#testRegionReplicationOnMidClusterSameHosts,13286162,Resolved,Major,Fixed,19/Feb/20 06:38,19/Feb/20 06:42,,"Test has this on it: @Test // Test is flakey. TODO: Fix! Let me cut it down. It runs for a while. It fails nearly every run since HBASE-23865 Up flakey history from 5 to 10 which upped the flakey test so it ran with more fork count." [Flakey Tests] Disable TestCustomSaslAuthenticationProvider#testNegativeAuthentication on branch-2.3,13294034,Resolved,Major,Fixed,25/Mar/20 22:40,25/Mar/20 22:47,,"Fails sporadically with relogin in progress complaints. See https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2/lastSuccessfulBuild/artifact/dashboard.html FYI [~elserj] i.e. org.apache.hadoop.hbase.security.provider.TestCustomSaslAuthenticationProvider.testNegativeAuthentication[2: rpcClientImpl=org.apache.hadoop.hbase.ipc.NettyRpcClient, rpcServerImpl=org.apache.hadoop.hbase.ipc.SimpleRpcServer] {code} Failed after attempts=4, exceptions: 2020-03-25T21:25:05.239Z, RpcRetryingCaller{globalStartTime=1585171502143, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=4, exceptions: 2020-03-25T21:25:04.624Z, RpcRetryingCaller{globalStartTime=1585171504623, pause=100, maxAttempts=4}, java.io.IOException: Call to asf905.gq1.ygridcore.net/67.195.81.149:45715 failed on local exception: java.io.IOException: Can not send request because relogin is in progress. 2020-03-25T21:25:04.726Z, RpcRetryingCaller{globalStartTime=1585171504623, pause=100, maxAttempts=4}, java.io.IOException: Call to asf905.gq1.ygridcore.net/67.195.81.149:45715 failed on local exception: java.io.IOException: Can not send request because relogin is in progress. 2020-03-25T21:25:04.929Z, RpcRetryingCaller{globalStartTime=1585171504623, pause=100, maxAttempts=4}, java.io.IOException: Call to asf905.gq1.ygridcore.net/67.195.81.149:45715 failed on local exception: java.io.IOException: Can not send request because relogin is in progress. 2020-03-25T21:25:05.235Z, RpcRetryingCaller{globalStartTime=1585171504623, pause=100, maxAttempts=4}, java.io.IOException: Call to asf905.gq1.ygridcore.net/67.195.81.149:45715 failed on local exception: java.io.IOException: Can not send request because relogin is in progress. {code} Disabling rather than spending time in here." Improve the layout of our proto files in hbase-protocol-shaded module,13294204,Resolved,Major,Fixed,26/Mar/20 13:40,06/Apr/20 02:23,,"Now it is only a big flat directory contains all the proto files, I think it will be better to have several sub directories to hold the proto files to different modules, such as rsgroup, rest, etc." "Disable ""Packaging and Integration"" stage from nightly",13295359,Resolved,Major,Won't Fix,31/Mar/20 21:12,02/Apr/20 18:14,2.3.0,This stage hangs up executors for 8 hours. Let's disable this until HBASE-24049 is resolved. [JDK11] Remove `unit` filter from nightly and precommit jobs,13294547,Resolved,Major,Fixed,27/Mar/20 19:30,01/Apr/20 19:32,2.3.0,"Added in HBASE-23946, we can remove this filter once HBASE-24007 lands." Bump hadoop-two.version to 2.10.0 on master and branch-2,13291669,Resolved,Major,Fixed,14/Mar/20 01:49,17/Mar/20 00:13,,"See this discussion on mailing list https://lists.apache.org/thread.html/rbab2e79f25b38c85fe205390b3fdbc6711984881a994a499c54aee97%40%3Cdev.hbase.apache.org%3E" MapReduce on snapshot restores and opens all regions in each mapper,13293041,Open,Major,,20/Mar/20 22:35,,1.6.0,"Given this scenario: one MR job scans a table (with many regions). I will use 'RestoreSnapshotHelper' to restore snapshot for all regions in each mapper.  In the code [https://github.com/apache/hbase/blob/branch-2.0/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java#L183] Seems there is no way to only restore relevant regions from snapshot to region. This leads to extreme slowness and waste of resource.      One quick example I can show as below, in my test, there are 2 regions in a testing table, each mapper opens and iterates 2 regions.  (which is wrong IMO, each mapper should only touch 1 region based on the splits) I have checked the splits are correct, which have  correct startKey and endKey 2020-03-19 18:58:15,225 INFO [main] mapred.MapTask - Map output collector class = org.apache.hadoop.mapred.MapTask$MapOutputBuffer 2020-03-19 18:58:15,285 INFO [main] snapshot.RestoreSnapshotHelper - region to add: *d7f85b4a9d3fa22a5e7b88bda39f6d50* 2020-03-19 18:58:15,285 INFO [main] snapshot.RestoreSnapshotHelper - region to add: *69dd3fdba3698f827f8883ed911161ef* 2020-03-19 18:58:15,286 INFO [main] snapshot.RestoreSnapshotHelper - clone region=d7f85b4a9d3fa22a5e7b88bda39f6d50 as d7f85b4a9d3fa22a5e7b88bda39f6d50   Please correct me if I am wrong or miss anything. thanks. So if I misunderstood anything, can anyone point to me where in this class, can distinguish which region to go through for different mappers?    btw the original implementation for MR on Snapshot is here, there weren't too many big changes after that HBASE-8369     " [RSGroup] Assign created tables to respective rsgroup automatically instead of manual operations ,13293086,Resolved,Major,Fixed,21/Mar/20 10:53,24/Mar/20 12:26,,"In prod practise, it's time consuming and tiring to assign tables to their rsgroups for HBase admin by shell, especially in 1.x rsgroup client is IA.private, we could not even write some programs to do that. And I'm here proposing a solution to do the automated rsgroup assignment by allowing running a shell in postCreateTable to determine which table should go to which rsgroup (way in branch-1 not master). The benefit is obvious, admin can determine or change at any time the mapping rule in script without restarting or re-config anything. It's flexible, convenience and time saving." Get `-PrunLargeTests` passing on JDK11,13292282,Resolved,Major,Fixed,17/Mar/20 21:48,30/Mar/20 16:50,,"Build on HBASE-23829 and HBASE-24006, now looking at large tests." Remove hbase-prototcol module,13283349,Resolved,Major,Fixed,05/Feb/20 01:39,30/Mar/20 12:35,, /hadoop-3.1.3/libexec/hadoop-functions.sh:行2360: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_USER: 错误的替换,13282921,Resolved,Major,Invalid,03/Feb/20 07:34,03/Mar/20 06:55,2.2.3,"/hadoop-3.1.3/libexec/hadoop-functions.sh:行2360: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_USER: 错误的替换 /hadoop-3.1.3/libexec/hadoop-functions.sh:行2455: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_OPTS: 错误的替换 Hadoop版本3.1.3 分布式安装启动报错" Rolling Upgrade: Regions are in RIT during enabling the table after restore_snapshot,13295187,Open,Major,,31/Mar/20 08:02,,1.3.4,"During Rolling upgrade, we performed some set of operations, which leads to regions were stuck in RIT. pre-requisites: configure the below properties in HBase 1.3.1 version {noformat} hbase.assignment.usezk true hbase.assignment.usezk.migrating true {noformat} configure the below properties in HBase 1.3.1 version {noformat} hbase.mirror.table.state.to.zookeeper true hbase.migrate.table.state.from.zookeeper true {noformat} Steps to reproduce the problem. {noformat} 1. start the hbase cluster with version 1.3.1 (1 master and 1 regionserver) 2. start the regionserver 2.2.x version [ 1 regionserver] 3. create the table with one region (ensure the table region with old version RS) 4. write some data into the table 5. flush the table. 6. create snapshot for the table 7. move the table region from old version to new version RS 8. disable the table. 9. restore snapshot on the table. 10 enable table. {noformat} After triggered the enable table operation, HBase 1.3.1 master assigned the region to HBase 1.3.1 Regionserver. RS failed to open the region. {noformat} 2020-03-18 21:10:45,103 WARN [RS_OPEN_REGION-vm1:16040-17] zookeeper.ZKAssign: regionserver:16040-0x200431c58cf0012, quorum=vm1:2181,vm2:2181,vm3:2181, baseZNode=/hbase Attempt to transition the unassigned node for 505f0e1d96a2a06eb111bd8b923a5a87 from M_ZK_REGION_OFFLINE to RS_ZK_REGION_OPENING failed, the server that tried to transition was vm1,16040,1584536385246 not the expected vm2,16040,1584536781189 2020-03-18 21:10:45,104 WARN [RS_OPEN_REGION-vm1:16040-17] coordination.ZkOpenRegionCoordination: Failed transition from OFFLINE to OPENING for region=505f0e1d96a2a06eb111bd8b923a5a87 2020-03-18 21:10:45,104 WARN [RS_OPEN_REGION-vm1:16040-17] handler.OpenRegionHandler: Region was hijacked? Opening cancelled for encodedName=505f0e1d96a2a06eb111bd8b923a5a87 2020-03-18 21:10:45,104 INFO [RS_OPEN_REGION-vm1:16040-17] coordination.ZkOpenRegionCoordination: Opening of region {ENCODED => 505f0e1d96a2a06eb111bd8b923a5a87, NAME => 'usertable01,user1089,1584535968752.505f0e1d96a2a06eb111bd8b923a5a87.', STARTKEY => 'user1089', ENDKEY => 'user1134'} failed, transitioning from OFFLINE to FAILED_OPEN in ZK, expecting version 0 2020-03-18 21:10:45,104 DEBUG [RS_OPEN_REGION-vm1:16040-17] zookeeper.ZKAssign: regionserver:16040-0x200431c58cf0012, quorum=vm1:2181,vm2:2181,vm3:2181, baseZNode=/hbase Transitioning 505f0e1d96a2a06eb111bd8b923a5a87 from M_ZK_REGION_OFFLINE to RS_ZK_REGION_FAILED_OPEN {noformat} Looked little deeper into the problem, found that HMaster failed to delete the Znode, during the table disable operation. {noformat} 2020-03-18 21:10:02,219 DEBUG [RpcServer.FifoWFPBQ.default.handler=42,queue=2,port=16000] master.AssignmentManager: Table being disabled so deleting ZK node and removing from regions in transition, skipping assignment of region usertable01,user1089,1584535968752.505f0e1d96a2a06eb111bd8b923a5a87. 2020-03-18 21:10:02,220 WARN [RpcServer.FifoWFPBQ.default.handler=42,queue=2,port=16000] zookeeper.ZKAssign: master:16000-0x100431c3faf0012, quorum=vm1:2181,vm2:2181,vm3:2181, baseZNode=/hbase Attempting to delete unassigned node 505f0e1d96a2a06eb111bd8b923a5a87 in RS_ZK_REGION_CLOSED state but node is in M_ZK_REGION_CLOSING state 2020-03-18 21:10:02,221 WARN [RpcServer.FifoWFPBQ.default.handler=42,queue=2,port=16000] zookeeper.ZKAssign: master:16000-0x100431c3faf0012, quorum=vm1:2181,vm2:2181,vm3:2181, baseZNode=/hbase Attempting to delete unassigned node 505f0e1d96a2a06eb111bd8b923a5a87 in M_ZK_REGION_OFFLINE state but node is in M_ZK_REGION_CLOSING state 2020-03-18 21:10:02,221 INFO [RpcServer.FifoWFPBQ.default.handler=42,queue=2,port=16000] master.AssignmentManager: Failed to delete the closed node for 505f0e1d96a2a06eb111bd8b923a5a87. The node type may not match {noformat} Region was closed successfully, and Latest RS sent RPC call back to the master about the region transition information, But master is expecting the Znode states modified by the RS, Based on those states HM will delete the ZNode." shell fails to launch out of binary tarball,13295117,Open,Major,,31/Mar/20 00:18,,3.0.0-alpha-1,"Trying to launch the shell out of binary tarball, doesn't launch. {noformat} $ JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home ~/tmp/packaging_and_integration/hbase-install/bin/hbase shell NameError: missing class name (`org.apache.hadoop.hbase.HColumnDescriptor') method_missing at org/jruby/javasupport/JavaPackage.java:259 at /Users/ndimiduk/tmp/packaging_and_integration/hbase-install/lib/ruby/hbase_constants.rb:42
at /Users/ndimiduk/tmp/packaging_and_integration/hbase-install/lib/ruby/hbase_constants.rb:34 require at org/jruby/RubyKernel.java:956 (root) at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
at /Users/ndimiduk/tmp/packaging_and_integration/hbase-install/bin/../bin/hirb.rb:131 {noformat}" [Flakey Tests] Reenable TestThriftHBaseServiceHandler#testLongLivedScan,13295097,Open,Major,,30/Mar/20 21:46,,,"Disabled by parent issue. Fails with {code} // Caused by: java.util.concurrent.RejectedExecutionException: // Task org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture@e385431 // rejected from java.util.concurrent.ThreadPoolExecutor@ 52b027d[Terminated, pool size = 0, // active threads = 0, queued tasks = 0, completed tasks = 1] // at org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler. // testLongLivedScan(TestThriftHBaseServiceHandler.java:804) {code} Reenable." [Flakey Tests] Renenable TestBucketCacheRefCnt.testBlockInRAMCache,13295095,Open,Major,,30/Mar/20 21:32,,,"Disabled in parent issue. Fails like this. Rare but enough times to mess up runs. TestBucketCacheRefCnt.testBlockInRAMCache:121 expected:<3> but was:<2> " Deprecated PBType on all 2.x branches,13294067,Resolved,Major,Fixed,26/Mar/20 02:40,27/Mar/20 02:51,, Refactor TestFromClientSide; takes too long since got parameterized,13290892,Resolved,Major,Duplicate,10/Mar/20 18:33,27/Mar/20 19:29,, Backport the personality changes in HBASE-23989 to all active branches,13292317,Resolved,Major,Fixed,18/Mar/20 02:01,20/Mar/20 06:34,, Enable SpotBugs in PreCommit,13294255,Resolved,Major,Not A Problem,26/Mar/20 17:28,27/Mar/20 16:57,2.3.0,"Yetus's SpotBugs module depends on {{maven_add_install}}. In {{Jenkinsfile_GitHub}}, I'm pretty strict on my module definitions, with {noformat} GENERAL_CHECK_PLUGINS = 'all,-compile,-javac,-javadoc,-jira,-shadedjars,-unit' JDK_SPECIFIC_PLUGINS = 'compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit' {noformat} The general check requests {{all}} but omits {{compile}} and {{maven}}, which I think means the {{spotbugs}} check gets dropped. Before HBASE-23767, we had just a single yetus that did {{all}}, so {{spotbugs}} would have been run." FileSystemUtilizationChore reduces unnecessary regions,13287035,Open,Major,,23/Feb/20 05:59,,2.2.3,"If the RS has 2000 reegions, and only one region1 has been disk space quota. FileSystemUtilizationChore can reduce unnecessary regions. RS only need to collect the region1 size !image-2020-02-23-13-59-32-894.png|width=608,height=138!" Add JDK11 compilation and unit test support to Github precommit,13282271,Resolved,Major,Fixed,29/Jan/20 21:55,05/Mar/20 21:59,,We already test against multiple JDK versions in a handful of places. Let's get JDK11 added to the mix. Applies to GitHub-based pre-commit. Snapshoting a splitting region results in corrupted snapshot,13291963,Open,Major,,16/Mar/20 12:44,,2.0.2,"The problem seems to originate from the fact that while the region split itself runs in a lock, the compactions following it run in separate threads. Alternatively the use of space quota policies can prevent compaction after a split and leads to the same issue. In both cases the resulting snapshot will keep the split status of the parent region, but do not keep the references to the daughter regions, because they (splitA, splitB qualifiers) are stored separately in the meta table and do not propagate with the snapshot. This is important because the in the freshly cloned table CatalogJanitor will find the parent region, realizes it is in split state, but because it can not find the daughter region references (haven't propagated) assumes parent could be cleaned up and deletes it. The archived region used in the snaphost only has back reference to the now also archived parent region and if the snapshot is deleted they both gets cleaned up. Unfortunately the daughter regions only contains hfile links, so at this point the data is lost. How to reproduce: {code:java} hbase shell < [Help 1] {noformat} Looks like it's because these xmlns values have actual meaning to the plugin, and having https uris breaks things. Removing the https bits allows the plugin to proceed." Use loopback for zk standalone server in minizkcluster,13291763,Resolved,Major,Fixed,15/Mar/20 03:37,18/Mar/20 03:45,,"Use loopback for minizkcluster. HBASE-23919 shows how sometimes unit tests fail in setup because the minizkcluster won't come up. It looks like client is trying to stat the server but though the server is trying to poll a socket bound to 0.0.0.0, the server never notices the client pings. Using loopback, I don't see these odd failures anymore." Coprocessor existence check for READ level privilege,13292583,Reopened,Major,,18/Mar/20 23:14,,,"Currently getTableDescriptor requires a user to have Admin or Create permissions. A client might need to get table descriptors to act accordingly eg. based on an attribute set or a CP loaded. It should not be necessary for the client to have create or admin privileges just to read the descriptor, execute and/or read permission should be sufficient? " Create branch-2.3,13292305,Resolved,Major,Fixed,18/Mar/20 00:28,18/Mar/20 17:56,,Per the summary. Provide a harness for running test-patch locally,13292266,Open,Major,,17/Mar/20 19:46,,,"This is more of brainstorm or wish than prescriptive. It would be really nice to be able to run locally Yetus {{test-patch}} the way we do for PreCommit and Nightly jobs. There are two use-cases I have in mind. It would be useful for folks who want to hack on the build infrastructure without ""doing it live"". It would also be handy just for running precommit or nightly checks locally, without waiting for shared resources or polluting the public space with experiments. I imagine a new dev-support tool that uses docker or vagrant to spin up the environment in a way that mimics the Jenkins build pipeline as close as possible. Maybe even uses the {{Jenkinsfiles}} directly with something like [jenkinsfile-runner|https://github.com/jenkinsci/jenkinsfile-runner]." move_namespaces_rsgroup is not moving namespace into desired rsgroup,13288009,Resolved,Major,Invalid,27/Feb/20 10:47,17/Mar/20 06:01,2.2.3,"When creating a namespace and specifying a rs group in hbase.rsgroup.name, the namespace gets associated with the mentioned rs group. However later, the namespace does not move to another rs group when using ""move_namespace_rsgroup"".   Steps to reproduce the issue: # create a rs group 'r1' and add a region server in it. # *create_namespace 'namespace',\{METHOD => 'set', 'hbase.rsgroup.name' => 'r1'}* # *describe_namespace 'namespace'* # *move_namespaces_rsgroup 'default',['namespace']* # *describe_namespace 'namespace'* Before moving the namespace into another rs group, it will show rsgroup r1 but even after the step 4, it still shows same description of the namespace. This bug is not allowing me to remove a rs group because it keeps on telling ""r1 cannot be deleted as namespace 'namespace' is still associated with the rs group 'r1' "".        " [Flakey Tests] Disable TestSecureExport.testVisibilityLabels ,13291749,Resolved,Major,Fixed,14/Mar/20 21:04,14/Mar/20 21:06,,See parent issue. Disabling for now. Consider hadoop2 check versions for branch-1.x,13291719,Open,Major,,14/Mar/20 12:19,,, Have test runs use less resources,13290843,Resolved,Major,Duplicate,10/Mar/20 15:36,14/Mar/20 03:40,,"Our tests can create thousands of threads all up in the one JVM. Using less means less memory, less contention, and hopefully, likelier passes. I've been studying the likes of TestNamespaceReplicationWithBulkLoadedData to see what it does as it runs (this test puts up 4 clusters with replication between). It peaks at 2k threads. After some configuration and using less HDFS, can get it down to ~800 threads and about 1/2 the memory-used. (HDFS is a profligate offender. DataXceivers (Server and Client), jetty threads, Volume threads (async disk 'worker' then another for cleanup...), image savers, ipc clients -- new thread per incoming connection w/o bound (or reuse), block responder threads, anonymous threads, and so on. Many are not configurable or boundable or are hard-coded; e.g. each volume gets 4 workers. Biggest impact was to be had by downing the count of data nodes. TODO: a follow-on that turns down DN counts in all tests) I've been using Java Flight Recorder during this study. Here is how you get a flight recorder for the a single test run: {code:java} MAVEN_OPTS="" -XX:StartFlightRecording=disk=true,dumponexit=true,filename=recording.jfr,settings=profile,path-to-gc-roots=true,maxsize=1024m"" mvn test -Dtest=TestNamespaceReplicationWithBulkLoadedData -Dsurefire.firstPartForkCount=0 -Dsurefire.secondPartForkCount=0 {code} i.e. start recording on mvn launch, bound the size of the recording, and have the test run in the mvn context (DON'T fork). Useful is connecting to the running test at the same time from JDK Mission Control. We do the latter because the thread reporting screen is overwhelmed by the count of running threads and if you connect live, you can at least get a 'live threads' graph w/ count as the test progresses. Useful. When the test finishes, it dumps a .jfr file which can be opened in JDK MC. I've been compiling w/ JDK8 and then running w/ JDK11 so I can use JDK MC Version 7, the non-commercial latest. Works pretty well. Let me put up a patch for tests that cuts down thread counts where we can.    " Disable TestSlowLogRecorder until parent addressed,13291450,Resolved,Major,Fixed,13/Mar/20 00:22,13/Mar/20 00:25,, Set version to 2.2.4 in branch-2.2 for first RC of 2.2.4,13290973,Resolved,Major,Fixed,11/Mar/20 03:44,11/Mar/20 06:14,, Generate CHANGES.md and RELEASENOTES.md for 2.2.4,13290974,Resolved,Major,Fixed,11/Mar/20 03:49,11/Mar/20 06:15,, SimpleBalancer bug when second pass to fill up to min,13290705,Resolved,Major,Fixed,10/Mar/20 03:23,11/Mar/20 03:01,2.2.0, SplitParent region should not be balanced,13290727,Resolved,Major,Fixed,10/Mar/20 08:09,10/Mar/20 18:16,2.2.0,"SplitParent region  may be in deadserver . balancer will move region onto these deadserver if SplitParent region participate balancing" "Backport CacheCompactedBlocksOnWrite: HBASE-23066, HBASE-23588, HBASE-23350 to branch-1",13277235,Resolved,Major,Fixed,02/Jan/20 16:29,10/Mar/20 15:08,1.6.0,"Backport HBASE-23066 and all relevant subtasks to branch-1: HBASE-23066: Create a config that forces to cache blocks on compaction  HBASE-23588: Cache index blocks and bloom blocks on write if CacheCompactedBlocksOnWrite is enabled HBASE-23350: Make compaction files cacheonWrite configurable based on threshold" "Forward-port HBASE-21345 to branch-2.2, 2.3 & master as well.",13281297,Resolved,Major,Fixed,23/Jan/20 22:00,24/Jan/20 20:03,,"HBASE-21345 is a good addition to branch-2.2, 2.3 & master. This Jira tracks the forward-porting." TestHFileWriterV3 should have tests for all data block encodings,13281842,Resolved,Major,Fixed,28/Jan/20 03:53,29/Jan/20 19:25,1.6.0,"TestHFileWriterV3 tests include writing and reading HFiles for default data blocks encoding. However, since this test has efficient way of testing by looping through encoded/un-encoded keys and values and keeping offsets updated etc, it would be really good to have such test for each encoded data blocks. For that, we should explore using respective seekers e.g. RowIndexV1Seeker for ROW_INDEX_V1 encoded data blocks etc." Include HBASE-21284 to branch-2.2,13281834,Resolved,Major,Fixed,28/Jan/20 02:23,31/Jan/20 05:39,,"HBASE-21284 was ought to be present in 2.2. But by the time the commit was done, the branch had been cut already. Hence this Jira to track it's inclusion." Include HBASE-21018 in 2.2 & 2.3,13281300,Resolved,Major,Fixed,23/Jan/20 22:18,24/Jan/20 20:05,,HBASE-21018 is missing from 2.2 & 2.3. This Jira tracks it's addition to these branches. Port HBASE-20981 in 2.2 & 2.3,13281298,Resolved,Major,Fixed,23/Jan/20 22:12,24/Jan/20 20:04,,"HBASE-20981 is present in 2.0, 2.1 & 3. But is missing from 2.2 and 2.3. This Jira tracks the addition of that commit." Priority configuration for system coprocessors,13280606,Resolved,Major,Fixed,20/Jan/20 19:15,24/Jan/20 01:03,,"Currenty HBase allows operators to set system region coprocessors via hbase-site.xml to be loaded on each table in a cluster (or alternately, all tables but system tables). HBase assumes that the first loaded system coprocessor gets the first, or SYSTEM priority, with each subsequent system coproc getting incremented by 1. As a reminder, in HBase _lower_ priorities go first. It can be useful for an operator to be able to define a coprocessor on each table that needs a different priority. For example, an operator might want a coproc to load on each table _last_, so that it can enforce some system invariant and know that no other coproc will interfere with it. I propose adding optional priority config to the hbase-site.xml configuration, separated from each coproc class in the comma-separated list by a special character (perhaps a pipe, such as table coprocs use) that's not used in class names. The region coprocessor host will parse the priority if present and use it when instantiating the coproc. " Resolve the TODO of FSTableDescriptor's construct method,13288422,Resolved,Major,Fixed,29/Feb/20 01:43,07/Mar/20 11:43,,"Resolve the TODO in FSTableDescriptor's construct method. {code:java} - * @param metaObserver Used by HMaster. It need to modify the META_REPLICAS_NUM for meta table descriptor. - * see HMaster#finishActiveMasterInitialization - * TODO: This is a workaround. Should remove this ugly code... {code} " The method setClusterLoad of SimpleLoadBalancer is incorrect when balance by table ,13289970,Resolved,Major,Fixed,06/Mar/20 07:21,07/Mar/20 08:47,2.2.2,"now if in parameter clusterLoad is by table, for example {code:java} table1=>      server1=>[table1,region1]      server2=>[] table2=>     server1=>[table2,region1]     server2=>[] {code} then, the member variable serverLoadList is: {code:java} [{server1, load 1}{server2, load 0}{server1, load 1} {server2, load 0}] {code} the cluster will be considered balanced  in method overallNeedsBalance" STUCK Region-In-Transition when failed to insert procedure to procedure store,13287701,Resolved,Major,Fixed,26/Feb/20 09:32,07/Mar/20 08:00,,"When move an region, it will generate a TRSP first and set the procedure to the region state node. But if the submit TRSP failed, the procedure cannot be unset now and the region will stuck in RIT. hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java {code:java} public Future moveAsync(RegionPlan regionPlan) throws HBaseIOException { TransitRegionStateProcedure proc = createMoveRegionProcedure(regionPlan.getRegionInfo(), regionPlan.getDestination()); return ProcedureSyncWait.submitProcedure(master.getMasterProcedureExecutor(), proc); } public TransitRegionStateProcedure createMoveRegionProcedure(RegionInfo regionInfo, ServerName targetServer) throws HBaseIOException { RegionStateNode regionNode = this.regionStates.getRegionStateNode(regionInfo); if (regionNode == null) { throw new UnknownRegionException(""No RegionStateNode found for "" + regionInfo.getEncodedName() + ""(Closed/Deleted?)""); } TransitRegionStateProcedure proc; regionNode.lock(); try { preTransitCheck(regionNode, STATES_EXPECTED_ON_UNASSIGN_OR_MOVE); regionNode.checkOnline(); proc = TransitRegionStateProcedure.move(getProcedureEnvironment(), regionInfo, targetServer); regionNode.setProcedure(proc); } finally { regionNode.unlock(); } return proc; } {code} hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateNode.java {code:java} public void setProcedure(TransitRegionStateProcedure proc) { assert this.procedure == null; this.procedure = proc; ritMap.put(regionInfo, this); } public void unsetProcedure(TransitRegionStateProcedure proc) { assert this.procedure == proc; this.procedure = null; ritMap.remove(regionInfo, this); } {code} {code:java} 2020-02-26,13:45:21,344 ERROR [RpcServer.default.RWQ.Fifo.read.handler=437,queue=5,port=21500] org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object java.io.UncheckedIOException: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out waiting for lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region 9731aea823e7f83264b14713ae486fb7 at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.update(RegionProcedureStore.java:588) at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.insert(RegionProcedureStore.java:545) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:1042) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:860) at org.apache.hadoop.hbase.master.procedure.ProcedureSyncWait.submitProcedure(ProcedureSyncWait.java:123) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.moveAsync(AssignmentManager.java:657) at org.apache.hadoop.hbase.master.HMaster.executeRegionPlansWithThrottling(HMaster.java:1793) at org.apache.hadoop.hbase.master.HMaster.balance(HMaster.java:1761) at org.apache.hadoop.hbase.master.MasterRpcServices.balance(MasterRpcServices.java:654) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:374) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:352) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:332) Caused by: org.apache.hadoop.hbase.exceptions.TimeoutIOException: Timed out waiting for lock for row: \x00\x00\x00\x00\x00\x0B\xAB\xD2 in region 9731aea823e7f83264b14713ae486fb7 at org.apache.hadoop.hbase.regionserver.HRegion.getRowLockInternal(HRegion.java:6158) at org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lockRowsAndBuildMiniBatch(HRegion.java:3488) at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4235) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4208) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4134) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4125) at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4139) at org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4511) at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3209) at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.update(RegionProcedureStore.java:584) ... 13 more {code}" Add JDK11 compilation and unit test support to nightly job,13286306,Resolved,Major,Fixed,19/Feb/20 19:02,05/Mar/20 22:00,,We already test against multiple JDK versions in a handful of places. Let's get JDK11 added to the mix. Applies to nightly job. "Implement the checkAndMutate(row, filter) method of RemoteHTable for Rest",13289443,Open,Major,,04/Mar/20 06:30,,, "Implement the checkAndMutate(row, filter) method of ThriftTable for Thrift",13289444,Open,Major,,04/Mar/20 06:31,,, [operator tools] Add forbiddennapis plugin to pom.xml so that we can permanently ban references to hbase I.A. private classes from hbck2,13289792,Resolved,Major,Fixed,05/Mar/20 11:50,06/Mar/20 10:30,hbase-operator-tools-1.0.0,"Following suggestion from [~elserj] on PR for HBASE-23791, this adds _forbiddenapis_ plugin to hbck2 pom.xml file, defining a ban to *MetaTableAccessor.* This also gets rid of one remaining reference to *MetaTableAccessor* on *HBCKMetaTableAccessor* that we missed to detect in HBASE-23791." ROW_INDEX_V1 encoder should consider the secondary index size with the encoded data size tracking,13283145,Resolved,Major,Fixed,04/Feb/20 04:48,06/Mar/20 01:10,,"Copied from parent issue comments ""In case of Row Index this tracking is not accounting the row offsets index being written. Because on the go these are kept in memory only and written at the end of block write. This end block decision was based on size check only which did NOT include this offsets index.""" CatalogJanitor consistency check adds merging regions to orphan list (tooo),13289661,Reopened,Major,,04/Mar/20 23:47,,,"When the CJ runs, it does its consistency checking first before figuring if the current row is that of a splitting or merging region. Down in the guts of consistency we will check if its a splitting region and then cater appropriately accommodating daughters, etc. For merge we don't do the same. We'll actually add merge children parents as orphans. Its transitory but confusing.   Here is an (ugly) example. Here is how the merge shows in orphans section of HBCK Report {code:java} {ENCODED => 8d4e9d9dbae0a90d47b9f72c89973693, NAME => 'scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693.', STARTKEY => '\x01\x03\x04\x01\x02\x03', ENDKEY => '\x01\x03\x04\x02\x02\x03'}{ENCODED => 62dbb839b3a70d5b670b9a30b0a05648, NAME => 'scooter_analytics_segment,\x01\x03\x04\x01\x02\x03\x02\x01\x01\x02201904090000\x00\x00qwest\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x0DW:S:P:D\x03\x00\x00\x03,1554833869031.62dbb839b3a70d5b670b9a30b0a05648.', STARTKEY => '\x01\x03\x04\x01\x02\x03\x02\x01\x01\x02201904090000\x00\x00qwest\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x0DW:S:P:D\x03\x00\x00\x03', ENDKEY => '\x01\x03\x04\x02\x01\x01'}{ENCODED => 8d4e9d9dbae0a90d47b9f72c89973693, NAME => 'scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693.', STARTKEY => '\x01\x03\x04\x01\x02\x03', ENDKEY => '\x01\x03\x04\x02\x02\x03'}{ENCODED => 2666b87ae4b58b05e815a3f14cc33215, NAME => 'scooter_analytics_segment,\x01\x03\x04\x02\x01\x01,1583365243857.2666b87ae4b58b05e815a3f14cc33215.', STARTKEY => '\x01\x03\x04\x02\x01\x01', ENDKEY => '\x01\x03\x04\x02\x02\x03'}{code} Then... here is the row in meta...   {code:java} scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:merge0000, timestamp=1583364483794, value=PBUF\x08\xE6\xE8\xFC\x9C\xA0-\x12$\x0A\x07default\x12\x19scooter_analytics_segment\x1A\x06\x01\x03\x04\x01\x02\x03""\x06\x01\x03\x04\x02\x02\x03(\x000\x008\x00B d097cacbd74c36e84a599926547e3249 scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:merge0001, timestamp=1583364483794, value=PBUF\x08\xC8\xF3\xF3\xBD\x8A.\x12$\x0A\x07default\x12\x19scooter_analytics_segment\x1A\x06\x01\x03\x04\x02\x01\x01""\x06\x01\x03\x04\x02\x02\x03(\x000\x008\x00B 6b2ac2d1878e688da50483014fc5ab58 scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:regioninfo, timestamp=1583364484283, value={ENCODED => 8d4e9d9dbae0a90d47b9f72c89973693, NAME => 'scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693.', STARTKEY => '\x01\x03\x04\x01\x02\x03', ENDKEY => '\x01\x03\x04\x02\x02\x03'} scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:seqnumDuringOpen, timestamp=1583364484283, value=\x00\x00\x00\x00\x00\x00\x010 scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:server, timestamp=1583364484283, value=a.example.com:16020 scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:serverstartcode, timestamp=1583364484283, value=1583349446638 scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:sn, timestamp=1583364483948, value=a.example.com,16020,1583349446638 scooter_analytics_segment,\x01\x03\x04\x01\x02\x03,1583362144713.8d4e9d9dbae0a90d47b9f72c89973693. column=info:state, timestamp=1583364484283, value=OPEN {code}" TestThriftHBaseServiceHandler.testMetricsWithException failing,13288443,Resolved,Major,Fixed,29/Feb/20 12:07,02/Mar/20 04:58,,TestThriftHBaseServiceHandler.testMetricsWithException() is failing as test due to timeout. We need to set hbase.client.retries.number [Flakey Tests] Down the flakies re-run ferocity; it makes for too many fails.,13289579,Resolved,Major,Fixed,04/Mar/20 16:51,05/Mar/20 00:23,,The parent issue upped the parallelism of the flakey reruns – see the second panel on this page [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2/lastSuccessfulBuild/artifact/dashboard.html] This upped the flakie list length. It also may have overcommitted the test-running machine. Let me down the rate to something more mild. [operator tools] Remove reference to I.A. Private interface MetaTableAccessor,13283273,Resolved,Major,Fixed,04/Feb/20 15:54,04/Mar/20 16:32,,"While trying to use newly command _extraRegionsInMeta_ added by HBASE-23371, [~daisuke.kobayashi] noticed it was not working properly on some deployments not including another patch merged in HBASE-22758, that changed *MetaTableAccessor* interface: {noformat} $ hbase hbck -j hbase-operator-tools-1.0.0.1.0.0.0-11/hbase-hbck2/hbase-hbck2.jar extraRegionsInMeta -f default:cluster_test Regions that had no dir on the FileSystem and got removed from Meta: 0 ERROR: There were following errors on at least one table thread: java.lang.NoSuchMethodError: org.apache.hadoop.hbase.MetaTableAccessor.deleteRegionInfos(Lorg/apache/hadoop/hbase/client/Connection;Ljava/util/List;) {noformat} Since *MetaTableAccessor* is IA Private, and HBCK2 is aimed to evolve independently of hbase project, ideally we should not rely in IA Private interfaces. There's already an existing *HBCKMetaTableAccessor* on hbck2, with some *MetaTableAccessor* original methods used in hbck2 re-implemented. This PR removes all dependencies to *MetaTableAccessor* currently existing in hbck2, re-implementing some of the required methods on *HBCKMetaTableAccessor*. Thanks for finding and reporting it, [~daisuke.kobayashi]!" Pass --copy-to argument in ExportSnapshot tests,13289239,Resolved,Major,Fixed,03/Mar/20 13:40,03/Mar/20 15:33,3.0.0-alpha-1,TestExportSnapshot and its subclasses are failing due to missing --copy-to parameter. Backport HBASE-23553 to branch-2.1,13288492,Resolved,Major,Fixed,01/Mar/20 08:35,03/Mar/20 18:44,,"HBASE-23553 is fixed in branch-2.2 but there are some conflicts on branch-2.1 backport. HBASE-23553 is required HBASE-6028(Turning compaction on/off feature), and HBASE-6028 is used only in test-case ""TestTableSnapshotScanner#testMergeRegion"" for this issue. Thought only to modify HBASE-23553 test-case without HBASE-6028 backport otherwise we may end up with several other conflicts on HBASE-6028 backport." Revisit Callable converting all exceptions (including Runtimes) to IOE,13288401,Open,Major,,28/Feb/20 21:49,,,"This came up in the review of HBASE-23904 where in one location, we swapped out the old Callable for a different idiom. The refactor happened to let out RuntimeExceptions rather than wrap them as we've done up to this. Discussion in the issue wondered if this not the proper behavior. This issue is about deciding if it is the case and if so, then the retrofit of the code base to not wrap REs in IOEs." Replace usages of HColumnDescriptor(byte [] familyName) with builder pattern,13286222,Resolved,Major,Fixed,19/Feb/20 11:54,02/Mar/20 11:52,3.0.0-alpha-1,Replace HColumnDescriptor(byte [] familyName) with ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor as we need to remove HColumnDescriptor(byte [] familyName) from 3.0. Attach the new rsgroup implementation design doc to our code base,13288419,Resolved,Major,Fixed,29/Feb/20 00:59,29/Feb/20 02:39,, Update the rsgroup section in our ref guide,13287453,Resolved,Major,Fixed,25/Feb/20 09:12,29/Feb/20 00:58,, Cleanup the remaining RSGroupInfo.getTables call in the code base,13284118,Resolved,Major,Fixed,09/Feb/20 07:40,12/Feb/20 02:02,, Make rsgroup related shell command to use the new admin methods,13283686,Resolved,Major,Fixed,06/Feb/20 12:00,09/Feb/20 02:34,, Inconsistent library versions notice.,13288520,Open,Major,,01/Mar/20 12:30,,,"Hi. I have implemented a tool to detect library version inconsistencies. Your project have 1 inconsistent library. Take junit:junit for example, this library is declared as version 4.13 in hbase-rest, 4.12 in hbase-archetypes/hbase-shaded-client-project and etc... Such version inconsistencies may cause unnecessary maintenance effort in the long run. For example, if two modules become inter-dependent, library version conflict may happen. It has already become a common issue and hinders development progress. Thus a version harmonization is necessary. Provided we applied a version harmonization, I calculated the cost it may have to harmonize to all upper versions including an up-to-date one. The cost refers to POM config changes and API invocation changes. Take junit:junit for example, if we harmonize all the library versions into 4.13-beta-1. The concern is, how much should the project code adapt to the newer library version. We list an effort table to quantify the harmonization cost. The effort table is listed below. It shows the overall harmonization effort by modules. The columns represents the number of library APIs and API calls(NA,NAC), deleted APIs and API calls(NDA,NDAC) as well as modified API and API calls(NMA,NMAC). Modified APIs refers to those APIs whose call graph is not the same as previous version. Take the first row for example, if upgrading the library into version 4.13-beta-1. Given that 1375 APIs is used in module hbase-server, 0 of them is deleted in a recommended version(which will throw a NoMethodFoundError unless re-compiling the project), 1 of them is regarded as modified which could break the former API contract. ||Index||Module||NA(NAC)||NDA(NDAC)||NMA(NMAC)|| |1|hbase-server|1375(4528)|0(0)|1(1)| |2|hbase-common|143(547)|0(0)|0(0)| |3|hbase-mapreduce|108(389)|0(0)|0(0)| |4|..|..|..|..|   Also we provided another table to show the potential files that may be affected due to library API change, which could help to spot the concerned API usage and rerun the test cases. The table is listed below. ||Module||File||Type||API|| |hbase-it|hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java|modify|org.junit.Assume.assumeFalse(boolean)| |hbase-archetypes/hbase-shaded-client-project|hbase-archetypes/hbase-shaded-client-project/src/test/java/org/apache/hbase/archetypes/exemplars/shaded_client/TestHelloHBase.java|modify|org.junit.Assert.assertEquals(java.lang.String,java.lang.Object,java.lang.Object)| |hbase-server|hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHBaseWalOnEC.java|modify|org.junit.Assume.assumeNoException(java.lang.String,java.lang.Throwable)| |4|..|..|..| If you are interested, you can have a more complete and detailed report in the attached PDF file." SecureTestCluster should allow its subclasses to pass their Class reference on HBaseKerberosUtils.setSSLConfiguration,13287562,Resolved,Major,Fixed,25/Feb/20 17:50,28/Feb/20 19:50,2.2.3,"Was working on a third party project that relies on hbase-server as a dependency and defines a UT class that extends *SecureTestCluster*. In this project, hbase-server jar is added on the test classpath, and it relies on *KeyStoreTestUtil* to decide where to place related ssl files. Current *KeyStoreTestUtil* code assumes related class files would be under an existing local FS path, but when those are loaded from a jar, related class URI path returns null and causes an NPE that errors out the test execution.    The test code in this case extends *SecureTestCluster*, so when *SecureTestCluster.setup* runs, it calls *HBaseKerberosUtils.setSSLConfiguration* passing its own class reference [here|https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/SecureTestCluster.java#L72]. ** *HBaseKerberosUtils.setSSLConfiguration*, in turn, calls *KeyStoreTestUtil.getClasspathDir* [here|https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java#L173]. *KeyStoreTestUtil.getClasspathDir* uses the passed class reference name to look for its related resource in the class loader. [This line|https://github.com/apache/hbase/blob/master/hbase-http/src/test/java/org/apache/hadoop/hbase/http/ssl/KeyStoreTestUtil.java#L58] returns an URL value as follows, when the passed class reference resource resides on jar file in the class loader (instead of being in a valid local FS path): {{jar:file:/Users/wellingtonchevreuil/.m2/repository/org/apache/hbase/hbase-server/2.2.3./hbase-server-2.2.3-tests.jar!/org/apache/hadoop/hbase/security/token/SecureTestCluster.class}} This causes [subsequent line|https://github.com/apache/hbase/blob/master/hbase-http/src/test/java/org/apache/hadoop/hbase/http/ssl/KeyStoreTestUtil.java#L59] calling {{url.toURI().getPath()}} to return null, then we get the NPE thrown in the following line, and the test errors out: {{java.lang.NullPointerException at org.apache.hadoop.hbase.http.ssl.KeyStoreTestUtil.getClasspathDir(KeyStoreTestUtil.java:59) at org.apache.hadoop.hbase.security.HBaseKerberosUtils.setSSLConfiguration(HBaseKerberosUtils.java:173) at org.apache.hadoop.hbase.security.token.SecureTestCluster.setUp(SecureTestCluster.java:74) at com.cloudera.hbase.security.token.TestCldrManualDelegationToken.setUp(TestCldrManualDelegationToken.java:168) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292) at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266) at java.util.concurrent.FutureTask.run(FutureTask.java) at java.lang.Thread.run(Thread.java:748}}" Procedure updating meta and Master shutdown are incompatible: CODE-BUG,13287924,Resolved,Major,Fixed,27/Feb/20 05:29,28/Feb/20 21:54,,"Chasing flakies, studying TestMasterAbortWhileMergingTable, I noticed a failure because {code:java} 2020-02-27 00:57:51,702 ERROR [PEWorker-6] procedure2.ProcedureExecutor(1688): CODE-BUG: Uncaught runtime exception: pid=14, state=RUNNABLE:MERGE_TABLE_REGIONS_UPDATE_META, locked=true; MergeTableRegionsProcedure table=test, regions=[48c9be922fa4356bfc7fc61b5b0785f3, ef196d5377c5c1d143e9a2a2ea056a9c], force=false java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@28b956c7 rejected from java.util.concurrent.ThreadPoolExecutor@639f20e5[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 5] at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2063) at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830) at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379) at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134) at org.apache.hadoop.hbase.client.HTable.coprocessorService(HTable.java:974) at org.apache.hadoop.hbase.client.HTable.coprocessorService(HTable.java:953) at org.apache.hadoop.hbase.MetaTableAccessor.multiMutate(MetaTableAccessor.java:1771) at org.apache.hadoop.hbase.MetaTableAccessor.mergeRegions(MetaTableAccessor.java:1637) at org.apache.hadoop.hbase.master.assignment.RegionStateStore.mergeRegions(RegionStateStore.java:268) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.markRegionAsMerged(AssignmentManager.java:1854) at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.updateMetaForMergedRegions(MergeTableRegionsProcedure.java:687) at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.executeFromState(MergeTableRegionsProcedure.java:229) at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.executeFromState(MergeTableRegionsProcedure.java:77) at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:194) at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:962) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1669) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1416) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:79) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1986) {code} A few seconds above, as part of the test, we'd stopped Master {code:java} 2020-02-27 00:57:51,620 INFO [Time-limited test] regionserver.HRegionServer(2212): ***** STOPPING region server 'rn-hbased-lapp01.rno.exampl.com,36587,1582765058324' ***** 2020-02-27 00:57:51,620 INFO [Time-limited test] regionserver.HRegionServer(2226): STOPPED: Stopping master 0 {code} The rejected execution damages the merge procedure. It shows as an unhandled CODE-BUG. Why we let a runtime exception out when trying to update meta is mildly interesting. We use Throwables.propagateIfPossible(e, IOException.{color:#000080}class{color}) from guava which at first blush would seem to throw the exception if it an IOE else return. In code, if return, we'll wrap whatever makes it through with an IOE.  But propagateIfPossible is a little sneaky in that if the passed Exception is a RuntimeException, as the Reject is, it will go ahead and throw and NOT return.  Not sure if this was authors' understanding ([~zhangduo]  ? HBASE-21789 for hbase-2.2.0). Looking at the old code, which called makeIOExceptionOfException from ProtobufUtil, if I read it right, this would wrap the exception in an IOE regardless whether a RuntimeException or not. A little digging exposes that likely root of the problem is that the Master is stopping. Its connection, which is used by the merge procedure when updating meta, is being shutdown too. The rejected exception is probably because the pool has been shutdown. Hard to tell for sure as Master doesn't log the minutae of services closed. The propagateIfPossible facility is used in a few places. Its addition to MetaTableAccessor is in one place only by HBASE-21789. I could restore the old behavior easy enough (Was afraid we had to deal with this issue around ALL meta table accesses via MTA).    " Backport HBASE-22040 to branch-2.1,13286361,Resolved,Major,Fixed,20/Feb/20 01:10,27/Feb/20 20:16,,This fix went in to 2.2+. But I feel like it's applicable and could be used in 2.1 as well. [Flakey Test] TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer,13288102,Resolved,Major,Invalid,27/Feb/20 17:06,28/Feb/20 00:06,,"{noformat} java.lang.AssertionError: Found unexpected number of snapshots expected:<2> but was:<1> at org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster.testGetCompletedSnapshotsWithCleanup(TestSnapshotFromMaster.java:313) {noformat}" [Flakey Test] TestQuotaObserverChoreRegionReports.testReportExpiration,13288101,Open,Major,,27/Feb/20 17:03,,3.0.0-alpha-1,"{noformat} at org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports.testReportExpiration(TestQuotaObserverChoreRegionReports.java:118) Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException: org.apache.hadoop.hbase.TableNotFoundException: hbase:quota at java.lang.Thread.getStackTrace(Thread.java:1559) at org.apache.hadoop.hbase.util.FutureUtils.setStackTrace(FutureUtils.java:130) at org.apache.hadoop.hbase.util.FutureUtils.rethrow(FutureUtils.java:145) at org.apache.hadoop.hbase.util.FutureUtils.get(FutureUtils.java:168) at org.apache.hadoop.hbase.client.TableOverAsyncTable.get(TableOverAsyncTable.java:180) at org.apache.hadoop.hbase.quotas.QuotaTableUtil.doGet(QuotaTableUtil.java:843) at org.apache.hadoop.hbase.quotas.QuotaTableUtil.getQuotas(QuotaTableUtil.java:162) at org.apache.hadoop.hbase.quotas.QuotaTableUtil.getQuotas(QuotaTableUtil.java:150) at org.apache.hadoop.hbase.quotas.QuotaTableUtil.getTableQuota(QuotaTableUtil.java:124) at org.apache.hadoop.hbase.quotas.MasterQuotaManager$4.fetch(MasterQuotaManager.java:276) at org.apache.hadoop.hbase.quotas.MasterQuotaManager.setQuota(MasterQuotaManager.java:467) at org.apache.hadoop.hbase.quotas.MasterQuotaManager.setTableQuota(MasterQuotaManager.java:272) at org.apache.hadoop.hbase.quotas.MasterQuotaManager.setQuota(MasterQuotaManager.java:160) at org.apache.hadoop.hbase.master.MasterRpcServices.setQuota(MasterRpcServices.java:1720) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:374) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {noformat}" No need to submit SplitTableRegionProcedure/MergeTableRegionsProcedure when split/merge is disabled,13285900,Resolved,Major,Fixed,18/Feb/20 06:54,26/Feb/20 07:00,,"Now even the split/merge is disabled, master will submit a SplitTableRegionProcedure, too. And rollback it when execute failed. I thought the split/merge switch is a cluster level swtich. Master can check it early and no need to submit SplitTableRegionProcedure/MergeTableRegionsProcedure when split/merge switch is disabled." Update GitHub PreCommit to post back incremental progress updates to PR,13287811,Open,Major,,26/Feb/20 18:02,,,"This is ""merely"" a quality of life issue, but I'm filing it as a ""Major"" because having it would increase contributor confidence in CI automation. GitHub provides some mechanism for build-bots to post details of the work they're performing on an PR. I've never used these APIs, but they appear to allow: # posting an initial update listing the checking being run # asynchronous updates of each check status as it completes # reporting the final check result as a vote on the PR. Let's see if we can wire these up, either as part of the pipeline or as part of Yetus. Ideally we can also hide the detailed results of these checks behind a UI that consolidates them behind a single summary, rather than having CI spam comments on issues over and over." [OpenTracing] Propagate trace context to server correctly,13282078,Resolved,Major,Duplicate,28/Jan/20 22:54,26/Feb/20 04:43,2.0.0-beta-1,"HBASE-18601 breaks trace propagation. Instead of fixing it for HTrace, we should fix it for OpenTracing." Remove Hadoop 2.8 support,13287626,Open,Major,,25/Feb/20 22:40,,,"See HADOOP-16880 for the details. It looks like the time to drop Hadoop 2.8 support. Create this jira as the placeholder for this task." Fix flaky TestSnapshotFromMaster in 1.x versions,13285852,Resolved,Major,Fixed,17/Feb/20 20:37,23/Feb/20 00:21,,"HBASE-23658 was about fixing this flakey ut in branch-2+. I think it can be backported to branch-1s as well. 18/30 times this test has failed in branch-1, 10/30 in 1.4 and 3/30 in 1.3." HBase Precommit builds are broken due to some docker/java issue.,13286920,Open,Major,,22/Feb/20 00:08,,,For example see: https://builds.apache.org/view/H-L/view/HBase/job/PreCommit-HBASE-Build/1136/console "[Flakey Test] TestStochasticLoadBalancerRegionReplicaHighReplication ""Two or more region replicas are hosted on the same host after balance""",13286354,Resolved,Major,Fixed,20/Feb/20 00:05,20/Feb/20 16:37,,Make the calculation less ambitious so we pass more regularly. This is doing same trick as was done in parent and it seems good now.. hopefully this one too. [Flakey Test] TestGenerateDelegationToken; Master not initialized after 200000ms,13286294,Resolved,Major,Fixed,19/Feb/20 18:17,19/Feb/20 23:51,,"This one was complaint about Master not initializing. Happened twice in a row on local run. Looking the in the .txt and -output.txt was no help but when I looked in the xml, I found this complaint: {code} org.apache.hadoop.hbase.ClockOutOfSyncException: Server localhost,53153,1582096705773 has been rejected; Reported time is too far out of sync with master. Time difference of 44964ms > max allowed of 30000ms {code} Indeed, RS is initialized then does its kerberos stuff and there is a big pause of almost 45 seconds. For now, let me up tolerance for all tests derived from SecureTestCluster" Upgrade hbase-thirdparty to 3.2.0 to match hbase master branch,13286256,Resolved,Major,Not A Problem,19/Feb/20 15:11,20/Feb/20 07:21,connector-1.0.0, "Update CI Nightly ""packaging and integration"" to use the new RM tools",13286280,Open,Major,,19/Feb/20 17:08,,,"Our nightly build does some validations designed to ""mimic the actions of a release manager"". Since the ""actions of a release manager"" are codified in a utility, let's use that utility (and it's isolated docker environment) instead of replicating part of the logic in the CI script." Revert optimized IO back to general compaction during upgrade/migration process ,13285402,Resolved,Major,Feedback Received,14/Feb/20 18:42,19/Feb/20 21:32,,"Optimized mode IO compaction may leave old MOB file, which size is above threshold as is and don't compact it." Fix flaky TestSnapshotFromMaster,13278044,Resolved,Major,Fixed,08/Jan/20 00:57,10/Jan/20 09:20,,"testAsyncSnapshotWillNotBlockSnapshotHFileCleaner is flaky.  The assert may fail. {code:java} assertTrue(master.getSnapshotManager().isTakingAnySnapshot()); future.get(); // in branch-2.2, here is Thread.sleep assertFalse(master.getSnapshotManager().isTakingAnySnapshot()); {code} See [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.cleaner/TestSnapshotFromMaster/testAsyncSnapshotWillNotBlockSnapshotHFileCleaner/]   [https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2.2/lastSuccessfulBuild/artifact/dashboard.html]" [Flakey Test] TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91) Wrong FS!,13284092,Resolved,Major,Fixed,08/Feb/20 19:06,12/Feb/20 17:40,,"Can't repro locally w/o running with lots of parallelism. Follow-on from parent issue. Here is error: {code} [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 115.741 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster [ERROR] org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState Time elapsed: 74.459 s <<< ERROR! java.lang.IllegalArgumentException: Wrong FS: file:/Users/stack/checkouts/hbase.apache.git/hbase-mapreduce/target/test-data/fad01338-65ef-e973-2412-05de114016fe/.hbase-snapshot/tableWithRefsV2, expected: hdfs://localhost:58051 at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:107) at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91) {code} With v1 had just run find which does same thing." Remove unused hadoop.guava.version from pom.xml,13284567,In Progress,Major,,11/Feb/20 12:34,,,"11.0.2 is still used in hbase-backup, I missed it at first... So, this should be either updated or removed. Checking which is feasible... Update: So even if I remove hadoop.guava.version, with hadoop-2 profile, 11.0.2 will be used during the build, and it will be on the classpath. Since hadoop only upgraded to guava 27.0 in hadoop-3, I'm not sure what we can do here. hadoop-2 is incompatible with guava 2x.x versions. " Fix NPE when disable DeadServerMetricRegionChore ,13278972,Resolved,Major,Fixed,13/Jan/20 02:23,09/Feb/20 05:19,2.2.3,"set hbase.assignment.dead.region.metric.chore.interval.msec = -1 {code} 2020-01-13 10:35:46,247 ERROR [master/10.89.25.45:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.NullPointerException at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.addChore(ProcedureExecutor.java:736) at org.apache.hadoop.hbase.master.assignment.AssignmentManager.joinCluster(AssignmentManager.java:1381) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1101) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2223) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:605) at java.lang.Thread.run(Thread.java:748) {code}" (2.1) Helper method to configure secure DFS cluster for tests,13282087,Resolved,Major,Fixed,29/Jan/20 00:13,09/Feb/20 09:13,,Let's get [~weichiu]'s HBASE-20950 onto branch-2.1. It will make the backport for HBASE-17115 that much easier. Increase maven heap allocation to 4G in Yetus personality,13283285,Resolved,Major,Fixed,04/Feb/20 16:59,05/Feb/20 22:38,2.3.0,"I saw this over on [https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2/2447/console]. Looks like we need to bump the memory allocation for maven. I wonder if this is the underlying cause of HBASE-22470.   {noformat} 6:38:47 ============================================================================ 16:38:47 ============================================================================ 16:38:47 Finished build. 16:38:47 ============================================================================ 16:38:47 ============================================================================ 16:38:47 16:38:47 Post stage [Pipeline] stash 16:38:48 Warning: overwriting stash 'hadoop2-result' 16:38:48 Stashed 1 file(s) [Pipeline] junit 16:38:48 Recording test results 16:38:54 Remote call on H2 failed Error when executing always post condition: java.io.IOException: Remote call on H2 failed at hudson.remoting.Channel.call(Channel.java:963) at hudson.FilePath.act(FilePath.java:1072) at hudson.FilePath.act(FilePath.java:1061) at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114) at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137) at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167) at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52) at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25) at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.OutOfMemoryError: Java heap space at com.sun.org.apache.xerces.internal.util.XMLStringBuffer.append(XMLStringBuffer.java:208) at com.sun.org.apache.xerces.internal.impl.XMLEntityScanner.scanData(XMLEntityScanner.java:1515) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanCDATASection(XMLDocumentFragmentScannerImpl.java:1654) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3014) at com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602) at com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112) at com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:842) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:771) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:643) at org.dom4j.io.SAXReader.read(SAXReader.java:465) at org.dom4j.io.SAXReader.read(SAXReader.java:343) at hudson.tasks.junit.SuiteResult.parse(SuiteResult.java:178) at hudson.tasks.junit.TestResult.parse(TestResult.java:348) at hudson.tasks.junit.TestResult.parsePossiblyEmpty(TestResult.java:281) at hudson.tasks.junit.TestResult.parse(TestResult.java:206) at hudson.tasks.junit.TestResult.parse(TestResult.java:178) at hudson.tasks.junit.TestResult.(TestResult.java:143) at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:146) at hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:118) at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3052) at hudson.remoting.UserRequest.perform(UserRequest.java:212) at hudson.remoting.UserRequest.perform(UserRequest.java:54) at hudson.remoting.Request$2.run(Request.java:369) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) ... 4 more [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // node [Pipeline] } [Pipeline] // stage [Pipeline] } 16:38:54 Failed in branch yetus jdk8 hadoop2 checks {noformat}" [hbase-thirdparty] Change pom version from 3.1.2-SNAPSHOT to 3.2.0-SNAPSHOT,13280899,Resolved,Major,Fixed,22/Jan/20 04:29,22/Jan/20 21:03,thirdparty-3.2.0, ExecutorService ignores Throwables,13283548,Open,Major,,05/Feb/20 18:53,,2.3.0,"From the [test logs|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2451/testReport/junit/org.apache.hadoop.hbase.mapred/TestTableMapReduce/health_checks___yetus_jdk8_hadoop2_checks___/] of a failed build, I find that the {{ExecutorService}} running in the region server appears to ignore exceptions thrown in its executor's tasks. In this case, a fatal {{RuntimeException}} was thrown. Instead of aborting the RS, we merely log. This results in the region open operation never completing, and the test simply hangs. This implementation is ancient, dating back to HBASE-4281 or before, circa 2011. Thus I assume it impacts all active release lines. {noformat} 2020-02-05 07:45:53,361 FATAL [RS_OPEN_REGION-regionserver/e590165b0ef0:0-1] conf.Configuration(2859): error parsing conf hbase-site.xml org.xml.sax.SAXParseException; systemId: file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-classes/hbase-site.xml; lineNumber: 1; columnNumber: 1; Premature end of file. at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:257) at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:339) at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:150) at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2684) at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672) at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746) at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706) at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579) at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091) at org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145) at org.apache.hadoop.conf.Configuration.getBoolean(Configuration.java:1550) at org.apache.hadoop.hbase.HBaseConfiguration.checkDefaultsVersion(HBaseConfiguration.java:70) at org.apache.hadoop.hbase.HBaseConfiguration.addHbaseResources(HBaseConfiguration.java:84) at org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:98) at org.apache.hadoop.hbase.util.LossyCounting.(LossyCounting.java:84) at org.apache.hadoop.hbase.regionserver.MetricsUserAggregateImpl.(MetricsUserAggregateImpl.java:45) at org.apache.hadoop.hbase.regionserver.MetricsUserAggregateFactory.getMetricsUserAggregate(MetricsUserAggregateFactory.java:35) at org.apache.hadoop.hbase.regionserver.MetricsRegion.(MetricsRegion.java:40) at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:849) at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:730) at sun.reflect.GeneratedConstructorAccessor23.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:7135) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7352) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7329) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7287) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7238) at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:133) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} " "Backport ""HBASE-23601 OutputSink.WriterThread exception gets stuck and repeated indefinietly"" to branch-2.2",13282364,Resolved,Major,Fixed,30/Jan/20 12:04,30/Jan/20 12:11,2.2.4, [Flakey Tests] TestSplitTransactionOnCluster,13281448,Resolved,Major,Fixed,24/Jan/20 18:05,24/Jan/20 20:00,,"TestSplitTransactionOnCluster fails 80% of time in the GCE run up on https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/branch-2/lastSuccessfulBuild/artifact/dashboard.html We want to run a compaction to clear up references but logic doesn't handle case where compaction already running." Add CellComparator to HFileContext,13280214,Resolved,Major,Fixed,17/Jan/20 20:00,29/Jan/20 18:58,,"The HFileContext is present when reading and writing files. It is populated at read time using HFile trailer content and file metadata. At write time, we create it up front. Interesting is that though CellComparator is written to the HFile trailer, and parse of the Trailer creates an HFileInfo which builds the HFileContext at read time, the HFileContext does not expose what CellComparator to use decoding and seeking. Around the codebase there are various compensations made for this lack with decoders that actually have a decoding context (with a reference to the hfilecontext), hard-coding use of the default CellComparator. StoreFileInfo will use default if not passed a comparator (even though we'd just read the trailer and even though it has reference to filecontext) and HFile does similar. What CellComparator to use in a given context is confused. Let me fix this situation removing ambiguity. It will also fix bugs in parent issue where UTs are failing because wrong CellComparator is being used." Support Point-In-Time Queries,13282250,Open,Major,,29/Jan/20 18:51,,,"HBase currently offers a snapshot feature which allows operators to capture the state of a table at a point in time in a way that can be cloned or queried in the future. It's quite useful in some circumstances, but limited because it's a heavyweight operation, and because it requires prior knowledge of the time you want to capture. Phoenix currently offers a feature called ""SCN"", which uses the max timestamp on Scans to provide the illusion of a ""lookback"" query at a point in time. It's imperfect, however, because of HBase's filtering and cleanup logic for deletes, max versions and TTLs can prevent users from seeing certain Cells they would have been able to see at a previous point in time. Even PHOENIX-5645, and the equivalent HBASE-23602, which try to control major compaction cleanup, don't cover all edge cases completely. (For example, you can't see rows whose TTL has expired now but hadn't back then. Same with max versions.) There are useful non-Phoenix applications as well, such as a change stream that shows before/after images, as DynamoDB offers. Since full support will require new configuration options added not just to major compaction, but also to the read pipeline, I'm filing this as an umbrella JIRA so we can have smaller sub-tasks, rather than trying to cram everything into HBASE-23602. " fix flaky TestSplitTransactionOnCluster,13278441,Resolved,Major,Duplicate,09/Jan/20 12:32,28/Jan/20 15:42,,"testShutDownFixupWhenDaughterHasSplit is flaky.  I had a look at it, it fails because the compaction isn't ready when the assertion is called. The function HRegion.compact() has a comment that it can block for a long time, do not use it for a time-sensitive thread.    edit: also found a weird debug message, it can also be a problem:  {{compactions.SortedCompactionPolicy(231): Not compacting files because we only have 0 files ready for compaction. Need 3 to initiate.}}  " [Flakey Tests] TestFavoredNodeTableImport fails 30% of the time,13281517,Resolved,Major,Fixed,25/Jan/20 01:38,26/Jan/20 18:47,,"Spent time on TestFavoredNodeTableImport. It fails w/ an NPE when we go to get favorednodes for one of the regions. It is sporadic. Fails for me locally too about 30% of the time. I tried to study where we are going wrong. The balancer is disabled when we start the cluster up again on FN balancer... but this don't seem to be the problem. Looks like laggard Regions taking their time to open means they don't show in the global list of favored nodes when the checking runs. Adding a wait till no RIT seems to stabilize the test." Optimize Memstore Flush for Hbase on S3(Object Store),13281315,Open,Major,,24/Jan/20 01:04,,,"The current Memstore Flush Process is divided into 2 stages: # Flushcache: In this stage, a “.tmp” region file is written in S3/HDFS for the memstore; # Commit: In this stage, the “.tmp” file created in the stage 1 is renamed to final destination of HBase region file. The above design(flush and commit) is OK for HDFS because “rename” is light opertion(only metadata operation). However, for storage like S3 or other object store, rename is “copy” and “delete” operation. We can follow the same pattern from V2 of  “FileOutputCommitter” in MapReduce. That means, we can write hfile directly to the S3 destination directory without “copy” and “paste”. So that we can have less S3 operations and the HBase memstore flush is more efficient." Make HBaseInterClusterReplicationEndpoint more extensible,13279057,Resolved,Major,Fixed,13/Jan/20 11:47,24/Jan/20 15:18,,"*HBaseInterClusterReplicationEndpoint* currently creates the cluster connection and sink manager instances inside its _init_ method and assigns those to private class variables. Then any potential custom extension of *HBaseInterClusterReplicationEndpoint* that requires custom implementations of connection and/or sink manager would need to resort to _java reflection_ for effectively replace those instances, such as below: {noformat} ... ClusterConnection conn = (ClusterConnection)ConnectionFactory. createConnection(context.getConfiguration(), User.create(replicationUgi)); ReplicationSinkManager sinkManager = new ReplicationSinkManager(conn, ctx.getPeerId(), this, context.getConfiguration()); try { Field field = this.getClass().getSuperclass().getDeclaredField(""conn""); field.setAccessible(true); field.set(this, conn); field = this.getClass().getSuperclass().getDeclaredField(""replicationSinkMgr""); field.setAccessible(true); field.set(this, sinkManager); } catch (Exception e) { throw new IOException(e); } ... {noformat}" TestCustomSaslAuthenticationProvider failing in nightlies,13281102,Resolved,Major,Fixed,23/Jan/20 02:47,23/Jan/20 21:43,,"{noformat} 2020-01-22 21:15:57,250 DEBUG [hconnection-0x5f0ea4c6-metaLookup-shared--pool15-t14] client.RpcRetryingCallerImpl(132): Call exception, tries=10, retries=16, started=38409 ms ago, cancelled=false, msg=Call to a8b44f950ced/172.17.0.3:42595 failed on local exception: java.io.IOException: java.lang.NullPointerException, details=row 'testPositiveAuthentication,r1,99999999999999' on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=a8b44f950ced,42595,1579726988645, seqNum=-1, see https://s.apache.org/timeout, exception=java.io.IOException: Call to a8b44f950ced/172.17.0.3:42595 failed on local exception: java.io.IOException: java.lang.NullPointerException at sun.reflect.GeneratedConstructorAccessor40.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:220) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:378) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:91) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:409) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:405) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:117) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:132) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:422) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:316) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$200(AbstractRpcClient.java:91) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:571) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$BlockingStub.scan(ClientProtos.java:42810) at org.apache.hadoop.hbase.client.ScannerCallable.openScanner(ScannerCallable.java:332) at org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:242) at org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:58) at org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:396) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:370) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107) at org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException: java.lang.NullPointerException at org.apache.hadoop.hbase.ipc.IPCUtil.toIOE(IPCUtil.java:154) ... 17 more Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.security.provider.BuiltInProviderSelector.selectProvider(BuiltInProviderSelector.java:128) at org.apache.hadoop.hbase.security.provider.TestCustomSaslAuthenticationProvider$InMemoryProviderSelector.selectProvider(TestCustomSaslAuthenticationProvider.java:390) at org.apache.hadoop.hbase.security.provider.SaslClientAuthenticationProviders.selectProvider(SaslClientAuthenticationProviders.java:214) at org.apache.hadoop.hbase.ipc.RpcConnection.(RpcConnection.java:106) at org.apache.hadoop.hbase.ipc.BlockingRpcConnection.(BlockingRpcConnection.java:219) at org.apache.hadoop.hbase.ipc.BlockingRpcClient.createConnection(BlockingRpcClient.java:72) at org.apache.hadoop.hbase.ipc.BlockingRpcClient.createConnection(BlockingRpcClient.java:38) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.getConnection(AbstractRpcClient.java:350) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:419) ... 16 more {noformat} Figure out what's goin on." [branch-1 backport] Periodic bump for Sep2019,13281249,Open,Major,,23/Jan/20 17:29,,,This issue is about backporting update to dependencies for branch-1. [create-release] Update yetus version used from 0.11.0 to 0.11.1,13281099,Resolved,Major,Fixed,23/Jan/20 01:58,23/Jan/20 02:09,,Update the yetus version used by the create-release scripts. Was pointing to 0.11.0 but that is no longer in apache repo so the create-release fails. Add 1.5.0 release to Downloads,13280959,Resolved,Major,Fixed,22/Jan/20 11:52,22/Jan/20 14:47,,Add 1.5.0 release to the Download page. Add further constraint on edits to hbase:meta to prevent possibly damaging edits,13281100,Open,Major,,23/Jan/20 02:17,,,"HBASE-23055 Alter hbase:meta enables editing hbase:meta in hbase-2.3.0. The patch includes constraint that prevents an operator accidentally deleting a critical column family. This issue is about adding further constraints to prevent possibly damaging configs. Per [~zhangduo], operator ""...should not set TTL on the column families, and also, you should not change the versions of REPLICATION_BARRIER_FAMILY...""" "[hbase-thirdparty] Update libs; pb from 3.9 to 3.11, etc.",13280900,Resolved,Major,Fixed,22/Jan/20 04:40,22/Jan/20 21:08,, RegionProcedureStore missing cleaning of hfile archive,13278821,Resolved,Major,Fixed,11/Jan/20 00:13,18/Jan/20 12:59,2.3.0,"See tail of parent issue. The new RegionProcedureStore accumulates deleted hfiles in its local archive dir. Needs a cleaner like the one that watches over /hbase/archive. Is there a problem clearning the new $masterproc$ files from the oldWALs too? These seem to stick around also." ByteBuff may not recycle correctly when NettyRpcServer enabled and client disconnect,13279813,Open,Major,,16/Jan/20 12:21,,,"Code in NettyRpcServerResponseEncoder {code:java} @Override public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) throws Exception { if (msg instanceof RpcResponse) { RpcResponse resp = (RpcResponse) msg; BufferChain buf = resp.getResponse(); ctx.write(Unpooled.wrappedBuffer(buf.getBuffers()), promise).addListener(f -> { resp.done(); if (f.isSuccess()) { metrics.sentBytes(buf.size()); } }); } else { ctx.write(msg, promise); } } {code} If exception occurs during ChannelHandlerContext#write (such as Client disconnected), ByteBuff may not be recycled correctly." Add HBase 2.2.3 documentation to website,13280099,Resolved,Major,Fixed,17/Jan/20 09:45,17/Jan/20 15:31,2.2.3,The website does not have documentation of HBase 2.2 release. Update checkstyle plugin (and update checkstyle.xml to match),13280248,Resolved,Major,Duplicate,17/Jan/20 22:54,18/Jan/20 00:18,,"In parent issue, its suggested we update our checkstyle plugin to match of intellij plugin default at least. Will need checkstyle.xml changes else it fails parse (See notes in parent by [~bharathv] on what needs doing). For extra points, do the [~ndimiduk] suggestion: ""...It would be nice also if we could commit the .idea/checkstyle-idea.xml file with the checkstyle version used buy the plugin pinned to the same version as we're using in maven.""" "After RegionProcedureStore completes migration of WALProcedureStore, still running WALProcedureStore.syncThread keeps trying to delete now inexistent log files. ",13279628,Resolved,Major,Fixed,15/Jan/20 16:55,16/Jan/20 06:27,3.0.0-alpha-1,"With the introduction of the new procedure store to save procs on a table, instead of proc WALs, we added some migration logic to enable a smooth upgrade of clusters under previous versions that used to have proc wal files as the underlying procedure store. While running a fresh install with latest master branch version, I had noticed that once the old _WALProcedureStore_ directory is detected, it creates and start a WPS instance [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L311], passing a built-in _ProcedureLoader_ [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L315] to perform the conversion from proc wal files to table based. At the end of this conversion, the builtin loader deletes the proc wal dir [here|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java#L363]. This may cause a race condition where a running _WALProcedureStore_ internal thread may be trying to delete the first proc wal file that may had already rolled, then failing with FNFE. Even worse is that _WALProcedureStore.syncLoop_ keeps trying indefinitely, flooding Master logs with messages such as below: {noformat} 2020-01-14 06:13:23,331 INFO [master/hbase01:16000:becomeActiveMaster] region.RegionProcedureStore: The old WALProcedureStore wal directory file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs exists, migrating... 2020-01-14 06:13:23,361 DEBUG [master/hbase01:16000:becomeActiveMaster] wal.WALProcedureStore: Starting WAL Procedure Store lease recovery 2020-01-14 06:13:23,453 INFO [master/hbase01:16000:becomeActiveMaster] wal.WALProcedureStore: Rolled new Procedure Store WAL, id=1 2020-01-14 06:13:23,454 DEBUG [master/hbase01:16000:becomeActiveMaster] wal.WALProcedureStore: Lease acquired for flushLogId=1 2020-01-14 06:13:23,454 DEBUG [master/hbase01:16000:becomeActiveMaster] wal.WALProcedureStore: No state logs to replay. 2020-01-14 06:13:23,454 INFO [master/hbase01:16000:becomeActiveMaster] region.RegionProcedureStore: The WALProcedureStore max pid is 0, and the max pid of all loaded procedures is -1 2020-01-14 06:13:23,455 INFO [master/hbase01:16000:becomeActiveMaster] region.RegionProcedureStore: Migration of WALProcedureStore finished 2020-01-14 06:13:23,455 INFO [master/hbase01:16000:becomeActiveMaster] procedure2.ProcedureExecutor: Recovered RegionProcedureStore lease in 784 msec 2020-01-14 06:13:23,471 TRACE [WALProcedureStoreSyncThread] wal.WALProcedureStore: no active procedures 2020-01-14 06:13:23,516 INFO [master/hbase01:16000:becomeActiveMaster] procedure2.ProcedureExecutor: Loaded RegionProcedureStore in 61 msec 2020-01-14 06:13:23,516 INFO [master/hbase01:16000:becomeActiveMaster] procedure2.RemoteProcedureDispatcher: Instantiated, coreThreads=128 (allowCoreThreadTimeOut=true), queueMaxSize=32, operationDelay=150 2020-01-14 06:13:23,628 INFO [WALProcedureStoreSyncThread] wal.WALProcedureStore: Rolled new Procedure Store WAL, id=2 2020-01-14 06:13:23,634 INFO [WALProcedureStoreSyncThread] wal.WALProcedureStore: Remove all state logs with ID less than 1, since no active procedures 2020-01-14 06:13:23,634 TRACE [WALProcedureStoreSyncThread] wal.WALProcedureStore: Removing log=file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log 2020-01-14 06:13:23,634 INFO [WALProcedureStoreSyncThread] wal.ProcedureWALFile: Archiving file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log to file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/oldWALs/pv2-00000000000000000001.log 2020-01-14 06:13:23,634 ERROR [WALProcedureStoreSyncThread] wal.WALProcedureStore: Unable to remove log: file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log java.io.FileNotFoundException: File file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log does not exist ... 2020-01-14 06:13:23,635 ERROR [WALProcedureStoreSyncThread] wal.WALProcedureStore: Unable to remove log: file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log java.io.FileNotFoundException: File file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log does not exist at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:635) ... 2020-01-14 06:13:37,352 ERROR [WALProcedureStoreSyncThread] wal.WALProcedureStore: Unable to remove log: file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log java.io.FileNotFoundException: File file:/root/hbase-3.0.0-SNAPSHOT/hbase-data/MasterProcWALs/pv2-00000000000000000001.log does not exist at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:635) {noformat} I believe a simple solution in this case is to explicitly call _WALProcedureStore.stop_ method at the end of the migration, which stops _WALProcedureStore_ internal _syncLoop_ thread.  Am opening a PR soon." Add 2.2.3 to download page,13279531,Resolved,Major,Fixed,15/Jan/20 08:45,15/Jan/20 09:50,, Replace HColumnDescriptor(String cf) with ColumnFamilyDescriptor,13278133,Resolved,Major,Fixed,08/Jan/20 10:47,16/Jan/20 02:48,3.0.0-alpha-1,"We have deprecated HColumnDescriptor and HTableDescriptor some time back in 2.0.0. Although there are many use-cases still using them, we can start replacing them with builder pattern: ColumnFamilyDescriptorBuilder and TableDescriptorBuilder. In an attempt to do so, starting with replacing specific constructor of HColumnDescriptor: {code:java} public HTableDescriptor(final TableName name) { this(new ModifyableTableDescriptor(name)); } {code}" Set version as 2.2.4-SNAPSHOT in branch-2.2,13279532,Resolved,Major,Fixed,15/Jan/20 08:46,15/Jan/20 08:54,, Set version to 2.2.3 in branch-2.2 for first RC of 2.2.3,13277358,Resolved,Major,Fixed,03/Jan/20 11:42,15/Jan/20 08:47,, Generate CHANGES.md and RELEASENOTES.md for 2.2.3,13277356,Resolved,Major,Fixed,03/Jan/20 11:38,15/Jan/20 08:47,, indicates a last flushed sequence id ... that is less than the previous last flushed sequence id,13279226,Open,Major,,14/Jan/20 00:11,,2.3.0,"I'm getting loads of the below in Master log running tests against branch-2. It is heavily loaded but generally keeping up though there is backlog in WAL files.... > 32 ... around the cluster so forced flushes happening. I'll see the below for a Region even though it seems like we've since flushed out a sequenceid on the RS-side that is larger than what the Master is seeing. Two column family table. {code} 2020-01-13 23:33:18,455 WARN org.apache.hadoop.hbase.master.ServerManager: RegionServer hbasedn030.sp07.siri.apple.com,16020,1578934813139 indicates a last flushed sequence id (1593644) that is less than the previous last flushed sequence id (1593649) for region t1,f9371d5,1576227377175. 3e41deae849d25f0a2f1d654f482d73a. Ignoring. {code} " Add UT for procedure store region flusher,13278861,Resolved,Major,Fixed,11/Jan/20 12:42,12/Jan/20 05:33,, BaseLoadBalancer#wouldLowerAvailability should consider region replicas,13278090,Resolved,Major,Fixed,08/Jan/20 08:30,10/Jan/20 09:19,,"Found this issue when try to fix the flaky unit test  TestRegionReplicaSplit. It may fail as  java.lang.AssertionError: Splitted regions should not be assigned to same region server. See [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.assignment/TestRegionReplicaSplit/testRegionReplicaSplitRegionAssignment/].   Now  wouldLowerAvailability method only consider the primary regions. The replica region can't assign to same server with primary region. But can be assigned to same server with other replica regions.   " Fix flaky TestRSGroupsKillRS: should wait the SCP to finish,13277913,Resolved,Major,Fixed,07/Jan/20 12:17,10/Jan/20 09:19,2.2.2,"In teardownAfterMethod, it will moveTables and delete RSGroups. It will fail if not wait SCP to finish.    " "Master log start filling with ""Flush journal status"" messages",13278390,Resolved,Major,Fixed,09/Jan/20 07:27,10/Jan/20 18:29,,"Takes a while to get into this condition. Not each to tell how because all logs have rolled off and I only have logs filled w/ below: {code} 2020-01-09 07:01:01,723 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush status journal: Acquiring readlock on region at 1578553261723 Flush successful flush result:CANNOT_FLUSH_MEMSTORE_EMPTY, failureReason:Nothing to flush,flush seq id45226854 at 1578553261723 2020-01-09 07:01:01,723 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush status journal: Acquiring readlock on region at 1578553261723 Flush successful flush result:CANNOT_FLUSH_MEMSTORE_EMPTY, failureReason:Nothing to flush,flush seq id45226855 at 1578553261723 2020-01-09 07:01:01,723 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush status journal: Acquiring readlock on region at 1578553261723 Flush successful flush result:CANNOT_FLUSH_MEMSTORE_EMPTY, failureReason:Nothing to flush,flush seq id45226856 at 1578553261723 2020-01-09 07:01:01,723 DEBUG org.apache.hadoop.hbase.regionserver.HRegion: Flush status journal: Acquiring readlock on region at 1578553261723 Flush successful flush result:CANNOT_FLUSH_MEMSTORE_EMPTY, failureReason:Nothing to flush,flush seq id45226857 at 1578553261723 {code} ... I added the printing of flushresult... i.e. cannot flush because store is empty. Digging." "Please add Apache Trafodion and EsgynDB to ""Powered by Apache HBase"" page",13277794,Resolved,Major,Fixed,06/Jan/20 22:40,09/Jan/20 16:08,,"Please add the following two entries to the web page ""Powered By Apache HBase™"" ([https://hbase.apache.org/poweredbyhbase.html]): Trafodion (link [https://trafodion.apache.org/])  Apache Trafodion(TM) is a webscale SQL-on-Hadoop solution enabling transactional or operational workloads. It uses HBase as its storage engine for SQL tables. EsgynDB (link [https://esgyn.com/]) EsgynDB, powered by Apache Trafodion(TM), provides enterprise SQL on Hadoop. It includes full ACID transactions, online transaction processing and online analytic processing, along with enterprise features such as disaster recovery and full backup/restore. Native tables are stored in HBase, but read and write access to various other file formats such as Apache Parquet and ORC is also supported. " "Backport ""HBASE-23660 hbase:meta's table.jsp ref to wrong rs address"" to branch-2",13278341,Resolved,Major,Fixed,09/Jan/20 02:38,09/Jan/20 09:26,2.2.2, Region balance throttling can be disabled,13277643,Resolved,Major,Fixed,06/Jan/20 07:51,08/Jan/20 11:08,2.2.3,"HBASE-17178 Add region balance throttling, but it can not be disabled, sometimes we need no throttle and balance the cluster as fast as possible." org.apache.hadoop.hbase.ipc.RpcServer.Listener#closeCurrentConnection did not close the connection properly,13278625,Open,Major,,10/Jan/20 06:54,,1.4.12,"The connection is attached to readKey, but the parameter passed into the closeCurrentConnection is acceptedKey. branch-2 is fixed in HBASE-15948, though 2.0+ already uses netty." 350+ lossy-count threads running,13278560,Open,Major,,10/Jan/20 00:13,,2.3.0,"Looking at a server under load (branch-2), I see 350 instances of lossy-count threads running. They look like this: {code} 8611 ""lossy-count-0"" #11672 daemon prio=5 os_prio=0 cpu=0.09ms elapsed=281.33s tid=0x00007f1baee76800 nid=0x2411 waiting on condition [0x00007f1b78793000] 8612 java.lang.Thread.State: WAITING (parking) 8613 at jdk.internal.misc.Unsafe.park(java.base@11.0.4/Native Method) 8614 - parking to wait for <0x00000000910a91e0> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) 8615 at java.util.concurrent.locks.LockSupport.park(java.base@11.0.4/LockSupport.java:194) 8616 at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(java.base@11.0.4/AbstractQueuedSynchronizer.java:2081) 8617 at java.util.concurrent.LinkedBlockingQueue.take(java.base@11.0.4/LinkedBlockingQueue.java:433) 8618 at java.util.concurrent.ThreadPoolExecutor.getTask(java.base@11.0.4/ThreadPoolExecutor.java:1054) 8619 at java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@11.0.4/ThreadPoolExecutor.java:1114) 8620 at java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@11.0.4/ThreadPoolExecutor.java:628) 8621 at java.lang.Thread.run(java.base@11.0.4/Thread.java:834) {code} Why we need 350 threads?" Implement an adaptive hedging policy ,13277611,Open,Major,,06/Jan/20 02:31,,3.0.0-alpha-1,"HBASE-23305 implements a new rpc channel that can hedge requests to multiple target end points. As [~andrew.purtell@gmail.com] noted in the code review, it makes more sense to have a pluggable hedging policy and make it adaptive based on certain rpc performance/success metrics. By default, the implementation hedges the requests across 'n' target addresses. However in most cases, for smaller rpcs, the first 1 or 2 end points should return the results pretty quickly and there is no point in hedging with a bigger fan out as that only increases the load on the target servers. The idea is to increase the fan out only when needed. A naive way is to double the fan out at each attempt (starting from 1) until we reach the configured max fan out. For example if the max fan out is 10, instead of bursting to all 10 in each attempt, we fan out with values 1, 2, 4, 8, 10, 10, 10... Any suggestions welcome." Upgrade to JUnit 5,13278524,Open,Major,,09/Jan/20 19:38,,,JUnit 4 has probably seen it's last release. It's time to [migrate|https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4] over to JUnit5. How to improve replication performance.,13278382,Open,Major,,09/Jan/20 06:46,,,"Inside the Replication function, when the sink node is selected as the source node, a node is randomly selected as the sink node. This presents a problem: the selected node has a relatively large replication traffic of its own, which increases the stress of node processing. To solve this problem, as a sink node, you can set up the flow control, which of course is for Replication. At the node of the sink end of the source end, the node with high flow can be filtered out and the node with low pressure can be selected by virtue of the flow control." Use ReplicationPeerConfig.needToReplicate in HBaseFsck,13277373,Resolved,Major,Fixed,03/Jan/20 13:43,08/Jan/20 12:32,hbase-operator-tools-1.1.0,ReplicationUtils.contains method was removed in HBASE-23345. HBCK2 used this method so it needs to be changed to ReplicationPeerConfig.needToReplicate. AsyncAdmin does not throw table operation exceptions,13278000,Resolved,Major,Invalid,07/Jan/20 19:52,08/Jan/20 03:01,,{{AsyncAdmin}} does not propagate table operation exceptions back to the caller. Reintroduce ReplicationUtils.contains as deprecated,13277380,Resolved,Major,Fixed,03/Jan/20 14:32,04/Jan/20 11:23,2.1.9,"ReplicationUtils.contains was removed in HBASE-23345. This is an IA.Private class but HBCK2 relied on this method. The plan is to add back the method as deprecated and also move HBCK2 off of this to the new ReplicationPeerConfig#needToReplicate(TableName) instead (HBASE-23641).  " Remove deprecated isLegalFamilyName(byte[]) from HColumnDescriptor,13285175,Resolved,Minor,Fixed,13/Feb/20 19:24,16/Feb/20 20:53,3.0.0-alpha-1,{{isLegalFamilyName(byte[])}} in HColumnDescriptor was deprecated back in 2.0.0 and should be removed for 3.0.0. The Jetty's version number leak occurred while using the thrift service,13294133,Resolved,Minor,Fixed,26/Mar/20 08:21,06/Oct/20 00:38,2.0.1,"When the port is checked with curl -I host:port, the version number of jetty is displayed. To be safe, jetty's version number should be blocked." [MERGETOOL] HBASE Support Merge region by pattern,13277928,Patch Available,Minor,,07/Jan/20 13:40,,,"Design Objective: # Merge empty region # Neat region # merge expired region Usage: bin/hbase onlinemerge [--tableName=] [--startRegion=] [--stopRegion=] [--maxRegionSize=] [--maxRegionCreateTime=] [--numMaxMergePlans=] [--targetRegionCount=] [--printExecutionPlan=] [--configMergePauseTime=] Options: --h or --h print help --tableName table name must be not null --startRegion start region --stopRegion stop region --maxRegionSize max region size Unit GB --maxRegionCreateTime max Region Create Time yyyy/MM/dd HH:mm:ss --numMaxMergePlans num MaxMerge Plans --targetRegionCount target Region Count --configMergePauseTime config Merge Pause Time In milliseconds --printExecutionPlan Value default is true print execution plans false is execution merge Examples: bin/hbase onlinemerge --tableName=test:test1 --startRegion=test:test1,,1576835912332.01d0d6c2b41e204104524d9aec6074fb. --stopRegion=test:test1,bbbbbbbb,1573044786980.0c9b5bd93f3b19eb9bd1a1011ddff66f. --maxRegionSize=0 --maxRegionCreateTime=yyyy/MM/dd HH:mm:ss --numMaxMergePlans=2 --targetRegionCount=4 --printExecutionPlan=false" Thrift2 DemoClient.py,13277470,Reopened,Minor,,04/Jan/20 10:26,,2.2.2,"*hbase-examples/py* I tried to connect to hbase thrift2 server with python with given demo file DemoClient.py.  Issue is the DemoClient.py is not updated for python 3.X.  Python 2.X support has ended. Even the github vesrion is not updated, happy to update it.  I'm using python 3.8. {color:#ff0000}_Attached file for DemoClient.py for python 3.X._ I'm new to Jira and hbase. {color} __  hbase.thrift file that was used to generate gen-py in 2.2.22 release examples does seem like this file hbase-src-2.2.2/hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift. _I'm looking for hbase.thrift that was used to get gen-py in py examples. If you can point me to that, that will be great._ {color:#172b4d}If you generate gen-py using thrift compiler 0.13, this is error that I'm getting when running DemoClient.py, {color} {color:#172b4d}Traceback (most recent call last): File ""DemoClient.py"", line 68, in client.put(table, put) File ""/Users/madhuseshadri/Projects/hbase-pyclient-thrift2/gen-py/hbase/THBaseService.py"", line 813, in put self.send_put(table, tput) File ""/Users/madhuseshadri/Projects/hbase-pyclient-thrift2/gen-py/hbase/THBaseService.py"", line 821, in send_put args.write(self._oprot) File ""/Users/madhuseshadri/Projects/hbase-pyclient-thrift2/gen-py/hbase/THBaseService.py"", line 4461, in write oprot.writeBinary(self.table) File ""/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/thrift-0.13.0-py3.8-macosx-10.9-x86_64.egg/thrift/protocol/TBinaryProtocol.py"", line 131, in writeBinary self.trans.write(str) File ""/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/thrift-0.13.0-py3.8-macosx-10.9-x86_64.egg/thrift/transport/TTransport.py"", line 174, in write raise e File ""/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/thrift-0.13.0-py3.8-macosx-10.9-x86_64.egg/thrift/transport/TTransport.py"", line 170, in write self.__wbuf.write(buf) TypeError: a bytes-like object is required, not 'str'{color} {color:#172b4d}Please note that I'm using 0.13 py client package for thrift. It does not work with thrift==0.9.3 as well.{color} Out of the box gen-py that came with 2.2.2 source examples has the following issues working with thrift 0.13 py packages and it is also not code generated for python 3.0 but 2.0. * ttypes.py > self.__dict.__iteritems() does not work in python 3.0, so it need to be items  * xrange does not work in python 3.0 so all that need to be range    thrift compiler 0.13 was available at this point from apache/thrift. It generates the files for python 2.0 it seems because of above two issues because hbase.thrift that is src (link given above), not sure what can be done about this.  So, I have 0.13 python thrift package which works with python 3.0. DemoClient.py updated to 3.0 but issue is gen-py generation. I don't want to edit these generated py files, so if right hbase.thrift file that works with thrift 0.13.0 compiler, that will be great. Thanks.  " TestUsersOperationsWithSecureHadoop fails when an existing ticket is present,13291184,Open,Minor,,11/Mar/20 21:54,,2.3.0,"{{TestUsersOperationsWithSecureHadoop}} makes assumptions about the state of the machine environment. When i have an existing ticket issued and active (shown via {{klist}}), this test fails. Signing out of all active sessions allows the test to again pass. {noformat} Caused by: org.apache.hadoop.security.authentication.util.KerberosName$NoMatchingRule: No rules applied to me@EXAMPLE.COM at org.apache.hadoop.hbase.security.TestUsersOperationsWithSecureHadoop.testAuthUtilLogin(TestUsersOperationsWithSecureHadoop.java:146) {noformat}" Fix remaining Checkstyle violations in tests of hbase-common,13277591,Closed,Minor,Fixed,05/Jan/20 21:23,22/Jan/20 13:47,,In {{hbase-common}} Checkstyle reports a lot of violations. The remaining violations in the tests should be fixed. Moving classes out of hbase-it /test for direct API use of chaos.,13277361,Resolved,Minor,Abandoned,03/Jan/20 11:56,11/Jun/22 20:20,,"In hbase-it package, Class like RESTApiClusterManager and HBaseClusterManager which has some part of implementation code for Chaos Action.   If any user wants to create private implementation which resembles HBaseClusterManager, then it has to be merged with hbase-it package as ClusterManager Interface and it's extended implementations are private.    We should make them public so anyone can have their own implementation and need to be merged with hbase-it. " Shell should attempt to format `timestamp` attributes as ISO-8601,13289651,Resolved,Minor,Fixed,04/Mar/20 22:27,12/Mar/20 00:16,,"Most of the time, the {{timestamp: long}} attribute of a cell is a timestamp. The shell should make an attempt to interpret these values as timestamps and print them out as such. Current practice is to copy the value out and pass it through an external tool." "Many split related metrics were present RS side but after split is moved to Master, these metrics are lost.",13292064,Patch Available,Minor,,16/Mar/20 20:50,,2.2.3,"Many of the split related metrics like following are present RS side : ""SplitTime_num_ops"": 0, ""SplitTime_min"": 0, ""SplitTime_max"": 0, ""SplitTime_mean"": 0, ""SplitTime_25th_percentile"": 0, ""SplitTime_median"": 0, ""SplitTime_75th_percentile"": 0, ""SplitTime_90th_percentile"": 0, ""SplitTime_95th_percentile"": 0, ""SplitTime_98th_percentile"": 0, ""SplitTime_99th_percentile"": 0, ""SplitTime_99.9th_percentile"": 0, Value of these will always be 0 since Split is happening Master side and there is no Metrics update.      Update 1: After the fix, JMX is like this : { ""name"": ""Hadoop:service=HBase,name=Master,sub=Procedure"", ""modelerType"": ""Master,sub=Procedure"", ""tag.Context"": ""master"", ""tag.Hostname"": ""blrphispra01257"", ""numMasterWALs"": 0, ""splitProcedure_RequestCount"": 0, ""splitProcedure_FailedCount"": 0, ""splitProcedure_SuccessCount"": 0, ""splitProcedureTime_num_ops"": 0, ""splitProcedureTime_min"": 0, ""splitProcedureTime_max"": 0, ""splitProcedureTime_mean"": 0, ""splitProcedureTime_25th_percentile"": 0, ""splitProcedureTime_median"": 0, ""splitProcedureTime_75th_percentile"": 0, ""splitProcedureTime_90th_percentile"": 0, ""splitProcedureTime_95th_percentile"": 0, ""splitProcedureTime_98th_percentile"": 0, ""splitProcedureTime_99th_percentile"": 0, ""splitProcedureTime_99.9th_percentile"": 0 },   ," The new cache entry can overflow the maxSize in CachedEntryQueue,13282092,Open,Minor,,29/Jan/20 00:48,,2.1.8,"When we check whether the new entry should be added into CachedEntryQueue#queue, we need to be sure that after adding the entry to the queue, the cache size does not overflow maxSize. " Periodically check whether a system stop is requested in compaction by time.,13291044,Resolved,Minor,Fixed,11/Mar/20 10:14,04/May/20 21:48,,"The compaction check that the system is stopped when it reaches hbase.hstore.close.check.interval size. If the size is not reached, the compaction does not stop even though the system is stopped. If compaction is not terminated, the region is not closed. As a result, region remains pending-close.   Thread A (regionserver/longCompactions): State: RUNNABLE Stack: org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:319) org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:111) org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:119) org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1232) org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1896) org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.doCompaction(CompactSplitThread.java:525) org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:562) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) java.lang.Thread.run(Thread.java:748) Thread B (RS_CLOSE_REGION): State: WAITING Waiting on org.apache.hadoop.hbase.regionserver.HRegion$WriteState Stack: java.lang.Object.wait(Native Method) java.lang.Object.wait(Object.java:502) org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1567) org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1417) org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1380) org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:138) org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) java.lang.Thread.run(Thread.java:748)  " hbase/bin/region_status.rb Not available in hbase2,13294131,Reopened,Minor,,26/Mar/20 08:20,,2.0.1,"A series of strange errors occurred while running this script in hbase2, which was corrected as prompted, and note that in hbase2's MetaTableAccessor, getHRegionInfo has been replaced by getRegionInfo" "The message ""Please make sure that backup is enabled on the cluster."" is shown even when the backup feature is enabled",13284097,Resolved,Minor,Fixed,08/Feb/20 20:39,29/Jun/21 09:20,,"The following message is shown even when the backup feature is enabled, which is confusing: {code} Please make sure that backup is enabled on the cluster. To enable backup, in hbase-site.xml, set: hbase.backup.enable=true hbase.master.logcleaner.plugins=YOUR_PLUGINS,org.apache.hadoop.hbase.backup.master.BackupLogCleaner hbase.procedure.master.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager hbase.procedure.regionserver.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager hbase.coprocessor.region.classes=YOUR_CLASSES,org.apache.hadoop.hbase.backup.BackupObserver and restart the cluster {code} " Minor improvements to Region Normalizer,13289670,Resolved,Minor,Fixed,05/Mar/20 00:24,11/Mar/20 19:39,2.3.0,"While hbck2 runs through fixes to meta, the Normalizer kicks in to ""help"". Mostly this is fine, however, things get confused when {{fixMeta}} is action on a region and then the normalizer decides to do something as well. Could be we advise operators disable normalizer while running hbck2, but would be better if the normalizer was less aggressive, so that there's fewer flags to fiddle." Move to Apache parent POM version 22 for operator-tools,13280737,Resolved,Minor,Fixed,21/Jan/20 11:20,27/Jan/20 12:03,,A new Apache parent POM (version 22) was released. The core project already updated to this version. The hbase-operator-tools should also do it. Convert Jira attached patch precommit to a Jenkinsfile build,13286599,Resolved,Minor,Won't Fix,21/Feb/20 00:45,30/Oct/20 22:47,,This is an old job for running precommit when a Jira user attaches a patch file to an issue. Let's upgrade it to a Jenkinsfile pipeline so that we can track job changes in version control. Document that with split-to-hfile data over the MOB threshold will be treated as normal data,13281719,Resolved,Minor,Fixed,27/Jan/20 13:36,08/Oct/20 03:55,2.3.0,"h3. documentation update Update the troubleshooting section of the MOB chapter to include a note for ""Why is there data over the MOB threshold in the normal {{/hbase/data}} directory rather than in {{/hbase/mobdir}}. List the split-to-hfile feature as one source and bulk loading as another. Note that in both cases the next compaction to include those files will write the data out to MOB hfiles. h3. original Steps to reproduce this issue. 1. create a table with 1 region, and mob enabled, keep threshold value to 5. 2. Load data into the table, keep the value size should be more than 5. 3. flush the table. 4. observe the mobdir and data dir, hfiles should be there. 5. load data again with different data set, keep the value size is greater than 5. 6. Kill -9 RS where table region is online 7. Start RS check the mob dir and data dir, both should have 2 hfiles each. But data dir only have 2 hfiles, that means mob threshold crossed data is considered as normal data." Avoid high speed recursion trap in AsyncRequestFutureImpl.,13290663,Resolved,Minor,Incomplete,09/Mar/20 22:39,06/Oct/20 01:02,2.3.0,"While working on branch-2, I ran into an issue where a retryable error kept occurring and code in AsyncRequestFutureImpl would reduce the backoff wait to 0 and extremely rapidly eat up a of thread stack space with recursive retry calls. This little patch stops the backoff wait kill after 3 retries. Chosen kind of arbitrarily, perhaps 5 is the right number, but I find large retry counts tend to hide things and that has made me default to fairly conservative in all my arbitrary number picking." Move to Apache parent POM version 22,13278717,Resolved,Minor,Fixed,10/Jan/20 13:56,16/Jan/20 13:56,1.6.0,Apache parent POM version 22 was released on 2020/01/09. Remove deprecated methods from Scan,13285419,Resolved,Minor,Fixed,14/Feb/20 21:05,02/Jun/20 10:26,3.0.0-alpha-1,Umbrella ticket for handling the deprecations of {{Scan}} for version 3.0.0. Improve the accuracy of the method sizeToString,13291043,Resolved,Minor,Fixed,11/Mar/20 10:08,13/Mar/20 14:18,,"In QuotaSettings，the method of sizeToString reserved integer. But, this is not very accurate. {code:java} hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G', POLICY => NO_INSERTS hbase(main):002:0> list_quotas OWNER QUOTAS TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT => 1T, VIOLATION_POLICY => NO_INSERTS 1 row(s) in 0.0340 seconds {code} after patch： {code:java} hbase(main):001:0> set_quota TYPE => SPACE, TABLE => 't1', LIMIT => '2000G', POLICY => NO_INSERTS hbase(main):002:0> list_quotas OWNER QUOTAS TABLE => t1 TYPE => SPACE, TABLE => t1, LIMIT => 1.95T, VIOLATION_POLICY => NO_INSERTS 1 row(s) in 0.0230 seconds {code} " Bookmark for github PR to jira redirection,13279472,Resolved,Minor,Fixed,15/Jan/20 00:25,15/Jan/20 06:20,,"Following is a simple js snippet that redirects from any HBase PR to its corresponding jira. Without this, one has to copy the jira ID from the PR, construct a jira URL manually and paste it in the browser URL bar. Saves a bunch of clicks. {code:javascript} javascript:location.href='https://issues.apache.org/jira/browse/'document.getElementsByClassName(""js-issue-title"")[0].innerHTML.match(/HBASE-\d/)[0];{code} Particularly helpful for reviewers who'd like to read the jira contents often when reviewing a PR. For chrome: - Right Click on the bookmarks bar - Click on Add page. Fill in the following details: Name: HBase jira redirect (or any other that you prefer) URL: – {{snippet from above}}-- - Click Save Now you should see ""HBase jira redirect"" (or any other name you gave) bookmark on the bar. Go to any Github PR, click on this button and it redirects to the corresponding jira." [flakey test] client.TestMultiParallel fails to read hbase-site.xml,13290866,Resolved,Minor,Fixed,10/Mar/20 17:02,19/May/20 23:00,1.4.13,"Saw this on a [PreCommit run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt]. Log file says {noformat} 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853): error parsing conf hbase-site.xml java.io.FileNotFoundException: /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml (No such file or directory) at java.io.FileInputStream.open0(Native Method) at java.io.FileInputStream.open(FileInputStream.java:195) at java.io.FileInputStream.(FileInputStream.java:138) at java.io.FileInputStream.(FileInputStream.java:93) at sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90) at sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188) at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672) at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746) at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706) at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579) at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091) at org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145) at org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363) at org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793) at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810) at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100) at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849) at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389) at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181) at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85) at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465) at org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180) at org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507) at org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496) at org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469) at org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483) at org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:586) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1039) at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1004) at org.apache.hadoop.hbase.client.TestMultiParallel.beforeClass(TestMultiParallel.java:96) {noformat} This stage ran on H9." Convert logging code to use Parameters when possible,13293050,Open,Minor,,21/Mar/20 00:41,,2.4.0,"Based on [~ndimiduk]'s comments in HBASE-23957 , {code:java} nit: we make a habit of using the logger's format string capability. That way it only performs the computation necessary to build the log message if the logger is emitting messages at the target level. LOG.debug(""Starting the test {}"", name.getMethodName()){code}  and  [http://blog.logscape.com/2017/03/concatenation-or-parameters-both-whats-the-top-method-of-java-logging/],  I did a quick search of the code base and found  [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java#L334]   This needs to be converted to use parameter instead of string concatenation. .   " License checker for hbase-thirdparty,13284007,Open,Minor,,07/Feb/20 20:47,,,"I'm playing with hbase-thirdparty artifacts, and realized it doesn't perform license check like the core hbase do. This is a wish list to add that support some day." Use enforcer plugin to print JVM info in maven output,13291457,Resolved,Minor,Fixed,13/Mar/20 00:53,24/Mar/20 16:24,,"This is a little nice-to-have. We currently dump OS info using {{os-maven-plugin}}. Since we build on multiple JVM environments, would be nice to add that info too. Looking around, there wasn't an obvious source of this information, until I realized it's readily available via {{enforcer:display-info}}. Should add this to the top-level pom, if we can get it to run just once/build instead of with every module. {noformat} [INFO] --- maven-enforcer-plugin:3.0.0-M2:display-info (default-cli) @ hbase-archetype-builder --- [INFO] Maven Version: 3.6.3 [INFO] JDK Version: 1.8.0_222 normalized as: 1.8.0-222 [INFO] OS Info: Arch: x86_64 Family: mac Name: mac os x Version: 10.14.6 [INFO] ------------------------------------------------------------------------ {noformat} {noformat} [INFO] --- maven-enforcer-plugin:3.0.0-M2:display-info (default-cli) @ hbase-archetype-builder --- [INFO] Maven Version: 3.6.3 [INFO] JDK Version: 11.0.4 normalized as: 11.0.4 [INFO] OS Info: Arch: x86_64 Family: mac Name: mac os x Version: 10.14.6 [INFO] ------------------------------------------------------------------------ {noformat}" Correct exception messages for table null and namespace unavailable.,13292755,Resolved,Minor,Fixed,19/Mar/20 18:04,21/Mar/20 15:13,,"Exception message for following two scenarios should be corrected.  1. Change message to ""The list of tables cannot be null."" in below code {code:java} @Override public void moveTables(Set tables, String targetGroup) throws IOException { if (tables == null) { throw new ConstraintException(""The list of servers cannot be null.""); } {code} 2. Change the message to ""Region server group ""+group+"" does not exist"" in below code. {code:java} public void preCreateNamespace(ObserverContext ctx, NamespaceDescriptor ns) throws IOException { String group = ns.getConfigurationValue(RSGroupInfo.NAMESPACE_DESC_PROP_GROUP); if(group != null && groupAdminServer.getRSGroupInfo(group) == null) { throw new ConstraintException(""Region server group ""+group+"" does not exit""); } } {code}  " FastPathBalancedQueueRpcExecutor should enforce queue length of 0,13281770,Resolved,Minor,Fixed,27/Jan/20 17:53,13/Jul/20 08:27,,"FastPathBalancedQueueRpcExecutor allows RPC requests to skip the RPC queue and get worked by an available handler under certain circumstances. Relatedly, the hbase.ipc.server.max.callqueue.length parameter can be set to 0, including dynamically. This can be useful to temporarily prevent writes on a cluster. When this is the case the executor is supposed to block all dispatching. However, the FastPathBalancedQueueRpcExecutor will still dispatch the request if one of the ""fast path"" handlers is available on its stack. This both isn't the desired effect, and also makes TestSimpleRpcScheduler.testSoftAndHardQueueLimits unstable when it checks the queue length 0 behavior. A simple fix is just to check max queue length > 0 before FastPathBalancedQueueRpcExecutor pops the fast handler off the stack. " MasterFileSystem should not create MasterProcWALs dir on fresh installs,13280795,Resolved,Minor,Fixed,21/Jan/20 15:42,30/May/20 08:13,3.0.0-alpha-1,"With the new procedure store that uses internal table for persisting procedures state, there's no need for creating the old MasterProcWALs folder on fresh installs. We should remove t from the list of dirs created by _MasterFileSystem.createInitialFileSystemLayout,_ so that it does not trigger an unnecessary conversion of procedure stores." Expose shaded clients through WebUI as Maven repository,13294293,Resolved,Minor,Incomplete,26/Mar/20 20:20,28/May/20 22:57,,"Props to [~busbey] for this idea. We have a number of shaded jars which are (largely) sufficient for launching any Java application against HBase. However, if users have multiple versions of HBase in their organization, it might be confusing to know ""which client"" do I need to use? Can we expose our shaded clients from HBase in such a way that build tools can just ask HBase for the client jars they should use? The idea here is that we can use embedded Jetty to ""fake"" out a Maven repository that users can put in their client applications. We have no extra burden from HBase because we already are packaging these jars. I'll link an example Maven application which uses this ""feature""." Meta browser should show all `info` columns,13291177,Resolved,Minor,Fixed,11/Mar/20 21:14,18/May/20 19:00,2.3.0,"The Meta table browser lists region states. There are other {{info}} columns in the table, which should be displayed. Looking through {{HConstants}}, it seems we need to add the following: * {{server}} * {{sn}} * {{splitA}} * {{splitB}} * {{merge}} * {{mergeA}} * {{mergeB}} Are there others?" Provide a much faster and efficient alternate option to maven and surefire for running tests.,13283665,Resolved,Minor,Won't Fix,06/Feb/20 10:23,17/May/20 06:33,,"With HBASE-23795, the hope is to drive tests with maven and surefire much closer to their potential. That will still leave a lot of room for improvement. For those that have some nice hardware and a need for speed, we can blow right past maven+surefire." Race condition in Master startup can ignore shutdown RPC,13285155,Open,Minor,,13/Feb/20 18:41,,2.3.0,"Identified as the root-cause of HBASE-23808. The master starts its RPC server first thing in its constructor, but does not initialize it's {{clusterTracker}} until later (both from the super constructor). Thus it is possible for a client to issue a {{shutdown}} RPC is received by a master before it has a clusterTracker instance. It is highly likely (guaranteed?) to also not be the active master at this point. In such a case, the {{shutdown}} is received and acknowledged back to the client, but is effectively ignored. After chatting with [~bharathv] on the PR, we believe this race becomes more likely (though still rare) after HBASE-18095. This is something to consider should we get around to a startup sequence refactor. Setting priority as ""minor"" because the condition is merely annoying; from what I can tell, a subsequent {{shutdown}} RPC to any master would result in the correct shutdown of the first." Rubocop configuration needs updated,13289895,Resolved,Minor,Fixed,05/Mar/20 19:27,12/May/20 12:11,1.7.0,"Looking at the general check output on [nightly/master|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1654/pipeline/96/], it looks like our {{.rubocop.yaml}} configuration file has drifted from the syntax expected by our current version of the tool. Lots of errors like the following: {noformat} [2020-03-05T15:36:27.538Z] Running rubocop against identified ruby scripts. [2020-03-05T15:36:27.538Z] .rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout [2020-03-05T15:36:27.538Z] Error: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. [2020-03-05T15:36:27.538Z] (obsolete configuration found in .rubocop.yml, please update it) [2020-03-05T15:36:27.538Z] .rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout [2020-03-05T15:36:27.538Z] Error: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. [2020-03-05T15:36:27.538Z] (obsolete configuration found in .rubocop.yml, please update it) ... {noformat}" Consider using 127.0.0.1 instead of localhost and binding to 127.0.0.1 as well.,13283294,Resolved,Minor,Won't Fix,04/Feb/20 17:25,11/May/20 20:17,,"This is perhaps controversial, but there are a variety of problems with counting on dns hostname resolution, especially for locahost.   # It can often be slow, slow under concurrency, or slow under specific conditions. # It can often not work at all - when on a VPN, with weird DNS hijacking hi-jinks, when you have a real hostname for you machines, a custom /etc/hosts file, OS's run their own local/funny DNS server services. # This makes coming to HBase for new devs a hit or miss experience and if you miss, dealing with an diagnosing the issues is a large endeavor and not straight forward or transparent. #  99% of the difference doesn't matter in most cases - except that 127.0.0.1 works and is fast pretty much universally." Scale *MiniCluster config for the environment it runs in.,13286898,Resolved,Minor,Duplicate,21/Feb/20 22:06,10/May/20 14:54,, Remove deprecated getTimeStampOfLastAppliedOp from MetricsSink,13281504,Resolved,Minor,Fixed,24/Jan/20 23:23,29/Jan/20 16:03,3.0.0-alpha-1,"{{MetricsSink}} defines the deprecated method {{getTimeStampOfLastAppliedOp}}, which should be removed for 3.0.0." Remove deprecated createLocalHRegion from HBaseTestingUtility,13281608,Resolved,Minor,Fixed,26/Jan/20 19:24,28/Jan/20 11:41,3.0.0-alpha-1,{{createLocalHRegion}} in {{HBaseTestingUtility}} was deprecated back in 2.0.0 and should be removed for 3.0.0. "Remove deprecated Scan(byte[], Filter) from Scan",13285427,Resolved,Minor,Fixed,14/Feb/20 21:28,16/Feb/20 20:52,3.0.0-alpha-1,"{{Scan(byte[], Filter)}} in {{Scan}} was deprecated back in 2.0.0 and should be removed for 3.0.0." Add IntelliJ check style plugin configuration,13280262,Resolved,Minor,Fixed,18/Jan/20 01:34,27/Jan/20 18:54,,"IntelliJ defines project configuration across a number of files, specifically so that some configurations can be committed with the source repository. The checkstyle plugin configuration is one such config file; add it." Remove deprecated setStopRow(byte[]) from Scan,13285435,Resolved,Minor,Fixed,14/Feb/20 21:51,24/Apr/20 11:50,3.0.0-alpha-1,{{setStopRow(byte[]}} in {{Scan}} was deprecated back in 2.0.0 and should be removed for 3.0.0. remove_servers_rsgroup did not get the correct result,13288015,Open,Minor,,27/Feb/20 11:21,,2.2.3,"While trying to remove a server from a rs group, if the rs group is not valid/present in the rs group, it still shows *0 row(s)*, instead of an *exception ""Server Invalid/Not found""*." "When encounter RowTooBigException, log the row info.",13294915,Resolved,Minor,Fixed,30/Mar/20 07:32,07/Apr/20 02:42,2.2.4,"Current when we encounter a big row and throw RowTooBigException, there is no information about the row, it hard to debug." Consider setting -XX:MaxDirectMemorySize in the root Maven pom.xml file.,13283287,Open,Minor,,04/Feb/20 17:02,,,"-XX:MaxDirectMemorySize is an artificial governor on how much off heap memory can be allocated. It would be nice to specify explicitly because: # The default can vary by platform / jvm impl - some devs may see random fails # It's just a limiter, it won't pre allocate or anything # A test env should normally ensure a healthy limit as would be done in production" Re-use underlying connection registry in RawAsyncHBaseAdmin,13277609,Resolved,Minor,Fixed,06/Jan/20 02:14,09/Jan/20 20:28,3.0.0-alpha-1,"Based on the discussion between [~stack] and I in the code review for HBASE-23305, the current usage of ConnectionRegistry is ad-hoc, sometimes multiple times per connection. Before Duo's Comment: don't see any obvious reason to not make it a singleton (except for testing). This makes it more readable. Edited to: Fix RawAsyncHBaseAdmin's creation of adhoc registry. " Change code in StoreFileInfo to use regex matcher for mob files.,13281117,Open,Minor,,23/Jan/20 05:31,,,Currently it sits on top of other regex with additional logic added. Code should simplified. [RSGroup] Error logs appear when the table is created,13294430,Open,Minor,,27/Mar/20 11:07,,2.1.7,"Will create table assigned to the corresponding rsgroup, appear TableStateNotFoundException: {code:java} 2020-03-27 15:49:21,959 INFO  [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving table Test:t3 to RSGroup default 2020-03-27 15:49:21,971 ERROR [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] master.TableStateManager: Unable to get table Test:t3 state org.apache.hadoop.hbase.master.TableStateManager$TableStateNotFoundException: Test:t3         at org.apache.hadoop.hbase.master.TableStateManager.getTableState(TableStateManager.java:215)         at org.apache.hadoop.hbase.master.TableStateManager.isTableState(TableStateManager.java:147)         at org.apache.hadoop.hbase.master.assignment.AssignmentManager.isTableDisabled(AssignmentManager.java:388)         at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTableRegionsToGroup(RSGroupAdminServer.java:252)         at org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveTables(RSGroupAdminServer.java:366)         at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.assignTableToGroup(RSGroupAdminEndpoint.java:447)         at org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.postCreateTable(RSGroupAdminEndpoint.java:470)         at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:350)         at org.apache.hadoop.hbase.master.MasterCoprocessorHost$13.call(MasterCoprocessorHost.java:347)         at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:551)         at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:625)         at org.apache.hadoop.hbase.master.MasterCoprocessorHost.postCreateTable(MasterCoprocessorHost.java:347)         at org.apache.hadoop.hbase.master.HMaster$4.run(HMaster.java:2043)         at org.apache.hadoop.hbase.master.procedure.MasterProcedureUtil.submitProcedure(MasterProcedureUtil.java:134)         at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:2026)         at org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:659)         at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2020-03-27 15:49:21,971 INFO  [RpcServer.default.RWQ.Fifo.read.handler=139,queue=14,port=16000] rsgroup.RSGroupAdminServer: Moving region(s) for table Test:t3 to RSGroup default   {code}   This doesn't seem to cause any problems, but I think it's best to avoid error logs like this" Dockerfiles showing hadolint check failures,13290126,Resolved,Minor,Fixed,06/Mar/20 16:18,10/Mar/20 19:34,,"HBASE-23876 fixed the hadolint install path, so now those checks are being run, and flagging problems. Let's fix them." Reduce number of Checkstyle violations in hbase-rest,13278119,Resolved,Minor,Fixed,08/Jan/20 10:08,26/Jan/20 12:39,,In {{hbase-rest}} Checkstyle reports a lot of violations. Reduce the number of reported violations. Remove deprecated Scan(byte[]) from Scan,13285423,Resolved,Minor,Fixed,14/Feb/20 21:17,02/Apr/20 09:44,3.0.0-alpha-1,{{Scan(byte[])}} in {{Scan}} was deprecated back in 2.0.0 and should be removed for 3.0.0. Solve the ambiguous reference for scala 2.12,13295153,Resolved,Minor,Fixed,31/Mar/20 05:04,02/Apr/20 19:53,,"When the {{hbase-spark}} module is compiled under the scala 2.12 environment, the following error appears in line 216 of the {{org.apache.hadoop.hbase.spark.datasources.HBaseTableScanRDD}} class: {code:java} [ERROR] [Error] /path/hbase-connectors/spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/datasources/HBaseTableScanRDD.scala:216: ambiguous reference to overloaded definition, both method addTaskCompletionListener in class TaskContext of type [U](f: org.apache.spark.TaskContext => U)org.apache.spark.TaskContext and method addTaskCompletionListener in class TaskContext of type (listener: org.apache.spark.util.TaskCompletionListener)org.apache.spark.TaskContext match argument types (org.apache.spark.TaskContext => Unit){code}" Fix links to build reports generated by nightly job,13295298,Resolved,Minor,Fixed,31/Mar/20 16:00,01/Apr/20 19:22,2.3.0,"Links going back to JIRA look like {noformat} For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2574//JDK8_Nightly_Build_Report_(Hadoop2)/] {noformat} But the actual URL to this report is https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2574/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/" "Remove deprecated Scan(byte[], byte[]) from Scan",13285422,Resolved,Minor,Fixed,14/Feb/20 21:09,01/Apr/20 11:11,3.0.0-alpha-1,"{{Scan(byte[], byte[])}} in {{Scan}} was deprecated back in 2.0.0 and should be removed for 3.0.0" SpotBugs check automatically skip inapplicable modules,13295031,Resolved,Minor,Fixed,30/Mar/20 15:55,31/Mar/20 16:36,,"Our personality runs spotbugs on a per-module basis, rather than from the root module. It has a hard-coded list of modules to skip over. The comment says it only runs on modules that have content under {{src/main/java}}. Replace the fixed list with a find expression." Remove deprecated setMaxVersions(int) from Scan,13285430,Resolved,Minor,Fixed,14/Feb/20 21:40,31/Mar/20 08:18,3.0.0-alpha-1,{{setMaxVersions(int)}} in {{Scan}} was deprecated back in 2.0.0 and should be removed for 3.0.0. Remove deprecated setMaxVersions() from Scan,13285429,Resolved,Minor,Fixed,14/Feb/20 21:34,29/Mar/20 09:47,3.0.0-alpha-1,{{setMaxVersions()}} in {{Scan}} was deprecated back in 2.0.0 and should be removed for 3.0.0. WALFactory.Providers.multiwal causes StackOverflowError,13293517,Resolved,Minor,Fixed,24/Mar/20 11:32,27/Mar/20 02:40,1.0.0,"if 'hbase.wal.provider=multiwal' and 'hbase.wal.regiongrouping.delegate.provider=multiwal', regionserver will create RegionGroupingProvider in a loop until StackOverflowError. {code:java} 2020-03-24 19:08:19,180 WARN [RS_CLOSE_META-regionserver/localhost:16020-0] handler.AssignRegionHandler: Fatal error occurred while opening region hbase:meta,,1.1 588230740, aborting... java.lang.StackOverflowError at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:125) at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:566) at java.lang.StringBuffer.append(StringBuffer.java:357) at org.apache.log4j.helpers.ISO8601DateFormat.format(ISO8601DateFormat.java:134) at java.text.DateFormat.format(DateFormat.java:345) at org.apache.log4j.helpers.PatternParser$DatePatternConverter.convert(PatternParser.java:443) at org.apache.log4j.helpers.PatternConverter.format(PatternConverter.java:65) at org.apache.log4j.PatternLayout.format(PatternLayout.java:506) at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:310) at org.apache.log4j.RollingFileAppender.subAppend(RollingFileAppender.java:276) at org.apache.log4j.WriterAppender.append(WriterAppender.java:162) at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251) at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66) at org.apache.log4j.Category.callAppenders(Category.java:206) at org.apache.log4j.Category.forcedLog(Category.java:391) at org.apache.log4j.Category.log(Category.java:856) at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:304) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getStrategy(RegionGroupingProvider.java:105) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.init(RegionGroupingProvider.java:160) at org.apache.hadoop.hbase.wal.WALFactory.createProvider(WALFactory.java:161) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.createProvider(RegionGroupingProvider.java:166) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:184) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212) ...... {code} " Enable surefire rerun flakey tests in PreCommit,13294250,Resolved,Minor,Not A Problem,26/Mar/20 17:08,27/Mar/20 17:55,,I'm not sure why we do this in nightly but not in PreCommit. Seems like we should turn it on. Support setting `-Dhadoop.profile` in adhoc_run_tests.sh,13293890,Resolved,Minor,Fixed,25/Mar/20 17:52,26/Mar/20 15:51,,Allow the caller to override the hadoop version used. This is required in order to use this tool with JDK11. TestHRegion.testCheckAndMutate_WithFilters is flaky,13293081,Resolved,Minor,Fixed,21/Mar/20 08:51,21/Mar/20 20:05,,"{code} [ERROR] Tests run: 108, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 119.165 s <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestHRegion [ERROR] org.apache.hadoop.hbase.regionserver.TestHRegion.testCheckAndMutate_WithFilters Time elapsed: 0.179 s <<< FAILURE! java.lang.AssertionError: expected: but was: at org.apache.hadoop.hbase.regionserver.TestHRegion.testCheckAndMutate_WithFilters(TestHRegion.java:2218) {code} This happens only in the master branch." Fix pylint invocation in pre-commit,13281773,Resolved,Minor,Fixed,27/Jan/20 18:14,19/Mar/20 23:32,,"Seems Yetus and our version of pylint disagree on executable arguments. From a recent pre-commit check over a python file: {noformat} Usage: pylint [options] module_or_package Check that a module satisfies a coding standard (and more !). pylint --help Display this help message and exit. pylint --help-msg [,] Display help messages about given message identifiers and exit. pylint: error: no such option: --score {noformat}" "protoc warns: ""no protobuf syntax specified""",13291193,Resolved,Minor,Fixed,11/Mar/20 23:29,17/Mar/20 22:40,,"This comes up in a couple places. {noformat} [INFO] --- protobuf-maven-plugin:0.6.1:compile (compile-protoc) @ hbase-protocol-shaded --- [INFO] Compiling 37 proto file(s) to /Users/ndimiduk/repos/apache/hbase/hbase-protocol-shaded/target/generated-sources/protobuf/java [WARNING] PROTOC: [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax specified for the proto file: RSGroupAdmin.proto. Please use 'syntax = ""proto2"";' or 'syntax = ""proto3"";' to specify a syntax version. (Defaulted to proto2 syntax.) [libprotobuf WARNING google/protobuf/compiler/parser.cc:546] No syntax specified for the proto file: RSGroup.proto. Please use 'syntax = ""proto2"";' or 'syntax = ""proto3"";' to specify a syntax version. (Defaulted to proto2 syntax.) {noformat}" Add an option to Actions to filter out meta RS,13287510,Resolved,Minor,Fixed,25/Feb/20 14:04,17/Mar/20 14:05,3.0.0-alpha-1,"Add an option to Actions to be able to filter meta server out.  Some ITs rely on meta RS and have timeout errors if this RS is killed. (e.g. IntegrationTestTimeBoundedRequestsWithRegionReplicas) For the time being there is no option for removing meta server from server list to kill or configuring these actions properly. The following chaos monkey actions are affected: GracefulRollingRestartRsAction, RollingBatchSuspendResumeRsAction " Add CI check that builds dockerfiles,13290904,Open,Minor,,10/Mar/20 19:23,,,"I stumbled into some bit-rot in a {{Dockerfile}} recently. The job that powers the flakey detector apparently only runs because the build machines have layers cached. We could detect these failures earlier by rebuilding docker environments with {{--no-cache}} on a regular interval. Nightly is probably overkill, but it's easy enough to tack on an additional parallel stage to the existing build." list_rsgroups didn't get the correct result,13287025,Resolved,Minor,Invalid,23/Feb/20 01:54,17/Mar/20 06:02,2.2.3,"if my_group does not exist, list_rsgroups will get 0 row(s), but i think list_rsgroups should throw NOTEXISTEXCEPTION !image-2020-02-23-09-53-49-594.png|width=449,height=143!" Remove deprecated setStartRow(byte[]) from Scan,13285432,Resolved,Minor,Fixed,14/Feb/20 21:46,13/Mar/20 00:44,3.0.0-alpha-1,{{setStartRow(byte[]}} in {{Scan}} was deprecated back in 2.0.0 and should be removed in 3.0.0. Include test logs in pre-commit artifacts,13287810,Resolved,Minor,Fixed,26/Feb/20 17:56,12/Mar/20 21:34,,Test xml logs are essential for diagnosing broken tests. Our nighly job includes these logs in the job artifacts gathered and retained in jenkins. the GitHub PreCommit job does not. Let's archive them for precommit as well. Shell formatter for for meta table should pretty-print values of info:merge columns,13289648,Resolved,Minor,Fixed,04/Mar/20 22:17,11/Mar/20 23:42,2.3.0,"Diagnosing mangled region assignments, scanning meta from the shell, we see regions with {{info:merge000X}} cells, but their values are printed as encoded protobuf. We should have a {{Formatter}} in place that can decode these values into something legible for a human." Add test for MinVersions and KeepDeletedCells TTL,13280616,Resolved,Minor,Fixed,20/Jan/20 21:30,22/Jan/20 09:16,,"Recently I was researching how HBase handles the interactions between setting MinVersions and KeepDeletedCells = TTL, and I wrote a test to prove my assumptions about the behavior were correct. There doesn't seem to be an equivalent existing test in TestMinVersions, so I thought I'd contribute it. " Make sure HBaseClassTestRule doesn't suffer same issue as HBaseClassTestRuleChecker,13279975,Resolved,Minor,Fixed,16/Jan/20 20:31,17/Jan/20 18:03,,"[~bharathv] pointed out on HBASE-23695 ([https://github.com/apache/hbase/pull/1052]) that HBaseClassTestRule suffers the same potential bug that I fixed in HBASE-23695 for HBaseClassTestRuleChecker. Make sure the fix is in both places.  " Fail more gracefully when test class is missing Category,13279632,Resolved,Minor,Fixed,15/Jan/20 17:03,16/Jan/20 15:25,,"When a test class is missing a category, you might see an error such as: {noformat} [ERROR] Test mechanism Time elapsed: 0.305 s <<< ERROR! java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time elapsed: 0.102 s <<< ERROR! java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time elapsed: 0.103 s <<< ERROR! java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time elapsed: 0.102 s <<< ERROR! java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism Time elapsed: 0.098 s <<< ERROR! java.lang.ArrayIndexOutOfBoundsException: 0[ERROR] Test mechanism :: 0 {noformat} You have to dig into the dump file to find out the actual error was: {noformat} org.apache.maven.surefire.testset.TestSetFailedException: Test mechanism :: 0         at org.apache.maven.surefire.common.junit4.JUnit4RunListener.rethrowAnyTestMechanismFailures(JUnit4RunListener.java:192)         at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)         at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:377)         at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:138)         at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:465)         at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:451) Caused by: java.lang.ArrayIndexOutOfBoundsException: 0         at org.apache.hadoop.hbase.HBaseClassTestRuleChecker.testStarted(HBaseClassTestRuleChecker.java:44)         at org.junit.runner.notification.RunNotifier$5.notifyListener(RunNotifier.java:156)         at org.junit.runner.notification.RunNotifier$SafeNotifier.run(RunNotifier.java:72)         at org.junit.runner.notification.RunNotifier.fireTestStarted(RunNotifier.java:153)         at org.apache.maven.surefire.common.junit4.Notifier.fireTestStarted(Notifier.java:100)         at org.junit.internal.runners.model.EachTestNotifier.fireTestStarted(EachTestNotifier.java:42)         at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:364)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)         at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)         at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)         at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)         at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)         at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)         at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)         at org.junit.runners.ParentRunner.run(ParentRunner.java:413)         at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)         at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)         at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)         at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)         ... 4 more {noformat} We can fix this up to get a proper exception thrown." Fix remaining Checkstyle violations in tests of hbase-rest,13277600,Resolved,Minor,Fixed,05/Jan/20 23:31,20/Jan/20 21:22,,In {{hbase-rest}} Checkstyle reports a lot of violations. The remaining violations in the tests should be fixed. [JDK11] Yetus should vote -0 for known JDK11 issues,13290129,Resolved,Minor,Fixed,06/Mar/20 16:21,09/Mar/20 16:14,,"So as t avoid everyone being depressed by failing builds, we should have Yetus vote -0 instead of -1 for checks that are known to fail with JDK11. Off the top of my head, these should be {{javadocs}} and {{unit}}." Invalid StoreFile WARN log message printed for recovered.hfiles directory,13281639,Resolved,Minor,Fixed,27/Jan/20 06:13,26/Feb/20 15:24,2.3.0,"After HBASE-23286, recovered.hfiles directories will be created under table CF dir. Region server validates the store file during store initializaiton. Currently it expect only store file inside the table CF directory, so for recovered.hfiles below WARN logs message will be printed. {code:java} 2020-01-27 11:13:09,823 WARN [StoreOpener-1588230740-1] regionserver.HRegionFileSystem: Invalid StoreFile: hdfs://127.0.0.1:8020/hbase/data/hbase/meta/1588230740/info/recovered.hfiles 2020-01-27 11:14:31,036 WARN [StoreOpener-1588230740-1] regionserver.HRegionFileSystem: Invalid StoreFile: hdfs://127.0.0.1:8020/hbase/data/hbase/meta/1588230740/info/recovered.hfiles 2020-01-27 11:14:31,110 WARN [StoreOpener-1588230740-1] regionserver.HRegionFileSystem: Invalid StoreFile: hdfs://127.0.0.1:8020/hbase/data/hbase/meta/1588230740/table/recovered.hfiles 2020-01-27 11:14:36,031 WARN [StoreOpener-16beeb2fd517283980b11b912490cbba-1] regionserver.HRegionFileSystem: Invalid StoreFile: hdfs://127.0.0.1:8020/hbase/data/default/t4/16beeb2fd517283980b11b912490cbba/cf1/recovered.hfiles 2020-01-27 11:14:36,057 WARN [StoreOpener-e430213f4660304a26b9b389f78b5681-1] regionserver.HRegionFileSystem: Invalid StoreFile: hdfs://127.0.0.1:8020/hbase/data/hbase/acl/e430213f4660304a26b9b389f78b5681/l/recovered.hfiles {code} No need to validate recovered.hfiles directory." list_regions fails if table is under split,13288223,Resolved,Minor,Fixed,28/Feb/20 08:44,06/Mar/20 07:42,1.6.0,"Shortly after executing split 'table' command from the shell the list_regions 'table' fails with ""ERROR: undefined method `toString' for nil:NilClass""   {noformat} hbase(main):002:0> list_regions 'cluster_test' SERVER_NAME | REGION_NAME | START_KEY | END_KEY | SIZE | REQ | LOCALITY | --------------------------- | --------------------------------------------------------------------- | ---------- | ---------- | ----- | -------- | ---------- | nokedli,34665,1582736360668 | cluster_test,,1582736408029.857a9b734a2f490e573ba20b1bbf99b3. | | 33333333 | 3348 | 20408042 | 0.0 | nokedli,34665,1582736360668 | cluster_test,33333333,1582736408029.1749360028b3a5e76b5da1d1888e5b9d. | 33333333 | 66666666 | 3321 | 20242123 | 0.0 | nokedli,34665,1582736360668 | cluster_test,66666666,1582736408029.1f1366aa0ee621d496103ac5a50bca77. | 66666666 | 99999999 | 3316 | 20215774 | 0.0 | nokedli,34665,1582736360668 | cluster_test,99999999,1582736408029.ae95589c9498443a89aea4c42c199372. | 99999999 | cccccccc | 3327 | 20285312 | 0.0 | nokedli,34665,1582736360668 | cluster_test,cccccccc,1582736408029.239647c37e27cbd3154180ce5004a1ea. | cccccccc | | 3355 | 20451469 | 0.0 | 5 rows hbase(main):003:0> split 'cluster_test' 0 row(s) in 0.2240 seconds hbase(main):004:0> list_regions 'cluster_test' ERROR: undefined method `toString' for nil:NilClass Here is some help for this command: List all regions for a particular table as an array and also filter them by server name (optional) as prefix and maximum locality (optional). By default, it will return all the regions for the table with any locality. The command displays server name, region name, start key, end key, size of the region in MB, number of requests and the locality. The information can be projected out via an array as third parameter. By default all these information is displayed. Possible array values are SERVER_NAME, REGION_NAME, START_KEY, END_KEY, SIZE, REQ and LOCALITY. Values are not case sensitive. If you don't want to filter by server name, pass an empty hash / string as shown below. Examples: hbase> list_regions 'table_name' hbase> list_regions 'table_name', 'server_name' hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', LOCALITY_THRESHOLD => 0.8} hbase> list_regions 'table_name', {SERVER_NAME => 'server_name', LOCALITY_THRESHOLD => 0.8}, ['SERVER_NAME'] hbase> list_regions 'table_name', {}, ['SERVER_NAME', 'start_key'] hbase> list_regions 'table_name', '', ['SERVER_NAME', 'start_key'] hbase(main):005:0> list_regions 'cluster_test' SERVER_NAME | REGION_NAME | START_KEY | END_KEY | SIZE | REQ | LOCALITY | --------------------------- | ---------------------------------------------------------------------------------------------------- | --------------------------------------- | --------------------------------------- | ----- | -------- | ---------- | nokedli,34665,1582736360668 | cluster_test,,1582878981608.614acededc61f55a10816bb871d0421b. | | 197f83f2390a2a0c4104f4630982c585-461828 | 3348 | 10204021 | 0.0 | nokedli,34665,1582736360668 | cluster_test,197f83f2390a2a0c4104f4630982c585-461828,1582878981608.5987f972793bd422564a0758e545caa5. | 197f83f2390a2a0c4104f4630982c585-461828 | 33333333 | 3348 | 10204021 | 0.0 | nokedli,34665,1582736360668 | cluster_test,33333333,1582878982425.a306381f3ee03161dc832eaca066131b. | 33333333 | 4cdfa653a3843d49a62004a6e4e71636-501997 | 3321 | 10121061 | 0.0 | nokedli,34665,1582736360668 | cluster_test,4cdfa653a3843d49a62004a6e4e71636-501997,1582878982425.ae87e47584e3dee98e524f961fa6906e. | 4cdfa653a3843d49a62004a6e4e71636-501997 | 66666666 | 3321 | 10121061 | 0.0 | nokedli,34665,1582736360668 | cluster_test,66666666,1582878983449.d4015a18e47a9aeec89a1ead9a974186. | 66666666 | 7ffd66580ac07b1ff7636f9b15609fa6-238805 | 3316 | 10107887 | 0.0 | nokedli,34665,1582736360668 | cluster_test,7ffd66580ac07b1ff7636f9b15609fa6-238805,1582878983449.c92f8a7b3a89fee59313bdb516720319. | 7ffd66580ac07b1ff7636f9b15609fa6-238805 | 99999999 | 3316 | 10107887 | 0.0 | nokedli,34665,1582736360668 | cluster_test,99999999,1582878984099.36d0e3d56119f2bdcae280853c29321d. | 99999999 | b36cb3f90c3019779ba5a3b00fb6da2f-320789 | 3327 | 10142656 | 0.0 | nokedli,34665,1582736360668 | cluster_test,b36cb3f90c3019779ba5a3b00fb6da2f-320789,1582878984099.9d76372540e628675a4aea5a8979107d. | b36cb3f90c3019779ba5a3b00fb6da2f-320789 | cccccccc | 3327 | 10142656 | 0.0 | nokedli,34665,1582736360668 | cluster_test,cccccccc,1582878984966.1292a5f5dbd5f454d5d3b3cf048c4a75. | cccccccc | e66d48d7b227e7845b73d43eb1a06fcb-86032 | 3355 | 10225734 | 0.0 | nokedli,34665,1582736360668 | cluster_test,e66d48d7b227e7845b73d43eb1a06fcb-86032,1582878984966.6765ff09c59899363ae9be115a9c3d78. | e66d48d7b227e7845b73d43eb1a06fcb-86032 | | 3355 | 10225734 | 0.0 | 10 rowshbase(main):006:0>{noformat}" Move Jira-attached file precommit definition from script in Jenkins config to dev-support,13286302,Resolved,Minor,Fixed,19/Feb/20 18:45,27/Feb/20 01:46,,Right now the precommit job that scans Jira for attachments is defined entirely in the Jenkins job configuration. Let's move this into git so that changes can be tracked. "Backport ""HBASE-18418 Remove apache_hbase_topology from dev-support"" to branch-2",13290138,Resolved,Minor,Duplicate,06/Mar/20 17:10,06/Mar/20 17:44,2.3.0,"HBASE-23945 flags this dockerfile as having issues, but it's been deleted from master. Drop it from branch-2 as well." [Jenkins Nightly] shelldocs executable unavailable within docker context,13289892,Open,Minor,,05/Mar/20 19:20,,3.0.0-alpha-1,"I'm not sure if this is an HBase build bug or a Yetus bug. Looking more closely at the yetus output, I noticed this in the general check section on [nightlies/master|https://builds.apache.org/blue/organizations/jenkins/HBase%20Nightly/detail/master/1654/pipeline/96]. {noformat} [2020-03-05T14:56:51.559Z] executable '/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/yetus-0.11.1/bin/shelldocs' for 'shelldocs' does not exist. {noformat} Of course the executable is available in the yetus distro unpacked into the workspace. However, we're running in the docker context, and apparently the yetus runtime does not make itself available to the running container." [flakey] TestThriftHttpServer fails to bind to port,13287813,Open,Minor,,26/Feb/20 18:08,,2.3.0,"We see thrift tests fail occasionally in Jenkins due to failure to bind to port. {noformat} 2020-02-26 10:24:07,725 INFO [ThriftServer-httpServer] http.HttpServer (HttpServer.java:start(1063)) - HttpServer.start() threw a non Bind IOException java.net.BindException: Port in use: 0.0.0.0:54902 at org.apache.hadoop.hbase.http.HttpServer.openListeners(HttpServer.java:1126) at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1060) at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:148) at org.apache.hadoop.hbase.thrift.ThriftServer.startInfoServer(ThriftServer.java:308) at org.apache.hadoop.hbase.thrift.ThriftServer.run(ThriftServer.java:849) at org.apache.hadoop.hbase.thrift.TestThriftHttpServer.lambda$startHttpServerThread$0(TestThriftHttpServer.java:121) at java.lang.Thread.run(Thread.java:748) Caused by: java.net.BindException: Address already in use at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:433) at sun.nio.ch.Net.bind(Net.java:425) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223) at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74) at org.eclipse.jetty.server.ServerConnector.openAcceptChannel(ServerConnector.java:351) at org.eclipse.jetty.server.ServerConnector.open(ServerConnector.java:319) at org.apache.hadoop.hbase.http.HttpServer.openListeners(HttpServer.java:1120) ... 6 more {noformat}" Build automation using Yetus pre-releases shouldn't assume test-patch runs directly from a src checkout,13287808,Open,Minor,,26/Feb/20 17:48,,,"HBASE-23873 reports that several places where CI tools allow for running with a Yetus that is not a release build are broken. The gist from that ticket is that at some point, Yetus restructured its {{precommit/src}} module and now paths are broken. In a discussion, [~busbey] mentioned that we should not assume that test-patch can be run directly from a source checkout and probably the automation should instead depend on (or perform) a build of the specified Yetus sources before consuming them. Thus this ticket documents the issue." Remove deprecated createTableDescriptor(String) from HBaseTestingUtility,13282554,Resolved,Minor,Fixed,31/Jan/20 08:36,25/Feb/20 20:12,3.0.0-alpha-1,{{createTableDescriptor(String)}} in {{HBaseTestingUtility}} was deprecated back in 2.0.0 and should be removed for 3.0.0. Addition to Supporting projects page,13277141,Resolved,Minor,Fixed,02/Jan/20 06:28,03/Jan/20 10:54,,"At [Flipkart|https://flipkart.com/], we are using a light-weight ORM wrapper on top of hbase-client: [hbase-orm|https://github.com/flipkart-incubator/hbase-orm] (open source, Apache 2.0 license) It helps Java applications interact with HBase in an object-oriented manner, by encapsulating {{Get}}, {{Put}}, {{Delete}}, {{Append}}, {{Increment}} and other classes in hbase-client.   It's published on Maven Central: [https://search.maven.org/search?q=g:com.flipkart%20AND%20a:hbase-object-mapper&core=gav] Kindly list this as supporting project. PR to follow.  " "Github Precommit summary should include link to archived personality file, instead of a workspace path",13286290,Open,Minor,,19/Feb/20 18:09,,,Path to the personality file isn't terribly useful to anyone in its current form. Would be better if this file were archived with the build and the report modified to include the archive path. Screenshot attached. TestEntityLocks often fails in lower resource envs in testEntityLockTimeout,13285215,Open,Minor,,13/Feb/20 23:39,,,"The test waits for something to happen and if the computer is a little slow, it will fail on line 178. Doing a check against 3 instead 2x seems to help a lot to start." Remove unnecessary Configuration instantiation in LossyAccounting,13283565,Resolved,Minor,Fixed,05/Feb/20 20:04,13/Feb/20 01:36,,Mighty [~stack] pointed out over on HBASE-23801 that maybe {{LossyCounting}} doesn't need to be instantiating a {{Configuration}} instance in the first place. unable to communicate with localhost when setting up Kerberos-related tests,13282249,Open,Minor,,29/Jan/20 18:40,,,"[~ndimiduk] gave an ask over on HBASE-23760 to change some of the Hadoop-level configuration properties around secure cluster setup from localhost to 127.0.0.1. He and [~bharathv] have been chasing some issues with ZooKeeper and not having a resolution of localhost to 127.0.0.1. Before I start making a change, how sure are we that this is an issue? Assuming that it's the nightlies that we see these on, how about we make a change to increase the krb5 and spnego debugging to see if we aren't resolving names properly? There might be a debug property for DNS lookups in Java too.... maybe?" TestSecureRESTServer fails due to hostname mismatch,13282280,Open,Minor,,29/Jan/20 22:54,,2.3.0,"Above test fails reliably in a simpleVagrant/VirtualBox Ubuntu vm. {noformat} Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.005 s <<< FAILURE! - in org.apache.hadoop.hbase.rest.TestSecureRESTServer org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed: 0.001 s <<< ERROR! java.io.IOException: Failed on local exception: java.io.IOException: Couldn't setup connection for hbase/localhost@EXAMPLE.COM to localhost/127.0.0.1:45719; Host Details : local host is: ""bionic/10.0.2.15""; destination host is: ""localhost"":45719; at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:193) Caused by: java.io.IOException: Couldn't setup connection for hbase/localhost@EXAMPLE.COM to localhost/127.0.0.1:45719 at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:193) Caused by: javax.security.sasl.SaslException: GSS initiate failed at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:193) Caused by: org.ietf.jgss.GSSException: No valid credentials provided (Mechanism level: Message stream modified (41) - Message stream modified) at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:193) Caused by: sun.security.krb5.KrbException: Message stream modified (41) - Message stream modified at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:193) Caused by: sun.security.krb5.Asn1Exception: Identifier doesn't match expected value (906) at org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:193) {noformat}" [DOC] Fix the maths on the section explaining call queue tuning options,13283580,Resolved,Minor,Fixed,05/Feb/20 21:40,10/Feb/20 17:08,,"Section *""121.11. Tuning callQueue Options""* from the RefGuide has some mismatches when explaining the percentages applied by different values set to _hbase.ipc.server.callqueue.read.ratio_ and _hbase.ipc.server.callqueue.scan.ratio,_ respectively, such as: ??A value of {{.3}} {color:#ff0000}uses 30% of the queues for reading and 60% for writing{color}. Given a value of {{10}} for {{hbase.ipc.server.num.callqueue}}, 3 queues would be used for reads and 7 for writes.?? Should be: ??A value of {{.3}} {color:#00875a}uses 30% of the queues for reading and 70% for writing.{color} Given a value of {{10}} for {{hbase.ipc.server.num.callqueue}}, 3 queues would be used for reads and 7 for writes.??" Remove deprecated createLocalHTU(Configuration) from HBaseTestingUtility,13282457,Resolved,Minor,Fixed,30/Jan/20 19:17,07/Feb/20 08:52,3.0.0-alpha-1,{{createLocalHTU(Configuration)}} in {{HBaseTestingUtility}} was deprecated back in 2.0.0 and should be removed for 3.0.0. Support HBase getconf in hbase shell similar to hdfs,13281829,Open,Minor,,28/Jan/20 01:03,,,"Similar to HDFS getconf confkey -[key], HBase should provide a way to read configurations from HBase shell " Address tests writing and reading SSL/Security files in a common location.,13282870,Resolved,Minor,Fixed,02/Feb/20 20:54,04/Feb/20 22:43,,This is causing me issues with parallel test runs because multiple tests can write and read the same files in the test-classes directory. Some tests write files in test-classes instead of their test data directory so that they can put the files on the classpath. Remove deprecated getTimeStampOfLastShippedOp from MetricsSource,13282337,Resolved,Minor,Fixed,30/Jan/20 08:34,03/Feb/20 23:26,3.0.0-alpha-1,"{{MetricsSource}} defines the deprecated method {{getTimeStampOfLastShippedOp}}, which should be removed for 3.0.0." Add 'new on release line report' for git/jira audit tool,13282095,Resolved,Minor,Fixed,29/Jan/20 01:01,03/Feb/20 21:21,,"Codify building the summary of what's new on a release line branch (i.e., {{branch-2}}), but not yet released on earlier release branches of that line. Builds a cvs report that looks like [https://home.apache.org/~ndimiduk/new_for_branch-2.csv|https://home.apache.org/~ndimiduk/new_for_branch-2.csv]" "Remove deprecated createTableDescriptor(String, int, int, int, KeepDeletedCells) from HBaseTestingUtility",13282461,Resolved,Minor,Fixed,30/Jan/20 19:42,02/Feb/20 23:24,3.0.0-alpha-1,"{{createTableDescriptor(String, int, int, int, KeepDeletedCells)}} in {{HBaseTestingUtility}} was deprecated back in 2.0.0 and should be removed for 3.0.0." Remove deprecated createLocalHTU from HBaseTestingUtility,13282458,Resolved,Minor,Fixed,30/Jan/20 19:21,01/Feb/20 23:30,3.0.0-alpha-1,{{createLocalHTU()}} in {{HBaseTestingUtility}} was deprecated back in 2.0.0 and should be removed for 3.0.0. TestHFileCleaner can fail after addition of ManualMobMaintHFileCleaner,13281318,Open,Minor,,24/Jan/20 01:20,,2.2.3,"After https://github.com/apache/hbase/commit/a881678ef4e0ffcd94add935729424c6e2567356 testHFileCleaning can fail due to some lazy directory creation in the test. ManualMobMaintHFileCleaner needs to get the table directory (and indirectly namespace) which can fail since the test itself only creates the file within the archive directory. It does not contain the archive/data/namespace/table/region/cf/ which the ManualMobMaintHFileCleaner expects. This is a relatively minor issue, but we saw this test fail when running on EC2 because we had an 'invalid namespace' (because it had a '-' in the path). FYI [~busbey]" Upgrade JUnit to 4.13,13278215,Resolved,Minor,Fixed,08/Jan/20 17:45,14/Jan/20 00:55,,"New JUnit released a week ago. Let's give it a spin. https://github.com/junit-team/junit4/blob/master/doc/ReleaseNotes4.13.md" Upgrade checkstyle and plugin versions,13279961,Resolved,Minor,Fixed,16/Jan/20 18:53,18/Jan/20 01:11,,"Our checkstyle version is pretty antiquated. Update it, and pull in the latest version of the maven plugin as well." Upgrade checkstyle and plugin versions for hbase-operator-tools,13280621,Open,Minor,,20/Jan/20 22:21,,,The Checkstyle version should be updated to a newer version (currently 8.28). To get this working also an update of the HBase version to at least 2.3.0 is necessary. Upgrade checkstyle and plugin versions for hbase-connectors,13280620,Open,Minor,,20/Jan/20 22:17,,,The Checkstyle version should be updated to a newer version (currently 8.28). To get this working also an update of the HBase version to at least 2.3.0 is necessary. Expose content of meta table in web ui,13277777,Resolved,Minor,Fixed,06/Jan/20 20:10,18/Jan/20 08:38,,"While testing improvements to hbck2, breaking and fixing a cluster's region assignments, we've found that quite a few questions can only be answered by dropping into a shell and scanning meta. This is in contrast to the nice web view we have on procedures and their locks. It would be nice to have a similar view into the content of meta. I've put together and extension to the existing {{table.jsp}} that does this. It's had a couple rounds of operator feedback. Will post up some screenshots along with the PR." Split unit tests from TestTableName into a separate test only class,13278240,Resolved,Minor,Fixed,08/Jan/20 19:46,17/Jan/20 17:53,,"The class {{TestTableName}} in hbase-common is both a unit test for the {{TableName}} class, and a junit {{TestRule}}. This double-duty is strange; the Rule functionality is not discoverable at all. Split the Rule out into a separate class, maybe {{TableNameRule}} or some such." region.jsp returns 500/NPE when provided encoded region name is not online,13278771,Resolved,Minor,Fixed,10/Jan/20 18:11,15/Jan/20 11:43,2.2.3,Noticed while testing for HBASE-23653. A link off to a region that is closed or otherwise not in the region server's online region map results in a 500. Update docs for setting up IntelliJ as a development environment,13279458,Resolved,Minor,Fixed,14/Jan/20 23:01,15/Jan/20 17:12,, Reduce number of Checkstyle violations in hbase-mapreduce,13277348,Resolved,Minor,Fixed,03/Jan/20 11:07,12/Jan/20 22:24,,In {{hbase-mapreduce}} Checkstyle reports a lot of violations. The number of violations should be reduced. Allow dot and hyphen in Profiler's URL,13278148,Resolved,Minor,Fixed,08/Jan/20 12:16,09/Jan/20 09:47,2.1.5,"ProfileOutputServlet sanitizes the input URL but fails when the query string contains dot or hyphen. These are valid characters for the hostname. Example URL part: /prof-output/async-prof-pid-122466-cpu-1.svg?host=myhost-1.example.com&port=16010  In this case the user gets the following error message: {noformat} HTTP ERROR: 500 Problem accessing /prof-output/async-prof-pid-122466-cpu-1.svg. Reason: java.lang.RuntimeException: Non-alphanumeric data found in input, aborting. Powered by Jetty:// 9.3.27.v20190418 {noformat}" hbase:meta's table.jsp ref to wrong rs address ,13278105,Resolved,Minor,Fixed,08/Jan/20 09:22,09/Jan/20 02:41,2.2.3,"/rs-status/""><%= StringEscapeUtils.escapeHtml4(hostAndPort) %> Click the link it returns error. {code} HTTP ERROR 404 Problem accessing /rs-status/. Reason: Not Found {code} " DeadServer cleanup,13277245,Resolved,Minor,Fixed,02/Jan/20 17:39,03/Jan/20 04:26,,"Cleanup of DeadServer class shutting down access, undoing duplication, adding doc., and removing unused code. One change is that we do not remove a server from 'processing' list when we 'remove' deadservers; we let SCP do it since it owns processing list (Saw issue where on fast restart of a server, the server was removed from deadserver and from processing list though the SCP for the dead server was still running -- no repercussions that I could see but a little confusing)." synchronizedList-related defect in HBaseFsck,13277176,Open,Minor,,02/Jan/20 10:04,,,"org.apache.hadoop.hbase.util.HBaseFsck: {{orphanHdfsDirs}} could be iterated in {{adoptHdfsOrphans()}} in parallel with modification. The body of the {{adoptHdfOrphans()}} should be wrapped with {{synchronized (orphanHdfsDirs) {}}}.  " Log networks and bind addresses when multicast publisher/listener enabled,13285517,Closed,Trivial,Fixed,15/Feb/20 17:13,11/Aug/20 03:59,,Log details on publisher and listeners at DEBUG level so can figure issues when client and server do not match. Add null checks and logging to misc set of tests,13284036,Resolved,Trivial,Fixed,07/Feb/20 23:11,26/Aug/20 03:58,,"I've been studying unit tests of late. A few are failing but then the output is missing a detail or shutdown complains of NPE because startup didn't succeed. Here are super minor items I've been carrying around that I'd like to land. They do not change the function of tests (there is an attempt at a fix of TestLogsCleaner). * TestFullLogReconstruction log the server we've chosen to expire and then note where we starting counting rows * TestAsyncTableScanException use a define for row counts; count 100 instead of 1000 and see if helps * TestRawAsyncTableLimitedScanWithFilter check connection was made before closing it in tearDown * TestLogsCleaner use single mod time. Make it for sure less than now in case test runs all in the same millisecond (would cause test fail) * TestReplicationBase test table is non-null before closing in tearDown " Add debug+fix to TestMasterShutdown,13294085,Resolved,Trivial,Fixed,26/Mar/20 05:41,25/Aug/20 00:59,,Temporarily add debug to TestMasterShutdown overnight to learn more about a test failure not reproducible locally. Fix typo in procedures.jsp,13284134,Resolved,Trivial,Fixed,09/Feb/20 13:22,10/Feb/20 02:03,,"I think there's a typo.In hbase-server/src/main/resources/hbase-webapps/master/procedures.jsp. The Sentences ""We do not list Procedures that have completed SUCCESSfully; their number makes it hard to spot the problematics."" are misspelled and need to be corrected as ""We do not list procedures that have completed successfully; their number makes it hard to spot the problematics.""" "Modify ""Block locality"" of RegionServer Web UI to human readable percentage",13285775,Resolved,Trivial,Fixed,17/Feb/20 12:39,18/Feb/20 02:16,,"The unit of ""Block locality"" in Web UI just like picture 1 !image-2020-02-17-20-36-50-084.png! I think we should change it to percentage unit like picture 2 !image-2020-02-17-20-38-52-990.png!  " Change bytes size to human readable size for Server Metrics of RegionServer Web UI,13285580,Resolved,Trivial,Fixed,16/Feb/20 11:31,17/Feb/20 01:21,,"I found that the “BytesBufferAllocator Status” in RegionServer Web UI still using ""Bytes"" as a fixture unit. I think we should use ""MB"" or ""GB"" when the size is too large !image-2020-02-16-19-23-39-432.png!   The Web UI after improvement: !image-2020-02-16-19-28-23-449.png!" More test classifications,13286151,Resolved,Trivial,Fixed,19/Feb/20 05:02,11/Aug/20 04:00,, Add WebUI to Canary,13291861,Resolved,Trivial,Fixed,16/Mar/20 01:16,14/Apr/20 23:18,3.0.0-alpha-1,"During the running of Canary, the table sniff failure information will be printed through the Log. {code:java} LOG.error(""Read from {} on {}"", table, server); {code}   I think we can use WebUI to display these failures to make it easier for us to view this information   !image-2020-03-16-09-12-00-595.png! As shown in the figure above, we can directly see the Table and Regionserver where the error occurred" DEBUG logging cleanup,13279418,Resolved,Trivial,Fixed,14/Jan/20 18:20,15/Jan/20 06:09,2.3.0,"Minor cleanup of annoying loggings. For example, over an hour, we logged this 200k times: {code}2020-01-14 11:06:00,287 DEBUG org.apache.hadoop.hbase.master.cleaner.LogCleaner: Exiting {code} There is no corresponding 'Starting'." Adding debug logging to a few ExportSnapshot tests,13285199,Resolved,Trivial,Fixed,13/Feb/20 21:35,13/Feb/20 21:57,,Bit of extra logging in tests to help me diagnose where they are going wrong. Backport HBASE-23561 to branch-2,13291201,Resolved,Trivial,Won't Do,12/Mar/20 00:30,07/Apr/20 04:00,, Fix TestAdminShell and TestQuotasShell mistakenly broken by parent commit,13291750,Resolved,Trivial,Fixed,14/Mar/20 22:04,31/Mar/20 13:35,,"Minor fix... " "Add in comments, minor refactorings, and review feedback from parent HBASE-23984",13292771,Open,Trivial,,19/Mar/20 19:21,,,"Add in comments and address code feedback from parent issue WITHOUT changing functionality. Parent got a lot of good feedback and in interests of getting a bug fix committed, the bulk of the original parent patch was postponed. This issue is about landing innocuous changes that help w/ readability and to pick up some of the feedback on original PR." Include hadoop version in Nightly report name,13292271,Resolved,Trivial,Fixed,17/Mar/20 20:13,17/Mar/20 21:52,2.3.0,"A minor thing I missed in HBASE-23876. Have this report name match the other ""JDKX, HadoopY"" report names." Backport HBASE-23561 to branch-1,13291200,Resolved,Trivial,Not A Bug,12/Mar/20 00:29,12/Mar/20 16:15,, Announce user-zh list,13282448,Resolved,Trivial,Fixed,30/Jan/20 18:19,01/Feb/20 00:36,,Let folks know about the new user-zh list that is dedicated for user questions in chinese (as opposed to the norm of english on user) Remove unused variables from HBaseSaslRpcServer,13289871,Resolved,Trivial,Fixed,05/Mar/20 17:13,06/Mar/20 10:24,2.3.0,"On *HBaseSaslRpcServer*, there's currently an unused _Logger_ variable, as well as an unused _Configuration_ parameter defined on *HBaseSaslRpcServer* constructor. *HBaseSaslRpcServer* is IA private, and its constructor is only referenced by *ServerRpcConnection,* so it should be fine to change constructor signature to get rid of the unused parameter." Documentation update of external_apis.adoc#example-scala-code,13285571,Resolved,Trivial,Fixed,16/Feb/20 09:52,21/Feb/20 21:10,,"Update the Example Scala Code in the Reference Guide as it contains deprecated content such as * new HBaseConfiguration() * new HTable(conf, ""mytable"") * add(Bytes.toBytes(""ids""),Bytes.toBytes(""id1""),Bytes.toBytes(""one"")) Replace it with: * HBaseConfiguration.create() * TableName.valueOf({color:#6a8759}""mytable""{color}) * addColumn(Bytes.toBytes({color:#6a8759}""ids""{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}""id1""{color}){color:#cc7832},{color}Bytes.toBytes({color:#6a8759}""one""{color}))" [Flakey Test] TestRegionReplicaFailover fails frequently,13286657,Resolved,Trivial,Incomplete,21/Feb/20 06:12,21/Feb/20 17:40,2.3.0,"Fails > 50% of the time in the GCE runs since we upped their ferocity a few days ago. Looking, the complaints are weirdly often OOME, can't create thread. Looking, it at least does start of a RS at end of a test when it kills one EVEN THOUGH the @before starts a whole new cluster. This improves general resource usage going by the resource dumps before and after but still loads of leaking. Cut down on the amount of work it does too. Let me push small patch and see if helps." Get surefire version from parent pom rather than define it in hbase-archetypes,13284033,Resolved,Trivial,Fixed,07/Feb/20 22:56,08/Feb/20 17:20,,"Minor, minor issue. Remove version specification when should be inheriting from parent." [DOC] HBase Web UI runs on different port,13282066,Resolved,Trivial,Not A Problem,28/Jan/20 21:56,29/Jan/20 18:22,,"Just started to work through the ref guide and started up the stand-alone setup. The guide mentions to look up [http://localhost:16010/] for the HBase Web UI, but there is no process listening to that port.    After checking netstat and logs I've discovered, that the UI runs on port 43105   {code} 2020-01-28 22:17:43,658 INFO [main] http.HttpServer: Jetty bound to port 43105 2020-01-28 22:17:43,658 INFO [main] mortbay.log: jetty-6.1.26 2020-01-28 22:17:43,697 INFO [main] mortbay.log: Started SelectChannelConnector@0.0.0.0:4310 {code}" Checkstyle plugin complains about our checkstyle.xml format; doc how to resolve mismatched version,13279508,Resolved,Trivial,Fixed,15/Jan/20 07:06,17/Jan/20 22:55,,"Trying to add the checkstyle.xml to the intellij checkstyle plugin after reading HBASE-23688, it complains with the following when it reads in the config file: {code} com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:473) at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198) at org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:61) at org.infernus.idea.checkstyle.service.cmd.OpCreateChecker.execute(OpCreateChecker.java:26) at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.executeCommand(CheckstyleActionsImpl.java:130) at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:60) at org.infernus.idea.checkstyle.service.CheckstyleActionsImpl.createChecker(CheckstyleActionsImpl.java:51) at org.infernus.idea.checkstyle.checker.CheckerFactoryWorker.run(CheckerFactoryWorker.java:46) Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. at com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:147) at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198) at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:468) ... 7 more {code} " Too many rit page Numbers show confusion,13278696,Resolved,Trivial,Fixed,10/Jan/20 11:23,15/Jan/20 21:58,3.0.0-alpha-1,"Too much rits can cause page rendering clutter, which can be resolved by adding pagers." Column family ns does not exist in region during upgrade to 3.0.0-beta-2,13568947,Resolved,Blocker,Fixed,17/Feb/24 22:30,10/Mar/24 08:46,3.0.0-beta-1,"Upgrading from 2.5.x to 3.0.0-alpha-2, migrateNamespaceTable kicks in to copy data from the namespace table to an ""ns"" family of the meta table. If you don't have an ""ns"" family, the migration fails and the hmaster will crash loop. You then can't rollback, because the briefly alive upgraded hmaster created a procedure that can't be deserialized by 2.x (I don't have this log handy unfortunately). I tried pushing code to create the ns family on startup, but it doesnt work becuase the migration happens while the hmaster is still initializing. So it seems imperative that you create the ns family before upgrading. We should handle this more gracefully." HBase Restore restores old data if data for the same timestamp is in different hfiles,13573077,Resolved,Blocker,Fixed,23/Mar/24 21:04,26/Mar/24 14:50,,"The restore brings back 'old' data when executing restore. It feels like the hfile sequence id is not respected during the restore. See testing code attached. The workaround solution is to trigger major compaction before doing the backup (not really feasible for daily backups) We didn't investigate this yet, but this might also impact the merge of multiple incremental backups (since that follows a similar code path merging hfiles). This currently blocks our support for HBase backup and restore. Willing to participate in a solution if necessary." Bump org.apache.zookeeper:zookeeper from 3.8.3 to 3.8.4,13572250,Resolved,Blocker,Fixed,18/Mar/24 14:00,21/Mar/24 04:13,, Add BootstrapNodeService handlers,13564893,Resolved,Blocker,Fixed,16/Jan/24 17:17,18/Jan/24 14:06,2.6.0,"We added calls to a BootstrapNodeService, but the servers are not setup to serve it. We need to add in two places: * RSRPCServices list of services: [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L1447] * HBasePolicyProvider mapping of acl to service: [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java#L40] Without adding to these two places, you first see UnknownServiceExceptions and then you see AccessDeniedExceptions  " Aborting Active HMaster is not rejecting remote Procedure Reports,13570796,Resolved,Critical,Fixed,05/Mar/24 08:53,05/Jun/24 14:42,2.4.17,"When the Active Hmaster is in the process of abortion and another HMaster is becoming Active HMaster,at the same time if any region server reports the completion of the remote procedure, it generally goes to the old active HMaster because of the cached value of rssStub -> [code|https://github.com/apache/hbase/blob/branch-2.5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L2829] ([caller method|https://github.com/apache/hbase/blob/branch-2.5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java#L3941]). On the Master side ([code|https://github.com/apache/hbase/blob/branch-2.5/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java#L2381]), It did check if the service is started but that returns true if the master is in the process of abortion(I didn't see when we are setting this flag false while abortion).   This issue becomes *critical* when *ServerCrash of meta hosting RS and master failover* happens at the same time and hbase:meta got stuck in the offline state. Logs for abortion start of HMaster  {noformat} 2024-02-02 07:33:11,581 ERROR [PEWorker-6] master.HMaster - ***** ABORTING master server4-1xxx,61000,1705169084562: FAILED persisting region=52d36581218e00a2668776cfea897132 state=CLOSING *****{noformat} {noformat} 2024-02-02 07:33:40,999 INFO [master/server4-1xxx:61000] regionserver.HRegionServer - Exiting; stopping=hbase2b-mnds4-1-ia2.ops.sfdc.net,61000,1705169084562; zookeeper connection closed.{noformat} it took almost 30 seconds to abort the HMaster.   Logs of starting SCP for meta carrying host. (This SCP is started by the new active HMaster) {noformat} 2024-02-02 07:33:32,622 INFO [aster/server3-1xxx61000:becomeActiveMaster] assignment.AssignmentManager - Scheduled ServerCrashProcedure pid=3305546 for server5-1xxx61020,1706857451955 (carryingMeta=true) server5-1- xxx61020,1706857451955/CRASHED/regionCount=1/lock=java.util.concurrent.locks.ReentrantReadWriteLock@1b0a5293[Write locks = 1, Read locks = 0], oldState=ONLINE.{noformat} initialization of remote procedure {noformat} 2024-02-02 07:33:33,178 INFO [PEWorker-4] procedure2.ProcedureExecutor - Initialized subprocedures=[{pid=3305548, ppid=3305547, state=RUNNABLE; SplitWALRemoteProcedure server5-1- xxxxt%2C61020%2C1706857451955.meta.1706858156058.meta, worker=server4-1-xxxx,61020,1705169180881}]{noformat} Logs of remote procedure handling on Old Active Hmaster(server4-1xxx,61000) (in the process of abortion) {noformat} 2024-02-02 07:33:37,990 DEBUG [r.default.FPBQ.Fifo.handler=243,queue=9,port=61000] master.HMaster - Remote procedure done, pid=3305548{noformat} This should be handled by the new active HMaster so that it can wake up the suspended Procedure on the new Active Hmaster. As the new ActiveHMaster was not able to wake that up, SCP procedure got stuck thus meta stayed OFFLINE.    Logs of Hmaster trying to becomeActivehmaster but stuck- {noformat} 2024-02-02 07:33:43,159 WARN [aster/server3-1-ia2:61000:becomeActiveMaster] master.HMaster - hbase:meta,,1.1588230740 is NOT online; state={1588230740 state=OPEN, ts=1706859212481, server=server5-1-xxx,61020,1706857451955}; ServerCrashProcedures=true. Master startup cannot progress, in holding-pattern until region onlined.{noformat} After this master was stuck till we did hmaster failover to come out of this situation. " RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server,13565178,Resolved,Critical,Fixed,18/Jan/24 02:37,28/Feb/24 15:23,,"After introducing RpcConnectionRegistry, we let master and region server both implement ClientMetaService. In our current client architecture, when security is enabled, we rely on the record in SecurityInfo to determine the server principal to use, unfortunately there is only one principal can be specified, so if we use different principal for master and region server, either we can not connect to master, or we can not connect to region server. And just changing the server principal field in SecurityInfo to an array can not solve the problem, as when connecting, we do not know whether the remote server is a master or region server, so we still can not determine which principal to use... Anyway, since this has been in our code base since 2.5.0, it is not a new problem, so just set it as critical, not a blocker. But we should find out the solution ASAP." Cleaning up binary assemblies and diagnostic tools,13571357,Resolved,Major,Fixed,09/Mar/24 06:21,11/Feb/25 11:41,3.0.0-beta-1,"As discussed on the mailing list, the current binary assembly has several problems.  The discussed improvements: * Provide assembly versions without transitive Hadoop dependencies * Remove test JARs and their dependencies from the assemblies * Move useful diagnostic tools into the runtime jars See [https://lists.apache.org/thread/s784s8778cys2vx0scbd28cl2lm1g6vt] for details." Update assembly to create a tarball with hadoop and without hadoop,13571360,Resolved,Major,Fixed,09/Mar/24 07:23,28/Jan/25 05:30,,"The goal of this task is to update the HBase assembly by providing two distinct variants - one that includes Hadoop and one that does not. Currently, our assembly includes a substantial amount of the Hadoop distribution. This task involves modifying our build and assembly process to create two separate distributions of HBase: * A variant that includes Hadoop, serving as a complete package for users who do not have a pre-existing Hadoop installation. * A leaner variant without Hadoop, suitable for environments where Hadoop is already installed and configured. This change aims to reduce the distribution size, speed up startup times, and decrease the chance of conflicts with the Hadoop jars. It also aims to reduce the number of CVE-prone JARs in the binary assemblies. The task includes ensuring that both variants function correctly in their respective scenarios and that existing functionality is not negatively impacted. CC: [~stoty], [~zhangduo], [~ndimiduk], [~bbeaudreault]" "Backport ""HBASE-27693 Support for Hadoop's LDAP Authentication mechanism (Web UI only)"" to branch-2",13568424,Patch Available,Major,,14/Feb/24 12:13,,,"Hadoop's AuthenticationFilter has changed and now has support for ldap mechanism too. HBase still uses an older version tightly coupled with kerberos and spnego as the only auth mechanisms. HADOOP-12082 has added support for multiple auth handlers including LDAP. On trying to use Hadoop's AuthenticationFilterInitializer in hbase.http.filter.initializers, there is a casting exception as HBase requires it to extend org.apache.hadoop.hbase.http.FilterInitializer." Modify the assembly to not include test jars and their transitive dependencies,13571359,Resolved,Major,Fixed,09/Mar/24 07:18,11/Nov/24 05:43,,"This task aims to modify the HBase assembly to exclude test jars and their transitive dependencies. Currently, our assembly includes test jars and test dependencies, which adds unnecessary bloat to the assembly and classpath. This not only increases the distribution size but also potentially introduces CVE-prone JARs into the binary assemblies. The objective of this task is to modify the build and assembly process to exclude these test jars and their dependencies. This will result in a leaner, more secure assembly with a faster startup time. CC:  [~stoty], [~zhangduo], [~ndimiduk], [~bbeaudreault]" Enable maven-source-plugin for all modules,13564811,Resolved,Major,Fixed,16/Jan/24 07:05,22/Mar/24 03:59,2.4.17,"There is no source jar generated for hbase-server. Enabling maven-source-plugin seems to work fine, and Eclipse can use the generated sources jar for debugging etc. It seems that these source JARs are not generated at least since HBase 2.0.0, but we did have source JARs sometime in the 1.x time frame. " Remove ZooKeeper as a means of creating a client connection,13571727,Open,Major,,13/Mar/24 10:13,,4.0.0-alpha-1,"Following up the discussion and decision around HBASE-23324, we will remove ZooKeeper as a point of entry for client connections." Refactor tools which are under test packaging to a new module hbase-diagnostics,13571358,Resolved,Major,Fixed,09/Mar/24 07:17,16/Oct/24 09:03,,"The purpose of this task is to refactor and move certain tools currently located under the test packaging to a new module, named 'hbase-tools'. The following tools have been initially identified for relocation(will add more as and when identified): - [PerformanceEvaluation|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java] - [LoadTestTool|https://github.com/apache/hbase/blob/936d267d1094e37222b9b836ab068689ccce3574/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java] - [HFilePerformanceEvaluation|https://github.com/apache/hbase/blob/936d267d1094e37222b9b836ab068689ccce3574/hbase-server/src/test/java/org/apache/hadoop/hbase/HFilePerformanceEvaluation.java] - [ScanPerformanceEvaluation|https://github.com/apache/hbase/blob/936d267d1094e37222b9b836ab068689ccce3574/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/ScanPerformanceEvaluation.java] - [LoadBalancerPerformanceEvaluation|https://github.com/apache/hbase/blob/936d267d1094e37222b9b836ab068689ccce3574/hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/LoadBalancerPerformanceEvaluation.java] - [WALPerformanceEvaluation|https://github.com/apache/hbase/blob/936d267d1094e37222b9b836ab068689ccce3574/hbase-server/src/test/java/org/apache/hadoop/hbase/wal/WALPerformanceEvaluation.java] These tools are valuable beyond the scope of testing and should be accessible in the binary distribution of HBase. However, their current location within the test jars adds unnecessary bloat to the assembly and classpath, and potentially introduces CVE-prone JARs into the binary assemblies. We plan to remove all test jars from assembly with HBASE-28433. This task involves creating the new 'hbase-tools' module, and moving the identified tools into this module. It also includes ensuring that these tools function correctly in their new location and that their relocation does not negatively impact any existing functionality or dependencies. CC: [~stoty], [~zhangduo], [~ndimiduk], [~bbeaudreault]" Add support splitting region into multiple regions(more than 2),13571563,In Progress,Major,,12/Mar/24 06:01,,,"We have a requirement of splitting one region into multiple hundreds of regions at a time to distribute loading hot data. To do that we need split a region and wait for the completion of it and then again split the two regions etc..which is time consuming activity. Would be better to support splitting region into multiple regions more than two so that in single operation we can split the region. Todo that we need to take care 1)Supporting admin APIs to take multiple split keys 2)Implement new procedure to create new regions, creating meta entries and udpating them to meta 3) close the parent region and open split regions. 4) Update the compaction of post split and readers also to use the portion store file reader based on the range to scan than half store reader. 5) make sure the catalog jonitor also cleaning the parent regions when there are all the regions split properly." Support building hbase-connectors with JDK17,13569154,Patch Available,Major,,20/Feb/24 07:43,,, Expose checkQuota to Coprocessor Endpoints,13567647,Resolved,Major,Fixed,06/Feb/24 18:25,08/Oct/24 11:01,,"Coprocessor endpoints may do non-trivial amounts of work, yet quotas do not throttle them. We can't generically apply quotas to coprocessors because we have no information on what a particular endpoint might do. One thing we could do is expose checkQuota to the RegionCoprocessorEnvironment. This way, coprocessor authors have the tools to ensure that quotas cover their implementations. While adding this, we can update AggregationImplementation to call checkQuota since those endpoints can be quite expensive." Quota throttling can cause a leak of scanners,13569517,Resolved,Major,Fixed,22/Feb/24 14:38,08/Oct/24 13:13,,"In RSRpcServices.scan, we check the quota after having created a new RegionScannerHolder. If the quota is exceeded, an exception will be thrown. In this case, we can't send the scannerName back to the client because it's just an exception. So the client will be forced to retry the openScanner call, but the RegionScannerHolder is not closed. Eventually the scanners will be cleaned up by the lease expiration, but this could cause many scanners to leak during periods of high throttling. We could close the newly opened scanner before throwing the throttle exception, but I think it's better to not open the scanner at all until we've grabbed some quota." Expose CacheStats ageAtEviction histogram in jmx,13566562,Open,Major,,29/Jan/24 17:46,,,"In CacheStats we keep track of the ageAtEviction in a histogram. This is exposed in the UI, but not via jmx. Expose via jmx as well for easier tracking over time." Region Server crash in our production environment.,13571542,Resolved,Major,Duplicate,11/Mar/24 22:33,20/Sep/24 18:00,,"Recently we are seeing lot of RS crash in our production environment creating core dump file and hs_err_pid.log file. HBase: hbase-2.5 Java: openjdk 1.8 Copying contents from hs_err_pid.log below: {noformat} # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f9fb1415ba2, pid=50172, tid=0x00007f92a97ec700 # # JRE version: OpenJDK Runtime Environment (Zulu 8.76.0.18-SA-linux64) (8.0_402-b06) (build 1.8.0_402-b06) # Java VM: OpenJDK 64-Bit Server VM (25.402-b06 mixed mode linux-amd64 ) # Problematic frame: # J 19801 C2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyBufferToStream(Ljava/io/OutputStream;Ljava/nio/ByteBuffer;II)V (75 bytes) @ 0x00007f9fb1415ba2 [0x00007f9fb14159a0+0x202] # # Core dump written. Default location: /home/sfdc/core or core.50172 # # If you would like to submit a bug report, please visit: # http://www.azul.com/support/ # --------------- T H R E A D --------------- Current thread (0x00007f9fa2d13000): JavaThread ""RS-EventLoopGroup-1-92"" daemon [_thread_in_Java, id=54547, stack(0x00007f92a96ec000,0x00007f92a97ed000)] siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0x0000559869daf000 Registers: RAX=0x00007f9dbd8b6460, RBX=0x0000000000080000, RCX=0x000000000005c86b, RDX=0x00007f9dbd8b6460 RSP=0x00007f92a97eaf20, RBP=0x0000000000000002, RSI=0x00007f92d225e970, RDI=0x0000000000000069 R8 =0x000055986975f028, R9 =0x000000000064ffd8, R10=0x000000000000005f, R11=0x00007f94a778b290 R12=0x00007f9e62855ae8, R13=0x0000000000000000, R14=0x00007f9e5a14b1e0, R15=0x00007f9fa2d13000 RIP=0x00007f9fb1415ba2, EFLAGS=0x0000000000010216, CSGSFS=0x0000000000000033, ERR=0x0000000000000004 TRAPNO=0x000000000000000e Top of Stack: (sp=0x00007f92a97eaf20) 0x00007f92a97eaf20: 000000690064ff79 00007f9dbd8b6460 0x00007f92a97eaf30: 00007f9dbd8b6460 0000005700000003 0x00007f92a97eaf40: 00007f94a778b290 0004000100040000 0x00007f92a97eaf50: 00040000d090c130 00007f9db5522220 0x00007f92a97eaf60: 0008000000040001 00007f92a97eaf90 0x00007f92a97eaf70: 00007f92d0908648 0000000000000001 0x00007f92a97eaf80: 0000000000000001 000000000000005c 0x00007f92a97eaf90: 00007f94ee8078d0 0000000000000206 0x00007f92a97eafa0: 00007f9db5545a00 00007f9fafb63670 0x00007f92a97eafb0: 00007f9e5a13ed70 0000006900000001 0x00007f92a97eafc0: 00007f93ab8965b8 00007f93b9959210 0x00007f92a97eafd0: 00007f9db5545a00 00007f9fb04b3e30 0x00007f92a97eafe0: 00007f9e5a13ed70 00007f9300000001 0x00007f92a97eaff0: 00007f93ab8965b8 00007f93a8ae3920 0x00007f92a97eb000: 00007f93b9959210 00007f94a778b290 0x00007f92a97eb010: 00007f9b60707c20 00007f93a8938c28 0x00007f92a97eb020: 00007f94ee8078d0 00007f9b60708608 0x00007f92a97eb030: 00007f9b60707bc0 00007f9b60707c20 0x00007f92a97eb040: 0000000000000069 00007f93ab8965b8 0x00007f92a97eb050: 00007f94a778b290 00007f94a778b290 0x00007f92a97eb060: 0005c80d0005c80c 00000000a828a590 0x00007f92a97eb070: 00007f9e5a13ed70 000000010000270e 0x00007f92a97eb080: 00007f9db5545790 0144002200000000 0x00007f92a97eb090: 00007f95ddc800c0 00007f93ab89a6c8 0x00007f92a97eb0a0: 00007f93ae65c270 00007f9fb24af990 0x00007f92a97eb0b0: 00007f93ae65c290 00007f93ae65c270 0x00007f92a97eb0c0: 00007f9e5a13ed70 00007f92ca328528 0x00007f92a97eb0d0: 00007f9e5a13ed98 00007f9e5e1e88b0 0x00007f92a97eb0e0: 00007f92ca32d870 00007f9e5a13ed98 0x00007f92a97eb0f0: 00007f9e5e1e88b0 00007f93b9956288 0x00007f92a97eb100: 00007f9e5a13ed70 00007f9fb23c3aac 0x00007f92a97eb110: 00007f9317c9c8d0 00007f9b60708608 Instructions: (pc=0x00007f9fb1415ba2) 0x00007f9fb1415b82: 44 3b d7 0f 8d 6d fe ff ff 4c 8b 40 10 45 8b ca 0x00007f9fb1415b92: 44 03 0c 24 c4 c1 f9 7e c3 4d 8b 5b 18 4d 63 c9 0x00007f9fb1415ba2: 47 0f be 04 08 4d 85 db 0f 84 49 03 00 00 4d 8b 0x00007f9fb1415bb2: 4b 08 48 b9 10 1c be 10 93 7f 00 00 4c 3b c9 0f Register to memory mapping: RAX=0x00007f9dbd8b6460 is an oop java.nio.DirectByteBuffer - klass: 'java/nio/DirectByteBuffer' RBX=0x0000000000080000 is an unknown value RCX=0x000000000005c86b is an unknown value RDX=0x00007f9dbd8b6460 is an oop java.nio.DirectByteBuffer - klass: 'java/nio/DirectByteBuffer' RSP=0x00007f92a97eaf20 is pointing into the stack for thread: 0x00007f9fa2d13000 RBP=0x0000000000000002 is an unknown value RSI=0x00007f92d225e970 is pointing into metadata RDI=0x0000000000000069 is an unknown value R8 =0x000055986975f028 is an unknown value R9 =0x000000000064ffd8 is an unknown value R10=0x000000000000005f is an unknown value R11=0x00007f94a778b290 is an oop org.apache.hbase.thirdparty.io.netty.buffer.PooledUnsafeDirectByteBuf - klass: 'org/apache/hbase/thirdparty/io/netty/buffer/PooledUnsafeDirectByteBuf' R12=0x00007f9e62855ae8 is an oop java.lang.StringBuilder - klass: 'java/lang/StringBuilder' R13=0x0000000000000000 is an unknown value R14=0x00007f9e5a14b1e0 is an oop java.util.ArrayList$Itr - klass: 'java/util/ArrayList$Itr' R15=0x00007f9fa2d13000 is a thread Stack: [0x00007f92a96ec000,0x00007f92a97ed000], sp=0x00007f92a97eaf20, free space=1019k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) J 19801 C2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyBufferToStream(Ljava/io/OutputStream;Ljava/nio/ByteBuffer;II)V (75 bytes) @ 0x00007f9fb1415ba2 [0x00007f9fb14159a0+0x202] J 38915 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.write(Ljava/io/OutputStream;Z)I (21 bytes) @ 0x00007f9fafb63670 [0x00007f9fafb63620+0x50] J 37217 C2 org.apache.hadoop.hbase.KeyValueUtil.oswrite(Lorg/apache/hadoop/hbase/Cell;Ljava/io/OutputStream;Z)I (256 bytes) @ 0x00007f9fb04b3e30 [0x00007f9fb04b3de0+0x50] J 37223 C2 org.apache.hadoop.hbase.ipc.CellBlockBuilder.encodeCellsTo(Ljava/io/OutputStream;Lorg/apache/hadoop/hbase/CellScanner;Lorg/apache/hadoop/hbase/codec/Codec;Lorg/apache/hadoop/io/compress/CompressionCodec;)V (138 bytes) @ 0x00007f9fb24af990 [0x00007f9fb24af140+0x850] J 28122 C2 org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.writeRequest(Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelHandlerContext;Lorg/apache/hadoop/hbase/ipc/Call;Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (376 bytes) @ 0x00007f9fb2a4bac4 [0x00007f9fb2a4b600+0x4c4] J 28121 C2 org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.write(Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelHandlerContext;Ljava/lang/Object;Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (144 bytes) @ 0x00007f9fb15531d4 [0x00007f9fb1553140+0x94] J 41543 C2 org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.write(Ljava/lang/Object;ZLorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (149 bytes) @ 0x00007f9fb57da15c [0x00007f9fb57d96c0+0xa9c] J 39549 C2 org.apache.hadoop.hbase.ipc.HBaseRpcControllerImpl.notifyOnCancel(Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcCallback;Lorg/apache/hadoop/hbase/ipc/HBaseRpcController$CancellationCallback;)V (36 bytes) @ 0x00007f9fb42e2c44 [0x00007f9fb42e2520+0x724] J 39675 C2 org.apache.hadoop.hbase.ipc.NettyRpcConnection$$Lambda$135.run()V (16 bytes) @ 0x00007f9faeb56e3c [0x00007f9faeb56ac0+0x37c] J 24927 C2 org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(J)Z (109 bytes) @ 0x00007f9fb260a408 [0x00007f9fb2609fc0+0x448] J 25959% C2 org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run()V (603 bytes) @ 0x00007f9faf772248 [0x00007f9faf772000+0x248] j org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run()V+44 j org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run()V+11 j org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run()V+4 J 8122 C1 java.lang.Thread.run()V (17 bytes) @ 0x00007f9faf7920c4 [0x00007f9faf791f80+0x144] v ~StubRoutines::call_stub V [libjvm.so+0x6aa9d6] JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*)+0xea6 V [libjvm.so+0x6a7f73] JavaCalls::call_virtual(JavaValue*, KlassHandle, Symbol*, Symbol*, JavaCallArguments*, Thread*)+0x263 V [libjvm.so+0x6a8577] JavaCalls::call_virtual(JavaValue*, Handle, KlassHandle, Symbol*, Symbol*, Thread*)+0x57 V [libjvm.so+0x749f6c] thread_entry(JavaThread*, Thread*)+0x6c V [libjvm.so+0xae8613] JavaThread::thread_main_inner()+0x1f3 V [libjvm.so+0xae89ad] JavaThread::run()+0x36d V [libjvm.so+0x971532] java_start(Thread*)+0x102 C [libpthread.so.0+0x7ea5] start_thread+0xc5 {noformat} " AsyncProcess inconsistent exception thrown for operation timeout,13568138,Open,Major,,11/Feb/24 14:35,,2.0.0,"I'm not sure if I'll get to this, but wanted to log it as a known issue. AsyncProcess has a design where it breaks the batch into sub-batches based on regionserver, then submits a callable per regionserver in a threadpool. In the main thread, it calls waitUntilDone() with an operation timeout. If the callables don't finish within the operation timeout, a SocketTimeoutException is thrown. This exception is not very useful because it doesn't give you any sense of how many calls were in progress, on which servers, or why it's delayed. Recently we've been improving the adherence to operation timeout within the callables themselves. The main driver here has been to ensure we don't erroneously clear the meta cache for operation timeout related errors. So we've added a new OperationTimeoutExceededException, which is thrown from within the callables and does not cause a meta cache clear. The added benefit is that if these bubble up to the caller, they are wrapped in RetriesExhaustedWithDetailsException which includes a lot more info about which server and which action is affected.  Now we've covered most but not all cases where operation timeout is exceeded. So when exceeding operation timeout it's possible sometimes to see a SocketTimeoutException from waitUntilDone, and sometimes see OperationTimeoutExceededException from the callables. It will depend on which one fails first. It may be nice to finish the swing here, ensuring that we always throw OperationTimeoutExceededException from the callables. The main remaining case is in the call to locateRegion, which hits meta and does not honor the call's operation timeout (instead meta operation timeout). Resolving this would require some refactoring of ConnectionImplementation.locateRegion to allow passing an operation timeout and having that affect the userRegionLock and meta scan." BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached,13573358,Resolved,Major,Fixed,26/Mar/24 15:21,05/Apr/24 11:48,2.6.0,"Noticed that TestBucketCachePersister.testPrefetchBlockEvictionWhilePrefetchRunning was flakey, failing whenever the block eviction happened while prefetch was still ongoing. In the test, we pass an instance of BucketCache directly to the cache config, so the test is actually placing both data and meta blocks in the bucket cache. So sometimes, the test call BucketCache.notifyFileCachingCompleted after the it has already evicted two blocks.   Inside BucketCache.notifyFileCachingCompleted, we iterate through the backingMap entry set, counting number of blocks for the given file. Then, to consider whether the file is fully cached or not, we do the following validation: {noformat} if (dataBlockCount == count.getValue() || totalBlockCount == count.getValue()) { LOG.debug(""File {} has now been fully cached."", fileName); fileCacheCompleted(fileName, size); } {noformat} But the test generates 57 total blocks, 55 data and 2 meta blocks. It evicts two blocks and asserts that the file hasn't been considered fully cached. When these evictions happen while prefetch is still going, we'll pass that check, as the the number of blocks for the file in the backingMap would still be 55, which is what we pass as dataBlockCount. As BucketCache is intended for storing data blocks only, I believe we should make sure BucketCache.notifyFileCachingCompleted only accounts for data blocks. Also, the TestBucketCachePersister.testPrefetchBlockEvictionWhilePrefetchRunning should be updated to consistently reproduce the eviction concurrent to the prefetch.   " Interrupt cache prefetch thread when a heap usage threshold is reached,13564213,Resolved,Major,Fixed,10/Jan/24 15:19,06/Feb/24 20:14,2.4.17,"Mostly critical when using non heap cache implementations, such as offheap or file based. If the cache medium is too large and there are many blocks to be cached, it may create a lot of cache index object in the RegionServer heap. We should have guardrails to preventing caching from exhausting available heap." Make Delay prefetch property to be dynamically configured,13563658,Resolved,Major,Fixed,05/Jan/24 05:08,16/Apr/24 13:59,2.4.17,Make the prefetch delay configurable. The prefetch delay is associated to hbase.hfile.prefetch.delay configuration. There are some cases where configuring hbase.hfile.prefetch.delay would help in achieving better throughput.  Update Apache Parent POM to version 33,13569479,Open,Major,,22/Feb/24 10:03,,,Bump to https://github.com/apache/maven-apache-parent/releases/tag/apache-33 [JDK17] Jenkins build support for hbase-operator-tools,13570701,Open,Major,,04/Mar/24 16:07,,, Build hbase-thirdparty with JDK17,13569152,Open,Major,,20/Feb/24 07:42,,,"hbase-thirdparty fails to build with JDK 17. It fails for Unsafe module with following: {code:java} [INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 5.138 s] [INFO] Apache HBase Patched and Relocated (Shaded) Protobuf SUCCESS [ 17.888 s] [INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SUCCESS [02:19 min] [INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SUCCESS [ 46.429 s] [INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SUCCESS [ 1.021 s] [INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SUCCESS [ 8.435 s] [INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SUCCESS [ 4.972 s] [INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SUCCESS [ 11.526 s] [INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SUCCESS [ 1.421 s] [INFO] Apache HBase Unsafe Wrapper ........................ FAILURE [ 0.331 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 03:57 min [INFO] Finished at: 2024-02-16T07:20:20Z [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project hbase-unsafe: Compilation failure: Compilation failure: [ERROR] /workspace/hbase/hbase-unsafe/src/main/java/org/apache/hadoop/hbase/unsafe/HBaseUnsafeInternal.java:[259,18] cannot find symbol [ERROR] symbol: method defineClass(java.lang.String,byte[],int,int,java.lang.ClassLoader,java.security.ProtectionDomain) [ERROR] location: variable UNSAFE of type sun.misc.Unsafe [ERROR] /workspace/hbase/hbase-unsafe/src/main/java/org/apache/hadoop/hbase/unsafe/HBaseUnsafeInternal.java:[263,18] cannot find symbol [ERROR] symbol: method defineAnonymousClass(java.lang.Class,byte[],java.lang.Object[]) [ERROR] location: variable UNSAFE of type sun.misc.Unsafe [ERROR] -> [Help 1] {code} The code does not compile as there is a breaking change in JKD17 around unsafe usage: * [https://bugs.openjdk.org/browse/JDK-8266760] * [https://bugs.openjdk.org/browse/JDK-8199699] Need to raise a patch with changes for HBaseUnsafeInternal implementation such that it is compatible (with JDK8) and still works for JDK11 and JDK17." Support building hbase-operator-tools with JDK17,13569153,Resolved,Major,Fixed,20/Feb/24 07:43,04/Mar/24 16:06,, HBase backup yarn queue parameter ignored,13569340,Resolved,Major,Fixed,21/Feb/24 11:48,01/Aug/24 04:48,2.6.0,"It seems the parameter to specify the yarn queue for HBase backup (`-q`) is ignored: {code:java} hbase backup create full hdfs:///tmp/backups/hbasetest/hbase -q hbase-backup {code} gets executed on the ""default"" queue. Setting the queue through the configuration does work." Zookeeper ConnectionRegistry APIs should have timeout,13571204,Resolved,Major,Fixed,07/Mar/24 20:05,19/Jul/24 05:17,2.4.17,"Came across a couple of instances where active master failover happens around the same time as Zookeeper leader failover, leading to stuck HBase client if one of the threads is blocked on one of the ConnectionRegistry rpc calls.  ConnectionRegistry APIs are wrapped with CompletableFuture. However, their usages do not have any timeouts, which can potentially lead to the entire client in stuck state indefinitely as we take some global locks. For instance, _getKeepAliveMasterService()_ takes {_}masterLock{_}, hence if getting active master from _masterAddressZNode_ gets stuck, we can block any admin operation that needs {_}getKeepAliveMasterService(){_}.   Sample stacktrace that blocked all client operations that required table descriptor from Admin: {code:java} jdk.internal.misc.Unsafe.park java.util.concurrent.locks.LockSupport.park java.util.concurrent.CompletableFuture$Signaller.block java.util.concurrent.ForkJoinPool.managedBlock java.util.concurrent.CompletableFuture.waitingGet java.util.concurrent.CompletableFuture.get org.apache.hadoop.hbase.client.ConnectionImplementation.get org.apache.hadoop.hbase.client.ConnectionImplementation.access$? org.apache.hadoop.hbase.client.ConnectionImplementation$MasterServiceStubMaker.makeStubNoRetries org.apache.hadoop.hbase.client.ConnectionImplementation$MasterServiceStubMaker.makeStub org.apache.hadoop.hbase.client.ConnectionImplementation.getKeepAliveMasterService org.apache.hadoop.hbase.client.ConnectionImplementation.getMaster org.apache.hadoop.hbase.client.MasterCallable.prepare org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable org.apache.hadoop.hbase.client.HBaseAdmin.getTableDescriptor org.apache.hadoop.hbase.client.HTable.getDescriptororg.apache.phoenix.query.ConnectionQueryServicesImpl.getTableDescriptor org.apache.phoenix.query.DelegateConnectionQueryServices.getTableDescriptor org.apache.phoenix.util.IndexUtil.isGlobalIndexCheckerEnabled org.apache.phoenix.execute.MutationState.filterIndexCheckerMutations org.apache.phoenix.execute.MutationState.sendBatch org.apache.phoenix.execute.MutationState.send org.apache.phoenix.execute.MutationState.send org.apache.phoenix.execute.MutationState.commit org.apache.phoenix.jdbc.PhoenixConnection$?.call org.apache.phoenix.jdbc.PhoenixConnection$?.call org.apache.phoenix.call.CallRunner.run org.apache.phoenix.jdbc.PhoenixConnection.commit {code} Another similar incident is captured on PHOENIX-7233. In this case, retrieving clusterId from ZNode got stuck and that blocked client from being able to create any more HBase Connection. Stacktrace for referece: {code:java} jdk.internal.misc.Unsafe.park java.util.concurrent.locks.LockSupport.park java.util.concurrent.CompletableFuture$Signaller.block java.util.concurrent.ForkJoinPool.managedBlock java.util.concurrent.CompletableFuture.waitingGet java.util.concurrent.CompletableFuture.get org.apache.hadoop.hbase.client.ConnectionImplementation.retrieveClusterId org.apache.hadoop.hbase.client.ConnectionImplementation. jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance? jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance java.lang.reflect.Constructor.newInstance org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$? org.apache.hadoop.hbase.client.ConnectionFactory$$Lambda$?.run java.security.AccessController.doPrivileged javax.security.auth.Subject.doAs org.apache.hadoop.security.UserGroupInformation.doAs org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs org.apache.hadoop.hbase.client.ConnectionFactory.createConnection org.apache.hadoop.hbase.client.ConnectionFactory.createConnectionorg.apache.phoenix.query.ConnectionQueryServicesImpl.openConnection org.apache.phoenix.query.ConnectionQueryServicesImpl.access$? org.apache.phoenix.query.ConnectionQueryServicesImpl$?.call org.apache.phoenix.query.ConnectionQueryServicesImpl$?.call org.apache.phoenix.util.PhoenixContextExecutor.call org.apache.phoenix.query.ConnectionQueryServicesImpl.init org.apache.phoenix.jdbc.PhoenixDriver.getConnectionQueryServices org.apache.phoenix.jdbc.HighAvailabilityGroup.connectToOneCluster org.apache.phoenix.jdbc.ParallelPhoenixConnection.getConnection org.apache.phoenix.jdbc.ParallelPhoenixConnection.lambda$new$? org.apache.phoenix.jdbc.ParallelPhoenixConnection$$Lambda$?.get org.apache.phoenix.jdbc.ParallelPhoenixContext.lambda$chainOnConnClusterContext$? org.apache.phoenix.jdbc.ParallelPhoenixContext$$Lambda$?.apply  {code} We should provide configurable timeout for all ConnectionRegistry APIs." Introduce a close method for memstore for release active segment,13569709,Resolved,Major,Fixed,24/Feb/24 09:10,11/Mar/24 10:22,,"Per the analysis in parent issue, we will always have an active segment in memstore even if it is empty, so if we do not call close on it, it will lead to a netty leak warning message. Although there is no real memory leak for this case, we'd better still fix it as it may hide other memory leak problem." [JDK17] Update hbase-env.sh with alternates to JVM flags which are no longer supported,13569156,In Progress,Major,,20/Feb/24 08:07,,,"Some JVM flags like {{{}-XX:+PrintGCDetails{}}}, {{-XX:+PrintGCDateStamps}} etc. are no longer supported with JDK 17 and hbase would fail to start if these are passed. We should do an audit and update [https://github.com/apache/hbase/blob/master/conf/hbase-env.sh] to capture alternate/fix.  Will refer following for a fix/repalacement: * [https://stackoverflow.com/questions/54144713/is-there-a-replacement-for-the-garbage-collection-jvm-args-in-java-11] * [https://docs.oracle.com/javase/9/tools/java.htm#GUID-BE93ABDC-999C-4CB5-A88B-1994AAAC74D5__CONVERTGCLOGGINGFLAGSTOXLOG-A5046BD1]" "Warn: Cache key had block type null, but was found in L1 cache",13568356,Resolved,Major,Fixed,13/Feb/24 22:32,10/Jul/24 11:50,2.4.18,"I'm ITBLL testing branch-2.6 and am seeing lots of these warns. This is new to me. I would expect a warn to be on the rare side or be indicative of a problem, but unclear from the code. cc [~wchevreuil] " Update ref guide about the EOL for branch-2.4,13573945,Resolved,Major,Fixed,30/Mar/24 06:30,08/Jul/24 03:11,, Mark 2.4.x as EOL,13573943,Resolved,Major,Fixed,30/Mar/24 06:28,08/Jul/24 03:44,, create-release should spotless:apply after making any file changes,13570454,Resolved,Major,Fixed,01/Mar/24 10:09,21/Apr/24 12:20,4.0.0-alpha-1,"Looks like the release notes generator can sometimes leave whitespace in its changes, as is currently the case on branch-2.5. We should be a little more careful about this in the create-release scripts. Anything that performs and commits some change should run spotless:apply over the affected files." Remove jenkins files for branch-2.4,13573944,Resolved,Major,Fixed,30/Mar/24 06:29,21/Jun/24 07:06,, Allow specify cluster key without zookeeper in replication,13571145,Resolved,Major,Fixed,07/Mar/24 13:10,24/May/24 15:19,,"When reviewing the usage of zookeeper in HBase, I found out that, we still rely on zookeeper when specifying the cluster key when setting up replication. If we want to completely hide zookeeper from outside a cluster, we should also remove this cluster key." Add 2.4.18 to download page,13573941,Resolved,Major,Fixed,30/Mar/24 06:25,25/May/24 12:55,, Return too slow when scanning a table with non-existing REGION_REPLICA_ID,13572136,Open,Major,,17/Mar/24 02:09,,,"It takes more than 8 seconds to get the error result, and it's always like this every thime.   Reproduction Step:   1. Creating a table with region replica create 't01', 'info', \{REGION_REPLICATION => 2}   2. Scanning this table with a non-existing REGION_REPLICA_ID by CONSISTENCY.TIMELINE scan 't01', \{CONSISTENCY => ""TIMELINE"", REGION_REPLICA_ID => 2}   3. we would take more than 8s to get the error result. {code:java} hbase:010:0> scan 't01', {CONSISTENCY => ""TIMELINE"", REGION_REPLICA_ID => 2}ROW                                     COLUMN+CELL ERROR: No location for t01, row='', locateType=CURRENT, replicaId=2 For usage try 'help ""scan""' Took 8.2830 seconds {code}     " Release 2.4.18,13573939,Resolved,Major,Fixed,30/Mar/24 06:24,25/May/24 14:54,,"The 2.6.0 release vote is ongoing, let's release 2.4.18 and mark 2.4.x as EOL." Finish 2.4.18 release,13573942,Resolved,Major,Fixed,30/Mar/24 06:28,25/May/24 14:54,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Add xml to download page(via HBASE-28473) # Push tag 2.4.18RCx as tag rel/2.4.18 (/) # Release 2.4.18 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12353080 # Add release data on https://reporter.apache.org/addrelease.html?hbase # Send announcement email" Put up 2.4.18RC0,13573940,Resolved,Major,Fixed,30/Mar/24 06:24,25/May/24 10:03,, Integration of time-based priority caching into cacheOnRead read code paths.,13573669,Resolved,Major,Fixed,28/Mar/24 10:43,22/May/24 18:47,,"This Jira tracks the integration of time-based caching framework APIs into read code paths. Thanks, Janardhan  " Integration of time-based priority caching into compaction paths.,13573672,Resolved,Major,Fixed,28/Mar/24 10:53,22/May/24 14:16,,"The time-based priority caching is dependent on the date-tiered compaction that structures store files in date-based tiered layout. This Jira tracks the changes are needed for the integration of this compaction strategy with the data-tiering to enable appropriate caching of hot data in the cache, while the code data can remain the cloud storage. Thanks, Janardhan" Incremental backup can fail if log gets archived while WALPlayer is starting up,13573586,Open,Major,,27/Mar/24 21:01,,,"We had incremental backup fail with FileNotFoundException for a file in the WALs directory. Upon investigation, the log had been archived a few mins earlier. WALInputFormat's record reader has support for falling back on an archived path: {code:java} } catch (IOException e) { Path archivedLog = AbstractFSWALProvider.findArchivedLog(logFile, conf); // archivedLog can be null if unable to locate in archiveDir. if (archivedLog != null) { openReader(archivedLog); // Try call again in recursion return nextKeyValue(); } else { throw e; } } {code} But the getSplits method has different handling: {code:java} try { List files = getFiles(fs, inputPath, startTime, endTime); allFiles.addAll(files); } catch (FileNotFoundException e) { if (ignoreMissing) { LOG.warn(""File "" + inputPath + "" is missing. Skipping it.""); continue; } throw e; } {code} This ignoreMissing variable was added in HBASE-14141 and is enabled via  wal.input.ignore.missing.files which is defaulted to false and never set. Looking at the comment and reviewboard history of HBASE-14141 I think there might have been some confusion about where to handle these missing files, and this got lost in the shuffle.   I would prefer not to ignore missing hfiles. I think that could result in some weird behavior: * RegionServer has 10 archived and 30 not-yet-archived WALs needing to be backed up * The process starts, and while it's running 1 of those 30 WALs gets archived. That would get skipped due to FileNotFoundException * But the remaining 29 would be backed up This scenario could cause some data consistency issues if this incremental backup is restored. We missed some edits in the middle of applied edits from other WALs. So I do think failing as we do today is necessary for consistency, but unrealistic in a live cluster. The solution is to try finding the missing file in the archived directory. Backups has a coprocessor which will not allow the archived file to be cleaned up until it's backed up, so I think it's safe to say that a WAL is either definitely in WALs or oldWALs." TestBlockingIPC.testBadPreambleHeader sometimes fails with broken pipe instead of bad auth,13570661,Resolved,Major,Fixed,04/Mar/24 11:38,06/Mar/24 10:15,, Support to skip Kerberos authentication for metric endpoints,13563762,Open,Major,,06/Jan/24 05:25,,2.5.5,"Make HBase support to skip Kerberos authentication for metric endpoints. (e.g. /jvm, /prometheus, /metrics) Since HBase uses KerberoAuthenticationHandler.java, whitelist configuration can be used like [HADOOP-16527|https://issues.apache.org/jira/browse/HADOOP-16527].    " Use connection url to specify the connection registry information,13571484,Resolved,Major,Fixed,11/Mar/24 12:26,25/Apr/24 16:00,,"As describe in this email from [~ndimiduk] https://lists.apache.org/thread/98wqlkqvlnmpx3r7yrg9mw4pqz9ppofh The first advantage here is that, we can encode the connection registry implementation in the scheme of the connection url, so for replication, we can now support cluster key other than zookeeper, which is important for us to remove zookeeper dependency on our public facing APIs." Time Based Priority for BucketCache,13573614,In Progress,Major,,28/Mar/24 04:59,,,"This Jira introduces the feature of time-based data tiering in HBase to optimize storage efficiency and access performance by segregating data based on its recency. By keeping recent data in the bucket cache (backed by faster storage types like SSDs) and evicting older data, the system aims to provide a more flexible control over the cache allocation and eviction logic via configuration, allowing for defining time priorities for cached data.  The need for a more extensive cache allocation mechanism becomes even more critical on HBase deployments where cache access reflects on significant performance gains, such as when using cloud storage as the underlying file system. The data is segregated into hot or cold categories based on its age. The recent data within a specific time range (configured as hot-data-age) is treated as hot and is stored in the cache, while the older data is stored and accessed from the file system. This feature intends to provide the TCO gains by optimizing the utilization of high cost bucket cache. Perfect fit for the use cases that have the date-based data writes while the scans focus on the recently written data. Please find the detailed design document of the feature attached with the Jira. Thanks, Janardhan" CompressionTest hangs when run over a Ozone ofs path,13572523,Resolved,Major,Fixed,20/Mar/24 08:15,10/May/24 00:21,,"If we run the Compression test over HDFS path, it works fine: {code:java} hbase org.apache.hadoop.hbase.util.CompressionTest hdfs://ns1/tmp/dir1/dir2/test_file.txt snappy 24/03/20 06:08:43 WARN impl.MetricsConfig: Cannot locate configuration: tried hadoop-metrics2-hbase.properties,hadoop-metrics2.properties 24/03/20 06:08:43 INFO impl.MetricsSystemImpl: Scheduled Metric snapshot period at 10 second(s). 24/03/20 06:08:43 INFO impl.MetricsSystemImpl: HBase metrics system started 24/03/20 06:08:43 INFO metrics.MetricRegistries: Loaded MetricRegistries class org.apache.hadoop.hbase.metrics.impl.MetricRegistriesImpl 24/03/20 06:08:43 INFO compress.CodecPool: Got brand-new compressor [.snappy] 24/03/20 06:08:43 INFO compress.CodecPool: Got brand-new compressor [.snappy] 24/03/20 06:08:44 INFO compress.CodecPool: Got brand-new decompressor [.snappy] SUCCESS {code} The command exits, but when the same is tried over a ofs path, the command hangs. {code:java} hbase org.apache.hadoop.hbase.util.CompressionTest ofs://ozone1710862004/test-222compression-vol/compression-buck2/test_file.txt snappy 24/03/20 06:05:19 INFO protocolPB.OmTransportFactory: Loading OM transport implementation org.apache.hadoop.ozone.om.protocolPB.Hadoop3OmTransportFactory as specified by configuration. 24/03/20 06:05:20 INFO client.ClientTrustManager: Loading certificates for client. 24/03/20 06:05:20 WARN impl.MetricsConfig: Cannot locate configuration: tried hadoop-metrics2-hbase.properties,hadoop-metrics2.properties 24/03/20 06:05:20 INFO impl.MetricsSystemImpl: Scheduled Metric snapshot period at 10 second(s). 24/03/20 06:05:20 INFO impl.MetricsSystemImpl: HBase metrics system started 24/03/20 06:05:20 INFO metrics.MetricRegistries: Loaded MetricRegistries class org.apache.hadoop.hbase.metrics.impl.MetricRegistriesImpl 24/03/20 06:05:20 INFO rpc.RpcClient: Creating Volume: test-222compression-vol, with om as owner and space quota set to -1 bytes, counts quota set to -1 24/03/20 06:05:20 INFO rpc.RpcClient: Creating Bucket: test-222compression-vol/compression-buck2, with bucket layout FILE_SYSTEM_OPTIMIZED, om as owner, Versioning false, Storage Type set to DISK and Encryption set to false, Replication Type set to server-side default replication type, Namespace Quota set to -1, Space Quota set to -1 24/03/20 06:05:21 INFO compress.CodecPool: Got brand-new compressor [.snappy] 24/03/20 06:05:21 INFO compress.CodecPool: Got brand-new compressor [.snappy] 24/03/20 06:05:21 WARN impl.MetricsSystemImpl: HBase metrics system already initialized! 24/03/20 06:05:21 INFO metrics.MetricRegistries: Loaded MetricRegistries class org.apache.ratis.metrics.dropwizard3.Dm3MetricRegistriesImpl 24/03/20 06:05:22 INFO compress.CodecPool: Got brand-new decompressor [.snappy] SUCCESS . . .{code} The command doesnt exit. Attaching the jstack of the process below: [^hbase_ozone_compression.jstack] cc: [~weichiu]   " HFileOutputFormat2 ClassCastException with s3 magic committer,13573524,Resolved,Major,Fixed,27/Mar/24 12:36,07/May/24 13:14,,"In hadoop3 there's the s3 magic committer which can speed up s3 writes dramatically. In HFileOutputFormat2.createRecordWriter we cast the passed in committer as a FileOutputCommitter. This causes a class cast exception when the s3 magic committer is enabled:   {code:java} Error: java.lang.ClassCastException: class org.apache.hadoop.fs.s3a.commit.magic.MagicS3GuardCommitter cannot be cast to class org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter {code}   We can cast to PathOutputCommitter instead, but its only available in hadoop3+. So we will need to use reflection to work around this in branch-2." Add metric for GetClusterStatus request count.,13563751,Open,Major,,05/Jan/24 22:46,,,"We have been bitten multiple times by GetClusterStatus request overwhelming HMaster's memory usage. It would be good to add a metric for the total GetClusterStatus requests count. In almost all of our production incidents involving GetClusterStatus request, HMaster were running out of memory with many clients call this RPC in parallel and the response size is very big. In hbase2 we have [ClusterMetrics.Option|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ClusterMetrics.java#L164-L224] which can reduce the size of the response. It would be nice to add another metric to indicate if the response size of GetClusterStatus is greater than some threshold (like 5MB)" Region open procedure silently returns without notifying the parent proc,13570004,Resolved,Major,Fixed,27/Feb/24 12:47,29/Apr/24 09:17,2.4.17,"*We had a scenario in production where a merge operation had failed as below* _2024-02-11 10:53:57,715 ERROR [PEWorker-31] assignment.MergeTableRegionsProcedure - Error trying to merge [a92008b76ccae47d55c590930b837036, f56752ae9f30fad9de5a80a8ba578e4b] in table1 (in state=MERGE_TABLE_REGIONS_CLOSE_REGIONS)_ _org.apache.hadoop.hbase.HBaseIOException: The parent region state=MERGING, location=rs-229,60020,1707587658182, table=table1, region=f56752ae9f30fad9de5a80a8ba578e4b is currently in transition, give up_ _at org.apache.hadoop.hbase.master.assignment.AssignmentManagerUtil.createUnassignProceduresForSplitOrMerge(AssignmentManagerUtil.java:120)_ _at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.createUnassignProcedures(MergeTableRegionsProcedure.java:648)_ _at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.executeFromState(MergeTableRegionsProcedure.java:205)_ _at org.apache.hadoop.hbase.master.assignment.MergeTableRegionsProcedure.executeFromState(MergeTableRegionsProcedure.java:79)_ _at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188)_ _at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:922)_ _at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650)_ _at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396)_ _at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75)_ _at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1964)_ _at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)_ _at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1991)_ *Now when we do rollback of failed merge operation we see a issue where region is in state opened until the RS holding it stopped.* Rollback create a TRSP as below _2024-02-11 10:53:57,719 DEBUG [PEWorker-31] procedure2.ProcedureExecutor - Stored [pid=26674602, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=table1, region=a92008b76ccae47d55c590930b837036, ASSIGN]_ *and rollback finished successfully* _2024-02-11 10:53:57,721 INFO [PEWorker-31] procedure2.ProcedureExecutor - Rolled back pid=26673594, state=ROLLEDBACK, exception=org.apache.hadoop.hbase.HBaseIOException via master-merge-regions:org.apache.hadoop.hbase.HBaseIOException: The parent region state=MERGING, location=rs-229,60020,1707587658182, table=table1, region=f56752ae9f30fad9de5a80a8ba578e4b is currently in transition, give up; MergeTableRegionsProcedure table=table1, regions=[a92008b76ccae47d55c590930b837036, f56752ae9f30fad9de5a80a8ba578e4b], force=false exec-time=1.4820 sec_ *We create a procedure to open the region a92008b76ccae47d55c590930b837036. Intrestingly we didnt close the region as creation of procedure to close regions had thrown exception and not execution of procedure. When we run TRSP it sends a OpenRegionProcedure which is handled by AssignRegionHandler. This handlers on execution suggests that region is already online* Sequence of events are as follow _2024-02-11 10:53:58,919 INFO [PEWorker-58] assignment.RegionStateStore - pid=26674602 updating hbase:meta row=a92008b76ccae47d55c590930b837036, regionState=OPENING, regionLocation=rs-210,60020,1707596461539_ _2024-02-11 10:53:58,920 INFO [PEWorker-58] procedure2.ProcedureExecutor - Initialized subprocedures=[\\{pid=26675798, ppid=26674602, state=RUNNABLE; OpenRegionProcedure a92008b76ccae47d55c590930b837036, server=rs-210,60020,1707596461539}]_ _2024-02-11 10:53:59,074 WARN [REGION-regionserver/rs-210:60020-10] handler.AssignRegionHandler - Received OPEN for table1,r1,1685436252488.a92008b76ccae47d55c590930b837036. which is already online_" Integration of time-based priority caching logic into cache evictions.,13573671,Resolved,Major,Fixed,28/Mar/24 10:46,25/Apr/24 10:00,,"When the time-based priority caching is enabled, then, the block evictions triggered when the cache is full, should use the time-based priority caching framework APIs to detect the cold files and evict the blocks of those files first. This ensures that the hot data remains in cache while the cold data is evicted from cache. Thanks, Janardhan" Make replication ZKWatcher config customizable in extensions,13573630,Resolved,Major,Implemented,28/Mar/24 08:26,24/Apr/24 10:54,,The ZKWatcher in HBaseReplicationEndpoint always uses the source cluster's ZooKeeper client config when connecting to the target cluster's zk. Those might not match. I would like to make the used ZKClientConfig customizable for replication extensions. Missing null check of rpcServer.scheduler.executor causes NPE with invalid value of hbase.client.default.rpc.codec,13572741,Resolved,Major,Fixed,20/Mar/24 21:58,29/Mar/24 07:48,,"When `hbase.client.default.rpc.codec` is set to `org.apache.hadoop.hbase.regionserver.wal.SecureWALCellCodec` the method `createRpcClientRTEDuringConnectionSetup` gives a NoSuchMethodException for the provided default codec value.    Since there was an exception, the code inside try block is not executed which contained the below code line  {code:java} try (AbstractRpcClient client = createRpcClientRTEDuringConnectionSetup(clientConf)) {       rpcServer.start();       . . .     } {code}   When finally block is executed which contains  {code:java} finally {       rpcServer.stop();     } {code}   The method `rpcServer.stop()` eventually makes call to `executor.shutdown()`. A null pointer exception is returned as  `rpcServer.scheduler.executor`  was never instantiated, which happens inside `rpcServer.start()`   {code:java} java.lang.NullPointerException at org.apache.hadoop.hbase.ipc.FifoRpcScheduler.stop(FifoRpcScheduler.java:71) at org.apache.hadoop.hbase.ipc.SimpleRpcServer.stop(SimpleRpcServer.java:441) at org.apache.hadoop.hbase.ipc.AbstractTestIPC.testRTEDuringConnectionSetup(AbstractTestIPC.java:194){code}  " Expose DelegatingRpcScheduler as IA.LimitedPrivate,13565123,Resolved,Major,Fixed,17/Jan/24 17:26,18/Jan/24 12:57,,"We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible change from HBASE-27144. We can limit the impact of breaking changes like this by exposing DelegatingRpcScheduler to users. Users can extend this class and only override the pieces that they care about, thus reducing the surface area of compatibility issues." BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file,13572736,Resolved,Major,Fixed,20/Mar/24 20:39,28/Mar/24 09:36,2.6.0,"HBASE-27313, HBASE-27686 and HBASE-27743 have extended BucketCache persistent cache capabilities to make it resilient to RS crashes or non graceful stops, when using file based ioengine for BucketCache. BucketCache maintains two main collections for tracking blocks in the cache: backingMap and blocksByHFile. The former is used as the main index of blocks for the actual cache, whilst the latter is a set of all blocks in the cache ordered by name, in order to conveniently and efficiently retrieve the list of all blocks from a single file in the BucketCache.evictBlocksByHfile method.   The problem is that at cache recovery time, we are populating the blocksByHFile set, which causes any calls to BucketCache.evictBlocksByHfile method to not evict any blocks, once we have recovered the cache from the cache persistence file (for instance, after a n RS restart)." Integration of time-based priority logic of bucket cache in prefetch functionality of HBase.,13573667,Resolved,Major,Fixed,28/Mar/24 10:38,22/Apr/24 09:54,,"This Jira tracks the integration of the framework of APIs (implemented in HBASE-28465) related to data tiering into prefetch logic of HBase. The implementation should filter out the cold data and enable the prefetching of hot data into bucket cache. Thanks, Janardhan  " HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry,13564157,Resolved,Major,Fixed,10/Jan/24 06:35,18/Apr/24 10:34,2.5.6,"{{When I view the contents of the HFile through storeFile.jsp or hbase hfile -p -v xxxx, it will throw an exception similar to the following:}}   {{HTTP ERROR 500 java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram com.codahale.metrics.MetricRegistry.histogram(java.lang.String, com.codahale.metrics.MetricRegistry$MetricSupplier)'}} ||URI:|/storeFile.jsp| ||STATUS:|500| ||MESSAGE:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram com.codahale.metrics.MetricRegistry.histogram(java.lang.String, com.codahale.metrics.MetricRegistry$MetricSupplier)'| ||SERVLET:|org.apache.hadoop.hbase.generated.regionserver.storeFile_jsp| ||CAUSED BY:|java.lang.NoSuchMethodError: 'com.codahale.metrics.Histogram com.codahale.metrics.MetricRegistry.histogram(java.lang.String, com.codahale.metrics.MetricRegistry$MetricSupplier)'| I found that there were conflicting files in the lib folder, specifically metrics-core-3.0.1.jar and metrics-core-3.2.6.jar. After deleting metrics-core-3.0.1.jar, the functionality returned to normal." Add trust/key store type to ZK TLS settings handled by HBase,13567065,Resolved,Major,Fixed,01/Feb/24 16:32,15/Feb/24 14:28,2.4.17,"Let's add the following settings as well. Last time we missed it. {noformat} zookeeper.ssl.keyStore.type zookeeper.ssl.trustStore.type{noformat} Handle them in hbase-site.xml as: {noformat} hbase.zookeeper.property.ssl.keyStore.type hbase.zookeeper.property.ssl.trustStore.type{noformat}" do-release-docker fails to setup gpg agent proxy if proxy container is slow to start,13572966,Open,Major,,22/Mar/24 14:24,,,"In do-release-docker.sh we spin up the gpg-agent-proxy container and then immediately run ssh-keyscan and then immediately run ssh. Despite having {{{}set -e{}}}, both of these can fail without failing the script. This manifests as a really hard to debug failure in the hbase-rm container with ""gpg: no gpg-agent running in this session"" With some debugging I realized that the ssh tunnel had not been created. looking at the logs, the gpg-agent-proxy.ssh-keyscan file is empty and the gpg-proxy.ssh.log shows a Connection refused error. You'd think these would fail the script, but they don't for different reasons: # ssh-keyscan output is piped through sort. Running ssh-keyscan directly returns an error code, but piping it through sort turns it into a success code. # ssh is executed in background with {{{}&{}}}, which similarly loses the error code I think we should add a step prior to ssh-keyscan which waits until port 62222 is available. I'm not sure how to retain the error codes in the above 2 commands, but can try to look into that as well." Introduce a version field in file based tracker record,13573354,Resolved,Major,Fixed,26/Mar/24 14:43,07/Apr/24 10:39,,"Per the discussion around HBASE-27826 and the related design doc, we all agree that we should add version field to store file tracker, so when downgrading, we will know that we will miss something when reading a tracker file with higher version and fail the initialization, instead of ignore it silently and may cause data loss." Implementation of framework for time-based priority bucket-cache.,13573665,Resolved,Major,Fixed,28/Mar/24 10:33,08/Apr/24 15:25,,"In this Jira, we track the implementation of framework for the time-based priority cache. This framework would help us to get the required metadata of the HFiles and helps us make the decision about the hotness or coldness of data. Thanks, Janardhan" Decommissioned hosts should be rejected by the HMaster,13567426,Resolved,Major,Fixed,05/Feb/24 13:59,29/Feb/24 16:09,,"We had an issue with a cluster, internally at HubSpot, where a decommissioned RegionServer was still being picked up by the HMaster. The host the RegionServer was living on was impaired, and we couldn't correctly kill the RegionServer, so the HMaster would periodically hear back from the host and remove it from its dead host's list. We would like to implement a fix so that this doesn't happen. We're thinking of adding a boolean flag to the Decommission RegionServer Admin API that signifies ignoring the startcode of the servername, when the boolean is True the host will be rejected every time it comes back even if it had a different startcode." Mis-order of SCP and regionServerReport results into region inconsistencies,13568367,Resolved,Major,Fixed,14/Feb/24 03:41,05/Apr/24 05:16,2.4.17,"If the regionserver is online but due to network issue, if it's rs ephemeral node gets deleted in zookeeper, active master schedules the SCP. However, if the regionserver is alive, it can still send regionServerReport to active master. In the case where SCP assigns regions to other regionserver that were previously hosted on the old regionserver (which is still alive), the old rs can continue to sent regionServerReport to active master. Eventually this results into region inconsistencies because region is alive on two regionservers at the same time (though it's temporary state because the rs will be aborted soon). While old regionserver can have zookeeper connectivity issues, it can still make rpc calls to active master. Logs: SCP: {code:java} 2024-01-29 16:50:33,956 INFO [RegionServerTracker-0] assignment.AssignmentManager - Scheduled ServerCrashProcedure pid=9812440 for server1-114.xyz,61020,1706541866103 (carryingMeta=false) server1-114.xyz,61020,1706541866103/CRASHED/regionCount=364/lock=java.util.concurrent.locks.ReentrantReadWriteLock@5d5fc31[Write locks = 1, Read locks = 0], oldState=ONLINE. 2024-01-29 16:50:33,956 DEBUG [RegionServerTracker-0] procedure2.ProcedureExecutor - Stored pid=9812440, state=RUNNABLE:SERVER_CRASH_START; ServerCrashProcedure server1-114.xyz,61020,1706541866103, splitWal=true, meta=false 2024-01-29 16:50:33,973 INFO [PEWorker-36] procedure.ServerCrashProcedure - Splitting WALs pid=9812440, state=RUNNABLE:SERVER_CRASH_SPLIT_LOGS, locked=true; ServerCrashProcedure server1-114.xyz,61020,1706541866103, splitWal=true, meta=false, isMeta: false {code} As part of SCP, d743ace9f70d55f55ba1ecc6dc49a5cb was assigned to another server:   {code:java} 2024-01-29 16:50:42,656 INFO [PEWorker-24] procedure.MasterProcedureScheduler - Took xlock for pid=9818494, ppid=9812440, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=PLATFORM_ENTITY.PLATFORM_IMMUTABLE_ENTITY_DATA, region=d743ace9f70d55f55ba1ecc6dc49a5cb, ASSIGN 2024-01-29 16:50:43,106 INFO [PEWorker-23] assignment.RegionStateStore - pid=9818494 updating hbase:meta row=d743ace9f70d55f55ba1ecc6dc49a5cb, regionState=OPEN, repBarrier=12867482, openSeqNum=12867482, regionLocation=server1-65.xyz,61020,1706165574050 {code}   rs abort, after ~5 min: {code:java} 2024-01-29 16:54:27,235 ERROR [regionserver/server1-114:61020] regionserver.HRegionServer - ***** ABORTING region server server1-114.xyz,61020,1706541866103: Unexpected exception handling getData ***** org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/master     at org.apache.zookeeper.KeeperException.create(KeeperException.java:102)     at org.apache.zookeeper.KeeperException.create(KeeperException.java:54)     at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1229)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getData(RecoverableZooKeeper.java:414)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.getDataInternal(ZKUtil.java:403)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.getDataAndWatch(ZKUtil.java:367)     at org.apache.hadoop.hbase.zookeeper.ZKNodeTracker.getData(ZKNodeTracker.java:180)     at org.apache.hadoop.hbase.zookeeper.MasterAddressTracker.getMasterAddress(MasterAddressTracker.java:152)     at org.apache.hadoop.hbase.regionserver.HRegionServer.createRegionServerStatusStub(HRegionServer.java:2892)     at org.apache.hadoop.hbase.regionserver.HRegionServer.tryRegionServerReport(HRegionServer.java:1352)     at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1142) {code}   Several region transition failure report logs: {code:java} 2024-01-29 16:55:13,029 INFO  [_REGION-regionserver/server1-114:61020-0] regionserver.HRegionServer - Failed report transition server { host_name: ""server1-114.xyz"" port: 61020 start_code: 1706541866103 } transition { transition_code: CLOSED region_info { region_id: 1671555604277 table_name { namespace: ""default"" qualifier: ""TABLE1"" } start_key: ""abc"" end_key: ""xyz"" offline: false split: false replica_id: 0 } proc_id: -1 }; retry (#0) immediately. java.net.UnknownHostException: Call to address=master-server1.xyz:61000 failed on local exception: java.net.UnknownHostException: master-server1.xyz:61000 could not be resolved     at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)     at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)     at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)     at java.lang.reflect.Constructor.newInstance(Constructor.java:423)     at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:239)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:391)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:425)     at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:420)     at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114)     at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.lambda$sendRequest$4(NettyRpcConnection.java:365)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)     at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:403)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)     at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)     at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)     at java.lang.Thread.run(Thread.java:750) Caused by: java.net.UnknownHostException: master-server1.xyz:61000 could not be resolved     at org.apache.hadoop.hbase.ipc.RpcConnection.getRemoteInetAddress(RpcConnection.java:192)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.connect(NettyRpcConnection.java:280)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.access$900(NettyRpcConnection.java:79)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection$5.run(NettyRpcConnection.java:340)     at org.apache.hadoop.hbase.ipc.HBaseRpcControllerImpl.notifyOnCancel(HBaseRpcControllerImpl.java:259)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.sendRequest0(NettyRpcConnection.java:323)     at org.apache.hadoop.hbase.ipc.NettyRpcConnection.lambda$sendRequest$4(NettyRpcConnection.java:363)     ... 8 more {code}   The server is later started after sometime: {code:java} Mon Jan 29 17:01:35 UTC 2024 Starting regionserver on server1-114.xyz core file size          (blocks, -c) unlimited ... ... {code}   In order to avoid region inconsistencies, we should clear regionserver -> region reported map from active master. We can do it in two ways: # Active: master should throw error while serving regionServerReport call if the server is already considered dead due to deletion of ephemeral znode. # Passive: run a chore that can compare the regionserver -> region map generated from the regionserver reports with the actual live servers based on the zk tracking, and remove any rs report that is no longer valid." Full backup restore fails for empty HFiles,13573548,Resolved,Major,Fixed,27/Mar/24 15:00,02/Apr/24 13:14,,"A full backup restore fails if the backup contains an empty HFile, for example when all data has been deleted from a table and full compaction has run. There are several issues: * HFiles are read in `RestoreTool` to read the first/last key, but this fails for empty HFiles * In `RestoreTool`, table creation also incorrectly assumes the region contains keys * In `MapReduceRestoreJob`, the tool incorrectly assumes that a bulkload with no loaded entries is an error. Example stacktrace: {code:java} 24/03/21 18:38:09 ERROR org.apache.hadoop.hbase.backup.util.BackupUtils: java.util.NoSuchElementException: No value present java.util.NoSuchElementException: No value present at java.base/java.util.Optional.get(Optional.java:143) at org.apache.hadoop.hbase.backup.util.RestoreTool.generateBoundaryKeys(RestoreTool.java:440) at org.apache.hadoop.hbase.backup.util.RestoreTool.checkAndCreateTable(RestoreTool.java:493) at org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:351) at org.apache.hadoop.hbase.backup.util.RestoreTool.fullRestoreTable(RestoreTool.java:211) at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:151) at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229) at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265) at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518) at org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176) at org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216) at org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) at org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224) 24/03/21 18:38:09 ERROR org.apache.hadoop.hbase.backup.RestoreDriver: Error while running restore backup java.lang.IllegalStateException: Cannot restore hbase table at org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:360) at org.apache.hadoop.hbase.backup.util.RestoreTool.fullRestoreTable(RestoreTool.java:211) at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:151) at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229) at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265) at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518) at org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176) at org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216) at org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) at org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224) Caused by: java.util.NoSuchElementException: No value present at java.base/java.util.Optional.get(Optional.java:143) at org.apache.hadoop.hbase.backup.util.RestoreTool.generateBoundaryKeys(RestoreTool.java:440) at org.apache.hadoop.hbase.backup.util.RestoreTool.checkAndCreateTable(RestoreTool.java:493) at org.apache.hadoop.hbase.backup.util.RestoreTool.createAndRestoreTable(RestoreTool.java:351) ... 10 more {code}" Quotas should have a configurable minimum wait interval,13571336,Resolved,Major,Won't Fix,08/Mar/24 18:26,31/Mar/24 14:54,,"At my day job we're attempting to rollout read size throttling by default for thousands of distinct users across hundreds of multi-tenant clusters. During our rollout we've observed that throttles with a 1 second refill interval will yield relatively tiny wait intervals disproportionately often. From what we've seen, wait intervals are <=5ms on approximately 20-50% of our RpcThrottlingExceptions; this could sound theoretically promising if latency is your top priority. But, in reality, this makes it very difficult to configure a throttle tolerant HBase client because retries become very prone to near-immediate exhaustion, and throttled clients quickly saturate the cluster's RPC layer with rapid-fire retries. One can combat this with the FixedIntervalRateLimiter, but that's a very heavy handed approach from latency's perspective, and can still yield tiny intervals that exhaust retries and erroneously fail client operations under significant load. With this in mind, I'm proposing that we introduce a configurable minimum wait interval for quotas, defaulted to 0. This would make quotas much more usable at scale from our perspective." Restoring incremental backups to mapped table requires existence of original table,13570342,Resolved,Major,Fixed,29/Feb/24 16:09,26/Mar/24 18:33,,"It appears that restoring a non-existing table from an incremental backup with the ""-m"" parameter results in an error in the restore client. Reproduction steps: Build & start hbase: {code:java} mvn clean install -Phadoop-3.0 -DskipTests bin/start-hbase.sh{code} In HBase shell: create table and some values: {code:java} create 'test', 'cf' put 'test', 'row1', 'cf:a', 'value1' put 'test', 'row2', 'cf:b', 'value2' put 'test', 'row3', 'cf:c', 'value3' scan 'test' {code} Create a full backup: {code:java} bin/hbase backup create full file:/tmp/hbase-backup{code} Adjust some data through HBase shell: {code:java} put 'test', 'row1', 'cf:a', 'value1-new' scan 'test' {code} Create an incremental backup: {code:java} bin/hbase backup create incremental file:/tmp/hbase-backup {code} Delete the original table in HBase shell: {code:java} disable 'test' drop 'test' {code} Restore the incremental backup under a new table name: {code:java} bin/hbase backup history bin/hbase restore file:/tmp/hbase-backup -t ""test"" -m ""test-restored"" {code} This results in the following output / error: {code:java} ... 2024-03-25T13:38:53,062 WARN  [main {}] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable 2024-03-25T13:38:53,174 INFO  [main {}] Configuration.deprecation: hbase.client.pause.cqtbe is deprecated. Instead, use hbase.client.pause.server.overloaded 2024-03-25T13:38:53,554 INFO  [main {}] impl.RestoreTablesClient: HBase table test-restored does not exist. It will be created during restore process 2024-03-25T13:38:53,593 INFO  [main {}] impl.RestoreTablesClient: Restoring 'test' to 'test-restored' from full backup image file:/tmp/hbase-backup/backup_1711370230143/default/test 2024-03-25T13:38:53,707 INFO  [main {}] util.BackupUtils: Creating target table 'test-restored' 2024-03-25T13:38:54,546 INFO  [main {}] mapreduce.MapReduceRestoreJob: Restore test into test-restored 2024-03-25T13:38:54,646 INFO  [main {}] mapreduce.HFileOutputFormat2: bulkload locality sensitive enabled 2024-03-25T13:38:54,647 INFO  [main {}] mapreduce.HFileOutputFormat2: Looking up current regions for table test-restored 2024-03-25T13:38:54,669 INFO  [main {}] mapreduce.HFileOutputFormat2: Configuring 1 reduce partitions to match current region count for all tables 2024-03-25T13:38:54,669 INFO  [main {}] mapreduce.HFileOutputFormat2: Writing partition information to file:/tmp/hbase-tmp/partitions_0667b6e2-79ef-4cfe-97e1-abb204ee420d 2024-03-25T13:38:54,687 INFO  [main {}] compress.CodecPool: Got brand-new compressor [.deflate] 2024-03-25T13:38:54,713 INFO  [main {}] mapreduce.HFileOutputFormat2: Incremental output configured for tables: test-restored 2024-03-25T13:38:54,715 WARN  [main {}] mapreduce.TableMapReduceUtil: The addDependencyJars(Configuration, Class...) method has been deprecated since it is easy to use incorrectly. Most users should rely on addDependencyJars(Job) instead. See HBASE-8386 for more details. 2024-03-25T13:38:54,742 WARN  [main {}] impl.MetricsConfig: Cannot locate configuration: tried hadoop-metrics2-jobtracker.properties,hadoop-metrics2.properties 2024-03-25T13:38:54,834 INFO  [main {}] input.FileInputFormat: Total input files to process : 1 2024-03-25T13:38:54,853 INFO  [main {}] mapreduce.JobSubmitter: number of splits:1 2024-03-25T13:38:54,964 INFO  [main {}] mapreduce.JobSubmitter: Submitting tokens for job: job_local748155768_0001 2024-03-25T13:38:54,967 INFO  [main {}] mapreduce.JobSubmitter: Executing with tokens: [] 2024-03-25T13:38:55,076 INFO  [main {}] mapred.LocalDistributedCacheManager: Creating symlink: /tmp/hadoop-dieter/mapred/local/job_local748155768_0001_0768a243-06e8-4524-8a6d-016ddd75df52/libjars <- /home/dieter/code/hbase/libjars/* 2024-03-25T13:38:55,079 WARN  [main {}] fs.FileUtil: Command 'ln -s /tmp/hadoop-dieter/mapred/local/job_local748155768_0001_0768a243-06e8-4524-8a6d-016ddd75df52/libjars /home/dieter/code/hbase/libjars/*' failed 1 with: ln: failed to create symbolic link '/home/dieter/code/hbase/libjars/*': No such file or directory2024-03-25T13:38:55,079 WARN  [main {}] mapred.LocalDistributedCacheManager: Failed to create symlink: /tmp/hadoop-dieter/mapred/local/job_local748155768_0001_0768a243-06e8-4524-8a6d-016ddd75df52/libjars <- /home/dieter/code/hbase/libjars/* 2024-03-25T13:38:55,079 INFO  [main {}] mapred.LocalDistributedCacheManager: Localized file:/tmp/hadoop/mapred/staging/dieter748155768/.staging/job_local748155768_0001/libjars as file:/tmp/hadoop-dieter/mapred/local/job_local748155768_0001_0768a243-06e8-4524-8a6d-016ddd75df52/libjars 2024-03-25T13:38:55,129 INFO  [main {}] mapreduce.Job: The url to track the job: http://localhost:8080/ 2024-03-25T13:38:55,129 INFO  [main {}] mapreduce.Job: Running job: job_local748155768_0001 2024-03-25T13:38:55,129 INFO  [Thread-33 {}] mapred.LocalJobRunner: OutputCommitter set in config null 2024-03-25T13:38:55,131 INFO  [Thread-33 {}] output.PathOutputCommitterFactory: No output committer factory defined, defaulting to FileOutputCommitterFactory 2024-03-25T13:38:55,132 INFO  [Thread-33 {}] output.FileOutputCommitter: File Output Committer Algorithm version is 2 2024-03-25T13:38:55,132 INFO  [Thread-33 {}] output.FileOutputCommitter: FileOutputCommitter skip cleanup _temporary folders under output directory:false, ignore cleanup failures: false 2024-03-25T13:38:55,132 INFO  [Thread-33 {}] mapred.LocalJobRunner: OutputCommitter is org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter 2024-03-25T13:38:55,151 INFO  [Thread-33 {}] mapred.LocalJobRunner: Waiting for map tasks 2024-03-25T13:38:55,151 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.LocalJobRunner: Starting task: attempt_local748155768_0001_m_000000_0 2024-03-25T13:38:55,160 INFO  [LocalJobRunner Map Task Executor #0 {}] output.PathOutputCommitterFactory: No output committer factory defined, defaulting to FileOutputCommitterFactory 2024-03-25T13:38:55,160 INFO  [LocalJobRunner Map Task Executor #0 {}] output.FileOutputCommitter: File Output Committer Algorithm version is 2 2024-03-25T13:38:55,160 INFO  [LocalJobRunner Map Task Executor #0 {}] output.FileOutputCommitter: FileOutputCommitter skip cleanup _temporary folders under output directory:false, ignore cleanup failures: false 2024-03-25T13:38:55,167 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.Task:  Using ResourceCalculatorProcessTree : [ ] 2024-03-25T13:38:55,197 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: Processing split: file:/tmp/hbase-backup/backup_1711370230143/default/test/archive/data/default/test/de6966990d8204028ef5dd5156c1670e/cf/2287fb0091f24a34bb9310c8fc377831:0+5029 2024-03-25T13:38:55,226 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: (EQUATOR) 0 kvi 26214396(104857584) 2024-03-25T13:38:55,226 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: mapreduce.task.io.sort.mb: 100 2024-03-25T13:38:55,226 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: soft limit at 83886080 2024-03-25T13:38:55,226 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: bufstart = 0; bufvoid = 104857600 2024-03-25T13:38:55,227 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: kvstart = 26214396; length = 6553600 2024-03-25T13:38:55,229 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: Map output collector class = org.apache.hadoop.mapred.MapTask$MapOutputBuffer 2024-03-25T13:38:55,230 INFO  [LocalJobRunner Map Task Executor #0 {}] mapreduce.HFileInputFormat: Initialize HFileRecordReader for file:/tmp/hbase-backup/backup_1711370230143/default/test/archive/data/default/test/de6966990d8204028ef5dd5156c1670e/cf/2287fb0091f24a34bb9310c8fc377831 2024-03-25T13:38:55,233 INFO  [LocalJobRunner Map Task Executor #0 {}] mapreduce.HFileInputFormat: Seeking to start 2024-03-25T13:38:55,257 WARN  [LocalJobRunner Map Task Executor #0 {}] impl.MetricsSystemImpl: JobTracker metrics system already initialized! 2024-03-25T13:38:55,272 INFO  [LocalJobRunner Map Task Executor #0 {}] metrics.MetricRegistries: Loaded MetricRegistries class org.apache.hadoop.hbase.metrics.impl.MetricRegistriesImpl 2024-03-25T13:38:55,278 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.LocalJobRunner:  2024-03-25T13:38:55,279 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: Starting flush of map output 2024-03-25T13:38:55,279 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: Spilling map output 2024-03-25T13:38:55,279 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: bufstart = 0; bufend = 135; bufvoid = 104857600 2024-03-25T13:38:55,279 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: kvstart = 26214396(104857584); kvend = 26214388(104857552); length = 9/6553600 2024-03-25T13:38:55,287 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.MapTask: Finished spill 0 2024-03-25T13:38:55,313 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.Task: Task:attempt_local748155768_0001_m_000000_0 is done. And is in the process of committing 2024-03-25T13:38:55,338 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.LocalJobRunner: map 2024-03-25T13:38:55,338 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.Task: Task 'attempt_local748155768_0001_m_000000_0' done. 2024-03-25T13:38:55,341 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.Task: Final Counters for attempt_local748155768_0001_m_000000_0: Counters: 22     File System Counters         FILE: Number of bytes read=268105         FILE: Number of bytes written=971133         FILE: Number of read operations=0         FILE: Number of large read operations=0         FILE: Number of write operations=0     Map-Reduce Framework         Map input records=3         Map output records=3         Map output bytes=135         Map output materialized bytes=147         Input split bytes=217         Combine input records=0         Spilled Records=3         Failed Shuffles=0         Merged Map outputs=0         GC time elapsed (ms)=0         CPU time spent (ms)=280         Physical memory (bytes) snapshot=412131328         Virtual memory (bytes) snapshot=19061460992         Total committed heap usage (bytes)=276824064         Peak Map Physical memory (bytes)=412131328         Peak Map Virtual memory (bytes)=19061460992     File Input Format Counters          Bytes Read=8701 2024-03-25T13:38:55,341 INFO  [LocalJobRunner Map Task Executor #0 {}] mapred.LocalJobRunner: Finishing task: attempt_local748155768_0001_m_000000_0 2024-03-25T13:38:55,341 INFO  [Thread-33 {}] mapred.LocalJobRunner: map task executor complete. 2024-03-25T13:38:55,343 INFO  [Thread-33 {}] mapred.LocalJobRunner: Waiting for reduce tasks 2024-03-25T13:38:55,343 INFO  [pool-11-thread-1 {}] mapred.LocalJobRunner: Starting task: attempt_local748155768_0001_r_000000_0 2024-03-25T13:38:55,346 INFO  [pool-11-thread-1 {}] output.PathOutputCommitterFactory: No output committer factory defined, defaulting to FileOutputCommitterFactory 2024-03-25T13:38:55,346 INFO  [pool-11-thread-1 {}] output.FileOutputCommitter: File Output Committer Algorithm version is 2 2024-03-25T13:38:55,346 INFO  [pool-11-thread-1 {}] output.FileOutputCommitter: FileOutputCommitter skip cleanup _temporary folders under output directory:false, ignore cleanup failures: false 2024-03-25T13:38:55,346 INFO  [pool-11-thread-1 {}] mapred.Task:  Using ResourceCalculatorProcessTree : [ ] 2024-03-25T13:38:55,366 INFO  [pool-11-thread-1 {}] mapred.ReduceTask: Using ShuffleConsumerPlugin: org.apache.hadoop.mapreduce.task.reduce.Shuffle@3a7c856f 2024-03-25T13:38:55,366 WARN  [pool-11-thread-1 {}] impl.MetricsSystemImpl: JobTracker metrics system already initialized! 2024-03-25T13:38:55,373 INFO  [pool-11-thread-1 {}] reduce.MergeManagerImpl: The max number of bytes for a single in-memory shuffle cannot be larger than Integer.MAX_VALUE. Setting it to Integer.MAX_VALUE 2024-03-25T13:38:55,373 INFO  [pool-11-thread-1 {}] reduce.MergeManagerImpl: MergerManager: memoryLimit=11732306944, maxSingleShuffleLimit=2147483647, mergeThreshold=7743323136, ioSortFactor=10, memToMemMergeOutputsThreshold=10 2024-03-25T13:38:55,374 INFO  [EventFetcher for fetching Map Completion Events {}] reduce.EventFetcher: attempt_local748155768_0001_r_000000_0 Thread started: EventFetcher for fetching Map Completion Events 2024-03-25T13:38:55,387 INFO  [localfetcher#1 {}] reduce.LocalFetcher: localfetcher#1 about to shuffle output of map attempt_local748155768_0001_m_000000_0 decomp: 143 len: 147 to MEMORY 2024-03-25T13:38:55,388 INFO  [localfetcher#1 {}] reduce.InMemoryMapOutput: Read 143 bytes from map-output for attempt_local748155768_0001_m_000000_0 2024-03-25T13:38:55,389 INFO  [localfetcher#1 {}] reduce.MergeManagerImpl: closeInMemoryFile -> map-output of size: 143, inMemoryMapOutputs.size() -> 1, commitMemory -> 0, usedMemory ->143 2024-03-25T13:38:55,389 INFO  [EventFetcher for fetching Map Completion Events {}] reduce.EventFetcher: EventFetcher is interrupted.. Returning 2024-03-25T13:38:55,390 INFO  [pool-11-thread-1 {}] mapred.LocalJobRunner: 1 / 1 copied. 2024-03-25T13:38:55,390 INFO  [pool-11-thread-1 {}] reduce.MergeManagerImpl: finalMerge called with 1 in-memory map-outputs and 0 on-disk map-outputs 2024-03-25T13:38:55,394 INFO  [pool-11-thread-1 {}] mapred.Merger: Merging 1 sorted segments 2024-03-25T13:38:55,395 INFO  [pool-11-thread-1 {}] mapred.Merger: Down to the last merge-pass, with 1 segments left of total size: 133 bytes 2024-03-25T13:38:55,397 INFO  [pool-11-thread-1 {}] reduce.MergeManagerImpl: Merged 1 segments, 143 bytes to disk to satisfy reduce memory limit 2024-03-25T13:38:55,397 INFO  [pool-11-thread-1 {}] reduce.MergeManagerImpl: Merging 1 files, 147 bytes from disk 2024-03-25T13:38:55,397 INFO  [pool-11-thread-1 {}] reduce.MergeManagerImpl: Merging 0 segments, 0 bytes from memory into reduce 2024-03-25T13:38:55,397 INFO  [pool-11-thread-1 {}] mapred.Merger: Merging 1 sorted segments 2024-03-25T13:38:55,397 INFO  [pool-11-thread-1 {}] mapred.Merger: Down to the last merge-pass, with 1 segments left of total size: 133 bytes 2024-03-25T13:38:55,398 INFO  [pool-11-thread-1 {}] mapred.LocalJobRunner: 1 / 1 copied. 2024-03-25T13:38:55,399 INFO  [pool-11-thread-1 {}] Configuration.deprecation: mapred.skip.on is deprecated. Instead, use mapreduce.job.skiprecords 2024-03-25T13:38:55,455 INFO  [pool-11-thread-1 {}] mapred.Task: Task:attempt_local748155768_0001_r_000000_0 is done. And is in the process of committing 2024-03-25T13:38:55,456 INFO  [pool-11-thread-1 {}] mapred.LocalJobRunner: 1 / 1 copied. 2024-03-25T13:38:55,456 INFO  [pool-11-thread-1 {}] mapred.Task: Task attempt_local748155768_0001_r_000000_0 is allowed to commit now 2024-03-25T13:38:55,458 INFO  [pool-11-thread-1 {}] output.FileOutputCommitter: Saved output of task 'attempt_local748155768_0001_r_000000_0' to file:/tmp/hbase-tmp/bulk_output-default-test-restored-1711370334546 2024-03-25T13:38:55,476 INFO  [pool-11-thread-1 {}] mapred.LocalJobRunner: Read class java.util.TreeSet > reduce 2024-03-25T13:38:55,476 INFO  [pool-11-thread-1 {}] mapred.Task: Task 'attempt_local748155768_0001_r_000000_0' done. 2024-03-25T13:38:55,476 INFO  [pool-11-thread-1 {}] mapred.Task: Final Counters for attempt_local748155768_0001_r_000000_0: Counters: 29     File System Counters         FILE: Number of bytes read=268431         FILE: Number of bytes written=976497         FILE: Number of read operations=0         FILE: Number of large read operations=0         FILE: Number of write operations=0     Map-Reduce Framework         Combine input records=0         Combine output records=0         Reduce input groups=3         Reduce shuffle bytes=147         Reduce input records=3         Reduce output records=3         Spilled Records=3         Shuffled Maps =1         Failed Shuffles=0         Merged Map outputs=1         GC time elapsed (ms)=0         CPU time spent (ms)=190         Physical memory (bytes) snapshot=415133696         Virtual memory (bytes) snapshot=19068817408         Total committed heap usage (bytes)=276824064         Peak Reduce Physical memory (bytes)=415133696         Peak Reduce Virtual memory (bytes)=19068817408     Shuffle Errors         BAD_ID=0         CONNECTION=0         IO_ERROR=0         WRONG_LENGTH=0         WRONG_MAP=0         WRONG_REDUCE=0     File Output Format Counters          Bytes Written=5217 2024-03-25T13:38:55,476 INFO  [pool-11-thread-1 {}] mapred.LocalJobRunner: Finishing task: attempt_local748155768_0001_r_000000_0 2024-03-25T13:38:55,476 INFO  [Thread-33 {}] mapred.LocalJobRunner: reduce task executor complete. 2024-03-25T13:38:56,131 INFO  [main {}] mapreduce.Job: Job job_local748155768_0001 running in uber mode : false 2024-03-25T13:38:56,132 INFO  [main {}] mapreduce.Job:  map 100% reduce 100% 2024-03-25T13:38:56,134 INFO  [main {}] mapreduce.Job: Job job_local748155768_0001 completed successfully 2024-03-25T13:38:56,147 INFO  [main {}] mapreduce.Job:     FILE: Number of write operations=0     Map-Reduce Framework         Map input records=3         Map output records=3         Map output bytes=135         Map output materialized bytes=147         Input split bytes=217         Combine input records=0         Combine output records=0         Reduce input groups=3         Reduce shuffle bytes=147         Reduce input records=3         Reduce output records=3         Spilled Records=6         Shuffled Maps =1         Failed Shuffles=0         Merged Map outputs=1         GC time elapsed (ms)=0         CPU time spent (ms)=470         Physical memory (bytes) snapshot=827265024         Virtual memory (bytes) snapshot=38130278400         Total committed heap usage (bytes)=553648128         Peak Map Physical memory (bytes)=412131328         Peak Map Virtual memory (bytes)=19061460992         Peak Reduce Physical memory (bytes)=415133696         Peak Reduce Virtual memory (bytes)=19068817408     Shuffle Errors         BAD_ID=0         CONNECTION=0         IO_ERROR=0         WRONG_LENGTH=0         WRONG_MAP=0         WRONG_REDUCE=0     File Input Format Counters          Bytes Read=8701     File Output Format Counters          Bytes Written=5217 2024-03-25T13:38:56,254 WARN  [main {}] tool.LoadIncrementalHFiles: Skipping non-directory file:/tmp/hbase-tmp/bulk_output-default-test-restored-1711370334546/_SUCCESS 2024-03-25T13:38:56,284 WARN  [main {}] token.FsDelegationToken: Unknown FS URI scheme: file 2024-03-25T13:38:56,326 INFO  [LoadIncrementalHFiles-0 {}] tool.LoadIncrementalHFiles: Trying to load hfile=file:/tmp/hbase-tmp/bulk_output-default-test-restored-1711370334546/cf/b0c03e04af784c77a9d12206559aa768 first=Optional[row1] last=Optional[row3] 2024-03-25T13:38:56,473 INFO  [main {}] impl.RestoreTablesClient: Restoring 'test' to 'test-restored' from log dirs: file:/tmp/hbase-backup/backup_1711370245048/default/test/cf/860b10b854204226834b85212e529f29 2024-03-25T13:38:56,477 INFO  [main {}] mapreduce.MapReduceRestoreJob: Restore test into test-restored 2024-03-25T13:38:56,486 ERROR [main {}] mapreduce.MapReduceRestoreJob: org.apache.hadoop.hbase.TableNotFoundException: test org.apache.hadoop.hbase.TableNotFoundException: test     at org.apache.hadoop.hbase.client.HBaseAdmin.getTableDescriptor(HBaseAdmin.java:635) ~[hbase-client-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.client.HTable.getDescriptor(HTable.java:244) ~[hbase-client-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.mapreduce.MapReduceHFileSplitterJob.createSubmittableJob(MapReduceHFileSplitterJob.java:117) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.mapreduce.MapReduceHFileSplitterJob.run(MapReduceHFileSplitterJob.java:165) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.mapreduce.MapReduceRestoreJob.run(MapReduceRestoreJob.java:84) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.util.RestoreTool.incrementalRestoreTable(RestoreTool.java:205) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:186) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) ~[hadoop-common-3.3.5.jar:?]     at org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT] 2024-03-25T13:38:56,491 ERROR [main {}] backup.RestoreDriver: Error while running restore backup java.io.IOException: Can not restore from backup directory file:/tmp/hbase-backup/backup_1711370245048/default/test/cf/860b10b854204226834b85212e529f29 (check Hadoop and HBase logs)      at org.apache.hadoop.hbase.backup.mapreduce.MapReduceRestoreJob.run(MapReduceRestoreJob.java:103) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.util.RestoreTool.incrementalRestoreTable(RestoreTool.java:205) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restoreImages(RestoreTablesClient.java:186) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.restore(RestoreTablesClient.java:229) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.RestoreTablesClient.execute(RestoreTablesClient.java:265) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.restore(BackupAdminImpl.java:518) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.RestoreDriver.parseAndRun(RestoreDriver.java:176) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.RestoreDriver.doWork(RestoreDriver.java:216) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.RestoreDriver.run(RestoreDriver.java:252) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) ~[hadoop-common-3.3.5.jar:?]     at org.apache.hadoop.hbase.backup.RestoreDriver.main(RestoreDriver.java:224) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT] Caused by: org.apache.hadoop.hbase.TableNotFoundException: test     at org.apache.hadoop.hbase.client.HBaseAdmin.getTableDescriptor(HBaseAdmin.java:635) ~[hbase-client-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.client.HTable.getDescriptor(HTable.java:244) ~[hbase-client-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.mapreduce.MapReduceHFileSplitterJob.createSubmittableJob(MapReduceHFileSplitterJob.java:117) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.mapreduce.MapReduceHFileSplitterJob.run(MapReduceHFileSplitterJob.java:165) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.mapreduce.MapReduceRestoreJob.run(MapReduceRestoreJob.java:84) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT] {code}" Fix BackupSystemTable Scans ,13572713,Resolved,Major,Fixed,20/Mar/24 15:35,25/Mar/24 19:37,,"When calculating which WALs should be included in an incremental backup the backup system does a prefix scan for the last roll log timestamp. This uses the backup root in the prefix (.) If you happen have multiple backup roots where one is a root of the other you'll get inaccurate results.    Since the rowkey is let's modify the prefix scan to be ." Support a middle ground between the Average and Fixed interval rate limiters,13572864,Resolved,Major,Fixed,21/Mar/24 18:39,25/Mar/24 19:37,2.6.0,"h3. Background HBase quotas support two rate limiters: a ""fixed"" and an ""average"" interval rate limiter. h4. FixedIntervalRateLimiter The fixed interval rate limiter is simpler: it has a TimeUnit, say 1 second, and it refills a resource allotment on the recurring interval. So you may get 10 resources every second, and if you exhaust all 10 resources in the first millisecond of an interval then you will need to wait 999ms to acquire even 1 more resource. h4. AverageIntervalRateLimiter The average interval rate limiter, HBase's default, allows for more flexibly timed refilling of the resource allotment. Extending our previous example, say you have a 10 reads/sec quota and you have exhausted all 10 resources within 1ms of the last full refill. If you request 1 more read then, rather than returning a 999ms wait interval indicating the next full refill time, the rate limiter will recognize that you only need to wait 99ms before 1 read can be available. After 100ms has passed in aggregate since the last full refill, it will support the refilling of 1/10th the limit to facilitate the request for 1/10th the resources. h3. The Problems with Current RateLimiters The problem with the fixed interval rate limiter is that it is too strict from a latency perspective. It results in quota limits to which we cannot fully subscribe with any consistency. The problem with the average interval rate limiter is that, in practice, it is far too optimistic. For example, a real rate limiter might limit to 100MB/sec of read IO per machine. Any multigets that come in will require only a tiny fraction of this limit; for example, a 64kb block is only 0.06% of the total. As a result, the vast majority of wait intervals end up being tiny — like <5ms. This can actually cause an inverse of your intention, where setting up a throttle causes a DDOS of your RPC layer via continuous throttling and ~immediate retrying. I've discussed this problem in https://issues.apache.org/jira/browse/HBASE-28429 and proposed a minimum wait interval as the solution there; after some more thinking, I believe this new rate limiter would be a less hacky solution to this deficit so I'd like to close that Jira in favor of this one. See the attached chart where I put in place a 10k req/sec/machine throttle for this user at 10:43 to try to curb this high traffic, and it resulted in a huge spike of req/sec due to the throttle/retry loop created by the AverageIntervalRateLimiter. h3. Original Proposal: PartialIntervalRateLimiter as a Solution I've implemented a RateLimiter which allows for partial chunks of the overall interval to be refilled, by default these chunks are 10% (or 100ms of a 1s interval). I've deployed this to a test cluster at my day job and have seen this really help our ability to full subscribe to a quota limit without executing superfluous retries. See the other attached chart which shows a cluster undergoing a rolling restart from using FixedIntervalRateLimiter to my new PartialIntervalRateLimiter and how it is then able to fully subscribe to its allotted 25MB/sec/machine read IO quota. h3. Updated Proposal: Improving FixedIntervalRateLimiter Rather than implement a new rate limiter, we can make a lower touch change which just adds support for a refill interval that is less than the time unit on a FixedIntervalRateLimiter. This can be a no-op change for those who have not opted into the feature by having the refill interval default to the time unit. For clarity, see [my branch here|https://github.com/apache/hbase/compare/master...HubSpot:hbase:HBASE-28453] which I will PR soon" Remove hbase-examples from hbase-assembly,13570618,Resolved,Major,Fixed,04/Mar/24 05:32,22/Mar/24 03:56,3.0.0-beta-1,"hbase-assembly is supposed to contain programming examples for HBase. However, it is added to the assembly API, and becomes part of the HBase distrbutions. On hand this adds some potentially useful components and coprocessors to HBase, on the other hand many of those are not production quality, and were never meant to be used as-is. It also adds the Curator libraries to the general HBase classpath, which are used but by but a single example. Removing hbase-examples from the assembly would fix both problems. " Cast without checking in TestCacheConfig,13572740,Open,Major,,20/Mar/24 21:56,,,"*1. What happened* After setting `hfile.block.cache.policy=AdaptiveLRU`, running test `org.apache.hadoop.hbase.io.hfile.TestCacheConfig#testBucketCacheConfigL1L2Setup` results in a casting error.   *2. Where's the problem* In`PooledRemoteClient`: {code:java}     FirstLevelBlockCache lbc = cbc.l1Cache; ...     // Force evictions by putting in a block too big.   final long justTooBigSize = ((LruBlockCache) lbc).acceptableSize() + 1;{code} However, lbc does not necessarily need to be a LruBlockCache, leading to a potential `ClassCastException`   *3. How to reproduce* 1. set `hfile.block.cache.policy` to `AdaptiveLRU ` 2. run `org.apache.hadoop.hbase.io.hfile.TestCacheConfig#testBucketCacheConfigL1L2Setup` you should observe {code:java} java.lang.ClassCastException: class org.apache.hadoop.hbase.io.hfile.LruAdaptiveBlockCache cannot be cast to class org.apache.hadoop.hbase.io.hfile.LruBlockCache (org.apache.hadoop.hbase.io.hfile.LruAdaptiveBlockCache and org.apache.hadoop.hbase.io.hfile.LruBlockCache are in unnamed module of loader 'app') at org.apache.hadoop.hbase.io.hfile.TestCacheConfig.testBucketCacheConfigL1L2Setup(TestCacheConfig.java:342) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43){code}   We would like to provide a patch if this is confirmed." Remove Curator dependency from hbase-endpoint,13570617,Resolved,Major,Fixed,04/Mar/24 05:09,19/Mar/24 14:57,3.0.0-beta-1,"TestRpcControllerFactory used to erronously import some classes from Curator's relocated Guava. This has been fixed now, but the (compile scope) dependency for curator has not been removed. I propose removing the dependency in master, branch-3 and branch-2. " Assertion failure in NewVersionBehaviorTracker during major compaction,13572112,Open,Major,,16/Mar/24 02:45,,,"The attached test inserts put, and delete mutations that include all types of delete markers. These mutations are written to multiple files using multiple memstore flushes. Then the test runs minor compaction, and finally major compaction. When KeepDeleteCells is set to true and new version behavior is enabled, the test fails with the following assertion failure: {code:java} java.lang.AssertionError     at org.apache.hadoop.hbase.regionserver.querymatcher.NewVersionBehaviorTracker.checkVersions(NewVersionBehaviorTracker.java:310)     at org.apache.hadoop.hbase.regionserver.querymatcher.MajorCompactionScanQueryMatcher.match(MajorCompactionScanQueryMatcher.java:78)     at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:640)     at org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:446)     at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:367)     at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62)     at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:122)     at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1177)     at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2407)     at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2262)     at org.apache.hadoop.hbase.regionserver.TestStoreFileWriter.testCompactedFiles(TestStoreFileWriter.java:187)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:498)     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)     at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)     at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.runners.ParentRunner.run(ParentRunner.java:413)     at org.junit.runners.Suite.runChild(Suite.java:128)     at org.junit.runners.Suite.runChild(Suite.java:27)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)     at java.util.concurrent.FutureTask.run(FutureTask.java:266)     at java.lang.Thread.run(Thread.java:748) {code} The attached [^Test-for-the-assert-failure-in-NewVersionBehaviorTra.patch]test is a simplified version of the test in the PR for HBASE-25972. " Bounded leak of FSDataInputStream buffers from checksum switching,13566805,Resolved,Major,Fixed,30/Jan/24 22:07,19/Mar/24 13:43,,"In FSDataInputStreamWrapper, the unbuffer() method caches an unbuffer instance the first time it is called. When an FSDataInputStreamWrapper is initialized, it has hbase checksum disabled. In HFileInfo.initTrailerAndContext we get the stream, read the trailer, then call unbuffer. At this point, checksums have not been enabled yet via prepareForBlockReader. So the call to unbuffer() caches the current non-checksum stream as the unbuffer instance. Later, in initMetaAndIndex we do a similar thing. This time, prepareForBlockReader has been called, so we are now using hbase checksums. When initMetaAndIndex calls unbuffer(), it uses the old unbuffer instance which actually has been closed when we switched to hbase checksums. So that call does nothing, and the new no-checksum input stream is never unbuffered. I haven't seen this cause an issue with normal hdfs replication (though haven't gone looking). It's very problematic for Erasure Coding because DFSStripedInputStream holds a large buffer (numDataBlocks * cellSize, so 6mb for RS-6-3-1024k) that is only used for stream reads NOT pread. The FSDataInputStreamWrapper we are talking about here is only used for pread in hbase, so those 6mb buffers just hang around totally unused but unreclaimable. Since there is an input stream per StoreFile, this can add up very quickly on big servers." Quota estimates are too optimistic for large scans,13569247,Resolved,Major,Fixed,20/Feb/24 19:52,13/Mar/24 22:12,,"Let's say you're running a table scan with a throttle of 100MB/sec per RegionServer. Ideally your scans are going to pull down large results, often containing hundreds or thousands of blocks. You will estimate each scan as costing a single block of read capacity, and if your quota is already exhausted then the server will evaluate the backoff required for your estimated consumption (1 block) to be available. This will often be ~1ms, causing your retries to basically be immediate. Obviously it will routinely take much longer than 1ms for 100MB of IO to become available in the given configuration, so your retries will be destined to fail. At worst this can cause a saturation of your server's RPC layer, and at best this causes erroneous exhaustion of the client's retries. We should find a way to make these estimates a bit smarter for large scans." Allow Action and Policies of ServerKillingMonkey to be configurable,13570706,Resolved,Major,Fixed,04/Mar/24 16:41,13/Mar/24 17:38,,"Currently for ServerKillingMonkeyFactory, actions and policies have hardcoded timeouts. {code:java}     Action[] actions1 = new Action[] {       new RestartRandomRsExceptMetaAction(60000),       new RestartActiveMasterAction(5000),       // only allow 2 servers to be dead       new RollingBatchRestartRsAction(5000, 1.0f, 2, true),       new ForceBalancerAction(),       new GracefulRollingRestartRsAction(gracefulRollingRestartTSSLeepTime),       new RollingBatchSuspendResumeRsAction(rollingBatchSuspendRSSleepTime,           rollingBatchSuspendtRSRatio)     }; {code} and {code:java}     return new PolicyBasedChaosMonkey(properties, util,       new CompositeSequentialPolicy(new DoActionsOncePolicy(60 * 1000, actions1),         new PeriodicRandomActionPolicy(60 * 1000, actions1)),       new PeriodicRandomActionPolicy(60 * 1000, actions2));   } {code} We should allow these to be configurable too." Add support for using mapreduce sort in HFileOutputFormat2,13571769,Open,Major,,13/Mar/24 15:49,,,"Currently HFileOutputFormat2 uses CellSortReducer, which attempts to sort all of the cells of a row in memory using a TreeSet. There is a warning in the javadoc ""If lots of columns per row, it will use lots of memory sorting."" This can be problematic for WALPlayer, which uses HFileOutputFormat2. You could have reasonably sized row which just gets lots of edits in the time period of WALs being replayed, and that would cause an OOM. We are seeing this in some cases with incremental backups. MapReduce has built-in sorting capabilities which are not limited to sorting in memory. It can spill to disk as necessary to sort very large datasets. We can get this capability in HFileOutputFormat2 with a couple changes: # Add support for a KeyOnlyCellComparable type as the map output key # When configured, use job.setSortComparatorClass(CellWritableComparator.class) and job.setReducerClass(PreSortedCellsReducer.class) # Update WALPlayer to have a mode which can output this new comparable instead of ImmutableBytesWritable CellWritableComparator exists already for the Import job, so there is some prior art. " Potential Data loss issue for the HFLog,13569263,Open,Major,,20/Feb/24 22:47,,," I am going through the WAL implementation HFLog, and based on the code reading, as my understanding there maybe potential data loss for example in below scenarios: # Append record A3 already into the stream, and but the syncFuture S3 does not reach to the SyncRunner yet # The SyncRunner run the sync and call sync on writer, but failed, all the data in stream lost including A3 # Because the syncFuture S3 does not reach to the syncRunner, it can not release it and mark it failed # In next run() of the SyncRunner, the new sync() succeeded, it will release and mark S3 as succeeded, but actually it should failed which cause data loss. Can anyone help to check above above is true? Am I missing anything regarding this process? !Screenshot 2024-02-19 at 10.53.20.png!" TableNotFoundException when executing 'hbase hbck',13569495,Resolved,Major,Fixed,22/Feb/24 11:38,10/Mar/24 13:30,,"*Reproduction:* Starting hbase cluster Executing command 'hbase hbck' TableNotFoundException occur aboubt '{color:#FF0000}hbase:replication{color}' {code:java} //代码占位符 org.apache.hadoop.hbase.replication.ReplicationException: failed to listAllQueues         at org.apache.hadoop.hbase.replication.TableReplicationQueueStorage.listAllQueues(TableReplicationQueueStorage.java:289)         at org.apache.hadoop.hbase.util.hbck.ReplicationChecker.getUnDeletedQueues(ReplicationChecker.java:77)         at org.apache.hadoop.hbase.util.hbck.ReplicationChecker.checkUnDeletedQueues(ReplicationChecker.java:105)         at org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixReplication(HBaseFsck.java:2575)         at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:803)         at org.apache.hadoop.hbase.util.HBaseFsck.exec(HBaseFsck.java:3752)         at org.apache.hadoop.hbase.util.HBaseFsck$HBaseFsckTool.run(HBaseFsck.java:3551)         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82)         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:97)         at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3536) Caused by: org.apache.hadoop.hbase.TableNotFoundException: hbase:replication {code} *Problem analysis:* hbase does not create the table 'hbase:replication' until the first add_peer operation would be executed. However, 'hbase hbck' operation would check the 'hbase:replication', So if this table has not been created, we would get TableNotFoundException." Set correct Result to RegionActionResult for successful Put/Delete mutations,13571079,Resolved,Major,Fixed,07/Mar/24 00:59,10/Mar/24 08:47,,"While returning response of multi(), RSRpcServices build the RegionActionResult with Result or Exception (ClientProtos.ResultOrException). It sets the Exception to this class in all cases where the operation fails with corresponding exception types e.g. NoSuchColumnFamilyException or FailedSanityCheckException etc. In case of atomic mutations Increment and Append, we add the Result object to ClientProtos.ResultOrException, which is used by client to retrieve result from the batch API: {_}Table#batch(List actions, Object[] results){_}. Phoenix performs atomic mutation for Put using _preBatchMutate()_ endpoint. Hence, returning Result object with ResultOrException is important for the purpose of returning the result back to the client as part of the atomic operation. Even if Phoenix returns the OperationStatus (with Result) to MiniBatchOperationInProgress, since HBase uses the empty Result for the Success case, the client would not be able to get the expected result. {code:java} case SUCCESS: builder.addResultOrException( getResultOrException(ClientProtos.Result.getDefaultInstance(), index)); break; {code} If OperationStatus returned by _Region#batchMutate_ has valid Result object, it should be used by RSRpcServices while returning the response." Revisit the way we do reference counting on MemStoreLAB,13571373,Open,Major,,09/Mar/24 15:25,,,"As in HBASE-28401, we found out that it is a bit different to align the code for Segment related reference counting logic. So we filed this issue to see if there is a better way to make code cleaner." RpcThrottlingException messages should describe the throttled access pattern,13571345,Open,Major,,08/Mar/24 20:22,,,"Right now we catch RpcThrottlingExceptions and have some debug logging in [RegionServerRpcQuotaManager|https://github.com/apache/hbase/blob/98eb3e01b352684de3c647a6fda6208a657c4607/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RegionServerRpcQuotaManager.java#L234-L236] — this is okay support for in depth explanations, but is not trivially transparent to users. For example, at my day job we have proxy APIs which sit between HBase and many microservices. We throttle these microservices in isolation, but the RpcThrottlingExceptions appear to be indiscriminate in the stdout of the proxy API. If we added the given username, table, and namespace to RpcThrottlingException messages then understanding the nature and specificity of any given throttle violation should be much more straightforward. Given that quotas/throttling is most useful in a multi-tenant environment, I would anticipate this being a pretty universal usability pain point. It would be a bit more complicated, but we should also consider including more information about the rate limiter which has been violated. For example, what is the current configured read size limit that we've exceeded?" Improve quota RateLimiter synchronization,13568303,Resolved,Major,Fixed,13/Feb/24 13:22,07/Mar/24 02:35,,"We've been experiencing RpcThrottlingException with 0ms waitInterval. This seems odd and wasteful, since the client side will immediately retry without backoff. I think the problem is related to the synchronization of RateLimiter. The TimeBasedLimiter checkQuota method does the following: {code:java} if (!reqSizeLimiter.canExecute(estimateWriteSize + estimateReadSize)) { RpcThrottlingException.throwRequestSizeExceeded( reqSizeLimiter.waitInterval(estimateWriteSize + estimateReadSize)); } {code} Both canExecute and waitInterval are synchronized, but we're calling them independently. So it's possible under high concurrency for canExecute to return false, but then waitInterval returns 0 (would have been true) I think we should simplify the API to have a single synchronized call: {code:java} long waitInterval = reqSizeLimiter.tryAcquire(estimateWriteSize + estimateReadSize); if (waitInterval > 0) { RpcThrottlingException.throwRequestSizeExceeded(waitInterval); }{code}" "WALPrettyPrinter fails with ""java.io.EOFException: EOF while reading message size""",13571149,Open,Major,,07/Mar/24 13:38,,2.6.0,"While testing WALPrettyPrinter fails with ""java.io.EOFException: EOF while reading message size"" {code:java} hbase wal -p /apps/hbase/data/WALs/HOSTNAME,16020,1709296677041/HOSTNAME%2C16020%2C1709296677041.1709815102928{code} {code:java} Writer Classes: ProtobufLogWriter AsyncProtobufLogWriter SecureProtobufLogWriter SecureAsyncProtobufLogWriter Cell Codec Class: org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec Exception in thread ""main"" java.io.EOFException: EOF while reading message size     at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.parseDelimitedFrom(ProtobufUtil.java:3727)     at org.apache.hadoop.hbase.regionserver.wal.ProtobufWALStreamReader.next(ProtobufWALStreamReader.java:56)     at org.apache.hadoop.hbase.wal.WALStreamReader.next(WALStreamReader.java:42)     at org.apache.hadoop.hbase.wal.WALPrettyPrinter.processFile(WALPrettyPrinter.java:297)     at org.apache.hadoop.hbase.wal.WALPrettyPrinter.run(WALPrettyPrinter.java:516)     at org.apache.hadoop.hbase.wal.WALPrettyPrinter.main(WALPrettyPrinter.java:429){code} cc [~nihaljain.cs] " Add ofs (Ozone Filesystem) support for acquireDelegationToken,13570856,Open,Major,,05/Mar/24 15:40,,,"Currently acquireDelegationToken is hardcoded for checking swebhdfs, webhdfs and hdfs(Refer below or [here|[https://github.com/apache/hbase/blob/4f97ece9f5ab9288ea44f5842be55a4dbaa866e0/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/FsDelegationToken.java#L62-L84]]). We should add support for Ozone also.  {code:java} public void acquireDelegationToken(final FileSystem fs) throws IOException { String tokenKind; String scheme = fs.getUri().getScheme(); if (SWEBHDFS_SCHEME.equalsIgnoreCase(scheme)) { tokenKind = SWEBHDFS_TOKEN_KIND.toString(); } else if (WEBHDFS_SCHEME.equalsIgnoreCase(scheme)) { tokenKind = WEBHDFS_TOKEN_KIND.toString(); } else if (HDFS_URI_SCHEME.equalsIgnoreCase(scheme)) { tokenKind = HDFS_DELEGATION_KIND.toString(); } else { LOG.warn(""Unknown FS URI scheme: "" + scheme); // Preserve default behavior tokenKind = HDFS_DELEGATION_KIND.toString(); } acquireDelegationToken(tokenKind, fs); } {code} This can impact jobs like BulkLoad on a secure environment. Thanks [~bszabolcs] for the debug help!  " Upgrade thirdparty dep to 4.1.6,13569094,Resolved,Major,Fixed,19/Feb/24 16:35,05/Mar/24 09:35,,Adopt the next hbase-thirdparty release. Improvements to backup of bulkloaded files,13571047,Open,Major,,06/Mar/24 19:39,,,"Backup/Restore has support for including bulkloaded files in incremental backups. There is a coprocessor hook which registers all bulkloads into a backup:system_bulk table. A cleaner plugin ensures that these files are not cleaned up from the archive until they are backed up. When the incremental backup occurs, the files are deleted from the system_bulk table and then cleaned up. We have encountered two problems to be solved with this: # The deletion process only happens during incremental backups, not full backups. A full backup already includes all data in the table via a snapshot export. So we should clear any pending bulkloads upon full backup. # There is currently no linking of bulkload state to backupRoot. It's possible to have multiple backupRoots for tables. For example, you might backup to 2 destinations with different schedules. Currently whichever backupRoot does an incremental backup first will be the one to include bulkloads, then the system_bulk table. We need some sort of mapping of bulkload to backupRoot, and we should only delete the rows from system_bulk once the files have been included in all active backupRoots." [thirdparty] Update release instructions,13570039,Resolved,Major,Fixed,27/Feb/24 16:08,04/Mar/24 11:28,,Our release instructions for hbase-thirdparty are out of date. Update them based on recent experience. Fix race condition in TestCleanerChore.retriesIOExceptionInStatus,13570418,Patch Available,Major,,01/Mar/24 06:45,,2.6.0,"We occasionally get a test failure in TestCleanerChore.retriesIOExceptionInStatus. For example, from a [recent PR build|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5725/1/testReport/org.apache.hadoop.hbase.master.cleaner/TestCleanerChore/precommit_checks___yetus_jdk11_hadoop3_checks___retriesIOExceptionInStatus/] on branch-2.6, {noformat} java.util.concurrent.ExecutionException: java.io.IOException: whomp whomp. at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:395) at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1999) at org.apache.hadoop.hbase.master.cleaner.TestCleanerChore.retriesIOExceptionInStatus(TestCleanerChore.java:163) ... Caused by: java.io.IOException: whomp whomp. at org.apache.hadoop.hbase.master.cleaner.TestCleanerChore$1.listStatus(TestCleanerChore.java:134) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.traverseAndDelete(CleanerChore.java:475) at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$chore$0(CleanerChore.java:258) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ... 1 more {noformat} This looks like a race condition where the chore manages an entire execution between when the flag is flipped and when the test thread gets back around to continuing execution. Make the test a little more pessimistic about its view of the world. " [JDK17] Unable to run hbase-it tests with JDK 17 ,13567833,Resolved,Major,Fixed,08/Feb/24 06:20,02/Mar/24 06:37,,"It could be because of CMS flags used to start running it tests {noformat} [ERROR] Please refer to apache/hbase/hbase-it/target/failsafe-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was /bin/sh -c cd 'apache/hbase/hbase-it' && '/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home/bin/java' '-enableassertions' '-Xmx4g' '-Djava.security.egd=file:/dev/./urandom' '-XX:+CMSClassUnloadingEnabled' '-verbose:gc' '-XX:+PrintCommandLineFlags' '-XX:+PrintFlagsFinal' '-jar' 'apache/hbase/hbase-it/target/surefire/surefirebooter-20240208114255880_3.jar' 'apache/hbase/hbase-it/target/surefire' '2024-02-08T11-42-55_824-jvmRun1' 'surefire-20240208114255880_1tmp' 'surefire_0-20240208114255880_2tmp' [ERROR] Error occurred in starting fork, check output in log [ERROR] Process Exit Code: 1 [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:643) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1203) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1055) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:871) [ERROR] at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162) [ERROR] at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:73) [ERROR] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:53) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:118) [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:261) [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:173) [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:101) [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:906) [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:283) [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:206) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [ERROR] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) [ERROR] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [ERROR] at java.base/java.lang.reflect.Method.invoke(Method.java:568) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:283) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:226) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:407) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:348) {noformat} " Improve debugging for failures in procedure tests,13569834,Resolved,Major,Fixed,26/Feb/24 11:51,01/Mar/24 10:10,,"We see unit test failures in Jenkins that look like this: {noformat} java.lang.IllegalArgumentException: run queue not empty at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:332) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:665) at org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.restart(ProcedureTestingUtility.java:132) at org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.restart(ProcedureTestingUtility.java:100) at org.apache.hadoop.hbase.master.procedure.MasterProcedureTestingUtility.restartMasterProcedureExecutor(MasterProcedureTestingUtility.java:85) at org.apache.hadoop.hbase.master.assignment.TestRollbackSCP.testFailAndRollback(TestRollbackSCP.java:180) {noformat} This isn't enough information to debug the situation. The test code in question looks reasonable enough -- it clears the object for re-use between tests. However, somewhere between stop/clear/start we miss something. Add some toString implementations and dump the objects in the preconditions." RegionSizeCalculator throws NPE when regions are in transition,13568017,Resolved,Major,Fixed,09/Feb/24 13:44,01/Mar/24 05:26,,"When a region is in transition, it may briefly have a null ServerName in meta. The RegionSizeCalculator calls RegionLocator.getAllRegionLocations() and does not handle the possibility that a RegionLocation.getServerName() could be null. The ServerName is eventually passed into an Admin call, which results in an NPE. This has come up in other contexts. For example, taking a look at getAllRegionLocations() impl, we have checks to ensure that we don't call null server names. We need to similarly handle the possibility of nulls in RegionSizeCalculator." Attach the design doc for preamble call to our code base,13569493,Resolved,Major,Fixed,22/Feb/24 11:11,29/Feb/24 08:47,, StorefileRefresherChore should not refresh readonly table,13564682,Resolved,Major,Fixed,15/Jan/24 08:47,29/Feb/24 07:16,2.4.17,"According to semantics, when StoreFile Refresher is turned on, only the area with replicas should be refreshed. *Tables with read-only attributes will not be refreshed.* There are the following scenarios: Assume that some tables in the database have replica enabled, while others do not. If a table that does not have replica enabled needs to perform migration tasks - first enable readonly and then export the snapshot, StorefileRefresherChore will always refresh the table that does not have replica enabled but performs migration tasks. This is obviously illogical. Therefore, StorefileRefresherChore needs to determine whether the region has a read-only copy, and refresh it if it has a read-only copy. And tables with read-only properties are not refreshed. patch:[HBASE-28313|https://github.com/apache/hbase/pull/5641]" "When AbstractRpcClient calls getConnection, the status of conn should be checked",13565359,Resolved,Major,Not A Problem,19/Jan/24 04:12,01/Mar/24 03:29,2.5.7,"h3. 1. Question The connection will only be created when it does not exist. Since the conn in *connections* are cleaned asynchronously and regularly, it is very likely that we will get a closed connection. {code:java} /** * Get a connection from the pool, or create a new one and add it to the pool. Connections to a * given host/port are reused. */ private T getConnection(ConnectionId remoteId) throws IOException { if (failedServers.isFailedServer(remoteId.getAddress())) { if (LOG.isDebugEnabled()) { LOG.debug(""Not trying to connect to "" + remoteId.getAddress() + "" this server is in the failed servers list""); } throw new FailedServerException( ""This server is in the failed servers list: "" + remoteId.getAddress()); } T conn; synchronized (connections) { if (!running) { throw new StoppedRpcClientException(); } conn = connections.getOrCreate(remoteId, () -> createConnection(remoteId)); conn.setLastTouched(EnvironmentEdgeManager.currentTime()); } return conn; } {code} h3. 2. Solution * When getConnection, we should to check whether the conn is active * Optimize the impl of isActive and increase the judgment of channel status {code:java} @Override public boolean isActive() { return channel != null && channel.isActive(); } {code} I am new to HBase, so my understanding may be wrong. Please correct me.  " Client ingegration tests fails for branch-2/branch-2.6,13569203,Resolved,Major,Fixed,20/Feb/24 13:12,28/Feb/24 15:01,,"In HBASE-28331, we fixed the problem that we should use the latest hadoop3 tarballs, for generating hdfs-site.xml. But for branch-2.x, we still use hadoop2 when compiling hbase by default, so there is no org.apache.hadoop.ipc.ProtobufRpcEngine2 class. But the hadoop 3.3.x will generate hdfs-site.xml with this config, then leads to the failure of hbase start up. Should we change to build with hadoop3 while running on top of hadoop3? Since for branch-2.x, we will publish artifacts for hadoop3." Broken test TestHRegionWithInMemoryFlush,13569310,Open,Major,,21/Feb/24 09:17,,4.0.0-alpha-1,{{TestHRegionWithInMemoryFlush}} is broken in Jenkins ([PR35693|https://github.com/apache/hbase/pull/5693]) and in local testing. It times out while waiting for HMaster to startup. Remove the need for ADMIN permissions for listDecommissionedRegionServers,13569414,Resolved,Major,Fixed,21/Feb/24 23:07,27/Feb/24 20:15,2.4.17,"Why we need {{ADMIN}} permissions for {{AccessController#preListDecommissionedRegionServers}} ? From Phoenix, we are calling {{Admin#getRegionServers(true)}} where the argument {{excludeDecommissionedRS}} is set to true. Refer [here|https://github.com/apache/hbase/blob/branch-2.5/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L1721-L1730]. If {{excludeDecommissionedRS}}  is set to true and if we have {{AccessController}} co-proc attached, it requires ADMIN permissions to execute {{listDecommissionedRegionServers}} RPC. Refer [here|https://github.com/apache/hbase/blob/branch-2.5/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java#L1205-L1207].   {code:java} @Override public void preListDecommissionedRegionServers(ObserverContext ctx) throws IOException { requirePermission(ctx, ""listDecommissionedRegionServers"", Action.ADMIN); } {code} I understand that we need ADMIN permissions for _preDecommissionRegionServers_ and _preRecommissionRegionServer_ because it changes the membership of regionservers but I don’t see any need for ADMIN permissions for _listDecommissionedRegionServers_. Do you think we can remove need for ADMIN permissions for  _listDecommissionedRegionServers_ RPC?" Cleanup / Resurrect hbase-table-reporter ,13570201,Open,Major,,28/Feb/24 17:31,,,"Seems [hbase-table-reporter|https://github.com/apache/hbase-operator-tools/tree/master/hbase-table-reporter] code is not maintained or maybe not even used? We have not had any change since a long time.  With this JIRA, I plan on doing following: * Bump dependencies to be latest, remove redundant ones * Update docs as I am not sure why it references com.apple.hbase.Reporter * Do basic sanity based on docs and ensure it works" region size can be wrong from RegionSizeCalculator,13569614,Open,Major,,23/Feb/24 09:17,,3.0.0-beta-1,"The RegionSizeCalculator calculates region byte size using the following method {code:java} private static final long MEGABYTE = 1024L * 1024L; long regionSizeBytes = ((long) regionLoad.getStoreFileSize().get(Size.Unit.MEGABYTE)) * MEGABYTE; {code} However, this method will lose accuracy. For example, the result of  {code:java} ((long) new Size(1, Size.Unit.BYTE).get(Size.Unit.MEGABYTE)) * MEGABYTE {code} is 0. This will result in a TableInputSplit with a length of 0, but in fact this TableInputSplit has a small amount of data.   This TableInputSplit will be ignored if we enable spark.hadoopRDD.ignoreEmptySplits." Move namespace to RS group can support multiple options to move tables under it,13570011,Open,Major,,27/Feb/24 13:36,,,"As discussed here [https://github.com/apache/hbase/pull/5661#issuecomment-1949090826] Move namespaces to rsgroup can have multiple options like: # *Move All Tables:* This option involves moving all tables within a namespace to the new RS group, regardless of the current RS group they belong to. This would effectively consolidate all tables of the namespace into the new RS group. This is the same as the current implementation so it can be default behavior. # {*}Move Tables present in current RS group{*}: With this option, only tables belonging to the current RS group of the namespace would be moved to the new RS group. This provides more granular control, allowing users to choose specific tables to move based on their needs. If the namespace does not belong to any RS group, the namespace tables in the default RS group would be moved to the new RS group. # *Move No Tables:* This option involves changing the RS group of the namespace without moving any tables. Existing tables would remain in their current RS group. This could be useful if there's a desire to separate the namespaces by RS group but without immediately moving the tables. With this options we can give control to user choose proper option based on the requirements. " Bump cryptography from 42.0.2 to 42.0.4 in /dev-support/git-jira-release-audit,13569752,Resolved,Major,Fixed,25/Feb/24 09:09,25/Feb/24 09:13,, [hbase-thirdparty] bump deps for 4.1.6 release,13568780,Resolved,Major,Fixed,16/Feb/24 15:18,26/Feb/24 14:58,,"* protobuf 3.24.3 -> 3.25.2 * guava 32.1.2-jre -> 33.0.0-jre * commons-cli 1.5.0 -> 1.6.0 * jetty 9.4.53.v20231009 -> 9.4.54.v20240208 * jersey 2.40 -> 2.41 * javassist 3.29.2-GA -> 3.30.2-GA * jackson-jaxrs-json-provider 2.15.2 -> 2.16.1" [hbase-thirdparty] Upgrade Netty to 4.1.107.Final,13568335,Resolved,Major,Fixed,13/Feb/24 16:49,13/Feb/24 21:55,,https://netty.io/news/2024/02/13/4-1-107-Final.html Make sure we close all the scanners in TestHRegion,13569605,Resolved,Major,Fixed,23/Feb/24 07:46,24/Feb/24 09:08,,"While trying to figure out the root cause for memory leak in HBASE-27941, we found that in TestHRegion, we do not always close the opened scanner, which messes up the memory leak log." WAL value compression fails for cells with large values,13569376,Resolved,Major,Fixed,21/Feb/24 16:47,23/Feb/24 19:02,,"We are testing out WAL compression and noticed that it fails for large values when both features (wal compression and wal value compression) are enabled. It works fine with either feature independently, but not when combined. It seems to fail for all of the value compressor types, and the failure is in the LRUDictionary of wal key compression:   {code:java} java.io.IOException: Error  while reading 2 WAL KVs; started reading at 230 and read up to 396     at org.apache.hadoop.hbase.regionserver.wal.ProtobufWALStreamReader.next(ProtobufWALStreamReader.java:94) ~[classes/:?]     at org.apache.hadoop.hbase.wal.CompressedWALTestBase.doTest(CompressedWALTestBase.java:181) ~[test-classes/:?]     at org.apache.hadoop.hbase.wal.CompressedWALTestBase.testForSize(CompressedWALTestBase.java:129) ~[test-classes/:?]     at org.apache.hadoop.hbase.wal.CompressedWALTestBase.testLarge(CompressedWALTestBase.java:94) ~[test-classes/:?]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]     at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2]     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2]     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2]     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2]     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) ~[junit-4.13.2.jar:4.13.2]     at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) ~[junit-4.13.2.jar:4.13.2]     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) ~[junit-4.13.2.jar:4.13.2]     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) ~[junit-4.13.2.jar:4.13.2]     at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]     at java.lang.Thread.run(Thread.java:829) ~[?:?] Caused by: java.lang.IndexOutOfBoundsException: index (21) must be less than size (1)     at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1371) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]     at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1353) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]     at org.apache.hadoop.hbase.io.util.LRUDictionary$BidirectionalLRUMap.get(LRUDictionary.java:153) ~[classes/:?]     at org.apache.hadoop.hbase.io.util.LRUDictionary$BidirectionalLRUMap.access$000(LRUDictionary.java:79) ~[classes/:?]     at org.apache.hadoop.hbase.io.util.LRUDictionary.getEntry(LRUDictionary.java:43) ~[classes/:?]     at org.apache.hadoop.hbase.regionserver.wal.WALCellCodec$CompressedKvDecoder.readIntoArray(WALCellCodec.java:366) ~[classes/:?]     at org.apache.hadoop.hbase.regionserver.wal.WALCellCodec$CompressedKvDecoder.parseCell(WALCellCodec.java:307) ~[classes/:?]     at org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:66) ~[classes/:?]     at org.apache.hadoop.hbase.wal.WALEdit.readFromCells(WALEdit.java:313) ~[classes/:?]     at org.apache.hadoop.hbase.regionserver.wal.ProtobufWALStreamReader.next(ProtobufWALStreamReader.java:84) ~[classes/:?]     ... 27 more {code} We've created a unit test which reproduces for each compressor type. It seems to fail around the 200kb value size for each." Default user quotas are refreshing too frequently,13568621,Resolved,Major,Fixed,15/Feb/24 17:21,19/Feb/24 22:16,,"In [https://github.com/apache/hbase/pull/5666] we introduced default user quotas, but I accidentally called UserQuotaState's default constructor rather than passing in the current timestamp. The consequence is that we're constantly refreshing these default user quotas, and this can be a bottleneck for horizontal cluster scalability. This should be a 1 line fix in QuotaUtil's buildDefaultUserQuotaState method." Bump gitpython from 3.1.37 to 3.1.41 in /dev-support/git-jira-release-audit,13564566,Resolved,Major,Fixed,13/Jan/24 06:50,13/Jan/24 06:55,, Bump cryptography from 41.0.6 to 42.0.0 in /dev-support/git-jira-release-audit,13568089,Resolved,Major,Fixed,10/Feb/24 03:03,10/Feb/24 03:04,, "WAL readers treat any exception as EOFException, which can lead to data loss",13569679,Open,Major,,23/Feb/24 19:16,,,"In HBASE-28390, I found a bug in our WAL compression which manifests as an IllegalArgumentException or ArrayIndexOutOfBoundException. Even worse is that ProtobufLogReader.readNext catches any Exception and rethrows it as an EOFException. EOFException gets handled in a variety of ways by the readers of WALs, and not all of them make sense for an exception that isn't really EOF. For example, WALInputFormat catches EOFException and returns false for nextKeyValue(), effectively skipping the rest of the WAL file but not failing the job. ReplicationSourceWALReader has some much more complicated handling of EOFException. RegionServer replayRecoveredEdits stops trying to read the WAL, which might mean data loss. We probably should better handle these exceptions which are not EOF exceptions." Bump jackson version to 2.16.1,13569477,Resolved,Major,Duplicate,22/Feb/24 09:44,23/Feb/24 10:47,, Makeuse of jenkins libraries to reuse the stage definition code to run with multiple JDKs,13569534,Open,Major,,22/Feb/24 17:51,,,As for the discussion at https://github.com/apache/hbase/pull/5689#pullrequestreview-1892363058 would be better to make use jenkins libraries to reuse most of the code in JenkinsFiles to support multiple JDKs. Fallback to simple is broken for blocking rpc client,13568964,Resolved,Major,Fixed,18/Feb/24 07:28,19/Feb/24 15:13,,"Found this when implementing HBASE-28321, we do not have a test for fallback to simple with blocking rpc client..." Field sorting is broken in HBase Web UI,13569321,Open,Major,,21/Feb/24 10:10,,2.6.0,Field sorting is broken in HBase Web UI for tables.jsp. As part of this Jira plan on auditing all such elements which support sorting and fixing them. Also we should avoid index based field sorting (which is prone to getting broken) as addition of new fields breaks them as the indexes may change. Close HBase connection on implicit exit from HBase shell,13567979,Resolved,Major,Fixed,09/Feb/24 09:20,13/Feb/24 10:26,,"The fix in HBASE-28345 only works when the exit function is explicitly called. It does not work when scripts are piped in in non-interactive mode. Hook the connection close into Ruby at_exit instead of the exit shell command." Bump cryptography from 42.0.0 to 42.0.2 in /dev-support/git-jira-release-audit,13568973,Resolved,Major,Fixed,18/Feb/24 10:30,18/Feb/24 10:31,, HBase Operator Tools fails to compile with hbase 2.6.0,13568792,Resolved,Major,Fixed,16/Feb/24 16:10,18/Feb/24 06:59,,"HBase Operator Tools fails to compile with hbase 2.6.0. {code:java} [ERROR] /file_path/hbase-operator-tools/hbase-hbck2/src/main/java/org/apache/hbase/hbck1/ReplicationChecker.java:[59,49] method getReplicationPeerStorage in class org.apache.hadoop.hbase.replication.ReplicationStorageFactory cannot be applied to given types; [ERROR]   required: org.apache.hadoop.fs.FileSystem,org.apache.hadoop.hbase.zookeeper.ZKWatcher,org.apache.hadoop.conf.Configuration [ERROR]   found: org.apache.hadoop.hbase.zookeeper.ZKWatcher,org.apache.hadoop.conf.Configuration [ERROR]   reason: actual and formal argument lists differ in length {code} Seems there is a breaking change between [https://github.com/apache/hbase/blob/branch-2.5/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStorageFactory.java] vs [https://github.com/apache/hbase/blob/branch-2.6/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStorageFactory.java] where a public method has been dropped, which is used by operator tools and hence  the build will fail for it. See [https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/src/main/java/org/apache/hbase/hbck1/ReplicationChecker.java#L58] where the effected method is invoked. Since ReplicationStorageFactory is @InterfaceAudience.Private so maybe it is fine. Will try to fix and make changes in hbase-operator-tools to fall back to new method, in case if build with branch-2.6 CC: [~zhangduo]  " [hbase-thirdparty] Bump protobuf version to 3.25.2,13568724,Resolved,Major,Duplicate,16/Feb/24 12:24,16/Feb/24 15:42,,There's an update to protobuf. [hbase-thirdparty] upgrade Guava to 33.0.0-jre,13568725,Resolved,Major,Duplicate,16/Feb/24 12:33,16/Feb/24 15:41,, Add os-maven-plugin to hbase-thirdparty build,13568444,Resolved,Major,Fixed,14/Feb/24 15:33,16/Feb/24 14:55,,A small nice thing we don't yet have in the hbase-thirdparty maven configuration. This extension prints the current operating system environment at the start of a build. Few ITs (using MiniMRYarnCluster on hadoop-2) are failing due to NCDFE: com/sun/jersey/core/util/FeaturesAndProperties,13564597,Resolved,Major,Fixed,14/Jan/24 06:57,13/Feb/24 19:09,,"Found this while trying to run tests for HBASE-28301 locally, On branch-2 where hadoop 2 is default, the specified tests don't even run as MiniMRYarnCluster itself fails to start. For example saw this while trying to run IntegrationTestImportTsv: {code:java} 2024-01-12T01:10:13,486 ERROR [Thread-221 {}] log.Slf4jLog(87): Error starting handlers java.lang.NoClassDefFoundError: com/sun/jersey/core/util/FeaturesAndProperties     at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]     at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]     at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) ~[?:1.8.0_381]     at java.net.URLClassLoader.defineClass(URLClassLoader.java:473) ~[?:1.8.0_381]     at java.net.URLClassLoader.access$100(URLClassLoader.java:74) ~[?:1.8.0_381]     at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]     at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]     at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_381]     at java.net.URLClassLoader.findClass(URLClassLoader.java:362) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]     at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]     at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]     at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) ~[?:1.8.0_381]     at java.net.URLClassLoader.defineClass(URLClassLoader.java:473) ~[?:1.8.0_381]     at java.net.URLClassLoader.access$100(URLClassLoader.java:74) ~[?:1.8.0_381]     at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]     at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]     at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_381]     at java.net.URLClassLoader.findClass(URLClassLoader.java:362) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]     at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.8.0_381]     at java.lang.ClassLoader.defineClass(ClassLoader.java:756) ~[?:1.8.0_381]     at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) ~[?:1.8.0_381]     at java.net.URLClassLoader.defineClass(URLClassLoader.java:473) ~[?:1.8.0_381]     at java.net.URLClassLoader.access$100(URLClassLoader.java:74) ~[?:1.8.0_381]     at java.net.URLClassLoader$1.run(URLClassLoader.java:369) ~[?:1.8.0_381]     at java.net.URLClassLoader$1.run(URLClassLoader.java:363) ~[?:1.8.0_381]     at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_381]     at java.net.URLClassLoader.findClass(URLClassLoader.java:362) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]     at java.lang.Class.getDeclaredConstructors0(Native Method) ~[?:1.8.0_381]     at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671) ~[?:1.8.0_381]     at java.lang.Class.getDeclaredConstructors(Class.java:2020) ~[?:1.8.0_381]     at com.google.inject.spi.InjectionPoint.forConstructorOf(InjectionPoint.java:243) ~[guice-3.0.jar:?]     at com.google.inject.internal.ConstructorBindingImpl.create(ConstructorBindingImpl.java:96) ~[guice-3.0.jar:?]     at com.google.inject.internal.InjectorImpl.createUninitializedBinding(InjectorImpl.java:629) ~[guice-3.0.jar:?]     at com.google.inject.internal.InjectorImpl.createJustInTimeBinding(InjectorImpl.java:845) ~[guice-3.0.jar:?]     at com.google.inject.internal.InjectorImpl.createJustInTimeBindingRecursive(InjectorImpl.java:772) ~[guice-3.0.jar:?]     at com.google.inject.internal.InjectorImpl.getJustInTimeBinding(InjectorImpl.java:256) ~[guice-3.0.jar:?]     at com.google.inject.internal.InjectorImpl.getBindingOrThrow(InjectorImpl.java:205) ~[guice-3.0.jar:?]     at com.google.inject.internal.InjectorImpl.getBinding(InjectorImpl.java:146) ~[guice-3.0.jar:?]     at com.google.inject.internal.InjectorImpl.getBinding(InjectorImpl.java:66) ~[guice-3.0.jar:?]     at com.google.inject.servlet.FilterDefinition.init(FilterDefinition.java:99) ~[guice-servlet-3.0.jar:?]     at com.google.inject.servlet.ManagedFilterPipeline.initPipeline(ManagedFilterPipeline.java:98) ~[guice-servlet-3.0.jar:?]     at com.google.inject.servlet.GuiceFilter.init(GuiceFilter.java:172) ~[guice-servlet-3.0.jar:?]     at org.mortbay.jetty.servlet.FilterHolder.doStart(FilterHolder.java:97) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) ~[jetty-util-6.1.26.jar:6.1.26]     at org.mortbay.jetty.servlet.ServletHandler.initialize(ServletHandler.java:713) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.jetty.servlet.Context.startContext(Context.java:140) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1282) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.jetty.handler.ContextHandler.doStart(ContextHandler.java:518) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.jetty.webapp.WebAppContext.doStart(WebAppContext.java:499) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) ~[jetty-util-6.1.26.jar:6.1.26]     at org.mortbay.jetty.handler.HandlerCollection.doStart(HandlerCollection.java:152) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.jetty.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:156) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) ~[jetty-util-6.1.26.jar:6.1.26]     at org.mortbay.jetty.handler.HandlerWrapper.doStart(HandlerWrapper.java:130) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.jetty.Server.doStart(Server.java:224) ~[jetty-6.1.26.jar:6.1.26]     at org.mortbay.component.AbstractLifeCycle.start(AbstractLifeCycle.java:50) ~[jetty-util-6.1.26.jar:6.1.26]     at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:964) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:408) ~[hadoop-yarn-common-2.10.2.jar:?]     at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:397) ~[hadoop-yarn-common-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.initializeWebApp(HistoryClientService.java:156) ~[hadoop-mapreduce-client-hs-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.serviceStart(HistoryClientService.java:121) ~[hadoop-mapreduce-client-hs-2.10.2.jar:?]     at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.hs.JobHistoryServer.serviceStart(JobHistoryServer.java:202) ~[hadoop-mapreduce-client-hs-2.10.2.jar:?]     at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster$JobHistoryServerWrapper$1.run(MiniMRYarnCluster.java:241) ~[hadoop-mapreduce-client-jobclient-2.10.2-tests.jar:?] Caused by: java.lang.ClassNotFoundException: com.sun.jersey.core.util.FeaturesAndProperties     at java.net.URLClassLoader.findClass(URLClassLoader.java:387) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:418) ~[?:1.8.0_381]     at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355) ~[?:1.8.0_381]     at java.lang.ClassLoader.loadClass(ClassLoader.java:351) ~[?:1.8.0_381]     ... 75 more 2024-01-12T01:10:13,488 INFO  [Thread-221 {}] log.Slf4jLog(67): Started HttpServer2$SelectChannelConnectorWithSafeStartup@WM-C02FW1LNMD6T:50665 2024-01-12T01:10:13,493 INFO  [Thread-221 {}] log.Slf4jLog(67): Stopped HttpServer2$SelectChannelConnectorWithSafeStartup@WM-C02FW1LNMD6T:0 2024-01-12T01:10:13,600 ERROR [Thread[Thread-222,5,main] {}] delegation.AbstractDelegationTokenSecretManager$ExpiredTokenRemover(696): ExpiredTokenRemover received java.lang.InterruptedException: sleep interrupted 2024-01-12T01:10:13,601 ERROR [Thread-221 {}] server.NIOServerCnxnFactory(85): Thread Thread[Thread-221,5,main] died org.apache.hadoop.yarn.webapp.WebAppException: Error starting http server     at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:412) ~[hadoop-yarn-common-2.10.2.jar:?]     at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:397) ~[hadoop-yarn-common-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.initializeWebApp(HistoryClientService.java:156) ~[hadoop-mapreduce-client-hs-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.serviceStart(HistoryClientService.java:121) ~[hadoop-mapreduce-client-hs-2.10.2.jar:?]     at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:121) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.hs.JobHistoryServer.serviceStart(JobHistoryServer.java:202) ~[hadoop-mapreduce-client-hs-2.10.2.jar:?]     at org.apache.hadoop.service.AbstractService.start(AbstractService.java:194) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster$JobHistoryServerWrapper$1.run(MiniMRYarnCluster.java:241) ~[hadoop-mapreduce-client-jobclient-2.10.2-tests.jar:?] Caused by: java.io.IOException: Problem in starting http server. Server handlers failed     at org.apache.hadoop.http.HttpServer2.start(HttpServer2.java:976) ~[hadoop-common-2.10.2.jar:?]     at org.apache.hadoop.yarn.webapp.WebApps$Builder.start(WebApps.java:408) ~[hadoop-yarn-common-2.10.2.jar:?]     ... 8 more{code} CC: [~zhangduo] " ChaosMonkey batch suspend/resume action assume shell implementation,13568358,Open,Major,,13/Feb/24 22:59,,,"These two actions have code like this: {code:java} case SUSPEND: server = serversToBeSuspended.remove(); try { suspendRs(server); } catch (Shell.ExitCodeException e) { LOG.warn(""Problem suspending but presume successful; code={}"", e.getExitCode(), e); } suspendedServers.add(server); break; {code} This only catches that one Shell.ExitCodeException, but operators may have an implementation of ClusterManager which does not use shell. We should expand this to catch all exceptions. The implication here is that the uncaught exception propagates, and we don't add the server to suspendedServers. If the suspension actually succeeded, this leaves some processes in a permanently suspended state until manual intervention occurs." Noisy exception from FlushRegionProcedure when result is CANNOT_FLUSH,13568355,Open,Major,,13/Feb/24 22:19,,,"Running ITBLL with chaos monkey in HBASE-28233. I noticed lots of exceptions: {code:java} [RS_FLUSH_OPERATIONS-regionserver/test-host:60020-1 {event_type=RS_FLUSH_REGIONS, pid=741536}] ERROR org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler: pid=741536 java.io.IOException: Unable to complete flush {ENCODED => 371d2ba6875913542893642c94634226, NAME => 'IntegrationTestBigLinkedList,-\x82\xD8-\x82\xD8-\x80,1707761077516.371d2ba6875913542893642c94634226.', STARTKEY = > '-\x82\xD8-\x82\xD8-\x80', ENDKEY => '33333330'}         at org.apache.hadoop.hbase.regionserver.FlushRegionCallable.doCall(FlushRegionCallable.java:61) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.BaseRSProcedureCallable.call(BaseRSProcedureCallable.java:35) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.BaseRSProcedureCallable.call(BaseRSProcedureCallable.java:23) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:51) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]         at java.lang.Thread.run(Thread.java:840) ~[?:?] {code} I took a look at the HRegion.flushcache code, and there are 3 reasons for CANNOT_FLUSH. All only print at debug log level and none look like actual errors. I think we shouldn't throw an exception here, or at least should downgrade to debug. It looks like a problem, but isn't (i dont think). cc [~frostruan] " NPE calling bootstrapNodeManager during RegionServer initialization,13568354,Open,Major,,13/Feb/24 22:11,,,"Shortly after starting up, if a RegionServer is getting requests from clients before it's ready (i.e. it restarts and they haven't cleared meta cache yet), it will throw an NPE. This is because netty may bind and start accepting requests before HRegionServer.preRegistrationInitialization finishes. I think this is similar to https://issues.apache.org/jira/browse/HBASE-28088. It's not critical because the RS self-resolves within a few seconds, but it causes noise in the logs and probably errors for clients. {code:java} 2024-02-13T18:24:02,537 [RpcServer.default.FPBQ.handler=6,queue=6,port=60020 {}] ERROR org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object java.lang.NullPointerException: Cannot invoke ""org.apache.hadoop.hbase.regionserver.BootstrapNodeManager.getBootstrapNodes()"" because ""this.bootstrapNodeManager"" is null         at org.apache.hadoop.hbase.regionserver.HRegionServer.getBootstrapNodes(HRegionServer.java:4179) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.regionserver.RSRpcServices.getAllBootstrapNodes(RSRpcServices.java:4140) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.shaded.protobuf.generated.BootstrapNodeProtos$BootstrapNodeService$2.callBlockingMethod(BootstrapNodeProtos.java:1259) ~[hbase-protocol-shaded-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:438) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) ~[hbase-server-2.6-hubspot-SNAPSHOT.jar:2.6-hubspot-SNAPSHOT] {code}" Update dependencies in hbase-connectors: HBase version to 2.6.0 post release,13568342,Open,Major,,13/Feb/24 18:56,,,"This proposes to bump up the default versions used by hbase-connectors to recent versions, in particular for HBase and hbase-thirdparty version" [JDK17] Fix Failure TestLdapHttpServer,13567103,Resolved,Major,Fixed,02/Feb/24 00:18,12/Feb/24 04:48,,"TestLdapHttpServer is failing with JDK17 because of internal APIs usage. {code:java} [INFO] Running org.apache.hadoop.hbase.http.TestLdapHttpServer [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 7.18 s <<< FAILURE! - in org.apache.hadoop.hbase.http.TestLdapHttpServer [ERROR] org.apache.hadoop.hbase.http.TestLdapHttpServer Time elapsed: 7.165 s <<< ERROR! java.lang.IllegalAccessError: class org.apache.directory.server.core.security.CertificateUtil (in unnamed module @0x25bbf683) cannot access class sun.security.x509.X500Name (in module java.base) because module java.base does not export sun.security.x509 to unnamed module @0x25bbf683 at org.apache.directory.server.core.security.CertificateUtil.createTempKeyStore(CertificateUtil.java:334) at org.apache.directory.server.factory.ServerAnnotationProcessor.instantiateLdapServer(ServerAnnotationProcessor.java:158) at org.apache.directory.server.factory.ServerAnnotationProcessor.createLdapServer(ServerAnnotationProcessor.java:318) at org.apache.directory.server.factory.ServerAnnotationProcessor.createLdapServer(ServerAnnotationProcessor.java:351) at org.apache.directory.server.core.integ.CreateLdapServerRule$2.evaluate(CreateLdapServerRule.java:112) at org.apache.directory.server.core.integ.CreateDsRule$2.evaluate(CreateDsRule.java:124) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] TestLdapHttpServer » IllegalAccess class org.apache.directory.server.core.security.CertificateUtil (in unnamed module @0x25bbf683) cannot access class sun.security.x509.X500Name (in module java.base) because module java.base does not export sun.security.x509 to unnamed module @0x25bbf683 [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 {code} Adding following to jvn flags works. {code} + --add-opens java.base/sun.security.x509=ALL-UNNAMED + --add-opens java.base/sun.security.util=ALL-UNNAMED {code}" HTable batch does not honor RpcThrottlingException waitInterval,13567956,Resolved,Major,Fixed,09/Feb/24 00:55,11/Feb/24 14:38,,I noticed that we only honor the waitInterval in RpcRetryingCaller.callWithRetries. But HTable.batch (AsyncProcess) uses custom retry logic. We need to update it to honor the waitInterval Atomic requests should increment read usage in quotas,13567761,Resolved,Major,Fixed,07/Feb/24 14:35,09/Feb/24 14:02,,"Right now atomic operations are just treated as a single write from the quota perspective. Since an atomic operation also encompasses a read, it would make sense to increment readNum and readSize counts appropriately." Positive connection test in TestShadeSaslAuthenticationProvider runs with Kerberos instead of Shade authentication,13566787,Resolved,Major,Fixed,30/Jan/24 21:10,08/Feb/24 15:38,2.4.17,"The positive test (testPositiveAuthentication) in TestShadeSaslAuthenticationProvider doesn't create a new user in user1.doAs(), so it will use the already Kerberos authenticated user instead of re-authenticating with the token.  As a consequence it doesn't reveal a problem introduced with HBASE-23881 which will cause clients to timeout if authenticated with a SASL mech which doesn't create a reply token in case of successful authentication." Output hbase logs to working directory in client integration test,13566075,Resolved,Major,Fixed,25/Jan/24 06:23,08/Feb/24 12:47,,"So we can see them in the job artifacts, currently it will be logged to hbase install directory which is outside the working dir so we can not see them. The client integration test for master branch is failing because can not start hbase cluster, we need the logs to find out the root cause." Close HBase connection on exit from HBase Shell,13567613,Resolved,Major,Fixed,06/Feb/24 15:18,08/Feb/24 07:34,2.4.17,"When using Netty for the ZK client, hbase shell hangs on exit. This is caused by the non-deamon Netty threads that ZK creates. Wheter ZK should create daemon threads for Netty or not is debatable, but explicitly closing the connection in hbase shell on exit fixes the issue." Multi should return what results it can before rpc timeout,13567754,Open,Major,,07/Feb/24 13:39,,,"Scans have a nice feature where they try to return a heartbeat with whatever results they have accumulated before the rpc timeout expires. It targets returning in 1/2 the rpc timeout or max scanner time. The reason for scans is to avoid painful scanner timeouts which cause the scan to have to be restarted due to out of sync sequence id. Multis have a similar problem. A big batch can come in which can't be served in the configured timeout. In this case the client side will abandon the request when the timeout is exceeded, and resubmit if there are retries/operation timeout left. This wastes work since it's likely that some of the results had been fetched by the time a timeout occurred. Multis already can retry immediately when the batch exceeds the max result size limit. We can use the same functionality to also return when we've taken more than half the rpc timeout." Update ref guide about isolation guarantees for scans,13567674,Open,Major,,07/Feb/24 02:40,,,"In the ""Consistency of Scans"" section of [https://hbase.apache.org/acid-semantics.html,] there is some confusing and outdated information. First it's hard to realize that it's specifically talking about consistency across rows. Secondly, it's outdated because in modern hbase we acquire and maintain a memstore readPt for the lifetime of a scan in a region. So we should retain read committed behavior across rows, at least within the scope of a region." Add comment around erasure coding policy in DEFAULT_VALUE map,13566534,Resolved,Major,Fixed,29/Jan/24 14:40,05/Feb/24 13:22,,"New description: Upon investigation, we realized that it's necessary to put ERASURE_CODING_POLICY in the DEFAULT_VALUES map so that when the TableDescriptor is printed as a string, that setting is not listed as METADATA. We added a comment to note that for future reference. Old description: With ERASURE_CODING_POLICY, the default value is null (no policy). I added a record of that in DEFAULT_VALUES, because other settings seemed to do that. A null value is never stored on a HTD because our code handles removing from map when setting null. So we'd never have an opportunity to match against the DEFAULT_VALUE. If someone tried setting a string value ""null"", that would fail validation because it's not a valid policy. So there's no reason to record this default value. It doesn't cause a problem, but is confusing to anyone reading the code. Remove it." Write codec class into hfile header/trailer,13567490,Open,Major,,05/Feb/24 21:46,,,"We recently started playing around with the new bundled compression libraries as of 2.5.0. Specifically, we are experimenting with the different zstd codecs. The book says that aircompressor's zstd is not data compatible with hadoops, but doesn't say the same about zstd-jni. In our experiments we ended up in a state where some hfiles were encoded with zstd-jni (zstd.ZstdCodec) while others were encoded with hadoop (ZStandardCodec). At this point the cluster became extremely unstable, with some files unable to be read because they encoded with a codec that didn't match the current runtime configration. Changing the runtime configuration caused the other files to not be readable. I think this problem could be solved by writing the classname of the codec used into the hfile. This could be used as a hint so that a regionserver can read hfiles compressed with any compression codec that it supports. [~apurtell] do you have any thoughts here since you brought us all of these great compression options?" Client integration test fails after upgrading hadoop3 version to 3.3.x,13566151,Resolved,Major,Fixed,25/Jan/24 14:33,30/Jan/24 08:44,,"Saw this error when starting HBase cluster {noformat} 2024-01-25T11:25:01,838 ERROR [master/jenkins-hbase21:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.ClassCastException: org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$SetSafeModeRequestProto cannot be cast to com.google.protobuf.Message at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:247) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:132) ~[hadoop-common-3.3.5.jar:?] at com.sun.proxy.$Proxy32.setSafeMode(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.setSafeMode(ClientNamenodeProtocolTranslatorPB.java:847) ~[hadoop-hdfs-client-3.3.5.jar:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_362] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_362] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:433) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:166) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:158) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:96) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:362) ~[hadoop-common-3.3.5.jar:?] at com.sun.proxy.$Proxy33.setSafeMode(Unknown Source) ~[?:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_362] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_362] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at com.sun.proxy.$Proxy34.setSafeMode(Unknown Source) ~[?:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_362] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_362] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at com.sun.proxy.$Proxy34.setSafeMode(Unknown Source) ~[?:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_362] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_362] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at com.sun.proxy.$Proxy34.setSafeMode(Unknown Source) ~[?:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_362] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_362] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_362] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_362] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at com.sun.proxy.$Proxy34.setSafeMode(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.DFSClient.setSafeMode(DFSClient.java:2138) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem.setSafeMode(DistributedFileSystem.java:1645) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hbase.util.FSUtils.isInSafeMode(FSUtils.java:251) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.util.FSUtils.waitOnSafeMode(FSUtils.java:650) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(MasterFileSystem.java:223) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileSystemLayout(MasterFileSystem.java:136) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.MasterFileSystem.(MasterFileSystem.java:113) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2499) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT] at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] {noformat} https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/995/artifact/output-integration/hadoop-3/hbase-jenkins-master-jenkins-hbase21.log/*view*/" HBaseReplicationEndpoint creates new ZooKeeper client every time it tries to reconnect,13567063,Resolved,Major,Invalid,01/Feb/24 16:20,02/Feb/24 16:11,2.4.17,"Asbtract base class {{HBaseReplicationEndpoint}} and therefore {{HBaseInterClusterReplicationEndpoint}} creates new ZooKeeper client instance every time there's an error occurs in communication and it tries to reconnect. This was not a problem with ZooKeeper 3.4.x versions, because the TGT Login thread was a static reference and only created once for all clients in the same JVM. With the upgrade to ZooKeeper 3.5.x the login thread is dedicated to the client instance, hence we have a new login thread every time the replication endpoint reconnects. {code:java} /** * A private method used to re-establish a zookeeper session with a peer cluster. */ protected void reconnect(KeeperException ke) { if ( ke instanceof ConnectionLossException || ke instanceof SessionExpiredException || ke instanceof AuthFailedException ) { String clusterKey = ctx.getPeerConfig().getClusterKey(); LOG.warn(""Lost the ZooKeeper connection for peer "" + clusterKey, ke); try { reloadZkWatcher(); } catch (IOException io) { LOG.warn(""Creation of ZookeeperWatcher failed for peer "" + clusterKey, io); } } }{code} {code:java} /** * Closes the current ZKW (if not null) and creates a new one * @throws IOException If anything goes wrong connecting */ synchronized void reloadZkWatcher() throws IOException { if (zkw != null) zkw.close(); zkw = new ZKWatcher(ctx.getConfiguration(), ""connection to cluster: "" + ctx.getPeerId(), this); getZkw().registerListener(new PeerRegionServerListener(this)); } {code} If the target cluster of replication is unavailable for some reason, the replication endpoint keeps trying to reconnect to ZooKeeper destroying and creating new Login threads constantly which will carpet bomb the KDC host with login requests.   I'm not sure how to fix this yet, trying to create a unit test first." Refactor TestClientTimeouts to make it more clear that what we want to test,13566230,Resolved,Major,Fixed,26/Jan/24 04:01,26/Jan/24 14:41,,"In HBASE-23647, we change the default registry to rpc based, so it could also fail when setting up connection when we inject a timeout rpc client, but actually we just want to test timeout for admin methods, so we'd better refactor the test a bit to make it more clear that the failure for master setup is not important." TestUnknownServers.testListUnknownServers is flaky in branch-2,13566120,Resolved,Major,Fixed,25/Jan/24 11:18,26/Jan/24 07:00,2.5.7,"{code:java} [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.913 s <<< FAILURE! - in org.apache.hadoop.hbase.master.TestUnknownServers [ERROR] org.apache.hadoop.hbase.master.TestUnknownServers.testListUnknownServers Time elapsed: 0.204 s <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<2> {code} The value of TestUnknownServers.SLAVES is different between [branch-2|https://github.com/apache/hbase/blob/68bc533f7116cedc681704b82319e5793b827621/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestUnknownServers.java#L44] and [master|https://github.com/apache/hbase/blob/b87b05c847f00c292664d894c21f83c73d48460d/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestUnknownServers.java#L43]. It is 1 in master but 2 in branch-2. The RegionServer marked UNKNOWN_SERVER is the one that *holds regions* but is not tracked by the ServerManager. Please see HMaster.getUnknownServers {code:java} private List getUnknownServers() { if (serverManager != null) { final Set serverNames = getAssignmentManager().getRegionStates().getRegionStates() .stream().map(RegionState::getServerName).collect(Collectors.toSet()); final List unknownServerNames = serverNames.stream() .filter(sn -> sn != null && serverManager.isServerUnknown(sn)).collect(Collectors.toList()); return unknownServerNames; } return null; } {code} In UT TestUnknownServers.testListUnknownServers, we start a HBase cluster with 2 RegionServer, if all region are assigned to ONE server, then only that server is called UNKNOWN_SERVER, the UT will fail." Remove noisy WARN from trying to construct MetricsServlet,13564892,Resolved,Major,Fixed,16/Jan/24 16:53,25/Jan/24 14:48,3.0.0-beta-1,"MetricsServlet is deprecated since hadoop 2.8 and removed in hadoop3. In HBASE-20904 the servlet initialization was refactored, and we now have a noisy WARN (with stacktrace) when MetricsServlet does not exist. This should be common, since hadoop3 is the modern version to run on (hadoop2 almost EOL). We shouldn't warn. Fix the code to not produce a warn when MetricsServlet is not available." "Add remove(String key, Metric metric) method to MetricRegistry interface",13566034,Resolved,Major,Fixed,24/Jan/24 20:37,25/Jan/24 13:31,,"Add a `remove(String name, Metric metric)` method to the `MetricRegistry` interface. Right now the interface only contains a `remove(String name)` method. This additional remove method will give users the power to remove a `Metric` with the specified `name` from the metric registry if and only if the provided `metric` matches the object in the registry. Implementing the new `remove(String name, Metric metric)` should be straight forward because the `MetricRegistryImpl` class stores metrics in a `ConcurrentMap`, which already contains a `remove(Object key, Object value)` method This change will not be a breaking one because the interface is marked with `@IntefaceStability.Evolving` [~rmdmattingly]" All nightly jobs are failing,13565899,Resolved,Major,Fixed,24/Jan/24 07:41,24/Jan/24 14:28,,"https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/991/console Failed in yetus install stage, seems to be related to gpg." Attach the design doc in HBASE-26220 to our code base,13565266,Resolved,Major,Fixed,18/Jan/24 13:37,24/Jan/24 14:12,, Add tracking of fs read times in ScanMetrics and slow logs,13564208,Resolved,Major,Fixed,10/Jan/24 14:43,23/Jan/24 18:10,,"We've had this in our production for a while, and it's useful info to have. We already track FS read times in [HFileBlock|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java#L1828-L1831C10]. We can project that into the ScanMetrics instance and slow log pretty easily. It is also helpful to add a slow.fs.read.threshold, over which we log a warn" TestRegionNormalizerWorkQueue#testTake is flaky,13565428,Resolved,Major,Fixed,19/Jan/24 11:54,22/Jan/24 06:38,2.5.7, The bad auth exception can not be passed to client rpc calls properly,13564650,Resolved,Major,Fixed,15/Jan/24 04:15,17/Jan/24 06:03,,"Found this when implementing HBASE-25051. Basically there are 2 problems: # IPCUtil.isFatalConnectionException only checks whether class name matches, so if we use a sub class for FatalConnectionException, it will return false which makes the logic incorrect. # In BlockingRpcConnection, we will first check whether there is a call with the id but since we will pass -1 as call id for bad preamble header, we will return earlier without actually checking the error response. This will not introduce big trouble in production as the call will still fail with connection closed exception, but still worth to fix, anyway." Add property to customize Version information,13564545,Resolved,Major,Fixed,12/Jan/24 20:06,16/Jan/24 21:51,,"In hbase-common we generate Version.java using the ${project.version} property. In some custom builds, it may be necessary to override the project version. The custom version may not be compatible with how Version works, or the user may want to add extra metadata (like a build number). We can add a property which defaults to ${project.version} but allows the user to specify separately if desired." Expose DelegatingRpcScheduler as IA.LimitedPrivate,13565122,Resolved,Major,Duplicate,17/Jan/24 17:26,17/Jan/24 17:34,,"We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible change from HBASE-27144. We can limit the impact of breaking changes like this by exposing DelegatingRpcScheduler to users. Users can extend this class and only override the pieces that they care about, thus reducing the surface area of compatibility issues." Expose DelegatingRpcScheduler as IA.LimitedPrivate,13565124,Resolved,Major,Duplicate,17/Jan/24 17:27,17/Jan/24 17:34,,"We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible change from HBASE-27144. We can limit the impact of breaking changes like this by exposing DelegatingRpcScheduler to users. Users can extend this class and only override the pieces that they care about, thus reducing the surface area of compatibility issues." Add hbase-openssl module and include in release binaries,13564550,Resolved,Major,Fixed,12/Jan/24 21:49,14/Jan/24 22:24,,"This will make it easier for someone to use, since a common deployment strategy would involve untar'ing our bin assembly." Bump jinja2 from 3.1.2 to 3.1.3 in /dev-support/flaky-tests,13564567,Resolved,Major,Fixed,13/Jan/24 06:52,13/Jan/24 06:58,, Bump gitpython from 3.1.37 to 3.1.41 in /dev-support/flaky-tests,13564565,Resolved,Major,Fixed,13/Jan/24 06:49,13/Jan/24 06:58,, Add hbase-shaded-testing-util version to dependencyManagement,13564254,Resolved,Major,Fixed,10/Jan/24 22:01,11/Jan/24 12:56,,"hbase-shaded-testing-util is the only sub-module referenced as a dependency in hbase poms which is not present in our parent pom dependencyManagement. This causes issues in my employer's build, but is also good for consistency." Few tests are failing due to NCDFE: org/bouncycastle/operator/OperatorCreationException,13563791,Resolved,Major,Fixed,07/Jan/24 08:21,10/Jan/24 13:23,,"See [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/23/] for branch-2.6 * [Test Result|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/23/testReport/] (6 failures / +4) ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.mapreduce.TestHBaseMRTestingUtility.testMRYarnConfigsPopulation|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/23/testReport/junit/org.apache.hadoop.hbase.mapreduce/TestHBaseMRTestingUtility/health_checks___yetus_jdk11_hadoop3_checks___testMRYarnConfigsPopulation/] ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/23/testReport/junit/org.apache.hadoop.hbase.replication/TestVerifyReplicationCrossDiffHdfs/health_checks___yetus_jdk11_hadoop3_checks______/] ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/23/testReport/junit/org.apache.hadoop.hbase.snapshot/TestMobSecureExportSnapshot/health_checks___yetus_jdk11_hadoop3_checks______/] ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/23/testReport/junit/org.apache.hadoop.hbase.snapshot/TestSecureExportSnapshot/health_checks___yetus_jdk11_hadoop3_checks______/] See [https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/] for branch-2 * [Test Result|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/] (8 failures / +7) ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.mapreduce.TestHBaseMRTestingUtility.testMRYarnConfigsPopulation|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.mapreduce/TestHBaseMRTestingUtility/health_checks___yetus_jdk11_hadoop3_checks___testMRYarnConfigsPopulation/] ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.replication/TestVerifyReplicationCrossDiffHdfs/health_checks___yetus_jdk11_hadoop3_checks______/] ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.snapshot/TestMobSecureExportSnapshot/health_checks___yetus_jdk11_hadoop3_checks______/] ** [health checks / yetus jdk11 hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.snapshot/TestSecureExportSnapshot/health_checks___yetus_jdk11_hadoop3_checks______/] ** [health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.mapreduce.TestHBaseMRTestingUtility.testMRYarnConfigsPopulation|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.mapreduce/TestHBaseMRTestingUtility/health_checks___yetus_jdk8_hadoop3_checks___testMRYarnConfigsPopulation/] ** [health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.replication/TestVerifyReplicationCrossDiffHdfs/health_checks___yetus_jdk8_hadoop3_checks______/] ** [health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.snapshot/TestMobSecureExportSnapshot/health_checks___yetus_jdk8_hadoop3_checks______/] ** [health checks / yetus jdk8 hadoop3 checks / org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.(?)|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/956/testReport/junit/org.apache.hadoop.hbase.snapshot/TestSecureExportSnapshot/health_checks___yetus_jdk8_hadoop3_checks______/] Also fails locally for me for master. {code:java} [INFO] ------------------------------------------------------- [INFO]  T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs [INFO] Running org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot [INFO] Running org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot [INFO] Running org.apache.hadoop.hbase.mapreduce.TestHBaseMRTestingUtility [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.928 s <<< FAILURE! - in org.apache.hadoop.hbase.mapreduce.TestHBaseMRTestingUtility [ERROR] org.apache.hadoop.hbase.mapreduce.TestHBaseMRTestingUtility.testMRYarnConfigsPopulation  Time elapsed: 2.861 s  <<< ERROR! java.lang.NoClassDefFoundError: org/bouncycastle/operator/OperatorCreationException         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:888)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createAndInitActiveServices(ResourceManager.java:1410)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:344)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.MiniYARNCluster.initResourceManager(MiniYARNCluster.java:359)         at org.apache.hadoop.yarn.server.MiniYARNCluster.access$200(MiniYARNCluster.java:129)         at org.apache.hadoop.yarn.server.MiniYARNCluster$ResourceManagerWrapper.serviceInit(MiniYARNCluster.java:494)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:109)         at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:327)         at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster.serviceInit(MiniMRYarnCluster.java:213)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.mapred.MiniMRClientClusterFactory.create(MiniMRClientClusterFactory.java:80)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:188)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:176)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:168)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:129)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2352)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2285)         at org.apache.hadoop.hbase.mapreduce.TestHBaseMRTestingUtility.testMRYarnConfigsPopulation(TestHBaseMRTestingUtility.java:64)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)         at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)         at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)         at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)         at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)         at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)         at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)         at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)         at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)         at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.ClassNotFoundException: org.bouncycastle.operator.OperatorCreationException         at java.net.URLClassLoader.findClass(URLClassLoader.java:387)         at java.lang.ClassLoader.loadClass(ClassLoader.java:418)         at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)         at java.lang.ClassLoader.loadClass(ClassLoader.java:351)         ... 43 more[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.902 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot [ERROR] org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot  Time elapsed: 19.899 s  <<< ERROR! java.lang.NoClassDefFoundError: org/bouncycastle/operator/OperatorCreationException         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:888)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createAndInitActiveServices(ResourceManager.java:1410)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:344)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.MiniYARNCluster.initResourceManager(MiniYARNCluster.java:359)         at org.apache.hadoop.yarn.server.MiniYARNCluster.access$200(MiniYARNCluster.java:129)         at org.apache.hadoop.yarn.server.MiniYARNCluster$ResourceManagerWrapper.serviceInit(MiniYARNCluster.java:494)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:109)         at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:327)         at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster.serviceInit(MiniMRYarnCluster.java:213)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.mapred.MiniMRClientClusterFactory.create(MiniMRClientClusterFactory.java:80)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:188)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:176)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:168)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:129)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2352)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2285)         at org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot.setUpBeforeClass(TestMobSecureExportSnapshot.java:56)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.ClassNotFoundException: org.bouncycastle.operator.OperatorCreationException         at java.net.URLClassLoader.findClass(URLClassLoader.java:387)         at java.lang.ClassLoader.loadClass(ClassLoader.java:418)         at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)         at java.lang.ClassLoader.loadClass(ClassLoader.java:351)         ... 35 more[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 19.968 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot [ERROR] org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot  Time elapsed: 19.966 s  <<< ERROR! java.lang.NoClassDefFoundError: org/bouncycastle/operator/OperatorCreationException         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:888)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createAndInitActiveServices(ResourceManager.java:1410)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:344)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.MiniYARNCluster.initResourceManager(MiniYARNCluster.java:359)         at org.apache.hadoop.yarn.server.MiniYARNCluster.access$200(MiniYARNCluster.java:129)         at org.apache.hadoop.yarn.server.MiniYARNCluster$ResourceManagerWrapper.serviceInit(MiniYARNCluster.java:494)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:109)         at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:327)         at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster.serviceInit(MiniMRYarnCluster.java:213)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.mapred.MiniMRClientClusterFactory.create(MiniMRClientClusterFactory.java:80)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:188)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:176)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:168)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:129)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2352)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2285)         at org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot.setUpBeforeClass(TestSecureExportSnapshot.java:56)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.ClassNotFoundException: org.bouncycastle.operator.OperatorCreationException         at java.net.URLClassLoader.findClass(URLClassLoader.java:387)         at java.lang.ClassLoader.loadClass(ClassLoader.java:418)         at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)         at java.lang.ClassLoader.loadClass(ClassLoader.java:351)         ... 35 more[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 30.248 s <<< FAILURE! - in org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs [ERROR] org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs  Time elapsed: 30.246 s  <<< ERROR! java.lang.NoClassDefFoundError: org/bouncycastle/operator/OperatorCreationException         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceInit(ResourceManager.java:888)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createAndInitActiveServices(ResourceManager.java:1410)         at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceInit(ResourceManager.java:344)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.yarn.server.MiniYARNCluster.initResourceManager(MiniYARNCluster.java:359)         at org.apache.hadoop.yarn.server.MiniYARNCluster.access$200(MiniYARNCluster.java:129)         at org.apache.hadoop.yarn.server.MiniYARNCluster$ResourceManagerWrapper.serviceInit(MiniYARNCluster.java:494)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.service.CompositeService.serviceInit(CompositeService.java:109)         at org.apache.hadoop.yarn.server.MiniYARNCluster.serviceInit(MiniYARNCluster.java:327)         at org.apache.hadoop.mapreduce.v2.MiniMRYarnCluster.serviceInit(MiniMRYarnCluster.java:213)         at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)         at org.apache.hadoop.mapred.MiniMRClientClusterFactory.create(MiniMRClientClusterFactory.java:80)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:188)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:176)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:168)         at org.apache.hadoop.mapred.MiniMRCluster.(MiniMRCluster.java:129)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2352)         at org.apache.hadoop.hbase.HBaseTestingUtil.startMiniMapReduceCluster(HBaseTestingUtil.java:2285)         at org.apache.hadoop.hbase.replication.TestVerifyReplicationCrossDiffHdfs.setUpBeforeClass(TestVerifyReplicationCrossDiffHdfs.java:108)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)         at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.lang.Thread.run(Thread.java:750) Caused by: java.lang.ClassNotFoundException: org.bouncycastle.operator.OperatorCreationException         at java.net.URLClassLoader.findClass(URLClassLoader.java:387)         at java.lang.ClassLoader.loadClass(ClassLoader.java:418)         at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:355)         at java.lang.ClassLoader.loadClass(ClassLoader.java:351)         ... 35 more[INFO]  [INFO] Results: [INFO]  [ERROR] Errors:  [ERROR]   TestHBaseMRTestingUtility.testMRYarnConfigsPopulation:64 » NoClassDefFound org/bouncycastle/operator/OperatorCreationException [ERROR]   TestVerifyReplicationCrossDiffHdfs.setUpBeforeClass:108 » NoClassDefFound org/bouncycastle/operator/OperatorCreationException [ERROR]   TestMobSecureExportSnapshot.setUpBeforeClass:56 » NoClassDefFound org/bouncycastle/operator/OperatorCreationException [ERROR]   TestSecureExportSnapshot.setUpBeforeClass:56 » NoClassDefFound org/bouncycastle/operator/OperatorCreationException [INFO]  [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0 {code} I am assuming failures are related to HBASE-28277  CC: [~zhangduo] " IntegrationTestImportTsv fails with ArrayIndexOfOutBounds,13563941,Resolved,Major,Fixed,08/Jan/24 19:30,10/Jan/24 04:08,,"While trying to fix HBASE-28295, found issues in IntegrationTestImportTsv {code:java} mvn --no-snapshot-updates -Dtest=IntegrationTestImportTsv -pl hbase-it package{code} {code:java} [INFO] ------------------------------------------------------- [INFO]  T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.563 s <<< FAILURE! - in org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [ERROR] org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv  Time elapsed: 0.556 s  <<< ERROR! java.lang.ExceptionInInitializerError         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)         at org.junit.runners.ParentRunner.run(ParentRunner.java:413)         at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)         at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)         at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)         at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)         at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)         at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)         at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)         at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495) Caused by: java.lang.ArrayIndexOutOfBoundsException: 1         at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv$1.(IntegrationTestImportTsv.java:90)         at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.(IntegrationTestImportTsv.java:83)         ... 20 more[ERROR] org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv  Time elapsed: 0.557 s  <<< ERROR! java.lang.NoClassDefFoundError: Could not initialize class org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.RunAfters.invokeMethod(RunAfters.java:46)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)         at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)         at org.junit.runners.ParentRunner.run(ParentRunner.java:413)         at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316)         at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240)         at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214)         at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155)         at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)         at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)         at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)         at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495) Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.ArrayIndexOutOfBoundsException: 1 [in thread ""main""]         at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv$1.(IntegrationTestImportTsv.java:90)         at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.(IntegrationTestImportTsv.java:83)         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)         at java.lang.reflect.Method.invoke(Method.java:498)         at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)         at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)         at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)         at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)         at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)         at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)         ... 10 more[INFO]  [INFO] Results: [INFO]  [ERROR] Errors:  [ERROR] org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.null [ERROR]   Run 1: IntegrationTestImportTsv » ExceptionInInitializer [ERROR]   Run 2: IntegrationTestImportTsv » NoClassDefFound Could not initialize class org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [INFO]  [INFO]  [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 {code} CC: [~zhangduo] " Sending compact request if necessary after flushing at server side,13563895,Open,Major,,08/Jan/24 12:41,,,"By default, hbase would automatically compact periodically. However, In this period, what we flush frequently would cause many hfile genereated, and hbase does not compact until the next period. So in order to prevent the rapid growth of the number of hfile under some conditions, I think we can add a check if it needs to compact after flushing region at server side. Do you think it's a better way?  thanks!   One of the codes in here: {code:java} //FlushRegionCallable.java doCall() try { HRegion.FlushResult res; if (columnFamilies == null) { res = region.flush(true); } else { res = region.flushcache(columnFamilies, false, FlushLifeCycleTracker.DUMMY); } if (res.getResult() == HRegion.FlushResult.Result.CANNOT_FLUSH) { throw new IOException(""Unable to complete flush "" + regionInfo); } {code}" Add 'TM' superscript to the index page title when generating javadoc,13563273,Resolved,Major,Fixed,01/Jan/24 11:16,06/Jan/24 09:19,, [hbase-thirdparty] Upgrade Netty to 4.1.104.Final,13563624,Resolved,Major,Fixed,04/Jan/24 18:45,05/Jan/24 13:38,,"There is a CVE: [https://github.com/netty/netty/security/advisories/GHSA-xpw8-rcwv-8f8p.] It does not affect us, but we can clear it anyway." Update website to add ‘TM’ superscript to HBase as much as possible,13563272,Open,Major,,01/Jan/24 11:15,,,This is a request from the trademarker team. "Add ""Uncompressed StoreFileSize"" column to the table.jsp",13564447,Resolved,Minor,Fixed,12/Jan/24 02:27,17/Jan/24 07:36,,"Currently, HBase Web UI can only see the uncompressed StoreFile size of each Region on the Region Server page, but sometimes we also hope to see this information on the table details page, which can help analyze the data distribution of each table." Upgrade curator to 5.7.1,13570296,Resolved,Minor,Fixed,29/Feb/24 09:57,19/Feb/25 11:39,,"HBase still uses Curator 4.2.0, -because it's the last version to support ZK 3.4.- Now that, with HBASE-28153, HBase uses a recent ZK, we can use the latest Curator. Also, curator 4.2.0 has multiple indirect vulnerabilities as per https://mvnrepository.com/artifact/org.apache.curator/curator-client/4.2.0 Vulnerabilities from dependencies: * CVE-2023-44981 * CVE-2023-2976 * CVE-2022-4065 * CVE-2020-8908 * CVE-2019-0201" Remove direct dependency on Curator,13570312,Patch Available,Minor,,29/Feb/24 11:40,,,"The only place where Curator is used is ZooKeeperScanPolicyObserver.java in hbase-examples. That functionality can be re-implementend without curator, and a problematic dependency can be removed from HBase." Flush/Compaction journal logs are missing from 2.x ,13567520,Open,Minor,,06/Feb/24 06:12,,,"After refactoring of TaskMonitor from branch-1 [  public synchronized MonitoredTask createStatus(String description)|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87] to branch-2/master public MonitoredTask createStatus(String description){           [return createStatus(description, false);|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/TaskMonitor.java#L87]  Flush journal logs are missing. While flush, currently we do no set ignore monitor flag as true here  [MonitoredTask status = TaskMonitor.get().createStatus(""Flushing "" + this);|https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L2459]" Add an option to count different types of Delete Markers in RowCounter,13566073,Resolved,Minor,Fixed,25/Jan/24 05:59,02/Dec/24 09:11,,"Add an option (count-delete-markers) to the [RowCounter|https://github.com/apache/hbase/blob/8a9ad0736621fa1b00b5ae90529ca6065f88c67f/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/RowCounter.java#L240C62-L240C75] tool to count the number of Delete Markers of all types, i.e. (DELETE, DELETE_COLUMN, DELETE_FAMILY,DELETE_FAMILY_VERSION) We already have such a feature within our internal implementation of RowCounter and it's very useful. Implementation Ideas: 1. If the option is passed, initialize the empty job counters for all 4 types of deletes. 2. Within mapper, increase the respective delete counts while processing each row." "New site configuration option ""hfile.block.size""",13572499,Open,Minor,,20/Mar/24 05:54,,2.5.0,"Right now there is no config attached to the HFile block size by which we can override the default. The default is set to 64 KB in HConstants.DEFAULT_BLOCKSIZE . We need a global config property that would go on hbase-site.xm which can control this value. Since the BLOCKSIZE is tracked at the column family level - we will need to respect the CFD value first. Also, configuration settings are also something that can be set in schema, at the column or table level, and will override the relevant values from the site file. Below is the precedence order we can use to get the final blocksize value : {code:java} ColumnFamilyDescriptor.BLOCKSIZE > schema level site configuration overrides > site configuration > HConstants.DEFAULT_BLOCKSIZE{code} PS: There is one related config “hbase.mapreduce.hfileoutputformat.blocksize” however that is specific to map-reduce jobs." Enable infra automation to add label on a Jira when a new PR is posted,13565779,Resolved,Minor,Fixed,23/Jan/24 09:55,01/Feb/24 13:21,,"https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Jiranotificationoptions Currently we make use of the ""link"" feature. This does not send a notification to watchers, so I propose that we add the ""comment"" feature, so that a comment will also be sent, and watchers can find out about the availability of the PR." Timing issue in Incremental Backup or TestIncrementalBackup,13573554,Open,Minor,,27/Mar/24 15:44,,2.6.0,"While working on tests for HBASE-28412, I noticed that `TestIncrementalBackup` always fails on my computer and the computer of a colleague. However, I manage to get this test working 100% when setting breakpoints on following locations (accidentally discovered while trying to debug this issue): * `IncrementalTableBackupClient` L269 (`newTimestamps = ((IncrementalBackupManager) backupManager).getIncrBackupLogFileMap();`) * `IncrementalBackupManager` L96 (`logList = getLogFilesForNewBackup(previousTimestampMins, newTimestamps, conf, savedStartCode);`) * `WALInputFormat` L356 (`RemoteIterator iter = fs.listLocatedStatus(dir);`) This test fails with the following error:   {code:java} java.io.IOException: java.io.FileNotFoundException: File hdfs://localhost:46787/user/dieter/test-data/b615664f-1cde-fc27-1752-33ab359a931c/WALs/localhost,38309,1711553427191/localhost%2C38309%2C1711553427191.localhost%2C38309%2C1711553427191.regiongroup-0.1711553471361 does not exist.    at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:289)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.backupTables(BackupAdminImpl.java:603)     at org.apache.hadoop.hbase.backup.TestIncrementalBackup.TestIncBackupRestore(TestIncrementalBackup.java:169)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.base/java.lang.reflect.Method.invoke(Method.java:566)     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)     at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.runners.ParentRunner.run(ParentRunner.java:413)     at org.junit.runners.Suite.runChild(Suite.java:128)     at org.junit.runners.Suite.runChild(Suite.java:27)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)     at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)     at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.io.FileNotFoundException: File hdfs://localhost:46787/user/dieter/test-data/b615664f-1cde-fc27-1752-33ab359a931c/WALs/localhost,38309,1711553427191/localhost%2C38309%2C1711553427191.localhost%2C38309%2C1711553427191.regiongroup-0.1711553471361 does not exist.     at org.apache.hadoop.hdfs.DistributedFileSystem$DirListingIterator.(DistributedFileSystem.java:1282)     at org.apache.hadoop.hdfs.DistributedFileSystem$DirListingIterator.(DistributedFileSystem.java:1256)     at org.apache.hadoop.hdfs.DistributedFileSystem$25.doCall(DistributedFileSystem.java:1201)     at org.apache.hadoop.hdfs.DistributedFileSystem$25.doCall(DistributedFileSystem.java:1197)     at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)     at org.apache.hadoop.hdfs.DistributedFileSystem.listLocatedStatus(DistributedFileSystem.java:1215)     at org.apache.hadoop.fs.FileSystem.listLocatedStatus(FileSystem.java:2230)     at org.apache.hadoop.hbase.mapreduce.WALInputFormat.getFiles(WALInputFormat.java:356)     at org.apache.hadoop.hbase.mapreduce.WALInputFormat.getSplits(WALInputFormat.java:321)     at org.apache.hadoop.hbase.mapreduce.WALInputFormat.getSplits(WALInputFormat.java:301)     at org.apache.hadoop.mapreduce.JobSubmitter.writeNewSplits(JobSubmitter.java:310)     at org.apache.hadoop.mapreduce.JobSubmitter.writeSplits(JobSubmitter.java:327)     at org.apache.hadoop.mapreduce.JobSubmitter.submitJobInternal(JobSubmitter.java:200)     at org.apache.hadoop.mapreduce.Job$11.run(Job.java:1678)     at org.apache.hadoop.mapreduce.Job$11.run(Job.java:1675)     at java.base/java.security.AccessController.doPrivileged(Native Method)     at java.base/javax.security.auth.Subject.doAs(Subject.java:423)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899)     at org.apache.hadoop.mapreduce.Job.submit(Job.java:1675)     at org.apache.hadoop.mapreduce.Job.waitForCompletion(Job.java:1696)     at org.apache.hadoop.hbase.mapreduce.WALPlayer.run(WALPlayer.java:423)     at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.walToHFiles(IncrementalTableBackupClient.java:406)     at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.convertWALsToHFiles(IncrementalTableBackupClient.java:378)     at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:282)     ... 34 more {code}     I suspect the issue is that the WAL files are not yet fully written to HDFS when the WALPlayer tries to convert them to HFiles. Since I'm not sure about the exact cause yet, I'm also not sure if this is a problem with the test (which uses a dedicated `IncrementalTableBackupClientForTest`) or the actual backup code. I attached 2 logfiles from tests (one where it runs, and one where it fails)." Remove the reflection for ByteBufferPositionedReadable,13572446,Open,Minor,,19/Mar/24 17:30,,,"HBASE-21946 used reflection to access the ByteBufferPositionedReadable API that's only available in Hadoop 3.3. Now that HBase branch-2.6 and above updated hadoop three dependency to 3.3, we can get rid of the reflection." FNFE related to 'master:store' when moving archived hfiles to global archived dir,13571164,Resolved,Minor,Fixed,07/Mar/24 15:35,18/Mar/24 13:57,,"Sometimes we encounter the following log. {code:java} 2024-02-26T18:11:34,934 WARN  [master:store-Store-Compactor] region.MasterRegionFlusherAndCompactor: Failed to move archived hfiles from file:/root/hbase-4.0.0-alpha-1-SNAPSHOT/tmp/hbase/MasterData/archive/data/master/store/1595e783b53d99cd5eef43b6debb2682/state to global dir file:/root/hbase-4.0.0-alpha-1-SNAPSHOT/tmp/hbase/archive/data/master/store/1595e783b53d99cd5eef43b6debb2682/statejava.io.FileNotFoundException: File file:/root/hbase-4.0.0-alpha-1-SNAPSHOT/tmp/hbase/MasterData/archive/data/master/store/1595e783b53d99cd5eef43b6debb2682/state does not exist        at org.apache.hadoop.fs.RawLocalFileSystem.listStatus(RawLocalFileSystem.java:733) ~[hadoop-common-3.3.5.jar:?]        at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:2045) ~[hadoop-common-3.3.5.jar:?]        at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:2089) ~[hadoop-common-3.3.5.jar:?]        at org.apache.hadoop.fs.ChecksumFileSystem.listStatus(ChecksumFileSystem.java:970) ~[hadoop-common-3.3.5.jar:?]        at org.apache.hadoop.hbase.master.region.MasterRegionUtils.moveFilesUnderDir(MasterRegionUtils.java:42) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]        at org.apache.hadoop.hbase.master.region.MasterRegionFlusherAndCompactor.moveHFileToGlobalArchiveDir(MasterRegionFlusherAndCompactor.java:145) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]        at org.apache.hadoop.hbase.master.region.MasterRegionFlusherAndCompactor.compact(MasterRegionFlusherAndCompactor.java:157) ~[hbase-server-4.0.0-alpha-1-SNAPSHOT.jar:4.0.0-alpha-1-SNAPSHOT]        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_231]        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_231]        at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_231] {code} Analysis: Against 'master:store', Archived hfiles would first be placed in \{hbase.rootdir}/MasterData/archive/ after compacting, and then moved to global archived dir. 'master:store' has 3 column families:proc,rs,state, if there is empty in one of column families,such as state, no files in this column families will be archived, and \{hbase.rootdir}/MasterData/archive/data/master/store/1595e783b53d99cd5eef43b6debb2682/state would do not exist. Finally, we will get FileNotFoundException when moving these archived hfiles to global archived dir.   Although，Current code can avoid this effecting by catching Exception, However it is maybe better to check the dir exists before moving." Shared job jars for full backups,13572255,Open,Minor,,18/Mar/24 15:05,,2.6.0,"Our YARN clusters are configured with 10GB of temporary local storage. When investigating an unhealthy YARN nodemanager, we found it became unhealthy because it's ""local-dirs usable space"" had dropped below 90%. Investigation showed that this was mainly due to over a 100 different entries in the usercache, all containing the exact same libjars: {code:java} yarn@yarn-nodemanager-0:/tmp/yarn/nm-local-dir$ du -s ./usercache/lily/filecache/* 41272 ./usercache/lily/filecache/10 41272 ./usercache/lily/filecache/100 41272 ./usercache/lily/filecache/101 41272 ./usercache/lily/filecache/102 41272 ./usercache/lily/filecache/103 41272 ./usercache/lily/filecache/104 ...{code} {code:java} yarn@yarn-nodemanager-0:/tmp/yarn/nm-local-dir$ du -s ./usercache/lily/filecache/99/libjars/* 576 ./usercache/lily/filecache/99/libjars/commons-lang3-3.12.0.jar 4496 ./usercache/lily/filecache/99/libjars/hadoop-common-3.3.6-2-lily.jar 1800 ./usercache/lily/filecache/99/libjars/hadoop-mapreduce-client-core-3.3.6-2-lily.jar 100 ./usercache/lily/filecache/99/libjars/hbase-asyncfs-2.6.0-prc-1-lily.jar 2076 ./usercache/lily/filecache/99/libjars/hbase-client-2.6.0-prc-1-lily.jar 876 ./usercache/lily/filecache/99/libjars/hbase-common-2.6.0-prc-1-lily.jar 76 ./usercache/lily/filecache/99/libjars/hbase-hadoop-compat-2.6.0-prc-1-lily.jar 164 ./usercache/lily/filecache/99/libjars/hbase-hadoop2-compat-2.6.0-prc-1-lily.jar 124 ./usercache/lily/filecache/99/libjars/hbase-http-2.6.0-prc-1-lily.jar 436 ./usercache/lily/filecache/99/libjars/hbase-mapreduce-2.6.0-prc-1-lily.jar 32 ./usercache/lily/filecache/99/libjars/hbase-metrics-2.6.0-prc-1-lily.jar 24 ./usercache/lily/filecache/99/libjars/hbase-metrics-api-2.6.0-prc-1-lily.jar 208 ./usercache/lily/filecache/99/libjars/hbase-procedure-2.6.0-prc-1-lily.jar 3208 ./usercache/lily/filecache/99/libjars/hbase-protocol-2.6.0-prc-1-lily.jar 7356 ./usercache/lily/filecache/99/libjars/hbase-protocol-shaded-2.6.0-prc-1-lily.jar 52 ./usercache/lily/filecache/99/libjars/hbase-replication-2.6.0-prc-1-lily.jar 5932 ./usercache/lily/filecache/99/libjars/hbase-server-2.6.0-prc-1-lily.jar 304 ./usercache/lily/filecache/99/libjars/hbase-shaded-gson-4.1.5.jar 4060 ./usercache/lily/filecache/99/libjars/hbase-shaded-miscellaneous-4.1.5.jar 4864 ./usercache/lily/filecache/99/libjars/hbase-shaded-netty-4.1.5.jar 1832 ./usercache/lily/filecache/99/libjars/hbase-shaded-protobuf-4.1.5.jar 20 ./usercache/lily/filecache/99/libjars/hbase-unsafe-4.1.5.jar 108 ./usercache/lily/filecache/99/libjars/hbase-zookeeper-2.6.0-prc-1-lily.jar 120 ./usercache/lily/filecache/99/libjars/metrics-core-3.1.5.jar 128 ./usercache/lily/filecache/99/libjars/opentelemetry-api-1.15.0.jar 48 ./usercache/lily/filecache/99/libjars/opentelemetry-context-1.15.0.jar 32 ./usercache/lily/filecache/99/libjars/opentelemetry-semconv-1.15.0-alpha.jar 524 ./usercache/lily/filecache/99/libjars/protobuf-java-2.5.0.jar 1292 ./usercache/lily/filecache/99/libjars/zookeeper-3.8.3.jar {code} Investigating the YARN logs showed that for every HBase table included in a full backup, a separate YARN application is started, each uploading these job jars. We encountered this on an HBase installation with limited tables, where we were running backup&restore related tests (so this was regular use). But I can imagine this could be annoying for HBase installations with hundreds to thousands of tables. I wonder if it's possible to use shared job jars instead of the current approach? (Strangely enough, the mechanisms to clean up this cache weren't triggering as expected, but that's probably something that requires its own investigation.)" Update downloads.xml for 2.5.8,13571806,Resolved,Minor,Fixed,13/Mar/24 21:33,13/Mar/24 21:33,, SplitWalProcedure will attempt SplitWalRemoteProcedure on the same target RegionServer indefinitely,13570868,Open,Minor,,05/Mar/24 17:39,,2.5.5,"Similar to HBASE-28050. If HMaster selects a RegionServer for SplitWalRemoteProcedure, it will retry this server as long as the server is alive. I believe this is because even though {{RSProcedureDispatcher.ExecuteProceduresRemoteCall.run}} calls {{{}remoteCallFailed{}}}, there is no logic after this to select a new target server. For {{TransitRegionStateProcedure}} there is logic to select a new server for opening a region, using {{{}forceNewPlan{}}}. But SplitWalRemoteProcedure only has logic to try another server if we receive a {{DoNotRetryIOException}} in SplitWALRemoteProcedure#complete: [https://github.com/apache/hbase/blob/780ff56b3f23e7041ef1b705b7d3d0a53fdd05ae/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SplitWALRemoteProcedure.java#L104-L110] If we receive any other IOException, we will just retry the target server forever. Just like in HBASE-28050, if there is a SaslException, this will never lead to retrying a SplitWalRemoteProcedure on a new server, which can lead to ServerCrashProcedure never finishing until the target server for SplitWalRemoteProcedure is restarted. The following log is seen repeatedly, always sending to the same host. {code:java} 2024-01-31 15:59:43,616 WARN [RSProcedureDispatcher-pool-72846] procedure.SplitWALRemoteProcedure - Failed split of hdfs:///hbase/WALs/,1704984571464-splitting/1704984571464.1706710908543, retry... java.io.IOException: Call to address= failed on local exception: java.io.IOException: Can not send request because relogin is in progress. at sun.reflect.GeneratedConstructorAccessor363.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:239) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:391) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:425) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:420) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.lambda$sendRequest$4(NettyRpcConnection.java:365) at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174) at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:403) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:750) Caused by: java.io.IOException: Can not send request because relogin is in progress. at org.apache.hadoop.hbase.ipc.NettyRpcConnection.sendRequest0(NettyRpcConnection.java:321) at org.apache.hadoop.hbase.ipc.NettyRpcConnection.lambda$sendRequest$4(NettyRpcConnection.java:363) ... 8 more {code}" Confusing logging during backup restore,13570197,Resolved,Minor,Fixed,28/Feb/24 16:42,01/Mar/24 12:29,2.6.0,"Encountered this while experimenting with the backup/restore functionality. My setup was as follows: * Took several backups (Full1, inc2, inc3) * Changed an entry in the ""lily_tenant_acme:LILY_SETTINGS"" table * Attempt a restore (to test if my changed entry is reverted): {code:java} $ hbase restore -conf backup-conf.xml s3a://backuprestore-experiments/hbase backup_1709123740345 -t ""lily_tenant_acme:LILY_SETTINGS"" -m ""lily_tenant_acme:LILY_SETTINGS-restored1"" -o 24/02/28 16:15:41 WARN org.apache.hadoop.hbase.mapreduce.TableMapReduceUtil: The addDependencyJars(Configuration, Class...) method has been deprecated since it is easy to use incorrectly. Most users should rely on addDependencyJars(Job) instead. See HBASE-8386 for more details. 24/02/28 16:15:58 WARN org.apache.hadoop.hbase.tool.LoadIncrementalHFiles: Skipping non-directory hdfs://hdfsns/user/lily/hbase-staging/bulk_output-lily_tenant_acme-LILY_SETTINGS-restored1-1709136941410/_SUCCESS 24/02/28 16:15:59 WARN org.apache.hadoop.hbase.backup.impl.RestoreTablesClient: Nothing has changed, so there is no need to restore 'lily_tenant_acme:LILY_SETTINGS' {code} Based on the final logging line, I presumed my restore operation had failed. After some investigation however, I found that this was not the case: my change was reverted as expected. Some code investigation learned me this log message is shown because I was restoring backup `inc3`, and there were no changes between `full1` and `inc3`. I suggest rephrasing this log message, and changing it to a INFO level.  " "Use ""set -x"" when running release script in debug mode",13569935,Resolved,Minor,Fixed,27/Feb/24 05:05,29/Feb/24 09:55,,"Phoenix release scripts are forked from HBase. I found using the bash ""set -x"" command very useful when diagnosing problems. It is implemented as part of PHOENIX-7236, and could be very easily ported back to HBase." "Backport ""HBASE-27811 Enable cache control for logs endpoint and set max age as 0"" to branch-2",13568386,Resolved,Minor,Fixed,14/Feb/24 09:20,18/Feb/24 19:46,,"Not setting the proper header values may cause browsers to store pages within their respective caches. On public, shared, or any other non-private computers, a malicious person may search through the browser cache to locate sensitive information cached during another user's session. /logs endpoint contains sensitive information that an attacker can exploit. Any page with sensitive information needs to have the following headers in response: Cache-Control: no-cache, no-store, max-age=0 Pragma: no-cache Expires: -1" Suppress the noisy logging on HBaseAdmin#postOperationResult,13568677,Open,Minor,,16/Feb/24 06:15,,,"While testing 2.6.0 found that for every admin operation there is INFO log of operation status which is noisy. Would be better to suppress by making it debug. This information is helpful during the operation failure to debug further but feel it's unnecessary to print in successful case. {noformat} hbase:002:0> create 't','f' 2024-02-16 06:02:38,887 INFO  [main] client.HBaseAdmin: Operation: CREATE, Table Name: default:t, procId: 65 completed Created table t {noformat} {noformat} hbase:006:0> flush 't' 2024-02-16 06:03:16,294 INFO  [main] client.HBaseAdmin: Operation: FLUSH, Table Name: default:t, procId: 68 completed Took 0.3733 seconds {noformat}" RegionServer Canary can should use Scan just like Region Canary with option to enable Raw Scan,13568112,Resolved,Minor,Fixed,10/Feb/24 22:11,13/Feb/24 01:26,,"While working on HBASE-28204 to improve Region Canary, It came to notice that RegionServer canary uses the same code as Region Canary to check if a region is accessible. Plus RegionSever Canary doesn't have Raw Scan enabled.    This JIRA aims to enable Raw Scan option for RegionServer Canary and use Scan only just like Region Canary." MoveWithAck#isSuccessfulScan for Region movement should use Region End Key for limiting scan to one region only.,13568115,Resolved,Minor,Fixed,10/Feb/24 23:26,13/Feb/24 01:19,,"Based on recent learnings and improvements in HBase Canary in HBASE-28204 and HBASE-28356, I noticed that MoveWithAck.java class also uses similar code to check that Region is online after region move.   {code:java}   private void isSuccessfulScan(RegionInfo region) throws IOException {     Scan scan = new Scan().withStartRow(region.getStartKey()).setRaw(true).setOneRowLimit()       .setMaxResultSize(1L).setCaching(1).setFilter(new FirstKeyOnlyFilter()).setCacheBlocks(false); {code} If the region, that was moved, is empty then MoveWithAck#isSuccessfulScan() will end up scanning next region key space, which is not the intent. If multiple regions in sequence are empty, then this could create too many unnecessary scans.  By setting withStopRow(endKeyOfRegion, false) for the scan object, this scan can be bound to only single region." Fix casting bug in NettyRpcServer introduced in HBASE-28317,13566573,Resolved,Minor,Fixed,29/Jan/24 19:01,30/Jan/24 19:38,,"I introduced a bug in HBASE-28317 that makes it useless. I tried to up-cast an array of {{java.security.cert.Certificate}} to an array of {{java.security.cert.X509Certificate}}, which doesn't work. I'll fix this in this ticket. This bug causes a lot of log spam and makes {{RpcCallContext.getClientCertificateChain()}} always return empty, but does not otherwise break the HBase server. I'm also immediately regretting my use of WARN logs when a certificate isn't present, because it turns out this happens on connections from localhost, so there's a lot of WARNs with stacktraces in the logs." RpcCallContext should expose client's TLS certificate,13565113,Resolved,Minor,Fixed,17/Jan/24 16:02,29/Jan/24 13:45,,"At my employer we plan on using a coprocessor to log information about some requests to HBase. For this to be useful to us, we need to know who each request is coming from. We use HBase's TLS support with mutual authentication to authenticate clients. I'd like a way to expose the client certificate used on a request to coprocessors. For setups using Kerberos authentication, RpcCall exposes the Kerberos principal shortname via {{getRequestUser()}}, so this would be the TLS equivalent to that." Type conversion is no need in method CompactionChecker.chore(),13566152,Resolved,Minor,Fixed,25/Jan/24 14:38,26/Jan/24 10:45,,"In method CompactionChecker.chore(), we iterate the map named onlineRegions ，which the type of value is HRegion, So we do not need to type conversion from Region to HRegion.   {code:java} private final Map onlineRegions = new ConcurrentHashMap<>(); {code}" IntegrationTestImportTsv fails with UnsupportedOperationException,13564188,Resolved,Minor,Fixed,10/Jan/24 11:54,11/Jan/24 20:35,,"IntegrationTestImportTsv fails with UnsupportedOperationException {code:java} [INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 337.526 s <<< FAILURE! - in org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [ERROR] org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.testGenerateAndLoad Time elapsed: 279.783 s <<< ERROR! java.lang.UnsupportedOperationException: Unable to find suitable constructor for class org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv$2 at org.apache.hadoop.hbase.util.ReflectionUtils.findConstructor(ReflectionUtils.java:133) at org.apache.hadoop.hbase.util.ReflectionUtils.newInstance(ReflectionUtils.java:98) at org.apache.hadoop.hbase.client.RawAsyncTableImpl.getScanner(RawAsyncTableImpl.java:628) at org.apache.hadoop.hbase.client.RawAsyncTableImpl.getScanner(RawAsyncTableImpl.java:90) at org.apache.hadoop.hbase.client.TableOverAsyncTable.getScanner(TableOverAsyncTable.java:198) at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.doLoadIncrementalHFiles(IntegrationTestImportTsv.java:156) at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.generateAndLoad(IntegrationTestImportTsv.java:206) at org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv.testGenerateAndLoad(IntegrationTestImportTsv.java:187) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:316) at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:240) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:214) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:155) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162) at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] IntegrationTestImportTsv.testGenerateAndLoad:187->generateAndLoad:206->doLoadIncrementalHFiles:156 » UnsupportedOperation Unable to find suitable constructor for class org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv$2 {code} FYi: [~zhangduo]" Set proper error in response for all usages of HttpServer.isInstrumentationAccessAllowed(),13564181,Open,Minor,,10/Jan/24 11:00,,,"During review https://github.com/apache/hbase/pull/5215, it was found we simply return 200 even if instrumentation is not allowed. While at some places we set proper error. This JIRA is to fix usages of the method and set proper response code. Review comment: https://github.com/apache/hbase/pull/5215/files#r1318296417 CC: [~ndimiduk]" Refactor GarbageCollectorMXBean instantiation in process*.jsp,13564182,Open,Minor,,10/Jan/24 11:05,,,"During review of https://github.com/apache/hbase/pull/5215/ we saw that beans are instantiated based on assumptions around JVM, it is a good idea to refactor code so that we don't get errors when JVM assumptions change in future. Review comment: https://github.com/apache/hbase/pull/5215/files#r1318304462 CC: [~ndimiduk]" Fix Typo in Java Method Comment,13573789,Resolved,Trivial,Fixed,29/Mar/24 03:24,18/Apr/24 10:48,4.0.0-alpha-1,"https://github.com/apache/hbase/blob/9adca10e9c106df5119cc067fd610fb19cd1d5ec/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L795   The java method comment contains a typo.  The comment incorrectly states ""Region name to assign"" instead of ""Region name to unassign"".  " The .flattened-pom.xml for some modules are not installed,13505205,Resolved,Blocker,Fixed,22/Nov/22 03:42,23/Nov/22 13:06,,"Found this when trying to make 2.5.2 release, at least the pom for the root pom and hbase-build-configuration still contain ${revision} and profiles." hlog loss result in data loss when regionserver down network card,13491717,Open,Blocker,,26/Oct/22 08:51,,2.2.7,"When tested hbase replication, I found that the data in the memory was lost. Through the source code of hbase, I found that after hbase split the meta table, it will delete the entire wal  directory , but hlog is still in the same directory, and which save the data in the memstore. Eventually cause data loss. The specific process is as follows: #  put a few data into hbase table. #  turn down the network card of all regionserver nodes. #  turn up the network card of all regionserver nodes，regionserver will be killed. #  restart the hbase cluster, scan table and find no data in the table. In hmaster log will print:       master.MasterWalManager: Log dir for server xxx does not exist   The splitLogDistributed function in SplitLogManager.java caused this issue. hmaster will first call splitLogDistributed function to publish the split task of the meta table. After the meta split task is completed, the directory will be deleted. Then hmaster want to publish another normal split task to restore the data again, but no wal directory was found. {code:java}     waitForSplittingCompletion(batch, status);       ...     for (Path logDir : logDirs) {       status.setStatus(""Cleaning up log directory..."");       final FileSystem fs = logDir.getFileSystem(conf);       try {         if (fs.exists(logDir) && !fs.delete(logDir, false)) {           LOG.warn(""Unable to delete log src dir. Ignoring. "" + logDir);         }       } catch (IOException ioe) {         FileStatus[] files = fs.listStatus(logDir);         if (files != null && files.length > 0) {           LOG.warn(""Returning success without actually splitting and ""               + ""deleting all the log files in path "" + logDir + "": ""               + Arrays.toString(files), ioe);         } else {           LOG.warn(""Unable to delete log src dir. Ignoring. "" + logDir, ioe);         }       }     }{code}    My English is poor, so if there is anything unclear, can leave me a message." Possible region gets stuck in CLOSING state,13505864,In Progress,Critical,,25/Nov/22 05:58,,2.3.4,"There is a possible chance of region gets stuck in closing state could be because of race between the flush and close or some where the readlock acquired on the region is not getting released. {noformat} ""MemStoreFlusher.1"" #236 prio=5 os_prio=0 tid=0x00005639266a4000 nid=0x296e waiting on condition [0x00007fdc48a63000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00007fdf42dde850> (a java.util.concurrent.locks.ReentrantReadWriteLock$FairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:967) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1283) at java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:727) at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2397) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:610) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:579) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:67) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:359) ""MemStoreFlusher.0"" #234 prio=5 os_prio=0 tid=0x00005639266a2800 nid=0x296d waiting on condition [0x00007fdc48b64000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00007fdf42dde850> (a java.util.concurrent.locks.ReentrantReadWriteLock$FairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:967) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1283) at java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:727) at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2397) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:610) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:579) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:67) at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:359) {noformat} {noformat} ""RS_CLOSE_REGION-regionserver/sl73tskrnsqln00107:16020-0"" #6337 daemon prio=5 os_prio=0 tid=0x00007fdc05448800 nid=0x15d1 waiting on condition [0x00007fdc1befd000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00007fdf42dde850> (a java.util.concurrent.locks.ReentrantReadWriteLock$FairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199) at java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:943) at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1662) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1591) - locked <0x00007fdf42ddf358> (a java.lang.Object) at org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:114) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:750) {noformat} From one of the region server logs flushed has started and replay edits of flush added then close requested then it got stuck in the transition and no further processing of the requests on the region. {noformat} 2022-11-23 05:51:00,503 INFO [MemStoreFlusher.1] regionserver.DefaultStoreFlusher: Flushed memstore data size=232.14 MB at sequenceid=29163855 (bloomFilter=true), to=hdfs://OCEDEV/apps/hbase/data/data/default/hbase_perf_wl2_1000m/8f342bca97c115f8bce460a998e4afbc/.tmp/cf1/c20f27a7407643b18558331d95f7a67f 2022-11-23 05:51:00,530 INFO [MemStoreFlusher.1] regionserver.HStore: Added hdfs://OCEDEV/apps/hbase/data/data/default/hbase_perf_wl2_1000m/8f342bca97c115f8bce460a998e4afbc/cf1/c20f27a7407643b18558331d95f7a67f, entries=231413, sequenceid=29163855, filesize=233.7 M 2022-11-23 05:51:00,536 INFO [MemStoreFlusher.1] regionserver.HRegion: Finished flush of dataSize ~232.14 MB/243420836, heapSize ~256.00 MB/268439136, currentSize=719.06 KB/736320 for 8f342bca97c115f8bce460a998e4afbc in 2146ms, sequenceid=29163855, compaction requested=true 2022-11-23 05:51:00,541 INFO [MemStoreFlusher.1] regionserver.HRegion: Flushing d92c7546be62225859dd641aa88992ea 1/1 column families, dataSize=232.62 MB heapSize=256.53 MB 2022-11-23 05:51:00,645 INFO [MemStoreFlusher.0] regionserver.DefaultStoreFlusher: Flushed memstore data size=232.15 MB at sequenceid=29037517 (bloomFilter=true), to=hdfs://OCEDEV/apps/hbase/data/data/default/hbase_perf_wl2_1000m/7beadd786ffc23edc074238c873f800b/.tmp/cf1/eb542141078e4f879128498d01517e98 2022-11-23 05:51:00,705 INFO [MemStoreFlusher.0] regionserver.HStore: Added hdfs://OCEDEV/apps/hbase/data/data/default/hbase_perf_wl2_1000m/7beadd786ffc23edc074238c873f800b/cf1/eb542141078e4f879128498d01517e98, entries=231402, sequenceid=29037517, filesize=233.7 M 2022-11-23 05:51:00,706 INFO [MemStoreFlusher.0] regionserver.HRegion: Finished flush of dataSize ~232.15 MB/243424206, heapSize ~256.01 MB/268442768, currentSize=935.82 KB/958277 for 7beadd786ffc23edc074238c873f800b in 2324ms, sequenceid=29037517, compaction requested=true 2022-11-23 05:51:00,708 INFO [MemStoreFlusher.0] regionserver.HRegion: Flushing 6c6694dce02a13f8109ecc3dd70009d5 1/1 column families, dataSize=232.68 MB heapSize=256.60 MB 2022-11-23 05:51:00,771 INFO [RS_CLOSE_REGION-regionserver/sl73tskrnsqln00107:16020-0] handler.UnassignRegionHandler: Close 8f342bca97c115f8bce460a998e4afbc {noformat} {noformat} 2022-11-23 07:37:06,887 WARN [RpcServer.default.FPBQ.Fifo.handler=28,queue=8,port=16020] regionserver.HRegion: Region is too busy to allow lock acquisition. org.apache.hadoop.hbase.RegionTooBusyException: Failed to obtain lock; regionName=hbase_perf_wl2_1000m,user8104,1668039117539.8f342bca97c115f8bce460a998e4afbc., server=sl73tskrnsqln00107.visa.com,16020,1669131710569 at org.apache.hadoop.hbase.regionserver.HRegion.lock(HRegion.java:8726) at org.apache.hadoop.hbase.regionserver.HRegion.lock(HRegion.java:8705) at org.apache.hadoop.hbase.regionserver.HRegion.startRegionOperation(HRegion.java:8610) at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3161) at org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2985) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45517) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) {noformat}" Optimize the compaction triggering logic if table has set TTL,13514021,Open,Critical,,15/Dec/22 09:42,,2.4.15,"Although table has a TTL set in the cluster，some regions do not perform periodic major compactions，and the expired TTL data is still stored in these large files. Not trigger the reason is that the periodic check of the thread according to number of files in the region  If > hbase.hstore.compaction.min then major compaction is not triggered, Instead, minor compaction is triggered first. But minor compaction which excludes large files (by the hbase.hstore.compaction.max.size), when the larger files reach a certain number, the expired data under the larger files cannot be deleted normally.      " In memory compaction 'COMPACT' may cause data corruption when adding cells large than maxAlloc(default 256k) size,13495312,Resolved,Critical,Fixed,04/Nov/22 07:59,17/Nov/22 15:26,,"When init 'CellChunkImmutableSegment' for 'COMPACT' action, we not force copy to current MSLab.  When cell size bigger than maxAlloc, cell will stay in previous chunk which will recycle after segment replace, and we may read wrong data when these chunk reused by others. !image-2022-11-04-15-46-21-645.png!   Timeline: # add a cell 'A' bigger than 256K # cell 'A' will copy to a chunk 'A' when first compact # cell 'A' will retain in chunk 'A' when second compact # chunk 'A' recycled after segment swap and close" Use different jdks when running hadoopcheck in personality scripts,13500317,Resolved,Critical,Fixed,09/Nov/22 03:32,10/Nov/22 15:22,, RegionServer JVM crash when scan,13493451,Open,Critical,,28/Oct/22 10:23,,2.3.5,"jdk8 + hadoop3 + bucketcache + g1 + hbase2.3.5 In our cluster, we found region servers may be crashed in several cases hs_err_pid117788.log # # A fatal error has been detected by the Java Runtime Environment: # #  SIGSEGV (0xb) at pc=0x00007fdc733a9a4e, pid=117788, tid=0x00007fdc0a34b700 # # JRE version: Java(TM) SE Runtime Environment (8.0_171-b11) (build 1.8.0_171-b11) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.171-b11 mixed mode linux-amd64 compressed oops) # Problematic frame: # j  org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.isConnectionOpen()Z+4 # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try ""ulimit -c unlimited"" before starting Java again # # If you would like to submit a bug report, please visit: #   [http://bugreport.java.com/bugreport/crash.jsp] #   ---------------  T H R E A D  ---------------   Current thread (0x00007fd48004f000):  JavaThread ""RpcServer.default.FPBQ.Fifo.handler=17,queue=2,port=16020"" daemon [_thread_in_Java, id=118639, stack(0x00007fdc0a24b000,0x00007fdc0a34c000)]   regionserver日志 2022-10-28 03:33:03,611 WARN  [RpcServer.default.FPBQ.Fifo.handler=25,queue=0,port=16020] ipc.RpcServer: (responseTooSlow): {""call"":""Scan(org.apache.hadoop.h base.shaded.protobuf.generated.ClientProtos$ScanRequest)"",""starttimems"":""1666899153611"",""responsesize"":""19"",""method"":""Scan"",""param"":""scanner_id: 119667009731 85298703 number_of_rows: 1000 close_scanner: false next_call_seq: 0 client_handles_partials: true client_handles_heartbeats: t "",""processingtimems "":30000,""client"":""10.64.143.22:48550"",""queuetimems"":0,""class"":""HRegionServer"",""scandetails"":""table: action_user_track_v2 region: action_user_track_v2,\\xE8 x00\\x00\\x00-\\xAA\\xF9\\xFB\\x00\\x00\\x01 {\\xCF\\xA6\\xDE\\x09,1645585735023.efb249fd8f4c26d4911d50f14fc30ce8.""}   2022-10-28 03:33:03,611 WARN  [RpcServer.default.FPBQ.Fifo.handler=17,queue=2,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 58a6823d3958 49099bb226e18acb79b2_SeqId_6__1032126997. This is harmless and can happen in rare cases (see HBASE-8547) 2022-10-28 03:33:03,611 WARN  [RpcServer.default.FPBQ.Fifo.handler=17,queue=2,port=16020] hfile.BlockCacheUtil: Caching an already cached block: eb1c30882099 45f6b5006db45d5fe286_SeqId_4__1032126997. This is harmless and can happen in rare cases (see HBASE-8547) 2022-10-28 03:33:03,612 WARN  [RpcServer.default.FPBQ.Fifo.handler=17,queue=2,port=16020] hfile.BlockCacheUtil: Caching an already cached block: eb1c30882099 45f6b5006db45d5fe286_SeqId_4__1032149468. This is harmless and can happen in rare cases (see HBASE-8547)" scan ipc.RpcServer: Unexpected throwable object ,13494483,Open,Critical,,03/Nov/22 02:11,,2.3.5,"regionserver日志： 2022-11-03 02:05:37,113 WARN  [RpcServer.default.FPBQ.Fifo.handler=43,queue=3,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 683273027345 48448d8384bea82dd541_SeqId_6__346562037. This is harmless and can happen in rare cases (see HBASE-8547) 2022-11-03 02:05:37,113 WARN  [RpcServer.default.FPBQ.Fifo.handler=22,queue=2,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 297c0c67dd78 40b5829c4dae5342664b_SeqId_4__346562037. This is harmless and can happen in rare cases (see HBASE-8547) 2022-11-03 02:05:37,114 WARN  [RpcServer.default.FPBQ.Fifo.handler=43,queue=3,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 683273027345 48448d8384bea82dd541_SeqId_6__346590844. This is harmless and can happen in rare cases (see HBASE-8547) 2022-11-03 02:05:37,114 WARN  [RpcServer.default.FPBQ.Fifo.handler=22,queue=2,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 683273027345 48448d8384bea82dd541_SeqId_6__346590844. This is harmless and can happen in rare cases (see HBASE-8547) 2022-11-03 02:05:37,114 WARN  [RpcServer.default.FPBQ.Fifo.handler=43,queue=3,port=16020] hfile.BlockCacheUtil: Cached block contents differ by nextBlockOnDi skSize, the new block has nextBlockOnDiskSize set. Caching new block. 2022-11-03 02:05:37,115 ERROR [RpcServer.default.FPBQ.Fifo.handler=22,queue=2,port=16020] ipc.RpcServer: Unexpected throwable object  java.lang.IllegalArgumentException: offset (0) + length (2) exceed the capacity of the array: -1207959040         at org.apache.hadoop.hbase.util.Bytes.explainWrongLengthOrOffset(Bytes.java:832)         at org.apache.hadoop.hbase.util.Bytes.toShort(Bytes.java:1125)         at org.apache.hadoop.hbase.util.Bytes.toShort(Bytes.java:1111)         at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decode(DiffKeyDeltaEncoder.java:439)         at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decodeNext(DiffKeyDeltaEncoder.java:527)         at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.next(BufferedDataBlockEncoder.java:806)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$EncodedScanner.next(HFileReaderImpl.java:1512)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.next(StoreFileScanner.java:196)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:124)         at org.apache.hadoop.hbase.regionserver.StoreScanner.trySkipToNextColumn(StoreScanner.java:917)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(StoreScanner.java:826)         at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:738)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:157)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6794)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6958)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6728)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3323)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3574)         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:44858)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)" RegionServer JVM crash when scan,13493686,Resolved,Critical,Duplicate,31/Oct/22 08:25,01/Nov/22 06:34,2.3.5,"hs_err_pid790137.log # # A fatal error has been detected by the Java Runtime Environment: # #  SIGSEGV (0xb) at pc=0x00007f0389b452a6, pid=790137, tid=139652643038976 # # JRE version: Java(TM) SE Runtime Environment (8.0_20-b26) (build 1.8.0_20-b26) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.20-b23 mixed mode linux-amd64 compressed oops) # Problematic frame: # V  [libjvm.so+0x5832a6]  G1ParScanThreadState::copy_to_survivor_space(oopDesc*)+0x226 # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try ""ulimit -c unlimited"" before starting Java again # # If you would like to submit a bug report, please visit: #   http://bugreport.sun.com/bugreport/crash.jsp #   ---------------  T H R E A D  ---------------   Current thread (0x00007f038405d000):  GCTaskThread [stack: 0x00007f036a1e2000,0x00007f036a2e3000] [id=790310]   siginfo: si_signo: 11 (SIGSEGV), si_code: 1 (SEGV_MAPERR), si_addr: 0x00000000000000e0   Registers: RAX=0x0000000000000000, RBX=0x00007f038a4ee240, RCX=0x0000000000000003, RDX=0x0000000000000001 RSP=0x00007f036a2e1310, RBP=0x00007f036a2e1370, RSI=0x00000004f00ebbe8, RDI=0x00000000080007a8 R8 =0x000000009e01d77d, R9 =0x00007f036a2e1590, R10=0x00000004e7c08208, R11=0x00007f0384994900 R12=0x00000004f00ebbe8, R13=0x00007f038497ca80, R14=0x00007f036a2e1590, R15=0x00007f036a2e1590 RIP=0x00007f0389b452a6, EFLAGS=0x0000000000010246, CSGSFS=0x0000000000000033, ERR=0x0000000000000004   TRAPNO=0x000000000000000e" Document auto cert file reloading HBASE-27347,13514079,Resolved,Major,Fixed,15/Dec/22 16:42,16/Dec/22 16:49,,Documentation hasn't been updated in HBASE-27347 Add block bytes scanned metrics,13513416,Resolved,Major,Fixed,13/Dec/22 14:18,05/Dec/23 21:10,,"Initially in HBASE-14978, but more recently improved in HBASE-27558 and HBASE-27570, we now track the amount of block bytes scanned by read requests. Random read use-cases (which might read 1 small row from a 64kb block) and heavily filtered scans (which might scan many blocks in order to return a needle in a haystack row) can unknowingly cause RegionServers to do more work than a user expects. Now that we have block IO accounting, we should expose this to the user in the form of jmx metrics and ScanMetrics.  " Client metrics for success/failure counts.,13514778,Resolved,Major,Fixed,19/Dec/22 22:19,21/Dec/22 14:17,2.5.2,"Client metrics to see total number of successful or failure counts of related RPC calls like get, mutate, scan etc..." AsyncRequestFutureImpl unnecessarily clears meta cache for full server,13513388,Resolved,Major,Fixed,13/Dec/22 14:02,10/Jan/23 13:09,,"In AsyncRequestFutureImpl.receiveGlobalFailure, the meta cache is cleared twice. First the entire cache is cleared for the serverName, then each individual region's cache is further cleared. See [here.|https://github.com/apache/hbase/blob/branch-2/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java#L766-L780] This behavior was introduced in HBASE-19900, which was a Jira more related to return value corruption rather than meta cache. I believe the change was an accident in the refactoring. Take a look at the commit [here.|https://github.com/apache/hbase/commit/e2636c81f7700a34368d73079375dbce6e180547#diff-7c58ffd83c150488599591ed5a3a068599646ebdbbbfdcd2233386e5472cca35L709] In the commit, the cleanServerCache call should have been wrapped in tableName == null. Then the updateCachedLocations call should have been wrapped in tableName != null. So we should only go down one path or another based on the existence of a tableName. Full server cache clears are extremely expensive in a high concurrency client. This is especially true in AsyncProcess, where a single request might hit many servers. We should reinstate the tableName checks so that we only do one or the other." AsyncProcess should not clear meta cache for RejectedExecutionException,13502961,Resolved,Major,Fixed,16/Nov/22 21:18,09/Dec/22 14:00,,"Batch requests using AsyncProcess get submitted to a thread pool. If the pool is too small or backing regionservers are overloaded, the pool may reject requests. Currently this causes a cache clear, which only exacerbates issues in most cases. If there's a real reason to clear cache, the individual failing tasks that actually get accepted into the pool should be enough to appropriately clear the cache. So let's special case REE in AsyncRequestFutureImpl to not clear cache." Locating regions for all actions of batch requests can exceed operation timeout,13502947,Resolved,Major,Fixed,16/Nov/22 19:34,06/Dec/22 13:09,,"This affects both AsyncTable and branch-2's Table. It's a follow-on from HBASE-27487. In both cases, for a batch request, the first thing that must be done is resolve region locations for all actions in a batch. This is done in sequence for all actions, and the timeout is not checked after each action. If meta is slow or a sufficiently large batch is sent, the time to sequentially resolve all actions may exceed the operation timeout. Currently, the code will eventually check the operation timeout after all locations have been resolved and before submitting the MultiRequests. We should check the timeout before each call to locate a region, and abort early if it's exceeded." Slow meta can create pathological feedback loop with multigets,13502761,Resolved,Major,Fixed,15/Nov/22 22:08,01/Dec/22 13:33,2.4.15,"This only affects the Table implementation in 2.x releases. h4. Call stack When Table.batch is called, an AsyncProcessTask is created with SubmittedRows.ALL, which is sent to AsyncProcess.submit(). For the ALL case, this goes to submitAll which creates an AsyncRequestFutureImpl and then calls groupAndSendMultiAction on that. When a AsyncRequestFutureImpl is created, a RetryingTimeTracker is created and started as the last step of the constructor. In groupAndSendMultiAction, the first thing that has to be done is resolve the HRegionLocation for every action in the batch. This is currently done sequentially, with no timeout on the overall batch completion. Once all actions have been resolved, they are passed into sendMultiAction which creates a SingleServerRequestRunnable. Once that runnable is executed, the first thing it does is create a new MultiServerCallable using the same RetryingTimeTracker that was originally created way back. That callable extends CancellableRegionServerCallable, and the call method first checks the tracker.getRemainingTime() before actually doing any work. If exceeded, it throws an exception. h4. Problem If meta is overloaded, or you send any sufficiently large batch of actions, the resolving of HRegionLocations (which happens sequentially) may take a while. Depending on the operation timeout configured for the client, that duration may already exceed that timeout before even reaching the CancellableRegionServerCallable.call(). When the timeout is exceeded there, a DoNotRetryIOException is thrown. This is considered a cache clearing exception, so any locations that may have been slowly resolved earlier up the chain will be thrown away. If done with enough concurrency, this can create a feedback loop that is impossible to recover from. h4. Potential Solutions # Change the thrown exception type from DoNotRetryIOException to something more appropriate for the actual error (some sort of timeout exception). We'd have to make that exception a ""special"" exception in ClientExceptionUtil so that it doesn't clear the cache. # Make DoNotRetryIOException itself a ""special"" exception. The point of clearing cache is to make retries more likely to succeed if the failure was related to a wrong location. But DoNotRetryIOException explicitly is not supposed to be retried, so you might think it shouldn't clear the cache as well. There are many usages of this exception, so it's hard to say for sure that this would be universally safe. # Reset the RetryingTimeTracker after resolving region locations. I think I'd lean towards option 1, because it seems odd to say ""don't retry in that case"". In fact, retrying should be more likely to succeed because locations will have been resolved. Whichever we choose, I think we should additionally check the timeout in groupAndSendMultiAction after resolving each region location. We should not allow that process to exceed timeouts and currently it can way more than exceed them before finally being checked incidentally at the end." IllegalArgumentException is thrown by SnapshotScannerHDFSAclController when dropping a table,13498465,Resolved,Major,Fixed,07/Nov/22 11:45,15/Nov/22 05:22,2.5.1,"If enabled the feature about scan snapshot and grant the permissions of a table and a namespace to the same user, an IllegalArgumentException will be thrown when droping tables." Improve BucketAllocatorException log to always include HFile name,13484255,Resolved,Major,Fixed,03/Oct/22 13:52,21/Nov/22 13:24,,"In HBASE-26444 the logging around BucketAllocatorException was improved. One thing I'm noticing is that I'm often seeing logs like this: {quote}2022-10-03T13:13:18,284 [main-BucketCacheWriter-0] WARN org.apache.hadoop.hbase.io.hfile.bucket.BucketCache: Most recent failed allocation after 60000 ms; Message: Allocation too big size=771956; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. {quote} According to the logic in the code, this means the failure was for an HFileBlock but the block's getColumnFamily and/or getTableName were null. I'm not sure why that is the case, we don't have any special customizations here. But as a result we don't print any indication of the hfile name. We should add an option to fallback here on the default printing which includes the re.getKey() (HFile name) in all cases." Clone Scan in ClientScanner to avoid errors with Scan re-used,13484126,Resolved,Major,Fixed,01/Oct/22 13:31,13/Jan/24 20:14,,"This has come up before in https://issues.apache.org/jira/browse/HBASE-1774 and https://issues.apache.org/jira/browse/HBASE-4891. The major pushback was around ScanMetrics, which relied on sharing a mutable Scan object. Since https://issues.apache.org/jira/browse/HBASE-17584, ScanMetrics are available on ResultScanner and the method on Scan was deprecated (removed in master). I think this issue became pretty urgent in https://issues.apache.org/jira/browse/HBASE-17167, when we started passing mvcc into the Scan object. If a user unknowingly reuses the Scan object, this can seem like data loss since the Scan will return none of the expected data.  We recently hit this in our upgrade from hbase client 1.2 to 2.4.6, where use-cases that had worked in 1.2 suddenly started returning no results in 2.4.6. It's very hard to debug. I suggest that we now add the clone in master branch. For branch-2, I think we could put it behind a config param to preserve backwards compatibility of Scan.getScanMetrics. If the config param is enabled, scan cloning occurs and Scan.getScanMetrics will be inaccurate. Personally I think this is far better scenario, because data result accuracy is more important than metrics. But we can leave it to the user to decide, and provide a release note." May be miss data when use mob,13515087,Open,Major,,21/Dec/22 12:21,,1.7.2,"After bulkload data into mob table or alter MOB_THRESHOLD, due to  FileDetails.latestPutTs err in compcation, may result in premature deletion of data" Document TLS mutual authentication,13484302,Open,Major,,03/Oct/22 17:45,,,"Now that HBASE-27280 has landed, we need to update docs to include the new features." Expose region/table datalocality data to the metrics,13501201,Open,Major,,12/Nov/22 17:14,,3.0.0-alpha-4,It is necessary to expose the datalocality of region/table to the metrics for collection and monitoring. Should use 'org.apache.hbase.thirdparty.io.netty.tryReflectionSetAccessible',13506602,Resolved,Major,Fixed,28/Nov/22 15:59,08/Jun/23 13:33,,"We current use '-Dio.netty.tryReflectionSetAccessible=true' in pom, but after shading, it should be '-Dorg.apache.hbase.thirdparty.io.netty.tryReflectionSetAccessible=true' now." Setup nightly job for s390x node,13492905,Resolved,Major,Fixed,28/Oct/22 04:45,15/Aug/23 02:10,, [hbase-connectors] Duplicate result when searching HBase by Spark,13502849,Resolved,Major,Fixed,16/Nov/22 08:29,02/Aug/23 11:55,,"I've used hbase-connector for querying HBase table by Spark, and the following issue is what I've encountered recently: When I run SQL: {code:java} select * from hbase_tabe where rowkey in ('r1', 'r2') or rowkey='r1' {code} I've got duplicate row ""r1"" in results. In HBaseTableScanRdd, buildGets method forms two duplicate GET request for rowkey ""r1"". I think we might need a Set to make sure duplicate rowkey won't be request." Bump spotless plugin to 2.27.2 and reimplement the 'Remove unhelpful javadoc stubs' rule,13485460,Resolved,Major,Fixed,10/Oct/22 15:20,12/Oct/22 15:28,,"spotless maven 2.27.2 is released and it contains https://github.com/diffplug/spotless/issues/1359, which allows the replacement to be null, so we can add back the 'Remove unhelpful javadoc stubs' rule now." Document the table based replication queue storage in ref guide,13509552,Resolved,Major,Fixed,03/Dec/22 13:23,06/May/23 14:20,, Should disable replication log cleaner when migrating replication queue data,13486501,Resolved,Major,Fixed,16/Oct/22 15:54,03/Dec/22 13:00,, Add exponential retry backoff support for MigrateReplicationQueueFromZkToTableProcedure,13486500,Resolved,Major,Fixed,16/Oct/22 15:53,30/Nov/22 15:28,, Fix the replication hfile/log cleaner report that the replication table does not exist,13484182,Resolved,Major,Fixed,02/Oct/22 15:56,12/Oct/22 06:40,, Region server abort with failing to list region servers.,13485982,Resolved,Major,Fixed,12/Oct/22 23:11,17/Oct/22 21:31,,"During unit tests, clusters were created and destroyed, the region server could abort during shutdown with failing to list region servers.   Logs:   2022-10-11 18:44:43,393 INFO  [main] utility.HBaseClusterSetup(160): Starting mini cluster: singleCluster [master/victorli-wsl:0:becomeActiveMaster] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - not a secure deployment, proceeding 2022-10-11 18:45:07,234 INFO  [Listener at localhost/45185] utility.HBaseClusterSetup(177): Started mini cluster: singleCluster [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [Listener at localhost/45185] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. 2022-10-11 18:45:45,980 INFO  [Listener at localhost/45185] utility.HBaseClusterSetup(132): Stopping mini cluster: singleCluster [RS:0;victorli-wsl:35113] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [zk-event-processor-pool-0] ERROR org.apache.hadoop.hbase.regionserver.HRegionServer - ***** ABORTING region server victorli-wsl,35113,1665539090704: failed to list region servers ***** [RS:0;victorli-wsl:35113] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. [M:0;victorli-wsl:42915] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close started. [M:0;victorli-wsl:42915] INFO org.apache.hadoop.hbase.zookeeper.ZKWatcher - ZKWatcher close finished. 2022-10-11 18:45:57,208 INFO  [Listener at localhost/45185] utility.HBaseClusterSetup(144): Stopped mini cluster: singleCluster   Stack: [zk-event-processor-pool-0] WARN org.apache.hadoop.hbase.zookeeper.ZKUtil - regionserver:35113-0x101b6fed2a00001, quorum=127.0.0.1:53028, baseZNode=/9 Unable to list children of znode /9/rs java.lang.InterruptedException     at java.lang.Object.wait(Native Method)     at java.lang.Object.wait(Object.java:502)     at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1601)     at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1573)     at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:2420)     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getChildren(RecoverableZooKeeper.java:341)     at org.apache.hadoop.hbase.zookeeper.ZKUtil.listChildrenAndWatchForNewChildren(ZKUtil.java:190)     at org.apache.hadoop.hbase.zookeeper.RegionServerAddressTracker.loadRegionServerList(RegionServerAddressTracker.java:54)     at org.apache.hadoop.hbase.zookeeper.RegionServerAddressTracker.nodeChildrenChanged(RegionServerAddressTracker.java:71)     at org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$processEvent$0(ZKWatcher.java:586)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177)     at org.apache.hadoop.hbase.zookeeper.ZKWatcher.processEvent(ZKWatcher.java:554)     at org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$process$1(ZKWatcher.java:607)     at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:750)" Separate slowlog thresholds for scans vs other requests,13513631,Resolved,Major,Fixed,14/Dec/22 15:55,22/Apr/23 04:23,,Scans by their nature are able to more efficiently pull back larger response sizes than gets. They also may take longer to execute than other request types. We should make it possible to configure a separate threshold for response time and response time for scans. This will allow us to tune down the thresholds for others without adding unnecessary noise for requests which are known to be slower/bigger. Include more request information in slowlog for Scans,13513648,Resolved,Major,Fixed,14/Dec/22 18:19,22/Apr/23 04:23,,"Currently the slowlog only includes a barebones text format of the underlying protobuf Message fields. This is not a great UX for 2 reasons: # Most of the proto fields dont mirror the actual API names in our requests (Scan, Get, etc). # The chosen data is often not enough to actually infer anything about the request Any of the API class's toString method would be a much better representation of the request. On the server side, we already have to turn the protobuf Message into an actual API class in order to serve the request in RSRpcServices. Given slow logs should be a very small percent of total requests, I think we should do a similar parsing in SlowLogQueueService. Or better yet, perhaps we can pass the already parsed request into the queue at the start to avoid the extra work.  When hydrating a SlowLogPayload with this request information, I believe we should use {{Operation's toMap(int maxCols)}} method. Adding this onto the SlowLogPayload as a map (or list of key/values) will make it easier to consume via downstream automation. Alternatively we could use {{{}toJSON(){}}}. We should also include any attributes from the queries, as those made aid tracing at the client level. Edit: because of nuance related to handling multis and the adequacy of info available for gets/puts, we're scoping this issue down to focus on improving the information available on Scan slowlogs" Support replication for hbase:acl,13485483,Resolved,Major,Fixed,10/Oct/22 17:49,14/Apr/23 10:40,2.5.4,"As of now, we allow replication only for user tables.  We should support replication for hbase:acl as well. " log duplication issues in MasterRpcServices,13511510,Resolved,Major,Fixed,10/Dec/22 10:23,20/Jan/23 08:59,,"MasterRpcServices record audit log in privileged operations (grant, revoke) and vital apis like ""execMasterService"". {code:java} public RevokeResponse revoke(RpcController controller, RevokeRequest request) throws ServiceException { try { ...... server.cpHost.preRevoke(userPermission); // has audit log in AccessChecker ...... // removeUserPermission User caller = RpcServer.getRequestUser().orElse(null); if (AUDITLOG.isTraceEnabled()) { // audit log should record all permission changes String remoteAddress = RpcServer.getRemoteAddress().map(InetAddress::toString).orElse(""""); AUDITLOG.trace(""User {} (remote address: {}) revoked permission {}"", caller, remoteAddress, userPermission); } ...... } {code} but I found a path from *server.cpHost.preRevoke(userPermission);* to {*}AccessChecker audit log{*}, which caused {*}log duplication{*}. *_+grant/revoke -> AccessController.preGrant/Revoke -> preGrantOrRevoke -> AccessChecker.requireGlobalPermission/... -> logResult+_* {code:java} public void requireGlobalPermission(User user, String request, Action perm, String namespace) throws IOException { AuthResult authResult; if (authManager.authorizeUserGlobal(user, perm)) { authResult = AuthResult.allow(request, ""Global check allowed"", user, perm, null); authResult.getParams().setNamespace(namespace); logResult(authResult); } else { authResult = AuthResult.deny(request, ""Global check failed"", user, perm, null); authResult.getParams().setNamespace(namespace); logResult(authResult); throw new AccessDeniedException( ""Insufficient permissions for user '"" + (user != null ? user.getShortName() : ""null"") + ""' (global, action="" + perm.toString() + "")""); } } public static void logResult(AuthResult result) { if (AUDITLOG.isTraceEnabled()) { User user = result.getUser(); UserGroupInformation ugi = user != null ? user.getUGI() : null; AUDITLOG.trace( ""Access {} for user {}; reason: {}; remote address: {}; request: {}; context: {};"" + ""auth method: {}"", (result.isAllowed() ? ""allowed"" : ""denied""), (user != null ? user.getShortName() : ""UNKNOWN""), result.getReason(), RpcServer.getRemoteAddress().map(InetAddress::toString).orElse(""""), result.getRequest(), result.toContextString(), ugi != null ? ugi.getAuthenticationMethod() : ""UNKNOWN""); } } {code} Since *AccessChecker* integrates auditlogs for permission check, I'll delete the log in MasterRpcServices. There must be more problems like this, I' ll check it later and commit the code. -There are many ""write"" operations like ""deleteTable"", which may cause security problems, should also record an audit log.-" HTable MetricsTableLatencies not remove trigger memory leak ,13502704,Open,Major,,15/Nov/22 13:04,,2.0.0,"MetricsTableLatenciesImpl  histogramsByTable only put but not remove.Maybe we should remove it when table disabled. supplement: MetricsTableQueryMeterImpl metersByTable has the same problem. Recurrence steps: # create table: create 'student','data' # write data: put 'student','2015001','data:name','Zhangsan' # disable table: disable 'student' # drop table: drop 'student' # visit regionserver:port/jmx # search Namespace_default_table_student_metric Table is deleted, the latency data of the deleted table always in the /jmx endpoint." Determine too large requests by response block size rather than cell size,13513629,Resolved,Major,Fixed,14/Dec/22 15:45,10/Feb/23 16:36,,"We send responses that are too slow or too large to the slow log. The too large is currently based on the response cell size, but the response block size is actually more important for performance. We should enhance the threshold check to use the response block size (or maybe check both sizes). As part of this, we should also add the response block size to the slow log entries." Provide RS coproc ability to attach WAL extended attributes to mutations at replication sink,13513268,Resolved,Major,Fixed,12/Dec/22 23:44,16/Jan/23 19:55,,"HBase provides coproc ability to enhance WALKey attributes (a.k.a. WAL annotations) in order for the replication sink cluster to build required metadata with the mutations. The endpoint is preWALAppend(). This ability was provided by HBASE-22622. The map of extended attributes is optional and hence not directly used by hbase internally.  For any hbase downstreamers to build CDC (Change Data Capture) like functionality, it might required additional metadata in addition to the ones being used by hbase already (replication scope, list of cluster ids, seq id, table name, region id etc). For instance, Phoenix uses many additional attributes like tenant id, schema name, table type etc. We already have this extended map of attributes available in WAL protobuf, to provide us the capability to (de)serialize it. While creating new ReplicateWALEntryRequest from the list of WAL entires, we are able to serialize the additional attributes. Similarly, at the replication sink side, the deserialized WALEntry has the extended attributes available. At the sink cluster, we should be able to attach the deserialized extended attributes to the newly generated mutations so that the peer cluster can utilize the mutation attributes to re-build required metadata." Observed lot of threads blocked in ConnectionImplementation.getKeepAliveMasterService,13503728,Resolved,Major,Fixed,19/Nov/22 06:01,12/Dec/22 18:48,2.5.0,"Recently We observed that lot of threads are blocked in method ""ConnectionImplementation.getKeepAliveMasterService"" during some initialization stages of rolling restart workflow.  During rolling restart, we make RPC calls to Master using RpcRetryingCallerImpl, so as part of initialization we call ""ConnectionImplementation.getKeepAliveMasterService"" for each thread. Internally this method do RPC call within a synchronized block to check if master is running (mss.isMasterRunning). Lots of threads are in blocked state due following synchronized block synchronized (masterLock) {    if (!isKeepAliveMasterConnectedAndRunning(this.masterServiceState)) {      MasterServiceStubMaker stubMaker = new MasterServiceStubMaker();      this.masterServiceState.stub = stubMaker.makeStub();    }    resetMasterServiceState(this.masterServiceState);  } In Thread Dump Analyzer (2.4), we get warning that ""A lot of threads are waiting for this monitor to become available again.  This might indicate a congestion. You also should analyze other locks blocked by threads waiting for this monitor as there might be much more threads waiting for it."". Please check attached screenshot !Screenshot 2022-11-16 at 10.06.59 AM.png|width=1639,height=971! -------------------- ""pool-11-thread-158"" #313 prio=5 os_prio=0 tid=0x000055b88bcb8800 nid=0x404e waiting for monitor entry [0x00007fa48aa86000]    java.lang.Thread.State: BLOCKED (on object monitor)     at org.apache.hadoop.hbase.client.ConnectionImplementation.getKeepAliveMasterService(ConnectionImplementation.java:1336)     - waiting to lock <0x00000005d30ecb68> (a java.lang.Object)     at org.apache.hadoop.hbase.client.ConnectionImplementation.getMaster(ConnectionImplementation.java:1327)     at org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:57)     at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:103)     at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3019)     at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3011)     at org.apache.hadoop.hbase.client.HBaseAdmin.move(HBaseAdmin.java:1458)     at org.apache.hadoop.hbase.util.MoveWithoutAck.call(MoveWithoutAck.java:58)     at org.apache.hadoop.hbase.util.MoveWithoutAck.call(MoveWithoutAck.java:33) -------------------   *Proposal:* We can optimize this flow as follows 1. Use double checked lock for ""isKeepAliveMasterConnectedAndRunning(this.masterServiceState)"" so that theads don't race for monitor, when master is running. 2. ""isKeepAliveMasterConnectedAndRunning()"" method should reuse the Globally cached state of isMasterRunning instead of doing expensive Call in for each thread.  Check PR [https://github.com/apache/hbase/pull/4889] for more details. Note: The ""master"" branch uses ""AsyncConnectionImpl"" so apparently we don't have issues there.    " Upgrade the dockerfile used in nightly and pre commit to ubuntu 22.04,13493760,Resolved,Major,Fixed,31/Oct/22 13:24,30/Jan/23 07:14,,"I've upgraded several dockerfiles when implementing HBASE-27359 related issues. Ubuntu 18.04 will be EOL at April, 2023, less than half a year, so let's do the upgrading." Close store file readers after region warmup ,13515929,Resolved,Major,Fixed,29/Dec/22 09:49,28/Jan/23 15:46,,"We recently upgraded one of our clusters from version 1.4.13 to 2.4.15. After that we noticed that the number of open FD was increased 10 times more than before, from 1.3k to 15k. Each RS has about 1000 regions.   I thouht that it is OK if the number of open FD keeps steady. But the number was increased when regions were balanced. I found that there is a bug related to the region warmup process, which leaks opened FDs, and I fixed it. Please review the PR.   But I still have a question about why HBase 2.4 opens much more than 1.4. I am trying to find the answer, but not yet. Is there any person who can answer the question?" Add multiWAL support for Replication Observability framework.,13494371,Open,Major,,02/Nov/22 17:44,,,HBASE-26913 added a new framework for observing health of replication subsystem. Currently we add replication marker row just to one WAL (i.e. default WAL). We need to add support for multi WAL implementation. Encapsulate and centralise access to ref count through StoreFileInfo,13514740,Resolved,Major,Fixed,19/Dec/22 13:34,22/Jan/23 05:27,3.0.0-alpha-3,"Both {{StoreFileReader}} and {{StoreFileInfo}} have a {{refCount}}, and the {{refCount}} is currently used in three main ways: * When a new {{StoreFileScanner}} is created or close, it increases or decreases the {{StoreFileReader.refCount}}. * When {{CompactedHFilesDischarger}} checks a {{HStoreFile}} whether it could be deleted, it check the {{StoreFileInfo.refCount}}. * When {{HStore.getScanners}} gets {{HStoreFile}} from {{StoreFileManager}}, it increases or decreases the {{StoreFileInfo.refCount}}. The problem here is {{StoreFileReader.refCount}} is copied from the {{StoreFileInfo.refCount}} and the inconsistent usage of the {{refCount}} making the code somewhat hard to understand and causing trace the resource race problems such as HBASE-27484 and HBASE-27519 somewhat difficult. I suggest we should unify these two {{refCount}} and just use {{StoreFileInfo.refCount}} " Allow namespace admins to clone snapshots created by them,13503537,Resolved,Major,Fixed,18/Nov/22 10:13,18/Jan/23 10:31,2.5.1,Creating a snapshot requires table admin permissions. But cloning it requires global admin permissions unless the user owns the snapshot and wants to recreate the original table the snapshot was based on using the same table name. This puts unnecessary load on the few people having global admin permissions. I would like to relax this rule a bit and allow the owner of the snapshot to clone it into any namespace where they have admin permissions regardless of the table name used. Bump gitpython from 3.1.29 to 3.1.30 in /dev-support/git-jira-release-audit,13515743,Resolved,Major,Fixed,27/Dec/22 13:29,11/Jan/23 03:13,,"Dependabot report security problems for git python. Let's upgrade it." The potential delay of HDFS RPC in HRegion may cause data inconsistency,13510285,Open,Major,,06/Dec/22 19:31,,2.4.2,"This is a follow-up for HBASE-26256 about the data inconsistency issue. The data inconsistency issue is that when the HBase shell is running the `create` command, the metadata is not finalized or committed until the shell command returns, but other clients can see the table “created” when they use the “list” command. We recently did more analysis and found the root cause. Here is the workflow. When a table is created, the CreateTableProcedure is created at HMaster#createTable at line 2011: {code:java} return MasterProcedureUtil  .submitProcedure(new MasterProcedureUtil.NonceProcedureRunnable(this, nonceGroup, nonce) {    @Override    protected void run() throws IOException {      getMaster().getMasterCoprocessorHost().preCreateTable(desc, newRegions);      LOG.info(getClientIdAuditPrefix() + "" create "" + desc);      // TODO: We can handle/merge duplicate requests, and differentiate the case of      // TableExistsException by saying if the schema is the same or not.      //      // We need to wait for the procedure to potentially fail due to ""prepare"" sanity      // checks. This will block only the beginning of the procedure. See HBASE-19953.      ProcedurePrepareLatch latch = ProcedurePrepareLatch.createBlockingLatch();      submitProcedure(        new CreateTableProcedure(procedureExecutor.getEnvironment(), desc, newRegions, latch));             // line 2011      latch.await();      getMaster().getMasterCoprocessorHost().postCreateTable(desc, newRegions);    }    @Override    protected String getDescription() {      return ""CreateTableProcedure"";    }  });{code} The its call stack is: {code:java} org.apache.hadoop.hbase.master.HMaster,createTable,1995 org.apache.hadoop.hbase.master.MasterRpcServices,createTable,705 org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2,callBlockingMethod,108919 org.apache.hadoop.hbase.ipc.RpcServer,call,395 org.apache.hadoop.hbase.ipc.CallRunner,run,133 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler,run,338 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler,run,318 {code} `CreateTableProcedure` is submitted at line 2011. It will eventually call CreateTableProcedure#executeFromState in HMaster. CreateTableProcedure#executeFromState runs a state machine. It exercises 3 states, one after another (via the loop in ProcedureExecutor#executeProcedure): # `CREATE_TABLE_ADD_TO_META` state. It will add table info to the hbase::meta. # `CREATE_TABLE_ASSIGN_REGIONS` state. It will create a subprocedure, which makes an AssignmentManager in master connect to regionservers to distribute the region create command. # `CREATE_TABLE_UPDATE_DESC_CACHE` state. It finalizes the region creation. Code snippet (CreateTableProcedure#executeFromState, line 105 ~ 120): {code:java} case CREATE_TABLE_ADD_TO_META:  newRegions = addTableToMeta(env, tableDescriptor, newRegions);  setNextState(CreateTableState.CREATE_TABLE_ASSIGN_REGIONS);  break; case CREATE_TABLE_ASSIGN_REGIONS:  setEnablingState(env, getTableName());  addChildProcedure(env.getAssignmentManager()    .createRoundRobinAssignProcedures(newRegions));  setNextState(CreateTableState.CREATE_TABLE_UPDATE_DESC_CACHE);  break; case CREATE_TABLE_UPDATE_DESC_CACHE:  // XXX: this stage should be named as set table enabled, as now we will cache the  // descriptor after writing fs layout.  setEnabledState(env, getTableName());  setNextState(CreateTableState.CREATE_TABLE_POST_OPERATION);  break;{code} When the issue described in HBASE-26256 appears, it is in the `CREATE_TABLE_ASSIGN_REGIONS` state. The subprocedure calling regionserver is stuck for a while, so the state machine is not able to proceed to the `CREATE_TABLE_UPDATE_DESC_CACHE` state temporarily. However, at this moment, when other clients run the `list` command, they are essentially only checking the meta variable field in this HMaster and print this table, although the state machine here is still stuck at the `CREATE_TABLE_ASSIGN_REGIONS` and this table is actually not yet fully created. Therefore, the inconsistency happens. To fix this issue, we need to slightly change the state machine or add some auxiliary flags for the tables to mark whether the table is still under the procedure of being created. We think the latter is better because changing the state machine may involve lots of modification." "AccessChecker records auditlog at trace level, while RPCServices record allow at info, deny at warn.",13511058,Open,Major,,09/Dec/22 11:52,,thirdparty-4.1.3, HBaseTestingUtility minicluster requires log4j2,13502649,Resolved,Major,Fixed,15/Nov/22 08:22,04/Jan/23 03:33,,"Using the HBaseMiniCluster now requires addition of log4j-api and log4j-core to the classpath. This can be demonstrated by updating hbase-downstreamer for 2.5.1. https://github.com/saintstack/hbase-downstreamer" Fix python requirements problem,13510788,Resolved,Major,Fixed,08/Dec/22 13:31,13/Dec/22 16:26,,"The dependabot report two security problems for python requirements gitpython <= 3.1.20 certifi < 2022.12.07 And there is also a parse error InstallationError(""Invalid requirement: 'cryptography=3.3.2' (from line 22 of /home/dependabot/dependabot-updater/dependabot_tmp_dir/requirements.txt)\nHint: = is not a valid operator. Did you mean == ?"")" Improve our hbase_docker to be able to build and start standalone clusters other than master branch,13494324,Resolved,Major,Fixed,02/Nov/22 13:12,13/Dec/22 16:26,,"Find this docker file when trying to upgrade all our docker files from ubuntu 18.04 to 22.04. While upgrading it to ubuntu 22.04, I think we could also improve it to start cluster for other branches and tags, i.e, the current stable release, which will be better for our end users." Modify README.txt to mention how to contribue,13507817,Resolved,Major,Fixed,01/Dec/22 10:43,10/Dec/22 13:20,,"Especially how to acquire a jira account. Will file other issues for changing other resources such as website and ref guide." Another case for FNFE on StoreFileScanner after a flush followed by a compaction,13509805,Resolved,Major,Fixed,05/Dec/22 03:19,10/Dec/22 04:53,2.4.15,"Besides the fix for {{HStore.getScanners}} for FNFE on StoreFileScanner after a flush followed by a compaction in HBASE-27484, there is a another case would cause FNFE: # When {{StoreScanner}} is scanning, there is a flush followed by a compaction. When the flushed is completed in {{HStore.completeFlush}} and after it adds the new {{HStoreFile}} in {{StoreEngine}}, it would notify the {{StoreScanner.updateReaders}} by {{HStore.notifyChangedReadersObservers}} with the new flushed {{HStoreFile}}： {code:java} private boolean completeFlush(List sfs, long snapshotId) throws IOException { // NOTE:we should keep clearSnapshot method inside the write lock because clearSnapshot may // close {@link DefaultMemStore#snapshot}, which may be used by // {@link DefaultMemStore#getScanners}. storeEngine.addStoreFiles(sfs, snapshotId > 0 ? () -> this.memstore.clearSnapshot(snapshotId) : () -> { }); // notify to be called here - only in case of flushes notifyChangedReadersObservers(sfs); if (LOG.isTraceEnabled()) { long totalSize = getTotalSize(sfs); String traceMessage = ""FLUSH time,count,size,store size,store files ["" + EnvironmentEdgeManager.currentTime() + "","" + sfs.size() + "","" + totalSize + "","" + storeSize + "","" + storeEngine.getStoreFileManager().getStorefileCount() + ""]""; LOG.trace(traceMessage); } return needsCompaction(); } {code} # But if before entering {{StoreScanner.updateReaders}} , the compaction task starts and it compacts the new flushed {{HStoreFile}} and then {{HStore.closeAndArchiveCompactedFiles}} is called by {{CompactedHFilesDischarger}} to delete the {{HStoreFile}}. # When {{StoreScanner.updateReaders}} continues to execute, it would read already deleted {{HStoreFile}} and throws FNFE." RegionServer JVM crash when the RPC request size is too big,13515190,Open,Major,,22/Dec/22 07:52,,2.3.4,"In our cluster, JVM crash when the request size is too big hs_err.log {code:java} # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f6c4bbb7b31, pid=5619, tid=0x00007f3dc57b4700 # # JRE version: Java(TM) SE Runtime Environment (8.0_181-b13) (build 1.8.0_181-b13) # Java VM: Java HotSpot(TM) 64-Bit Server VM (25.181-b13 mixed mode linux-amd64 ) # Problematic frame: # C [libc.so.6+0x15bb31] __memmove_ssse3_back+0x1ba1 # # Core dump written. Default location: /home/user/core or core.5619 (max size 1048576 kB). To ensure a full core dump, try ""ulimit -c unlimited"" before starting Java again # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # Stack: [0x00007f3dc56b4000,0x00007f3dc57b5000], sp=0x00007f3dc57b2d48, free space=1019k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) C [libc.so.6+0x15bb31] __memmove_ssse3_back+0x1ba1 J 2301 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007f6c35a3ae21 [0x00007f6c35a3ad40+0xe1] j org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36 j org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69 j org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39 j org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31 j org.apache.hadoop.hbase.CellUtil.cloneQualifier(Lorg/apache/hadoop/hbase/Cell;)[B+12 j org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B+1 j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;Ljava/util/function/Function;)Ljava/lang/String;+97 j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;)Ljava/lang/String;+6 j org.apache.hadoop.hbase.CellUtil.toString(Lorg/apache/hadoop/hbase/Cell;Z)Ljava/lang/String;+16 j org.apache.hadoop.hbase.ByteBufferKeyValue.toString()Ljava/lang/String;+2 j org.apache.hadoop.hbase.client.Mutation.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Mutation;+28 j org.apache.hadoop.hbase.client.Put.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Put;+2 J 19274 C2 org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MutationProto;Lorg/apache/hadoop/hbase/CellScanner;)Lorg/apache/hadoop/hbase/client/Put; (910 bytes) @ 0x00007f6c386ed4e4 [0x00007f6c386eb7a0+0x1d44] J 32557 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apache/hadoop/hbase/quotas/OperationQuota;Ljava/util/List;Lorg/apache/hadoop/hbase/CellScanner;JLorg/apache/hadoop/hbase/quotas/ActivePolicyEnforcement;Z)V (1046 bytes) @ 0x00007f6c39d9e494 [0x00007f6c39d9dcc0+0x7d4] J 29517 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apache/hadoop/hbase/quotas/OperationQuota;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionAction;Lorg/apache/hadoop/hbase/CellScanner;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;Ljava/util/List;JLorg/apache/hadoop/hbase/regionserver/RSRpcServices$RegionScannersCloseCallBack;Lorg/apache/hadoop/hbase/ipc/RpcCallContext;Lorg/apache/hadoop/hbase/quotas/ActivePolicyEnforcement;)Ljava/util/List; (901 bytes) @ 0x00007f6c39c25898 [0x00007f6c39c24da0+0xaf8] J 31074 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcController;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiRequest;)Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiResponse; (1119 bytes) @ 0x00007f6c39e7dcd4 [0x00007f6c39e7db20+0x1b4] J 28404 C2 org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(Lorg/apache/hbase/thirdparty/com/google/protobuf/Descriptors$MethodDescriptor;Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcController;Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;)Lorg/apache/hbase/thirdparty/com/google/protobuf/Message; (221 bytes) @ 0x00007f6c38ec2008 [0x00007f6c38ec1e00+0x208] J 31063 C2 org.apache.hadoop.hbase.ipc.RpcServer.call(Lorg/apache/hadoop/hbase/ipc/RpcCall;Lorg/apache/hadoop/hbase/monitoring/MonitoredRPCHandler;)Lorg/apache/hadoop/hbase/util/Pair; (634 bytes) @ 0x00007f6c39e6c8e8 [0x00007f6c39e6c0a0+0x848] J 29524 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1376 bytes) @ 0x00007f6c39c5e3f8 [0x00007f6c39c5da00+0x9f8] J 20025 C2 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(Lorg/apache/hadoop/hbase/ipc/CallRunner;)V (268 bytes) @ 0x00007f6c36f98918 [0x00007f6c36f987a0+0x178] J 20980% C2 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run()V (72 bytes) @ 0x00007f6c37ee2698 [0x00007f6c37ee1e80+0x818] v ~StubRoutines::call_stub V [libjvm.so+0x697a76] JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*)+0x1056 V [libjvm.so+0x697f81] JavaCalls::call_virtual(JavaValue*, KlassHandle, Symbol*, Symbol*, JavaCallArguments*, Thread*)+0x321 V [libjvm.so+0x698427] JavaCalls::call_virtual(JavaValue*, Handle, KlassHandle, Symbol*, Symbol*, Thread*)+0x47 V [libjvm.so+0x71789e] thread_entry(JavaThread*, Thread*)+0x7e V [libjvm.so+0xa813f3] JavaThread::thread_main_inner()+0x103 V [libjvm.so+0xa8153c] JavaThread::run()+0x11c V [libjvm.so+0x930198] java_start(Thread*)+0x108 C [libpthread.so.0+0x7e65] start_thread+0xc5 Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) J 2301 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007f6c35a3ada7 [0x00007f6c35a3ad40+0x67] j org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36 j org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69 j org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39 j org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31 j org.apache.hadoop.hbase.CellUtil.cloneQualifier(Lorg/apache/hadoop/hbase/Cell;)[B+12 j org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B+1 j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;Ljava/util/function/Function;)Ljava/lang/String;+97 j org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;)Ljava/lang/String;+6 j org.apache.hadoop.hbase.CellUtil.toString(Lorg/apache/hadoop/hbase/Cell;Z)Ljava/lang/String;+16 j org.apache.hadoop.hbase.ByteBufferKeyValue.toString()Ljava/lang/String;+2 j org.apache.hadoop.hbase.client.Mutation.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Mutation;+28 j org.apache.hadoop.hbase.client.Put.add(Lorg/apache/hadoop/hbase/Cell;)Lorg/apache/hadoop/hbase/client/Put;+2 J 19274 C2 org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MutationProto;Lorg/apache/hadoop/hbase/CellScanner;)Lorg/apache/hadoop/hbase/client/Put; (910 bytes) @ 0x00007f6c386ed4e4 [0x00007f6c386eb7a0+0x1d44] J 32557 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apache/hadoop/hbase/quotas/OperationQuota;Ljava/util/List;Lorg/apache/hadoop/hbase/CellScanner;JLorg/apache/hadoop/hbase/quotas/ActivePolicyEnforcement;Z)V (1046 bytes) @ 0x00007f6c39d9e494 [0x00007f6c39d9dcc0+0x7d4] J 29517 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(Lorg/apache/hadoop/hbase/regionserver/HRegion;Lorg/apache/hadoop/hbase/quotas/OperationQuota;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionAction;Lorg/apache/hadoop/hbase/CellScanner;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;Ljava/util/List;JLorg/apache/hadoop/hbase/regionserver/RSRpcServices$RegionScannersCloseCallBack;Lorg/apache/hadoop/hbase/ipc/RpcCallContext;Lorg/apache/hadoop/hbase/quotas/ActivePolicyEnforcement;)Ljava/util/List; (901 bytes) @ 0x00007f6c39c25898 [0x00007f6c39c24da0+0xaf8] J 31074 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcController;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiRequest;)Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiResponse; (1119 bytes) @ 0x00007f6c39e7dcd4 [0x00007f6c39e7db20+0x1b4] J 28404 C2 org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(Lorg/apache/hbase/thirdparty/com/google/protobuf/Descriptors$MethodDescriptor;Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcController;Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;)Lorg/apache/hbase/thirdparty/com/google/protobuf/Message; (221 bytes) @ 0x00007f6c38ec2008 [0x00007f6c38ec1e00+0x208] J 31063 C2 org.apache.hadoop.hbase.ipc.RpcServer.call(Lorg/apache/hadoop/hbase/ipc/RpcCall;Lorg/apache/hadoop/hbase/monitoring/MonitoredRPCHandler;)Lorg/apache/hadoop/hbase/util/Pair; (634 bytes) @ 0x00007f6c39e6c8e8 [0x00007f6c39e6c0a0+0x848] J 29524 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1376 bytes) @ 0x00007f6c39c5e3f8 [0x00007f6c39c5da00+0x9f8] J 20025 C2 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(Lorg/apache/hadoop/hbase/ipc/CallRunner;)V (268 bytes) @ 0x00007f6c36f98918 [0x00007f6c36f987a0+0x178] J 20980% C2 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run()V (72 bytes) @ 0x00007f6c37ee2698 [0x00007f6c37ee1e80+0x818] v ~StubRoutines::call_stub {code} regionserver log {code:java} 2022-12-21 20:38:03,341 WARN [RS-EventLoopGroup-1-67] ipc.NettyRpcServer: RPC data length of 741092396 received from 11.0.10.10 is greater than max allowed 268435456. Set ""hbase.ipc.max.request.size"" on server to override this limit (not recommended) 2022-12-21 20:38:54,426 INFO [main] zookeeper.ZooKeeper: Client environment:zookeeper.version=3.5.7-f0fdd52973d373ffd9c86b81d99842dc2c7f660e, built on 02/10/2020 11:30 GMT 2022-12-21 20:38:54,426 INFO [main] zookeeper.ZooKeeper: Client environment:host.name=HT-HBASE-xxxx-10-70-121-0.hadoop.jd.local 2022-12-21 20:38:54,426 INFO [main] zookeeper.ZooKeeper: Client environment:java.version=1.8.0_181 2022-12-21 20:38:54,427 INFO [main] zookeeper.ZooKeeper: Client environment:java.vendor=Oracle Corporation 2022-12-21 20:38:54,427 INFO [main] zookeeper.ZooKeeper: Client environment:java.home=/software/servers/jdk1.8.0_181/jre {code} May be the Bytebuffer is already release. " Move some persistent states from zookeeper to master region,13507828,Resolved,Major,Fixed,01/Dec/22 11:22,22/Dec/22 06:05,,"Although losing these data is not a big problem but I think they should still be considered as persistent state, not transient state. So let's move them off zookeeper." Evict blocks on split/merge; Avoid caching reference/hlinks if compaction is enabled,13500236,Resolved,Major,Fixed,08/Nov/22 21:03,19/Dec/22 12:15,3.0.0-alpha-3,"This change aims to improve block cache usage upon splits/merges. On a split/merge event the following main steps happen: 1) parent regions are closed; 2) daughters are created and opened with refs/hlinks; 3) Compaction is triggered soon after the daughters get online; With ""hbase.rs.evictblocksonclose"" set to false, we keep all blocks for the closed regions in 1, then will try to load same blocks again on 2 (since we are using the refs/links for the cache key), just to throw it away and cache the compaction resulting file in 3.  If the block cache is close to its capacity, blocks from the compacted files in 3 will likely miss the cache. The proposal here is to always evict blocks for parent regions on a split/merge event, and also avoid caching blocks for refs/hlinks if compactions are enabled. " Hbase cannot support offpeak periods throughout all the day when hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted,13502989,Open,Major,,17/Nov/22 02:37,,2.4.15,"Hbase cannot support offpeak periods throughout all the day when hbase.offpeak.start.hour=0 and hbase.offpeak.end.hour=23 setted   !image-2022-11-17-10-37-10-989.png!  " Slow log improvements,13513611,Resolved,Major,Incomplete,14/Dec/22 14:14,14/Dec/22 14:23,,"Over the next several months, we would like to make some improvements to the regionserver slow log. I'm going to log this to organize them. " CallTimeoutException can cause feedback loop with meta clears,13510675,Resolved,Major,Not A Problem,07/Dec/22 22:58,13/Dec/22 14:09,,"In HBASE-27487 and HBASE-27490 we added safeguard which should reduce feedback loop caused by slow meta. We have continued to chaos test the hbase client and have found another case that needs to be handled. With those two jiras, we no longer allow multiget to exceed operation timeout when meta is slow, and OperationTimeoutExceededExceptions do not clear meta cache. This allows for quicker recovery in many cases. However, consider the case where you have a 1s RPC timeout and 3s operation timeout. Let's say meta is slow and it takes 2.9 seconds to resolve region locations for a batch. When we go to submit the multi actions to the server, we will only have a 100ms remaining time on our operation timeout. This may not be enough, and it results in a CallTimeoutException. I use slow meta as an example, but it's possible for any slow regionserver to kick off a feedback loop due to a sudden surge in CallTimeoutException resulting in many clients clearing cache and hitting meta. Even with meta replicas, this just exacerbates any slowness and may become unrecoverable without extreme actions. I also use multigets as the example here, and I think they are most at risk of this, but this is theoretically possible for all request types. A single Get might retry a few times and the last attempt only has a few milliseconds of remaining time. This could also result in a CallTimeoutException and potentially kick off a feedback loop. I'm still trying to consider options, and am open to opinions here. This issue affects AyncTable and Table. Here are some raw options I've been weighing: * Treat CTE as special (non-clearing) ** Problem: what if a failed server continues to timeout and we have no idea that regions have moved? ** Can we differentiate CTE vs some sort of SocketTimeoutException (where server is not serving)? * Rate limit cache clears from CTE * Rate limit all cache clears * Rethrow CTE as an OperationTimeoutExceededException when remainingTime < rpcTimeout, thus skipping clear in that case ** This is the most targeted solution, but may leave other edge cases. ** Problem: what about the case where a server is just running slow, but continually causing cache clears?" Port HBASE-27498 to branch-2,13511502,Resolved,Major,Fixed,10/Dec/22 05:16,12/Dec/22 19:02,2.6.0,"Port HBASE-27498 to ""branch-2"" Please refer to PR [https://github.com/apache/hbase/pull/4919]  " "Hbase master is not up due to NotServingRegionException: hbase:meta,,1 is not online",13505770,Open,Major,,24/Nov/22 14:17,,2.4.13,"Hbase master is in initializing state and never become ready. it is not up due to following error ""NotServingRegionException: hbase:meta,,1 is not online on hbase-regionserver-0.hbase-regionserver.default.svc.cluster.local, ..."" when we observe this: when region server split into multiple region and there is restart of hbase regionserver and master. {code:java} INFO  [main] util.HBaseFsck: Validating mapping using HDFS state Number of live region servers: 1 Number of dead region servers: 2 Master: hbase-master-0.hbase-master.default.svc.cluster.local,.... Number of backup masters: 0 Average load: 0.0 Number of requests: 0 Number of regions: 0 Number of regions in transition: 0 INFO  [main] client.RpcRetryingCallerImpl: Call exception, tries=6, retries=16, started=4333 ms ago, cancelled=false, msg=org.apache.hadoop.hbase.PleaseHoldException: Master is initializing     at org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:2830)     at org.apache.hadoop.hbase.master.MasterRpcServices.getTableDescriptors(MasterRpcServices.java:1075)     at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:384)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:131)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:371)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:351) , details=, see https://s.apache.org/timeout {code} workaround: to make it up, we are deleting /hbase/meta-regionserver using ""hbase zkcli delete   /hbase/meta-regionserver""   is there any way to prevent this to occur by setting some properties in hbase-site.xml " hbase client metrics per user specified identity on hconnections.,13495961,Resolved,Major,Fixed,04/Nov/22 23:07,05/Dec/22 20:25,,"At present, hbase client metrics is per each individual hconnection and with a pre-configured scope in conf or cluster ID plus connection ID which has generated hash code as suffix. If a client has more than one connections and the scope configuration is common among all connections, the metrics might override each other. I am proposing connections to share a common metrics object if the connections have a common configured scope. If a connection identity is not provided, client metrics will continue working per hconnection and has a connection ID as it scope. I.e. no behavior change." Add 2.5.2 to download page,13509558,Resolved,Major,Fixed,03/Dec/22 14:35,04/Dec/22 16:30,, Release 2.5.2,13504826,Resolved,Major,Fixed,21/Nov/22 13:54,05/Dec/22 04:05,, Finish the 2.5.2 release,13509557,Resolved,Major,Fixed,03/Dec/22 14:33,05/Dec/22 04:00,,"# Move release binaries from dist-dev to dist-release # Publish maven artifacts on repository.a.o # Tag rel/2.5.2 and push it # Mark 2.5.2 as release on jira # Send anouncement email" FNFE on StoreFileScanner after a flush followed by a compaction,13502592,Resolved,Major,Fixed,15/Nov/22 00:14,29/Nov/22 14:10,2.4.15,"One of our customers was running SyncTable from a 1.2 based cluster, where SyncTable map tasks were open scanners on a 2.4 based cluster for comparing the two clusters. Few of the map tasks failed with a DoNotRetryException caused by a FileNotFoundException blowing all the way up to the client: {noformat} Error: org.apache.hadoop.hbase.DoNotRetryIOException: org.apache.hadoop.hbase.DoNotRetryIOException: java.io.FileNotFoundException: open s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/e2c58350e4e54c21b0f713a4c271b8c0 at 7225 on s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/e2c58350e4e54c21b0f713a4c271b8c0: com.amazonaws.services.s3.model.AmazonS3Exception: The specified key does not exist. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchKey; Request ID: KBRNC67WZGCS4SCF; S3 Extended Request ID: wWEJm8tlFSj/8g+xFpmD1vgWzT/n7HzBcOFAZ8ayIqKMsDZGN/d2kEhdusPLhMd540h+QAPP1xw=; Proxy: null), S3 Extended Request ID: wWEJm8tlFSj/8g+xFpmD1vgWzT/n7HzBcOFAZ8ayIqKMsDZGN/d2kEhdusPLhMd540h+QAPP1xw=:NoSuchKey at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3712) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45819) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:392) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:140) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:359) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:339) Caused by: java.io.FileNotFoundException: open s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/e2c58350e4e54c21b0f713a4c271b8c0 at 7225 on s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/e2c58350e4e54c21b0f713a4c271b8c0: com.amazonaws.services.s3.model.AmazonS3Exception: The specified key does not exist. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchKey; Request ID: KBRNC67WZGCS4SCF; S3 Extended Request ID: wWEJm8tlFSj/8g+xFpmD1vgWzT/n7HzBcOFAZ8ayIqKMsDZGN/d2kEhdusPLhMd540h+QAPP1xw=; Proxy: null), S3 Extended Request ID: wWEJm8tlFSj/8g+xFpmD1vgWzT/n7HzBcOFAZ8ayIqKMsDZGN/d2kEhdusPLhMd540h+QAPP1xw=:NoSuchKey ... at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:632) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekAtOrAfter(StoreFileScanner.java:315) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seek(StoreFileScanner.java:216) at org.apache.hadoop.hbase.regionserver.StoreScanner.seekScanners(StoreScanner.java:417) at org.apache.hadoop.hbase.regionserver.StoreScanner.reopenAfterFlush(StoreScanner.java:1018) at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:552) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:155) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:7399) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:7567) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:7331) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3373) {noformat} We can see on the RS logs that the above file got recently create as an outcome of a memstore flush, then compaction is triggered shortly: {noformat} 2022-11-11 22:16:50,322 INFO org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher: Flushed memstore data size=208.15 KB at sequenceid=4949703 (bloomFilter=false), to=s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/e2c58350e4e54c21b0f713a4c271b8c0 2022-11-11 22:16:50,513 INFO org.apache.hadoop.hbase.regionserver.HStore: Added s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/e2c58350e4e54c21b0f713a4c271b8c0, entries=951, sequenceid=4949703, filesize=26.2 K ... 2022-11-11 22:16:50,791 INFO org.apache.hadoop.hbase.regionserver.HRegion: Starting compaction of 4c53da8c2ab9b7d7a0d6046ef3bb701c/0 in xxxxxx,IT001E90506702\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00,1618275339031.4c53da8c2ab9b7d7a0d6046ef3bb701c. 2022-11-11 22:16:50,791 INFO org.apache.hadoop.hbase.regionserver.HStore: Starting compaction of [s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/9a865e5e3ba74ab6b9597fe0e295fd8d, s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/adbe118d8c76482d8faed3170437be0b, s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/0/e2c58350e4e54c21b0f713a4c271b8c0] into tmpdir=s3a://xxxxxxxxx-xxxxxxxx-xxxxxxx/hbase/data/default/xxxxxx/4c53da8c2ab9b7d7a0d6046ef3bb701c/.tmp, totalSize=27.1 M ... 2022-11-11 22:16:54,469 INFO org.apache.hadoop.hbase.regionserver.HStore: Completed compaction of 3 file(s) in 4c53da8c2ab9b7d7a0d6046ef3bb701c/0 of 4c53da8c2ab9b7d7a0d6046ef3bb701c into bc44bfd06a03429fb331ab4dc10dbb8d(size=27.1 M), total size for store is 4.9 G. This selection was in queue for 0sec, and took 3sec to execute. {noformat} I believe this is an unlucky scenario where the compaction discharger moved the compacted away files while the StoreFileScanner was getting created but had not updated the refCounter on the file reader yet. We couldn't reproduce this on a real cluster, but I could emulate it with a UT and artificially inducing a delay in the StoreFileScanner creation when creating scans not for compactions. One possible fix is to update the reader refCounter as soon we get the files for the StoreFileScanner instances we are creating." Put up 2.5.2RC0,13504827,Resolved,Major,Fixed,21/Nov/22 13:54,03/Dec/22 14:31,, Regionservers aborted as mvcc read point is less than max seq id derived from .seqid files,13505253,Resolved,Major,Workaround,22/Nov/22 08:31,01/Dec/22 23:21,2.4.15,"HBase cluster is upgraded from 1.6 to 2.4.14/15 version recently. The cluster doesn't have much traffic. After 4-5 days of this upgrade, suddenly 144 out of ~150 regionservers were aborted with {*}java.io.IOException: The new max sequence id {} is less than the old max sequence id {}{*}. After starting regionservers, things were normal.   Sequence of events for the first regionserver that was aborted: Table snapshot was created, hence region went through snapshot subprocedure. {code:java} 2022-11-16 01:03:11,504 DEBUG [532)-snapshot-pool-0] snapshot.SnapshotManifest - Storing 'TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b.' region-info for snapshot=SNAPSHOT_TABLE01_1668560404026_1668560447300_0 2022-11-16 01:03:11,504 DEBUG [532)-snapshot-pool-0] snapshot.FlushSnapshotSubprocedure - Starting snapshot operation on TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b. 2022-11-16 01:03:11,504 DEBUG [532)-snapshot-pool-0] snapshot.SnapshotManifest - Adding snapshot references for [hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/0/ea13e8a1f56843efb1243d5ba108e63a] hfiles 2022-11-16 01:03:11,504 DEBUG [532)-snapshot-pool-0] snapshot.SnapshotManifest - Adding reference for file (1/1): hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/0/ea13e8a1f56843efb1243d5ba108e63a for snapshot=SNAPSHOT_TABLE01_1668560404026_1668560447300_0 2022-11-16 01:03:11,562 DEBUG [532)-snapshot-pool-0] snapshot.FlushSnapshotSubprocedure - Closing snapshot operation on TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b. 2022-11-16 01:03:11,562 DEBUG [532)-snapshot-pool-0] snapshot.FlushSnapshotSubprocedure - ... SkipFlush Snapshotting region TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b. completed. {code}   After 6+ hr, major compaction of the table was triggered. Logs from RS c01-dabc11-12-xyz.abcxyz: {code:java} 2022-11-16 07:36:34,978 INFO  [0-shortCompactions-0] regionserver.HStore - Starting compaction of [hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/0/ea13e8a1f56843efb1243d5ba108e63a] into tmpdir=hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/.tmp, totalSize=939.0 M 2022-11-16 07:36:34,978 INFO  [0-shortCompactions-0] regionserver.HRegion - Starting compaction of d773829ad7e76202cccac6fbc314091b/0 in TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b. {code}     Region split is triggered by CompactSplit. Logs from RS c01-dabc11-12-xyz.abcxyz: {code:java} 2022-11-16 07:38:03,570 DEBUG [0-shortCompactions-0] regionserver.CompactSplit - Splitting TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b., compactionQueue=(longCompactions=0:shortCompactions=0), splitQueue=0 2022-11-16 07:38:03,848 INFO  [abc11-12-xyz:61020-0] regionserver.HRegion - Closing region TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b. 2022-11-16 07:38:03,860 DEBUG [2cccac6fbc314091b.-1] backup.HFileArchiver - Archived from FileableStoreFile, hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/0/ea13e8a1f56843efb1243d5ba108e63a to hdfs://c01/hbase/archive/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/0/ea13e8a1f56843efb1243d5ba108e63a 2022-11-16 07:38:03,881 DEBUG [abc11-12-xyz:61020-0] regionserver.HRegion - Region close journal for d773829ad7e76202cccac6fbc314091b: Waiting for close lock at 1668584283848Running coprocessor pre-close hooks at 1668584283848Disabling compacts and flushes for region at 1668584283848Disabling writes for close at 1668584283848Writing region close event to WAL at 1668584283876 (+28 ms) 2022-11-16 07:38:03,881 WARN  [abc11-12-xyz:61020-0] handler.UnassignRegionHandler - Fatal error occurred while closing region d773829ad7e76202cccac6fbc314091b, aborting... java.io.IOException: The new max sequence id 1963762 is less than the old max sequence id 1963764     at org.apache.hadoop.hbase.wal.WALSplitUtil.writeRegionSequenceIdFile(WALSplitUtil.java:397)     at org.apache.hadoop.hbase.regionserver.HRegion.writeRegionCloseMarker(HRegion.java:1217)     at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1816)     at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1552)     at org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:118)     at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:98)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:750) {code} Leading to RS abort: {code:java} 2022-11-16 07:38:03,889 ERROR [abc11-12-xyz:61020-0] regionserver.HRegionServer - ***** ABORTING region server c01-dabc11-12-xyz.abcxyz,61020,1668064189532: Failed to close region d773829ad7e76202cccac6fbc314091b and can not recover ***** java.io.IOException: The new max sequence id 1963762 is less than the old max sequence id 1963764     at org.apache.hadoop.hbase.wal.WALSplitUtil.writeRegionSequenceIdFile(WALSplitUtil.java:397)     at org.apache.hadoop.hbase.regionserver.HRegion.writeRegionCloseMarker(HRegion.java:1217)     at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1816)     at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1552)     at org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:118)     at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:98)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:750) {code}     Master tries to open the region on other RS. master logs: {code:java} 2022-11-16 07:38:08,840 INFO  [PEWorker-60] assignment.RegionStateStore - pid=58195 updating hbase:meta row=d773829ad7e76202cccac6fbc314091b, regionState=ABNORMALLY_CLOSED 2022-11-16 07:38:08,883 INFO  [PEWorker-32] assignment.RegionStateStore - pid=58195 updating hbase:meta row=d773829ad7e76202cccac6fbc314091b, regionState=OPENING, regionLocation=c01-dabc6-10-xyz.abcxyz,61020,1668058690832 2022-11-16 07:38:08,883 DEBUG [PEWorker-32] hbase.META - Put {""totalColumns"":3,""row"":""TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\\x000000000000000008\\xFD\\xCC\\xDC\\x9C\\xB7\\xA4\\xFF\\xCF\\xBB\\xCA\\xB5\\xCF\\xCF\\xCF\\xCF\\xCF\\xCF\\x8A\\xAE\\xB3\\xA7\\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b."",""families"":{""info"":[{""qualifier"":""regioninfo"",""vlen"":245,""tag"":[],""timestamp"":""1668584288883""},{""qualifier"":""sn"",""vlen"":53,""tag"":[],""timestamp"":""1668584288883""},{""qualifier"":""state"",""vlen"":7,""tag"":[],""timestamp"":""1668584288883""}]},""ts"":""1668584288883""} 2022-11-16 07:38:08,888 INFO  [PEWorker-32] procedure2.ProcedureExecutor - Initialized subprocedures=[{pid=58794, ppid=58195, state=RUNNABLE; OpenRegionProcedure d773829ad7e76202cccac6fbc314091b, server=c01-dabc6-10-xyz.abcxyz,61020,1668058690832}] 2022-11-16 07:38:09,398 INFO  [PEWorker-55] assignment.RegionStateStore - pid=58195 updating hbase:meta row=d773829ad7e76202cccac6fbc314091b, regionState=OPEN, repBarrier=1963765, openSeqNum=1963765, regionLocation=c01-dabc6-10-xyz.abcxyz,61020,1668058690832 {code}       On the new RS, region is opened, recovered, closed (as part of compact split), compacted and successfully archived. Logs from new RS c01-dabc6-10-xyz.abcxyz: {code:java} 2022-11-16 07:38:09,168 INFO  [dabc6-10-xyz:61020-0] handler.AssignRegionHandler - Open TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b. 2022-11-16 07:38:09,235 DEBUG [dabc6-10-xyz:61020-0] regionserver.HRegion - Instantiated TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b.; StoreHotnessProtector, parallelPutToStoreThreadLimit=10 ; minColumnNum=100 ; preparePutThreadLimit=20 ; hotProtect now enable 2022-11-16 07:38:09,318 DEBUG [dabc6-10-xyz:61020-0] regionserver.HRegion - Found 0 recovered edits file(s) under hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b 2022-11-16 07:38:09,330 DEBUG [dabc6-10-xyz:61020-0] regionserver.HRegion - Found 1 recovered edits file(s) under hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b 2022-11-16 07:38:09,334 INFO  [dabc6-10-xyz:61020-0] regionserver.HRegion - Replaying edits from hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/recovered.edits/0000000000001963761 2022-11-16 07:38:09,365 DEBUG [dabc6-10-xyz:61020-0] regionserver.HRegion - Applied 0, skipped 1, firstSequenceIdInLog=1963761, maxSequenceIdInLog=1963761, path=hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/recovered.edits/0000000000001963761 2022-11-16 07:38:09,365 DEBUG [dabc6-10-xyz:61020-0] regionserver.HRegion - d773829ad7e76202cccac6fbc314091b : Replaying compaction marker table_name: ""TABLE01"" encoded_region_name: ""d773829ad7e76202cccac6fbc314091b"" family_name: ""0"" compaction_input: ""ea13e8a1f56843efb1243d5ba108e63a"" compaction_output: ""e629d75027ed4da79fd962e645c7a3b4"" store_home_dir: ""0"" region_name: ""TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\0000000000000000008\375\314\334\234\267\244\377\317\273\312\265\317\317\317\317\317\317\212\256\263\247\235,1658067025381.d773829ad7e76202cccac6fbc314091b."" with seqId=9223372036854775807 and lastReplayedOpenRegionSeqId=-1 2022-11-16 07:38:09,367 DEBUG [dabc6-10-xyz:61020-0] regionserver.HRegion - Deleted recovered.edits file=hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/recovered.edits/0000000000001963761 2022-11-16 07:38:09,372 DEBUG [dabc6-10-xyz:61020-0] regionserver.HRegion - writing seq id for d773829ad7e76202cccac6fbc314091b 2022-11-16 07:38:09,373 INFO  [dabc6-10-xyz:61020-0] regionserver.HRegion - Opened d773829ad7e76202cccac6fbc314091b; next sequenceid=1963765; SteppingSplitPolicysuper{IncreasingToUpperBoundRegionSplitPolicy{initialSize=536870912, ConstantSizeRegionSplitPolicy{desiredMaxFileSize=9917293600, jitterRate=-0.07638005912303925}}}, FlushLargeStoresPolicy{flushSizeLowerBound=-1} 2022-11-16 07:38:09,581 INFO  [dabc6-10-xyz:61020-2] regionserver.HRegion - Closing region TABLE01,00DJ0000003PwkV000000000000000005J000000681gsU\x000000000000000008\xFD\xCC\xDC\x9C\xB7\xA4\xFF\xCF\xBB\xCA\xB5\xCF\xCF\xCF\xCF\xCF\xCF\x8A\xAE\xB3\xA7\x9D,1658067025381.d773829ad7e76202cccac6fbc314091b. 2022-11-16 07:38:09,597 DEBUG [dabc6-10-xyz:61020-2] wal.WALSplitUtil - Wrote file=hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/recovered.edits/1963767.seqid, newMaxSeqId=1963767, maxSeqId=1963764 2022-11-16 07:38:09,601 INFO  [dabc6-10-xyz:61020-2] handler.UnassignRegionHandler - Closed d773829ad7e76202cccac6fbc314091b 2022-11-16 07:38:10,340 INFO  [0-shortCompactions-0] regionserver.HStore - Starting compaction of [hdfs://c01/hbase/data/default/TABLE01/2eaab01e9bd001727475abf7a4f73053/0/e629d75027ed4da79fd962e645c7a3b4.d773829ad7e76202cccac6fbc314091b->hdfs://c01/hbase/data/default/TABLE01/d773829ad7e76202cccac6fbc314091b/0/e629d75027ed4da79fd962e645c7a3b4-top] into tmpdir=hdfs://c01/hbase/data/default/TABLE01/2eaab01e9bd001727475abf7a4f73053/.tmp, totalSize=939.0 M 2022-11-16 07:38:10,340 DEBUG [0-shortCompactions-0] compactions.Compactor - Compacting e629d75027ed4da79fd962e645c7a3b4.d773829ad7e76202cccac6fbc314091b, keycount=18319191, bloomtype=NONE, size=939.0 M, encoding=FAST_DIFF, compression=NONE, seqNum=1963665, earliestPutTs=1637575074953 2022-11-16 07:38:10,349 DEBUG [0-shortCompactions-1] compactions.Compactor - Compacting e629d75027ed4da79fd962e645c7a3b4.d773829ad7e76202cccac6fbc314091b, keycount=18319191, bloomtype=NONE, size=939.0 M, encoding=FAST_DIFF, compression=NONE, seqNum=1963664, earliestPutTs=1637575074953 2022-11-16 07:40:15,455 DEBUG [dabc6-10-xyz:61020-8] backup.HFileArchiver - Archived from FileableStoreFile, hdfs://c01/hbase/data/default/TABLE01/d188c0c23b5826973511da243e8c892a/0/e629d75027ed4da79fd962e645c7a3b4.d773829ad7e76202cccac6fbc314091b to hdfs://c01/hbase/archive/data/default/TABLE01/d188c0c23b5826973511da243e8c892a/0/e629d75027ed4da79fd962e645c7a3b4.d773829ad7e76202cccac6fbc314091b {code}  " Lock contention when doing multiple parallel preads due to StoreFileReader reuse,13507279,Open,Major,,29/Nov/22 14:58,,,"In HStoreFile, we reuse the StoreFileReader created during HStoreFile initialization when creating a StoreFileScanner for preads: [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java#L545] When using S3 as hbase storage, we noticed this caused lock contention when multiple clients were doing preads in parallel: {noformat} ... ""RpcServer.default.FPBQ.Fifo.handler=38,queue=8,port=16020"" #125 daemon prio=5 os_prio=0 tid=0x00007fc11d83c000 nid=0x73f2 waiting for monitor entry [0x00007fc1154e6000]    java.lang.Thread.State: BLOCKED (on object monitor)         at org.apache.hadoop.fs.FSInputStream.read(FSInputStream.java:73)         - waiting to lock <0x00007fc4c2769660> (a org.apache.hadoop.fs.s3a.S3AInputStream) ... ""RpcServer.default.FPBQ.Fifo.handler=37,queue=7,port=16020"" #124 daemon prio=5 os_prio=0 tid=0x00007fc11d83a000 nid=0x73f1 waiting for monitor entry [0x00007fc1155e7000]    java.lang.Thread.State: BLOCKED (on object monitor)         at org.apache.hadoop.fs.FSInputStream.read(FSInputStream.java:73)         - waiting to lock <0x00007fc4c2769660> (a org.apache.hadoop.fs.s3a.S3AInputStream) ... ""RpcServer.default.FPBQ.Fifo.handler=36,queue=6,port=16020"" #123 daemon prio=5 os_prio=0 tid=0x00007fc11d838000 nid=0x73f0 runnable [0x00007fc1156e8000]    java.lang.Thread.State: RUNNABLE         at java.net.SocketInputStream.socketRead0(Native Method) ... at org.apache.hadoop.fs.s3a.S3AInputStream.reopen(S3AInputStream.java:216)         - locked <0x00007fc4c2769660> (a org.apache.hadoop.fs.s3a.S3AInputStream) ... {noformat}  We should create a new instance of StoreFileReader for each StoreFileScanner when doing preads, instead," [hbase-thirdparty] Set updatePomFile for maven-flatten-plugin,13505354,Resolved,Major,Fixed,22/Nov/22 13:43,23/Nov/22 02:27,, Improve HFileLinkCleaner to validate back reference links ahead the next traverse ,13503681,Resolved,Major,Fixed,18/Nov/22 17:43,20/Nov/22 23:23,2.5.2,"We found a a race in the CleanerChore related to back reference links. When the HFileLinkCleaner runs for a file it can make 2 decisions depending on the file types. - HFiles, The cleaner for HFile deletion only checks if the .links-<> directory is present with files.  - Back reference links, the cleaner checks if the forward link is still available in the data directory. The logic and order how the cleaner checks these 2 files matters. When the back reference is checked first it can remove both the reference and the HFile from the archive, however, when it first runs for the HFile then only the back-reference is removed. In this case, the HFile is only deleted in the next iteration of the CleanerChore, and it could be very slow if the list of files are huge in case of using object store. The goal of this task is to improve traverse of the archived HFile, reusing the list of found back reference files, and immediately apply the checks for the Back reference links." Use java11 in the general check of our jenkins job,13491328,Resolved,Major,Fixed,25/Oct/22 15:17,20/Nov/22 14:55,,In this way we could also bump the version of error prone plugin. Upgrade hbase-thirdparty to 4.1.3 and upgrade Jackson for CVE-2022-42003/42004,13485511,Resolved,Major,Fixed,11/Oct/22 00:35,17/Nov/22 14:33,,"Jackson 2.13.4 fixes CVE-2022-42003 and databind 2.14.0-rc1 fixes CVE-2022-42004. Move jackson.version to 2.13.4. Move jackson.databind.version to 2.14.0-rc1. " [hbase-thirdparty] Release hbase-thirdparty 4.1.3,13499217,Resolved,Major,Fixed,08/Nov/22 03:25,15/Nov/22 15:15,, [hbase-thirdparty] Put up hbase-thirdparty 4.1.3RC1,13501124,Resolved,Major,Fixed,11/Nov/22 13:53,15/Nov/22 15:14,, Skip error prone for hadoop2/3 checkes in our nightly jobs,13501020,Resolved,Major,Fixed,11/Nov/22 04:04,11/Nov/22 06:45,,"We have done error prone check in general checks so we do not need to check it again in other checks, especially after we upgrade to a error prone which only support java 11." Tweak hbase-vote.sh to support hbase-thirdparty,13500742,Resolved,Major,Fixed,09/Nov/22 16:20,10/Nov/22 12:29,,"With a small change, the {{hbase-vote.sh}} script can be used to verify release candidates produced from the hbase-thirdparty repository." [hbase-thirdparty] Put up hbase-thirdparty 4.1.3RC0,13499240,Resolved,Major,Fixed,08/Nov/22 03:34,11/Nov/22 13:53,, [hbase-thirdparty] Use maven flatten plugin to generate final pom,13500926,Resolved,Major,Fixed,10/Nov/22 15:43,11/Nov/22 05:35,, The personality script set wrong hadoop2 check version for branch-2,13499649,Resolved,Major,Fixed,08/Nov/22 10:49,10/Nov/22 05:04,,"We missed a condition while changing the supported hadoop version, which made our branch-2 hadoopcheck skip testing any hadoop2 versions..." Fix spotbugs warnings in hbase-rest Client.getResponseBody,13499701,Resolved,Major,Fixed,08/Nov/22 14:51,10/Nov/22 05:04,, [hbase-thirdparty] Use $revision as placeholder for maven version,13498015,Resolved,Major,Fixed,07/Nov/22 02:22,08/Nov/22 03:24,,To align with our main repo. Recovered replication may be blocked if enabled hbase.separate.oldlogdir.by.regionserver,13500640,Open,Major,,09/Nov/22 07:11,,2.4.15,"In other PR, I got a failed UT {code:java} [ERROR] Failures: [ERROR] org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSWithSeparateOldWALs.killOneMasterRS [ERROR] Run 1: TestReplicationKillMasterRSWithSeparateOldWALs>TestReplicationKillMasterRS.killOneMasterRS:47->TestReplicationKillRS.loadTableAndKillRS:84 Waited too much time for queueFailover replication. Waited 61065ms. [ERROR] Run 2: TestReplicationKillMasterRSWithSeparateOldWALs>TestReplicationKillMasterRS.killOneMasterRS:47->TestReplicationKillRS.loadTableAndKillRS:84 Waited too much time for queueFailover replication. Waited 58864ms. [ERROR] Run 3: TestReplicationKillMasterRSWithSeparateOldWALs>TestReplicationKillMasterRS.killOneMasterRS:47->TestReplicationKillRS.loadTableAndKillRS:84 Waited too much time for queueFailover replication. Waited 57103ms. {code} This should be caused by a bug. If enabled {_}hbase.separate.oldlogdir.by.regionserver{_}, old wals will be moved into different dir by regionserver name like root/oldWALs/server1/wal1 . For recovered replication,  can't convert wal path(like root/oldWALs/wal1) into such paths, and throws FileNotFoundException." [hbase-thirdparty] Bump thirdparty dependencies,13498014,Resolved,Major,Fixed,07/Nov/22 02:15,08/Nov/22 03:23,, [hbase-thirdparty] Release hbase-thirdparty 4.1.2,13484734,Resolved,Major,Fixed,06/Oct/22 09:54,07/Nov/22 13:21,, [hbase-thirdparty] Set version as 4.1.3-SNAPSHOT in prep for the next release,13486491,Resolved,Major,Fixed,16/Oct/22 12:42,07/Nov/22 13:21,, Fix the hadolint errors after HBASE-27456,13494347,Resolved,Major,Fixed,02/Nov/22 14:55,03/Nov/22 11:27,, "The regionserver service process is in, but the hmaster page shows dead",13495494,Open,Major,,04/Nov/22 10:31,,2.3.5,"hadoop3  + hbase 2.3.5 + bucketcache +  jdk8  + scan  hmaster log info 2022-11-03 02:06:14,002 INFO [RegionServerTracker-0] master.RegionServerTracker: RegionServer ephemeral node deleted, processing expiration [dx-pipe-sata674 -pm,16020,1667070800282] 2022-11-03 02:06:14,002 INFO [RegionServerTracker-0] master.ServerManager: Processing expiration of dx-pipe-sata674-pm,16020,1667070800282 on dx-pipe-pt263- pm,16000,1632381868857 2022-11-03 02:06:14,006 INFO [RegionServerTracker-0] assignment.AssignmentManager: Scheduled ServerCrashProcedure pid=4251436 for dx-pipe-sata674-pm,16020,1 667070800282 (carryingMeta=false) dx-pipe-sata674-pm,16020,1667070800282/CRASHED/regionCount=522/lock=java.util.concurrent.locks.ReentrantReadWriteLock@938cb 01[Write locks = 1, Read locks = 0], oldState=ONLINE. 2022-11-03 02:06:14,006 INFO [org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$ServerEventsListenerThread-dx-pipe-pt263-pm,16000,1632381868857] rsgrou p.RSGroupInfoManagerImpl$ServerEventsListenerThread: Updating default servers. 2022-11-03 02:06:14,007 INFO [PEWorker-9] procedure.ServerCrashProcedure: Start pid=4251436, state=RUNNABLE:SERVER_CRASH_START, locked=true; ServerCrashProc edure dx-pipe-sata674-pm,16020,1667070800282, splitWal=true, meta=false 2022-11-03 02:06:14,007 INFO [PEWorker-9] procedure.ServerCrashProcedure: dx-pipe-sata674-pm,16020,1667070800282 had 522 regions   2022-11-03 02:06:14,016 INFO [PEWorker-9] master.SplitLogManager: dead splitlog workers [dx-pipe-sata674-pm,16020,1667070800282] 2022-11-03 02:06:14,016 INFO [PEWorker-9] master.SplitLogManager: Started splitting 3 logs in [hdfs://bigdata-hbase-hdd/hbase/WALs/dx-pipe-sata674-pm,16020, 1667070800282-splitting] for [dx-pipe-sata674-pm,16020,1667070800282]    regionserver log info 2022-11-03 02:05:37,114 WARN [RpcServer.default.FPBQ.Fifo.handler=22,queue=2,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 683273027345 48448d8384bea82dd541_SeqId_6__346590844. This is harmless and can happen in rare cases (see HBASE-8547) 2022-11-03 02:05:37,114 WARN [RpcServer.default.FPBQ.Fifo.handler=43,queue=3,port=16020] hfile.BlockCacheUtil: Cached block contents differ by nextBlockOnDi skSize, the new block has nextBlockOnDiskSize set. Caching new block. 2022-11-03 02:05:37,115 ERROR [RpcServer.default.FPBQ.Fifo.handler=22,queue=2,port=16020] ipc.RpcServer: Unexpected throwable object java.lang.IllegalArgumentException: offset (0) + length (2) exceed the capacity of the array: -1207959040 at org.apache.hadoop.hbase.util.Bytes.explainWrongLengthOrOffset(Bytes.java:832) at org.apache.hadoop.hbase.util.Bytes.toShort(Bytes.java:1125) at org.apache.hadoop.hbase.util.Bytes.toShort(Bytes.java:1111) at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decode(DiffKeyDeltaEncoder.java:439) at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decodeNext(DiffKeyDeltaEncoder.java:527) at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.next(BufferedDataBlockEncoder.java:806) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$EncodedScanner.next(HFileReaderImpl.java:1512) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.next(StoreFileScanner.java:196) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:124) at org.apache.hadoop.hbase.regionserver.StoreScanner.trySkipToNextColumn(StoreScanner.java:917) at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(StoreScanner.java:826) at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:738) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:157) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6794) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6958) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6728) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3323) at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3574) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:44858) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:393) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2022-11-03 02:05:37,116 WARN [RpcServer.default.FPBQ.Fifo.handler=13,queue=3,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 297c0c67dd7840b5829c4dae5342664b_SeqId_4__346614261. This is harmless and can happen in rare cases (see HBASE-8547) 2022-11-03 02:05:37,117 WARN [RpcServer.default.FPBQ.Fifo.handler=13,queue=3,port=16020] hfile.BlockCacheUtil: Caching an already cached block: 68327302734548448d8384bea82dd541_SeqId_6__346656355. This is harmless and can happen in rare cases (see HBASE-8547)  " Tags cannot be written to the hfile during bulkload,13493955,Open,Major,,01/Nov/22 08:08,,,"When I store hdfs file data into hbase through bulkload, I want to give different data different ttl, so I use tags in mapper to create per cell ttl for each cell, but I found that this ttl does not take effect. I have the bulkload driver   {code:java} job.setInputFormatClass(TextInputFormat.class); TextInputFormat.setInputPaths(job, inputFile); job.setOutputFormatClass(HFileOutputFormat2.class); HFileOutputFormat2.setOutputPath(job, outputPath); HFileOutputFormat2.configureIncrementalLoad(job, table, conn.getRegionLocator(TableName.valueOf(tableName))); job.waitForCompletion(true); LoadIncrementalHFiles loader = new LoadIncrementalHFiles(conf); loader.doBulkLoad(outputPath, admin, table, conn.getRegionLocator(TableName.valueOf(tableName))); {code}   and the mapper   {code:java} public class BulkloadTTLTestMapper extends Mapper { public void map(LongWritable key, Text value, Mapper.Context context) throws IOException, InterruptedException { String values = value.toString(); String[] lines = values.split("",""); byte[] rowkey = Bytes.toBytes(lines[0]); ImmutableBytesWritable putRowKey = new ImmutableBytesWritable(rowkey); Put put = new Put(rowkey); Cell cell1 = new KeyValue(Bytes.toBytes(lines[0]), Bytes.toBytes(""d""), Bytes.toBytes(""field1""), HConstants.LATEST_TIMESTAMP, Bytes.toBytes(lines[1]),new Tag[]{new Tag(TagType.TTL_TAG_TYPE, Bytes.toBytes(100000L))}); put.add(cell1); Cell cell2 = new KeyValue(Bytes.toBytes(lines[0]), Bytes.toBytes(""d""), Bytes.toBytes(""field2""), HConstants.LATEST_TIMESTAMP, generateValue(lines[2]),new Tag[]{new Tag(TagType.TTL_TAG_TYPE, Bytes.toBytes(200000L))}); put.add(cell2); context.write(putRowKey, put); } } {code}   I checked the execution steps through debug, and I found that the tags were not written into hfile. By reading the source code, I found that in org.apache.hadoop.hbase.protobuf.ProtobufUtil.toMutation()   {code:java} if (cell.getTagsLength() > 0) {    valueBuilder.setTags(ByteStringer.wrap(cell.getTagsArray(),        cell.getTagsOffset(), cell.getTagsLength())); }{code}   This code was deleted at [issue15198|https://issues.apache.org/jira/browse/HBASE-15198], which made it impossible for me to write tags into hfile. If i just add  {code:java} conf.set(""hbase.client.rpc.codec"", ""org.apache.hadoop.hbase.codec.CellCodecWithTags""){code} It is Useless, because bulkload does not use these Codecs. Only when I add back those two lines of code that were deleted at issue15198, I could write tags into hfile and make per cell ttl take effect. So I want to know is there any other way to help me carry tags in bulkload besides adding these two lines of code back. Thanks.    " Add an admin method to get replication enabled state,13491718,Resolved,Major,Fixed,26/Oct/22 08:55,01/Nov/22 03:27,,"When implementing HBASE-27109, it is a bit surprise to me that there is no way for me to get the enabled state of a replication peer directly through Admin interface, I need to call listReplicationPeers to find out the ReplicationPeerDescription and then get the enabled state. I think we should add a method in Admin interface for this." Use xmllint to parse version and revision in release scripts,13492161,Resolved,Major,Fixed,27/Oct/22 03:56,29/Oct/22 13:10,,It could make our scripts more stable. Update all our python scripts to use python3,13492495,Resolved,Major,Fixed,27/Oct/22 11:49,28/Oct/22 11:03,,"./dev-support/create-release/prepend_changes.py ./dev-support/create-release/prepend_releasenotes.py ./dev-support/submit-patch.py ./dev-support/checkstyle_report.py ./dev-support/checkcompatibility.py ./dev-support/git-jira-release-audit/git_jira_release_audit.py ./dev-support/flaky-tests/findHangingTests.py ./dev-support/flaky-tests/report-flakies.py ./dev-support/gen_redirect_html.py" Spotbugs 4.7.2 report a lot of logging errors when generating report,13491705,Resolved,Major,Fixed,26/Oct/22 07:20,28/Oct/22 10:48,,"Like this {noformat} Unexpected problem occured during version sanity check 11:27:32 Reported exception: 11:27:32 java.lang.AbstractMethodError: org.apache.logging.slf4j.SLF4JServiceProvider.getRequestedApiVersion()Ljava/lang/String; 11:27:32 at org.slf4j.LoggerFactory.versionSanityCheck(LoggerFactory.java:297) 11:27:32 at org.slf4j.LoggerFactory.performInitialization(LoggerFactory.java:141) 11:27:32 at org.slf4j.LoggerFactory.getProvider(LoggerFactory.java:421) 11:27:32 at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:407) 11:27:32 at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:356) 11:27:32 at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:382) 11:27:32 at edu.umd.cs.findbugs.PluginLoader.(PluginLoader.java:113) 11:27:32 at edu.umd.cs.findbugs.DetectorFactoryCollection.getCoreResource(DetectorFactoryCollection.java:353) 11:27:32 at edu.umd.cs.findbugs.SystemProperties.loadPropertiesFromConfigFile(SystemProperties.java:84) 11:27:32 at edu.umd.cs.findbugs.SystemProperties.(SystemProperties.java:67) 11:27:32 at edu.umd.cs.findbugs.DetectorFactoryCollection.(DetectorFactoryCollection.java:57) 11:27:32 at edu.umd.cs.findbugs.workflow.Filter.main(Filter.java:693) {noformat} Checked the dependencies, it uses slf4j-api-2.0.0 and log4j2 2.18.0 together, which may be caused by LOG4J2-3139. In spotbugs 4.7.3 they bumped log4j2 to 2.19.0, which should have fixed the problem. https://github.com/spotbugs/spotbugs/issues/2176 Let's also do an upgrade." TestHeapSize is flaky,13487271,Resolved,Major,Fixed,20/Oct/22 13:18,28/Oct/22 15:33,,"I believe it is just in memory computation, so it is weird that why it can be flaky. Need to dig more." Change the way of bumping version in release scripts,13490051,Resolved,Major,Fixed,24/Oct/22 02:38,25/Oct/22 16:19,,"After HBASE-27434, we can not use 'mvn versions:set' to change the versions, as all the versions are filled with the $revision placeholder. We need to use 'mvn versions:set-property' instead." metrics method removeHistogramMetrics trigger serious memory leak,13487895,Resolved,Major,Fixed,21/Oct/22 02:42,24/Oct/22 11:19,2.4.15,"the method removeHistogramMetrics will cause the metricsMap leak! because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove. !https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png!" Make release scripts can generate CHANGES.md and RELEASENOTES.md for 3.x,13487289,Resolved,Major,Fixed,20/Oct/22 15:21,24/Oct/22 11:30,,"For 3.x, we do not have CHANGES.md and RELEASENOTES.md in source control, so we need to find a new way to generate it and commit it to dist.a.o." Use $revision as placeholder for maven version to make it easier to control the version from command line,13487023,Resolved,Major,Fixed,19/Oct/22 08:10,24/Oct/22 04:23,,"https://stackoverflow.com/questions/10582054/maven-project-version-inheritance-do-i-have-to-specify-the-parent-version https://maven.apache.org/maven-ci-friendly.html " Use jdk 11.0.16 instead of 11.0.16.1 for branch-2.4,13489480,Resolved,Major,Fixed,23/Oct/22 13:37,24/Oct/22 04:31,,"In 2.4.x we still support hadoop 3.2.0, which is still on jetty 9.3.x, which can not parse jva version like 11.0.16.1 https://github.com/eclipse/jetty.project/issues/2090 This causes bunch of UT failures in nightly job for branch-2.4 and finally cause almost all UTs to be in flaky list. Usually for a mature minor release line, we will not bump its hadoop version, so let's downgrade the jdk 11 version to 11.0.16 to fix the nightly and flaky jobs." Upgrade Jettison for CVE-2022-40149/40150,13485512,Resolved,Major,Fixed,11/Oct/22 00:39,11/Oct/22 17:13,,"Jettison versions <= 1.5.0 are subject to CVE-2022-40149 and CVE-2022-40150. Move jettison.version to 1.5.1." Update to hbase-thirdparty 4.1.2,13484845,Resolved,Major,Fixed,06/Oct/22 17:25,11/Oct/22 02:46,2.4.14,Update to hbase-thirdparty 4.1.2 when it is released. Clean up current broken 'n's in our javadoc,13484123,Resolved,Major,Fixed,01/Oct/22 12:39,07/Oct/22 09:27,, Remove 'Remove unhelpful javadoc stubs' spotless rule for now,13484129,Resolved,Major,Fixed,01/Oct/22 14:31,03/Oct/22 15:22,,"Until we fix the spotless issue: https://github.com/diffplug/spotless/issues/1359" DefaultMobStoreCompactor should delete MobStoreFile cleanly when compaction is failed,13486747,Resolved,Major,Fixed,18/Oct/22 03:46,21/Oct/22 11:40,3.0.0-alpha-3,"When compaction is failed, {{DefaultMobStoreCompactor.performCompaction}} deletes the {{MobStoreFile}} which is writing, but for {{OptimizedMode}}, {{DefaultMobStoreCompactor.performCompaction}} may create multiple MobStoreFiles, if compaction is failed, all theses MobStoreFiles are useless and should be deleted altogether. We should better not depend on {{RSMobFileCleanerChore}} to clean them because it is mainly used for archive already compacted MobStoreFiles." metrics method removeHistogramMetrics trigger serious memory leak,13487849,Resolved,Major,Abandoned,21/Oct/22 02:23,21/Oct/22 02:44,2.4.14,"!https://user-images.githubusercontent.com/13758677/196915944-71197086-2d53-4a85-8b5e-0a61441e8f64.png! the method removeHistogramMetrics will cause the metricsMap leak! because the put op in the map is the baseName but the remove is not , the origin code add the histogramSuffixe follow the baseName when remove.   !https://user-images.githubusercontent.com/13758677/196916259-196e3e8a-cde0-4989-8b64-de13b860522d.png!" TestUsersOperationsWithSecureHadoop fails affter HBASE-27411,13486692,Resolved,Major,Fixed,17/Oct/22 19:57,17/Oct/22 20:20,2.5.1, Remove the 'Hadoop 2.x is recommended.' section in our ref guide,13486492,Open,Major,,16/Oct/22 12:55,,,We should move up to hadoop 3.x now Put up hbase-thirdparty 4.1.2RC0,13484739,Resolved,Major,Fixed,06/Oct/22 09:58,16/Oct/22 12:41,, The 'Remove unhelpful javadoc stubs' spotless rule will leave a 'n' instead of '\n',13484122,Resolved,Major,Fixed,01/Oct/22 12:03,12/Oct/22 15:30,,"That's why there are lots of 'n' in our code base... Let me find a way to fix this and clean up all the 'n's." Fix the javadoc for WARCRecord,13484276,Resolved,Major,Fixed,03/Oct/22 15:42,06/Oct/22 10:20,,"It has some special format and after landing HBASE-26899 we format it and lost the format... Let's try to revert it back and use some html tags to keep the format." [hbase-thirdparty] Bump dependency versions in hbase-thirdparty,13484629,Resolved,Major,Fixed,05/Oct/22 14:57,06/Oct/22 09:53,,"There are several security issues in our dependencies, for example https://nvd.nist.gov/vuln/detail/CVE-2022-42004 Let's bump the dependencies." [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 4.1.2,13484738,Resolved,Major,Fixed,06/Oct/22 09:57,07/Oct/22 10:06,, [hbase-thirdparty] Set version as 4.1.2 in master in prep for first RC of 4.1.2,13484737,Resolved,Major,Fixed,06/Oct/22 09:56,06/Oct/22 11:45,, MemStoreFlusher: Cache flush failed for region,13484641,Open,Major,,05/Oct/22 17:36,,2.2.6,"We are running an HBase cluster (Hadoop 3.3.1 + HBase 2.2.6) when clients frequently write a lot of data into this HBase cluster, we got the message ""Cache flush failed for the region"" error log. then got a lot of ""responseTooSlow"" logs. below are the sample logs of the ""Cache flush failed for region"" messages: {code:java} 022-08-09 11:04:05,069 DEBUG [MemStoreFlusher.0] regionserver.HRegion: Flush status journal:     Acquiring readlock on region at 1660067945028     Running coprocessor pre-flush hooks at 1660067945028     Obtaining lock to block concurrent updates at 1660067945028     Preparing flush snapshotting stores in dfab869db13603b7800cf7b33d58a885 at 1660067945028     Finished memstore snapshotting ns1:htable1,77e1422d7b070b9ee3ac9466174655e884d41d87bbe9182e05661cf11d02298b,1653473214632.dfab869db13603b7800cf7b33d58a885., syncing WAL and waiting on mvcc, flushsize=dataSize=28417, getHeapSize=59360, getOffHeapSize=0, getCellsCount=284 at 1660067945028 2022-08-09 11:04:05,070 ERROR [MemStoreFlusher.0] regionserver.MemStoreFlusher: Cache flush failed for region ns1:htable1,77e1422d7b070b9ee3ac9466174655e884d41d87bbe9182e05661cf11d02298b,1653473214632.dfab869db13603b7800cf7b33d58a885. org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=77949378, WAL system stuck?     at org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:145)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:722)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:616)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.sync(AsyncFSWAL.java:593)     at org.apache.hadoop.hbase.regionserver.HRegion.doSyncOfUnflushedWALChanges(HRegion.java:2754)     at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2691)     at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2549)     at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2523)     at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2413)     at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:611)     at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:580)     at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68)     at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:360)     at java.lang.Thread.run(Thread.java:748) 2022-08-09 11:04:05,070 INFO  [MemStoreFlusher.0] hbase.RangerAuthorizationCoprocessor: Unable to get remote Address 2022-08-09 11:04:05,071 DEBUG [MemStoreFlusher.0] regionserver.HRegion: Flush column family: ai of 326f48e574a65d7ba599a68dbf742603 because time of oldest edit=1660064392583 is > 3600000 from now =1660068245071 2022-08-09 11:04:05,072 INFO  [MemStoreFlusher.0] regionserver.HRegion: Flushing 326f48e574a65d7ba599a68dbf742603 1/3 column families, dataSize=111.73 KB heapSize=184.23 KB; ai={dataSize=12.15 KB, heapSize=24.73 KB, offHeapSize=0 B} 2022-08-09 11:04:05,275 WARN  [RpcServer.default.FPBQ.Fifo.handler=42,queue=0,port=16020] ipc.RpcServer: (responseTooSlow): {""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1660067945231"",""responsesize"":""1659"",""method"":""Multi"",""param"":""region\u003d ns1:htable12,a8f9942ef122d7bb0d0b0036cc5d776d030f9c06b7af0ebb2908edd5a4f43b4c,1460489972562.204291859a0abda7305f73ccb03b174c., for 1 act \u003cTRUNCATED\u003e"",""processingtimems"":300043,""client"":""172.16.139.217:35044"",""queuetimems"":0,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1} 2022-08-09 11:04:05,561 WARN  [RpcServer.default.FPBQ.Fifo.handler=14,queue=2,port=16020] ipc.RpcServer: (responseTooSlow): {""call"":""Multi(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$MultiRequest)"",""multi.gets"":0,""starttimems"":""1660067945519"",""responsesize"":""1659"",""method"":""Multi"",""param"":""region\u003d ns1:htable13,a00bd53d,1502528412031.f04f3634f3822a67dccf8286cfe3e19a., for 1 action(s) and 1st row key\u003da0fd50edde8a734b63a39899f4572a8 \u003cTRUNCATED\u003e"",""processingtimems"":300042,""client"":""172.16.139.215:38654"",""queuetimems"":0,""multi.servicecalls"":0,""class"":""HRegionServer"",""multi.mutations"":1} {code}  " "Make ""/prometheus"" endpoint accessible from HBase UI",13484215,Resolved,Minor,Fixed,03/Oct/22 08:41,20/Oct/22 10:52,2.6.0,"Prometheus metrics feature were added in HBASE-20904, but it's not in the UI yet, so the only option to use it is the URL. I would like to make a change in the web UI, so it can be accessed via a dropdown menu there and I would like to include the description option, so metrics can be viewed with or without description." Update downloads.xml for release 2.5.1,13493555,Resolved,Minor,Fixed,29/Oct/22 00:18,29/Oct/22 00:21,, Update downloads.xml for release 2.4.15,13493554,Resolved,Minor,Fixed,29/Oct/22 00:18,29/Oct/22 00:21,, Deprecate getStats and setStatistics in Result,13509319,Open,Minor,,02/Dec/22 21:55,,,"setStatistics is already IA.Private, but it has never been called. It replaced a deprecated addResults method, which was removed in HBASE-14703.  The getter getStats() now always returns a null value, since nothing in the codebase ever calls setStatistics. We should deprecate these methods to keep our API clear and concise." Client meta cache clear by exception metrics are missing some cases,13503620,Resolved,Minor,Fixed,18/Nov/22 16:23,30/Nov/22 18:13,2.4.15,"MetricsConnection has metrics for meta cache clears by server and region, and also metrics by exception type which triggered the clear. The metric by exception type is currently missing at least one instance (in AsyncRequestFutureImpl) where the cache is cleared due to an exception. We should do an audit of cache clear calls and ensure all the appropriate ones are tracked by exception too." Expose table and region storefiles accessed days and size to the metrics,13501203,Open,Minor,,12/Nov/22 17:24,,3.0.0-alpha-4,"At present, we have no metrics to show the hot and cold status of region/table storefiles, but from the perspective of storage cost, users are very concerned about the hot and cold status of their table data. So, it's necessary to expose region/table storefiles accessed days and size to the metrics." Remove protobuf 2 dependencies,13487168,Open,Minor,,19/Oct/22 22:01,,2.4.16,"Protobuf 2 is subject to CVE-2015-5237, CVE-2021-22569, and CVE-2022-3171 and scanners checking compliance with zero tolerance CVE policies will hit on HBase because a dependency on com.google.protobuf:protobuf-java:2.5.0 is still exported by 2.x versions. It is impossible to remove that dependency by upgrade to Protobuf 3 everywhere given our compatibility guidelines but nonetheless it is a problem for downstream consumers of HBase with such security policies. HBase 2 uses Protobuf 3 internally for RPC, in hbase-protocol-shaded. We still depend on some protobuf-java v2.5 classes however because we use the Protobuf 2 compiler to compile the IDL in the backwards compatible hbase-protocol module. Perhaps we can extract and produce a scaffold from protobuf-java v2.5, just enough so the generated classes from the IDL will compile, and ship that scaffold included, so the dependency on protobuf-java 2.5 proper can be dropped. Protobuf is MIT licensed so partial appropriation of the source would be allowable. " Use ReadWriteLock for region scanner readpoint map ,13494218,Resolved,Minor,Fixed,02/Nov/22 04:44,02/Mar/23 05:50,3.0.0-alpha-3,"Currently we manage the concurrency between the RegionScanner and getSmallestReadPoint by synchronizing on the scannerReadPoints object. In our production, we find that many read threads are blocked by this when we have a heavy read load.  we need to get smallest read point when  a. flush a memstore  b. compact memstore/storefile  c. do delta operation like increment/append Usually the frequency of these operations is much less than read requests.  It's a little expensive to use an exclusive lock here because for region scanners, what it need to do is just calcaulating readpoint and putting the readpoint in the scanner readpoint map, which is thread-safe. Multiple read threads can do this in parallel without synchronization. Based on the above consideration, maybe we can replace the synchronized lock with readwrite lock. It will help improve the read performance if the bottleneck is on the synchronization here. !jstack.png!" Add BulkLoad bandwidth throttling,13510732,In Progress,Minor,,08/Dec/22 09:21,,,"#  Background: During bulk load HFile copy, the server performance is affected to prevent the bandwidth of the server from being full. We can design a throttler to limit the speed of copy and thus limit the bandwidth used by copy #  Function:  2.1 Dynamically Updating Traffic Limiting Configurations  2.2 Node copy HFile Traffic Limiting  2.3 Synchronous copy HFile of the Active and Standby Clusters is unlimited #  Mode of Use: hbase.regionserver.bulkload.node.bandwidth is greater than 0 open unit Byte/sec Update the limit value with update_all_config or update_config 'node' #  Effect: // Begin 5M/sec   hbase.regionserver.bulkload.node.bandwidth   5242880   hbase-site.xml // After update_all_config to 10M/sec   hbase.regionserver.bulkload.node.bandwidth   5242880   hbase-site.xml !image-2023-02-02-13-10-06-619.png!" Backups should be able to be restored to a separate filesystem,13514993,Resolved,Minor,Fixed,21/Dec/22 00:21,24/Jan/23 13:39,3.0.0-alpha-3,Currently it's not possible to set the hfile output path for a given restore job. This prevents us from running restore jobs in external yarn clusters. Remove unneeded distcp log cleanup after incremental backups,13514998,Resolved,Minor,Fixed,21/Dec/22 01:07,24/Jan/23 13:39,3.0.0-alpha-3,"During the completion step of incremental backups, the [TableBackupClient|https://github.com/apache/hbase/blob/2c3abae18aa35e2693b64b143316817d4569d0c3/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java#L343-L355] ensures distcp logs are cleaned up. However, [DistCp|https://github.com/apache/hadoop/blob/b87c0ea7ebde3edc312dcc8938809610a914df7f/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java#L465-L476] already ensures that the metafolder, where the distcp logs are stored, is cleaned up via the [CopyCommitter|https://github.com/apache/hadoop/blob/b743d56eb4bf350448bd315540fde4f029175082/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/CopyCommitter.java#L189]. Additionally, when running in an external yarn cluster external to hbase, this causes issues as it assumes a common filesystem. The TableBackupClient cleanup method should be able to be safely removed. e: After digging in to this even more, the `_distcp_log` path used in the `TableBackupClient` is not actually the correct path used by distcp." Fix several problems after HBASE-27304,13502911,Resolved,Minor,Fixed,16/Nov/22 15:11,10/Jan/23 06:55,,"In the HBASE-27304, we support using IP to expose master/rs service to client. But there are several problems that need to be fixed, see #[4732|https://github.com/apache/hbase/pull/4732] for details. This issue is used to track and fix these problems." "NettyHBaseSaslRpcServerHandler.channelRead0 forget to record ""AUTH_FAILED_FOR"" auditlog for an exception.",13511071,Resolved,Minor,Not A Problem,09/Dec/22 13:29,23/Dec/22 09:17,,"In other methods such as SimpleServerRpcConnection.saslReadAndProcess, they always record ""AUTH_FAILED_FOR"" for an exception, and ""AUTH_SUCCESSFUL_FOR"" after task is completed like this: {code:java} private void saslReadAndProcess(ByteBuff saslToken) throws IOException, InterruptedException { ...... } catch (IOException e) { ...... // attempting user could be null RpcServer.AUDITLOG.warn(""{}{}: {}"", RpcServer.AUTH_FAILED_FOR, clientIP, saslServer.getAttemptingUser()); throw e; } ...... if (saslServer.isComplete()) { ...... RpcServer.AUDITLOG.info(RpcServer.AUTH_SUCCESSFUL_FOR + ugi); ...... } } } {code} but NettyHBaseSaslRpcServerHandler.channelRead0 only record ""AUTH_SUCCESSFUL_FOR"" in finishSaslNegotiation, and just throw Exception without record ""AUTH_FAILED_FOR"": {code:java} protected void channelRead0(ChannelHandlerContext ctx, ByteBuf msg) throws Exception { ...... if (saslServer.isComplete()) { conn.finishSaslNegotiation(); ...... } } void finishSaslNegotiation() throws IOException { ...... RpcServer.AUDITLOG.info(RpcServer.AUTH_SUCCESSFUL_FOR + ugi); } {code} So I think an exceptionCaught should be called here: {code:java} public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { LOG.error(""Error when doing SASL handshade, provider={}"", conn.provider, cause); Throwable sendToClient = HBaseSaslRpcServer.unwrap(cause); doResponse(ctx, SaslStatus.ERROR, null, sendToClient.getClass().getName(), sendToClient.getLocalizedMessage()); rpcServer.metrics.authenticationFailure(); String clientIP = this.toString(); // attempting user could be null RpcServer.AUDITLOG.warn(""{}{}: {}"", RpcServer.AUTH_FAILED_FOR, clientIP, conn.saslServer != null ? conn.saslServer.getAttemptingUser() : ""Unknown""); NettyFutureUtils.safeClose(ctx); } {code} " Ensure that the baseStagingDir created by SecureBulkLoadManager has the correct permissions,13515343,Resolved,Minor,Duplicate,23/Dec/22 09:17,23/Dec/22 09:45,,"In the start function of SecureBulkLoadManager, there is the following code segment {code:java} public void start() throws IOException { ...... fs = FileSystem.get(conf); baseStagingDir = new Path(CommonFSUtils.getRootDir(conf), HConstants.BULKLOAD_STAGING_DIR_NAME); ...... if (!fs.exists(baseStagingDir)) { fs.mkdirs(baseStagingDir, PERM_HIDDEN); } } {code} It can be seen that the run function will use the mkdirs to create the path when baseStagingDir does not exist, and the parameters passed in include the path variable baseStagingDir and a permission 700. But we haven't confirmed whether the permission is correctly assigned to the file. The above question is raised because there are two mkdir functions of hadoop, namely {code:java} mkdirs(Path f, FsPermission permission) {code} and {code:java} mkdirs(FileSystem fs, Path dir, FsPermission permission) {code} , and the first one is used here. The permissions of this function will be affected by the underlying umask. Although 700 here will hardly be affected by umask, but I think from a rigorous point of view, we should have one more permission check and permission grant here." Use reflect to read HDFS ReadStatistics,13510709,Resolved,Minor,Won't Fix,08/Dec/22 06:46,20/Dec/22 03:03,,"  {code:java} java.lang.NoSuchMethodError: org.apache.hadoop.hdfs.client.HdfsDataInputStream.getReadStatistics()Lorg/apache/hadoop/hdfs/DFSInputStream$ReadStatistics; at org.apache.hudi.org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.updateInputStreamStatistics(FSDataInputStreamWrapper.java:249) at org.apache.hudi.org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.close(FSDataInputStreamWrapper.java:296) at org.apache.hudi.org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl.closeStreams(HFileBlock.java:1825) at org.apache.hudi.org.apache.hadoop.hbase.io.hfile.HFilePreadReader.close(HFilePreadReader.java:107) at org.apache.hudi.org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.close(HFileReaderImpl.java:1421) at org.apache.hudi.io.storage.HoodieHFileReader.close(HoodieHFileReader.java:218) at org.apache.hudi.table.action.commit.HoodieMergeHelper.runMerge(HoodieMergeHelper.java:152) at org.apache.hudi.table.HoodieSparkCopyOnWriteTable.handleUpdateInternal(HoodieSparkCopyOnWriteTable.java:230) at org.apache.hudi.table.HoodieSparkCopyOnWriteTable.handleUpdate(HoodieSparkCopyOnWriteTable.java:221) at org.apache.hudi.table.action.compact.HoodieCompactor.compact(HoodieCompactor.java:227) at org.apache.hudi.table.action.compact.HoodieCompactor.lambda$compact$57154431$1(HoodieCompactor.java:138) {code}" Add configuration for disabling CleanerChore,13505574,In Progress,Minor,,23/Nov/22 16:13,,,The CleanerChore can be disabled from the shell but not from the configuration. The Cleaner will start with HBase Master and it is not possible to prevent it from the initial start. A configuration property could be added to disable the CleanerChore.  Make Prometheus metrics queryable,13487056,Resolved,Minor,Fixed,19/Oct/22 11:29,12/Dec/22 11:04,,"To provide the same features that JMX has, I would like to implement querying in Prometheus metrics. This includes the *_qry_* URL parameter which can be used with the Prometheus name of the metric." Support replace in GC_OPTS for ZGC,13505283,Resolved,Minor,Fixed,22/Nov/22 09:33,28/Nov/22 16:20,2.4.15,"HBase support replace -Xloggc: for G1 or CMS。ZGC changed the format，like this： {code:java} -Xlog:safepoint,classhisto*=trace,age*,gc*=info:file=:time,tid,tags:filecount=1,filesize=500M{code} Can  we only replace instead of -Xloggc: to support ZGC？ [https://github.com/apache/hbase/blob/master/bin/hbase-daemon.sh#L174] {code:java} if [ -n ""$SERVER_GC_OPTS"" ]; then export SERVER_GC_OPTS=${SERVER_GC_OPTS/""-Xloggc:""/""-Xloggc:${HBASE_LOGGC}""} fi if [ -n ""$CLIENT_GC_OPTS"" ]; then export CLIENT_GC_OPTS=${CLIENT_GC_OPTS/""-Xloggc:""/""-Xloggc:${HBASE_LOGGC}""} fi {code}" Reset sizeOfLogQueue when refresh replication source,13495185,Resolved,Minor,Fixed,04/Nov/22 05:58,27/Nov/22 15:51,3.0.0-alpha-3,"When refresh replication sources, we don't clear the metric. That may cause the value of sizeOfLogQueue metric wrong." Optionally disable sorting directories by size in CleanerChore,13505568,Resolved,Minor,Fixed,23/Nov/22 15:37,25/Nov/22 15:01,,"The CleanerChore computes the size of the directories to start the cleaning with the largest directory first. This computation can take a long time over object stores when the archive directory is huge. Make it configurable to skip the directory sorting in the CleanerChore.  " result of DirectMemoryUtils#getDirectMemorySize may be wrong,13491550,Resolved,Minor,Fixed,26/Oct/22 05:23,23/Nov/22 13:06,3.0.0-alpha-3,"If the parameter is set repeatedly, the latter will take effect. For example, if we set  -Xms30g -Xmx30g -XX:MaxDirectMemorySize=40g -XX:MaxDirectMemorySize=50g the MaxDirectMemorySize will be set as 50g." Remove duplicated config 'hbase.normalizer.merge.min_region_age.days' in hbase-default.xml,13505340,Resolved,Minor,Fixed,22/Nov/22 12:34,23/Nov/22 13:07,2.3.0,'hbase.normalizer.merge.min_region_age.days' are defined in hbase-default.xml twice. Add tool commands list_enabled_tables and list_disabled_tables,13491392,Resolved,Minor,Fixed,26/Oct/22 02:36,23/Nov/22 02:30,3.0.0-alpha-4,"Currently, there is no command line tool to get the all enabled or disabled tables, which can only be seen through the HMaster UI." Optionally limit the amount of plans executed in the Normalizer,13503684,Resolved,Minor,Fixed,18/Nov/22 18:23,22/Nov/22 18:29,,"My company (Hubspot) is starting to use {{{}SimpleRegionNormalizer{}}}. We turn the normalizer switch on for 30 minutes each day, when our database traffic is at a low point. We're using the {{hbase.normalizer.throughput.max_bytes_per_sec}} setting to create a rate limit. I've found that while the {{SimpleRegionNormalizer}} only produces new plans for 30 minutes each day, the plans often take many hours to execute. This leds to region splits, merges, and moves occurring in our HBase clusters during hours we'd prefer them not to. I propose a new setting {{{}hbase.normalizer.plans_size_limit.mb{}}}. This will allow HBase administrators to limit the number of plans processed by a run of {{{}RegionNormalizerWorker{}}}, by forcing it to stop processing new plans once the cumulative region size limits are exceeded. This will give you a way to limit approximately how long it takes to execute the plans. Because the current limit to execute plans is primarily determined by a per-byte rate limit, I propose that the new settings also work on a similar basis. This will make it feasible to reason about how your rate limit and your size limits interact." Search order for locations in HFileLink,13484659,Resolved,Minor,Fixed,05/Oct/22 21:02,05/Nov/22 15:25,,"Found that search order for locations is following the order of these locations added to HFileLink object.    setLocations(originPath, tempPath, mobPath, archivePath); archivePath is the last one to be searched. For most cases, hfile exists in archivePath, so we can move archivePath to the first parameter to avoid unnecessary NN query." Run flaky test job more often,13485959,Resolved,Minor,Fixed,12/Oct/22 18:26,21/Oct/22 06:35,,"We currently run the flaky tests once per 4 hours and keep a backlog of 50 runs. That means it takes a perfect test a bit over 8 days to get back out of being penalized. we regularly are leaving a bunch of executors idle (see attached PNG) and I think we should run the tests more often. we use an executor per branch for a flaky test run. the duration depends on the specific tests that are flagged, but it has a timeout of 2 hours. as an example the master branch tests currently take < 30 minutes (see other attached PNG). " Failure while connecting to zk if HBase is running in standalone mode in a container,13485179,Resolved,Minor,Fixed,07/Oct/22 15:55,11/Oct/22 19:36,,"With [this change|https://issues.apache.org/jira/browse/HBASE-23993] zookeeper will only listen for client connections on 127.0.0.1 in standalone mode. If HBase is running in standalone mode inside a docker container and docker port forwarding is being used to connect to HBase inside container then, any client trying to connect to zk will have destination IP as container's private IP rather than loopback IP. This will cause zk to reject all client connections being initiated from outside the container.  Thus, we need a way to make zk listen for client connections on IP other than loopback. zk already provides a property named `clientPortAddress` to specify the address to listen for client connections. And, we can specify zk properties using `hbase.zookeeper.property.` prefix. Thus, the proposal is to allow user to specify the IP address that zk will listen on using `hbase.zookeeper.property.clientPortAddress` and if its not specified then default to loopback as per current behaviour. This way, the tests will still remain unimpacted and HBase can also be used in standalone mode in a container." Update and clean up bcprov-jdk15on dependency,13484409,Resolved,Minor,Fixed,04/Oct/22 10:41,11/Oct/22 00:28,3.0.0-alpha-4,"{noformat} $ env JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home mvn -T0.5C clean install -DskipTests [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.hbase:hbase-server:jar:3.0.0-alpha-4-SNAPSHOT [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.bouncycastle:bcprov-jdk15on:jar -> duplicate declaration of version (?) @ line 331, column 17 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] {noformat}" "Fixing check for ""description"" request param in JMXJsonServlet.java",13484233,Resolved,Minor,Fixed,03/Oct/22 11:23,06/Oct/22 11:05,2.6.0,"When trying to access the JMX metrics' description via the ""description=true"" URL parameter, any value is accepted. The current version checks only if ""description"" is in the URL parameter, but doesn't check the parameter value.  I would like to fix this via checking if the parameter value is 'true' and showing the description only when this condition is met." Long running ExportSnapshot fails with Can't find hfile Exception.,13484170,Open,Minor,,02/Oct/22 11:37,,,"ExportSnapshot Jobs running for more than destination cluster hbase.master.hfilecleaner.ttl value, are filing with {_}Can't find hfile: in the real or archive folders{_}. Copied HFiles in archive folder is getting deleted at the Destination cluster by SnapshotHFileCleaner cleaner.   # Export snapshot moves archived hfiles files to destination archved folders. # In progress ExportSnapshot manifest will be there in /hbase/.hbase-snapshot/.tmp till it is completed. # in SnapshotHFileCleaner flow, where it is ignoring /hbase/.hbase-snapshot/.tmp directory to find the snapshot reference files, {code:java}   private void refreshCache() throws IOException {   // just list the snapshot directory directly, do not check the modification time for the root   // snapshot directory, as some file system implementations do not modify the parent directory's   // modTime when there are new sub items, for example, S3.   FileStatus[] snapshotDirs = FSUtils.listStatus(fs, snapshotDir,     p -> !p.getName().equals(SnapshotDescriptionUtils.SNAPSHOT_TMP_DIR_NAME)); {code} # As in progress snapshot reference is missed by SnapshotHFileCleaner. TimeToLiveHFileCleaner marks the HFiles older(coped before hbase.master.hfilecleaner.ttl) than hbase.master.hfilecleaner.ttl to delete from in progress ExportSnapshots dir. # This is causing ExportSnapshot to fail at the verification stage.   Workaround: increase hbase.master.hfilecleaner.ttl value to more than the Snapshot ExportSnapshot job run time in the destination cluster.   I think this issue needs to be fixed in SnapshotHFileCleaner flow so that long-running ExportSnapshot jobs can succeed." Fix comment syntax errors,13513283,Resolved,Trivial,Fixed,13/Dec/22 02:33,14/Dec/22 15:33,,"I found some sytax errors in the comments while reading the source code. such as the fallowing examples: at hbase-asyncfs.src.main.java.org.apache.hadoop.hbase.util.RecoverLeaseFSUtils.java(line 95, 121) at hbase-asyncfs.src.main.java.org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput.java(line 87, 107) at hbase-balancer.src.main.java.org.apache.hadoop.hbase.master.balancer.BaseLoadBalancer.java(line 53, 59) ...... In fact, I did a simple scan and there were quite a few errors, although only a few affected the reading. I think maybe we can fix it, even if it's not in a hurry." Add file `.git-blame-ignore-revs` for `git blame`,13507786,Resolved,Trivial,Fixed,01/Dec/22 09:14,01/Dec/22 12:18,,"We introduce spotless to format the code, but it is inconvenient for `git blame` to view the changes.  We can ignore some commits through `--ignore-rev`. git v2.23 support `--ignore-rev` ```bash git config blame.ignoreRevsFile .git-blame-ignore-revs ```" Add a note for RegionMerge tool. ,13503701,Open,Trivial,,18/Nov/22 21:13,,,"Ref: [https://github.com/apache/hbase-operator-tools/blob/master/hbase-tools/README.md] NOTE:  Do not perform region merge operations on phoenix slated tables. It may affect the region boundaries and produce incorrect query results.   " Flaky Test testClone in TestTaskMonitor,13500982,Resolved,Trivial,Fixed,10/Nov/22 21:53,17/Nov/22 14:34,,"{{`testClone`}} is detected as flaky by [[NonDex|https://github.com/TestingResearchIllinois/NonDex]|https://github.com/TestingResearchIllinois/NonDex] since the origin task monitor and the cloned one are represented as JSON objects, which are in a non-deterministic order. " Remove TestRemoteTable.testLimitedScan,13486502,Resolved,Trivial,Fixed,16/Oct/22 15:57,17/Oct/22 07:44,2.4.15,"The TestRemoteTable.testLimitedScan was originally added in HBASE-24267 for 3.0.0-alpha-1 but with the backport of HBASE-27401 the test was added to branch-2.4, branch-2.5, and branch-2 where the limit support is not available. This causes test failure on these branches." resource leak for store flush during high load,13519908,Open,Blocker,,17/Jan/23 14:19,,2.4.15,"2023-01-17 14:01:00,294 WARN  [Close-WAL-Writer-3] asyncfs.FanOutOneBlockAsyncDFSOutputHelper: complete file /hbase/WALs/prod-storage-4,16020,1673962204907/prod-storage-4%2C16020%2C1673962204907.1673964006883 not finished, retry = 0 2023-01-17 14:08:02,681 ERROR [regionserver/prod-storage-4:16020-shortCompactions-0] util.ResourceLeakDetector: iter(StoreFlusher.java:68)     org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)     org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:992)     org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2358)     org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2837)     org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2579)     org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2551)     org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2421)     org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:588)     org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:558)     org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:64)     org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:340)" Rename TestConnectionImplementation in hbase-it to fix javadoc failure,13521183,Resolved,Blocker,Fixed,24/Jan/23 22:41,25/Jan/23 03:01,2.4.16,"discussed during release of 2.5.3RC0 [https://lists.apache.org/thread/b34lgz3yy8vkv4fbbxj4mvtjyjrp4m6p] I found a javadoc problem introduced by HBASE-27498 with the same test class shared the same package prefix such that the javadoc failed with a unclear java.lang.NullPointerException. - hbase-it/src/test/java/org/apache/hadoop/hbase/client/TestConnectionImplementation.java - hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestConnectionImplementation.java after renaming hbase-it/src/test/java/org/apache/hadoop/hbase/client/TestConnectionImplementation.java to hbase-it/src/test/java/org/apache/hadoop/hbase/client/TestConnectionImplementationCacheMasterState.java should fix this issue." Upgrade hbase-thirdparty to 4.1.4,13519971,Resolved,Blocker,Fixed,18/Jan/23 02:53,21/Jan/23 09:03,,"There are some security fixes, and also, HBASE-27505 is an important change which fixed the 'broken' pom in thirdparty 4.1.3." CatalogJanitor can cause data loss due to errors during cleanMergeRegion,13520137,Resolved,Blocker,Fixed,19/Jan/23 04:25,20/Jan/23 18:05,,"In CatalogJanitor.cleanMergeRegion, there is the following check: {code:java} HRegionFileSystem regionFs = null; try { regionFs = HRegionFileSystem.openRegionFromFileSystem(this.services.getConfiguration(), fs, tabledir, mergedRegion, true); } catch (IOException e) { LOG.warn(""Merged region does not exist: "" + mergedRegion.getEncodedName()); } if (regionFs == null || !regionFs.hasReferences(htd)) { .. do the cleanup .. } {code}   I think the assumption here is that an IOException would only be thrown if a region doesn't exist? We had a very poorly timed NameNode failover, during CatalogJanitor run, after a merge. The NameNode failover caused the openRegionFromFileSystem call to fail, which logged: {code:java} WARN org.apache.hadoop.hbase.master.janitor.CatalogJanitor: Merged region does not exist: 32c71224852c5a4b94a3ba271b4fcb15 {code} This region did in fact exist and had not fully compacted, so there were still some lingering reference files. The cleanup process moves the parent regions to the archive directory, but the default TTL for those files in the archive directory is only 5 minutes. After that they are cleaned up and the data is now unrecoverable. This resulted in FileNotFoundExceptions trying to read or open this region. Our only course of action was to move the lingering reference files aside, so the data is unrecoverable." Fix UT failures after HBASE-27632 goes in,13528244,Resolved,Critical,Duplicate,13/Mar/23 14:06,18/Mar/23 13:53,,"Need to fix this. {noformat} 2023-03-13T04:16:20,762 ERROR [RS_REFRESH_PEER-regionserver/df65750736d7:0-0.replicationSource,2.replicationSource.wal-reader.df65750736d7%2C35391%2C1678680878451,2] regionserver.HRegionServer(2747): ***** ABORTING region server df65750736d7,35391,1678680878451: Unexpected exception in RS_REFRESH_PEER-regionserver/df65750736d7:0-0.replicationSource,2.replicationSource.wal-reader.df65750736d7%2C35391%2C1678680878451,2 ***** java.lang.NullPointerException: null at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.switched(ReplicationSourceWALReader.java:224) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.SerialReplicationSourceWALReader.readWALEntries(SerialReplicationSourceWALReader.java:114) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:178) ~[classes/:?] at org.apache.hadoop.hbase.replication.regionserver.SerialReplicationSourceWALReader.run(SerialReplicationSourceWALReader.java:35) ~[classes/:?] {noformat} And this {noformat} java.io.EOFException: EOF while reading message size at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.parseDelimitedFrom(ProtobufUtil.java:3730) at org.apache.hadoop.hbase.regionserver.wal.ProtobufWALStreamReader.next(ProtobufWALStreamReader.java:56) at org.apache.hadoop.hbase.wal.WALStreamReader.next(WALStreamReader.java:42) at org.apache.hadoop.hbase.wal.TestWALOpenAfterDNRollingStart.test(TestWALOpenAfterDNRollingStart.java:126) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:829) {noformat}" Region replica replication sometimes orphans WAL queue entries during recovery,13528235,Open,Critical,,13/Mar/23 12:36,,2.5.0,"Running with timeline-consistent read replicas and {{hbase.region.replica.replication.enabled=true}}, we're seeing some region servers have WAL queue entires that never clear. This appears to correlate with SCP and recovery of replication queues. The result is WALs that build up, consuming dangerous amounts of space on HDFS. Remediation requires disabling and removing the {{region_replica_replication}} peer, which forces an impacted region server to abort with the message ""Failed to operate on replication queue"". We then delete the zk entry, which unlocks the WAL and the cleaner chore can sweep them." RS may be OutOfMemory when run large mob scan,13529927,Open,Critical,,24/Mar/23 08:01,,,"When run a large mob scan, the memory used by MobStoreScanner#referencedMobCells will continue to increase until the end of the scanner request，if current store have large data, likely to cause OutOfMemory." PB's parseDelimitedFrom can successfully return when there are not enough bytes,13526195,Resolved,Critical,Fixed,26/Feb/23 06:58,28/Feb/23 02:10,,"Found this when writing some UTs for parsing partial header and trailer, WALHeader.parseDelimitedFrom can return successfully when there are only two bytes in the stream(only the length, actually). So I know why in the past we have a followingKvCount == 0 check in ProtobufLogReader, as we just want to prevent the partial PB message. This is a very critial problem, for me I think we should provide our own implementation of parseDelimitedFrom for some critical usages, for example, when reading WAL entries. If there are not enough data, we just throw exception out instead of returning a partial PB message." Should not return false when WALKey has no following KVs while reading WAL file,13524992,Resolved,Critical,Fixed,16/Feb/23 09:47,26/Feb/23 08:36,,"In the current implementation {code} if (!walKey.hasFollowingKvCount() || 0 == walKey.getFollowingKvCount()) { LOG.trace(""WALKey has no KVs that follow it; trying the next one. current offset={}"", this.inputStream.getPos()); seekOnFs(originalPosition); return false; } {code} Here we just return false, seek back to the original position. I think the intention here is that it means the data is not available yet and we should try to read them next time. But this class is not only used for replication, it is also used by splitting, return false will make the reader.next return null, and WALSplitter will think the WAL file has been fully read and complete the splitting task. If there are still other WAL entries in the file, we will miss reading them and cause data loss. And in fact, the following kv count is a field in a pb message, so it is impossible that now it is 0 but later it will become a value greater than 0, as we use writeDelimited to write the message, there is a size in front of the message, if we read it successfully, we can make sure the message is complete/ So seeking back in replication is also an useless operation. So here we propose we still need to return true here, so the upper layer are free to skip or not, but they still need to read other entries." Zero length value would cause value compressor read nothing and not advance the position of the InputStream,13524493,Resolved,Critical,Fixed,13/Feb/23 15:13,15/Feb/23 05:11,,"This is a code sniff from the discussion of HBASE-27073 {code} public static void main(String[] args) throws Exception { CompressionContext ctx = new CompressionContext(LRUDictionary.class, false, false, true, Compression.Algorithm.GZ); ValueCompressor compressor = ctx.getValueCompressor(); byte[] compressed = compressor.compress(new byte[0], 0, 0); System.out.println(""compressed length: "" + compressed.length); ByteArrayInputStream bis = new ByteArrayInputStream(compressed); int read = compressor.decompress(bis, compressed.length, new byte[0], 0, 0); System.out.println(""read length: "" + read); System.out.println(""position: "" + (compressed.length - bis.available())); {code} And the output is {noformat} compressed length: 20 read length: 0 position: 0 {noformat} So it turns out that, when compressing, an empty array will still generate some output bytes but while reading, we will skip reading anything if we find the output length is zero, so next time when we read from the stream, we will start at a wrong position..." Also clear the Dictionary when resetting when reading compressed WAL file,13523746,Resolved,Critical,Fixed,08/Feb/23 09:53,11/Feb/23 12:21,,"After trying several times, now I can reproduce a critical problem when reading compressed WAL file in replication. The problem is about how we construct the LRUDictionary when reset the WALEntryStream. In the current design, we will not reconstruct the LRUDictionary when reseting, but when reading again, we will call addEntry directly to add 'new' word into the dict, which will mess up the dict and cause data corruption. I've implemented a UT to simulate reading partial WAL entry in replication, with the current code base, after reseting and reading again, we will stuck there for ever. -The fix is to always use findEntry when constructing the dict when reading, so we will not mess things up.- It turns out that the above solution does not work. Another possible fix is to always reconstruct the dict after reseting, we will also clear the dict and reconstruct it again. But it is less efficient as we need to read from the beginning to the position we want to seek to, instead of seek to the position directly, especially when tailing the WAL file which is currently being written. And notice that, the UT can only reproduce the problem in local file system, on HDFS, the available method is implemented so if there is not enough data, we will throw EOFException earlier before parsing cells with the compression decoder, so we will not add duplicated word to dict. But in real world, it is possible that even if there are enough data to read, we could hit an IOException while reading and lead to the same problem described above. And while fixing, I also found another problem that in TagConressionContext and CompressionContext, we use the result of InputStream incorrectly, as we just cast it to byte and test whether it is -1 to determine whether the field is in the dict. The return value of InputStream.read is an int, and it will return -1 if reaches EOF, but here we will consider it as not in dict... We should throw EOFException instead. I'm not sure whether fix this can also fix HBASE-27073 but let's have a try first." Remove checked in generated PB files,13523538,Resolved,Critical,Invalid,07/Feb/23 17:27,09/Feb/23 04:35,,"Now that we have new PB maven plugin, there is no need to have the PB files checked in to the repo.The reason this is done is to ease up developer env setup." Incremental backups should re-use splits from last full backup,13525794,Resolved,Major,Fixed,22/Feb/23 22:49,24/Jan/25 18:04,,"All incremental backups require a previous full backup. Full backups use snapshots + ExportSnapshot, which includes exporting the SnapshotManifest. The SnapshotManifest includes all of the regions in the table during the snapshot. Incremental backups use WALPlayer to turn new HLogs since last backup into HFiles. This uses HFileOutputFormat2, which writes HFiles along the split boundaries of the tables at the time that it runs. Active clusters may have regions split and merge over time, so the split boundaries of incremental backup hfiles may not align to the original full backup. This means we need to use MapReduceHFileSplitterJob during restore in order to read all of the hfiles for all of the incremental backups and re-split them based on the restored table. * So let's say a cluster with regions A, B, C does a full backup. Data in that backup will be segmented into those 3 regions. * Over time the cluster splits and merges and we end up with totally different regions D, E, F. An incremental backup occurs, and the data will be segmented into those 3 regions.Later the cluster splits those 3 regions so we end up with new regions G, H, I, J, K, L.  Then next incremental backup goes with that When we go to restore this cluster, it'll pull the full backup and the 2 incrementals. The full backup will get restored first, so the new table will have regions A, B, C.  Then all of the hfiles from the incrementals will be combined together and run through MapReduceHFileSplitterJob. This will cause all of those data files to get re-partitioned based on the A, B, C regions of the newly restored table (based on the full backup). This splitting process is expensive on a large cluster. We could skip it entirely if incremental backups used the RegionInfos from the original full backup SnapshotManifest as the splits for WALPlayer. Therefore, all incremental backups will use the same splits as the original full backup. The resulting hfiles could be directly bulkloaded without any split process, reducing cost and time of restore. One other benefit is that one could use the combination of a full backup + all incremental backups as an input to their own mapreduce job. This impossible now because all of the backups will have HFiles with different start/end keys which don't align to a common set of splits for combining into ClientSideRegionScanner." NPE in TestBasicWALEntryStreamFSHLog.testEOFExceptionInOldWALsDirectory,13529082,Resolved,Major,Fixed,18/Mar/23 13:55,24/Mar/23 10:03,,"https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/7985/testReport/junit/org.apache.hadoop.hbase.replication.regionserver/TestBasicWALEntryStreamFSHLog/testEOFExceptionInOldWALsDirectory_1__isCompressionEnabled_true_/ {noformat} java.lang.NullPointerException at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.findArchivedLog(AbstractFSWALProvider.java:488) at org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testEOFExceptionInOldWALsDirectory(TestBasicWALEntryStream.java:771) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:750) {noformat}" Upgrade Curator version to 5.4.0 and Zookeeper to 3.8.1,13523503,Resolved,Major,Duplicate,07/Feb/23 12:48,07/Jan/25 06:42,, Ignore invalid hostname when getNetworkInterfaces,13525816,Resolved,Major,Fixed,23/Feb/23 03:56,30/Dec/24 14:46,,"TestRegionServerHostname#testRegionServerHostname timeout in my CI pipeline. !image-2023-02-23-11-54-42-036.png|width=503,height=98! That's because NetworkInterface.getNetworkInterfaces get kube-ipvs0(k8s ipvs) with so many InetAddresses. !image-2023-02-23-11-55-28-798.png|width=662,height=44!" "hfile split occurs during bulkload, the new HFile file does not specify favored nodes",13529174,Resolved,Major,Fixed,20/Mar/23 05:34,30/Dec/24 14:49,,"## BulkloadHFilesTool.class /** * Copy half of an HFile into a new HFile. */ private static void copyHFileHalf(Configuration conf, Path inFile, Path outFile, Reference reference, ColumnFamilyDescriptor familyDescriptor) throws IOException { FileSystem fs = inFile.getFileSystem(conf); CacheConfig cacheConf = CacheConfig.DISABLED; HalfStoreFileReader halfReader = null; StoreFileWriter halfWriter = null; try { ReaderContext context = new ReaderContextBuilder().withFileSystemAndPath(fs, inFile).build(); StoreFileInfo storeFileInfo = new StoreFileInfo(conf, fs, fs.getFileStatus(inFile), reference); storeFileInfo.initHFileInfo(context); halfReader = (HalfStoreFileReader) storeFileInfo.createReader(context, cacheConf); storeFileInfo.getHFileInfo().initMetaAndIndex(halfReader.getHFileReader()); Map fileInfo = halfReader.loadFileInfo(); int blocksize = familyDescriptor.getBlocksize(); Algorithm compression = familyDescriptor.getCompressionType(); BloomType bloomFilterType = familyDescriptor.getBloomFilterType(); HFileContext hFileContext = new HFileContextBuilder().withCompression(compression) .withChecksumType(StoreUtils.getChecksumType(conf)) .withBytesPerCheckSum(StoreUtils.getBytesPerChecksum(conf)).withBlockSize(blocksize) .withDataBlockEncoding(familyDescriptor.getDataBlockEncoding()).withIncludesTags(true) .withCreateTime(EnvironmentEdgeManager.currentTime()).build(); *halfWriter = new StoreFileWriter.Builder(conf, cacheConf, fs).withFilePath(outFile)* *.withBloomType(bloomFilterType).withFileContext(hFileContext).build();* HFileScanner scanner = halfReader.getScanner(false, false, false); scanner.seekTo(); ...   When hfile splitting occurs during bulkload, the new HFile file does not specify favored nodes, which will affect the locality of data. Internally, we implemented a version of the code that allows us to specify the favored nodes of the split HFile in copyHFileHalf() to avoid compromising locality" Enhancements for the persistent cache,13529657,Resolved,Major,Delivered,22/Mar/23 18:06,17/Dec/24 11:10,,"Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache or when the region is moved and the blocks from that region are evicted (or not evicted). The Hfile is kept in the prefetch list forever and over time the prefetch list would have all the files of the cluster and the prefetch would never be executed. This change aims to update the prefetched list of HFiles upon block eviction.  " Get slow/large log response that matched the ‘CLIENT_IP' without client port,13524507,Resolved,Major,Fixed,13/Feb/23 17:07,14/Nov/24 08:32,2.4.14,"'get_largelog_responses' and 'get_slowlog_responses' support filter the records with the given client by 'CLIENT_IP', but user has to provide the client ip and client port both. The client uses an ephemeral port mostly, there will be a better user experience if 'CLIENT_IP' without port is supported, then all the records matched the client ip will be returned." Upgrade mockito to 4.x,13521846,Resolved,Major,Fixed,28/Jan/23 08:44,02/Feb/23 14:40,,"Mockito 2.28.2 is release May 29, 2019, which is very old now. Let's upgrade to the latest 4.x version, as mockito 5.0.0 requires java 11, which is not suitable for us." Clean up ScanMetrics API,13530142,Open,Major,,26/Mar/23 19:28,,,"ScanMetrics object exposes public instance variables for all metrics. For example, ScanMetrics.countOfRPCcalls. This is not standard API design in java or in hbase, and requires suppressing VisibilityModifier checkstyle warnings. We should clean this up, but would require major version changes since it's part of public API" Support Ozone as a WAL backing storage,13529336,Open,Major,,21/Mar/23 01:33,,,"As discussed in the [thread|https://lists.apache.org/thread/tcrp8vxxs3z12y36mpzx35txhpp7tvxv], we'd like to make HBase workloads possible on Ozone. This feature is to be built on top of # HDDS-7593 (support hsync and lease recovery in Ozone), and # HADOOP-18671 (Add recoverLease(), setSafeMode(), isFileClosed() APIs to FileSystem). " Exclude the older versions of netty pulling from Hadoop dependencies,13527613,Reopened,Major,,08/Mar/23 09:53,,,"Currently the netty version of 3.10.6 is getting pulled from hdfs dependencies and sonatype kind of tools reporting the CVEs in HBase. To get rid of this better to exclude netty where hdfs or mapred client jars used. * org.apache.hbase : hbase-it : jar : tests : 2.5.2 ** org.apache.hadoop : hadoop-mapreduce-client-core : 3.2.2 *** io.netty : netty : 3.10.6.final ** org.apache.hbase : hbase-endpoint : 2.5.2 *** org.apache.hadoop : hadoop-hdfs : jar : tests : 3.2.2 **** io.netty : netty : 3.10.6.final *** org.apache.hadoop : hadoop-hdfs : 3.2.2 **** io.netty : netty : 3.10.6.final * org.apache.hadoop : hadoop-mapreduce-client-jobclient : 3.2.2 ** io.netty : netty : 3.10.6.final ** org.apache.hadoop : hadoop-mapreduce-client-common : 3.2.2 *** io.netty : netty : 3.10.6.final * org.apache.hadoop : hadoop-mapreduce-client-jobclient : jar : tests : 3.2.2 ** io.netty : netty : 3.10.6.final * org.apache.hadoop : hadoop-mapreduce-client-hs : 3.2.2 ** io.netty : netty : 3.10.6.final ** org.apache.hadoop : hadoop-mapreduce-client-app : 3.2.2 *** io.netty : netty : 3.10.6.final *** org.apache.hadoop : hadoop-mapreduce-client-shuffle : 3.2.2 **** io.netty : netty : 3.10.6.final" Connection and Request Attributes,13525442,Resolved,Major,Fixed,20/Feb/23 14:28,29/Mar/24 15:38,,"Currently we have the ability to set Operation attributes, via Get.setAttribute, etc. It would be useful to be able to set attributes at the request and connection level. These levels can result in less duplication. For example, send some attributes once per connection instead of for every one of the millions of requests a connection might send. Or send once for the request, instead of duplicating on every operation in a multi request. Additionally, the Connection and RequestHeader are more globally available on the server side. Both can be accessed via RpcServer.getCurrentCall(), which is useful in various integration points – coprocessors, custom queues, quotas, slow log, etc. Operation attributes are harder to access because you need to parse the raw Message into the appropriate type to get access to the getter. I was thinking adding two new methods to Connection interface: - setAttribute (and getAttribute/getAttributes) - setRequestAttributeProvider Any Connection attributes would be set onto the ConnectionHeader during initialization. The RequestAttributeProvider would be called when creating each RequestHeader. An alternative to setRequestAttributeProvider would be to add this into HBaseRpcController, which can already be customized via site configuration. " Implement a tool to migrate replication peer data between different storage implementation,13528901,Resolved,Major,Fixed,17/Mar/23 05:40,17/Apr/23 14:53,,"Replication peer data is usually stable unless you manually modify it, so it is OK to not migrate automatically. Instead, we could provide a tool to migrate the replication peer data. And after migration, users can use online configuration change or via a cluster a restart to load the new configuration." Fix mTLS client hostname verification,13526338,Resolved,Major,Fixed,27/Feb/23 13:09,01/Mar/23 11:21,3.0.0-alpha-3,"The exception what I get: {noformat} 23/02/22 15:18:06 ERROR tls.HBaseTrustManager: Failed to verify host address: 127.0.0.1 javax.net.ssl.SSLPeerUnverifiedException: Certificate for <127.0.0.1> doesn't match any of the subject alternative names: [***] at org.apache.hadoop.hbase.io.crypto.tls.HBaseHostnameVerifier.matchIPAddress(HBaseHostnameVerifier.java:144) at org.apache.hadoop.hbase.io.crypto.tls.HBaseHostnameVerifier.verify(HBaseHostnameVerifier.java:117) at org.apache.hadoop.hbase.io.crypto.tls.HBaseTrustManager.performHostVerification(HBaseTrustManager.java:143) at org.apache.hadoop.hbase.io.crypto.tls.HBaseTrustManager.checkClientTrusted(HBaseTrustManager.java:97) ... 23/02/22 15:18:06 ERROR tls.HBaseTrustManager: Failed to verify hostname: localhost javax.net.ssl.SSLPeerUnverifiedException: Certificate for doesn't match any of the subject alternative names: [***] at org.apache.hadoop.hbase.io.crypto.tls.HBaseHostnameVerifier.matchDNSName(HBaseHostnameVerifier.java:159) at org.apache.hadoop.hbase.io.crypto.tls.HBaseHostnameVerifier.verify(HBaseHostnameVerifier.java:119) at org.apache.hadoop.hbase.io.crypto.tls.HBaseTrustManager.performHostVerification(HBaseTrustManager.java:171) at org.apache.hadoop.hbase.io.crypto.tls.HBaseTrustManager.checkClientTrusted(HBaseTrustManager.java:97) ... 23/02/22 15:18:06 WARN ipc.NettyRpcServer: Connection /100.100.124.2:47109; caught unexpected downstream exception. org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException: Failed to verify both host address and host name at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:499) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:499) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:397) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.lang.Thread.run(Thread.java:750) Caused by: javax.net.ssl.SSLHandshakeException: Failed to verify both host address and host name at sun.security.ssl.Alert.createSSLException(Alert.java:131) at sun.security.ssl.TransportContext.fatal(TransportContext.java:324) at sun.security.ssl.TransportContext.fatal(TransportContext.java:267) at sun.security.ssl.TransportContext.fatal(TransportContext.java:262) at sun.security.ssl.CertificateMessage$T12CertificateConsumer.checkClientCerts(CertificateMessage.java:700) at sun.security.ssl.CertificateMessage$T12CertificateConsumer.onCertificate(CertificateMessage.java:411) at sun.security.ssl.CertificateMessage$T12CertificateConsumer.consume(CertificateMessage.java:375) at sun.security.ssl.SSLHandshake.consume(SSLHandshake.java:377) at sun.security.ssl.HandshakeContext.dispatch(HandshakeContext.java:444) at sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:981) at sun.security.ssl.SSLEngineImpl$DelegatedTask$DelegatedAction.run(SSLEngineImpl.java:968) at java.security.AccessController.doPrivileged(Native Method) at sun.security.ssl.SSLEngineImpl$DelegatedTask.run(SSLEngineImpl.java:915) at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler.runDelegatedTasks(SslHandler.java:1549) at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler.unwrap(SslHandler.java:1395) at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler.decodeJdkCompatible(SslHandler.java:1236) at org.apache.hbase.thirdparty.io.netty.handler.ssl.SslHandler.decode(SslHandler.java:1285) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:529) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:468) ... 15 more Caused by: java.security.cert.CertificateException: Failed to verify both host address and host name at org.apache.hadoop.hbase.io.crypto.tls.HBaseTrustManager.performHostVerification(HBaseTrustManager.java:175) at org.apache.hadoop.hbase.io.crypto.tls.HBaseTrustManager.checkClientTrusted(HBaseTrustManager.java:97) at sun.security.ssl.CertificateMessage$T12CertificateConsumer.checkClientCerts(CertificateMessage.java:682) ... 29 more Caused by: javax.net.ssl.SSLPeerUnverifiedException: Certificate for doesn't match any of the subject alternative names: [***] at org.apache.hadoop.hbase.io.crypto.tls.HBaseHostnameVerifier.matchDNSName(HBaseHostnameVerifier.java:159) at org.apache.hadoop.hbase.io.crypto.tls.HBaseHostnameVerifier.verify(HBaseHostnameVerifier.java:119) at org.apache.hadoop.hbase.io.crypto.tls.HBaseTrustManager.performHostVerification(HBaseTrustManager.java:171) ... 31 more {noformat} The connection was made from {{100.100.124.2:47109}}, however it tried to verify the certificate with {{localhost/127.0.0.1}}." Refactoring the long tryAdvanceEntry method in WALEntryStream,13528402,Resolved,Major,Fixed,14/Mar/23 10:48,15/Mar/23 13:51,,"Let's make it more readable and add more logs, for debugging." Shutdown zookeeper logs coming via ReadOnlyZKClient when hbase shell started,13524267,Resolved,Major,Not A Problem,10/Feb/23 17:45,11/Jun/24 21:01,,"When hbase shell with HBase 2.5.2 started there is too much logging of zk connection realated, classpaths etc.  Even though we enabled ERROR log level for zookeeper package. {noformat} 2023-02-10 17:34:25,211 INFO  [ReadOnlyZKClient-host1:2181,host2:2181,host3:2181@0x15c16f19] zookeeper.ZooKeeper: Client environment:zookeeper.version=3.5.9-5-a433770fc7b303332f10174221799495a26bbca2, built on 02/07/2023 13:02 GMT 2023-02-10 17:34:25,212 INFO  [ReadOnlyZKClient-host1:2181,host2:2181,host3:2181@0x15c16f19] zookeeper.ZooKeeper: Client environment:host.name=host1 2023-02-10 17:34:25,212 INFO  [ReadOnlyZKClient-host1:2181,host2:2181,host3:2181:2181@0x15c16f19] zookeeper.ZooKeeper: Client environment:java.version=1.8.0_352 2023-02-10 17:34:25,212 INFO  [ReadOnlyZKClient-host1:2181,host2:2181,host3:2181@0x15c16f19] zookeeper.ZooKeeper: Client environment:java.vendor=Red Hat, Inc. 2023-02-10 17:34:25,212 INFO  [ReadOnlyZKClient-host1:2181,host2:2181,host3:2181@0x15c16f19] zookeeper.ZooKeeper: Client environment:java.home=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.352.b08-2.el7_9.x86_64/jre {noformat} Better to change the  org.apache.hadoop.hbase.zookeeper package log level to error. {noformat} # Set logging level to avoid verboseness org.apache.logging.log4j.core.config.Configurator.setAllLevels('org.apache.zookeeper', log_level) org.apache.logging.log4j.core.config.Configurator.setAllLevels('org.apache.hadoop', log_level) org.apache.logging.log4j.core.config.Configurator.setAllLevels('org.apache.hadoop.hbase.zookeeper', log_level) {noformat}" User metrics for filtered and read rows are too expensive,13527871,Open,Major,,09/Mar/23 19:22,,,"MetricsUserAggregateImpl has a pattern like this: {code:java} String user = getActiveUser(); if (user != null) { MetricsUserSource userSource = getOrCreateMetricsUser(user); incrementFilteredReadRequests(userSource); } {code} So every update involves a getOrCreate call, which does a ConcurrentHashMap lookup. This overhead is not too bad for most requests, because it's just executed once per request (i.e. updatePut gets called once at the end, though multi's it happens for every action). For updateFilteredReadRequests and updateReadRequestCount, these are currently called in RegionScannerImpl for every row scanned or filtered.  Doing the map lookup over and over adds up. Profiling the regionserver under load, I see over 5% of the time spent updating these metrics. We should try to collect these metrics maybe in the RpcCallContext, and the translate into user metrics once at the end of the request. Or otherwise find a way to minimize querying the ConcurrentHashMap multiple times in the context of a request. Maybe we should actually stash the MetricsUserSource in the RpcCallContext so that all user metrics only need to do the lookup once, even for multi's." Inconsistent synchronization in MetricsUserSourceImpl,13530143,Resolved,Major,Fixed,26/Mar/23 19:30,31/Mar/23 14:09,,"Picked up by spotbugs:   ||Code||Warning|| |IS|Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto; locked 50% of time| | |[Bug type IS2_INCONSISTENT_SYNC (click for details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.appendHisto Synchronized 50% of the time Unsynchronized access at MetricsUserSourceImpl.java:[line 253] Synchronized access at MetricsUserSourceImpl.java:[line 146]| |IS|Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto; locked 50% of time| | |[Bug type IS2_INCONSISTENT_SYNC (click for details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.getHisto Synchronized 50% of the time Unsynchronized access at MetricsUserSourceImpl.java:[line 241] Synchronized access at MetricsUserSourceImpl.java:[line 141]| |IS|Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto; locked 50% of time| | |[Bug type IS2_INCONSISTENT_SYNC (click for details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.incrementHisto Synchronized 50% of the time Unsynchronized access at MetricsUserSourceImpl.java:[line 247] Synchronized access at MetricsUserSourceImpl.java:[line 145]| |IS|Inconsistent synchronization of org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto; locked 50% of time| | |[Bug type IS2_INCONSISTENT_SYNC (click for details)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5067/7/artifact/yetus-general-check/output/new-spotbugs-hbase-hadoop-compat.html#IS2_INCONSISTENT_SYNC] In class org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl Field org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl.scanTimeHisto Synchronized 50% of the time Unsynchronized access at MetricsUserSourceImpl.java:[line 264] Synchronized access at MetricsUserSourceImpl.java:[line 142]|" Quotas can drastically overflow configured limit,13528043,Resolved,Major,Fixed,10/Mar/23 22:17,03/Apr/23 21:16,,"The original implementation did not allow exceeding quota. For example, you specify a limit of 10 resource/sec and consume 20 resources, it takes 1.1 seconds to be able submit another request. This was covered by the [testOverconsumption in TestRateLimiter|https://github.com/apache/hbase/blame/587b0b4f20bdc0415b6541023e611b69c87dba15/hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRateLimiter.java#L97]. As an incidental part of HBASE-13686, that logic was changed. There is no mention of the reasoning behind the change in the issue comments or review board, I think it was missed. The goal of that issue was to add different refill strategies, but it also modified the over consumption. The testOverconsumption was [split out for both refill strategies|https://github.com/apache/hbase/blame/master/hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRateLimiter.java#L104-L159], but the core reasoning was lost. The comment says: {code:java} // 10 resources are available, but we need to consume 20 resources109 // Verify that we have to wait at least 1.1sec to have 1 resource available {code} But the actual test was updated to only require a new resource after 100ms. This is incorrect.  The problem is, when consuming if you go negative it sets to 0 [here|https://github.com/apache/hbase/blame/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RateLimiter.java#L187-L191]. Additionally, when refilling the new logic does a Math.max(0, available + refillAmount): [here|https://github.com/apache/hbase/blame/master/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/RateLimiter.java#L159-L163]. So it's really impossible to get below 0, which is impractical for a rate limiter.  With this setup it's very easy to drastically overconsume the rate limiter. See attached screenshot, which shows two humps. The first one has the current logic, the second hump has my fix which removes both of those problems. The rate limit was set to 500mb/s, but I was easily able to go over 700 mb/s without the fix." CopyOnWriteArrayMap does not honor contract of ConcurrentMap.putIfAbsent,13525034,Resolved,Major,Fixed,16/Feb/23 14:32,18/Feb/23 00:23,,"I've been tracking down a meta cache issue and noticed this. I'm not sure if this is actually causing an issue, but if you enable TRACE logs on MetaCache it causes all calls to cacheLocation to go down the ""Merged cached locations"" path instead of the ""Cached location"" path for inserting new entries. This is just misleading, but also means going through the more expensive RegionLocations.mergeLocations. Reading the code, I don't think that would cause an actual issue, but hard to be sure." Reverse scan over rows with tags throw exceptions when using DataBlockEncoding,13520217,Resolved,Major,Fixed,19/Jan/23 16:07,04/Feb/23 17:34,,"This is easily reproducible, see test below. All you need to do is create a table with a DBE, write some puts with setTTL, then do a reverse scan. All 3 compressing DBE's fail.  PREFIX throws an exception: {code:java} Caused by: java.lang.IndexOutOfBoundsException: index (0) must be less than size (0)     at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1355)     at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkElementIndex(Preconditions.java:1337)     at org.apache.hadoop.hbase.io.util.LRUDictionary$BidirectionalLRUMap.get(LRUDictionary.java:153)     at org.apache.hadoop.hbase.io.util.LRUDictionary$BidirectionalLRUMap.access$000(LRUDictionary.java:79)     at org.apache.hadoop.hbase.io.util.LRUDictionary.getEntry(LRUDictionary.java:43)     at org.apache.hadoop.hbase.io.TagCompressionContext.uncompressTags(TagCompressionContext.java:152)     at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.decodeTags(BufferedDataBlockEncoder.java:819)     at org.apache.hadoop.hbase.io.encoding.PrefixKeyDeltaEncoder$SeekerStateBufferedEncodedSeeker.decodeNext(PrefixKeyDeltaEncoder.java:209)     at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.seekToKeyInBlock(BufferedDataBlockEncoder.java:920) {code}   DIFF throws an exception: {code:java} Caused by: java.lang.ArrayIndexOutOfBoundsException: arraycopy: length -22 is negative     at java.base/java.lang.System.arraycopy(Native Method)     at org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray(ByteBufferUtils.java:1140)     at org.apache.hadoop.hbase.nio.SingleByteBuff.get(SingleByteBuff.java:213)     at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decode(DiffKeyDeltaEncoder.java:431)     at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decodeNext(DiffKeyDeltaEncoder.java:502)     at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.seekToKeyInBlock(BufferedDataBlockEncoder.java:920) {code}   FAST_DIFF throws a similar exception: {code:java} Caused by: java.lang.ArrayIndexOutOfBoundsException: arraycopy: length -22 is negative     at java.base/java.lang.System.arraycopy(Native Method)     at org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray(ByteBufferUtils.java:1140)     at org.apache.hadoop.hbase.nio.SingleByteBuff.get(SingleByteBuff.java:213)     at org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$FastDiffSeekerStateBufferedEncodedSeeker.decode(FastDiffDeltaEncoder.java:424)     at org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$FastDiffSeekerStateBufferedEncodedSeeker.decodeNext(FastDiffDeltaEncoder.java:490)     at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.seekToKeyInBlock(BufferedDataBlockEncoder.java:920) {code}   Reproduce with: {code:java} private static final Logger LOG = LoggerFactory.getLogger(TestTags.class); @Test public void testReverseScanWithDBE() throws IOException { byte[] family = Bytes.toBytes(""0""); Configuration conf = new Configuration(TEST_UTIL.getConfiguration()); conf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 1); try (Connection connection = ConnectionFactory.createConnection(conf)) { for (DataBlockEncoding encoding : DataBlockEncoding.values()) { boolean isCompressing = encoding != DataBlockEncoding.NONE && encoding != DataBlockEncoding.ROW_INDEX_V1; try { testReverseScanWithDBE(connection, encoding, family); if (isCompressing) { Assert.fail(""Expected to throw exception for DBE "" + encoding); } } catch (Exception e) { LOG.info(""Got exception for DBE {}"", encoding, e); assertTrue(""Only expected compressing encodings to fail, but failed on "" + encoding, isCompressing); } } } } private void testReverseScanWithDBE(Connection conn, DataBlockEncoding encoding, byte[] family) throws IOException { LOG.info(""Running test with DBE={}"", encoding); TableName tableName = TableName.valueOf(TEST_NAME.getMethodName() + ""-"" + encoding); TEST_UTIL.createTable( TableDescriptorBuilder.newBuilder(tableName) .setColumnFamily(ColumnFamilyDescriptorBuilder.newBuilder(family) .setDataBlockEncoding(encoding) .build()) .build(), null); Table table = conn.getTable(tableName); for (int i = 0; i < 10; i++) { table.put(new Put(Bytes.toBytes(i)).addColumn(family, Bytes.toBytes(0), new byte[10]).setTTL(600_000)); } TEST_UTIL.flush(table.getName()); Scan scan = new Scan(); scan.setReversed(true); try (ResultScanner scanner = table.getScanner(scan)) { // should fail for compressing encodings scanner.next(); } } {code}" Recovery of BucketCache and Prefetched data after RS Crash,13527026,Resolved,Major,Fixed,03/Mar/23 17:27,16/Mar/23 16:02,,"HBASE-27313 introduced the ability to persist a list of hfiles for which prefetch has already been completed, so the we can avoid prefetching those files again in the event of a graceful restart, but it doesn't cover crash scenarios, as if the RS is killed or abnormally stopped, the list wouldn't be saved. This change aims to persist the list of already prefetched from a background thread that periodically checks cache state and persists the list if updates have happened." Recover WAL encounter KeeperErrorCode = NoNode cause RegionServer crash,13530438,Open,Major,,28/Mar/23 13:41,,,"20696 2022-07-07 14:51:52,638 ERROR.HRegionServer: ***** ABORTING region server ***: Failed to operate on replication queue ***** 120697 org.apache.hadoop.hbase.replication.ReplicationException: Failed to set log position (serverName=***, queueId=***.regiongroup-0.1657176199216,position=55122787) 120698     at org.apache.hadoop.hbase.replication.ZKReplicationQueueStorage.setWALPosition(ZKReplicationQueueStorage.java:261) 120699     at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.lambda$logPositionAndCleanOldLogs$7(ReplicationSourceManager.java:529) 120700     at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.interruptOrAbortWhenFail(ReplicationSourceManager.java:476) 120701     at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.logPositionAndCleanOldLogs(ReplicationSourceManager.java:528) 120702     at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.updateLogPosition(ReplicationSourceShipper.java:271) 120703     at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.shipEdits(ReplicationSourceShipper.java:205) 120704     at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper.run(ReplicationSourceShipper.java:120) 120705 Caused by: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode 120706     at org.apache.zookeeper.KeeperException.create(KeeperException.java:118) 120707     at org.apache.zookeeper.ZooKeeper.multiInternal(ZooKeeper.java:1925) 120708     at org.apache.zookeeper.ZooKeeper.multi(ZooKeeper.java:1830) 120709     at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.multi(RecoverableZooKeeper.java:668) 120710     at org.apache.hadoop.hbase.zookeeper.ZKUtil.multiOrSequential(ZKUtil.java:1797) 120711     at org.apache.hadoop.hbase.replication.ZKReplicationQueueStorage.setWALPosition(ZKReplicationQueueStorage.java:251) 120712     ... 6 more" Migrate meta locations from zookeeper to master data may not always possible if we migrate from 1.x HBase,13527861,In Progress,Major,,09/Mar/23 17:51,,2.5.0,"In HBase 1.x versions meta server location from zookeeper will be removed when the server stopped. In such cases migrating to 2.5.x branches may not create any meta entries in master data. So in case if we could not find the meta location from zookeeper we can get meta location from wal directories with .meta extension and add to master data. {noformat} private void tryMigrateMetaLocationsFromZooKeeper() throws IOException, KeeperException { // try migrate data from zookeeper try (ResultScanner scanner = masterRegion.getScanner(new Scan().addFamily(HConstants.CATALOG_FAMILY))) { if (scanner.next() != null) { // notice that all replicas for a region are in the same row, so the migration can be // done with in a one row put, which means if we have data in catalog family then we can // make sure that the migration is done. LOG.info(""The {} family in master local region already has data in it, skip migrating..."", HConstants.CATALOG_FAMILY_STR); return; } } // start migrating byte[] row = CatalogFamilyFormat.getMetaKeyForRegion(RegionInfoBuilder.FIRST_META_REGIONINFO); Put put = new Put(row); List metaReplicaNodes = zooKeeper.getMetaReplicaNodes(); StringBuilder info = new StringBuilder(""Migrating meta locations:""); for (String metaReplicaNode : metaReplicaNodes) { int replicaId = zooKeeper.getZNodePaths().getMetaReplicaIdFromZNode(metaReplicaNode); RegionState state = MetaTableLocator.getMetaRegionState(zooKeeper, replicaId); info.append("" "").append(state); put.setTimestamp(state.getStamp()); MetaTableAccessor.addRegionInfo(put, state.getRegion()); if (state.getServerName() != null) { MetaTableAccessor.addLocation(put, state.getServerName(), HConstants.NO_SEQNUM, replicaId); } put.add(CellBuilderFactory.create(CellBuilderType.SHALLOW_COPY).setRow(put.getRow()) .setFamily(HConstants.CATALOG_FAMILY) .setQualifier(RegionStateStore.getStateColumn(replicaId)).setTimestamp(put.getTimestamp()) .setType(Cell.Type.Put).setValue(Bytes.toBytes(state.getState().name())).build()); } if (!put.isEmpty()) { LOG.info(info.toString()); masterRegion.update(r -> r.put(put)); } else { LOG.info(""No meta location available on zookeeper, skip migrating...""); } } {noformat}" Implement filesystem based Replication peer storage,13528900,Resolved,Major,Fixed,17/Mar/23 05:37,13/Apr/23 11:46,, Support for Hadoop's LDAP Authentication mechanism (Web UI only),13527581,Resolved,Major,Fixed,08/Mar/23 06:24,28/Apr/23 15:59,,"Hadoop's AuthenticationFilter has changed and now has support for ldap mechanism too. HBase still uses an older version tightly coupled with kerberos and spnego as the only auth mechanisms. HADOOP-12082 has added support for multiple auth handlers including LDAP. On trying to use Hadoop's AuthenticationFilterInitializer in hbase.http.filter.initializers, there is a casting exception as HBase requires it to extend org.apache.hadoop.hbase.http.FilterInitializer." Enhance quotas to consume blockBytesScanned rather than response size,13527085,Resolved,Major,Fixed,04/Mar/23 15:22,06/Feb/24 20:52,,"As of HBASE-27558 we now apply quota.getReadAvailable() to max block bytes scanned by scans/multis. This issue enhances further so that we can track read size consumed in Quotas based on block bytes scanned rather than response size. In this mode, quotas would end-to-end be based on blockBytesScanned. Right now we call quota.addGetResult or addScanResult. This would just be a matter of no-oping those calls, and calling RpcCall.getBlockBytesScanned() in Quota.close() instead." Additional Zstandard codec compatible with the Hadoop native one,13528208,Open,Major,,13/Mar/23 09:56,,2.5.3,"  We're in the process of upgrading a HBase installation from 2.2.4 to 2.5.3. We're currently using Zstd compression from our Hadoop installation. Due to some other class path issues (Netty issues in relation to the async WAL provider), we would like to remove Hadoop from the class path. However, using the Zstd compression from HBase (which uses [https://github.com/luben/zstd-jni]) we seem to hit some incompatibility. When restarting a node to use this implementation we had errors like the following: {code:java} 2023-03-10 16:33:01,925 WARN [RS_OPEN_REGION-regionserver/n2:16020-0] handler.AssignRegionHandler: Failed to open region NAMESPACE:TABLE,,1673888962751.cdb726dad4eaabf765969f195e91c737., will report to master java.io.IOException: java.io.IOException: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading data index and meta index from file hdfs://CLUSTER/hbase/data/NAMESPACE/TABLE/cdb726dad4eaabf765969f195e91c737/e/aea6eddaa8ee476197d064a4b4c345b9 at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1148) at org.apache.hadoop.hbase.regionserver.HRegion.initializeStores(HRegion.java:1091) at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:994) at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:941) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7228) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7183) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7159) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7118) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7074) at org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:147) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:100) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.io.IOException: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading data index and meta index from file hdfs://CLUSTER/hbase/data/NAMESPACE/TABLE/cdb726dad4eaabf765969f195e91c737/e/aea6eddaa8ee476197d064a4b4c345b9 at org.apache.hadoop.hbase.regionserver.StoreEngine.openStoreFiles(StoreEngine.java:288) at org.apache.hadoop.hbase.regionserver.StoreEngine.initialize(StoreEngine.java:338) at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:297) at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6359) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1114) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1111) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) ... 3 more Caused by: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading data index and meta index from file hdfs://CLUSTER/hbase/data/NAMESPACE/TABLE/cdb726dad4eaabf765969f195e91c737/e/aea6eddaa8ee476197d064a4b4c345b9 at org.apache.hadoop.hbase.io.hfile.HFileInfo.initMetaAndIndex(HFileInfo.java:392) at org.apache.hadoop.hbase.regionserver.HStoreFile.open(HStoreFile.java:394) at org.apache.hadoop.hbase.regionserver.HStoreFile.initReader(HStoreFile.java:518) at org.apache.hadoop.hbase.regionserver.StoreEngine.createStoreFileAndReader(StoreEngine.java:225) at org.apache.hadoop.hbase.regionserver.StoreEngine.lambda$openStoreFiles$0(StoreEngine.java:266) ... 6 more Caused by: java.io.IOException: Premature EOF from inputStream, but still need 2883 bytes at org.apache.hadoop.hbase.io.util.BlockIOUtils.readFullyWithHeapBuffer(BlockIOUtils.java:153) at org.apache.hadoop.hbase.io.encoding.HFileBlockDefaultDecodingContext.prepareDecoding(HFileBlockDefaultDecodingContext.java:104) at org.apache.hadoop.hbase.io.hfile.HFileBlock.unpack(HFileBlock.java:644) at org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl$1.nextBlock(HFileBlock.java:1397) at org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl$1.nextBlockWithBlockType(HFileBlock.java:1407) at org.apache.hadoop.hbase.io.hfile.HFileInfo.initMetaAndIndex(HFileInfo.java:365) ... 10 more {code} I've been able to reproduce the issue with something like: {code:java} Configuration conf = HBaseConfiguration.create(); conf.set(""hbase.io.compress.zstd.codec"", ""org.apache.hadoop.hbase.io.compress.zstd.ZstdCodec""); HFileSystem fs = (HFileSystem) HFileSystem.get(conf); HFile.createReader(fs, new Path(...), conf); {code} with a file from HDFS that was created with the native compressor from Hadoop. Note that I only _suspect_ that this issue is caused by Zstd! In our test environment we are already running 2.5.3 with reasonable succes. This issue arises when we drop Hadoop from the class path and use the 'built in' compression. But that's not hard evidence of Zstd being the root cause of course." Optimize reference counting in off-heap ByteBuff,13528973,Open,Major,,17/Mar/23 13:11,,,"In HBASE-27710 we uncovered a performance regression in reference counting of ByteBuff. This was especially prominent in on-heap buffers when doing a simple HFile.Reader iteration of a file. For that case, we saw a 4x regression when reference counting was in play. It stands to reason that this same regression exists in off-heap buffers, and I've run a microbenchmark which indeed shows the same issue. With existing reference counting, scanning a 20gb hfile takes 40s. With an optimized version, scanning the same file takes 20s. We don't typically see this in profiling live regionservers where so much else goes on, but optimizing this would eliminate some cpu cycles. It's worth noting that netty saw this same regression a few years ago: [https://github.com/netty/netty/pull/8895]. Hat tip to [~zhangduo] for pointing this out. One of the fixes there was to copy some internal code from deeper in the ref counting, so that the call stack was smaller and inlining was possible. We can't really do that. Another thing they did was add a boolean field in their CompositeByteBuffer, which gets set to true when the buffer is recycled. So they don't need to do reference counting on every operation, instead they can just check a boolean. I tried adding a boolean to our RefCnt.java, and it indeed fixes the regression. The problem is, due to class alignment issues in java, adding this boolean field increases the heap size of RefCnt from 24 to 32 bytes. This seems non-trivial given it's used in bucket cache where there could be many millions of them. I think we can get around this by simply nulling out the recycler in RefCnt after it has been called. Then, instead of doing a boolean check we can do a null check. This performs similarly to the boolean, but without any extra memory." "Use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system",13531048,Resolved,Major,Fixed,31/Mar/23 22:39,22/Nov/23 23:13,2.4.16,"after HADOOP-18671 , we will change the hbase-asyncfs to use use hasPathCapability to support recoverLease, setSafeMode, isFileClosed for non-HDFS file system instead of directly casting only HDFS in RecoverLeaseFSUtils" Hbase shell non interactive stalls,13529623,Open,Major,,22/Mar/23 13:02,,2.4.8,"The following bash shell script invocations may stall or not `hbase shell -n` indefinitely (=until timeout). This might be how tty / pipes interact with the hbase shell. Opening this to better understand either if this is a bug or limitation in hbase shell, or what workarounds are there. The below samples and execution is with hbase 2.4.8, whilst in a containerized HBase 2.4.11 the stall issues don't appear. {color:#00875a}Works executed in CLI bash{color} {code:java} function check_alter_hbase () {   HBASE_SHELL_CMD=""hbase shell -n""   hbase_state=$( echo ""describe 'my_table'"" | $HBASE_SHELL_CMD )   echo $hbase_state } export -f check_alter_hbase timeout 30s bash -c check_alter_hbase{code} {color:#de350b}Doesn't work as bash script, stalls until timeout ** {color} {code:java} # cat stall.sh function check_alter_hbase () {   HBASE_SHELL_CMD=""hbase shell -n""   hbase_state=$( echo ""describe 'my_table'"" | $HBASE_SHELL_CMD )   echo $hbase_state } export -f check_alter_hbase timeout 30s bash -c check_alter_hbase # echo $? 124{code} {color:#172b4d}Running the same bash stall logic in HBase 2.4.11 doesn't seem to reproduce the issue, though there is a slight difference that we have containers there (e.g. pod hbasemaster-0).{color} {color:#00875a}Works executed in CLI as bash script{color} {code:java} # cat works.sh function check_alter_hbase () {   HBASE_SHELL_CMD=""hbase shell -n""   hbase_state=$( echo ""describe 'my_table'"" | $HBASE_SHELL_CMD )   echo $hbase_state } export -f check_alter_hbase timeout --foreground 30s bash -c check_alter_hbase # bash works.sh Table my_table is ENABLED ... # echo $? 0{code} {color:#ff0000}Doesn't work as internal init script, stalls (called indirectly not via CLI){color} {code:java} function check_alter_hbase () {   HBASE_SHELL_CMD=""hbase shell -n""   hbase_state=$( echo ""describe 'my_table'"" | $HBASE_SHELL_CMD )   echo $hbase_state } export -f check_alter_hbase timeout --foreground 30s bash -c check_alter_hbase {code} Running the same bash stall logic in HBase 2.4.11 doesn't seem to reproduce the issue, though there is a slight difference that we have containers there (e.g. pod hbasemaster-0)." Release 2.4.17,13530163,Resolved,Major,Fixed,27/Mar/23 00:52,17/Oct/23 23:52,, hbase-spark bulkload stage directory limited to hdfs only,13524066,Resolved,Major,Fixed,09/Feb/23 18:36,14/Feb/23 12:33,connector-1.0.0,"It's impossible to set up the staging directory for bulkload operation in spark-hbase connector to any other filesystem different from hdfs. That might be a problem for deployments where hbase.rootdir points to cloud storage. In this case, an additional copy task from hdfs to cloud storage would be required before loading hfiles to hbase." "Support hbase-connectors compilation with HBase 2.5.3, Hadoop 3.2.4 and Spark 3.2.3",13524585,Resolved,Major,Fixed,14/Feb/23 05:16,01/Mar/23 09:34,,"Goal is to allow hbase-connectors to compile with: * HBase: 2.5.3 * Hadoop: 3.2.4 and * Spark: 3.2.3 We could also discuss if we want to bump the versions of the above mentioned in the pom itself, or just want to let spark connector compile with above components as the JIRA title says." Update checkstyle in hbase-connectors,13526537,Resolved,Major,Fixed,28/Feb/23 13:58,28/Feb/23 17:37,,There is a known CVE on the used checkstyle in hbase-connectors. Bump junit to 4.13.2 in hbase-connectors,13526558,Resolved,Major,Fixed,28/Feb/23 16:38,06/Mar/23 14:14,,Dependapot reported an issue with junit. Move to the version we have in hbase main repository. Support steal job queue mode for read RPC queues of RWQueueRpcExecutor,13530718,Open,Major,,30/Mar/23 04:14,,2.5.3,"Currently, the RPC queues are distinguished by request type, under most circumstances of RWQueueRpcExecutor, there are write queues and read queues, while reads queues are always divided by get requests and scan requests. The reason why we isolate the scan requests and get requests is that we do not want large scans block small gets. Since the handler resources for a regionserver is limited and we can't dynamicly change the handler ratio by the ratio of requests. We should both keep large scan and the small gets be isolated, and let the idle handlers for the samller ratio scans to handle some gets when the gets handlers are busy. This steal queue idea can also be used in other circumstances, e.g. idle read handler steal jobs from write queus. " HBase token expired because the connection was not released,13525673,Open,Major,,22/Feb/23 03:01,,,"I used hbase-spark to read hbase data in spark streaming application, and the token expired error occurred after 7 days. Error: {code:java} 23/02/20 19:29:07 INFO AsyncRequestFutureImpl: id=38643, table=XXX, attempt=11/16, failureCount=1ops, last exception=java.io.IOException: Call to XXX.XXX/XXX.XXX.XXX.XXX:60020 failed on local exception: java.io.IOException: org.apache.hbase.thirdparty.io.netty.handler.codec.DecoderException: org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.security.token.SecretManager$InvalidToken): Token has expired on XXX.XXX,60020,1675839912342, tracking started null, retrying after=10009ms, operationsToReplay=1 {code} HBase RpcClient has expired connections that have not been cleaned up. arthas command:  {code:java} watch org.apache.hadoop.hbase.ipc.AbstractRpcClient getConnection ""target.connections.values.{token.toString}"" -x 2 -n 2 {code} result: {code:java} @ArrayList[     @String[Kind: HBASE_AUTH_TOKEN, Service: a88deda4-d74c-483e-af8b-0fb9de7c7594, Ident: ((username=XXX, keyId=575, issueDate=1676858059133, expirationDate=1677462859133, sequenceNumber=772469))],     ...     @String[Kind: HBASE_AUTH_TOKEN, Service: a88deda4-d74c-483e-af8b-0fb9de7c7594, Ident: ((username=XXX, keyId=573, issueDate=1676656459093, expirationDate=1677261259093, sequenceNumber=587447))],     ...     @String[Kind: HBASE_AUTH_TOKEN, Service: a88deda4-d74c-483e-af8b-0fb9de7c7594, Ident: ((username=XXX, keyId=571, issueDate=1676454859019, expirationDate=1677059659019, sequenceNumber=430605))],     ... ]{code} The hbase connection seems to be cleaned up only after being idle for a period of time. {code:java} org.apache.hadoop.hbase.spark.HBaseConnectionCache#connectionMap org.apache.hadoop.hbase.ipc.AbstractRpcClient#connections {code}  " "Bump commons-lang3 to 3.12.0, surefire to 3.0.0 and dependency manage reload4j to 1.2.25 to support jdk11",13523911,Resolved,Major,Fixed,09/Feb/23 07:49,04/Aug/23 05:14,connector-1.0.0,"When trying to run the tests with Java 11, I get: {noformat} [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.733 s <<< FAILURE! - in org.apache.hadoop.hbase.spark.TestJavaHBaseContext [ERROR] org.apache.hadoop.hbase.spark.TestJavaHBaseContext  Time elapsed: 0.721 s  <<< ERROR! java.lang.ExceptionInInitializerError     at org.apache.hadoop.hbase.spark.TestJavaHBaseContext.setUpBeforeClass(TestJavaHBaseContext.java:86) Caused by: java.lang.NullPointerException     at org.apache.hadoop.hbase.spark.TestJavaHBaseContext.setUpBeforeClass(TestJavaHBaseContext.java:86)[ERROR] org.apache.hadoop.hbase.spark.TestJavaHBaseContext  Time elapsed: 0.721 s  <<< ERROR! java.lang.NullPointerException     at org.apache.hadoop.hbase.spark.TestJavaHBaseContext.tearDownAfterClass(TestJavaHBaseContext.java:106) {noformat} The same test runs fine with Java 8." Respect SparkContext hadoop configuration,13528149,Resolved,Major,Fixed,13/Mar/23 01:37,02/Aug/23 07:51,,"In our environment, the hbase clusters are independent of spark computing cluster, I want to set hbase configuration through `spark.hadoop.hbase.XXX`, so I hope hbase-spark can respect `sparkContext.hadoopConfiguration`." Make sure the close method of the SmartSonnection is called,13525405,Resolved,Major,Fixed,20/Feb/23 09:46,02/Aug/23 08:03,,The close method of SmartSonnection may not be called when an exception occurs in the hbaseForeachPartition or hbaseMapPartition methods of HBaseContext. We should use try-finally to ensure that the close method is called. Clean up hbase-connector dependencies and assembly,13529904,Open,Major,,24/Mar/23 04:59,,,"We ship a lot of external jars in the /lib directory of the assembly. I know that for Spark none of those are needed, because we take everything from the Spark classpath. I am not familiar with the Kafka connector, but according to the readme, that one also adds the jars from 'hbase classpath' , which includes most/all of the external JARs in the lib directory." scan table is slow when enter hbase shell first time,13530536,Open,Major,,29/Mar/23 03:54,,2.4.14,"When we test HBase 2.4.14 on our cluster... I find we  scan a table is slow when enter hbase shell first time. step like this: hbase shell scan 'hbase:meta',\{LIMIT=>1} the cost time is more than HBase 1.3 Any one can help compare the two versions(HBase 2.x vs HBase 1.x) in first scan process? thanks~   ------- I find the the “Future f = cs.poll(timeBeforeReplicas, TimeUnit.MICROSECONDS);” in org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas#call  cost above 200+ms  " HMaster can not finish Initialization when hbase:namespace is in ABNORMALLY_CLOSED state and the proc corrupt,13516649,Resolved,Major,Not A Problem,05/Jan/23 13:46,25/Jun/23 12:59,2.4.14,"2023-01-05 19:56:41,385 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=102, ppid=97, state=SUCCESS; OpenRegionProcedure 1903713b7f970a75db1e7a0e72da21d7, server=node-master2mesq,21302,1672817611868 | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,385 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=103, ppid=96, state=SUCCESS; OpenRegionProcedure 6695b9c5ad80249bc43830ddc5259487, server=node-master2mesq,21302,1672817611868 | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,402 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=106, ppid=82, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED; TransitRegionStateProcedure table=ImportTable1, region=050bcf6e15ddd079d750992bbfb53163, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,403 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=107, ppid=82, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED; TransitRegionStateProcedure table=hbase:hindex, region=6789443c0a98d2b34f891ae60878aac3, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,404 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=108, ppid=82, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED; TransitRegionStateProcedure table=hbase:acl, region=96a2ec5ea797e6847188c965f8c78ce1, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,404 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=109, ppid=82, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED; TransitRegionStateProcedure table=ImportTable1, region=24e0cb0a958d242976a790ff435d24b5, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,405 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=110, ppid=82, state=RUNNABLE:REGION_STATE_TRANSITION_OPEN; TransitRegionStateProcedure table=ImportTable1, region=a2e7b85420a3cf98fc731ad93f7129a2, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) *2023-01-05 19:56:41,405 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=111, ppid=82, state=RUNNABLE:REGION_STATE_TRANSITION_OPEN; TransitRegionStateProcedure table=hbase:namespace, region=9be1542260fa8af4a712ddda322b7b6f, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343)* 2023-01-05 19:56:41,406 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=112, ppid=82, state=WAITING:REGION_STATE_TRANSITION_CONFIRM_OPENED; TransitRegionStateProcedure table=hbase:rsgroup, region=eaf1531c6cc0738027def0b4d4615b5f, ASSIGN | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,406 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=125, ppid=95, state=SUCCESS; OpenRegionProcedure 85301e5c14a8c3e5ba31822d7db0a6fc, server=node-master3mpye,21302,1672817640502 | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,407 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=126, ppid=96, state=SUCCESS; OpenRegionProcedure 6695b9c5ad80249bc43830ddc5259487, server=node-master3mpye,21302,1672817640502 | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343) 2023-01-05 19:56:41,408 | ERROR | master/node-master3MPYe:21300:becomeActiveMaster | Corrupt pid=127, ppid=94, state=SUCCESS; OpenRegionProcedure 448b88d503d4e31c47b80ac10d8ef6a4, server=node-master3mpye,21302,1672817640502 | org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.handleCorrupted(ProcedureExecutor.java:343)   2023-01-05 19:57:26,250 | INFO  | PEWorker-13 | hdfs://hacluster/hbase/WALs/node-master2mesq,21302,1672919282543-splitting dir is empty, no logs to split. | org.apache.hadoop.hbase.master.SplitLogManager.getFileList(SplitLogManager.java:171) 2023-01-05 19:57:26,250 | INFO  | PEWorker-13 | node-master2mesq,21302,1672919282543 WAL count=0, meta=false | org.apache.hadoop.hbase.master.SplitWALManager.getWALsToSplit(SplitWALManager.java:106) *2023-01-05 19:57:27,068 | WARN  | master/node-master3MPYe:21300:becomeActiveMaster | hbase:namespace,,1672387265579.9be1542260fa8af4a712ddda322b7b6f. is NOT online; state=\{9be1542260fa8af4a712ddda322b7b6f state=ABNORMALLY_CLOSED, ts=1672919843989, server=node-master1ficj,21302,1672820444411}; ServerCrashProcedures=true. Master startup cannot progress, in holding-pattern until region onlined. | org.apache.hadoop.hbase.master.HMaster.isRegionOnline(HMaster.java:1264)* 2023-01-05 19:57:27,227 | INFO  | PEWorker-13 | Initialized subprocedures=[ {pid=606, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ImportTable1, region=8d29da5ef730c7a003cafb0be8981674, ASSIGN} , {pid=607, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=hbase:hindex, region=6789443c0a98d2b34f891ae60878aac3, ASSIGN} , {pid=608, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ImportTable1, region=3117c3b77e4cf7a9f7ae9fa1aec87f08, ASSIGN} , {pid=609, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=hbase:acl, region=96a2ec5ea797e6847188c965f8c78ce1, ASSIGN} , {pid=610, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ImportTable1, region=9051d9e17c5b811c09471616044ed8be, ASSIGN} ] | org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1683) 2023-01-05 19:57:27,235 | INFO  | PEWorker-14 | Took xlock for pid=606, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ImportTable1, region=8d29da5ef730c7a003cafb0be8981674, ASSIGN | org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.waitRegions(MasterProcedureScheduler.java:727) 2023-01-05 19:57:27,236 | INFO  | PEWorker-4 | Took xlock for pid=607, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=hbase:hindex, region=6789443c0a98d2b34f891ae60878aac3, ASSIGN | org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.waitRegions(MasterProcedureScheduler.java:727) 2023-01-05 19:57:27,242 | INFO  | PEWorker-16 | Took xlock for pid=609, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=hbase:acl, region=96a2ec5ea797e6847188c965f8c78ce1, ASSIGN | org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.waitRegions(MasterProcedureScheduler.java:727) 2023-01-05 19:57:27,245 | INFO  | PEWorker-13 | Took xlock for pid=610, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ImportTable1, region=9051d9e17c5b811c09471616044ed8be, ASSIGN | org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.waitRegions(MasterProcedureScheduler.java:727) 2023-01-05 19:57:27,249 | INFO  | PEWorker-15 | Took xlock for pid=608, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=ImportTable1, region=3117c3b77e4cf7a9f7ae9fa1aec87f08, ASSIGN | org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler.waitRegions(MasterProcedureScheduler.java:727) 2023-01-05 19:57:27,250 | INFO  | PEWorker-14 | Setting lastHost as the region location node-master2mesq,21302,1672919282543 | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:197) 2023-01-05 19:57:27,252 | INFO  | PEWorker-14 | Starting pid=606, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=ImportTable1, region=8d29da5ef730c7a003cafb0be8981674, ASSIGN; state=OPEN, location=node-master2mesq,21302,1672919282543; forceNewPlan=false, retain=true | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:201) 2023-01-05 19:57:27,254 | INFO  | PEWorker-4 | Setting lastHost as the region location node-master2mesq,21302,1672919282543 | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:197) 2023-01-05 19:57:27,257 | INFO  | PEWorker-4 | Starting pid=607, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=hbase:hindex, region=6789443c0a98d2b34f891ae60878aac3, ASSIGN; state=OPEN, location=node-master2mesq,21302,1672919282543; forceNewPlan=false, retain=true | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:201) 2023-01-05 19:57:27,266 | INFO  | PEWorker-16 | Setting lastHost as the region location node-master2mesq,21302,1672919282543 | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:197) 2023-01-05 19:57:27,266 | INFO  | PEWorker-13 | Setting lastHost as the region location node-master2mesq,21302,1672919282543 | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:197) 2023-01-05 19:57:27,267 | INFO  | PEWorker-16 | Starting pid=609, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=hbase:acl, region=96a2ec5ea797e6847188c965f8c78ce1, ASSIGN; state=OPEN, location=node-master2mesq,21302,1672919282543; forceNewPlan=false, retain=true | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:201) 2023-01-05 19:57:27,267 | INFO  | PEWorker-13 | Starting pid=610, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=ImportTable1, region=9051d9e17c5b811c09471616044ed8be, ASSIGN; state=OPEN, location=node-master2mesq,21302,1672919282543; forceNewPlan=false, retain=true | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:201) 2023-01-05 19:57:27,271 | INFO  | PEWorker-15 | Setting lastHost as the region location node-master2mesq,21302,1672919282543 | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:197) 2023-01-05 19:57:27,271 | INFO  | PEWorker-15 | Starting pid=608, ppid=603, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE, locked=true; TransitRegionStateProcedure table=ImportTable1, region=3117c3b77e4cf7a9f7ae9fa1aec87f08, ASSIGN; state=OPEN, location=node-master2mesq,21302,1672919282543; forceNewPlan=false, retain=true | org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure.queueAssign(TransitRegionStateProcedure.java:201) 2023-01-05 19:57:27,280 | INFO  | PEWorker-19 | pid=606 updating hbase:meta row=8d29da5ef730c7a003cafb0be8981674, regionState=OPENING, regionLocation=node-master1ficj,21302,1672919746624 | org.apache.hadoop.hbase.master.assignment.RegionStateStore.updateUserRegionLocation(RegionStateStore.java:219)   *The hbase:namespace is in ABNORMALLY_CLOSED state and the the proc is corrupt, then the hbase:namespace never assigned and HMaster Initialization failed*   *I think we should process the regions in ABNORMALLY_CLOSED state in org.apache.hadoop.hbase.master.assignment.AssignmentManager#processOfflineRegions? or check proc in  org.apache.hadoop.hbase.master.HMaster#waitForNamespaceOnline?*" Should support single call queue mode for RPC handlers while separating by request type,13526849,Open,Major,,02/Mar/23 12:03,,2.5.3,"Currently we not only seperate call queues by request type, e.g. read, write, scan, but also distinguish queues for handlers by the config `hbase.ipc.server.callqueue.handler.factor`, whose description is as follows, {code:java} Factor to determine the number of call queues. A value of 0 means a single queue shared between all the handlers. A value of 1 means that each handler has its own queue. {code} But I think what we want is not only one queue for all the requests, or each handler has its own queue. We also want each request type has its own queue. Distinguishing queues in the same type of requests will make some handlers too iddle but some handlers too busy under current balanced/random RPC executor framework. For the extrem case, each handler has its own queue, then if a large request comes for a handler, duing to he executor dispath calls without considering the queue size or the state of the handler, the afterwards coming requests will be queued until the handler complete the large slow request. While other handlers may process small requests quickly, but they can not help or grab calls from the busy queue, they must stay and wait it own queue jobs coming. Then we can see the queue time of some requests are long but there are iddle handlers. We can also see these circumstances, that the queue time of calls is too larger than the process time, sometimes twice or more. Restarting the slow RS will make these problems disappear.  By using single call queue for each request type, we can fully use the handler resources." Remove unused params in region metrics,13528336,Resolved,Major,Fixed,14/Mar/23 03:57,01/Jun/23 09:16,3.0.0-alpha-3,"Histogram metrics in region have been removed in HBASE-17017, but there are some time cost params still left. Need to remove them." Publish SBOM artifacts,13517317,Resolved,Major,Fixed,10/Jan/23 02:29,20/Jan/23 08:56,3.0.0-alpha-4, Test failures on branch-2.4 with corrupted exclude list,13516657,Resolved,Major,Fixed,05/Jan/23 15:01,09/Jan/23 11:13,2.4.16,"Nightly builds and PRs on branch-2.4 are failing with an invalid exclude list. Executed unit test command: {code:java} /opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4944/yetus-m2/hbase-branch-2.4-patch-0 --threads=4 -Djava.io.tmpdir=/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4944/yetus-jdk8-hadoop2-check/src/target -DHBasePatchProcess -PrunAllTests -Dtest.exclude.pattern=**/replication.regionserver.TestMetaRegionReplicaReplicationEndpoint.java,**/client.TestMetaRegionLocationCache.java,**/master.balancer.TestStochasticLoadBalancerRegionReplicaWithRacks.java,**/replication.TestZKReplicationQueueStorageWARNING: All illegal access operations will be denied in a future release.java,**/replication.regionserver.TestBasicWALEntryStreamFSHLog.java -Dsurefire.firstPartForkCount=0.5C -Dsurefire.secondPartForkCount=0.5C clean test -fae {code} The latest exclude list contains ""WARNING: All illegal access operations will be denied in a future release"" and maven treats this as a new parameter. As a result unit tests are failing on CI that rely on the exclude list. [https://ci-hbase.apache.org/job/HBase-Find-Flaky-Tests/job/branch-2.4/lastSuccessfulBuild/artifact/output/excludes/*view*/] {noformat} **/replication.regionserver.TestMetaRegionReplicaReplicationEndpoint.java,**/client.TestMetaRegionLocationCache.java,**/master.balancer.TestStochasticLoadBalancerRegionReplicaWithRacks.java,**/replication.TestZKReplicationQueueStorageWARNING: All illegal access operations will be denied in a future release.java,**/replication.regionserver.TestBasicWALEntryStreamFSHLog.java {noformat}" Start a new ReplicationSyncUp after the previous failed,13523858,Resolved,Major,Fixed,09/Feb/23 02:28,05/Apr/23 15:37,, Update the list of prefetched files upon region movement,13529995,Resolved,Major,Fixed,24/Mar/23 15:38,09/May/23 19:56,3.0.0-alpha-3,"Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache. This ticket is for updating the list of prefetched files when the region is moved but the blocks from that region are not evicted." Release 2.5.4,13530164,Resolved,Major,Fixed,27/Mar/23 00:52,15/Apr/23 01:07,, Include EventType and ProcedureV2 pid in logging via MDC,13530246,Resolved,Major,Fixed,27/Mar/23 13:17,01/May/23 15:47,2.4.17,"Tracing the distributed actions of ProcedureV2 {{RemoteProcedure}} execution is painful. We are pretty good about logging the {{proc_id}} most of the time, but we don't catch them all. Now that we're up on log4j2, let's use the MDC feature to include some basic information universally." Normalizer can skip picking presplit regions while preparing merge plans,13526148,Resolved,Major,Won't Fix,25/Feb/23 05:06,18/Apr/23 10:57,,"Normalizer can be used to merge the regions which become emtpy post TTL expiry. But it's picking the presplit regions as well. We can skip picking presplit regions while preparing the merge plans by looking at the number of storefiles along with size. Presplit regions have zero storefiles where as the TTL expired regions have 1 storefile with zero size." Race conditions in BlockingRpcConnection,13530821,Resolved,Major,Fixed,30/Mar/23 14:47,10/Apr/23 19:34,,"We've been experiencing strange timeouts since upgrading to hbase2 client. We use BlockingRpcConnection for now until we migrate our auth stack to native TLS. In diagnosing the timeouts, I noticed a few issues in this class: # Most importantly, there is a race condition which can result in a case where a BlockingRpcConnection instance has 2 reader threads running. In this case, both are competing for the socket and it causes weird timeouts and in some cases corrupted response (i.e. InvalidProtocolBufferException) # The waitForWork loop does not properly handle interruption. When it gets interrupted, if the above race condition occurs, the waitForWork loop ends up forever being in a tight loop. The ""wait()"" call instantly throws InterruptedException, and we set interrupted state back and restart the loop. So no waiting is occurring anymore. The race condition is somewhat rare, only occurring in certain failure scenarios on our highest volume clients. But when it happens, a low level of errors will forever be thrown for the affected server connection until the client is bounced." Remove numRegions in Region Metrics,13528398,Resolved,Major,Fixed,14/Mar/23 10:39,08/Apr/23 07:11,,"After HBASE-27681, I'd like to refactor region metrics, Then found this issue. We have a metric named `numRegions` in Region Metrics, which I think it's a regionServer metric, but not a region metric. And we do have a `regionCount` metric in RegionServer Metrics. So I think we should delete the `numRegions`." Add biggest cell related info into web ui,13530615,Resolved,Major,Fixed,29/Mar/23 12:42,05/Apr/23 15:20,,"There are some disadvantages to large cell, such as can't be cached or cause memory fragmentation, but currently user can't easily to find them out. My proposal is save len and key of the biggest cell into fileinfo of hfile, and shown on web ui, including two places. 1: Add ""Len Of Biggest Cell"" into main page of regionServer, in here we can find out which regions has large cell by sorting. 2: Add ""Len Of Biggest Cell"" and ""Key Of Biggest Cell"" into region page, in here we can find out the exactly key and the hfile." Implement ClusterManager interface for Kubernetes,13519918,Patch Available,Major,,17/Jan/23 15:55,,,Implement the {{ClusterManager}} interface enough such that we can run the ChaosMonkey against a deployment on Kubernetes. Make request guardrail configs in RSRpcServices live updatable,13530140,Resolved,Major,Fixed,26/Mar/23 18:34,03/Apr/23 21:08,,"We currently have 3 ""guardrail"" like configs in RSRpcServies: hbase.rpc.rows.warning.threshold hbase.rpc.rows.size.threshold.reject hbase.server.scanner.max.result.size It would be useful if these could be updatable with update_config" Release 2.4.16,13522397,Resolved,Major,Fixed,01/Feb/23 06:08,01/Apr/23 00:58,, Push 2.4.16 release out,13523097,Resolved,Major,Fixed,05/Feb/23 10:42,01/Apr/23 00:58,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Add to download page, which is tracked by HBASE-27610 as it requires code change # Push tag 2.4.16RC1 as tag rel/2.4.16 # Release 2.4.16 on jira # Add release data on https://reporter.apache.org/addrelease.html?hbase # Send announcement email" HFileSystem.getLocalFs is not used,13529245,Resolved,Major,Fixed,20/Mar/23 12:47,21/Mar/23 15:03,2.4.15,HFileSystem::getLocalFs not be used by any method in source code，so make a hotfix by removing it. Update the list of prefetched hfiles upon simple block eviction,13529992,Resolved,Major,Fixed,24/Mar/23 15:21,27/Mar/23 10:30,2.6.0,"Currently, we maintain a list of Hfiles on disk for which prefetch is complete and avoid prefetching those files after a restart. But we don't handle cases where blocks are evicted from the cache. This ticket is for updating the list of prefetched files upon simple block eviction." [HBCK2] generateMissingTableDescriptorFile should throw write permission error and fail,13530028,Resolved,Major,Fixed,24/Mar/23 19:19,28/Mar/23 11:09,,"Try running hbck2 generateMissingTableDescriptorFile with a user not having permissions to write to HDFS.  *Actual* The tool completes with success message, while it actually does not really generate/write the files, as it does not even have permissions. *Expected* Tool should throw error and should not log task is success 'Table descriptor written successfully. Orphan table xxxx fixed.' *Debug dump* Upon enabling debug logging, we can see incorrect behaviour. {code:java} 2023-03-24T19:03:16,890 DEBUG [IPC Parameter Sending Thread #0] ipc.Client: IPC Client (199657303) connection to hostname/ip_address:port_num from root sending #31 org.apache.hadoop.hdfs.protocol.ClientProtocol.getFileInfo 2023-03-24T19:03:16,893 DEBUG [IPC Client (199657303) connection to hostname/ip_address:port_num from root] ipc.Client: IPC Client (199657303) connection to hostname/ip_address:port_num from root got value #31 2023-03-24T19:03:16,894 DEBUG [main] ipc.ProtobufRpcEngine: Call: getFileInfo took 4ms 2023-03-24T19:03:16,894 DEBUG [main] hdfs.DFSClient: /apps/hbase/data/data/default/ittable-2090120905/.tmp/.tableinfo.0000000010: masked={ masked: rw-r--r--, unmasked: rw-rw-rw- } 2023-03-24T19:03:16,895 DEBUG [IPC Parameter Sending Thread #0] ipc.Client: IPC Client (199657303) connection to hostname/ip_address:port_num from root sending #32 org.apache.hadoop.hdfs.protocol.ClientProtocol.create 2023-03-24T19:03:16,897 DEBUG [IPC Client (199657303) connection to hostname/ip_address:port_num from root] ipc.Client: IPC Client (199657303) connection to hostname/ip_address:port_num from root got value #32 2023-03-24T19:03:16,898 DEBUG [main] retry.RetryInvocationHandler: Exception while invoking call #32 ClientNamenodeProtocolTranslatorPB.create over null. Not retrying because try once and fail. org.apache.hadoop.ipc.RemoteException: Permission denied: user=root, access=WRITE, inode=""/apps/hbase/data/data/default/ittable-2090120905/.tmp"":hdfs:hdfs:drwxr-xr-x at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.check(FSPermissionChecker.java:399) at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:255) at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:193) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1896) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1880) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkAncestorAccess(FSDirectory.java:1839) at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.resolvePathForStartFile(FSDirWriteFileOp.java:323) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInt(FSNamesystem.java:2513) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFile(FSNamesystem.java:2457) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.create(NameNodeRpcServer.java:791) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.create(ClientNamenodeProtocolServerSideTranslatorPB.java:478) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:528) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1086) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1031) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:959) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1762) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2963) at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1587) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1533) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1430) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:233) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:118) ~[hadoop-common-hadoop_version.jar:?] at com.sun.proxy.$Proxy25.create(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.create(ClientNamenodeProtocolTranslatorPB.java:372) ~[hadoop-hdfs-client-hadoop_version.jar:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:java_version] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:java_version] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:java_version] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:java_version] at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:422) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:165) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:157) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:359) ~[hadoop-common-hadoop_version.jar:?] at com.sun.proxy.$Proxy26.create(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.DFSOutputStream.newStreamForCreate(DFSOutputStream.java:276) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DFSClient.create(DFSClient.java:1222) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DFSClient.create(DFSClient.java:1201) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DFSClient.create(DFSClient.java:1139) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$8.doCall(DistributedFileSystem.java:534) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$8.doCall(DistributedFileSystem.java:531) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem.create(DistributedFileSystem.java:545) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem.create(DistributedFileSystem.java:472) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1125) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1105) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:994) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hbase.HBCKFsTableDescriptors.writeTD(HBCKFsTableDescriptors.java:391) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCKFsTableDescriptors.writeTableDescriptor(HBCKFsTableDescriptors.java:365) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCKFsTableDescriptors.createTableDescriptorForTableDirectory(HBCKFsTableDescriptors.java:439) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCKFsTableDescriptors.createTableDescriptor(HBCKFsTableDescriptors.java:411) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.MissingTableDescriptorGenerator.generateTableDescriptorFileIfMissing(MissingTableDescriptorGenerator.java:93) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:1034) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCK2.run(HBCK2.java:830) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hbase.HBCK2.main(HBCK2.java:1145) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] 2023-03-24T19:03:16,902 DEBUG [main] hbase.HBCKFsTableDescriptors: Failed write and/or rename; retrying org.apache.hadoop.security.AccessControlException: Permission denied: user=root, access=WRITE, inode=""/apps/hbase/data/data/default/ittable-2090120905/.tmp"":hdfs:hdfs:drwxr-xr-x at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.check(FSPermissionChecker.java:399) at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:255) at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:193) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1896) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1880) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkAncestorAccess(FSDirectory.java:1839) at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.resolvePathForStartFile(FSDirWriteFileOp.java:323) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInt(FSNamesystem.java:2513) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFile(FSNamesystem.java:2457) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.create(NameNodeRpcServer.java:791) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.create(ClientNamenodeProtocolServerSideTranslatorPB.java:478) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:528) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1086) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1031) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:959) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1762) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2963) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:java_version] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:java_version] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:java_version] at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[?:java_version] at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:121) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:88) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DFSOutputStream.newStreamForCreate(DFSOutputStream.java:281) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DFSClient.create(DFSClient.java:1222) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DFSClient.create(DFSClient.java:1201) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DFSClient.create(DFSClient.java:1139) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$8.doCall(DistributedFileSystem.java:534) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$8.doCall(DistributedFileSystem.java:531) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem.create(DistributedFileSystem.java:545) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem.create(DistributedFileSystem.java:472) ~[hadoop-hdfs-client-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1125) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:1105) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:994) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hbase.HBCKFsTableDescriptors.writeTD(HBCKFsTableDescriptors.java:391) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCKFsTableDescriptors.writeTableDescriptor(HBCKFsTableDescriptors.java:365) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCKFsTableDescriptors.createTableDescriptorForTableDirectory(HBCKFsTableDescriptors.java:439) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCKFsTableDescriptors.createTableDescriptor(HBCKFsTableDescriptors.java:411) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.MissingTableDescriptorGenerator.generateTableDescriptorFileIfMissing(MissingTableDescriptorGenerator.java:93) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:1034) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hbase.HBCK2.run(HBCK2.java:830) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hbase.HBCK2.main(HBCK2.java:1145) ~[hbase-hbck2-hbase_op_tools_version.jar:hbase_op_tools_version] Caused by: org.apache.hadoop.ipc.RemoteException: Permission denied: user=root, access=WRITE, inode=""/apps/hbase/data/data/default/ittable-2090120905/.tmp"":hdfs:hdfs:drwxr-xr-x at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.check(FSPermissionChecker.java:399) at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:255) at org.apache.hadoop.hdfs.server.namenode.FSPermissionChecker.checkPermission(FSPermissionChecker.java:193) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1896) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkPermission(FSDirectory.java:1880) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.checkAncestorAccess(FSDirectory.java:1839) at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.resolvePathForStartFile(FSDirWriteFileOp.java:323) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInt(FSNamesystem.java:2513) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFile(FSNamesystem.java:2457) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.create(NameNodeRpcServer.java:791) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.create(ClientNamenodeProtocolServerSideTranslatorPB.java:478) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:528) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1086) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1031) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:959) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1762) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2963) at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1587) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1533) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1430) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:233) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:118) ~[hadoop-common-hadoop_version.jar:?] at com.sun.proxy.$Proxy25.create(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.create(ClientNamenodeProtocolTranslatorPB.java:372) ~[hadoop-hdfs-client-hadoop_version.jar:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:java_version] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:java_version] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:java_version] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:java_version] at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:422) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:165) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:157) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95) ~[hadoop-common-hadoop_version.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:359) ~[hadoop-common-hadoop_version.jar:?] at com.sun.proxy.$Proxy26.create(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.DFSOutputStream.newStreamForCreate(DFSOutputStream.java:276) ~[hadoop-hdfs-client-hadoop_version.jar:?] ... 21 more 2023-03-24T19:03:16,907 DEBUG [IPC Parameter Sending Thread #0] ipc.Client: IPC Client (199657303) connection to hostname/ip_address:port_num from root sending #33 org.apache.hadoop.hdfs.protocol.ClientProtocol.getFileInfo 2023-03-24T19:03:16,908 DEBUG [IPC Client (199657303) connection to hostname/ip_address:port_num from root] ipc.Client: IPC Client (199657303) connection to hostname/ip_address:port_num from root got value #33 2023-03-24T19:03:16,908 DEBUG [main] ipc.ProtobufRpcEngine: Call: getFileInfo took 2ms 2023-03-24T19:03:16,908 WARN [main] hbase.HBCKFsTableDescriptors: Failed cleanup of hdfs://hostname:port_num/apps/hbase/data/data/default/ittable-2090120905/.tmp/.tableinfo.0000000010 2023-03-24T19:03:16,909 INFO [main] hbase.MissingTableDescriptorGenerator: Table descriptor written successfully. Orphan table ittable-2090120905 fixed. {code}  " [hbase-operator-tools] Use $revision as placeholder for maven version,13527662,Resolved,Major,Fixed,08/Mar/23 16:11,16/Mar/23 13:03,hbase-operator-tools-1.3.0,To align with our main repo. Replication threads not attached to their parent process,13530223,Open,Major,,27/Mar/23 10:16,,2.5.4,"While debugging HBASE-27707 in a unit test, I see behaviour that I cannot explain. My test uses a minicluster, enables read replica replication, writes some data, concurrently kills a region server thread hosting a primary region, and then verifies that all replicas eventually show all data. Inspecting logs, noticed that replication source threads seem to continue working even after their associated region server is killed. Interspersing some thread dumps and sleeps, I can see that replication threads associated with the condemned region server are not being removed after it is killed. I think that this behaviour will render unreliably any replication test that relies on killing a source or sink region server. It also implies to me that the minicluster leaks replication threads and cannot be reliably recycled within a single jvm process." Bump jettison from 1.5.2 to 1.5.4,13529910,Resolved,Major,Fixed,24/Mar/23 06:22,24/Mar/23 14:04,, Document protoc workarounds with Apple Silicon,13529760,Resolved,Major,Fixed,23/Mar/23 12:16,23/Mar/23 16:20,,"Building hbase 2.x on Apple Silicon is difficult because there is no protoc library available. [~ndimiduk] added a solution in HBASE-27741 to use osx-x86_64 but it is also possible to build protoc locally and use that." Scan handlers in the RPC executor should match at least one scan queues,13526482,Resolved,Major,Fixed,28/Feb/23 08:29,22/Mar/23 00:13,2.5.3,"This issue is try to avoid NO scan queues for some scan handlers. For example, if we set hbase.regionserver.handler.count=150, hbase.ipc.server.callqueue.scan.ratio=0.1, hbase.ipc.server.callqueue.read.ratio=0.5, hbase.ipc.server.callqueue.handler.factor=0.1, then there will be 150 * 0.5 * 0.1 = 7 scan handlers, but there are 150 * 0.1 * 0.5 * 0.1 = 0 scan RPC queues. When there are no scan rpc queues, all the scan and get requests will be dispatched to the read rpc queues, while we we thought they had been dealt with separately, since the scan handler count is not 0. When there are not enough handlers for large scan requests under this circumstance, the small get requests will be blocked in the rpc queues. We can see from the codes, {code:java} int scanQueues = Math.max(0, (int) Math.floor(readQueues * callqScanShare)); int scanHandlers = Math.max(0, (int) Math.floor(readHandlers * callqScanShare)); if ((readQueues - scanQueues) > 0) { readQueues -= scanQueues; readHandlers -= scanHandlers; } else { scanQueues = 0; scanHandlers = 0; } {code} when readQueues * callqScanShare < 1 but readHandlers * callqScanShare > 1, there will be some iddle scan handlers with NO scan queues." Client metrics for user region lock related behaviors.,13526924,Resolved,Major,Fixed,03/Mar/23 01:11,21/Mar/23 23:46,2.0.0, Fix brotli4j licence issue on native-osx-aarch64,13528847,Resolved,Major,Duplicate,16/Mar/23 18:45,21/Mar/23 20:34,,Apparently the licence of {{brotli4j}} is malformed and fixed in {{{}supplemental-models.xml{}}}. It didn't however cover {{native-osx-aarch64}} yet. Update documentation about how to enable encryption on WAL,13528811,Resolved,Major,Fixed,16/Mar/23 14:50,20/Mar/23 10:50,,"After HBASE-27632 and HBASE-27702, we removed SecureProtobufLogReader and SecureProtobufLogWriter, users do not need to specify the reader/writer class any more, they just need to enable WAL encryption. Remove the related configurations such as 'hbase.regionserver.hlog.writer.impl' and 'hbase.regionserver.hlog.reader.impl' in hbase-default.xml, and also change ref guide to tell users how to enable WAL encryption for 2.6+." Remove 'hbase.regionserver.hlog.writer.impl' config,13527996,Resolved,Major,Fixed,10/Mar/23 15:16,20/Mar/23 03:13,,"We do not support sequence file based WAL file any more, and we should also automatically choose SecureProtobufWALWriter if WAL entryption is enabled. This is a follow up issue for HBASE-27632." Missed one parameter when logging exception in StoreFileListFile,13528934,Resolved,Major,Fixed,17/Mar/23 09:45,19/Mar/23 12:10,,"At line 265 {code} LOG.debug(""Failed to delete old track file {}, ignoring the exception"", e); {code} Should add 'trackFiles[nextTrackFile]' before 'e'." Skip hbase:meta table scan if the normalizer not enabled for any of the tables as well as default table wise normalization disabled,13529242,Open,Major,,20/Mar/23 12:29,,,"Currently when the zk data is null considering normaliser on which leads to unnecessary hbase meta scans. Would be better to scan through meta only when normalizer enabled explictly. {noformat} public boolean isNormalizerOn() { byte[] upData = super.getData(false); try { // if data in ZK is null, use default of on. return upData == null || parseFrom(upData).getNormalizerOn(); } catch (DeserializationException dex) { LOG .error(""ZK state for RegionNormalizer could not be parsed "" + Bytes.toStringBinary(upData)); // return false to be safe. return false; } } {noformat} {noformat} public boolean normalizeRegions(final NormalizeTableFilterParams ntfp, final boolean isHighPriority) throws IOException { if (regionNormalizerManager == null || !regionNormalizerManager.isNormalizerOn()) { LOG.debug(""Region normalization is disabled, don't run region normalizer.""); return false; } if (skipRegionManagementAction(""region normalizer"")) { return false; } if (assignmentManager.hasRegionsInTransition()) { return false; } final Set matchingTables = getTableDescriptors(new LinkedList<>(), ntfp.getNamespace(), ntfp.getRegex(), ntfp.getTableNames(), false).stream() .map(TableDescriptor::getTableName).collect(Collectors.toSet()); final Set allEnabledTables = tableStateManager.getTablesInStates(TableState.State.ENABLED); {noformat}" Refactor WAL.Reader implementation so we can better support WAL splitting and replication,13524168,Resolved,Major,Fixed,10/Feb/23 07:32,10/Mar/23 15:04,,"WAL splitting and replication has completely different requirements on WAL reader, the latter one is much comlicated as it wants to tail a WAL file which is currently being written. I think split them into two classes is better here. But we exposes two configurations out 'hbase.regionserver.hlog.reader.impl' 'hbase.regionserver.hlog.writer.impl' which indicates that we only have one implementation for wal reader. These two configurations are inrtoduced in 0.96, for reading the pre 0.94 sequence file format WAL file. And starting from 2.0.0, we have already dropped the support of reading sequence file format WAL file, so I think the configurations are useless now. Now we stil require users to specify SecureProtobufLogReader and SecureProtobufLogWriter when enable WAL encryption, but actually they are both the only choice, so just use 'hbase.regionserver.wal.encryption' to determine whether we need to use SecureProtobufLogWriter to write WAL. And for reading, I do not think we should rely on the configuration, we should detect whether the WAL file itself is encrypted(I believe we have already done this in SecureProtobufLogReader.readHeader. So in general, I prefer we just mark these two configurations deprecated and do not use them in our code base, so we can have different Reader implementations for WAL splitting and replication." ByteBuff ref counting is too expensive for on-heap buffers,13528263,Resolved,Major,Fixed,13/Mar/23 15:42,17/Mar/23 19:26,,"We recently were upgrading an internal project's hbase client from 1.2 to 2.5. The project does raw HFile.Reader reading of some hfiles. We noticed an over 4x performance regression with the new client. Profiling showed that the majority of the time was spent in SingleByteBuff.checkRefCount. That ref counting is necessary for off-heap reads, but this case was using on-heap. Removing checkRefCount eliminated the regression. I asked on the dev list and we agreed to remove checkRefCount calls for on-heap buffers: https://lists.apache.org/thread/2qm0g8fbxb0no4ozfx7bw8xmkryt4zz0" CPU hot-spot resolving User subject,13528239,Resolved,Major,Fixed,13/Mar/23 13:20,16/Mar/23 12:58,2.5.0,"Even with OpenTelemetry tracing disabled, we see contention related to populating the string representation of the User principle on the client side. Can HBase connection cache this?" HBase blocking thread on java.util.concurrent.ConcurrentHashMap.computeIfAbsent,13528889,Open,Major,,17/Mar/23 03:31,,,"Made hbase pe RandomRead test for 100% memory-cache in HBase 2.5.0 before. We found that there are many blocking regionserver handler threads, and our cpu utilisation percentage is about 50% and cannot increase anymore. Here is the blocking stack: RpcServer.default.FPBQ.Fifo.handler=116,port=16020"" #299 daemon prio=5 os_prio=0 tid=0x0000ffff825d5000 nid=0x208e51 waiting for monitor entry [0x0000ffbe67734000]     java.lang.Thread.State: BLOCKED (on object monitor)      at java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1674)      - waiting to lock <0x0000fff75f465128> (a java.util.concurrent.ConcurrentHashMap$Node)      at org.apache.hadoop.hbase.regionserver.MetricsTableQueryMeterImpl.getOrCreateTableMeter(MetricsTableQueryMeterImpl.java:77)      at org.apache.hadoop.hbase.regionserver.MetricsTableQueryMeterImpl.updateTableReadQueryMeter(MetricsTableQueryMeterImpl.java:82)      at org.apache.hadoop.hbase.regionserver.RegionServerTableMetrics.updateTableReadQueryMeter(RegionServerTableMetrics.java:93)      at org.apache.hadoop.hbase.regionserver.MetricsRegionServer.updateReadQueryMeter(MetricsRegionServer.java:283)      at org.apache.hadoop.hbase.regionserver.HRegion.metricsUpdateForGet(HRegion.java:7401)      at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2667)      at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2567)      at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45945)      at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:385)      at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)      at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)      at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82)       " Client-side lock contention around Configuration when using read replica regions,13525193,Resolved,Major,Fixed,17/Feb/23 11:40,15/Mar/23 15:09,2.5.1,Since upgrading to 2.5.1 our client-side application has noticed lock contention. Regions permanently stuck in unknown_server state,13528304,Open,Major,,13/Mar/23 21:20,,2.4.11,"We see this log message and the regions listed are never put back into service without manual intervention: {code:java} NodeC hbasemaster-0 hbasemaster 2023-02-15 14:15:56,149 WARN  [master/NodeC:16000.Chore.1] janitor.CatalogJanitor: unknown_server=NodeA,16201,1676468874221/__test-table_NodeA__,,1672786676251.a3cac9159205d7611c85dd5c4feeded7., unknown_server=NodeA,16201,1676468874221/__test-table_NodeB__,,1672786676579.50e948f0a5bc962aabfe27e9ea4227a5., unknown_server=NodeA,16201,1676468874221/aeris_v2,,1672786736251.6ab0292cca294784bce8415cc69c30d4., unknown_server=NodeA,16201,1676468874221/aeris_v2,\x06,1672786736251.15d958805892370907a47f31a6e08db1., unknown_server=NodeA,16201,1676468874221/aeris_v2,\x12,1672786736251.ac3c78ff6903f52d9e2acf80b8436085.{code}   Normally when we see these unknown_server logs, they do get resolved by reassigning the regions, however we have a reproducible case where this doesn't happen. When this occurs we also see the following log messages related to the regions: {code:java} NodeC hbasemaster-0 hbasemaster 2023-02-15 14:10:59,810 WARN  [RpcServer.priority.RWQ.Fifo.write.handler=0,queue=0,port=16000] assignment.AssignmentManager: Reporting NodeC,16201,1676469549542 server does not match state=OPEN, location=NodeA,16201,1676468874221, table=aeris_v2, region=6ab0292cca294784bce8415cc69c30d4 (time since last update=3749ms); closing… NodeC hbasemaster-0 hbasemaster 2023-02-15 14:11:00,323 WARN  [RpcServer.priority.RWQ.Fifo.write.handler=0,queue=0,port=16000] assignment.AssignmentManager: No matching procedure found for C,16201,1676469549542 transition on state=OPEN, location=NodeA,16201,1676468874221, table=aeris_v2, region=6ab0292cca294784bce8415cc69c30d4 to CLOSED {code}   This suggests that the master has a different mapping of region to region server than is expected so it closes the region. We would expect that the regions get assigned somewhere else and then reopened, but we are not seeing that. This log message comes from here: [https://github.com/apache/hbase/blob/branch-2.4/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1292] The next thing that is done is calling AssignmentManager's closeRegionServerSilently method. Our setup: We have a three server cluster that runs a full HBASE stack: 3 zookeeper nodes, an HBASE master active and standby, 3 region servers, 3 HDFS data nodes. For reliability testing we are running a script that will restart one of the three servers, which will have running on it a region server, zookeeper and HDFS process, and possibly also the HBASE master primary or standby. In this test we saw the issue after NodeB had been killed at 14:08:33, which had been running the active master, so the master did switchover to NodeC. Then at 14:12:56 we saw a ""STUCK Region-In-Transition"" log for a region on NodeA (this is another common reproducible issue we plan to open a ticket for) and then restarted just the region server process on NodeA to get that region reassigned." Fix TestWALOpenAfterDNRollingStart,13528403,Resolved,Major,Fixed,14/Mar/23 10:49,15/Mar/23 03:09,,"Just a test issue, should use NoEOF reader." WALEntryStreamTestBase creates a new HBTU in startCluster method which causes all sub classes are testing default configurations,13528401,Resolved,Major,Fixed,14/Mar/23 10:47,15/Mar/23 03:09,,"Should be a typo... Let's fix this..." "HFile splitting occurs during bulkload, the CREATE_TIME_TS of hfileinfo is 0",13527158,Resolved,Major,Fixed,06/Mar/23 02:45,15/Mar/23 00:26,,"If HFile splitting occurs during bulkload, the CREATE_TIME_TS of hfileinfo =0,When HFile is copied after splitting, CREATE_TIME_TS of the original file is not copied。 {code:java} ##BulkLoadHFilesTool.class /** * Copy half of an HFile into a new HFile. */ private static void copyHFileHalf(Configuration conf, Path inFile, Path outFile, Reference reference, ColumnFamilyDescriptor familyDescriptor) throws IOException { FileSystem fs = inFile.getFileSystem(conf); CacheConfig cacheConf = CacheConfig.DISABLED; HalfStoreFileReader halfReader = null; StoreFileWriter halfWriter = null; try { 。。。 HFileContext hFileContext = new HFileContextBuilder().withCompression(compression) .withChecksumType(StoreUtils.getChecksumType(conf)) .withBytesPerCheckSum(StoreUtils.getBytesPerChecksum(conf)).withBlockSize(blocksize) .withDataBlockEncoding(familyDescriptor.getDataBlockEncoding()).withIncludesTags(true) .build(); // TODO .withCreateTime(EnvironmentEdgeManager.currentTime())       halfWriter = new StoreFileWriter.Builder(conf, cacheConf, fs).withFilePath(outFile) .withBloomType(bloomFilterType).withFileContext(hFileContext).build(); HFileScanner scanner = halfReader.getScanner(false, false, false); scanner.seekTo(); do { halfWriter.append(scanner.getCell()); } while (scanner.next()); for (Map.Entry entry : fileInfo.entrySet()) { if (shouldCopyHFileMetaKey(entry.getKey())) { halfWriter.appendFileInfo(entry.getKey(), entry.getValue()); } } } finally { 。。。 } } ##get lastMajorCompactionTs metric lastMajorCompactionTs = this.region.getOldestHfileTs(true); ... long now = EnvironmentEdgeManager.currentTime(); return now - lastMajorCompactionTs; ... ## public long getOldestHfileTs(boolean majorCompactionOnly) throws IOException { long result = Long.MAX_VALUE; for (HStore store : stores.values()) { Collection storeFiles = store.getStorefiles(); ... for (HStoreFile file : storeFiles) { StoreFileReader sfReader = file.getReader(); ... result = Math.min(result, reader.getFileContext().getFileCreateTime()); } } return result == Long.MAX_VALUE ? 0 : result; }{code}  " LEAK: RefCnt.release() was not called before it's garbage-collected in regionserver,13528670,Open,Major,,15/Mar/23 16:57,,2.5.2,"2023-03-15 07:15:12,119 ERROR [RpcServer.default.FPBQ.Fifo.handler=50,queue=2,port=16020] util.ResourceLeakDetector: LEAK: RefCnt.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information. Recent access records: Created at:         org.apache.hadoop.hbase.nio.RefCnt.(RefCnt.java:59)         org.apache.hadoop.hbase.nio.RefCnt.create(RefCnt.java:54)         org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.(MemStoreLABImpl.java:108)         sun.reflect.GeneratedConstructorAccessor34.newInstance(Unknown Source)         sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)         java.lang.reflect.Constructor.newInstance(Constructor.java:423)         org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:54)         org.apache.hadoop.hbase.util.ReflectionUtils.instantiateWithCustomCtor(ReflectionUtils.java:42)         org.apache.hadoop.hbase.regionserver.MemStoreLAB.newInstance(MemStoreLAB.java:116)         org.apache.hadoop.hbase.regionserver.SegmentFactory.createMutableSegment(SegmentFactory.java:81)         org.apache.hadoop.hbase.regionserver.AbstractMemStore.resetActive(AbstractMemStore.java:93)         org.apache.hadoop.hbase.regionserver.AbstractMemStore.(AbstractMemStore.java:83)         org.apache.hadoop.hbase.regionserver.DefaultMemStore.(DefaultMemStore.java:78)         sun.reflect.GeneratedConstructorAccessor62.newInstance(Unknown Source)         sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)         java.lang.reflect.Constructor.newInstance(Constructor.java:423)         org.apache.hadoop.hbase.util.ReflectionUtils.instantiate(ReflectionUtils.java:54)         org.apache.hadoop.hbase.util.ReflectionUtils.newInstance(ReflectionUtils.java:91)         org.apache.hadoop.hbase.regionserver.HStore.getMemstore(HStore.java:371)         org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:280)         org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6359)         org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1114)         org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1111)         java.util.concurrent.FutureTask.run(FutureTask.java:266)         java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)         java.util.concurrent.FutureTask.run(FutureTask.java:266)         java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         java.lang.Thread.run(Thread.java:748)" Add group of regionServer on Master webUI,13523133,Resolved,Major,Fixed,06/Feb/23 04:03,14/Mar/23 06:11,,"We do have a RSGroupList on webUI now, but it is still a little inconvenient if I just want to know which group a specific regionServer belongs to. So add this info on webUI: !image-2023-02-06-12-04-03-503.png|width=889,height=174!" Refactor Table Latency Metrics,13526712,Resolved,Major,Fixed,01/Mar/23 15:56,08/Mar/23 15:22,,"Benefit: # Table Latency Metrics could removed after table has been moved away. Fix HBASE-27617 # Could remove the hash lookup caused by metrics map from the hot request path. # Reduce the output in jmx. As if we use jmx_exporter to collect metrics to Prometheus, the operation overhead of performing regular matching in metric is relatively high(especially region metrics, which might be next step). # I think that could be the first step after hbase-metrics released. It seems that the roadmap indicates that we should replace directly use hadoop-metrics2 with hbase-metrics. Influence: # The metrics structure in jmx will change. Old: !image-2023-03-01-23-55-14-095.png|width=450,height=407! New: !image-2023-03-01-23-56-16-819.png|width=615,height=479!" Update ref guide about how to enable WAL encryption,13527997,Open,Major,,10/Mar/23 15:17,,,"AFter HBASE-27632 and HBASE-27702, we do not need to specify the WAL implementation any more. Update ref guide about this change." chaos-daemon.sh should make use hbase script start/stop chaosagent and chaos monkey runner.,13526282,Resolved,Major,Fixed,27/Feb/23 07:46,09/Mar/23 02:58,,"Currently chaos-daemon.sh  is just adding the libs from HBASE_HOME which is failing because hadoop dependencies not present in the classpath would be better to use hbase script which adds all the relevant jars from different classpaths like HBASE_CLASSPATH and Hadoop paths so that things works as expected . " Create a dummy metric implementation in ConnectionImplementation.,13527855,Open,Major,,09/Mar/23 16:45,,2.5.0,"This Jira is for branch-2 only. If CLIENT_SIDE_METRICS_ENABLED_KEY conf is set to true, then we initialize metrics to MetricsConnection, otherwise it is set to null. {code:java} if (conf.getBoolean(CLIENT_SIDE_METRICS_ENABLED_KEY, false)) { this.metricsScope = MetricsConnection.getScope(conf, clusterId, this); this.metrics = MetricsConnection.getMetricsConnection(this.metricsScope, this::getBatchPool, this::getMetaLookupPool); } else { this.metrics = null; } {code} Whenever we want to update metrics, we always do a null check. We can improve this by creating a dummy metrics object and have an empty implementation. When we want to populate the metrics, we can check if metrics is an instance of dummy metrics." Document zookeeper based cluster manager,13526364,In Progress,Major,,27/Feb/23 16:41,,, Make metrics from MetricsTableLatenciesImpl removable,13523471,Resolved,Major,Won't Do,07/Feb/23 10:07,09/Mar/23 02:06,,"Now the table latency metrics will last forever on a RS. Could reproduce this issue easily: 1. Create a test table and the region opened on RS_A; 2. Do a query; 3. Move the table to another group; 4. See JMX on RS_A, table latency metrics still exists and will not deleted." "Backport ""HBASE-27681 Refactor Table Latency Metrics"" to branch-2",13527572,Resolved,Major,Invalid,08/Mar/23 03:54,08/Mar/23 15:30,, Standby masters appear to not purge their old write-ahead logs,13527641,Open,Major,,08/Mar/23 13:32,,2.5.0,"Dropping this one here, haven't investigated yet. We noticed that on a cluster who's elected master had been active for quite a long time that the master store wal directory steadily grew in size. Failing over master cause the directory to be cleaned up." Fake Cell is being passed to Filters and comparators during StoreFileScans,13527520,Open,Major,,07/Mar/23 21:54,,2.2.7,"I am trying to upgrade HBase version (client and server) from 1.2.0 to 2.2.6 and started seeing some unexpected behavior around discovery of ambiguous row in filter during StoreFileScans. *Is it a valid case that filters and Comparators might see a fake cell passed to them if that row is set as an inclusive(by default) start row to skip preceding row during Store file scans during client side execution?* When rows were persisted or updated on a table through bulkload, looks like a scan with specific column triggers a different behavior compared to a scan without columns which doesn't trigger this behavior. From what I have troubleshooted so far, it looks like this is triggered during [lazy scan|https://github.com/apache/hbase/blob/rel/2.2.6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java#L251-L256] inside [StoreScanner|https://github.com/apache/hbase/blob/rel/2.2.6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java#L406-L410] with [StoreFileScanner|https://github.com/apache/hbase/blob/rel/2.2.6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java#L388-L448] implementation where it eventually returns fake cell as current row on store heap [StoreFileScanner|https://github.com/apache/hbase/blob/rel/2.2.6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java#L437-L444] thus passed to filter but it's actually filtered later and not returned to client. This was not the case with hbase 1.7.2. I have created couple of simple Tests using hbase 1.7.2 and hbase 2.2.6 that bulkloads some sample rows to table and creates a column specific Scan to reproduce behavior that I have been talking about. I have simply copied KeyOnlyFilter, added few loggers to catch rowkeys being passed to filter and added few loggers to catch row keys returned as a result on client side. Here is my working repo that demonstrate this diverged behavior [hbase-scans|https://github.com/tejkiran/hbase-scans] I have a mapper that creates PUT with row keys 0, 2, 3 and bulkload those rows to table. When a scan is issued with 2.2.6 hbase API, it parses that start row on Scan to filter during server side execution. Screenshot of discovered row keys in filter during server side . !image-2023-03-07-15-46-01-182.png! Screenshoot of discovered row keys in filter with hbase 1.7.2 !image-2023-03-07-15-50-59-696.png!          " Update README.md about how to request a jira account,13527185,Resolved,Major,Fixed,06/Mar/23 07:40,07/Mar/23 02:17,,"Recently INFRA team developped a self serving tool for requesting jira account. https://selfserve.apache.org/jira-account.html So we no longer need to let contributor to send email to private@hbase, jsut let them go to this page and submit the request." Improve FSUtils to directly obtain FSDataOutputStream,13526311,Resolved,Major,Fixed,27/Feb/23 10:03,04/Mar/23 14:59,,"hbase interacts with hdfs and obtains FSDataOutputStream to generate HFiles. In order to support favoredNodes, reflection is used. The DistributedFileSystem has a more direct way to get the FSDataOutputStream，for example:dfs.createFile(path).permission(perm).create()...;  this API allows you to set various parameters, including favoredNodes. I think avoiding reflection can improve performance, and if you agree with me, I can optimize this part of the code; Model:hbase-server class:FSUtils   {code:java} public static FSDataOutputStream create(Configuration conf, FileSystem fs, Path path, FsPermission perm, InetSocketAddress[] favoredNodes) throws IOException { if (fs instanceof HFileSystem) { FileSystem backingFs = ((HFileSystem) fs).getBackingFs(); if (backingFs instanceof DistributedFileSystem) { // Try to use the favoredNodes version via reflection to allow backwards- // compatibility. short replication = Short.parseShort(conf.get(ColumnFamilyDescriptorBuilder.DFS_REPLICATION, String.valueOf(ColumnFamilyDescriptorBuilder.DEFAULT_DFS_REPLICATION))); try { return (FSDataOutputStream) (DistributedFileSystem.class .getDeclaredMethod(""create"", Path.class, FsPermission.class, boolean.class, int.class, short.class, long.class, Progressable.class, InetSocketAddress[].class) .invoke(backingFs, path, perm, true, CommonFSUtils.getDefaultBufferSize(backingFs), replication > 0 ? replication : CommonFSUtils.getDefaultReplication(backingFs, path), CommonFSUtils.getDefaultBlockSize(backingFs, path), null, favoredNodes));{code}" Chaos Service Improvements,13526363,In Progress,Major,,27/Feb/23 16:36,,,"We can improve the usage of chaos service to run random operations in the real cluster to verify the stability. Following things can be done. 1) Make use of the hbase script in the existing chaos-daemon.sh script instead of directly using the java command. 2) We can add a script to chaos server runner to run the script in the background. 3) Document usage of zookeeper based cluster manager mainly in the environments where ssh cannot be performed. 4) sudo is not required to kill the it's own user process so while running the commands need not use sudo." "Bump hbase, hbase-thirdparty, hadoop and spark for hbase-connectors",13526695,Resolved,Major,Fixed,01/Mar/23 14:05,03/Mar/23 09:00,,"Will update following as part of this JIRA * HBase: 2.4.16 * HBase thirdparty: 4.1.4 (See [https://github.com/apache/hbase/blob/d1714710877653691e2125bd94b68a5b484a3a06/pom.xml#L634]) * Hadoop3: 3.2.4 (We are bumping to latest stable 3.2.x) * Hadoop2: 2.10.0 (See  * [https://github.com/apache/hbase/blob/d1714710877653691e2125bd94b68a5b484a3a06/pom.xml#L543]) * Spark: 3.2.3 * Scala binary: 2.12 (See [https://github.com/apache/spark/blob/b53c341e0fefbb33d115ab630369a18765b7763d/pom.xml#L164])  * Scala: 2.12.15 (See [https://github.com/apache/spark/blob/b53c341e0fefbb33d115ab630369a18765b7763d/pom.xml#L163])" ReplaySyncReplicationWALCallable should consider WAL files which are not closed cleanly,13526506,Resolved,Major,Duplicate,28/Feb/23 11:03,02/Mar/23 14:05,,"Be more specfic, we need to deal with EOFException, instead of throwing everything out, like the WALSplitter." Allow preCompact hooks to return scanners whose cells can be shipped,13526137,Resolved,Major,Fixed,25/Feb/23 00:49,28/Feb/23 19:04,,"In [Compactor.java#L492|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java#L492], when the compaction scanner extends KeyValueScanner, we call shipped() periodically. This releases shared buffers which makes compactions less memory hungry. When a preCompact hook returns a custom scanner, that scanner is unlikely to extend KeyValueScanner. So installing a preCompact hook can cause a regression in terms of memory pressure. KeyValueScanner is a large interface with many methods, but the method being called (shipped()) is actually on the Shipper interface (which KeyValueScanner extends). It would be nice to allow coprocessors to more easily integrate here. I can think of two options: # Simply change the cast on [line 436|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java#L436] from KeyValueScanner to Shipper. A coprocessor can easily return an InternalScanner impl which also extends Shipper since it's just one method. A common pattern will likely be to delegate to the underlying real scanner. # Add a new DelegateInternalScanner which coprocessors can return. In that case, call scanner.getDelegate() and check if _that_ extends KeyValueScanner. I prefer option 1 as it's very simple and makes it really easy to reason about – a coprocessor may not _want_ to release cells, in which case they don't need to extend Shipper. The downside of this is we'd have to promote Shipper interface to IA.LimitedPrivate(COPROC) Option 2 could open us to other possibilities in the future, and could be configurable. Like maybe it has a scanner.supportsShipped() or something. If true, the underlying scanner's shipped method will be called. If not, it won't. Barring other opinions, I will go with option 1 as it's trivial. cc [~anoopsamjohn] since you were involved in the linked change and the creation of Shipper interface. In the linked code, we don't use any other method on KeyValueScanner interface so it seems totally fine to use Shipper instead." Cannot Specify Namespace via the hbase.table Option in Spark Connector,13523883,Resolved,Major,Fixed,09/Feb/23 06:16,09/Feb/23 13:37,hbase-connectors-1.0.1,"When using the old mapping format and specifying the HBase table via the  _hbase.table_ option, the connector passes the namespaced string to HBase, and we get {noformat} Caused by: java.lang.IllegalArgumentException: Illegal character code:58, <:> at 7. User-space table qualifiers may only contain 'alphanumeric characters' and digits: staplesHbaseNamespace:staplesHbaseTableName at org.apache.hadoop.hbase.TableName.isLegalTableQualifierName(TableName.java:187) at org.apache.hadoop.hbase.TableName.isLegalTableQualifierName(TableName.java:138) at org.apache.hadoop.hbase.TableName.(TableName.java:320) at org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:354) at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:484){noformat} This seems to be related to the changes in HBASE-24276" Merging empty regions corrupts meta cache,13525124,Resolved,Major,Fixed,17/Feb/23 03:19,28/Feb/23 02:18,,"Let's say you have three regions with start keys A, B, C and all are cached in the meta cache. Region B is empty and not getting any requests, and all 3 regions are merged together. The new merged region has start key A. A user submits a request for row C1, which would previously have gone to region C. That region no longer exists, so the MetaCache returns region C, the request goes out to the server which throws NotServingRegionException. That region C is now removed from the cache, and meta is scanned. The meta scan returns the newly merged region A, which is cached into the MetaCache. So now we have a MetaCache where A has been updated with the newly merged RegionInfo, B still exists with the old/deleted RegionInfo, and C has been removed. A user submits a request for row C1 again. This _should_ go to region A, but we do cache.floorEntry(C1) which returns the old but still cached region B. We have checks in MetaCache which validate the RegionInfo.getEndKey() against the requested row, and that validation fails because C1 is beyond the endkey of the old region. The cached region B result is ignored and cache returns null. Meta is scanned, and returns the new region A, which is cached again. Requests to rows C1+ will still succeed... but they will always require a meta scan because the meta cache will always return that old region B which is invalid and doesn't contain the C1+ rows. Currently, the only way this will ever resolve is if a request is sent to region B, which will cause a NotServingRegionException which will finally clear region B from the cache. At that point, requests for C1+ will properly get resolved to region A in the cache. I've created a reproducible test case here: [https://gist.github.com/bbeaudreault/c82ff9f8ad0b9424eb987483ede35c12] This problem affects both AsyncTable and branch-2's Table.  " Fix the cached block differ (which should not have happened) issue with cacheDataOnWrite on,13525007,Open,Major,,16/Feb/23 11:03,,2.5.3,"When caching the block by reading from hfile, the block cached will contains a header with the next block info. But when caching the block by writing when cacheDataOnWrite is on, the block cached without the header of the next block info. Then when comparing the old and new blocks in BlockCacheUtil#validateBlockAddition, it will print error logs , {code:java} hfile.BlockCacheUtil: Cached block contents differ, which should not have happened. cacheKey:XXX {code} This will harm the actual replacement of the cached block, since we should replace or not when the cached block contents differ by nextBlockOnDiskSize. " WALPlayer does not properly dedupe overridden cell versions,13525081,Resolved,Major,Fixed,16/Feb/23 20:20,25/Feb/23 20:15,,"If you do 2 Puts to a cell with different values but the same timestamp, the latest one will win. This is because in the memstore we use a sequenceId as a tie breaker for duplicate timestamps. When the data is flushed to a StoreFile, the deduplication will occur and eventually the sequenceId will be dropped. Those 2 Puts would have been added to the WAL, and if you use WALPlayer to replay those WALs (as anyone could do, but also as backup/restore does for incremental restores) it will not properly do the same thing. It's unclear which of the duplicate cells you will get, when you should always get the latest. Our WAL encoder doesn't include the sequenceIds in the WALEntry cells. Instead the WALKey has a getSequenceId() which contains the same sequenceId the cells used to have. In WALCellMapper we don't pass those along, nor in CellSerialization, and thus CellSortReducer is not able to use the sequenceId to dedupe. I think we just need to translate the WALKey.getSequenceId() into the output Cells in WALCellMapper, then update CellSerialization to include them as well. At that point CellSortReducer should work as expected, and we should get the correct cell values in the hfiles. One open question is whether we should clear out the sequenceId before flushing to the hfile. I don't think so?" Set size of systable queue in UT,13525833,Resolved,Major,Fixed,23/Feb/23 06:52,25/Feb/23 15:58,,"TestSlowLogAccessor#testHigherSlowLogs failed in my CI pipeline. !image-2023-02-23-14-52-38-867.png|width=654,height=409! !image-2023-02-23-14-53-02-177.png|width=702,height=328! SlowLogPersistentService use an [EvictingQueue|https://github.com/apache/hbase/blob/22dbb7afc383b9b9a8678f2c9eca1dca31784615/hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/SlowLogPersistentService.java#L58] to handle slowLogs. and default size is 1000. So when the write speed is fast, this UT cannot guarantee that more than 2000 slowLogs will be stored in the table (they will be evicted in the queue)." Update checkstyle in hbase-operator-tools,13526049,Resolved,Major,Fixed,24/Feb/23 10:15,26/Feb/23 11:52,hbase-operator-tools-1.2.0,The checkstyle dependency is vulnerable in hbase-operator-tools. RS crash on ipc request to big,13526040,Open,Major,,24/Feb/23 09:46,,," 2023-02-17 16:44:09,601 WARN  [RS-EventLoopGroup-1-46] ipc.NettyRpcServer: RPC data length of 825701220 received from client_ip1 is greater than max allowed 268435456. Set ""hba      se.ipc.max.request.size"" on server to override this limit (not recommended)  9423 2023-02-17 16:44:12,668 ERROR [RpcServer.default.RWQ.Fifo.write.handler=62,queue=62,port=16020] ipc.RpcServer: Unexpected throwable object  9424 java.lang.RuntimeException: Unknown code 98  9425     at org.apache.hadoop.hbase.KeyValue$Type.codeToType(KeyValue.java:276)  9426     at org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(CellUtil.java:1340)  9427     at org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(CellUtil.java:1318)  9428     at org.apache.hadoop.hbase.CellUtil.toString(CellUtil.java:1512)  9429     at org.apache.hadoop.hbase.ByteBufferKeyValue.toString(ByteBufferKeyValue.java:301)  9430     at org.apache.hadoop.hbase.client.Mutation.add(Mutation.java:786)  9431     at org.apache.hadoop.hbase.client.Put.add(Put.java:282)  9432     at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(ProtobufUtil.java:656)  9433     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:1033)  9434     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:987)  9435     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:950)  9436     at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2949)  9437     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45265)  9438     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:394)  9439     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)  9440     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)  9441     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)  9442 2023-02-17 16:44:19,430 WARN  [RS-EventLoopGroup-1-60] ipc.RpcServer: Invalid request header: , should have param set in it  9443 2023-02-17 16:44:19,431 WARN  [RS-EventLoopGroup-1-60] ipc.RpcServer: /hostname_rs1:16020 is unable to read call parameter from client client_ip1  9444 org.apache.hadoop.hbase.DoNotRetryIOException: Invalid request header: , should have param set in it  9445     at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processRequest(ServerRpcConnection.java:654)  9446     at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processOneRpc(ServerRpcConnection.java:448)  9447     at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:89)  9448     at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:63)  9449     at org.apache.hadoop.hbase.ipc.NettyRpcServerRequestDecoder.channelRead(NettyRpcServerRequestDecoder.java:62)  9450     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)  9451     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)  9452     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)  9453     at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)  9454     at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)  9455     at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)  9456     at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)  9457     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)  9458     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)  9459     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)  9460     at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)  9461     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)  9462     at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)  9463     at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)  9464     at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795)  9465     at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480)  9466     at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378)  9467     at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)  9468     at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)  9469     at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)  9470     at java.base/java.lang.Thread.run(Thread.java:832)  9471 2023-02-17 16:44:19,431 WARN  [RS-EventLoopGroup-1-60] ipc.NettyRpcServer: RPC data length of 4294967044 received from client_ip1 is greater than max allowed 268435456. Set ""hb      ase.ipc.max.request.size"" on server to override this limit (not recommended)  9472 2023-02-17 16:44:24,215 INFO  [qtp1820051628-4977731] requests.regionserver: 127.0.0.1 - - [17/2月/2023:08:44:24 +0000] ""GET //127.0.0.1:16030/jmx HTTP/1.1"" 200 1397322  9473 2023-02-17 16:44:24,703 ERROR [RpcServer.default.RWQ.Fifo.write.handler=532,queue=132,port=16020] ipc.RpcServer: Unexpected throwable object  9474 java.lang.NegativeArraySizeException: -620684796  9475     at org.apache.hadoop.hbase.CellUtil.cloneValue(CellUtil.java:126)  9476     at org.apache.hadoop.hbase.ByteBufferKeyValue.getValueArray(ByteBufferKeyValue.java:168)  9477     at org.apache.hadoop.hbase.CellUtil.toString(CellUtil.java:1522)  9478     at org.apache.hadoop.hbase.ByteBufferKeyValue.toString(ByteBufferKeyValue.java:301)  9479     at org.apache.hadoop.hbase.client.Mutation.add(Mutation.java:786)  9480     at org.apache.hadoop.hbase.client.Put.add(Put.java:282)  9481     at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toPut(ProtobufUtil.java:656)  9482     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:1033)  9483     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:987)  9484     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:950)  9485     at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2949)  9486     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45265)  9487     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:394)  9488     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)  9489     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)  9490     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)  9491 2023-02-17 16:44:25,356 WARN  [RS-EventLoopGroup-1-13] ipc.NettyRpcServer: RPC data length of 929117235 received from client_ip1 is greater than max allowed 268435456. Set ""hbase.ipc.max.request.size"" on server to override this limit (not recommended)" IndexBlockEncoding is missing in HFileContextBuilder copy constructor,13525312,Resolved,Major,Fixed,19/Feb/23 03:11,20/Feb/23 10:25,2.5.3,"{{IndexBlockEncoding}} is missing in {{HFileContextBuilder}} copy constructor, so if we want to construct a new {{HFileContext}} by an existing {{HFileContext}}, we would missing the {{ndexBlockEncoding}} setting. " "The ""CREATE_TIME_TS"" value of the hfile generated by the HFileOutputFormat2 class is 0",13524473,Resolved,Major,Fixed,13/Feb/23 12:36,18/Feb/23 03:03,,"When HFileOutputFormat2 is used to create an hfile, the CREATE_TIME_TS of hfileinfo will not be assigned when creating an hfileContext, resulting in the value of  lastMajorCompactionAge  is the timestamp of the current time. {code:java} ##HFileOutputFormat2.class HFileContextBuilder contextBuilder = new HFileContextBuilder() .withCompression(compression) .withChecksumType(HStore.getChecksumType(conf)) .withBytesPerCheckSum(HStore.getBytesPerChecksum(conf)) .withBlockSize(blockSize); ##get lastMajorCompactionTs metric lastMajorCompactionTs = this.region.getOldestHfileTs(true); ... long now = EnvironmentEdgeManager.currentTime(); return now - lastMajorCompactionTs; ... ## public long getOldestHfileTs(boolean majorCompactionOnly) throws IOException { long result = Long.MAX_VALUE; for (HStore store : stores.values()) { Collection storeFiles = store.getStorefiles(); ... for (HStoreFile file : storeFiles) { StoreFileReader sfReader = file.getReader(); ... result = Math.min(result, reader.getFileContext().getFileCreateTime()); } } return result == Long.MAX_VALUE ? 0 : result; }{code}    " [JDK17] Use ReflectionUtils#getModifiersField in UT,13524998,Resolved,Major,Fixed,16/Feb/23 10:04,17/Feb/23 13:34,,"https://issues.apache.org/jira/browse/HBASE-25516 has solved an issue caused by more restrictive reflection protection of java.base classes in the newer java versions.   But there is still an old usage in branch-2." [JDK17] Add-opens java.util.concurrent,13524961,Resolved,Major,Fixed,16/Feb/23 07:09,17/Feb/23 13:35,,"Met this failure UT base on JDK17:   {code:java} [ERROR] Errors: [ERROR]   TestOpenRegionFailedMemoryLeak.testOpenRegionFailedMemoryLeak:108 » InaccessibleObject Unable to make field private final java.util.concurrent.BlockingQueue java.util.concurrent.ThreadPoolExecutor.workQueue accessible: module java.base does not ""opens java.util.concurrent"" to unnamed module @20322d26 [INFO] [ERROR] Tests run: 9, Failures: 0, Errors: 1, Skipped: 0 {code} It seems that since JDK 16 this kind of access was switched to deny by default ([https://openjdk.java.net/jeps/396])  " Should not return OptionalLong.empty when the file is active but the write is still null,13525294,Open,Major,,18/Feb/23 15:07,,,"I think this could only happen when the FSWAL has not been initialized yet, in this way we should return OptionalLong.of(0) instead of OptionalLong.empty(). As in the replication implenentation, if we can make sure a file is not being written any more, we will dequeue it and go to the next file. Although in the current implementation, it should not be a problem and we will only test beingWritten after reading from a WAL file, but since the FSWAL has not been initialized yet, the replication queue of this FSWAL should not be initialized too, so we are safe for now. But anyway, this is still a potential bug if we change the implementation in the future, so let's change it OptionalLong.of(0) and let replication framework know that it should wait a bit." Backport HBASE-27043 to branch-2.4,13524053,Resolved,Major,Fixed,09/Feb/23 16:59,13/Feb/23 13:00,, Remove the impact of operating env on testHFileCleaning,13522211,Resolved,Major,Fixed,31/Jan/23 11:07,11/Feb/23 12:22,,"TestHFileCleaner#testHFileCleaning failed on my local, with this error: {code:java} 2023-01-31T19:05:14,453 ERROR [hfile_cleaner-dir-scan-pool-0] mob.ManualMobMaintHFileCleaner(87): Failed to determine mob status of 'hdfs://localhost:59285/user/tianhang.tang/test-data/01a0d8a0-6306-7725-b63a-5debcab8cf57/archive/someHFileThatWouldBeAUUID.1675163114186', keeping it just in case. java.lang.IllegalArgumentException: Illegal character <.> at 8. Namespaces may only contain 'alphanumeric characters' from any language and digits: tianhang.tang at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:221) ~[classes/:?] at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:196) ~[classes/:?] at org.apache.hadoop.hbase.TableName.(TableName.java:316) ~[classes/:?] at org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:349) ~[classes/:?] at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:387) ~[classes/:?] at org.apache.hadoop.hbase.util.CommonFSUtils.getTableName(CommonFSUtils.java:440) ~[classes/:?] at org.apache.hadoop.hbase.mob.ManualMobMaintHFileCleaner.isFileDeletable(ManualMobMaintHFileCleaner.java:62) ~[classes/:?] at org.apache.hbase.thirdparty.com.google.common.collect.Iterators$5.computeNext(Iterators.java:673) ~[hbase-shaded-miscellaneous-4.1.4.jar:4.1.4] at org.apache.hbase.thirdparty.com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:146) ~[hbase-shaded-miscellaneous-4.1.4.jar:4.1.4] at org.apache.hbase.thirdparty.com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:141) ~[hbase-shaded-miscellaneous-4.1.4.jar:4.1.4] at org.apache.hbase.thirdparty.com.google.common.collect.Iterators$ConcatenatedIterator.hasNext(Iterators.java:1391) ~[hbase-shaded-miscellaneous-4.1.4.jar:4.1.4] at org.apache.hadoop.hbase.master.cleaner.HFileCleaner.deleteFiles(HFileCleaner.java:194) ~[classes/:?] at org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteFiles(CleanerChore.java:391) ~[classes/:?] at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$traverseAndDelete$1(CleanerChore.java:483) ~[classes/:?] at org.apache.hadoop.hbase.master.cleaner.CleanerChore.deleteAction(CleanerChore.java:565) ~[classes/:?] at org.apache.hadoop.hbase.master.cleaner.CleanerChore.traverseAndDelete(CleanerChore.java:483) ~[classes/:?] at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$chore$0(CleanerChore.java:258) ~[classes/:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?] at java.lang.Thread.run(Thread.java:833) ~[?:?] {code} That's because the mocked dir is too simple, need to add a whole namespace/table/region path. " Bulkload fails when trying to bulkload files with invalid names after HBASE-26707,13523518,Resolved,Major,Fixed,07/Feb/23 14:29,09/Feb/23 13:52,2.5.3,"HBASE-26707 has introduced changes to reduce renames on bulkload when using FILE based SFT. However, if the bulkloading file has an invalid hfile name, or has been split in the bulkload process, we don't do any renaming when FILE based SFT is enabled, and we place the file name as ""it is"" in the store dir. This later fails the validations performed by StoreFileReader when it tries to open the file. This jira adds extra validation for the bulkloading file name format in HRegion.bulkLoadHFiles and also extends TestLoadIncrementalHFiles to run the same test suite with FILE based SFT enabled." Backport HBASE-25899 to branch-2.4,13523976,Resolved,Major,Fixed,09/Feb/23 13:17,09/Feb/23 18:09,,Backport HBASE-25899 to branch-2.4 as it can increase the speed of archive cleanup. Bump cryptography from 3.3.2 to 39.0.1 in /dev-support/git-jira-release-audit,13523753,Resolved,Major,Fixed,08/Feb/23 11:04,08/Feb/23 14:06,, Optimize INFO message after HBASE-27498,13522311,Resolved,Major,Duplicate,31/Jan/23 23:24,09/Feb/23 16:10,2.4.16,"During the RC vote of 2.4.16 and 2.5.3, I found the below message should be removed or hidden from the connection operation. {code} 2023-01-31T15:19:03,890 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-01-31T15:19:03,891 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-01-31T15:19:03,997 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-01-31T15:19:03,997 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-01-31T15:19:04,201 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-01-31T15:19:04,202 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-01-31T15:19:04,508 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-01-31T15:19:04,508 INFO [main] client.ConnectionImplementation: Getting master state using rpc call {code}" Add 2.4.16 to download page,13523095,Resolved,Major,Fixed,05/Feb/23 10:27,05/Feb/23 12:45,, Document upgrade to latest 2.4/5 in the Book,13523227,Open,Major,,06/Feb/23 12:26,,,"Let's review the upgrade process from 2.3 to 2.4 and 2.5, document any operator actions in The Book." Release 2.5.3,13523094,Resolved,Major,Fixed,05/Feb/23 10:25,06/Feb/23 07:57,, Complete Release 2.5.3,13523105,Resolved,Major,Fixed,05/Feb/23 16:52,06/Feb/23 07:57,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # HBASE-27611 Add to download page # Push tag 2.5.3RC1 as tag rel/2.5.3 # Release 2.5.3 on JIRA [https://issues.apache.org/jira/projects/HBASE/versions/12352572] # Add release data on [https://reporter.apache.org/addrelease.html?hbase] # Send announcement email (learnt from HBASE-27612)" Unify tracking of block IO across all read request types,13519815,Resolved,Major,Fixed,16/Jan/23 19:16,04/Feb/23 17:45,,"Various requests in RSRpcServices use [addSize|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L1303-L1335] in an attempt to estimate block IO of the request by pulling the capacity of the underlying cell buffer when that buffer changes. This is just an estimate and can be inaccurate in certain circumstances, such as when the ordering of gets in a multiget causes the same buffer to be counted twice. As of HBASE-27558, we now have a hook in StoreScanner for tracking block IO via HFileReaderImpl.reportBlockSize method call. We use this for getting block IO into ScannerContext for tracking limits. We can add a call to RpcCall.incrementResponseBlockSize here so that we can get an accurate accounting of block IO for all request types." Region Reopen failure when the openNum has issue,13523110,Open,Major,,05/Feb/23 22:52,,,"We faced the issue when change the TTL for the hbase table and a lot of regions keep reopen and tons of TRSP created, after troubleshooting, we found some logic issue for the region reopen procedure logic. In the reopen process, it will check the seqNum to confirm if the region reopened successfully or not. If the seqNum accident become bigger than the current HFile and WAL (because of the data loss), there will be issue and unnecessary loop for the region close/open   We should be able to optimize the logic, more details For this regionOpenedWithoutPersistingToMeta, should we just update the OpenSeqNum when the new one is bigger than the old one? As the region already opened, we should update the OpenSeqNum no matter its bigger or smaller, otherwise, we should not just return WARN but failed the open, right? [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/OpenRegionProcedure.java#L81]   Above does matter because for the checkReopened([https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L312]), if the seq is smaller, the region will be returned and keep reopening.  So we should either update the logic in regionOpenedWithoutPersistingToMeta or checkReopened to make sure the region reopen works properly if the seqNum has issue     Reproduce steps:   1. {{{}Create a test table and put some data, for example:{}}}{{{}test{}}} {{create 'test', 'info'}} {{put 'test', 'fool', 'info:cat', 'test'}} {{2. Manually update one region row for this test table in hbase:meta on the column, for example:}} {{put 'hbase:meta', 'test,,1673406566311.3eb4d3e0258bd06f4639a595920c7673.', 'info:seqnumDuringOpen', ""\x00\x00\x00\x00\x00\x10\x00\x05""}} 3. Modify the table TTL : alter 'test', \{NAME=>'info' , TTL => '63244800'}}}   You will see the region keep reopening" "Unexpected throwable object java.lang.RuntimeException: Cached block contents differ, which should not have happened.cacheKey",13521822,Open,Major,,28/Jan/23 02:11,,2.2.6,"This uncaught exception caused the RegionServer to crash.   2023-01-19 03:19:06,986 ERROR [RpcServer.default.RWQ.Fifo.scan.handler=226,queue=19,port=60020] ipc.RpcServer: Unexpected throwable object java.lang.RuntimeException: Cached block contents differ, which should not have happened.cacheKey:bbec4ed53b6d475cbb8711f183556eb0_14145152         at org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.validateBlockAddition(BlockCacheUtil.java:205)         at org.apache.hadoop.hbase.io.hfile.BlockCacheUtil.shouldReplaceExistingCacheBlock(BlockCacheUtil.java:237)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.shouldReplaceExistingCacheBlock(BucketCache.java:432)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.cacheBlockWithWait(BucketCache.java:417)         at org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.cacheBlock(BucketCache.java:403)         at org.apache.hadoop.hbase.io.hfile.CombinedBlockCache.cacheBlock(CombinedBlockCache.java:68)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.lambda$readBlock$2(HFileReaderImpl.java:1528)         at java.util.Optional.ifPresent(Optional.java:159)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1526)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.readNextDataBlock(HFileReaderImpl.java:928)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.isNextBlock(HFileReaderImpl.java:1061)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.positionForNextBlock(HFileReaderImpl.java:1055)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl._next(HFileReaderImpl.java:1073)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.next(HFileReaderImpl.java:1094)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseekAtOrAfter(StoreFileScanner.java:351)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseek(StoreFileScanner.java:244)         at org.apache.hadoop.hbase.regionserver.NonLazyKeyValueScanner.doRealSeek(NonLazyKeyValueScanner.java:55)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:324)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.reseek(KeyValueHeap.java:267)         at org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:1099)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(StoreScanner.java:1088)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(StoreScanner.java:823)         at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:730)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:157)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6681)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6845)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6615)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3238)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3483)         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42278)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:379)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)" Make the behavior of hadoop profile consistent,13521973,Resolved,Major,Fixed,30/Jan/23 03:51,04/Feb/23 09:56,,"In HBASE-27599 I found an issue that should cause build failure, but in fact both the community and my local build jobs succeed, which is not as expected. The reason is, the activation condition in hbase-shaded-testing-util module is different with other modules, and it will not activate by default." Cleanup wrong dependency in dependencyManagement,13521964,Resolved,Major,Fixed,30/Jan/23 03:08,04/Feb/23 09:56,,"In HBASE-27340 added a hadoop-3.0 profile in hbase-shaded-testing-util pom, but missed the version of hadoop-common test jar: [HBASE-27340|https://github.com/apache/hbase/commit/1b5403cf7d906a22c20bd4f025566a2a5f895d44] !screenshot-2.png! This will cause build failure: !screenshot-1.png! But I still don't know why this problem does not necessarily arise..." Put up 2.4.16RC1,13522399,Resolved,Major,Fixed,01/Feb/23 06:09,05/Feb/23 10:27,, Use lowercase image reference name in our docker file,13522799,Resolved,Major,Fixed,02/Feb/23 15:07,03/Feb/23 04:03,,"https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4966/5/consoleFull The build failed with {noformat} 19:46:22 #1 [internal] load build definition from Dockerfile 19:46:22 #1 transferring dockerfile: 7.66kB done 19:46:22 #1 DONE 0.1s 19:46:22 19:46:22 #2 [internal] load .dockerignore 19:46:22 #2 transferring context: 2B done 19:46:22 #2 DONE 0.1s 19:46:22 Dockerfile:117 19:46:22 -------------------- 19:46:22 115 | # 19:46:22 116 | 19:46:22 117 | >>> FROM BASE_IMAGE 19:46:22 118 | SHELL [""/bin/bash"", ""-o"", ""pipefail"", ""-c""] 19:46:22 119 | 19:46:22 -------------------- 19:46:22 ERROR: failed to solve: failed to parse stage name ""BASE_IMAGE"": invalid reference format: repository name must be lowercase {noformat} Changing BASE_IMAGE to base_image can fix the problem." Bump up jruby to 9.3.9.0 and related joni and jcodings to 2.1.43 and 1.0.57 respectively,13521071,Resolved,Major,Fixed,24/Jan/23 05:45,01/Feb/23 03:42,,"Bump up Jruby to 9.3.9.0 to ensure compliance which has multiple CVEs fixed related to openssl,snakeyaml etc. * rdoc has been updated to 6.3.3 to fix all known CVEs. ([#7396|https://github.com/jruby/jruby/issues/7396], [#7404|https://github.com/jruby/jruby/issues/7404]) * rexml has been updated to 3.2.5 to fix all known CVEs. ([#7395|https://github.com/jruby/jruby/issues/7395], [#7405|https://github.com/jruby/jruby/issues/7405]) * jruby-openssl has been updated to 0.14.0 to fix weak HMAC key hashing in bouncycastle, which itself is updated to 1.71. ([#7335|https://github.com/jruby/jruby/issues/7335], [#7385|https://github.com/jruby/jruby/issues/7385], [#7399|https://github.com/jruby/jruby/issues/7399]) * psych has been updated to 3.3.4 to fix CVE-2022-38752 in the SnakeYAML library, which itself is updated to 1.33. ([#7386|https://github.com/jruby/jruby/issues/7386], [#7388|https://github.com/jruby/jruby/issues/7388], [#7400|https://github.com/jruby/jruby/issues/7400]) * rubygems has been updated to 3.2.33 and bundler updated to 2.2.33 to address CVE-2021-43809. ([#7397|https://github.com/jruby/jruby/issues/7397], [#7401|https://github.com/jruby/jruby/issues/7401])" Region with one huge hfile should split,13522683,Open,Major,,02/Feb/23 03:23,,2.4.14,"I found some regions in our production cluster have one huge hfile and can not split automatically anymore, it causes the poor read performance. If a region loaded lots of data via bulkload, it will split after compaction done. The reference files are cleared by 'CompactedHFilesDischarger' asynchronized, so the daughter regions will not split after compaction finished. If the daughter regions have no more write operation, they will never split although the rewrote hfile exceed the disired  max hfile size(ConstantSizeRegionSplitPolicy),  !image-2023-02-02-11-25-16-499.png!" Put up 2.4.16RC0,13522398,Resolved,Major,Fixed,01/Feb/23 06:08,01/Feb/23 06:09,, Scan quotas and limits should account for total block IO,13517056,Resolved,Major,Fixed,06/Jan/23 17:03,30/Jan/23 18:26,,"Scan and Multi requests pull the byte throughput limit from Quotas.getReadAvailable(). Multis validate the result inline in RSRpcServices, by checking the accumulated {{RpcCallContext.getResponseCellSize}} and {{getResponseBlockSize}} against the read available after each action. Scans make use of {{{}ScannerContext{}}}, and only checks the total cell serialized size and {{{}cell.heapSize(){}}}. The handling for Multis was added in HBASE-14978. The block size is checked because regardless of the actual cell size, the regionserver needs to retain entire blocks backing those cells for the lifetime of a request. If the retained blocks grows too large, a regionserver can OOM or experience heavy GC pressure. So multis validate read available against the actual block size retained for the responses, but scans only account for cell sizes. We should extend the same block support to scans through ScannerContext tracking block bytes scanned. Large scans can read over ranges of both returned and filtered rows. Despite what's returned the users, the server-side cost of the scan is just as impacted by filtered rows as non-filtered. Both Scans and Multis take the Math.min of Quotas read available and hbase.server.scanner.max.result.size. Scans further take the min of that and Scan.setMaxResultSize.  " The release script will fail if we run publish-dist step separately,13522081,Open,Major,,30/Jan/23 14:34,,,"Because of can not find CHANGES.md and RELEASENOTES.md in the parent directory. For 3.0.0+, we will not include CHANGES.md and RELEASENOTES.md in git repo so the solution is to mv it to parent directory and let later step to use it, but if we execute publish-dist separately, the solution can not work." Bump up commons-codec to 1.15,13521072,Resolved,Major,Fixed,24/Jan/23 05:50,27/Jan/23 15:22,,"commons-codec 1.15 has proper fix of few CVEs which may not effect in HBase but better to upgrade to ensure compliance. Ex: While [a fix|https://github.com/apache/commons-codec/commit/48b615756d1d770091ea3322eefc08011ee8b113] was earlier made to {{commons-codec:commons-codec}} version 1.13, it was later found out to be incomplete. A [complete fix|https://github.com/apache/commons-codec/pull/29] exists in version 1.14 and that is the version users should upgrade to." Bump jettison from 1.5.1 to 1.5.2,13516254,Resolved,Major,Fixed,03/Jan/23 04:39,03/Jan/23 08:34,, Remove -X option when building protoc check in nightly and pre commit job,13520888,Resolved,Major,Fixed,21/Jan/23 09:15,25/Jan/23 14:57,,"We eat too many spaces on jenkins {noformat} root@jenkins-cm8 /home/jenkins/jenkins-home/jobs/HBase Nightly/branches # find . -type f -size +100G |xargs ls -l -rw-r--r-- 1 jenkins jenkins 128604282880 Jan 21 06:45 ./branch-2-4.ib7ujg/builds/497/archive/output-general/patch-hbaseprotoc-root.txt -rw-r--r-- 1 jenkins jenkins 249367112376 Jan 20 12:10 ./branch-2-5.lbpvbe/builds/282/archive/output-general/patch-hbaseprotoc-root.txt -rw-r--r-- 1 jenkins jenkins 249367112376 Jan 20 12:10 ./branch-2-5.lbpvbe/builds/282/htmlreports/General_20Nightly_20Build_20Report/patch-hbaseprotoc-root.txt -rw-r--r-- 1 jenkins jenkins 249572082864 Jan 20 21:50 ./branch-2/builds/723/archive/output-general/patch-hbaseprotoc-root.txt -rw-r----- 1 jenkins jenkins 123016740864 Jan 21 06:45 ./branch-2/builds/723/htmlreports/General_20Nightly_20Build_20Report/patch-hbaseprotoc-root.txt -rw-r--r-- 1 jenkins jenkins 247567066688 Jan 20 10:48 ./master/builds/759/archive/output-general/patch-hbaseprotoc-root.txt -rw-r--r-- 1 jenkins jenkins 247567066688 Jan 20 10:48 ./master/builds/759/htmlreports/General_20Nightly_20Build_20Report/patch-hbaseprotoc-root.txt {noformat}" "IllegalArgumentException: In CellChunkMap, cell must be associated with chunk",13521825,Open,Major,,28/Jan/23 02:47,,2.2.6,"2023-01-24 19:14:45,414 ERROR [RpcServer.default.RWQ.Fifo.read.handler=92,queue=11,port=60020] ipc.RpcServer: Unexpected throwable object java.lang.IllegalArgumentException: In CellChunkMap, cell must be associated with chunk.. We were looking for a cell at index 5         at org.apache.hadoop.hbase.regionserver.CellChunkMap.getCell(CellChunkMap.java:109)         at org.apache.hadoop.hbase.regionserver.CellFlatMap.find(CellFlatMap.java:87)         at org.apache.hadoop.hbase.regionserver.CellFlatMap.getValidIndex(CellFlatMap.java:114)         at org.apache.hadoop.hbase.regionserver.CellFlatMap.tailMap(CellFlatMap.java:184)         at org.apache.hadoop.hbase.regionserver.CellFlatMap.tailMap(CellFlatMap.java:45)         at org.apache.hadoop.hbase.regionserver.CellSet.tailSet(CellSet.java:150)         at org.apache.hadoop.hbase.regionserver.CellSet.tailSet(CellSet.java:145)         at org.apache.hadoop.hbase.regionserver.Segment.tailSet(Segment.java:414)         at org.apache.hadoop.hbase.regionserver.SegmentScanner.getIterator(SegmentScanner.java:131)         at org.apache.hadoop.hbase.regionserver.SegmentScanner.reseek(SegmentScanner.java:156)         at org.apache.hadoop.hbase.regionserver.NonLazyKeyValueScanner.doRealSeek(NonLazyKeyValueScanner.java:55)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:324)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.reseek(KeyValueHeap.java:267)         at org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:1099)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(StoreScanner.java:1088)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(StoreScanner.java:823)         at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:730)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:157)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6681)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6845)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6615)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:6592)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:6579)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2645)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2571)         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42274)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:379)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)   2023-01-24 19:14:45,419 WARN  [main-BucketCacheWriter-1] bucket.BucketCache: Failed allocation for 5740f58a86a14107afaab310bf2444cb_0; org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=4493298; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. 2023-01-24 19:14:45,420 WARN  [main-BucketCacheWriter-1] bucket.BucketCache: Failed allocation for b1aa2b31cc8a4a23bb5d6bc3d43df51b_0; org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=3260552; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. 2023-01-24 19:14:45,424 WARN  [main-BucketCacheWriter-1] bucket.BucketCache: Failed allocation for e20825c52020440c9eaa1abc29e3516b_0; org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=3266144; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. 2023-01-24 19:14:45,426 WARN  [main-BucketCacheWriter-1] bucket.BucketCache: Failed allocation for 591bb35d28d64eaebc30079f8f83b529_0; org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=3261225; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. 2023-01-24 19:14:45,430 WARN  [main-BucketCacheWriter-2] bucket.BucketCache: Failed allocation for a94eeb8e9e9f4cc590d3c6cd2118c48d_0; org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=3260054; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. 2023-01-24 19:14:45,436 WARN  [main-BucketCacheWriter-1] bucket.BucketCache: Failed allocation for 1ce6f0cb59b64345aba5d0c21c1b178f_0; org.apache.hadoop.hbase.io.hfile.bucket.BucketAllocatorException: Allocation too big size=3260278; adjust BucketCache sizes hbase.bucketcache.bucket.sizes to accomodate if size seems reasonable and you want it cached. 2023-01-24 19:14:45,439 ERROR [MemStoreFlusher.7] regionserver.HRegionServer: ***** ABORTING region server node71-130-29.hadoop,60020,1670988984660: Replay of WAL required. Forcing server shutdown ***** org.apache.hadoop.hbase.DroppedSnapshotException: region: boss_nova_tag_vip,,1628813687297.eb382431ecdd2207af9f25159f09386d.         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2882)         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2551)         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2523)         at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2409)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:611)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:580)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:68)         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:360)         at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.IllegalArgumentException: In CellChunkMap, cell must be associated with chunk.. We were looking for a cell at index 5         at org.apache.hadoop.hbase.regionserver.CellChunkMap.getCell(CellChunkMap.java:109)         at org.apache.hadoop.hbase.regionserver.CellFlatMap$CellFlatMapIterator.next(CellFlatMap.java:441)         at org.apache.hadoop.hbase.regionserver.CellFlatMap$CellFlatMapIterator.next(CellFlatMap.java:427)         at org.apache.hadoop.hbase.regionserver.SnapshotSegmentScanner.reseek(SnapshotSegmentScanner.java:79)         at org.apache.hadoop.hbase.regionserver.NonLazyKeyValueScanner.doRealSeek(NonLazyKeyValueScanner.java:55)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:324)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.reseek(KeyValueHeap.java:267)         at org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:1099)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(StoreScanner.java:1088)         at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(StoreScanner.java:823)         at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:730)         at org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:127)         at org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:69)         at org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1057)         at org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2374)         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2818)         ... 8 more" Update hadoop netty version for hadoop-2.0 profile,13521499,Resolved,Major,Fixed,25/Jan/23 14:51,25/Jan/23 22:47,,"In HBASE-27299 we updated our minimum hadoop 2 dependency in branch-2 to 2.10.2, but we left our hadoop.netty.version at 3.6.2.Final.  According to [https://github.com/apache/hadoop/blob/rel/release-2.10.2/hadoop-project/pom.xml#L721,] the correct version is 3.10.6.Final. This is causing a NoSuchMethodError in our newly backported TestRemoteRestore tests. Bumping to 3.10.6.Final locally fixes the tests." Add config options to delay assignment to retain last region location,13516641,Resolved,Major,Fixed,05/Jan/23 12:56,25/Jan/23 11:14,,"HBASE-27313 introduced the ability to persist the list of files cached in a given RS, but temporary RSes loss or restarts would cause regions to be eagerly reassigned on other RSes, making the persisted cache useless. For some use cases, such as when using ObjectStores based persistence, performance degradation caused by cache misses have a worse impact than temporary region unavailability. This proposes and additional config property (disabled by default) to forcibly wait the TRSP for a configurable time while checking for the previous RS holding region to get back online, before proceeding with the region assignment. " Clear meta cache for full server when handling FailedServerException,13521530,Open,Major,,25/Jan/23 16:08,,,"Currently we prefer to clear meta cache for an individual region that fails. This is preferred in most cases, because clearing cache for an entire server is much more expensive. If a server hosts 100 regions, unnecessarily clearing the cache for the entire server would cause 100 meta requests per client. However, when a client fails to connect to a regionserver, it gets added to the FailedServers list. Subsequent requests to that server are fast-failed, throwing a FailedServerException. This is a pretty clear indicator that there's a problem with a specific server. In this case I think we should clear the cache for that full server. We had a production incident recently where a server completely hung and we did see ""Clear Region"" calls, but the server hosted many regions and the meta clears continued for a while longer than necessary. Adding ""Clear Server"" call due to FailedServers would have mitigated this issue much quicker." L1 cache leaks index blocks over time when under subscribed,13521180,Open,Major,,24/Jan/23 22:09,,,"Let's say you have CombinedBlockCache enabled. DATA goes to L2, INDEX/BLOOM go to L1.  Your regionserver has index size of 2gb and bloom size of 1gb. So you really only need around 3gb of L1 to fully hold all of the ""L1 candidates"". When data set does not fit into cache, LRU will handle evictions to stay under max. But in the above scenario, if you configure 6gb for L1 (3 more than needed) over time you will end up filling that entire 6gb with old INDEX blocks. Once you reach max, LRU will handle evicting out the oldest ones. Since the leak is contained to the configured max L1 size, this isn't a huge issue but it results in heap waste. Under high heap allocations, if you haven't left enough buffer outside memstore, L1, etc, you will start seeing GC pressure. This L1 leak then becomes a little more problematic, because you end up in a circumstance where longer lived regionservers (who've leaked closer to the max L1 size) have less extra buffer available than more newly restarted regionservers. The best fix is to appropriately set your L1 size so there is not a lot of excess, but this can be painful to maintain over time as clusters shrink, grow, or data shape changes. It'd be a lot better if the L1 did not leak so you don't have to so finely tune the L1. I haven't fully figured out where the leak comes from, but I think it's related to compactions. Perhaps the INDEX blocks are not being evicted as hfiles are compacted away. The leak is very linear over time in our experience." Document availability of experimental Backup/Restore feature as of release 2.6.0,13521050,Open,Major,,24/Jan/23 00:56,,, [hbase-thirdparty] Release hbase-thirdparty 4.1.4,13519968,Resolved,Major,Fixed,18/Jan/23 02:40,21/Jan/23 07:55,, [hbase-thirdparty] Put up hbase-thirdparty 4.1.4RC0,13519969,Resolved,Major,Fixed,18/Jan/23 02:41,21/Jan/23 07:54,, Add default encryption type for MiniKDC to fix failed tests on JDK11+,13517459,Resolved,Major,Fixed,10/Jan/23 14:43,20/Jan/23 08:54,,"An example of a failed test run with Hadoop2 and JDK17:   {code:java} [INFO] Running org.apache.hadoop.hbase.coprocessor.TestSecureExport [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 56.87 s <<< FAILURE! - in org.apache.hadoop.hbase.coprocessor.TestSecureExport [ERROR] org.apache.hadoop.hbase.coprocessor.TestSecureExport  Time elapsed: 56.862 s  <<< ERROR! java.io.IOException: Failed on local exception: java.io.IOException: Couldn't setup connection for tianhang.tang/localhost@EXAMPLE.COM to localhost/127.0.0.1:53756; Host Details : local host is: ""Tangs-MacBook-Pro.local/10.2.175.4""; destination host is: ""localhost"":53756;     at org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:805)     at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1544)     at org.apache.hadoop.ipc.Client.call(Client.java:1486)     at org.apache.hadoop.ipc.Client.call(Client.java:1385)     at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:232)     at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:118)     at jdk.proxy2/jdk.proxy2.$Proxy34.getDatanodeReport(Unknown Source)     at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getDatanodeReport(ClientNamenodeProtocolTranslatorPB.java:653)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.base/java.lang.reflect.Method.invoke(Method.java:568)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:422)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:165)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:157)     at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)     at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:359)     at jdk.proxy2/jdk.proxy2.$Proxy35.getDatanodeReport(Unknown Source)     at org.apache.hadoop.hdfs.DFSClient.datanodeReport(DFSClient.java:2111)     at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2698)     at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2742)     at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1723)     at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:905)     at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:798)     at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:668)     at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:641)     at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1130)     at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1105)     at org.apache.hadoop.hbase.coprocessor.TestSecureExport.beforeClass(TestSecureExport.java:206)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.base/java.lang.reflect.Method.invoke(Method.java:568)     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)     at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)     at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)     at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:38)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)     at java.base/java.lang.Thread.run(Thread.java:833) Caused by: java.io.IOException: Couldn't setup connection for tianhang.tang/localhost@EXAMPLE.COM to localhost/127.0.0.1:53756     at org.apache.hadoop.ipc.Client$Connection$1.run(Client.java:763)     at java.base/java.security.AccessController.doPrivileged(AccessController.java:712)     at java.base/javax.security.auth.Subject.doAs(Subject.java:439)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1893)     at org.apache.hadoop.ipc.Client$Connection.handleSaslConnectionFailure(Client.java:734)     at org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:828)     at org.apache.hadoop.ipc.Client$Connection.access$3700(Client.java:423)     at org.apache.hadoop.ipc.Client.getConnection(Client.java:1601)     at org.apache.hadoop.ipc.Client.call(Client.java:1432)     ... 41 more Caused by: javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Message stream modified (41) - Message stream modified)]     at jdk.security.jgss/com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:228)     at org.apache.hadoop.security.SaslRpcClient.saslConnect(SaslRpcClient.java:407)     at org.apache.hadoop.ipc.Client$Connection.setupSaslConnection(Client.java:629)     at org.apache.hadoop.ipc.Client$Connection.access$2200(Client.java:423)     at org.apache.hadoop.ipc.Client$Connection$2.run(Client.java:815)     at org.apache.hadoop.ipc.Client$Connection$2.run(Client.java:811)     at java.base/java.security.AccessController.doPrivileged(AccessController.java:712)     at java.base/javax.security.auth.Subject.doAs(Subject.java:439)     at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1893)     at org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:810)     ... 44 more Caused by: GSSException: No valid credentials provided (Mechanism level: Message stream modified (41) - Message stream modified)     at java.security.jgss/sun.security.jgss.krb5.Krb5Context.initSecContext(Krb5Context.java:778)     at java.security.jgss/sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:266)     at java.security.jgss/sun.security.jgss.GSSContextImpl.initSecContext(GSSContextImpl.java:196)     at jdk.security.jgss/com.sun.security.sasl.gsskerb.GssKrb5Client.evaluateChallenge(GssKrb5Client.java:209)     ... 53 more Caused by: KrbException: Message stream modified (41) - Message stream modified     at java.security.jgss/sun.security.krb5.KrbTgsRep.(KrbTgsRep.java:72)     at java.security.jgss/sun.security.krb5.KrbTgsReq.getReply(KrbTgsReq.java:224)     at java.security.jgss/sun.security.krb5.KrbTgsReq.sendAndGetCreds(KrbTgsReq.java:235)     at java.security.jgss/sun.security.krb5.internal.CredentialsUtil.serviceCredsSingle(CredentialsUtil.java:477)     at java.security.jgss/sun.security.krb5.internal.CredentialsUtil.serviceCreds(CredentialsUtil.java:340)     at java.security.jgss/sun.security.krb5.internal.CredentialsUtil.serviceCreds(CredentialsUtil.java:314)     at java.security.jgss/sun.security.krb5.internal.CredentialsUtil.acquireServiceCreds(CredentialsUtil.java:169)     at java.security.jgss/sun.security.krb5.Credentials.acquireServiceCreds(Credentials.java:493)     at java.security.jgss/sun.security.jgss.krb5.Krb5Context.initSecContext(Krb5Context.java:700)     ... 56 more Caused by: KrbException: Identifier doesn't match expected value (906)     at java.security.jgss/sun.security.krb5.internal.KDCRep.init(KDCRep.java:140)     at java.security.jgss/sun.security.krb5.internal.TGSRep.init(TGSRep.java:65)     at java.security.jgss/sun.security.krb5.internal.TGSRep.(TGSRep.java:60)     at java.security.jgss/sun.security.krb5.KrbTgsRep.(KrbTgsRep.java:54)     ... 64 more {code} That's because hadoop-minikdc lower than 3.0 has compatibility issues with JDK11+, and we can find some useful infos in [KAFKA-7338|https://issues.apache.org/jira/browse/KAFKA-7338], FLINK-13516 and [SPARK-29957|https://issues.apache.org/jira/browse/SPARK-29957]: New encryption types of aes128-cts-hmac-sha256-128 and aes256-cts-hmac-sha384-192 (for Kerberos 5) enabled by default were added in Java 11. Actually I'm not sure is it suitable to merge into master, because HBase has a rule that JDK11+ could only run with Hadoop3+. Is this just a design rule, or caused by some compatibility issues? If it is not a ""rule"", maybe we can try to find out the issues and fix them. Wish someone could give me some background infos.  " Bump gitpython from 3.1.29 to 3.1.30 in /dev-support,13517523,Resolved,Major,Fixed,11/Jan/23 03:01,11/Jan/23 03:14,, ChaosMonkey add support for JournalNodes,13517892,Resolved,Major,Fixed,12/Jan/23 16:19,17/Jan/23 17:37,2.4.16,Looks like our ChaosMonkey knowledge of HDFS topology is stale. Add the concept of a Journal Node to ClusterManager et al. [hbase-thirdparty] Bump dependency versions,13519913,Resolved,Major,Fixed,17/Jan/23 15:11,18/Jan/23 02:39,, Get supports RAW,13519865,Open,Major,,17/Jan/23 07:39,,,"[https://github.com/apache/hbase/blob/da261344cc55e7812dfe22d86d5fa88c93ed79b9/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java#L234]   I used the `Get` to query all put and delete in a column, but I got this error *Cannot specify any column for a raw scan.* Why add this restriction?" Make the initial corePoolSize configurable for ChoreService,13517479,Resolved,Major,Fixed,10/Jan/23 17:14,12/Jan/23 14:01,,"The initial corePoolSize for ChoreService is set to 1. The pool size is increased when a scheduled task misses its start time. On a cluster where the archive size is large, the HFileCleaner could run for a very long time and block the rest of the chores to run. By making the initial pool size configurable we could solve the bottleneck of caused by a long-running HFileCleaner chore." Backport HBASE-23340 to branch-2.4,13517022,Resolved,Major,Fixed,06/Jan/23 09:46,06/Jan/23 19:47,2.4.15, [hbase-connectors] org.apache.hadoop.hbase.spark.TestJavaHBaseContext failing with HBase 2.5.x,13516315,Resolved,Major,Duplicate,03/Jan/23 11:45,03/Jan/23 16:40,,"{noformat} [INFO] ------------------------------------------------------- [INFO]  T E S T S [INFO] ------------------------------------------------------- [INFO] Running org.apache.hadoop.hbase.spark.TestJavaHBaseContext [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.157 s <<< FAILURE! - in org.apache.hadoop.hbase.spark.TestJavaHBaseContext [ERROR] org.apache.hadoop.hbase.spark.TestJavaHBaseContext  Time elapsed: 5.142 s  <<< ERROR! java.lang.NoClassDefFoundError: org/apache/logging/log4j/Level     at org.apache.hadoop.hbase.spark.TestJavaHBaseContext.setUpBeforeClass(TestJavaHBaseContext.java:98) Caused by: java.lang.ClassNotFoundException: org.apache.logging.log4j.Level     at org.apache.hadoop.hbase.spark.TestJavaHBaseContext.setUpBeforeClass(TestJavaHBaseContext.java:98) [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR]   TestJavaHBaseContext.setUpBeforeClass:98 » NoClassDefFound org/apache/logging/... [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 [INFO] {noformat}" [hbase-thirdparty] Upgrade Netty to 4.1.86.Final,13516266,Resolved,Major,Fixed,03/Jan/23 06:55,03/Jan/23 09:23,,"Netty version - 4.1.86.Final has fix some CVEs. CVE-2022-41915, CVE-2022-41881 Upgrade to latest version. " [JDK17] SecurityManager is deprecated since JDK17,13521582,Open,Minor,,26/Jan/23 05:01,,,"Our UTs will print out lots of WARNINGs if we run on JDK17: {code:java} WARNING: A terminally deprecated method in java.lang.System has been called WARNING: System::setSecurityManager has been called by org.apache.hadoop.hbase.SystemExitRule (file:/Users/tianhang.tang/workspaces/apache/hbase/hbase-common/target/test-classes/) WARNING: Please consider reporting this to the maintainers of org.apache.hadoop.hbase.SystemExitRule WARNING: System::setSecurityManager will be removed in a future release{code} This is because [JEP 411|[https://openjdk.org/jeps/411],] Security Manager is deprecated since JDK17, and will removed in the future version after JDK18. We introduced the SecurityManager in [HBASE-24185|https://issues.apache.org/jira/browse/HBASE-24185], mainly using ??checkExit?? to ensure that the JVM does not exit during testing. [JDK-8199704|https://bugs.openjdk.org/browse/JDK-8199704] may provide an API in the future, but at the moment we really don't seem to have an alternative available. In short, this WARNING does not have any practical impact at present, what we need to do is to refactor HBASE-24185 in the future. But the large amount of logging is still annoying, and I haven't found a way to turn it off yet.  " Upgrade commons-validator to version 1.7,13528998,Resolved,Minor,Fixed,17/Mar/23 16:50,21/Mar/23 15:04,,"The current version of commons-validator (1.6) has a dependency on commons-beanutils-1.9.2.jar, this dependency comes with two CVEs: - [CVE-2014-0114|https://nvd.nist.gov/vuln/detail/cve-2014-0114] - [CVE-2019-10086|https://nvd.nist.gov/vuln/detail/cve-2019-10086] With commons-validator version 1.7 these CVEs are no longer present. I've also checked the master branch for usages. The only location where commons-validator is used is in org.apache.hadoop.hbase.zookeeper.ZKConfig for validating ipv6 addresses." Add usage docs to HBase-Spark connector,13524183,Open,Minor,,10/Feb/23 09:27,,,"Documentation for the HBase Spark connectors is mostly non-existent. We could start by adding most of the content from  [https://github.com/LucaCanali/Miscellaneous/blob/master/Spark_Notes/Spark_HBase_Connector.md] to the Spark connector README." Check if the file system supports storage policy before invoking setStoragePolicy(),13529873,Resolved,Minor,Fixed,23/Mar/23 22:53,22/Aug/24 04:35,,"Found these messages on an Ozone cluster: {noformat} 2023-03-20 12:27:09,185 WARN org.apache.hadoop.hbase.util.CommonFSUtils: Unable to set storagePolicy=HOT for path=ofs://ozone1/vol1/bucket1/hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682/proc. DEBUG log level might have more details. java.lang.UnsupportedOperationException: RootedOzoneFileSystem doesn't support setStoragePolicy at org.apache.hadoop.fs.FileSystem.setStoragePolicy(FileSystem.java:3227) at org.apache.hadoop.hbase.util.CommonFSUtils.invokeSetStoragePolicy(CommonFSUtils.java:521) at org.apache.hadoop.hbase.util.CommonFSUtils.setStoragePolicy(CommonFSUtils.java:504) at org.apache.hadoop.hbase.util.CommonFSUtils.setStoragePolicy(CommonFSUtils.java:477) at org.apache.hadoop.hbase.regionserver.HRegionFileSystem.setStoragePolicy(HRegionFileSystem.java:225) at org.apache.hadoop.hbase.regionserver.HStore.(HStore.java:275) at org.apache.hadoop.hbase.regionserver.HRegion.instantiateHStore(HRegion.java:6387) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1115) at org.apache.hadoop.hbase.regionserver.HRegion$1.call(HRegion.java:1112) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} Ozone does not support storage policy. If we use FileSystem.hasPathCapability() API to check before invoking the API, these warning messages can be avoided." hbase.master.port is ignored in processing of hbase.masters ,13517299,Resolved,Minor,Fixed,10/Jan/23 00:30,17/Jan/23 22:09,2.5.2,"Setting of hbase.master.port is ignored in default processing of hbase.masters. For example, hbase.masters=localhost hbase.master.port=8100 ""Server at localhost:16000"" is in the failed servers list"" hbase.masters=localhost:8100 hbase.master.port=8100 and all is well. This is confusing and a minor configuration handling bug." Optimize writes of zero length values in compressed WALs,13524719,Open,Minor,,14/Feb/23 21:16,,,"If we unconditionally use the compressor, to ""write"" 0 bytes, then the compression codec will emit overheads... hadoop compressionstream header, compression bitstream header. All of that should be skipped so truly no compressed value data is written when the value is empty. " [JDK17] Backport to branch-2.4 HBASE-25058 HBase-27510,13529241,Resolved,Minor,Duplicate,20/Mar/23 12:07,14/Dec/23 08:32,,"I use jdk17 on branch-2.4，encountered some WARN like: {code:java} WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem Pass '--add-opens java.base/sun.nio.ch=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED' to enable.{code} Backport HBASE-25058 and HBASE-27510 PR can resolve the warn problem." Fall back to protoc osx-x86_64 on Apple Silicon,13529464,Resolved,Minor,Fixed,21/Mar/23 14:54,22/Mar/23 14:19,2.4.0,"Building non-master branches on an Apple Silicon machine fails because there's no protoc binary available. Use a profile to fall back to the x86 version of the binary, as per https://cwiki.apache.org/confluence/display/HADOOP/Develop+on+Apple+Silicon+%28M1%29+macOS  " Add rsgroup name for dead region servers on master UI,13528412,Resolved,Minor,Fixed,14/Mar/23 11:26,27/Aug/23 07:30,2.5.3,"We also want to known the rsgroup name of dead region servers, which are showed in the `Dead Region Servers` of master UI." [HBCK2] addFsRegionsMissingInMeta command should support dumping region list into a file which can be passed as input to assigns command,13528857,Resolved,Minor,Fixed,16/Mar/23 19:54,19/Aug/23 17:32,,"_addFsRegionsMissingInMeta_ command currently outputs a command as last line of output which needs to be run with hbck2 {code:java} assigns 22d30d9e332af3272302cf780da14c3c 43245731f82e5bb907a4433f688574c1 5a19939f4f219ab177dd5b376dcb882f 774514b1027846c4e3b6702e193ce03d 7f6ad3360e0a4811c4dace8c1a901f40 8cd363e4da1b95fd43166f451546ad63 90e3414947f9500ec01f6672103f29d0{code} This is good, but the user has to copy and format the command, which can get really big depending on how many regions need to be assigned. _addFsRegionsMissingInMeta_ should support a flag, say -f to facilitate dumping region list into a file, which can be passed onto as input to _assigns_ command via -i parameter. Sample expected use-case: {code:java} # Dump output of command (in a formatted manner) to file hbase hbck -j hbase-hbck2-version.jar addFsRegionsMissingInMeta -i table_list.txt -f regions_to_assign.txt # Pass file as input to assigns hbase hbck -j hbase-hbck2-version.jar assigns -i regions_to_assign.txt{code}  " SlowLog does not include params for Mutations,13516650,Resolved,Minor,Fixed,05/Jan/23 13:56,24/Jul/23 12:22,,"SlowLog params are extracted via [ProtobufUtil.getSlowLogParams|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L2154]. This method has various if/else branches for each request type, but mutation (the line linked above) is incorrect. Currently it handles MutationProto, but it should be MutateRequest. A MutationProto is never passed into this method, only MutateRequests so any MutateRequests being passed in now will fall through to the default case which contains nothing useful about the request. As part of fixing this, we should also ensure that we extract the region name from the MutateRequest to add into the SlowLogParams object like all the other requests. While we are here, the CoprocessorServiceRequest (handled further down) has a getRegion() method, but that is not passed into the SlowLogParams either. We should add that too." ChaosMonkey documentation enhancements,13526001,Resolved,Minor,Fixed,24/Feb/23 05:30,05/Jul/23 14:13,,"Post refactoring the code to org.apache.hadoop.hbase.chaos package, new references need to be updated in the [https://hbase.apache.org/book.html#maven.build.commands.integration.tests.destructive] doc. The sample command given also is stale." Read RPC threads may BLOCKED at the Configuration.get when using java compression,13526322,Resolved,Minor,Fixed,27/Feb/23 11:23,06/Mar/23 04:56,2.5.3,"As in the jstack info, we can see some RPC threads or compaction threads BLOCKED, !image-2023-02-27-19-22-52-704.png|width=976,height=355!" Builds emit errors related to SBOM parsing,13524215,Resolved,Minor,Fixed,10/Feb/23 11:53,21/May/23 12:24,3.0.0-alpha-4,"My build is littered with noise of the form of, {noformat} [INFO] CycloneDX: Resolving Dependencies [ERROR] An error occurred attempting to read POM org.codehaus.plexus.util.xml.pull.XmlPullParserException: UTF-8 BOM plus xml decl of ISO-8859-1 is incompatible (position: START_DOCUMENT seen {'hbase.region.store.parallel.put.limit' => 100} 2、update_all_config The table-level configuration will be overwrite" TestClusterRestartFailover is flakey due to metrics assertion,13528651,Resolved,Minor,Fixed,15/Mar/23 14:48,17/Apr/23 09:46,2.4.16,"I'm seeing failures like this in PR, {noformat} [ERROR] Failures: [ERROR] org.apache.hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk.test [ERROR] Run 1: TestClusterRestartFailoverSplitWithoutZk>TestClusterRestartFailover.test:143 serverNode should be deleted after SCP finished expected null, but was: [ERROR] Run 2: TestClusterRestartFailoverSplitWithoutZk>TestClusterRestartFailover.test:147 serverCrashSubmittedCount(8) should be equal expected:<4> but was:<8> [ERROR] Run 3: TestClusterRestartFailoverSplitWithoutZk>TestClusterRestartFailover.test:147 serverCrashSubmittedCount(12) should be equal expected:<4> but was:<12> {noformat} Looks like subsequent runs would have passed, but for the firm metric count assertion." Correct the line logged with flag hbase.procedure.upgrade-to-2-2 in docs,13525999,Resolved,Minor,Fixed,24/Feb/23 05:23,05/Apr/23 15:31,,"The https://hbase.apache.org/book.html#upgrade2.2 doc says to search for a ""READY TO ROLLING UPGRADE"" log in master after setting the flag whereas no such log exists. The actual log line indicating that procedure store is empty is ""UPGRADE OK: All existed procedures have been finished, quit...""" [hbase-operator-tools] TestMissingTableDescriptorGenerator fails with HBase 2.5.3,13529993,Resolved,Minor,Fixed,24/Mar/23 15:29,31/Mar/23 23:13,,"hbase-operator-tools fails to compile against hbase 2.5.3 with following test failures. {code:java} [INFO] Running org.apache.hbase.TestMissingTableDescriptorGenerator [ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 30.149 s <<< FAILURE! - in org.apache.hbase.TestMissingTableDescriptorGenerator [ERROR] testTableinfoGeneratedWhenNoTableSpecified(org.apache.hbase.TestMissingTableDescriptorGenerator) Time elapsed: 16.734 s <<< ERROR! java.lang.IllegalArgumentException: hdfs://localhost:51882/user/nihaljain/test-data/de8af727-6c02-7a95-9beb-027d18fc6603/data/default/test-1/.tabledesc/.tableinfo.0000000001.639 at org.apache.hbase.TestMissingTableDescriptorGenerator.testTableinfoGeneratedWhenNoTableSpecified(TestMissingTableDescriptorGenerator.java:145) [ERROR] shouldGenerateTableInfoBasedOnFileSystem(org.apache.hbase.TestMissingTableDescriptorGenerator) Time elapsed: 6.794 s <<< ERROR! java.lang.IllegalArgumentException: hdfs://localhost:51961/user/nihaljain/test-data/5ade0aa1-cb9a-a1da-b700-fe808eeda3b9/data/default/test-1/.tabledesc/.tableinfo.0000000001.666 at org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnFileSystem(TestMissingTableDescriptorGenerator.java:120) [ERROR] shouldGenerateTableInfoBasedOnCachedTableDescriptor(org.apache.hbase.TestMissingTableDescriptorGenerator) Time elapsed: 6.621 s <<< ERROR! java.lang.IllegalArgumentException: hdfs://localhost:52022/user/nihaljain/test-data/d858258b-6ba1-8e4f-c118-4e30d8a5136f/data/default/test-1/.tabledesc/.tableinfo.0000000001.666 at org.apache.hbase.TestMissingTableDescriptorGenerator.shouldGenerateTableInfoBasedOnCachedTableDescriptor(TestMissingTableDescriptorGenerator.java:107) {code} Steps to reproduce, run following against hbase-operator-tools master: {code:java} mvn clean install -Dhbase.version=2.5.3 -Dhbase-thirdparty.version=4.1.4 {code} The goal is to allow hbase-operator-tools to compile with hbase 2.5.3 without any failures" Update compression dependencies,13529686,Resolved,Minor,Fixed,23/Mar/23 01:34,23/Mar/23 20:33,,"Update compression codec dependencies: - aircompressor 0.21 -> 0.24 - brotli4j 1.8.0 -> 1.11.0 - snappy 1.1.8.4 -> 1.1.9.1 - zstd-jni 1.5.0-4 -> 1.5.4-2 and add a new supplemental model for new brotli4j dependency." Change Iterable to List in SnapshotFileCache,13521238,Resolved,Minor,Fixed,25/Jan/23 08:57,13/Feb/23 13:43,,"The HFileCleaners can have low performance on large /archive area when used with slow storage like S3. The snapshot write lock in SnapshotFileCache is held while the file metadata is fetched from S3. Due to this even with multiple cleaner threads only a single cleaner can effectively delete files from the archive. File metadata collection is performed before SnapshotHFileCleaner just by changing the passed parameter type in FileCleanerDelegate from Iterable to List. Running with the below cleaner configurations I observed that the lock held in SnapshotFileCache went down from 45000ms to 100ms  when it was running for 1000 files in a directory. The complete evaluation and deletion for this folder took the same time but since the file metadata fetch from S3 was done outside of the lock the multiple cleaner threads were able to run concurrently. {noformat} hbase.cleaner.directory.sorting=false hbase.cleaner.scan.dir.concurrent.size=0.75 hbase.regionserver.hfilecleaner.small.thread.count=16 hbase.regionserver.hfilecleaner.large.thread.count=8 {noformat} The files to evaluate are already passed in a List to CleanerChore.checkAndDeleteFiles but it is converted to an Iterable to run the checks on the configured cleaners." ruby shell not handled SyntaxError exceptions properly,13528891,Resolved,Minor,Fixed,17/Mar/23 03:34,29/Mar/23 09:10,2.5.2,"hbase:002:0> create 't2', 'cf' 2023-03-14 04:54:50,061 INFO  [main] client.HBaseAdmin: Operation: CREATE, Table Name: default:t2, procId: 2140 completed Created table t2 Took 1.1503 seconds => Hbase::Table - t2 hbase:003:0> alter 't2', NAME ⇒ 'cf', VERSIONS ⇒ 5 SyntaxError: (hbase):3: syntax error, unexpected tIDENTIFIER alter 't2', NAME ⇒ 'cf', VERSIONS ⇒ 5                  ^~~                       eval at org/jruby/RubyKernel.java:1091                   evaluate at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/workspace.rb:85                   evaluate at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/context.rb:385                 eval_input at uri:classloader:/irb/hirb.rb:115              signal_status at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:647                 eval_input at uri:classloader:/irb/hirb.rb:112   each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:246                       loop at org/jruby/RubyKernel.java:1507   each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:232                      catch at org/jruby/RubyKernel.java:1237   each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:231                 eval_input at uri:classloader:/irb/hirb.rb:111                        run at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:428                      catch at org/jruby/RubyKernel.java:1237                        run at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:427
at classpath:/jar-bootstrap.rb:226" Bump hbase to 2.4.16 and hbase-thirdparty to 4.1.4 for hbase-operator-tools,13530005,Resolved,Minor,Won't Fix,24/Mar/23 16:45,24/Mar/23 17:20,, Add supplemental model for com.aayushatharva.brotli4j:native-osx-aarch64,13529273,Resolved,Minor,Fixed,20/Mar/23 16:00,21/Mar/23 14:24,2.5.0,License aggregation fails on Apple Silicon because we're missing the supplemental model entry for this architecture's brotli4j implementation. Client should not be able to restore/clone a snapshot after it's TTL has expired,13526317,Resolved,Minor,Fixed,27/Feb/23 10:41,20/Mar/23 22:14,2.5.2,"Steps: precondition : base.master.cleaner.snapshot.interval to 5 min in hbase-site.xml 1. create a table t1 , put some data 2. create a snapshot 'snapt1' with TTL 1 mins let the TTL expries  3. disable and drop table t1 4. restore snapshot t1 Actual : restore snapshot successful  Expected : restore operation should fail and throw specified snapshot TTL expried cant restore Note : its can consider as improvement point " hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM,13525179,Resolved,Minor,Fixed,17/Feb/23 10:14,20/Mar/23 14:37,2.4.17,"Running HBase in a container environment, launched using {{{}bin/hbase-daemon.sh foreground_start ...{}}}. Signaling the container for config refresh or for graceful termination doesn't make it through to the JVM process. Rather, the {{trap}} function is unconditionally sending {{{}kill -9{}}}." Should not use pread when prefetching in HFilePreadReader,13525006,Resolved,Minor,Fixed,16/Feb/23 10:47,20/Mar/23 11:29,2.5.3,"While prefetchOnOpen will read althrough the hfile, we should use stream read for it." Remove Java reflection used in FSUtils.create() ,13529310,Open,Minor,,20/Mar/23 20:10,,,"FSUtils.create() uses reflection to access a HDFS API DistributedFileSystem.create() that supports favored node. This API is added in Hadoop 2.1.0-beta (HDFS-2576) so we can use it directly without reflection." The regionStateNode only need remove once in regionOffline,13528462,Resolved,Minor,Fixed,14/Mar/23 15:14,19/Mar/23 12:24,2.4.14,"The regionStateNode only need remove once in regionOffline when delete a table. In org.apache.hadoop.hbase.master.assignment.AssignmentManager#deleteTable   why need delete twice? i think one is enougth" Remove DNS reflection helper method,13529295,Open,Minor,,20/Mar/23 19:19,,,"HBASE-14594 used a reflection helper method to use an Hadoop API added in 2.8.0. We should remove this reflection from the master branch now. https://github.com/apache/hbase/blob/fbe3b90e0c4eef1dc13fb2a5ed9381106ca671dd/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DNS.java#L57" Fix surefire corrupted channel,13528589,Open,Minor,,15/Mar/23 09:15,,,"Testing, at least with hbase-server, emits a warning, {noformat} [WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-5036/yetus-jdk8-hadoop2-check/src/hbase-server/target/surefire-reports/2023-03-14T13-20-30_932-jvmRun1.dumpstream {noformat} I cannot tell if this is causing maven to recognize the test run as a failure, though in this case, the test run was marked as failing, with two tests rerun and passing on their second attempt. Surefire apparently uses stdio to communicate with maven, so when our code under test produces output on the channel, it corrupts that communication. https://maven.apache.org/surefire/maven-surefire-plugin/examples/process-communication.html#the-tcp-ip-communication-channel" ZStdCodec codec implementation class documentation typo,13527994,Resolved,Minor,Fixed,10/Mar/23 15:03,13/Mar/23 09:34,,As mentioned in the [user@hbase.apache.org|mailto:user@hbase.apache.org] mailing list I noticed a small typo in the documentation on compression for Zstd. The codec implementation class in the documentation is listed as {{org.apache.hadoop.hbase.io.compress.zstd.ZStdCodec}} while the actual class is written with a lower case S: {{ZStdCodec.}} rolling-restart.sh stop all masters at the same time,13527925,Open,Minor,,10/Mar/23 06:35,,,"The rolling-restart.sh in $HBASE_HOME/bin would stop all master service (including the backup ones) at the same time, and then restart them at the same time: {code:java} # The content of rolling-restart.sh ... # stop all masters before re-start to avoid races for master znode ""$bin""/hbase-daemon.sh --config ""${HBASE_CONF_DIR}"" stop master ""$bin""/hbase-daemons.sh --config ""${HBASE_CONF_DIR}"" \ --hosts ""${HBASE_BACKUP_MASTERS}"" stop master-backup # make sure the master znode has been deleted before continuing zmaster=`$bin/hbase org.apache.hadoop.hbase.util.HBaseConfTool zookeeper.znode.master` ... # all masters are down, now restart ""$bin""/hbase-daemon.sh --config ""${HBASE_CONF_DIR}"" ${START_CMD_DIST_MODE} master ""$bin""/hbase-daemons.sh --config ""${HBASE_CONF_DIR}"" \ --hosts ""${HBASE_BACKUP_MASTERS}"" ${START_CMD_DIST_MODE} master-backup {code} In this way the HMaster service would be unavailable during this period. We can restart them in a more graceful way, like this: * Stop the backup masters, and then restart them one by one * Stop the active master, then one of the backup master would become active * Start the original active master, now it's the backup one Will upload patch soon." Enable code coverage reporting to SonarQube in HBase,13526960,Resolved,Minor,Fixed,03/Mar/23 09:28,10/Mar/23 20:44,, Fix a misspell in TestRegionStateStore,13527427,Resolved,Minor,Fixed,07/Mar/23 09:56,08/Mar/23 15:28,, "Metrics for RPC handlers should provide more info, e.g. avg,max",13526813,Open,Minor,,02/Mar/23 08:08,,2.5.3,"We need the distribution info of the handler count to address problems of performance, e.g. the maximum value, the average value of the handlers.  It is extremly importance for system of low latency requests." Expose master startup status via JMX,13524746,Open,Minor,,15/Feb/23 01:39,,,"As described in HBASE-21521 by [~apurtell] ,  add an internal API to the master for tracking startup progress. Expose this information via JMX." Verify replication reporting excessive BADROWS,13524733,Open,Minor,,14/Feb/23 22:47,,,"Verify replication can generate a lot of `BADROWS` results when comparing a row that may be particularly hot at the time of re-compare. This can lead to a mismatch between the source and sink result due to replication lag.  We could add some configurable re-compare mechanism that will make verify replication less susceptible to falsely reporting `BADROWS` when under significant write load. These re-compares can be done asynchronously so as to not significantly slow down the execution time of the job." Suppress noisy logging in client.ConnectionImplementation,13523954,Resolved,Minor,Fixed,09/Feb/23 11:38,09/Feb/23 18:34,2.4.16,"_client.ConnectionImplementation_ logs a lot at INFO level: {code:java} hbase:001:0> restore_snapshot 'tableSnapshot' 2023-02-09 05:15:35,538 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:35,538 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:36,599 INFO [main] client.HBaseAdmin: Taking restore-failsafe snapshot: hbase-failsafe-tableSnapshot-1675919736599 2023-02-09 05:15:36,608 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:36,608 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:36,806 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:36,806 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:37,026 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:37,026 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:37,334 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:37,334 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:37,341 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:37,342 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:37,413 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:37,413 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:37,534 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:37,535 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:37,742 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:37,742 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:38,055 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:38,056 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:38,561 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:38,561 INFO [main] client.ConnectionImplementation: Getting master state using rpc call 2023-02-09 05:15:38,568 INFO [main] client.HBaseAdmin: Operation: MODIFY, Table Name: nj:testImport, procId: 392 completed 2023-02-09 05:15:38,568 INFO [main] client.HBaseAdmin: Deleting restore-failsafe snapshot: hbase-failsafe-tableSnapshot-1675919736599 2023-02-09 05:15:38,570 INFO [main] client.ConnectionImplementation: Getting master connection state from TTL Cache 2023-02-09 05:15:38,570 INFO [main] client.ConnectionImplementation: Getting master state using rpc call Took 3.1595 seconds {code} We should log these lines in TRACE level." Potential client thread pool leak in MetricsConnection.,13524069,Resolved,Minor,Invalid,09/Feb/23 19:02,09/Feb/23 21:12,2.5.2,"The thread pools are not explicitly deleted from the list, this may keep the thread pools in the list forever and eventually may cause leaks." update download.xml for release 2.5.3,13523096,Resolved,Minor,Fixed,05/Feb/23 10:28,06/Feb/23 06:59,, ThreadGroup is removed since Hadoop 3.2.4,13521719,Resolved,Minor,Fixed,27/Jan/23 10:57,02/Feb/23 06:44,,"Found lots of WARNING in UT log: {code:java} 2023-01-26T05:26:18,869 WARN [FsDatasetAsyncDiskServiceFixer] hbase.HBaseTestingUtil$FsDatasetAsyncDiskServiceFixer(617): failed to reset thread pool timeout for FsDatasetAsyncDiskService java.lang.NoSuchFieldException: threadGroup at java.lang.Class.getDeclaredField(Class.java:2411) ~[?:?] at org.apache.hadoop.hbase.HBaseTestingUtil$FsDatasetAsyncDiskServiceFixer.run(HBaseTestingUtil.java:609) ~[test-classes/:?] {code} FsDatasetAsyncDiskServiceFixer is introduced by [HBASE-27148|https://issues.apache.org/jira/browse/HBASE-27148], to prevent unexpected kill. But Hadoop 3.2.4 has fixed this issue [HDFS-16586|https://issues.apache.org/jira/browse/HDFS-16586] and for now HBase use 3.2.4 on branch master. So I think maybe can remove these code. " Update releaseTarget for JDK11+,13517171,Resolved,Minor,Won't Do,09/Jan/23 03:39,09/Jan/23 04:53,,"For now the default value of releaseTarget is 8, but I think it is a little strange, It should be unlikely that it will be compiled with JDK11+ and then run on an 8 JVM. So maybe we can update the default value." """Instantiating StoreFileTracker impl"" INFO level logging is too chatty",13521181,Resolved,Minor,Fixed,24/Jan/23 22:09,25/Jan/23 22:46,," INFO [] storefiletracker.StoreFileTrackerFactory: instantiating StoreFileTracker impl .... This should be logged at DEBUG level as it is debug information. It is frequently printed in the logs and because it's the same impl every time (although in theory could be varied in table schema) there is no value for operators, it just consumes logging resources." [JDK17] Fix failure TestImmutableScan#testScanCopyConstructor,13521266,Resolved,Minor,Fixed,25/Jan/23 10:47,27/Jan/23 15:21,,"{code:java} [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR]   TestImmutableScan.testScanCopyConstructor:113->compareGetters:351 » InaccessibleObject Unable to make field private static final long java.util.Collections$UnmodifiableMap.serialVersionUID accessible: module java.base does not ""opens java.util"" to unnamed module @18be83e4 [INFO] [ERROR] Tests run: 249, Failures: 0, Errors: 1, Skipped: 0{code}" CatalogJanitor consistencyCheck cannot report the hole on last region if next table is disabled in meta,13517244,Resolved,Minor,Fixed,09/Jan/23 13:14,11/Jan/23 10:50,2.4.15,"When doing metaTableConsistencyCheck with ReportMakingVisitor, it will skip to check disabled table. When table before the disabled table in meta has a hole on last region,  it cannot be added to holes pairs." [JDK17] Update shade plugin version,13517033,Resolved,Minor,Fixed,06/Jan/23 10:54,20/Jan/23 05:33,,"maven-shade-plugin:3.2.4 cannot support JDK17, if build HBase with releaseTarget=17 will meet this error: !image-2023-01-06-18-54-09-703.png! So need to update it's version." Bump future from 0.18.2 to 0.18.3 in /dev-support,13519959,Resolved,Minor,Fixed,17/Jan/23 22:16,20/Jan/23 02:27,2.4.15,"Bump future from 0.18.2 to 0.18.3 in /dev-support. Dependabot PR: https://github.com/apache/hbase/pull/4980" Errorprone cleanup in hbase-backup,13520744,In Progress,Minor,,20/Jan/23 13:36,,,"I noticed a bunch of javac warnings in backporting the backups feature to branch-2. The same problems exist in master branch. Let's cleanup error prone warnings in both branches once the backport lands. See [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4770/10/artifact/yetus-general-check/output/diff-compile-javac-root.txt] for initial set to fix. Mostly in tests." Introduce ChaosMonkey Action to print HDFS Cluster status,13517845,Resolved,Minor,Fixed,12/Jan/23 13:02,16/Jan/23 14:53,2.4.16,"We have ChaosMonkey actions for perturbing HDFS components, but we lack a means to periodically display status/health. Introduce a ""dump"" action similar to the one we have for HBase." balance_rsgroup NullPointerException,13519760,Open,Minor,,16/Jan/23 10:57,,,"hbase shell hbase(main):001:0> balance_rsgroup 'default' ERROR: java.io.IOException         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:469)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) Caused by: java.lang.NullPointerException   hbase server log 2023-01-16 18:53:51,418 INFO  [RpcServer.default.RWQ.Fifo.read.handler=315,queue=85,port=16000] rsgroup.RSGroupAdminEndpoint: Client=xxxxx balance rsgroup, group=default 2023-01-16 18:53:51,421 ERROR [RpcServer.default.RWQ.Fifo.read.handler=315,queue=85,port=16000] ipc.RpcServer: Unexpected throwable object java.lang.NullPointerException" ChaosMonkey sometimes generates invalid boundaries for random item selection,13517453,Resolved,Minor,Fixed,10/Jan/23 13:29,12/Jan/23 17:10,2.4.16,"While running chaos monkey, I occasionally see `IndexOutOfBoundsException` originating from `PolicyBasedChaosMonkey#selectRandomItems`. Looks like we make some false assumptions about the arguments passes to the function. " Process all patch-unit-root.txt in report-flakies.py ,13516663,Open,Minor,,05/Jan/23 16:34,,,"The report-flakies.py which parses the output of the unit tests does not review all the patch-unit-root.txt files. The for loop exists on the first found unit test output file and ignores the rest. Earlier the build only had a single unit test run but the current setup runs multiple builds based on the JDK or Hadoop version. All of these outputs should be parsed by the script." Description error in documentation of hbase.ipc.server.callqueue.read.ratio,13530788,Open,Trivial,,30/Mar/23 11:40,,,"There is an error in this document:[https://github.com/apache/hbase/blob/master/src/main/asciidoc/_chapters/performance.adoc] In 4.11 Tuning callQueue Options there is a description below: _A value of {{.6}} uses 60% of the queues for reading and 40% for reading. Given a value of {{10}} for {{{}hbase.ipc.server.num.callqueue{}}}, 6 queues would be used for reads and 4 for writes_ It shoud be :60% of the queues for reading and 40% for writing, not all reading." Remove the empty path annotation from ClusterMetricsResource,13525320,Resolved,Trivial,Fixed,19/Feb/23 10:00,28/Feb/23 13:41,2.5.0,"I see the following warning on starting HBase Master services. {code:java} 2023-02-19 03:35:39,034 WARN  [main] internal.Errors: The following warnings have been detected: WARNING: The (sub)resource method getBaseMetrics in org.apache.hadoop.hbase.master.http.api_v1.cluster_metrics.resource.ClusterMetricsResource contains empty path annotation. {code}" Spotless fix in RELEASENOTES.md,13524007,Resolved,Trivial,Fixed,09/Feb/23 15:58,09/Feb/23 16:39,2.4.16,"There is a whitespace vilotation in RELEASENOTES.md on branch-2.4 and branch-2.5 causing the pre-commit and nightly builds to fail. {noformat} [ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.27.2:check (default-cli) on project hbase: The following files had format violations: [ERROR] RELEASENOTES.md [ERROR] @@ -85,7 +85,7 @@ [ERROR] [ERROR] *·[HBASE-27529](https://issues.apache.org/jira/browse/HBASE-27529)·|·*Major*·|·**Provide·RS·coproc·ability·to·attach·WAL·extended·attributes·to·mutations·at·replication·sink** [ERROR] [ERROR] -New·regionserver·coproc·endpoints·that·can·be·used·by·coproc·at·the·replication·sink·cluster·if·WAL·has·extended·attributes.· [ERROR] +New·regionserver·coproc·endpoints·that·can·be·used·by·coproc·at·the·replication·sink·cluster·if·WAL·has·extended·attributes. [ERROR] Using·the·new·endpoints,·WAL·extended·attributes·can·be·transferred·to·Mutation·attributes·at·the·replication·sink·cluster. {noformat}" TestZooKeeperScanPolicyObserver and TestAdminShell fail 100% of times on flaky dashboard,13577475,Resolved,Blocker,Fixed,28/Apr/24 09:38,29/Apr/24 01:08,,"This is for branch-2.5+, need to figure out why before cutting any releases." HMaster crash when upgrading from HBase-2.5.8 to HBase-3.0.0-beta-1,13575709,Resolved,Critical,Duplicate,13/Apr/24 03:56,21/Nov/24 07:40,2.5.8,"h1. Reproduce Step1: Start up HBase-2.5.8 cluster: 4 nodes: 1 HM, 2 RS, 1 HDFS (hadoop-2.10.2). Step2: Perform a full-stop upgrade to HBase-3.0.0-beta-1 cluster: 1 HM, 2 RS, 1 HDFS (hadoop-2.10.2). +(No command is needed before the upgrade)+ HMaster aborts with the following exception {code:java} 2024-04-13T03:47:15,969 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILED         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:384) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:324) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1535) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1204) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2494) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-beta-1.jar:3.0.0-beta-1]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 2 actions: RetriesExhaustedException: 2 times, servers with issues:          at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.makeError(BufferedMutatorOverAsyncBufferedMutator.java:107) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.internalFlush(BufferedMutatorOverAsyncBufferedMutator.java:122) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.close(BufferedMutatorOverAsyncBufferedMutator.java:166) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.TableNamespaceManager.migrateNamespaceTable(TableNamespaceManager.java:92) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:122) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:61) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:252) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1532) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         ... 5 more 2024-04-13T03:47:15,970 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: Master server abort: loaded coprocessors are: [org.apache.hadoop.hbase.quotas.MasterQuotasObserver] 2024-04-13T03:47:15,970 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master hmaster,16000,1712980015693: Unhandled exception. Starting shutdown. ***** java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILED         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:384) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:324) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1535) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1204) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2494) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-beta-1.jar:3.0.0-beta-1]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 2 actions: RetriesExhaustedException: 2 times, servers with issues:          at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.makeError(BufferedMutatorOverAsyncBufferedMutator.java:107) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.internalFlush(BufferedMutatorOverAsyncBufferedMutator.java:122) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.client.BufferedMutatorOverAsyncBufferedMutator.close(BufferedMutatorOverAsyncBufferedMutator.java:166) ~[hbase-client-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.TableNamespaceManager.migrateNamespaceTable(TableNamespaceManager.java:92) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:122) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:61) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:252) ~[hbase-shaded-miscellaneous-4.1.5.jar:4.1.5]         at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1532) ~[hbase-server-3.0.0-beta-1.jar:3.0.0-beta-1]         ... 5 more 2024-04-13T03:47:15,971 INFO  [master/hmaster:16000:becomeActiveMaster] master.HMaster: ***** STOPPING master 'hmaster,16000,1712980015693' ***** 2024-04-13T03:47:15,971 INFO  [master/hmaster:16000:becomeActiveMaster] master.HMaster: STOPPED: Stopped by master/hmaster:16000:becomeActiveMaster 2024-04-13T03:47:15,971 INFO  [master/hmaster:16000] hbase.HBaseServerBase: Stop info server {code} I also tried upgrading from 2.5.8 to 3.0.0-alpha-1 and 3.0.0-alpha-4, they will encounter the same exception. I have attached my full logs. h1. Root Cause The exception is thrown when migrating Namespace data. The HBase doc mentions ""hbase:namespace table has been removed and fold into hbase:meta"". However, the exact root cause is still unclear." The GET call for column keys becomes significantly slower when it follows lexicographically prior deleted cells. [PERFORMANCE BLOAT],13583918,Open,Critical,,26/Jun/24 14:38,,2.5.5,"*Steps to Reproduce :*  1. Ensure the column family of the table is configured with MIN_VERSION = 1 and KEEP_DELETED_CELLS = true to ensure that deleted cells remain even after deletion (this is to ensure that flush/compaction doesn't remove deleted cells). 2. Add multiple column keys against a single row key. In this case, use a timestamp (SET1). 3. Use a GET call (GET1) with an iterator-based design to get all the keys. Use the ColumnPaginationFilter and RangeKeyFilter to achieve this (refer to the attached HbaseGet.java file for implementation details). 4. Note the time taken for GET1 (e.g., ~1 second for 100,000 entries). 5. Delete all the added column keys (SET1). 6. Add another set of 100,000 entries (SET2). 7. Use the GET call again (GET2) to retrieve the data and note the time taken. *Expected Behavior:* The time taken for GET2 should be similar to GET1, approximately ~1 second. *Actual Behavior:* The time taken for GET2 increases significantly, approximately 60 seconds, which is ~50 times longer than GET1. *Additional Information:* i) If, after the first delete (SET1), data with lexicographically prior characters (e.g., ""0"") are added before the deleted cells (timestamp), the GET call time remains consistent with GET1, approximately 1200 ms. ii) If all 200,000 entries are retrieved without deleting the first set (SET1), the total time is around 2 to 3 seconds. However, deleting SET1 causes GET2 to take 50 times longer than GET1. *Suggested Fix:* Temporarily, to fix this issue, add a dummy column key with a lexicographically prior character (e.g., ""0"") to ensure consistent GET call times. *Note:* Please refer to the attached [^HbaseGet.java], RegionserverFlameGraph  and dataFlow for detailed steps to reproduce the issue." Only allow one TableProcedureInterface for a single table to run at the same time for some special procedure types,13583346,Resolved,Critical,Fixed,20/Jun/24 15:13,17/Jul/24 01:45,,"We have a table lock in the MasterProcedureScheduler, which is designed to only allow one procedure to run at the same time when they require exclusive lock. But there is a problem that for availability, usually we can not always hold the exclusive lock through the whole procedure life time, as if so, we can not execute region assignment for this table too. The solution is to set holdLock to false, which means we will release the table lock after one execution cycle. In this way, it is possible that different table procedures may execute at the same time, which could mess things up. Especially that, in HBASE-28522, we find out that it is even impossible for DisableTableProcedure to hold the exclusive lock all the time. If the steps for DisableTableProcedure can be overlapped with other procedures like ModifyTableProcedure or even EnableTableProcedure, things will be definationly messed up... So we need to find another way to ensure that for a single table, only one of these procedures can be executed at the same time." UNASSIGN proc indefinitely stuck on dead rs,13575773,Resolved,Critical,Fixed,14/Apr/24 18:50,27/Jul/24 15:18,,"One scenario we noticed in production - we had DisableTableProc and SCP almost triggered at similar time 2024-03-16 17:59:23,014 INFO [PEWorker-11] procedure.DisableTableProcedure - Set to state=DISABLING 2024-03-16 17:59:15,243 INFO [PEWorker-26] procedure.ServerCrashProcedure - Start pid=21592440, state=RUNNABLE:SERVER_CRASH_START, locked=true; ServerCrashProcedure , splitWal=true, meta=false DisabeTableProc creates unassign procs, and at this time ASSIGNs of SCP is not completed {{2024-03-16 17:59:23,003 DEBUG [PEWorker-40] procedure2.ProcedureExecutor - LOCK_EVENT_WAIT pid=21594220, ppid=21592440, state=RUNNABLE:REGION_STATE_TRANSITION_GET_ASSIGN_CANDIDATE; TransitRegionStateProcedure table=, region=, ASSIGN}} UNASSIGN created by DisableTableProc is stuck on the dead regionserver and we had to manually bypass unassign of DisableTableProc and then do ASSIGN. If we can break the loop for UNASSIGN procedure to not retry if there is scp for that server, we do not need manual intervention?, at least the DisableTableProc can go to a rollback state?" replication quota leak when peer changes,13580567,Open,Critical,,27/May/24 13:25,,,"When peer changes, replication closes the reader and shipper created earlier. However, after the specified timeout, the shipper still does not automatically close (It was interrupted, but it didn't close properly). The existing code simply returns without releasing quota. Not cleaning buffer usage. In one practice of my company, in this case, the quota was full because it was not released in time, so wal reader could not continue read new data and replication had a backlog.   The log is as follows: 2024-05-20 20:00:00,796 WARN [RpcServer.default.FPRWQ.Fifo.read.handler=70,queue=1,port=16020] regionserver.ReplicationSourceShipper: Shipper clearWALEntryBatch method timed out whilst waiting reader/shipper thread to stop. Not cleaning buffer usage. Shipper alive: peer1; Reader alive: false 2024-05-20 20:00:01,351 WARN peer=peer1, can't read more edits from WAL as buffer usage 268435456B exceeds limit 268435456B" ModifyTableProcedure should not reset TRSP on region node when closing unused region replicas,13578761,Resolved,Critical,Fixed,09/May/24 14:24,29/May/24 15:23,,"Found this when digging HBASE-28522. First, this is not safe as MTP does not like DTP where we hold the exclusive lock all the time. Second, even if we hold the exclusive lock all the time, as showed in HBASE-28522, we may still hang there forever because SCP will not interrupt the TRSP." Optimize the verifyCopyResult logic in ExportSnapshot,13582337,Resolved,Critical,Fixed,12/Jun/24 01:47,21/Jun/24 17:12,,"In [HBASE-28625|https://issues.apache.org/jira/browse/HBASE-28625], we added checksum logic comparison for ExportSnapshot files, but the checksum verification scenarios were too simple. This issue aims to address the existing problem. For detailed discussion, please refer to PR [5950|https://github.com/apache/hbase/pull/5950]." Losing exception from scan RPC can lead to partial results,13579378,Resolved,Critical,Fixed,15/May/24 14:05,18/May/24 14:50,,"This was discovered in Apache Impala using HBase 2.2 based branch hbase client and server. It is not clear yet whether other branches are also affected. The issue happens if the server side of the scan throws an exception and closes the scanner, but at the same time, the client gets an rpc connection closed error and doesn't process the exception sent by the server. Client then thinks it got a network error, which leads to retrying the RPC instead of opening a new scanner. But then when the client retry reaches the server, the server returns an empty ScanResponse instead of an error, leading to closing the scanner on client side without returning any error. A few pointers to critical parts: region server: 1st call throws exception leading to closing (but not deleting) scanner: [https://github.com/apache/hbase/blob/0c8607a35008b7dca15e9daaec41ec362d159d67/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3539] 2nd call (retry of 1st) returns empty results: [https://github.com/apache/hbase/blob/0c8607a35008b7dca15e9daaec41ec362d159d67/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3403] client: some exceptions are handled as non-retriable at RPC level and are only handled through opening a new scanner: [https://github.com/apache/hbase/blob/0c8607a35008b7dca15e9daaec41ec362d159d67/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L214] [https://github.com/apache/hbase/blob/0c8607a35008b7dca15e9daaec41ec362d159d67/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java#L367] This mechanism in the client only works if it gets the exception from the server. If there are connection issues during the RPC then the client won't really know the state of the server." The StochasticLoadBalancer should support discrete evaluations for replica distribution,13575394,Open,Major,,10/Apr/24 18:54,,,"I have a larger write up available [here|https://docs.google.com/document/d/1jA8Ghs86v7b-53j5DcsdbPnOXxbHjewkIBFi1E4S1pY/edit?usp=sharing]. Secondary replica balancing squashes all other cost considerations. Basically there are a few cost functions with relatively huge default multipliers. For example `PrimaryRegionCountSkewCostFunction` has a default multiplier of 100,000. Meanwhile things like StoreFileCostFunction have a multiplier of 5. Having any multiplier of 100k, while others are single digit, basically makes the latter category totally irrelevant from balancer considerations. I understand that it's critical to distribute a region's replicas across multiple hosts/racks, but I don't think we should do this at the expense of all other balancer considerations. For example, maybe we could have two types of balancer considerations: costs (as we do now), and conditionals (for the more discrete considerations, like "">1 replica of the same region should not exist on a single host""). This would allow us to prioritize replica distribution _and_ maintain consideration for things like storefile balance." "Support streams in REST Client, RemoteHTable and RemoteAdmin",13582102,Patch Available,Major,,10/Jun/24 06:57,,,"Support using streams for sending/receiving data in org.apache.hadoop.hbase.rest.client.Client . Also update tests to use the new methods." REST ScannerModel doesn't support includeStartRow/includeStopRow,13580882,Resolved,Major,Fixed,29/May/24 14:38,10/Jan/25 19:14,,"includeStartRow/includeStopRow should be transparently supported. The current behaviour is limited and confusing, as the user would rightly expect this to work via the REST interface. The only problem is that adding them may break backwards compatibility. Need to test if the XML unmarshaller can handle nonexistent fields. " Enable setting blockcache on-heap sizes in bytes,13579632,Resolved,Major,Fixed,17/May/24 09:37,14/Jan/25 02:27,,Specifying blockcache and memcache sizes as a percentage of heap is not always ideal. Sometimes it's easier to specify exact values rather than backing into a percentage. Let's introduce new configuration settings (perhaps named similarly to {{hbase.bucketcache.size}}) that accept byte values. Even nicer would be if these settings accepted human-friendly byte values like {{512m}} or {{10g}}. "Extend REST Documentation: Stateless Scanner, table exists, multiget with filter",13575960,Resolved,Major,Fixed,16/Apr/24 06:13,09/Dec/24 09:45,,"The new features added in HBASE-28518 do not have documentation. While reviewing, I also found other undocumented interfaces, like TableScan, and options like globbed gets." Allow replication to different target table,13574653,Open,Major,,04/Apr/24 15:19,,,"At the moment, HBase replication assumes the source and target table have the same name. Our company is looking into a use case that would require replicating to an arbitrary target table.    *Potential Solution:* It seems that the WALKey stores the table name of it's corresponding edit should be applied to. We can add a setting to ReplicationPeerConfig that allows users to specify a source to target table mapping. This mapping can then be used to overwrite the WALKey's table before shipping the edit to the target cluster. " Fail-fast retry limit for specific errors to recover from remote procedure failure using server crash,13581576,Resolved,Major,Fixed,04/Jun/24 20:25,03/Jan/25 20:23,2.5.10,"As per one of the recent incidents, some regions faced 5+ minute of availability drop because before active master could initiate SCP for the dead server, some region moves tried to assign regions on the already dead regionserver. Sometimes, due to transient issues, we see that active master gets notified after few minutes (5+ minute in this case). {code:java} 2024-05-08 03:47:38,518 WARN  [RSProcedureDispatcher-pool-4790] procedure.RSProcedureDispatcher - request to host1,61020,1713411866443 failed due to org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Call to address=host1:61020 failed on local exception: org.apache.hadoop.hbase.exceptions.ConnectionClosedException: Connection closed, try=0, retrying... {code} And as we know, we have infinite retries here, so it kept going on..   Eventually, SCP could be initiated only after active master discovered the server as dead: {code:java} 2024-05-08 03:50:01,038 DEBUG [RegionServerTracker-0] master.DeadServer - Processing host1,61020,1713411866443; numProcessing=1 2024-05-08 03:50:01,038 INFO  [RegionServerTracker-0] master.RegionServerTracker - RegionServer ephemeral node deleted, processing expiration [host1,61020,1713411866443] {code} leading to {code:java} 2024-05-08 03:50:02,313 DEBUG [RSProcedureDispatcher-pool-4833] assignment.RegionRemoteProcedureBase - pid=54800701, ppid=54800691, state=RUNNABLE; OpenRegionProcedure 5cafbe54d5685acc6c4866758e67fd51, server=host1,61020,1713411866443 for region state=OPENING, location=host1,61020,1713411866443, table=T1, region=5cafbe54d5685acc6c4866758e67fd51, targetServer host1,61020,1713411866443 is dead, SCP will interrupt us, give up {code} This entire duration of outage could be avoided if we can fail-fast for connection drop errors.   *Problem Statement:* Master initiated remote procedures are scheduled by RSProcedureDispatcher. If it encounters specific errors on first retry (e.g. CallQueueTooBigException or SaslException), it is guaranteed that the remote call has not reached the regionserver, therefore the remote call is marked failed prompting the parent procedure to select different target regionserver to resume the operation. If the first attempt is successful, RSProcedureDispatcher continues with infinite retries. We can encounter valid case (e.g. ConnectionClosedException) which is halting the remote operation. Without manual intervention, it can cause significant delay upto several minutes or hours to the region-in-transition.   *Proposed Solution:* The purpose of this Jira is to impose retry limit for specific error types such that if the retry limit is reached, the master can recover the state of the ongoing remote call failure by initiating SCP (ServerCrashProcedure) on the target server. The SCP is going to override the TRSP (TransitRegionStateProcedure) if required. This can ensure that the target server has no region hosted online before we suspend the ongoing TRSP. Scheduling SCP for the target server will always lead to the regionserver in stopped state. Either regionserver would be automatically stopped, or if the regionserver is able to send the region report to master, master will reject it, which will further lead to regionserver abort." ScanResumer.resume would perform unnecessary scan when close AsyncTableResultScanner,13575272,Resolved,Major,Fixed,10/Apr/24 03:20,20/Apr/24 07:43,2.6.0,"When we invoke {{AsyncTableResultScanner.close}}, {{AsyncTableResultScanner.resultQueue}} is cleared and {{AsyncTableResultScanner.closed}} is set to true, and we do not need any more scan results. But if there is a {{ScanResumser}}, {{ScanResumer.resume}} would be invoked to perform another unnecessary scan on {{RegionServer}} and call {{AsyncTableResultScanner.onNext}} again when {{ScanResponse}} is received. {{AsyncTableResultScanner.onNext}} would do nothing else but just discard scan results because {{AsyncTableResultScanner.closed}} is true. We could save this unnecessary scan on {{RegionServer}} and close scanner directly ." Implement HTTP session support in REST server and client for default auth,13574769,Open,Major,,05/Apr/24 11:32,,,"The REST server (and java client) currently does not implement sessions. While is not necessary for the REST API to work, implementing sessions would be a big improvement in throughput and resource usage. * It would make load balancing with sticky sessions possible * It would save the overhead of performing authentication for each request The gains are particularly big when using SPENGO: * The full SPENGO handshake can be skipped for subsequent requests * When Knox performs SPENGO authentication for the proxied client, it access the identity store each time. When the session is set, this step is only perfomed on the initial request. The same change has resulted in spectacular performance improvements for Phoenix Query Server when implemented in Avatica." Optimise BucketCache usage upon regions splits/merges.,13579398,Reopened,Major,,15/May/24 16:48,,2.6.0,"This proposal aims to give more flexibility for users to decide whether or not blocks from a parent region should be evict, and also optimise cache usage by resolving file reference blocks to the referred block in the cache. Some extra context: 1) Originally, the default behaviour on splits was to rely on the ""hbase.rs.evictblocksonclose"" value to decide if the cached blocks from the parent split should be evicted or not. Then the resulting split daughters get open with refs to the parent file. If hbase.rs.prefetchblocksonopen is set, these openings will trigger a prefetch of the blocks from the parent split, now with cache keys from the ref path. That means, if ""hbase.rs.evictblocksonclose"" is false and “hbase.rs.prefetchblocksonopen” is true, we will be duplicating blocks in the cache. In scenarios where cache usage is at capacity and added latency for reading from the file system is high (for example reading from a cloud storage), this can have a severe impact, as the prefetch for the refs would trigger evictions. Also, the refs tend to be short lived, as compaction is triggered on the split daughters soon after it’s open. 2) HBASE-27474 has changed the original behaviour described above, to now always evict blocks from the split parent upon split is completed, and skipping prefetch for refs (since refs are short lived). The side effect is that the daughters blocks would only be cached once compaction is completed, but compaction itself will run slower since it needs to read the blocks from the file system. On regions as large as 20GB, the performance degradation reported by users has been severe. This proposes a new “hbase.rs.evictblocksonsplit” configuration property that makes the eviction over split configurable. Depending on the use case, the impact of mass evictions due to cache capacity may be higher, in which case users might prefer to keep evicting split parent blocks. Additionally, it modifies the way we handle refs when caching. HBASE-27474 behaviour was to skip caching refs to avoid duplicate data in the cache as long as compaction was enabled, relying on the fact that refs from splits are usually short lived. Here, we propose modifying the search for blocks cache keys, so that we always resolve the referenced file first and look for the related referenced file block in the cache. That way we avoid duplicates in the cache and also expedite scan performance on the split daughters, as it’s now resolving the referenced file and reading from the cache." """WAL system stuck?"" due to threads hang at org.apache.hadoop.hbase.regionserver.MultiVersionConcurrencyControl.complete",13574817,Open,Major,,05/Apr/24 18:54,,2.5.5,"Currently we come across a issue in write handler threads of a regionserver during AsyncFSWAL append operation. We could see regionserver's write handler threads is going to WAITING State  while acquiring lock for WAL append operation at  MultiVersionConcurrencyControl.begin   {code:java} ""RpcServer.default.FPRWQ.Fifo.write.handler=7,queue=3,port=16020"" #133 daemon prio=5 os_prio=0 tid=0x00007f9301fe7800 nid=0x329a02 runnable [0x00007f8a6489a000]    java.lang.Thread.State: TIMED_WAITING (parking)     at sun.misc.Unsafe.park(Native Method)     at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:338)     at com.lmax.disruptor.MultiProducerSequencer.next(MultiProducerSequencer.java:136)     at com.lmax.disruptor.MultiProducerSequencer.next(MultiProducerSequencer.java:105)     at com.lmax.disruptor.RingBuffer.next(RingBuffer.java:263)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$stampSequenceIdAndPublishToRingBuffer$10(AbstractFSWAL.java:1202)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$$Lambda$631/875615795.run(Unknown Source)     at org.apache.hadoop.hbase.regionserver.MultiVersionConcurrencyControl.begin(MultiVersionConcurrencyControl.java:144)     - locked <0x00007f8afa4d1a80> (a java.util.LinkedList)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(AbstractFSWAL.java:1201)     at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(AsyncFSWAL.java:647)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$appendData$14(AbstractFSWAL.java:1255)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$$Lambda$699/1762709833.call(Unknown Source)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)     at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.appendData(AbstractFSWAL.java:1255)     at org.apache.hadoop.hbase.regionserver.HRegion.doWALAppend(HRegion.java:7800)     at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4522)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4446)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4368)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:1033)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:951)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:916)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2892)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45008)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:415)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) {code}   Other write handler threads are getting BLOCKED state while waiting for above lock to get released.   {code:java} ""RpcServer.default.FPRWQ.Fifo.write.handler=38,queue=2,port=16020"" #164 daemon prio=5 os_prio=0 tid=0x00007f9303147800 nid=0x329a21 waiting for monitor entry [0x00007f8a61586000]    java.lang.Thread.State: BLOCKED (on object monitor)     at org.apache.hadoop.hbase.regionserver.MultiVersionConcurrencyControl.complete(MultiVersionConcurrencyControl.java:179)     - waiting to lock <0x00007f8afa4d1a80> (a java.util.LinkedList)     at org.apache.hadoop.hbase.regionserver.HRegion.doWALAppend(HRegion.java:7808)     at org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4522)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4446)     at org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4368)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:1033)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:951)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:916)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2892)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45008)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:415)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)     at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82){code} Due to above occurence , WAL system getting stucked and facing callqueueTooBig Exception {code:java} ERROR [MemStoreFlusher.0] o.a.h.h.r.MemStoreFlusher - Cache flush failed for region analytics:RawData,DIO|DISK_USAGE_STATS,1710357005367.55ec1db85903bbf9d2588b6d60b7b66f. org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=5472571, WAL system stuck?         at org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:171) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.blockOnSync(AbstractFSWAL.java:869) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doSync(AsyncFSWAL.java:668) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$sync$1(AbstractFSWAL.java:590) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) ~[hbase-common-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.sync(AbstractFSWAL.java:590) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.sync(AbstractFSWAL.java:580) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.HRegion.doSyncOfUnflushedWALChanges(HRegion.java:2779) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.HRegion.internalPrepareFlushCache(HRegion.java:2721) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2580) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2554) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2424) ~[hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:603) [hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:572) [hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$1000(MemStoreFlusher.java:65) [hbase-server-2.5.5.jar:2.5.5]         at org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:344) [hbase-server-2.5.5.jar:2.5.5] {code} Issue get fixed in above mentioned regionserver after restarting the process. But after sometime again same issue occurs in other regionserver.  " There is a possibility that data cannot be obtained during reverse fuzzy query.,13581338,Resolved,Major,Fixed,03/Jun/24 06:35,25/Nov/24 09:18,2.4.14,"this is my example: 1.   create 'abcd','f' put 'abcd','111311','f:name','aaaaa' put 'abcd','111444','f:name','aaaaa' put 'abcd','111511','f:name','aaaaa' put 'abcd','111611','f:name','aaaaa' put 'abcd','111446','f:name','aaaaa' put 'abcd','111777 ','f:name','aaaaa' put 'abcd',' 111777','f:name','aaaaa'   2.  When I don't use the reversed query, I can get the data. scan 'abcd', \{FILTER => org.apache.hadoop.hbase.filter.FuzzyRowFilter.new(Arrays.asList(Pair.new(Bytes.toBytesBinary('111433'),Bytes.toBytesBinary(""\xFF\xFF\xFF\xFF\x02\x02""))))} !image-2024-06-03-14-26-57-645.png!   3. When I use the reversed query, I can not get the data. scan 'abcd', \{REVERSED=>TRUE, FILTER => org.apache.hadoop.hbase.filter.FuzzyRowFilter.new(Arrays.asList(Pair.new(Bytes.toBytesBinary('111433'),Bytes.toBytesBinary(""\xFF\xFF\xFF\xFF\x02\x02""))))} !image-2024-06-03-14-27-17-516.png!   4.  The test shows that the following two issues may be related to this issue: HBASE-26232 How to reproduce the issue resolved by this issue? Currently, I solve the fuzzy query by rolling back the code of this issue. Is there a better solution?  " More sensible client meta operation timeout default,13579978,Resolved,Major,Fixed,21/May/24 13:54,21/Nov/24 14:40,2.4.17,"Documented behavior in the HBase reference for client meta operation timeout {{hbase.client.meta.operation.timeout}} default is that it will be set to the configured client operation timeout, but implementation is that it defaults to the default client operation timeout of 20 minutes. I propose to set the default meta operation to what is currently specified in the hbase reference:  From ""Timeout settings"" in the hbase reference: {panel} A higher-level timeout is hbase.client.operation.timeout which is valid for each client call. When an RPC call fails for instance for a timeout due to hbase.rpc.timeout it will be retried until hbase.client.operation.timeout is reached. Client operation timeout for system tables can be fine tuned by setting hbase.client.meta.operation.timeout configuration value. When this is not set its value will use hbase.client.operation.timeout {panel} There seem to be two very different dependencies on meta operation timeout: # End to end operation timeout for system table operations (2.x and 3) # Timeout to acquire {{userRegionLock}} to initiate meta scan in {{locateRegionInMeta}} (2.x blocking client only, see HBASE-28730 for more detail/related work) For case 1 I believe it makes sense from a user perspective that meta operation timeout, which is meant to apply to a specific subset of operations, will respect the 'general' operation timeout that is configured if the more specific meta operation timeout is not explicitly set.  For case 2 blocking client, the default meta timeout value defeats the purpose of the `userRegionLock` timeout if one has a typical setup where {{hbase.client.operation.timeout}} << 20 minutes and {{hbase.client.meta.operation.timeout}} is not explicitly set, which can lead to operations taking much longer than the configured operation timeout to actually timeout if there is e.g meta slowness and/or contention around userRegionLock on 2.x, see HBASE-28730 for more detail/related work." list_namespace not working after an incorrect user input,13582468,Open,Major,,13/Jun/24 02:45,,2.6.0,"When using hbase-3.0.0 or 2.6.0, there's a shell bug related to failure handling. If user inputs an incorrect *list_namespace* command, hshell throws an exception. However, it has a side effect on the following *list_namespace* command: the result becomes empty (incorrect). h1. Reproduce Execute the following 2 commands can reproduce this bug * The first command is an incorrect list_namespace command, which causes and exception. * The second command is a correct list_namespace command, its return value is incorrect (empty). {code:java} list_namespace, 'ns.*' list_namespace{code} Here's the execution result The return result of the second command is incorrect. {code:java} hbase:002:0> list_namespace, 'ns.*' Traceback (most recent call last): SyntaxError ((hbase):2: syntax error, unexpected end-of-file) list_namespace, 'ns.*'                       ^ hbase:003:0> list_namespace hbase:004:0>  {code} The expected output of list_namespace is {code:java} hbase:001:0> list_namespace NAMESPACE                                                                                                                              default                                                                                                                                hbase                                                                                                                                  2 row(s) Took 0.6820 seconds {code} h1. Root Cause This could be a bug in shell related to list_namespace. Restarting the shell restores normal functionality of the list_namespace command.        " PrefixFilter should use SEEK_NEXT_USING_HINT ,13580598,Resolved,Major,Fixed,27/May/24 17:52,06/Nov/24 07:54,,"Looking at PrefixFilter, I have noticed that it doesn't use the SEEK_NEXT_USING_HINT mechanism. AFAICT, we could safely set the the prefix as a next row hint, which could be a huge performance win. Of course, ideally the user would set the scan startRow to the prefix, which avoids the problem, but the user may forget to do that, or may use the filter in a filterList that doesn't allow for setting the start/stop rows close tho the prefix." Refactor direct interactions of Reference file creations to SFT interface,13578029,Resolved,Major,Fixed,03/May/24 06:10,04/Nov/24 08:06,,"HBASE-27826 introduces tracking of Link/Reference files with StoreFileTracker interface and with that, we can have the FileBasedStoreFileTracker implementation to track Link/Reference files only using .filelist file itself and not create actual link/ref files (virtual links). To support the same, we need to refactor all the direct interactions of Ref/Link file creations to SFT layer and this changes starts off with moving the current Reference file operations/logic to StoreFileTrackerBase. Post that we should be able to override/evolve the representation to handle Virtual Links." Add separate fields for column family and qualifier in REST message formats,13577896,Open,Major,,02/May/24 04:16,,,"The current format uses the archaic column field, which requires extra processing and copying to encode/decode the CF and CQ at both the server and client side. We need to: - Add a version field to the requests, to be enabled by clients that support the new format - Add the new fields to the JSON, XML and protobuf formats, and logic to use them. This should be doable in a backwards-compatible manner, with the server falling back to the old format if it receives an unversioned request." Backport HBASE-26123 Restore fields dropped by HBASE-25986 to public interfaces,13579017,In Progress,Major,,13/May/24 07:46,,, Race condition during WAL splitting leading to corrupt recovered.edits,13578273,Open,Major,,06/May/24 12:48,,2.4.17,"There is a race condition that can happen when a regionserver aborts initialisation while splitting a WAL from another regionserver. This race leads to writing the WAL trailer for recovered edits while the writer threads are still running, thus the trailer gets interleaved with the edits corrupting the recovered edits file (and preventing the region to be assigned). We've seen this happening on HBase 2.4.17, but looking at the latest code it seems that the race can still happen there. The sequence of operations that leads to this issue: * {{org.apache.hadoop.hbase.wal.WALSplitter.splitWAL}} calls {{outputSink.close()}} after adding all the entries to the buffers * The output sink is {{org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink}} and its {{close}} method calls first {{finishWriterThreads}} in a try block which in turn will call {{finish}} on every thread and then join it to make sure it's done. * However if the splitter thread gets interrupted because of RS aborting, the join will get interrupted and {{finishWriterThreads}} will rethrow without waiting for the writer threads to stop. * This is problematic because coming back to {{org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink.close}} it will call {{closeWriters}} in a finally block (so it will execute even when the join was interrupted). * {{closeWriters}} will call {{org.apache.hadoop.hbase.wal.AbstractRecoveredEditsOutputSink.closeRecoveredEditsWriter}} which will call {{close}} on {{{}editWriter.writer{}}}. * When {{editWriter.writer}} is {{{}org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter{}}}, its {{close}} method will write the trailer before closing the file. * This trailer write will now go in parallel with writer threads writing entries causing corruption. * If there are no other errors, {{closeWriters}} will succeed renaming all temporary files to final recovered edits, causing problems next time the region is assigned. Logs evidence supporting the above flow: Abort is triggered (because it failed to open the WAL due to some ongoing infra issue): {noformat} regionserver-2 regionserver 06:22:00.384 [RS_OPEN_META-regionserver/host01:16201-0] ERROR org.apache.hadoop.hbase.regionserver.HRegionServer - ***** ABORTING region server host01,16201,1709187641249: WAL can not clean up after init failed *****{noformat} We can see that the writer threads were still active after closing (even considering that the ordering in the log might not be accurate, we see that they die because the channel is closed while still writing, not because they're stopping): {noformat} regionserver-2 regionserver 06:22:09.662 [DataStreamer for file /hbase/data/default/aeris_v2/53308260a6b22eaf6ebb8353f7df3077/recovered.edits/0000000003169600719-host02%2C16201%2C1709180140645.1709186722780.temp block BP-1645452845-192.168.2.230-1615455682886:blk_1076340939_2645368] WARN  org.apache.hadoop.hdfs.DataStreamer - Error Recovery for BP-1645452845-192.168.2.230-1615455682886:blk_1076340939_2645368 in pipeline [DatanodeInfoWithStorage[192.168.2.230:15010,DS-2aa201ab-1027-47ec-b05f-b39d795fda85,DISK], DatanodeInfoWithStorage[192.168.2.232:15010,DS-39651d5a-67d2-4126-88f0-45cdee967dab,DISK], Datanode InfoWithStorage[192.168.2.231:15010,DS-e08a1d17-f7b1-4e39-9713-9706bd762f48,DISK]]: datanode 2(DatanodeInfoWithStorage[192.168.2.231:15010,DS-e08a1d17-f7b1-4e39-9713-9706bd762f48,DISK]) is bad. regionserver-2 regionserver 06:22:09.742 [split-log-closeStream-pool-1] INFO  org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink - Closed recovered edits writer path=hdfs://mycluster/hbase/data/default/aeris_v2/53308260a6b22eaf6ebb8353f7df3077/recovered.edits/0000000003169600719-host02%2C16201% 2C1709180140645.1709186722780.temp (wrote 5949 edits, skipped 0 edits in 93 ms) regionserver-2 regionserver 06:22:09.743 [RS_LOG_REPLAY_OPS-regionserver/host01:16201-1-Writer-0] ERROR org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink - Failed to write log entry aeris_v2/53308260a6b22eaf6ebb8353f7df3077/3169611655=[#edits: 8 = ] to log regionserver-2 regionserver java.nio.channels.ClosedChannelException: null regionserver-2 regionserver    at org.apache.hadoop.hdfs.ExceptionLastSeen.throwException4Close(ExceptionLastSeen.java:73) ~[hadoop-hdfs-client-3.2.4.jar:?] regionserver-2 regionserver    at org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:153) ~[hadoop-hdfs-client-3.2.4.jar:?] regionserver-2 regionserver    at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105) ~[hadoop-common-3.2.4.jar:?] regionserver-2 regionserver    at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:57) ~[hadoop-common-3.2.4.jar:?] regionserver-2 regionserver    at java.io.DataOutputStream.write(Unknown Source) ~[?:?] regionserver-2 regionserver    at org.apache.hadoop.hbase.io.ByteBufferWriterOutputStream.write(ByteBufferWriterOutputStream.java:94) ~[hbase-common-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.KeyValue.write(KeyValue.java:2093) ~[hbase-common-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.KeyValueUtil.oswrite(KeyValueUtil.java:737) ~[hbase-common-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.wal.WALCellCodec$EnsureKvEncoder.write(WALCellCodec.java:365) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:58) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.AbstractRecoveredEditsOutputSink$RecoveredEditsWriter.writeRegionEntries(AbstractRecoveredEditsOutputSink.java:237) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink.append(RecoveredEditsOutputSink.java:66) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink$WriterThread.writeBuffer(OutputSink.java:249) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink$WriterThread.doRun(OutputSink.java:241) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink$WriterThread.run(OutputSink.java:211) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver 06:22:09.745 [RS_LOG_REPLAY_OPS-regionserver/host01:16201-1-Writer-0] ERROR org.apache.hadoop.hbase.wal.OutputSink - Exiting thread regionserver-2 regionserver java.nio.channels.ClosedChannelException: null regionserver-2 regionserver    at org.apache.hadoop.hdfs.ExceptionLastSeen.throwException4Close(ExceptionLastSeen.java:73) ~[hadoop-hdfs-client-3.2.4.jar:?] regionserver-2 regionserver    at org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:153) ~[hadoop-hdfs-client-3.2.4.jar:?] regionserver-2 regionserver    at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105) ~[hadoop-common-3.2.4.jar:?] regionserver-2 regionserver    at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:57) ~[hadoop-common-3.2.4.jar:?] regionserver-2 regionserver    at java.io.DataOutputStream.write(Unknown Source) ~[?:?] regionserver-2 regionserver    at org.apache.hadoop.hbase.io.ByteBufferWriterOutputStream.write(ByteBufferWriterOutputStream.java:94) ~[hbase-common-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.KeyValue.write(KeyValue.java:2093) ~[hbase-common-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.KeyValueUtil.oswrite(KeyValueUtil.java:737) ~[hbase-common-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.wal.WALCellCodec$EnsureKvEncoder.write(WALCellCodec.java:365) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:58) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.AbstractRecoveredEditsOutputSink$RecoveredEditsWriter.writeRegionEntries(AbstractRecoveredEditsOutputSink.java:237) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink.append(RecoveredEditsOutputSink.java:66) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink$WriterThread.writeBuffer(OutputSink.java:249) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink$WriterThread.doRun(OutputSink.java:241) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink$WriterThread.run(OutputSink.java:211) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver 06:22:09.749 [split-log-closeStream-pool-1] INFO  org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink - Rename recovered edits hdfs://mycluster/hbase/data/default/aeris_v2/53308260a6b22eaf6ebb8353f7df3077/recovered.edits/0000000003169600719-host02%2C16201%2C1709180140645.1709186722780.temp to hdfs://mycluster/hbase/data/default/aeris_v2/53308260a6b22eaf6ebb8353f7df3077/recovered.edits/0000000003169611654{noformat} And we can see the {{finishWriterThreads}} was interrupted: {noformat} regionserver-2 regionserver 06:22:20.643 [RS_LOG_REPLAY_OPS-regionserver/host01:16201-1] WARN  org.apache.hadoop.hbase.regionserver.SplitLogWorker - Resigning, interrupted splitting WAL hdfs://mycluster/hbase/WALs/host02,16201,1709180140645-splitting/host02%2C16201%2C1709180140645.1709186722780 regionserver-2 regionserver java.io.InterruptedIOException: null regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink.finishWriterThreads(OutputSink.java:139) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.RecoveredEditsOutputSink.close(RecoveredEditsOutputSink.java:94) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.WALSplitter.splitWAL(WALSplitter.java:414) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:201) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.SplitLogWorker.splitLog(SplitLogWorker.java:108) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:100) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.SplitWALCallable.call(SplitWALCallable.java:46) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.regionserver.handler.RSProcedureHandler.process(RSProcedureHandler.java:49) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:98) [hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:?] regionserver-2 regionserver    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:?] regionserver-2 regionserver    at java.lang.Thread.run(Unknown Source) [?:?] regionserver-2 regionserver Caused by: java.lang.InterruptedException regionserver-2 regionserver    at java.lang.Object.wait(Native Method) ~[?:?] regionserver-2 regionserver    at java.lang.Thread.join(Unknown Source) ~[?:?] regionserver-2 regionserver    at java.lang.Thread.join(Unknown Source) ~[?:?] regionserver-2 regionserver    at org.apache.hadoop.hbase.wal.OutputSink.finishWriterThreads(OutputSink.java:137) ~[hbase-server-2.4.17.jar:2.4.17] regionserver-2 regionserver    ... 11 more{noformat}   The corrupted recovered edits file contained one additional piece of evidence towards a race condition. The 0 bytes that form the 32 bit trailer length were scattered through the file while the marker {{LAWP}} was written in one piece. This is because in OpenJDK11 {{writeInt}} writes each byte individually but byte arrays are written all at once.   Original bug report from Vlad Hanciuta." Hide old PR comments when posting new,13581787,Resolved,Major,Fixed,06/Jun/24 12:30,25/Sep/24 13:34,,"It would be really nice if the build bot would hide the old commits when it posts new ones. When a PR has been open for a while, we end up with more build-bot activity than human activity and it's easy to lose human comments." Authentication failure when running hbase-spark in local mode,13576309,In Progress,Major,,18/Apr/24 04:58,,connector-1.0.0,"h2. Problem When running Spark in local mode, hbase-spark fails to authenticate to a Kerberos secured HBase cluster. The error message is: {quote}No matching SASL authentication provider and supporting token found from providers for user: xxx@XXX.XXX (auth:PROXY) {quote} That is because {{applyCreds}} changes the authentication method of the current user to {{{}PROXY{}}}, when it should still be {{KERBEROS}} for local mode to run correctly. h2. Suggested solution To fix this, I propose removing {{{}applyCreds{}}}. The function is no longer needed and should be removed: 1. Because we should not change the authentication mode of the current user in local mode 2. And because the purpose of the function is no longer valid. It is not doing anything meaningful since the broadcasting of the user credentials was removed in this commit: [https://github.com/apache/hbase-connectors/commit/75e41365207408f5b47d5925469a49fd60078b5e] A pull request is on the way. h2. Testing The fix was manually tested against Kerberos secured HBase 2.4.17 + Hadoop 3.3.5 cluster using Spark 3.5.1, both in local mode and with Yarn master, running the following Python code. {code:java} df = (spark.read.format(""org.apache.hadoop.hbase.spark"") .option(""hbase.columns.mapping"", ""key STRING :key, state STRING info:state"") .option(""hbase.table"", ""hbase:meta"").load()) df.first() {code}  " Enable setting memcache on-heap sizes in bytes,13579633,Open,Major,,17/May/24 09:38,,,Specifying blockcache and memcache sizes as a percentage of heap is not always ideal. Sometimes it's easier to specify exact values rather than backing into a percentage. Let's introduce new configuration settings (perhaps named similarly to {{hbase.bucketcache.size}}) that accept byte values. Even nicer would be if these settings accepted human-friendly byte values like {{512m}} or {{10g}}. asyncwal should attempt to recover lease if close fails,13581569,Resolved,Major,Fixed,04/Jun/24 19:20,12/Jun/24 17:59,,"AsyncFSWAL does not verify that WAL gets closed properly. For example, HDDS-10609 found that Ozone close may fail because it runs out of space. In such a case, the executor thread responsible for closing WAL file simply exits, and the WAL remains open. It is okay for HDFS WAL to stay open, but Ozone does not support renaming open files, and therefore WAL archiving failed. See HDDS-10609 for more details." CVE-2024-29131 resolution,13575724,Open,Major,,13/Apr/24 12:05,,,"The CVE-2024-29131 is related to the package org.apache.commons:commons-configuration2. The current version used is 2.1.1. This needs to be upgraded to 2.10.1. I tried upgrading it. When commons-configuration2 is upgraded to 2.10.1 then the below error occurs in hbase-master:       Exception in thread ""main"" java.lang.NoSuchMethodError: org.apache.commons.text.lookup.StringLookupFactory.base64DecoderStringLookup()Lorg/apache/commons/text/lookup/StringLookup;         at org.apache.commons.configuration2.interpol.DefaultLookups.(DefaultLookups.java:68)         at org.apache.commons.configuration2.interpol.ConfigurationInterpolator$DefaultPrefixLookupsHolder.createDefaultLookups(ConfigurationInterpolator.java:647)         at org.apache.commons.configuration2.interpol.ConfigurationInterpolator$DefaultPrefixLookupsHolder.(ConfigurationInterpolator.java:627)         at org.apache.commons.configuration2.interpol.ConfigurationInterpolator$DefaultPrefixLookupsHolder.(ConfigurationInterpolator.java:614)         at org.apache.commons.configuration2.interpol.ConfigurationInterpolator.getDefaultPrefixLookups(ConfigurationInterpolator.java:290)         at org.apache.commons.configuration2.AbstractConfiguration.installDefaultInterpolator(AbstractConfiguration.java:378)         at org.apache.commons.configuration2.AbstractConfiguration.(AbstractConfiguration.java:125)         at org.apache.commons.configuration2.BaseConfiguration.(BaseConfiguration.java:36)         at org.apache.commons.configuration2.PropertiesConfiguration.(PropertiesConfiguration.java:1060)         at org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:114)         at org.apache.hadoop.metrics2.impl.MetricsConfig.create(MetricsConfig.java:97)         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:482)         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)         at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)         at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)         at org.apache.hadoop.hbase.metrics.BaseSourceImpl$DefaultMetricsSystemInitializer.init(BaseSourceImpl.java:54)         at org.apache.hadoop.hbase.metrics.BaseSourceImpl.(BaseSourceImpl.java:112)         at org.apache.hadoop.hbase.metrics.ExceptionTrackingSourceImpl.(ExceptionTrackingSourceImpl.java:47)         at org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceImpl.(MetricsThriftServerSourceImpl.java:54)         at org.apache.hadoop.hbase.thrift.MetricsThriftServerSourceFactoryImpl.createThriftOneSource(MetricsThriftServerSourceFactoryImpl.java:43)         at org.apache.hadoop.hbase.thrift.ThriftMetrics.(ThriftMetrics.java:75)         at org.apache.hadoop.hbase.thrift.ThriftServer.createThriftMetrics(ThriftServer.java:200)         at org.apache.hadoop.hbase.thrift.ThriftServer.setupParamters(ThriftServer.java:228)         at org.apache.hadoop.hbase.thrift.ThriftServer.run(ThriftServer.java:830)         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)         at org.apache.hadoop.hbase.thrift.ThriftServer.main(ThriftServer.java:861)" RS SIGSEGV under heavy replication load,13578807,Resolved,Major,Fixed,09/May/24 21:13,20/Sep/24 00:13,2.5.6,"I'm observing RS crashes under heavy replication load:   {code:java} # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f7546873b69, pid=29890, tid=36828 # # JRE version: Java(TM) SE Runtime Environment 18.9 (11.0.23+7) (build 11.0.23+7-LTS-222) # Java VM: Java HotSpot(TM) 64-Bit Server VM 18.9 (11.0.23+7-LTS-222, mixed mode, tiered, compressed oops, g1 gc, linux-amd64) # Problematic frame: # J 24625 c2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyBufferToStream(Ljava/io/OutputStream;Ljava/nio/ByteBuffer;II)V (75 bytes) @ 0x00007f7546873b69 [0x00007f7546873960+0x0000000000000209] {code}   The heavier load comes when a replication peer has been disabled for several hours for patching etc. When the peer is re-enabled the replication load is high until the peer is all caught up. The crashes happen on the cluster receiving the replication edits.   I believe this problem started after upgrading from 2.4.x to 2.5.x.   One possibly relevant non-standard config I run with: {code:java} hbase.region.store.parallel.put.limit     100   Added after seeing ""failed to accept edits"" replication errors in the destination region servers indicating this limit was being exceeded while trying to process replication edits. {code}   I understand from other Jiras that the problem is likely around direct memory usage by Netty. I haven't yet tried switching the Netty allocator to {{unpooled}} or {{{}heap{}}}. I also haven't yet tried any of the  {{io.netty.allocator.*}} options.   {{MaxDirectMemorySize}} is set to 26g.   Here's the full stack for the relevant thread:   {code:java} Stack: [0x00007f72e2e5f000,0x00007f72e2f60000], sp=0x00007f72e2f5e450, free space=1021k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) J 24625 c2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyBufferToStream(Ljava/io/OutputStream;Ljava/nio/ByteBuffer;II)V (75 bytes) @ 0x00007f7546873b69 [0x00007f7546873960+0x0000000000000209] J 26253 c2 org.apache.hadoop.hbase.ByteBufferKeyValue.write(Ljava/io/OutputStream;Z)I (21 bytes) @ 0x00007f7545af2d84 [0x00007f7545af2d20+0x0000000000000064] J 22971 c2 org.apache.hadoop.hbase.codec.KeyValueCodecWithTags$KeyValueEncoder.write(Lorg/apache/hadoop/hbase/Cell;)V (27 bytes) @ 0x00007f754663f700 [0x00007f754663f4c0+0x0000000000000240] J 25251 c2 org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.write(Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelHandlerContext;Ljava/lang/Object;Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (90 bytes) @ 0x00007f7546a53038 [0x00007f7546a50e60+0x00000000000021d8] J 21182 c2 org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(Ljava/lang/Object;Lorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (73 bytes) @ 0x00007f7545f4d90c [0x00007f7545f4d3a0+0x000000000000056c] J 21181 c2 org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.write(Ljava/lang/Object;ZLorg/apache/hbase/thirdparty/io/netty/channel/ChannelPromise;)V (149 bytes) @ 0x00007f7545fd680c [0x00007f7545fd65e0+0x000000000000022c] J 25389 c2 org.apache.hadoop.hbase.ipc.NettyRpcConnection$$Lambda$247.run()V (16 bytes) @ 0x00007f7546ade660 [0x00007f7546ade140+0x0000000000000520] J 24098 c2 org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(J)Z (109 bytes) @ 0x00007f754678fbb8 [0x00007f754678f8e0+0x00000000000002d8] J 27297% c2 org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run()V (603 bytes) @ 0x00007f75466c4d48 [0x00007f75466c4c80+0x00000000000000c8] j org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run()V+44 j org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run()V+11 j org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run()V+4 J 12278 c1 java.lang.Thread.run()V java.base@11.0.23 (17 bytes) @ 0x00007f753e11f084 [0x00007f753e11ef40+0x0000000000000144] v ~StubRoutines::call_stub V [libjvm.so+0x85574a] JavaCalls::call_helper(JavaValue*, methodHandle const&, JavaCallArguments*, Thread*)+0x27a V [libjvm.so+0x853d2e] JavaCalls::call_virtual(JavaValue*, Handle, Klass*, Symbol*, Symbol*, Thread*)+0x19e V [libjvm.so+0x8ffddf] thread_entry(JavaThread*, Thread*)+0x9f V [libjvm.so+0xdb68d1] JavaThread::thread_main_inner()+0x131 V [libjvm.so+0xdb2c4c] Thread::call_run()+0x13c V [libjvm.so+0xc1f2e6] thread_native_entry(Thread*)+0xe6 {code}      " Docs around configuring backups can lead to unexpectedly disabling other features,13580727,In Progress,Major,,28/May/24 17:42,,2.6.0,"In our documentation for enabling backups, we suggest that the user set the following: {code:java} hbase.master.logcleaner.plugins org.apache.hadoop.hbase.backup.master.BackupLogCleaner,... hbase.master.hfilecleaner.plugins org.apache.hadoop.hbase.backup.BackupHFileCleaner,... {code} A naive user will set these and not know what to do about the "",..."" part. In doing so, they will unexpectedly be disabling all of the default cleaners we have. For example here are the defaults: {code:java} hbase.master.logcleaner.plugins org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreWALCleaner hbase.master.hfilecleaner.plugins org.apache.hadoop.hbase.master.cleaner.TimeToLiveHFileCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreHFileCleaner {code} So basically disabling support for hbase.master.logcleaner.ttl and hbase.master.hfilecleaner.ttl. There exists a method BackupManager.decorateMasterConfiguration and BackupManager.decorateRegionServerConfiguration. They are currently javadoc'd as being for tests only, but I think we should call these in HMaster and HRegionServer. Then we can only require the user to set ""hbase.backup.enable"" and very much simplify our docs here." Upgrade from 2.5.9 to 3.0.0 crash with InvalidProtocolBufferException: Message missing required fields: old_table_schema,13578805,Open,Major,,09/May/24 21:12,,2.5.9,"When migrating data from 2.5.9 cluster (1HM, 2RS, 1 HDFS) to 3.0.0 (1 HM, 2 RS, 2 HDFS), I met the following exception and the upgrade failed. {code:java} 2024-05-10T00:54:45,936 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: Failed to become active master org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException: Message missing required fields: old_table_schema         at org.apache.hbase.thirdparty.com.google.protobuf.UninitializedMessageException.asInvalidProtocolBufferException(UninitializedMessageException.java:56) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.checkMessageInitialized(AbstractParser.java:45) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:97) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:102) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:25) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.Any.unpack(Any.java:118) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hadoop.hbase.procedure2.ProcedureUtil$StateSerializer.deserialize(ProcedureUtil.java:125) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.procedure.RestoreSnapshotProcedure.deserializeStateData(RestoreSnapshotProcedure.java:303) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProcedure(ProcedureUtil.java:295) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.store.ProtoAndProcedure.getProcedure(ProtoAndProcedure.java:43) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.store.InMemoryProcedureIterator.next(InMemoryProcedureIterator.java:90) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.loadProcedures(ProcedureExecutor.java:517) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$200(ProcedureExecutor.java:80) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$1.load(ProcedureExecutor.java:344) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.load(RegionProcedureStore.java:287) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:335) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:666) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1860) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1019) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2524) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] 2024-05-10T00:54:45,937 ERROR [master/hmaster:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master hmaster,16000,1715302475720: Unhandled exception. Starting shutdown. ***** org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException: Message missing required fields: old_table_schema         at org.apache.hbase.thirdparty.com.google.protobuf.UninitializedMessageException.asInvalidProtocolBufferException(UninitializedMessageException.java:56) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.checkMessageInitialized(AbstractParser.java:45) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:97) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:102) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.AbstractParser.parseFrom(AbstractParser.java:25) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hbase.thirdparty.com.google.protobuf.Any.unpack(Any.java:118) ~[hbase-shaded-protobuf-4.1.7.jar:4.1.7]         at org.apache.hadoop.hbase.procedure2.ProcedureUtil$StateSerializer.deserialize(ProcedureUtil.java:125) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.procedure.RestoreSnapshotProcedure.deserializeStateData(RestoreSnapshotProcedure.java:303) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureUtil.convertToProcedure(ProcedureUtil.java:295) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.store.ProtoAndProcedure.getProcedure(ProtoAndProcedure.java:43) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.store.InMemoryProcedureIterator.next(InMemoryProcedureIterator.java:90) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.loadProcedures(ProcedureExecutor.java:517) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$200(ProcedureExecutor.java:80) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$1.load(ProcedureExecutor.java:344) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.load(RegionProcedureStore.java:287) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:335) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:666) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1860) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:1019) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2524) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:613) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] {code} h1. Reproduce This bug can be reproduced deterministically with the following steps: Start up HBase 2.5.9 cluster (1 HM, 1 RS, 1 HDFS: hadoop 2.10.2) Execute the following commands {code:java} create 'tb1', {NAME => 'c0', VERSIONS => 1} snapshot 'tb1', 's1' disable 'tb1' restore_snapshot 's1' {code} Stop the 2.5.9 cluster, then start up *3.0.0 cluster (commit: 516c89e8597fb6)* The upgrade will fail with the above exception. h1. Root Cause This incompatibility between 2.5.9 and 3.0.0 is related to a newly added *required* field in proto file: _{*}old_table_schema{*}._ 2.5.9 {code:java} hbase-protocol-shaded/src/main/protobuf/MasterProcedure.proto message RestoreSnapshotStateData {   required UserInformation user_info = 1;   required SnapshotDescription snapshot = 2;   required TableSchema modified_table_schema = 3;   repeated RegionInfo region_info_for_restore = 4;   repeated RegionInfo region_info_for_remove = 5;   repeated RegionInfo region_info_for_add = 6;   repeated RestoreParentToChildRegionsPair parent_to_child_regions_pair_list = 7;   optional bool restore_acl = 8; }{code} 3.0.0 (516c89e8597fb6) {code:java} message RestoreSnapshotStateData {   required UserInformation user_info = 1;   required SnapshotDescription snapshot = 2;   required TableSchema modified_table_schema = 3;   repeated RegionInfo region_info_for_restore = 4;   repeated RegionInfo region_info_for_remove = 5;   repeated RegionInfo region_info_for_add = 6;   repeated RestoreParentToChildRegionsPair parent_to_child_regions_pair_list = 7;   optional bool restore_acl = 8;   required TableSchema old_table_schema = 9; } {code} In certain scenarios, the proto message does not contain the old_table_schema field. I am wondering whether *_old_table_schema_* field must be set as required.   I attached the master log. I am trying to find out the root cause. I appreciate any suggestions. Thank you!" Partition BackupSystemTable queries,13584202,Resolved,Major,Fixed,28/Jun/24 16:13,09/Sep/24 13:31,2.6.0,"When successfully taking an incremental backup, one of our final steps is to delete bulk load metadata from the system table for the bulk loads that needed to be captured in the given backup. This means that we will basically truncate the entire bulk loads system table in a single batch of the deletes after successfully taking an incremental backup. This logic occurs in {{{}BackupSystemTable#deleteBulkLoadedRows{}}}: {code:java} /* * Removes rows recording bulk loaded hfiles from backup table * @param lst list of table names * @param rows the rows to be deleted */ public void deleteBulkLoadedRows(List rows) throws IOException { try (Table table = connection.getTable(bulkLoadTableName)) { List lstDels = new ArrayList<>(); for (byte[] row : rows) { Delete del = new Delete(row); lstDels.add(del); LOG.debug(""orig deleting the row: "" + Bytes.toString(row)); } table.delete(lstDels); LOG.debug(""deleted "" + rows.size() + "" original bulkload rows""); } } {code} Depending on your usage, one may run tons of bulk loads between backups, so this design is needlessly fragile. We should partition these deletes so that we never erroneously fail a backup due to this." Revert the deprecation for methods in WALObserver,13578685,Resolved,Major,Fixed,09/May/24 03:47,08/Sep/24 12:49,,"Per the discussion in this thread https://lists.apache.org/thread/28c2tn4kn9gwvtsdtcbxx1c5tjdfh5jy" Remove deprecated methods in KeyValue,13578679,Resolved,Major,Fixed,09/May/24 02:59,23/May/24 03:21,, Don't clean bulk load system entries until backup is complete,13584205,Resolved,Major,Fixed,28/Jun/24 17:05,02/Sep/24 12:09,2.6.0,"I've been thinking through the incremental backup order of operations, and I think we delete rows from the bulk loads system table too early and, consequently, make it possible to produce a ""successful"" incremental backup that is missing bulk loads. To summarize the steps here, starting in {{{}IncrementalTableBackupCilent#execute{}}}: # We take an incremental backup of the WALs generated since the last backup # We ensure any bulk loads done since the last backup are appropriately represented in the new backup by going through the system table and copying the appropriate files to the backup directory # We delete all of the system table rows which told us about these bulk loads # We generate a backup manifest and mark the backup as complete If we began deleting any of the system table rows regarding bulk loads, but fail in steps 3 and 4 before we are able to mark the backup as complete, then we'll be in a precarious spot. If we retry an incremental backup then it may succeed, but it would not know to persist the bulk loaded files for which we have already deleted system table references. We could consider this issue an extension or replacement of https://issues.apache.org/jira/browse/HBASE-28084 in some ways, depending on what solution we land on. I think that we could fix this specific issue by reordering the bulk load table cleanup, but there will always be gotchas like this. Maybe it is simpler to require that the next backup be a full backup after any incremental failure." An unbounded backup failure message can cause an irrecoverable state for the given backup,13581792,Resolved,Major,Fixed,06/Jun/24 12:51,02/Sep/24 12:06,2.6.0,"The BackupInfo class has a failedMsg field which is a string of unbounded length. When a DistCp job fails then its failure message contains all of its source paths, and its failure message gets propagated to this failedMsg field on the given BackupInfo. If a DistCp job has enough source paths, then this will result in backup status updates being rejected: {noformat} java.lang.IllegalArgumentException: KeyValue size too large at org.apache.hadoop.hbase.client.ConnectionUtils.validatePut(ConnectionUtils.java:513) at org.apache.hadoop.hbase.client.HTable.validatePut(HTable.java:1095) at org.apache.hadoop.hbase.client.HTable.lambda$put$3(HTable.java:564) at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) at org.apache.hadoop.hbase.client.HTable.put(HTable.java:563) at org.apache.hadoop.hbase.backup.impl.BackupSystemTable.updateBackupInfo(BackupSystemTable.java:292) at org.apache.hadoop.hbase.backup.impl.BackupManager.updateBackupInfo(BackupManager.java:376) at org.apache.hadoop.hbase.backup.impl.TableBackupClient.failBackup(TableBackupClient.java:243) at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:317) at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.backupTables(BackupAdminImpl.java:603) at com.hubspot.hbase.recovery.core.backup.BackupManager.lambda$runBackups$2(BackupManager.java:145){noformat} Without the ability to update the backup's state, it will never be returned as a failed backup by the client. This means that any mechanisms designed for repairing or cleaning failed backups won't work properly. I think that a simple fix here would be fine: we should truncate the failedMsg field to a reasonable maximum size." Aborting Active HMaster is not rejecting reportRegionStateTransition if procedure is initialised by next Active master,13583660,Resolved,Major,Fixed,24/Jun/24 12:57,29/Aug/24 14:34,2.5.8,"A CloseRegionProcedure on master requests the RS to close the region and after closing the region RS reports RegionStateTransition back([here|https://github.com/apache/hbase/blob/d1015a68ed9f94d74668abd37edefd32f5e9305b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java#L1853]). On receiving the report, the master checks if regionNode has any procedure assigned to it ([code|https://github.com/apache/hbase/blob/d1015a68ed9f94d74668abd37edefd32f5e9305b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L1294]).    {code:java}  private boolean reportTransition(RegionStateNode regionNode, ServerStateNode serverNode,     TransitionCode state, long seqId, long procId) throws IOException {     ServerName serverName = serverNode.getServerName();     TransitRegionStateProcedure proc = regionNode.getProcedure();     if (proc == null) {       return false;     }     proc.reportTransition(master.getMasterProcedureExecutor().getEnvironment(), regionNode,       serverName, state, seqId, procId);     return true;   } {code} If regionNode doesn't have any procedure, the master just logs it and doesn't throw any error to RPC.    Think of a case when MasterFailover is happening and the new Active master only initialized the TRSP and CloseRegionProcedure. Now aborting Master has stale/false data. If the transition report comes to the aborting master, not rejecting this report is causing the procedure to get stuck.    *Logs for more understanding*  active master server4-1 failing {noformat} 2024-06-20 04:45:05,576 ERROR [iority.RWQ.Fifo.write.handler=3,queue=0,port=61000] master.HMaster - ***** ABORTING master server4-1,61000,1715413775736: Failed to record region server as started *****{noformat} *logs of new active master server5-1*   {noformat} 2024-06-20 04:49:28,893 DEBUG [aster/server5-1:61000:becomeActiveMaster] assignment.RegionStateStore - Load hbase:meta entry region=888a715d5926adbb89c985d8967f40d4, regionState=OPEN, lastHost=server1-119,61020,1717560166420, regionLocation=server1-119,61020,1717560166420, openSeqNum=34892620 024-06-20 04:49:51,886 INFO [PEWorker-22] procedure2.ProcedureExecutor - Initialized subprocedures=[{pid=16276416, ppid=16276108, state=RUNNABLE:REGION_STATE_TRANSITION_CLOSE; TransitRegionStateProcedure table=RIMBS.UPLOADER_JOB_DETAILS, region=888a715d5926adbb89c985d8967f40d4, UNASSIGN}] (on server5-1) 2024-06-20 04:49:52,022 INFO [PEWorker-40] procedure2.ProcedureExecutor - Initialized subprocedures=[{pid=16276470, ppid=16276416, state=RUNNABLE; CloseRegionProcedure 888a715d5926adbb89c985d8967f40d4, server=server1-119,61020,1717560166420}] (on server5-1){noformat}   *RS logs for closing*  {noformat} 2024-06-20 04:49:52,267 INFO [_REGION-regionserver/server1-119:61020-2] handler.UnassignRegionHandler - Close 888a715d5926adbb89c985d8967f40d4 2024-06-20 04:49:52,267 DEBUG [_REGION-regionserver/server1-119:61020-2] regionserver.HRegion - Closing 888a715d5926adbb89c985d8967f40d4, disabling compactions & flushes 2024-06-20 04:49:52,354 INFO [_REGION-regionserver/server1-119:61020-2] regionserver.HRegion - Closed TABLE,KW\x00na240-app1-16\x00/Events-120620231740\x00MARKER-Events,1702619592612.888a715d5926adbb89c985d8967f40d4. {noformat} *Logs of report on aborting active Hmaster* {noformat} 2024-06-20 04:49:52,355 WARN [iority.RWQ.Fifo.write.handler=1,queue=0,port=61000] assignment.AssignmentManager - No matching procedure found for server1-119,61020,1717560166420 transition on state=OPEN, location=server1-119,61020,1717560166420, table=RIMBS.UPLOADER_JOB_DETAILS, region=888a715d5926adbb89c985d8967f40d4 to CLOSED ( host = server4-1 , hbaseMasterLogFile){noformat}" Remove vulnerable dependencies: slf4j-log4j12 and log4j:log4j,13576215,Resolved,Major,Fixed,17/Apr/24 13:23,13/Aug/24 14:18,,"slf4j-log4j12 is a bridge from SLF4J to Log4j 1.x. Since log4j 1.x is vulnerable , so this needs to be removed.   It is to be replaced with the log4j-slf4j-impl dependency, which is a bridge from SLF4J to Log4j 2.x." IndexOutOfBoundsException when executing HBCK2 ,13576212,Resolved,Major,Fixed,17/Apr/24 12:33,13/Aug/24 15:23,,"Reproduction   Execute the following command: {code:java} //代码占位符 ${HBASE_HOME}/bin/hbase --config /etc/hbase-conf hbck -j ~/hbase-operator-tools/hbase-hbck2/target/hbase-hbck2-1.0.0-SNAPSHOT.jar {code} we would get IndexOutOfBoundsException, as following. {code:java} //代码占位符 Caused by: java.lang.StringIndexOutOfBoundsException: String index out of range: -1    at java.lang.String.substring(String.java:1967)    at org.apache.logging.log4j.util.PropertiesUtil.partitionOnCommonPrefixes(PropertiesUtil.java:555)    at org.apache.logging.log4j.core.config.properties.PropertiesConfigurationBuilder.build(PropertiesConfigurationBuilder.java:174)    at org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:56)    at org.apache.logging.log4j.core.config.properties.PropertiesConfigurationFactory.getConfiguration(PropertiesConfigurationFactory.java:35)    at org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:557)    at org.apache.logging.log4j.core.config.ConfigurationFactory$Factory.getConfiguration(ConfigurationFactory.java:481)    at org.apache.logging.log4j.core.config.ConfigurationFactory.getConfiguration(ConfigurationFactory.java:323)    at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:695)    at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:716)    at org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:270)    at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:155)    at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:47)    at org.apache.logging.log4j.LogManager.getContext(LogManager.java:196)    at org.apache.logging.log4j.spi.AbstractLoggerAdapter.getContext(AbstractLoggerAdapter.java:137)    at org.apache.logging.slf4j.Log4jLoggerFactory.getContext(Log4jLoggerFactory.java:55)    at org.apache.logging.log4j.spi.AbstractLoggerAdapter.getLogger(AbstractLoggerAdapter.java:47)    at org.apache.logging.slf4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:33)    at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:358)    at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:383)    at org.apache.hbase.HBCK2.(HBCK2.java:92) {code} The Reason. The current version of HBase uses version 2.17.2 of log4j2, which supports shorthand syntax for properties configuration ( LOG4J2-3341 :   https://issues.apache.org/jira/browse/LOG4J2-3341).   However, The current version of HBCK2 uses version 2.17.1 of log4j2, which does not support the feature. So, we would get IndexOutOfBoundsException when HBCK2 uses as following log4j2 properties, and this is the default log configuration format for HBase logger.http = INFO,NullAppender In order to avoid this problem, I think we need bump log4j2 from 2.17.1 to 2.17.2 against HBCK2.  " [hbase-connectors] Support for build on mac M1,13579734,Resolved,Major,Fixed,18/May/24 06:27,12/Aug/24 16:09,,"[INFO] --- protobuf:0.6.1:compile (compile-protoc) @ hbase-spark-protocol --- [ERROR] PROTOC FAILED: " Change the deprecation cycle for RegionObserver.postInstantiateDeleteTracker,13582141,Resolved,Major,Fixed,10/Jun/24 13:32,05/Aug/24 08:47,,Visibility label feature still use this method so it can not be removed in 3.0.0. Should change the deprecation cycle javadoc. Remove deprecated methods in Cell,13578846,Resolved,Major,Fixed,10/May/24 07:09,31/Jul/24 03:06,, TestHFileCompressionZstd fails with IllegalArgumentException: Illegal bufferSize,13582269,Resolved,Major,Fixed,11/Jun/24 13:47,25/Jul/24 18:29,2.5.8,"HADOOP-18810 added io.compression.codec.zstd.buffersize in core-default.xml with default value as 0. So ZSTD buffer size will be returned as 0 based on core-default.xml, {code:java} static int getBufferSize(Configuration conf) { return conf.getInt(ZSTD_BUFFER_SIZE_KEY, conf.getInt(CommonConfigurationKeys.IO_COMPRESSION_CODEC_ZSTD_BUFFER_SIZE_KEY, // IO_COMPRESSION_CODEC_ZSTD_BUFFER_SIZE_DEFAULT is 0! We can't allow that. ZSTD_BUFFER_SIZE_DEFAULT)); } {code} HBASE-26259 added a value check, but got reverted in HBASE-26959.   This issue will also occur during region flush and abort the RegionServer.   TestHFileCompressionZstd and other zstd related test cases are are also failing, {code:java} java.lang.IllegalArgumentException: Illegal bufferSize at org.apache.hadoop.io.compress.CompressorStream.(CompressorStream.java:42) at org.apache.hadoop.io.compress.BlockCompressorStream.(BlockCompressorStream.java:56) at org.apache.hadoop.hbase.io.compress.aircompressor.ZstdCodec.createOutputStream(ZstdCodec.java:106) at org.apache.hadoop.hbase.io.compress.Compression$Algorithm.createPlainCompressionStream(Compression.java:454) at org.apache.hadoop.hbase.io.encoding.HFileBlockDefaultEncodingContext.(HFileBlockDefaultEncodingContext.java:99) at org.apache.hadoop.hbase.io.hfile.NoOpDataBlockEncoder.newDataBlockEncodingContext(NoOpDataBlockEncoder.java:85) at org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.(HFileBlock.java:846) at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.finishInit(HFileWriterImpl.java:304) at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.(HFileWriterImpl.java:185) at org.apache.hadoop.hbase.io.hfile.HFile$WriterFactory.create(HFile.java:312) at org.apache.hadoop.hbase.io.compress.HFileTestBase.doTest(HFileTestBase.java:73) at org.apache.hadoop.hbase.io.compress.aircompressor.TestHFileCompressionZstd.test(TestHFileCompressionZstd.java:54) {code}" Improvements in HFile prefetch,13576152,Open,Major,,17/Apr/24 06:47,,,Currently hfile prefetch on open is configurable cluster wise. Would be better to make it table wise configurable. Also would be better to have region filters which can allow to specify which regions data can be prefetched. This will be useful when there are hot regions whose data prefetching can help for low latency requirements. MapReduceBackupCopyJob should support custom DistCp options,13583457,Resolved,Major,Fixed,21/Jun/24 14:57,22/Jul/24 15:31,2.6.0,"h4. Problem The MapReduceBackupCopyJob class provides no means for updating DistCp job options. This means that you're stuck with defaults, which isn't always desirable. For example, my workplace would like the freedom to deviate from at least two DistCp defaults: # distcp.direct.write — we would like to set this to true, because writing and renaming tmp files is expensive in S3 (where we store our backups). # we would also like control over the number of mappers that DistCp will run h4. Proposed Solution It is not the prettiest solution, but I'm proposing that we support DistCp customizations via the given backup client configuration like [this.|https://github.com/HubSpot/hbase/compare/hubspot-2.6...HubSpot:hbase:backup-distcp-options] It's necessary to do this conf -> arg conversion because we still want to use [DistCp's run method|https://github.com/HubSpot/hadoop/blob/c4c25b0ea2be1c8bca31d86962597060b2630f62/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java#L134-L171], which expects args, so as to not change any error codes. Hadoop actually does something similar, but in the opposite direction — the DistCp job has logic to convert the args back to configurations (lol). Further, the DistCp API is really unfortunately designed for programmatic use, so it doesn't leave us great alternatives. For example, it doesn't matter what you pass in as DistCpOptions to the constructor if you use the run method, your options will be overwritten based on the args that you pass in. Alternatively, if you pass in the DistCpOptions in the constructor and use DistCp#execute or DistCp#createAndSubmitJob, then you get none of the error specificity!" Bump minimum supported java version to 17 for HBase 3.x,13583068,Resolved,Major,Fixed,18/Jun/24 15:44,17/Jul/24 03:21,, ExportSnapshot should verify checksums for the source file and the target file,13580770,Resolved,Major,Fixed,29/May/24 01:38,06/Jun/24 03:13,,"In our cluster, we encountered cases where the target hfile was corrupted after executing ExportSnapshot. [HBASE-13588 |https://issues.apache.org/jira/browse/HBASE-13588] can only checksum data transferred, but cannot solve our problem. Therefore, we believe it is necessary to verify checksums on the files exported by ExportSnapshot." Remove CellWrapper and use ExtendedCell internally in client side data structure,13583413,Resolved,Major,Fixed,21/Jun/24 06:55,11/Jul/24 14:16,,"In general, all Cells in HBase are ExtendedCells, we introduce Cell interface is only for preventing user to call some methods which damage the system. So I think we should have internal methods which can get ExtendedCell from the client side data structures so we do not need to cast everywhere." Change releaseTarget to 17 and also remove unused profile for older jdk versions in pom,13583069,Resolved,Major,Fixed,18/Jun/24 15:45,03/Jul/24 03:15,, hbase-rest client shading conflict with hbase-shaded-client in HBase 2.x,13576041,Resolved,Major,Fixed,16/Apr/24 14:12,05/Jun/24 05:08,2.4.17,"When trying to decode a protobuf encoded CellSet, I get {noformat} Exception in thread ""main"" java.lang.NoSuchMethodError: org.apache.hadoop.hbase.protobuf.ProtobufUtil.mergeFrom(Lcom/google/protobuf/Message$Builder;[B)V at org.apache.hadoop.hbase.rest.model.CellSetModel.getObjectFromMessage(CellSetModel.java:129) at RestClientExample.getMulti(RestClientExample.java:191) at RestClientExample.start(RestClientExample.java:138) at RestClientExample.main(RestClientExample.java:124) {noformat} Seems to be caused by relocating protobuf 2.5 in hbase-shaded-client. It works fine with the unrelcoated client i.e. when using the {noformat} export CLASSPATH=`hbase --internal-classpath classpath`: {noformat} command to set up the classpath for the client. " Ensure large batches are not indefinitely blocked by quotas,13583054,Resolved,Major,Fixed,18/Jun/24 13:49,10/Jul/24 14:35,2.6.0,"At my day job we are trying to implement default quotas for a variety of access patterns. We began by introducing a default read IO limit per-user, per-machine — this has been very successful in reducing hotspots, even on clusters with thousands of distinct users. While implementing a default writes/second throttle, I realized that doing so would put us in a precarious situation where large-enough batches may never succeed. If your batch size is greater than your TimeLimiter's max throughput, then you will always fail in the quota estimation stage. Meanwhile [IO estimates are more optimistic|https://github.com/apache/hbase/blob/bdb3f216e864e20eb2b09352707a751a5cf7460f/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/DefaultOperationQuota.java#L192-L193], deliberately, which can let large requests do targeted oversubscription of an IO quota:   {code:java} // assume 1 block required for reads. this is probably a low estimate, which is okay readConsumed = numReads > 0 ? blockSizeBytes : 0;{code}   This is okay because the Limiter's availability will go negative and force a longer backoff on subsequent requests. I believe this is preferable UX compared to a doomed throttling loop. In my opinion, we should do something similar in batch request estimation, by estimating a batch request's workload at {{Math.min(batchSize, limiterMaxThroughput)}} rather than simply {{{}batchSize{}}}." Add documentation about specifying connection uri in replication and map reduce jobs,13582752,Resolved,Major,Fixed,15/Jun/24 05:44,10/Jul/24 02:35,, fix CVE-2024-29025 in netty package ,13574718,Resolved,Major,Duplicate,05/Apr/24 01:56,21/Apr/24 14:03,,"Following CVEs are observed in io.netty : netty-handler and io.netty : netty-codec-http : 4.1.100.Final [CVE-2024-29025|http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-29025] sonatype-2020-0026    " Support non-root context in REST RemoteHTable and RemodeAdmin ,13583418,Resolved,Major,Fixed,21/Jun/24 07:59,08/Jul/24 13:55,,"RemoteHTable and RemodeAdmin expect that the REST server is in the root context. This is not true when the REST server is accessed via a reverse proxy like Apache Knox. Make it possible to set the context for those classes." Add hadoop 3.4.0 in hadoop check,13584224,Resolved,Major,Fixed,29/Jun/24 01:50,08/Jul/24 07:29,, Change hbase site build to use jdk 17,13584247,Resolved,Major,Fixed,29/Jun/24 14:13,04/Jul/24 07:30,,"After HBASE-28676 we need to use jdk 17 for building master branch, so we also need to upgrade website build to use jdk 17." Make client integration and packaging test work with java 17,13584043,Resolved,Major,Fixed,27/Jun/24 11:46,29/Jun/24 13:46,,Now branch-3.x requires building with jdk 17+ but we still use older jdk in this check so the nightly jobs for master and branch-3 fail. Bump jdk and maven versions in pre commit and nighly dockerfile,13584225,Resolved,Major,Fixed,29/Jun/24 01:51,29/Jun/24 13:45,,Bump to the newest version. Make nightly builds for 3.x java 17 only and add java 17 test for 2.x,13583169,Resolved,Major,Fixed,19/Jun/24 08:48,29/Jun/24 02:28,, Make pre commit build for 3.x to only run jdk 17 test,13583070,Resolved,Major,Fixed,18/Jun/24 15:46,26/Jun/24 15:17,, BackupSystemTable#checkSystemTable should ensure that the backup system tables are enabled,13583466,Resolved,Major,Fixed,21/Jun/24 16:39,27/Jun/24 19:36,2.6.0,"If the backup system tables become disabled, then we enter a state which the backup client will not recover from. Without manual intervention, every subsequent backup attempt will fail on [BackupSystemTable's calls to waitForSystemTable|https://github.com/apache/hbase/blob/3a3dd66e21da3f85c72d75605857713716d579fb/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java#L214-L215]. This checkSystemTable method already ensures that the tables exist — it should also ensure that the tables are enabled before we await that condition. Alternatively, we could fast-fail if the tables are disabled rather than awaiting an enabled state that will never occur." Use ExtendedCell instead of Cell in KeyValueScanner,13582074,Resolved,Major,Fixed,09/Jun/24 15:38,21/Jun/24 06:52,,"Need to do this before removing some deprecated methods in Cell, as we still need to use these method at server side." Cleanup deprecated methods around Operation related data sttructures,13584265,Resolved,Major,Not A Problem,30/Jun/24 08:45,30/Jun/24 09:05,,"There are still some deprecated methods there, like compareTo, setTimeStamp etc." Add more files in spotless for trim tailing whitespaces,13583504,Open,Major,,22/Jun/24 06:07,,, Quotas should support hard limits,13584200,Open,Major,,28/Jun/24 16:03,,2.6.0,"Quotas only support soft limits. Previously, some limits have accidentally been overly strict in a way that caused difficult UX, and we made them more lenient in https://issues.apache.org/jira/browse/HBASE-28672 It would be nice if quotas allowed users to specify hard throughput limits that they would certainly not exceed. This would be simple for read/write/request number quotas, but would be more difficult for read size throttling where workload estimations are much less precise. It's possible that this can/should only be supported for some combination of read number, write number, request number, and write size throttles." Change flaky tests to run with jdk17,13584001,Resolved,Major,Fixed,27/Jun/24 03:59,27/Jun/24 11:45,,"Now we use jdk8 to run flaky tests jenkins jobs. Let's change to use jdk17 for all active branches." Add jdk 17 task for pre commit build for 2.x,13583072,Resolved,Major,Fixed,18/Jun/24 15:47,26/Jun/24 15:17,, Correct the usage for blanks ignore options in yetus,13583501,Resolved,Major,Fixed,22/Jun/24 03:51,23/Jun/24 15:05,, The failsafe snapshot should be deleted after rollback successfully,13582415,Resolved,Major,Fixed,12/Jun/24 12:26,22/Jun/24 15:12,2.4.13,"When a table exists and is in a disabled state, hbase supports to restore by the snapshot of this table. In this scenario, hbase would create a failsafe snapshot for this disabled table, and hbase would rollback by this failsafe snapshot when fail to restore. However on hbase cluster, the failsafe snapshot still exists after rollback successfully by failsafe snapshot. I think when restore failed by table snapshot but rollback successfully by failsafe snapshot, this failsafe snapshot should be deleted." BackupLogCleaner causes HMaster WALs to pile up indefinitely,13583220,Resolved,Major,Fixed,19/Jun/24 15:41,21/Jun/24 15:14,2.6.0,"We have been trying to setup daily incremental backups for hundreds of clusters at my day job. Recently we discovered that old WALs were piling up across many clusters inline with when we began running incremental backups. This led to the realization that [the BackupLogCleaner will always skip archived HMaster WALs|https://github.com/HubSpot/hbase/blob/3a170578b04d5947c655319f1b8d8475ccb6bb4e/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java#L364-L367]. This is a problem because, if a cleaner is skipping a given file, then [the CleanerChore will never delete it|https://github.com/apache/hbase/blob/fb988373c1cd0184400fe17c4323fbf0de07c951/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java#L312-L332]. This seems like a misunderstanding of what it means to ""skip"" a WAL in a BaseLogCleanerDelegate, and, instead, we should always return these HMaster WALs as deletable from the perspective of the BackupLogCleaner. We could subject them to the same scrutiny as RegionServer WALs: are they older than the most recent successful  backup? But, if I understand correctly, HMaster WALs do not contain any data relevant to table backups, so that would be unnecessary." Upgrade yetus to a newer version,13583210,Resolved,Major,Fixed,19/Jun/24 14:48,22/Jun/24 03:50,,"Now we use the one in yetus for validating, where it uses jrunscript to execute a simple javascript script. But the javascript engine has been removed from JDK starting from JDK 15, so in JDK 17 we can not use this way any more. https://openjdk.java.net/jeps/372 We should find another way to validate xml files. ========= In newer version, yetus has already changed to use xmllint, so let's see how to upgreade yetus." Add trademark statement in footer on our website,13580458,Resolved,Major,Fixed,25/May/24 13:59,21/Jun/24 04:16,, Make -h arg respected by hbck2 and exit if unrecognized arguments are passed,13581202,Resolved,Major,Fixed,31/May/24 18:59,21/Jun/24 10:55,,"The -h argument in hbck is not respected and instead of displaying the argument usage guide, the command continued to execute. Any unrecognized arguments should cause an exception and exit.   example:  {code:java} $ hbck2 addFsRegionsMissingInMeta -h OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=permit; support was removed in 17.0 19:09:08.831 [main] INFO  org.apache.hadoop.conf.Configuration.deprecation - hbase.client.pause.cqtbe is deprecated. Instead, use hbase.client.pause.server.overloaded ERROR: Unrecognized option: -h FOR USAGE, use the -h or --help option {code}    " Add documentation about the URI based connection registry,13577000,Resolved,Major,Fixed,24/Apr/24 03:12,20/Jun/24 14:10,, ITBLL and other MR-based integration tests should heartbeat often,13583282,Open,Major,,20/Jun/24 08:52,,,"We have this little note in our ITBLL harness, {noformat} // If we cause enough chaos, RPC requests might get into long backoffs. During this // time, it won't send keep alives to the map/reduce context. So increase the timeout // a bunch {noformat} Investigating, the ITBLL Generator's persist method updates the MR context progress only every 100 puts. You'd think that would be enough, but given chaos, it really isn't. What if we update progress with every put? Digging through MR source code, it seems that calling the context.progress() method only sets an AtomicBoolean that a progress update needs sent, actual sending of progress reports is gated by {{mapreduce.task.progress-report.interval}}, or 1% of {{mapreduce.task.timeout}}, which defaults to 1% of 300_000ms, or 3 seconds. So yeah, we should probably update this AtomicBool much more often in chaotic jobs, as doing so is effectively free and will improve reliability. But still, every put is perhaps excessive. What if we add a pre-flush hook to (Async)BufferedMutator so that a MR job can set this progress flag right before the client disappears down into a retry loop? I bet other applications would find such a hook useful as well." Remove unused pages on our website and update doap.rdf,13583251,Resolved,Major,Fixed,20/Jun/24 02:47,20/Jun/24 02:56,, Add close method to REST client,13582989,Resolved,Major,Fixed,18/Jun/24 06:14,19/Jun/24 09:00,,"This allows the user to clean up any open pooled Http Connections. Also add an experimental new constructor to let the user use a custom HttpClientConnectionManager for the Apache HttpClient library." Bump urllib3 from 1.26.18 to 1.26.19 in /dev-support/git-jira-release-audit,13583057,Resolved,Major,Fixed,18/Jun/24 14:25,18/Jun/24 14:35,, Hbase compaction is slow in 2.4.11 compared to hbase 1.x,13581714,Open,Major,,05/Jun/24 20:27,,2.4.11,"Hi Team, we build an Hbase 2.4.11 cluster comprising HDFS and HBase components. However, during our performance testing, we observed that the HBase compaction process was taking longer than expected. With identical configurations, in  HBase-1 cluster is completing compaction tasks in less time compared to the new Hbase 2  cluster. Hbase1 cluster details: HBASE: 1.1.2 Hbase2 cluster details HBASE: 2.4.11 Please find the scre enshot for the Compaction iteration and timeline: !image-2024-06-05-16-15-45-975.png! IN Hbase 1  COMPACTION TIME  In the HBASE1 cluster with the same set of configurations and tables, we observed consistent behavior in terms of compaction time(3hrs). Start Time: 1:30AM  End Time: 4:30AM !image-2024-06-05-16-17-34-685.png! IN Hbase 2  COMPACTION TIME Start Time: 1:30AM End Time: 23:00PM+ !image-2024-06-05-16-18-33-322.png!   Actions Taken: Tuning of HBase configurations related to compactions was performed initially but didn't yield significant improvement. Observations: We suspected that this absence of data encoding might be contributing to longer compaction times in HBase-2. Scheduled two separate compactions for tables with and without DATA_ENCODING enabled in Hbase 2. In the screenshot below, the first compaction started at 1:30 AM for 15 tables (total size exceeding 220TB+) with (DATA ENCODED=FAST_DIFF) enabled and this compaction completed by 2:30 AM. However, at 2:30 AM, we scheduled another compaction for only 6 tables, totalling over 60TB in size, but these tables were not enabled with DATA ENCODING , and this compaction is taking longer. !image-2024-06-05-16-22-33-464.png! After enabling DATA ENCODING for all the  tables in HBASE-2, we initiated compaction at 1:30 AM, which completed by 4:30 AM(3hrs) Start Time: 1:30AM End Time: 4:30 AM !image-2024-06-05-16-23-29-565.png!   Noticed that tables with (DATA_ENCODING=FAST_DIFF) enabled underwent faster compactions compared to those without. Upon comparing the debug logs of the two Hbase 2 clusters, we discovered that the cluster with (DATA_ENCODING=FAST_DIFF) enabled exhibited higher throughput(average throughput is 89.54 MB/Second), whereas the cluster with DATA_ENCODING disabled showed lower throughput(average throughput is 8.19 MB/second,).   #DATA_ENCODED ENBALED Tables throughput 2024-04-02 03:11:58,956 INFO [regionserver/xxxxxxxx:16020-shortCompactions-0] throttle.PressureAwareThroughputController: 803e9ef64aec8e526837c0477cc48884#scr#compaction#34672 average throughput is 89.54 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-02 03:12:23,680 INFO [regionserver/usr-Hbase 1201:16020-shortCompactions-7] throttle.PressureAwareThroughputController: 82565df649e3e6eb53a1e168435204db#scr#compaction#34677 average throughput is 65.02 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-02 02:45:46,538 DEBUG [regionserver/xxxxxx:16020-longCompactions-7] compactions.Compactor: Compaction progress: b746a46d64df25ca82571b10bb1e2c03#key#compaction#34484 128896600/371074603 (34.74%), rate=17151.92 KB/sec, throughputController is DefaultCompactionThroughputController [maxThroughput=unlimited, activeCompactions=22] 2024-04-02 02:45:47,291 DEBUG [regionserver/usr-Hbase 1201:16020-shortCompactions-0] compactions.Compactor: Compaction progress: a1338704db18a8fc613ad2c9a4561d65#key#compaction#34496 90148941/110577879 (81.53%), rate=20950.64 KB/sec, throughputController is DefaultCompactionThroughputController [maxThroughput=unlimited, activeCompactions=22]   #DATA_ENCODED DISABLED tables throughput 2024-04-04 03:12:48,521 INFO [regionserver/xxxxxxx:16020-longCompactions-3] throttle.PressureAwareThroughputController: 273b9d62b602ecd3e6df3d244f796c0b#key#compaction#185279 average throughput is 8.91 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-04 03:14:02,793 INFO [regionserver/usr-Hbase 1201:16020-longCompactions-2] throttle.PressureAwareThroughputController: 11fff837daa7da3fa307ecbb457fe64d#key#compaction#185282 average throughput is 8.19 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-03 02:46:21,165 DEBUG [regionserver/xxxxxxx:16020-shortCompactions-0] compactions.Compactor: Compaction progress: 98748d4c25e15c623e43a3e42f03f5de#key#com paction#178586 2986892/73628890 (4.06%), rate=9936.51 KB/sec, throughputController is DefaultCompactionThroughputController [maxThroughput=unlimited, activeCompactions=22] 2024-04-03 02:46:21,193 DEBUG [regionserver/:16020-longCompactions-0] compactions.Compactor: Compaction progress: ce578c37f0a8354afd6d37fa5ca9c7d7#key#comp Need Help With:  In Hbase 1 the compaction is consistently completing in 3 hours without data encoading.  In hbase 2 Compaction without data encoading and compression it is taking 12 + hours. but with data encoading and compression we are able to finish it in approx 4-4.5 hours." Use Streams to unmarshall protobuf REST data,13582098,Resolved,Major,Fixed,10/Jun/24 06:13,18/Jun/24 06:33,,"We've recently optimized REST marshalling by using streams directly. We should do the same for unmarshalling. The easy part is the server side, as that affects only a small set files. However, we should also support streams on the client side, which requires duplicating each method the returns / expects a byte array to also work with streams." Marker interface for Cells which may have backing ByteBuffers,13582822,Open,Major,,17/Jun/24 06:10,,,"We often need to treat cells that may have backing ByteBuffers differently. The easy thing to would be checking if they are ByteBufferExtendedCell , but CellWrapper , OnHepDecodedCell and TagRewriteCell may also delegate to a ByteBufferExtendedCell. Having a marker interface that indicates that a cell is guaranteed to be on-heap, or that it may not be fully on-heap would make it easier and faster to check whether we need to clone them. (We only need one, it may be either negative or positive)" Backport HBASE-28246 Expose region cached size over JMX metrics and report in the RS UI,13582363,Resolved,Major,Fixed,12/Jun/24 07:54,17/Jun/24 09:45,2.6.0, Fix compatibility issue in SecurityHeadersFilter in branch-2.x,13582504,Resolved,Major,Fixed,13/Jun/24 09:02,14/Jun/24 18:06,, Make map reduce jobs accept connection uri when specifying peer cluster,13578152,Resolved,Major,Fixed,04/May/24 14:18,12/Jun/24 11:14,, Upgrade Kerby to 2.0.3,13582260,Open,Major,,11/Jun/24 12:08,,,Upgrade Kerby to 2.0.3 due to [CVE-2023-25613.|https://nvd.nist.gov/vuln/detail/CVE-2023-25613] Support specifying connection configuration through queries of the connection uri,13576998,Resolved,Major,Fixed,24/Apr/24 03:11,20/May/24 03:43,, Backport HBASE-21785 master reports open regions as RITs and also messes up rit age metric,13582238,Resolved,Major,Fixed,11/Jun/24 09:05,11/Jun/24 21:04,, NPE in hmaster (setServerState function),13582454,Open,Major,,12/Jun/24 22:17,,3.0.0-beta-2,"I met NPE in master node after migrating data from 2.5.8. {code:java} [ERROR LOG] executionId = LrmpjV32 ConfigIdx = test9 Node02024-05-11T10:45:57,896 ERROR [PEWorker-15] procedure2.ProcedureExecutor: CODE-BUG: Uncaught runtime exception: pid=48, state=RUNNABLE:SERVER_CRASH_SPLIT_LOGS, hasLock=true; ServerCrashProcedure hregion1,16020,1715424228375, splitWal=true, meta=true java.lang.NullPointerException: null         at org.apache.hadoop.hbase.master.assignment.RegionStates.setServerState(RegionStates.java:409) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.assignment.RegionStates.logSplitting(RegionStates.java:435) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.executeFromState(ServerCrashProcedure.java:226) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT] 2024-05-11T10:45:57,918 ERROR [PEWorker-15] procedure2.ProcedureExecutor: Root Procedure pid=48, state=FAILED:SERVER_CRASH_SPLIT_LOGS, hasLock=true, exception=java.lang.NullPointerException via CODE-BUG: Uncaught runtime exception: pid=48, state=RUNNABLE:SERVER_CRASH_SPLIT_LOGS, hasLock=true; ServerCrashProcedure hregion1,16020,1715424228375, splitWal=true, meta=true:java.lang.NullPointerException; ServerCrashProcedure hregion1,16020,1715424228375, splitWal=true, meta=true does not support rollback but the execution failed and try to rollback, code bug? org.apache.hadoop.hbase.procedure2.RemoteProcedureException: java.lang.NullPointerException         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1826) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1484) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1100(ProcedureExecutor.java:80) ~[hbase-procedure-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT] {code} h1. Reproduce This bug cannot be reproduced deterministically. I upgraded hbase cluster form 2.5.8 to 3.0.0 (commit: 516c89e8597fb) with 4 nodes (1HM, 2RS, 1HDFS) h1. Root Case From the stack trace, the bug is in setServerState state function. {code:java} hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java private void setServerState(ServerName serverName, ServerState state) {     ServerStateNode serverNode = getServerNode(serverName);     synchronized (serverNode) { // NPE!       serverNode.setState(state);     }   } {code} The serverNode sometimes could be null and there's no null pointer check. {code:java}   /** Returns Pertinent ServerStateNode or NULL if none found (Do not make modifications). */   public ServerStateNode getServerNode(final ServerName serverName) {     return serverMap.get(serverName);   } {code} The potential fix could be adding a NULL serverNode. However, how it runs into this buggy state is unclear.  I am running the workloads that could trigger the bug multiple times to see if I can find more information. I have attached the error log." Reformat the javadoc for CellChunkMap,13582234,Resolved,Major,Fixed,11/Jun/24 08:22,11/Jun/24 14:25,,"It was messed up while introducing spotless, let's restore it." Wrong properties are used to set up SSL for REST Client Kerberos authenticator,13582162,Resolved,Major,Fixed,10/Jun/24 16:07,11/Jun/24 04:23,,"When setting the ssl keystore properties, when we should be setting the truststore ones. This results in SPENGO negotiation failing with custom truststores." Support non-SPNEGO authentication methods and implement session handling in REST java client library,13574961,Resolved,Major,Fixed,08/Apr/24 08:39,21/May/24 07:50,,"The current java client only supports the SPENGO authentication method. This does not support the case when an application proxy like Apache Knox performs AAA conversion from BASIC/DIGEST to kerberos authentication. Add support for BASIC username/password auth the client. Generally, the authentication code in the client looks quite backwards, it seems that most of the kerberos / auth cookie code duplicates HttpClient functionality. AFAICT setting HttpClient up (or letting user set it up) , and letting it handle authentication by itself would be a better and more generic solution. -Also add support for specifying a prefix for the URL path.-" Use streaming when marshalling protobuf REST output,13580220,Resolved,Major,Fixed,23/May/24 07:51,28/May/24 10:41,,"We are currently marshalling protobuf into a byte array, and then send that to the client. This is both slow and memory intensive. I see a ~25% reduction in the REST server CPU usage for my benchmark with this patch. " Make shell commands support column qualifiers with colons,13577005,Resolved,Major,Fixed,24/Apr/24 03:38,08/Jun/24 03:49,,"Revisiting abandonded HBASE-13788. h2. Problem Shell commands do not support column qualifiers with colons (which are actually quite common in practice) because the part after the first colon is always treated as a converter expression. This can be too restrictive because: # Converters are only used for {{get}} and {{scan}} commands. They are not supported anyway for other mutating commands such as {{put}}, {{delete}}, {{incr}}, etc. # Converter expression should follow a specific pattern. It should either be a method name of the {{Bytes}} class, or should be in {{c(CLASS).METHOD}} format. We ignore the part after the first colon even if it does not follow the pattern. h2. Suggested solution I suggest applying two approaches to make the commands support column qualifiers with colons. # Do not interpret column qualifiers when using commands that don't support converters. # If the part after the first colon does not follow the pattern, treat it as a part of the column qualifier h2. Counterargument Depending on how you see it, this makes the commands inconsistent in how they handle column qualifiers. For example, a user may want to use the same column expression throughout the commands. {code} create 't1', 'cf' col = 'cf:cq:toLong' # Expecting incr command to automatically ignore :toLong part incr 't1', 'r1', col, 1 get 't1', 'r1', COLUMNS => [col] {code} However, if we see the converter as an option that is supported by only a few commands, passing it to a command that doesn't support it can be considered to be a user error. {{help 'put'}} or {{help 'delete'}} don't mention anything about converters. h2. Alternative solution An alternative solution would be to add a global switch that disables the converter interpretation altogether. " Merge of incremental backups fails if backups are on a separate FileSystem,13576685,Resolved,Major,Fixed,22/Apr/24 07:30,07/Jun/24 08:05,2.6.0,"When the backups are stored on a location that is not the DistributedFilesystem underpinning HBase itself merging of incremental backups fails. Detected with backups stored on S3A, but can be reproduced with any other (like LocalFilesystem). Attached is a patch with a proposed fix and a unit test that reproduces the issue." Add UTs for testing copy/sync table between clusters,13581529,Resolved,Major,Fixed,04/Jun/24 13:19,07/Jun/24 10:27,,"While implementing HBASE-28565, I found out that there is no test for testing these two tools between clusters." The hadolint check in nightly build is broken,13580479,Resolved,Major,Fixed,26/May/24 09:23,06/Jun/24 12:43,,"https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1080/General_20Nightly_20Build_20Report/ " Correct backup ancestor calculation,13577957,Resolved,Major,Fixed,02/May/24 14:43,06/Jun/24 13:34,2.6.0,"This is the same issue as HBASE-25870, but I think the fix there was wrong. This issue can prevent creation of (incremental) backups when data of unrelated backups was damaged on backup storage. Minimal example to reproduce from source: * Add following to `conf/hbase-site.xml` to enable backups: {code:java} hbase.backup.enable true hbase.master.logcleaner.plugins org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreWALCleaner,org.apache.hadoop.hbase.backup.master.BackupLogCleaner hbase.procedure.master.classes org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager hbase.procedure.regionserver.classes org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager hbase.coprocessor.region.classes org.apache.hadoop.hbase.backup.BackupObserver hbase.fs.tmp.dir file:/tmp/hbase-tmp {code} * Start HBase and open a shell: {{{}bin/start-hbase.sh{}}}, {{bin/hbase shell}} * Execute following commands (""put"" & ""create"" commands in hbase shell, other commands in commandline): * {code:java} create 'experiment', 'fam' put 'experiment', 'row1', 'fam:b', 'value1' bin/hbase backup create full file:/tmp/hbasebackup Backup session backup_1714649896776 finished. Status: SUCCESS put 'experiment', 'row2', 'fam:b', 'value2' bin/hbase backup create incremental file:/tmp/hbasebackup Backup session backup_1714649920488 finished. Status: SUCCESS put 'experiment', 'row3', 'fam:b', 'value3' bin/hbase backup create incremental file:/tmp/hbasebackup Backup session backup_1714650054960 finished. Status: SUCCESS (Delete the files corresponding to the first incremental backup - backup_1714649920488 in this example) put 'experiment', 'row4', 'fam:a', 'value4' bin/hbase backup create full file:/tmp/hbasebackup Backup session backup_1714650236911 finished. Status: SUCCESS put 'experiment', 'row5', 'fam:a', 'value5' bin/hbase backup create incremental file:/tmp/hbasebackup Backup session backup_1714650289957 finished. Status: SUCCESS put 'experiment', 'row6', 'fam:a', 'value6' bin/hbase backup create incremental file:/tmp/hbasebackup2024-05-02T13:45:27,534 ERROR [main {}] impl.BackupManifest: file:/tmp/hbasebackup/backup_1714649920488 does not exist 2024-05-02T13:45:27,534 ERROR [main {}] impl.TableBackupClient: Unexpected Exception : file:/tmp/hbasebackup/backup_1714649920488 does not exist org.apache.hadoop.hbase.backup.impl.BackupException: file:/tmp/hbasebackup/backup_1714649920488 does not exist     at org.apache.hadoop.hbase.backup.impl.BackupManifest.(BackupManifest.java:451) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupManifest.(BackupManifest.java:402) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupManager.getAncestors(BackupManager.java:331) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupManager.getAncestors(BackupManager.java:353) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.TableBackupClient.addManifest(TableBackupClient.java:286) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.TableBackupClient.completeBackup(TableBackupClient.java:351) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:314) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.backupTables(BackupAdminImpl.java:603) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupCommands$CreateCommand.execute(BackupCommands.java:345) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) ~[hadoop-common-3.3.5.jar:?]     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT] 2024-05-02T13:45:27,538 ERROR [main {}] impl.TableBackupClient: BackupId=backup_1714650324099,startts=1714650324486,failedts=1714650327538,failedphase=STORE_MANIFEST,failedmessage=file:/tmp/hbasebackup/backup_1714649920488 does not exist 2024-05-02T13:45:28,763 ERROR [main {}] impl.TableBackupClient: Backup backup_1714650324099 failed. Backup session finished. Status: FAILURE 2024-05-02T13:45:28,764 ERROR [main {}] backup.BackupDriver: Error running command-line tool java.io.IOException: org.apache.hadoop.hbase.backup.impl.BackupException: file:/tmp/hbasebackup/backup_1714649920488 does not exist     at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:319) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.backupTables(BackupAdminImpl.java:603) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupCommands$CreateCommand.execute(BackupCommands.java:345) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.BackupDriver.parseAndRun(BackupDriver.java:134) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.BackupDriver.doWork(BackupDriver.java:169) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.BackupDriver.run(BackupDriver.java:199) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:82) ~[hadoop-common-3.3.5.jar:?]     at org.apache.hadoop.hbase.backup.BackupDriver.main(BackupDriver.java:177) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT] Caused by: org.apache.hadoop.hbase.backup.impl.BackupException: file:/tmp/hbasebackup/backup_1714649920488 does not exist     at org.apache.hadoop.hbase.backup.impl.BackupManifest.(BackupManifest.java:451) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupManifest.(BackupManifest.java:402) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupManager.getAncestors(BackupManager.java:331) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.BackupManager.getAncestors(BackupManager.java:353) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.TableBackupClient.addManifest(TableBackupClient.java:286) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.TableBackupClient.completeBackup(TableBackupClient.java:351) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:314) ~[hbase-backup-2.6.1-SNAPSHOT.jar:2.6.1-SNAPSHOT]     ... 7 more{code} Currently working on a PR." Hbase compaction is slow in 2.4.11 compared to hbase 1.x,13581712,Resolved,Major,Duplicate,05/Jun/24 20:12,06/Jun/24 05:46,2.4.11,"Hi Team, we build an Hbase 2.4.11 cluster comprising HDFS and HBase components. However, during our performance testing, we observed that the HBase compaction process was taking longer than expected. With identical configurations, in  HBase-1 cluster is completing compaction tasks in less time compared to the new Hbase 2  cluster. Hbase1 cluster details: HBASE: 1.1.2 Hbase2 cluster details HBASE: 2.4.11 Please find the screenshot for the Compaction iteration and timeline: !image-2024-06-05-16-11-50-691.png! IN Hbase 1  COMPACTION TIME  In the HBASE1 cluster with the same set of configurations and tables, we observed consistent behavior in terms of compaction time(3hrs). Start Time: 1:30AM  End Time: 4:30AM !image-2024-06-04-16-17-38-873.png!   IN Hbase 2  COMPACTION TIME Start Time: 1:30AM End Time: 23:00PM+ !image-2024-06-04-16-18-06-474.png!   Actions Taken: Tuning of HBase configurations related to compactions was performed initially but didn't yield significant improvement. OS Mitigations were switched off and filesystem was migrated from ext4 to xfs, yet compactions didn't improve as expected. Observations: We suspected that this absence of data encoding might be contributing to longer compaction times in HBase-2. Scheduled two separate compactions for tables with and without DATA_ENCODING enabled in Hbase 2. In the screenshot below, the first compaction started at 1:30 AM for 15 tables (total size exceeding 220TB+) with (DATA ENCODED=FAST_DIFF) enabled and this compaction completed by 2:30 AM. However, at 2:30 AM, we scheduled another compaction for only 6 tables, totalling over 60TB in size, but these tables were not enabled with DATA ENCODING , and this compaction is taking longer. !image-2024-06-04-16-18-26-818.png!   After enabling DATA ENCODING for all the  tables in HBASE-2, we initiated compaction at 1:30 AM, which completed by 4:30 AM(3hrs) Start Time: 1:30AM End Time: 4:30 AM !image-2024-06-04-16-18-55-672.png! Noticed that tables with (DATA_ENCODING=FAST_DIFF) enabled underwent faster compactions compared to those without. Upon comparing the debug logs of the two Hbase 2 clusters, we discovered that the cluster with (DATA_ENCODING=FAST_DIFF) enabled exhibited higher throughput(average throughput is 89.54 MB/Second), whereas the cluster with DATA_ENCODING disabled showed lower throughput(average throughput is 8.19 MB/second,).   #DATA_ENCODED ENBALED Tables throughput 2024-04-02 03:11:58,956 INFO [regionserver/xxxxxxxx:16020-shortCompactions-0] throttle.PressureAwareThroughputController: 803e9ef64aec8e526837c0477cc48884#scr#compaction#34672 average throughput is 89.54 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-02 03:12:23,680 INFO [regionserver/usr-Hbase 1201:16020-shortCompactions-7] throttle.PressureAwareThroughputController: 82565df649e3e6eb53a1e168435204db#scr#compaction#34677 average throughput is 65.02 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-02 02:45:46,538 DEBUG [regionserver/xxxxxx:16020-longCompactions-7] compactions.Compactor: Compaction progress: b746a46d64df25ca82571b10bb1e2c03#key#compaction#34484 128896600/371074603 (34.74%), rate=17151.92 KB/sec, throughputController is DefaultCompactionThroughputController [maxThroughput=unlimited, activeCompactions=22] 2024-04-02 02:45:47,291 DEBUG [regionserver/usr-Hbase 1201:16020-shortCompactions-0] compactions.Compactor: Compaction progress: a1338704db18a8fc613ad2c9a4561d65#key#compaction#34496 90148941/110577879 (81.53%), rate=20950.64 KB/sec, throughputController is DefaultCompactionThroughputController [maxThroughput=unlimited, activeCompactions=22]   #DATA_ENCODED DISABLED tables throughput 2024-04-04 03:12:48,521 INFO [regionserver/xxxxxxx:16020-longCompactions-3] throttle.PressureAwareThroughputController: 273b9d62b602ecd3e6df3d244f796c0b#key#compaction#185279 average throughput is 8.91 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-04 03:14:02,793 INFO [regionserver/usr-Hbase 1201:16020-longCompactions-2] throttle.PressureAwareThroughputController: 11fff837daa7da3fa307ecbb457fe64d#key#compaction#185282 average throughput is 8.19 MB/second, slept 0 time(s) and total slept time is 0 ms. 21 active operations remaining, total limit is unlimited 2024-04-03 02:46:21,165 DEBUG [regionserver/xxxxxxx:16020-shortCompactions-0] compactions.Compactor: Compaction progress: 98748d4c25e15c623e43a3e42f03f5de#key#com paction#178586 2986892/73628890 (4.06%), rate=9936.51 KB/sec, throughputController is DefaultCompactionThroughputController [maxThroughput=unlimited, activeCompactions=22] 2024-04-03 02:46:21,193 DEBUG [regionserver/:16020-longCompactions-0] compactions.Compactor: Compaction progress: ce578c37f0a8354afd6d37fa5ca9c7d7#key#comp Need Help With:  In Hbase 1 the compaction is consistently completing in 3 hours without data encoading.  In hbase 2 Compaction without data encoading and compression it is taking 12 + hours. but with data encoading and compression we are able to finish it in approx 4-4.5 hours." HBase web console automatically listing directories in static/css directory,13575528,Patch Available,Major,,11/Apr/24 17:13,,,"HBase web console automatically lists directories present in \{link-to-master-ui}/static/css.     " FilterListWithAND can swallow SEEK_NEXT_USING_HINT,13580599,Resolved,Major,Fixed,27/May/24 18:01,04/Jun/24 12:56,,"org.apache.hadoop.hbase.filter.FilterListWithAND.filterRowKey(Cell) will return true if ANY of the filters returns true for Filter#filterRowKey(). However, the SEEK_NEXT_USING_HINT mechanism relies on filterRowKey() returning false, so that filterCell() can return SEEK_NEXT_USING_HINT. If none of the filters matches, but one of them returns true for filterRowKey(), then the filter(s) that returned false, so that they can return SEEK_NEXT_USING_HINT in filterCell() never get a chance to return SEEK_NEXT_USING_HINT, and instead of seeking to the hint, FilterListWithAND will do very slow full scan. " BackupHFileCleaner.loadHFileRefs is very expensive,13576578,Open,Major,,19/Apr/24 21:31,,,"I noticed some odd CPU spikes on the hmasters of one of our clusters. Turns out it had been getting lots of bulkoads (30k) and processing them was expensive. The method scans hbase and then parses the paths. Surprisingly the parsing is more expensive than the reading hbase, with the vast majority of time spent in org/apache/hadoop/fs/Path.. We should see if this is possible to be optimized. Attaching profile." Change SyncTable to IA.Public and add it to mapreduce Driver,13581671,Open,Major,,05/Jun/24 14:46,,, Bump io.airlift:aircompressor from 0.24 to 0.27,13581395,Resolved,Major,Fixed,03/Jun/24 13:49,03/Jun/24 14:26,, Use Base64.getUrlEncoder().withoutPadding() in REST tests,13580966,Resolved,Major,Fixed,30/May/24 04:42,30/May/24 18:10,,"The encoder returned by java.util.Base64.getUrlEncoder() is unsuitable for the purpose. To get an encoder that is actually usable in URLs, java.util.Base64.getUrlEncoder().withoutPadding() must be used. The relevant Java bug is https://bugs.openjdk.org/browse/JDK-8026330 , however instead of fixing the encoder, Java has decided to keep the broken default, and add the .withoutPadding() method as a way to get a working one. Due to sheer luck (or rather bad luck), this is not triggered in our tests, but anyone using them as a template will be in for a ride when hit by this problem. " Using JDK17 resulted in regionserver reportForDuty failing,13580980,Resolved,Major,Information Provided,30/May/24 08:23,30/May/24 10:32,2.1.1,"I am currently using HBASE-2.1.1 version to adapt to JDK17 and have encountered some issues: 1) Java. lang. NoSuchFiledException: modifiers; 2) Unable to make static boolean Java.nio Bits.unaligned() accessible: module java.base does not ""opens java.nio"" to unnamed moudle； 3) Regionserver HRegionServer: error telling master we are up。 Problem 1 is solved through HBASE-25516 [JDK17] reflective access Field. class. getDeclaredField (""modifiers"") not supported - ASF JIRA (apache. org). Problem 2 is solved by adding – add open Java. base/Java. lang=ALL-UNNAMED – add open Java. base/Java. lang. reflect=ALL-UNNAMED – add open Java. base/Java. nio=ALL-UNNAMED parameter. However, there is currently no idea for problem 3. How can I handle this. now master is running  normally. regionserver: !image-2024-05-30-16-23-34-561.png! master: !image-2024-05-30-17-02-18-965.png!" MultiRowRangeFilter deserialization fails in org.apache.hadoop.hbase.rest.model.ScannerModel,13580868,Resolved,Major,Fixed,29/May/24 12:45,30/May/24 05:59,,"org.apache.hadoop.hbase.filter.MultiRowRangeFilter.BasicRowRange has several getters that have no corresponing setters. jackson serializes the pseudo-getters' values, but when it tries to deserialize, there are no corresponding setters and it errors out. {noformat} com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field ""ascendingOrder"" (class org.apache.hadoop.hbase.filter.MultiRowRangeFilter$RowRange), not marked as ignorable (4 known properties: ""startRow"", ""startRowInclusive"", ""stopRow"", ""stopRowInclusive""]) at [Source: (String)""{""type"":""FilterList"",""op"":""MUST_PASS_ALL"",""comparator"":null,""value"":null,""filters"":[{""type"":""MultiRowRangeFilter"",""op"":null,""comparator"":null,""value"":null,""filters"":null,""limit"":null,""offset"":null,""family"":null,""qualifier"":null,""ifMissing"":null,""latestVersion"":null,""minColumn"":null,""minColumnInclusive"":null,""maxColumn"":null,""maxColumnInclusive"":null,""dropDependentColumn"":null,""chance"":null,""prefixes"":null,""ranges"":[{""startRow"":""MQ=="",""startRowInclusive"":true,""stopRow"":""MQ=="",""stopRowInclusive"":t""[truncated 553 chars]; line: 1, column: 526] (through reference chain: org.apache.hadoop.hbase.rest.model.ScannerModel$FilterModel[""filters""]->java.util.ArrayList[0]->org.apache.hadoop.hbase.rest.model.ScannerModel$FilterModel[""ranges""]->java.util.ArrayList[0]->org.apache.hadoop.hbase.filter.MultiRowRangeFilter$RowRange[""ascendingOrder""]) at com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException.from(UnrecognizedPropertyException.java:61) at com.fasterxml.jackson.databind.DeserializationContext.handleUnknownProperty(DeserializationContext.java:1127) at com.fasterxml.jackson.databind.deser.std.StdDeserializer.handleUnknownProperty(StdDeserializer.java:2036) at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownProperty(BeanDeserializerBase.java:1700) at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.handleUnknownVanilla(BeanDeserializerBase.java:1678) at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:320) at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:177) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeFromArray(CollectionDeserializer.java:355) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:244) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:28) at com.fasterxml.jackson.databind.deser.impl.FieldProperty.deserializeAndSet(FieldProperty.java:138) at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:314) at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:177) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer._deserializeFromArray(CollectionDeserializer.java:355) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:244) at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:28) at com.fasterxml.jackson.databind.deser.impl.FieldProperty.deserializeAndSet(FieldProperty.java:138) at com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:314) at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:177) at com.fasterxml.jackson.databind.deser.DefaultDeserializationContext.readRootValue(DefaultDeserializationContext.java:323) at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4674) at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3629) at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3597) at org.apache.hadoop.hbase.rest.model.ScannerModel.buildFilter(ScannerModel.java:516) at org.apache.hadoop.hbase.rest.ResultGenerator.buildFilter(ResultGenerator.java:40) at org.apache.hadoop.hbase.rest.ScannerResultGenerator.buildFilterFromModel(ScannerResultGenerator.java:49) at org.apache.hadoop.hbase.rest.ScannerResource.update(ScannerResource.java:111) at org.apache.hadoop.hbase.rest.ScannerResource.put(ScannerResource.java:150) {noformat} " Remove/Deprecated the rs.* related configuration in TableOutputFormat,13580457,Resolved,Major,Fixed,25/May/24 13:46,29/May/24 08:04,, Scan with MultiRowRangeFilter very slow,13580705,Resolved,Major,Won't Fix,28/May/24 13:47,29/May/24 13:39,2.4.14,"when scan a big table({*}more than 500 regions{*}) with {*}MultiRowRangeFilter{*}, it is very slow... it seems to {*}scan all regions{*}... for example: we scan 3 ranges.. startRow: 097_28220_ stopRow: 097_28220_~ startRow: 098_28221_ stopRow: 098_28221_~ startRow: 099_28222_ stopRow: 099_28222_~ and enable TRACE log in hbase client we find there are too many scans.... {code:java}  1713987938886.93886cc52eea6200518feb7ebce7e1a4.', STARTKEY => '', ENDKEY => '000_2147757104_4641'}     行 139: 1716188377677.a2e0d724dd73196d81ecbfb58c77b611.', STARTKEY => '000_2147757104_4641', ENDKEY => '000_21     行 162: 1716188377677.b377942c957c300286afcb763f0dd338.', STARTKEY => '000_2148042968_3081', ENDKEY => '000_21     行 185: 1714319482833.4e5bfdfb6f2bcf381681726429bf2adb.', STARTKEY => '000_2148518165_26648', ENDKEY => '000_3     行 197: 1715031138715.36bac123de7eec3c4c08a775d592f387.', STARTKEY => '000_389786_4001', ENDKEY => '000_434112     行 211: 1715031138715.2dc9f1a78f532454ce8381ff9738e93e.', STARTKEY => '000_434112_88683', ENDKEY => '000~'}     行 225: 1713890960521.94e341a71b5b3e98569809d7a0f4354e.', STARTKEY => '000~', ENDKEY => '001_2147735632_4395'}     行 250: 1716239834572.3061c9f457b91ed40c938d801f8cac5f.', STARTKEY => '001_2147735632_4395', ENDKEY => '001_21     行 264: 1716239834572.e56a4d6aae43b5d42561e4ee6f0e3132.', STARTKEY => '001_2148043057_5975', ENDKEY => '001_23     行 278: 1714252181329.5de683912a8120bae9f37833fb286a30.', STARTKEY => '001_238065_2439', ENDKEY => '001_400433     行 292: 1714858026179.941a4921968267374876b52fdb33a1d7.', STARTKEY => '001_400433_45599', ENDKEY => '001_43429     行 306: 1714858026179.16e7de83bd7944e9d23b3568b14eaf9c.', STARTKEY => '001_434296_34588', ENDKEY => '001~'}     行 331: 1714082282269.6853c99dc6d17b2340e04307e5492d58.', STARTKEY => '001~', ENDKEY => '002_2147741550_785'}     行 345: 1714463331546.80f60ef11f1d337bcc09d7f24d390b28.', STARTKEY => '002_2147741550_785', ENDKEY => '002_214     行 359: 1714463331546.9281d964d08863aab2745f8331c148ad.', STARTKEY => '002_2148386148_27094', ENDKEY => '002_4     行 373: 1714685085875.2affd725c347399ad8c77eabd0a5d4f2.', STARTKEY => '002_400185_74884', ENDKEY => '002_45861     行 387: 1714685085875.910cbc03d1d8571f1eda21e3441f9359.', STARTKEY => '002_458618_25467', ENDKEY => '002~'}     行 401: 1714065682984.2358541c9c8d3f2f8c4496a1fd350c6c.', STARTKEY => '002~', ENDKEY => '003_2147739809_4985'}     行 415: 1716251410111.c60662b46cabd2cd0638d39796f11827.', STARTKEY => '003_2147739809_4985', ENDKEY => '003_21     行 429: 1716251410111.016507ab001379f86acdf0c40a5b93be.', STARTKEY => '003_2148024128_3054', ENDKEY => '003_21     行 443: 1714348539371.e7a41938549f7384192edd059d7e4a3e.', STARTKEY => '003_2148386097_25973', ENDKEY => '003_3     行 457: 1714925889818.a6c3c09cddd2c3e359c0f1497a302d6d.', STARTKEY => '003_396959_86147', ENDKEY => '003_45861     行 471: 1714925889818.eb98caf696d333714fc917c95839ea8e.', STARTKEY => '003_458619_61964', ENDKEY => '003~'}     行 485: 1713919439849.22b315f87ea850b2f1b052ccacf40a5c.', STARTKEY => '003~', ENDKEY => '004_2147804164_6378'}     行 499: 1714553829364.ee60c3e63e43e18487afa3ebd9db7890.', STARTKEY => '004_2147804164_6378', ENDKEY => '004_21     行 516: 1714553829364.30e09f836793166fb64f1799b63c56fc.', STARTKEY => '004_2148363241_1674', ENDKEY => '004_40     行 530: 1714831210652.05d86d46eb1717408f7b6d189c711b6d.', STARTKEY => '004_400633_98138', ENDKEY => '004_45953     行 544: 1714831210652.7ebc65054e3819ff8f3848108f07a1da.', STARTKEY => '004_459534_8710', ENDKEY => '004~'}     行 558: 1714049632767.4eb7c320ce17d5e6c79d37ad1235cd56.', STARTKEY => '004~', ENDKEY => '005_2147868266_5368'}     行 572: 1714364810854.f65ec5a2f28317951dab5e241d2e100f.', STARTKEY => '005_2147868266_5368', ENDKEY => '005_21     行 586: 1714364810854.f11c9bba0679a71b0b2893a44a8e188b.', STARTKEY => '005_2148453550_2383', ENDKEY => '005_40     行 600: 1715226125040.c01b757b47a6b845d2db236b31077995.', STARTKEY => '005_400582_60878', ENDKEY => '005_45853     行 614: 1715226125040.9e721738a1a570bc5c0b6517af0e8dec.', STARTKEY => '005_458531_5320', ENDKEY => '005~'}     行 628: 1713940302372.b87acbb397753e23c469e70abe4fa9f9.', STARTKEY => '005~', ENDKEY => '006_2147745442_5063'}     行 642: 1714587432405.3f8e44ed581d262a1b259db2ff63318a.', STARTKEY => '006_2147745442_5063', ENDKEY => '006_21     行 656: 1714587432405.1f97f75c0fed08f834fb93b13e7aa811.', STARTKEY => '006_2148337090_6508', ENDKEY => '006_40     行 681: 1716332054802.c3b7bfa948f16dff94b3dedc1ec7f50d.', STARTKEY => '006_400189_97248', ENDKEY => '006_45813     行 695: 1716332054802.2e8765e428d0ccd80b9225ddc65446c8.', STARTKEY => '006_458138_15806', ENDKEY => '006~'}     行 709: 1713788567209.ec31f7f5ddfde10878ea051fe1f32ba3.', STARTKEY => '006~', ENDKEY => '007_2147740551_7490'}     行 723: 1714934462762.57e70e760f17ada5007a9e772d90beca.', STARTKEY => '007_2147740551_7490', ENDKEY => '007_21     行 737: 1714934462762.35bb9dfb3d05e8432901f8033f6cee7a.', STARTKEY => '007_2148056236_82497', ENDKEY => '007_2     行 751: 1714154229934.45c37b2c010998db597ccef35afd3064.', STARTKEY => '007_272256_66', ENDKEY => '007_403520_7     行 780: 1715940654148.311e89a95b4d297ca2780945158adc58.', STARTKEY => '007_403520_77527', ENDKEY => '007_45928     行 794: 1715940654148.3c6cf0272f39f876768d4842337d3299.', STARTKEY => '007_459288_29269', ENDKEY => '007~'}     行 808: 1713782187978.9bdda1260a762a2c488a40738a03fa79.', STARTKEY => '007~', ENDKEY => '008_2147802447_7381'}     行 822: 1716066379697.94171fe067a8eee101f2eba648a9ec5d.', STARTKEY => '008_2147802447_7381', ENDKEY => '008_21     行 840: 1716066379697.a70ae8aaf714e5ca19c475dcc22fecf6.', STARTKEY => '008_2148072875_1952', ENDKEY => '008_29     行 854: 1714176119218.60a9e5d7d38d6d7fc068e02a68eb4d71.', STARTKEY => '008_292586_15', ENDKEY => '008_403559_1     行 871: 1708076814211.2507b64001a7889ba98c992952e0a11c.', STARTKEY => '008_403559_12058', ENDKEY => '008~'}     行 885: 1713850847437.b1cbc32638deb727e6276d769631c807.', STARTKEY => '008~', ENDKEY => '009_2147870693_12'}     行 899: 1714589904081.7726c5dda6dfcc017394131ee0076069.', STARTKEY => '009_2147870693_12', ENDKEY => '009_2148     行 913: 1714589904081.b87728ff46c63c7f501200685e0e4894.', STARTKEY => '009_2148372282_27326', ENDKEY => '009_3     行 931: 1708045910524.04fd253c56df243307e9307c8a3d68cf.', STARTKEY => '009_397212_26389', ENDKEY => '009~'}     行 945: 1713882406639.8258e2429f573eb330fd8e5b7d2ee1f8.', STARTKEY => '009~', ENDKEY => '010_2147737127_247'}     行 959: 1714796123225.5389ff2d265f77a26dcd87e17cb3b579.', STARTKEY => '010_2147737127_247', ENDKEY => '010_214     行 973: 1714796123225.5b718200fc3ea850c602b3f703f779eb.', STARTKEY => '010_2148057205_93400', ENDKEY => '010_2     行 987: 1714299710921.2aa8c9188f544df81356eb52af65d018.', STARTKEY => '010_244005_3000', ENDKEY => '010_402609     行 1004: 1708074203058.587ec6f2f433291774c3d8de0f1f2242.', STARTKEY => '010_402609_42476', ENDKEY => '010~'}     行 1018: 1713836238945.c75b2a896ceba1b2d56e48ca277dadaa.', STARTKEY => '010~', ENDKEY => '011_2147745395_715'}     行 1032: 1714339069201.710d615f2df6cbd093f79b0b213ce791.', STARTKEY => '011_2147745395_715', ENDKEY => '011_214     行 1046: 1714339069201.03aaf8e6f8d8c67537dd9f0afd01943e.', STARTKEY => '011_2148369538_34757', ENDKEY => '011_4     行 1060: 1716070503891.bc4c6d88182f1b632d38da991e48e011.', STARTKEY => '011_404725_94731', ENDKEY => '011_45970     行 1074: 1716070503891.eb16cf2fb7a49b0943687d3d32ead894.', STARTKEY => '011_459700_5099', ENDKEY => '011~'}     行 1088: 1713891016217.de71cb2169f52e4cc0d358c0c2a43582.', STARTKEY => '011~', ENDKEY => '012_2147741757_8484'}     行 1102: 1716002692031.eae5ab77746cbe503b286cfb3b272b72.', STARTKEY => '012_2147741757_8484', ENDKEY => '012_21     行 1116: 1716002692031.f93986ef399fbb2c2fca9d9f11a5392d.', STARTKEY => '012_2148056189_47976', ENDKEY => '012_2     行 1130: 1714208784238.54bf4fe301e9364af9256d5c87b06a46.', STARTKEY => '012_238000_9816', ENDKEY => '012_400551     行 1144: 1714975594254.a4d00e7e767681097b05fdeb79b35bad.', STARTKEY => '012_400551_16541', ENDKEY => '012_43374     行 1158: 1714975594254.4ecc60753c27aa85a3fcc4ac86c8b0b2.', STARTKEY => '012_433749_60035', ENDKEY => '012~'}     行 1172: 1713974475437.9aab0765dcb738043945499216101ba9.', STARTKEY => '012~', ENDKEY => '013_2147741955_6492'}     行 1186: 1714960845057.46c9a8d0df0bd6db3bdce0e0a2cea48a.', STARTKEY => '013_2147741955_6492', ENDKEY => '013_21     行 1200: 1714960845057.d88bc43ffac73492a0a36f7c5bfcc0c8.', STARTKEY => '013_2148057208_95281', ENDKEY => '013_2     行 1214: 1714265486039.0d03fdd437a7632b273c0053e87ffdc1.', STARTKEY => '013_217100_1043', ENDKEY => '013_401950     行 1233: 1715148615709.1f657f5c7bc271b76948bcd185c97e2d.', STARTKEY => '013_401950_1130', ENDKEY => '013_459059     行 1247: 1715148615709.6b5157233edee3b4130c07f226ba3fd6.', STARTKEY => '013_459059_41294', ENDKEY => '013~'}     行 1261: 1714039908922.fbc61de7adef2db95a44ea4b0935bbe2.', STARTKEY => '013~', ENDKEY => '014_2147878723_251'}     行 1279: 1714486830209.a20ba7d8da9112cb336da1c2a8bb26c2.', STARTKEY => '014_2147878723_251', ENDKEY => '014_214     行 1293: 1714486830209.1b60af9303c5114cb3d5cafb79f3eb74.', STARTKEY => '014_2148447801_19926', ENDKEY => '014_3     行 1307: 1714674554447.2e9c855e61a7d9135e53a3d55293a14c.', STARTKEY => '014_386802_1214', ENDKEY => '014_433464     行 1321: 1714674554447.a7f79cd8e82bd364d6cfcff388f750ea.', STARTKEY => '014_433464_7363', ENDKEY => '014~'}     行 1335: 1713858038258.dacc8560915e029713afc25ea30d7447.', STARTKEY => '014~', ENDKEY => '015_2147737329_8952'}     行 1349: 1714761458802.8d4c138669a8d68a7a53f5c58d41b9bb.', STARTKEY => '015_2147737329_8952', ENDKEY => '015_21     行 1363: 1714761458802.366510d937e095436af5db15b2aa1c4e.', STARTKEY => '015_2148057120_63732', ENDKEY => '015_2     行 1377: 1714184733381.b77404d820f77c613e41194515e27eb8.', STARTKEY => '015_240699_8762', ENDKEY => '015_401807     行 1391: 1714949929081.bdf72f69de268dd82b7898df150bf979.', STARTKEY => '015_401807_40927', ENDKEY => '015_45848     行 1405: 1714949929081.a84c2af137996e16a55bb3704d17ce1b.', STARTKEY => '015_458489_9720', ENDKEY => '015~'}     行 1419: 1713867712521.4fddeb3b772edc77e235c1f158cdd3b9.', STARTKEY => '015~', ENDKEY => '016_2147731002_6889'}     行 1433: 1714969898563.f0861b8e640e34ad21d6109556485ad9.', STARTKEY => '016_2147731002_6889', ENDKEY => '016_21     行 1447: 1714969898563.ceb9bce219bcdf889a65abbdd8da5687.', STARTKEY => '016_2148055832_54403', ENDKEY => '016_2     行 1461: 1714257950140.557d89a9c7b6e24a8650bb1aed3b4c5a.', STARTKEY => '016_228973_8206', ENDKEY => '016_400320     行 1475: 1715248692312.76de3ca7e7434cafccb4b05e672ccbf8.', STARTKEY => '016_400320_69747', ENDKEY => '016_45925     行 1489: 1715248692312.388ddb00921d7103720be536287f5caf.', STARTKEY => '016_459259_97215', ENDKEY => '016~'}     行 1503: 1713907554663.db5fe00f1c73ec7c1ea05cffbeb909f4.', STARTKEY => '016~', ENDKEY => '017_2147726183_4182'}     行 1517: 1714357655434.d6857cc20b13dc4525deb1c03f59b85a.', STARTKEY => '017_2147726183_4182', ENDKEY => '017_21     行 1531: 1714357655434.ce20a7abd04554004ea9bb364521ee04.', STARTKEY => '017_2148350869_5378', ENDKEY => '017_39     行 1545: 1714888685039.658f6d9a3f1a11ace0e2545e239498b4.', STARTKEY => '017_390123_314', ENDKEY => '017_459457_     行 1559: 1714888685039.d9215665b0d1b46e391132fa5ada45ac.', STARTKEY => '017_459457_59600', ENDKEY => '017~'}     行 1573: 1714053082288.8c4fd1bf2a0304fa2949a7436fb2c161.', STARTKEY => '017~', ENDKEY => '018_2147786397_6775'}     行 1591: 1716219867208.f1a09ef92ae2282633b7adca9eb296a1.', STARTKEY => '018_2147786397_6775', ENDKEY => '018_21     行 1605: 1716219867208.830042bb8e849cfca9551db75892b916.', STARTKEY => '018_2148056209_6675', ENDKEY => '018_21     行 1619: 1714347201480.5d37a440482254ac01332889d35826eb.', STARTKEY => '018_2148452272_3562', ENDKEY => '018_40     行 1633: 1714943366404.8e3439cd2c807cdedc6407e2747357dd.', STARTKEY => '018_400557_64723', ENDKEY => '018_43418     行 1647: 1714943366404.c28d48b642ae6f4d5cacdccbe993a504.', STARTKEY => '018_434185_2410', ENDKEY => '018~'}     行 1672: 1713988096794.d5951fd3d0d16db5100ca5ad9be1066c.', STARTKEY => '018~', ENDKEY => '019_2147946056_1911'}     行 1686: 1714763767953.260036fcb47ecc8a8aa5e187a905f854.', STARTKEY => '019_2147946056_1911', ENDKEY => '019_21     行 1700: 1714763767953.e008a337b9774ff4db713ae4b37c87dc.', STARTKEY => '019_2148372254_6621', ENDKEY => '019_40     行 1714: 1714806528552.89c614bd99944f2d125516b04a1bab43.', STARTKEY => '019_400558_55203', ENDKEY => '019_45870     行 1728: 1714806528552.727ebac21e4fc3d22c9dad59dfe97e69.', STARTKEY => '019_458704_45272', ENDKEY => '019~'}     行 1742: 1713751690854.1172720f76b83a8ec2099f909feff552.', STARTKEY => '019~', ENDKEY => '020_2147742247_6150'}     行 1756: 1714409142876.a4cc5f075dd4575cb0b221a70e7f17ca.', STARTKEY => '020_2147742247_6150', ENDKEY => '020_21     行 1770: 1714409142876.02cb0b3a04f772620dbb48f8f2b6265f.', STARTKEY => '020_2148372255_56716', ENDKEY => '020_4     行 1787: 1714893629505.137b5c716fec406c578834a06f748e23.', STARTKEY => '020_403011_11994', ENDKEY => '020_45845     行 1801: 1714893629505.bbaad23d0331f7ac8def29b6795b4fb1.', STARTKEY => '020_458456_86200', ENDKEY => '020~'}     行 1815: 1713852789342.6de778f17b0b322ff84c6c2a53df7daf.', STARTKEY => '020~', ENDKEY => '021_2147817893_4476'}     行 1829: 1714264115637.61e8f568bc75d06153f12216b6854f7e.', STARTKEY => '021_2147817893_4476', ENDKEY => '021_28     行 1843: 1714264115637.a8fd3032a2162e98322e20ae922774e1.', STARTKEY => '021_280710_4018', ENDKEY => '021_401920     行 1857: 1715360230355.4f4b909d030d18b27351a1a7abbac926.', STARTKEY => '021_401920_75711', ENDKEY => '021_45990     行 1871: 1715360230355.6da6b017b272022bf34cb09780d76d7b.', STARTKEY => '021_459907_49165', ENDKEY => '021~'}     行 1885: 1713836262481.65777e28cc1f01762fb789cecc087aa6.', STARTKEY => '021~', ENDKEY => '022_2147732603_9644'}     行 1899: 1716197523402.3357d8cc8b439f874f109775d138437d.', STARTKEY => '022_2147732603_9644', ENDKEY => '022_21     行 1913: 1716197523402.b97a54f51959cd9c5b6fd73a93781809.', STARTKEY => '022_2148055838_28370', ENDKEY => '022_2     行 1927: 1714198041468.5086f65768ad2da8eed6b9d075fdad65.', STARTKEY => '022_249410_8761', ENDKEY => '022_400720     行 1945: 1714881089327.156d67cd1e0857dea9e8482c37672714.', STARTKEY => '022_400720_59546', ENDKEY => '022_45990     行 1959: 1714881089327.a4eb1e9d08e283bddc5ba8c6f77a5da9.', STARTKEY => '022_459908_48435', ENDKEY => '022~'}     行 1973: 1713873527915.a2cd6851d20a967ea1699fbe0948c275.', STARTKEY => '022~', ENDKEY => '023_2147737444_7403'}     行 1987: 1716133890482.ecb29e5958bf2915a050426dfc996bbd.', STARTKEY => '023_2147737444_7403', ENDKEY => '023_21     行 2001: 1716133890482.10bc7d4b65b96f9ebc5745f0ac5bb166.', STARTKEY => '023_2148056556_40410', ENDKEY => '023_2     行 2015: 1714262180359.4a375e8641e264151b0ab46b1b3fc5f5.', STARTKEY => '023_240866_3053', ENDKEY => '023_401673     行 2029: 1716034696239.d7c3aa31e2d017a38a109fbb71cac8d0.', STARTKEY => '023_401673_36630', ENDKEY => '023_45957     行 2043: 1716034696239.78a3bc563cac7a95174fa608db5d4150.', STARTKEY => '023_459570_62668', ENDKEY => '023~'}     行 2057: 1713933588897.1c4e718cf2c57bf4859518f7fefb36c9.', STARTKEY => '023~', ENDKEY => '024_2147738594_4199'}     行 2071: 1716154114889.390ed264ffb6901fee48a22d93701daf.', STARTKEY => '024_2147738594_4199', ENDKEY => '024_21     行 2088: 1716154114889.3fafa4143e3528fbeb875489352a9f70.', STARTKEY => '024_2148047234_7436', ENDKEY => '024_21     行 2102: 1714313789768.19a29e6a465c0462bf9d0e4b07b01f1a.', STARTKEY => '024_219620_8492', ENDKEY => '024_391279     行 2116: 1714916738323.5006b0610af145de1d6e1f7ebf5f8be9.', STARTKEY => '024_391279_4677', ENDKEY => '024_432667     行 2130: 1714916738323.80074685e1c08a6649335ee5a34dc52a.', STARTKEY => '024_432667_60035', ENDKEY => '024~'}     行 2144: 1713860254833.125fd40b74b3293e76d718e6d3db92fb.', STARTKEY => '024~', ENDKEY => '025_2147728987_7735'}     行 2158: 1714575734010.60b963d3e3e00317b50e91be27d750c9.', STARTKEY => '025_2147728987_7735', ENDKEY => '025_21     行 2176: 1714575734010.35ee3911536a49e359f9b082fed8f581.', STARTKEY => '025_2148362417_6513', ENDKEY => '025_39     行 2190: 1715995396782.532936620f036f0e4bf0bef71c8d099e.', STARTKEY => '025_396960_53690', ENDKEY => '025_43386     行 2204: 1715995396782.9b82287de9d65c6c49c30bd37eba0f6b.', STARTKEY => '025_433869_38225', ENDKEY => '025~'}     行 2218: 1713924261013.d11ffba865d8aa3ed3d62a6413d3d7cd.', STARTKEY => '025~', ENDKEY => '026_2147739994_3757'}     行 2232: 1715030690353.e536a3d848d1f80499855b7cf0088a13.', STARTKEY => '026_2147739994_3757', ENDKEY => '026_21     行 2249: 1715030690353.191970e5d31196129032db28647e749c.', STARTKEY => '026_2148050518_8774', ENDKEY => '026_22     行 2263: 1714287082025.3f7786d9daa74a949fb1a7e96b87bd35.', STARTKEY => '026_227260_1406', ENDKEY => '026_400527     行 2280: 1714941095816.40be78efc2138a716211f49ab1cc851e.', STARTKEY => '026_400527_14684', ENDKEY => '026_43415     行 2294: 1714941095816.c7a2737ddc94d1052db9c98e6391f5ff.', STARTKEY => '026_434155_42163', ENDKEY => '026~'}     行 2308: 1714019422593.7c500e78acc10752a620df86181ab57a.', STARTKEY => '026~', ENDKEY => '027_2147799541_51'}     行 2322: 1714972517147.f3f95f0f15c17c0ba888a3603384091e.', STARTKEY => '027_2147799541_51', ENDKEY => '027_2148     行 2336: 1714972517147.2ab3ff1a51561c52ecec478d711f08b9.', STARTKEY => '027_2148165799_7617', ENDKEY => '027_37     行 2350: 1714915096787.072b3aef1aff0b440d54452a75529a4c.', STARTKEY => '027_371492_9995', ENDKEY => '027_432003     行 2364: 1714915096787.cf4764996dba98b407dce5bcb10c78c1.', STARTKEY => '027_432003_96360', ENDKEY => '027~'}     行 2378: 1713967802535.bacd5a3eb4400074b86bc66936144dc0.', STARTKEY => '027~', ENDKEY => '028_2147738795_4140'}     行 2392: 1715018084186.c2275687ef0a27b58129595e3ccf8ee5.', STARTKEY => '028_2147738795_4140', ENDKEY => '028_21     行 2406: 1715018084186.71277e79771e6e5aa867a278dbddbdd5.', STARTKEY => '028_2148055806_98519', ENDKEY => '028_2     行 2420: 1714214509223.1dec7cd6de851a10e423e9b649852c0f.', STARTKEY => '028_215736_1091', ENDKEY => '028_401678     行 2434: 1715655855350.d4cd150573f2b7a5a2be402ed186057d.', STARTKEY => '028_401678_34009', ENDKEY => '028_45957     行 2448: 1715655855350.52c2771cef03565add32a6d3b104623d.', STARTKEY => '028_459575_43277', ENDKEY => '028~'}     行 2462: 1714544966794.305c465d4d04ba0e2ff0f10fce434b80.', STARTKEY => '028~', ENDKEY => '029_2147797141_7842'}     行 2476: 1714544966794.5ef917b333401806e194448ce0d0eb88.', STARTKEY => '029_2147797141_7842', ENDKEY => '029_21     行 2490: 1713899500099.e1a9847354c08f59c75e363345c79c93.', STARTKEY => '029_2148334692_1773', ENDKEY => '029_40     行 2507: 1708036535068.c726ae51ee61b2a892d4b095f35abb93.', STARTKEY => '029_405280_27926', ENDKEY => '029~'}     行 2521: 1713930947732.2607e169cf772b46d854c2cf3dca1db3.', STARTKEY => '029~', ENDKEY => '030_2147868270_4664'}     行 2535: 1715004957141.98f79229536db0c736fe219e2f8a67fe.', STARTKEY => '030_2147868270_4664', ENDKEY => '030_21     行 2555: 1715004957141.13d57559324b5dae58d05a4b05054339.', STARTKEY => '030_2148076854_6921', ENDKEY => '030_27     行 2569: 1714589325698.cae7d40026955f839123c7293a686bd5.', STARTKEY => '030_271292_9741', ENDKEY => '030_403218     行 2583: 1714923910572.b5c9a68d552bce7e4b11790dcda17b0b.', STARTKEY => '030_403218_126', ENDKEY => '030_459629_     行 2597: 1714923910572.e905f59374c027c4634c81bc3f6f2906.', STARTKEY => '030_459629_45058', ENDKEY => '030~'}     行 2612: 1714800246401.90db6093fb991bb96281db1e934bc827.', STARTKEY => '030~', ENDKEY => '031_2147750252_9616'}     行 2626: 1714800246401.8c452ff2cd8bf3f8d68457ced01b0002.', STARTKEY => '031_2147750252_9616', ENDKEY => '031_21     行 2644: 1716101219054.db99a72845cb326578c668bc1c002383.', STARTKEY => '031_2148069305_7617', ENDKEY => '031_24     行 2658: 1716101219054.dd17ff16a4a1ca32b92dc2c987db7997.', STARTKEY => '031_246393_5199', ENDKEY => '031_404133     行 2676: 1714960186674.73b701f09bac97020468f18aee814901.', STARTKEY => '031_404133_65972', ENDKEY => '031_45934     行 2690: 1714960186674.4110f7745e75cca2050b918bd918b072.', STARTKEY => '031_459343_71262', ENDKEY => '031~'}     行 2704: 1713960382758.9d0eb5912f6b3f9a1c4cd90cc8c5c720.', STARTKEY => '031~', ENDKEY => '032_2147878599_5920'}     行 2721: 1714603797675.c46fd42994fa5b3ae13900dd02f6074b.', STARTKEY => '032_2147878599_5920', ENDKEY => '032_24     行 2735: 1714603797675.a2224028bc6d37c78b100d8bab1d34d4.', STARTKEY => '032_240602_5224', ENDKEY => '032_403811     行 2752: 1715496340820.855a601cc2c965e030249e19d9176f66.', STARTKEY => '032_403811_10299', ENDKEY => '032_46090     行 2766: 1715496340820.47edb984dc77ea61719ee555328ab5c2.', STARTKEY => '032_460905_44795', ENDKEY => '032~'}     行 2780: 1713953650437.2b6457b0a130d2803ef255cb96fcb52c.', STARTKEY => '032~', ENDKEY => '033_2147969048_5464'}     行 2794: 1714929179252.88fbe077396ad3f9b9a55bf7351244f7.', STARTKEY => '033_2147969048_5464', ENDKEY => '033_21     行 2808: 1714929179252.bfa03380687d104cbcbb859c5c5be912.', STARTKEY => '033_2148440004_12404', ENDKEY => '033_4     行 2825: 1715584633789.4f078fc48d534ef24029b1bbe10c2047.', STARTKEY => '033_402991_77626', ENDKEY => '033_46090     行 2839: 1715584633789.ef8161d1a56b402cc11aa4f5293c6597.', STARTKEY => '033_460906_56282', ENDKEY => '033~'}     行 2853: 1713871721988.43e5441dbdba8a08ba8d7ec12431b497.', STARTKEY => '033~', ENDKEY => '034_2147752370_3312'}     行 2867: 1714917613795.a3812947a7aaecb658192ece9a442685.', STARTKEY => '034_2147752370_3312', ENDKEY => '034_21     行 2881: 1714917613795.c96b81227da9e78d7e05079b50108147.', STARTKEY => '034_2148057927_28309', ENDKEY => '034_2     行 2895: 1714252279945.cab455a7d86974dda242cb977e6359fa.', STARTKEY => '034_278984_5967', ENDKEY => '034_404136     行 2912: 1714910921339.50477fad738b87d0500bdb8455c8854d.', STARTKEY => '034_404136_28628', ENDKEY => '034_46117     行 2926: 1714910921339.22e824c1e8eddbb4f0712090db9bd84d.', STARTKEY => '034_461178_57741', ENDKEY => '034~'}     行 2940: 1713641707736.43530796d840b0b0caeee044d78fb295.', STARTKEY => '034~', ENDKEY => '035_2147945908_487'}     行 2954: 1714581966710.1c36435404bd1c2ca90d07f75a686ff8.', STARTKEY => '035_2147945908_487', ENDKEY => '035_214     行 2972: 1714581966710.2fa2605c8760c6a6e1d1116b78e5a4c3.', STARTKEY => '035_2148440151_16256', ENDKEY => '035_4     行 2986: 1714923473567.e1174b8ead96718d3ec1142d071f733c.', STARTKEY => '035_403997_77781', ENDKEY => '035_46037     行 3000: 1714923473567.92a5fb8ecde1aff24473e73cb7831800.', STARTKEY => '035_460372_74376', ENDKEY => '035~'}     行 3014: 1715542310929.3482485535ca66fe7e0240aba398db90.', STARTKEY => '035~', ENDKEY => '036_2147761263_9237'}     行 3028: 1715542310929.c0a99596704ba8a9227673286cfabdde.', STARTKEY => '036_2147761263_9237', ENDKEY => '036_21     行 3042: 1713425201281.380cd84f2bacfa99ba2a5bbaf35e0968.', STARTKEY => '036_2148163081_2053', ENDKEY => '036_40     行 3056: 1714839839046.6c9a5b5b55c5999e37c0951a672cdf84.', STARTKEY => '036_404335_20143', ENDKEY => '036_45934     行 3070: 1714839839046.38acbda3d1b86794436f3d7953c79821.', STARTKEY => '036_459348_35924', ENDKEY => '036~'}     行 3084: 1713856689186.23a6c7294695d2afd06692ac314b8a74.', STARTKEY => '036~', ENDKEY => '037_2147734446_4983'}     行 3098: 1714488756723.2ebc3991884d369c5b903fa9bd23ae88.', STARTKEY => '037_2147734446_4983', ENDKEY => '037_21     行 3116: 1714488756723.6814f2e4bb1b22f99eec342254b3da58.', STARTKEY => '037_2148363253_366', ENDKEY => '037_400     行 3135: 1714702557066.dfdc3c33d0ef9c8014ae73527db2f0c4.', STARTKEY => '037_400593_50147', ENDKEY => '037_45897     行 3149: 1714702557066.fd3b397b8eecc74d8166bf518a2026d4.', STARTKEY => '037_458974_15926', ENDKEY => '037~'}     行 3163: 1714812578658.53c8a0168863dcb24ec9d4fa6e37b053.', STARTKEY => '037~', ENDKEY => '038_2147761265_9569'}     行 3177: 1714812578658.9e63b5fcf2ca94f5a73dc501c4464441.', STARTKEY => '038_2147761265_9569', ENDKEY => '038_21     行 3191: 1713641075195.c67eaa21187e7dc99a5534a82067dd84.', STARTKEY => '038_2148163083_5274', ENDKEY => '038_40     行 3208: 1714960925066.af8f39b5c58792d6eaf0f7e99c1dc2f4.', STARTKEY => '038_404966_47017', ENDKEY => '038_45974     行 3222: 1714960925066.e0cc442dc1fe664bcd141ff00132ff29.', STARTKEY => '038_459744_69590', ENDKEY => '038~'}     行 3236: 1713916009855.3448c4a8eae9f560a77db7f0b08ec3b2.', STARTKEY => '038~', ENDKEY => '039_2147978681_1657'}     行 3254: 1714851190381.a111f910596601060725d4edfd86d360.', STARTKEY => '039_2147978681_1657', ENDKEY => '039_21     行 3268: 1714851190381.c44c998877886d2504b834b7892e77f4.', STARTKEY => '039_2148440155_15140', ENDKEY => '039_4     行 3282: 1707966725859.5c87b93186d8bde3f91df0edf8ec1b39.', STARTKEY => '039_404338_65339', ENDKEY => '039~'}     行 3296: 1713968593988.3e0922afbd8cd2eda6cc59b623ba8165.', STARTKEY => '039~', ENDKEY => '040_2147937307_6375'}     行 3310: 1714936999164.a9a5f7b3d07967a41fc683723162768c.', STARTKEY => '040_2147937307_6375', ENDKEY => '040_21     行 3324: 1714936999164.f11b7a6c492f24a40f19c6f107d2735f.', STARTKEY => '040_2148386272_44278', ENDKEY => '040_3     行 3338: 1714900430108.4977650e6ffb001e979f23b66ea08d42.', STARTKEY => '040_399859_79658', ENDKEY => '040_45831     行 3352: 1714900430108.96d08fec2bb7f61a93f0c782b8e82832.', STARTKEY => '040_458310_77125', ENDKEY => '040~'}     行 3366: 1715716868969.8b49170c059e4b0e5f822f8976bd2e7f.', STARTKEY => '040~', ENDKEY => '041_2147720000_5328'}     行 3380: 1715716868969.b85d02b9e5512a9fef3e008058851918.', STARTKEY => '041_2147720000_5328', ENDKEY => '041_21     行 3397: 1714095365195.315c3c4a64d3c901d88fdaf6c995e12e.', STARTKEY => '041_2148022766_9063', ENDKEY => '041_39     行 3411: 1715656068605.fcf5b494b55fdd7d591d4803a7e496b0.', STARTKEY => '041_394536_6459', ENDKEY => '041_458311     行 3425: 1715656068605.e493e45689611648ecee5e71765d64ce.', STARTKEY => '041_458311_412', ENDKEY => '041~'}     行 3439: 1713934003144.069ee6032be74297f3e4f110308c1e79.', STARTKEY => '041~', ENDKEY => '042_2147900707_4040'}     行 3453: 1714816197591.af3c0f65ce3836653f312cd060f1fb56.', STARTKEY => '042_2147900707_4040', ENDKEY => '042_21     行 3467: 1714816197591.39361d5c428f904f9258dd9ce258b5f4.', STARTKEY => '042_2148372097_18202', ENDKEY => '042_4     行 3486: 1714770109039.7e9b917aad41bc218bd132be89efb63b.', STARTKEY => '042_400560_1597', ENDKEY => '042_458547     行 3500: 1714770109039.9fe190b58b466df331823e5ef21898da.', STARTKEY => '042_458547_5364', ENDKEY => '042~'}     行 3514: 1714021531722.2bd5e707c3c0d7e70b6a0721037d48b8.', STARTKEY => '042~', ENDKEY => '043_2147729162_3998'}     行 3528: 1714264590109.042d00027af8612b693a9c68dfd78617.', STARTKEY => '043_2147729162_3998', ENDKEY => '043_21     行 3542: 1714264590109.bda48b84f8aec09e80241d530c45f06d.', STARTKEY => '043_2148372098_32023', ENDKEY => '043_3     行 3556: 1714643769960.cd3faf8c408663822edb96be6d942e1c.', STARTKEY => '043_381275_6964', ENDKEY => '043_433524     行 3570: 1714643769960.6d7e4cee8a77bedad422e416ba0ce8be.', STARTKEY => '043_433524_80427', ENDKEY => '043~'}     行 3584: 1713894205750.1c7f71503ffa6d99ed13330fa01935e5.', STARTKEY => '043~', ENDKEY => '044_2147738735_492'}     行 3598: 1714308720232.2ef1bb62f9905d4eb440c45ed0b5dfb3.', STARTKEY => '044_2147738735_492', ENDKEY => '044_226     行 3612: 1714308720232.0e3ef644f54aa1713a50042ce95598fa.', STARTKEY => '044_226433_2176', ENDKEY => '044_397174     行 3626: 1715245911220.2918ea5a37bf0c8b88ad001f738aa1de.', STARTKEY => '044_397174_64305', ENDKEY => '044_43367     行 3640: 1715245911220.b0c8bc9f9950948f65e1386f42dcbe31.', STARTKEY => '044_433670_7184', ENDKEY => '044~'}     行 3654: 1713943224502.1bdc7f049218a9632bc56e5073daec1b.', STARTKEY => '044~', ENDKEY => '045_2147742303_6101'}     行 3668: 1715655978496.f186146836257f0b7dc0dec68e1e2a3c.', STARTKEY => '045_2147742303_6101', ENDKEY => '045_21     行 3682: 1715655978496.20d54b2e081d1988569da51a9aec9af0.', STARTKEY => '045_2148055878_67044', ENDKEY => '045_2     行 3696: 1714319884925.39b7db5f60ce567783437c1f4ee02c12.', STARTKEY => '045_221777_3133', ENDKEY => '045_400615     行 3714: 1708086158167.8647f50f5195092e17c36e4a9c5169ed.', STARTKEY => '045_400615_2152', ENDKEY => '045~'}     行 3728: 1713974059696.fe03e5948c6aeef881e8d3640297669a.', STARTKEY => '045~', ENDKEY => '046_2147784486_4759'}     行 3746: 1714745564686.87d5984d87f7b02d262175e767289565.', STARTKEY => '046_2147784486_4759', ENDKEY => '046_21     行 3760: 1714745564686.59cabe37ba13982fa599b7c4ef56d572.', STARTKEY => '046_2148337607_15608', ENDKEY => '046_3     行 3774: 1714816703593.9dafc63bfa65f7ed6454bb066c4d2e23.', STARTKEY => '046_397228_93582', ENDKEY => '046_45851     行 3788: 1714816703593.c82d8b72a873c19092425694888d85d9.', STARTKEY => '046_458513_34239', ENDKEY => '046~'}     行 3802: 1713987696820.b24a66202fd89b2a62162f01a5b4b365.', STARTKEY => '046~', ENDKEY => '047_2147925791_3565'}     行 3816: 1714925404381.9f607566b74103f5a2f9e4a48b4af4ec.', STARTKEY => '047_2147925791_3565', ENDKEY => '047_21     行 3830: 1714925404381.6124aa12304bb17448ceea88a3d6e1b8.', STARTKEY => '047_2148372313_73226', ENDKEY => '047_4     行 3844: 1716070911932.426539e601cd5ef9f54bd05dc57b5ef7.', STARTKEY => '047_400330_41719', ENDKEY => '047_43419     行 3858: 1716070911932.2ff7f6e8fa5f735a0b4b1e8990fdb346.', STARTKEY => '047_434193_93214', ENDKEY => '047~'}     行 3872: 1713854755004.5a9b7ab988daaae829e18a2dacbe23a8.', STARTKEY => '047~', ENDKEY => '048_2147796892_8758'}     行 3886: 1714398430762.f1b3006af7d069901819e3fc92264c8a.', STARTKEY => '048_2147796892_8758', ENDKEY => '048_21     行 3900: 1714398430762.8aabd93f6731b4f97a0936ae186f701c.', STARTKEY => '048_2148369464_26740', ENDKEY => '048_4     行 3914: 1714767094495.9dcb6adb24ca5638e467f52192513706.', STARTKEY => '048_401335_58929', ENDKEY => '048_45946     行 3928: 1714767094495.e0eaca3e387b475288a631b154fb12aa.', STARTKEY => '048_459467_49704', ENDKEY => '048~'}     行 3942: 1713890035617.65ee7a390b2b28c961451cb4923f0d29.', STARTKEY => '048~', ENDKEY => '049_2147740285_2525'}     行 3956: 1714928166634.ea318641c634d5697dd0ae713e1cb586.', STARTKEY => '049_2147740285_2525', ENDKEY => '049_21     行 3970: 1714928166634.3f42ce48af2c23e930cf1a6a3bb0a368.', STARTKEY => '049_2148056416_43650', ENDKEY => '049_2     行 3984: 1714197504973.d0db592885f4fddb87fb60f58bd19d72.', STARTKEY => '049_230188_2901', ENDKEY => '049_396659     行 3998: 1714980383255.d15bb2254fb6826886b587cfdaeab680.', STARTKEY => '049_396659_47718', ENDKEY => '049_45846     行 4012: 1714980383255.a6cde35fac9fa9cf19b596236b07a799.', STARTKEY => '049_458464_54191', ENDKEY => '049~'}     行 4026: 1713843702411.4bb1fea606c662e1315bc69064e9f402.', STARTKEY => '049~', ENDKEY => '050_2147786370_211'}     行 4044: 1714357372528.bc9c6db90c8fb02f474526778e68cd43.', STARTKEY => '050_2147786370_211', ENDKEY => '050_214     行 4058: 1714357372528.5dac9f3dd0744c15b728919b66234a02.', STARTKEY => '050_2148371979_29685', ENDKEY => '050_4     行 4072: 1715004908443.522bced95d7f99bd904eed32ce08bab1.', STARTKEY => '050_401337_24816', ENDKEY => '050_45943     行 4086: 1715004908443.acda3916dc6db284e17f38394931f841.', STARTKEY => '050_459431_938', ENDKEY => '050~'}     行 4100: 1714120534361.f7b8159e26866feedbf1284340a35975.', STARTKEY => '050~', ENDKEY => '051_2147730876_342'}     行 4114: 1714334004693.79e8d6c7c035d2202d8cd61aed8fab15.', STARTKEY => '051_2147730876_342', ENDKEY => '051_214 {code}   The MultiRowRangeFilter should scan all regions? it's differnet as i want... maybe we could changed it, just like the phoenix's skipScanFilter? we just want get data from these Specify ranges, so we could skip to send scan request to other regions...  " Remove deprecated methods in WAL,13578847,Resolved,Major,Fixed,10/May/24 07:10,28/May/24 15:03,, Bump requests from 2.31.0 to 2.32.2 in /dev-support/git-jira-release-audit,13580379,Resolved,Major,Fixed,24/May/24 14:42,24/May/24 14:43,, Add ErrorProne ban on Hadoop shaded thirdparty jars,13579683,Resolved,Major,Fixed,17/May/24 15:09,23/May/24 08:22,,"Over on HBASE-28568 we got tripped up because we pulled in the shaded Guava provided by Hadoop. This wasn't noticed until the backport to branch-2, which builds against hadoop-2. We should make this a compile time failure." Incremental backup fails when WALs move,13579648,Open,Major,,17/May/24 10:40,,2.6.0,"The incremental back process appears to collect a set of WAL files to operate over and then proceed to do so. In between a file moves. This causes the backup to fail. This is reproducible as a flakey unit test, as we see in TestIncrementalBackup.TestIncBackupRestore, {noformat} java.io.IOException: java.io.FileNotFoundException: File hdfs://localhost:39577/user/jenkins/test-data/f51646e4-e3e0-ef30-df2b-aa2a22ed41c3/WALs/94f4fe62ee7a,40249,1715620734331/94f4fe62ee7a%2C40249%2C1715620734331.94f4fe62ee7a%2C40249%2C1715620734331.regiongroup-0.1715620773674 does not exist. at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:289) at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.backupTables(BackupAdminImpl.java:595) at org.apache.hadoop.hbase.backup.TestIncrementalBackup.TestIncBackupRestore(TestIncrementalBackup.java:169) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:840) Caused by: java.io.FileNotFoundException: File hdfs://localhost:39577/user/jenkins/test-data/f51646e4-e3e0-ef30-df2b-aa2a22ed41c3/WALs/94f4fe62ee7a,40249,1715620734331/94f4fe62ee7a%2C40249%2C1715620734331.94f4fe62ee7a%2C40249%2C1715620734331.regiongroup-0.1715620773674 does not exist. at org.apache.hadoop.hdfs.DistributedFileSystem$DirListingIterator.(DistributedFileSystem.java:1282) at org.apache.hadoop.hdfs.DistributedFileSystem$DirListingIterator.(DistributedFileSystem.java:1256) at org.apache.hadoop.hdfs.DistributedFileSystem$25.doCall(DistributedFileSystem.java:1201) at org.apache.hadoop.hdfs.DistributedFileSystem$25.doCall(DistributedFileSystem.java:1197) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hdfs.DistributedFileSystem.listLocatedStatus(DistributedFileSystem.java:1215) at org.apache.hadoop.fs.FileSystem.listLocatedStatus(FileSystem.java:2230) at org.apache.hadoop.hbase.mapreduce.WALInputFormat.getFiles(WALInputFormat.java:356) at org.apache.hadoop.hbase.mapreduce.WALInputFormat.getSplits(WALInputFormat.java:321) at org.apache.hadoop.hbase.mapreduce.WALInputFormat.getSplits(WALInputFormat.java:301) at org.apache.hadoop.mapreduce.JobSubmitter.writeNewSplits(JobSubmitter.java:310) at org.apache.hadoop.mapreduce.JobSubmitter.writeSplits(JobSubmitter.java:327) at org.apache.hadoop.mapreduce.JobSubmitter.submitJobInternal(JobSubmitter.java:200) at org.apache.hadoop.mapreduce.Job$11.run(Job.java:1678) at org.apache.hadoop.mapreduce.Job$11.run(Job.java:1675) at java.base/java.security.AccessController.doPrivileged(AccessController.java:712) at java.base/javax.security.auth.Subject.doAs(Subject.java:439) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899) at org.apache.hadoop.mapreduce.Job.submit(Job.java:1675) at org.apache.hadoop.mapreduce.Job.waitForCompletion(Job.java:1696) at org.apache.hadoop.hbase.mapreduce.WALPlayer.run(WALPlayer.java:423) at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.walToHFiles(IncrementalTableBackupClient.java:406) at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.convertWALsToHFiles(IncrementalTableBackupClient.java:378) at org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.execute(IncrementalTableBackupClient.java:282) ... 34 more {noformat}" Bump requests from 2.31.0 to 2.32.0 in /dev-support/flaky-tests,13579926,Resolved,Major,Fixed,21/May/24 08:21,21/May/24 08:24,, [hbase-operator-tools] setRegionState log should match actual region state,13579985,Open,Major,,21/May/24 14:18,,,"  {code:java} hbase:007:0> list_regions 'ns1:ot1'                                   SERVER_NAME |                                                REGION_NAME |  START_KEY |    END_KEY |  SIZE |   REQ |   LOCALITY | -------------------------------------------- | ---------------------------------------------------------- | ---------- | ---------- | ----- | ----- | ---------- | ,16020,1716198252550 |   ns1:ot1,,1716198398262.4fee86bfd0585b9e8431bc2f8148b11b. |            |         10 |     0 |     0 |        0.0 | ,16020,1716198252550 | ns1:ot1,10,1716198398262.ebec0c22088e9486c044458389de5e16. |         10 |         20 |     0 |     0 |        0.0 | ,16020,1716198252550 | ns1:ot1,20,1716198398262.fbd628f29f99d5e1ccc73abbbafc5f62. |         20 |         30 |     0 |     0 |        0.0 | ,16020,1716198252550 | ns1:ot1,30,1716198398262.621f63c9aebf16614bdaa4c8b22bd681. |         30 |         40 |     0 |     0 |        0.0 | ,16020,1716198252550 | ns1:ot1,40,1716198398262.4a3d75653f14bbbf90dda0db1a1eddcc. |         40 |            |     0 |     0 |        0.0 |{code} {code:java} hbase hbck -j setRegionState 4a3d75653f14bbbf90dda0db1a1eddcc CLOSED {code} With this command, CLI shows the state is changed to CLOSED     {code:java} Changed region 4a3d75653f14bbbf90dda0db1a1eddcc STATE from OPEN to CLOSED {code} However same region state in Hbase UI is still OPEN.   Next time when I run same command again, it changes from CLOSED to CLOSED   {code:java} Changed region 4a3d75653f14bbbf90dda0db1a1eddcc STATE from CLOSED to CLOSED{code}    " [Hbase Operator Tools] Suport Hbase 2.6.0,13579983,Open,Major,,21/May/24 14:05,,,Bump up hbase.version from 2.4.4 to 2.6.0 [HBase Connectors] Support Hbase 2.6.0,13579981,Open,Major,,21/May/24 14:03,,,Bump up hbase.version from 2.5.4 to 2.6.0 Backport HBASE-26525 Use unique thread name for group WALs,13579055,Resolved,Major,Fixed,13/May/24 11:07,21/May/24 08:30,, RowTooBigException is thrown when duplicate increment RPC call is attempted,13579511,Resolved,Major,Fixed,16/May/24 11:45,20/May/24 01:38,2.5.5,"*Issue:* `RowTooBigException` is thrown when a duplicate increment RPC call is attempted. *Expected Behavior:* 1. The initial RPC increment call should time out for some reason. 2. The duplicate RPC call should be converted to a GET request and fetch the result that I am trying to increment. 3. The result should contain only the qualifier that I am attempting to increment. *Actual Behavior:* 1. The initial RPC increment call timed out, which is expected. 2. The duplicate RPC call is converted to a GET request but fails to clone the qualifier into the GET request. 3. Hence, the GET request attempts to retrieve all qualifiers for the given row and columnfamily, resulting in a `RowTooBigException`. *Steps to Reproduce:* 1. Ensure a row with a total value size exceeding `hbase.table.max.rowsize` (default = 1073741824) exists. 2. Nonce property should be enabled `hbase.client.nonces.enabled` which is actually defaulted to true. 3. Attempt to increment a qualifier against the same row. 4. In my case, I am using a postIncrement co-processor which may cause a delay (longer than the RPC timeout property). 5. A duplicate increment call should be triggered, which tries to get the value rather than increment it. 6. The GET request actually tries to retrieve all the qualifiers for the row, resulting in a `RowTooBigException`. *Insights:* Upon further debugging, I found that qualifiers are not cloned into the GET instance due to incorrect usage of [CellScanner.advance|https://github.com/apache/hbase/blob/7ebd4381261fefd78fc2acf258a95184f4147cee/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java#L3833] *Fix Suggestion:* Removing the `!` operation from `while (!CellScanner.advance)` may resolve the issue. Attached Exception Stack Trace for reference." Finish 2.6.0 release,13579679,Resolved,Major,Done,17/May/24 14:00,20/May/24 21:03,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Add xml to download page (via HBASE-28236) # Push tag 2.6.0RC4 as tag rel/2.6.0 # Release 2.6.0 on JIRA [https://issues.apache.org/jira/projects/HBASE/versions/12353291] # Add release data on [https://reporter.apache.org/addrelease.html?hbase] # Send announcement email" Incremental backup set does not correctly shrink,13578269,Resolved,Major,Fixed,06/May/24 12:39,18/May/24 17:31,2.6.0,"The logic in BackupAdminImpl#finalizeDelete does not properly clean up tables from the incrementalBackupTableSet (= the set of backups to include in every incremental backup). This can lead to backups failing.   Minimal example to reproduce from source: * Add following to `conf/hbase-site.xml` to enable backups: {code:java} hbase.backup.enable true hbase.master.logcleaner.plugins org.apache.hadoop.hbase.master.cleaner.TimeToLiveLogCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveProcedureWALCleaner,org.apache.hadoop.hbase.master.cleaner.TimeToLiveMasterLocalStoreWALCleaner,org.apache.hadoop.hbase.backup.master.BackupLogCleaner hbase.procedure.master.classes org.apache.hadoop.hbase.backup.master.LogRollMasterProcedureManager hbase.procedure.regionserver.classes org.apache.hadoop.hbase.backup.regionserver.LogRollRegionServerProcedureManager hbase.coprocessor.region.classes org.apache.hadoop.hbase.backup.BackupObserver hbase.fs.tmp.dir file:/tmp/hbase-tmp {code} * Start HBase: {{bin/start-hbase.sh}} * {code:java} echo ""create 'table1', 'cf'"" | bin/hbase shell -n echo ""create 'table2', 'cf'"" | bin/hbase shell -nbin/hbase backup create full file:/tmp/hbasebackups -t table1 bin/hbase backup create full file:/tmp/hbasebackups -t table2 bin/hbase backup create incremental file:/tmp/hbasebackups # Deletes the 2 most recent backups bin/hbase backup delete -l $(bin/hbase backup history | head -n1  | tail -n -1 | grep -o -P ""backup_\d+""),$(bin/hbase backup history | head -n2  | tail -n -1 | grep -o -P ""backup_\d+"") bin/hbase backup create incremental file:/tmp/hbasebackups -t table1 bin/hbase backup history{code} * Output shows the incremental backup still includes table2, this should only be table1: {code:java} {ID=backup_1715000053763,Type=INCREMENTAL,Tables={table2,table1},State=COMPLETE,Start time=Mon May 06 14:54:14 CEST 2024,End time=Mon May 06 14:54:16 CEST 2024,Progress=100%} {ID=backup_1715000031407,Type=FULL,Tables={table1},State=COMPLETE,Start time=Mon May 06 14:53:52 CEST 2024,End time=Mon May 06 14:53:54 CEST 2024,Progress=100%} {code} PR will follow soon. (Edited: my original ticket included a stacktrace of an IllegalStateException from a PR for HBASE-28562)" Fix the error message in ReservoirSample's constructor,13579681,Resolved,Major,Fixed,17/May/24 14:43,18/May/24 09:08,, NPE for writer object access in AsyncFSWAL#closeWriter,13579460,Resolved,Major,Fixed,16/May/24 06:34,17/May/24 14:44,2.4.18,"Observed NPE during execution of some of the UT cases. Exception is happening in AbstractFSWAL#closeWriter when trying to put null writer object in inflightWALClosures map. Need to add null check for writer object in AsyncFSWAL#doShutdown function before its usage." Hide HFileScanner related methods in StoreFileReader,13578681,Resolved,Major,Fixed,09/May/24 03:02,17/May/24 14:27,, Remove deprecated methods in HFileScanner,13578680,Resolved,Major,Fixed,09/May/24 03:00,17/May/24 14:24,, Remove deprecated methods in thrift module,13578286,Resolved,Major,Fixed,06/May/24 14:01,17/May/24 14:23,, Backport HBASE-28174 to branch-2.4 and branch-2.5,13575892,Resolved,Major,Fixed,15/Apr/24 14:18,15/Apr/24 14:39,2.4.17,The changes are backwards compatible and the REST interface is super limited without them. Support native Cell format in REST server and client,13579458,Open,Major,,16/May/24 06:18,,,"REST currently uses its own (outdated) CellSetModel format for transferring cells. This is fine for XML and JSON, which are slow anyway and even slower handling byte arrays, and is expected to be used in cases where a simple client code which does not depend on the hbase java libraries is more important than raw performance. However, we perform the same marshalling and unmarshalling when we are using protobuf, which doesn't really add value, but eats up resources. We could add a new encoding for Results which uses the native cell format, by simply dumping the binary cell bytestreams into the REST response body. This should save a lot of resources on the server side, and would be either faster, or the same speed on the client. As an additional advantage, the resulting Cells would be of native HBase Cell type instead of the REST Cell type. " SSLContext not used for Kerberos auth negotiation in rest client,13577293,Resolved,Major,Duplicate,26/Apr/24 05:09,16/May/24 08:54,,"The included REST client now supports specifying a Trust store for SSL connections. However, the configured SSL library is not used when the Kerberos negotation is performed by the Hadoop library, which uses its own client. We need to set up the Hadoop auth process to use the same SSLContext." Backup manifest of full backup contains incomplete table list,13574971,Resolved,Major,Fixed,08/Apr/24 10:55,16/May/24 06:11,2.6.0,"Noticed that the {{BackupManifest#getTableNames}} is returning only a single table instead of the complete list of tables that were requested for the backup in case of a full backup, in case of an incremental backup the manifest table list seem complete. Checking the {{TableBackupClient#addManifest}} method shows why: * While looping over the included tables the manifest is stored per table and the comment mentions something about storing the manifest with the table directory: {code:java} // Since we have each table's backup in its own directory structure, // we'll store its manifest with the table directory. for (TableName table : backupInfo.getTables()) { manifest = new BackupManifest(backupInfo, table); ArrayList ancestors = backupManager.getAncestors(backupInfo, table); for (BackupImage image : ancestors) { manifest.addDependentImage(image); } if (type == BackupType.INCREMENTAL) { // We'll store the log timestamps for this table only in its manifest. Map> tableTimestampMap = new HashMap<>(); tableTimestampMap.put(table, backupInfo.getIncrTimestampMap().get(table)); manifest.setIncrTimestampMap(tableTimestampMap); ArrayList ancestorss = backupManager.getAncestors(backupInfo); for (BackupImage image : ancestorss) { manifest.addDependentImage(image); } } manifest.store(conf); }{code} * but the manifest path is based on the backup root dir and backup id, so it is not on a table directory level:  {code:java} Path manifestFilePath = new Path(HBackupFileSystem.getBackupPath(backupImage.getRootDir(), backupImage.getBackupId()), MANIFEST_FILE_NAME);{code} * so each call to {{manifest.store(conf)}} is just overwriting the same manifest file * for incremental backups the ""complete"" manifest is stored as well with {{manifest.store(conf)}} and using the exact same path, so that explains why it is correct for incremental backups: {code:java} // For incremental backup, we store a overall manifest in // /WALs/ // This is used when created the next incremental backup if (type == BackupType.INCREMENTAL) { manifest = new BackupManifest(backupInfo); // set the table region server start and end timestamps for incremental backup manifest.setIncrTimestampMap(backupInfo.getIncrTimestampMap()); ArrayList ancestors = backupManager.getAncestors(backupInfo); for (BackupImage image : ancestors) { manifest.addDependentImage(image); } manifest.store(conf); }{code} * the comment related to the manifest path being {{/WALs/}} is incorrect   I created a simple test that verifies this issue [^TestBackupManifest.java] , but no idea how to fix this. Perhaps only the overall manifest file should be stored on \{{/ }}level, but that goes against the comments here so not sure." Remove deprecated methods in TableDescriotorBuilder,13578690,Resolved,Major,Fixed,09/May/24 04:01,12/May/24 14:08,, Remove FirstKeyValueMatchingQualifiersFilter,13578678,Resolved,Major,Fixed,09/May/24 02:57,12/May/24 14:07,, Backport HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableRelativePath method,13578843,Resolved,Major,Fixed,10/May/24 06:47,12/May/24 15:23,2.6.0, "Add a new ""Promoting Release Candidate"" section to the book",13579101,Open,Major,,13/May/24 14:24,,,"Once we have a release candidate voted on and approved by the PMC, the steps for promoting the release artifacts are not obvious. We have, for example HBASE-24012, steps outlined by previous release managers. Let's make this less of a mystery." "Update ""Releasing Apache HBase"" section in the book to document `do-release.sh`",13579100,Open,Major,,13/May/24 14:23,,,Manually rolling release candidates is a thing of the past. Let's update this section of the book to describe how to use the automation in {{dev-support/create-release}} and throw out these old manual instructions. NPE after upgrade from 2.5.8 to 3.0.0,13578962,Open,Major,,11/May/24 22:42,,3.0.0,"When upgrade hbase cluster from 2.5.8 to 3.0.0 (commit: 516c89e8597fb6), I met the following NPE in master log. {code:java} 2024-05-11T02:17:47,293 ERROR [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] ipc.RpcServer: Unexpected throwable object  java.lang.NullPointerException: null         at org.apache.hadoop.hbase.master.MasterRpcServices.reportFileArchival(MasterRpcServices.java:2578) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:16463) ~[hbase-protocol-shaded-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:443) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT] 2024-05-11T02:17:47,326 ERROR [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] ipc.RpcServer: Unexpected throwable object  java.lang.NullPointerException: null         at org.apache.hadoop.hbase.master.MasterRpcServices.reportFileArchival(MasterRpcServices.java:2578) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:16463) ~[hbase-protocol-shaded-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:443) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT] 2024-05-11T02:17:47,337 ERROR [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=16000] ipc.RpcServer: Unexpected throwable object  java.lang.NullPointerException: null         at org.apache.hadoop.hbase.master.MasterRpcServices.reportFileArchival(MasterRpcServices.java:2578) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos$RegionServerStatusService$2.callBlockingMethod(RegionServerStatusProtos.java:16463) ~[hbase-protocol-shaded-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:443) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) ~[hbase-server-3.0.0-beta-2-SNAPSHOT.jar:3.0.0-beta-2-SNAPSHOT]{code} h1. Reproduce This bug cannot be reproduced deterministically but it happens pretty frequently (10% to trigger with the following steps. 1. Start up 2.5.8 cluster with default configuration (1 HM, 2 RS, 1 HDFS) 2. Execute the commands in commands.txt 3. Stop the 2.5.8 cluster and upgrade to 3.0.0 cluster with default configuration (commit: 516c89e8597fb6, 1 HM, 2 RS, 1 HDFS)  The error message will occur in master log. I attached (1) commands to reproduce it (2) master log and (3) full error logs of all nodes." Remove deprecated fields in HBTU,13578284,Resolved,Major,Fixed,06/May/24 14:00,08/May/24 07:51,, Remove deprecated methods map reduce utils,13578285,Resolved,Major,Fixed,06/May/24 14:00,07/May/24 14:24,, Bump jinja2 from 3.1.3 to 3.1.4 in /dev-support/flaky-tests,13578429,Resolved,Major,Fixed,07/May/24 13:29,07/May/24 13:43,, Remove deprecated methods in RegionCoprocessorHost for 3.0.0,13574134,Resolved,Major,Fixed,01/Apr/24 09:34,06/May/24 08:10,, Remove ZKDataMigrator,13578188,Resolved,Major,Fixed,05/May/24 14:30,06/May/24 14:03,, Update compatibility report generator to ignore o.a.h.hbase.shaded packages,13578400,Open,Major,,07/May/24 08:47,,,"This is a small change that will make reviewing release candidates a little easier. Right now that compatibility report includes classes that we shade. So when we shaded upgrade 3rd party dependencies, they show up in this report as an incompatible change. Changes to these classes do not affect users so there's no reason to consider them wrt compatibility. We should update the reporting tool to exclude this package. For example, https://dist.apache.org/repos/dist/dev/hbase/2.6.0RC4/api_compare_2.5.0_to_2.6.0RC4.html#Binary_Removed" Race condition causes MetaRegionLocationCache to never set watcher to populate meta location,13578210,Resolved,Major,Fixed,06/May/24 00:57,06/May/24 08:11,2.5.8,"{{ZKWatcher#getMetaReplicaNodesAndWatchChildren()}} attempts to set a a watch on the base /hbase znode children using {{ZKUtil.listChildrenAndWatchForNewChildren()}}, but if the node does not exist, no watch gets set. We've seen this in the test container Trino uses over at [trino/21569|https://github.com/trinodb/trino/pull/21569] , where ZK, master, and RS are all run in the same container. The fix is to throw if the node does not exist so that {{MetaRegionLocationCache}} can retry until the node gets created." Change the deprecation cycle for HasMasterServices and HasRegionServerServices,13574132,Resolved,Major,Fixed,01/Apr/24 09:32,06/May/24 07:46,,"The plan is to integration all core coprocessors into core but actually the work is not fully done in 3.0.0, like AccessController, quotas, visibility labels, bulk load replication, TokenProvider, etc. So we are not likely to remove them in 3.0.0, and since these are all internal, we are free to remove it any releases." Use standard ConnectionRegistry and Client API to get region server list in in replication,13575762,Resolved,Major,Fixed,14/Apr/24 11:46,01/May/24 14:10,,"This is for allowing specify cluster key without zookeeper in replication peer config. For now, we will set a watcher on zookeeper for fetching the region server list for the remote cluster, this means we must know the zookeeper address of the remote cluster. This should be fixed as we do not want to leak the zookeeper outside the cluster itself." Fix constructors for sub classes of Connection,13577565,Resolved,Major,Fixed,29/Apr/24 10:33,01/May/24 13:29,,"We still have some testing classes which implement Connection but do not have constructors with ConnectionRegistry as parameter. This lead to some test failures on branch-2.x, but we'd better also fix them on master as well." Implement a region server level configuration to enable/disable data-tiering,13576373,Resolved,Major,Fixed,18/Apr/24 12:43,02/May/24 08:25,,"Provide the user with the ability to enable and disable the data tiering feature. The time-based data tiering is applicable to a specific set of use cases which write date based records and access to recently written data. The feature, in general, should be avoided for use cases which are not dependent on the date-based reads and writes as the code flows which enable data temperature checks can induce performance regressions. This Jira is added to track the functionality to optionally enable region-server wide configuration to disable or enable the feature. Thanks, Janardhan" Split procedure rollback can leave parent region state in SPLITTING after completion,13576231,Resolved,Major,Fixed,17/Apr/24 15:42,30/Apr/24 15:15,2.5.8,"Depending on where the split procedure fails, SplitTableRegionProcedure rollback can leave the parent region's in memory RegionStateNode in SPLITTING after rollback is complete, when the parent region is still online on the assigned region server and according to meta. This leaves active HMaster believing that the parent region is offline according to its RegionStates, and causes subsequent procedures that require the region to be online like merge/split/move to fail to start. One workaround is to restart active HMaster to reset the in memory record of region states.  Two example scenarios where this can happen: * If we get to SPLIT_TABLE_REGION_CLOSE_PARENT_REGION and the parent region has a replica which is in transition, the unassign procedure in that step is never created/rolled back and we are left with the parent region state in splitting. * If region quotas are enabled and a split is run for a region whose namespace is at its maximum region quota limit we will fail in SPLIT_TABLE_REGION_PRE_OPERATION with QuotaExceededException and we are left with the parent region state in splitting The region replica case is demonstrated in TestSplitTableRegionProcedure.testRollbackForSplitTableRegionWithReplica. To reproduce the region quota case in HBase shell: {code:java} > create_namespace 'test_ns', {'hbase.namespace.quota.maxregions'=> 2} > create 'test_ns:test_table', 'f1', {NUMREGIONS => 2, SPLITALGO => 'UniformSplit'} > region_a = > region_b = > split region_a, 'x' # HMaster will report: pid=405, state=ROLLEDBACK, exception=org.apache.hadoop.hbase.quotas.QuotaExceededException via master-split-regions:org.apache.hadoop.hbase.quotas.QuotaExceededException: Region split not possible for : as quota limits are exceeded ; SplitTableRegionProcedure table=test_ns:test_table, parent=... > merge_region region_a, region_b ERROR: org.apache.hadoop.hbase.exceptions.MergeRegionException: org.apache.hadoop.hbase.client.DoNotRetryRegionException: is not OPEN; state=SPLITTING > stop_master # trigger hmaster failover > merge_region region_a, region_b # merge now succeeds {code}" Use a single get call in REST multiget endpoint,13575801,Resolved,Major,Fixed,15/Apr/24 05:15,30/Apr/24 11:30,,"The REST multiget endpoint currently issues a separate HBase GET operation for each key. Use the method that accepts a list of keys instead. That should be faster." ThriftConnection does not need ConnectionRegistry,13577507,Resolved,Major,Duplicate,29/Apr/24 01:23,01/May/24 13:29,, Provide working benchmark tool for REST server,13577022,Open,Major,,24/Apr/24 07:50,,,"This is an umbrella ticket for the individual changes. The goal is to be able to performance test the rest server performance either directly or via Knox or other proxies / load balancers, and compare this with the results when going via the native client." Region quotas: Split/merge procedure rollback can lead to inaccurate account of region counts,13577643,Open,Major,,29/Apr/24 23:17,,3.0.0-beta-2,"When region quotas are enabled, HMaster keeps an in memory account of region counts through NamespaceStateManager. Region counts in NamespaceStateManager are incremented/decremented at the beginning stages of split/merge procedures, in SPLIT_TABLE_REGION_PRE_OPERATION/MERGE_TABLE_REGIONS_PRE_MERGE_OPERATION before any region is offlined. If the split/merge procedure gets rolled back after the region count change in NamespaceStateManager is made, the split/merge procedure rollback does not revert the region count change in NamespaceStateManager to reflect that the expected split/merge never succeeded. This leaves NamespaceStateManager with an inaccurate account of the number of regions, believing that there are more/less regions than actually exist.  " Region quotas: Multi-region merge causes inaccurate accounting of region counts,13577639,Open,Major,,29/Apr/24 22:31,,3.0.0-beta-2,"There is support for merging more than two regions in one merge procedure with multi-region merge, but if region quotas are enabled, [NamespaceAuditor assumes that every merge is a two region merge|https://github.com/apache/hbase/blob/branch-3/hbase-server/src/main/java/org/apache/hadoop/hbase/namespace/NamespaceAuditor.java#L128-L129]. This causes an inaccurate in memory accounting of region counts in NamespaceStateManager, leading MasterQuotaManager to believe there are more regions than actually exist if multi-region merge is used.  To demonstrate the issue: 1. Start with a table with 3 regions in a namespace with a region quota limit of 3 2. Merge all 3 regions leaving 1 region, NamespaceAuditor assumed it was a 2 region merge and believes the number of regions to be 2. 3. Split a region, number of regions is now 2, and NamespaceAuditor believe it to be 3. 4. Attempt another region split, which will fail because NamespaceAuditor believes the ns to be at its region limit of 3 when there are actually only 2 regions. " Reverse scan with tags throws ArrayIndexOutOfBoundsException with DBE,13574373,Resolved,Major,Fixed,03/Apr/24 04:20,28/Apr/24 15:20,,"Facing ArrayIndexOutOfBoundsException when performing reverse scan on a table with 30K+ records in single hfile. Exception is happening  when block changes during seekBefore call. {code:java} Caused by: java.lang.ArrayIndexOutOfBoundsException     at org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray(ByteBufferUtils.java:1326)     at org.apache.hadoop.hbase.nio.SingleByteBuff.get(SingleByteBuff.java:213)     at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decode(DiffKeyDeltaEncoder.java:431)     at org.apache.hadoop.hbase.io.encoding.DiffKeyDeltaEncoder$DiffSeekerStateBufferedEncodedSeeker.decodeNext(DiffKeyDeltaEncoder.java:502)     at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.seekToKeyInBlock(BufferedDataBlockEncoder.java:1012)     at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$EncodedScanner.loadBlockAndSeekToKey(HFileReaderImpl.java:1605)     at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekBefore(HFileReaderImpl.java:719)     at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekBeforeAndSaveKeyToPreviousRow(StoreFileScanner.java:645)     at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekToPreviousRowWithoutHint(StoreFileScanner.java:570)     at org.apache.hadoop.hbase.regionserver.StoreFileScanner.seekToPreviousRow(StoreFileScanner.java:506)     at org.apache.hadoop.hbase.regionserver.ReversedKeyValueHeap.next(ReversedKeyValueHeap.java:126)     at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:693)     at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:151){code}   Steps to reproduce: Create a table with DataBlockEncoding.DIFF and block size as 1024, write some 30K+ puts with setTTL, then do a reverse scan. {code:java} @Test public void testReverseScanWithDBEWhenCurrentBlockUpdates() throws IOException { byte[] family = Bytes.toBytes(""0""); Configuration conf = new Configuration(TEST_UTIL.getConfiguration()); conf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 1); try (Connection connection = ConnectionFactory.createConnection(conf)) { testReverseScanWithDBE(connection, DataBlockEncoding.DIFF, family, 1024, 30000); for (DataBlockEncoding encoding : DataBlockEncoding.values()) { testReverseScanWithDBE(connection, encoding, family, 1024, 30000); } } } private void testReverseScanWithDBE(Connection conn, DataBlockEncoding encoding, byte[] family, int blockSize, int maxRows) throws IOException { LOG.info(""Running test with DBE={}"", encoding); TableName tableName = TableName.valueOf(TEST_NAME.getMethodName() + ""-"" + encoding); TEST_UTIL.createTable(TableDescriptorBuilder.newBuilder(tableName) .setColumnFamily( ColumnFamilyDescriptorBuilder.newBuilder(family).setDataBlockEncoding(encoding).setBlocksize(blockSize).build()) .build(), null); Table table = conn.getTable(tableName); byte[] val1 = new byte[10]; byte[] val2 = new byte[10]; Bytes.random(val1); Bytes.random(val2); for (int i = 0; i < maxRows; i++) { table.put(new Put(Bytes.toBytes(i)).addColumn(family, Bytes.toBytes(1), val1) .addColumn(family, Bytes.toBytes(2), val2).setTTL(600_000)); } TEST_UTIL.flush(table.getName()); Scan scan = new Scan(); scan.setReversed(true); try (ResultScanner scanner = table.getScanner(scan)) { for (int i = maxRows - 1; i >= 0; i--) { Result row = scanner.next(); assertEquals(2, row.size()); Cell cell1 = row.getColumnLatestCell(family, Bytes.toBytes(1)); assertTrue(CellUtil.matchingRows(cell1, Bytes.toBytes(i))); assertTrue(CellUtil.matchingValue(cell1, val1)); Cell cell2 = row.getColumnLatestCell(family, Bytes.toBytes(2)); assertTrue(CellUtil.matchingRows(cell2, Bytes.toBytes(i))); assertTrue(CellUtil.matchingValue(cell2, val2)); } } } {code}   HBASE-27580 has fixed the issue for seekBefore in rewind function flow, but similar change is required in setCurrentBlock function flow also." Upgrade jline to version 3.x.,13577546,Open,Major,,29/Apr/24 08:24,,,Need to upgrade jline version to 3.x as 2.x is EOL Use ZKClientConfig instead of system properties when setting zookeeper configurations,13576156,Resolved,Major,Fixed,17/Apr/24 07:08,23/Apr/24 15:11,,"In HBASE-28340, we allow loading zookeeper configurations from hbase configurations, but then we use system properties to pass these parameters when creating zookeeper client. For replication, we may want to use different zookeeper configurations comparing to the ones we use for starting this hbase cluster, so using system properties to pass these parameters is not suitable then. We should make use of ZKClientConfig to pass these flags." Bump up bouncycastle dependency from 1.76 to 1.78,13577191,Resolved,Major,Fixed,25/Apr/24 10:12,26/Apr/24 07:24,,"org.bouncycastle : bcprov-jdk18on : 1.76 to be upgraded to latest  org.bouncycastle : bcprov-jdk18on : 1.78 Refer [link org.bouncycastle|https://security.snyk.io/package/maven/org.bouncycastle:bcprov-debug-jdk18on]" Update error prone to 2.26.1,13575338,Resolved,Major,Fixed,10/Apr/24 11:21,26/Apr/24 07:02,, Allow specifying a filter for the REST multiget endpoint,13575658,Resolved,Major,Fixed,12/Apr/24 15:28,25/Apr/24 14:04,,"The native HBase API allows specifying Filters for get operations. The REST interface does not currently expose this functionality. Add a parameter to the multiget enpoint to allow specifying filters. " Make properties dynamically configured,13575656,Resolved,Major,Fixed,12/Apr/24 15:15,25/Apr/24 10:47,,"Make following properties dynamically configured,    hbase.rs.evictblocksonclose   hbase.rs.cacheblocksonwrite   hbase.block.data.cacheonread for use case scenarios where configuring them dynamically would help in achieving better throughput." Adjust BlockCacheKey to use the file path instead of file name.,13576150,Resolved,Major,Won't Do,17/Apr/24 06:31,25/Apr/24 06:56,,"The time-based priority eviction policy relies on the presence of path in the BlockCacheKey to fetch the required metadata to check data hotness and decide whether or not to retain the block in the bucket cache. Hence, the constructor of BlockCacheKey is adjusted to take the file path as the input parameter. The code paths that create the blockCacheKey and also the unit tests need to be adjusted to pass the path instead of file name.  " Allow users implement and register ConnectionRegistry by themselves,13577057,Open,Major,,24/Apr/24 11:33,,,"We use ServiceLoader to load the ConnectionRegistryURIFactory, so it is possible for users to implement their own ConnectionRegistry and ConnectionRegistryURIFactory, but we need to change the IA annotation for these two classes, maybe a new type of IA.LimitedPrivate." Multiple issues preventing starting org.apache.hadoop.hbase.rest.PerformanceEvaluation,13576751,Open,Major,,22/Apr/24 12:07,,,"I am trying to run org.apache.hadoop.hbase.rest.PerformanceEvaluation. It cannot connect to the ZK quorum specified in hbase-site.xml. It implements the Configurable interface incorrectly. Fixing the Configurable implementation results in connecing to ZK properly. --host option does not work because it conflicts with --h for help" org.apache.hadoop.hbase.rest.PerformanceEvaluation does not evaluate REST performance,13576778,Open,Major,,22/Apr/24 14:43,,,"org.apache.hadoop.hbase.rest.PerformanceEvaluation only uses the REST interface for Admin tasks like creating tables. All data access is done via the native RPC client, which makes the whole tool a big red herring." Worker thread gets stuck in an infinite retry when TRUNCATE command runs into RowTooBigException,13576968,Open,Major,,23/Apr/24 18:40,,2.4.17,"Hi, I am testing the reliability of HBase to see if it could work normally or properly handle exceptions under different configurations. When setting +hbase.table.max.rowsize+ to a relatively small size, create an empty table and then truncate it could get worker thread to get stuck in an infinite retry and generate massive logs. h1. Reproduce This bug can be reproduced determinstically with the following steps: 1. Set hbase.table.max.rowsize to a relatively small value: 745 hbase-site.xml {code:java}             hbase.table.max.rowsize         745     {code} 2. Start up HBase cluster 2.5.8 (1HM, 2RS) and execute the following commands from hbase shell {code:java} create 'uuid0f06811e5d11431fa9d4a543705b8747', {NAME => 'uuidad7c09870a6346598bbca56cb97c4c67', VERSIONS => 4, COMPRESSION => 'GZ', BLOOMFILTER => 'NONE', IN_MEMORY => 'false'}, {NAME => 'uuidd2c5ad4df7b844afb4c2ac92b224dedd', VERSIONS => 4, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'true'}, {NAME => 'uuid6e21f5f492eb4b9ba0e431b9a0666dae', VERSIONS => 4, COMPRESSION => 'NONE', BLOOMFILTER => 'NONE', IN_MEMORY => 'true'}, {NAME => 'uuidfb110629fba44915956e41609b68ebe9', VERSIONS => 2, COMPRESSION => 'NONE', BLOOMFILTER => 'ROW', IN_MEMORY => 'false'}, {NAME => 'uuid4943640bf1f6425582ac9b3572d95964', VERSIONS => 4, COMPRESSION => 'GZ', BLOOMFILTER => 'ROWCOL', IN_MEMORY => 'false'} truncate 'uuid0f06811e5d11431fa9d4a543705b8747' {code} *truncate* command timeout after 10m. However, the PEWorker thread still gets stuck in an *infinite retry* and keep generating a massive WARN in HMaster logs {code:java} ➜  log git:(main) ✗ ls hbase--master-09e0b9e25e7c.log     hbase--master-09e0b9e25e7c.log.12  hbase--master-09e0b9e25e7c.log.16  hbase--master-09e0b9e25e7c.log.2   hbase--master-09e0b9e25e7c.log.5  hbase--master-09e0b9e25e7c.log.9   SecurityAuth.audit hbase--master-09e0b9e25e7c.log.1   hbase--master-09e0b9e25e7c.log.13  hbase--master-09e0b9e25e7c.log.17  hbase--master-09e0b9e25e7c.log.20  hbase--master-09e0b9e25e7c.log.6  hbase--master-09e0b9e25e7c.out hbase--master-09e0b9e25e7c.log.10  hbase--master-09e0b9e25e7c.log.14  hbase--master-09e0b9e25e7c.log.18  hbase--master-09e0b9e25e7c.log.3   hbase--master-09e0b9e25e7c.log.7  hbase--zookeeper-09e0b9e25e7c.log hbase--master-09e0b9e25e7c.log.11  hbase--master-09e0b9e25e7c.log.15  hbase--master-09e0b9e25e7c.log.19  hbase--master-09e0b9e25e7c.log.4   hbase--master-09e0b9e25e7c.log.8  hbase--zookeeper-09e0b9e25e7c.out {code} The logs contain the following repeated exceptions {code:java} 2024-04-23T02:52:16,144 WARN  [PEWorker-14] procedure.TruncateTableProcedure: Retriable error trying to truncate table=uuid0f06811e5d11431fa9d4a543705b8747 state=TRUNCATE_TABLE_CLEAR_FS_LAYOUT org.apache.hadoop.hbase.regionserver.RowTooBigException: org.apache.hadoop.hbase.regionserver.RowTooBigException: Max row size allowed: 745, but the row is bigger than that, the row info: uuid0f06811e5d11431fa9d4a543705b8747,,1713840709844.c03450373b32cba95a2dd3139f0a2201./info:state/1713840716052/Put/vlen=6/seqid=16, already have process row cells = 6, it belong to region = hbase:meta,,1.1588230740         at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:653)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:145)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.populateResult(RegionScannerImpl.java:342)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.nextInternal(RegionScannerImpl.java:513)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.nextRaw(RegionScannerImpl.java:278)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.next(RegionScannerImpl.java:256)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.next(RegionScannerImpl.java:243)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2654)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2577)         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45002)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:415)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82)        at sun.reflect.GeneratedConstructorAccessor30.newInstance(Unknown Source) ~[?:?]         at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:1.8.0_362]         at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[?:1.8.0_362]         at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:110) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:100) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:280) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:265) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:126) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:103) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.client.HTable.get(HTable.java:390) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.client.HTable.lambda$get$0(HTable.java:363) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[hbase-common-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.client.HTable.get(HTable.java:363) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.MetaTableAccessor.get(MetaTableAccessor.java:248) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.MetaTableAccessor.getRegionResult(MetaTableAccessor.java:344) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.MetaTableAccessor.getMergeRegions(MetaTableAccessor.java:374) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.master.procedure.DeleteTableProcedure.deleteFromFs(DeleteTableProcedure.java:283) ~[hbase-server-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:103) ~[hbase-server-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.master.procedure.TruncateTableProcedure.executeFromState(TruncateTableProcedure.java:44) ~[hbase-server-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188) ~[hbase-procedure-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:942) ~[hbase-procedure-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1765) ~[hbase-procedure-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1443) ~[hbase-procedure-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:77) ~[hbase-procedure-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:2091) ~[hbase-procedure-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[hbase-common-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2118) ~[hbase-procedure-2.5.8.jar:2.5.8] Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException: org.apache.hadoop.hbase.regionserver.RowTooBigException: Max row size allowed: 745, but the row is bigger than that, the row info: uuid0f06811e5d11431fa9d4a543705b8747,,1713840709844.c03450373b32cba95a2dd3139f0a2201./info:state/1713840716052/Put/vlen=6/seqid=16, already have process row cells = 6, it belong to region = hbase:meta,,1.1588230740         at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:653)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:145)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.populateResult(RegionScannerImpl.java:342)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.nextInternal(RegionScannerImpl.java:513)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.nextRaw(RegionScannerImpl.java:278)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.next(RegionScannerImpl.java:256)         at org.apache.hadoop.hbase.regionserver.RegionScannerImpl.next(RegionScannerImpl.java:243)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2654)         at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2577)         at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45002)         at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:415)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102)         at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82)        at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:388) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:425) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:420) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.readResponse(NettyRpcDuplexHandler.java:199) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelRead(NettyRpcDuplexHandler.java:220) ~[hbase-client-2.5.8.jar:2.5.8]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:509) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:407) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[hbase-shaded-netty-4.1.5.jar:?]         at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[hbase-shaded-netty-4.1.5.jar:?]         at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_362] {code} I have attached the one example hmaster log. h1. Root Cause If decrease the length of the table name and cf name in the create table command, the truncate will work normally. This indicates that the symptom could be triggered if there's a table whose metadata size is larger than the max row size. E.g., using the default max row size value (1GB), if create a table with a large metadata size (lots of columns with long names), it might still cause the similar infinite loop problem.  This usually won't happen with the default configurations. However, users are more likely to run into this exception if they set the max row size to a smaller value and create a large table. h1. Fix A better error handler might work * This infinite loop could be avoided by adding a retry limit if the truncate command keeps running into RowTooBigException. I am still examining the exact root cause. I could try to provide a patch. Any suggestions are welcome. Thank you." Re-use ZstdDecompressCtx/ZstdCompressCtx for performance,13574698,Resolved,Major,Fixed,04/Apr/24 19:59,09/Apr/24 11:21,,"The zstd documentation [recommends|https://facebook.github.io/zstd/zstd_manual.html#Chapter4] re-using context objects when possible, because their creation has some expense. They can be more cheaply reset than re-created. In {{ZstdDecompressor}} and {{{}ZstdCompressor{}}}, we create a new context object for every call to {{decompress()}} and {{{}compress(){}}}. In CPU profiles I've taken at my company, the constructor of {{ZstdDecompressCtx}} can sometimes represent 10-25% of the time spent in zstd decompression, which itself is 5-10% of a RegionServer's total CPU time. Avoiding this performance penalty won't lead to any massive performance boost, but is a nice little win." Refactoring Data Tiering Management for Improved Extensibility and Maintainability,13576734,Open,Major,,22/Apr/24 10:24,,,"This Jira focuses on refactoring the Data Tiering Management module to enhance modularity and remove the Singleton pattern. The objective is to restructure the codebase for better separation of concerns and increased flexibility. This includes migrating away from the Singleton pattern in favor of a more modular approach, enabling easier integration of new data tiering types and handlers." Missing fields in Get.toJSON,13574902,Resolved,Major,Fixed,07/Apr/24 08:34,21/Apr/24 14:26,,"Missing fields in Get.toJSON conversion. |Class|Whether Mapped to JSON?|add to json?| |Get| | | |row|Yes| | |maxVersions|Yes| | |cacheBlocks|Yes| | |storeLimit|No|Yes| |storeOffset|No|Yes| |tr|Yes| | |checkExistenceOnly|No|Yes| |familyMap|Yes| | | | | | |Query| | | |filter|Yes| | |targetReplicaId|No|Yes| |consistency|No|Yes| |colFamTimeRangeMap|No|Yes| |loadColumnFamiliesOnDemand|No|Yes| | | | | |OperationWithAttributes| | | |attributes|partial, only ID attribute is set|Yes| |priority|No|Yes|" RegionServer abort when max sequence id wrong,13576700,Open,Major,,22/Apr/24 08:01,,2.2.3,"When we disable a table, some region close failed because max sequence id is less than the old max sequence id, then RS abort...Then the region close success on another RS.. we just use bulkload...is it releated? -------------------------------------------------------------------------------------------- 2024-04-20 23:44:20,611 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/4f43f6cf569643da8ecc140668fa726e is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:44:20,645 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/4f43f6cf569643da8ecc140668fa726e to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/dc30be37cbd0ddee2f49712c55fd36cd/.tmp/6f7e97f2e3994881a6e04b36759f495e | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:44:20,648 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/dc30be37cbd0ddee2f49712c55fd36cd/.tmp/6f7e97f2e3994881a6e04b36759f495e into dc30be37cbd0ddee2f49712c55fd36cd/info as viewfs://ClusterX/hbase/data/default/boss20240420/dc30be37cbd0ddee2f49712c55fd36cd/info/3946dc15ea1c49b582a2ed175fe12ec3_SeqId_26_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:44:20,664 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/dc30be37cbd0ddee2f49712c55fd36cd/info/3946dc15ea1c49b582a2ed175fe12ec3_SeqId_26_ into dc30be37cbd0ddee2f49712c55fd36cd/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:44:20,664 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/dc30be37cbd0ddee2f49712c55fd36cd/.tmp/6f7e97f2e3994881a6e04b36759f495e into dc30be37cbd0ddee2f49712c55fd36cd/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/dc30be37cbd0ddee2f49712c55fd36cd/info/3946dc15ea1c49b582a2ed175fe12ec3_SeqId_26_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:44:23,592 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Validating hfile at viewfs://ClusterX/tenant/hw_cdr/dsttab/load_20240420232000/boss20240420/info/a97bb2bfcb5244279bcedbe20ec8322b for inclusion in b3d102e51ca3b78a1078580ed8a002de/info | org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:817) 2024-04-20 23:44:23,669 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/a97bb2bfcb5244279bcedbe20ec8322b is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:44:23,743 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/a97bb2bfcb5244279bcedbe20ec8322b to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/b3d102e51ca3b78a1078580ed8a002de/.tmp/f40ec16d10ab4474ace7af41d9126aa0 | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:44:23,747 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/b3d102e51ca3b78a1078580ed8a002de/.tmp/f40ec16d10ab4474ace7af41d9126aa0 into b3d102e51ca3b78a1078580ed8a002de/info as viewfs://ClusterX/hbase/data/default/boss20240420/b3d102e51ca3b78a1078580ed8a002de/info/7cfcf858a6b34bd1b9d47ccce5dde9e4_SeqId_41_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:44:23,760 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/b3d102e51ca3b78a1078580ed8a002de/info/7cfcf858a6b34bd1b9d47ccce5dde9e4_SeqId_41_ into b3d102e51ca3b78a1078580ed8a002de/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:44:23,760 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/b3d102e51ca3b78a1078580ed8a002de/.tmp/f40ec16d10ab4474ace7af41d9126aa0 into b3d102e51ca3b78a1078580ed8a002de/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/b3d102e51ca3b78a1078580ed8a002de/info/7cfcf858a6b34bd1b9d47ccce5dde9e4_SeqId_41_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:44:25,443 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Validating hfile at viewfs://ClusterX/tenant/hw_cdr/dsttab/load_20240420232000/boss20240420/info/4dac6fe338ed45028dd4ac859d02c386 for inclusion in eec5518fe33d8c6b5f99f66e20bf782d/info | org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:817) 2024-04-20 23:44:25,720 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/4dac6fe338ed45028dd4ac859d02c386 is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:44:25,798 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/4dac6fe338ed45028dd4ac859d02c386 to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/eec5518fe33d8c6b5f99f66e20bf782d/.tmp/09cb80cf4b5d47b78ddf31eafce4f5f6 | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:44:25,802 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/eec5518fe33d8c6b5f99f66e20bf782d/.tmp/09cb80cf4b5d47b78ddf31eafce4f5f6 into eec5518fe33d8c6b5f99f66e20bf782d/info as viewfs://ClusterX/hbase/data/default/boss20240420/eec5518fe33d8c6b5f99f66e20bf782d/info/6d674b96ccec40339a4a1f486a65c4a7_SeqId_20_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:44:25,823 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/eec5518fe33d8c6b5f99f66e20bf782d/info/6d674b96ccec40339a4a1f486a65c4a7_SeqId_20_ into eec5518fe33d8c6b5f99f66e20bf782d/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:44:25,823 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/eec5518fe33d8c6b5f99f66e20bf782d/.tmp/09cb80cf4b5d47b78ddf31eafce4f5f6 into eec5518fe33d8c6b5f99f66e20bf782d/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/eec5518fe33d8c6b5f99f66e20bf782d/info/6d674b96ccec40339a4a1f486a65c4a7_SeqId_20_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:44:28,837 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Validating hfile at viewfs://ClusterX/tenant/hw_cdr/dsttab/load_20240420232000/boss20240420/info/ef44caa4e05440569f76a05d351e4a62 for inclusion in 21d5667a8bcd59088ae865f5d9660283/info | org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:817) 2024-04-20 23:44:28,950 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/ef44caa4e05440569f76a05d351e4a62 is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:44:29,007 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/ef44caa4e05440569f76a05d351e4a62 to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/21d5667a8bcd59088ae865f5d9660283/.tmp/1be6287d04084bf48afd8eb0e0e63a6e | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:44:29,010 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/21d5667a8bcd59088ae865f5d9660283/.tmp/1be6287d04084bf48afd8eb0e0e63a6e into 21d5667a8bcd59088ae865f5d9660283/info as viewfs://ClusterX/hbase/data/default/boss20240420/21d5667a8bcd59088ae865f5d9660283/info/fb872c3f89e543c6b54fcb54898112d4_SeqId_16_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:44:29,063 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Validating hfile at viewfs://ClusterX/tenant/hw_cdr/dsttab/load_20240420232000/boss20240420/info/6fdde06815624c5095d39e7b98cc81c7 for inclusion in 0bf7d39f1708c5e50444c810f60d3f9f/info | org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:817) 2024-04-20 23:44:29,066 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/21d5667a8bcd59088ae865f5d9660283/info/fb872c3f89e543c6b54fcb54898112d4_SeqId_16_ into 21d5667a8bcd59088ae865f5d9660283/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:44:29,066 | INFO  | RpcServer.default.FPBQ.Fifo.handler=483,queue=33,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/21d5667a8bcd59088ae865f5d9660283/.tmp/1be6287d04084bf48afd8eb0e0e63a6e into 21d5667a8bcd59088ae865f5d9660283/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/21d5667a8bcd59088ae865f5d9660283/info/fb872c3f89e543c6b54fcb54898112d4_SeqId_16_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:44:29,116 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/6fdde06815624c5095d39e7b98cc81c7 is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:44:29,182 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/6fdde06815624c5095d39e7b98cc81c7 to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/0bf7d39f1708c5e50444c810f60d3f9f/.tmp/0b6350c99fca4b06ba873f49a1ddb835 | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:44:29,185 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/0bf7d39f1708c5e50444c810f60d3f9f/.tmp/0b6350c99fca4b06ba873f49a1ddb835 into 0bf7d39f1708c5e50444c810f60d3f9f/info as viewfs://ClusterX/hbase/data/default/boss20240420/0bf7d39f1708c5e50444c810f60d3f9f/info/2ae95a60b63541538939adfef0ab2190_SeqId_34_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:44:29,201 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/0bf7d39f1708c5e50444c810f60d3f9f/info/2ae95a60b63541538939adfef0ab2190_SeqId_34_ into 0bf7d39f1708c5e50444c810f60d3f9f/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:44:29,201 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/0bf7d39f1708c5e50444c810f60d3f9f/.tmp/0b6350c99fca4b06ba873f49a1ddb835 into 0bf7d39f1708c5e50444c810f60d3f9f/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/0bf7d39f1708c5e50444c810f60d3f9f/info/2ae95a60b63541538939adfef0ab2190_SeqId_34_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:44:31,993 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Validating hfile at viewfs://ClusterX/tenant/hw_cdr/dsttab/load_20240420232000/boss20240420/info/f886ffd9d3d44804bcf164ff14ff24a6 for inclusion in bf26eb5268636a04d990e9a99da516fa/info | org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:817) 2024-04-20 23:44:32,071 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/f886ffd9d3d44804bcf164ff14ff24a6 is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:44:32,179 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__t20amapi48eb4ce0k0t80jatvnnhpm5rohaj26a5rdsp0s7kifokcdd32ko89u7n/info/f886ffd9d3d44804bcf164ff14ff24a6 to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/bf26eb5268636a04d990e9a99da516fa/.tmp/bb3afca8b1c34f30a44fbc23416e43c7 | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:44:32,182 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/bf26eb5268636a04d990e9a99da516fa/.tmp/bb3afca8b1c34f30a44fbc23416e43c7 into bf26eb5268636a04d990e9a99da516fa/info as viewfs://ClusterX/hbase/data/default/boss20240420/bf26eb5268636a04d990e9a99da516fa/info/e7cafc760651400f95b9929bc4dfe09f_SeqId_24_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:44:32,194 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/bf26eb5268636a04d990e9a99da516fa/info/e7cafc760651400f95b9929bc4dfe09f_SeqId_24_ into bf26eb5268636a04d990e9a99da516fa/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:44:32,194 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/bf26eb5268636a04d990e9a99da516fa/.tmp/bb3afca8b1c34f30a44fbc23416e43c7 into bf26eb5268636a04d990e9a99da516fa/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/bf26eb5268636a04d990e9a99da516fa/info/e7cafc760651400f95b9929bc4dfe09f_SeqId_24_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:44:32,643 | INFO  | LruBlockCacheStatsExecutor | totalSize=810.84 MB, freeSize=2.37 GB, max=3.16 GB, blockCount=6432, accesses=2141008613, hits=42674300, hitRatio=1.99%, , cachingAccesses=42757862, cachingHits=42611408, cachingHitsRatio=99.66%, evictions=863177, evicted=0, evictedPerRun=0.0 | org.apache.hadoop.hbase.io.hfile.LruBlockCache.logStats(LruBlockCache.java:940) 2024-04-20 23:44:32,967 | INFO  | BucketCacheStatsExecutor | failedBlockAdditions=0, totalSize=2.00 GB, freeSize=2.00 GB, usedSize=1.60 MB, cacheSize=1.55 MB, accesses=2103504114, hits=59423, IOhitsPerSecond=0, IOTimePerHit=NaN, hitRatio=0.00%, cachingAccesses=290936, cachingHits=946, cachingHitsRatio=0.33%, evictions=49, evicted=289802, evictedPerRun=5914.326530612245 | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.logStats(BucketCache.java:637) 2024-04-20 23:44:35,020 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch, finalDestination=hbaseRegional.async.summary.batch.log4j, interval=01:02.099 minutes, events=18, succcessCount=8, totalEvents=10351899, totalSuccessCount=1046226 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:44:38,469 | INFO  | p1tdhdpdn-v-7:21302Replication Statistics #0 | Global stats: WAL Edits Buffer Used=0B, Limit=268435456B  | org.apache.hadoop.hbase.replication.regionserver.Replication$ReplicationStatisticsTask.printStats(Replication.java:241) 2024-04-20 23:45:35,922 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch, finalDestination=hbaseRegional.async.summary.batch.log4j, interval=01:00.902 minutes, events=2, succcessCount=2, totalEvents=10351901, totalSuccessCount=1046228 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:45:52,951 | INFO  | HBase-Metrics2-1 | Stopping HBase metrics system... | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:210) 2024-04-20 23:45:52,958 | INFO  | HBase-Metrics2-1 | HBase metrics system stopped. | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:216) 2024-04-20 23:45:53,459 | WARN  | HBase-Metrics2-1 | Cannot locate configuration: tried hadoop-metrics2-hbase.properties,hadoop-metrics2.properties | org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:133) 2024-04-20 23:45:53,459 | INFO  | HBase-Metrics2-1 | Scheduled Metric snapshot period at 10 second(s). | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.startTimer(MetricsSystemImpl.java:378) 2024-04-20 23:45:53,460 | INFO  | HBase-Metrics2-1 | HBase metrics system started | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:191) 2024-04-20 23:47:38,739 | INFO  | RpcServer.default.FPBQ.Fifo.handler=415,queue=15,port=21302 | Chore [ScheduledChore: Name: QuotaRefresherChore Period: 300000 Unit: MILLISECONDS] is enabled. | org.apache.hadoop.hbase.ChoreService.scheduleChore(ChoreService.java:157) 2024-04-20 23:47:41,926 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch.log4j, interval=03:30.005 minutes, events=10, succcessCount=10, totalEvents=1046228, totalSuccessCount=1046228 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:48:36,094 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch, finalDestination=hbaseRegional.async.summary.batch.log4j, interval=01:00.169 minutes, events=3787, succcessCount=896, totalEvents=10355688, totalSuccessCount=1047124 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:49:25,976 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Validating hfile at viewfs://ClusterX/tenant/hw_cdr/dsttab/load_20240420233000/boss20240420/info/6403649b9cff4e2e9a716edfb91eed02 for inclusion in 24b5f9451a7c43c78f510539ac3124b6/info | org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:817) 2024-04-20 23:49:26,330 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__npj0dvc9jt9shu2lknr23t8d0l9qu9v84rjc1atk9m69ludreffg4plgpjeo5jlb/info/6403649b9cff4e2e9a716edfb91eed02 is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:49:26,762 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__npj0dvc9jt9shu2lknr23t8d0l9qu9v84rjc1atk9m69ludreffg4plgpjeo5jlb/info/6403649b9cff4e2e9a716edfb91eed02 to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/24b5f9451a7c43c78f510539ac3124b6/.tmp/a3eb0160995742509ccd235ebfcfa281 | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:49:26,768 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/24b5f9451a7c43c78f510539ac3124b6/.tmp/a3eb0160995742509ccd235ebfcfa281 into 24b5f9451a7c43c78f510539ac3124b6/info as viewfs://ClusterX/hbase/data/default/boss20240420/24b5f9451a7c43c78f510539ac3124b6/info/775e33b5b20242f1821c8b52d9b93ddf_SeqId_16_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:49:26,782 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/24b5f9451a7c43c78f510539ac3124b6/info/775e33b5b20242f1821c8b52d9b93ddf_SeqId_16_ into 24b5f9451a7c43c78f510539ac3124b6/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:49:26,782 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/24b5f9451a7c43c78f510539ac3124b6/.tmp/a3eb0160995742509ccd235ebfcfa281 into 24b5f9451a7c43c78f510539ac3124b6/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/24b5f9451a7c43c78f510539ac3124b6/info/775e33b5b20242f1821c8b52d9b93ddf_SeqId_16_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:49:27,148 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Validating hfile at viewfs://ClusterX/tenant/hw_cdr/dsttab/load_20240420233000/boss20240420/info/474cd88557de4a999c14173dd65c8817 for inclusion in 281284cc6ea724c51c83ce23e5249f7b/info | org.apache.hadoop.hbase.regionserver.HStore.assertBulkLoadHFileOk(HStore.java:817) 2024-04-20 23:49:27,219 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Bulk-load file hdfs://hacluster/hbase/staging/cdr__boss20240420__npj0dvc9jt9shu2lknr23t8d0l9qu9v84rjc1atk9m69ludreffg4plgpjeo5jlb/info/474cd88557de4a999c14173dd65c8817 is on different filesystem than the destination store. Copying file over to destination filesystem. | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:540) 2024-04-20 23:49:27,257 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Copied hdfs://hacluster/hbase/staging/cdr__boss20240420__npj0dvc9jt9shu2lknr23t8d0l9qu9v84rjc1atk9m69ludreffg4plgpjeo5jlb/info/474cd88557de4a999c14173dd65c8817 to temporary path on destination filesystem: viewfs://ClusterX/hbase/data/default/boss20240420/281284cc6ea724c51c83ce23e5249f7b/.tmp/7d352cb6f77047e9a39bc35379f70a92 | org.apache.hadoop.hbase.regionserver.HRegionFileSystem.bulkLoadStoreFile(HRegionFileSystem.java:544) 2024-04-20 23:49:27,260 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/281284cc6ea724c51c83ce23e5249f7b/.tmp/7d352cb6f77047e9a39bc35379f70a92 into 281284cc6ea724c51c83ce23e5249f7b/info as viewfs://ClusterX/hbase/data/default/boss20240420/281284cc6ea724c51c83ce23e5249f7b/info/8fb058fa1e4c48fb862e559f873a1390_SeqId_32_ - updating store file list. | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:908) 2024-04-20 23:49:27,276 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Loaded HFile viewfs://ClusterX/hbase/data/default/boss20240420/281284cc6ea724c51c83ce23e5249f7b/info/8fb058fa1e4c48fb862e559f873a1390_SeqId_32_ into 281284cc6ea724c51c83ce23e5249f7b/info | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:942) 2024-04-20 23:49:27,276 | INFO  | RpcServer.default.FPBQ.Fifo.handler=301,queue=1,port=21302 | Successfully loaded viewfs://ClusterX/hbase/data/default/boss20240420/281284cc6ea724c51c83ce23e5249f7b/.tmp/7d352cb6f77047e9a39bc35379f70a92 into 281284cc6ea724c51c83ce23e5249f7b/info (new location: viewfs://ClusterX/hbase/data/default/boss20240420/281284cc6ea724c51c83ce23e5249f7b/info/8fb058fa1e4c48fb862e559f873a1390_SeqId_32_) | org.apache.hadoop.hbase.regionserver.HStore.bulkLoadHFile(HStore.java:914) 2024-04-20 23:49:27,417 | INFO  | regionserver/p1tdhdpdn-v-7:21302.Chore.11 | MemstoreFlusherChore requesting flush of boss20240405,H3020209~,1712160114717.4e7bdeeb9b222b113307199da2810e18. because 4e7bdeeb9b222b113307199da2810e18/info has an old edit so flush to free WALs after random delay 239909 ms | org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemStoreFlusher.chore(HRegionServer.java:2059) 2024-04-20 23:49:30,094 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch.log4j, interval=01:48.168 minutes, events=896, succcessCount=896, totalEvents=1047124, totalSuccessCount=1047124 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:49:32,643 | INFO  | LruBlockCacheStatsExecutor | totalSize=811.85 MB, freeSize=2.37 GB, max=3.16 GB, blockCount=6440, accesses=2141096719, hits=42676155, hitRatio=1.99%, , cachingAccesses=42759717, cachingHits=42613255, cachingHitsRatio=99.66%, evictions=863207, evicted=0, evictedPerRun=0.0 | org.apache.hadoop.hbase.io.hfile.LruBlockCache.logStats(LruBlockCache.java:940) 2024-04-20 23:49:32,967 | INFO  | BucketCacheStatsExecutor | failedBlockAdditions=0, totalSize=2.00 GB, freeSize=2.00 GB, usedSize=1.60 MB, cacheSize=1.55 MB, accesses=2103590357, hits=59423, IOhitsPerSecond=0, IOTimePerHit=NaN, hitRatio=0.00%, cachingAccesses=290936, cachingHits=946, cachingHitsRatio=0.33%, evictions=49, evicted=289802, evictedPerRun=5914.326530612245 | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.logStats(BucketCache.java:637) 2024-04-20 23:49:38,469 | INFO  | p1tdhdpdn-v-7:21302Replication Statistics #0 | Global stats: WAL Edits Buffer Used=0B, Limit=268435456B  | org.apache.hadoop.hbase.replication.regionserver.Replication$ReplicationStatisticsTask.printStats(Replication.java:241) 2024-04-20 23:49:39,094 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch, finalDestination=hbaseRegional.async.summary.batch.log4j, interval=01:03.000 minutes, events=4, succcessCount=2, totalEvents=10355692, totalSuccessCount=1047126 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:50:52,951 | INFO  | HBase-Metrics2-1 | Stopping HBase metrics system... | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:210) 2024-04-20 23:50:52,959 | INFO  | HBase-Metrics2-1 | HBase metrics system stopped. | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:216) 2024-04-20 23:50:53,461 | WARN  | HBase-Metrics2-1 | Cannot locate configuration: tried hadoop-metrics2-hbase.properties,hadoop-metrics2.properties | org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:133) 2024-04-20 23:50:53,476 | INFO  | HBase-Metrics2-1 | Scheduled Metric snapshot period at 10 second(s). | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.startTimer(MetricsSystemImpl.java:378) 2024-04-20 23:50:53,476 | INFO  | HBase-Metrics2-1 | HBase metrics system started | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:191) 2024-04-20 23:51:14,537 | INFO  | regionserver/p1tdhdpdn-v-7:21302-longCompactions-9 | 0bf7d39f1708c5e50444c810f60d3f9f#info#compaction#11852 average throughput is 3.49 MB/second, slept 1444 time(s) and total slept time is 3969809 ms. 8 active operations remaining, total limit is 18.00 MB/second | org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController.finish(PressureAwareThroughputController.java:145) 2024-04-20 23:51:15,245 | INFO  | regionserver/p1tdhdpdn-v-7:21302-longCompactions-9 | Completed compaction of 15 (all) file(s) in 0bf7d39f1708c5e50444c810f60d3f9f/info of 0bf7d39f1708c5e50444c810f60d3f9f into 8ae2d25f22a34a01a8b895b0bfa7394e(size=2.2 G), total size for store is 2.2 G. This selection was in queue for 0sec, and took 1hrs, 9mins, 7sec to execute. | org.apache.hadoop.hbase.regionserver.HStore.logCompactionEndMessage(HStore.java:1669) 2024-04-20 23:51:15,245 | INFO  | regionserver/p1tdhdpdn-v-7:21302-longCompactions-9 | Completed compaction Request=regionName=boss20240420,H1030107628~,1713456095893.0bf7d39f1708c5e50444c810f60d3f9f., storeName=info, fileCount=15, fileSize=2.3 G (30.8 M, 1.2 G, 1003.2 M, 25.0 M, 7.1 M, 94.0 K, 83.3 K, 27.0 K, 23.4 K, 21.6 K, 14.7 K, 10.9 K, 17.4 K, 10.9 K, 12.8 K), priority=2, time=1713624128170; duration=1hrs, 9mins, 7sec | org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:632) 2024-04-20 23:53:27,327 | INFO  | MemStoreFlusher.3 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-20 23:53:27,376 | INFO  | MemStoreFlusher.3 | Flushing 4e7bdeeb9b222b113307199da2810e18 1/1 column families, dataSize=1.87 MB heapSize=2.50 MB | org.apache.hadoop.hbase.regionserver.HRegion.logFatLineOnFlush(HRegion.java:2870) 2024-04-20 23:53:27,524 | INFO  | MemStoreFlusher.3 | Flushed memstore data size=1.87 MB at sequenceid=146705 (bloomFilter=true), to=viewfs://ClusterX/hbase/data/default/boss20240405/4e7bdeeb9b222b113307199da2810e18/.tmp/info/98071aebc1e4481aafc41f8e1e8d2243 | org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:85) 2024-04-20 23:53:27,554 | INFO  | MemStoreFlusher.3 | Added viewfs://ClusterX/hbase/data/default/boss20240405/4e7bdeeb9b222b113307199da2810e18/info/98071aebc1e4481aafc41f8e1e8d2243, entries=2940, sequenceid=146705, filesize=190.2 K | org.apache.hadoop.hbase.regionserver.HStore.commitFile(HStore.java:1145) 2024-04-20 23:53:27,555 | INFO  | MemStoreFlusher.3 | Finished flush of dataSize ~1.87 MB/1960410, heapSize ~2.50 MB/2618256, currentSize=0 B/0 for 4e7bdeeb9b222b113307199da2810e18 in 179ms, sequenceid=146705, compaction requested=false | org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:3079) 2024-04-20 23:53:30,121 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch.log4j, interval=04:00.027 minutes, events=2, succcessCount=2, totalEvents=1047126, totalSuccessCount=1047126 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:53:39,121 | INFO  | org.apache.ranger.audit.queue.AuditBatchQueue0 | Audit Status Log: name=hbaseRegional.async.summary.batch, finalDestination=hbaseRegional.async.summary.batch.log4j, interval=01:00.001 minutes, events=2, succcessCount=1, totalEvents=10355694, totalSuccessCount=1047127 | org.apache.ranger.audit.provider.BaseAuditHandler.logStatus(BaseAuditHandler.java:332) 2024-04-20 23:54:32,643 | INFO  | LruBlockCacheStatsExecutor | totalSize=812.98 MB, freeSize=2.37 GB, max=3.16 GB, blockCount=6449, accesses=2141184975, hits=42678224, hitRatio=1.99%, , cachingAccesses=42761786, cachingHits=42615315, cachingHitsRatio=99.66%, evictions=863237, evicted=0, evictedPerRun=0.0 | org.apache.hadoop.hbase.io.hfile.LruBlockCache.logStats(LruBlockCache.java:940) 2024-04-20 23:54:32,967 | INFO  | BucketCacheStatsExecutor | failedBlockAdditions=0, totalSize=2.00 GB, freeSize=2.00 GB, usedSize=1.60 MB, cacheSize=1.55 MB, accesses=2103676600, hits=59423, IOhitsPerSecond=0, IOTimePerHit=NaN, hitRatio=0.00%, cachingAccesses=290936, cachingHits=946, cachingHitsRatio=0.33%, evictions=49, evicted=289802, evictedPerRun=5914.326530612245 | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.logStats(BucketCache.java:637) 2024-04-20 23:54:32,972 | INFO  | MobFileCache #0 | MobFileCache Statistics, access: 0, miss: 0, hit: 0, hit ratio: 0%, evicted files: 0 | org.apache.hadoop.hbase.mob.MobFileCache.printStatistics(MobFileCache.java:341) 2024-04-20 23:54:38,469 | INFO  | p1tdhdpdn-v-7:21302Replication Statistics #0 | Global stats: WAL Edits Buffer Used=0B, Limit=268435456B  | org.apache.hadoop.hbase.replication.regionserver.Replication$ReplicationStatisticsTask.printStats(Replication.java:241) 2024-04-20 23:55:10,095 | INFO  | regionserver/p1tdhdpdn-v-7:21302.logRoller | Rolled WAL /hbase/WALs/p1tdhdpdn-v-7,21302,1704995671636/p1tdhdpdn-v-7%2C21302%2C1704995671636.1713624909375 with entries=584, filesize=1.11 MB; new WAL /hbase/WALs/p1tdhdpdn-v-7,21302,1704995671636/p1tdhdpdn-v-7%2C21302%2C1704995671636.1713628510024 | org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.logRollAndSetupWalProps(AbstractFSWAL.java:727) 2024-04-20 23:55:10,095 | INFO  | Log-Archiver-0 | Archiving viewfs://ClusterX/hbase/WALs/p1tdhdpdn-v-7,21302,1704995671636/p1tdhdpdn-v-7%2C21302%2C1704995671636.1713621309238 to viewfs://ClusterX/hbase/oldWALs/p1tdhdpdn-v-7%2C21302%2C1704995671636.1713621309238 | org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.archiveLogFile(AbstractFSWAL.java:708) 2024-04-20 23:55:52,951 | INFO  | HBase-Metrics2-1 | Stopping HBase metrics system... | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:210) 2024-04-20 23:55:52,958 | INFO  | HBase-Metrics2-1 | HBase metrics system stopped. | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.stop(MetricsSystemImpl.java:216) 2024-04-20 23:55:53,460 | WARN  | HBase-Metrics2-1 | Cannot locate configuration: tried hadoop-metrics2-hbase.properties,hadoop-metrics2.properties | org.apache.hadoop.metrics2.impl.MetricsConfig.loadFirst(MetricsConfig.java:133) 2024-04-20 23:55:53,461 | INFO  | HBase-Metrics2-1 | Scheduled Metric snapshot period at 10 second(s). | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.startTimer(MetricsSystemImpl.java:378) 2024-04-20 23:55:53,461 | INFO  | HBase-Metrics2-1 | HBase metrics system started | org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:191) 2024-04-20 23:59:32,643 | INFO  | LruBlockCacheStatsExecutor | totalSize=814.11 MB, freeSize=2.36 GB, max=3.16 GB, blockCount=6458, accesses=2141273489, hits=42680456, hitRatio=1.99%, , cachingAccesses=42764018, cachingHits=42617538, cachingHitsRatio=99.66%, evictions=863267, evicted=0, evictedPerRun=0.0 | org.apache.hadoop.hbase.io.hfile.LruBlockCache.logStats(LruBlockCache.java:940) 2024-04-20 23:59:32,967 | INFO  | BucketCacheStatsExecutor | failedBlockAdditions=0, totalSize=2.00 GB, freeSize=2.00 GB, usedSize=1.60 MB, cacheSize=1.55 MB, accesses=2103762905, hits=59423, IOhitsPerSecond=0, IOTimePerHit=NaN, hitRatio=0.00%, cachingAccesses=290936, cachingHits=946, cachingHitsRatio=0.33%, evictions=49, evicted=289802, evictedPerRun=5914.326530612245 | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.logStats(BucketCache.java:637) 2024-04-20 23:59:38,469 | INFO  | p1tdhdpdn-v-7:21302Replication Statistics #0 | Global stats: WAL Edits Buffer Used=0B, Limit=268435456B  | org.apache.hadoop.hbase.replication.regionserver.Replication$ReplicationStatisticsTask.printStats(Replication.java:241) 2024-04-21 00:00:15,428 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Close 8975d95b7a69dc45b0055630545c2e25 | org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:107) 2024-04-21 00:00:15,428 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:15,488 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:15,488 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Waiting for flushes and compactions to finish for the region boss20240221,H5CC9923038~,1708358595748.8975d95b7a69dc45b0055630545c2e25. | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1924) 2024-04-21 00:00:15,488 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Total wait time for flushes and compaction for the region boss20240221,H5CC9923038~,1708358595748.8975d95b7a69dc45b0055630545c2e25. is: 0ms | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1960) 2024-04-21 00:00:15,488 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Closing region boss20240221,H5CC9923038~,1708358595748.8975d95b7a69dc45b0055630545c2e25. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1696) 2024-04-21 00:00:15,839 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-2 | Close 0d541b4f0bf68727cfd0f2dfffc4dde5 | org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:107) 2024-04-21 00:00:15,840 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-2 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:15,840 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-2 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:15,840 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-2 | Waiting for flushes and compactions to finish for the region boss20240221,H5CC9915320~,1708358595748.0d541b4f0bf68727cfd0f2dfffc4dde5. | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1924) 2024-04-21 00:00:15,840 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-2 | Total wait time for flushes and compaction for the region boss20240221,H5CC9915320~,1708358595748.0d541b4f0bf68727cfd0f2dfffc4dde5. is: 0ms | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1960) 2024-04-21 00:00:15,840 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-2 | Closing region boss20240221,H5CC9915320~,1708358595748.0d541b4f0bf68727cfd0f2dfffc4dde5. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1696) 2024-04-21 00:00:16,349 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-42 | Close b8083f48bb2d591ca5aff2931d6e1ff7 | org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:107) 2024-04-21 00:00:16,349 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-42 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:16,349 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-42 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:16,349 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-42 | Waiting for flushes and compactions to finish for the region boss20240221,H5CC9907525~,1708358595748.b8083f48bb2d591ca5aff2931d6e1ff7. | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1924) 2024-04-21 00:00:16,349 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-42 | Total wait time for flushes and compaction for the region boss20240221,H5CC9907525~,1708358595748.b8083f48bb2d591ca5aff2931d6e1ff7. is: 0ms | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1960) 2024-04-21 00:00:16,349 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-42 | Closing region boss20240221,H5CC9907525~,1708358595748.b8083f48bb2d591ca5aff2931d6e1ff7. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1696) 2024-04-21 00:00:16,631 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Closed boss20240221,H5CC9923038~,1708358595748.8975d95b7a69dc45b0055630545c2e25. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1913) 2024-04-21 00:00:16,820 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-47 | Close 00c03d83783ca21c7480b26b0f7b099e | org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:107) 2024-04-21 00:00:16,820 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-47 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:16,820 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-47 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:16,820 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-47 | Waiting for flushes and compactions to finish for the region boss20240221,H5309912782~,1708358595748.00c03d83783ca21c7480b26b0f7b099e. | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1924) 2024-04-21 00:00:16,820 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-47 | Total wait time for flushes and compaction for the region boss20240221,H5309912782~,1708358595748.00c03d83783ca21c7480b26b0f7b099e. is: 0ms | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1960) 2024-04-21 00:00:16,820 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-47 | Closing region boss20240221,H5309912782~,1708358595748.00c03d83783ca21c7480b26b0f7b099e. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1696) 2024-04-21 00:00:17,018 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | Close 2b67a4ae42d57326ff9cf11a222b33ab | org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:107) 2024-04-21 00:00:17,018 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:17,018 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | Unable to get remote Address | org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor.getRemoteAddress(RangerAuthorizationCoprocessor.java:214) 2024-04-21 00:00:17,026 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | Waiting for flushes and compactions to finish for the region boss20240221,H52R9907~,1708515296800.2b67a4ae42d57326ff9cf11a222b33ab. | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1924) 2024-04-21 00:00:17,027 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | Total wait time for flushes and compaction for the region boss20240221,H52R9907~,1708515296800.2b67a4ae42d57326ff9cf11a222b33ab. is: 0ms | org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1960) 2024-04-21 00:00:17,027 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | Closing region boss20240221,H52R9907~,1708515296800.2b67a4ae42d57326ff9cf11a222b33ab. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1696) 2024-04-21 00:00:17,189 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-16 | Closed 8975d95b7a69dc45b0055630545c2e25 | org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:147) 2024-04-21 00:00:17,447 | INFO  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-2 | Closed boss20240221,H5CC9915320~,1708358595748.0d541b4f0bf68727cfd0f2dfffc4dde5. | org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1913) 2024-04-21 00:00:17,603 | WARN  | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | Fatal error occurred while closing region 2b67a4ae42d57326ff9cf11a222b33ab, aborting... | org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.handleException(UnassignRegionHandler.java:152) java.io.IOException: The new max sequence id 328 is less than the old max sequence id 330     at org.apache.hadoop.hbase.wal.WALSplitUtil.writeRegionSequenceIdFile(WALSplitUtil.java:461)     at org.apache.hadoop.hbase.regionserver.HRegion.writeRegionCloseMarker(HRegion.java:1265)     at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1893)     at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1625)     at org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:116)     at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:106)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:748) 2024-04-21 00:00:17,610 | ERROR | RS_CLOSE_REGION-regionserver/p1tdhdpdn-v-7:21302-0 | ***** ABORTING region server p1tdhdpdn-v-7,21302,1704995671636: Failed to close region 2b67a4ae42d57326ff9cf11a222b33ab and can not recover ***** | org.slf4j.helpers.MarkerIgnoringBase.error(MarkerIgnoringBase.java:159) java.io.IOException: The new max sequence id 328 is less than the old max sequence id 330     at org.apache.hadoop.hbase.wal.WALSplitUtil.writeRegionSequenceIdFile(WALSplitUtil.java:461)     at org.apache.hadoop.hbase.regionserver.HRegion.writeRegionCloseMarker(HRegion.java:1265)     at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1893)     at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1625)     at org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:116)     at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:106)     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)     at java.lang.Thread.run(Thread.java:748)" Update hbase-thirdparty to 4.1.7,13575336,Resolved,Major,Fixed,10/Apr/24 11:19,21/Apr/24 14:02,, [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release,13576489,Resolved,Major,Fixed,19/Apr/24 09:33,19/Apr/24 11:55,,"# Release the artifacts on repository.apache.org # Move the binaries from dist-dev to dist-release # Push tag 4.1.7RC0 as tag rel/4.1.7 # Release thirdparty-4.1.7 on JIRA https://issues.apache.org/jira/projects/HBASE/versions/12354385 # Add release data on https://reporter.apache.org/addrelease.html?hbase # Send announcement email" [hbase-thirdparty] Fix pre commit build,13574845,Resolved,Major,Fixed,06/Apr/24 06:13,06/Apr/24 13:09,,"The pre commit build kept failing, all mvn commands generate empty output. Need to dig more." [hbase-thirdparty] Put up hbase-thirdparty-4.1.7RC0,13575282,Resolved,Major,Fixed,10/Apr/24 04:06,19/Apr/24 09:29,, [hbase-thirdparty] Release hbase-thirdparty 4.1.7,13574777,Resolved,Major,Fixed,05/Apr/24 12:26,19/Apr/24 11:55,, Rest Java client library assumes stateless servers,13574959,Resolved,Major,Fixed,08/Apr/24 08:26,17/Apr/24 13:10,,"The Rest Java client library accepts a list of rest servers, and does random load balancing between them for each request. This does not work for scans, which do have state on the rest server instance." Better not use threads when parallel seek enabled and only one storescanner to seek,13576193,Open,Major,,17/Apr/24 09:45,,,"When parallel seek enabled, seeking through the scanners using multiple threads and waiting on the countdown lock to complete the seek on all the scanners. It would be better not to use threads when there is only one scanners to seek. Might not be significant improvement but will be useful when a region has one store file post major compaction. {code:java} private void parallelSeek(final List scanners, final Cell kv) throws IOException { if (scanners.isEmpty()) return; int storeFileScannerCount = scanners.size(); CountDownLatch latch = new CountDownLatch(storeFileScannerCount); List handlers = new ArrayList<>(storeFileScannerCount); for (KeyValueScanner scanner : scanners) { if (scanner instanceof StoreFileScanner) { ParallelSeekHandler seekHandler = new ParallelSeekHandler(scanner, kv, this.readPt, latch); executor.submit(seekHandler); handlers.add(seekHandler); } else { scanner.seek(kv); latch.countDown(); } } try { latch.await(); } catch (InterruptedException ie) { throw (InterruptedIOException) new InterruptedIOException().initCause(ie); } {code} " Implement eviction logic for scanners in Rest APIs to prevent scanner leakage,13575057,Resolved,Major,Fixed,09/Apr/24 05:24,15/Apr/24 15:49,,"The REST API maintains a map of _ScannerInstanceResource_s (which are ultimately tracking Scanner objects). The user is supposed to delete these after using them, but if for any reason it does not, then these objects are maintained indefinitely. Implement logic to evict old scanners automatically." fix spotless:check errors,13574919,Resolved,Major,Fixed,07/Apr/24 17:41,13/Apr/24 02:29,2.6.0," I have observed that mvn spotless:check gives error on branch-2.6 {noformat} The following files had format violations: [ERROR]     RELEASENOTES.md{noformat}" Bump idna from 2.8 to 3.7 in /dev-support/git-jira-release-audit,13575652,Resolved,Major,Fixed,12/Apr/24 14:43,12/Apr/24 14:45,, Deprecate hbase-compression-xz,13575205,Resolved,Major,Fixed,09/Apr/24 16:15,12/Apr/24 21:22,,"Refer to [https://lists.apache.org/thread/on62z40rwotrcc8w1l5n55rd4zldho5g] . Deprecate in 2.5.x. I will add a release note when resolving this issue." Remove hbase-compression-xz,13575204,Resolved,Major,Fixed,09/Apr/24 16:15,10/Apr/24 18:22,,"Refer to [https://lists.apache.org/thread/on62z40rwotrcc8w1l5n55rd4zldho5g] . Deprecate in 2.5.x, remove in 2.6. I will add a release note when resolving this issue." Remove the need for ADMIN permissions for RSRpcServices#execRegionServerService,13575241,Open,Major,,09/Apr/24 22:49,,2.4.17,"We have introduced a new regionserver coproc within phoenix and all the permission related tests are failing with the following exception. {noformat} Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.security.AccessDeniedException): org.apache.hadoop.hbase.security.AccessDeniedException: Insufficient permissions for user 'groupUser_N000042' (global, action=ADMIN) at org.apache.hadoop.hbase.security.access.AccessChecker.requireGlobalPermission(AccessChecker.java:152) at org.apache.hadoop.hbase.security.access.AccessChecker.requirePermission(AccessChecker.java:125) at org.apache.hadoop.hbase.regionserver.RSRpcServices.requirePermission(RSRpcServices.java:1318) at org.apache.hadoop.hbase.regionserver.RSRpcServices.rpcPreCheck(RSRpcServices.java:584) at org.apache.hadoop.hbase.regionserver.RSRpcServices.execRegionServerService(RSRpcServices.java:3804) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45016) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:415) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) {noformat} This check is failing. [RSRpcServices|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3815] {code} @Override public CoprocessorServiceResponse execRegionServerService(RpcController controller, CoprocessorServiceRequest request) throws ServiceException { rpcPreCheck(""execRegionServerService""); return server.execRegionServerService(controller, request); } private void rpcPreCheck(String requestName) throws ServiceException { try { checkOpen(); requirePermission(requestName, Permission.Action.ADMIN); } catch (IOException ioe) { throw new ServiceException(ioe); } } {code} Why do we need ADMIN permissions to call region server coproc? We don't need ADMIN permissions to call all region co-procs. We require ADMIN permissions to execute some region coprocs (compactionSwitch, clearRegionBlockCache). Can we change the permission to READ? " Implement enforcement to require Date Tiered Compaction for Time Range Data Tiering,13575198,Resolved,Major,Fixed,09/Apr/24 15:00,12/Apr/24 09:25,,The implementation should enforce the requirement of enabling Date Tiered Compaction for Time Range Data Tiering. This restriction ensures that users can fully benefit from Time Range Data Tiering functionality by disallowing its usage unless Date Tiered Compaction is enabled. "Troubleshooting the issue of the ""hbase-cleanup.sh --cleanAcls"" command not taking effect",13574889,Patch Available,Major,,07/Apr/24 06:26,,2.4.15,"When executing the ""hbase-cleanup.sh --cleanAcls"" command, it was noticed that the ACL permissions of nodes in ZooKeeper did not change. The reason is that in the hbase-cleanup.sh script, the contents of the execute_clean_acls method are as follows:   {code:java} execute_clean_acls() { command=$1; ""$bin""/hbase org.apache.hadoop.hbase.zookeeper.ZkAclReset $command 2>&1 } {code} The corresponding type in the ""hbase-zookeeper"" module should be ""org.apache.hadoop.hbase.zookeeper.ZKAclReset"", so it is necessary to change ""org.apache.hadoop.hbase.zookeeper.ZkAclReset"" to ""org.apache.hadoop.hbase.zookeeper.ZKAclReset"" in the ""execute_clean_acls"" method." Validate access check for each RegionServerCoprocessor Endpoint.,13575563,Open,Major,,11/Apr/24 20:45,,,"Currently we enforce ADMIN permissions for each regionserver coprocessor method. See HBASE-28508 for more details. There can be regionserver endpoint implementation which don't want to enforce calling users to have ADMIN permissions. So there needs to be a way for RS coproc implementation to override the access checks, with the default being requiring ADMIN permissions." [hbase-thirdparty] Bump protobuf version,13574783,Resolved,Major,Fixed,05/Apr/24 12:55,10/Apr/24 03:59,, [hbase-thirdparty] Bump netty to 4.1.108.Final for addressing CVE-2024-29025,13574778,Resolved,Major,Fixed,05/Apr/24 12:28,07/Apr/24 00:21,,https://nvd.nist.gov/vuln/detail/CVE-2024-29025 [hbase-thirdparty] Bump dependency versions before releasing,13574779,Resolved,Major,Fixed,05/Apr/24 12:29,09/Apr/24 10:04,,"Like jetty, guava, etc." Remove the hbase1 compatible code in FixedFileTrailer,13574128,Resolved,Major,Fixed,01/Apr/24 09:09,07/Apr/24 10:49,, Prompting table already exists after failing to create table with many region replications,13574163,Resolved,Major,Fixed,01/Apr/24 15:38,07/Apr/24 10:37,2.4.13,"Reproduction steps: {code:java} # Create table with 65537 region replications # we would get errors as follow,  this step is no problem hbase:005:0> create 't01', 'info', {REGION_REPLICATION => 65537} ERROR: java.lang.IllegalArgumentException: ReplicaId cannot be greater than65535 For usage try 'help ""create""' Took 0.7590 seconds{code} {code:java} # list, and found the table does not exist, as follow hbase:006:0> list TABLE 0 row(s) Took 0.0100 seconds => []{code} {code:java} # we create this tale agin by the correct way # we would get message that this table already exists hbase:007:0> create 't01', 'info' ERROR: Table already exists: t01! For usage try 'help ""create""' Took 0.1210 seconds {code}   Reason: In the CreateTableProcedure, we update this table descriptor into HBase cluster at stage  CREATE_TABLE_WRITE_FS_LAYOUT   {code:java} env.getMasterServices().getTableDescriptors().update(tableDescriptor, true); {code}   and then, we check if the Region Replication Count is legal at stage CREATE_TABLE_ADD_TO_META.     {code:java} newRegions = addTableToMeta(env, tableDescriptor, newRegions); // MutableRegionInfo.checkReplicaId private static int checkReplicaId(int regionId) {     if (regionId > MAX_REPLICA_ID) {         throw new IllegalArgumentException(""ReplicaId cannot be greater than"" + MAX_REPLICA_ID);   }     return regionId; }{code}     So, we can not create the same name table by correct way after faling to create table with many region replications (exceed 65536), because the table descriptor has been updated into cluster and there is no rollback. So i think we can check if the region replication count at stage CREATE_TABLE_PRE_OPERATION to avoid this problem" Keep entries in draining ZNode when HMaster is configured to reject decommissioned hosts,13574998,Open,Major,,08/Apr/24 13:55,,,"Last month we shipped a config feature to allow the HMaster to reject decommissioned hosts (see: [HBASE-28342|https://issues.apache.org/jira/browse/HBASE-28342]). After some testing internally at HubSpot, we discovered that the HMaster loses the entry of a decommissioned host from the draining ZNode when the RegionServer restarts or becomes dead. Our proposal for this fix would be to keep entries in the draining ZNode as long as the HMaster is configured to reject decommissioned hosts." Merge of incremental backups fails on bulkloaded Hfiles,13574632,Resolved,Major,Fixed,04/Apr/24 13:24,06/Apr/24 20:06,2.6.0,"The merge of incremental backups fails in case one of the backups contains a bulk loaded HFile and the other backups doesn't. See test in attachements based on {code:java} org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java{code} that reproduces the exception when useBulkLoad is set to true [^TestIncrementalBackupMergeWithBulkLoad.java]. This exception occurs in the call to`HFileRecordReader#initialize` as it tries to read a directory path as an HFile. I'll see if I can create a patch on master to fix this. {code:java} 2024-04-04T14:55:15,462 INFO  LocalJobRunner Map Task Executor #0 {} mapreduce.HFileInputFormat$HFileRecordReader(95): Initialize HFileRecordReader for hdfs://localhost:34093/user/thomass/backupIT/backup_1712235269368/default/table-true/eaeb223066c24d3e77a2ee6987e30cb3/0 2024-04-04T14:55:15,482 WARN  [Thread-1429 {}] mapred.LocalJobRunner$Job(590): job_local1854345815_0018 java.lang.Exception: java.io.FileNotFoundException: Path is not a file: /user/thomass/backupIT/backup_1712235269368/default/table-true/eaeb223066c24d3e77a2ee6987e30cb3/0 at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90) at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76) at org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:156) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:2124) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:769) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:460) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:621) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1213) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1089) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1012) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/javax.security.auth.Subject.doAs(Subject.java:423) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:3026)   at org.apache.hadoop.mapred.LocalJobRunner$Job.runTasks(LocalJobRunner.java:492) ~[hadoop-mapreduce-client-common-3.3.5.jar:?] at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:552) ~[hadoop-mapreduce-client-common-3.3.5.jar:?] Caused by: java.io.FileNotFoundException: Path is not a file: /user/thomass/backupIT/backup_1712235269368/default/table-true/eaeb223066c24d3e77a2ee6987e30cb3/0 at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90) at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76) at org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:156) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:2124) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:769) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:460) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:621) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1213) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1089) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1012) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/javax.security.auth.Subject.doAs(Subject.java:423) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:3026)   at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?] at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:?] at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?] at java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[?:?] at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:121) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:88) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.hdfs.DFSClient.callGetBlockLocations(DFSClient.java:902) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DFSClient.getLocatedBlocks(DFSClient.java:889) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DFSClient.getLocatedBlocks(DFSClient.java:878) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1046) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$4.doCall(DistributedFileSystem.java:340) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$4.doCall(DistributedFileSystem.java:336) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem.open(DistributedFileSystem.java:353) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.fs.FilterFileSystem.open(FilterFileSystem.java:168) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:997) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:122) ~[classes/:?] at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:99) ~[classes/:?] at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:94) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFile.createReader(HFile.java:543) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFile.createReader(HFile.java:525) ~[classes/:?] at org.apache.hadoop.hbase.mapreduce.HFileInputFormat$HFileRecordReader.initialize(HFileInputFormat.java:96) ~[classes/:?] at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:561) ~[hadoop-mapreduce-client-core-3.3.5.jar:?] at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:799) ~[hadoop-mapreduce-client-core-3.3.5.jar:?] at org.apache.hadoop.mapred.MapTask.run(MapTask.java:348) ~[hadoop-mapreduce-client-core-3.3.5.jar:?] at org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:271) ~[hadoop-mapreduce-client-common-3.3.5.jar:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?] at java.lang.Thread.run(Thread.java:829) ~[?:?] Caused by: org.apache.hadoop.ipc.RemoteException: Path is not a file: /user/thomass/backupIT/backup_1712235269368/default/table-true/eaeb223066c24d3e77a2ee6987e30cb3/0 at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90) at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76) at org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:156) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:2124) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:769) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:460) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:621) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:589) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:573) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1213) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1089) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1012) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/javax.security.auth.Subject.doAs(Subject.java:423) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1899) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:3026)   at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1584) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1530) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.ipc.Client.call(Client.java:1427) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:258) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.ipc.ProtobufRpcEngine2$Invoker.invoke(ProtobufRpcEngine2.java:139) ~[hadoop-common-3.3.5.jar:?] at com.sun.proxy.$Proxy44.getBlockLocations(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getBlockLocations(ClientNamenodeProtocolTranslatorPB.java:334) ~[hadoop-hdfs-client-3.3.5.jar:?] at jdk.internal.reflect.GeneratedMethodAccessor18.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:433) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:166) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:158) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:96) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:362) ~[hadoop-common-3.3.5.jar:?] at com.sun.proxy.$Proxy45.getBlockLocations(Unknown Source) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor18.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[classes/:?] at com.sun.proxy.$Proxy48.getBlockLocations(Unknown Source) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor18.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[classes/:?] at com.sun.proxy.$Proxy48.getBlockLocations(Unknown Source) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor18.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[classes/:?] at com.sun.proxy.$Proxy48.getBlockLocations(Unknown Source) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor18.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[classes/:?] at com.sun.proxy.$Proxy48.getBlockLocations(Unknown Source) ~[?:?] at jdk.internal.reflect.GeneratedMethodAccessor18.invoke(Unknown Source) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.apache.hadoop.hbase.fs.HFileSystem$1.invoke(HFileSystem.java:363) ~[classes/:?] at com.sun.proxy.$Proxy48.getBlockLocations(Unknown Source) ~[?:?] at org.apache.hadoop.hdfs.DFSClient.callGetBlockLocations(DFSClient.java:900) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DFSClient.getLocatedBlocks(DFSClient.java:889) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DFSClient.getLocatedBlocks(DFSClient.java:878) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1046) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$4.doCall(DistributedFileSystem.java:340) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem$4.doCall(DistributedFileSystem.java:336) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.hdfs.DistributedFileSystem.open(DistributedFileSystem.java:353) ~[hadoop-hdfs-client-3.3.5.jar:?] at org.apache.hadoop.fs.FilterFileSystem.open(FilterFileSystem.java:168) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:997) ~[hadoop-common-3.3.5.jar:?] at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:122) ~[classes/:?] at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:99) ~[classes/:?] at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:94) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFile.createReader(HFile.java:543) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFile.createReader(HFile.java:525) ~[classes/:?] at org.apache.hadoop.hbase.mapreduce.HFileInputFormat$HFileRecordReader.initialize(HFileInputFormat.java:96) ~[classes/:?] at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:561) ~[hadoop-mapreduce-client-core-3.3.5.jar:?] at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:799) ~[hadoop-mapreduce-client-core-3.3.5.jar:?] at org.apache.hadoop.mapred.MapTask.run(MapTask.java:348) ~[hadoop-mapreduce-client-core-3.3.5.jar:?] at org.apache.hadoop.mapred.LocalJobRunner$Job$MapTaskRunnable.run(LocalJobRunner.java:271) ~[hadoop-mapreduce-client-common-3.3.5.jar:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) ~[?:?] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?] at java.lang.Thread.run(Thread.java:829) ~[?:?] 2024-04-04T14:55:16,451 ERROR [Listener at localhost/33145 {}] mapreduce.MapReduceBackupMergeJob(188): java.io.IOException: Can not merge backup images for backupIT/backup_1712235269368/default/table-true,backupIT/backup_1712235285491/default/table-true (check Hadoop/MR and HBase logs). Player return code =1 java.io.IOException: Can not merge backup images for backupIT/backup_1712235269368/default/table-true,backupIT/backup_1712235285491/default/table-true (check Hadoop/MR and HBase logs). Player return code =1 at org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(MapReduceBackupMergeJob.java:141) ~[classes/:?] at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.mergeBackups(BackupAdminImpl.java:622) ~[classes/:?] at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.merge(TestIncrementalBackupMergeWithBulkLoad.java:222) ~[test-classes/:?] at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.test(TestIncrementalBackupMergeWithBulkLoad.java:137) ~[test-classes/:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.run(ParentRunner.java:413) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.Suite.runChild(Suite.java:128) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.Suite.runChild(Suite.java:27) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) ~[junit-4.13.2.jar:4.13.2] at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) ~[junit-4.13.2.jar:4.13.2] at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?] at java.lang.Thread.run(Thread.java:829) ~[?:?] 2024-04-04T14:55:16,456 DEBUG [Listener at localhost/33145 {}] impl.BackupSystemTable(657): Finish backup exclusive operation 2024-04-04T14:55:16,459 INFO  [Listener at localhost/33145 {}] client.AsyncConnectionImpl(233): Connection has been closed by Listener at localhost/33145. 2024-04-04T14:55:16,459 DEBUG [Listener at localhost/33145 {}] client.AsyncConnectionImpl(264): Call stack:     at java.base/java.lang.Thread.getStackTrace(Thread.java:1602)     at org.apache.hadoop.hbase.client.AsyncConnectionImpl.lambda$close$5(AsyncConnectionImpl.java:235)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177)     at org.apache.hadoop.hbase.client.AsyncConnectionImpl.close(AsyncConnectionImpl.java:229)     at org.apache.hadoop.hbase.client.ConnectionOverAsyncConnection.close(ConnectionOverAsyncConnection.java:130)     at org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(MapReduceBackupMergeJob.java:203)     at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.mergeBackups(BackupAdminImpl.java:622)     at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.merge(TestIncrementalBackupMergeWithBulkLoad.java:222)     at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.test(TestIncrementalBackupMergeWithBulkLoad.java:137)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.base/java.lang.reflect.Method.invoke(Method.java:566)     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)     at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.runners.ParentRunner.run(ParentRunner.java:413)     at org.junit.runners.Suite.runChild(Suite.java:128)     at org.junit.runners.Suite.runChild(Suite.java:27)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)     at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)     at java.base/java.lang.Thread.run(Thread.java:829)   2024-04-04T14:55:16,459 DEBUG [Listener at localhost/33145 {}] ipc.AbstractRpcClient(514): Stopping rpc client 2024-04-04T14:55:16,459 DEBUG [Listener at localhost/33145 {}] ipc.AbstractRpcClient(514): Stopping rpc client 2024-04-04T14:55:16,459 INFO  [Registry-endpoints-refresh-end-points {}] client.RegistryEndpointsRefresher(78): Registry end points refresher loop exited. 2024-04-04T14:55:16,460 INFO  [Listener at localhost/33145 {}] client.AsyncConnectionImpl(233): Connection has been closed by Listener at localhost/33145. 2024-04-04T14:55:16,460 DEBUG [Listener at localhost/33145 {}] client.AsyncConnectionImpl(264): Call stack:     at java.base/java.lang.Thread.getStackTrace(Thread.java:1602)     at org.apache.hadoop.hbase.client.AsyncConnectionImpl.lambda$close$5(AsyncConnectionImpl.java:235)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187)     at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177)     at org.apache.hadoop.hbase.client.AsyncConnectionImpl.close(AsyncConnectionImpl.java:229)     at org.apache.hadoop.hbase.client.ConnectionOverAsyncConnection.close(ConnectionOverAsyncConnection.java:130)     at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.merge(TestIncrementalBackupMergeWithBulkLoad.java:220)     at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.test(TestIncrementalBackupMergeWithBulkLoad.java:137)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.base/java.lang.reflect.Method.invoke(Method.java:566)     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)     at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.runners.ParentRunner.run(ParentRunner.java:413)     at org.junit.runners.Suite.runChild(Suite.java:128)     at org.junit.runners.Suite.runChild(Suite.java:27)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)     at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)     at java.base/java.lang.Thread.run(Thread.java:829)   2024-04-04T14:55:16,460 DEBUG [Listener at localhost/33145 {}] ipc.AbstractRpcClient(514): Stopping rpc client 2024-04-04T14:55:16,460 DEBUG [Listener at localhost/33145 {}] ipc.AbstractRpcClient(514): Stopping rpc client 2024-04-04T14:55:16,460 INFO  [Registry-endpoints-refresh-end-points {}] client.RegistryEndpointsRefresher(78): Registry end points refresher loop exited. 2024-04-04T14:55:16,468 INFO  [Listener at localhost/33145 {}] hbase.HBaseTestingUtil(1041): Shutting down minicluster 2024-04-04T14:55:16,468 INFO  [Listener at localhost/33145 {}] client.AsyncConnectionImpl(233): Connection has been closed by Listener at localhost/33145. 2024-04-04T14:55:16,468 DEBUG [Listener at localhost/33145 {}] client.AsyncConnectionImpl(264): Call stack:   java.io.IOException: Backup merge operation failed, you should try it again   at org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(MapReduceBackupMergeJob.java:195) at org.apache.hadoop.hbase.backup.impl.BackupAdminImpl.mergeBackups(BackupAdminImpl.java:622) at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.merge(TestIncrementalBackupMergeWithBulkLoad.java:222) at org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithBulkLoad.test(TestIncrementalBackupMergeWithBulkLoad.java:137) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: java.io.IOException: Can not merge backup images for backupIT/backup_1712235269368/default/table-true,backupIT/backup_1712235285491/default/table-true (check Hadoop/MR and HBase logs). Player return code =1 at org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupMergeJob.run(MapReduceBackupMergeJob.java:141) ... 36 more{code}" Division by zero encountered when using BloomFilter with a misconfiguration,13574744,Open,Major,,05/Apr/24 08:47,,,"h2. What happened: Got Division by 0 when trying to run org.apache.hadoop.hbase.procedure2.store.region.TestHFileProcedurePrettyPrinter#test with io.storefile.bloom.max.fold set too large. h2. Buggy code: In BloomFilterUtil.java: {code:java} public static int optimalFunctionCount(int maxKeys, long bitSize) {     long i = bitSize / maxKeys; // here maxKeys might be zero ...   } {code} h2. StackTrace: {code:java} org.apache.hadoop.hbase.DroppedSnapshotException: region: master:store,,1.1595e783b53d99cd5eef43b6debb2682. … Caused by: java.lang.ArithmeticException: / by zero at org.apache.hadoop.hbase.util.BloomFilterUtil.optimalFunctionCount(BloomFilterUtil.java:143) at org.apache.hadoop.hbase.util.BloomFilterUtil.createBySize(BloomFilterUtil.java:167){code} h2. How to reproduce: (1) Set io.storefile.bloom.max.fold to 73830463 (2) Run test: org.apache.hadoop.hbase.procedure2.store.region.TestHFileProcedurePrettyPrinter#test" Make WAL rolling exception clear,13576981,Resolved,Minor,Fixed,23/Apr/24 22:54,31/May/24 18:17,,"Occasionally we see errors like this that doesn't really give much clue what went wrong. {noformat} 2024-04-22 08:08:02,026 ERROR org.apache.hadoop.hbase.master.HMaster: ***** ABORTING master ccycloud-7.ozn-hb973chf3oz.xyz,22001,1713770648404: Log rolling failed ***** java.lang.RuntimeException at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeWALMetadata(AsyncProtobufLogWriter.java:217) at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeMagicAndWALHeader(AsyncProtobufLogWriter.java:223) at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:164) at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:116) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:726) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:129) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:886) at org.apache.hadoop.hbase.wal.AbstractWALRoller$RollController.rollWal(AbstractWALRoller.java:304) at org.apache.hadoop.hbase.wal.AbstractWALRoller.run(AbstractWALRoller.java:211) {noformat} In this case, it was due to a time out exception. It would be helpful to make the log message more friendly." Avoid expensive allocation in createRegionSpan,13574768,Patch Available,Minor,,05/Apr/24 11:32,,2.5.0,"On our busy clusters, the alloc profile shows that createRegionSpan() is responsible for 15-20% of all the allocations. These allocations comes from getRegionNameAsString(). getRegionNameAsString() takes the region name and encode invisible characters in their hex representation. This requires the use of a StringBuilder and thus generate new strings every time. This becomes really expensive on a cluster with high number of requests. We have a patch that replaced the call with getEncodedName() instead. It seems better to just take the encoded region name (the md5 part) and use that in trace attributes, because: - it's fixed in size (the full region name can be much longer depending on the rowkey size), - it's enough information to link a trace to a region, - it doesn't require any new allocation." Add build information to the REST server version endpoint,13582092,Resolved,Minor,Fixed,10/Jun/24 04:50,27/Sep/24 08:34,,"There is currently no way to check the REST server version / build number remotely. The */version/cluster* endpoint takes the version from master (fair enough), and the */version/rest* does not include the build information. We should add a version field to the /version/rest endpoint, which reports the version of the REST server component. We should also log this at startup, just like we log the cluster version now. We may have to add and store the version in the hbase-rest code during build, similarly to how do it for the other components." copy_tables_desc.rb script should handle scenarios where the namespace does not exist in the target cluster,13578841,Resolved,Minor,Fixed,10/May/24 06:40,27/Sep/24 11:57,2.4.17,"When utilizing the {{copy_tables_desc.rb}} script to duplicate tables to a target cluster, if the specified table's namespace is nonexistent in the target cluster, the script fails to execute successfully. It is recommended to incorporate logic within the script for detecting and handling scenarios where the namespace does not exist." Make sure that filterAllRemaining() is not called from filterRowKey(),13581332,Open,Minor,,03/Jun/24 04:51,,,"Many of the current filters call filterAllRemaining() from filterRowKey(). This should not be necessary, as in the normal (RS) code path, filterRowKey() is only called AFTER filterAllReamaining() has returned false. Well-written filters do cache their filterAllReamaining() status, so this is not very expensive, but we could still save a few cycles for each cell. * Change the filter API definition to explicitly state this * Fix the code where this is not true. At first glance, org.apache.hadoop.hbase.mapreduce.Import seems to be one place that does not confirm to this behaviour." Reduce memory copying in Rest server when serializing CellModel to Protobuf,13577540,Resolved,Minor,Fixed,29/Apr/24 07:56,07/May/24 06:32,,"The REST server does a lot of unneccessary coping, which could be avoided at least for protobuf encoding. - -It uses ByteStringer to handle ByteBuffer backed Cells. However, it uses the client API, so it should never encounter ByteBuffer backed cells.- - It clones everything from the cells (sometimes multiple times) before serializing to protbuf. We could mimic the structure in Cell, with array, offset and length for each field, in CellModel and use the appropriate protobuf setters to avoid the extra copies. There may or may not be a way to do the same for JSON and XML via jax-rs, I don't know the frameworks well enough to tell, but if not, we could just do the copying in the getters for them, which would not make things worse. " Use the latest Httpclient/Httpcore 5.x in HBase,13574948,Open,Minor,,08/Apr/24 07:09,,,"HttpClient 4.x is not actively developed. We use Httpclient directly in the REST client code, and in the tests for several modules. Httpclient 4.5 is a transitive dependency at least from Hadoop and Thrift, but httpclient 5.x uses a separate java package, so 4.5 and 5.x should be able to co-exist fine. As of now, Httpclient 4.5 is in maintenance mode: https://hc.apache.org/status.html " "After one RegionServer restarts, another RegionServer leaks a connection to ZooKeeper",13582794,Resolved,Minor,Fixed,16/Jun/24 08:07,06/Sep/24 08:56,2.4.5,"The peer ""to_pd_A"" has been removed, but there is an error log in RegionServer, error log： {code:java} 2024-06-11 09:42:34.074 ERROR [ReplicationExecutor-0.replicationSource,to_pd_A-172.30.12.12,6002,1709612684705-SendThread(bjtx-hbase-onll-meta-01:2181)] client.StaticHostProvider: Unable to resolve address: bjtx-hbase-onll-meta-03:2181 java.net.UnknownHostException: bjtx-hbase-onll-meta-03    at java.net.InetAddress$CachedAddresses.get(InetAddress.java:764)    at java.net.InetAddress.getAllByName0(InetAddress.java:1291)    at java.net.InetAddress.getAllByName(InetAddress.java:1144)    at java.net.InetAddress.getAllByName(InetAddress.java:1065)    at org.apache.zookeeper.client.StaticHostProvider$1.getAllByName(StaticHostProvider.java:92)    at org.apache.zookeeper.client.StaticHostProvider.resolve(StaticHostProvider.java:147)    at org.apache.zookeeper.client.StaticHostProvider.next(StaticHostProvider.java:375)    at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1137){code} Here are the steps to reproduce: I have 3 RegionServers. The following steps can reproduce the phenomenon of ZK connection leakage: 1. Enable replication 2. Create a peer 3. Shut down any two RegionServers for a few minutes and restart them 4. Print the thread stack on the RegionServer that is not shut down, search for the keyword , and you can see that there are 4 more threads with ZooKeeper 5. By removing the peer, the extra 4 threads still exist The following is the thread stack leak in one of my RegionServers： {code:java} ""ReplicationExecutor-0.replicationSource,lizy_test_replication-10.0.16.29,6002,1718180442225-EventThread"" #610 daemon prio=5 os_prio=0 cpu=0.27ms elapsed=466.94s tid=0x00007efc58179000 nid=0x5a051 waiting on condition [0x00007efc2cdef000] ""ReplicationExecutor-0.replicationSource,lizy_test_replication-10.0.16.29,6002,1718180442225-SendThread(10.0.16.100:2181)"" #609 daemon prio=5 os_prio=0 cpu=3.02ms elapsed=466.94s tid=0x00007efc58178800 nid=0x5a050 runnable [0x00007efc2cef0000] ""ReplicationExecutor-0.replicationSource,lizy_test_replication-10.0.16.9,6002,1718180457260-EventThread"" #505 daemon prio=5 os_prio=0 cpu=0.27ms elapsed=556.09s tid=0x00007efc50094800 nid=0x59c04 waiting on condition [0x00007efc2d7f7000] ""ReplicationExecutor-0.replicationSource,lizy_test_replication-10.0.16.9,6002,1718180457260-SendThread(10.0.16.100:2181)"" #504 daemon prio=5 os_prio=0 cpu=3.72ms elapsed=556.09s tid=0x00007efc50093000 nid=0x59c03 runnable [0x00007efc2d8f8000] {code}" Support only remove expired files in the compact process,13582266,In Progress,Minor,,11/Jun/24 13:26,,,"As is known to all, the compact processes generate a certain amount of I/O. But in some cases, not being compact in time does not affect online services. For example, in the scenario where the TTL time of a table is short, there are more writes than reads. To ensure write performance and reduce cluster I/O pressure, Only expired files are removed in the compact process is a good idea. Another usage scenario: Tables have primary and backup, and the backup table can add this table attribute to reduce the compact IO of the backup cluster. Optimization solution: Add a table attribute for the HBase table" WALs not marked closed when there are errors in closing WALs,13582656,Resolved,Minor,Fixed,14/Jun/24 08:22,11/Jul/24 06:02,2.5.8,"In our production clusters we have observed that when WAL close fails It causes the the oldWAL files not marked as close and not letting them cleaned. When a WAL close fails in closeWriter it increments the error count. {code:java} Span span = Span.current(); try { span.addEvent(""closing writer""); writer.close(); span.addEvent(""writer closed""); } catch (IOException ioe) { int errors = closeErrorCount.incrementAndGet(); boolean hasUnflushedEntries = isUnflushedEntries(); if (syncCloseCall && (hasUnflushedEntries || (errors > this.closeErrorsTolerated))) { LOG.error(""Close of WAL "" + path + "" failed. Cause=\"""" + ioe.getMessage() + ""\"", errors="" + errors + "", hasUnflushedEntries="" + hasUnflushedEntries); throw ioe; } LOG.warn(""Riding over failed WAL close of "" + path + ""; THIS FILE WAS NOT CLOSED BUT ALL EDITS SYNCED SO SHOULD BE OK"", ioe); } {code} When there are errors in closing WAL only twice doReplaceWALWriter enters this code block {code:java} if (isUnflushedEntries() || closeErrorCount.get() >= this.closeErrorsTolerated) { try { closeWriter(this.writer, oldPath, true); } finally { inflightWALClosures.remove(oldPath.getName()); } } {code} as we don't mark them closed here like we do it here {code:java} Writer localWriter = this.writer; closeExecutor.execute(() -> { try { closeWriter(localWriter, oldPath, false); } catch (IOException e) { LOG.warn(""close old writer failed"", e); } finally { // call this even if the above close fails, as there is no other chance we can set // closed to true, it will not cause big problems. {color:red} markClosedAndClean(oldPath);{color} inflightWALClosures.remove(oldPath.getName()); } }); {code} " Not allowed to disable hbase:replication,13583914,Open,Minor,,26/Jun/24 14:10,,,"hbase:replication belongs to the hbase system table, we cannot add new peer if this table is in disabled state. So, I think disabling this table is not allowed just like hbase:meta.   Or any better suggestions? " [HBASE] The Archives folder in the HBASE root directory starts to grow uncontrollably under load,13582654,Resolved,Minor,Fixed,14/Jun/24 08:12,26/Jun/24 07:10,,"If there are empty .snapshotinfo and data.manifest in .hbase-snapshot dir, we got a lot of this warns on master server {code:java} WARN  [snapshot-hfile-cleaner-cache-refresher] snapshot.SnapshotFileCache: Failed to refresh snapshot hfile cache! org.apache.hadoop.hbase.snapshot.CorruptedSnapshotException: Couldn't read snapshot info from:hdfs://host/apps/hbase/data/.hbase-snapshot/test/.snapshotinfo{code} {color:#172b4d}how to reproduce:{color} * {color:#172b4d}create a folder (for example snap2) at the path /apps/base/data/.base-snapshot {color} * {color:#172b4d}create two empty files there: .snapshotinfo data.manifest {color} * {color:#172b4d}give a load, for example like this: hbase lt -write 1:10:100 -num_keys 1000000 -read 100:30 -num_tablets 20 -data_block_encoding NONE -tn load_test_tool {color} * {color:#172b4d}wait... {color} * {color:#172b4d}the /apps/base/data/archive folder will start to grow (approximately to the size of /apps/base/data/data) {color} * {color:#172b4d}if you delete the previously created snap2 folder, the size of /aps/base/data/archive will return to its original state{color}" Show the create time of the peer,13580987,Open,Minor,,30/May/24 09:14,,,"When the table data needs to be migrated due to the closure of the computer room or the business side needs to have a primary and standby table, we need to create a peer.  By checking the creation time of the peer, we can understand when and what operations were performed, and the impact of these operations on the HBase system status. When there is a problem with the HBase cluster, such as abnormal data synchronization, performance degradation, etc., displaying the creation time of the peer can help us quickly locate the possible source of the problem. For example, if a peer has a problem shortly after it is created, we can prioritize checking the configuration and status of the peer, optimize the related configuration of replication, etc. Recording the creation time of the peer helps to audit and track system changes, ensuring that any changes to the replication configuration can be traced. This is very important for meeting data governance, security compliance, and business continuity requirements." CanaryTool continues executing and scanning after timeout,13582618,Resolved,Minor,Fixed,13/Jun/24 23:55,19/Jun/24 19:24,2.0.0,"If you run the {{CanaryTool}} in region mode until it reaches the configured timeout, the logs and sink results will show that it can continue executing and scanning for 10 seconds. This is because the RegionTasks have already been submitted to an ExecutorService which continues execution after timeout, and the Monitor continues execution on a separate thread. The 10 second delay in shutdown is seen, in hbase 2.x at least, because {{runMonitor}} will close the {{Connection}} and that process ([code|https://github.com/apache/hbase/blob/e865c852c0e9a1e9b55b9d1512d379072d3e7a7b/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java#L1054-L1094]) will lead to {{ConnectionImplementation#close}} ([code|https://github.com/apache/hbase/blob/e865c852c0e9a1e9b55b9d1512d379072d3e7a7b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L2272-L2300]) and inside {{shutdownPools}} we will potentially wait the full 10 seconds of {{awaitTermination}} if client operations are in progress. The scenario can be improved by simply interrupting the monitor thread, as we will often be in an {{invokeAll}} call in a {{sniff}} method. The {{invokeAll}} method is blocking, and interrupting the monitor in this call will interrupt the client threads and generally shutdown properly and timely. However, we can be more robust by also watching for a shutdown signal in the various tasks such as {{RegionTask}} so any remaining tasks will drain quickly and without errors. This will remove a lot of errors from the canary logs during shutdown.   {code:java} 2024-06-12 02:57:14 [Time-limited test] ERROR tool.Canary(1076): The monitor is running too long (1140098) after timeout limit:1140000 will be killed itself !! 2024-06-12 02:57:14 [Time-limited test] INFO client.ConnectionImplementation(2039): Closing master protocol: MasterService 2024-06-12 02:57:14 [pool-3-thread-4] ERROR tool.Canary(353): Read from REGION1. on serverName=REGIONSERVER-1, columnFamily=0 failed java.lang.RuntimeException: java.util.concurrent.RejectedExecutionException: Task org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture@54f2a9a4 rejected from java.util.concurrent.ThreadPoolExecutor@2d3d204d[Shutting down, pool size = 7, active threads = 7, queued tasks = 0, completed tasks = 180094] at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:199) at org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:271) at org.apache.hadoop.hbase.client.ClientScanner.loadCache(ClientScanner.java:440) at org.apache.hadoop.hbase.client.ClientScanner.nextWithSyncCache(ClientScanner.java:314) at org.apache.hadoop.hbase.client.ClientScanner.next(ClientScanner.java:612) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.readColumnFamily(CanaryTool.java:565) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.read(CanaryTool.java:609) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:503) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:471) [... repeats for 10 seconds and tens of thousands of regions ... ] 2024-06-12 02:57:16 [pool-3-thread-11] ERROR tool.Canary(353): Read from REGION10000. on serverName=REGIONSERVER-2, columnFamily=0 failed java.lang.RuntimeException: java.util.concurrent.RejectedExecutionException: Task org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture@d08d21f rejected from java.util.concurrent.ThreadPoolExecutor@2d3d204d[Shutting down, pool size = 3, active threads = 3, queued tasks = 0, completed tasks = 180098] [...] 2024-06-12 02:57:24 [pool-3-thread-11] ERROR tool.Canary(353): Read from REGION42000. on serverName=REGIONSERVER-3, columnFamily=0 failed java.lang.RuntimeException: java.util.concurrent.RejectedExecutionException: Task org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture@38e7a5a1 rejected from java.util.concurrent.ThreadPoolExecutor@2d3d204d[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 180101] 2024-06-12T02:57:24.202Z, java.io.InterruptedIOException at org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.throwEnrichedException(RpcRetryingCallerWithReadReplicas.java:294) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:255) at org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(ScannerCallableWithReplicas.java:53) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:191) at org.apache.hadoop.hbase.client.ClientScanner.call(ClientScanner.java:271) at org.apache.hadoop.hbase.client.ClientScanner.loadCache(ClientScanner.java:440) at org.apache.hadoop.hbase.client.ClientScanner.nextWithSyncCache(ClientScanner.java:314) at org.apache.hadoop.hbase.client.ClientScanner.next(ClientScanner.java:612) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.readColumnFamily(CanaryTool.java:565) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.read(CanaryTool.java:609) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:503) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:471) 2024-06-12 02:57:24 [pool-3-thread-8] WARN client.ConnectionImplementation(428): Checking master connection org.apache.hadoop.hbase.ipc.StoppedRpcClientException: Call to address=HMASTER-1 failed on local exception: org.apache.hadoop.hbase.ipc.StoppedRpcClientException at sun.reflect.GeneratedConstructorAccessor27.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:206) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:391) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:425) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:420) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:114) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:129) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(AbstractRpcClient.java:446) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:332) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$200(AbstractRpcClient.java:92) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:595) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$BlockingStub.isMasterRunning(MasterProtos.java) at org.apache.hadoop.hbase.client.ConnectionImplementation$MasterServiceState.isMasterRunning(ConnectionImplementation.java:1235) at org.apache.hadoop.hbase.client.ConnectionImplementation.lambda$masterConnectionStateSupplier$1(ConnectionImplementation.java:421) at org.apache.hadoop.hbase.client.ConnectionImplementation.isKeepAliveMasterConnectedAndRunning(ConnectionImplementation.java:2025) at org.apache.hadoop.hbase.client.ConnectionImplementation.getKeepAliveMasterService(ConnectionImplementation.java:1441) at org.apache.hadoop.hbase.client.ConnectionImplementation.getMaster(ConnectionImplementation.java:1433) at org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:57) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:101) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3020) at org.apache.hadoop.hbase.client.HBaseAdmin.getTableDescriptor(HBaseAdmin.java:579) at org.apache.hadoop.hbase.client.HTable.getDescriptor(HTable.java:242) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.read(CanaryTool.java:593) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:503) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:471) 2024-06-12 02:57:24 [pool-3-thread-7] ERROR tool.Canary(345): Read from REGION43000. on serverName=REGIONSERVER-4 failed org.apache.hadoop.hbase.DoNotRetryIOException: Connection was closed while trying to get master at org.apache.hadoop.hbase.client.ConnectionImplementation$MasterServiceStubMaker.makeStub(ConnectionImplementation.java:1381) at org.apache.hadoop.hbase.client.ConnectionImplementation.getKeepAliveMasterService(ConnectionImplementation.java:1445) at org.apache.hadoop.hbase.client.ConnectionImplementation.getMaster(ConnectionImplementation.java:1433) at org.apache.hadoop.hbase.client.MasterCallable.prepare(MasterCallable.java:57) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:101) at org.apache.hadoop.hbase.client.HBaseAdmin.executeCallable(HBaseAdmin.java:3020) at org.apache.hadoop.hbase.client.HBaseAdmin.getTableDescriptor(HBaseAdmin.java:579) at org.apache.hadoop.hbase.client.HTable.getDescriptor(HTable.java:242) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.read(CanaryTool.java:593) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:503) at org.apache.hadoop.hbase.tool.CanaryTool$RegionTask.call(CanaryTool.java:471){code}" Removing missing scanner via REST should return 404,13582526,Resolved,Minor,Fixed,13/Jun/24 12:06,19/Jun/24 08:31,,"We do not handle the case when the user is trying to remove a missing scanner, and let an NPE bubble up to Jersey. We should check or catch the error and return 404 instead." REST multiget endpoint returns 500 error if no rows are specified,13582218,Resolved,Minor,Fixed,11/Jun/24 05:43,18/Jun/24 13:50,,"Should return 404 instead. Need to check if there are any ""row"" params before trying to iterate over them {noformat} Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.rest.MultiRowResource.get(MultiRowResource.java:100) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hbase.thirdparty.org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52) at org.apache.hbase.thirdparty.org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:134) at org.apache.hbase.thirdparty.org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:177) at {noformat} " Dropping unclosed WALTailingReaders leads to leaked sockets,13582714,Resolved,Minor,Fixed,14/Jun/24 15:34,16/Jun/24 02:36,2.6.0,"{{WALEntryStream#prepareReader()}} will, in some cases, reach [the line|https://github.com/apache/hbase/blob/ba15d67a350adb11ae1d4c44d214216406ae0b5a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java#L258] {code} reader = WALFactory.createTailingReader(fs, nextPath, conf, currentPositionOfEntry > 0 ? currentPositionOfEntry : -1); {code} when {{reader}} is non-null. In this case, the old object pointed to by {{reader}} becomes un-referenced and is garbage-collected. However, that object was never closed. At Hubspot we see the effects of this when doing tests that use inter-cluster replication. Machines in the source cluster experience a build-up of sockets. Eventually this causes the machine to run out of TCP kernel memory and start dropping packets. The only workaround currently is to restart the RegionServer process. I have found that simply putting {code} closeReader(); {code} immediately before the line quoted above appears to resolve the issue and causes no obvious problems. However, I'm still developing a proper test for this fix." Log hfile name when unpack is failed,13582747,Open,Minor,,14/Jun/24 22:09,,,"When an HFile block is corrupted, identifying the corrupt HFile name is challenging because we only log a ""Corrupted block detected"" message. So, we should log the HFile name (fileContext.getHFileName()) whenever an unpack operation is unsuccessful.   Ref: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java#L659 !Screenshot 2024-06-14 at 2.59.04 PM.png!" Cache Results in org.apache.hadoop.hbase.rest.client.RemoteHTable.Scanner,13576694,Resolved,Minor,Fixed,22/Apr/24 07:52,07/Jun/24 08:09,,"The implementation of org.apache.hadoop.hbase.rest.client.RemoteHTable.Scanner is very inefficient, as the standard next() methods makes separate a http request for each row. Performance can be improved by not specifying the row count in the REST call and caching the returned Results. Chunk size can still be influenced by scan.setBatch(); " Introduce a field to display whether the snapshot is expired,13580245,Resolved,Minor,Fixed,23/May/24 10:18,05/Jun/24 15:50,,"HBase supports to create snapshot with TTL, and expired snapshots will be periodically deleted. This period is 30 min by default, as follow. {code:java} private static final String SNAPSHOT_CLEANER_INTERVAL = ""hbase.master.cleaner.snapshot.interval""; private static final int SNAPSHOT_CLEANER_DEFAULT_INTERVAL = 1800 * 1000; // Default 30 min {code}   Therefore, the following situation may occur:  The expired snapshot would still exist for a period of time on hbase cluster, and would not be deleted until the next operation of the periodic thread. So, Sometimes, we may use the expired snapshot because we donot know whether the snapshot is expired.   So, I think we can introduce a expired field for this situation in HBase UI. And on hbase shell ,adding snapshot TTL info and displaying expired if the snaphost has already expired. Or any better suggestions? Thanks a lot!" Fix the inaccurate message when snapshot doesn't exist,13580548,Resolved,Minor,Fixed,27/May/24 11:57,06/Jun/24 14:33,2.4.13,"We would get the as following message when restore a non-existing snapshot. {code:java} hbase:021:0> restore_snapshot  'non_existing_snap' ERROR: Unable to find the table name for snapshot=non_existing_snap For usage try 'help ""restore_snapshot""' Took 0.0170 seconds {code}   ERROR: {color:#FF0000}Unable to find the table{color} name for snapshot=non_existing_snap This error message is inaccurate." Doc for the config of hbase.ipc.sserver.callqueue.read.ratio is misleading,13580982,Resolved,Minor,Fixed,30/May/24 08:41,01/Jun/24 15:11,,"Doc for the config of hbase.ipc.sserver.callqueue.read.ratio is misleading. Fix the explanation for the configuration of hbase.ipc.sserver.callqueue.read.ratio" test,13580050,Resolved,Minor,Abandoned,22/May/24 04:26,26/May/24 14:09,,111 Client Does not Stop Retrying after DoNotRetryException,13578953,Open,Minor,,11/May/24 15:03,,1.2.0,"I recently discovered that the fix for HBase-14598 does not completely resolve the issue. Their fix addressed two aspects: first, when the Scan/Get RPC attempts to allocate a very large array that could potentially lead to an out-of-memory (OOM) error, it will check the size of the array before allocation and directly throw an exception to prevent the region server from crashing and avoid possible cascading failures. Second, the developer intends for the client to stop retrying after such a failure, as retrying will not resolve the issue. However, their fix involved throwing a DoNotRetryException. After ByteBufferOutputStream.write throws the DoNotRetryException, in the call stack (ByteBufferOutputStream.write --> encoder.write --> encodeCellsTo --> his.cellBlockBuilder.buildCellBlockStream --> call.setResponse), the DoNotRetryException is ultimately caught in the CallRunner.run function, with only a log printed. Consequently, the DoNotRetryException is not sent back to the client side. Instead, the client receives a generic exception for the failed RPC request and continues retrying, which is not the desired behavior. I have reproduced this on the cluster. In the code of CallRunner, it is obvious that the DoNotRetryException in call.setResponse will be swallowed in the error handler with just a LOG printed." Closing ZooKeeper in ZKMainServer,13578015,Resolved,Minor,Fixed,03/May/24 00:37,08/May/24 08:02,,"Users can switch the Zookeeper client/server communication framework to Netty. ZKMainServer process fails to terminate due to when users utilize Netty for ZooKeeper connections. Netty threads identified as non-Daemon threads. Enforce the calling of close() on ZooKeeper before ZKMainServer termination." Always printing error log when snapshot table ,13578442,Resolved,Minor,Fixed,07/May/24 15:18,08/May/24 08:01,2.4.13,"Reproduction. 1.  Disable snapshot procedure if your hbase support snapshot procedure feature Set hbase.snapshot.procedure.enabled to false to disable snapshot procedure. 2. Executing snapshot against a table, this step is no problem snapshot 't01', 'sn0001' 3.  HBase outputs error logs, as follow. 2024-05-07T23:16:37,175 ERROR [MASTER_SNAPSHOT_OPERATIONS-master/archlinux:16000-0] snapshot.TakeSnapshotHandler: Couldn't delete snapshot working directory:file:/opt/hbase/hbase-4.0.0-alpha-1-SNAPSHOT/tmp/hbase/.hbase-snapshot/.tmp/sn001   The Reason. HBase would clean tmp of the snapshot after snapshot.  The tmp would be empty if snapshot was executed successfully We would get false when calling `Filesystem.delete()` to delete the tmp which does not exist, so hbase outputs error logs." Fix `Disable Stripe Compaction` run error in document,13576381,Resolved,Trivial,Fixed,18/Apr/24 13:53,18/May/24 09:13,2.5.6,"*Disable Stripe Compaction* in document is {code:java} alter 'orders_table', CONFIGURATION => {'hbase.hstore.engine.class' => 'rg.apache.hadoop.hbase.regionserver.DefaultStoreEngine'}{code} This should be 'org.apache.hadoop.hbase.regionserver.DefaultStoreEngine'  This will cause all regions to be in the openning state.Finally, I went through the disable table and corrected it before enable it.    " Visualize current state of region assignment,13377306,Resolved,Blocker,Fixed,07/May/21 18:23,15/Mar/22 20:24,,"After several months of debugging and tuning the balancer and normalizer on a large production cluster, we found that working from visualizations of the current region state was very useful for understanding behaviors and quantifying improvements we made along the way. Specifically, we found that a chart of total assigned region count and total assigned region store files size per table per host was immensely useful for tuning the balancer. Histograms of store file size made understanding normalizer activity much more intuitive. Our scripts would parse the output of the shell's {{status 'detailed'}} command, extract the desired metric, and produce charts. I'd like to build into the master UI the equivalent functionality, with data coming directly from the {{ClusterMetrics object}}, and data rendered into an interactive chart rendered in the browser." Shutdown of WAL stuck at waitForSafePoint,13380042,Resolved,Blocker,Fixed,24/May/21 08:11,01/Dec/21 00:37,2.0.0,"We use the fan-out HDFS OutputStream and AsyncFSWAL on our clusters, but met the problem than RS can not exit completely for several hours util manual interventions. The two jstacks below show that the regionserver thread can waiting unlimitedly in both  AsyncFSWAL#waitForSafePoint() {code:java} ""regionserver/gh-data-hbase-finance08.mt/10.22.179.24:16020"" #29 prio=5 os_prio=0 tid=0x00007fb2feb5c000 nid=0xa92b waiting on condition [0x00007f9ccb992000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00007faea229a9d0> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitUninterruptibly(AbstractQueuedSynchronizer.java:1976) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.waitForSafePoint(AsyncFSWAL.java:687) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.doShutdown(AsyncFSWAL.java:743) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.shutdown(AbstractFSWAL.java:900) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.shutdown(AbstractFSWALProvider.java:182) at org.apache.hadoop.hbase.wal.RegionGroupingProvider.shutdown(RegionGroupingProvider.java:232) at org.apache.hadoop.hbase.wal.WALFactory.shutdown(WALFactory.java:271) at org.apache.hadoop.hbase.regionserver.HRegionServer.shutdownWAL(HRegionServer.java:1405) at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1147) at java.lang.Thread.run(Thread.java:745) {code} and the log roller stuck at waiting for lock {code:java} ""regionserver/gh-data-hbase-finance08.mt/10.22.179.24:16020.logRoller"" #322 daemon prio=5 os_prio=0 tid=0x00007fb2e11a4000 nid=0xa953 waiting on condition [0x00007f9cbd9f1000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00007faea1217048> (a java.util.concurrent.locks.ReentrantLock$FairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199) at java.util.concurrent.locks.ReentrantLock$FairSync.lock(ReentrantLock.java:224) at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:822) at org.apache.hadoop.hbase.wal.AbstractWALRoller$RollController.rollWal(AbstractWALRoller.java:269) at org.apache.hadoop.hbase.wal.AbstractWALRoller.run(AbstractWALRoller.java:186){code}  " [branch-1] add -U for maven build to force a check for updated releases and snapshots on remote repositories,13378434,Resolved,Blocker,Fixed,14/May/21 07:31,20/Oct/21 08:50,,"{code} [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Could not find artifact org.apache.hbase:hbase-thrift:jar:1.7.0 in apache release (https://repository.apache.org/content/repositories/releases/) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :hbase-assembly {code} {code} [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Failure to find org.apache.hbase:hbase-thrift:jar:1.7.0 in https://repository.apache.org/content/repositories/releases/ was cached in the local repository, resolution will not be reattempted until the update interval of apache release has elapsed or updates are forced -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :hbase-assembly {code}" [branch-1] make hbase-thrift optional in hbase-assembly module,13377016,Resolved,Blocker,Fixed,06/May/21 11:00,20/Oct/21 07:13,,"{code} [ERROR] Failed to execute goal on project hbase-assembly: Could not resolve dependencies for project org.apache.hbase:hbase-assembly:pom:1.7.0: Failure to find org.apache.hbase:hbase-thrift:jar:1.7.0 in https://repository.apache.org/content/repositories/releases/ was cached in the local repository, resolution will not be reattempted until the update interval of apache release has elapsed or updates are forced -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException {code}" [branch-1] remove thrift examples out of hbase-examples module for bypassing the thrift version check,13376004,Resolved,Blocker,Fixed,30/Apr/21 09:00,20/Oct/21 07:11,,"[ERROR] Failed to execute goal on project hbase-examples: Could not resolve dependencies for project org.apache.hbase:hbase-examples:jar:1.7.0: Could not find artifact org.apache.hbase:hbase-thrift:jar:1.7.0 in apache release (https://repository.apache.org/content/repositories/releases/) -> [Help 1] This is the msg when I tried to run make_rc.sh, we need to remove thrift related codes from hbase-examples for making release successfully." [branch-1] Make hbase-thrift module build with jdk8,13374415,Resolved,Blocker,Fixed,22/Apr/21 13:44,20/Oct/21 06:39,, Master has completed initialization but hbase shell can't connect and throw a unhandledexception,13378265,Open,Blocker,,13/May/21 08:08,,2.2.2,"I modified some values in the hbase-site.xml file, and then ran hbase in stand-alone mode. Hbase can be initialized normally, but the connection from the client cannot be processed, and the client will throw an unhandled exception.  Please see the attachment for the configuration file, log information and error information" HBase Write may be stuck forever when using CompactingMemStore,13385395,Resolved,Critical,Fixed,23/Jun/21 11:31,12/Aug/21 15:27,2.3.0,"Sometimes I observed that HBase Write might be stuck in my hbase cluster which enabling {{{}CompactingMemStore{}}}. I have simulated the problem by unit test in my PR. The problem is caused by {{CompactingMemStore.checkAndAddToActiveSize}} : {code:java} 425 private boolean checkAndAddToActiveSize(MutableSegment currActive, Cell cellToAdd, 426 MemStoreSizing memstoreSizing) { 427 if (shouldFlushInMemory(currActive, cellToAdd, memstoreSizing)) { 428 if (currActive.setInMemoryFlushed()) { 429 flushInMemory(currActive); 430 if (setInMemoryCompactionFlag()) { 431 // The thread is dispatched to do in-memory compaction in the background ...... } {code} In line 427, {{shouldFlushInMemory}} checking if {{currActive.getDataSize}} adding the size of {{cellToAdd}} exceeds {{{}CompactingMemStore.inmemoryFlushSize{}}},if true, then {{currActive}} should be flushed, {{currActive.setInMemoryFlushed()}} is invoked in line 428 ： {code:java} public boolean setInMemoryFlushed() { return flushed.compareAndSet(false, true); } {code} After sucessfully set {{currActive.flushed}} to true, in above line 429 {{flushInMemory(currActive)}} invokes {{CompactingMemStore.pushActiveToPipeline}} : {code:java} protected void pushActiveToPipeline(MutableSegment currActive) { if (!currActive.isEmpty()) { pipeline.pushHead(currActive); resetActive(); } } {code} In above {{CompactingMemStore.pushActiveToPipeline}} method , if the {{currActive.cellSet}} is empty, then nothing is done. Due to concurrent writes and because we first add cell size to {{currActive.getDataSize}} and then actually add cell to {{{}currActive.cellSet{}}}, it is possible that {{currActive.getDataSize}} could not accommodate {{cellToAdd}} but {{currActive.cellSet}} is still empty if pending writes which not yet add cells to {{{}currActive.cellSet{}}}. So if the {{currActive.cellSet}} is empty now, then no {{ActiveSegment}} is created, and new writes still continue target to {{{}currActive{}}}, but {{currActive.flushed}} is true, {{currActive}} could not enter {{flushInMemory(currActive)}} again，and new {{ActiveSegment}} could not be created forever ! In the end all writes would be stuck. In my opinion , once {{currActive.flushed}} is set true, it could not continue use as {{ActiveSegment}} , and because of concurrent pending writes, only after {{currActive.updatesLock.writeLock()}} is acquired(i.e. {{currActive.waitForUpdates}} is called) in {{CompactingMemStore.inMemoryCompaction}} ,we can safely say {{currActive}} is empty or not. My fix is remove the {{if (!currActive.isEmpty())}} check here and left the check to background {{InMemoryCompactionRunnable}} after {{currActive.waitForUpdates}} is called. An alternative fix is we use synchronization mechanism in {{checkAndAddToActiveSize}} method to prevent all writes , wait for all pending write completed(i.e. currActive.waitForUpdates is called) and if {{currActive}} is still empty ,then we set {{currActive.flushed}} back to false,but I am not inclined to use so heavy synchronization in write path, and I think we would better maintain lockless implementation for {{CompactingMemStore.add}} method just as now and {{currActive.waitForUpdates}} would better be left in background {{{}InMemoryCompactionRunnable{}}}." DBB released too early and dirty data for some operations,13386464,Resolved,Critical,Fixed,29/Jun/21 08:31,14/Jul/21 08:44,2.0.0,"Before HBASE-25187, we found there are regionserver JVM crashing problems on our production clusters, the coredump infos are as follows, {code:java} Stack: [0x00007f621ba8d000,0x00007f621bb8e000], sp=0x00007f621bb8c0e0, free space=1020k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) J 10829 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.getTimestamp()J (9 bytes) @ 0x00007f6a5ee11b2d [0x00007f6a5ee11ae0+0x4d] J 22844 C2 org.apache.hadoop.hbase.regionserver.HRegion.doCheckAndRowMutate([B[B[BLorg/apache/hadoop/hbase/filter/CompareFilter$CompareOp;Lorg/apache/hadoop/hbase/filter/ByteArrayComparable;Lorg/apache/hadoop/hbase/client/RowMutations;Lorg/apache/hadoop/hbase/client/Mutation;Z)Z (540 bytes) @ 0x00007f6a60bed144 [0x00007f6a60beb320+0x1e24] J 17972 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.checkAndRowMutate(Lorg/apache/hadoop/hbase/regionserver/Region;Ljava/util/List;Lorg/apache/hadoop/hbase/CellScanner;[B[B[BLorg/apache/hadoop/hbase/filter/CompareFilter$CompareOp;Lorg/apache/hadoop/hbase/filter/ByteArrayComparable;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$RegionActionResult$Builder;)Z (312 bytes) @ 0x00007f6a5f4a7ed0 [0x00007f6a5f4a6f40+0xf90] J 26197 C2 org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(Lorg/apache/hbase/thirdparty/com/google/protobuf/RpcController;Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiRequest;)Lorg/apache/hadoop/hbase/shaded/protobuf/generated/ClientProtos$MultiResponse; (644 bytes) @ 0x00007f6a61538b0c [0x00007f6a61537940+0x11cc] J 26332 C2 org.apache.hadoop.hbase.ipc.RpcServer.call(Lorg/apache/hadoop/hbase/ipc/RpcCall;Lorg/apache/hadoop/hbase/monitoring/MonitoredRPCHandler;)Lorg/apache/hadoop/hbase/util/Pair; (566 bytes) @ 0x00007f6a615e8228 [0x00007f6a615e79c0+0x868] J 20563 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1196 bytes) @ 0x00007f6a60711a4c [0x00007f6a60711000+0xa4c] J 19656% C2 org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(Ljava/util/concurrent/BlockingQueue;Ljava/util/concurrent/atomic/AtomicInteger;)V (338 bytes) @ 0x00007f6a6039a414 [0x00007f6a6039a320+0xf4] j org.apache.hadoop.hbase.ipc.RpcExecutor$1.run()V+24 j java.lang.Thread.run()V+11 v ~StubRoutines::call_stub {code} I have made a UT to reproduce this error, it can occur 100%。 After HBASE-25187，the check result of the checkAndMutate will be false, because it read wrong/dirty data from the released ByteBuff." MOB data loss - incorrect concatenation of MOB_FILE_REFS ,13382158,Resolved,Critical,Fixed,04/Jun/21 14:09,19/Aug/22 10:54,3.0.0-alpha-1,"Active MOB files can be deleted by MobFileCleanerChore. The MOB_FILE_REFS are wrongly concatenated when multiple files or tables are stored. During the MOB cleanup HBase wants to keep the incorrectly concatenated file and considers the real file as deletable. {noformat} 2021-06-03 15:03:09,876 TRACE org.apache.hadoop.hbase.mob.MobFileCleanerChore: Specific mob references found for store=hdfs://c1377-node2.coelab.cloudera.com:8020/hbase/data/default/IntegrationTestIngestWithMOB/1df6561244ecc434f505501e6bda9af0/test_cf/2956445a41184488b914e93199df905a : {IntegrationTestIngestWithMOB=[d41d8cd98f00b204e9800998ecf8427e20210603a6c8c0e5bf8548649b0009b156452c21_1df6561244ecc434f505501e6bda9af0d41d8cd98f00b204e9800998ecf8427e20210603497714eabbe5418c9d52382a4808e986_1df6561244ecc434f505501e6bda9af0, d41d8cd98f00b204e9800998ecf8427e202106037464cbddc86943a1bad77d52a3bd412c_1df6561244ecc434f505501e6bda9af0]} ... 2021-06-03 15:03:10,208 TRACE org.apache.hadoop.hbase.mob.MobFileCleanerChore: Archiving MOB file hdfs://c1377-node2.coelab.cloudera.com:8020/hbase/mobdir/data/default/IntegrationTestIngestWithMOB/e9b5d936e7f55a4f1c3246a8d5ce53c2/test_cf/d41d8cd98f00b204e9800998ecf8427e20210603497714eabbe5418c9d52382a4808e986_1df6561244ecc434f505501e6bda9af0 creation time=1622729860319 2021-06-03 15:03:10,467 DEBUG org.apache.hadoop.hbase.mob.MobFileCleanerChore: MOB Cleaner is archiving: hdfs://c1377-node2.coelab.cloudera.com:8020/hbase/mobdir/data/default/IntegrationTestIngestWithMOB/e9b5d936e7f55a4f1c3246a8d5ce53c2/test_cf/d41d8cd98f00b204e9800998ecf8427e20210603497714eabbe5418c9d52382a4808e986_1df6561244ecc434f505501e6bda9af0 {noformat}" Corruption in recovered WAL in WALSplitter,13378863,Resolved,Critical,Won't Fix,17/May/21 18:16,09/Aug/22 08:06,1.6.0,"Recently we encountered RS aborts due to NPE while replaying edits from split logs during region open. {noformat} 2021-05-13 19:34:28,871 ERROR [:60020-17] handler.OpenRegionHandler - Failed open of region=,1619036437822.0556ab96be88000b6f5f3fad47938ccd., starting to roll back the global memstore size. java.lang.NullPointerException at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:411) at org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEdits(HRegion.java:4682) at org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsForPaths(HRegion.java:4557) at org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsIfAny(HRegion.java:4470) at org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:949) at org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:908) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7253) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7214) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7185) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7141) at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7092) at org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:364) at org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:131) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} Tracing back how the corrupt wal was generated. {noformat} 2021-05-12 05:21:23,333 FATAL [:60020-0-Writer-1] wal.WALSplitter - 556ab96be88000b6f5f3fad47938ccd/5039807= to log java.nio.channels.ClosedChannelException at org.apache.hadoop.hdfs.DataStreamer$LastExceptionInStreamer.throwException4Close(DataStreamer.java:331) at org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:151) at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105) at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:58) at java.io.DataOutputStream.write(DataOutputStream.java:107) at org.apache.hadoop.hbase.KeyValue.write(KeyValue.java:2543) at org.apache.phoenix.hbase.index.wal.KeyValueCodec.write(KeyValueCodec.java:104) at org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$IndexKeyValueEncoder.write(IndexedWALEditCodec.java:218) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:128) at org.apache.hadoop.hbase.wal.WALSplitter$LogRecoveredEditsOutputSink.appendBuffer(WALSplitter.java:1742) at org.apache.hadoop.hbase.wal.WALSplitter$LogRecoveredEditsOutputSink.append(WALSplitter.java:1714) at org.apache.hadoop.hbase.wal.WALSplitter$WriterThread.writeBuffer(WALSplitter.java:1179) at org.apache.hadoop.hbase.wal.WALSplitter$WriterThread.doRun(WALSplitter.java:1171) at org.apache.hadoop.hbase.wal.WALSplitter$WriterThread.run(WALSplitter.java:1141) 2021-05-12 05:21:23,333 ERROR [:60020-0-Writer-1] wal.WALSplitter - Exiting thread java.nio.channels.ClosedChannelException at org.apache.hadoop.hdfs.DataStreamer$LastExceptionInStreamer.throwException4Close(DataStreamer.java:331) at org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:151) at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105) at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:58) at java.io.DataOutputStream.write(DataOutputStream.java:107) at org.apache.hadoop.hbase.KeyValue.write(KeyValue.java:2543) at org.apache.phoenix.hbase.index.wal.KeyValueCodec.write(KeyValueCodec.java:104) at org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$IndexKeyValueEncoder.write(IndexedWALEditCodec.java:218) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:128) at org.apache.hadoop.hbase.wal.WALSplitter$LogRecoveredEditsOutputSink.appendBuffer(WALSplitter.java:1742) at org.apache.hadoop.hbase.wal.WALSplitter$LogRecoveredEditsOutputSink.append(WALSplitter.java:1714) at org.apache.hadoop.hbase.wal.WALSplitter$WriterThread.writeBuffer(WALSplitter.java:1179) at org.apache.hadoop.hbase.wal.WALSplitter$WriterThread.doRun(WALSplitter.java:1171) at org.apache.hadoop.hbase.wal.WALSplitter$WriterThread.run(WALSplitter.java:1141) {noformat} 3 milliseconds ago, it looks like we closed the log file {noformat} 2021-05-12 05:21:23,330 DEBUG [it-log-closeStream-1] wal.WALSplitter - Closed wap hdfs:///hbase/data/default//0556ab96be88000b6f5f3fad47938ccd/recovered.edits/0000000000005039408-%2C60020%2C1620792238779.1620794103718.temp (wrote 85 edits, skipped 0 edits in 204ms 2021-05-12 05:21:23,343 INFO [it-log-closeStream-1] wal.WALSplitter - Rename hdfs:///hbase/data/default//0556ab96be88000b6f5f3fad47938ccd/recovered.edits/0000000000005039408-%2C60020%2C1620792238779.1620794103718.temp to hdfs:///hbase/data/default//0556ab96be88000b6f5f3fad47938ccd/recovered.edits/0000000000005039806 {noformat} It looks like we closed the log file while the writer thread is still writing to it. Here is the code from branch-1 {code:java} @Override public List finishWritingAndClose() throws IOException { boolean isSuccessful = false; List result = null; try { isSuccessful = finishWriting(false); ----> Received an exception in this method. Writer is still writing. } finally { result = close(); ------> We close the log file here List thrown = closeLogWriters(null); -------> We close the writer here. if (thrown != null && !thrown.isEmpty()) { throw MultipleIOException.createIOException(thrown); } } {code} We *should close the writer first* and then close the log file. SplitLogWorker thread exited with the following exception couple of seconds ago. {noformat} 2021-05-12 05:21:19,060 INFO [:60020] regionserver.SplitLogWorker - Sending interrupt to stop the worker thread 2021-05-12 05:21:19,064 INFO [/:60020] regionserver.HRegionServer - Stopping infoServer 2021-05-12 05:21:19,064 WARN [:60020] coordination.ZkSplitLogWorkerCoordination - Interrupted while yielding for other region servers java.lang.InterruptedException: sleep interrupted at java.lang.Thread.sleep(Native Method) at org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination.grabTask(ZkSplitLogWorkerCoordination.java:274) at org.apache.hadoop.hbase.coordination.ZkSplitLogWorkerCoordination.taskLoop(ZkSplitLogWorkerCoordination.java:426) at org.apache.hadoop.hbase.regionserver.SplitLogWorker.run(SplitLogWorker.java:148) at java.lang.Thread.run(Thread.java:748) 2021-05-12 05:21:19,065 INFO [:60020] regionserver.SplitLogWorker - SplitLogWorker ,60020,1620796868880 exiting {noformat}" It is not reliable to use nodeDeleted event to track region server's death,13385452,Resolved,Critical,Fixed,23/Jun/21 15:40,30/Jun/21 03:54,,"When implementing HBASE-26011, [~sunxin] pointed out an interesting scenario, where a region server up and down between two sync requests, then we can not know the death of the region server. https://github.com/apache/hbase/pull/3405#discussion_r656720923 This is a valid point, and when thinking of a solution, I noticed that, the current zk iplementation has the same problem. Notice that, a watcher on zk can only be triggered once, so after zk triggers the watcher, and before you set a new watcher, it is possible that a region server is up and down, and you will miss the nodeDeleted event for this region server. I think, the general approach here, which could works for both master based and zk based replication tracker is that, we should not rely on the tracker to tell you which region server is dead. Instead, we just provide the list of live regionservers, and the upper layer should compare this list with the expected list(for replication, the list should be gotten by listing replicators), to detect the dead region servers." Upgrade hbase-thirdparty dependency to 3.5.1,13380399,Resolved,Critical,Fixed,25/May/21 18:57,28/Jan/22 05:07,,Recently we have fixed multiple CVEs from jetty & netty as part of HBASE-25728 & HBASE-25746.  This Jira is to upgrade hbase-thirdparty jar version. FSHLog WAL lockup with sync future reuse [RS deadlock],13382792,Resolved,Critical,Fixed,08/Jun/21 21:08,19/Jun/21 00:49,1.7.0,"We use FSHLog as the WAL implementation (branch-1 based) and under heavy load we noticed the WAL system gets locked up due to a subtle bug involving racy code with sync future reuse. This bug applies to all FSHLog implementations across branches. Symptoms: On heavily loaded clusters with large write load we noticed that the region servers are hanging abruptly with filled up handler queues and stuck MVCC indicating appends/syncs not making any progress. {noformat} WARN [8,queue=9,port=60020] regionserver.MultiVersionConcurrencyControl - STUCK for : 296000 millis. MultiVersionConcurrencyControl{readPoint=172383686, writePoint=172383690, regionName=1ce4003ab60120057734ffe367667dca} WARN [6,queue=2,port=60020] regionserver.MultiVersionConcurrencyControl - STUCK for : 296000 millis. MultiVersionConcurrencyControl{readPoint=171504376, writePoint=171504381, regionName=7c441d7243f9f504194dae6bf2622631} {noformat} All the handlers are stuck waiting for the sync futures and timing out. {noformat} java.lang.Object.wait(Native Method) org.apache.hadoop.hbase.regionserver.wal.SyncFuture.get(SyncFuture.java:183) org.apache.hadoop.hbase.regionserver.wal.FSHLog.blockOnSync(FSHLog.java:1509) ..... {noformat} Log rolling is stuck because it was unable to attain a safe point {noformat} java.util.concurrent.CountDownLatch.await(CountDownLatch.java:277) org.apache.hadoop.hbase.regionserver.wal.FSHLog$SafePointZigZagLatch.waitSafePoint(FSHLog.java:1799) org.apache.hadoop.hbase.regionserver.wal.FSHLog.replaceWriter(FSHLog.java:900) {noformat} and the Ring buffer consumer thinks that there are some outstanding syncs that need to finish.. {noformat} org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.attainSafePoint(FSHLog.java:2031) org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1999) org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1857) {noformat} On the other hand, SyncRunner threads are idle and just waiting for work implying that there are no pending SyncFutures that need to be run {noformat} sun.misc.Unsafe.park(Native Method) java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442) org.apache.hadoop.hbase.regionserver.wal.FSHLog$SyncRunner.run(FSHLog.java:1297) java.lang.Thread.run(Thread.java:748) {noformat} Overall the WAL system is dead locked and could make no progress until it was aborted. I got to the bottom of this issue and have a patch that can fix it (more details in the comments due to word limit in the description)." Add missing CFs in meta during HBase 1 to 2.3+ Upgrade,13379549,Resolved,Critical,Fixed,20/May/21 16:28,01/Jul/21 10:08,2.3.0,"Making note of this issue in case others run into it. At my place of employ, we tried to upgrade a cluster that was an hbase-1.2.x version to an hbase-2.3.5 but it failed because meta didn't have the 'table' column family. Up to 2.3.0, hbase:meta was hardcoded. HBASE-12035 added the 'table' CF for hbase-2.0.0. HBASE-23782 (2.3.0) undid hardcoding of the hbase:meta schema; i.e. reading hbase:meta schema from the filesystem. The hbase:meta schema is only created on initial install. If an upgrade over existing data, the hbase-1 hbase:meta will not be suitable for hbase-2.3.x context as it will be missing columnfamilies needed to run (HBASE-23055 made it so hbase:meta could be altered (2.3.0) but probably of no use since Master won't come up). It would be a nice-to-have if a user could go from hbase1 to hbase.2.3.0 w/o having to first install an hbase2 that is earlier than 2.3.0 but needs to be demand before we would work on it; meantime, install an intermediate hbase2 version before going to hbase-2.3.0+ if coming from hbase-1.x" RegionServer JVM crash when compaction,13380663,Resolved,Critical,Fixed,27/May/21 04:58,03/Jun/21 10:05,2.3.5,"In our cluster, we found region servers may be crashed in several cases. In hs_err_pid27712.log: {code:java} Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) J 2687 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007f85c987eda7 [0x00007f85c987ed40+0x67] J 5884 C1 org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V (62 bytes) @ 0x00007f85c93fd904 [0x00007f85c93fd780+0x184] J 4274 C1 org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V (73 bytes) @ 0x00007f85c9d57a94 [0x00007f85c9d574a0+0x5f4] J 5211 C2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V (69 bytes) @ 0x00007f85ca039a34 [0x00007f85ca0399a0+0x94] J 5985 C1 org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I (59 bytes) @ 0x00007f85c9296a34 [0x00007f85c92964c0+0x574] J 6011 C1 org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B (5 bytes) @ 0x00007f85c913e094 [0x00007f85c913d4c0+0xbd4] J 6004 C1 org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;Ljava/util/function/Function;)Ljava/lang/String; (211 bytes) @ 0x00007f85c93737b4 [0x00007f85c93722e0+0x14d4] J 6000 C1 org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;)Ljava/lang/String; (10 bytes) @ 0x00007f85c9854d14 [0x00007f85c9854ba0+0x174] j org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.getMidpoint(Lorg/apache/hadoop/hbase/CellComparator;Lorg/apache/hadoop/hbase/Cell;Lorg/apache/hadoop/hbase/Cell;Lorg/apache/hadoop/hbase/io/hfile/HFileContext;)Lorg/apache/hadoop/hbase/Cell;+132 j org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.finishBlock()V+102 j org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.checkBlockBoundary()V+32 j org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.append(Lorg/apache/hadoop/hbase/Cell;)V+77 j org.apache.hadoop.hbase.regionserver.StoreFileWriter.append(Lorg/apache/hadoop/hbase/Cell;)V+20 j org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$FileDetails;Lorg/apache/hadoop/hbase/regionserver/InternalScanner;Lorg/apache/hadoop/hbase/regionserver/CellSink;JZLorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;ZI)Z+318 j org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionRequestImpl;Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$InternalScannerFactory;Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$CellSinkFactory;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+221 j org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionRequestImpl;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+12 j org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+16 j org.apache.hadoop.hbase.regionserver.HStore.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionContext;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+194 {code} In hs_err_pid28814.log: {code:java} Stack: [0x00007f6d8e69b000,0x00007f6d8e6dc000], sp=0x00007f6d8e6d9e88, free space=251k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x747fa0] J 2989 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0 bytes) @ 0x00007f751db756e1 [0x00007f751db75600+0xe1] j org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36 j org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69 j org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39 j org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31 J 12082 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.getQualifierArray()[B (5 bytes) @ 0x00007f751ef15fbc [0x00007f751ef15dc0+0x1fc] J 16584 C2 org.apache.hadoop.hbase.CellUtil.getCellKeyAsString(Lorg/apache/hadoop/hbase/Cell;Ljava/util/function/Function;)Ljava/lang/String; (211 bytes) @ 0x00007f751fe320b8 [0x00007f751fe31b80+0x538] J 17007 C2 org.apache.hadoop.hbase.regionserver.StoreFileWriter.append(Lorg/apache/hadoop/hbase/Cell;)V (31 bytes) @ 0x00007f751fc2c0f4 [0x00007f751fc2aac0+0x1634] J 17178 C2 org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$FileDetails;Lorg/apache/hadoop/hbase/regionserver/InternalScanner;Lorg/apache/hadoop/hbase/regionserver/CellSink;JZLorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;ZI)Z (767 bytes) @ 0x00007f751f8e330c [0x00007f751f8e2960+0x9ac] j org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionRequestImpl;Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$InternalScannerFactory;Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$CellSinkFactory;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+221 j org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionRequestImpl;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+12 j org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+16 j org.apache.hadoop.hbase.regionserver.HStore.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionContext;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List;+194 {code} Sometimes, RS is not crashed but we can see the following logs: {code:java} 2021-05-27T12:53:54,465 ERROR [RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=40769-shortCompactions-2] regionserver.CompactSplit$CompactionRunner(640): Compaction failed Request=regionName=t1,user00000000000000000080,1622091224198.cf38ea5f2ea0d90163b53c2b2fd329d2., storeName=A, fileCount=2, fileSize=2.0 M (1009.7 K, 1009.7 K), priority=1, time=16220912334172021-05-27T12:53:54,465 ERROR [RpcServer.default.FPBQ.Fifo.handler=2,queue=0,port=40769-shortCompactions-2] regionserver.CompactSplit$CompactionRunner(640): Compaction failed Request=regionName=t1,user00000000000000000080,1622091224198.cf38ea5f2ea0d90163b53c2b2fd329d2., storeName=A, fileCount=2, fileSize=2.0 M (1009.7 K, 1009.7 K), priority=1, time=1622091233417java.lang.IllegalArgumentException: Left byte array sorts after right row; left=user00000000000000000080, right=user00000000000000000001 at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.getMinimumMidpointArray(HFileWriterImpl.java:445) ~[classes/:?] at org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.getMidpoint(HFileWriterImpl.java:390) ~[classes/:?] {code} Because byte buffers of cells have been already released, but RS still need to use these cells." "When graceful_stop a regionserver, RegionMover always retry to move the regions to other rsgoup's regionservers",13381380,Open,Critical,,01/Jun/21 06:21,,,"[hadoop@bigdata-hbase-master003.prod.com bin]$ ./graceful_stop.sh bigdata-hbase-rs105.prod.com 2021-05-28T11:05:06 Disabling load balancer SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/hadoop/cloud/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/hadoop/cloud/hbase/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See [http://www.slf4j.org/codes.html#multiple_bindings] for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] 2021-05-28T11:05:12 Previous balancer state was true 2021-05-28T11:05:12 Unloading bigdata-hbase-rs105.prod.com region(s) SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/hadoop/cloud/hadoop/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/hadoop/cloud/hbase/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See [http://www.slf4j.org/codes.html#multiple_bindings] for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] 2021-05-28 11:05:13,990 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:zookeeper.version=3.4.10-39d3a4f269333c922ed3db283be479f9deacaa0f, built on 03/23/2017 10:13 GMT 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:host.name=bigdata-hbase-master003.prod.com 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:java.version=1.8.0_241 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:java.vendor=Oracle Corporation 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:java.home=/home/hadoop/cloud/jdk1.8.0_241/jre 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: adoop/mapreduce/lib/jackson-mapper-asl-1.9.13.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-core-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.9.2-tests.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-examples-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-shuffle-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-hs-plugins-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-hs-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-app-2.9.2.jar:/home/hadoop/cloud/hadoop/share/hadoop/mapreduce/hadoop-mapreduce-client-common-2.9.2.jar:/home/hadoop/cloud/hadoop/contrib/capacity-scheduler/*.jar:/home/hadoop/cloud/hbase/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:java.library.path=/home/hadoop/cloud/hadoop/lib/native 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:java.io.tmpdir=/tmp 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:java.compiler= 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:os.name=Linux 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:os.arch=amd64 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:os.version=2.6.32-696.3.1.el6.x86_64 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:user.name=hadoop 2021-05-28 11:05:13,991 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:user.home=/home/hadoop 2021-05-28 11:05:13,992 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Client environment:user.dir=/home/hadoop/cloud/hbase/bin 2021-05-28 11:05:13,993 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Initiating client connection, connectString=bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181 sessionTimeout=30000 watcher=org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient$$Lambda$14/668288113@5d84a9ed 2021-05-28 11:05:14,138 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c-SendThread(bigdata-hbase-rs101.prod.com:2181)] zookeeper.Login: Client successfully logged in. 2021-05-28 11:05:14,140 INFO [Thread-4] zookeeper.Login: TGT refresh thread started. 2021-05-28 11:05:14,142 INFO [Thread-4] zookeeper.Login: TGT valid starting at: Fri May 28 11:05:14 CST 2021 2021-05-28 11:05:14,142 INFO [Thread-4] zookeeper.Login: TGT expires: Fri May 28 23:05:14 CST 2021 2021-05-28 11:05:14,143 INFO [Thread-4] zookeeper.Login: TGT refresh sleeping until: Fri May 28 21:07:54 CST 2021 2021-05-28 11:05:14,144 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c-SendThread(bigdata-hbase-rs101.prod.com:2181)] client.ZooKeeperSaslClient: Client will use GSSAPI as SASL mechanism. 2021-05-28 11:05:14,150 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c-SendThread(bigdata-hbase-rs101.prod.com:2181)] zookeeper.ClientCnxn: Opening socket connection to server bigdata-hbase-rs101.prod.com/10.87.103.134:2181. Will attempt to SASL-authenticate using Login Context section 'Client' 2021-05-28 11:05:14,154 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c-SendThread(bigdata-hbase-rs101.prod.com:2181)] zookeeper.ClientCnxn: Socket connection established to bigdata-hbase-rs101.prod.com/10.87.103.134:2181, initiating session 2021-05-28 11:05:14,158 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c-SendThread(bigdata-hbase-rs101.prod.com:2181)] zookeeper.ClientCnxn: Session establishment complete on server bigdata-hbase-rs101.prod.com/10.87.103.134:2181, sessionid = 0x371ba929aec16a2, negotiated timeout = 30000 2021-05-28 11:05:14,754 INFO [pool-2-thread-1] util.RegionMover: Moving 16 regions from bigdata-hbase-rs105.prod.com to 4 servers using 1 threads .Ack Mode:true 2021-05-28 11:05:20,479 INFO [pool-3-thread-1] util.RegionMover: Moving region:0e75b85e4970faf3ee7d83ba5edfbf7a from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs101.prod.com,16020,1615279448828 2021-05-28 11:06:14,775 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:06:14,786 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c] zookeeper.ZooKeeper: Session: 0x371ba929aec16a2 closed 2021-05-28 11:06:14,786 INFO [ReadOnlyZKClient-bigdata-hbase-master003.prod.com:2181,bigdata-hbase-master004.prod.com:2181,bigdata-hbase-rs101.prod.com:2181,bigdata-hbase-rs102.prod.com:2181,bigdata-hbase-rs103.prod.com:2181@0x24aed80c-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0x371ba929aec16a2 2021-05-28 11:06:18,880 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:06:19,983 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:06:21,086 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:06:22,190 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,080, !1r^,1609991498659.0e75b85e4970faf3ee7d83ba5edfbf7a. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs101.prod.com,16020,1615279448828 2021-05-28 11:06:22,210 INFO [pool-3-thread-1] util.RegionMover: Moving region:cad8bd3f09cb02b6be55acfa3fe81509 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs102.prod.com,16020,1615279437177 2021-05-28 11:07:22,265 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:07:23,369 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:07:24,472 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:07:25,576 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:07:26,679 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,0c0, 4B.J,1609991498659.cad8bd3f09cb02b6be55acfa3fe81509. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs102.prod.com,16020,1615279437177 2021-05-28 11:07:26,699 INFO [pool-3-thread-1] util.RegionMover: Moving region:175b9149fe5c2715832fe8ebe2273e3e from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs103.prod.com,16020,1615279437032 2021-05-28 11:07:27,868 INFO [pool-3-thread-1] util.RegionMover: Moved Region test:t2,100, ""la,1608747109269.175b9149fe5c2715832fe8ebe2273e3e. cost:1.188 2021-05-28 11:07:27,890 INFO [pool-3-thread-1] util.RegionMover: Moving region:8e58792c240f9dd6879fa610de648978 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs104.prod.com,16020,1615279437314 2021-05-28 11:07:29,042 INFO [pool-3-thread-1] util.RegionMover: Moved Region test:t2,180, &C9#,1608747109269.8e58792c240f9dd6879fa610de648978. cost:1.174 2021-05-28 11:07:29,061 INFO [pool-3-thread-1] util.RegionMover: Moving region:b135ab7358a5375eabec1ba9bd6abea2 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs101.prod.com,16020,1615279448828 2021-05-28 11:08:29,144 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:08:30,248 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:08:31,351 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:08:32,454 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:08:33,556 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,280,101866,1608761306479.b135ab7358a5375eabec1ba9bd6abea2. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs101.prod.com,16020,1615279448828 2021-05-28 11:08:33,576 INFO [pool-3-thread-1] util.RegionMover: Moving region:9ab60065e4d739b4b1205baaeb4ab112 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs102.prod.com,16020,1615279437177 2021-05-28 11:09:33,626 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:09:34,729 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:09:35,833 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:09:36,936 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:09:38,038 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,380,7408,1608742520235.9ab60065e4d739b4b1205baaeb4ab112. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs102.prod.com,16020,1615279437177 2021-05-28 11:09:38,052 INFO [pool-3-thread-1] util.RegionMover: Moving region:36d483f9537cbcb066c535d5c97500b7 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs103.prod.com,16020,1615279437032 2021-05-28 11:10:38,056 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:10:39,159 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:10:40,261 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:10:41,364 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:10:42,467 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,480,7627,1608755031336.36d483f9537cbcb066c535d5c97500b7. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs103.prod.com,16020,1615279437032 2021-05-28 11:10:42,491 INFO [pool-3-thread-1] util.RegionMover: Moving region:4fb21d1bcdd1230351828b7c6e779e08 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs104.prod.com,16020,1615279437314 2021-05-28 11:10:43,629 INFO [pool-3-thread-1] util.RegionMover: Moved Region test:t2,60000000,1608752443610.4fb21d1bcdd1230351828b7c6e779e08. cost:1.161 2021-05-28 11:10:43,659 INFO [pool-3-thread-1] util.RegionMover: Moving region:3286929984e362752b03dd4f1c723b78 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs101.prod.com,16020,1615279448828 2021-05-28 11:11:43,652 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:11:44,755 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:11:45,858 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:11:46,961 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:11:48,063 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,700,73323,1608755402890.3286929984e362752b03dd4f1c723b78. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs101.prod.com,16020,1615279448828 2021-05-28 11:11:48,089 INFO [pool-3-thread-1] util.RegionMover: Moving region:1626df981007111128002bb7008ebe07 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs102.prod.com,16020,1615279437177 2021-05-28 11:11:49,209 INFO [pool-3-thread-1] util.RegionMover: Moved Region test:t2,80000000,1608747946269.1626df981007111128002bb7008ebe07. cost:1.146 2021-05-28 11:11:49,234 INFO [pool-3-thread-1] util.RegionMover: Moving region:b9934989ffd9abb8b2484208b2a4860c from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs103.prod.com,16020,1615279437032 2021-05-28 11:12:49,215 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:12:50,318 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:12:51,421 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:12:52,523 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:12:53,626 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,900,7405,1608752559891.b9934989ffd9abb8b2484208b2a4860c. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs103.prod.com,16020,1615279437032 2021-05-28 11:12:53,657 INFO [pool-3-thread-1] util.RegionMover: Moving region:2cfb6d72b252e02b6651741bce8af0a9 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs104.prod.com,16020,1615279437314 2021-05-28 11:12:54,789 INFO [pool-3-thread-1] util.RegionMover: Moved Region test:t2,980,5003,1608752559891.2cfb6d72b252e02b6651741bce8af0a9. cost:1.163 2021-05-28 11:12:54,805 INFO [pool-3-thread-1] util.RegionMover: Moving region:027a58629de39ed42fd534364f239bc1 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs101.prod.com,16020,1615279448828 2021-05-28 11:12:55,918 INFO [pool-3-thread-1] util.RegionMover: Moved Region test:t2,a0000000,1608748813503.027a58629de39ed42fd534364f239bc1. cost:1.129 2021-05-28 11:12:55,941 INFO [pool-3-thread-1] util.RegionMover: Moving region:2f40e2ea776ad5ccc63dedc112f780b3 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs102.prod.com,16020,1615279437177 2021-05-28 11:13:55,918 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:13:57,022 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:13:58,124 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:13:59,227 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 ^[2021-05-28 11:14:00,330 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,c0000000,1608749249432.2f40e2ea776ad5ccc63dedc112f780b3. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs102.prod.com,16020,1615279437177 2021-05-28 11:14:00,376 INFO [pool-3-thread-1] util.RegionMover: Moving region:bebf648e765b7369ff2a86c6ca290828 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs103.prod.com,16020,1615279437032 2021-05-28 11:15:00,409 INFO [pool-3-thread-1] util.RegionMover: Retry 1 of maximum 5 2021-05-28 11:15:01,512 INFO [pool-3-thread-1] util.RegionMover: Retry 2 of maximum 5 2021-05-28 11:15:02,615 INFO [pool-3-thread-1] util.RegionMover: Retry 3 of maximum 5 2021-05-28 11:15:03,718 INFO [pool-3-thread-1] util.RegionMover: Retry 4 of maximum 5 2021-05-28 11:15:04,821 ERROR [pool-3-thread-1] util.RegionMover: Region: test:t2,e80, _R@_,1608746950666.bebf648e765b7369ff2a86c6ca290828. stuck on bigdata-hbase-rs105.prod.com,16020,1616402972076,newServer=bigdata-hbase-rs103.prod.com,16020,1615279437032 2021-05-28 11:15:04,844 INFO [pool-3-thread-1] util.RegionMover: Moving region:5beda27c11cef510a70af7f4609c84d3 from bigdata-hbase-rs105.prod.com,16020,1616402972076 to bigdata-hbase-rs104.prod.com,16020,1615279437314 2021-05-28 11:15:05,994 INFO [pool-3-thread-1] util.RegionMover: Moved Region test:t2,f80, !<&2,1608745215226.5beda27c11cef510a70af7f4609c84d3. cost:1.172 2021-05-28 11:15:05,994 ERROR [pool-2-thread-1] util.RegionMover: Was Not able to move region....Exiting Now 2021-05-28 11:15:05,995 ERROR [pool-2-thread-1] util.RegionMover: Error while unloading regions java.lang.Exception: Could not move region Exception at org.apache.hadoop.hbase.util.RegionMover.waitMoveTasksToFinish(RegionMover.java:541) at org.apache.hadoop.hbase.util.RegionMover.unloadRegions(RegionMover.java:497) at org.apache.hadoop.hbase.util.RegionMover.lambda$unload$1(RegionMover.java:449) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) 2021-05-28 11:15:06,003 INFO [main] client.ConnectionImplementation: Closing master protocol: MasterService 2021-05-28T11:15:06 Unloaded bigdata-hbase-rs105.prod.com region(s) 2021-05-28T11:15:06 Stopping regionserver on bigdata-hbase-rs105.prod.com bigdata-hbase-rs105.prod.com: running regionserver, logging to /home/logs/hbase/hbase-hadoop-regionserver-bigdata-hbase-rs105.prod.com.out bigdata-hbase-rs105.prod.com: stopping regionserver.... 2021-05-28T11:15:10 Restoring balancer state to true" RS getting aborted due to NPE in Replication WALEntryStream,13379226,Resolved,Critical,Fixed,19/May/21 07:35,26/May/21 09:03,,"Below sequence of events happened in a customer cluster An empty WAL file got roll req. The close of file failed at HDFS side but as there file had all edits synced, we continue. New WAL file is created and old rolled. This old WAL file got archived to oldWAL {code} 2021-05-13 13:38:46.000 Riding over failed WAL close of hdfs://xxx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678, cause=""Unexpected EOF while trying to read response from server"", errors=1; THIS FILE WAS NOT CLOSED BUT ALL EDITS SYNCED SO SHOULD BE OK 2021-05-13 13:38:46.000 Rolled WAL /xx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678 with entries=0, filesize=90 B; new WAL /xx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620913126549 2021-05-13 13:38:46.000 Archiving hdfs://xxx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678 to hdfs://xxx/oldWALs/xxxt%2C16020%2C1620828102351.1620910673678 2021-05-13 13:38:46.000 Log hdfs://xxx/WALs/xxx,16020,1620828102351/xxx%2C16020%2C1620828102351.1620910673678 was moved to hdfs://xxx/oldWALs/xxx%2C16020%2C1620828102351.1620910673678 {code} As there was move of file, the WALEntryStream got IOE and we will recreate the stream . {code} ReplicationSourceWALReader#run while (isReaderRunning()) { try { entryStream = new WALEntryStream(logQueue, conf, currentPosition, source.getWALFileLengthProvider(), source.getServerWALsBelongTo(), source.getSourceMetrics(), walGroupId); while (isReaderRunning()) { ... ... } catch (IOException e) { // stream related if (handleEofException(e, batch)) { sleepMultiplier = 1; } else { LOG.warn(""Failed to read stream of replication entries"", e); if (sleepMultiplier < maxRetriesMultiplier) { sleepMultiplier++; } Threads.sleep(sleepForRetries * sleepMultiplier); } } {code} eofAutoRecovery is turned off anyways. So it will go to outer while loop and create new WALEntryStream object Then we do readWALEntries {code} protected WALEntryBatch readWALEntries(WALEntryStream entryStream, WALEntryBatch batch) throws IOException, InterruptedException { Path currentPath = entryStream.getCurrentPath(); if (!entryStream.hasNext()) { {code} Here the currentPath will be still null. WALEntryStream#hasNext -> tryAdvanceEntry -> checkReader -> openNextLog {code} private boolean openNextLog() throws IOException { PriorityBlockingQueue queue = logQueue.getQueue(walGroupId); Path nextPath = queue.peek(); if (nextPath != null) { openReader(nextPath); private void openReader(Path path) throws IOException { try { // Detect if this is a new file, if so get a new reader else // reset the current reader so that we see the new data if (reader == null || !getCurrentPath().equals(path)) { closeReader(); reader = WALFactory.createReader(fs, path, conf); seek(); setCurrentPath(path); } else { resetReader(); } } catch (FileNotFoundException fnfe) { handleFileNotFound(path, fnfe); } catch (RemoteException re) { IOException ioe = re.unwrapRemoteException(FileNotFoundException.class); if (!(ioe instanceof FileNotFoundException)) { throw ioe; } handleFileNotFound(path, (FileNotFoundException)ioe); } catch (LeaseNotRecoveredException lnre) { // HBASE-15019 the WAL was not closed due to some hiccup. LOG.warn(""Try to recover the WAL lease "" + currentPath, lnre); recoverLease(conf, currentPath); reader = null; } catch (NullPointerException npe) { // Workaround for race condition in HDFS-4380 // which throws a NPE if we open a file before any data node has the most recent block // Just sleep and retry. Will require re-reading compressed WALs for compressionContext. LOG.warn(""Got NPE opening reader, will retry.""); reader = null; } } {code} Here the call to WALFactory.createReader is not able to complete because of issue from HDFS. (Ya its on the same WAL file for which the close had an issue) We have a retry mechanism there in createReader () for 5 mns. But eventually it throws LeaseNotRecoveredException. ya we try handle it. But the problem here is in that call we pass the state variable currentPath which is still null here! This will throw NPE {code} java.lang.NullPointerException at org.apache.hadoop.fs.FileSystem.fixRelativePart(FileSystem.java:2635) at org.apache.hadoop.hdfs.DistributedFileSystem.fixRelativePart(DistributedFileSystem.java:3087) at org.apache.hadoop.hdfs.DistributedFileSystem.recoverLease(DistributedFileSystem.java:297) at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverLease(FSHDFSUtils.java:283) at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverDFSFileLease(FSHDFSUtils.java:216) at org.apache.hadoop.hbase.util.FSHDFSUtils.recoverFileLease(FSHDFSUtils.java:163) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.recoverLease(WALEntryStream.java:387) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:370) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.handleFileNotFound(WALEntryStream.java:343) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openReader(WALEntryStream.java:362) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.openNextLog(WALEntryStream.java:303) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.checkReader(WALEntryStream.java:294) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:175) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:192) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:138) {code} This will kill the RS! When next RS takes this Replication Q source from this failed RS, even that also got NPE. Here in the call recoverLease() we should have been passing the method param 'path'.. All other calls from this method do that way but seems this was miss!" Per Cell TTL tags get duplicated with increments causing tags length overflow,13375813,Resolved,Critical,Fixed,29/Apr/21 10:56,21/May/21 17:35,2.1.9,"Incrementing with per cell TTL and flushing corrupts the HFile.   Reproducing the issue: Incrementing a row and a column with per cell TTL for about 3 thousand times and flushing corrupts the HFile leaving the table unusable. Cause: On reading the HFile, it is found that duplicate TTL tags get appended for each cell. Though this case has already been addressed here at HBASE-18030, corruption still occurs even with this patch. {code:java} java.lang.IllegalStateException: Invalid currTagsLen -32767. Block offset: 16665, block length: 65596, position: 0 (without header). path=hdfs://hdfs/file/path at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.checkTagsLen(HFileReaderImpl.java:642) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.readKeyValueLen(HFileReaderImpl.java:630) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.updateCurrentBlock(HFileReaderImpl.java:1206) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.loadBlockAndSeekToKey(HFileReaderImpl.java:1149) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.seekTo(HFileReaderImpl.java:863) at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.reseekTo(HFileReaderImpl.java:837) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseekAtOrAfter(StoreFileScanner.java:347) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseek(StoreFileScanner.java:256) at org.apache.hadoop.hbase.regionserver.StoreFileScanner.enforceSeek(StoreFileScanner.java:469) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.pollRealKV(KeyValueHeap.java:369) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(KeyValueHeap.java:311) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.requestSeek(KeyValueHeap.java:275) at org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(StoreScanner.java:1038) at org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(StoreScanner.java:1029) at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(StoreScanner.java:764) at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:695) at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:153) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6593) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6757) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6527) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:6504) at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.next(HRegion.java:6491) at org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:7458) at org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:7436) at org.apache.hadoop.hbase.regionserver.HRegion.get(HRegion.java:8123) at org.apache.hadoop.hbase.regionserver.HRegion.reckonDeltasByStore(HRegion.java:8003) at org.apache.hadoop.hbase.regionserver.HRegion.reckonDeltas(HRegion.java:7958) at org.apache.hadoop.hbase.regionserver.HRegion.doDelta(HRegion.java:7805) at org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:7767) at org.apache.hadoop.hbase.regionserver.RSRpcServices.increment(RSRpcServices.java:734) at org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:877) at org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2705) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42290) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) {code}        " ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations,13372457,Resolved,Critical,Fixed,14/Apr/21 16:54,08/May/21 01:30,,"[https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3025/9/testReport/org.apache.hadoop.hbase.replication/TestSyncReplicationStandbyKillRS/precommit_checks___yetus_jdk8_Hadoop3_checks______/] {code:java} ...[truncated 391170 chars]... 76d634:45149.replicationSource,1] regionserver.HRegionServer(2351): STOPPED: Unexpected exception in RS:2;ece3af76d634:45149.replicationSource,1 2021-04-11T11:14:40,268 INFO [RS:2;ece3af76d634:45149] regionserver.HeapMemoryManager(218): Stopping 2021-04-11T11:14:40,268 INFO [MemStoreFlusher.0] regionserver.MemStoreFlusher$FlushHandler(384): MemStoreFlusher.0 exiting 2021-04-11T11:14:40,268 INFO [RS:2;ece3af76d634:45149] flush.RegionServerFlushTableProcedureManager(118): Stopping region server flush procedure manager abruptly. 2021-04-11T11:14:40,270 INFO [RS:2;ece3af76d634:45149] snapshot.RegionServerSnapshotManager(136): Stopping RegionServerSnapshotManager abruptly. 2021-04-11T11:14:40,270 INFO [RS:2;ece3af76d634:45149] regionserver.HRegionServer(1146): aborting server ece3af76d634,45149,1618139661734 2021-04-11T11:14:40,272 ERROR [ReplicationExecutor-0.replicationSource,1-ece3af76d634,44745,1618139625245] regionserver.ReplicationSource(428): Unexpected exception in ReplicationExecutor-0.replicationSource,1-ece3af76d634,44745,1618139625245 currentPath=null java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:547) ~[classes/:?] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_282] 2021-04-11T11:14:40,272 DEBUG [ReplicationExecutor-0.replicationSource,1-ece3af76d634,44745,1618139625245] regionserver.HRegionServer(2576): Abort already in progress. Ignoring the current request with reason: Unexpected exception in ReplicationExecutor-0.replicationSource,1-ece3af76d634,44745,1618139625245 {code} Maybe it should use HBASE-24877 to avoid failure of the initialize of ReplicationSource.  " Exclude tomcat-embed-core from libthrift,13370709,Resolved,Critical,Fixed,09/Apr/21 17:35,10/Apr/21 08:35,2.2.7,"HBASE-25568 upgraded the Thrift dependency to 0.14.1 to fix a known CVE but a dependency issue in libthrift brings in tomcat-embed-core which has many vulnerabilities. See: THRIFT-5375 Since this dependency is used in Thrift only for a test we can safely exclude it inside HBase." Bulk Import fails with java.io.IOException: Type mismatch in value from map,13376405,In Progress,Major,,03/May/21 15:59,,2.2.5,"Bulk Import with {{-Dimport.bulk.output=/HFILES -Dimport.bulk.hasLargeResult=true}} always results in {noformat} Error: java.io.IOException: Type mismatch in value from map: expected org.apache.hadoop.hbase.util.MapReduceExtendedCell, received org.apache.hadoop.hbase.IndividualBytesFieldCell at org.apache.hadoop.mapred.MapTask$MapOutputBuffer.collect(MapTask.java:1077) at org.apache.hadoop.mapred.MapTask$NewOutputCollector.write(MapTask.java:715) at org.apache.hadoop.mapreduce.task.TaskInputOutputContextImpl.write(TaskInputOutputContextImpl.java:89) at org.apache.hadoop.mapreduce.lib.map.WrappedMapper$Context.write(WrappedMapper.java:112) at org.apache.hadoop.hbase.mapreduce.Import$CellSortImporter.map(Import.java:423) at org.apache.hadoop.hbase.mapreduce.Import$CellSortImporter.map(Import.java:394) at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:146) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:787) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:341) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:175) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1844) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:169) {noformat} The Problem is that in {{org.apache.hadoop.hbase.mapreduce.Import.CellSortImporter#map}} the {{Cell}} coming from {{value.rawCells()}} (which is of type {{org.apache.hadoop.hbase.IndividualBytesFieldCell}}) is directly written to the context without wrapping it into {{MapReduceExtendedCell}} (like it happens at {{CellImporter#map}}). IMHO [line 423|https://github.com/apache/hbase/blob/f76a601273e834267b55c0cda12474590283fd4c/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java#L423] must look like this: {code:java} context.write(new CellWritableComparable(ret), new MapReduceExtendedCell(ret)); {code}  Furthermore it seems to me that this is also wrong in all subsequent versions    " Update downloads.xml for release 2.4.4,13383827,Resolved,Major,Fixed,15/Jun/21 00:43,15/Jun/21 00:44,, Add 1.7.0 to download page,13383562,Resolved,Major,Resolved,12/Jun/21 07:37,12/Jun/21 07:52,, TestRSGroupsWithACL.setupBeforeClass is flaky,13371099,Resolved,Major,Fixed,11/Apr/21 06:54,21/Apr/21 06:48,,"[ERROR] Failures: [ERROR] TestRSGroupsWithACL.setupBeforeClass:136->SecureTestUtil.grantGlobal:345->SecureTestUtil.updateACLs:313 Waiting timed out after [10,000] msec *[https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3025/8/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt]*  " Add 2.3.5 to the downloads page,13368979,Resolved,Major,Fixed,01/Apr/21 00:46,01/Apr/21 03:17,, tableSkewCostFunction aggregate cost per table incorrectly,13385241,Resolved,Major,Duplicate,22/Jun/21 18:16,26/Oct/24 13:28,,"There is another bug in the original tableSkew cost function for aggregation of the cost per table: If we have 10 regions, one per table, evenly distributed on 10 nodes, the cost is scale to 1.0. The more tables we have, the closer the value will be to 1.0. The cost function becomes useless. All the balancer tests were set up with large numbers of tables with minimal regions per table. This artificially inflates the total cost and trigger balancer runs. With this fix on TableSkewFunction, we need to overhaul the tests too. We also need to add tests that reflect more diversified scenarios for table distribution such as large tables with large numbers of regions. {code:java} protected double cost() { double max = cluster.numRegions; double min = ((double) cluster.numRegions) / cluster.numServers; double value = 0; for (int i = 0; i < cluster.numMaxRegionsPerTable.length; i++) { value += cluster.numMaxRegionsPerTable[i]; } LOG.info(""min = {}, max = {}, cost= {}"", min, max, value); return scale(min, max, value); } }{code}" TableSkewCostFunction need to use aggregated deviation,13369880,Resolved,Major,Fixed,06/Apr/21 20:58,16/Jul/21 17:55,,"TableSkewCostFunction uses the sum of the max deviation region per server for all tables as the measure of unevenness. It doesn't work in a very common scenario in operations. Say we have 100 regions on 50 nodes, two on each. We add 50 new nodes and they have 0 each. The max deviation from the mean is 1, compared to 99 in the worst case scenario of 100 regions on a single server. The normalized cost is 1/99 = 0.011 < default threshold of 0.05. Balancer wouldn't move.  The proposal is to use aggregated deviation of the count per region server to detect this scenario, generating a cost of 100/198 = 0.5 in this case." Region server JVM Crash - A fatal error has been detected by the Java Runtime Environment,13385257,Resolved,Major,Duplicate,22/Jun/21 20:40,27/Sep/24 02:59,2.1.9,"Our production Region servers JVM crashed with the following error logs.   Register to memory mapping: RAX=0x000000002eea8f42 is an unknown value RBX=0x00007f1f8c7900d6 is an unknown value RCX=0x0000000000000021 is an unknown value RDX=0x0000000000000000 is an unknown value RSP=0x00007f1fe3092200 is pointing into the stack for thread: 0x00007f29775fb000 RBP=0x00007f1fe3092200 is pointing into the stack for thread: 0x00007f29775fb000 RSI=0x00007f1f8c7900cc is an unknown value RDI=0x000000002eea8f38 is an unknown value R8 =0x00007f28e14a3a38 is an oop java.nio.DirectByteBuffer - klass: 'java/nio/DirectByteBuffer' R9 =0x00007f1f8c790094 is an unknown value R10=0x00007f2965053400 is at begin+0 in a stub StubRoutines::unsafe_arraycopy [0x00007f2965053400, 0x00007f296505343b[ (59 bytes) R11=0x00007f28e14a3a38 is an oop java.nio.DirectByteBuffer - klass: 'java/nio/DirectByteBuffer' R12= [error occurred during error reporting (printing register info), id 0xb]   Stack: [0x00007f1fe2f93000,0x00007f1fe3094000],  sp=0x00007f1fe3092200,  free space=1020k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) v  ~StubRoutines::jshort_disjoint_arraycopy J 18388 C2 org.apache.hadoop.hbase.io.ByteBufferListOutputStream.write(Ljava/nio/ByteBuffer;II)V (53 bytes) @ 0x00007f2967fa0ea2 [0x00007f2967fa0d40+0x162] J 11722 C2 org.apache.hadoop.hbase.util.ByteBufferUtils.copyBufferToStream(Ljava/io/OutputStream;Ljava/nio/ByteBuffer;II)V (75 bytes) @ 0x00007f29670aa0fc [0x00007f29670a9fa0+0x15c] J 13251 C2 org.apache.hadoop.hbase.ByteBufferKeyValue.write(Ljava/io/OutputStream;Z)I (21 bytes) @ 0x00007f2965cbe87c [0x00007f2965cbe820+0x5c] J 8703 C2 org.apache.hadoop.hbase.KeyValueUtil.oswrite(Lorg/apache/hadoop/hbase/Cell;Ljava/io/OutputStream;Z)I (259 bytes) @ 0x00007f296684a2d4 [0x00007f296684a140+0x194] J 15474 C2 org.apache.hadoop.hbase.ipc.CellBlockBuilder.buildCellBlockStream(Lorg/apache/hadoop/hbase/codec/Codec;Lorg/apache/hadoop/io/compress/CompressionCodec;Lorg/apache/hadoop/hbase/CellScanner;Lorg/apache/hadoop/hbase/io/ByteBufferPool;)Lorg/apache/hadoop/hbase/io/ByteBufferListOutputStream; (75 bytes) @ 0x00007f29675f9dc8 [0x00007f29675f7c80+0x2148] J 14260 C2 org.apache.hadoop.hbase.ipc.ServerCall.setResponse(Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;Lorg/apache/hadoop/hbase/CellScanner;Ljava/lang/Throwable;Ljava/lang/String;)V (408 bytes) @ 0x00007f29678ad11c [0x00007f29678acec0+0x25c] J 14732 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1376 bytes) @ 0x00007f296797f690 [0x00007f296797e6a0+0xff0] J 14293 C2 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(Lorg/apache/hadoop/hbase/ipc/CallRunner;)V (268 bytes) @ 0x00007f29667b7464 [0x00007f29667b72e0+0x184] J 17796% C1 org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run()V (72 bytes) @ 0x00007f2967c9cbe4 [0x00007f2967c9caa0+0x144] v  ~StubRoutines::call_stub V  [libjvm.so+0x65ebbb]  JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*)+0x108b V  [libjvm.so+0x65ffd7]  JavaCalls::call_virtual(JavaValue*, KlassHandle, Symbol*, Symbol*, JavaCallArguments*, Thread*)+0x2f7 V  [libjvm.so+0x660497]  JavaCalls::call_virtual(JavaValue*, Handle, KlassHandle, Symbol*, Symbol*, Thread*)+0x47 V  [libjvm.so+0x6ada71]  thread_entry(JavaThread*, Thread*)+0x91 V  [libjvm.so+0x9f24f1]  JavaThread::thread_main_inner()+0xf1 V  [libjvm.so+0x9f26d8]  JavaThread::run()+0x1b8 V  [libjvm.so+0x8af502]  java_start(Thread*)+0x122 C  [libpthread.so.0+0x7dc5]  start_thread+0xc5   we used the workaround by switching *hbase.rpc.server.impl* back to SimpleRpcServer as mentioned in the following JIRA https://issues.apache.org/jira/browse/HBASE-22539?focusedCommentId=16855688&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16855688 Also, attached the error logs during JVM crash. Any help?" Dual File Compaction,13382247,Resolved,Major,Fixed,04/Jun/21 23:46,17/May/24 19:43,,"HBase stores tables row by row in its files, HFiles. An HFile is composed of blocks. The number of rows stored in a block depends on the row sizes. The number of rows per block gets lower when rows get larger on disk due to multiple row versions since HBase stores all row versions sequentially in the same HFile after compaction. However, applications (e.g., Phoenix) mostly query the most recent row versions. The default compactor in HBase compacts HFiles into one file. This Jira introduces a new store file writer which writes the retained cells by compaction into two files, which will be called DualFileWriter. One of these files will include the live cells. This file will be called a live-version file. The other file will include the rest of the cells, that is, historical versions. This file will be called a historical-version file. DualFileWriter will work with the default compactor. The historical files will not be read for the scans scanning latest row versions. This eliminates scanning unnecessary cell versions in compacted files and thus it is expected to improve performance of these scans." Support an overall coarse and fast balance strategy for StochasticLoadBalancer,13371189,Open,Major,,12/Apr/21 06:58,,1.4.13,"When we use StochasticLoadBalancer + balanceByTable, we could face two difficulties. # For each table, their regions are distributed uniformly, but for the overall cluster, still exiting imbalance between RSes; # When there are large-scaled restart of RSes, or expansion for groups or cluster, we hope the balancer can execute as soon as possible, but the StochasticLoadBalancer may need a lot of time to compute costs. We can detect these circumstances in StochasticLoadBalancer(such as using the percentage of skew tables), and before the normal balance steps trying, we can add a strategy to let it just balance like the SimpleLoadBalancer or use few light cost functions here.    " Support JDK17,13386489,Open,Major,,29/Jun/21 10:02,,,"JDK 17 is the next Java LTS, coming out this September. It brings a number of goodies. One of which is the production-ready ZGC (available since JDK15). (as well as the Shenandoah GC, available since JDK15) After September 2021, there will be three Java LTS versions: Java 8, Java 11 and Java 17. Java 8 will still be the mainstream SDK in the foreseeable future, so I am not looking to take advantage of the new APIs that are only available in JDK17. This jira aims to support HBase on all three JDK LTS. Porting HBase to JDK17 is not a big hurdle. HBase (master branch) builds successfully on JDK17. A few tests fail mostly due to the new (more strict) Java module isolation enforcement. I have a small PoC that I will post here in the coming days. What I am trying to achieve is to add an experimental support for JDK17. It will be interesting to benchmark HBase on ZGC and Shenandoah and determine if we should set our default GC to them. By then, we'll be able to claim production-ready support." [JDK17] Replace the usage of deprecated API ThreadGroup.destroy(),13386690,Resolved,Major,Fixed,30/Jun/21 06:34,17/May/24 16:12,,"According to the JDK17 doc, ThreadGroup.destroy() is deprecated because {quote}Deprecated, for removal: This API element is subject to removal in a future version. {quote} The API and mechanism for destroying a ThreadGroup is inherently flawed. The ability to explicitly or automatically destroy a thread group will be removed in a future release. [https://download.java.net/java/early_access/jdk17/docs/api/java.base/java/lang/ThreadGroup.html#destroy(]) We don't necessarily need to remove this usage now, but the warning sounds bad enough." [JDK17] Track JDK17 unit test failures,13386687,Resolved,Major,Fixed,30/Jun/21 06:19,17/May/24 09:39,,"As of now, there are still two failed unit tests after exporting JDK internal modules and the modifier access hack. {noformat} [ERROR] Tests run: 7, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.217 s <<< FAILURE! - in org.apache.hadoop.hbase.io.TestHeapSize [ERROR] org.apache.hadoop.hbase.io.TestHeapSize.testSizes Time elapsed: 0.041 s <<< FAILURE! java.lang.AssertionError: expected:<160> but was:<152> at org.apache.hadoop.hbase.io.TestHeapSize.testSizes(TestHeapSize.java:335) [ERROR] org.apache.hadoop.hbase.io.TestHeapSize.testNativeSizes Time elapsed: 0.01 s <<< FAILURE! java.lang.AssertionError: expected:<72> but was:<64> at org.apache.hadoop.hbase.io.TestHeapSize.testNativeSizes(TestHeapSize.java:134) [INFO] Running org.apache.hadoop.hbase.io.Tes [ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.697 s <<< FAILURE! - in org.apache.hadoop.hbase.ipc.TestBufferChain [ERROR] org.apache.hadoop.hbase.ipc.TestBufferChain.testWithSpy Time elapsed: 0.537 s <<< ERROR! java.lang.NullPointerException: Cannot enter synchronized block because ""this.closeLock"" is null at org.apache.hadoop.hbase.ipc.TestBufferChain.testWithSpy(TestBufferChain.java:119) {noformat} It appears that JDK17 makes the heap size estimate different than before. Not sure why. TestBufferChain.testWithSpy failure might be because of yet another unexported module." Support Hadoop 3.3.1,13380436,Resolved,Major,Fixed,26/May/21 01:30,09/Jun/21 23:16,,"The Hadoop 3.3.1 is a big release, quite different from 3.3.0. File this jira to track the support for Hadoop 3.3.1." Store the store file list by a file,13382922,Resolved,Major,Fixed,09/Jun/21 10:46,26/Aug/21 11:01,, Add support to take parallel backups,13386095,In Progress,Major,,27/Jun/21 14:22,,3.0.0-alpha-2,"*Existing Design:* !existing_design.png|width=632,height=1238! *Proposed Changes:* *!proposed_design.png|width=637,height=1300!*" java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI,13383842,Open,Major,,15/Jun/21 04:10,,2.3.5,"Hi All, We have Hadoop 3.2.2 and HBase 2.3.5 Versions installed. (java version ""1.8.0_291"")   While bringing up HBase master, I'm seeing following error messages in HBase master log.   Other HDFS. clients like Spark,MapReduce,Solr etc are able to write HDFS but HBase is unable to write its meta files in HDFS with following exceptions.   > Summary of Error logs from hbase master  2021-06-15 03:57:45,968 INFO [Thread-7] hdfs.DataStreamer: Exception in createBlockOutputStream java.io.IOException: Invalid token in javax.security.sasl.qop: ^DD 2021-06-15 03:57:45,939 WARN [Thread-7] hdfs.DataStreamer: Abandoning BP-1583998547-10.10.10.3-1622148262434:blk_1073743393_2570 2021-06-15 03:57:45,946 WARN [Thread-7] hdfs.DataStreamer: Excluding datanode DatanodeInfoWithStorage[10.10.10.3:50010,DS-281c3377-2bc1-47ea-8302-43108ee69430,DISK] 2021-06-15 03:57:45,994 WARN [Thread-7] hdfs.DataStreamer: DataStreamer Exception org.apache.hadoop.ipc.RemoteException(java.io.IOException): File /hbase/data/data/hbase/meta/.tmp/.tableinfo.0000000001 could only be written to 0 of the 1 minReplication nodes. There are 3 datanode(s) running and 3 node(s) are excluded in this operation. 2021-06-15 03:57:46,023 INFO [Thread-9] hdfs.DataStreamer: Exception in createBlockOutputStream java.io.IOException: Invalid token in javax.security.sasl.qop: ^DDI 2021-06-15 03:57:46,035 INFO [Thread-9] hdfs.DataStreamer: Exception in createBlockOutputStream java.io.IOException: Invalid token in javax.security.sasl.qop: ^DD 2021-06-15 03:57:46,508 ERROR [main] regionserver.HRegionServer: Failed construction RegionServer java.io.IOException: Failed update hbase:meta table descriptor 2021-06-15 03:57:46,509 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMaster. Caused by: java.io.IOException: Failed update hbase:meta table descriptor   Not sure what is the root cause behind this. Any comments/suggestions on this is much appreciated." [JDK17] Add a JDK17 profile,13386682,Resolved,Major,Implemented,30/Jun/21 05:59,18/May/23 15:41,,"While HBase builds fine with JDK17, tests fail because a number of Java SDK modules are no longer exposed to unnamed modules by default. We need to open them up. Without which, the tests fail for errors like: {noformat} [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 0.469 s <<< FAILURE! - in org.apache.hadoop.hbase.rest.model.TestNamespacesModel [ERROR] org.apache.hadoop.hbase.rest.model.TestNamespacesModel.testBuildModel Time elapsed: 0.273 s <<< ERROR! java.lang.ExceptionInInitializerError at org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int) throws java.lang.ClassFormatError accessible: module java.base does not ""opens java.lang"" to unnamed module @56ef9176 at org.apache.hadoop.hbase.rest.model.TestNamespacesModel.(TestNamespacesModel.java:43) {noformat}" Fix Jersey for hbase-server processes,13376457,Reopened,Major,,03/May/21 23:12,,2.5.0,"I spent some time trying to use Jersey from within the Master and it's not working. To summarize, we have unshaded resources from both jersey-server-1.19 and jersey-server-2.32 on the hbase-server classpath. Jersey's initialization uses ServiceLoader to look up concrete implementation classes of {{javax.ws.rs}} classes at runtime. Because we do not shade {{javax.ws.rs}} in hbase-thirdparty-jersey, an attempt to use shaded jersey-2.x still results in loading unshaded jersey-1.x jars, leading to an error like this {noformat} java.lang.AbstractMethodError: javax.ws.rs.core.UriBuilder.uri(Ljava/lang/String;)Ljavax/ws/rs/core/UriBuilder; at javax.ws.rs.core.UriBuilder.fromUri(UriBuilder.java:96) at org.apache.hbase.thirdparty.org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:275) at org.apache.hbase.thirdparty.org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:791) at org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1626) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112) {noformat} We cannot override what version of these classes are loaded at runtime via Java property because Jersey's load order implementation checks system properties as a last resort, not first thing as is claimed by javadoc. So I can think of two solutions. # One is to shade {{javax.ws.rs}} in hbase-thirdparty-jersey. This would shade both the interfaces and the resource files that are referenced at runtime, allowing for an entirely isolated jersey container instantiate. # Another idea is to add a custom {{ClassLoader}} that is inserted before jersey is initialized. This would filter out resources that are ""banned"", allowing our desired implementation through. Between these, I think (1) is better, but I don't know what else might break. I've made an effort of both, but with neither approach can I get a jersey environment to response from my resource class... either because the solution is incomplete, or because I don't have the jersey environment configured properly. See also some discussion that happened over on Slack, https://apache-hbase.slack.com/archives/C13K8NVAM/p1618857521051700" msg=org.apache.hadoop.hbase.PleaseHoldException: Master is initializing at org.apache.hadoop.hbase.master.HMaster.checkInitialized,13374937,Open,Major,,25/Apr/21 18:51,,,"Hi Team, I am getting error ""apache.hadoop.hbase.PleaseHoldException Master is initializing"". When In have checked the status of region server with status 'detailed' command then getting same region server as a live node and dead also. I have tried to removing /hbase-unsecure and to restart hbase master and region server but no luck. Even, I have restarted  Hbase services in sequence( ZK, region, Master) multiple times but still the issue didn't resolve.    [main] client.RpcRetryingCallerImpl: Call exception, tries=7, retries=36, started=8209 ms ago, cancelled=false, msg=org.apache.hadoop.hbase.PleaseHoldException: Master is initializing at org.apache.hadoop.hbase.master.HMaster.checkInitialized(HMaster.java:2977)" RSGroupBasedLoadBalancer online status never updates after being set to true for the first time,13375105,Open,Major,,26/Apr/21 16:24,,,"Once the RSGroupBasedLoadBalancer is “online” (it has found the hbase:meta and hbase:rsgroup tables), it will never update the status again. That means if hbase:meta or hbase:rsgroup ever go offline, the balancer doesn’t update its status to “offline,” so some of the code paths will go through the “online” code path even though the catalog tables aren’t available to be read from or written to (in particular, anything that calls RSGroupInfoManagerImpl#flushConfig). Also, in the RSGroupInfoManagerImpl#flushConfig code path, the call to write to hbase:rsgroup comes before the update to the rsGroupMap and tableMap which are stored in memory (see order of [these lines of code|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java#L664-L670]), so if hbase:rsgroup goes offline after the RSGroupBasedLoadBalancer is already marked as “online,” exceptions thrown while trying to write to an offline hbase:rsgroup table prevent the in-memory rsGroupMap and tableMap from being updated. In terms of the order just mentioned, in-memory state should be updated first." NettyRpcFrameDecoder decode request header wrong when handleTooBigRequest,13383390,Resolved,Major,Fixed,11/Jun/21 10:59,15/Jun/21 06:51,2.4.4,"Client write a big request to server, server decode request wrong, so client do not get a RequestTooBigException as expected. {code} 2021-06-11 18:57:27,340 INFO [RS-EventLoopGroup-1-20] ipc.NettyRpcServer: org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException$InvalidWireTypeException: Protocol message tag had invalid wire type. at org.apache.hbase.thirdparty.com.google.protobuf.InvalidProtocolBufferException.invalidWireType(InvalidProtocolBufferException.java:111) at org.apache.hbase.thirdparty.com.google.protobuf.UnknownFieldSet$Builder.mergeFieldFrom(UnknownFieldSet.java:519) at org.apache.hbase.thirdparty.com.google.protobuf.GeneratedMessageV3.parseUnknownField(GeneratedMessageV3.java:298) at org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos$RequestHeader.(RPCProtos.java:5958) at org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos$RequestHeader.(RPCProtos.java:5916) at org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos$RequestHeader$1.parsePartialFrom(RPCProtos.java:7249) at org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos$RequestHeader$1.parsePartialFrom(RPCProtos.java:7244) at org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos$RequestHeader$Builder.mergeFrom(RPCProtos.java:6679) at org.apache.hadoop.hbase.shaded.protobuf.generated.RPCProtos$RequestHeader$Builder.mergeFrom(RPCProtos.java:6482) at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:420) at org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage$Builder.mergeFrom(AbstractMessage.java:317) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.mergeFrom(ProtobufUtil.java:2716) at org.apache.hadoop.hbase.ipc.NettyRpcFrameDecoder.getHeader(NettyRpcFrameDecoder.java:174) at org.apache.hadoop.hbase.ipc.NettyRpcFrameDecoder.handleTooBigRequest(NettyRpcFrameDecoder.java:126) at org.apache.hadoop.hbase.ipc.NettyRpcFrameDecoder.decode(NettyRpcFrameDecoder.java:65) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:502) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:441) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:405) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:372) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:355) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:242) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:228) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:221) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1403) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:242) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:228) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:912) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:827) at org.apache.hbase.thirdparty.io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) at org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:495) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:905) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:834) {code}" Improve efficiency of SnapshotHFileCleaner,13379245,Resolved,Major,Fixed,19/May/21 09:06,24/May/21 14:21,2.0.0,"We have met same problems of thousands threads in HBASE-22867, but after this issue, the cleaner becomes more inefficient. From the jstack we can see that most dir-scan threads are blocked at SnapshotHFileCleaner#getDeletableFiles, {code:java} ""dir-scan-pool-19"" #694 daemon prio=5 os_prio=0 tid=0x0000000002ab1800 nid=0x26a7e waiting for monitor entry [0x00007fb0a9913000]    java.lang.Thread.State: BLOCKED (on object monitor)         at org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner.getDeletableFiles(SnapshotHFileCleaner.java:74)         - waiting to lock <0x00007fb148737048> (a org.apache.hadoop.hbase.master.snapshot.SnapshotHFileCleaner)         at org.apache.hadoop.hbase.master.cleaner.CleanerChore.checkAndDeleteFiles(CleanerChore.java:498)         at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$traverseAndDelete$1(CleanerChore.java:246)         at org.apache.hadoop.hbase.master.cleaner.CleanerChore$$Lambda$41/1187372779.act(Unknown Source)         at org.apache.hadoop.hbase.master.cleaner.CleanerChore.deleteAction(CleanerChore.java:358)         at org.apache.hadoop.hbase.master.cleaner.CleanerChore.traverseAndDelete(CleanerChore.java:246)         at org.apache.hadoop.hbase.master.cleaner.CleanerChore.lambda$null$2(CleanerChore.java:255)         at org.apache.hadoop.hbase.master.cleaner.CleanerChore$$Lambda$38/2003131501.run(Unknown Source)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:745){code} and all the HFileCleaner threads are waiting at the delete tasks queue, {code:java} ""gha-data-hbase0002:16000.activeMasterManager-HFileCleaner.large.2-1621210982419"" #358 daemon prio=5 os_prio=0 tid=0x00007fb967fc0000 nid=0x266f2 waiting on condition [0x00007fb0c57d6000]    java.lang.Thread.State: WAITING (parking)         at sun.misc.Unsafe.park(Native Method)         - parking to wait for  <0x00007fb1486db9f0> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)         at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)         at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)         at org.apache.hadoop.hbase.util.StealJobQueue.take(StealJobQueue.java:106)         at org.apache.hadoop.hbase.master.cleaner.HFileCleaner.consumerLoop(HFileCleaner.java:264)         at org.apache.hadoop.hbase.master.cleaner.HFileCleaner$1.run(HFileCleaner.java:233) {code} So it's need to increase the speed of scanning files. But since the getDeletableFiles is a synchronized method, increasing the number of scan-dir threads can not solve this problem.  After looking through the codes in SnapshotHFileCleaner and SnapshotFileCache, I think the lock granularity in them should be optimized.  " The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException,13385413,Resolved,Major,Fixed,23/Jun/21 12:12,10/Dec/21 06:35,2.2.7,"The batch api of HTable contains a param named results to store result or exception, its type is Object[]. If user pass an array with other type, eg: org.apache.hadoop.hbase.client.Result, and if we need to put an exception into it by some reason, then the ArrayStoreException will occur in AsyncRequestFutureImpl.updateResult, then the AsyncRequestFutureImpl.decActionCounter will be skipped, then in the AsyncRequestFutureImpl.waitUntilDone we will stuck at here checking the actionsInProgress again and again, forever. It is better to add an cutoff calculated by operationTimeout, instead of only depend on the value of actionsInProgress. BTW, this issue only for 2.x, since 3.x the implement has refactored. How to reproduce: 1: add sleep in RSRpcServices.multi to mock slow response {code:java} try { Thread.sleep(2000); } catch (InterruptedException e) { e.printStackTrace(); } {code} 2: set time out in config {code:java} conf.set(""hbase.rpc.timeout"",""2000""); conf.set(""hbase.client.operation.timeout"",""6000""); {code} 3: call batch api {code:java} Table table = HbaseUtil.getTable(""test""); byte[] cf = Bytes.toBytes(""f""); byte[] c = Bytes.toBytes(""c1""); List gets = new ArrayList<>(); for (int i = 0; i < 10; i++) { byte[] rk = Bytes.toBytes(""rk-"" + i); Get get = new Get(rk); get.addColumn(cf, c); gets.add(get); } Result[] results = new Result[gets.size()]; table.batch(gets, results); {code} The log will looks like below: {code:java} [ERROR] [2021/06/22 23:23:00,676] hconnection-0x6b927fb-shared-pool3-t1 - id=1 error for test processing localhost,16020,1624343786295 java.lang.ArrayStoreException: org.apache.hadoop.hbase.DoNotRetryIOException at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.updateResult(AsyncRequestFutureImpl.java:1242) at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.trySetResultSimple(AsyncRequestFutureImpl.java:1087) at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.setError(AsyncRequestFutureImpl.java:1021) at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.manageError(AsyncRequestFutureImpl.java:683) at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.receiveGlobalFailure(AsyncRequestFutureImpl.java:716) at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.access$1500(AsyncRequestFutureImpl.java:69) at org.apache.hadoop.hbase.client.AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncRequestFutureImpl.java:219) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266) at java.util.concurrent.FutureTask.run(FutureTask.java) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) [INFO ] [2021/06/22 23:23:10,375] main - #1, waiting for 10 actions to finish on table: test [INFO ] [2021/06/22 23:23:20,378] main - #1, waiting for 10 actions to finish on table: test [INFO ] [2021/06/22 23:23:30,384] main - #1, waiting for 10 actions to finish on table: [INFO ] [2021/06/22 23:23:40,387] main - #1, waiting for 10 actions to finish on table: test [INFO ] [2021/06/22 23:23:50,397] main - #1, waiting for 10 actions to finish on table: test [INFO ] [2021/06/22 23:24:00,400] main - #1, waiting for 10 actions to finish on table: test [INFO ] [2021/06/22 23:24:10,408] main - #1, waiting for 10 actions to finish on table: test [INFO ] [2021/06/22 23:24:20,413] main - #1, waiting for 10 actions to finish on table: test {code}" javadoc generation fails on openjdk-11.0.11+9,13382734,Resolved,Major,Fixed,08/Jun/21 14:49,25/Oct/22 15:12,2.4.3,"I'm trying to build javadoc for HBase 2.4.3 on jdk11. The command I'm running is as follows: {code:java} JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/  mvn -Phadoop-3.0 -Phadoop.profile=3.0 -Dhadoop-three.version=3.2.2 -Dhadoop.guava.version=27.0-jre -Dslf4j.version=1.7.25 -Djetty.version=9.3.29.v20201019 -Dzookeeper.version=3.5.7 -DskipTests -Dcheckstyle.skip=true site{code} I've tried this with maven 3.5.4 and 3.6.2. Based on JAVA_HOME above, jdk11.0.11+9. {{The error is as follows:}} {code:java} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project hbase: Error generating maven-javadoc-plugin:3.2.0:aggregate-no-fork report: [ERROR] Exit code: 1 - javadoc: warning - The old Doclet and Taglet APIs in the packages [ERROR] com.sun.javadoc, com.sun.tools.doclets and their implementations [ERROR] are planned to be removed in a future JDK release. These [ERROR] components have been superseded by the new APIs in jdk.javadoc.doclet. [ERROR] Users are strongly recommended to migrate to the new APIs. [ERROR] javadoc: error - invalid flag: -author [ERROR] [ERROR] Command line was: /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/bin/javadoc -J-Xmx2G @options @packages [ERROR] [ERROR] Refer to the generated Javadoc files in '/hbase/rpm/build/BUILD/hbase-2.4.3/target/site/apidocs' dir. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1]{code} I believe this is due to the yetus doclet org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet. Commenting this doclet out from the userapi and testuserapi reportSets in pom.xml fixes the build.   I noticed hbase 2.4.3 depends on audience-annotations 0.5.0, which is very old. I tried updating to 0.13.0, but that did not help. " Add flexibility to backup replication in case replication filter throws an exception,13376723,Resolved,Major,Fixed,05/May/21 06:00,22/May/21 00:25,1.6.0,"There may be situations when the wal entry filter might result in some temporary issues but expected to recover at some point in time. In this case, we should have an option to backup replication and retry until the wal entry filter recovers instead of just aborting the region server." Close PENDING_OPEN regions make regions FAILED_CLOSE,13373013,Resolved,Major,Won't Fix,16/Apr/21 13:11,02/Aug/22 09:08,1.7.1,"There is a case on our production cluster, # RS1 crash; # bulk assign some RS1 regions to RS2, including region A; # RS2 crash; # bulk assign RS2 regions to RS3, including region A; # the first assign of A to RS2 failed and reassign A; # close A on RS3, but A is PENDING_OPEN on RS3; # A FAILED_CLOSE;  " WAL lockup on 'sync failed',13386635,Open,Major,,30/Jun/21 04:02,,2.3.5,"Making note of issue seen in production cluster. Node had been struggling under load for a few days with slow syncs up to 10 seconds, a few STUCK MVCCs from which it recovered and some java pauses up to three seconds in length. Then the below happened: {code:java} 2021-06-27 13:41:27,604 WARN  [AsyncFSWAL-0-hdfs://XXXX:8020/hbase] wal.AsyncFSWAL: sync failedorg.apache.hbase.thirdparty.io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: Connection reset by peer {code} ... and WAL turned dead in the water. Scanners start expiring. RPC prints text versions of requests complaining requestsTooSlow. Then we start to see these: {code:java} org.apache.hadoop.hbase.exceptions.TimeoutIOException: Failed to get sync result after 300000 ms for txid=552128301, WAL system stuck? {code} Whats supposed to happen when other side goes away like this is that we will roll the WAL – go set up a new one. You can see it happening if you run {code:java} mvn test -Dtest=org.apache.hadoop.hbase.regionserver.wal.TestAsyncFSWAL#testBrokenWriter {code} I tried hacking the test to repro the above hang by throwing same exception in above test (on linux because need epoll to repro) but all just worked. Thread dumps of the hungup WAL subsystem are a little odd. The log roller is stuck w/o timeout trying to write a long on the WAL header:   {code:java} Thread 9464: (state = BLOCKED) - sun.misc.Unsafe.park(boolean, long) @bci=0 (Compiled frame; information may be imprecise) - java.util.concurrent.locks.LockSupport.park(java.lang.Object) @bci=14, line=175 (Compiled frame) - java.util.concurrent.CompletableFuture$Signaller.block() @bci=19, line=1707 (Compiled frame) - java.util.concurrent.ForkJoinPool.managedBlock(java.util.concurrent.ForkJoinPool$ManagedBlocker) @bci=119, line=3323 (Compiled frame) - java.util.concurrent.CompletableFuture.waitingGet(boolean) @bci=115, line=1742 (Compiled frame) - java.util.concurrent.CompletableFuture.get() @bci=11, line=1908 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.write(java.util.function.Consumer) @bci=16, line=189 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.writeMagicAndWALHeader(byte[], org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos$WALHeader) @bci=9, line=202 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(org.apache.hadoop.fs.FileSystem, org.apache.hadoop.fs.Path, org.apache.hadoop.conf.Configuration, boolean, long) @bci=107, line=170 (Compiled frame) - org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(org.apache.hadoop.conf.Configuration, org.apache.hadoop.fs.FileSystem, org.apache.hadoop.fs.Path, boolean, long, org.apache.hbase.thirdparty.io.netty.channel.EventLoopGroup, java.lang.Class) @bci=61, line=113 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(org.apache.hadoop.fs.Path) @bci=22, line=651 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(org.apache.hadoop.fs.Path) @bci=2, line=128 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(boolean) @bci=101, line=797 (Compiled frame) - org.apache.hadoop.hbase.wal.AbstractWALRoller$RollController.rollWal(long) @bci=18, line=263 (Compiled frame) - org.apache.hadoop.hbase.wal.AbstractWALRoller.run() @bci=198, line=179 (Compiled frame) {code}   Other threads are BLOCKED trying to append the WAL w/ flush markers etc. unable to add the ringbuffer:   {code:java} Thread 9465: (state = BLOCKED) - sun.misc.Unsafe.park(boolean, long) @bci=0 (Compiled frame; information may be imprecise) - java.util.concurrent.locks.LockSupport.parkNanos(long) @bci=11, line=338 (Compiled frame) - com.lmax.disruptor.MultiProducerSequencer.next(int) @bci=82, line=136 (Compiled frame) - com.lmax.disruptor.MultiProducerSequencer.next() @bci=2, line=105 (Interpreted frame) - com.lmax.disruptor.RingBuffer.next() @bci=4, line=263 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.lambda$stampSequenceIdAndPublishToRingBuffer$1(org.apache.commons.lang3.mutable.MutableLong, com.lmax.disruptor.RingBuffer) @bci=2, line=1031 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL$$Lambda$270.run() @bci=8 (Compiled frame) - org.apache.hadoop.hbase.regionserver.MultiVersionConcurrencyControl.begin(java.lang.Runnable) @bci=36, line=140 (Interpreted frame) - org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.stampSequenceIdAndPublishToRingBuffer(org.apache.hadoop.hbase.client.RegionInfo, org.apache.hadoop.hbase.wal.WALKeyImpl, org.apache.hadoop.hbase.wal.WALEdit, boolean, com.lmax.disruptor.RingBuffer) @bci=62, line=1030 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.append(org.apache.hadoop.hbase.client.RegionInfo, org.apache.hadoop.hbase.wal.WALKeyImpl, org.apache.hadoop.hbase.wal.WALEdit, boolean) @bci=10, line=589 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.appendMarker(org.apache.hadoop.hbase.client.RegionInfo, org.apache.hadoop.hbase.wal.WALKeyImpl, org.apache.hadoop.hbase.wal.WALEdit) @bci=5, line=1081 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.WALUtil.doFullMarkerAppendTransaction(org.apache.hadoop.hbase.wal.WAL, java.util.NavigableMap, org.apache.hadoop.hbase.client.RegionInfo, org.apache.hadoop.hbase.wal.WALEdit, org.apache.hadoop.hbase.regionserver.MultiVersionConcurrencyControl, java.util.Map, boolean) @bci=39, line=161 (Compiled frame) - org.apache.hadoop.hbase.regionserver.wal.WALUtil.writeFlushMarker(org.apache.hadoop.hbase.wal.WAL, java.util.NavigableMap, org.apache.hadoop.hbase.client.RegionInfo, org.apache.hadoop.hbase.shaded.protobuf.generated.WALProtos$FlushDescriptor, boolean, org.apache.hadoop.hbase.regionserver.MultiVersionConcurrencyControl) @bci=13, line=89 (Compiled frame) {code}   Interesting is how more than one thread is able to be inside the synchronize block in mvcc#begin seemingly.... In" Setting NAMESPACES when adding a replication peer still requires scope definition at CF level,13381425,In Progress,Major,,01/Jun/21 10:15,,2.3.5,"A common ask from our customers is for an easy way to enable replication for all tables within a namespace, but we had noticed that setting *NAMESPACES* option when adding a peer has no effect on enabling replication for the defined namespaces tables, it still replicates only entries where the *CF REPLICATION_SCOPE* is set to '1'. The problem is due to the chaining of *ScopeWALEntryFilter* and *NamespaceTableCfWALEntryFilter* together. This is currently done on *BaseReplicationEndpoint* class, but these two filters are not compatible, as *ScopeWALEntryFilter.filterCells* logic filters out cells from CFs where REPLICATION_SCOPE property is set to 0, before *NamespaceTableCfWALEntryFilter.filterCells* can have a chance to apply it's own logic, based on namespace definition. -This PR changes the logic described above, making  *ScopeWALEntryFilter* and *NamespaceTableCfWALEntryFilter* mutual exclusive, allowing for entries from all tables within the defined namespaces to be replicated without needing to have *REPLICATION_SCOPE* set to true.- Changing the original approach: Adding boolean operators to *ChainWALEntryFilter,* allowing operators to define either *AND/OR* junction logic for the chained filters." Move StoreFlushContext out of HStore and make it pluggable,13380134,Closed,Major,Fixed,24/May/21 14:50,26/May/21 18:42,3.0.0-alpha-1,"Currently, StoreFlushContext is directly implemented and instantiated inside HStore class. This implementation assumes hfiles are always flushed into temp dir first, and its commit implementation moves these files into the actual family dir. In order to allow for the direct flushes (no temp, nor renames), we need to make StoreFlushContext implementations pluggable in HStore." Row commit sequencer,13382311,Open,Major,,05/Jun/21 22:38,,,"Use a row commit sequencer in HRegion to ensure that only the operations that mutate disjoint sets of rows are able to commit within the same clock tick. This maintains the invariant that more than one mutation to a given row will never be committed in the same clock tick. Callers will first acquire row locks for the row(s) the pending mutation will mutate. Then they will use RowCommitSequencer.getRowSequence to ensure that the set of rows about to be mutated do not overlap with those for any other pending mutations in the current clock tick. If an overlap is identified, getRowSequence will yield and loop until there is no longer an overlap and the caller's pending mutation can succeed." Implement a Region Visualization on Master WebUI,13379162,Resolved,Major,Fixed,18/May/21 23:45,15/Mar/22 20:18,,Demonstrate end-to-end delivery of an interesting visualization. Implement a Cluster Metrics JSON endpoint,13379161,Resolved,Major,Fixed,18/May/21 23:44,14/Mar/22 16:29,,"In order to build a dynamic visualization functionality, we need access to the underlying dataset. I think we can do a lot by exposing the ClusterMetrics already available via the {{o.a.h.h.client.Admin}} interface." Introduce EnvironmentEdge.currentTimeAdvancing,13380222,Resolved,Major,Abandoned,25/May/21 01:23,02/Aug/21 16:20,,"Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures that when the current time is returned, it is the current time in a different clock tick from the last time the {{EnvironmentEdge}} was used to get the current time. When processing mutations we substitute the {{Long.MAX_VALUE}} timestamp placeholder with a real placeholder just before committing the mutation. The current code gets the current time for timestamp substitution while under row lock and mvcc. We will simply use {{EnvironmentEdge#currentTimeAdvancing}} instead of {{EnvironmentEdge#currentTime}} at this point in the code to ensure we have seen the clock tick over. When processing a batch of mutations (doMiniBatchMutation etc) we will call {{currentTimeAdvancing}} only once. This means the client cannot bundle cells with wildcard timestamps into a batch where those cells must be committed with different timestamps. Clients must simply not submit mutations that must be committed with guaranteed distinct timestamps in the same batch. Easy to understand, easy to document, and it aligns with our design philosophy of the client knows best. It is not required to handle batches as proposed. We could guarantee a distinct timestamp for every mutation in a batch. Count the number of mutations, call this M. Acquire all row locks and get the current time. Then, wait for at least M milliseconds. Then, set the first mutation timestamp with this value and increment by 1 for all remaining. Then, do the rest of mutation processing as normal. I don't think this extra waiting to reserve the range of timestamps is necessary. See reasoning in above paragraph. Mentioned here for sake of discussion. It will be fine to continue to use {{EnvironmentEdge#currentTime}} everywhere else. In this way we will only potentially spin wait where it matters, and won't suffer serious overheads during batch processing." Backport HBASE-22120 (Replace HTrace with OpenTelemetry) to branch-2,13376813,Resolved,Major,Fixed,05/May/21 15:14,01/Sep/21 22:31,2.5.0,"list of commits from upstream/master need to be backported {code} HBASE-25373 https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef HBASE-25401 https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04 HBASE-25424 https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d HBASE-23898 https://github.com/apache/hbase/commit/805b2ae2ad0f6325515d46043ff01e4e2c7a9f59 HBASE-25454 https://github.com/apache/hbase/commit/dcb78bd4bda4a4ae13d863df8aec266031e5bc93 HBASE-25481 https://github.com/apache/hbase/commit/ae2c62ffaad5ba4c976b0a79c10a365edf2844fd HBASE-25455 https://github.com/apache/hbase/commit/03e12bfa4ad62ecc6eee6a2c68d431bea2d5c473 HBASE-25484 https://github.com/apache/hbase/commit/2be2c63f0d3917a243b74af9754cbfc805b858d1 HBASE-25535 https://github.com/apache/hbase/commit/bb8c4967f8ce2c89ebaf1ddc5d8a1bf55f1e20d3 HBASE-25591 https://github.com/apache/hbase/commit/f6ff519dd0c7fe0e3ae3c175eefee27a26a065a4 HBASE-25617 https://github.com/apache/hbase/commit/8d68f8cd1c8613be1b499eaa99f46806b2743294 HBASE-25616 https://github.com/apache/hbase/commit/8399293e21127df3ffdcb757242e4cb5964c7e99 HBASE-25723 https://github.com/apache/hbase/commit/7f90c2201f6a17d2e2d031505c35ae7c2b1ed7ea HBASE-25732 https://github.com/apache/hbase/commit/8df9bebdd367d52a32b08c18a7cf4f9c2d712071 HBASE-25733 https://github.com/apache/hbase/commit/b71488998970a3353086a34736ed1edab527f673 HBASE-23762 https://github.com/apache/hbase/commit/be4503d9f82f044fbfce21c8a42d0b1684607238 HBASE-25778 https://github.com/apache/hbase/commit/f36e1539648bbaee84c626fd54d1605baebf3c5a {code}" ReadOnlyZKClient APIs - CompletableFuture.get() calls can cause threads to hang forver when ZK client create throws Non IOException,13379984,Resolved,Major,Fixed,23/May/21 12:02,31/May/21 06:20,,"This is applicable for zk client versions which is not having fix for ZOOKEEPER-2184. Now we are on zookeeper 3.5.7 on active 2.x branches. Still its better to handle this case in our code." TestSlowLogAccessor.testHigherSlowLogs repeatable failure,13375703,Resolved,Major,Cannot Reproduce,28/Apr/21 22:31,02/Apr/22 18:28,2.4.3,"{noformat} [ERROR] TestSlowLogAccessor.testHigherSlowLogs:211 Waiting timed out after [7,000] msec{noformat} Repeatable failure." Region Visualizer: Implement a Region Size histogram,13381550,Open,Major,,01/Jun/21 20:53,,,"Add a new view to the Region Visualizer that displays a histogram of region size. Make it so that the visualization can by selected, rather than showing multiple charts at once." Support Read/Write request size cost functions in StochasticLoadBalancer,13369248,Open,Major,,02/Apr/21 06:59,,1.7.1,"Currently, StochasticLoadBalancer has several cost functions to reflect pressure of regions, they are Read/Write/CP RequestCostFunction, MemStoreSizeCostFunction, StoreFileCostFunction. Memstore and storefile cost functions are used to reflect the write io pressure. But when some regions has high read io pressures, balancer can not aware of it and then make some actions. Like request count cost functions in StochasticLoadBalancer, we could also support request size cost functions. Because in some circumstances, request size  is the most important factor reflecting the pressure of RSes." TestStochasticLoadBalancerBalanceCluster.testBalanceCluster is flaky,13372999,Resolved,Major,Duplicate,16/Apr/21 12:31,07/Mar/22 11:13,,"Seems after HBASE-25739. Shows in [https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3176/1/testReport/org.apache.hadoop.hbase.master.balancer/TestStochasticLoadBalancerBalanceCluster/testBalanceCluster/] Local test can reproduce the failure, {code:java} 2021-04-16T20:11:21,425 INFO  [Time-limited test] balancer.TestStochasticLoadBalancerBalanceCluster(61): Mock Cluster : { srv1241949559:1 , srv609693614:5 , srv1125287745:6 , srv1143442391:6 , srv1165735784:6 , srv1221998538:6 , srv394489737:6 , srv593165442:6 , srv736809440:6 , srv741384165:6 } [srvr=10 rgns=54 avg=5.4 max=6 min=5]2021-04-16T20:11:21,425 INFO  [Time-limited test] balancer.TestStochasticLoadBalancerBalanceCluster(61): Mock Cluster : { srv1241949559:1 , srv609693614:5 , srv1125287745:6 , srv1143442391:6 , srv1165735784:6 , srv1221998538:6 , srv394489737:6 , srv593165442:6 , srv736809440:6 , srv741384165:6 } [srvr=10 rgns=54 avg=5.4 max=6 min=5]2021-04-16T20:11:21,425 INFO  [Time-limited test] balancer.BaseLoadBalancer(1791): Start Generate Balance plan for cluster.2021-04-16T20:11:21,425 DEBUG [Time-limited test] balancer.StochasticLoadBalancer$RegionCountSkewCostFunction(925): RegionCountSkewCostFunction sees a total of 10 servers and 54 regions.2021-04-16T20:11:21,425 DEBUG [Time-limited test] balancer.StochasticLoadBalancer(361): Skipping load balancing because balanced cluster; total cost=25.97402597402596, sum multiplier=582.0; cost/multiplier to need a balance is 0.052021-04-16T20:11:21,425 INFO  [Time-limited test] balancer.TestStochasticLoadBalancerBalanceCluster(67): Mock Balance : { srv1241949559:1 , srv609693614:5 , srv1125287745:6 , srv1143442391:6 , srv1165735784:6 , srv1221998538:6 , srv394489737:6 , srv593165442:6 , srv736809440:6 , srv741384165:6 } java.lang.AssertionError: All servers should have load no less than 5. server=srv1241949559,13844,-2719393974186553415 , load=1 at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.assertTrue(Assert.java:42) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.assertClusterAsBalanced(BalancerTestBase.java:207) at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerBalanceCluster.testBalanceCluster(TestStochasticLoadBalancerBalanceCluster.java:68) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) {code} @[~claraxiong] Could you help to fix this issue?  " Filter out o.a.hadoop.thirdparty building shaded jars,13373727,Resolved,Major,Fixed,20/Apr/21 00:40,27/Apr/21 15:43,2.4.3,"Hadoop 3.3.1 (unreleased currently) shades guava. The shaded guava then trips the check in our shading that tries to exclude hadoop bits from the fat jars we build. For the issue to trigger, need to build against tip of hadoop branch-3.3. You then get this complaint: {code} [INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ hbase-shaded-check-invariants --- [ERROR] Found artifact with unexpected contents: '/Users/stack/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/2.3.6-SNAPSHOT/hbase-shaded-mapreduce-2.3.6-SNAPSHOT.jar' Please check the following and either correct the build or update the allowed list with reasoning. org/apache/hadoop/thirdparty/ org/apache/hadoop/thirdparty/com/ org/apache/hadoop/thirdparty/com/google/ org/apache/hadoop/thirdparty/com/google/common/ org/apache/hadoop/thirdparty/com/google/common/annotations/ org/apache/hadoop/thirdparty/com/google/common/annotations/Beta.class org/apache/hadoop/thirdparty/com/google/common/annotations/GwtCompatible.class org/apache/hadoop/thirdparty/com/google/common/annotations/GwtIncompatible.class org/apache/hadoop/thirdparty/com/google/common/annotations/VisibleForTesting.class org/apache/hadoop/thirdparty/com/google/common/base/ org/apache/hadoop/thirdparty/com/google/common/base/Absent.class org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$1.class org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator$State.class org/apache/hadoop/thirdparty/com/google/common/base/AbstractIterator.class org/apache/hadoop/thirdparty/com/google/common/base/Ascii.class org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$1.class org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$2.class org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$3.class org/apache/hadoop/thirdparty/com/google/common/base/CaseFormat$4.class .... {code}" FanOutOneBlockAsyncDFSOutputHelper stuck when run against hadoop-3.3.1-RC3,13382231,Resolved,Major,Not A Problem,04/Jun/21 21:56,09/Jun/21 18:00,,"This is in the log: {code} 2021-06-04 21:29:39,138 DEBUG [master/oss-master-1:16000:becomeActiveMaster] ipc.ProtobufRpcEngine: Call: addBlock took 6ms 2021-06-04 21:29:39,169 WARN [RS-EventLoopGroup-1-1] concurrent.DefaultPromise: An exception was thrown by org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$4.operationComplete() java.lang.IllegalArgumentException: object is not an instance of declaring class at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.apache.hadoop.hbase.io.asyncfs.ProtobufDecoder.(ProtobufDecoder.java:69) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.processWriteBlockResponse(FanOutOneBlockAsyncDFSOutputHelper.java:343) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$100(FanOutOneBlockAsyncDFSOutputHelper.java:112) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$4.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:425) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:578) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:552) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:491) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.addListener(DefaultPromise.java:184) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.initialize(FanOutOneBlockAsyncDFSOutputHelper.java:419) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$300(FanOutOneBlockAsyncDFSOutputHelper.java:112) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$5.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:477) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$5.operationComplete(FanOutOneBlockAsyncDFSOutputHelper.java:472) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:578) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners0(DefaultPromise.java:571) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:550) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:491) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:616) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.setSuccess0(DefaultPromise.java:605) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.trySuccess(DefaultPromise.java:104) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPromise.trySuccess(DefaultChannelPromise.java:84) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.fulfillConnectPromise(AbstractEpollChannel.java:653) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.finishConnect(AbstractEpollChannel.java:691) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.epollOutReady(AbstractEpollChannel.java:567) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:470) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) at org.apache.hbase.thirdparty.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at org.apache.hbase.thirdparty.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:834) {code} These are WARNs but Master startup is stuck here: {code} ""master/oss-master-1:16000:becomeActiveMaster"" #88 daemon prio=5 os_prio=0 cpu=666.20ms elapsed=1834.30s tid=0x00005603036c6230 nid=0xd3 in Object.wait() [0x00007f335f440000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait(java.base@11.0.9/Native Method) - waiting on at java.lang.Object.wait(java.base@11.0.9/Object.java:328) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.awaitUninterruptibly(DefaultPromise.java:275) - waiting to re-lock in wait() <0x000000008e0ff540> (a org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.syncUninterruptibly(DefaultPromise.java:411) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultPromise.syncUninterruptibly(DefaultPromise.java:35) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:549) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.access$400(FanOutOneBlockAsyncDFSOutputHelper.java:112) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$8.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:616) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper$8.doCall(FanOutOneBlockAsyncDFSOutputHelper.java:611) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(FanOutOneBlockAsyncDFSOutputHelper.java:624) at org.apache.hadoop.hbase.io.asyncfs.AsyncFSOutputHelper.createOutput(AsyncFSOutputHelper.java:53) at org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter.initOutput(AsyncProtobufLogWriter.java:180) at org.apache.hadoop.hbase.regionserver.wal.AbstractProtobufLogWriter.init(AbstractProtobufLogWriter.java:166) at org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:113) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:663) at org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:131) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:852) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:555) at org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:496) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:161) at org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:63) at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:296) at org.apache.hadoop.hbase.master.region.MasterRegion.createWAL(MasterRegion.java:187) at org.apache.hadoop.hbase.master.region.MasterRegion.open(MasterRegion.java:260) at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:303) at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:104) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:834) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2091) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:507) at org.apache.hadoop.hbase.master.HMaster$$Lambda$164/0x0000000100559440.run(Unknown Source) at java.lang.Thread.run(java.base@11.0.9/Thread.java:834) {code} I don't see these log messges which I was thinking I should.... {code} try { protobufMessageLiteClass = Class.forName(""org.apache.hadoop.thirdparty.protobuf.MessageLite""); protobufMessageLiteBuilderClass = Class.forName( ""org.apache.hadoop.thirdparty.protobuf.MessageLite.Builder""); LOG.debug(""Hadoop 3.3 and above shades protobuf.""); } catch (ClassNotFoundException e) { LOG.debug(""Hadoop 3.2 and below use unshaded protobuf."", e); } {code}" [hbase-thirdparty] Shade jackson-jaxrs-json-provider for use with shaded jersey,13377318,Resolved,Major,Fixed,07/May/21 22:18,29/Nov/21 22:32,,The only pluggable feature of the this JSR spec that we take advantage of is using jackson-jaxrs-json-provider to get Jackson entity serialization. Rewrite this provider as well so that its use of the JSR API classes is against our shaded packages. Balancer should explain progress in a better way in log,13382250,Resolved,Major,Fixed,05/Jun/21 00:47,18/Jul/21 20:04,3.0.0-alpha-1,"In the log, balancer logs at info level at the beginning of run:  {code} balancer.StochasticLoadBalancer: start StochasticLoadBalancer.balancer, initCost=277.3479243125063, functionCost=RegionCountSkewCostFunction : (500.0, 0.3749771215224234); ServerLocalityCostFunction : (25.0, 0.5807483226644186); RackLocalityCostFunction : (15.0, 0.0); TableSkewCostFunction : (1000.0, 0.0019704142954972883); StoreFileCostFunction : (200.0, 0.3668512059459341); computedMaxSteps: 42270438200 {code} the cost is reported without context, it is hard for operator to understand how unbalanced the cluster is for balancer and how much progress we are making. For a large cluster, the calculation can take a long time, we also need to let operator understand that it will take up to the max time to complete the calculation.  At the end of computation: {code} balancer.StochasticLoadBalancer: Finished computing new load balance plan. Computation took PT40M0.006S to try 1036409 different iterations. Found a solution that moves 161926 regions; Going from a computed cost of 118.75715593924485 to a new cost of 1.5509126920967042 {code} The time to compute the plan is also printed in a  format that is not human readable. we also need to let operator understand that balancer is just submitting the plan and it be up to execution to complete the move.    " Create a chore to update age related metrics.,13377942,In Progress,Major,,11/May/21 19:06,,,"We had a case where logRoller and ReplicationShipper thread were stuck for a day since some other thread was holding the lock. We were not rolling the wal for 1 day and we were not shipping any edits for 1 day. Still the oldestWalAge and age of last ship metric were not spiking as they should. The way we calculate any age related metric is we calculate the diff between current time and the time at which any event happens and we add that to metrics Framework. We lose the event timestamp at that point. If the thread populating the metric is stuck then we will always carry forward the same value forever. This will make it look like there is no problem in the system. In this case the oldestWalAge metric was stuck at 809 value and age of last ship metric was 0 the whole time and no alert was fired. From Andrew Purtell, We have the Chore/ScheduledChore framework. We could be making more use of it. Much of this is legacy, before Chore was formalized as it is today." Master control the global throughput of all compaction servers,13386681,In Progress,Major,,30/Jun/21 05:58,,,"Compaction servers report compaction tasks to  master via heartbeat report.  The report response has throughput control message and compaction server use this message to adjust compaction throughtput. We can set total throughtput of all compaction servers via hbase shell commands." Use shaded javax.ws.rs package classes,13377304,Resolved,Major,Won't Fix,07/May/21 18:16,11/Jan/22 01:29,,Update anywhere that we use Jersey to make use of the shaded {{javax.ws.rs}} package name. Update ref guide about the 2.4.x release line,13383841,Resolved,Major,Fixed,15/Jun/21 04:03,08/Jan/22 16:29,,we do not have 2.4 in the compatibility matrix and release manager section. Release 3.0.0-alpha-1,13386840,Resolved,Major,Fixed,30/Jun/21 15:48,22/Jul/21 02:33,, Cleanup netty-all transitive includes,13382063,Resolved,Major,Fixed,04/Jun/21 05:57,09/Jun/21 04:40,,"Our releases include lib/netty-all.jar as a transitive include from hadoop. -Purge.- ... looks like I can't purge the transitive netty-all includes just yet, not w/o moving MR out of hbase core. The transitively included netty-all w/ the old version is needed to run the tests that put up a MR cluster." add clusterReadRequests and clusterWriteRequests jmx ,13374045,Resolved,Major,Fixed,21/Apr/21 07:36,09/Dec/21 01:20,, [hbase-thirdparty] Shade javax.ws.rs package for use with shaded Jersey,13377302,Resolved,Major,Fixed,07/May/21 18:09,29/Nov/21 22:32,,"From a comment on the parent ticket, bq. Jersey is an implementation of the specifications that define that package and its subcomponents. Thus, to use a shaded version of Jersey, one must also shade usage of this package as well." [hbase-thirdparty] Release 3.5.1,13381059,Resolved,Major,Fixed,29/May/21 01:57,29/Nov/21 15:05,, [hbase-thirdparty] Put up 3.5.1RC0,13381296,Resolved,Major,Fixed,31/May/21 13:52,29/Nov/21 15:05,, Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty,13381610,Resolved,Major,Cannot Reproduce,02/Jun/21 04:19,30/Jun/21 04:58,,"A coworker was trying to use hbase client in a fat application that uses a different netty version to what hbase uses internally. Their app would fail to launch because it kept bumping into an incompatible netty .so lib. Here are the unshaded netty .so's we bundle looking at hbase-2.4.1...: ./lib/hbase-shaded-netty-3.4.1.jar has: {code} META-INF/native/libnetty_transport_native_epoll_aarch_64.so META-INF/native/liborg_apache_hbase_thirdparty_netty_transport_native_epoll_x86_64.so META-INF/native/libnetty_transport_native_epoll_x86_64.so {code} (HBASE-25959 should fix the non-relocation of libnetty_transport_native_epoll_aarch_64). ./lib/shaded-clients/hbase-shaded-client-byo-hadoop-2.4.1.1-apple.jar has the same three .sos as does ./lib/shaded-clients/hbase-shaded-mapreduce-2.4.1.1-apple.jar and ./lib/shaded-clients/hbase-shaded-client-2.4.1.1-apple.jar We even bundle ./lib/netty-all-4.1.17.Final.jar which unsurprisingly has the netty .sos in it. Looking at published builds of hbase-thirdparty, I see that these too include the above trio of .sos... The hbase-shaded-netty includes them in 3.4.1 https://repo1.maven.org/maven2/org/apache/hbase/thirdparty/hbase-shaded-netty/3.4.1/ as does 3.5.0. I just tried running a build of hbase-thirdparty and it does NOT include the extras.... META-INF/native/liborg_apache_hbase_thirdparty_netty_transport_native_epoll_aarch_64.so META-INF/native/liborg_apache_hbase_thirdparty_netty_transport_native_epoll_x86_64.so (it has the fix for aarch included... when I built) Here is link to the snapshot I made: https://repository.apache.org/content/repositories/orgapachehbase-1451/org/apache/hbase/thirdparty/hbase-shaded-netty/3.5.1-stack4/ " WAL value compression,13377329,Resolved,Major,Fixed,08/May/21 01:06,21/May/21 19:39,,"WAL storage can be expensive, especially if the cell values represented in the edits are large, consisting of blobs or significant lengths of text. Such WALs might need to be kept around for a fairly long time to satisfy replication constraints on a space limited (or space-contended) filesystem. We have a custom dictionary compression scheme for cell metadata that is engaged when WAL compression is enabled in site configuration. This is fine for that application, where we can expect the universe of values and their lengths in the custom dictionaries to be constrained. For arbitrary cell values it is better to use one of the available compression codecs, which are suitable for arbitrary albeit compressible data." Duplicate cost calculation by TableSkewCostFunction when balancing by table,13378044,Resolved,Major,Won't Fix,12/May/21 08:34,04/Nov/21 12:02,2.0.0,"When using balance by table, the StochasticLoadBalancer will create the cluster state according to the regions distribution of only one table. As a result,  the TableSkewCostFunction should be replaced by the RegionCountSkewCostFunction when the table count of the cluster state is less than 2. The most important problem is that,  TableSkewCostFunction will cause unnecessary calculation steps when there is only one table. For example，we have 40000+ regions for one table in one group, balance this table may calculate lots of steps, but we can avoid duplicate computing costs of TableSkewCostFunction while computing cost of RegionCountSkewCostFunction and balancing by table.     !image-2021-08-17-20-20-12-768.png|width=907,height=164!" EOL 2.2.x,13374963,Resolved,Major,Fixed,26/Apr/21 03:33,21/Oct/21 13:11,,"As discussed in https://s.apache.org/7rqow , 2.2.7 will be the last 2.2.x release. Since 2.2.7 is out, let's EOL 2.2.x." Release 1.7.0,13369157,Resolved,Major,Fixed,01/Apr/21 16:28,20/Oct/21 06:15,,"Discussion is [here|https://lists.apache.org/thread.html/r34d3fb86d667f8b3e58cbba78655733ac76e10f5883650f4910adc5c%40%3Cuser.hbase.apache.org%3E], this may or may not be the last release of branch-1. But please allow me to go through the whole process before making any words.  I'll spend the upcoming next whole week to do this release, having said to my employer. cc [~andrew.purtell@gmail.com]  " TestSnapshotScannerHDFSAclController.setupBeforeClass is flaky,13372448,Resolved,Major,Fixed,14/Apr/21 16:18,02/Sep/21 09:07,,"[https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3140/2/testReport/org.apache.hadoop.hbase.security.access/TestSnapshotScannerHDFSAclController/precommit_checks___yetus_jdk8_Hadoop3_checks______/] SnapshotScannerHDFSAclController.postStartMaster alters hbase:acl to add a new cf ""m"", but `TestSnapshotScannerHDFSAclController.setupBeforeClass(TestSnapshotScannerHDFSAclController.java:101)`  fails before the disable and enable hbase:acl complete." Remove dependence on storing WAL filenames for backup,13378613,Resolved,Major,Fixed,15/May/21 16:52,13/Sep/21 01:49,3.0.0-alpha-1,"Context: Currently WAL logs are stored in `backup:system` meta table  {code:java} // code placeholder wals:preprod-dn-1%2C16020%2C1614844389000.1621996160175 column=meta:backupId, timestamp=1622003479895, value=backup_1622003358258 wals:preprod-dn-1%2C16020%2C1614844389000.1621996160175 column=meta:file, timestamp=1622003479895, value=hdfs://store/hbase/oldWALs/preprod-dn-1%2C16020%2C1614844389000.1621996160175 wals:preprod-dn-1%2C16020%2C1614844389000.1621996160175 column=meta:root, timestamp=1622003479895, value=s3a://2021-05-25--21-45-00--full/set1 wals:preprod-dn-1%2C16020%2C1614844389000.1621999760280 column=meta:backupId, timestamp=1622003479895, value=backup_1622003358258 wals:preprod-dn-1%2C16020%2C1614844389000.1621999760280 column=meta:file, timestamp=1622003479895, value=hdfs://store/hbase/oldWALs/preprod-dn-1%2C16020%2C1614844389000.1621999760280 wals:preprod-dn-1%2C16020%2C1614844389000.1621999760280 column=meta:root, timestamp=1622003479895, value=s3a://2021-05-25--21-45-00--full/set1 {code} Also, Every backup (Incremental and Full) performs a log roll just before taking backup and stores what was the timestamp at which log roll was performed per regionserver per backup using following format.   {code:java} // code placeholder rslogts:hdfs://xx.xx.xx.xx:8020/tmp/backup_yaktest\x00preprod-dn-2:16020 column=meta:rs-log-ts, timestamp=1622887363301,value=\x00\x00\x01y\xDB\x81ar rslogts:hdfs://xx.xx.xx.xx:8020/tmp/backup_yaktest\x00preprod-dn-3:16020 column=meta:rs-log-ts, timestamp=1622887363294, value=\x00\x00\x01y\xDB\x81aP rslogts:hdfs://xx.xx.xx.xx:8020/tmp/backup_yaktest\x00preprod-dn-1:16020 column=meta:rs-log-ts, timestamp=1622887363275, value=\x00\x00\x01y\xDB\x81\x85 {code}   There are 2 cases for which WAL log refrences stored in `backup:system` and are being used.  *Use Case 1.* *Existing Design:* To cleanup WAL's for which backup is already taken using `BackupLogCleaner`. Which uses this references to clean up backed up logs. *New Design:* Since log roll timestamp is stored as part of backup per regionserver. We can check all previous successfull backup's and then identify which logs are to be retained and which ones are to be cleaned up as follows * Identify which are the latest successful backups performed per table. * Per backup identified above, identify what is the oldest log rolled timestamp perfomed per regionserver per table.  * All those WAL's which are older than oldest log rolled timestamp perfomed for any table backed can be removed by `BackupLogCleaner`    *Use Case 2.* *Existing Design:* During incremental backup, to check system table if there are any duplicate WAL's for which backup is taken again.  *New Design:* * Incremental backup already identifies which all WAL's to be backed up using `rslogts:` mentioned above. * Additionally it checks `wals:` to ensure no logs are backuped for second time. And this is redundant and not seen any extra benefit. " Introduce RegionSplitRestriction that restricts the pattern of the split point,13371123,Resolved,Major,Fixed,11/Apr/21 12:34,22/Apr/21 05:16,,"As discussed in HBASE-25706, we can introduce RegionSplitRestriction that restricts the pattern of the split point. See the following comment for the details: https://issues.apache.org/jira/browse/HBASE-25706?focusedCommentId=17310190&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17310190 CC: [~zhangduo] [~stack]" Support for Parallel Backups enabling multi tenancy with rsgroups,13373183,In Progress,Major,,17/Apr/21 06:40,,,"*Existing Design*   !existing_design.png|width=851,height=1667! *Problem 1:*  With this design, Incremental and Full backup can't be run in parallel and leading to degraded RPO's in case Full backup is of longer duration esp for large tables.   Example:  Expectation: Say you have a big table with 10 TB and your RPO is 60 minutes and you are allowed to ship the remote backup with 800 Mbps. And you are allowed to take Full Backups once in a week and rest of them should be incremental backups   Shortcoming: With the above design, one can't run parallel backups and whenever there is a full backup running (which takes roughly 25 hours) you are not allowed to take incremental backups and that would be a breach in your RPO.    *Proposed Solution:* Barring some critical sections such as modifying state of the backup on meta tables, others can happen parallelly. Leaving incremental backups to be able to run based on older successful full / incremental backups and completion time of backup should be used instead of start time of backup for ordering. I have not worked on the full redesign, and will be doing so if this proposal seems acceptable for the community.   *Problem 2:* With one backup at a time, it fails easily for a multi-tenant system. This poses following problems * Admins will not be able to achieve required RPO's for their tables because of dependence on other tenants present in the system. As one tenant doesn't have control over other tenants' table sizes and hence the duration of the backup * Management overhead of setting up a right sequence to achieve required RPO's for different tenants could be very hard. *Proposed Solution:* Same as previous proposal   *Problem 3:*  Incremental backup works on WAL's and org.apache.hadoop.hbase.backup.master.BackupLogCleaner ensures that WAL's are never cleaned up until the next backup (Full / Incremental) is taken. This poses following problem * WAL's can grow unbounded in case there are transient problems like backup site facing issues or anything else until next backup scheduled goes successful *Proposed Solution:* I can't think of anything better, but I see this can be a potential problem. Also, one can force full backup if required WAL files are missing for whatever other reasons not necessarily mentioned above.    *Proposed Design.* !proposed_design.png|width=865,height=1766!" HBoss tests compile/failure against Hadoop 3.3.1,13379306,Resolved,Major,Fixed,19/May/21 13:50,05/Oct/21 16:52,hbase-filesystem-1.0.0-alpha1,"Changes in Hadoop 3.3.x stop the tests compiling/working. * changes in signature of nominally private classes (HADOOP-17497): fix, update * HADOOP-16721 -s3a rename throwing more exceptions, but no longer failing if the dest parent doesn't exist. Fix: change s3a.xml * HADOOP-17531/HADOOP-17620 distcp moving to listIterator; test failures. * HADOOP-13327: tests on syncable which expect files being written to to be visible. Fix: skip that test The fix for HADOOP-17497 stops this compiling against Hadoop < 3.3.1. This is unfortunate but I can't see an easy fix. The new signature takes a parameters class, so we can (and already are) adding new config options without breaking this signature again. And I've tagged it as LimitedPrivate so that future developers will know it's used here" Add CompactionServer Web UI,13386678,Resolved,Major,Fixed,30/Jun/21 05:53,25/Sep/21 01:50,, Perf improvement in L1 cache,13384846,Resolved,Major,Won't Fix,21/Jun/21 10:43,12/Aug/21 08:32,2.3.5,"After HBASE-25698 is in, all L1 caching strategies perform buffer.retain() in order to maintain refCount atomically while retrieving cached blocks (CHM#computeIfPresent). Retaining refCount is coming up bit expensive in terms of performance. Using computeIfPresent API, CHM uses coarse grained segment locking and even if our computation is not so complex (we just call block retain API), it will block other update APIs for the keys within bucket that is locked. computeIfPresent keeps showing up on flame graphs as well (attached one of them). Specifically when we see aggressive cache hits for meta blocks (with major blocks in cache), we would want to get away from coarse grained locking. One of the suggestions came up while reviewing PR#3215 is to treat cache read API as optimistic read and deal with block retain based refCount issues by catching the respective Exception and let it treat as cache miss. This should allow us to go ahead with lockless get API." Update default weight of cost functions,13371887,Open,Major,,12/Apr/21 21:30,,,"In production, we have seen some critical big tables that handle majority of the load. Table Skew is becoming more important. With the update of table skew function, balancer finally works for large table distribution on large cluster. We should increase the weight from 35 to a level comparable to region count skew: 500. We can even push further to replace region count skew by table skew since the latter works in the same way and account for region distribution per node. Another weight we found helpful to increase is for store file size cost function. Ideally if normalizer works perfectly, we don't need to worry about it since region count skew would have accounted for it. But we are often in a situation it doesn't. Store file distribution needs to be given more way as accommodation. we tested changing it from 5 to 200 and it works fine." The client integration test is failing after HBASE-22120 merged,13374901,Resolved,Major,Fixed,25/Apr/21 11:05,27/Apr/21 03:51,, The tracinig implementation for AsyncConnectionImpl.getHbck is incorrect,13372597,Resolved,Major,Fixed,15/Apr/21 10:29,16/Apr/21 08:16,,"Thanks [~GeorryHuang] for pinging me offline. Let me try to fix." Upgrade opentelemetry to 1.0.1,13369601,Resolved,Major,Fixed,05/Apr/21 14:31,07/Apr/21 08:39,, Change the command line argument for tracing after upgrading opentelemtry to 1.0.0,13369592,Resolved,Major,Fixed,05/Apr/21 13:45,07/Apr/21 08:38,,"The config parameters have been changed, we also need to change the default config in hbase-env.sh." Temporarily remove the trace support for RegionScanner.next,13369150,Resolved,Major,Fixed,01/Apr/21 16:06,03/Apr/21 15:08,,"Please see the test result in HBASE-25658, tracing RegionScanner.next could lead to a 6% performance downgrading even if we do not enable tracing. I think the problem here is that, a single scan rpc call could lead to a bunch of RegionScanner.next. So if trace is enabled, there will be much more performance impact as we need to store a bunch of spans(maybe this could be limited by some parameters?). Anyway, let's remove it for now to land the basic trace framework first. Can improve later." [HBOSS] Introducing hbase metrics to Hboss,13381730,Resolved,Major,Fixed,02/Jun/21 15:27,02/Jun/21 15:37,,I would like to introduce hbase metrics to Hboss to allow closer monitoring of rename performance. "Backport HBASE-22738, HBASE-24760, & HBASE-25298 (Fallback feature for RS groups when there are no RS in current group) to branch-1",13376724,Resolved,Major,Fixed,05/May/21 06:18,17/Aug/21 13:56,, Implement namespace and table level access control for thrift & thrift2,13386480,Resolved,Major,Fixed,29/Jun/21 09:31,16/Aug/21 18:13,,Client can grant or revoke ns & table level user permissions through thrift & thrift2. This is implemented with AccessControlClient. add hbase hbck result on jmx,13383359,Open,Major,,11/Jun/21 09:02,,,https://github.com/apache/hbase/pull/3379 Backport 'HBASE-25894 Improve the performance for region load and region count related cost functions' to branch-2.4 and branch-2.3,13381063,Resolved,Major,Fixed,29/May/21 02:14,11/Jun/21 01:48,, Remove DfsBuilderUtility,13386695,Resolved,Major,Fixed,30/Jun/21 07:08,26/Jul/21 10:04,2.5.0,"DfsBuilderUtility was created to reflectively access DistributedFileSystem$HdfsDataOutputStreamBuilder, which was added by  HDFS-11170 and available since Hadoop 2.9.0. We can remove this class and access the HDFS builder class directly in HBase 3 and 2.5.0." CompactionServer support compact TTL data,13386676,Resolved,Major,Fixed,30/Jun/21 05:50,26/Jul/21 09:17,, HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization,13385000,Resolved,Major,Fixed,21/Jun/21 19:42,30/Jun/21 02:34,1.7.0,"As of today, if we bring up HBase cluster using branch-1 and upgrade to branch-2.4, we are facing issue while parsing namespace from HDFS fileinfo. Instead of ""*hbase:meta*"" and ""*hbase:namespace*"", parsing using ProtobufUtil seems to be producing ""*\n hbase meta*"" and ""*\n hbase namespace*"" {code:java} 2021-06-22 00:05:56,611 INFO [RpcServer.priority.RWQ.Fifo.read.handler=3,queue=1,port=16025] regionserver.RSRpcServices: Open hbase:meta,,1.1588230740 2021-06-22 00:05:56,648 INFO [RpcServer.priority.RWQ.Fifo.read.handler=5,queue=1,port=16025] regionserver.RSRpcServices: Open hbase:namespace,,1624297762817.396cb6cc00cd4334cb1ea3a792d7529a. 2021-06-22 00:05:56,759 ERROR [RpcServer.priority.RWQ.Fifo.read.handler=5,queue=1,port=16025] ipc.RpcServer: Unexpected throwable object java.lang.IllegalArgumentException: Illegal character < > at 0. Namespaces may only contain 'alphanumeric characters' from any language and digits: ^Ehbase^R namespace at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:246) at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:220) at org.apache.hadoop.hbase.TableName.(TableName.java:348) at org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:385) at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:508) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toTableName(ProtobufUtil.java:2292) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toTableDescriptor(ProtobufUtil.java:2937) at org.apache.hadoop.hbase.client.TableDescriptorBuilder$ModifyableTableDescriptor.parseFrom(TableDescriptorBuilder.java:1625) at org.apache.hadoop.hbase.client.TableDescriptorBuilder$ModifyableTableDescriptor.access$200(TableDescriptorBuilder.java:597) at org.apache.hadoop.hbase.client.TableDescriptorBuilder.parseFrom(TableDescriptorBuilder.java:320) at org.apache.hadoop.hbase.util.FSTableDescriptors.readTableDescriptor(FSTableDescriptors.java:511) at org.apache.hadoop.hbase.util.FSTableDescriptors.getTableDescriptorFromFs(FSTableDescriptors.java:496) at org.apache.hadoop.hbase.util.FSTableDescriptors.getTableDescriptorFromFs(FSTableDescriptors.java:482) at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:210) at org.apache.hadoop.hbase.regionserver.RSRpcServices.openRegion(RSRpcServices.java:2112) at org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:35218) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318) 2021-06-22 00:05:56,759 ERROR [RpcServer.priority.RWQ.Fifo.read.handler=3,queue=1,port=16025] ipc.RpcServer: Unexpected throwable object java.lang.IllegalArgumentException: Illegal character < > at 0. Namespaces may only contain 'alphanumeric characters' from any language and digits: ^Ehbase^R^Dmeta at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:246) at org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:220) at org.apache.hadoop.hbase.TableName.(TableName.java:348) at org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:385) at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:508) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toTableName(ProtobufUtil.java:2292) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toTableDescriptor(ProtobufUtil.java:2937) at org.apache.hadoop.hbase.client.TableDescriptorBuilder$ModifyableTableDescriptor.parseFrom(TableDescriptorBuilder.java:1625) at org.apache.hadoop.hbase.client.TableDescriptorBuilder$ModifyableTableDescriptor.access$200(TableDescriptorBuilder.java:597) at org.apache.hadoop.hbase.client.TableDescriptorBuilder.parseFrom(TableDescriptorBuilder.java:320) at org.apache.hadoop.hbase.util.FSTableDescriptors.readTableDescriptor(FSTableDescriptors.java:511) at org.apache.hadoop.hbase.util.FSTableDescriptors.getTableDescriptorFromFs(FSTableDescriptors.java:496) at org.apache.hadoop.hbase.util.FSTableDescriptors.getTableDescriptorFromFs(FSTableDescriptors.java:482) at org.apache.hadoop.hbase.util.FSTableDescriptors.get(FSTableDescriptors.java:210) at org.apache.hadoop.hbase.regionserver.RSRpcServices.openRegion(RSRpcServices.java:2112) at org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:35218) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318){code}" The SnapshotOfRegionAssignmentFromMeta.initialize call in FavoredNodeLoadBalancer is just a dummy one,13380997,Resolved,Major,Fixed,28/May/21 14:32,29/May/21 03:16,,"After we introduced FavoredNodesManager, we do not need to load this information every time when balancing, as all the updates to favored nodes will go to FavoredNodesManager and it can update its in memory state accordingly. The current SnapshotOfRegionAssignmentFromMeta.initialize is just a dummy one in FavoredNodeLoadBalancer, as we never use it in the method. It will introduce a full scan on hbase:meta so let's just remove it." "Backport HBASE-25766 ""Introduce RegionSplitRestriction that restricts the pattern of the split point"" to branch-2.3",13384265,Resolved,Major,Won't Fix,17/Jun/21 03:18,23/Jun/21 06:49,,Backport the parent issue to branch-2.3. Backport HBASE-25703 and HBASE-26002 to branch-2.3,13384266,Resolved,Major,Won't Fix,17/Jun/21 03:20,23/Jun/21 06:52,,"Backport HBASE-25703 ""Support conditional update in MultiRowMutationEndpoint"" and HBASE-26002 ""MultiRowMutationEndpoint should return the result of the conditional update"" to branch-2.3." UI of master-status to show recent history of balancer desicion,13380068,Resolved,Major,Fixed,24/May/21 10:28,25/May/21 07:13,2.5.0,"HBASE-24528 provide ‘Balancer Decision’ to display the history that includes decision factor details and weights and costs while running balancer. This issue implement 'Balancer Decision' UI web page" Upgrade to latest hbase-thirdparty,13369341,Resolved,Major,Duplicate,02/Apr/21 18:11,30/Jun/21 20:15,2.4.2, Move method reportProcedureDone from RegionServerStatus.proto to Master.proto,13374617,Resolved,Major,Fixed,23/Apr/21 10:03,21/Jul/21 14:19,,"We next need use the procedure mechanism to implement enable/disable/refresh peer, and  ReplicationServer also needs reportProcedureDone to master, so I hope to move method reportProcedureDone to Master.proto from RegionServerStatus.proto." Add a flag to mark if the IOError can be solved by retry in thrift IOError,13385317,Resolved,Major,Fixed,23/Jun/21 06:26,21/Jul/21 14:18,,"Currently, if an HBaseIOException occurs, the thrift client can only get the error message. This is inconvenient for the client constructing a retry mechanism to handle the exception. So I added a canRetry mark in IOError to make the client side exception handling smarter." Region state stuck in PENDING_OPEN,13380543,Resolved,Major,Fixed,26/May/21 13:07,19/Jul/21 06:16,1.0.0,"Region will not be reassigned if encounters ConnectionClosingException, and then it will stuck in PENDING_OPEN state. Error logs are as follows, {code:java} INFO  [jd-data-hbase02.gh.sankuai.com,16000,1621944138744-GeneralBulkAssigner-12] master.AssignmentManager: Unable to communicate with jd-data-hbase15.gh.sankuai.com,16020,1622026221268 in order to assign regions,  org.apache.hadoop.hbase.exceptions.ConnectionClosingException: Call to jd-data-hbase15.gh.sankuai.com/10.78.96.166:16020 failed on local exception: org.apache.hadoop.hbase.exceptions.ConnectionClosingException: Connection to jd-data-hbase15.gh.sankuai.com/10.78.96.166:16020 is closing. Call id=19239, waitTime=1         at org.apache.hadoop.hbase.ipc.AbstractRpcClient.wrapException(AbstractRpcClient.java:289)         at org.apache.hadoop.hbase.ipc.RpcClientImpl.call(RpcClientImpl.java:1270)         at org.apache.hadoop.hbase.ipc.AbstractRpcClient.callBlockingMethod(AbstractRpcClient.java:227)         at org.apache.hadoop.hbase.ipc.AbstractRpcClient$BlockingRpcChannelImplementation.callBlockingMethod(AbstractRpcClient.java:336)         at org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$BlockingStub.openRegion(AdminProtos.java:25890)         at org.apache.hadoop.hbase.master.ServerManager.sendRegionOpen(ServerManager.java:798)         at org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1744)         at org.apache.hadoop.hbase.master.GeneralBulkAssigner$SingleServerBulkAssigner.run(GeneralBulkAssigner.java:203)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)         at java.lang.Thread.run(Thread.java:745) Caused by: org.apache.hadoop.hbase.exceptions.ConnectionClosingException: Connection to jd-data-hbase15.gh.sankuai.com/10.78.96.166:16020 is closing. Call id=19239, waitTime=1         at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.cleanupCalls(RpcClientImpl.java:1083)         at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.close(RpcClientImpl.java:863)         at org.apache.hadoop.hbase.ipc.RpcClientImpl$Connection.run(RpcClientImpl.java:580) {code}" ReplicationSourceWALReader#run - Reset sleepMultiplier in loop once out of any IOE,13382846,Resolved,Major,Invalid,09/Jun/21 05:41,28/Jun/21 10:24,, HBaseCluster support CompactionServer for UTs,13375969,Resolved,Major,Fixed,30/Apr/21 06:36,01/Jun/21 02:28,, JVM crash when displaying regionserver UI,13382624,Resolved,Major,Fixed,08/Jun/21 06:10,09/Jun/21 10:21,2.0.0,"The MonitoredRPCHandlerImpl refers to the params of a request, and will show them when we call 'toJson()'. But the running RPC call may be cleaned up and the ByteBuffer be released  before the displaying in UI.  We need to let the life cycle of RPC status monitor be inner the life cycle of RPC. {code:java} J 19267 C2 org.apache.hbase.thirdparty.com.google.protobuf.TextFormat$Printer.printMessage(Lorg/apache/hbase/thirdparty/com/google/protobuf/MessageOrBuilder;Lorg/apache/hbase/thirdparty/com/google/protobuf/TextFormat$TextGenerator;)V (73 bytes) @ 0x00007f1ac7e54640 [0x00007f1ac7e53f60+0x6e0] J 20932 C2 org.apache.hbase.thirdparty.com.google.protobuf.TextFormat$Printer.print(Lorg/apache/hbase/thirdparty/com/google/protobuf/MessageOrBuilder;Lorg/apache/hbase/thirdparty/com/google/protobuf/TextFormat$TextGenerator;)V (34 bytes) @ 0x00007f1ac68ab9b0 [0x00007f1ac68ab880+0x130] J 21843 C1 org.apache.hbase.thirdparty.com.google.protobuf.AbstractMessage.toString()Ljava/lang/String; (8 bytes) @ 0x00007f1ac620e14c [0x00007f1ac620dba0+0x5ac] J 21835 C1 org.apache.hadoop.hbase.monitoring.MonitoredRPCHandlerImpl.toMap()Ljava/util/Map; (240 bytes) @ 0x00007f1ac5009bf4 [0x00007f1ac50071c0+0x2a34] J 21833 C1 org.apache.hadoop.hbase.monitoring.MonitoredRPCHandlerImpl.toJSON()Ljava/lang/String; (5 bytes) @ 0x00007f1ac74efb74 [0x00007f1ac74efaa0+0xd4] j  org.apache.hadoop.hbase.tmpl.common.TaskMonitorTmplImpl.renderNoFlush(Ljava/io/Writer;)V+259 j  org.apache.hadoop.hbase.tmpl.common.TaskMonitorTmpl.renderNoFlush(Ljava/io/Writer;)V+16 j  org.apache.hadoop.hbase.tmpl.regionserver.RSStatusTmplImpl.renderNoFlush(Ljava/io/Writer;)V+129 {code} [^hs_err_pid116190.log-gha-data-hbase-cat0085-ui]" Performance improvements for StochasticLoadBalancer,13376169,Open,Major,,01/May/21 00:52,,,"This is what I posted in the slack channel. {quote} When refactoring balancer related code for moving them out to hbase-balancer module, I found that we will create a OffPeakHours instance in MoveCostFunction.cost every time. So I wrote a simple JMH test to test its performance. https://github.com/Apache9/hbase-jmh-test/blob/master/src/main/java/org/apache/hadoop/hbase/master/balancer/MoveCostFunctionBenchmark.java For the original version, the result is Benchmark Mode Samples Score Score error Units o.a.h.h.m.b.MoveCostFunctionBenchmark.computeCost avgt 10 242.312 3.853 ns/op 12:06 If I initialized OffPeakHours in constructor, then the result is Benchmark Mode Samples Score Score error Units o.a.h.h.m.b.MoveCostFunctionBenchmark.computeCost avgt 10 81.186 0.720 ns/op 12:06 If I also eliminate the conf.getFloat in the cost method(by storing them to a field member in constructor, the result is Benchmark Mode Samples Score Score error Units o.a.h.h.m.b.MoveCostFunctionBenchmark.computeCost avgt 10 4.419 0.035 ns/op 12:08 I think on a large cluster, the performance for balancer is a problem, so maybe we should try to avoid creating too many objects or calling conf.getXXX in the critical path? As we will call StochasticLoadBalancer.computeCost in every step when balancing cluster... {quote} For large clusters, the performance of StochasticLoadBalancer will be very important, so I think we need to treat this problem seriously and try to improve." "POC: hbase:meta,,1 as ROOT",13370833,Open,Major,,10/Apr/21 16:19,,,"One of the proposals up in the split-meta design doc suggests a sleight-of-hand where the current hard-coded hbase:meta,,1 Region is leveraged to serve as first Region of a split hbase:meta but also does double-duty as 'ROOT'. This suggestion was put aside as a complicating recursion in chat but then Francis noticed on a re-read of the BigTable paper, that this is how they describe they do 'ROOT': ""The root tablet is just the first tablet in the METADATA table, but is treated specially -- it is never split..."" This issue is for playing around with this notion to see what the problems are so can do a better description of this approach here, in the design: https://docs.google.com/document/d/11ChsSb2LGrSzrSJz8pDCAw5IewmaMV0ZDN1LrMkAj4s/edit?ts=606c120f#heading=h.ikbhxlcthjle" Do compaction on compaction server,13383075,Resolved,Major,Fixed,10/Jun/21 02:22,06/Jul/21 09:47,,"after HBASE-25968 , this patch implement code in compaction server " Complement admin operations in Thrift2 after HBASE-21674,13385801,Resolved,Major,Fixed,25/Jun/21 09:06,05/Jul/21 04:14,,Thrift2 Admin operations were not finished in HBASE-21674. Finished them this time. hbase-cleanup.sh did not clean the wal dir if hbase.wal.dir configured individually,13385675,Resolved,Major,Fixed,24/Jun/21 16:06,03/Jul/21 03:22,2.2.3,"If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem or directories, hbase clean script will clean the directory of 'hbase.rootdir' only, the directory of 'hbase.wal.dir'  will be left. The left direcotries 'WAls,' 'oldWALs', and recovered.edits under region dir should be cleaned also." Remove the reflection used in FSUtils.isInSafeMode,13386699,Resolved,Major,Fixed,30/Jun/21 07:36,02/Jul/21 06:23,,DistributedFileSystem.setSafeMode() was added by HDFS-3507 in Hadoop 2.0.3-alpha. No need to access via reflection. Remove reflections used to access HDFS EC APIs,13386718,Resolved,Major,Fixed,30/Jun/21 08:48,02/Jul/21 03:11,3.0.0-alpha-1,"HDFS EC APIs exists since Hadoop 3.0. We can access them directly in HBase 3.0 without reflections." Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo(),13386632,Resolved,Major,Fixed,30/Jun/21 03:07,02/Jul/21 03:03,,PrintThreadInfoLazyHolder uses reflection to access Hadoop's ReflectionUtils.printThreadInfo(). Replace it with HBase's ReflectionUtils.printThreadInfo(). The view as json page shows exception when using TinyLfuBlockCache,13385425,Resolved,Major,Fixed,23/Jun/21 13:03,01/Jul/21 02:24,,Some variable in TinyLfuBlockCache should be marked as transient. MultiRowMutationEndpoint should return the result of the conditional update,13383726,Resolved,Major,Fixed,14/Jun/21 13:11,15/Jun/21 05:19,,"HBASE-25703 added support for the conditional update in MultiRowMutationEndpoint, but MultiRowMutationEndpoint doesn't return the result of the conditional update (whether or not the mutations are executed). In this Jira, we will make MultiRowMutationEndpoint return the result of the conditional update. " The readRequestsCount does not calculate when the outResults is empty,13381820,Resolved,Major,Fixed,03/Jun/21 02:42,10/Jun/21 03:13,,"This metric is about request, so should not depend on the result." Remove CHANGES and RELEASENOTES,13386842,Open,Major,,30/Jun/21 15:55,,,"Let's do this first. The release script has a flag to skip the generating stage so it could be done later." TestReplicationKillRS is useless after HBASE-23956,13386501,Resolved,Major,Fixed,29/Jun/21 11:24,30/Jun/21 00:33,,"In TestReplicationKillRS, we assume there are at least 2 regionservers but in HBASE-23956, we set the region server number to 1. So in fact, we do not kill any region servers which makes the tests useless..." Replace reflections that are redundant,13386628,Open,Major,,30/Jun/21 02:10,,,"A number of reflections were used to access (back in the time) new Hadoop APIs that were only available in newer Hadoop versions. Some of them are no longer needed with the default Hadoop dependency 3.1.2, so they can be removed to avoid the brittle code. Also, makes it possible to determine compile time dependency." Remove reflections used in HBaseConfiguration.getPassword(),13384919,Resolved,Major,Fixed,21/Jun/21 13:41,23/Jun/21 11:26,,HBaseConfiguration.getPassword() uses Hadoop API Configuration.getPassword(). The API was added in Hadoop 2.6.0. Reflection was used to access the API. It's time to remove the reflection and invoke the API directly. (HBase 3.0 as well as 2.x too) Introduce a new API to sync the live region server list more effectively,13384378,Resolved,Major,Invalid,17/Jun/21 14:57,30/Jun/21 03:50,,"In HBASE-25976, we introduced a master based replication tracker to not depend on zk, but the problem is that we will always fetch the whole region server list, from every region server, which will become a performance issue when the cluster has lots of region servers. So we need to introduce a new API to sync the live region server list. As the region server list will not be changed too much, we should have a way to detect this and not pass the full list." Validate nightly builds run on new ci workers hbase11-hbase15,13385714,Resolved,Major,Later,24/Jun/21 20:57,29/Jun/21 16:27,,"Per slack, asf infra has finished adding in nodes hbase10-hbase15 to ci-hadoop. make sure they can run nightly. # Set labels for all these node to ""hbase-staging"" # Push a feature branch off of current HEAD that updates the agent labels to use ""hbase-staging"" # trigger a bunch of runs. make sure *something* runs on each of the nodes # Set labels for the nodes to ""hbase"" # delete feature branch" Add donated buildbots for jenkins,13383016,Resolved,Major,Incomplete,09/Jun/21 17:51,29/Jun/21 18:16,,"This issue is for keeping notes on how to add a donated buildbot to our apache build. My employer donated budget (I badly under-estimated cost but whatever...). This issue is about adding 5 GCP nodes. There is this page up on apache on donating machines for build https://infra.apache.org/hosting-external-agent.html It got me some of the ways... at least as far as the bit about mailing root@a.o....(nada). At [~zhangduo]'s encouragement -- he has been this route already adding in the xiaomi donation -- I filed a JIRA after deploying a machine on GCP, INFRA-21973. I then reached out on slack and the gentleman Gavin MacDonald picked up the task. He told me run this script on all hosts after making edits (comment out line #39 where we set hostname -- doesn't work): https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/agent-install.sh (For more context on the above script and as a good backgrounder, see the nice C* page on how to do this setup: https://github.com/apache/cassandra-builds/blob/trunk/ASF-jenkins-agents.md) After doing the above, I had to do a visudo on each host to add a line for an infra account to allow passwordless access. " Master table.jsp pointed at meta throws 500 when no all replicas are online,13382570,Resolved,Major,Fixed,07/Jun/21 21:31,27/Jun/21 14:44,2.3.5,"With a replica in a transition state, the UI renders, {noformat} HTTP ERROR 500 Problem accessing /table.jsp. Reason: Server Error Caused by: org.apache.hadoop.hbase.NotAllMetaRegionsOnlineException: Timed out; 1ms at org.apache.hadoop.hbase.zookeeper.MetaTableLocator.waitMetaRegionLocation(MetaTableLocator.java:190) at org.apache.hadoop.hbase.generated.master.table_jsp._jspService(table_jsp.java:264) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) {noformat}" Provide slow/large logs on RegionServer UI,13380229,Resolved,Major,Fixed,25/May/21 03:16,27/Jun/21 14:27,2.5.0,Pulling slow/large log from  in-memory queues on RegionServer then display details info in RegionServer status UI Should implement getRegionServers(boolean) method in AsyncAdmin,13384565,Resolved,Major,Fixed,18/Jun/21 16:01,27/Jun/21 14:21,,"We have this method in Admin but not in AsyncAdmin, we should align these two interfaces." Implement a master based ReplicationTracker,13382338,Resolved,Major,Fixed,06/Jun/21 14:23,17/Jun/21 10:40,,"Now the only thing we care about is the live region servers and we can get this information from master, so let's do it to remove the dependencies on zookeeper." Fix typo in NOTICE.vm,13381794,Resolved,Major,Fixed,02/Jun/21 21:46,23/Jun/21 16:49,1.4.0,"I noticed there's a typo in {{hbase-resource-bundle/src/main/resources/META-INF/NOTICE.vm}}: ""bundled-boostrap"" instead of ""bundled-bootstrap""." Split TestWALEntryStream.testDifferentCounts out,13384924,Resolved,Major,Fixed,21/Jun/21 14:11,23/Jun/21 15:27,,"It consumes too much time and may cause the whole UT to timeout. And in fact, it should be implemented as parameterized." DNS jitter causes hbase client to get stuck,13385094,Open,Major,,22/Jun/21 07:49,,1.2.0,"In our product hbase cluster, we occasionally encounter below errors, and stuck hbase a long time. Then hbase requests to this machine will fail forever. {code:java} WARN org.apache.hadoop.security.UserGroupInformation: PriviledgedActionException as:${user@realm} (auth:KERBEROS) cause:javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Server not found in Kerberos database (7) - LOOKING_UP_SERVER)] WARN org.apache.hadoop.security.UserGroupInformation: PriviledgedActionException as:${user@realm} (auth:KERBEROS) cause:java.io.IOException: Couldn't setup connection for ${user@realm} to hbase/${ip}@realm {code} The main problem is  the trully server principal we generated in KDC is  hbase/*${hostname}*@realm, so we must can't find  hbase/*${ip}*@realm in KDC. When RpcClientImpl#Connection construct, the field serverPrincial which never changed generated by method InetAddress.getCanonicalHostName() which will return IP when failed to get hostname. Therefor, once DNS jitter when RpcClientImpl#Connection, this connection will never setup sasl env. And I'm not see connection abandon logic in sasl failed code path. I think of two solutions to this problem:  # Abandon connection when sasl failed. So next request will reconstruct a connection, and will regenerate a new server principal. # Refresh serverPrincial field when sasl failed. So next retry will use new server principal. HBase Version: 1.2.0-cdh5.14.4" Add access check for compactionSwitch,13377831,Resolved,Major,Fixed,11/May/21 11:00,22/Jun/21 15:53,,"Should we add access check for org.apache.hadoop.hbase.regionserver.RSRpcServices#compactionSwitch    " Polish the ReplicationSourceWALReader code for 2.x after HBASE-25596,13383111,Resolved,Major,Fixed,10/Jun/21 08:18,21/Jun/21 15:59,,"The code are very different for 2.x and 1.x, and the original code for HBASE-25596 is for 1.x, so create this issue to polish the code to make it more suitable for 2.x." Update ref guide about the EOL for 2.2.x,13383840,Resolved,Major,Fixed,15/Jun/21 03:59,18/Jun/21 16:07,,"For example, remove the release manager for 2.2.x, and also update the compatibility matrix with hadoop, etc." Request compact to compaction server,13381856,Resolved,Major,Fixed,03/Jun/21 07:41,21/Jun/21 03:06,,"In this patch, figure out the offload compaction process: HRegionserver->compactionOffloadManager->compactionserver-> HRegionserver, and implement code in HRegionserver, compactionOffloadManager, the code of compactionserver left to next patch" Backport HBASE-25596 and HBASE-25992 to branch-2.3,13381620,Open,Major,,02/Jun/21 06:32,,, Revisit synchronization in SyncFuture,13383447,Resolved,Major,Fixed,11/Jun/21 15:51,19/Jun/21 00:52,1.7.0,"While working on HBASE-25984, I noticed some weird frames in the flame graphs around monitor entry exit consuming a lot of CPU cycles (see attached images). Noticed that the synchronization there is too coarse grained and sometimes unnecessary. I did a simple patch that switched to a reentrant lock based synchronization with condition variable rather than a busy wait and that showed 70-80% increased throughput in WAL PE. Seems too good to be true.. (more details in the comments)." ServiceLoader usages should not be tied to Thread Context Classloader,13384508,Open,Major,,18/Jun/21 10:01,,,"Classes which uses ServiceLoader facility does not specify ClassLoader to use. For hbase-client 2.4.1 they are (at least): * SaslClientAuthenticationProviders * MetricRegistries When hbase libraries are loaded dynamically and Thread Context Classloader is not set SaslClientAuthenticationProviders instantiation failes becuse it can't find default providers. Some proposals for classloader selection strategy (usage dependent I guess): * Use classloader specified in Configuration instance. * Use classloader which loaded specific hbase class * Combine them: use classloader from Configuration if present and fallback to classloader which loaded specific hbase class Real world requirement example: currently we migrating from hbase 1 to hbase 2. For better compatibility and smooth migration we try to build abstraction around hbase client libraries and isolate them with custom classloaders. To workaround problems with context classloader we must either wrap all calls to use proper contextclassloader or explicitly trigger initialization of affected classes (SaslClientAuthenticationProviders) wich are marked private under proper context classloader. It would be better if hbase client will take care of it itself." Change the method name for DoubleArrayCost.setCosts,13383293,Resolved,Major,Fixed,11/Jun/21 01:28,15/Jun/21 05:19,,"See this discussion. https://github.com/apache/hbase/pull/3276#discussion_r643448466 It is a little strange to have setter to pass in a function." Active WAL tailing fails when WAL value compression is enabled,13383268,Resolved,Major,Fixed,10/Jun/21 19:50,15/Jun/21 00:16,2.5.0,"Depending on which compression codec is used, a short read of the compressed bytes can cause catastrophic errors that confuse the WAL reader. This problem can manifest when the reader is actively tailing the WAL for replication. The input stream's available() method sometimes lies so cannot be relied upon. To avoid these issues, when WAL value compression is enabled, ensure all bytes of the compressed value are read before submitting the payload to the decompressor. " FanOutOneBlockAsyncDFSOutput using shaded protobuf in hdfs 3.3+,13383004,Resolved,Major,Fixed,09/Jun/21 16:54,12/Jun/21 14:33,,"The parent added some fancy dancing to make it so on hadoop-3.3.0+ we'd use hadoops shaded protobuf rather than the non-relocated protobuf. When hdfs 3.3, the 'trick' is not working so we continue to use the unshaded protobuf. Fix is trivial. Found this testing the 3.3.1RC3. Hard to see because whether we use shaded or unshaded is at DEBUG level. If you set DEBUG level and run TestFanOutOneBlockAsyncDFSOutput with hdfs 3.3.1 RC candidate in place you'll see it uses the unshaded protobuf." Improve the performance for region load and region count related cost functions,13379059,Resolved,Major,Fixed,18/May/21 13:24,25/May/21 10:13,,"For a large cluster, we have a lot of regions, so computing the whole cost will be expensive. We should try to remove the unnecessary calculation as much as possible." Make excluded SSL cipher suites configurable for all Web UIs,13383198,Resolved,Major,Fixed,10/Jun/21 13:49,10/Jun/21 17:39,2.2.7,"When starting a jetty http server, one can explicitly exclude certain (unsecure) SSL cipher suites. This can be especially important, when the HBase cluster needs to be compliant with security regulations (e.g. FIPS). Currently it is possible to set the excluded ciphers for the ThriftServer (""hbase.thrift.ssl.exclude.cipher.suites"") or for the RestServer (""hbase.rest.ssl.exclude.cipher.suites""), but one can not configure it for the regular InfoServer started by e.g. the master or region servers. In this commit I want to introduce a new configuration ""ssl.server.exclude.cipher.list"" to configure the excluded cipher suites for the http server started by the InfoServer. This parameter has the same name and will work in the same way, as it was already implemented in hadoop (e.g. for hdfs/yarn). See: HADOOP-12668, HADOOP-14341" Seeing a spike in uncleanlyClosedWALs metric.,13380557,Resolved,Major,Fixed,26/May/21 14:41,10/Jun/21 17:29,1.7.0,"Getting the following log line in all of our production clusters when WALEntryStream is dequeuing WAL file. {noformat} 2021-05-02 04:01:30,437 DEBUG [04901996] regionserver.WALEntryStream - Reached the end of WAL file hdfs://. It was not closed cleanly, so we did not parse 8 bytes of data. This is normally ok. {noformat} The 8 bytes are usually the trailer serialized size (SIZE_OF_INT (4bytes) + ""LAWP"" (4 bytes) = 8 bytes) While dequeue'ing the WAL file from WALEntryStream, we reset the reader here. [WALEntryStream|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java#L199-L221] {code:java} private void tryAdvanceEntry() throws IOException { if (checkReader()) { readNextEntryAndSetPosition(); if (currentEntry == null) { // no more entries in this log file - see if log was rolled if (logQueue.getQueue(walGroupId).size() > 1) { // log was rolled // Before dequeueing, we should always get one more attempt at reading. // This is in case more entries came in after we opened the reader, // and a new log was enqueued while we were reading. See HBASE-6758 resetReader(); ---> HERE readNextEntryAndSetPosition(); if (currentEntry == null) { if (checkAllBytesParsed()) { // now we're certain we're done with this log file dequeueCurrentLog(); if (openNextLog()) { readNextEntryAndSetPosition(); } } } } // no other logs, we've simply hit the end of the current open log. Do nothing } } // do nothing if we don't have a WAL Reader (e.g. if there's no logs in queue) } {code} In resetReader, we call the following methods, WALEntryStream#resetReader ----> ProtobufLogReader#reset ---> ProtobufLogReader#initInternal. In ProtobufLogReader#initInternal, we try to create the whole reader object from scratch to see if any new data has been written. We reset all the fields of ProtobufLogReader except for ReaderBase#fileLength. We calculate whether trailer is present or not depending on fileLength." Back port HBASE-25924 and its related patches to branch-2.3,13381505,Open,Major,,01/Jun/21 16:45,,2.3.6,The branch has diverged a bit and the patches are not applying clean. Make SSL keystore type configurable for HBase ThriftServer,13382882,Resolved,Major,Fixed,09/Jun/21 08:24,09/Jun/21 16:02,2.2.7,"We get the following exception, when trying to start Hbase Thrift Server in http mode (hbase.regionserver.thrift.http=true) and use non default (not ""jks"") keystore type:   {noformat} 2021-06-08 07:40:10,275 ERROR org.apache.hadoop.hbase.thrift.ThriftServer: Cannot run ThriftServer java.io.IOException: Invalid keystore format at sun.security.provider.JavaKeyStore.engineLoad(JavaKeyStore.java:663) at sun.security.provider.JavaKeyStore$JKS.engineLoad(JavaKeyStore.java:56) at sun.security.provider.KeyStoreDelegator.engineLoad(KeyStoreDelegator.java:224) at sun.security.provider.JavaKeyStore$DualFormatJKS.engineLoad(JavaKeyStore.java:70) at java.security.KeyStore.load(KeyStore.java:1445) at org.eclipse.jetty.util.security.CertificateUtils.getKeyStore(CertificateUtils.java:54) at org.eclipse.jetty.util.ssl.SslContextFactory.loadKeyStore(SslContextFactory.java:1197) at org.eclipse.jetty.util.ssl.SslContextFactory.load(SslContextFactory.java:321) at org.eclipse.jetty.util.ssl.SslContextFactory.doStart(SslContextFactory.java:243) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) at org.eclipse.jetty.server.SslConnectionFactory.doStart(SslConnectionFactory.java:97) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117) at org.eclipse.jetty.server.AbstractConnector.doStart(AbstractConnector.java:321) at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:81) at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:234) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.eclipse.jetty.server.Server.doStart(Server.java:401) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73) at org.apache.hadoop.hbase.thrift.ThriftServer$2.run(ThriftServer.java:861) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:360) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1878) at org.apache.hadoop.hbase.thrift.ThriftServer.run(ThriftServer.java:855) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.hbase.thrift.ThriftServer.main(ThriftServer.java:882){noformat} This problem appeared after we applied HBASE-25930 to our local HBase version. It looks, we never had a parameter to specify the keystore type for thrift http server. Before HBASE-25930, the keystore type used by the thrift http server was accidentally defined based on the InfoServer (web ui) configuration of ""ssl.server.keystore.type"". Before HBASE-25930, the InfoServer was started first and it set the keystore type in the global keystore manager, which setting propagated to the thrift http server too, without any override. In HBASE-25930 the startup order changed, and the thrift http server configuration happens before the InfoServer start, so we lack this accidental configuration change now. Given that we have independent keystore file path / password parameters already for the thrift http server, the proper solution is to create a new parameter also for the keystore type of the thrift http server: *hbase.thrift.ssl.keystore.type* (defaulting to ""jks"")." add basic compaction server metric,13381189,Resolved,Major,Fixed,31/May/21 03:18,09/Jun/21 15:25,,"the ServerLoad has RegionLoad, ReplicationLoadSource/ReplicationLoadSink metrics, which is nothing to do with Compaction server. So,  introduce CompactionServerLoad, only has compaction related metircs" Thrift does not support requests in Kerberos environment,13380760,Resolved,Major,Fixed,27/May/21 12:16,04/Jun/21 07:08,2.2.6,"In Kerberos environment, running DemoClient to request thrift server failed   !image-2021-05-27-20-17-48-466.png!" HBaseCluster should be marked as IA.Public,13381711,Resolved,Major,Fixed,02/Jun/21 14:10,06/Jun/21 13:30,,"Its sub class MiniHBaseCluster is marked as IA.Public, so it should also be IA.Public. And in general, HBaseCluster just provides some abstract method so I think it is OK to expose it as IA.Public. But for MiniHBaseCluster, it exposes several internal stuff such as RegionServerThread so maybe it should not be marked as IA.Public." TestJMXConnectorServer fails with BindException,13382527,Open,Major,,07/Jun/21 16:17,,,"Test needs to accommodate port clashes as TestJMXListener et al. does. {code} 2021-06-05 05:13:47,401 ERROR [master/d1cb58dfe2a6:0:becomeActiveMaster] coprocessor.CoprocessorHost(416): The coprocessor org.apache.hadoop.hbase.JMXListener threw java.rmi.server.ExportException: Port already in use: 49932; nested exception is: java.net.BindException: Address already in use (Bind failed) java.rmi.server.ExportException: Port already in use: 49932; nested exception is: java.net.BindException: Address already in use (Bind failed) at java.rmi/sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:335) at java.rmi/sun.rmi.transport.tcp.TCPTransport.exportObject(TCPTransport.java:243) at java.rmi/sun.rmi.transport.tcp.TCPEndpoint.exportObject(TCPEndpoint.java:412) at java.rmi/sun.rmi.transport.LiveRef.exportObject(LiveRef.java:147) at java.rmi/sun.rmi.server.UnicastServerRef.exportObject(UnicastServerRef.java:234) at java.rmi/sun.rmi.registry.RegistryImpl.setup(RegistryImpl.java:220) at java.rmi/sun.rmi.registry.RegistryImpl.(RegistryImpl.java:205) at java.rmi/java.rmi.registry.LocateRegistry.createRegistry(LocateRegistry.java:203) at org.apache.hadoop.hbase.JMXListener.startConnectorServer(JMXListener.java:134) at org.apache.hadoop.hbase.JMXListener.start(JMXListener.java:209) at org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:72) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:283) at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.loadSystemCoprocessors(CoprocessorHost.java:168) at org.apache.hadoop.hbase.master.MasterCoprocessorHost.(MasterCoprocessorHost.java:158) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:897) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2091) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:507) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: java.net.BindException: Address already in use (Bind failed) at java.base/java.net.PlainSocketImpl.socketBind(Native Method) at java.base/java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:436) at java.base/java.net.ServerSocket.bind(ServerSocket.java:395) at java.base/java.net.ServerSocket.(ServerSocket.java:257) at java.base/java.net.ServerSocket.(ServerSocket.java:149) at java.rmi/sun.rmi.transport.tcp.TCPDirectSocketFactory.createServerSocket(TCPDirectSocketFactory.java:45) at java.rmi/sun.rmi.transport.tcp.TCPEndpoint.newServerSocket(TCPEndpoint.java:670) at java.rmi/sun.rmi.transport.tcp.TCPTransport.listen(TCPTransport.java:324) ... 17 more {code}" Remove 2.2.7 from download page,13382361,Resolved,Major,Fixed,07/Jun/21 01:30,07/Jun/21 03:43,,I think it is time to do this. Shell alter command (modify operation) sometimes times out,13382257,Open,Major,,05/Jun/21 04:42,,2.1.4,"Execution of an alter command like the following on a non-interactive shell sometimes times out: {code:java} echo ""alter 'aeris_v2', {NAME=>'e', VERSIONS=>'43200', MIN_VERSIONS=>'3', TTL=>'7776000'}, NANOSECOND_TIMESTAMPS => 'true'"" | hbase shell -n{code} A similar issue was reported in [HBASE-21795|https://issues.apache.org/jira/browse/HBASE-21795], but based on its description it should be resolved on the HBase versions we are running (2.1.4, 2.2.4). The hbasemaster and regionserver logs attached are relevant to one occurrence of the issue when the command started at 2021-05-29 05:25 and timed out 10 minutes later at 2021-05-29 05:35. Note that the affected table appeared to be modified even though the shell command timed out. The hbase shell debug output attached is from another similar failure where we managed to toggle the shell d flag to capture extra debug information. The capture indicates the zookeeper client session being closed at the 1-minute mark and the command failing at the 10-minute mark with a timeout. If there is a way to output even more debugging information (e.g. stack traces) from the shell process other than specifying the ""d"" flag to help troubleshoot the issue, please let us know." Fix wrong initialization value in StressAssignmentManagerMonkeyFactory,13372581,Resolved,Major,Fixed,15/Apr/21 08:54,19/Apr/21 09:57,,the initialization of BatchRestartRsAction and RollingBatchRestartRsAction in StressAssignmentManagerMonkeyFactory use wrong default value. TestWALEntryStream#testCleanClosedWALs test is failing.,13380778,Resolved,Major,Fixed,27/May/21 13:32,01/Jun/21 15:31,2.3.6,"We are seeing the following test failure. TestWALEntryStream#testCleanClosedWALs This test was added in HBASE-25924. I don't think the test failure has anything to do with the patch in HBASE-25924. Before HBASE-25924, we were *not* monitoring _uncleanlyClosedWAL_ metric. In all the branches, we were not parsing the wal trailer when we close the wal reader inside ReplicationSourceWALReader thread. The root cause was when we add active WAL to ReplicationSourceWALReader, we cache the file size when the wal was being actively written and once the wal was closed and replicated and removed from WALEntryStream, we did reset the ProtobufLogReader object but we didn't update the length of the wal and that was causing EOF errors since it can't find the WALTrailer with the stale wal file length. The fix applied nicely to branch-1 since we use FSHlog implementation which closes the WAL file sychronously. But in branch-2 and master, we use _AsyncFSWAL_ implementation and the closing of wal file is done asynchronously (as the name suggests). This is causing the test to fail. Below is the test. {code:java} @Test public void testCleanClosedWALs() throws Exception { try (WALEntryStream entryStream = new WALEntryStream( logQueue, CONF, 0, log, null, logQueue.getMetrics(), fakeWalGroupId)) { assertEquals(0, logQueue.getMetrics().getUncleanlyClosedWALs()); appendToLogAndSync(); assertNotNull(entryStream.next()); log.rollWriter(); =======> This does an asynchronous close of wal. appendToLogAndSync(); assertNotNull(entryStream.next()); assertEquals(0, logQueue.getMetrics().getUncleanlyClosedWALs()); } } {code} In the above code, when we roll writer, we don't close the old wal file immediately so the ReplicationReader thread is not able to get the updated wal file size and that is throwing EOF errors. If I add a sleep of few milliseconds (1 ms in my local env) between rollWriter and appendToLogAndSync statement then the test passes but this is *not* a proper fix since we are working around the race between ReplicationSourceWALReaderThread and closing of WAL file." [hbase-thirdparty] Relocate mac jnilib for netty,13381650,Resolved,Major,Fixed,02/Jun/21 09:15,02/Jun/21 10:43,, [hbase-thirdparty] Generate CHANGES.md and RELEASENOTES.md for 3.5.1,13381061,Resolved,Major,Fixed,29/May/21 01:59,02/Jun/21 02:55,, TestRESTServerSSL fails because of jdk bug,13381053,Resolved,Major,Fixed,28/May/21 22:35,31/May/21 04:38,,"[~weijing329] identified issue in TestRESTServerSSL when using jdk8 292+. It came up in comment in the parent issue. I verified it fails for me using jdk8 v292. Here is the failure.... ```[INFO] Running org.apache.hadoop.hbase.rest.TestRESTServerSSL [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.4 s <<< FAILURE! - in org.apache.hadoop.hbase.rest.TestRESTServerSSL [ERROR] org.apache.hadoop.hbase.rest.TestRESTServerSSL Time elapsed: 1.387 s <<< ERROR! java.security.NoSuchAlgorithmException: unrecognized algorithm name: PBEWithSHA1AndDESede at org.apache.hadoop.hbase.rest.TestRESTServerSSL.beforeClass(TestRESTServerSSL.java:74)``` For workaround, see https://github.com/bcgit/bc-java/issues/941" Move FavoredNodeLoadBalancer to hbase-balancer module,13380373,Resolved,Major,Fixed,25/May/21 15:29,31/May/21 14:55,, Remove deprecated ZK command 'rmr' in hbase-cleanup.sh,13381074,Resolved,Major,Fixed,29/May/21 04:12,31/May/21 05:40,2.5.0,"Deprecated command 'rmr' was removed from ZooKeeper since 3.6.0(see: ZOOKEEPER-3411). It's better to use 'deleteall' instead." Move RSGroupBasedLoadBalancer to hbase-balancer,13380374,Open,Major,,25/May/21 15:29,,, Move RSGroupInfoManager to hbase-balancer,13381161,Open,Major,,30/May/21 15:18,,, Move rs group related balancer code to hbase-balancer module,13381309,Open,Major,,31/May/21 15:21,,, [hbase-thirdparty] Set version as 3.5.1 in prep for first RC,13381060,Resolved,Major,Fixed,29/May/21 01:58,31/May/21 13:43,, Move more tests code for StochasticLoadBalancer to hbase-balancer module,13381000,Resolved,Major,Fixed,28/May/21 14:49,30/May/21 14:39,, "Update Compression/TestCompressionTest: LZ4, SNAPPY, LZO",13381048,Resolved,Major,Fixed,28/May/21 21:05,29/May/21 16:18,,"LZ4 was changed in hadoop-3.3.1 to use a more amenable library, one that did not require gymnastics installing lz4 native libs everywhere; rather, you just add a jar to the classpath. See HADOOP-17292. Similar was done for SNAPPY. See HADOOP-17125. What this means is that our TestCompressionTest passes for hadoop before 3.3.1 but at 3.3.1, the assert that SNAPPY and LZ4 compressors should fail -- because no lib installed -- now no longer asserts. While in here, LZO is GPL and requires extra install to setup [1]. When TestCompressionTest runs, it emits the below for the LZO check. The check is kinda useless. {code} 2021-05-28T10:05:36,513 WARN [Time-limited test] util.CompressionTest(75): Can't instantiate codec: lzo org.apache.hadoop.hbase.DoNotRetryIOException: Compression algorithm 'lzo' previously failed test. {code} I think best thing for now is to comment out the asserts that LZ4 and SNAPPY do NOT work when binary cannot be found -- since this holds only if hadoop < 3.3..1; the test is a little weak anyways. 1. https://stackoverflow.com/questions/23441142/class-com-hadoop-compression-lzo-lzocodec-not-found-for-spark-on-cdh-5" Exclude jakarta.activation-api,13380150,Resolved,Major,Fixed,24/May/21 16:29,28/May/21 01:19,2.3.0,"Hadoop 3.3.1 replaced its dependency of javax.activation 1.2.0 with jakarta.activation 1.2.1. They are essentially the same thing (they even have the same classpath name), but Eclipse took over JavaEE development and therefore changed group/artifact id. (https://stackoverflow.com/questions/46493613/what-is-the-replacement-for-javax-activation-package-in-java-9) See HADOOP-17049 for more details. Hadoop 3.3.0 updated jackson-databind to 2.10 which shades jakarta.activation, causing classpath conflict. The solution to this issue will be similar to HBASE-22268" TestHBaseConfiguration#testDeprecatedConfigurations is broken with Hadoop 3.3,13380638,Resolved,Major,Fixed,26/May/21 22:48,28/May/21 14:45,2.5.0,"The test TestHBaseConfiguration#testDeprecatedConfigurations was added recently by HBASE-25861 to address the usage of Hadoop Configuration addDeprecations API. However, the API's behavior was changed to fix a bug." Move FavoredNodeManager to hbase-balancer module,13380763,Resolved,Major,Fixed,27/May/21 12:29,28/May/21 07:58,, [hbase-thirdparty] Bump dependencis in hbase-thirdparty,13381058,Resolved,Major,Fixed,29/May/21 01:46,29/May/21 02:48,, Correct the usage of Configuration#addDeprecation,13377130,Resolved,Major,Fixed,07/May/21 03:31,28/May/21 14:46,2.5.0,"When I was solving HBASE-25745 ([PR3139|https://github.com/apache/hbase/pull/3139]), I found that our use of Configuration#addDeprecation API was wrong.    At present, we will call Configuration#addDeprecation in the static block for the deprecated configuration. But after testing, it is found that this does not complete backward compatibility. When user upgrades HBase and does not change the deprecated configuration to the new configuration, he will find that the deprecated configuration does not effect, which may not be consistent with expectations. The specific test results can be seen in the PR above, and we can found the calling order of Configuration#addDeprecation is very important.   Configuration#addDeprecation is a Hadoop API, looking through the Hadoop source code, we will find that before creating the Configuration object, the addDeprecatedKeys() method will be called first: [https://github.com/apache/hadoop/blob/b93e448f9aa66689f1ce5059f6cdce8add130457/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/HdfsConfiguration.java#L34] ." Add target Region to connection exceptions,13369690,Resolved,Major,Fixed,06/Apr/21 06:01,08/Apr/21 20:42,,"We spent a bit of time making it so exceptions included the remote host name. Looks like we can add the target Region name too with a bit of manipulation; will help figuring hot-spotting or problem Region on serverside. For example, here is what I was seeing recently on client-side when a RS was was timing out requests: {code} 2021-04-06T02:18:23.533Z, RpcRetryingCaller{globalStartTime=1617675482894, pause=100, maxAttempts=4}, org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to ps0989.example.org/1.1.1.1:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:145) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:383) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:357) ... Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to ps0989.bot.parsec.apple.com/17.58.114.206:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 at org.apache.hadoop.hbase.ipc.IPCUtil.wrapException(IPCUtil.java:209) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:378) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:89) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:409) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:405) at org.apache.hadoop.hbase.ipc.Call.setTimeout(Call.java:110) at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:136) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:672) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:747) at org.apache.hbase.thirdparty.io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:472) ... 1 more Caused by: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=88369369,methodName=Get], waitTime=5006, rpcTimeout=5000 at org.apache.hadoop.hbase.ipc.RpcConnection$1.run(RpcConnection.java:137) ... 4 more {code} I wanted the region it was hitting. I wanted to know if it was a server problem or a Region issue. If clients only having issue w/ one Region, then I could focus on it. After the PR the exception (from another context) looks like this: {code} org.apache.hadoop.hbase.ipc.CallTimeoutException: Call to address=127.0.0.1:12345, regionInfo=hbase:meta,,1.1588230740 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: error .... {code}" Data is not getting replicated to secondary replicas after altering a table to enable region replication (async Wal replication),13380983,Open,Major,,28/May/21 13:07,,,"Data is not getting replicated to secondary replicas after altering a table to enable region replication (async Wal replication) *Test Steps:* 1)Create table with one replica  create 'table1','cf' 2)Alter table with region replica=3 alter 'table1',\{REGION_REPLICATION => '3'} 3)write data to table1  *Observation:* 1)Data is not getting replicated to secondary replicas this is happening when alter table after the peer is created for region replication. 2)In table UI page also you can observe write requests showing for secondary replicas=0" Move MetaTableAccessor out of hbase-balancer module,13370810,Resolved,Major,Fixed,10/Apr/21 13:48,28/May/21 01:19,,"It should not be there. The only reason we have to put it there is the favor node balancer. The favor node balancer does not work well so maybe we could just purge it. ==== update ==== With HBASE-25926 in place we could just move it directly." Cleanup MetaTableAccessor references in FavoredNodeBalancer related code,13380571,Resolved,Major,Fixed,26/May/21 15:15,27/May/21 10:00,,"Actually we do not need to use MetaTableAccessor here, and we do not need to put region info when updating favored node. And also the tests need some improvements." Add compaction offload switch,13374365,Resolved,Major,Fixed,22/Apr/21 10:04,27/May/21 06:18,,"Add this swith to control each regionserver whether enable compaction offload feature. Also, we keep a boolean value in zookeeper as cluster status, RS take this default value when start up." RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start,13377613,Resolved,Major,Fixed,10/May/21 11:34,25/May/21 18:49,,"RegionServer failed to complete initialization and aborted during AuthenticationTokenSecretManager#leaderElector start. Observed following WARN log, {noformat} 2021-05-03 07:59:01,848 | WARN | RS-EventLoopGroup-1-6 | Thread leaderElector[ZKSecretWatcher-leaderElector:56] is stopped or not alive | org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:153) 2021-05-03 07:59:01,848 | INFO | RS-EventLoopGroup-1-6 | Thread leaderElector [ZKSecretWatcher-leaderElector:56] is started | org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.retrievePassword(AuthenticationTokenSecretManager.java:156) 2021-05-03 07:59:01,854 | INFO | ZKSecretWatcher-leaderElector | Found existing leader with ID: RS-IP-PORT-StartCode | org.apache.hadoop.hbase.zookeeper.ZKLeaderManager.waitToBecomeLeader(ZKLeaderManager.java:130) {noformat} As per the code, AuthenticationTokenSecretManager#leaderElector is started while retrieving password before AuthenticationTokenSecretManager#start, [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L155] So IllegalThreadStateException occured during AuthenticationTokenSecretManager#start, [https://github.com/apache/hbase/blob/8c2332d46532135723cc7a6084a2a125f3d9d8db/hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java#L107] {noformat} 2021-05-03 07:59:02,066 | ERROR | main | Failed construction RegionServer | org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:775) java.lang.IllegalThreadStateException at java.lang.Thread.start(Thread.java:708) at org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.start(AuthenticationTokenSecretManager.java:107) at org.apache.hadoop.hbase.ipc.NettyRpcServer.start(NettyRpcServer.java:131) at org.apache.hadoop.hbase.regionserver.RSRpcServices.start(RSRpcServices.java:1695) at org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:756) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.regionserver.HRegionServer.constructRegionServer(HRegionServer.java:3270) at org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.start(HRegionServerCommandLine.java:63) at org.apache.hadoop.hbase.regionserver.HRegionServerCommandLine.run(HRegionServerCommandLine.java:87) {noformat}" Client integration test is failing on master and branch-2,13380019,Resolved,Major,Fixed,24/May/21 02:34,26/May/21 15:10,,"{noformat} Starting up HBase 127.0.0.1: Host key verification failed. running master, logging to /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/hbase-install/bin/../logs/hbase-jenkins-master-jenkins-hbase7.out 2021-05-22T04:16:40,142 INFO [main] master.HMaster: STARTING service HMaster 2021-05-22T04:16:40,149 INFO [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT 2021-05-22T04:16:40,149 INFO [main] util.VersionInfo: Source code repository file:///home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/unpacked_src_tarball revision=Unknown 2021-05-22T04:16:40,149 INFO [main] util.VersionInfo: Compiled by jenkins on Sat May 22 04:07:41 UTC 2021 2021-05-22T04:16:40,149 INFO [main] util.VersionInfo: From source with checksum b6959885410c34f4458efd580213907ca50e84a0a900ea1d465d04a1a9480e520419d51da933547e3f517850a2913a8e8aefbcd6ba9e12589fced980910fb941 cat: /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers: No such file or directory cat: /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/output-integration/hadoop-3/hbase-conf//regionservers: No such file or directory retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. retry waiting for hbase to come up. /home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh: line 539: 3122 Terminated sleep ""${sleep_time}"" Shutting down HBase no hbase master found {noformat}" FavoredNodeBalancer related code refactoring and improvement,13380558,Open,Major,,26/May/21 14:46,,,"Will do some code refactoring first before actually moving it to hbase-balancer in HBASE-25649, as some of the improvements can also go to branch-2." Move StochasticLoadBalancer to hbase-balancer module,13375383,Resolved,Major,Fixed,27/Apr/21 16:19,25/May/21 15:25,, Corrupt wal while region server is aborting.,13378331,Resolved,Major,Fixed,13/May/21 16:00,26/May/21 03:04,1.6.0,"We have seen a case in our production cluster where we ended up in corrupt wal. WALSplitter logged the below error {noformat} 2021-05-12 00:42:46,786 FATAL [XXXX:60020-1] regionserver.HRegionServer - ABORTING region server HOST-B,60020,16207794418 88: Caught throwable while processing event RS_LOG_REPLAY java.lang.NullPointerException at org.apache.hadoop.hbase.CellUtil.matchingFamily(CellUtil.java:411) at org.apache.hadoop.hbase.regionserver.wal.WALEdit.isMetaEditFamily(WALEdit.java:145) at org.apache.hadoop.hbase.regionserver.wal.WALEdit.isMetaEdit(WALEdit.java:150) at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:408) at org.apache.hadoop.hbase.wal.WALSplitter.splitLogFile(WALSplitter.java:261) at org.apache.hadoop.hbase.regionserver.SplitLogWorker$1.exec(SplitLogWorker.java:105) at org.apache.hadoop.hbase.regionserver.handler.WALSplitterHandler.process(WALSplitterHandler.java:72) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} Looking at the raw wal file, we could see that the last WALEdit contains the region id, tablename and sequence number but cells were not persisted. Looking at the logs of the RS that generated that corrupt wal file, {noformat} 2021-05-11 23:29:22,114 DEBUG [/HOST-A:60020] wal.FSHLog - Closing WAL writer in /hbase/WALs/HOST-A,60020,1620774393046 2021-05-11 23:29:22,196 DEBUG [/HOST-A:60020] ipc.AbstractRpcClient - Stopping rpc client 2021-05-11 23:29:22,198 INFO [/HOST-A:60020] regionserver.Leases - regionserver/HOST-A/:60020 closing leases 2021-05-11 23:29:22,198 INFO [/HOST-A:60020] regionserver.Leases - regionserver/HOST-A:/HOST-A:60020 closed leases 2021-05-11 23:29:22,198 WARN [0020.append-pool8-t1] wal.FSHLog - Append sequenceId=7147823, requesting roll of WAL java.nio.channels.ClosedChannelException at org.apache.hadoop.hdfs.DataStreamer$LastExceptionInStreamer.throwException4Close(DataStreamer.java:331) at org.apache.hadoop.hdfs.DFSOutputStream.checkClosed(DFSOutputStream.java:151) at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:105) at org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:58) at java.io.DataOutputStream.write(DataOutputStream.java:107) at org.apache.hadoop.hbase.KeyValue.write(KeyValue.java:2543) at org.apache.phoenix.hbase.index.wal.KeyValueCodec.write(KeyValueCodec.java:104) at org.apache.hadoop.hbase.regionserver.wal.IndexedWALEditCodec$IndexKeyValueEncoder.write(IndexedWALEditCodec.java:218) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogWriter.append(ProtobufLogWriter.java:128) at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.append(FSHLog.java:2083) at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1941) at org.apache.hadoop.hbase.regionserver.wal.FSHLog$RingBufferEventHandler.onEvent(FSHLog.java:1857) at com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:129) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) {noformat} These 2 lines are interesting. {quote}2021-05-11 23:29:22,114 DEBUG [/HOST-A:60020] wal.FSHLog - Closing WAL writer in /hbase/WALs/HOST-A,60020,1620774393046 .... .... 2021-05-11 23:29:22,198 WARN [0020.append-pool8-t1] wal.FSHLog - Append sequenceId=7147823, requesting roll of WAL java.nio.channels.ClosedChannelException {quote} The append thread encountered java.nio.channels.ClosedChannelException while writing to wal file because the wal file was already closed. This is the sequence of shutting down of threads when RS aborts. {noformat} // With disruptor down, this is safe to let go. if (this.appendExecutor != null) this.appendExecutor.shutdown(); // Tell our listeners that the log is closing ... if (LOG.isDebugEnabled()) { LOG.debug(""Closing WAL writer in "" + FSUtils.getPath(fullPathLogDir)); } if (this.writer != null) { this.writer.close(); this.writer = null; } } {noformat} 1. Shutdown the appendExecutor (but we *don't* wait for the currently running tasks to complete) 2. Close the writer. This will in turn close the wal log file. We need to wait for appendExecutor to terminate properly and then only close the writer. Code has been changed a lot in master branch. Need to study whether this bug exists in master/branch-2" Support Hadoop 3.3.1,13380435,Resolved,Major,Duplicate,26/May/21 01:30,26/May/21 01:45,,"The Hadoop 3.3.1 is a big release, quite different from 3.3.0. File this jira to track the support for Hadoop 3.3.1." UI of master-status to show a recent history of that why balancer was rejected to run,13373587,Resolved,Major,Fixed,19/Apr/21 10:37,25/May/21 17:05,, Refactor and cleanup the code for CostFunction,13377517,Resolved,Major,Fixed,09/May/21 14:09,24/May/21 14:18,,For later performance improvements. "Improve logging in ""packaging and integration"" stage",13380186,Open,Major,,24/May/21 20:22,,3.0.0-alpha-1,"We had a nightly build of master [fail inscrutably|https://ci-hadoop.apache.org/blue/organizations/jenkins/HBase%2FHBase%20Nightly/detail/master/298/pipeline/103]. Looks like the build went down some dark hole and didn't make a peep for almost 16h. It would be nice to get some logging from whatever process that was. {noformat} [2021-05-20T20:13:45.733Z] Attempting to use run an instance on top of Hadoop 3. [2021-05-21T11:58:19.827Z] Sending interrupt signal to process [2021-05-21T11:58:20.683Z] Sending interrupt signal to process [2021-05-21T11:58:32.771Z] script returned exit code 2 {noformat}" Ban System.currentTimeMillis with a build enforcer,13380214,Open,Major,,25/May/21 00:06,,,"We introduced EnvironmentEdgeManager a long time ago as a way to inject alternate clocks (gettimeofday() aka System.currentTimeMillis()) for unit tests. In order for this to be effective, all callers that would otherwise use System.currentTimeMillis() must call EnvironmentEdgeManager.currentTime() instead, except obviously the implementors of EnvironmentEdge. It's common for contributors to be unaware of this practice and reviewers might not catch it. It will be much more important to have EnvironmentEdgeManager in use where expected once we have EnvironmentEdge also providing a monotonic clock source. (See parent.) Introduce a build enforcer that bans System.currentTimeMillis() except where annotated to allow it." Backup tests are categorically flakey,13378371,Resolved,Major,Fixed,13/May/21 20:50,24/May/21 01:36,,"Here's some logs from a PR build vs. master that suffered a significant number of failures in the backup tests. I suspect that a single improvement could fix all of these tests to be more robust. {noformat} Test Name Duration Age precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestBackupDeleteRestore.testBackupDeleteRestore 6 min 23 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestBackupDeleteRestore.(?) 1 min 6 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestBackupMerge.TestIncBackupMergeRestore 5 min 3 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestBackupMerge.(?) 1 min 6 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestFullBackupSet.testFullBackupSetExist 6 min 16 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestFullBackupSet.(?) 1 min 6 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures.TestIncBackupMergeRestore 5 min 55 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures.(?) 1 min 6 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad.TestIncBackupDeleteTable 5 min 56 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad.(?) 1 min 6 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests.testFullRestoreSingleEmpty 6 min 5 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests.testFullRestoreMultipleEmpty 0.17 sec 1 precommit checks / yetus jdk8 Hadoop3 checks / org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests.(?) {noformat} https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/testReport/" Replication may lose data during regionserver restart when multiwal is in use,13379493,Resolved,Major,Fixed,20/May/21 11:47,24/May/21 01:33,2.1.4,"When multiwal is used, restarting the region server may result in the loss of replication data.This may be due to a non thread safe update of the queues in the ReplicationSource# enqueueLog. ." 'False' should be 'True' in auditlog of listLabels,13378802,Resolved,Major,Fixed,17/May/21 12:18,22/May/21 09:27,,"In method `listLabels` at line 932, it should be {code:java} logResult(true, ""listLabels"", ""Listing labels allowed"", null, null, regex);{code} instead of  {code:java} logResult(false, ""listLabels"", ""Listing labels allowed"", null, null, regex); {code} as listLabels is executed normally.  " TestRetainAssignmentOnRestart is flaky after HBASE-25032,13379219,Resolved,Major,Fixed,19/May/21 07:03,20/May/21 13:27,,"The problem is that, we will only assign regions to a region server after its first regionServerReport, so after restart, the region may be assigned before the region server is ready to take regions, and then cause the test to fail." Provide javadoc strings for all significant public symbols in o.a.h.h.client.*,13378389,Resolved,Major,Invalid,13/May/21 23:34,19/May/21 18:59,,"While playing with the jshell via HBASE-25841, I noticed that several of our classes and methods in this package don't have javadoc. We should do this anyway, but with jshell's tab-completion to show javadoc, this became particularly noticeable. Specifically, the very first class one must use, {{ConnectionFactory}}, is without a class-level javadoc. I assume there are plenty more." [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers,13378180,Resolved,Major,Fixed,12/May/21 19:56,19/May/21 18:03,hbase-operator-tools-1.1.0,"When iterating over existing region over cycles to perform merges, RegionsMerger may try to merge two regions that had been recently merged and would then have still have a ""merge"" qualifier to sign these still refers to parent regions files. That means the request is useless, the created SCPs would be aborted right away once it finds the so called merge qualifiers. RegionsMerger should avoid submitting these attempts, by checking for merge qualifiers and skipping those that still have merge qualifiers." Add documentation for LoadBalancer about synchronization,13377513,Resolved,Major,Fixed,09/May/21 13:08,17/May/21 02:38,,"In general, the balanceCluster call is not thread safe and we only allow one balanceCluster call at the same time, so we need to synchronize balanceCluster, onConfigurationChange, and setClusterMetrics(which will be called periodically, maybe we should rename it to updateClusterMetrics). Most setters do not need to be synchronized as they will only be called once before initialization. And anothe group of methods are XXXAssignment, these methods should be thread safe and should not be synchronized to improve the assignment performance." The regionFinder and rackManager fields in BaseLoadBalancer should be volatile,13378106,Resolved,Major,Fixed,12/May/21 13:55,17/May/21 01:58,,"As they may be changed after intialization by calling onConfigurationChange, we need to make sure that in XXXAssignment methods we won't get a broken regionFinder or rackManager." Revisit the synchronization of balancer implementation,13375771,Resolved,Major,Fixed,29/Apr/21 08:03,17/May/21 02:43,,"In StochasticLoadBalancer, some methods are synchronized, for example, setClusterMetrics, setConf, balanceTable, etc. What I can see is that, we have ConfigurationObserver support, so we need to make sure that the configuration updating does not effect the balance operation, so we need synchronization here. But do we support two balance operations at the same time? And what about other balancer implementations? I think we need to make the synchronization more clearer." Validate only direct ancestors instead of entire history for a particular backup,13377384,Resolved,Major,Fixed,08/May/21 06:50,12/May/21 23:44,,"While creating a manifest of particular backup, it looks for entire history of backups taken on that cluster and links are still valid. This need not hold true and unnecessary. Only ancestors of a particular incremental backup is necessary and sufficient." NPE while getting Balancer decisions,13378168,Resolved,Major,Fixed,12/May/21 19:22,14/May/21 09:56,,"With HBASE-25790 in place, we have new balancer queue: BalancerRejection in addition to BalancerDecision. However, now while retrieving records from ring buffer, only if exactly one of the ring buffers are enabled, we get NPE while retrieving the other one. Ideally it should return empty results. Result of get_balancer_decision when only rejection queue is enabled but not the balancer decision one.   {code:java} 2021-05-02T21:22:31,830 WARN  [RPCClient-NioEventLoopGroup-1-2] client.AsyncRpcRetryingCaller: Call to master failed, tries = 6, maxAttempts = 7, timeout = 1200000 ms, time elapsed = 2360 ms2021-05-02T21:22:31,830 WARN  [RPCClient-NioEventLoopGroup-1-2] client.AsyncRpcRetryingCaller: Call to master failed, tries = 6, maxAttempts = 7, timeout = 1200000 ms, time elapsed = 2360 msjava.io.IOException: java.io.IOException at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:463) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:135) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.master.MasterRpcServices.getBalancerDecisions(MasterRpcServices.java:3432) at org.apache.hadoop.hbase.master.MasterRpcServices.getLogEntries(MasterRpcServices.java:3395) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395) ... 3 more {code}  " "[hbase-operator-tools]Add tool for identifying ""unknown servers"" from master logs, then submit SCPs for each of those.",13377607,Resolved,Major,Fixed,10/May/21 10:50,14/May/21 09:11,hbase-operator-tools-1.1.0,"Mostly useful when reusing hbase data dir from a previously destroyed cluster to a new cluster definition (see HBASE-24286) with hbase versions prior to 2.2.7, 2.3.5 and 2.4.7, where there's no support for *scheduleSCPsForUnknownServers*. *HBCK2* has this *scheduleRecoveries* method, that submits SCPs for individual RS names passed as parameter, but it still requires operators to manually parse these unknown server names from master logs in order to build the command. This tool automates the parsing step, building the list of proper server names, then reusing *HBCK2.scheduleRecoveries* to trigger SCPs. " [branch-1] Update CHANGES.txt and tag 1.7.0RC0 to the most recent commit,13377881,Open,Major,,11/May/21 14:51,,, NamedQueue 'BalancerRejection' for recent history of balancer skipping,13373586,Resolved,Major,Fixed,19/Apr/21 10:34,08/May/21 19:13,,"[HBASE-24528|https://issues.apache.org/jira/browse/HBASE-24528] implements a NamedQueue that saved recent history of balancer decision details. Since we want to know exactly why the balancer is skipping to run, we need a new namedQueue called 'BalancerRejection' to hold the history of all details information why the balancer was rejected to run(skipping). LogEntry of 'BalancerRejection' should contain the information below: 1. Reason, to show why this time balancer was rejected Maybe look like:   {code:java} (cost1*multiplier1+cost2*multiplier2+...+costn*multipliern)/sumMultiplier=0.025 <= minCostNeedBalance(0.35) {code} 2. Detail cost factors and multipliers Maybe look like: {code:java} org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer$RegionCountSkewCostFunction cost:0.0 multiplier:500.0 org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer$MoveCostFunction cost:0.0 multiplier:7.0 org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer$RackLocalityCostFunction cost:1.0 multiplier:15.0 {code}  " Move all the intialization work of LoadBalancer implementation to initialize method,13376809,Resolved,Major,Fixed,05/May/21 14:58,13/May/21 06:19,,"To make sure that we have all the necessary properties set before initialization. And also, this could also help to make the synchronization more clear, as before initialization, we should not call balance or assignment methods yet, so we do not need to synchronize initialization method. We only need to synchronize when we want to change the configuration." The nightly build for master branch is failing when running UTs in hbase-procedure after HBASE-22120 merged,13374900,Resolved,Major,Cannot Reproduce,25/Apr/21 11:04,27/Apr/21 15:11,, Add metric for successful wal roll requests.,13377055,Resolved,Major,Fixed,06/May/21 15:14,08/May/21 07:43,1.6.0,We don't have any metric for number of successful wal roll requests. If we have that metric then we can add some alerts if that metric is stuck for some reason. TestRollingRestart is flaky,13376331,Resolved,Major,Fixed,03/May/21 07:24,07/May/21 12:32,,"the method *waitForRSShutdownToStartAndFinish* is incorrect, for the judgment method *sm.areDeadServersInProgress* may execute before scp is fired !screenshot-1.png!" Fix spotbugs warnings on branch-2,13376748,Resolved,Major,Fixed,05/May/21 08:12,07/May/21 12:22,,"{noformat} Dodgy code Warnings Code Warning UC Useless condition: it's known that major == true at this point Bug type UC_USELESS_CONDITION (click for details) In class org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor In method org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor.performCompaction(Compactor$FileDetails, InternalScanner, CellSink, long, boolean, ThroughputController, boolean, int) Value major == true Unreachable code at DefaultMobStoreCompactor.java:[line 210] At DefaultMobStoreCompactor.java:[line 210] {noformat} https://github.com/apache/hbase/blob/afa9836b87f9c909ac4fc18d904a5b5b0a3dfff6/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java#L211 {code} if (major) { try { delFileWriter = mobStore.createDelFileWriterInTmp(new Date(fd.latestPutTs), fd.maxKeyCount, major ? majorCompactionCompression : minorCompactionCompression, store.getRegionInfo().getStartKey()); } catch (IOException e) { LOG.warn( ""Failed to create del writer, "" + ""we will continue the compaction by writing delete markers directly in store files"", e); } } {code} The 'major ? majorCompactionCompression : minorCompactionCompression' is useless as we have a 'if (major)' test above." Opentelemetry span in ServerRpcConnection is incorrect,13377416,Resolved,Major,Not A Problem,08/May/21 10:19,08/May/21 13:55,,A span was created but never end in ServerRpcConnection Remove redundant AM in-memory state changes in CatalogJanitor,13376834,Resolved,Major,Fixed,05/May/21 16:50,06/May/21 16:13,,"In CatalogJanitor we schedule GCRegionProcedure to clean up both filesystem and in-memory state after a split, and GCMultipleMergedRegionsProcedure to do the same for merges. Both GCRegionProcedure and GCMultipleMergedRegionsProcedure clean up in-memory state, but CatalogJanitor also does this redundantly just after scheduling the procedures. The cleanup should be done in only one place. Presumably we are using the procedures to do it in a principled way. This is least a nit, but probably a source of future bugs. Remove the redundancy in CatalogJanitor and fix any follow on issues, like test failures. " Make LoadBalancer not extend Configurable interface,13376800,Resolved,Major,Fixed,05/May/21 12:58,06/May/21 15:40,,"On master, LoadBalancer has a setClusterInfoProvider method and on branch-2, LoadBalancer has a setMasterServices method. Both ClusterInfoProvider and MasterServices could give a Configuration out so I do not think we need to expose another setConf method. When refactoring StochasticLoadBalancer, the initialization order is also a pain as after setConf, we will load a lot of configuration but at that time, the ClusterInfoProvider is not present, and easy to cause NPE... And it could also help simplity locking." Deadlock during peer cleanup with NoNodeException,13369914,Resolved,Major,Fixed,07/Apr/21 01:35,06/May/21 00:23,1.7.0,"We have observed that replication source metrics for peer exists on some region servers even though peer has been removed.  This is because when we encounter the NoNodeException in ReplicationSource, it calls the `peerRemoved` workflow which should eventually terminate the source and removes the source from the source manager. Now, the problem is ReplicationSource thread terminates itself and thus the action to removePeer is not complete leaving the metrics there forever for source. This is the flow, replication source trying to clean wals [here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L801] and on NoNodeException it calls the [peerRemoved|https://github.com/apache/hbase/blob/b231dd620f107b488b88599e16dc846eb856972c/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java#L244] and terminate the source (itself), leaving the terminated source there in sourcemanager and not clearing it's [metrics|https://github.com/apache/hbase/blob/b231dd620f107b488b88599e16dc846eb856972c/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java#L645].  " "sorry for my mistake, could someone delete it.",13376868,Resolved,Major,Invalid,05/May/21 20:39,06/May/21 13:58,, Remove balanceTable method from LoadBalancer interface,13376277,Resolved,Major,Fixed,02/May/21 14:14,05/May/21 08:08,,"The balanceTable method is never called outside balancer implementation, so let's remove it from the interface to reduce the number of public methods, which could also reduce the work of synchronization." HBase bulk import fails with exitCode -100,13376996,Open,Major,,06/May/21 08:43,,2.2.5,"I want to import the data from an HBase 1.0 cluster to our new HBase 2.2.5 cluster. Our setup is as follows: * 6 data nodes with 250GB disc space each * total DFS capacity (as reported by Hadoop): 1.46 TB * one additional node running namenode, hmaster, resource manager The data I'm trying to import was created by HBase export on the 1.0 HBase cluster and take 14.9 GB in HDFS (due to `hdfs dfs -du -h`) The import uses bulk-output with `hasLargeResult=true:` {noformat} > hdfs dfs -du -h / 2.6 G /TMP_IMPORT ... > yarn jar $HBASE_HOME/lib/hbase-mapreduce-2.2.5.jar import \ -Dmapreduce.map.speculative=false \ -Dmapreduce.reduce.speculative=false \ -Dimport.bulk.output=/HFILES \ -Dimport.bulk.hasLargeResult=true \ my_table /TMP_IMPORT {noformat}   Approximately 3 hours later the import fails with this error messages: {noformat} Error: org.apache.hadoop.mapreduce.task.reduce.Shuffle$ShuffleError: error in shuffle in OnDiskMerger - Thread to merge on-disk map-outputs at org.apache.hadoop.mapreduce.task.reduce.Shuffle.run(Shuffle.java:134) at org.apache.hadoop.mapred.ReduceTask.run(ReduceTask.java:376) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:175) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1844) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:169) Caused by: org.apache.hadoop.util.DiskChecker$DiskErrorException: Could not find any valid local directory for opt/seritrack/tt/nosql/data/yarn/usercache/seritrack/appcache/application_1620201940366_0003/output/attempt_1620201940366_0003_r_000000_1/map_40.out at org.apache.hadoop.fs.LocalDirAllocator$AllocatorPerContext.getLocalPathForWrite(LocalDirAllocator.java:446) at org.apache.hadoop.fs.LocalDirAllocator.getLocalPathForWrite(LocalDirAllocator.java:151) at org.apache.hadoop.fs.LocalDirAllocator.getLocalPathForWrite(LocalDirAllocator.java:132) at org.apache.hadoop.mapreduce.task.reduce.MergeManagerImpl$OnDiskMerger.merge(MergeManagerImpl.java:549) at org.apache.hadoop.mapreduce.task.reduce.MergeThread.run(MergeThread.java:94) {noformat}   The Yarn web UI reports this: {noformat} AM Container for appattempt_1620201940366_0003_000001 exited with exitCode: -100 Failing this attempt.Diagnostics: Container released on a *lost* nodeFor more detailed output, check the application tracking page: http://master:8088/cluster/app/application_1620201940366_0003 Then click on links to logs of each attempt. {noformat} Hadoop name node reports: {noformat} Configured Capacity: 1.46 TB DFS Used: 34.26 GB (2.28%) Non DFS Used: 1.33 TB <<<<< !!! {noformat} We can see that Yarn occupies more than 200GB on each data node (inside .../data/yarn/usercache/xyz/appcache), so that it uses 1.33 TB in total which is almost the whole capacity of 1.5 TB. There are more than 100 files on each data node named like `attempt_1620201940366_0003_m_000035_1_spill_37.out` each of which is 77MB in size.   So my question is, how can I use bulk import if it needs the 100x amount of disk space as cache?          " Ignore duplicate split requests from regionserver reports,13376298,Resolved,Major,Fixed,02/May/21 20:52,04/May/21 17:05,2.4.3,"A SplitTableRegionProcedure may already be running when a regionserver report is received that includes a split request. The outcome is multiple SplitTableRegionProcedure procedures scheduled for the split request, only one of which can succeed. The others error out. Perhaps it is only WARN level noise in the logs that will cause operator concern, but is clearly not correct. Do not create a split procedure in response to a region state change report if the region is not open or already splitting." RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer,13375755,Resolved,Major,Fixed,29/Apr/21 06:53,30/Apr/21 15:15,, Use double instead of Double in StochasticLoadBalancer,13376389,Resolved,Major,Fixed,03/May/21 14:28,05/May/21 08:05,,"{code} // to save and report costs to JMX private Double curOverallCost = 0d; private Double[] tempFunctionCosts; private Double[] curFunctionCosts; {code} It seems we never do null check on these field or the elements, so I do not see any reason we should use Double here. Just use double instead." RegionStates#getAssignmentsForBalancer should only care about OPEN or OPENING regions,13376299,Resolved,Major,Fixed,02/May/21 20:56,04/May/21 01:24,,"RegionStates#getAssignmentsForBalancer is used by the HMaster to collect all regions of interest to the balancer for the next chore iteration. We check if a table is in disabled state to exclude regions that will not be of interest (because disabled regions are or will be offline) or are in a state where they shouldn't be mutated (like SPLITTING ). The current checks do not get to the point so are not comprehensive. We should filter out all regions that are not in OPEN or OPENING state when building the set of interesting regions for the balancer to consider. Only regions open (or opening) on the cluster are of interest to balancing calculations. Regions in all other states can be expected to not be of interest -- either offline (OFFLINE, or FAILED_*), not subject to balancer decisions now (SPLITTING, SPLITTING_NEW, MERGING, MERGING_NEW), or will be offline shortly (CLOSING) -- until at least the next chore iteration. " [branch-1] Precommit fails to build docker due to python-dateutil,13376471,Resolved,Major,Fixed,04/May/21 03:43,04/May/21 07:46,,"02:34:22 Downloading/unpacking python-dateutil 02:34:22 Cannot fetch index base URL https://pypi.python.org/simple/ 02:34:22 Could not find any downloads that satisfy the requirement python-dateutil 02:34:22 Cleaning up... 02:34:22 No distributions at all found for python-dateutil 02:34:22 Storing debug log for failure in /root/.pip/pip.log 02:34:22 The command '/bin/sh -c pip install python-dateutil' returned a non-zero code: 1 02:34:22 ERROR: Docker failed to build yetus/hbase:edccfe439a." Fix style issues for StochasticLoadBalancer,13375468,Resolved,Major,Fixed,28/Apr/21 01:29,29/Apr/21 03:27,,"There are some warnings when moving it to hbase-balancer module. Let's fix them before doing the actual moving as it could also by applied to branch-2." TestCacheOnWrite sometimes times out,13375698,Open,Major,,28/Apr/21 22:00,,3.0.0-alpha-1,"From a failed Jenkins run, I see {noformat} ------------------------------------------------------------------------------- Test set: org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite ------------------------------------------------------------------------------- Tests run: 107, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 780.027 s <<< FAILURE! - in org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite Time elapsed: 7.651 s <<< ERROR! org.junit.runners.model.TestTimedOutException: test timed out after 780 seconds at app//org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testCachingDataBlocksDuringCompactionInternals(TestCacheOnWrite.java:505) at app//org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite.testCachingDataBlocksDuringCompaction(TestCacheOnWrite.java:582) {noformat}" Move BaseLoadBalancer to hbase-balancer module,13370809,Resolved,Major,Fixed,10/Apr/21 13:46,27/Apr/21 15:26,, Find a way to know whether logQueue goes empty when ReplicationSource is running on ReplicationServer,13375583,Open,Major,,28/Apr/21 11:47,,,"HBASE-25110 we choose to use ZK to notify ReplicationServer that a new wal was generated, this is asynchronous. And then we got a problem, the shipper thread and the wal reader thread may go terminated as logQueue goes empty before receiving the notification of new wal. So we now need find a way to know whether logQueue is really empty after the last wal in logQueue is consumed." "Other protobuf services, other than ClientService, cannot be invoked with RpcClient",13373568,Resolved,Major,Not A Problem,19/Apr/21 09:48,27/Apr/21 08:22,2.4.2,"I'd like to invoke a coprocessor with RpcClient, and I find the service_name in function RpcSerde::Header() has been hard coded, and when I change the service_name to another one, the call failed. Before I change the service_name, I get the following error message: {noformat} # ./adamas-echo-test /usr/src/hbase/hbase-native-client/src/test/adamas-echo-test.cc:83: Failure Failed Failed because: N5hbase15RemoteExceptionE: /172.17.0.4:16000 is unable to read call parameter from client 172.17.0.4; java.lang.UnsupportedOperationException: adamasEcho, Shouldn't get here, exception is not expected for RPC adamasEcho.{noformat} As I look into the hbase server, I find the service name is ClientService, which is not what I expected. then I hard code the ""ClientService"" to my own service, i.e. the service name in my own .proto file, by changing the INTERFACE macro. but when I connect to the hbase server, it reset the connection immediately, showing: {noformat} # ./adamas-echo-test /usr/src/hbase/hbase-native-client/src/test/adamas-echo-test.cc:83: Failure Failed Failed because: N5hbase11IOExceptionE: Connection closed to server:172.17.0.4:16000, Shouldn't get here, exception is not expected for RPC adamasEcho.{noformat} and I look into the wingle library, I find the errno is 104, which means 'Connection reset by peer'. So what is the problem? Thank you!" Miscellaneous style improvements for load balancer related classes,13374308,Resolved,Major,Fixed,22/Apr/21 07:19,26/Apr/21 05:10,,Landing some improvements first as they could also be landed on branch-2. Backport the region location finder initialization fix in HBASE-25802,13374526,Resolved,Major,Fixed,23/Apr/21 00:51,26/Apr/21 05:09,,"As mentioned in HBASE-25802, we create region location finder in constructor before setConf called, which is incorrect. We need to get this fix in branch-2.4 and branch-2.3." Remove jenkins files in the code base for branch-2.2,13374964,Resolved,Major,Fixed,26/Apr/21 03:35,26/Apr/21 05:29,,To save resources. Http InfoServers should honor gzip encoding when requested,13372143,Resolved,Major,Fixed,13/Apr/21 23:15,19/Apr/21 22:24,2.3.0,"Working on another project, I noticed that our InfoServer does not honor the {{Accept-Encoding}} HTTP header when present. It appears to be a relatively trivial matter to add the GzipHandler provided by Jetty. I'm not sure if there are other encodings we should support, but this is the only one I found available in Jetty itself (the other one by browser sent was ""deflate"")." [branch-1] Backport improvements to FSHLog from branch-2,13374719,Resolved,Major,Fixed,23/Apr/21 19:00,24/Apr/21 02:30,1.6.0,"From c96b642f15d (HBASE-15265 Implement an asynchronous FSHLog) - Better formatting; use { } instead of dangling ifs, elses, etc. in RingBufferEventHandler. From b1269ec57ff (HBASE-19811 Fix findbugs and error-prone warnings in hbase-server (branch-2)) - Change syncFuturesCount in RingBufferEventHandler from 'volatile int' to AtomicInteger. 'volatile' is insufficient for multithreaded access. From afc1746757f (HBASE-24034 [Flakey Tests] A couple of fixes and cleanups) - Make a local copy of takeSyncFuture after we get it in SyncRunner#run. This looks like a workaround for a JIT/compiler bug in some Java versions. (SCARY)" [branch-1] TestAtomicOperation.testMultiRowMutationMultiThreads deadlock,13374741,Resolved,Major,Fixed,23/Apr/21 22:08,24/Apr/21 02:30,,"TestAtomicOperation.testMultiRowMutationMultiThreads deadlocks. There is an easy fix for the test that synchronizes on the CHM instead of the object. We already have a Findbugs exceptions for synchronization on the CHM and get-then-set on it is what we synchronizing for anyway. This is only relevant for branch-1 because we have to synchronize get-then-set due to Java 7 compatibility. For branch-2 and master we use CHM#computeIfPresent." [branch-1] Upgrade com.lmax.disruptor to 3.4.2,13374523,Resolved,Major,Fixed,23/Apr/21 00:33,23/Apr/21 22:42,,"branch-1 is on 3.3.0. Partial changelog from 3.3.0 to 3.4.2: * Fix for race condition on restart of BatchEventProcessor with 3 or more threads (in 3.4.2) * Fix race between run() and halt() on BatchEventProcessor (in 3.4.1) * Ensure that if halt is call the BatchEventProcessor will always exit cleanly (in 3.4.1) * Remove unsafe based padding from RingBuffer. (in 3.4.0) * Fix bug were the cursor could be accidentally changed (in 3.3.7) * Add StoreLoad barrier before reading the gating sequences (in 3.3.6) * Resignal any waiting threads when trying to publish to a full ring buffer (in 3.3.5) * NPE using time wait blocking strategy (in 3.3.5) branch-2 and master are on 3.4.2. 3.4.3 change is ""Add Automatic-Module-Name to MANIFEST.MF"" which is harmless. Compatibility for branch-1 tested with openjdk version ""1.7.0_272 (OpenJDK Runtime Environment (Zulu 7.40.0.15-CA-macosx) (build 1.7.0_272-b10) OpenJDK 64-Bit Server VM (Zulu 7.40.0.15-CA-macosx) (build 24.272-b10, mixed mode))"" " Move BaseLoadBalancer.Cluster to a separated file,13373862,Resolved,Major,Fixed,20/Apr/21 14:01,22/Apr/21 16:08,,"It is a static inner class and has more than 800 lines. Let's move it out." RegionMover tool reassigning the already opened regions,13374108,Open,Major,,21/Apr/21 10:49,,,"{color:#000000}{color:#000000}Steps: 1)Install cluster with 3 RS (RS1,RS2,RS3) 2)Create table with 1000 regions  3)Perform RegionMover to unload from RS1 4)While unloading the regions stop RS1  Observation: {color}{color} {color:#000000}Regions already asigned to RS2 or RS3(by SCP) getting reassigned by the tool{color} {color:#000000}2021-03-17 15:08:15,484 INFO [pool-3-thread-1] util.RegionMover: Moved Region table1,user25612,1615963232549.b19f9a6dac88a1fa21191c9fd0d515aa. cost:2.485 2021-03-17 15:08:16,663 INFO [pool-3-thread-1] util.RegionMover: Moving region:b19f9a6dac88a1fa21191c9fd0d515aa from RS1,16040,1615810740162 to RS2,16040,1615810791637{color}" Move NamedQueuePayload to hbase-common,13374299,Resolved,Major,Won't Fix,22/Apr/21 06:48,22/Apr/21 07:13,,"We use this class to record the balancer decision in LoadBalancer, so if we want to move LoadBalancer to hbae-balancer, we also need to move NamedQueueRecord related classes out of hbase-server. Since we use a system table to record, hbase-client will be a suitable place. ====== Update ====== A we depend on disruptor for NamedQueueRecord, I do not think it is a good idea to introduce this dependency to our client library. So let's just move the minimum classes to hbase-client or hbase-common instead of the whole namedqueues implementation." Duplicate uploads for hbase-shaded-protobuf sources jar causing nexus deploy failure,13370831,Open,Major,,10/Apr/21 15:54,,,"There are two configurations in [pom.xml|https://github.com/apache/hbase-thirdparty/blob/master/hbase-shaded-protobuf/pom.xml] of hbase-shaded-protobuf that create the sources jar. Here is [one|https://github.com/apache/hbase-thirdparty/blob/ccc49e6a78a00e61fa49f1292ace2f8bde28c54e/hbase-shaded-protobuf/pom.xml#L150] in the maven-shade-plugin and [other|https://github.com/apache/hbase-thirdparty/blob/ccc49e6a78a00e61fa49f1292ace2f8bde28c54e/hbase-shaded-protobuf/pom.xml#L133] in maven-source-plugin(introduced in HBASE-18313) After removing the one from maven-shade-plugin, viz. true, we are able to successfully deploy as it generates source jar only once.   Error stacktraces: Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project hbase-shaded-protobuf: Failed to deploy artifacts: Could not transfer artifact org.apache.hbase.thirdparty:hbase-shaded-protobuf:jar:sources:3.5.1 from/to nexus ([https://nexus.xyz.com/nexus/content/repositories/hbase/):|https://nexus.soma.salesforce.com/nexus/content/repositories/salesforce-hbase/):] Transfer failed for [https://nexus.xyz.com/nexus/content/repositories/hbase/org/apache/hbase/thirdparty/hbase-shaded-protobuf/3.5.1/hbase-shaded-protobuf-3.5.1-sources.jar|https://nexus.soma.salesforce.com/nexus/content/repositories/salesforce-hbase/org/apache/hbase/thirdparty/hbase-shaded-protobuf/3.5.1-sfdc-1.0.3/hbase-shaded-protobuf-3.5.1-sfdc-1.0.3-sources.jar] 400 Bad Request -> [Help 1]   Build Commands:  mvn org.codehaus.mojo:versions-maven-plugin:2.7:set -DgenerateBackupPoms=false -DoldVersion='\''*'\'' -DnewVersion='\''3.5.1'\''' mvn -X -e -nsu clean deploy -DadditionalJOption=-Xdoclint:none -DskipTests    " Add 2.2.7 to download page,13372793,Resolved,Major,Fixed,16/Apr/21 05:14,19/Apr/21 14:18,, Pushed signed release tag,13373386,Resolved,Major,Done,18/Apr/21 13:27,19/Apr/21 12:27,,Push signed rel/2.2.7 tag. """Release"" staged nexus repository",13373384,Resolved,Major,Done,18/Apr/21 13:14,19/Apr/21 12:26,, Release 2.2.7 in Jira,13373385,Resolved,Major,Done,18/Apr/21 13:24,18/Apr/21 13:24,, "Update reporter tool with new release, 2.2.7",13373383,Resolved,Major,Fixed,18/Apr/21 13:09,18/Apr/21 13:09,,Add 2.2.7 to https://reporter.apache.org/addrelease.html?hbase "org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618369396289",13372189,Resolved,Major,Invalid,14/Apr/21 05:56,17/Apr/21 05:11,2.0.0,"when start hbase: Wed Apr 14 13:32:48 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318Wed Apr 14 13:32:48 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:48 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:48 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:49 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:50 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:52 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:56 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:06 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:16 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:26 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:36 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:56 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:34:16 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:34:36 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:34:56 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:35:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:35:37 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:35:57 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:36:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:36:37 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:36:57 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:37:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:37:37 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:37:57 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:38:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:38:38 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:38:58 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:39:18 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:39:38 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:39:58 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:145) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:386) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:360) at org.apache.hadoop.hbase.master.TableNamespaceManager.get(TableNamespaceManager.java:142) at org.apache.hadoop.hbase.master.TableNamespaceManager.isTableAvailableAndInitialized(TableNamespaceManager.java:279) at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:104) at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:63) at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:226) at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1106) ... 4 moreCaused by: org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at sun.reflect.GeneratedConstructorAccessor9.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:100) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:90) at org.apache.hadoop.hbase.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:279) at org.apache.hadoop.hbase.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:266) at org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:129) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107) ... 12 moreCaused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.NotServingRegionException): org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:387) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:95) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:410) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:406) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:103) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:118) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.readResponse(NettyRpcDuplexHandler.java:162) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelRead(NettyRpcDuplexHandler.java:192) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:801) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:404) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:304) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138) ... 1 more2021-04-14 13:39:58,461 ERROR org.apache.hadoop.hbase.master.HMaster: Master server abort: loaded coprocessors are: []2021-04-14 13:39:58,461 ERROR org.apache.hadoop.hbase.master.HMaster: ***** ABORTING master bd197,16000,1618378303389: Unhandled exception. Starting shutdown. *****java.lang.IllegalStateException: Expected the service ClusterSchemaServiceImpl [FAILED] to be RUNNING, but the service has FAILED at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:345) at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.awaitRunning(AbstractService.java:291) at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1108) at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:954) at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2086) at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:553) at java.lang.Thread.run(Thread.java:748)Caused by: org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=31, exceptions:Wed Apr 14 13:32:47 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:48 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:48 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:48 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:49 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:50 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:52 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:32:56 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:06 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:16 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:26 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:36 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:33:56 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:34:16 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:34:36 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:34:56 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:35:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:35:37 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:35:57 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:36:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:36:37 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:36:57 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:37:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:37:37 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:37:57 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:38:17 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:38:38 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:38:58 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:39:18 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:39:38 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) Wed Apr 14 13:39:58 CST 2021, RpcRetryingCaller\{globalStartTime=1618378367830, pause=100, maxAttempts=31}, org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:145) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:386) at org.apache.hadoop.hbase.client.HTable.get(HTable.java:360) at org.apache.hadoop.hbase.master.TableNamespaceManager.get(TableNamespaceManager.java:142) at org.apache.hadoop.hbase.master.TableNamespaceManager.isTableAvailableAndInitialized(TableNamespaceManager.java:279) at org.apache.hadoop.hbase.master.TableNamespaceManager.start(TableNamespaceManager.java:104) at org.apache.hadoop.hbase.master.ClusterSchemaServiceImpl.doStart(ClusterSchemaServiceImpl.java:63) at org.apache.hbase.thirdparty.com.google.common.util.concurrent.AbstractService.startAsync(AbstractService.java:226) at org.apache.hadoop.hbase.master.HMaster.initClusterSchemaService(HMaster.java:1106) ... 4 moreCaused by: org.apache.hadoop.hbase.NotServingRegionException: org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at sun.reflect.GeneratedConstructorAccessor9.newInstance(Unknown Source) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:100) at org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:90) at org.apache.hadoop.hbase.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:279) at org.apache.hadoop.hbase.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:266) at org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:129) at org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107) ... 12 moreCaused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(org.apache.hadoop.hbase.NotServingRegionException): org.apache.hadoop.hbase.NotServingRegionException: hbase:namespace,,1544623399046.0d98a5b9654f3a3783388bc294c25067. is not online on bd133,16020,1618378306318 at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegionByEncodedName(HRegionServer.java:3245) at org.apache.hadoop.hbase.regionserver.HRegionServer.getRegion(HRegionServer.java:3222) at org.apache.hadoop.hbase.regionserver.RSRpcServices.getRegion(RSRpcServices.java:1414) at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2429) at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:41998) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:130) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.onCallFinished(AbstractRpcClient.java:387) at org.apache.hadoop.hbase.ipc.AbstractRpcClient.access$100(AbstractRpcClient.java:95) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:410) at org.apache.hadoop.hbase.ipc.AbstractRpcClient$3.run(AbstractRpcClient.java:406) at org.apache.hadoop.hbase.ipc.Call.callComplete(Call.java:103) at org.apache.hadoop.hbase.ipc.Call.setException(Call.java:118) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.readResponse(NettyRpcDuplexHandler.java:162) at org.apache.hadoop.hbase.ipc.NettyRpcDuplexHandler.channelRead(NettyRpcDuplexHandler.java:192) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) at org.apache.hbase.thirdparty.io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1359) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) at org.apache.hbase.thirdparty.io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:935) at org.apache.hbase.thirdparty.io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:801) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:404) at org.apache.hbase.thirdparty.io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:304) at org.apache.hbase.thirdparty.io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858) at org.apache.hbase.thirdparty.io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:138) ... 1 more2021-04-14 13:39:58,463 INFO org.apache.hadoop.hbase.regionserver.HRegionServer: ***** STOPPING region server 'bd197,16000,1618378303389' *****2021-04-14 13:39:58,463 INFO org.apache.hadoop.hbase.regionserver.HRegionServer: STOPPED: Stopped by Thread-162021-04-14 13:39:58,465 INFO org.apache.hadoop.hbase.regionserver.HRegionServer: Stopping infoServer2021-04-14 13:39:58,479 INFO org.eclipse.jetty.server.handler.ContextHandler: Stopped o.e.j.w.WebAppContext@4cb2918c\{/,null,UNAVAILABLE}{file:/home/opt/cloudera/parcels/CDH-6.0.1-1.cdh6.0.1.p0.590678/lib/hbase/hbase-webapps/master}2021-04-14 13:39:58,483 INFO org.eclipse.jetty.server.AbstractConnector: Stopped ServerConnector@5d497a91\{HTTP/1.1,[http/1.1]}{0.0.0.0:16010}2021-04-14 13:39:58,484 INFO org.eclipse.jetty.server.handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@5e519ad3\{/static,file:///home/opt/cloudera/parcels/CDH-6.0.1-1.cdh6.0.1.p0.590678/lib/hbase/hbase-webapps/static/,UNAVAILABLE}2021-04-14 13:39:58,484 INFO org.eclipse.jetty.server.handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@a451491\{/logs,file:///var/log/hbase/,UNAVAILABLE}2021-04-14 13:39:58,487 INFO org.apache.hadoop.hbase.regionserver.HRegionServer: stopping server bd197,16000,16183783033892021-04-14 13:39:58,489 INFO org.apache.hadoop.hbase.zookeeper.ReadOnlyZKClient: Close zookeeper connection 0x15d201af to bd201:2181,bd200:2181,bd197:2181,bd198:2181,bd199:21812021-04-14 13:39:58,492 INFO org.apache.hadoop.hbase.regionserver.HRegionServer: stopping server bd197,16000,1618378303389; all regions closed.2021-04-14 13:39:58,492 INFO org.apache.hadoop.hbase.ChoreService: Chore service for: master/bd197:16000 had [[ScheduledChore: Name: bd197,16000,1618378303389-BalancerChore Period: 300000 Unit: MILLISECONDS], [ScheduledChore: Name: LogsCleaner Period: 600000 Unit: MILLISECONDS], [ScheduledChore: Name: ReplicationZKNodeCleanerChore Period: 600000 Unit: MILLISECONDS], [ScheduledChore: Name: CatalogJanitor-bd197:16000 Period: 300000 Unit: MILLISECONDS], [ScheduledChore: Name: bd197,16000,1618378303389-RegionNormalizerChore Period: 300000 Unit: MILLISECONDS], [ScheduledChore: Name: bd197,16000,1618378303389-ClusterStatusChore Period: 60000 Unit: MILLISECONDS], [ScheduledChore: Name: HFileCleaner Period: 600000 Unit: MILLISECONDS]] on shutdown2021-04-14 13:39:58,494 WARN org.apache.hadoop.hbase.master.ActiveMasterManager: Failed get of master address: java.io.IOException: Can't get master address from ZooKeeper; znode data == null2021-04-14 13:39:58,494 INFO org.apache.hadoop.hbase.master.assignment.AssignmentManager: Stopping assignment manager2021-04-14 13:39:58,497 INFO org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher: Stopping procedure remote dispatcher2021-04-14 13:39:58,498 INFO org.apache.hadoop.hbase.procedure2.ProcedureExecutor: Stopping2021-04-14 13:39:58,503 INFO org.apache.hadoop.hbase.procedure2.store.wal.WALProcedureStore: Stopping the WAL Procedure Store, isAbort=false2021-04-14 13:39:58,676 INFO org.apache.hadoop.hbase.ChoreService: Chore service for: master/bd197:16000.splitLogManager. had [[ScheduledChore: Name: SplitLogManager Timeout Monitor Period: 1000 Unit: MILLISECONDS]] on shutdown2021-04-14 13:39:58,677 INFO org.apache.hadoop.hbase.procedure.flush.MasterFlushTableProcedureManager: stop: server shutting down.2021-04-14 13:39:58,677 INFO org.apache.hadoop.hbase.ipc.NettyRpcServer: Stopping server on /0.0.0.0:160002021-04-14 13:39:58,712 INFO org.apache.zookeeper.ZooKeeper: Session: 0x478cddb73240806 closed2021-04-14 13:39:58,712 INFO org.apache.zookeeper.ClientCnxn: EventThread shut down2021-04-14 13:39:58,712 INFO org.apache.hadoop.hbase.regionserver.HRegionServer: Exiting; stopping=bd197,16000,1618378303389; zookeeper connection closed." Use a special balancer to deal with maintenance mode,13372520,Resolved,Major,Fixed,15/Apr/21 03:00,16/Apr/21 06:06,,"So we can separate the region on master logic and maintenance mode logic, which makes it easier for us to remove the region on master logic on master branch." Set version as 2.2.7 in branch-2.2,13371113,Resolved,Major,Fixed,11/Apr/21 10:13,12/Apr/21 01:59,, Generate CHANGES.md and RELEASENOTES.md for 2.2.7,13371109,Resolved,Major,Fixed,11/Apr/21 09:34,12/Apr/21 01:59,, CandidateGenerator.getRandomIterationOrder is too slow on large cluster,13371127,Resolved,Major,Fixed,11/Apr/21 13:15,14/Apr/21 00:40,,"Similar to HBASE-25759, it is just used to test whether we should skip calculation, but in production masterServices will never be null. ========== Update, change the title of this issue for removing CandidateGenerator.getRandomIterationOrder as it is too slow which causes the CandidateGenerator.getRandomIterationOrder to fail when we remove the masterServices field in LocalityBasedCandidateGenerator. As this is the most important change in this issue so change the title of this issue." Recommend Hadoop 3.x,13372153,Open,Major,,14/Apr/21 01:41,,,"We have this section in the hbase book: {quote} Hadoop 2.x is recommended. Hadoop 2.x is faster and includes features, such as short-circuit reads (see Leveraging local data), which will help improve your HBase random read profile. Hadoop 2.x also includes important bug fixes that will improve your overall HBase experience. HBase does not support running with earlier versions of Hadoop. See the table below for requirements specific to different HBase versions. Hadoop 3.x is still in early access releases and has not yet been sufficiently tested by the HBase community for production use cases. {quote} The Hadoop 2.x development is winding down. 2.10.x will be the last dev branch. On the contrary, we've got years of production users on Hadoop 3.x already so I think it's time to change our stance." [Flake Test][branch-1] TestAdmin2,13370326,Resolved,Major,Fixed,08/Apr/21 09:14,14/Apr/21 02:18,,Attempt to improve the stability. The master services field in LocalityBasedCostFunction is never used,13370820,Resolved,Major,Fixed,10/Apr/21 14:23,12/Apr/21 16:00,,"We just use it to test whether we should do the calculation. But in fact, it should never be null when we arrive here. Maybe it is because in test we may skip setting the master services but I think we should just skip balancing in the balancer, not in the cost function." Change default of `hbase.normalizer.merge.min_region_size.mb` to `0`,13370201,Resolved,Major,Fixed,07/Apr/21 20:11,11/Apr/21 23:22,2.5.0,"The current default value is {{1}}, which means normalizer will leave regions of 0-1mb size hanging around. We should set this down to {{0}} so that these small regions go away by default. As I recall, the value was set as it is in order to prevent the normalizer from merging up regions immediately after an operator creates a pre-split table. IMHO, this use case is more than covered by these other configurations with their default values: * {{hbase.normalizer.min.region.count=3}} * {{hbase.normalizer.merge.min_region_age.days=3}} For details, see * http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/master/normalizer/package-summary.html#package.description * http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.html" Add writable TimeToPurgeDeletes to ScanOptions,13370505,Resolved,Major,Fixed,09/Apr/21 00:07,09/Apr/21 20:15,,"In HBase 1.x and before, it was possible to override all settings on the ScanInfo when overriding the flush and compaction scanner open coprocoessors. HBase 2.x changed the coprocessor model to instead allow changes to a limited set of options on the ScanOptions object. In HBASE-19895 and HBASE-24321, we added support for KeepDeletedCells and MinVersions to be overriden by ScanOptions, as needed by Phoenix. A 1.x coprocessor used at my day job overrides TimeToPurgeDeletes, and to convert it to HBase 2.x that property would need to be overridable from ScanOptions as well. This should be a straightforward extension of the previous work. " [Flake Test][branch-1] TestSnapshotCloneIndependence's teardown() is always timeout,13370542,Resolved,Major,Fixed,09/Apr/21 04:17,10/Apr/21 04:34,,"The tearDown method after each test is always timeout. So the fix is to 1. make the tearDown method without After annotation and make it private 2. move it under each test 3. Increase timeout to 30000 for each test, as for it is MediumTests." "Upgrade RpcControllerFactory and HBaseRpcController from Private to LimitedPrivate(COPROC,PHOENIX)",13370482,Resolved,Major,Fixed,08/Apr/21 20:39,09/Apr/21 00:52,2.4.3,Phoenix has had an unrecognized dependency on RpcControllerFactory and HBaseRpcController for about four years. These interfaces are used to override setPriority for appropriate dispatch of requests for Phoenix system or index tables to separate pools. This is a reasonable use of these interfaces but the audience annotations were never updated to reflect this usage. Also seems reasonable to do so as there has been no issue here for four years. (Phoenix commit was made in 2017.) Make it official. Retry REQUESTTIMEOUT KeeperExceptions from ZK,13370167,Resolved,Major,Fixed,07/Apr/21 17:55,08/Apr/21 07:01,2.3.6,"Starting ZOOKEEPER-2251, client requests exceeding a timeout can throw a KeeperException with REQUESTTIMEOUT opcode set. RecoverableZookeeper doesn't transparently retry in such case. This was causing RS aborts when there is a flaky ZK quorum member serving slow requests (especially in cases like rolling upgrades and such)." hbase failed to write to multiple index table issue,13370521,Resolved,Major,Invalid,09/Apr/21 02:37,09/Apr/21 08:39,1.2.6,"    When we load data into phoenix(psql.py load csv file) table A, and at the same time we drop and create table B,in hbase log, we can    find one ERROR,that says index issue:  ERROR 1121(XCL21): Write to the index failed.    disableIndexOnFailure=true,Failed to write multiple index tables Any ideas for this issue?" [hbase-thirdparty] Update jetty to >= 9.4.39 due to CVE-2021-28165,13370233,Resolved,Major,Fixed,08/Apr/21 01:13,08/Apr/21 17:24,,Update jetty to 9.4.39 due to CVE-2021-28165. Backport HBASE-25629 to branch-1,13369896,Resolved,Major,Fixed,06/Apr/21 22:39,07/Apr/21 08:08,1.7.0,"HBASE-25629 recently fixed an issue where TestCurrentHourProvider consistently failed on certain OSes due to quirks in time zone implementations. This test is also failing in branch-1, so in order to expedite a potential 1.7.0 release we should backport to branch-1 as well. " TestConnectionImplementation BadHostname tests fail in branch-1,13369369,Resolved,Major,Fixed,02/Apr/21 22:25,06/Apr/21 04:34,1.7.0,"TestConnectionImplementation.testGetAdminBadHostname and testGetClientBadHostname are consistently failing in branch-1. This is because they're assuming that the validity of the host is checked immediately upon getting the protobuf service object, when instead the service code purposefully waits until the first service call to check. I'll revise the tests to make service calls and verify that they return the correct exceptions (ServiceException wrapping an UnknownHostException)." update download area for 2.3.5 as new stable build,13369152,Resolved,Major,Fixed,01/Apr/21 16:14,02/Apr/21 22:13,,"* update the stable symlink to point to 2.3.5 * Remove the 2.3.4 release from downloads.a.o" MoveCostFunction is not included in the list of cost functions for StochasticLoadBalancer,13369181,Resolved,Major,Fixed,01/Apr/21 17:54,02/Apr/21 17:52,1.7.0,"After OffPeakHours fix for MoveCostFunction (HBASE-24709), MoveCostFunction is no longer included in costFunctions list. {{addCostFunction}} expects multiplier to be non-zero, but multiplier is now only set in {{cost}} function. As a result, {{hbase.master.balancer.stochastic.maxMovePercent}} is not respected, and there is no cost function to oppose a move. Any move that decreases total cost at all will be accepted, causing more churn and disruption from balancer executions. We noticed this when investigating a case where the balancer would run after a regionserver was restarted without use of region_mover script. The regionserver comes online with 0 regions, leading to a shortcut in {{needsBalance}} for {{idleRegionServerExist}}. The balancer runs to move regions to that newly restarted regionserver. However, it moves a large number of regions in the cluster, hyper-optimizing the other cost variables. There were ~4300 regions in the cluster at the time, so moving 25% of the regions should have had a final cost of at least 7 (default moveCostFunction weight.) MoveCostFunction is also not listed in the functions contributing to the initial cost. {{2021-03-30 15:47:43,396 INFO [49187_ChoreService_3] balancer.StochasticLoadBalancer - start StochasticLoadBalancer.balancer, initCost=12.91377229840024, functionCost=RegionCountSkewCostFunction : (500.0, 0.014878672009326464); TableSkewCostFunction : (35.0, 0.013600280177445717); RegionReplicaHostCostFunction : (100000.0, 0.0); RegionReplicaRackCostFunction : (10000.0, 0.0); ReadRequestCostFunction : (5.0, 0.8296332203204705); WriteRequestCostFunction : (5.0, 0.06818455421617946); MemstoreSizeCostFunction : (5.0, 0.08132131691669181); StoreFileCostFunction : (5.0, 0.02054620605193966); computedMaxSteps: 1000000}} {{2021-03-30 15:48:13,385 DEBUG [49187_ChoreService_3] balancer.StochasticLoadBalancer - Finished computing new load balance plan. Computation took 30004ms to try 6571 different iterations. Found a solution that moves 1095 regions; Going from a computed cost of 12.91377229840024 to a new cost of 4.804625730746651}}" [hbase-thirdparty] Upgrade Netty library to >= 4.1.60 due to security vulnerability CVE-2021-21295,13369340,Resolved,Major,Fixed,02/Apr/21 18:09,02/Apr/21 18:33,,We don't have a direct exposure to this vulnerability but vulnerability scanners aware of the CVE database may flag it. "Update reporter tool with new release, 2.3.5",13368980,Resolved,Major,Fixed,01/Apr/21 01:08,01/Apr/21 07:06,,Reporter tool: [https://reporter.apache.org/addrelease.html?hbase] Fix typo in AsyncConnectionImpl,13384122,Resolved,Minor,Fixed,16/Jun/21 09:45,16/Jun/21 11:01,, Add 2.4.3 to download page,13381502,Resolved,Minor,Fixed,01/Jun/21 16:40,01/Jun/21 16:41,, remove files from filesCompacting when clear compaction queues,13377921,Open,Minor,,11/May/21 16:54,,,"When clear compaction queues, we just clear the workQueue of ThreadPoolExecutor, but files in compaction request are still in filesCompacting list. maybe we should clear it also. For system compaction, selectNow will be false, which means files will be added to the compacting list when the compaction task is actually executed. So it is safe to just clear the workQueue of compaction thread pool executor. However, for user-triggered compaction, selectNow will be true, which means files are already added to the compacting list when we put the compaction request to the queue. When CompactionPolicy selects candidate files for minor compaction, files in compacting list will be excluded. If we just clear the workQueue of compaction thread pool executor, files of these compaction requests are still in compacting list. These files will not be selected by CompactionPolicy and compacted any more unless we force a major compaction. So I think maybe we should remove those files from compacting list when we clear the compaction queue." Disabled sanity checks ignored on snapshot restore,13380498,Resolved,Minor,Fixed,26/May/21 08:55,26/Aug/22 14:20,2.2.6,"Disabling sanity checks on a table is ignored when restoring snapshots. If this is expected behavior at least the error message is misleading. h3. Steps *to Reproduce* # Create a new table {{create 't', 'cf'}} # Add a coprocessor to the newly created table {{alter 't', METHOD => 'table_att', 'coprocessor' => 'coprocessor.jar|com.example.MyCoprocessor|0'}} # Create a snapshot {{snapshot 't', 'snapshot-t'}} # Disable the table to prevent region servers from crashing in the next step {{disable 't'}} # Delete the coprocessor JAR and restart HBase. # Attempt to restore the snapshot leads to failing sanity check as expected {{restore_snapshot 'snapshot-t'}} {{ERROR: org.apache.hadoop.hbase.DoNotRetryIOException: coprocessor.jar Set hbase.table.sanity.checks to false at conf or table descriptor if you want to bypass sanity checks [...]}} # Disable sanity checks (as described in the error message) and retry {{alter 't', CONFIGURATION => \{'hbase.table.sanity.checks' => 'false'}}} {{restore_snapshot 'snapshot-t'}} h3. Expected Behavior The snapshot is restored. h3. Actual Behavior The same error message as in step 6. is shown." StripeCompactionPolicy should support compacting cold regions,13370656,Resolved,Minor,Fixed,09/Apr/21 13:18,23/Apr/21 07:55,1.4.13,"Cold regions cannot perform compactions by flushing memstores, while CompactionChecker can period check need compaction regions. But some cold regions using stripe store engine may not be checked to perform compaction by`needCompaction()` or trigger automatic major compactions, because StripeCompactionPolicy#shouldPerformMajorCompaction() always returns false.  StripeCompactionPolicy never performs automatic major compactions now. But cold regions' outdated data need to be cleaned.      " Improved logging when interrupting active RPC handlers holding the region close lock (HBASE-25212 hbase.regionserver.close.wait.abort),13370467,Open,Minor,,08/Apr/21 19:04,,1.7.0,"HBASE-25212 adds an optional improvement to Close Region, for interrupting active RPC handlers holding the region close lock. If, after the timeout is reached, the close lock can still not be acquired, the regionserver may abort. It would be helpful to add logging for which threads or components are holding the region close lock at this time. Depending on the size of regionLockHolders, or use of any stack traces, log output may need to be truncated. The interrupt code is in HRegion#interruptRegionOperations." ‘mobdir’ overlaps in HFileLink.mobPath,13380253,Open,Minor,,25/May/21 07:18,,1.4.13,"‘mobdir’ overlaps in HFileLink.mobPath, like '/root/mobdir/mobdir/data/table/...'" Fix various formatting issues in the refrence guide book,13377880,In Progress,Minor,,11/May/21 14:51,,3.0.0-alpha-1,"This jira is used to collect and fix various formatting issues in the refrence guide book. For example,in the first paragraph of the chapter 8.1，the bulleted list is not displayed correctly，as show below： !image-2021-05-11-22-55-13-810.png!" "When turn on access control, the cell level TTL of Increment and Append operations is invalid.",13383708,Resolved,Minor,Fixed,14/Jun/21 11:32,26/Jul/21 18:34,,"AccessController postIncrementBeforeWAL() and postAppendBeforeWAL() methods will rewrite the new cell's tags by the old cell's. This will makes the other kinds of tag in new cell invisible (such as TTL tag) after this. As in Increment and Append operations, the new cell has already catch forward all tags of the old cell and TTL tag from mutation operation, here in AccessController we do not need to rewrite the tags once again. Also, the TTL tag of newCell will be invisible in the new created cell. Actually, in Increment and Append operations, the newCell has already copied all tags of the oldCell. So the oldCell is useless here. {code:java} private Cell createNewCellWithTags(Mutation mutation, Cell oldCell, Cell newCell) { // Collect any ACLs from the old cell List tags = Lists.newArrayList(); List aclTags = Lists.newArrayList(); ListMultimap perms = ArrayListMultimap.create(); if (oldCell != null) { Iterator tagIterator = PrivateCellUtil.tagsIterator(oldCell); while (tagIterator.hasNext()) { Tag tag = tagIterator.next(); if (tag.getType() != PermissionStorage.ACL_TAG_TYPE) { // Not an ACL tag, just carry it through if (LOG.isTraceEnabled()) { LOG.trace(""Carrying forward tag from "" + oldCell + "": type "" + tag.getType() + "" length "" + tag.getValueLength()); } tags.add(tag); } else { aclTags.add(tag); } } } // Do we have an ACL on the operation? byte[] aclBytes = mutation.getACL(); if (aclBytes != null) { // Yes, use it tags.add(new ArrayBackedTag(PermissionStorage.ACL_TAG_TYPE, aclBytes)); } else { // No, use what we carried forward if (perms != null) { // TODO: If we collected ACLs from more than one tag we may have a // List of size > 1, this can be collapsed into a single // Permission if (LOG.isTraceEnabled()) { LOG.trace(""Carrying forward ACLs from "" + oldCell + "": "" + perms); } tags.addAll(aclTags); } } // If we have no tags to add, just return if (tags.isEmpty()) { return newCell; } // Here the new cell's tags will be in visible. return PrivateCellUtil.createCell(newCell, tags); } {code} " Make HRegion.getStores() an O(1) operation,13385742,Open,Minor,,25/Jun/21 02:06,,,"This is a relatively minor issue, but I did spot HRegion.getStores() popping up in my profiler. Checking the code, I realized that HRegion.getStores() allocates a new array list in it, converting the Collection<> to List<>. But it also makes it an O( n ) in space and time complexity. This conversion appears mostly unnecessary, because we only iterate the stores in production code, and so the new ArrayList object is thrown away immediately. Only in a number of test code where we index into the stores. I suggest we should return the stores object directly, an O( 1 ) operation." "CompactionProgress WARNS: ""totalCompactingKVs=N less than currentCompactedKVs=M""",13375922,Resolved,Minor,Fixed,30/Apr/21 00:59,12/Jun/22 18:41,2.4.3,"Similar to HBASE-25642, but compaction progress warnings. Lots of warnings like: {noformat} 2021-04-30 00:55:15,436 WARN [regionserver/ip-172-31-63-65:8120] compactions.CompactionProgress: totalCompactingKVs=15589 less than currentCompactedKVs=21411 {noformat} {noformat} 2021-04-30 00:55:15,437 WARN [regionserver/ip-172-31-63-65:8120] compactions.CompactionProgress: totalCompactingKVs=21916 less than currentCompactedKVs=33328 {noformat} {noformat} 2021-04-30 00:55:15,438 WARN [regionserver/ip-172-31-63-65:8120] compactions.CompactionProgress: totalCompactingKVs=89731 less than currentCompactedKVs=92808 {noformat} A couple of issues: - Is there a way to make CompactionProgress more reliable? I seem to recall this is the second or third time around the block on this. - This is annoying because compaction progress isn't always accurate, but this information is not used to determine anything significant, so WARN level is a bit much. (Or, if this is a real correctness problem, see point above.)" Update Reference Guide documentation for log4j2.xml,13377260,Resolved,Minor,Fixed,07/May/21 15:16,05/Mar/22 01:37,3.0.0-alpha-1,"In Apache HBase ™ Reference Guide *Need to modify part：* 7.Default Configuration ->7.4. log4j.properties *explanation：* we need to update to 7.4 log4j2.xml  " Relocate libnetty_transport_native_epoll_aarch_64.so in hbase-thirdparty,13381582,Resolved,Minor,Fixed,02/Jun/21 00:18,02/Jun/21 00:32,,Minor item I came across while trying to figure where all the netty native_epoll .so instances are coming from when I look at an hbase release. We've relocated the x86 lib but not the aarch_64... Minor item. [hbase-thirdparty] Fix typo in jersey relocation path,13376865,Resolved,Minor,Fixed,05/May/21 19:48,10/May/21 21:17,thirdparty-3.4.1,"We shade to ""jersery"" instead of ""jersey""." Master local region should be considered as a system table,13386903,Open,Minor,,30/Jun/21 22:05,,2.4.4,"The title says most of it. The master local region is not a typical Table/Region, however, we should consider it a system table when creating the TableName so that if we call isSystemTable() it returns true." hbase performance evaluation tool could not support datasize more than 2048g,13384632,Patch Available,Minor,,19/Jun/21 07:00,,2.1.0,"in our daily test, we may hope to test more datasize than 2048g, when we set --size more than 2048g, pe print abnormal message like this: [TestClient-1] hbase.PerformanceEvaluation: Start class org.apache.hadoop.hbase.PerformanceEvaluation$SequentialWriteTest at offset -1138166308 for -21474836 rows   this is due to variable totalRows in TestOptions defined by int(-2147483648  --- 2147483647), One GB is 1048576(1024*1024) by default. The max value of totalRow is  2147483647, in this condition, we may write not larger than 2147483647/1048576 = 2047.999G." Move delete of WAL directory out of LOG.info and avoid left over directory,13381767,Resolved,Minor,Fixed,02/Jun/21 18:18,02/Jun/21 21:21,1.1.0,"Followup the comment by [~anoopsamjohn] on HBASE-25921 (in [PR#88|https://github.com/apache/hbase-operator-tools/pull/88]) {quote} Not on this patch. But here is an issue. The actual delete() call happening within a Log statement. If INFO level not enabled, the delete wont get called. Can we fix that also here pls? {quote} " Fix Wrong FileSystem when running `filesystem` on non-HDFS storage,13380450,Resolved,Minor,Fixed,26/May/21 03:29,02/Jun/21 17:39,1.0.0,"recently we found a bug that when running {{hbck filesystem -f}} on a non-HDFS and caused {{Wrong FS}} error and cannot move forward. this change fix this problem and use {{FSUtils.getCurrentFileSystem}} to respect the root directory of what we set with {{hbase.rootdir}} in stead of just using {{fs.defaultFS}} e.g. this is one of the captured ERROR message  {code} Exception in thread ""main"" java.lang.IllegalArgumentException: Wrong FS: s3://xyz/data/default/abc, expected: hdfs://xyz/ at org.apache.hadoop.fs.FileSystem.checkPath(FileSystem.java:737) at org.apache.hadoop.hdfs.DistributedFileSystem.getPathName(DistributedFileSystem.java:233) at org.apache.hadoop.hdfs.DistributedFileSystem.listStatusInternal(DistributedFileSystem.java:1045) at org.apache.hadoop.hdfs.DistributedFileSystem.access$1000(DistributedFileSystem.java:131) at org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1112) at org.apache.hadoop.hdfs.DistributedFileSystem$24.doCall(DistributedFileSystem.java:1109) at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81) at org.apache.hadoop.hdfs.DistributedFileSystem.listStatus(DistributedFileSystem.java:1119) at org.apache.hadoop.hbase.util.FSUtils.listStatusWithStatusFilter(FSUtils.java:1530) at org.apache.hbase.hbck1.HFileCorruptionChecker.checkTableDir(HFileCorruptionChecker.java:320) at org.apache.hbase.hbck1.HFileCorruptionChecker.checkTables(HFileCorruptionChecker.java:431) at org.apache.hbase.FileSystemFsck.fsck(FileSystemFsck.java:87) at org.apache.hbase.HBCK2.doCommandLine(HBCK2.java:721) at org.apache.hbase.HBCK2.run(HBCK2.java:631) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90) at org.apache.hbase.HBCK2.main(HBCK2.java:865) {code}" More DEBUG and TRACE level logging in CatalogJanitor and HbckChore,13376672,Resolved,Minor,Fixed,05/May/21 02:19,06/May/21 00:01,2.4.3,Add DEBUG and TRACE level logging to CatalogJanitor and HbckChore to facilitate debugging and verification of correct operation. HFilePrettyPrinter tool can not print the last LEAF_INDEX block or BLOOM_CHUNK.,13384610,Open,Minor,,19/Jun/21 03:23,,2.1.0,"when i use pretty printer tool to print the headers of block, i can not get the last LEAF_INDEX block and BLOOM_CHUNK. the last info of the tools is blow:  " Reference class incorrectly parses the protobuf magic marker,13377027,Resolved,Minor,Fixed,06/May/21 12:10,10/May/21 19:52,2.4.1,"The Reference class incorrectly parses the protobuf magic marker. It uses: {code:java} // DataInputStream.read(byte[lengthOfPNMagic]){code} but this call does not guarantee to read all the bytes of the marker. The fix is the same as the one for https://issues.apache.org/jira/browse/HBASE-25674" Expose the NORMALIZARION_ENABLED table descriptor through a property in hbase-site,13382872,Resolved,Minor,Fixed,09/Jun/21 07:56,19/Jul/21 10:02,,"Today if we want to enable region normalizer on a table we have to add the table descriptor ""{color:#6a8759}NORMALIZATION_ENABLED{color}"" to the table. If we have a lot of tables and we want normalizer to be enabled by default for each table unless disabled explicitly for a table we can't achieve it  [https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java#L164]   Intention here is to set it using a property in hbase-site  " Backport HBASE-24305 to branch-2.2,13369842,Resolved,Minor,Fixed,06/Apr/21 17:50,08/Apr/21 16:21,, Backport HBASE-24305 to branch-2.4,13369647,Resolved,Minor,Fixed,05/Apr/21 20:17,06/Apr/21 17:12,, Backport HBASE-24305 to branch-2.3,13369840,Resolved,Minor,Fixed,06/Apr/21 17:39,08/Apr/21 13:07,, Get operations readRows metrics becomes zero after HBASE-25677,13384486,Resolved,Minor,Fixed,18/Jun/21 08:37,24/Jun/21 08:02,,"After HBASE-25677, Server+table counters on each scan are extracted from #nextRaw to rsServices scan. In this case, the get operation will not count the read rows. So that the readRows metrics becomes zero. Should add counter in metricsUpdateForGet." Fix hbase-operator-tools build with HBase 2.4.4,13386874,Resolved,Minor,Fixed,30/Jun/21 19:14,06/Jul/21 20:19,hbase-operator-tools-1.2.0,"I tried building hbase-operator-tools with HBase 2.4.4 and encountered a number of issues. Opening this for the fix. {noformat} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project hbase-hbck2: Compilation failure: Compilation failure: [ERROR] /Users/zyork/workspace/apache/hbase-operator-tools/hbase-hbck2/src/main/java/org/apache/hbase/HBCKAbstractFileStatusFilter.java:[20,39] package edu.umd.cs.findbugs.annotations does not exist [ERROR] /Users/zyork/workspace/apache/hbase-operator-tools/hbase-hbck2/src/main/java/org/apache/hbase/HBCKAbstractFileStatusFilter.java:[52,46] cannot find symbol [ERROR] symbol: class CheckForNull [ERROR] location: class org.apache.hbase.HBCKAbstractFileStatusFilter [ERROR] /Users/zyork/workspace/apache/hbase-operator-tools/hbase-hbck2/src/main/java/org/apache/hbase/HBCKAbstractFileStatusFilter.java:[64,44] cannot find symbol [ERROR] symbol: class CheckForNull [ERROR] location: class org.apache.hbase.HBCKAbstractFileStatusFilter [ERROR] /Users/zyork/workspace/apache/hbase-operator-tools/hbase-hbck2/src/main/java/org/apache/hbase/HBCKAbstractFileStatusFilter.java:[68,49] cannot find symbol [ERROR] symbol: class CheckForNull [ERROR] location: class org.apache.hbase.HBCKAbstractFileStatusFilter [ERROR] /Users/zyork/workspace/apache/hbase-operator-tools/hbase-hbck2/src/main/java/org/apache/hbase/HBCKFsUtils.java:[367,39] cannot find symbol [ERROR] symbol: class CheckForNull [ERROR] location: class org.apache.hbase.HBCKFsUtils.FamilyDirFilter [ERROR] /Users/zyork/workspace/apache/hbase-operator-tools/hbase-hbck2/src/main/java/org/apache/hbase/HBCKFsUtils.java:[402,39] cannot find symbol [ERROR] symbol: class CheckForNull [ERROR] location: class org.apache.hbase.HBCKFsUtils.RegionDirFilter [ERROR] -> [Help 1] {noformat} The Threads change is masked by these changes, but the method is clearly removed in HBASE-24750 `" Redundant null check in the compareTo function ,13386376,Resolved,Minor,Fixed,28/Jun/21 23:27,01/Jul/21 15:00,,"Remove a redundant null check in the compareTo function {code:java} if (!(source instanceof MetricsRegionSourceImpl)) { return -1; } MetricsRegionSourceImpl impl = (MetricsRegionSourceImpl) source; if (impl == null) { return -1; } {code}" "Sorting by ""Start time"" in the Master UI does so alphabetically and not by date",13375620,Resolved,Minor,Duplicate,28/Apr/21 15:05,01/Jul/21 04:53,2.3.4,When sorting by the start time column in the Maser UI it sorts alphabetically and not by date Improve logging and dequeue logic in DelayQueue,13384402,Resolved,Minor,Fixed,17/Jun/21 17:05,24/Jun/21 10:02,2.3.5,"In Remote Procedure dispatcher, before submitting (sub)Procedure to Thread pool, we enqueue it as DelayedWithTimeout object on DelayQueue.  TimeoutExecutorThread keeps dequeuing elements from this DelayQueue and submit the Procedure to the threadpool. The expiration of DelayedWithTimeout is determined by getDelay(TimeUnit): {code:java} @Override public long getDelay(final TimeUnit unit) { return DelayedUtil.getRemainingTime(unit, getTimeout()); } {code} {code:java} /** * @return Time remaining as milliseconds. */ public static long getRemainingTime(final TimeUnit resultUnit, final long timeout) { final long currentTime = EnvironmentEdgeManager.currentTime(); if (currentTime >= timeout) { return 0; } return resultUnit.convert(timeout - currentTime, TimeUnit.MILLISECONDS); } {code} Hence, in order for the elements to get dequeued on time, it is necessary that EnvironmentEdgeManager.currentTime() returns the current time in millis. As part of unit test, if we use our own custom EnvironmentEdge and inject it using EnvironmentEdgeManager.injectEdge before creating any tables, it is possible that we continue returning same value (based on custom impl) with EnvironmentEdgeManager.currentTime(). If that is the case, getRemainingTime as mentioned above, will never return 0 and hence, the procedure wrapped in DelayedWithTimeout might never be dequeued from DelayQueue because it's delay will not expire. As of today, our system goes in hanging state while waiting for table regions to be available (as mentioned above, DelayedWithTimeout object never gets dequeued from DelayQueue). Thread dump might show something like this consistently: {code:java} ""ProcedureDispatcherTimeoutThread"" #319 daemon prio=5 os_prio=31 tid=0x00007fcaf0cae800 nid=0x21d03 waiting on condition [0x0000700019293000] java.lang.Thread.State: TIMED_WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00000007225a0090> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject) at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215) at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078) at java.util.concurrent.DelayQueue.take(DelayQueue.java:223) at org.apache.hadoop.hbase.procedure2.util.DelayedUtil.takeWithoutInterrupt(DelayedUtil.java:82) at org.apache.hadoop.hbase.procedure2.RemoteProcedureDispatcher$TimeoutExecutorThread.run(RemoteProcedureDispatcher.java:314) Locked ownable synchronizers: - None {code} Although running into situation like this is not likely possible unless custom EnvironmentEdge is used as mentioned above, we should improve our dequeue logic as well as log important message to show where we are stuck." Add username for RegionScannerHolder,13380897,Resolved,Minor,Fixed,28/May/21 03:32,23/Jun/21 07:29,,"This JIRA[HBASE-25542|https://issues.apache.org/jira/browse/HBASE-25542] has added part of the client information before, we can also add username for RegionScannerHolder." Clarify UnknownRegionException,13380994,Resolved,Minor,Fixed,28/May/21 14:23,22/Jun/21 14:55,,"UnknownRegionException seems to accept a ""region name"" but it's actually a normal Exception message (and is used that way).  Fix this to be ""message"" and add a ""cause"" capability as well." Port HBASE-26001 (cell level tags invisible in atomic operations when access control is on) to branch-1,13383837,Resolved,Minor,Fixed,15/Jun/21 03:31,21/Jun/21 07:38,, Optimize the display of ZK dump in the master web UI,13383611,Resolved,Minor,Fixed,13/Jun/21 07:13,15/Jun/21 13:29,2.3.5,"Optimize the display of ZK dump in the master web UI. h3. *Before:* _*hbase:meta with 1 replica:*_ !1-replica-before.jpg|width=667,height=215! _*hbase:meta with 3 replica:*_ !3-replica-before.jpg|width=658,height=187! h3. *After:* _*hbase:meta with 1 replica:*_   !1-replica-after.jpg|width=648,height=229! _*hbase:meta with 3 replica:*_ !3-replica-after.jpg|width=656,height=254!  " NettyRpcServerRequestDecoder.exceptionCaught log e instead of e.getCause,13382690,Resolved,Minor,Won't Fix,08/Jun/21 10:53,08/Jun/21 11:03,,"After this change, we can get exception, otherwise null 2021-06-08T18:50:38,235 TRACE [NettyRpcServer-4-2] ipc.NettyRpcServerRequestDecoder(76): Connection /127.0.1.1:46443; caught unexpected downstream exception.2021-06-08T18:50:38,235 DEBUG [NettyRpcServer-4-2] ipc.NettyRpcServerRequestDecoder(76): Connection /127.0.1.1:46443; caught unexpected downstream exception.org.apache.hadoop.hbase.ipc.UnknownServiceException: CompactionService at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processConnectionHeader(ServerRpcConnection.java:498) ~[classes/:?] at org.apache.hadoop.hbase.ipc.ServerRpcConnection.processOneRpc(ServerRpcConnection.java:450) ~[classes/:?] at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:89) ~[classes/:?] at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:73) ~[classes/:?] at org.apache.hadoop.hbase.ipc.NettyServerRpcConnection.process(NettyServerRpcConnection.java:68) ~[classes/:?] at org.apache.hadoop.hbase.ipc.NettyRpcServerRequestDecoder.channelRead(NettyRpcServerRequestDecoder.java:62) ~[classes/:?] at org.apache.hbase.thirdparty.io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)" Stateless scanner endpoint documentation missing,13382377,Open,Minor,,07/Jun/21 05:03,,2.4.3,Hbase older versions(For example: 1.2) has [documentation for stateless scanner|https://hbase.apache.org/1.2/apidocs/org/apache/hadoop/hbase/rest/package-summary.html#operation_stateless_scanner] endpoints. But there is no mention of it in [recent documentation|[http://hbase.apache.org/book.html#_rest]|http://hbase.apache.org/book.html#_rest].] Improve Logging Statement Formatting,13380988,Open,Minor,,28/May/21 13:31,,,"I reviewed most of the TRACE/DEBUG log statements and wanted to clean up the first tier issues:   * Use logging anchors {{{}}} where previously was concatenating (without logging guard) * Remove String.format and use logging anchors {{{}}} * Remove logging guards around statements which use anchors (kind of defeats the purpose of anchors) * Remove logging guards around log statements which have no parameters (not concatenation) * Remove explicit calls to toString() that defeat the purpose of anchors * Remove Objects.toString() - logging framework will handle {{null}} values * Remove StringUtils ExceptionStackTrace logging - logging framework will handle pretty-print of Exception messages and stack traces * Remove logging guards around INFO messages.  They will just about always be printed in production systems, no need to try to protect them from happening The goal here is, maybe a tiny bump in performance, but to reduce the size of the code and to make logging statement more clear to developers." Fix uses of System.currentTimeMillis (should be EnvironmentEdgeManager.currentTime),13380213,Resolved,Minor,Fixed,25/May/21 00:05,01/Jun/21 23:08,,"We introduced EnvironmentEdgeManager a long time ago as a way to inject alternate clocks (gettimeofday() aka System.currentTimeMillis()) for unit tests. In order for this to be effective, all callers that would otherwise use System.currentTimeMillis() must call EnvironmentEdgeManager.currentTime() instead, except obviously the implementors of EnvironmentEdge. It's common for contributors to be unaware of this practice and reviewers might not catch it. It will be much more important to have EnvironmentEdgeManager in use where expected once we have EnvironmentEdge also providing a monotonic clock source. (See parent.) On another subtask I will introduce a build enforcer that bans System.currentTimeMillis() except where annotated to allow it.  " Fix TestClusterPortAssignment.testClusterPortAssignment test and re-enable it.,13380210,Resolved,Minor,Fixed,24/May/21 23:48,02/Jun/21 09:10,,"This test assigned with random unused ports for master and region server ports and start a cluster, however it can fail as the previously unsigned port might be taken by other application at the moment when cluster start to bind the ports. Server has an option to allow auto assign an port if the port is unavailable. This option needs to be disabled in this test in order to test explicit port assignment. The exception for the failure of starting server needs to change to IOException and there is a need to set a retry count instead of infinite retry. Related ticket: https://issues.apache.org/jira/browse/HBASE-24342" Fix the log messages by not stringifying the exceptions in log,13380590,Resolved,Minor,Fixed,26/May/21 16:48,29/May/21 04:42,2.4.4,"There are few places where we stringify the exceptions and log, instead we should just pass them as a parameter to see the stack trace in good format.  For example: https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L175" Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`,13370204,Resolved,Minor,Fixed,07/Apr/21 20:22,28/May/21 20:10,2.5.0,"After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to merge plans. Let's deprecate/rename the configuration key so that it is clear in what context it applies, and so that it matches the configuration structure of related keys." "Log trace raw exception, instead of cause message in NettyRpcServerRequestDecoder",13380802,Resolved,Minor,Fixed,27/May/21 14:39,27/May/21 19:07,2.2.7,"In *NettyRpcServerRequestDecoder,* override of *exceptionCaught* method tries to log the exception cause message, however this not always will have a content, causing debugging of connection failure issues harder to troubleshoot. We should simply log trace the observed *Throwable* reference itself:   {noformat} diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java index 1e844bb02cb..40f59ad1259 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcServerRequestDecoder.java @@ -74,7 +74,7 @@ class NettyRpcServerRequestDecoder extends ChannelInboundHandlerAdapter {    public void exceptionCaught(ChannelHandlerContext ctx, Throwable e) {      allChannels.remove(ctx.channel());      NettyRpcServer.LOG.trace(""Connection {}; caught unexpected downstream exception."", -        ctx.channel().remoteAddress(), e.getCause()); +        ctx.channel().remoteAddress(), e);      ctx.channel().close();    } } {noformat}  " Add basic jshell support,13376432,Resolved,Minor,Fixed,03/May/21 19:26,25/May/21 17:10,2.3.0,Let's make it easy to start a {{jshell}} session that includes HBase jars and dependencies on the class path. Memory leak from thrift server hashMap,13375331,Resolved,Minor,Fixed,27/Apr/21 12:24,22/May/21 02:59,1.7.0,"I found when the scanner does not closed successfully, it remains forever in the hashMap that stores the state of the scanner. To resolve this problem, I make scannerMap to Guava Cache so that can be expired on set time." RESTServer should implement Hadoop's Tool interface,13377309,Open,Minor,,07/May/21 20:16,,,"The class that provides the main entry point for the REST gateway appears to be entirely hand-constructed. Instead, this should probably use the common {{Tool}} support provided by Hadoop, so that it can do things like parse command line configuration parameters. For example, it could extend from {{AbstractHBaseTool}}." Extra doc around ITBLL,13377314,Resolved,Minor,Fixed,07/May/21 20:59,11/May/21 18:28,,Added some doc around ITBLL to explain stuff I had difficultly with. Minor items such as log message & javadoc edits and explaining how to pass configuration to the ChaosMonkeyRunner. Move master http-related code into o.a.h.h.master.http,13376456,Resolved,Minor,Fixed,03/May/21 22:44,05/May/21 15:38,,Minor refactor. Group code related to the Master's Info Page into a common package. SPLIT state detritus,13375927,Resolved,Minor,Fixed,30/Apr/21 02:07,06/May/21 16:14,2.4.3,"Seen after an integration test (see HBASE-25824) with 'calm' monkey, so this happened in the happy path. There were no errors accessing all loaded table data. The integration test writes a log to HDFS of every cell written to HBase and the verify phase uses that log to read each value and confirm it. That seems fine: {noformat} 2021-04-30 02:16:33,316 INFO [main] test.IntegrationTestLoadCommonCrawl$Verify: REFERENCED: 154943544 2021-04-30 02:16:33,316 INFO [main] test.IntegrationTestLoadCommonCrawl$Verify: UNREFERENCED: 0 2021-04-30 02:16:33,316 INFO [main] test.IntegrationTestLoadCommonCrawl$Verify: CORRUPT: 0 {noformat} However whenever the balancer runs there are a number of concerning INFO level log messages printed of the form _assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=TABLENAME_ For example: {noformat} 2021-04-30 02:02:09,286 INFO [master/ip-172-31-58-47:8100.Chore.2] assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=IntegrationTestLoadCommonCrawl, region=087fb2f7847c2fc0a0b85eb30a97036e 2021-04-30 02:02:09,286 INFO [master/ip-172-31-58-47:8100.Chore.2] assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=IntegrationTestLoadCommonCrawl, region=0952b94a920454afe9c40becbb7bf205 2021-04-30 02:02:09,286 INFO [master/ip-172-31-58-47:8100.Chore.2] assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=IntegrationTestLoadCommonCrawl, region=f87a8b993f7eca2524bf2331b7ee3c06 2021-04-30 02:02:09,286 INFO [master/ip-172-31-58-47:8100.Chore.2] assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=IntegrationTestLoadCommonCrawl, region=74bb28864a120decdf0f4956741df745 2021-04-30 02:02:09,286 INFO [master/ip-172-31-58-47:8100.Chore.2] assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=IntegrationTestLoadCommonCrawl, region=bc918b609ade0ae4d5530f0467354cae 2021-04-30 02:02:09,286 INFO [master/ip-172-31-58-47:8100.Chore.2] assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=IntegrationTestLoadCommonCrawl, region=183a199984539f3917a2f8927fe01572 2021-04-30 02:02:09,286 INFO [master/ip-172-31-58-47:8100.Chore.2] assignment.RegionStates: Skipping, no server for state=SPLIT, location=null, table=IntegrationTestLoadCommonCrawl, region=6cc5ce4fb4adc00445b3ec7dd8760ba8 {noformat} The HBCK chore notices them but does nothing: ""Loaded *80 regions* from in-memory state of AssignmentManager"" ""Loaded *73 regions from 5 regionservers' reports* and found 0 orphan regions"" ""Loaded 3 tables 80 regions from filesystem and found 0 orphan regions"" Yes, there are exactly 7 region state records of SPLIT state with server=null. {noformat} 2021-04-30 02:02:09,300 INFO [master/ip-172-31-58-47:8100.Chore.1] master.HbckChore: Loaded 80 regions from in-memory state of AssignmentManager 2021-04-30 02:02:09,300 INFO [master/ip-172-31-58-47:8100.Chore.1] master.HbckChore: Loaded 73 regions from 5 regionservers' reports and found 0 orphan regions 2021-04-30 02:02:09,306 INFO [master/ip-172-31-58-47:8100.Chore.1] master.HbckChore: Loaded 3 tables 80 regions from filesystem and found 0 orphan regions {noformat} This repeats indefinitely. " Move regionserver http-related code into o.a.h.h.regionserver.http,13376455,Resolved,Minor,Fixed,03/May/21 22:43,04/May/21 22:47,,Minor refactor. Group code related to the Region Server's Info Page into a common package. Batch version of checkAndMutate on AsyncTable always returns false,13373956,Resolved,Minor,Fixed,20/Apr/21 23:11,05/May/21 17:18,2.4.1,"Batch version of CheckAndMutate always returns false whereas non-batch version works fine.  The code is like:    {code:java} AysncTable table = connection.getTable(tableName, executorService); ... // add r1 table.put(Arrays.asList( new Put(Bytes.toBytes(""r1"")).addColumn(COL_FAMILY, Bytes.toBytes(""q1""), Bytes.toBytes(""v1"")))); CheckAndMutate checkAndMutate1 = CheckAndMutate.newBuilder(Bytes.toBytes(""r1"")) .ifNotExists(COL_FAMILY, Bytes.toBytes(""q1"")) .build(new Put(Bytes.toBytes(""r1"")).addColumn(COL_FAMILY, Bytes.toBytes(""q1""), Bytes.toBytes(""v1""))); CheckAndMutate checkAndMutate2 = CheckAndMutate.newBuilder(Bytes.toBytes(""r2"")) .ifNotExists(COL_FAMILY, Bytes.toBytes(""q2"")) .build(new Put(Bytes.toBytes(""r2"")).addColumn(COL_FAMILY, Bytes.toBytes(""q2""), Bytes.toBytes(""v2""))); {code}   With batch version of checkAndMutate {code:java} List> results =    table.checkAndMutate(Arrays.asList(checkAndMutate1, checkAndMutate2)); System.out.println(""first: "" + results.get(0).join().isSuccess());  // false System.out.println(""second: "" + results.get(1).join().isSuccess()); //false! {code}     Even it returned false, the r1 was written to the table. (timestamp was updated)    With non-batch version of checkAndMutate   {code:java} CompletableFuture result1 = table.checkAndMutate(checkAndMutate1); CompletableFuture result2 = table.checkAndMutate(checkAndMutate2); System.out.println(""first: "" + result1.join().isSuccess()); // false  System.out.println(""second: "" + result2.join().isSuccess()); // true as expected {code}   As expected r1 wasn't written to the table. " Backport 'HBASE-25825 RSGroupBasedLoadBalancer.onConfigurationChange should chain the request to internal balancer' to branch-1,13376634,Resolved,Minor,Fixed,04/May/21 20:43,05/May/21 07:16,,"In branch-1, [RSGroupBasedLoadBalancer#onConfigurationChange|https://github.com/apache/hbase/blob/branch-1/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java#L452] doesn't do anything – it should call the internal balancer's onConfigurationChange()." "CatalogJanitor warns about skipping gc of regions during RIT, but does not actually skip",13376428,Resolved,Minor,Fixed,03/May/21 19:08,04/May/21 01:20,2.4.3,"Found while looking for something else. We claim in a WARN level log line to {{""Playing-it-safe skipping merge/split gc'ing of regions from hbase:meta while regions-in-transition (RIT)""}} but do not actually skip because of a missing return. Playing it safe has proven unnecessary, I would say. Nonetheless here is a patch that adds the missing return, for discussion. " IntegrationTestLoadCommonCrawl,13375709,Resolved,Minor,Fixed,28/Apr/21 23:26,04/May/21 01:04,,"This integration test loads successful resource retrieval records from the Common Crawl (https://commoncrawl.org/) public dataset into an HBase table and writes records that can be used to later verify the presence and integrity of those records. Run like: {noformat} ./bin/hbase org.apache.hadoop.hbase.test.IntegrationTestLoadCommonCrawl \ -files /path/to/hadoop-aws.jar \ -Dfs.s3n.awsAccessKeyId= \ -Dfs.s3n.awsSecretAccessKey= \ /path/to/test-CC-MAIN-2021-10-warc.paths.gz \ /path/to/tmp/warc-loader-output {noformat} Access to the Common Crawl dataset in S3 is made available to anyone by Amazon AWS, but Hadoop's S3N filesystem still requires valid access credentials to initialize. The input path can either specify a directory or a file. The file may optionally be compressed with gzip. If a directory, the loader expects the directory to contain one or more WARC files from the Common Crawl dataset. If a file, the loader expects a list of Hadoop S3N URIs which point to S3 locations for one or more WARC files from the Common Crawl dataset, one URI per line. Lines should be terminated with the UNIX line terminator. Included in hbase-it/src/test/resources/CC-MAIN-2021-10-warc.paths.gz is a list of all WARC files comprising the Q1 2021 crawl archive. There are 64,000 WARC files in this data set, each containing ~1GB of gzipped data. The WARC files contain several record types, such as metadata, request, and response, but we only load the response record types. If the HBase table schema does not specify compression (by default) there is roughly a 10x expansion. Loading the complete CC-MAIN-2021-10 crawl archive results in a table approximately 640 TB in size. The hadoop-aws jar will be needed at runtime to instantiate the S3N filesystem. Use the -files ToolRunner argument to add it. You can also split the Loader and Verify stages: Load with: {noformat} ./bin/hbase 'org.apache.hadoop.hbase.test.IntegrationTestLoadCommonCrawl$Loader' \ -files /path/to/hadoop-aws.jar \ -Dfs.s3n.awsAccessKeyId= \ -Dfs.s3n.awsSecretAccessKey= \ /path/to/test-CC-MAIN-2021-10-warc.paths.gz \ /path/to/tmp/warc-loader-output {noformat} Verify with: {noformat} ./bin/hbase 'org.apache.hadoop.hbase.test.IntegrationTestLoadCommonCrawl$Verify' \ /path/to/tmp/warc-loader-output {noformat}" HBase Configuration File Descriptions has some description errors or inaccurate,13376260,Resolved,Minor,Fixed,02/May/21 09:24,02/May/21 13:03,3.0.0-alpha-1,"In Apache HBase ™ Reference Guide *Need to modify part1：* _3 Configuration Files->HBase Configuration File Descriptions->log4j.properties_ *explanation：* HBase 3.0.0 log frame is now log4j2，so need to update dectiption like follows: log4j2.xml Configuration file for HBase logging via log4j2. *Need to modify part2：* _3 Configuration Files->HBase Configuration File Descriptions->hbase-site.xml_ You can view (but do not edit) the default configuration file at docs/hbase-default.xml. *explanation：* maybe we need to update hbase-default.xml filePath to hbase-common/src/main/resources/hbase-default.xml" "Improve the documentation of ""Architecture"" section of reference guide",13375151,Resolved,Minor,Fixed,26/Apr/21 19:41,03/May/21 07:34,,"While going through the reference guide, I found these small changes that can be made to the documentation of the ""Architecture"" part of it. Hence I'm filing this Jira to track those changes.  " Support alternate compression for major and minor compactions,13370729,Resolved,Minor,Fixed,09/Apr/21 19:34,23/Apr/21 23:20,,"Resurrecting HBASE-2988. Currently we can specify a compression algorithm for a column family, or, optionally an alternative compression algorithm to use when compacting (as opposed to flushing). Extend this to optionally specify alternative compression algorithms for minor or major compactions. The interest here is specifically a separate alternative algorithm for major compactions, which might be an expensive but aggressively compressing algorithm like bzip2 or lzma (with custom patches). " typo in MetricsAssertHelper,13374003,Resolved,Minor,Fixed,21/Apr/21 03:56,21/Apr/21 15:25,2.5.0,"""boolean true id counter metric exists."" -> ""boolean true if counter metric exists.""" Batch version of checkAndMutate on AsyncTable always returns false,13373955,Resolved,Minor,Duplicate,20/Apr/21 23:10,22/Apr/21 06:29,2.4.1,"Batch version of CheckAndMutate always returns false whereas non-batch version works fine.  The code is like:  ``` AysncTable table = connection.getTable(tableName, executorService); ... // add r1 table.put(Arrays.asList( new Put(Bytes.toBytes(""r1"")).addColumn(COL_FAMILY, Bytes.toBytes(""q1""), Bytes.toBytes(""v1"")))); CheckAndMutate checkAndMutate1 = CheckAndMutate.newBuilder(Bytes.toBytes(""r1"")) .ifNotExists(COL_FAMILY, Bytes.toBytes(""q1"")) .build(new Put(Bytes.toBytes(""r1"")).addColumn(COL_FAMILY, Bytes.toBytes(""q1""), Bytes.toBytes(""v1""))); CheckAndMutate checkAndMutate2 = CheckAndMutate.newBuilder(Bytes.toBytes(""r2"")) .ifNotExists(COL_FAMILY, Bytes.toBytes(""q2"")) .build(new Put(Bytes.toBytes(""r2"")).addColumn(COL_FAMILY, Bytes.toBytes(""q2""), Bytes.toBytes(""v2""))); ``` With batch version of checkAndMutate ``` List> results =    table.checkAndMutate(Arrays.asList(checkAndMutate1, checkAndMutate2)); System.out.println(""first: "" + results.get(0).join().isSuccess());  // false System.out.println(""second: "" + results.get(1).join().isSuccess()); //false! ``` Even it returned false, the item was written to the table.    With non-batch version of checkAndMutate ``` CompletableFuture result1 = table.checkAndMutate(checkAndMutate1); CompletableFuture result2 = table.checkAndMutate(checkAndMutate2); System.out.println(""first: "" + result1.join().isSuccess()); // false  System.out.println(""second: "" + result2.join().isSuccess()); // true as expected ``` As expected r1 wasn't written to the table. " Provide utility to validate a snapshot,13373944,Open,Minor,,20/Apr/21 20:47,,,"Validate if there is a verify snapshot option present. If not, provide utility to invoke the validation. Currently, we are verifying snapshots in the ExportSnapshot utility. It will be good to move that out to be used on its own as well. " Add cacheBlocks option to RowCounter,13372965,In Progress,Minor,,16/Apr/21 10:03,,,"{{I want to preload the block cache quickly during performance testing,I find this:}} {{[#HBASE-25278 Add option to toggle CACHE_BLOCKS in count.rb]}} {{But it's too slow, adding cacheBlocks option to RowCounter maybe better for some case.}}" Use Class.asSubclass to fix the warning in StochasticLoadBalancer.loadCustomCostFunctions,13372528,Resolved,Minor,Fixed,15/Apr/21 03:39,15/Apr/21 18:13,,"{code} klass = (Class) Class.forName(c); {code} This will generated a warning of unchecked casting, could simply use Class.forName(c).asSubclass(CostFunction.class)." Scan should be limited by read capacity unit quota if read size quota is not set,13369703,Open,Minor,,06/Apr/21 06:45,,,"Scan is currently limited by available size of quota, and quota size only considers the READ_SIZE type: {code:java} long maxQuotaResultSize = Math.min(maxScannerResultSize, quota.getReadAvailable()); {code} If read size is not set, we should limit the result size by read capacity unit to avoid exceeding quota." Improvement for some debug-logging guards,13371073,Resolved,Minor,Fixed,11/Apr/21 02:24,14/Apr/21 00:27,,"Some potential expensive debug-logging calls are partially guarded by `isXXXEnabled()`. Therefore, - Moving some potential expensive statements into the adjacent `isDebugEnabled` in `NettyRpcDuplexHandler.java` - Moving the `isTraceEnabled` up to the beginning of `printChoreDetails` and `printChoreServiceDetails` in `ChoreService.java `." HBASE shell list_regions doesn't work when region replica is enabled after merge regions,13370053,Open,Minor,,07/Apr/21 10:42,,2.2.3,"steps : 1.create 'Merget1', 'f1', \{REGION_REPLICATION => 2} 2. split 'Merget1','20' 3.list_regions 'Merget1' 4. merge_region 'EncodeRegionName1','EncodeRegionName2'   5. when list_regions 'Merget1' getting undefined method !image-2021-04-07-16-10-50-935.png!  *Issue doesn't seems to occur for tables which do not have region replica enabled*" Remove unused getWriteAvailable method in OperationQuota,13370297,Resolved,Minor,Fixed,08/Apr/21 07:04,09/Apr/21 02:59,,"The getWriteAvailable method is unused in OperationQuota, because for write operation, the size is accurate." HBase RegionServer Canary reports failure if an online regionserver is hosting 0 regions,13369351,Open,Minor,,02/Apr/21 19:39,,,"The probability of this happening increases with system rsgroup enabled (i.e. an rsgroup dedicated to system tables, which have few regions) and paired with table-level load balancing. As long as the server is alive and able to accept/serve regions, we should not consider it an error case if it is currently serving no regions." Add retry if we fail to read all bytes of the protobuf magic marker,13377680,Resolved,Trivial,Fixed,10/May/21 19:55,26/Oct/24 08:53,,The parent issue fixes an instance where we try once to read protobuf magic marker bytes rather than retry till we have enough. This subtask applies the same trick in all cases where we could run into this issue. affect version is editable,13381293,Resolved,Trivial,Invalid,31/May/21 13:30,01/Jun/21 10:32,1.4.12, Get rid of null regioninfo in wrapped connection exceptions,13381057,Resolved,Trivial,Fixed,29/May/21 00:12,31/May/21 04:23,2.4.4,"I was debugging something and noticed this, {noformat} org.apache.hbase.thirdparty.com.google.protobuf.ServiceException: java.io.IOException: Call to address=localhost:59142null failed on local exception: java.io.IOException: Connection reset by peer {noformat} `null` there is regioninfo and because this call has nothing set on it, it was confusing where that null is coming from, added recently via HBASE-25735." Fix checkstyle violations in hbase-table-reporter module,13373901,Resolved,Trivial,Fixed,20/Apr/21 16:49,04/May/21 08:43,,"The hbase-table-reporter module in hbase-operator-tools has a bunch of checkstyle violations. {noformat} [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[22] (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.Option' import. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[23] (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.CommandLineParser' import. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[24] (imports) ImportOrder: Wrong order for 'org.apache.commons.cli.CommandLine' import. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[34,8] (imports) UnusedImports: Unused import - org.apache.hadoop.hbase.HRegionInfo. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[37] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.apache.hadoop.hbase.client.*. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[41] (imports) ImportOrder: Wrong order for 'java.io.BufferedWriter' import. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[66,1] (design) HideUtilityClassConstructor: Utility classes should not have a public or default constructor. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[94] (sizes) LineLength: Line is longer than 100 characters (found 120). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[126] (sizes) LineLength: Line is longer than 100 characters (found 105). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[132] (sizes) LineLength: Line is longer than 100 characters (found 106). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[247] (indentation) Indentation: 'throws' has incorrect indentation level 2, expected level should be 4. [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[275] (sizes) LineLength: Line is longer than 100 characters (found 112). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[279] (sizes) LineLength: Line is longer than 100 characters (found 105). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[308] (sizes) LineLength: Line is longer than 100 characters (found 101). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[370] (sizes) LineLength: Line is longer than 100 characters (found 121). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[371] (sizes) LineLength: Line is longer than 100 characters (found 108). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[375] (sizes) LineLength: Line is longer than 100 characters (found 102). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[401] (sizes) LineLength: Line is longer than 100 characters (found 113). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[407] (sizes) LineLength: Line is longer than 100 characters (found 112). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[410] (sizes) LineLength: Line is longer than 100 characters (found 107). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[437] (sizes) LineLength: Line is longer than 100 characters (found 114). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[438] (sizes) LineLength: Line is longer than 100 characters (found 109). [ERROR] src/main/java/org/apache/hbase/reporter/TableReporter.java:[445] (indentation) Indentation: 'throws' has incorrect indentation level 2, expected level should be 4. [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[27] (imports) ImportOrder: Wrong order for 'java.util.ArrayList' import. [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[30] (imports) ImportOrder: Wrong order for 'org.apache.hadoop.hbase.shaded.junit.framework.TestCase.assertEquals' import. [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[59] (sizes) LineLength: Line is longer than 100 characters (found 110). [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[75] (sizes) LineLength: Line is longer than 100 characters (found 110). [ERROR] src/test/java/org/apache/hbase/reporter/TestTableReporter.java:[80] (sizes) LineLength: Line is longer than 100 characters (found 111). {noformat}" HRegionServer#compactSplitThread should be private,13372753,Resolved,Trivial,Fixed,15/Apr/21 23:41,29/Apr/21 00:13,,"Minor refactor. Make the {{compactSplitThread}} member field of {{HRegionServer}} private, and gate all access through the getter method." graceful_stop.sh unable to restore the balance state,13475413,Resolved,Blocker,Fixed,05/Aug/22 13:08,09/Aug/22 01:59,2.4.13,"When executing the command ’graceful_stop.sh --restart --reload‘, the balance state cannot be restored normally. Because the related command returned the wrong result: {code:java} HBASE_BALANCER_STATE=$(echo 'balance_switch false' | hbase shell -n | tail -1) echo ${HBASE_BALANCER_STATE}  hbase:002:0> {code}   The information returned by  ""echo 'balance_switch false' | hbase shell -n"" is as follows: hbase:001:0> balance_switch false  {color:#ff0000}#line 1{color} 2022-08-05 22:41:57,269 INFO  [RPCClient-NioEventLoopGroup-1-1] Configuration.deprecation: hbase.client.pause.cqtbe is deprecated. Instead, use hbase.client.pause.server.overloaded {color:#ff0000}#line 2{color} Previous balancer state : true   {color:#ff0000}# line 3{color} Took 0.6787 seconds {color:#ff0000}#line 4{color} => true  {color:#ff0000}#line 5{color} hbase:002:0> {color:#ff0000}#line 6{color}   head -1 is {color:#172b4d}#line 1{color}: ""hbase:001:0> balance_switch false"" tail -1 is {color:#172b4d}#line 6{color}: ""hbase:002:0>""   {color:#172b4d}balance_switch.rb is as follows:{color} {code:java} def command(enableDisable) prev_state = !!admin.balance_switch(enableDisable) formatter.row([""Previous balancer state : #{prev_state}""]) prev_state end{code} #line 3 and #line 5 of 'true'  represent the previous balance status. So we can use the value of {color:#172b4d}#line 5{color}  as the state of the previous balance.  " NettyServerRpcConnection is not properly closed when the netty channel is closed,13470875,Resolved,Blocker,Fixed,10/Jul/22 14:49,12/Jul/22 01:48,,"We have a close method for NettyServerRpcConnection where we dispose the SaslServer and also release the ByteBuf if needed, but we never call it... This could also leak memory and also other resources..." The ReplicationLogCleaner is not thread safe but can be called from different threads at the same time,13478310,Resolved,Critical,Fixed,24/Aug/22 02:43,27/Aug/22 16:32,,"In preClean method we will update the class fields and then use them in the getDeletableFiles method. This implies that we will have only one cleaner run at the same time. But actually, in MasterRpcServices.runCleanerChore, we will call execute the HFileCleaner and LogCleaner directly, not in the cleanerChore thread. This could cause data loss for replication, which is a very serious problem." HBase FileNotFound Exception After Region Transitioned ,13479404,Open,Critical,,31/Aug/22 03:41,,2.1.0,"We have the exactly the same issue with https://issues.apache.org/jira/browse/HBASE-13651: * The SCAN will got FNFE after RS got Full GC and  transmitted and opened in another RS.  * During which ,taking snapshot will also report FNFE * Issue could be resolved by move the problem region manually. We find that the HBASE-13651 is reverted afterwards by https://issues.apache.org/jira/browse/HBASE-18786 since they thought it is not a problem anymore with the comment in HBASE-18786 !image-2022-08-31-11-39-58-549.png! Basic Timeline of my issue: {code:java} 2022-08-27 05:26:35     Snapshot TestSnapshot is taken successfully  2022-08-27 15:21:51     The target hfile fafb8f91bd20b1adfe15e2a64a39557e/i/041e9aeb8cdb46f991459c92f8581e16 is generated by a compaction in regionserver-67 2022-08-27 17:26:36     041e9aeb8cdb46f991459c92f8581e16 is compacted to fd53b8e6b4874eb38712ad2d04389fff successfully 2022-08-27 17:34:53     A full GC started to happen on regionserver-67  2022-08-27 17:35:50    Region fafb8f91bd20b1adfe15e2a64a39557e is re-opened in regionserver-11, which is scheduled by HMaster 2022-08-27 17:35:56     regionserver-67 wake up from Full GC 2022-08-27 17:35:57     File  fafb8f91bd20b1adfe15e2a64a39557e is archived by lashadoop-regionserver-67 and afterwards, regionserver-67 found that it is kicked out and exit.  2022-08-27 18:00:00    The archived hfile is removed by HMaster's CleanerChore 2022-08-27 19:48:10    User's job shows error that the file is missed  2022-08-27 20:26:04    Re-taking snapshot TaggingSegmentationSnapshot failed for 041e9aeb8cdb46f991459c92f8581e16 is missing{code} The exception of Scanning after region is transmitted:   {code:java} java.io.FileNotFoundException: File does not exist:/hbase/prod/hbase-prod/data/default/mdm/fafb8f91bd20b1adfe15e2a64a39557e/i/041e9aeb8cdb46f991459c92f8581e16        at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:85)         at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:75)         at org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:152)         at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1909)         at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:735)         at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:415)         at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)         at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:523)         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:869)         at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:815)         at java.security.AccessController.doPrivileged(Native Method)         at javax.security.auth.Subject.doAs(Subject.java:422)         at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1875)         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2675)         at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)         at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)         at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)         at java.lang.reflect.Constructor.newInstance(Constructor.java:423)         at org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:121)         at org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:88)         at org.apache.hadoop.hdfs.DFSClient.callGetBlockLocations(DFSClient.java:861)         at org.apache.hadoop.hdfs.DFSClient.getLocatedBlocks(DFSClient.java:848)         at org.apache.hadoop.hdfs.DFSClient.getLocatedBlocks(DFSClient.java:837)         at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1005)         at org.apache.hadoop.hdfs.DistributedFileSystem$4.doCall(DistributedFileSystem.java:317)         at org.apache.hadoop.hdfs.DistributedFileSystem$4.doCall(DistributedFileSystem.java:313)         at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)         at org.apache.hadoop.hdfs.DistributedFileSystem.open(DistributedFileSystem.java:325)         at org.apache.hadoop.fs.FilterFileSystem.open(FilterFileSystem.java:163)         at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:898)         at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:125)         at org.apache.hadoop.hbase.io.FSDataInputStreamWrapper.(FSDataInputStreamWrapper.java:102)         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.open(StoreFileInfo.java:269)         at org.apache.hadoop.hbase.regionserver.HStoreFile.createStreamReader(HStoreFile.java:491)         at org.apache.hadoop.hbase.regionserver.HStoreFile.getStreamScanner(HStoreFile.java:516)         at org.apache.hadoop.hbase.regionserver.StoreFileScanner.getScannersForStoreFiles(StoreFileScanner.java:149)         at org.apache.hadoop.hbase.regionserver.HStore.getScanners(HStore.java:1309)         at org.apache.hadoop.hbase.regionserver.HStore.recreateScanners(HStore.java:2042)         at org.apache.hadoop.hbase.regionserver.StoreScanner.trySwitchToStreamRead(StoreScanner.java:1064)         at org.apache.hadoop.hbase.regionserver.StoreScanner.shipped(StoreScanner.java:1198)         at org.apache.hadoop.hbase.regionserver.KeyValueHeap.shipped(KeyValueHeap.java:437)         at org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.shipped(HRegion.java:6959)         at org.apache.hadoop.hbase.regionserver.RSRpcServices$RegionScannerShippedCallBack.run(RSRpcServices.java:388)         at org.apache.hadoop.hbase.ipc.ServerCall.setResponse(ServerCall.java:289)         at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:161)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324)         at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304) {code}   The exception of taking snapshot after region is transmitted: {code:java} 2022-08-27 20:26:03,794 ERROR org.apache.hadoop.hbase.procedure.Subprocedure: Subprocedure 'TaggingSegmentationSnapshot' aborting due to a ForeignException! java.io.FileNotFoundException via regionserver-11.**,60020,1653373878295:java.io.FileNotFoundException: File does not exist: hdfs://test-hbase/hbase/prod/hbase-prod/data/default/mdm/fafb8f91bd20b1adfe15e2a64a39557e/i/041e9aeb8cdb46f991459c92f8581e16         at org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager$SnapshotSubprocedurePool.waitForOutstandingTasks(RegionServerSnapshotManager.java:349)         at org.apache.hadoop.hbase.regionserver.snapshot.FlushSnapshotSubprocedure.flushSnapshot(FlushSnapshotSubprocedure.java:173)         at org.apache.hadoop.hbase.regionserver.snapshot.FlushSnapshotSubprocedure.insideBarrier(FlushSnapshotSubprocedure.java:193)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:189)         at org.apache.hadoop.hbase.procedure.Subprocedure.call(Subprocedure.java:53)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) Caused by: java.io.FileNotFoundException: File does not exist: hdfs://beaconstore/hbase/prod/hbase-prod/data/ap/mdm_user_segments/fafb8f91bd20b1adfe15e2a64a39557e/i/041e9aeb8cdb46f991459c92f8581e16         at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1500)         at org.apache.hadoop.hdfs.DistributedFileSystem$29.doCall(DistributedFileSystem.java:1493)         at org.apache.hadoop.fs.FileSystemLinkResolver.resolve(FileSystemLinkResolver.java:81)         at org.apache.hadoop.hdfs.DistributedFileSystem.getFileStatus(DistributedFileSystem.java:1508)         at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:442)         at org.apache.hadoop.hbase.regionserver.StoreFileInfo.getReferencedFileStatus(StoreFileInfo.java:368)         at org.apache.hadoop.hbase.snapshot.SnapshotManifestV2$ManifestBuilder.storeFile(SnapshotManifestV2.java:129)         at org.apache.hadoop.hbase.snapshot.SnapshotManifestV2$ManifestBuilder.storeFile(SnapshotManifestV2.java:68)         at org.apache.hadoop.hbase.snapshot.SnapshotManifest.addRegion(SnapshotManifest.java:249)         at org.apache.hadoop.hbase.snapshot.SnapshotManifest.addRegion(SnapshotManifest.java:218)         at org.apache.hadoop.hbase.regionserver.HRegion.addRegionToSnapshot(HRegion.java:4285)         at org.apache.hadoop.hbase.regionserver.snapshot.FlushSnapshotSubprocedure$RegionSnapshotTask.call(FlushSnapshotSubprocedure.java:134)         at org.apache.hadoop.hbase.regionserver.snapshot.FlushSnapshotSubprocedure$RegionSnapshotTask.call(FlushSnapshotSubprocedure.java:77)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)         ... 4 more {code}   cc [~mbertozzi]  [~apurtell]  " Class missing at runtime,13478520,Resolved,Critical,Not A Bug,25/Aug/22 02:04,30/Aug/22 06:37,2.3.4,"We found that some class cannot be found after the regionserver has been running for a period of time(more than a month). And more than half of the machines in our cluster have this problem. Some are still running normally, but _/rs-status_ cannot be opened，and others have various problems(such as rit, replication failed, abort failed) Some exceptions are as follows: {code:java} java.lang.NoClassDefFoundError: org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl at org.apache.hadoop.hbase.regionserver.RSStatusServlet.doGet(RSStatusServlet.java:49) at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:848) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1780) at org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:112) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.apache.hadoop.hbase.http.SecurityHeadersFilter.doFilter(SecurityHeadersFilter.java:66) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.apache.hadoop.hbase.http.ClickjackingPreventionFilter.doFilter(ClickjackingPreventionFilter.java:52) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1767) at org.apache.hadoop.hbase.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:1495) {code} {code:java} 2022-08-24 19:22:52,536 ERROR [RS_CLOSE_REGION-regionserver/xxxx:26020-1] regionserver.HRegionServer: ***** ABORTING region server 10.x.x.x,26020,1659357427101: Replay of WAL required. Forcing server shutdown ***** org.apache.hadoop.hbase.DroppedSnapshotException: region: xxxx:xxxx,xxxxxx,1661298619920.943104cbcf4a74db9896fd4abd051411. at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2906) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2575) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2547) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2538) at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1652) at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1591) at org.apache.hadoop.hbase.regionserver.handler.UnassignRegionHandler.process(UnassignRegionHandler.java:114) at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.NoClassDefFoundError: org/apache/hadoop/hbase/regionserver/querymatcher/DeleteTracker$DeleteResult at org.apache.hadoop.hbase.regionserver.querymatcher.ScanDeleteTracker.isDeleted(ScanDeleteTracker.java:108) at org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher.checkDeleted(ScanQueryMatcher.java:209) at org.apache.hadoop.hbase.regionserver.querymatcher.MinorCompactionScanQueryMatcher.match(MinorCompactionScanQueryMatcher.java:54) at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:627) at org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:127) at org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:69) at org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1067) at org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2442) at org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2842) ... 10 more Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.regionserver.querymatcher.DeleteTracker$DeleteResult at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 19 more {code}" Add default implementation for Connection$getClusterId,13475726,Resolved,Critical,Fixed,08/Aug/22 11:12,11/Aug/22 15:29,2.4.14,The getClusterId method was added to Connection for delegation token based auth. This interface is InterfaceAudience.Public so it breaks client compatibility. Hbase connections builds fail with the latest 2.4.14-SNAPSHOT version and downstream applications relying on Connection interface will fail to work on these versions. Rolling back from 2.5.0-SNAPSHOT to 2.4.13 fails due to `File does not exist: /hbase/MasterData/data/master/store/.initialized/.regioninfo`,13473839,Resolved,Critical,Fixed,27/Jul/22 17:52,01/Aug/22 23:51,2.5.0,"I was doing some perf testing with builds of 2.5.0. I rolled back to 2.4.13 and the master won't start. Stack trace ends in, {noformat} java.io.FileNotFoundException: File does not exist: /hbase/MasterData/data/master/store/.initialized/.regioninfo at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:86) at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76) at org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:156) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:2089) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:762) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:458) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:604) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:572) at org.apache.hadoop.ipc.ProtobufRpcEngine2$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine2.java:556) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1093) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:1043) at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:971) at java.base/java.security.AccessController.doPrivileged(AccessController.java:712) at java.base/javax.security.auth.Subject.doAs(Subject.java:439) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1878) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2976) {noformat} When I examine the on-disk file system, I see, {noformat} nonroot@namenode-0:~$ hdfs dfs -ls /hbase/MasterData/data/master/store/ Found 3 items drwxr-xr-x - nonroot supergroup 0 2022-07-19 17:37 /hbase/MasterData/data/master/store/.initialized drwxr-xr-x - nonroot supergroup 0 2022-07-19 17:37 /hbase/MasterData/data/master/store/.tabledesc drwxr-xr-x - nonroot supergroup 0 2022-07-27 16:25 /hbase/MasterData/data/master/store/1595e783b53d99cd5eef43b6debb2682 nonroot@namenode-0:~$ hdfs dfs -ls /hbase/MasterData/data/master/store/.initialized/ nonroot@namenode-0:~$ {noformat}" BlockingRpcClient will hang for 20 seconds when SASL is enabled after finishing negotiation,13471598,Resolved,Critical,Fixed,14/Jul/22 13:43,25/Jul/22 06:15,,"Found this when implementing HBASE-27185. When running TestSecureIPC, if BlockingRpcClient is used, the tests will spend much more time comparing to NettyRpcClient. The problem is that, for the normal kerberos authentication, the last step is client send a reply to server, so after server receives the last token, it will not write anything back but expect client to send connection header. In HBASE-24579, for reading the error message, we added a readReply after the SaslClient indicates that the negotiation is completed. But as said above, for normal cases, we will not write anything back from server side, so the client will hang there and only throw an exception when timeout is reached, which is 20 seconds. This nearly makes the BlockingRpcClient unusable when sasl is enabled, as it will hang 20 seconds when connecting..." Data race in MonitoredTaskImpl could cause split wal failure,13471857,Resolved,Critical,Fixed,16/Jul/22 04:11,18/Jul/22 12:09,,"https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/3866/testReport/junit/org.apache.hadoop.hbase.wal/TestWALSplitBoundedLogWriterCreation/testThreading/ {noformat} java.lang.reflect.UndeclaredThrowableException at com.sun.proxy.$Proxy49.prettyPrintJournal(Unknown Source) at org.apache.hadoop.hbase.wal.WALSplitter.splitWAL(WALSplitter.java:427) at org.apache.hadoop.hbase.wal.TestWALSplit.doTestThreading(TestWALSplit.java:1035) at org.apache.hadoop.hbase.wal.TestWALSplit.testThreading(TestWALSplit.java:939) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.GeneratedMethodAccessor41.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.hbase.monitoring.TaskMonitor$PassthroughInvocationHandler.invoke(TaskMonitor.java:291) ... 32 more Caused by: java.lang.NullPointerException at org.apache.hadoop.hbase.monitoring.MonitoredTaskImpl.prettyPrintJournal(MonitoredTaskImpl.java:278) ... 36 more {noformat} In general, we do not set any null value in the code but the related data structutre are not thread safe and we use it in multi thread environment when splitting wal, so let's make it thread safe first." Bump hadoop version to 3.2.4,13476508,Resolved,Major,Fixed,12/Aug/22 06:23,30/Dec/24 14:38,,https://github.com/apache/hbase/security/dependabot/14 Add 2.5 Documentation to the website,13479496,Resolved,Major,Fixed,31/Aug/22 13:46,01/Sep/22 13:10,,"Following the example from HBASE-24487, will create PR for both the main repo and the hbase-site repo. Generating the site documentation from main repo, copy to site, as follows: {noformat} hbase $ git checkout rel/2.5.0 hbase $ mvn clean site site:stage -DskipTests hbase-site $ git checkout asf-site hbase-site $ cp -r ../hbase/target/staging ./2.5 hbase-site $ git add 2.5 {noformat} Then, update the site structure to include a reference to the new content, following https://github.com/apache/hbase/pull/2060" Add validation of request user and groups from TLS certificate,13478469,In Progress,Major,,24/Aug/22 17:48,,2.6.0,"When using mTLS for client authentication, we can allow the user to configure certain certificate fields as a means for validating the passed username on the ConnectionHeader. We can further look to inject groups for the user into the request context, which can be used for downstream authz in (for example) AuthManager/AccessChecker/etc. I would propose two new configs: {code:java} hbase.rpc.tls.certificate.username.oid When specified and TLS enabled, the client's SSL certificate will be inspected for an OID of this value. A value must be found and the value must match the username passed in the ConnectionHeader. For example, can be set to ""CN"" and we will use the CommonName of the certificate to validate the username. hbase.rpc.tls.certificate.group.oid When specified and TLS enabled, the client's SSL certificate will be inspected for OIDs of this value. If one or more values are found, they will be used as the user's groups for use in hbase authz. {code} I think this would only apply when AuthenticationMethod is SIMPLE (no kerberos)." The process and queue time metrics of read and write calls on the server side should be separated,13478329,Open,Major,,24/Aug/22 06:01,,2.5.3,The process time and queue time vary widely between read and write requests. We should seperate them to let the metrics be more accurate for requests. RegionServer should be aborted when WAL.sync throws TimeoutIOException,13472577,Resolved,Major,Fixed,21/Jul/22 03:15,07/Mar/24 15:12,3.0.0-alpha-4,"As HBASE-27223 said, if {{WAL.sync}} get a timeout exception, we should abort the region server, as the design of WAL sync, is to succeed or die, there is no 'failure'. It is usually not a big deal is because we set a very large default value(5 minutes) for {{AbstractFSWAL.WAL_SYNC_TIMEOUT_MS}}, usually the WAL system will abort the region server if it can not finish the sync within 5 minutes. In the PR, only the {{WAL.sync}} timeout in {{HRegion#doWALAppend}} ,regionServer is always aborted. For {{WALUtil.writeMarker}}, it is just record the internal state and seems it is no need to always abort the regionServer when {{WAL.sync}} timeout，it is the internal state transition that determines whether regionServer is aborted." Abort RS when the hostname is different from master seen,13478794,Resolved,Major,Fixed,26/Aug/22 10:44,29/Mar/23 07:02,2.5.3,"For HRegionServer#handleReportForDutyResponse, when the hostname is different from the regionserver and master side, both the two conditions should abort RS. {code:java} if ( !StringUtils.isBlank(useThisHostnameInstead) && !hostnameFromMasterPOV.equals(useThisHostnameInstead) ) { String msg = ""Master passed us a different hostname to use; was="" + this.useThisHostnameInstead + "", but now="" + hostnameFromMasterPOV; LOG.error(msg); throw new IOException(msg); } if ( StringUtils.isBlank(useThisHostnameInstead) && !hostnameFromMasterPOV.equals(rpcServices.getSocketAddress().getHostName()) ) { String msg = ""Master passed us a different hostname to use; was="" + rpcServices.getSocketAddress().getHostName() + "", but now="" + hostnameFromMasterPOV; LOG.error(msg); } {code}" Fix TestQuotaThrottle after HBASE-27046,13473635,Open,Major,,26/Jul/22 21:02,,,TestQuotaThrottle breaks monotonic WAL numbering after HBASE-20746 because of how it manipulates the EnvironmentEdge and was disabled by HBASE-27087. Fix the test. region.jsp shows incorrect size for split reference hfiles,13474192,Open,Major,,29/Jul/22 11:23,,,"When a region is split, the resulting daughter regions each refer back to original store files for the original region. When viewing the region.jsp page in the RegionServer UI, these show a size  of 0. This is because the region.jsp is directly checking the FileSystem length for the given storefile path, which isn't aware of references/links. We should be able to update region.jsp to call a variant of HStore.getStorefilesSize, which handles this complexity." Create admin/shell api for reloading just HMaster configs,13481298,Open,Major,,13/Sep/22 12:27,,,"We have {{update_config}} and {{{}update_all_config{}}}. The former can do an individual host (RS or HMaster), the latter does all hosts in the cluster.  If you just want to reload HMaster(s) you need to go into JMX metrics to find the tag.ServerName for each HMaster, and then paste that into individual update_config calls. We could either add a new {{update_hmaster_config}} or add an argument to the existing {{{}update_all_config 'hmaster'{}}}. Whatever way we go, we should add a corresponding method in Admin as well." Still seeing 'Stuck' in static initialization creating RegionInfo instance,13482595,Resolved,Major,Fixed,21/Sep/22 14:14,04/Oct/22 12:33,,"See https://issues.apache.org/jira/browse/HBASE-24896 for the original description. Despite having that fix, we are seeing this issue in a 2.4.6-based deploy. We recently started seeing it as we were moving to centos8. I'm not sure why the centos version would affect this, otherwise the hbase server version and java versions were not changing. We're seeing this in a non-trivial number of new centos8 servers that we spin up. I'm pushing a hotfix which removes RegionInfo.UNDEFINED to see if that resolves our issue. As mentioned in my last comments on that jira, it could be that this field is still an issue because according to [https://stackoverflow.com/questions/28631656/runnable-thread-state-but-in-object-wait:] > Such deadlocks may be caused by a [typical bug|https://bugs.openjdk.org/browse/JDK-8037567] when a subclass is referenced from a static initializer. If that's true, in this case MutableRegionInfo is a subclass/implementer of RegionInfo, so that could trigger it. Granted the linked bug is marked ""Not An Issue""." Downgrade ERROR log to DEBUG in ConnectionUtils.updateStats,13483224,Resolved,Major,Fixed,26/Sep/22 14:54,28/Sep/22 15:40,,"This method logs with ERROR level if the MultiResponse does not include RegionLoadStats. These stats may be disabled on the server side, and really this doesn't seem like an error state. We should downgrade to DEBUG since it's an optional feature that is not enabled by default." Make slow log configs updatable with configuration observer,13473878,Resolved,Major,Fixed,27/Jul/22 23:52,15/Dec/22 22:56,,"It would be very useful to be able to turn slow log on or off, change thresholds, etc on demand as needed when diagnosing a traffic issue. Should be a simple matter of moving the configs into RpcServer#onConfigurationChange" Read blocks into off-heap if caching is disabled for read,13473137,Resolved,Major,Fixed,24/Jul/22 19:21,21/Dec/22 18:33,,"Currently we decide whether a disk read {{shouldUseHeap}} based on three criteria: # If block cache is disabled, return false # If block cache is anything other than CombinedBlockCache, return true # Otherwise return false for DATA blocks and true for other blocks The assumption here is we're making the decision based on which cache the block is likely to end up in. But if the read has caching disabled (i.e. setCacheBlocks(false)), it won't get into any cache. So we should return false in that case too. The only caller to {{shouldUseHeap}} in HFileReaderImpl has a boolean {{cacheBlock}} available which determines if the read block should attempt to be cached. We can pass that boolean into the function. We should probably also account for cacheConf.shouldCacheBlockOnRead for the same reason.  " HFile tool statistic sampling produces misleading results,13472277,Resolved,Major,Fixed,19/Jul/22 13:20,06/Sep/22 19:42,,"HFile tool uses codahale metrics for collecting statistics about key/values in an HFile. We recently had a case where the statistics printed out that the max row size was only 25k. This was confusing because I was seeing bucket cache allocation failures for blocks as large as 1.5mb.  Digging in, I was able to find the large row using the ""-p"" argument (which was obviously very verbose). Once I found the row, I saw the vlen was listed as ~1.5mb which made much more sense. First thing I notice here is that default codahale metrics histogram is using ExponentiallyDecayingReservoir. This probably makes sense for a long-lived histogram, but the HFile tool is run at a point in time. It might be best to use UniformReservoir instead. Secondly, we do not need sampling for min/max. Let's supplement the histogram with our own calculation which is guaranteed to be accurate for the entirety of the file." [hbase-thirdparty] Add nimbus-jose-jwt library to hbase-shaded-miscellaneous,13478844,Resolved,Major,Won't Fix,26/Aug/22 15:32,10/Apr/24 20:56,,Required for OAuthBearer SASL auth plugin to work properly. Persist list of Hfiles names for which prefetch is done,13478048,Resolved,Major,Fixed,22/Aug/22 16:04,21/Mar/23 14:37,3.0.0-alpha-3,"Persist list of Hfiles names for which prefetch is completed when persist for in-memory bucket cache mapping state is enabled. We need to persist the Set, which contains a list of all the HFiles for which the prefetch has completed along with the In-memory state of the bucket cache so that when we restart and if any prefetch is scheduled again for the same HFile and we already have the in-memory state retrieved, we can skip the prefetch for it." Update create-release to work with maven-gpg-plugin-3.0.1 and gnupg >= 2.1.x,13478044,Resolved,Major,Fixed,22/Aug/22 15:40,09/Nov/22 13:34,,"I've run into some trouble with `create-release`. The issue seems to come down to changes to maven-release-plugin via MGPG-79 and working with the `agent-extra-socket`. After MGPG-79, maven-release-plugin uses `--pinentry-mode error` in a non-interactive setting, which is not permissible over the restricted permissions exposed via `agent-extra-socket`." Introduce prefix tree index block encoding use less space,13478639,Open,Major,,25/Aug/22 12:20,,,"This index block encoding which use less space than the current implementation. Index block use it not data block." Auto merging small stripes in StripeCompactionPolicy,13478380,Open,Major,,24/Aug/22 10:01,,2.4.13,"Currently, stripes merge only happens when two stripes are empty, but that is not enough. With the data appending the stripes splits by splits, but with the data deleting, stripes might become smaller size while the stripes count is large.  Auto merging small stripes can help to reduce the file count in the store and improve read effiecency. " Support to take the initiative to compact cold large files and compression diff hfiles after changing storefile compression algrithm ,13478378,Open,Major,,24/Aug/22 09:54,,2.4.13,"We can set switch to enable this feature, to make the compression algrithm changes be applied to all the existing store files, especially when we make a lower space usage compression algrithm change, e.g. from LZO to ZSTD can save more than 30% spaces. All the compaction policies should support this feature." Clean up error-prone findings,13471471,In Progress,Major,,13/Jul/22 20:24,,,It's time to do another sweep over error-prone findings. Umbrella for module-by-module work as subtasks. Clean up error-prone findings in hbase-mapreduce,13473883,Open,Major,,28/Jul/22 00:50,,, Add cost function in balancer to consider the cost of building bucket cache before moving regions,13482969,Reopened,Major,,23/Sep/22 16:16,,,"HBase currently uses StochasticLoadBalancer to determine the cost of moving the regions from one RS to another. Each cost functions give a result between 0 and 1, with 0 being the lowest cost and 1 being the cost. The balancer iterates through each cost function and comes up with the total cost. Now, the balancer will create multiple balancing plans on random actions and try to compute the cost of each plan as if they are executed, if the cost of the plan is less than the initial cost, the plan is executed. Implement a new ""CacheAwareCostFunction"" which takes into account if the region is fully cached and return the highest cost if the plan suggests moving this region." Reduce reflection overhead in Filter deserialization,13475447,Resolved,Major,Fixed,05/Aug/22 14:22,10/Nov/23 14:19,,"Running hbase 2.4.x, I recently profiled one of our clusters which does a very high volume of random reads. An astonishing 12% of CPU time was just spent deserializing in ProtobufUtil.toFilter. One immediate thought would be to cache String -> Class mappings. Currently Class.forName shows up multiple times (6 in my example) in the profile, each time taking over 1%. I think this is partially due to using FilterList in this example.  " The servername in the rsgroup table should be lowercase,13473326,Open,Major,,25/Jul/22 13:27,,2.4.13,"In HBASE-13995 and HBASE-24395, both mention that ServerName.getHostname() is case sensitive.    Now the move_servers_rsgroup is still case sensitive. Servername is displayed in lowercase on the master ui, but uppercase is stored in the rsgroup table. I think the master ui should be consistent with the rsgroup table. !27237.png!  " Cluster completely down due to WAL splitting failing for hbase:meta table.,13482643,Resolved,Major,Won't Fix,21/Sep/22 19:30,11/Oct/23 18:38,1.7.2,"We are running some version of 1.7.2 in our production environment. We encountered this issue recently. We colocate namenode and region server holding hbase:meta table on a set of 5 master nodes. Co-incidentally active namenode and region server holding meta table were on the same physical node and that node went down due to hardware issue. We have sub optimal hdfs level timeouts configured so whenever active namenode goes down, it takes around 12-15 minutes for hdfs client within hbase to connect to new active namenode. So all the region servers were having problems for about 15 minutes to connect to new active namenode. Below are the sequence of events: 1. Host running active namenode and hbase:meta went down at +2022-09-09 16:56:56,878+ 2. HMaster started running ServerCrashProcedure at +2022-09-09 16:59:05,696+ {noformat} 2022-09-09 16:59:05,696 DEBUG [t-processor-pool2-t1] procedure2.ProcedureExecutor - Procedure ServerCrashProcedure serverName=,61020,1662714013670, shouldSplitWal=true, carryingMeta=true id=1 owner=dummy state=RUNNABLE:SERVER_CRASH_START added to the store. 2022-09-09 16:59:05,702 DEBUG [t-processor-pool2-t1] master.ServerManager - Added=,61020,1662714013670 to dead servers, submitted shutdown handler to be executed meta=true 2022-09-09 16:59:05,707 DEBUG [ProcedureExecutor-0] master.DeadServer - Started processing ,61020,1662714013670; numProcessing=1 2022-09-09 16:59:05,712 INFO [ProcedureExecutor-0] procedure.ServerCrashProcedure - Start processing crashed ,61020,1662714013670 {noformat} 3. SplitLogManager created 2 split log tasks in zookeeper. {noformat} 2022-09-09 16:59:06,049 INFO [ProcedureExecutor-1] master.SplitLogManager - Started splitting 2 logs in [hdfs:///hbase/WALs/,61020,1662714013670-splitting] for [,61020,1662714013670] 2022-09-09 16:59:06,081 DEBUG [main-EventThread] coordination.SplitLogManagerCoordination - put up splitlog task at znode /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta 2022-09-09 16:59:06,093 DEBUG [main-EventThread] coordination.SplitLogManagerCoordination - put up splitlog task at znode /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662739251611.meta {noformat} 4. The first split log task is more interesting: +/hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta+ 5. Since all the region servers were having problems connecting to active namenode, SplitLogManager tried total of 4 times to assign this task (3 resubmits, configured by hbase.splitlog.max.resubmit) and then finally gave up. {noformat} ---------- try 1 --------------------- 2022-09-09 16:59:06,205 INFO [main-EventThread] coordination.SplitLogManagerCoordination - task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta acquired by ,61020,1662540522069 ---------- try 2 --------------------- 2022-09-09 17:01:06,642 INFO [ager__ChoreService_1] coordination.SplitLogManagerCoordination - resubmitting task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta 2022-09-09 17:01:06,666 DEBUG [main-EventThread] coordination.SplitLogManagerCoordination - task not yet acquired /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta ver = 2 2022-09-09 17:01:06,715 INFO [main-EventThread] coordination.SplitLogManagerCoordination - task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta acquired by ,61020,1662530684713 ---------- try 3 --------------------- 2022-09-09 17:03:07,643 INFO [ager__ChoreService_1] coordination.SplitLogManagerCoordination - resubmitting task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta 2022-09-09 17:03:07,687 DEBUG [main-EventThread] coordination.SplitLogManagerCoordination - task not yet acquired /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta ver = 4 2022-09-09 17:03:07,738 INFO [main-EventThread] coordination.SplitLogManagerCoordination - task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta acquired by ,61020,1662542355806 ---------- try 4 --------------------- 2022-09-09 17:05:08,684 INFO [ager__ChoreService_1] coordination.SplitLogManagerCoordination - resubmitting task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta 2022-09-09 17:05:08,717 DEBUG [main-EventThread] coordination.SplitLogManagerCoordination - task not yet acquired /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta ver = 6 2022-09-09 17:05:08,757 INFO [main-EventThread] coordination.SplitLogManagerCoordination - task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta acquired by ,61020,1662543537599 ------- after all retries exhausted --------- 2022-09-09 17:07:09,642 INFO [ager__ChoreService_1] coordination.SplitLogManagerCoordination - Skipping resubmissions of task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta because threshold 3 reached {noformat} 6. After it exhausts all the retries, HMaster now will wait indefinitely for to complete the splitting. In this case the last region server died and hmaster couldn't assign hbase:meta table to any other region server. 7. We failed over the active hmaster and then the new active hmaster was able to successfully assign hbase:meta to another region server. Looking at the last region server logs () It acquired the task of splitting log at +2022-09-09 17:05:08,732+ and got aborted at +2022-09-09 17:10:12,151+ SplitLogWorker thread was terminated as a part of termination process. {noformat} 2022-09-09 17:05:08,732 INFO [-:61020] coordination.ZkSplitLogWorkerCoordination - worker ,61020,1662543537599 acquired task /hbase/splitWAL/WALs%2F%2C61020%2C1662714013670-splitting%2F%252C61020%252C1662714013670.meta.1662735651285.meta 2022-09-09 17:10:12,151 FATAL [,queue=21,port=61020] regionserver.HRegionServer - ABORTING region server ,61020,1662543537599: WAL sync failed, aborting to preserve WAL as source of truth 2022-09-09 17:10:12,185 INFO [-:61020] regionserver.SplitLogWorker - SplitLogWorker interrupted. Exiting. {noformat} +Possible Improvements+ 1. Can we remove the maximum number of retries config hbase.splitlog.max.resubmit if table is hbase:meta table or for all the tables ? 2. If HMaster is not able to assign split wal tasks after hbase.splitlog.max.resubmit retries, then should we just self abort ? Any other suggestions are welcome. " FSHLog should retry writing WAL entries when syncs to HDFS failed.,13472579,Resolved,Major,Fixed,21/Jul/22 03:32,13/Jul/23 13:34,3.0.0-alpha-4,"Just as HBASE-27223 said, basically, if the {{WAL}} write to HDFS fails, we do not know whether the data has been persistent or not. The implementation for {{AsyncFSWAL}}, is to open a new writer and try to write the WAL entries again, and then adding logic in WAL split and replay to deal with duplicate entries. But for {{FSHLog}}, it does not have the same logic with {{AsyncFSWAL}}, when {{ProtobufLogWriter.append}} and {{ProtobufLogWriter.sync}} failed, {{FSHLog.sync}} immediately throws the exception thrown by {{ProtobufLogWriter.append}} and {{ProtobufLogWriter.sync}} , we should implement the same retry logic as {{AsyncFSWAL}}, so {{WAL.sync}} could only throw {{TimeoutIOException}} and we could uniformly abort the RegionServer when {{WAL.sync}} failed. The basic idea is because both {{FSHLog.RingBufferEventHandler}} and {{AsyncFSWAL.consumeExecutor}} are single-thread, we could reuse the logic in {{AsyncWAL}} and move the most code in {{AsyncWAL}} upward to {{AbstractFSWAL}} , and just adapting the {{SyncRunner}} in {{FSHLog}} to the logic in {{AsyncWriter.sync}}. Once we do that, most logic in {{AsyncWAL}} and {{FSHLog}} are unified, just how to sync the {{writer}} is different." [hbase-connectors] Add checkstyle check in hbase-connectors pre commit build,13469968,Open,Major,,04/Jul/22 13:38,,, [hbase-connectors] Add spotless plugin to format code (including scala code),13469969,Resolved,Major,Fixed,04/Jul/22 13:39,16/Aug/23 10:45,, [hbase-connectors] Fail to build hbase-connectors because of checkstyle error,13469963,Resolved,Major,Fixed,04/Jul/22 13:22,02/Aug/23 07:59,,"We set failOnViolation to true but in pre commit, we will use ""-Dcheckstyle.skip=true"" when running mvninstall so we can not find the problem in pre commit, but when we run 'mvn install' locally, the build will fail." Implement the new replication hfile/log cleaner,13471920,Resolved,Major,Fixed,17/Jul/22 14:36,31/Aug/22 13:26,, Add a new procedure type for implementing some global operations such as migration,13483240,Resolved,Major,Fixed,26/Sep/22 15:53,29/Sep/22 02:28,,"When implementing HBASE-27218, I need to implement a special procedure for migrating the replication queue data, but there is no support for this type of procedure, we only support server/table/peer, but this procedure can not fit any of them. So let's implement a new type of procedure." Client connection warming API,13472498,Open,Major,,20/Jul/22 15:15,,,"In a high performance API or low latency stream workers, you often do not want to incur costs on the first few requests. In these cases, you want to warm connections before ever adding to the load balancer or processing group. Upon first creating a Connection, there are two areas that can slow down the first few requests: * Fetching region locations * Creating the initial connection to each RegionServer, which sends connection headers, possibly does auth handshakes, etc. A user can easily work around the first slowness by calling Table.getRegionLocator().getAllRegionLocations(). It's more challenging for a user to warm the actual RegionServer connections. One way we have done this is to use a RegionLocator to fetch all locations for a table, reduce that down to 1 region per server, and then issue a Get to each row. We end up repeating this for every table that a process may connect to, because at the level we do this we can't easily tell which servers have already been warmed. We also have run into various bugs over time, for example where an empty startkey causes a Get to fail. We can make this easier for the users by providing an API which uses Connection internals to as cheaply as possible warm these connections. I'd propose we add the following: New Table/AsyncTable method {{{}warmConnections(){}}}. This would do the following: * use region locator to fetch all locations (with caching) * reduce returned locations to unique ServerNames * for each ServerName (with lock): ** if already warmed, skip ** otherwise, get a connection to that server and send an initial request to trigger socket creation/connection header/etc With this API, if someone is connecting to multiple tables, they could warm each of them Table in parallel and we'd only create connections to each server once. " TestRaceBetweenSCPAndTRSP fails in pre commit,13475552,Resolved,Major,Fixed,06/Aug/22 15:48,23/May/23 15:00,,"Seems the PE worker is stuck here. Need dig more. {noformat} ""PEWorker-5"" daemon prio=5 tid=326 in Object.wait() java.lang.Thread.State: WAITING (on object monitor) at java.base@11.0.10/jdk.internal.misc.Unsafe.park(Native Method) at java.base@11.0.10/java.util.concurrent.locks.LockSupport.park(LockSupport.java:194) at java.base@11.0.10/java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:885) at java.base@11.0.10/java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1039) at java.base@11.0.10/java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly(AbstractQueuedSynchronizer.java:1345) at java.base@11.0.10/java.util.concurrent.CountDownLatch.await(CountDownLatch.java:232) at app//org.apache.hadoop.hbase.master.assignment.TestRaceBetweenSCPAndTRSP$AssignmentManagerForTest.getRegionsOnServer(TestRaceBetweenSCPAndTRSP.java:97) at app//org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.getRegionsOnCrashedServer(ServerCrashProcedure.java:288) at app//org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.executeFromState(ServerCrashProcedure.java:195) at app//org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.executeFromState(ServerCrashProcedure.java:66) at app//org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188) at app//org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:919) at app//org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1650) at app//org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1396) at app//org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1000(ProcedureExecutor.java:75) at app//org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:1962) at app//org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread$$Lambda$477/0x0000000800ac1840.call(Unknown Source) at app//org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) at app//org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:1989) {noformat}" Re-enable the disabled tests when implementing HBASE-27212,13475410,Resolved,Major,Fixed,05/Aug/22 12:51,18/Apr/23 13:52,,"For landing the first basic framework of the new replication queue storage implementation, we have to disable several UTs. This issue is used to track these tests to make sure we finally re-enabled them all." Revisit the ReplicationSyncUp tool,13471922,Resolved,Major,Fixed,17/Jul/22 14:37,18/Mar/23 13:39,, Revisit the DumpReplicationQueues tool,13471923,Resolved,Major,Fixed,17/Jul/22 14:38,13/Nov/22 14:04,, Support rolling upgrading,13471924,Resolved,Major,Fixed,17/Jul/22 14:39,06/Nov/22 08:58,, Add support for sync replication,13471921,Resolved,Major,Fixed,17/Jul/22 14:37,15/Sep/22 14:44,, Add support for claim queue operation,13471919,Resolved,Major,Fixed,17/Jul/22 14:35,20/Aug/22 15:11,, Implement a new table based replication queue storage and make the minimum replication system work,13471918,Resolved,Major,Fixed,17/Jul/22 14:33,15/Aug/22 02:47,,"This is the start point. The plan is to introduce the new table based replication queue storage implementation, and make simple replication work, no failure recovery, no claim queue, no wal cleaner, etc. The related UTs will be disabled until we finally cover the area in later issues." Make index block be customized and configured,13478108,Resolved,Major,Fixed,23/Aug/22 02:42,11/Oct/22 02:25,,"Current the index block use a flat structure and can not support other format, we can explore other structure to use it like the data block encoding." [JDK17] Add-opens java.util,13480110,Resolved,Major,Won't Do,05/Sep/22 10:39,17/Feb/23 07:03,,"Should add-opens _java.base/java.util_ or UT failed under JDK17: {code:java} [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.404 s <<< FAILURE! - in org.apache.hadoop.hbase.client.TestImmutableScan [ERROR] org.apache.hadoop.hbase.client.TestImmutableScan.testScanCopyConstructor  Time elapsed: 0.273 s  <<< ERROR! java.lang.reflect.InaccessibleObjectException: Unable to make field private static final long java.util.Collections$UnmodifiableMap.serialVersionUID accessible: module java.base does not ""opens java.util"" to unnamed module @18be83e4     at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)     at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)     at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)     at java.base/java.lang.reflect.AccessibleObject.setAccessible(AccessibleObject.java:130)     at org.apache.commons.lang3.builder.EqualsBuilder.reflectionAppend(EqualsBuilder.java:576)     at org.apache.commons.lang3.builder.EqualsBuilder.reflectionAppend(EqualsBuilder.java:537)     at org.apache.commons.lang3.builder.EqualsBuilder.reflectionEquals(EqualsBuilder.java:460)     at org.apache.commons.lang3.builder.EqualsBuilder.reflectionEquals(EqualsBuilder.java:408)     at org.apache.commons.lang3.builder.EqualsBuilder.reflectionEquals(EqualsBuilder.java:347)     at org.apache.hadoop.hbase.client.TestImmutableScan.compareGetters(TestImmutableScan.java:351)     at org.apache.hadoop.hbase.client.TestImmutableScan.testScanCopyConstructor(TestImmutableScan.java:113)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.base/java.lang.reflect.Method.invoke(Method.java:568)     at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)     at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)     at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)     at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)     at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)     at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)     at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)     at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)     at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)     at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)     at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)     at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)     at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)     at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)     at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)     at java.base/java.lang.Thread.run(Thread.java:833) {code}" Long running heavily filtered scans hold up too many ByteBuffAllocator buffers,13472496,Resolved,Major,Won't Do,20/Jul/22 14:55,30/Jan/23 18:31,,"We have a workload which is launching long running scans searching for a needle in a haystack. They have a timeout of 60s, so are allowed to run on the server for 30s. Most of the rows are filtered, and the final result is usually only a few kb. When these scans are running, we notice our ByteBuffAllocator pool usage goes to 100% and we start seeing 100+ MB/s of heap allocations. When the scans finish, the pool goes back to normal and heap allocations go away. My working theory here is that we are only releasing ByteBuff's once we call {{shipper.shipped(),}} which only happens once a response is returned to the user. This works fine for normal scans which are likely to quickly find enough results to return, but for long running scans in which most of the results are filtered we end up holding on to more and more buffers until the scan finally returns. We should consider whether it's possible to release buffers for blocks whose cells have been completely skipped by a scan.  " Backport Backup/Restore to 2.x,13473336,Resolved,Major,Fixed,25/Jul/22 14:16,24/Jan/23 00:55,,Backport backup/restore to 2.x branch.  getClusterMetrics NullPointerException when ServerTask status null,13482989,Resolved,Major,Fixed,24/Sep/22 00:00,15/Dec/22 17:06,,"We had a situation where an hmaster had just started up and something started calling Admin.getClusterMetrics. It seems there were ServerTasks in memory, but at least one had no status. This resulted in a spam of NPE: {code:java} [RpcServer.default.FPBQ.Fifo.handler=29,queue=2,port=60000] ERROR org.apache.hadoop.hbase.ipc.RpcServer: Unexpected throwable object java.lang.NullPointerException at org.apache.hadoop.hbase.shaded.protobuf.generated.ClusterStatusProtos$ServerTask$Builder.setStatus(ClusterStatusProtos.java:14352) at org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toServerTask(ProtobufUtil.java:3565) at org.apache.hadoop.hbase.ClusterMetricsBuilder.lambda$toClusterStatus$4(ClusterMetricsBuilder.java:80) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) at org.apache.hadoop.hbase.ClusterMetricsBuilder.toClusterStatus(ClusterMetricsBuilder.java:80) at org.apache.hadoop.hbase.master.MasterRpcServices.getClusterStatus(MasterRpcServices.java:980) at org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java) at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:385) at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:102) at org.apache.hadoop.hbase.ipc.RpcHandler.run(RpcHandler.java:82) {code}" Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections,13479303,Resolved,Major,Fixed,30/Aug/22 12:05,28/Nov/22 14:20,3.0.0-alpha-3,As a follow-up feature I'd like to port the file watcher functionality from ZooKeeper in order to avoid restarts when keystore/truststore is updated on a running cluster. Publish binaries and maven artifacts for both hadoop2 and hadoop3,13480311,Resolved,Major,Fixed,06/Sep/22 15:48,05/Dec/22 04:06,,"As per the discussion in this thread https://lists.apache.org/thread/y05gspk4mnxsz6nk7hc5ots8wt50366b And this is possible after we land HBASE-27340." Add config for setting a max actions per normalizer run,13483892,Resolved,Major,Duplicate,29/Sep/22 18:14,18/Nov/22 18:31,,"When you enable the normalizer for the first time on an existing table, the next time it runs it can do a massive amount of merges/splits. This can be painful for callers. Additionally, if someone were to write a large amount of Puts or Deletes it may cause a merge/split storm as well. We should add a config which allows operators to limit the amount of actions per run. This way the normalizer can work towards its plan gracefully over the course of a few hours rather than all at once." Avoid synchronization in AsyncFSWAL,13480187,Patch Available,Major,,06/Sep/22 03:08,,3.0.0-alpha-3,"{{AsyncFSWAL}} uses {{consumeLock}} to synchronize operations between {{AsyncFSWAL.consumeExecutor}} and {{AsyncFSWAL.doReplaceWriter}} (also {{AsyncFSWAL.doShutdown}}), I think we could further use the event-driven approach again to eliminate the {{consumeLock}}: * For {{AsyncFSWAL.doReplaceWriter}} ,it could just publish the request for replacing writer event to {{AsyncFSWAL}} and wait for the event to complete. * For {{AsyncFSWAL.consumeExecutor}} ,it could detect the replacing writer event at its safe point (i.e. writer is broken or no {{FSWALEntry}} to write) and executes replacing writer event by itself, and after it completes , it notifies {{LogRoller}} thread that the event is completed. Replacing writer is a very lightweight operation and only replacing writer is completed, {{AsyncFSWAL.consumeExecutor}} could continue to write WAL, so it is harmless for {{AsyncFSWAL.consumeExecutor}} and could avoid using consumeLock. The main difference between the PR and the current implementation is {{AsyncFSWAL.consumeExecutor}} replacing the writer by itself." EOF thrown by WALEntryStream causes replication blocking,13479654,Open,Major,,01/Sep/22 11:17,,2.4.14,"In [WALEntryStream#readNextEntryAndRecordReaderPosition|https://github.com/apache/hbase/blob/308cd729d23329e6d8d4b9c17a645180374b5962/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java#L257], it is possible that we read uncommitted data.  If we read beyond the committed file length, then reopen inputStream and seek back. In our use, we found that the position where seek back may be exactly the length of the file being written, which may cause EOF. The thrown EOF is finally caught [ReplicationSourceWALReader.run|https://github.com/apache/hbase/blob/308cd729d23329e6d8d4b9c17a645180374b5962/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L158], but [totalBufferUsed|https://github.com/apache/hbase/blob/308cd729d23329e6d8d4b9c17a645180374b5962/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java#L78] is not cleanup up. After a long run, all peers will go slow and eventually block completely." Upgrade reload4j due to XXE vulnerability,13473393,Resolved,Major,Fixed,25/Jul/22 19:27,26/Jul/22 18:39,2.4.13,https://github.com/qos-ch/reload4j/issues/53 fixed in reload4j 1.2.22 "when “hbase.regionserver.logroll.period” is set to a negative number, Log cannot run normally",13478980,Open,Major,,28/Aug/22 14:38,,,"In hbase- default.xml {code:java}    hbase.regionserver.logroll.period    3600000    Period at which we will roll the commit log regardless   of how many edits it has.  {code} Taking hbase.regionserver.logroll.period set to -1 in hbase-site.xml as an example, it is normal to start hbase. However, {*}there are a large number of repeated wal rolling operation records in the log file{*}. {code:java} 2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156 with entries=0, filesize=83 B; new WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167 2022-08-06 15:39:37,172 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Archiving file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156 to file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577156 2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta with entries=0, filesize=83 B; new WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta 2022-08-06 15:39:37,177 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Archiving file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta to file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577160.meta 2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167 with entries=0, filesize=83 B; new WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177 2022-08-06 15:39:37,182 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Archiving file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167 to file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577167 2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta with entries=0, filesize=83 B; new WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta 2022-08-06 15:39:37,188 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Archiving file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta to file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577172.meta 2022-08-06 15:39:37,196 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177 with entries=0, filesize=83 B; new WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577188 2022-08-06 15:39:37,197 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Archiving file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177 to file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.1659771577177 2022-08-06 15:39:37,201 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Rolled WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta with entries=0, filesize=83 B; new WAL /home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577197.meta 2022-08-06 15:39:37,201 INFO  [regionserver/xmw1-kb310-65:16020.logRoller] wal.AbstractFSWAL: Archiving file:/home/xmw/hbase-2.2.2/hbase-tmp/WALs/xmw1-kb310-65,16020,1659771570212/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta to file:/home/xmw/hbase-2.2.2/hbase-tmp/oldWALs/xmw1-kb310-65%2C16020%2C1659771570212.meta.1659771577182.meta{code} When using the service, it works fine and close normally. According to the above phenomenon, we believe that the phenomenon is related to the WAL rolling of regionserver. After code review, we found that in the constructor of hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java. After reading the configuration item hbase.regionserver.logroll.period, {*}it is not checked whether the value is normal{*}. In the subsequent run() function, the current time is directly compared to the last rollback time with hbase.regionserver.logroll.period to determine whether to perform the WAL rollback operation, so that no matter what the current time is, The rollback operation will be performed, {*}resulting in a large number of records in the LOG{*}, *and it is very likely to occupy too many resources. And no prompt message appears to remind us of the problem.* Therefore, we propose to {*}add the judgment of hbase.regionserver.logroll.period on the constructor of LogRoller{*}. If the parameter LogRoller.rollPeriod affected by this configuration item is less than zero, an error message will be output and he relevant exception can be thrown.  This way, if the hbase.regiononserver.logroll.period is less than 0, an exception can be thrown and an error message logged, stopping the log from having a large number of duplicate wal roll operation records.      " Minimise block addition failures due to no space in bucket cache writers queue by introducing wait time,13481164,Resolved,Major,Fixed,12/Sep/22 17:39,04/Oct/22 23:06,3.0.0-alpha-3,"Currently in bucket cache asynchronous caching mechanism introduced where initially the blocks to be cached will be added to queue and writer threads consume the blocks from the queue and write to bucket cache. In case if block writing to bucket cache is slow then there is a chance that queue of writer threads become full and following block additions will be failed. In case of slower storages like s3 might introduce latencies even if we enable bigger sizes of bucket cache using ephemeral storages. So we can allow configurable wait time while adding blocks to queue so that chances of queue free up is possible during the wait time and block addition failures can be minimised. To avoid the performance impact of wait time in regular read paths we can use the wait time mainly during background operations like compactions, flushes or prefetches etc." "Frequent and not useful ""Final timeLimitDelta"" log lines",13483288,Resolved,Major,Fixed,27/Sep/22 00:30,27/Sep/22 00:55,2.4.14,"Introduced by HBASE-27205 Fix tests that rely on EnvironmentEdgeManager in branch-2.4.  This line should be removed: https://github.com/apache/hbase/blob/e25b2a7cd0b0daddad5ab09a87cd7ed9f59c81b6/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L3236" Avoid decompressing blocks when reading from bucket cache prefetch threads ,13481380,Resolved,Major,Fixed,13/Sep/22 20:29,20/Sep/22 13:38,3.0.0-alpha-4,"When prefetching blocks into bucket cache, we had observed a consistent CPU usage around 70% with no other workloads ongoing. For large bucket caches (i.e. when using file based bucket cache), the prefetch can last for sometime and having such a high CPU usage may impact the database usage by client applications. Further analysis of the prefetch threads stack trace showed that very often, decompress logic is being executed by these threads: {noformat} ""hfile-prefetch-1654895061122"" #234 daemon prio=5 os_prio=0 tid=0x0000557bb2907000 nid=0x406d runnable [0x00007f294a504000]    java.lang.Thread.State: RUNNABLE         at org.apache.hadoop.io.compress.snappy.SnappyDecompressor.decompressBytesDirect(Native Method)         at org.apache.hadoop.io.compress.snappy.SnappyDecompressor.decompress(SnappyDecompressor.java:235)         at org.apache.hadoop.io.compress.BlockDecompressorStream.decompress(BlockDecompressorStream.java:88)         at org.apache.hadoop.io.compress.DecompressorStream.read(DecompressorStream.java:105)         at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)         at java.io.BufferedInputStream.read(BufferedInputStream.java:345)         - locked <0x00000002d24c0ae8> (a java.io.BufferedInputStream)         at org.apache.hadoop.hbase.io.util.BlockIOUtils.readFullyWithHeapBuffer(BlockIOUtils.java:105)         at org.apache.hadoop.hbase.io.compress.Compression.decompress(Compression.java:465)         at org.apache.hadoop.hbase.io.encoding.HFileBlockDefaultDecodingContext.prepareDecoding(HFileBlockDefaultDecodingContext.java:90)         at org.apache.hadoop.hbase.io.hfile.HFileBlock.unpack(HFileBlock.java:650)         at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(HFileReaderImpl.java:1342) {noformat} This is because *HFileReaderImpl.readBlock* is always decompressing blocks even when *hbase.block.data.cachecompressed* is set to true. This patch proposes an alternative flag to differentiate prefetch from normal reads, so that doesn't decompress DATA blocks when prefetching with *hbase.block.data.cachecompressed* set to true. " Update java versions in our Dockerfiles,13481440,Resolved,Major,Fixed,14/Sep/22 07:06,19/Sep/22 09:32,, Fix new spotbugs warnings after upgrading spotbugs to 4.7.2,13481590,Resolved,Major,Fixed,15/Sep/22 00:26,19/Sep/22 04:02,, Do not need to throw IllegalStateException when peer is not active in ReplicationSource.initialize,13481323,Resolved,Major,Fixed,13/Sep/22 14:51,15/Sep/22 07:51,,"The only place where we can reset the sourceRunning flag to false is in terminate method, where we want to stop the replication source. And we already have a interrupted state check in the initialize method to not throw IllegalStateException when peer is terminating, so I think here we could just do not throw IllegalStateExeption at all. The reason why the interrupted state check does not work is that, in FutureUtils.get, we will wrap InterruptedException with InterruptedIOException, without restoring the interrupted state, but the upper layer does not treat InterruptedIOException specially so the interrupted state is lost. But anway, I do not think we should rely on the interrupted state to determine whether we should abort the region server..." Bump spotbugs version,13481436,Resolved,Major,Fixed,14/Sep/22 06:40,14/Sep/22 15:35,,"Recently there are strange spotbugs failures in pre commit builds, likely to be a false positive. https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4779/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html Let's see if upgrading the spotbugs version can solve the problem." Update ref guide about the 2.5.x release line,13479121,Resolved,Major,Fixed,29/Aug/22 14:14,17/Oct/22 10:53,,"The hadoop support matrix, release manager, etc." Add dead region server to SplitLogManager#deadWorkers set as the first step.,13482649,Open,Major,,21/Sep/22 20:54,,1.7.2,"Currently we add a dead region server to +SplitLogManager#deadWorkers+ set in SERVER_CRASH_SPLIT_LOGS state. Consider a case where a region server is handling split log task for hbase:meta table and SplitLogManager has exhausted all the retries and won't try any more region server. The region server which is handling split log task has died. We have a check in SplitLogManager where if a region server is declared dead and if that region server is responsible for split log task then we forcefully resubmit split log task. See the code [here|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java#L721-L726]. But we add a region server to SplitLogManager#deadWorkers set in [SERVER_CRASH_SPLIT_LOGS|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L252] state. Before that it runs [SERVER_CRASH_GET_REGIONS|https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L214] state and checks if hbase:meta table is up. In this case, hbase:meta table was not online and that prevented SplitLogManager to add this RS to deadWorkers list. This created a deadlock and hbase cluster was completely down for an extended period of time until we failed over active hmaster. See HBASE-27382 for more details. Improvements: 1. We should a dead region server to +SplitLogManager#deadWorkers+ list as the first step. " Document native TLS support in Netty RPC,13472452,Resolved,Major,Fixed,20/Jul/22 10:38,08/Sep/22 17:14,,"Add a new section to the HBase book on how a developer can get this going. Should include * relevant TLS properties added in X509Util.java which need to be added to hbase-site.xml * how to generate a self-signed CA and certs using {{{}keytool{}}}/{{{}openssl{}}} * any known limitations" Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores,13479099,Resolved,Major,Fixed,29/Aug/22 12:24,01/Sep/22 08:06,,"Based on a discussion in the TLS Jira and mailing list, it would be beneficial to protect the password of trust and key stores for TLS encryption support in Netty RPC. Hadoop Credentials API is built for the same purpose, extensible and simple to use: [https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/CredentialProviderAPI.html]  " LogLevel.Servlet not working in 2.5.0,13483452,Resolved,Major,Not A Problem,27/Sep/22 12:44,27/Sep/22 13:42,2.5.0,"I'm upgrading our servers to hbase 2.5.0 and noticed that the LogLevel.Servlet no longer works. I am guessing this is due to the log4j2 change. According to the servlet output, it sees log class as {{org.slf4j.impl.Log4jLoggerAdapter}} but the log levels seem totally disconnected from reality — setting a log level has no effect, and checking the loglevel of a logger that i had configured in my log4j.properties shows the wrong value. Logging itself seems to be using my log4j.properties correctly, but the LogLevel.Servlet sees and sets a different view I tried moving aside the {{log4j2.properties}} and also separately tried moving aside the {{{}log4j.properties{}}}, neither helped" EOL 1.x,13475959,Resolved,Major,Fixed,09/Aug/22 12:19,26/Sep/22 16:01,, Update HEADER.html to mention the EOL of 1.x,13475964,Resolved,Major,Fixed,09/Aug/22 12:22,26/Sep/22 16:00,, Remove 1.7.x from dist.a.o,13475963,Resolved,Major,Fixed,09/Aug/22 12:21,26/Sep/22 15:57,, Make balance byTable config take effect when use CLI ,13482913,Resolved,Major,Won't Do,23/Sep/22 09:05,26/Sep/22 04:00,,"For Master triger balance, whether balance by table is depend on  {code:java} this.isByTable = conf.getBoolean(HConstants.HBASE_MASTER_LOADBALANCE_BYTABLE, isByTable);{code} But for CLI, is different.   I think we'd better make the balance behavior same." HBase master reports a region has been in transition for 50+ years,13473602,Open,Major,,26/Jul/22 16:09,,2.4.10,"Every time we upgrade our HBase clusters we get some spurious alerts firing because for a brief period of time the HBase master reports some impossibly high RIT (region in transition) time. For example: !image.png|width=747,height=249!   The condition resolves itself on its own within a few minutes. I'll try to find some relevant logs and attach them to this issue." Remove 1.7.x from our download page,13475962,Resolved,Major,Fixed,09/Aug/22 12:21,23/Sep/22 15:11,, Add mutual authentication support to TLS,13475624,Resolved,Major,Fixed,07/Aug/22 21:26,23/Sep/22 13:20,,"With HBASE-26666 we now have native TLS on server and client. By default clients validate server certificate on handshake. This issue adds server authentication of clients. We can also add support for custom rules, such as cert CommonName validation. I've already got a POC running of this, so assigning to me" Use encoded size for calculating compression ratio in block size predicator,13482736,Resolved,Major,Fixed,22/Sep/22 10:05,23/Sep/22 10:01,3.0.0-alpha-3,"In HBASE-27264 we had introduced the notion of block size predicators to define hfile block boundaries when writing a new hfile, and provided the PreviousBlockCompressionRatePredicator implementation for calculating block sizes based on a compression ratio. It was using the raw data size written to the block so far to calculate the compression ratio, but in the case where encoding is enabled, this could lead to a very high compression ratio and therefore, larger block sizes. We should use the encoded size to calculate compression ratio, instead. Here's a example scenario: 1) Sample block size when not using the  PreviousBlockCompressionRatePredicator as implemented by HBASE-27264: {noformat} onDiskSizeWithoutHeader=6613, uncompressedSizeWithoutHeader=32928 {noformat} 2) Sample block size when using PreviousBlockCompressionRatePredicator as implemented by HBASE-27264 (uses raw data size to calculate compression rate): {noformat} onDiskSizeWithoutHeader=126920, uncompressedSizeWithoutHeader=655393 {noformat} 3) Sample block size when using PreviousBlockCompressionRatePredicator with encoded size for calculating compression rate: {noformat} onDiskSizeWithoutHeader=54299, uncompressedSizeWithoutHeader=328051 {noformat}" Add BucketAllocator bucket size statistic logging,13472294,Resolved,Major,Fixed,19/Jul/22 14:29,26/Jul/22 01:13,,"BucketCache places blocks into configurably sized buckets based on the block size. The default sizes aim to provide broad coverage for common block sizes, but should probably be tuned for certain use-cases. However, we provide no way for operators to gain insight into the distribution of buckets. There already exists a BucketAllocator#logStatistics method, but it is not called anywhere. I suggest that we hook that up in BucketCache#logStats (which is called periodically by a stats thread). We can go from there. Looking at the IndexStatistics used in that method, it looks like a good start. One thing I'd like to add is a count of freeBuckets and completelyFreeBuckets per index. I think this will be useful for indicating how much more wiggle room we have for redistributing buckets among the various block sizes." Add metrics for evaluating cost and effectiveness of bloom filters,13473422,Resolved,Major,Fixed,26/Jul/22 01:05,09/Aug/22 20:59,,"Bloom filters can be costly for some tables, easily resulting in an aggregate memory footprint of many GBs. It's currently hard to monitor for that cost on a per-table basis. You can view {{staticBloomSize}} in JMX, but that is for the whole server. Otherwise you must manually sum the values using the regionserver UI.  We can add this (as well as staticIndexSize) to the per-table metrics. Additionally, it can be hard to know how effective those bloom filters are. I think the easiest way to measure that is to count bloomFilterRequests and bloomFilterNegativeResults. With these metrics in hand, one can have an easier time deciding how much memory they want to give to their L1 cache and/or whether they want to disable blooms on a table." Remove unnecessary usage of CachedBlocksByFile from RS UI,13474214,Resolved,Major,Fixed,29/Jul/22 13:36,29/Jul/22 19:34,,"We have started deploying regionservers with large BucketCaches, with over 1M blocks in the cache. I noticed that our RS UI was loading pretty slowly, and I also noticed the following warning: {quote}*The stats below are incomplete!* We ran into our accounting limit of 1000000 blocks. Up the configuration {_}hbase.ui.blockcache.by.file.max{_}.{quote} Tracking that down, it seems like the original implementation back in 2014 for the BlockCache statistics used CachedBlocksByFile to calculate counts, sizes, etc. But over time this was improved to be backed by CacheStats, for example in HBASE-11573, HBASE-15635, HBASE-18532, etc. At this point the cbsbf variable holding the CachedBlocksByFile object is not actually used by anything on the RS UI. Instead those per-file statistics have been moved to other endpoints, available via the ""View block cache as JSON"" and ""as JSON by file"" links. Removing the creation of the cbsbf variable makes a dramatic improvement on RS UI load times for large caches. Prior to the change, it consistently took 4-5s to load the UI. Afterward it takes a fraction of a second." Rs shut down because of DroppedSnapshotException when memstore flushing,13482696,Open,Major,,22/Sep/22 06:20,,1.0.0,"After memstore be flushed, flush marker will be writed to WAL. But current wal being rolled now, the DroppedSnapshotException will happen. if (wal != null) { // write flush marker to WAL. If fail, we should throw DroppedSnapshotException FlushDescriptor desc = ProtobufUtil.toFlushDescriptor(FlushAction.COMMIT_FLUSH, getRegionInfo(), flushOpSeqId, committedFiles); WALUtil.writeFlushMarker(wal, this.htableDescriptor, getRegionInfo(), desc, sequenceId, true); } } catch (Throwable t) { ....... DroppedSnapshotException dse = new DroppedSnapshotException(""region: "" + Bytes.toStringBinary(getRegionName())); dse.initCause(t); status.abort(""Flush failed: "" + StringUtils.stringifyException(t)); throw dse;" Unnecessary replication to secondary region replicas should avoid when WAL.sync throws Exception,13476839,Resolved,Major,Fixed,15/Aug/22 14:06,24/Aug/22 02:27,3.0.0-alpha-4,"As HBASE-27230 and HBASE-27223 said, if {{WAL.sync}} throws an exception, we should abort the region server to avoid the data inconsistent between the primary region and secondary region replicas, so we have no need to replicate to secondary region replicas when {{WAL.sync}} throws an exception." Add query rate metric for filtered reads,13482243,Open,Major,,19/Sep/22 23:19,,,"We have very useful metrics ServerReadQueryPerSecond and ServerWriteQueryPerSecond. The benefit of these over readRequestCount and writeRequestCount are that they are stable over the life of the regionserver. The readRequestCount and writeRequestCount can be heavily skewed when regions move around and the counters get decremented. We have filteredReadRequestCount which has the same issue. It'd be nice to have a stable rate for this metric, as I find that filtered reads are almost as costly as non-filtered." Add metrics reporting on multi-cf reads,13482242,Open,Major,,19/Sep/22 23:16,,,"Data in column families are stored in separate files. When a read comes in to a table with multiple column families, by default it will fetch data from all column families unless the specific column/family was requested. These reads are more expensive, especially in multigets. As an operator, it's hard to know when these are coming in. It would be useful to have a metric." Add an option to reject multi-cf bulkloads,13482241,Open,Major,,19/Sep/22 23:14,,,"Doing a multi-cf bulkload requires taking a write lock on the region. When bulkloading many regions or doing many bulkloads to individual regions, this can cause a sort of denial of service for the region or entire table. For those deployments which prefer to prioritize uptime, we should provide the ability to disallow these multi-cf bulkloads. It would be good to make this configurable via hbase-site.xml and overridden by TableDescriptor." Export Hbase table to hdfs as comma delimiter,13481894,Open,Major,,16/Sep/22 13:37,,,we are trying to export hbase table to hdfs as comma delimiter/seperator . hope this feature will be added. Suspected memory leak caused by major compaction,13482010,Open,Major,,18/Sep/22 04:47,,2.2.6,"There are 49G Hfiles in a certain region, and major compact has been unsuccessful, and the Old area in the heap memory continues to fill up, causing frequent Full GCs and causing the RegionServer process to OOM. After analyzing the dump file of heap memory using MAT, we found that: !image-2022-09-18-12-46-08-478.png! The full stack involved is as follows: regionserver/node71:60020-longCompactions-3   at org.apache.hadoop.util.NativeCrc32.nativeComputeChunkedSums(IILjava/nio/ByteBuffer;ILjava/nio/ByteBuffer;IILjava/lang/String;JZ)V (Native Method)   at org.apache.hadoop.util.NativeCrc32.verifyChunkedSums(IILjava/nio/ByteBuffer;Ljava/nio/ByteBuffer;Ljava/lang/String;J)V (NativeCrc32.java:63)   at org.apache.hadoop.util.DataChecksum.verifyChunkedSums(Ljava/nio/ByteBuffer;Ljava/nio/ByteBuffer;Ljava/lang/String;J)V (DataChecksum.java:380)   at org.apache.hadoop.hbase.io.hfile.ChecksumUtil.verifyChunkedSums(Lorg/apache/hadoop/util/DataChecksum;Lorg/apache/hadoop/hbase/nio/ByteBuff;Lorg/apache/hadoop/hbase/nio/ByteBuff;Ljava/lang/String;)Z (ChecksumUtil.java:104)   at org.apache.hadoop.hbase.io.hfile.ChecksumUtil.validateChecksum(Lorg/apache/hadoop/hbase/nio/ByteBuff;Ljava/lang/String;JI)Z (ChecksumUtil.java:191)   at org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl.validateChecksum(JLorg/apache/hadoop/hbase/nio/ByteBuff;I)Z (HFileBlock.java:1842)   at org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl.readBlockDataInternal(Lorg/apache/hadoop/fs/FSDataInputStream;JJZZZZ)Lorg/apache/hadoop/hbase/io/hfile/HFileBlock; (HFileBlock.java:1777)   at org.apache.hadoop.hbase.io.hfile.HFileBlock$FSReaderImpl.readBlockData(JJZZZ)Lorg/apache/hadoop/hbase/io/hfile/HFileBlock; (HFileBlock.java:1570)   at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.readBlock(JJZZZZLorg/apache/hadoop/hbase/io/hfile/BlockType;Lorg/apache/hadoop/hbase/io/encoding/DataBlockEncoding;)Lorg/apache/hadoop/hbase/io/hfile/HFileBlock; (HFileReaderImpl.java:1519)   at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.readNextDataBlock()Lorg/apache/hadoop/hbase/io/hfile/HFileBlock; (HFileReaderImpl.java:928)   at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.isNextBlock()Z (HFileReaderImpl.java:1061)   at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.positionForNextBlock()Z (HFileReaderImpl.java:1055)   at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl._next()Z (HFileReaderImpl.java:1073)   at org.apache.hadoop.hbase.io.hfile.HFileReaderImpl$HFileScannerImpl.next()Z (HFileReaderImpl.java:1094)   at org.apache.hadoop.hbase.io.HalfStoreFileReader$1.next()Z (HalfStoreFileReader.java:169)   at org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseekAtOrAfter(Lorg/apache/hadoop/hbase/io/hfile/HFileScanner;Lorg/apache/hadoop/hbase/Cell;)Z (StoreFileScanner.java:351)   at org.apache.hadoop.hbase.regionserver.StoreFileScanner.reseek(Lorg/apache/hadoop/hbase/Cell;)Z (StoreFileScanner.java:244)   at org.apache.hadoop.hbase.regionserver.NonLazyKeyValueScanner.doRealSeek(Lorg/apache/hadoop/hbase/regionserver/KeyValueScanner;Lorg/apache/hadoop/hbase/Cell;Z)Z (NonLazyKeyValueScanner.java:55)   at org.apache.hadoop.hbase.regionserver.KeyValueHeap.generalizedSeek(ZLorg/apache/hadoop/hbase/Cell;ZZ)Z (KeyValueHeap.java:324)   at org.apache.hadoop.hbase.regionserver.KeyValueHeap.reseek(Lorg/apache/hadoop/hbase/Cell;)Z (KeyValueHeap.java:267)   at org.apache.hadoop.hbase.regionserver.StoreScanner.reseek(Lorg/apache/hadoop/hbase/Cell;)Z (StoreScanner.java:1099)   at org.apache.hadoop.hbase.regionserver.StoreScanner.seekAsDirection(Lorg/apache/hadoop/hbase/Cell;)Z (StoreScanner.java:1088)   at org.apache.hadoop.hbase.regionserver.StoreScanner.seekOrSkipToNextColumn(Lorg/apache/hadoop/hbase/Cell;)V (StoreScanner.java:823)   at org.apache.hadoop.hbase.regionserver.StoreScanner.next(Ljava/util/List;Lorg/apache/hadoop/hbase/regionserver/ScannerContext;)Z (StoreScanner.java:730)   at org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$FileDetails;Lorg/apache/hadoop/hbase/regionserver/InternalScanner;Lorg/apache/hadoop/hbase/regionserver/CellSink;JZLorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;ZI)Z (Compactor.java:387)   at org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionRequestImpl;Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$InternalScannerFactory;Lorg/apache/hadoop/hbase/regionserver/compactions/Compactor$CellSinkFactory;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List; (Compactor.java:326)   at org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionRequestImpl;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List; (DefaultCompactor.java:65)   at org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List; (DefaultStoreEngine.java:126)   at org.apache.hadoop.hbase.regionserver.HStore.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionContext;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Ljava/util/List; (HStore.java:1469)   at org.apache.hadoop.hbase.regionserver.HRegion.compact(Lorg/apache/hadoop/hbase/regionserver/compactions/CompactionContext;Lorg/apache/hadoop/hbase/regionserver/HStore;Lorg/apache/hadoop/hbase/regionserver/throttle/ThroughputController;Lorg/apache/hadoop/hbase/security/User;)Z (HRegion.java:2264)   at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(Lorg/apache/hadoop/hbase/security/User;)V (CompactSplit.java:624)   at org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run()V (CompactSplit.java:666)   at java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V (ThreadPoolExecutor.java:1142)   at java.util.concurrent.ThreadPoolExecutor$Worker.run()V (ThreadPoolExecutor.java:617)   at java.lang.Thread.run()V (Thread.java:748)  " split or merge removed region under snapshot,13481189,Open,Major,,12/Sep/22 22:48,,2.4.5,"We run into snapshot failures for one table with large number of regions. The event sequence is like the following:   # Snapshot process lists all regions for one table. # Normalize kicks in to split some regions for the table under snapshot. # split finishes and major compaction finishes. The parent region is moved to archive. # When the Snapshot processes the parent region, it does not exist and snapshot fails. Since snapshot process acquires the table lock, but there is no table lock acquired in split or merge process, they crash into each other." The trace related assertions are flaky for async client tests,13480391,Resolved,Major,Fixed,07/Sep/22 06:07,09/Sep/22 15:09,,"https://ci-hbase.apache.org/job/HBase-Flaky-Tests/job/master/4167/testReport/junit/org.apache.hadoop.hbase.client/TestAsyncTableScanner/testScanWrongColumnFamily_0__table_raw__scan_normal_/ The failure message is kinda unreadable... I guess the problem is we do not wait enough time as the completion of the span can be executed concurrently with normal scan operation. And also I saw this in the test code {code} // RawAsyncTableImpl never invokes the callback to `onScanMetricsCreated` -- bug? {code} This is not a bug as you need to manually enable scan metrics by calling Scan.setScanMetricsEnabled(true). Let me also fix this. " Add .flattened-pom.xml to .gitignore,13480399,Resolved,Major,Fixed,07/Sep/22 06:57,08/Sep/22 09:01,,"The flatten plugin will create a .flattened-pom.xml file in each module and also root, we should ignore them." Fix some tests hung by CompactSplit.requestCompactionInternal ignoring compactionsEnabled check,13480473,Resolved,Major,Fixed,07/Sep/22 12:10,09/Sep/22 02:37,3.0.0-alpha-3,"When compaction is disabled, {{CompactSplit.compactionsEnabled}} is set to false and {{CompactSplit.longCompactions}} and {{CompactSplit.shortCompactions}} is shutdown. But for {{CompactSplit.requestCompactionInternal}} , it only check {{CompactSplit.compactionsEnabled}} in {{CompactSplit.selectCompaction}}, when {{selectNow}} is false, {{CompactSplit.selectCompaction}} is not invoked and would submit the compaction task to {{CompactSplit.shortCompactions}},after HBASE-27332, because {{CompactSplit.shortCompactions}} is shut down, {{RejectedExecutionException}} would throw. For test such as {{TestRegionSplit.testSplitTableRegion}}, because compaction is disabled, this problem would make the new region after split could not open, so it make the test hang." Autodetect key/truststore file type from file extension,13479302,Resolved,Major,Fixed,30/Aug/22 12:03,06/Sep/22 20:59,,"Noticed that file type autodetection hasn't been properly ported from ZooKeeper although the comment says otherwise. Instead of defaulting to JKS we should check the file extension." Delete causes timestamp to be negative,13474673,Resolved,Major,Not A Problem,02/Aug/22 10:11,06/Sep/22 15:09,2.3.4,"When client-1.1.6 and server-2.3.4 there is a case where the batch delete timestamp is negative # 1. RegionServer log message: {code:java} 2022-07-19 12:13:29,324 WARN [RS_OPEN_REGION-regionserver/HBASE-HOSTNAME1:16020-1.replicationSource.wal-reader.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.regiongroup-2,clusterB] hbase.KeyValueUtil: Timestamp cannot be negative, ts=-4323977095312258207, KeyValueBytesHex=\x00\x00\x00, offset=0, length=40 2022-07-19 12:13:29,324 WARN [RS_OPEN_REGION-regionserver/HBASE-HOSTNAME1:16020-1.replicationSource.wal-reader.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.HBASE-HOSTNAME1.local%2C16020%2C1657184880284.regiongroup-2,clusterB] wal.ProtobufLogReader: Encountered a malformed edit, seeking back to last good position in file, from 1099261 to 1078224 java.io.EOFException: EOF while reading 660 WAL KVs; started reading at 1078317 and read up to 1099261 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:403) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:97) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:85) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:264) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:178) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:103) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:230) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:145) Caused by: java.lang.IllegalArgumentException: Timestamp cannot be negative, ts=-4323977095312258207, KeyValueBytesHex=\x00\x00\x00, offset=0, length=40 at org.apache.hadoop.hbase.KeyValueUtil.checkKeyValueBytes(KeyValueUtil.java:612) at org.apache.hadoop.hbase.KeyValue.(KeyValue.java:346) at org.apache.hadoop.hbase.KeyValueUtil.createKeyValueFromInputStream(KeyValueUtil.java:717) at org.apache.hadoop.hbase.codec.KeyValueCodecWithTags$KeyValueDecoder.parseCell(KeyValueCodecWithTags.java:81) at org.apache.hadoop.hbase.codec.BaseDecoder.advance(BaseDecoder.java:68) at org.apache.hadoop.hbase.wal.WALEdit.readFromCells(WALEdit.java:276) at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:387) ... 7 more {code} # 2. Debug WAL file ,found that the delete operation is caused {code:java} Sequence=365693989, table=tableA, region=148cedb7b8ca3145690800fd650e084d, at write timestamp=Sat Jul 16 00:50:01 CST 2022 2022-07-22 22:09:43,244 ERROR [main] wal.WALPrettyPrinter: Timestamp is negative row=rowkey1, column=d:act, timestamp=-4323977095312258207, type=Delete {code} # 3. User use spark read/write hbase batchsize is 10000 {code:scala} def dataDeleteFromHbase(rdd: RDD[(String, String)], hbase_table: String, hbase_instance: String, hbase_accesskey: String, accumulator: LongAccumulator, buffersize: String, batchsize: Int): Unit = { rdd.foreachPartition(iterator => { val partitionId = TaskContext.getPartitionId() val conf = HBaseConfiguration.create() val connection = SparkHbaseUtils.getconnection(conf) val table = connection.getTable(TableName.valueOf(hbase_table)) var deleteList = new util.LinkedList[Delete]() var count = 0 var batchCount = 0 while (iterator.hasNext) { val element = iterator.next val crc32 = new CRC32() crc32.update(s""${element._1}_${element._2}"".getBytes()) val crcArr = convertLow4bit2SmallEndan(crc32.getValue) val key = concat(DigestUtils.md5(s""${element._1}_${element._2}""), crcArr) val delete = new Delete(key) deleteList.add(delete) count += 1 if (count % batchsize.toInt == 0) { batchCount = batchCount + 1 try { table.delete(deleteList) } catch { case _: RetriesExhaustedWithDetailsException => { LOGGER.warn(s""======partitionId: ${partitionId}===batchCount: ${batchCount}===Wait 1000 ms, retry......============"") Thread.sleep(1000) processDelThrottlingException(table, deleteList, partitionId, batchCount) } case _: ThrottlingException => { LOGGER.warn(s""======partitionId: ${partitionId}===batchCount: ${batchCount}===Wait 1000 ms, retry......============"") Thread.sleep(1000) processDelThrottlingException(table, deleteList, partitionId, batchCount) } } LOGGER.warn(s""======partitionId: ${partitionId}===${batchCount * batchsize} rows delete success! ============"") accumulator.add(batchsize) LOGGER.warn(s""##########################already delete count: ${accumulator.value}#######################"") deleteList = new util.LinkedList[Delete]() } } if (CollectionUtils.isNotEmpty(deleteList)) { batchCount = batchCount + 1 val listSize = deleteList.size() try { table.delete(deleteList) } catch { case _: RetriesExhaustedWithDetailsException => { LOGGER.warn(s""======partitionId: ${partitionId}===batchCount: ${batchCount}===Wait 1000 ms, retry......============"") Thread.sleep(1000) processDelThrottlingException(table, deleteList, partitionId, batchCount) } case _: ThrottlingException => { LOGGER.warn(s""======partitionId: ${partitionId}===batchCount: ${batchCount}===Wait 1000 ms, retry......============"") Thread.sleep(1000) processDelThrottlingException(table, deleteList, partitionId, batchCount) } } LOGGER.warn(s""======partitionId: ${partitionId}===${(batchCount - 1) * batchsize + listSize} rows delete success! ============"") accumulator.add(listSize) LOGGER.warn(s""##########################already delete count: ${accumulator.value}#######################"") } if (table != null) { table.close() } if (connection != null) { connection.close() } }) } {code} " Enforcer phase EvaluateBeanShell fails occasionally,13478638,Open,Major,,25/Aug/22 12:12,,,"For example, from https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/412/General_20Nightly_20Build_20Report/ {noformat} [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ hbase-shaded-client-byo-hadoop --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed with message: Couldn't evaluate condition: File license = new File(""/home/jenkins/jenkins-home/workspace/HBase_Nightly_branch-2.4/component/hbase-shaded/hbase-shaded-client/target/maven-shared-archive-resources/META-INF/LICENSE""); // Beanshell does not support try-with-resources, // so we must close this scanner manually Scanner scanner = new Scanner(license); while (scanner.hasNextLine()) { if (scanner.nextLine().startsWith(""ERROR:"")) { scanner.close(); return false; } } scanner.close(); return true; [INFO] No sources to compile {noformat} " Add 2.5.0 to the downloads page,13479491,Resolved,Major,Fixed,31/Aug/22 13:10,31/Aug/22 14:39,, HBase shell hang for a minute when quiting,13478837,Resolved,Major,Fixed,26/Aug/22 14:47,31/Aug/22 03:33,2.5.0,"Found this when trying the 2.5.0 RC. The way to reproduce Use './bin/hbase shell' to connect to a cluster, and then run these two commands {code} count ""hbase:meta"" quit {code} We will hang about 1 minute before the final exit of the shell process." The region visualizer shows 'undefined' region server,13478841,Resolved,Major,Fixed,26/Aug/22 15:23,31/Aug/22 12:48,2.5.0, releasing resources when quiting IRB,13479398,Open,Major,,31/Aug/22 02:50,,,Please refer to #[4737|https://github.com/apache/hbase/pull/4737] for details. Improvements of HMaster web ui,13478662,Open,Major,,25/Aug/22 13:47,,2.4.13,"The HMaster web ui open very slowly when there are many regions in the cluster, it may takes above 3min to load region and table messages， The RIT and table on home page is very slow, because we load all info on one time... we need improve page loading speed of HMaster home page..." RoundRobinTableInputFormat main should extend `AbstractHBaseTool` for proper configuration parsing,13479106,Open,Major,,29/Aug/22 12:42,,2.3.5,"Noticed while reviewing the compatibility report for 2.5.0RC1. `RoundRobinTableInputFormat` ships with an undocumented main method that prints out input split diagnostic information. That main does some basic configuration parsing but it inconsistent with how parsing is normally done. If the tool is going to ship a main, it should do paring properly, make use of `AbstractHBaseTool`." RSGroupMappingScript#getRSGroup has thread safety problem,13473743,Resolved,Major,Fixed,27/Jul/22 09:34,24/Aug/22 08:59,,"We are using version 1.4.12 and met a problem in table creation phase some time. The master branch also has this problem. The error message is: {code:java} 2022-07-26 19:26:20.122 [http-nio-8078-exec-24,d2ad4b13b542b6fb] ERROR HBaseServiceImpl - hbase create table: xxx:xxxx failed. (HBaseServiceImpl.java:116) java.lang.RuntimeException: org.apache.hadoop.hbase.constraint.ConstraintException: org.apache.hadoop.hbase.constraint.ConstraintException: Default RSGroup (default default) for this table's namespace does not exist. {code} The rsgroup here should be one 'default' but not two consecutive 'default'. The code to get RSGroup from a mapping script is: {code:java} String getRSGroup(String namespace, String tablename) { if (rsgroupMappingScript == null) { return null; } String[] exec = rsgroupMappingScript.getExecString(); exec[1] = namespace; exec[2] = tablename; try { rsgroupMappingScript.execute(); } catch (IOException e) { // This exception may happen, like process doesn't have permission to run this script. LOG.error(""{}, placing {} back to default rsgroup"", e.getMessage(), TableName.valueOf(namespace, tablename)); return RSGroupInfo.DEFAULT_GROUP; } return rsgroupMappingScript.getOutput().trim(); } {code} here the rsgourpMappingScript could be executed by multi-threads. To test it is a multi-thread issue, I ran a piece of code locally and found that the hadoop ShellCommandExecutor is not thread-safe (I run the code with hadoop 2.10.0 and 3.3.2). So that we should make this method synchronized. Besides, I found that this issue is retained in master branch also. The test code is attached and my rsgroup mapping script is very simple: {code:java} #!/bin/bash namespace=$1 tablename=$2 echo default {code} The reproduced screenshot is also attached. " The implementation of syncReplicationPeerLock is incomplete,13478034,Resolved,Major,Fixed,22/Aug/22 15:03,23/Aug/22 07:08,,"We also need to restore the state after loading the procedure after master restarts. And we'd better not just let the PEWorker hand there on waiting the semaphore, better to let the procedure suspend and retry later." "Backport ""HBASE-26810 Add dynamic configuration support for system coprocessors"" to branch-2.5",13476491,Resolved,Major,Duplicate,12/Aug/22 04:27,23/Aug/22 12:07,2.5.0,"Backport HBASE-26810 dynamic configuration for system coprocessor to branch-2.5 , this have been done in master and branch-2, so let's see if we can have it in branch-2.5 before 2.5.0 or 2.5.1 release" Fix RC calculation in create-release,13478249,Open,Major,,23/Aug/22 15:52,,3.0.0-alpha-4,"Working on 2.5.0RC1, there exits a 2.5.0RC0 in the repo already. `create-release` is proposing 2.5.0RC2 as the tag." Remove invalid peer RegionServer crash,13473804,In Progress,Major,,27/Jul/22 14:12,,,"add_peer 'test', CLUSTER_KEY => ""zookeeper-01:2181:/hbase_01"" remove_peer 'test' find add peer wrong, remove peer but regionserver crash The log information is as follows: 2022-07-18 13:26:11,016 ERROR [ReadOnlyZKClient-zookeeper-01:2181@0x44281bff-SendThread(zookeeper-01:2181)] client.StaticHostProvider: Unable to resolve address: zookeeper-01/:2181 java.net.UnknownHostException: zookeeper-01 at java.base/java.net.InetAddress$CachedAddresses.get(InetAddress.java:800) at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1507) at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1366) at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1300) at org.apache.zookeeper.client.StaticHostProvider$1.getAllByName(StaticHostProvider.java:92) at org.apache.zookeeper.client.StaticHostProvider.resolve(StaticHostProvider.java:147) at org.apache.zookeeper.client.StaticHostProvider.next(StaticHostProvider.java:375) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1137) 2022-07-18 13:26:11,016 WARN [ReadOnlyZKClient-zookeeper-01:2181@0x44281bff-SendThread(zookeeper-01:2181)] zookeeper.ClientCnxn: Session 0x0 for server zookeeper-01/:2181, unexpected error, closing socket connection and attempting reconnect java.lang.IllegalArgumentException: Unable to canonicalize address zookeeper-01/:2181 because it's not resolvable at org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:71) at org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:39) at org.apache.zookeeper.ClientCnxn$SendThread.startConnect(ClientCnxn.java:1087) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1139) 2022-07-18 13:26:11,116 WARN [ReadOnlyZKClient-zookeeper-01:2181@0x44281bff] zookeeper.ReadOnlyZKClient: 0x44281bff to zookeeper-01:2181 failed for get of /hbase_01/hbaseid, code = CONNECTIONLOSS, retries = 48 2022-07-18 13:26:11,119 WARN [regionserver/ip1:16020.logRoller] regionserver.ReplicationSource: peerId=test, WAL group ip1%2C16020%2C1658118295598.ip1%2C16020%2C1658118295598.regiongroup-2 queue size: 11 exceeds value of replication.source.log.queue.warn 2 2022-07-18 13:26:12,055 INFO [MemStoreFlusher.1] regionserver.HRegion: Flushing 31bbfb9b76b6795e5d44fabd113174c0 1/2 column families, dataSize=245.67 MB heapSize=257.48 MB; f1={dataSize=245.67 MB, heapSize=257.48 MB, offHeapSize=0 B} 2022-07-18 13:26:12,116 ERROR [ReadOnlyZKClient-zookeeper-01:2181@0x44281bff-SendThread(zookeeper-01:2181)] client.StaticHostProvider: Unable to resolve address: zookeeper-01/:2181 java.net.UnknownHostException: zookeeper-01 at java.base/java.net.InetAddress$CachedAddresses.get(InetAddress.java:800) at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1507) at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1366) at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1300) at org.apache.zookeeper.client.StaticHostProvider$1.getAllByName(StaticHostProvider.java:92) at org.apache.zookeeper.client.StaticHostProvider.resolve(StaticHostProvider.java:147) at org.apache.zookeeper.client.StaticHostProvider.next(StaticHostProvider.java:375) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1137) 2022-07-18 13:26:30,270 INFO [RS_REFRESH_PEER-regionserver/ip1:16020-1] regionserver.RefreshPeerCallable: Received a peer change event, peerId=test, type=REMOVE_PEER 2022-07-18 13:26:30,270 INFO [RS_REFRESH_PEER-regionserver/ip1:16020-1] regionserver.ReplicationSourceManager: Number of deleted recovered sources for test: 0 2022-07-18 13:26:30,270 INFO [RS_REFRESH_PEER-regionserver/ip1:16020-1] regionserver.ReplicationSource: peerId=test, Closing source test because: Replication stream was removed by a user 2022-07-18 13:26:30,271 WARN [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] client.ConnectionImplementation: Retrieve cluster id failed java.lang.InterruptedException at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:385) at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2063) at org.apache.hadoop.hbase.client.ConnectionImplementation.retrieveClusterId(ConnectionImplementation.java:583) at org.apache.hadoop.hbase.client.ConnectionImplementation.(ConnectionImplementation.java:316) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:64) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481) at org.apache.hadoop.hbase.client.ConnectionFactory.lambda$createConnection$0(ConnectionFactory.java:230) at java.base/java.security.AccessController.doPrivileged(AccessController.java:691) at java.base/javax.security.auth.Subject.doAs(Subject.java:425) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1830) at org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs(User.java:347) at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:228) at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:128) at org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.createConnection(HBaseInterClusterReplicationEndpoint.java:140) at org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.init(HBaseInterClusterReplicationEndpoint.java:172) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initAndStartReplicationEndpoint(ReplicationSource.java:340) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:557) at java.base/java.lang.Thread.run(Thread.java:832) 2022-07-18 13:26:30,271 INFO [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] zookeeper.RecoverableZooKeeper: Process identifier=connection to cluster: test connecting to ZooKeeper ensemble=zookeeper-01:2181 2022-07-18 13:26:30,271 INFO [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] zookeeper.ZooKeeper: Initiating client connection, connectString=zookeeper-01:2181 sessionTimeout=90000 watcher=org.apache.hadoop.hbase.zookeeper.PendingWatcher@70ad0136 2022-07-18 13:26:30,271 INFO [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] zookeeper.ClientCnxnSocket: jute.maxbuffer value is 67108864 Bytes 2022-07-18 13:26:30,272 INFO [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] zookeeper.ClientCnxn: zookeeper.request.timeout value is 0. feature enabled= 2022-07-18 13:26:30,272 ERROR [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test-SendThread()] client.StaticHostProvider: Unable to resolve address: zookeeper-01/:2181 java.net.UnknownHostException: zookeeper-01 at java.base/java.net.InetAddress$CachedAddresses.get(InetAddress.java:800) at java.base/java.net.InetAddress.getAllByName0(InetAddress.java:1507) at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1366) at java.base/java.net.InetAddress.getAllByName(InetAddress.java:1300) at org.apache.zookeeper.client.StaticHostProvider$1.getAllByName(StaticHostProvider.java:92) at org.apache.zookeeper.client.StaticHostProvider.resolve(StaticHostProvider.java:147) at org.apache.zookeeper.client.StaticHostProvider.next(StaticHostProvider.java:375) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1137) 2022-07-18 13:26:30,272 ERROR [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] regionserver.ReplicationSource: Unexpected exception in RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test currentPath=null java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:581) at java.base/java.lang.Thread.run(Thread.java:832) 2022-07-18 13:26:30,272 WARN [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test-SendThread(zookeeper-01:2181)] zookeeper.ClientCnxn: Session 0x0 for server zookeeper-01/:2181, unexpected error, closing socket connection and attempting reconnect java.lang.IllegalArgumentException: Unable to canonicalize address zookeeper-01/:2181 because it's not resolvable at org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:71) at org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:39) at org.apache.zookeeper.ClientCnxn$SendThread.startConnect(ClientCnxn.java:1087) at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1139) 2022-07-18 13:26:30,274 ERROR [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] regionserver.HRegionServer: ***** ABORTING region server ip1,16020,1658118295598: Unexpected exception in RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test ***** java.lang.IllegalStateException: Source should be active. at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.initialize(ReplicationSource.java:581) at java.base/java.lang.Thread.run(Thread.java:832) 2022-07-18 13:26:30,275 ERROR [RS_REFRESH_PEER-regionserver/ip1:16020-0.replicationSource,test] regionserver.HRegionServer: RegionServer abort: loaded coprocessors are: [org.apache.hadoop.hbase.security.access.AccessController, org.apache.hadoop.hbase.replication.regionserver.ReplicationObserver] " Configuration to allow client fallback to non-SSL if handshake fails,13478222,Open,Major,,23/Aug/22 13:32,,,"[~zhangduo] brought up a great idea when reviewing the new native TLS docs. Since HMasters and RegionServers are both clients and servers, currently it requires multiple cluster restarts to transition an existing cluster to TLS: {quote}1. Enable {{hbase.server.netty.tls.enabled}} only, with supportPlaintext=true. After restart, servers will _accept_ TLS, but not _send_ TLS.  2. Additionally enable {{hbase.client.netty.tls.enabled}} on servers, keeping supportPlaintext=true. After restart, servers will now _accept and send_ TLS. 3. Remove supportPlaintext=true. After restart, servers will reject requests if not TLS. Clients can be updated to use {{hbase.client.netty.tls.enabled}} either after step 1 or 2, but before 3. {quote} This could be simplified by allowing the client-side to also fallback to plaintext if handshake fails: {quote}Theoretically at client side it is possible. In the NettyRpcConnection implementation, before the ssl handshake finishes, we will not send any data out. So if we want to fallback to non ssl communication, we could just remove the ssl handler and set up the connection without encryption. But probably at server side we will just close the connection... {quote} We'd need to test to see how the server-side handles this downgrade, per the last sentence above." Clean up error-prone findings in hbase-common,13471652,Resolved,Major,Fixed,14/Jul/22 23:30,21/Aug/22 14:25,, Clean up error-prone findings in hbase-examples,13473174,Resolved,Major,Fixed,25/Jul/22 06:00,20/Aug/22 16:33,, Clean up error-prone findings in hbase-it,13473873,Resolved,Major,Fixed,27/Jul/22 23:22,20/Aug/22 15:50,, Add new hadoop releases in our hadoop checks,13476360,Resolved,Major,Fixed,11/Aug/22 09:55,16/Aug/22 14:07,,"3.1.3, 3.1.4 3.2.3, 3.2.4 3.3.2,3.3.3,3.3.4" Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler,13475598,Resolved,Major,Fixed,07/Aug/22 12:36,16/Aug/22 14:06,,"Though this is not recommended as SslHandler has already done wrap/unwrap, it is still better to make it work(maybe we could add some warning logs to say this is unnecessary?) than fail with strange error message." Add options to consider compressed size when delimiting blocks during hfile writes,13474514,Resolved,Major,Fixed,01/Aug/22 12:13,15/Aug/22 21:57,3.0.0-alpha-4,"In HBASE-27232 we had modified ""hbase.writer.unified.encoded.blocksize.ratio"" property soo that it can allow for the encoded size to be considered when delimiting hfiles blocks during writes. -Here we propose two additional properties,""hbase.block.size.limit.compressed"" and  ""hbase.block.size.max.compressed"" that would allow for consider the compressed size (if compression is in use) for delimiting blocks during hfile writing. When compression is enabled, certain datasets can have very high compression efficiency, so that the default 64KB block size and 10GB max file size can lead to hfiles with very large number of blocks.-  -In this proposal, ""hbase.block.size.limit.compressed"" is a boolean flag that switches to compressed size for delimiting blocks, and ""hbase.block.size.max.compressed"" is an int with the limit, in bytes for the compressed block size, in order to avoid very large uncompressed blocks (defaulting to 320KB).- Note: As of 15/08/2022, the original proposal above has been modified to define a pluggable strategy for predicating block compression rate. Please refer to the release notes for more details.   " Bump minimum hadoop 2 version to 2.10.2,13476514,Resolved,Major,Fixed,12/Aug/22 07:00,15/Aug/22 11:36,,"Although 2.10.2 still have some security issues, at least it is better than other hadoop2 releases and we still want to maintain hadoop 2 support for branch-2.x." Bump spotless version to 2.24.1,13472165,Resolved,Major,Fixed,19/Jul/22 01:38,15/Aug/22 07:44,,To catch up with the lastest version. Improve TestTlsIPC to reuse existing IPC test code,13475597,Resolved,Major,Fixed,07/Aug/22 12:34,15/Aug/22 11:32,,We could make it extends AbstractTestIPC to test more IPC/RPC functions when enabling TLS. Adding a trigger for Stochastica Balancer to safeguard for upper bound outliers.,13476673,Open,Major,,14/Aug/22 01:02,,,"In large clusters, if one outlier has a lot of regions, the calculated imbalance for  RegionCountSkewCostFunction is quite low and often fails to trigger the balancer. For example, a node with twice average count on a 400-node cluster only produce an imbalance of 0.004 < 0.02(current default threshold to trigger balancer). An empty node also have similar effect but we have a safeguard in place. https://issues.apache.org/jira/browse/HBASE-24139 We can add a safeguard for this so  we don't have to lower threshold on larger clusters that makes the balancer more sensitive to other minor imbalances." Remove jenkins and personality scripts support for 1.x,13476058,Resolved,Major,Fixed,10/Aug/22 02:55,11/Aug/22 09:13,, Clean up error-prone findings in hbase-http,13473417,Resolved,Major,Fixed,26/Jul/22 00:36,11/Aug/22 06:55,, Clean up error-prone findings in hbase-backup,13471482,Resolved,Major,Fixed,13/Jul/22 23:41,11/Aug/22 07:02,, Fix build failure against Hadoop 3.3.4 due to added dependency on okhttp,13475982,Resolved,Major,Fixed,09/Aug/22 14:04,10/Aug/22 15:53,,"{noformat} $ mvn clean install -DskipTests -Phadoop-3.0 -Dhadoop-three.version=3.3.4 ... [ERROR] Found artifact with unexpected contents: '/home/rocky/srcs/hbase/hbase-shaded/hbase-shaded-mapreduce/target/hbase-shaded-mapreduce-3.0.0-alpha-4-SNAPSHOT.jar' Please check the following and either correct the build or update the allowed list with reasoning. okhttp3/ okhttp3/Request$Builder.class ... kotlin/ kotlin/collections/ kotlin/collections/ArraysUtilJVM.class ... {noformat}" bin/hbase still use slf4j-log4j while reload4j in place,13473652,Resolved,Major,Fixed,27/Jul/22 00:54,10/Aug/22 08:14,2.4.13,"For the bin/hbase file, there are some class path set which will handle the slf4j-log4j before, but now in hbase branch 2, we upgrade to reload4j, but the hbase file not upgrade, for example, if we run mapredcp: hbase mapredcp: /usr/lib/hbase/lib/shaded-clients/hbase-shaded-mapreduce-2.4.12.jar:/usr/lib/hbase/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/usr/lib/hbase/lib/client-facing-thirdparty/commons-logging-1.2.jar:/usr/lib/hbase/lib/client-facing-thirdparty/htrace-core4-4.2.0-incubating.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/reload4j-1.2.19.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-api-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar Among above, /usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar should be excluded but as slf4j-log4j before This will impact the downstream users " Update compatibility matrix and release manager section in our ref guide about the EOL of 1.x,13475961,Resolved,Major,Fixed,09/Aug/22 12:21,10/Aug/22 06:24,, Remove jenkins files for branch-1,13475960,Resolved,Major,Fixed,09/Aug/22 12:20,10/Aug/22 06:25,, Use readTO instead of hard coded RpcClient.DEFAULT_SOCKET_TIMEOUT_READ when creating ReadTimeoutHandler in NettyRpcConnection,13475845,Resolved,Major,Fixed,09/Aug/22 04:03,09/Aug/22 08:33,,"So by setting a smaller read timeout, we could speed up the TestSecureIPC run." CME in AuthManager causes region server crash,13475765,Resolved,Major,Fixed,08/Aug/22 14:29,09/Aug/22 01:59,,"java.util.ConcurrentModificationException     at java.util.HashMap$HashIterator.nextNode(HashMap.java:1445)     at java.util.HashMap$KeyIterator.next(HashMap.java:1469)     at org.apache.hadoop.hbase.security.access.AuthManager.authorizeNamespace(AuthManager.java:313)     at org.apache.hadoop.hbase.security.access.AuthManager.authorizeUserNamespace(AuthManager.java:297)     at org.apache.hadoop.hbase.security.access.AuthManager.authorizeUserTable(AuthManager.java:405)     at org.apache.hadoop.hbase.security.access.AuthManager.authorizeUserTable(AuthManager.java:372)     at org.apache.hadoop.hbase.security.access.AccessChecker.permissionGranted(AccessChecker.java:711)     at org.apache.hadoop.hbase.security.access.AccessController.permissionGranted(AccessController.java:325)     at org.apache.hadoop.hbase.security.access.AccessController.internalPreRead(AccessController.java:1337)     at org.apache.hadoop.hbase.security.access.AccessController.preGetOp(AccessController.java:1422)     at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$19.call(RegionCoprocessorHost.java:866)     at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$19.call(RegionCoprocessorHost.java:863)     at org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:581)     at org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:655)     at org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.preGet(RegionCoprocessorHost.java:863)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2905)     at org.apache.hadoop.hbase.regionserver.RSRpcServices.get(RSRpcServices.java:2844)     at org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42274)     at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:458)     at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)     at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)" Add 1.7.2 to download page,13475879,Resolved,Major,Fixed,09/Aug/22 06:45,09/Aug/22 08:17,, Consider bloom filter alternates,13474667,Open,Major,,02/Aug/22 09:52,,,"The XOR filter https://arxiv.org/pdf/1912.08258.pdf The Ribbon filter https://arxiv.org/pdf/2103.02515.pdf We could see if we can integrate these new data structure in HBase to replace the usage of bloom filter." Put up 1.7.2RC0,13474388,Resolved,Major,Fixed,31/Jul/22 12:19,09/Aug/22 06:45,, Should stop autoRead and skip all the bytes when rpc request too big,13475292,Resolved,Major,Fixed,05/Aug/22 06:09,06/Aug/22 12:45,,"We want to write RequestTooBigException back to client so we will not close the channel immediately after we foud a too big request, but then we will not skip all the bytes so it will casue the decode still running, and also client could still send more bytes which generate a lot of loads on the rpc server, before we finally close the channel." The implementation of TestReplicationStatus.waitOnMetricsReport is incorrect,13474902,Resolved,Major,Fixed,03/Aug/22 14:49,04/Aug/22 15:23,,"{code} private List waitOnMetricsReport(int greaterThan, ServerName serverName) throws IOException { ClusterMetrics metrics = hbaseAdmin.getClusterMetrics(EnumSet.of(Option.LIVE_SERVERS)); List list = metrics.getLiveServerMetrics().get(serverName).getReplicationLoadSourceList(); while (list.size() <= greaterThan) { Threads.sleep(1000); } return list; } {code} Obviously the while loop is just a dummy one as the list will not be updated in the loop..." BufferCallBeforeInitHandler should ignore the flush request,13474910,Resolved,Major,Fixed,03/Aug/22 15:28,04/Aug/22 15:22,,"This is by design but we failed to do this in the past and caused others rely on this mistake, such as NettyHBaseRpcConnectionHeaderHandler, where we should add it before BufferCallBeforeInitHandler but we add it after BufferCallBeforeInitHandler ..." Generate CHANGES.txt for 1.7.2,13474387,Resolved,Major,Fixed,31/Jul/22 12:18,03/Aug/22 09:43,, Set version as 1.7.2 in branch-1 in prep for first RC of 1.7.2,13474386,Resolved,Major,Fixed,31/Jul/22 12:17,02/Aug/22 08:18,, Computed argLine not passed through to surefire configuration,13474289,Resolved,Major,Invalid,30/Jul/22 01:10,01/Aug/22 16:08,,See PR. Maybe I am missing something. Release 1.7.2,13474385,Open,Major,,31/Jul/22 12:09,,, Rewrite NettyRpcServer to decode rpc request with netty handler,13470715,Resolved,Major,Fixed,08/Jul/22 14:20,28/Jul/22 09:38,,"This is a follow on issue of HBASE-26708. The memory leaks happens in the saslReadAndProcess method. It does not follow a typical netty style so it is more likely to introduce bugs. Since we agree that NettyRpcServer is the future and SimpleRpcServer should be deprecated and finally removed, let's first implement dedicated rpc request decoder for netty." TestPerTableCFReplication.testParseTableCFsFromConfig is broken because of ReplicationPeerConfigUtil.parseTableCFsFromConfig,13473774,Resolved,Major,Fixed,27/Jul/22 12:00,28/Jul/22 00:59,3.0.0-alpha-4,"HBASE-27203 has modified {{ReplicationPeerConfigUtil.parseTableCFsFromConfig}} which causes {{TestPerTableCFReplication.testParseTableCFsFromConfig}} broken." Clean up error-prone findings in hbase-client,13471487,Resolved,Major,Fixed,14/Jul/22 01:00,27/Jul/22 23:06,, Clean up error-prone findings in hbase-hbtop,13473177,Resolved,Major,Fixed,25/Jul/22 06:04,27/Jul/22 01:08,, Clean up error-prone findings in hbase-endpoint,13471853,Resolved,Major,Fixed,16/Jul/22 01:59,27/Jul/22 01:03,, BucketCache statistics should not count evictions by hfile,13472562,Resolved,Major,Fixed,21/Jul/22 00:09,26/Jul/22 21:13,,"The eviction metrics are helpful for determining how much access-related churn there is in your block cache. The LruBlockCache properly ignores evictions by invalidation of HFile, but the BucketCache tracks them.  We should make the BucketCache work similarly so that one can get an accurate view of the evictions occurring through too much random access or too large working set." Backport HBASE-22120 (Replace HTrace with OpenTelemetry) to branch-2.4,13473890,Open,Major,,28/Jul/22 02:00,,2.4.0,"list of commits from upstream/master need to be backported {code:java} HBASE-25373 https://github.com/apache/hbase/commit/302d9ea8b888762a5a20a5ba5c2be7bc239afaef HBASE-25401 https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04 HBASE-25424 https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d HBASE-23898 https://github.com/apache/hbase/commit/805b2ae2ad0f6325515d46043ff01e4e2c7a9f59 HBASE-25454 https://github.com/apache/hbase/commit/dcb78bd4bda4a4ae13d863df8aec266031e5bc93 HBASE-25481 https://github.com/apache/hbase/commit/ae2c62ffaad5ba4c976b0a79c10a365edf2844fd HBASE-25455 https://github.com/apache/hbase/commit/03e12bfa4ad62ecc6eee6a2c68d431bea2d5c473 HBASE-25484 https://github.com/apache/hbase/commit/2be2c63f0d3917a243b74af9754cbfc805b858d1 HBASE-25535 https://github.com/apache/hbase/commit/bb8c4967f8ce2c89ebaf1ddc5d8a1bf55f1e20d3 HBASE-25591 https://github.com/apache/hbase/commit/f6ff519dd0c7fe0e3ae3c175eefee27a26a065a4 HBASE-25617 https://github.com/apache/hbase/commit/8d68f8cd1c8613be1b499eaa99f46806b2743294 HBASE-25616 https://github.com/apache/hbase/commit/8399293e21127df3ffdcb757242e4cb5964c7e99 HBASE-25723 https://github.com/apache/hbase/commit/7f90c2201f6a17d2e2d031505c35ae7c2b1ed7ea HBASE-25732 https://github.com/apache/hbase/commit/8df9bebdd367d52a32b08c18a7cf4f9c2d712071 HBASE-25733 https://github.com/apache/hbase/commit/b71488998970a3353086a34736ed1edab527f673 HBASE-23762 https://github.com/apache/hbase/commit/be4503d9f82f044fbfce21c8a42d0b1684607238 HBASE-25778 https://github.com/apache/hbase/commit/f36e1539648bbaee84c626fd54d1605baebf3c5a {code} " Purge FutureReturnValueIgnored warnings from error prone,13472187,Resolved,Major,Fixed,19/Jul/22 05:26,26/Jul/22 16:15,,"We used to introduce a FutureUtils to purge the FutureReturnValueIgnored warnings in the async client implementation, to make sure we catch the exception from the callback. For netty, we could apply the same trick. And there is another problem for netty that channel.write and some other methods will also return a ChannelFuture but usually we just do nothing on it, this will generated a FutureReturnValueIgnored warning too. We could add a logging listener to log the errors if any." Clean up error-prone findings in hbase-hadoop-compat,13473176,Resolved,Major,Fixed,25/Jul/22 06:02,26/Jul/22 00:32,, Fix checking for encoded block size when deciding if block should be closed,13472681,Resolved,Major,Fixed,21/Jul/22 12:35,25/Jul/22 13:27,2.4.13,"On HFileWriterImpl.checkBlockBoundary, we useed to consider the unencoded and uncompressed data size when deciding to close a block and start a new one. That could lead to varying ""on-disk"" block sizes, depending on the encoding efficiency for the cells in each block. HBASE-17757 introduced the hbase.writer.unified.encoded.blocksize.ratio property, as ration of the original configured block size, to be compared against the encoded size. This was an attempt to ensure homogeneous block sizes. However, the check introduced by HBASE-17757 also considers the unencoded size, which in the cases where encoding efficiency is higher than what's configured in hbase.writer.unified.encoded.blocksize.ratio, it would still lead to varying block sizes. This patch changes that logic, to only consider encoded size if hbase.writer.unified.encoded.blocksize.ratio property is set, otherwise, it will consider the unencoded size. This gives a finer control over the on-disk block sizes and the overall number of blocks when encoding is in use." Avoid data inconsistent between primary and secondary replicas for the new region replication framework,13472238,Resolved,Major,Won't Fix,19/Jul/22 09:54,22/Jul/22 02:40,3.0.0-alpha-3,"For the new region replication framework introduced by HBASE-26233, when we write the {{Mutation}} on primary region replica , if {{HRegion.doMiniBatchMutate}} throws a exception, for example ,{{WAL.sync}} throws a {{TimeoutIOException}} because sync timeout, the writing on primary region replica is failed and we could not query the {{Mutation}} on the primary region replica because of {{Mutation}} is not written to the {{MemStore}}, but the replication to the second replica may be successful because we always execute {{MultiVersionConcurrencyControl.WriteEntry.runCompletionAction}} in {{MultiVersionConcurrencyControl.complete}} , and we could get the {{Mutation}} on the secondary region replica, this inconsistency should be avoid even if it is short. But for {{WALUtil.writeMarker}}, we should always replicate to the second replica even though {{WAL.sync}} is failed, because we just want to sync region state to secondary replica." Apply the spotless format change in HBASE-27208 to our code base,13472163,Resolved,Major,Fixed,19/Jul/22 01:31,19/Jul/22 02:14,, Use spotless to purge the missing summary warnings from error prone,13471803,Resolved,Major,Fixed,15/Jul/22 15:06,19/Jul/22 01:54,,"https://github.com/google/error-prone/blob/master/docs/bugpattern/javadoc/MissingSummary.md We could use replaceRegex step to purge these warnings." Clean up netty worker/thread pool configuration,13471274,Resolved,Major,Fixed,12/Jul/22 18:45,19/Jul/22 01:16,2.5.0,"Refer to https://issues.apache.org/jira/browse/HBASE-27112?focusedCommentId=17565952&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17565952 {quote} ""server instanceof HRegionServer"" will be true for both HMaster and HRegionServer classes, hence it seems we are only using ""hbase.netty.worker.count"" essentially during both master and regionservers Netty server initialization. ""hbase.netty.eventloop.rpcserver.thread.count"" is used for bunch of other implementations of Server interface (used in UTs only) {quote}" Clean up error-prone findings in hbase-balancer,13471486,Resolved,Major,Fixed,14/Jul/22 00:44,18/Jul/22 22:36,, Clean up error-prone findings in hbase-archetypes,13471481,Resolved,Major,Fixed,13/Jul/22 23:36,18/Jul/22 22:31,, Clean up error-prone findings in hbase-asyncfs,13471478,Resolved,Major,Not A Problem,13/Jul/22 22:36,18/Jul/22 22:31,, Add ScanMetrics to slow log record,13471845,Open,Major,,15/Jul/22 20:54,,,"It would be useful to include aspects of the response in the slowlog record. For scans it would be useful to include the ScanMetrics, if available. That might give insight into rows filtered, etc." "When Hbase uses GET to query data, some rowkeys cannot be queried，ERROR: java.io.TOException: java.lang.NoclassDefFoundError: org/apache/hadoop/hdfs/DFSInputStreamS2",13470654,Closed,Major,Not A Bug,08/Jul/22 09:00,15/Jul/22 13:25,,!image-2022-07-08-16-59-52-808.png! The retry number for TestSeparateClientZKCluster is too small,13471132,Resolved,Major,Fixed,12/Jul/22 06:33,14/Jul/22 00:57,,"The retry number is only 2, checking the log output, we will fail the request within 600ms, which is too small in testMetaMoveDuringClientZkClusterRestart, as in this method we will shutdown the client zookeeper, the retry interval when updating zookeeper is way more greater, usually several seconds. For example {noformat} 2022-07-11T00:51:09,998 DEBUG [ClientZKUpdater-/hbase/meta-region-server] zookeeper.RecoverableZooKeeper(303): Retry, connectivity issue (JVM Pause?); quorum=localhost:21828,exceptionorg.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/meta-region-server= 2022-07-11T00:51:11,187 DEBUG [ClientZKUpdater-/hbase/meta-region-server] zookeeper.RecoverableZooKeeper(303): Retry, connectivity issue (JVM Pause?); quorum=localhost:21828,exceptionorg.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/meta-region-server= 2022-07-11T00:51:13,617 WARN [HBase-Metrics2-1] impl.MetricsConfig(136): Cannot locate configuration: tried hadoop-metrics2-hbase.properties,hadoop-metrics2.properties 2022-07-11T00:51:13,852 DEBUG [HBase-Metrics2-1] regionserver.MetricsTableSourceImpl(130): Creating new MetricsTableSourceImpl for table 'hbase:meta' 2022-07-11T00:51:13,853 DEBUG [HBase-Metrics2-1] regionserver.MetricsTableSourceImpl(130): Creating new MetricsTableSourceImpl for table 'testAsyncTable' 2022-07-11T00:51:13,854 DEBUG [HBase-Metrics2-1] regionserver.MetricsTableSourceImpl(130): Creating new MetricsTableSourceImpl for table 'testMetaMoveDuringClientZkClusterRestart' 2022-07-11T00:51:14,124 ERROR [ClientZKUpdater-/hbase/meta-region-server] zookeeper.RecoverableZooKeeper(300): ZooKeeper setData failed after 2 attempts 2022-07-11T00:51:14,124 DEBUG [ClientZKUpdater-/hbase/meta-region-server] zksyncer.ClientZKSyncer(179): Failed to set data for /hbase/meta-region-server to client ZK, will retry later org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/meta-region-server at org.apache.zookeeper.KeeperException.create(KeeperException.java:102) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:2384) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.setData(RecoverableZooKeeper.java:428) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:558) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:603) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.ZKUtil.setData(ZKUtil.java:597) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer.setDataForClientZkUntilSuccess(ClientZKSyncer.java:175) ~[classes/:?] at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer.access$300(ClientZKSyncer.java:45) ~[classes/:?] at org.apache.hadoop.hbase.master.zksyncer.ClientZKSyncer$ClientZkUpdater.run(ClientZKSyncer.java:319) ~[classes/:?] {noformat} The first retry log is at 09.998, the second one is at 11.187, and the third one is at 14.124. Let's just remove the line which set retry number to 2." Add test coverage for SimpleRpcServer,13471267,Resolved,Major,Fixed,12/Jul/22 18:06,13/Jul/22 19:01,,"Add test coverage for SimpleRpcServer. Improve the way we test both SimpleRpcServer and NettyRpcServer: Use LoadTestKVGenerator to generate random values with varying sizes between 1000 bytes and 1M bytes, and also to verify them when reading the values back. Add secure test coverage for both SimpleRpcServer and NettyRpcServer." TestZooKeeper is flaky,13471210,Resolved,Major,Fixed,12/Jul/22 11:41,13/Jul/22 02:54,,"https://nightlies.apache.org/hbase/HBase-Flaky-Tests/master/3847/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.TestZooKeeper-output.txt Found this in the log output {noformat} 2022-07-11T20:46:34,839 ERROR [zk-event-processor-pool-0] master.HMaster(3054): Master server abort: loaded coprocessors are: [org.apache.hadoop.hbase.coprocessor.MultiRowMutationEndpoint] 2022-07-11T20:46:34,839 ERROR [zk-event-processor-pool-0] master.HMaster(3059): ***** ABORTING master jenkins-hbase19.apache.org,44207,1657572391676: Received an unexpected KeeperException, aborting ***** org.apache.zookeeper.KeeperException$SessionExpiredException: KeeperErrorCode = Session expired for /hbase/master at org.apache.zookeeper.KeeperException.create(KeeperException.java:134) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.zookeeper.KeeperException.create(KeeperException.java:54) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:2021) ~[zookeeper-3.5.7.jar:3.5.7] at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:262) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:250) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.ZKUtil.watchAndCheckExists(ZKUtil.java:108) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.master.ActiveMasterManager.handleMasterNodeChange(ActiveMasterManager.java:197) ~[classes/:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.master.ActiveMasterManager.handle(ActiveMasterManager.java:130) ~[classes/:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.master.ActiveMasterManager.nodeDeleted(ActiveMasterManager.java:125) ~[classes/:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$processEvent$0(ZKWatcher.java:574) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:187) ~[hbase-common-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:177) ~[hbase-common-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.ZKWatcher.processEvent(ZKWatcher.java:556) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.zookeeper.ZKWatcher.lambda$process$1(ZKWatcher.java:609) ~[hbase-zookeeper-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at org.apache.hadoop.hbase.trace.TraceUtil.lambda$tracedRunnable$2(TraceUtil.java:155) ~[hbase-common-3.0.0-alpha-4-SNAPSHOT.jar:3.0.0-alpha-4-SNAPSHOT] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_291] at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_291] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_291] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_291] at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_291] 2022-07-11T20:46:34,839 DEBUG [Listener at localhost.localdomain/39949] master.HMaster(3049): Abort called but aborted=true, stopped=false 2022-07-11T20:46:34,839 INFO [zk-event-processor-pool-0] master.HMaster(3153): ***** STOPPING master 'jenkins-hbase19.apache.org,44207,1657572391676' ***** 2022-07-11T20:46:34,840 INFO [zk-event-processor-pool-0] master.HMaster(3155): STOPPED: Stopped by zk-event-processor-pool-0 {noformat} So the problem here is that, we call abort manually in UT, but it is possible that after closing zookeeper client, the master itself will call abort in some background threads, and there is a race that, the abortedRequested is set, but stopped is not set while we call abort manually, so we will return immediately and once we check for master.isStopped, it is still false, as the log output above. It is just a test issue. Let me provide a very simple patch to fix it, just a wait is enough..." Multiple possible buffer leaks,13470185,Resolved,Major,Fixed,05/Jul/22 17:50,08/Jul/22 00:35,,When using ByteBuf you need to be very careful about releasing it as otherwise you might leak data. There are various places in the code-base where such a leak could happen as the buffer is not correctly released Rework tracing configuration,13470336,Resolved,Major,Fixed,06/Jul/22 12:29,11/Jul/22 12:38,2.5.0,"I'd like to make some adjustments to how we manage tracing configuration in `conf/hbase-env.sh`. I'd like to take advantage of the fact that OpenTelemetry can read its configuration from environment variables and make use of this where possible, only falling back to passing properties into the process launch configuration when it's necessary. I think this will DRY up tracing configuration and make it easier to manage in a container environment." Add some docs about exporting and importing snapshots using Aliyun object storage service(OSS),13470913,Resolved,Major,Fixed,11/Jul/22 05:53,11/Jul/22 13:13,3.0.0-alpha-3,"[Aliyun Object Storage Service|https://www.aliyun.com/product/oss](Aliyun OSS) is widely used, particularly popular among China’s cloud users, and it provides cloud object storage for a variety of use cases. [Hadoop file system|http://hadoop.apache.org/docs/current/hadoop-aliyun/tools/hadoop-aliyun/index.html] supports OSS since version 2.9.1. Now, we can export and import snapshots using Aliyun object storage service(OSS)." Support regionserver to connect to HMaster proxy port,13470620,Resolved,Major,Won't Fix,08/Jul/22 05:29,09/Jul/22 18:10,,"Regionservers get active master address from Zookeeper/Master registry and tries to make RPC calls to master. For security concerns, regionservers might require making connection to a different proxy port of master rather than it's original port retrieved from Zookeeper. Configs: # hbase.master.expose.proxy.port: Master can use this config (int) to expose new proxy port on active and backup master znodes. # hbase.client.consume.master.proxy.port: Clients/Regionservers can use this config (boolean) to determine whether to connect to active master on new proxy port that master has exposed or continue using original port of master for connection." "master.HMaster: Failed to become active master , after reboot the hosts",13470804,Open,Major,,09/Jul/22 12:53,,,"2022-07-09 20:17:02,408 INFO  [ReadOnlyZKClient-hadoop01:2181,hadoop02:2181,hadoop03:2181@0x23c8e44a-SendThread(hadoop01:2181)] zookeeper.ClientCnxn: Socket connection established, initiating session, client: /172.19.21.101:57094, server: hadoop01/172.19.21.101:2181 2022-07-09 20:17:02,409 INFO  [ReadOnlyZKClient-hadoop01:2181,hadoop02:2181,hadoop03:2181@0x23c8e44a-SendThread(hadoop01:2181)] zookeeper.ClientCnxn: Session establishment complete on server hadoop01/172.19.21.101:2181, sessionid = 0xff81e2d459f50248, negotiated timeout = 40000 2022-07-09 20:17:02,434 INFO  [master/hadoop01:16000:becomeActiveMaster] region.MasterRegion: Create or load local region for table 'master:store', \{NAME => 'proc', BLOOMFILTER => 'ROW', IN_MEMORY => 'false', VERSIONS => '1', KEEP_DELETED_CELLS => 'FALSE', DATA_BLOCK_ENCODING => 'NONE', COMPRESSION => 'NONE', TTL => 'FOREVER', MIN_VERSIONS => '0', BLOCKCACHE => 'true', BLOCKSIZE => '65536', REPLICATION_SCOPE => '0'}ZIZIaUaUaU 2022-07-09 20:17:02,437 INFO  [master/hadoop01:16000:becomeActiveMaster] region.MasterRegionFlusherAndCompactor: Injected flushSize=134217728, flushPerChanges=1000000, flushIntervalMs=900000 2022-07-09 20:17:02,486 INFO  [master/hadoop01:16000:becomeActiveMaster] wal.WALFactory: Instantiating WALProvider of type class org.apache.hadoop.hbase.wal.AsyncFSWALProvider 2022-07-09 20:17:02,522 ERROR [master/hadoop01:16000:becomeActiveMaster] master.HMaster: Failed to become active master java.lang.ArrayIndexOutOfBoundsException: 0         at org.apache.hadoop.hbase.master.region.MasterRegion.open(MasterRegion.java:222)         at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:309)         at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:104)         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:948)         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2240)         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:621)         at java.lang.Thread.run(Thread.java:748) 2022-07-09 20:17:02,523 ERROR [master/hadoop01:16000:becomeActiveMaster] master.HMaster: ***** ABORTING master hadoop01,16000,1657369019206: Unhandled exception. Starting shutdown. ***** java.lang.ArrayIndexOutOfBoundsException: 0         at org.apache.hadoop.hbase.master.region.MasterRegion.open(MasterRegion.java:222)         at org.apache.hadoop.hbase.master.region.MasterRegion.create(MasterRegion.java:309)         at org.apache.hadoop.hbase.master.region.MasterRegionFactory.create(MasterRegionFactory.java:104)         at org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:948)         at org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2240)         at org.apache.hadoop.hbase.master.HMaster.lambda$run$0(HMaster.java:621)         at java.lang.Thread.run(Thread.java:748) 2022-07-09 20:17:02,523 INFO  [master/hadoop01:16000:becomeActiveMaster] regionserver.HRegionServer: ***** STOPPING region server 'hadoop01,16000,1657369019206' ***** 2022-07-09 20:17:02,523 INFO  [master/hadoop01:16000:becomeActiveMaster] regionserver.HRegionServer: STOPPED: Stopped by master/hadoop01:16000:becomeActiveMaster 2022-07-09 20:17:02,523 INFO  [master/hadoop01:16000] regionserver.HRegionServer: Stopping infoServer 2022-07-09 20:17:02,529 INFO  [master/hadoop01:16000] handler.ContextHandler: Stopped o.e.j.w.WebAppContext@648d0e6d\{/,null,UNAVAILABLE}{file:/home/hadoop/app/hbase-2.3.5/hbase-webapps/master}pOpPpP 2022-07-09 20:17:02,534 INFO  [master/hadoop01:16000] server.AbstractConnector: Stopped ServerConnector@512d6e60\{HTTP/1.1,[http/1.1]}qPqPqP\{0.0.0.0:16010}xI 2022-07-09 20:17:02,534 INFO  [master/hadoop01:16000] handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@a66e580\{/static,file:///home/hadoop/app/hbase-2.3.5/hbase-webapps/static/,UNAVAILABLE} 2022-07-09 20:17:02,534 INFO  [master/hadoop01:16000] handler.ContextHandler: Stopped o.e.j.s.ServletContextHandler@352c44a8\{/logs,file:///home/hadoop/app/hbase-2.3.5/logs/,UNAVAILABLE} 2022-07-09 20:17:02,535 INFO  [master/hadoop01:16000] regionserver.HRegionServer: aborting server hadoop01,16000,1657369019206 2022-07-09 20:17:02,535 INFO  [master/hadoop01:16000] regionserver.HRegionServer: stopping server hadoop01,16000,1657369019206; all regions closed. 2022-07-09 20:17:02,535 INFO  [master/hadoop01:16000] hbase.ChoreService: Chore service for: master/hadoop01:16000 had [] on shutdown 2022-07-09 20:17:02,536 WARN  [master/hadoop01:16000] master.ActiveMasterManager: Failed get of master address: java.io.IOException: Can't get master address from ZooKeeper; znode data == null 2022-07-09 20:17:02,537 INFO  [master/hadoop01:16000] hbase.ChoreService: Chore service for: hadoop01:16000.splitLogManager. had [ScheduledChore name=SplitLogManager Timeout Monitor, period=1000, unit=MILLISECONDS] on shutdown 2022-07-09 20:17:02,537 INFO  [master/hadoop01:16000] ipc.NettyRpcServer: Stopping server on /172.19.21.101:16000 2022-07-09 20:17:02,638 INFO  [ReadOnlyZKClient-hadoop01:2181,hadoop02:2181,hadoop03:2181@0x23c8e44a] zookeeper.ZooKeeper: Session: 0xff81e2d459f50248 closed 2022-07-09 20:17:02,638 INFO  [ReadOnlyZKClient-hadoop01:2181,hadoop02:2181,hadoop03:2181@0x23c8e44a-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0xff81e2d459f50248 2022-07-09 20:17:02,737 INFO  [master/hadoop01:16000] zookeeper.ZooKeeper: Session: 0xff81e2d459f50246 closed 2022-07-09 20:17:02,737 INFO  [main-EventThread] zookeeper.ClientCnxn: EventThread shut down for session: 0xff81e2d459f50246 2022-07-09 20:17:02,737 INFO  [master/hadoop01:16000] regionserver.HRegionServer: Exiting; stopping=hadoop01,16000,1657369019206; zookeeper connection closed. 2022-07-09 20:17:02,738 ERROR [main] master.HMasterCommandLine: Master exiting java.lang.RuntimeException: HMaster Aborted         at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMasterCommandLine.java:261)         at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:149)         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)         at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)         at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3085)" Upgrade OpenTelemetry dependency to 1.15.0,13469667,Resolved,Major,Fixed,01/Jul/22 13:50,06/Jul/22 11:56,2.5.0,"Current release versions of the SDK and agent libraries is 1.15.0. The newer SDK has some nice API ergonomics improvements that we could adopt." Add major compact table or region operation on master web table page,13477614,Resolved,Minor,Fixed,19/Aug/22 14:11,12/Nov/22 13:15,,"Add major compact table or region operation on master web table page !image-2022-09-22-02-32-36-619.png!" Update downloads.xml for release 2.4.13,13469719,Resolved,Minor,Fixed,01/Jul/22 19:18,01/Jul/22 19:51,, Support using IP to expose master/rs servers for some special scenarios,13476867,Resolved,Minor,Fixed,15/Aug/22 16:02,25/Sep/22 14:50,3.0.0-alpha-4,"In our environment, when accessing the HBase cluster from another cluster (such as the Flink cluster), you cannot use the hostname to access the HBase cluster, but you can use IP. Because it is possible that the hostname of the HBase cluster automatic expansion node is not maintained in the Flink cluster. So we should support using IP to expose master/rs servers for this special scenarios.  " RitDuration histogram metric is broken,13482453,Open,Minor,,20/Sep/22 19:41,,2.5.0,"Looks like the method which updates it in MetricsAssignmentManager, updateRitDuration, got broken somewhere along the way. It's no longer used. We should wire this back up. https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsAssignmentManager.java#L82" Add timeout to JavaRegexEngine,13478117,Open,Minor,,23/Aug/22 04:10,,,"Java regular expression engine is based on backtracking. Thus, a malicious regular expression may result in a ReDoS. When ReDoS occurs in the HBase, the region server's handler is occupied as a result it cannot process the user's request. It would be nice to have a timeout for system protection. The engine does not have timeout. The charAt method is called during pattern matching, and the charAt method checks if it is timeout. " fix typo: docs of StealJobQueue,13478749,Open,Minor,,26/Aug/22 06:57,,2.4.13,"{code:java} * steal-from queue if this q ueue is empty. {code}" Separate meta read requests from master and client ,13479901,Open,Minor,,02/Sep/22 14:31,,3.0.0-alpha-3,"If we have a large number of store files in a single region or the response from hdfs is slow, the region transition can be slow, the client may put a lot of pressure on the meta server when retrying. This may block the master system read requests. Maybe we can set a special priority for the master request to isolate read requests from master and client." Fix sonar report paths,13475919,Resolved,Minor,Fixed,09/Aug/22 09:21,15/Aug/22 08:54,,Sonar XML report paths are not set correctly for jacoco and scoverage. MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names,13473835,Resolved,Minor,Fixed,27/Jul/22 17:25,08/Mar/23 13:47,2.4.13,"MasterRpcServices#setRegionStateInMeta does not support replica region names, it assumes the primary region only. This makes HBCK2's setRegionState for replica region fails. " MetricsSource lastShippedTimeStamps ConcurrentModificationException cause RegionServer crash,13482802,In Progress,Minor,,22/Sep/22 15:31,,,"022-09-20 14:14:40,332 ERROR [regionserver/hostname1:16020] regionserver.HRegionServer: ***** ABORTING region server hostname1,16020,1663147531495: Unhandled: null *****  8587 java.util.ConcurrentModificationException  8588     at java.util.HashMap$HashIterator.nextNode(HashMap.java:1442)  8589     at java.util.HashMap$ValueIterator.next(HashMap.java:1471)  8590     at org.apache.hadoop.hbase.replication.regionserver.MetricsSource.getTimestampOfLastShippedOp(MetricsSource.java:321)  8591     at org.apache.hadoop.hbase.replication.regionserver.ReplicationLoad.buildReplicationLoad(ReplicationLoad.java:80)  8592     at org.apache.hadoop.hbase.replication.regionserver.Replication.buildReplicationLoad(Replication.java:264)  8593     at org.apache.hadoop.hbase.replication.regionserver.Replication.refreshAndGetReplicationLoad(Replication.java:253)  8594     at org.apache.hadoop.hbase.regionserver.HRegionServer.buildServerLoad(HRegionServer.java:1436)  8595     at org.apache.hadoop.hbase.regionserver.HRegionServer.tryRegionServerReport(HRegionServer.java:1243)  8596     at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1065)" BufferedMutator#mutate supports mutation type verification,13481330,Open,Minor,,13/Sep/22 15:44,,3.0.0-alpha-4,"At present, BufferedMutator#mutate method only tell the user in the comment that it only supports Put / Delete.  But it is not verified in the code implementation, so we need to deal with it." Add Move table to Target Group on master web,13477611,In Progress,Minor,,19/Aug/22 14:07,,,Move table to Target Group on master web Artifacts with resolved profiles,13478948,Resolved,Minor,Fixed,27/Aug/22 23:46,06/Sep/22 15:07,,"Brainstorming/Discussion. The maven-flatten-plugin makes it so published poms are 'flattened'. The poms contain the runtime-necessary dependencies only, 'build' and 'test' dependencies and plugins are dropped, versions are resolved out of properties, and so on. The published poms are the barebones minimum needed to run. With a switch, the plugin can also make it so the produced poms have all profiles 'resolved' – making it so the produced poms have all resolved hadoop2 or hadoop3 dependencies baked-in – based off which profile we used building. (I've been interested in this flattening technique since I ran into a downstreamer using hbase from a gradle build. Gradle does not respect profiles. You can't specify that the gradle build pull in hbase with hadoop3 dependencies using 'profiles'. I notice too our [~gjacoby] , [~apurtell] et al. up on the dev list talking about making a hadoop3 set of artifacts...who might be interested in this direction). The attached patch adds the flatten plugin so folks can take a look-see. It uncovers some locations where our versioning on dependencies is not explicit. The workaround practiced here was adding hadoop2/hadoop3 profiles into sub-modules that were missing them or moving problematic dependencies that were outside of profiles under profiles in sub-modules that had them already. For the latter, if the dependency specified excludes, the excludes were moved up to the parent pom profile (parent pom profiles have dependencyManagement sections... sub-modules have explicit dependency mentions... checks with dependency:tree seem to show excludes continue to be effective). This is the switch that flattens profiles:           true This is the sort of complaint we had when the flatten plugin was having trouble figure dependency versions – particularly hadoop versions {{[ERROR] Failed to execute goal org.codehaus.mojo:flatten-maven-plugin:1.3.0:flatten (flatten) on project hbase-hadoop2-compat: 3 problems were encountered while building the effective model for org.apache.hbase:hbase-hadoop2-compat:2.5.1-SNAPSHOT}} {{[ERROR] [WARNING] 'build.plugins.plugin.version' for org.codehaus.mojo:flatten-maven-plugin is missing. @}} {{[ERROR] [ERROR] 'dependencies.dependency.version' for org.apache.hadoop:hadoop-mapreduce-client-core:jar is missing. @}} {{[ERROR] [ERROR] 'dependencies.dependency.version' for javax.activation:javax.activation-api:jar is missing. @}}" Time based metrics will be reset after any get request,13478160,Open,Minor,,23/Aug/22 08:15,,2.4.13,"Jmx metrics can be query by http request. But metrics will be reset after any get request. The root cause may be the implement of Histogram's method ""snapshot"" {code:java} @Override public Snapshot snapshot() { return histogram.snapshotAndReset(); } {code} It will call snapshot and reset at the same time. I think it should not be reset cause we may need history metrics." Spark-hbase support for 'startWith' predicate.,13483552,Resolved,Minor,Fixed,27/Sep/22 23:10,29/Nov/22 12:30,3.0.0-alpha-3,"Currently, spark-hbase connector doesn't support stringStartWith predicate and completely ignores it. This is a disadvantage compared to the Apache Phoenix connector and the old SHC (Hortonworks spark-hbase connector). It would be nice if we also have this functionality in the actual connector." numOpenConnections metric is one less than the actual ,13482258,Resolved,Minor,Fixed,20/Sep/22 02:02,16/Nov/22 09:26,2.0.0,"In HBASE-17263，serverChannel add to allChannels，so NumOpenConnections exclude serverChannel from the count. {code:java} public NettyRpcServer(final Server server, final String name, final List services, final InetSocketAddress bindAddress, Configuration conf, RpcScheduler scheduler) throws IOException { super(server, name, services, bindAddress, conf, scheduler); ... try { serverChannel = bootstrap.bind(this.bindAddress).sync().channel(); LOG.info(""NettyRpcServer bind to address="" + serverChannel.localAddress() + "", hbase.netty.rpc.server.worker.count="" + workerCount + "", useEpoll="" + useEpoll); allChannels.add(serverChannel); } catch (InterruptedException e) { throw new InterruptedIOException(e.getMessage()); } ... } @Override public int getNumOpenConnections() { // allChannels also contains the server channel, so exclude that from the count. return allChannels.size() - 1; }{code} In HBASE-17263，serverChannel not add to allChannels，so NumOpenConnections  is one less than the actual. {code:java} public NettyRpcServer(Server server, String name, List services, InetSocketAddress bindAddress, Configuration conf, RpcScheduler scheduler) throws IOException { ... try { serverChannel = bootstrap.bind(this.bindAddress).sync().channel(); LOG.info(""NettyRpcServer bind to address="" + serverChannel.localAddress()); } catch (InterruptedException e) { throw new InterruptedIOException(e.getMessage()); } ... } {code} In HBASE-21610, I think it's actually influenced by this bug.  " Improve sasl connection failure log message to include server,13478874,Resolved,Minor,Fixed,26/Aug/22 20:18,11/Oct/22 19:09,1.7.2,"We were seeing timeout issues in our deployment in the saslConnect path in the blockingRPC client.  Knowing which server we failed to connect to would help isolate and understand the issue.     {code:java} ipc.BlockingRpcConnection - Exception encountered while connecting to the server : java.io.IOException: Connection reset by peer {code}     Change the log message to something like   {code:java} ipc.BlockingRpcConnection - Exception encountered while connecting to the server myhost.realm.net: java.io.IOException: Connection reset by peer {code}   See relevant code [here|https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java#L398]" Backport HBASE-27064 to branch 2.4,13482665,Resolved,Minor,Fixed,22/Sep/22 00:54,27/Sep/22 06:01,2.4.14,{*}Error: java.util.ConcurrentModificationException{*}{{{}java.util.concurrent.ExecutionException: java.util.ConcurrentModificationException at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928) at org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.testTake(TestRegionNormalizerWorkQueue.java:211) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.apache.hadoop.hbase.SystemExitRule$1.evaluate(SystemExitRule.java:39) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:750) Caused by: java.util.ConcurrentModificationException at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719) at java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742) at org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorkQueue.take(RegionNormalizerWorkQueue.java:192) at org.apache.hadoop.hbase.master.normalizer.TestRegionNormalizerWorkQueue.lambda$testTake$3(TestRegionNormalizerWorkQueue.java:192) at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1640) at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1632) at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175){}}} Adding description to Prometheus metrics,13483465,Resolved,Minor,Fixed,27/Sep/22 13:51,07/Oct/22 09:36,2.6.0,As /jmx endpoint provides enabling description for metrics by using 'description=true' URL parameter I would like to implement this feature for the /prometheus endpoint as well. Remove dumping of EOFException while reading WAL with ProtobufLogReader,13483721,Resolved,Minor,Won't Fix,28/Sep/22 18:59,05/Oct/22 00:04,,"The log processing tooling that helps extract and analyze Exceptions from regionserver logs can read EOFException while reseting seeking to original position as part of ProtobufLogReader implementation. Common logs: {code:java} 2022-09-28 17:02:00,288 DEBUG [20%2C1664323516467,1] wal.ProtobufLogReader - Encountered a malformed edit, seeking back to last good position in file, from 187159 to 187158 java.io.EOFException: Partial PB while reading WAL, probably an unexpected EOF, ignoring. current offset=187159 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:390) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:104) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:92) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:258) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:172) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.tryAdvanceStreamAndCreateWALBatch(ReplicationSourceWALReader.java:251) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:148) {code} {code:java} 2022-09-28 11:02:10,792 DEBUG [20%2C1664323193648,1] wal.ProtobufLogReader - Encountered a malformed edit, seeking back to last good position in file, from 112026775 to 112026303 java.io.EOFException: EOF while reading 296 WAL KVs; started reading at 112026367 and read up to 112026775 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:418) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:104) at org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:92) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:258) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:172) at org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.readWALEntries(ReplicationSourceWALReader.java:222) at org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceWALReader.run(ReplicationSourceWALReader.java:157) Caused by: java.io.EOFException: Only read 6 at org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:406) ... 7 more {code} After looking at these logs, it seems that having EOFException even at DEBUG level is not helping much because reseting seek to a different position is going to be expected often. We should remove dumping EOFException in these cases." Add balance rsgroup operation on master web table page,13477612,Open,Minor,,19/Aug/22 14:08,,, Add disabled table is displayed red on master web tables list,13477616,Resolved,Minor,Fixed,19/Aug/22 14:19,20/Sep/22 09:19,,"The table of the disabled state is displayed in red The effect is as follows： !image-2022-09-01-14-27-56-145.png!" Correcting the Store file tracker tool help doc option,13478178,Resolved,Minor,Fixed,23/Aug/22 09:29,14/Sep/22 11:46,,"Column family is not an optional parameter, we need to correct the sysout msg properly." Quoted string argument with spaces passed from command line are propagated wrongly to the underlying java class,13479531,Resolved,Minor,Fixed,31/Aug/22 17:26,13/Sep/22 12:44,2.5.0,"Running the following command :  /hbase/bin/hbase org.apache.hadoop.hbase.mapreduce.Import -Dmapreduce.map.java.opts=""-XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=$HADOOP_HOME/logs/@taskid@_map.hprof"" SYSTEM.CATALOG /tmp fails with error. It is due to the fact that [read -r -a CMD_ARGS <<< ""$@"" |https://github.com/apache/hbase/blob/master/bin/hbase#L878] in the hbase script would split the command line args (i.e. ""$@""). Instead a straightforward array copy can be used. !Screenshot 2022-08-31 at 10.52.11 PM.png! " Intra-cluster replication sink metrics,13481120,Open,Minor,,12/Sep/22 14:13,,,"Region replication doesn't emit any sink metrics at the moment, these would be useful in determining replication lag. Adding metrics such as ageOfLastAppliedOp would be helpful." opentelemetry-context jar missing at runtime causes MR jobs to fail,13479629,Resolved,Minor,Fixed,01/Sep/22 09:17,07/Sep/22 18:04,2.5.0,"MR jobs like RowCounter, Import have a dependency on opentelemetry-context via TableInputFormat -> ConnectionFactory -> io.opentelemetry.context.ImplicitContextKeyed which causes these jobs to fail with missing class. This would be an addendum on top of HBASE-25811|(which added opentelemetry-api and opentelemetry-semconv) Error: java.lang.NoClassDefFoundError: io/opentelemetry/context/ImplicitContextKeyed at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:757) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:473) at java.net.URLClassLoader.access$100(URLClassLoader.java:74) at java.net.URLClassLoader$1.run(URLClassLoader.java:369) at java.net.URLClassLoader$1.run(URLClassLoader.java:363) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:362) at java.lang.ClassLoader.loadClass(ClassLoader.java:419) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:365) at java.lang.ClassLoader.loadClass(ClassLoader.java:352) at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:218) at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:131) at org.apache.hadoop.hbase.mapreduce.TableInputFormat.initialize(TableInputFormat.java:193) at org.apache.hadoop.hbase.mapreduce.TableInputFormatBase.createRecordReader(TableInputFormatBase.java:162) at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.(MapTask.java:528) at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:771) at org.apache.hadoop.mapred.MapTask.run(MapTask.java:348) at org.apache.hadoop.mapred.YarnChild$2.run(YarnChild.java:178) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1878) at org.apache.hadoop.mapred.YarnChild.main(YarnChild.java:172) Caused by: java.lang.ClassNotFoundException: io.opentelemetry.context.ImplicitContextKeyed at java.net.URLClassLoader.findClass(URLClassLoader.java:387) at java.lang.ClassLoader.loadClass(ClassLoader.java:419) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:365) at java.lang.ClassLoader.loadClass(ClassLoader.java:352) ... 24 more" Remove RejectedExecutionHandler for long/short compaction thread pools,13478751,Resolved,Minor,Fixed,26/Aug/22 07:00,05/Sep/22 13:18,2.4.13,"As disscussed in https://github.com/apache/hbase/pull/4725 actually the max size of StealJobQueue is bouded by the VM limit of an array, and the OOM exception occurs before the rejection handler. So StealJobQueue is equivalent to be unbounded. I think the RejectionHandler may bring some confusions and make the codes a little puzzle." Change HBCK2's setRegionState() to use HBCK's setRegionStateInMeta(),13470200,Open,Minor,,05/Jul/22 19:41,,2.4.13,"Replica region id is  not recognized by hbck2's setRegionState as it does not show up in meta. We run into cases that it needs to set region state in meta for replica regions in order to fix inconsistency. We ended up writing the state manually into meta table and did a master failover to sync state from meta table.    hbck2's setRegionState needs to support replica region id and handles it nicely. Currently, setRegionState does not use MasterRpcServices#setRegionStateInMeta. There is an issue in setRegionStateInMeta to support replica regions. After that is fixed, and setRegionState uses setRegionStateInMeta to set the region state, it will support replica Id." Online schema migration causes the master to report a very high or negative number of QPS,13480162,Open,Minor,,05/Sep/22 16:53,,2.4.12,"We've seen this a few times when making an online schema change, e.g.: {code:java} alter 'foo', {NAME=>'e',VERSIONS=>'2147483646'} {code} This causes the master to briefly show extremely high QPS per regionserver, and probably causes an integer overflow in the sum. !Screen Shot 2022-09-05 at 18.31.00.png|width=859,height=323! ... !Screen Shot 2022-09-05 at 18.31.06.png|width=856,height=322! This could be related to the issue reported in HBASE-27242." hide some sensitive configuration information in the UI,13478257,Resolved,Minor,Fixed,23/Aug/22 17:09,24/Aug/22 07:21,3.0.0-alpha-3,"In the discussion about how to store keystore/truststore password securely, [~bbeaudreault]  mentioned and I quote here ""I agree that it seems insecure to put it directly into the hbase-site.xml. Another reason is due to the RS UI which (helpfully) can print the entire site configuration. We’d need to make sure the password is excluded from that, but better to remove it from site xml altogether"". I also felt that some sensitive information was exposed in the UI, for example, if we set superuser in the hbase-site.xml, the non-admin users can obtain superuser information and simulate superuser to perform some non-permitted operations on the cluster. So I think maybe we should hide these sensitive information in the UI." brotli compression lib tests fail on arm64,13478866,Resolved,Minor,Fixed,26/Aug/22 18:31,29/Aug/22 16:45,2.5.0,"The brotli tests fail on M1 macs   {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}} {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}} {{[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.33 s <<< FAILURE! - in org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}} {{[ERROR] org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli.test  Time elapsed: 0.225 s  <<< ERROR!}} {{java.lang.UnsatisfiedLinkError: Failed to load Brotli native library}} {{...}}   The lib is installed on this machine. A new release of *[Brotli4j|https://github.com/hyperxpro/Brotli4j]* lib, 1.8.0, done a few days ago fixes the issue... (See [https://github.com/hyperxpro/Brotli4j/pull/34).] I tried it . {{[INFO] -------------------------------------------------------}} {{[INFO]  T E S T S}} {{[INFO] -------------------------------------------------------}} {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}} {{[INFO] Running org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}} {{[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.036 s - in org.apache.hadoop.hbase.io.compress.brotli.TestHFileCompressionBrotli}} {{[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.42 s - in org.apache.hadoop.hbase.io.compress.brotli.TestBrotliCodec}} {{[INFO]}} {{[INFO] Results:}} {{[INFO]}} {{[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0}} {{[INFO]}} {{[INFO]}} {{[INFO] --- maven-surefire-plugin:3.0.0-M6:test (secondPartTestsExecution) @ hbase-compression-brotli ---}} {{[INFO] Tests are skipped.}} {{[INFO]}} {{[INFO] --- maven-jar-plugin:3.2.0:test-jar (default) @ hbase-compression-brotli ---}} {{[INFO] Building jar: /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar}} {{[INFO]}} {{[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ hbase-compression-brotli ---}} {{[INFO] Building jar: /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar}} {{[INFO]}} {{[INFO] --- maven-site-plugin:3.12.0:attach-descriptor (attach-descriptor) @ hbase-compression-brotli ---}} {{[INFO] Skipping because packaging 'jar' is not pom.}} {{[INFO]}} {{[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ hbase-compression-brotli ---}} {{[INFO] Installing /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0.jar to /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.jar}} {{[INFO] Installing /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/pom.xml to /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0.pom}} {{[INFO] Installing /Users/stack/checkouts/hbase/2.5.0RC1/hbase-2.5.0/hbase-compression/hbase-compression-brotli/target/hbase-compression-brotli-2.5.0-tests.jar to /Users/stack/.m2/repository/org/apache/hbase/hbase-compression-brotli/2.5.0/hbase-compression-brotli-2.5.0-tests.jar}} {{[INFO] ------------------------------------------------------------------------}} {{[INFO] BUILD SUCCESS}} {{[INFO] ------------------------------------------------------------------------}} {{[INFO] Total time:  16.805 s}} {{[INFO] Finished at: 2022-08-26T11:30:13-07:00}} {{[INFO] ------------------------------------------------------------------------}}        " Add 2.4.14 to the downloads page,13479176,Resolved,Minor,Fixed,29/Aug/22 20:39,29/Aug/22 22:16,2.4.14, Add support for unsigned varint to Bytes util class,13478815,Open,Minor,,26/Aug/22 11:59,,,"Our current Bytes.vintToBytes accepts a signed long, and the resulting encoded size is larger than it needs to be for small values. For example, Bytes.vintToBytes requires 3 bytes for values over 255, whereas an unsigned implementation can use 2 bytes for up to 16383. This continues across the spectrum, with the current requiring 4 bytes for values over 65535 and an unsigned impl can use 3 bytes up to 2097151, etc. We can pull the implementation from protobuf's CodedInputStream and CodedOutputStream" the bulkload max call queue size can be update to a wrong value,13478437,Resolved,Minor,Fixed,24/Aug/22 14:58,25/Aug/22 03:03,3.0.0-alpha-3,"The configKey can be wrong, because  name.toLowerCase(Locale.ROOT).contains(""bulkLoad"") is always false." Add bulkloadExecutor.resizeQueues,13474906,Resolved,Minor,Fixed,03/Aug/22 15:12,10/Aug/22 16:52,, add an option to skip file splitting when bulkload hfiles,13477068,Resolved,Minor,Fixed,16/Aug/22 13:29,22/Aug/22 14:53,3.0.0-alpha-3,"When bulkload hfiles, if the key range of the hfile does not match the key range of the region, the BulkLoadHFilesTool will split hfile to fit make the key range of the new file match the key range of the region. If there are many files to be split, the load on the BulkLoadHFilesTool will be very high. Sometimes we want to avoid this situation, just directly fail and regenerate new hfiles. Here we try to introduce a new option, When the above problem is encountered, an exception will be thrown and let the upper client handle it." Add Delete addFamilyVersion timestamp verify,13476588,Resolved,Minor,Fixed,12/Aug/22 15:28,15/Aug/22 07:43,, Expose the archive option to end user,13473655,Open,Minor,,27/Jul/22 02:15,,2.5.0,"For the delete table procedure, we already have archive option, but the archive now will already be true and not provided to end user. Actually its valuable to provide this option to the end user because some time, customer does not want this table archived when drop the table, it will waste the storage and time if hbase keep archive the table. Especially for the users who are using AWS s3 or Azure as storage which will take lots time for the rename and delete operation for big tables" "In trace log mode, the client does not print callId/startTime and the server does not print receiveTime",13474790,Resolved,Minor,Fixed,03/Aug/22 02:42,20/Aug/22 13:19,2.5.0,"*Question:* In some scenarios in the production environment, users find that the request latancy is high on the client side, but it is not high on the server side (all through the internal monitor system). In this inconsistent scenario, we want to know if there is a problem with the client or the current network. Therefore, we want to know the time when the server receives the request. However, in Trace mode, no relevant information is printed.   A possible solution is that the client prints callId (so we can associate the corresponding request on the server) and startTime about the request，and the server prints receiveTime about the request. In this way, we can find out at what stage the problem occurs.    The client can even wrap the startTime in the request, and the server can directly collect the time at the network level (netty framework process time and network transmission time and so on) which make it easy to monitor some network level metrics about the client requests." HBase-web adds shortcut operations,13477606,In Progress,Minor,,19/Aug/22 13:53,,,hbase-web adds shortcut operations to improve the operational efficiency of DBA personnel. Correct the comment of list_deadservers method in admin.rb,13476408,Resolved,Minor,Fixed,11/Aug/22 15:45,17/Aug/22 23:36,3.0.0-alpha-4, Some Cell's implementation of toString() such as IndividualBytesFieldCell prints out value and tags which is too verbose,13476449,Resolved,Minor,Fixed,11/Aug/22 20:59,15/Aug/22 16:18,2.4.12,"One of users sees cells >10Mb are logged when over limit at their client log.  Checked the code, toString() behavior is not consistent, mostly does not include values and tags. Change toString() to exclude tags/value." HBASE client add cache used to store non-existent tables that are high frequency accessed ,13476576,Open,Minor,,12/Aug/22 13:40,,,"Table already drop. but the task of operating hbase has not stopped.  A large number of concurrent accesses to non-existing tables cause the CPU of the machine where the meta table is located to be too high and cannot process other requests." WALPrettyPrinter add print timestamp,13473795,Resolved,Minor,Fixed,27/Jul/22 13:42,10/Aug/22 13:38,,"hbase wal  xxxx-wal -p, print include timestamp At first: row=rowA, column=f:c1, type=Delete     value:  cell total size sum: 88   New: row=rowA, column=f:c1, timestamp=1657851212679, type=Delete     value:  cell total size sum: 88" Tool to read the contents of the storefile tracker file,13474528,Resolved,Minor,Fixed,01/Aug/22 12:49,08/Aug/22 14:33,2.6.0,"It will be useful to have a tool that provides an ability to read the contents of the tracker file (.filelist/f1 or f2) Using the hdfs -cat or -text displays the contents of the tracker file in binary and there is no option to show the contents in plain text. {code:java} x[cloudbreak@cod--z4t08rqbuyms-master0 ~]$ sudo hdfs dfs -text s3a://odx-qe-bucket/odx-d7v40h/audit/cod--z4t08rqbuyms/hbase/data/default/one/6126beb5b349a1eee4b92987b78f1058/cf/.filelist/f1 22/04/05 19:51:14 WARN impl.MetricsConfig: Cannot locate configuration: tried hadoop-metrics2-s3a-file-system.properties,hadoop-metrics2.properties 22/04/05 19:51:14 INFO impl.MetricsSystemImpl: Scheduled Metric snapshot period at 10 second(s). 22/04/05 19:51:14 INFO impl.MetricsSystemImpl: s3a-file-system metrics system started 22/04/05 19:51:14 INFO s3a.IDBDelegationTokenBinding: There is no Knox Token available, fetching one from IDBroker... 22/04/05 19:51:14 INFO idbroker.AbstractIDBClient: Authenticating with IDBroker requires Kerberos 22/04/05 19:51:14 INFO idbroker.AbstractIDBClient: Kerberos credentials are available, using Kerberos to establish a session. UGI=hbase/cod--z4t08rqbuyms-master0.odx-d7v4.svbr-nqvp.int.cldr.work@ODX-D7V4.SVBR-NQVP.INT.CLDR.WORK (auth:KERBEROS) Apr 05, 2022 7:51:14 PM org.apache.knox.gateway.shell.KnoxSession createClient INFO: Using default JAAS configuration 22/04/05 19:51:15 INFO s3a.IDBDelegationTokenBinding: Bonded to Knox token eyJqa3...OGdQmQ 22/04/05 19:51:15 INFO Configuration.deprecation: No unit for fs.s3a.connection.request.timeout(0) assuming SECONDS 22/04/05 19:51:15 INFO idbroker.AbstractIDBClient: Creating Knox CAB session using Knox DT eyJqa3...OGdQmQ ... 22/04/05 19:51:16 INFO s3a.S3AInputStream: Switching to Random IO seek policy ⑙��/% 98ef4cf597be48598c8376bc1cac200d�&����22/04/05 19:51:16 INFO impl.MetricsSystemImpl: Stopping s3a-file-system metrics system... 22/04/05 19:51:16 INFO impl.MetricsSystemImpl: s3a-file-system metrics system stopped. 22/04/05 19:51:16 INFO impl.MetricsSystemImpl: s3a-file-system metrics system shutdown complete.{code}" Enable code coverage reporting to SonarQube in hbase-connectors,13475180,Resolved,Minor,Fixed,04/Aug/22 13:45,05/Aug/22 10:46,, Make RowTooBigException configurable for snapshot reads ,13474492,Resolved,Minor,Workaround,01/Aug/22 10:39,02/Aug/22 09:01,,"While trying to read snapshot data using TableSnapshotInputFormat in an MR job, we can skip OOME check (introduced by HBASE-10925 for region server side OOME protection ) since the allocated memory resources would be from MR tasks themselves (as compared to RS during live scans) !Screenshot 2022-08-01 at 3.42.57 PM.png!" Issues building with OpenJDK 17,13470010,Resolved,Minor,Fixed,04/Jul/22 23:55,25/Jul/22 11:32,3.0.0-alpha-3,"When building with OpenJDK 17, some errors appear: * The flag --illegal-access=permit is ignored, therefore its function of allowing access to private fields by reflection no longer works, One has to explicitly enable which packages can be accessed with --add-opens. * In order for the tests of kerberos code to run, one has to add the export of java.security.jgss/sun.security.krb5=ALL-UNNAMED To address these issues, I have created pull request [https://github.com/apache/hbase/pull/4594]   Best regards.  " Change JONI encoding in RegexStringComparator,13471989,Resolved,Minor,Fixed,18/Jul/22 07:07,19/Jul/22 16:23,,"I change the engine of RegexStringComparator to JONI. After that I sent a regex filter request, the RegionServer's heap memory usage spiked and the RegionServer did not work due to GC.   !rs-heap.png|width=609,height=55! (RegionServer Heap Memory Usage)   {code:java} INFO  [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine (eg GC): pause of approximately 1435ms GC pool 'ParNew' had collection(s): count=1 time=1550ms INFO  [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine (eg GC): pause of approximately 1073ms GC pool 'ParNew' had collection(s): count=1 time=1534ms INFO  [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine (eg GC): pause of approximately 1456ms GC pool 'ParNew' had collection(s): count=1 time=1574ms INFO  [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine (eg GC): pause of approximately 1297ms GC pool 'ParNew' had collection(s): count=1 time=1415ms {code} (RegionServer Log)   I checked the reason, it is said that when using UTF8Encoding, an infinite loop can occur if an invalid UTF8 is entered. For trino, using NonStrictUTF8Encoding instead of UTF8Encoding. (https://github.com/trinodb/trino/commit/ea66e8cb27b098a5cea184106fe245064351b567) After changing the encoding of JoniRegexEngine to NonStrictUTF8Encoding in RegexStringComparator, it was confirmed that the heap memory usage spike was gone." Fix tests that rely on EnvironmentEdgeManager in branch-2.4,13471614,Resolved,Minor,Fixed,14/Jul/22 15:40,18/Jul/22 19:19,2.4.13,"https://issues.apache.org/jira/browse/HBASE-25911 converted all System.currentTimeMillis() calls in master and branch-2 to use EnvironmentEdgeManager. For whatever reason, this was not backported to branch-2.4.  There exists tests TestAppendTimeRange and TestIncrementTimeRange which rely on EnvironmentEdge injection. These tests are consistently timing out due to logic in RSRpcServices.getRemainingRpcTimeout which subtracts ""now"" from call.getReceiveTime().  In this case, the now calculation uses EnvironmentEdge, but the ServerCalls use System.currentTimeMillis(). This discrepancy causes the calculated timeout to be unexpectedly large, hanging the test. We have two options: # Add EnvironmentEdgeManager in the narrowly necessary places to get this to work. # Revert branch-2.4's getTimeLimit to use System.currentTimeMillis. I'm going to push a PR which does option 1, but I'm open to open 2 if that is desired instead." ConnectionUtils.allOf should be moved to FutureUtils,13471669,Resolved,Minor,Fixed,15/Jul/22 03:02,15/Jul/22 09:04,3.0.0-alpha-3,"{{ConnectionUtils.allOf}} has nothing to do with {{Connection}} and should be moved to {{FutureUtils}}, HBASE-26950 which only applied for branch-2 have already moved {{ConnectionUtils.allOf}},so here also moving it for master." Enable code coverage reporting to SonarQube in hbase-filesystem,13471399,Resolved,Minor,Fixed,13/Jul/22 11:51,15/Jul/22 09:19,,We would like to be able to publish code coverage results to SonarQube and it would be useful to create a script to do it. Add KeyRangeSplitRestriction,13471455,Open,Minor,,13/Jul/22 17:54,,,"A common schema design pattern is to add a shard/salt prefix to row keys. For example, you may start every row key with bytes 0 through f (16 shards). If HBase is unaware of this pattern, it may split regions such that start/end row lands outside of that range. This typically happens at the start and end of a table – if HBase tries to split the first region (empty start, 1 end) it will probably choose something between -127 and 1 as the first byte (-64) but the lowest possible rowkey for your table starts with byte 0. So this newly split region will remain empty forever and never get any requests. I originally thought KeyPrefixRegionSplitRestriction could help with this, but that works through truncating split points. If you set the prefix to 1, you effectively limit the table to 16 regions max. This is impractical for any non-trivial table. What we actually want to do is ensure that HBase is not allowed to create a split point below the known start range or after the known end range. So I suggest a KeyRangeSplitRestriction which disallows splits out of a configured range." Report maxStoreFileCount in jmx,13470872,Resolved,Minor,Fixed,10/Jul/22 12:39,12/Jul/22 02:20,,"We currently report metrics like storeFileCount, maxStoreFileAge, etc. These are provided at the regionserver level and table table. We should also report maxStoreFileCount, which would be aggregated across all regions on the server or table(s). This metric would be helpful in ensuring we don't get too close to the {{hbase.hstore.blockingStoreFiles }}limit before running compactions or slowing writes." Report block cache size metrics separately for L1 and L2,13470752,Resolved,Minor,Fixed,08/Jul/22 20:24,12/Jul/22 02:19,,"Currently, in terms of block cache size metrics, we report the following: blockCacheFreeSize, blockCacheCount, blockCacheSize, blockCacheEvictionCount. This isn't super useful when running with BucketCache, because in that case L1 (holding index/meta blocks) and L2 (holding data blocks) operate largely independently. Additionally, you might typically report on block cache sizes in terms of monitoring heap usage. But with BucketCache, the cache is off-heap, so it becomes a misleading metric in that case. We have metrics l1CacheHitCount/MissCount/HitRatio/MissRatio, and the same for l2. We should add l1CacheFreeSize, l1CacheSize, l1CacheCount, l1CacheEvictionCount, and the same for l2." ResourceLeakDetector stacktraces can be truncated when logged,13471092,Open,Minor,,12/Jul/22 01:30,,2.5.0,"Looks like ResourceLeakDetector stacktraces can be truncated by log4j, at least with the default configuration. This is unfortunate because what log4j will do then is print the first bit of the log line then only the end, which omits the crucial top part of the stack trace. Should these be given the NamedQueueRecorder treatment like the slow log or balancer decisions, i.e. we would also log detected resource leaks and their complete stacktrace details into a system table? WDYT [~vjasani] [~zhangduo]" Failure to cleanup WAL split dir log should be at INFO level,13469783,Resolved,Minor,Fixed,03/Jul/22 00:10,06/Jul/22 23:35,,"As part of the SCP, after we are done splitting WALs, we try removing the -splitting dirs but if the dir doesn't exist, dfs#delete fails with IOE. Since we are aware of this case, we just log the message but we don't interrupt SCP because handling of the failure is gracefully done. Hence, failure to remove ""-splitting"" dir should not be mentioned as WARN log, let's convert this to INFO level: {code:java} LOG.warn(""Remove WAL directory for {} failed, ignore...{}"", serverName, e.getMessage()); {code}   Any other genuine failure to remove the splitting dir is anyways covered by this log, hence we don't have worry about keeping the above mentioned log at WARN level, we have anyways mentioned ""ignore..."" in the log message. {code:java} if (!fs.delete(splitDir, false)) { LOG.warn(""Failed delete {}, contains {}"", splitDir, fs.listFiles(splitDir, true)); } {code}" Consider adding ResourceLeakDetector to RefCnt,13469701,Resolved,Minor,Duplicate,01/Jul/22 17:14,05/Jul/22 18:02,,"In my quest to figure out HBASE-27170, I ended up adding ResourceLeakDetector to RefCnt in my local fork. This immediately reports the leak to the logs, making it hard to miss. ResourceLeakDetector is already active in the netty layer, and the default state is designed to be very low overhead. We could add it directly to RefCnt, or make it further configurable if we're concerned about performance. Either way it's good to have and document, to aid future leak investigations." Fix the config key name for PREFETCH_PERSISTENCE_PATH_KEY,13480893,Resolved,Trivial,Fixed,09/Sep/22 14:51,21/Oct/22 07:25,,Change the config key for PREFETCH_PERSISTENCE_PATH_KEY to hbase.prefetch.file.list.path  "Purge stale pom comment: """"",13483493,Open,Trivial,,27/Sep/22 16:14,,,"Any pom that has a hadoop-2.0 profile in it – all but the master branch – has this comment in the activation clause:   {{