feat: add memberships

databases/data.duckdb

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:61e70b472a2b545005f5668a47b292381c50348db0083dab886fe65457d84c4c
-size 5779456
+oid sha256:82433f465a60e793068d978c267fc8247e50afe187c3e226f132d3c5ff9385d1
+size 19935232

scripts/load_persons_to_db.py

@@ -16,6 +16,7 @@ import duckdb
 sys.path.insert(0, str(Path(__file__).parent.parent))
 
 from schemas.person import PERSON_SCHEMA
+from schemas.membership import MEMBERSHIP_SCHEMA
 from schemas.base import transform_value
 from config import DATABASE_PATH, PERSON_DATA_DIR
 
@@ -41,22 +42,35 @@ def create_persons_table(conn: duckdb.DuckDBPyConnection):
     conn.execute(create_sql)
 
 
+def create_memberships_table(conn: duckdb.DuckDBPyConnection):
+    """Create the memberships table using the explicit schema."""
+    create_sql = MEMBERSHIP_SCHEMA.get_create_table_sql()
+
+    print(f"Creating table '{MEMBERSHIP_SCHEMA.table_name}' with {len(MEMBERSHIP_SCHEMA.schema)} columns:")
+    print(f"  Fields: {', '.join(MEMBERSHIP_SCHEMA.field_order)}")
+
+    conn.execute(create_sql)
+
+
 def load_persons_to_db(data_dir: Path, db_path: Path, export_parquet: bool = False, parquet_path: Path = None):
     """Load all person TOML files into the DuckDB database."""
     print(f"Connecting to database: {db_path}")
     conn = duckdb.connect(str(db_path))
 
-    # Create table with explicit schema
+    # Create tables with explicit schema
     create_persons_table(conn)
+    create_memberships_table(conn)
 
-    # Build INSERT statement using schema definition
-    insert_sql = PERSON_SCHEMA.get_insert_sql()
+    # Build INSERT statements using schema definitions
+    insert_person_sql = PERSON_SCHEMA.get_insert_sql()
+    insert_membership_sql = MEMBERSHIP_SCHEMA.get_insert_sql()
 
     # Load data within a single transaction for performance
     print("\nLoading person data...")
     loaded_count = 0
     error_count = 0
     processed_count = 0
+    memberships_loaded_count = 0
     unknown_fields_seen = set()
 
     # Start explicit transaction
@@ -68,8 +82,9 @@ def load_persons_to_db(data_dir: Path, db_path: Path, export_parquet: bool = Fal
                 person_data = load_toml_file(toml_file)
 
                 # Warn about unknown fields (helps catch typos)
+                # Skip 'memberships' as it's handled separately
                 for field in person_data.keys():
-                    if field not in PERSON_SCHEMA.schema and field not in unknown_fields_seen:
+                    if field not in PERSON_SCHEMA.schema and field != 'memberships' and field not in unknown_fields_seen:
                         print(f"  Warning: Unknown field '{field}' found in {toml_file.name} (will be ignored)")
                         unknown_fields_seen.add(field)
 
@@ -81,7 +96,29 @@ def load_persons_to_db(data_dir: Path, db_path: Path, export_parquet: bool = Fal
                 ]
 
                 # Insert person data
-                conn.execute(insert_sql, values)
+                conn.execute(insert_person_sql, values)
+
+                # Extract and insert memberships for this person
+                person_id = person_data.get('id')
+                memberships = person_data.get('memberships', [])
+
+                for idx, membership in enumerate(memberships):
+                    # Generate unique ID for membership: person_id + index
+                    membership_id = f"{person_id}_m{idx}"
+
+                    membership_values = [
+                        membership_id,
+                        person_id,
+                        membership.get('party'),
+                        membership.get('region'),
+                        membership.get('province'),
+                        membership.get('locality'),  # May be None/missing
+                        membership.get('position'),
+                        membership.get('year'),
+                    ]
+
+                    conn.execute(insert_membership_sql, membership_values)
+                    memberships_loaded_count += 1
 
                 loaded_count += 1
                 processed_count += 1
@@ -113,12 +150,14 @@ def load_persons_to_db(data_dir: Path, db_path: Path, export_parquet: bool = Fal
     print(f"  Errors: {error_count}")
 
     # Show database stats
-    result = conn.execute("SELECT COUNT(*) as total FROM persons").fetchone()
-    print(f"  Total persons in database: {result[0]}")
+    persons_count = conn.execute("SELECT COUNT(*) as total FROM persons").fetchone()
+    memberships_count = conn.execute("SELECT COUNT(*) as total FROM memberships").fetchone()
+    print(f"  Total persons in database: {persons_count[0]}")
+    print(f"  Total memberships in database: {memberships_count[0]}")
     print(f"{'='*60}")
 
     # Show sample data
-    print("\nSample data (first 5 rows):")
+    print("\nSample persons (first 5 rows):")
     sample = conn.execute("""
         SELECT id, first_name, last_name, name_suffix
         FROM persons
@@ -129,6 +168,24 @@ def load_persons_to_db(data_dir: Path, db_path: Path, export_parquet: bool = Fal
         suffix = f" {row[3]}" if row[3] else ""
         print(f"  {row[0]}: {row[1]} {row[2]}{suffix}")
 
+    # Show sample memberships
+    print("\nSample memberships (first 5 rows):")
+    memberships_sample = conn.execute("""
+        SELECT
+            p.first_name,
+            p.last_name,
+            m.party,
+            m.position,
+            m.region,
+            m.year
+        FROM memberships m
+        JOIN persons p ON m.person_id = p.id
+        LIMIT 5
+    """).fetchall()
+
+    for row in memberships_sample:
+        print(f"  {row[0]} {row[1]} - {row[3]} ({row[2]}) in {row[4]}, {row[5]}")
+
     # Export to Parquet if requested
     if export_parquet:
         print(f"\n{'='*60}")