iiegn commited on
Commit
654e1a1
·
verified ·
1 Parent(s): 3c52a9f

tools: report blocked treebanks ignored during validation

Browse files
Files changed (1) hide show
  1. tools/05_validate_parquet.py +70 -15
tools/05_validate_parquet.py CHANGED
@@ -15,15 +15,16 @@ Usage:
15
  python 05_validate_parquet.py [OPTIONS]
16
 
17
  Options:
18
- --ud-ver VERSION UD version context for metadata/revision defaults (default: 2.17)
19
- --test Only validate 3 test treebanks (fr_gsd, en_ewt, it_isdt)
20
- --treebanks NAMES Comma-separated list of treebank names to validate
21
- --revision BRANCH HuggingFace Hub revision/branch (default: --ud-ver)
22
- --local Validate local parquet files instead of HuggingFace Hub
23
- --parquet-dir DIR Path to local parquet directory (implies --local)
24
- -v, --verbose Print progress messages (default: True)
25
- -vv, --very-verbose Show all differences
26
- -q, --quiet Suppress progress messages
 
27
 
28
  Examples:
29
  # Validate 3 test treebanks from local files
@@ -44,13 +45,15 @@ Note for developers:
44
  """
45
 
46
  import argparse
 
47
  import os
48
  import sys
49
  from pathlib import Path
50
 
51
  from dotenv import load_dotenv
 
 
52
  from _ud_hfp_wrapper import (
53
- append_common_selection_args,
54
  append_common_verbosity_args,
55
  get_repo_paths,
56
  run_ud_tools,
@@ -65,6 +68,30 @@ UD_VER = os.getenv("UD_VER", "2.17")
65
  PATHS = get_repo_paths(__file__)
66
 
67
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
68
  def main():
69
  """Main entry point - wrapper around ud-hf-parquet-tools."""
70
  parser = argparse.ArgumentParser(
@@ -72,8 +99,12 @@ def main():
72
  )
73
  parser.add_argument("--test", action="store_true", help="Test mode: validate 3 treebanks only")
74
  parser.add_argument("--treebanks", help="Comma-separated list of treebank names")
75
- parser.add_argument("--ud-ver", default=UD_VER,
76
- help="UD version context for local metadata defaults (default: UD_VER from env or 2.17)")
 
 
 
 
77
  parser.add_argument("--revision", help="HuggingFace Hub revision/branch (default: --ud-ver)")
78
  parser.add_argument("--local", action="store_true", help="Validate local parquet files")
79
  parser.add_argument("--parquet-dir", help="Path to local parquet directory (implies --local)")
@@ -88,13 +119,37 @@ def main():
88
  versioned_metadata = Path(__file__).resolve().parent / f"metadata-{ud_ver}.json"
89
  default_metadata = versioned_metadata if versioned_metadata.exists() else PATHS.metadata_file
90
  metadata_path = args.metadata or str(default_metadata)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
91
 
92
  # Build arguments for ud-hf-parquet-tools
93
  tool_args = [
94
  "ud-hfp-tools",
95
  "validate",
96
- "--metadata", metadata_path,
97
- "--ud-repos-dir", str(PATHS.ud_repos_dir),
 
 
 
 
98
  ]
99
 
100
  # Handle parquet directory
@@ -105,7 +160,7 @@ def main():
105
  else:
106
  # Remote validation
107
  tool_args.extend(["--revision", revision])
108
- append_common_selection_args(args, tool_args)
109
  append_common_verbosity_args(args, tool_args)
110
  return run_ud_tools(tool_args)
111
 
 
15
  python 05_validate_parquet.py [OPTIONS]
16
 
17
  Options:
18
+ --ud-ver VERSION UD version context for metadata/revision defaults (default: 2.17)
19
+ --test Only validate 3 test treebanks (fr_gsd, en_ewt, it_isdt)
20
+ --treebanks NAMES Comma-separated list of treebank names to validate
21
+ --blocked-treebanks FILE Path to blocked treebanks YAML file (default: tools/blocked_treebanks.yaml)
22
+ --revision BRANCH HuggingFace Hub revision/branch (default: --ud-ver)
23
+ --local Validate local parquet files instead of HuggingFace Hub
24
+ --parquet-dir DIR Path to local parquet directory (implies --local)
25
+ -v, --verbose Print progress messages (default: True)
26
+ -vv, --very-verbose Show all differences
27
+ -q, --quiet Suppress progress messages
28
 
29
  Examples:
30
  # Validate 3 test treebanks from local files
 
45
  """
46
 
47
  import argparse
48
+ import json
49
  import os
50
  import sys
51
  from pathlib import Path
52
 
53
  from dotenv import load_dotenv
54
+ import yaml
55
+
56
  from _ud_hfp_wrapper import (
 
57
  append_common_verbosity_args,
58
  get_repo_paths,
59
  run_ud_tools,
 
68
  PATHS = get_repo_paths(__file__)
69
 
70
 
71
+ def _load_metadata_treebanks(metadata_path: str) -> list[str]:
72
+ with open(metadata_path, "r", encoding="utf-8") as f:
73
+ metadata = json.load(f)
74
+ return sorted(metadata.keys())
75
+
76
+
77
+ def _load_blocked_treebanks(blocked_treebanks_path: str) -> set[str]:
78
+ blocked_file = Path(blocked_treebanks_path)
79
+ if not blocked_file.exists():
80
+ return set()
81
+
82
+ with open(blocked_file, "r", encoding="utf-8") as f:
83
+ blocked_data = yaml.safe_load(f) or {}
84
+ return set(blocked_data.keys())
85
+
86
+
87
+ def _select_treebanks(args, metadata_treebanks: list[str]) -> list[str]:
88
+ if args.test:
89
+ return [t for t in ["fr_gsd", "en_ewt", "it_isdt"] if t in metadata_treebanks]
90
+ if args.treebanks:
91
+ return [t.strip() for t in args.treebanks.split(",") if t.strip()]
92
+ return metadata_treebanks
93
+
94
+
95
  def main():
96
  """Main entry point - wrapper around ud-hf-parquet-tools."""
97
  parser = argparse.ArgumentParser(
 
99
  )
100
  parser.add_argument("--test", action="store_true", help="Test mode: validate 3 treebanks only")
101
  parser.add_argument("--treebanks", help="Comma-separated list of treebank names")
102
+ parser.add_argument(
103
+ "--ud-ver",
104
+ default=UD_VER,
105
+ help="UD version context for local metadata defaults (default: UD_VER from env or 2.17)",
106
+ )
107
+ parser.add_argument("--blocked-treebanks", help="Path to blocked treebanks YAML file")
108
  parser.add_argument("--revision", help="HuggingFace Hub revision/branch (default: --ud-ver)")
109
  parser.add_argument("--local", action="store_true", help="Validate local parquet files")
110
  parser.add_argument("--parquet-dir", help="Path to local parquet directory (implies --local)")
 
119
  versioned_metadata = Path(__file__).resolve().parent / f"metadata-{ud_ver}.json"
120
  default_metadata = versioned_metadata if versioned_metadata.exists() else PATHS.metadata_file
121
  metadata_path = args.metadata or str(default_metadata)
122
+ blocked_treebanks_path = args.blocked_treebanks or str(PATHS.blocked_treebanks_file)
123
+
124
+ metadata_treebanks = _load_metadata_treebanks(metadata_path)
125
+ selected_treebanks = _select_treebanks(args, metadata_treebanks)
126
+ blocked_treebanks = _load_blocked_treebanks(blocked_treebanks_path)
127
+ ignored_blocked = [t for t in selected_treebanks if t in blocked_treebanks]
128
+ treebanks_to_validate = [t for t in selected_treebanks if t not in blocked_treebanks]
129
+
130
+ if not args.quiet:
131
+ print(
132
+ f"Ignored blocked treebanks ({len(ignored_blocked)}) "
133
+ f"from {blocked_treebanks_path}"
134
+ )
135
+ if args.verbose and ignored_blocked:
136
+ print(f" {', '.join(sorted(ignored_blocked))}")
137
+
138
+ if not treebanks_to_validate:
139
+ if not args.quiet:
140
+ print("No treebanks to validate after blocked filtering.")
141
+ return 0
142
 
143
  # Build arguments for ud-hf-parquet-tools
144
  tool_args = [
145
  "ud-hfp-tools",
146
  "validate",
147
+ "--metadata",
148
+ metadata_path,
149
+ "--ud-repos-dir",
150
+ str(PATHS.ud_repos_dir),
151
+ "--treebanks",
152
+ ",".join(treebanks_to_validate),
153
  ]
154
 
155
  # Handle parquet directory
 
160
  else:
161
  # Remote validation
162
  tool_args.extend(["--revision", revision])
163
+
164
  append_common_verbosity_args(args, tool_args)
165
  return run_ud_tools(tool_args)
166