Update arca23k.py

arca23k.py

@@ -4,14 +4,11 @@
 
 
 import os
-import json
 import gzip
 import shutil
 import pathlib
 import logging
-import textwrap
 import datasets
-import itertools
 import typing as tp
 import pandas as pd
 import urllib.request
@@ -19,9 +16,8 @@ from pathlib import Path
 from copy import deepcopy
 from tqdm.auto import tqdm
 from rich.logging import RichHandler
-from huggingface_hub import hf_hub_download
 
-from ._arca23k import CLASSES, COARSE_TO_FINE
+from ._arca23k import CLASSES, FINE_TO_COARSE
 
 logger = logging.getLogger(__name__)
 logger.addHandler(RichHandler())
@@ -81,9 +77,9 @@ class ARCA23K(datasets.GeneratorBasedBuilder):
         """Returns SplitGenerators."""
         for zip_type in ['zip', 'z01', 'z02', 'z03', 'z04']:
             _filename = f'ARCA23K.audio.{zip_type}'
-            _zip_file_url = f'https://zenodo.org/records/5117901/files/ARCA23K.audio.{zip_type}'
+            _zip_file_url = f'https://zenodo.org/records/5117901/files/ARCA23K.audio.{zip_type}?download=1'
             _save_path = os.path.join(
-                HF_DATASETS_CACHE, 'confit___arca23k/v1.0', VERSION, _filename
+                HF_DATASETS_CACHE, 'confit___arca23k/v1.0', VERSION
             )
             download_file(_zip_file_url, os.path.join(_save_path, _filename))
             logger.info(f"`{_filename}` is downloaded to {_save_path}")
@@ -94,44 +90,44 @@ class ARCA23K(datasets.GeneratorBasedBuilder):
         _output_file = os.path.join(HF_DATASETS_CACHE, 'confit___arca23k/v1.0', VERSION, concat_zip_filename)
         
         if not os.path.exists(_output_file):
-            logger.info(f"Reassemble {_output_file} file")
-            os.system(f"zip -q -F {_input_file} --out {_output_file}")
+            logger.info(f"Reassembling {_output_file}")
+            os.system(f"zip -F {_input_file} --out {_output_file}")
+        
         archive_path = dl_manager.extract(_output_file)
-        logger.info(f"`{concat_zip_filename}` is downloaded to {archive_path}")
-
-        metadata_path = dl_manager.download_and_extract("https://zenodo.org/records/5117901/files/ARCA23K-FSD.ground_truth.zip")
-        train_df = pd.read_csv(os.path.join(metadata_path, 'train.csv'))
-        validation_df = pd.read_csv(os.path.join(metadata_path, 'val.csv'))
-        test_df = pd.read_csv(os.path.join(metadata_path, 'test.csv'))
+        logger.info(f"`{concat_zip_filename}` is extracted to {archive_path}")
 
+        metadata_path = dl_manager.download_and_extract("https://zenodo.org/records/5117901/files/ARCA23K.ground_truth.zip")
+        metadata_df = pd.read_csv(os.path.join(metadata_path, 'ARCA23K.ground_truth', 'train.csv'))
+        
         return [
             datasets.SplitGenerator(
-                name=datasets.Split.TRAIN, gen_kwargs={"archive_path": archive_path, "split": "train", "metadata": train_df}
-            ), 
-            datasets.SplitGenerator(
-                name=datasets.Split.VALIDATION, gen_kwargs={"archive_path": archive_path, "split": "validation", "metadata": validation_df}
-            ), 
-            datasets.SplitGenerator(
-                name=datasets.Split.TEST, gen_kwargs={"archive_path": archive_path, "split": "test", "metadata": test_df}
+                name=datasets.Split.TRAIN, gen_kwargs={"archive_path": archive_path, "split": "train", "metadata_df": metadata_df}
             ), 
+            # datasets.SplitGenerator(
+            #     name=datasets.Split.VALIDATION, gen_kwargs={"archive_path": archive_path, "split": "validation", "metadata_path": metadata_path}
+            # ), 
+            # datasets.SplitGenerator(
+            #     name=datasets.Split.TEST, gen_kwargs={"archive_path": archive_path, "split": "test", "metadata_path": metadata_path}
+            # ), 
         ]
-
-    def _generate_examples(self, archive_path, split=None, metadata=None):
+    
+    def _generate_examples(self, archive_path, split=None, metadata_df=None):
         extensions = ['.wav']
         _, _walker = fast_scandir(archive_path, extensions, recursive=True)
 
         fileid2class = {}
-        for idx, row in metadata.iterrows():
-            fileid2index[row['fname']] = row['label'] # this filename doesn't have suffix
-
+        for idx, row in metadata_df.iterrows():
+            fileid2class[f"{row['fname']}.wav"] = row['label'] # this filename doesn't have suffix
+            
         for guid, audio_path in enumerate(_walker):
-            fileid = Path(audio_path).stem
+            fileid = Path(audio_path).name
+            sound = fileid2class.get(fileid)
             yield guid, {
                 "id": str(guid),
                 "file": audio_path, 
                 "audio": audio_path, 
-                "sound": fileid2index.get(fileid), 
-                "label": fileid2index.get(fileid), 
+                "sound": sound, 
+                "label": sound, 
             }