hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
904d8f29c6ed3c1bf12d4f3f6c637dc5f29ef0ac
diff --git a/lib/media/streaming_engine.js b/lib/media/streaming_engine.js index <HASH>..<HASH> 100644 --- a/lib/media/streaming_engine.js +++ b/lib/media/streaming_engine.js @@ -1187,8 +1187,9 @@ shaka.media.StreamingEngine = class { try { const isMP4 = stream.mimeType == 'video/mp4' || stream.mimeType == 'audio/mp4'; + const isReadableStreamSupported = window.ReadableStream; // Enable MP4 low latency streaming with ReadableStream chunked data. - if (this.config_.lowLatencyMode && isMP4) { + if (this.config_.lowLatencyMode && isReadableStreamSupported && isMP4) { let remaining = new Uint8Array(0); const streamDataCallback = async (data) => { await initSourceBuffer; @@ -1224,6 +1225,10 @@ shaka.media.StreamingEngine = class { await this.fetch_(mediaState, reference, streamDataCallback); } else { + if (this.config_.lowLatencyMode && !isReadableStreamSupported) { + shaka.log.warning('Low latency streaming mode is enabled, but ' + + 'ReadableStream is not supported by the browser.'); + } const fetchSegment = this.fetch_(mediaState, reference); const results = await Promise.all([initSourceBuffer, fetchSegment]); this.destroyer_.ensureNotDestroyed();
feat(LL-Dash): Check whether ReadableStream is supported If low latency mode is enabled and ReadableStream is supported by the browser, use the streamDataCallback to handle the chunked data of the ReadableStream. If low latency mode is enabled but ReadableStream is not supported, show a warning message, and fall back to the regular streaming pipeline. Issue #<I> Change-Id: I4ea<I>b<I>d<I>a<I>fb<I>d<I>b2c<I>f
google_shaka-player
train
js
fb4565183808d9cadccc721aaa6e6c872869bf55
diff --git a/src/main/java/com/conveyal/gtfs/validator/SpeedTripValidator.java b/src/main/java/com/conveyal/gtfs/validator/SpeedTripValidator.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/conveyal/gtfs/validator/SpeedTripValidator.java +++ b/src/main/java/com/conveyal/gtfs/validator/SpeedTripValidator.java @@ -61,7 +61,7 @@ public class SpeedTripValidator extends TripValidator { registerError(currStopTime, DEPARTURE_BEFORE_ARRIVAL); } // Detect if travel times are rounded off to minutes. - boolean bothTravelTimesRounded = areTravelTimesRounded(prevStopTime); + boolean bothTravelTimesRounded = areTravelTimesRounded(prevStopTime) && areTravelTimesRounded(currStopTime); double travelTimeSeconds = currStopTime.arrival_time - prevStopTime.departure_time; // If travel times are rounded and travel time is zero, determine the maximum and minimum possible speed // by adding/removing one minute of slack.
fix(validate): fix rounded travel times check
conveyal_gtfs-lib
train
java
6d42fc353a4d006e937a65d6262bd0f5bd4b6f7c
diff --git a/api/src/opentrons/util/calibration_functions.py b/api/src/opentrons/util/calibration_functions.py index <HASH>..<HASH> 100644 --- a/api/src/opentrons/util/calibration_functions.py +++ b/api/src/opentrons/util/calibration_functions.py @@ -35,8 +35,8 @@ def probe_instrument(instrument, robot, tip_length=None) -> Point: robot.poses = instrument._move(robot.poses, z=safe_height) for hs in hot_spots: - x0 = tp.center[0] + hs.x_start_offs - y0 = tp.center[1] + hs.y_start_offs + x0 = center[0] + hs.x_start_offs + y0 = center[1] + hs.y_start_offs z0 = hs.z_start_abs log.info("Moving to {}".format((x0, y0, z0)))
fix(api): fix tip probing not fully self-centering (#<I>) fix #<I>
Opentrons_opentrons
train
py
b264e3a1eefb3462b33f580e6d8eab30b05a627e
diff --git a/code/extensions/AssetAdminSyncFilesExtension.php b/code/extensions/AssetAdminSyncFilesExtension.php index <HASH>..<HASH> 100644 --- a/code/extensions/AssetAdminSyncFilesExtension.php +++ b/code/extensions/AssetAdminSyncFilesExtension.php @@ -6,9 +6,13 @@ class AssetAdminSyncFilesExtension extends Extension { - public function updateEditForm($form) { + private static $enable_sync_files_button = false; - $form->Fields()->removeByName('SyncButton'); + public function updateEditForm($form) { + $enable = Config::inst()->get('AssetAdmin', 'enable_sync_files_button'); + if (!$enable){ + $form->Fields()->removeByName('SyncButton'); + } } }
feat(AssetAdminSyncFilesExtension): change the removal of this to be overridable via config
symbiote_silverstripe-seed
train
php
330872a48ec7eb491c53dcc1c22b52810e5d79ba
diff --git a/engine/src/main/java/org/camunda/bpm/engine/impl/bpmn/parser/BpmnParse.java b/engine/src/main/java/org/camunda/bpm/engine/impl/bpmn/parser/BpmnParse.java index <HASH>..<HASH> 100644 --- a/engine/src/main/java/org/camunda/bpm/engine/impl/bpmn/parser/BpmnParse.java +++ b/engine/src/main/java/org/camunda/bpm/engine/impl/bpmn/parser/BpmnParse.java @@ -2274,13 +2274,7 @@ public class BpmnParse extends Parse { return null; } else { - Object value = topicAttributeValue; - if (StringUtil.isExpression(topicAttributeValue)) { - return createParameterValueProvider(value, expressionManager); - } else { - // A topic can be a string, but not an expression - return new ConstantValueProvider(value); - } + return createParameterValueProvider(topicAttributeValue, expressionManager); } }
chore(engine): simplify parsing code for topic expression * Reduce steps for generating a ValueProvider for the topic Related to CAM-<I>
camunda_camunda-bpm-platform
train
java
8f38471e299a3b29cbfa905e5c238039fb0d4eb7
diff --git a/cmd/cp-main.go b/cmd/cp-main.go index <HASH>..<HASH> 100644 --- a/cmd/cp-main.go +++ b/cmd/cp-main.go @@ -64,9 +64,9 @@ USAGE: FLAGS: {{range .VisibleFlags}}{{.}} - {{end}} + {{end}} ENVIRONMENT VARIABLES: - MC_MULTIPART_THREADS: To set number of multipart threads. By default it is 4. + MC_MULTIPART_THREADS: To set number of multipart threads. By default it is 4. EXAMPLES: 1. Copy a list of objects from local file system to Amazon S3 cloud storage. diff --git a/cmd/mirror-main.go b/cmd/mirror-main.go index <HASH>..<HASH> 100644 --- a/cmd/mirror-main.go +++ b/cmd/mirror-main.go @@ -78,9 +78,9 @@ USAGE: FLAGS: {{range .VisibleFlags}}{{.}} - {{end}} + {{end}} ENVIRONMENT VARIABLES: - MC_MULTIPART_THREADS: To set number of multipart threads. By default it is 4. + MC_MULTIPART_THREADS: To set number of multipart threads. By default it is 4. EXAMPLES: 1. Mirror a bucket recursively from Minio cloud storage to a bucket on Amazon S3 cloud storage.
fix: Correct some cp/mirror help indentations (#<I>)
minio_mc
train
go,go
032212d949a4bfb9e46c8f8dc61846edd55c7bb8
diff --git a/test/instrumentation/modules/http/aborted-requests-enabled.js b/test/instrumentation/modules/http/aborted-requests-enabled.js index <HASH>..<HASH> 100644 --- a/test/instrumentation/modules/http/aborted-requests-enabled.js +++ b/test/instrumentation/modules/http/aborted-requests-enabled.js @@ -16,9 +16,12 @@ test('client-side abort below error threshold - call end', { timeout: 10000 }, f var clientReq t.plan(9) + t.on('end', function () { + server.close() + }) + resetAgent(function (data) { assert(t, data) - server.close() }) t.equal(agent._transport._writes.length, 0, 'should not have any samples to begin with')
ci(jenkins): end test properly even if it times out (#<I>) This was missed in #<I>
elastic_apm-agent-nodejs
train
js
d297056ff191d2fe447b5467504554415398d78f
diff --git a/napalm/eos/eos.py b/napalm/eos/eos.py index <HASH>..<HASH> 100644 --- a/napalm/eos/eos.py +++ b/napalm/eos/eos.py @@ -36,7 +36,7 @@ from netaddr.core import AddrFormatError # third party libs import pyeapi from pyeapi.eapilib import ConnectionError, EapiConnection -from netmiko import ConfigInvalidException +from netmiko import BaseConnection, ConfigInvalidException # NAPALM base import napalm.base.helpers @@ -231,7 +231,9 @@ class EOSDriver(NetworkDriver): def close(self): """Implementation of NAPALM method close.""" self.discard_config() - if hasattr(self.device.connection, "close") and callable( + if isinstance(self.device, BaseConnection): + self._netmiko_close() + elif hasattr(self.device.connection, "close") and callable( self.device.connection.close ): self.device.connection.close()
fix(eos): handle netmiko close (#<I>) Resolves #<I>
napalm-automation_napalm
train
py
530b0020a12decd37dfcef095047ae8ad7591e84
diff --git a/src/main/java/com/synopsys/integration/executable/ProcessBuilderRunner.java b/src/main/java/com/synopsys/integration/executable/ProcessBuilderRunner.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/synopsys/integration/executable/ProcessBuilderRunner.java +++ b/src/main/java/com/synopsys/integration/executable/ProcessBuilderRunner.java @@ -75,7 +75,7 @@ public class ProcessBuilderRunner implements ExecutableRunner { errorOutputThread.start(); final int returnCode = process.waitFor(); - logger.info(String.format("Process finished: %d", returnCode)); + logger.info(String.format("Process return code: %d", returnCode)); standardOutputThread.join(); errorOutputThread.join();
fix: Update exit message to be more user friendly
blackducksoftware_integration-common
train
java
88522f1589df0ae6b6072e0cea04e388356ee731
diff --git a/Skinny.class.php b/Skinny.class.php index <HASH>..<HASH> 100644 --- a/Skinny.class.php +++ b/Skinny.class.php @@ -97,7 +97,7 @@ class Skinny{ return '<p>ADDTEMPLATE('.$spot.'):'.$template.':ETALPMETDDA</p>'; } - function getImageURLPF ( &$parser, $name = '', $arg = 'abs' ) { + public static function getImageURLPF ( &$parser, $name = '', $arg = 'abs' ) { $img = Image::newFromName( $name ); if($img!==NULL){ return ( trim($arg==='abs') ? $GLOBALS['wgServer'] : '') . $img->getURL();
fix: declare method getImageURLPF as public static
tinymighty_skinny
train
php
0bedcdbf7abd02f340bd94b3a905325eda3c996f
diff --git a/gridsome/lib/develop.js b/gridsome/lib/develop.js index <HASH>..<HASH> 100644 --- a/gridsome/lib/develop.js +++ b/gridsome/lib/develop.js @@ -38,6 +38,7 @@ module.exports = async (context, args) => { server.hooks.afterSetup.tap('develop', server => { const devMiddleware = require('webpack-dev-middleware')(compiler, { pathPrefix: webpackConfig.output.pathPrefix, + watchOptions: webpackConfig.devServer ? webpackConfig.devServer.watchOptions : null, logLevel: 'silent' })
fix(webpack): use devServer.watchOptions for dev middleware (#<I>)
gridsome_gridsome
train
js
11f30fc351286e6cfb1c43810217d12de5beb58d
diff --git a/aio/tools/transforms/authors-package/index.spec.js b/aio/tools/transforms/authors-package/index.spec.js index <HASH>..<HASH> 100644 --- a/aio/tools/transforms/authors-package/index.spec.js +++ b/aio/tools/transforms/authors-package/index.spec.js @@ -12,6 +12,7 @@ describe('authors-package (integration tests)', () => { originalJasmineTimeout = jasmine.DEFAULT_TIMEOUT_INTERVAL; jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000; }); + afterAll(() => jasmine.DEFAULT_TIMEOUT_INTERVAL = originalJasmineTimeout); beforeEach(() => {
style(aio): add newline between test blocks (#<I>) PR Close #<I>
angular_angular
train
js
1d66542f8b15d8cc9ecb0eb5f1ca647e687afa7f
diff --git a/bin/run-tests.js b/bin/run-tests.js index <HASH>..<HASH> 100755 --- a/bin/run-tests.js +++ b/bin/run-tests.js @@ -4,6 +4,7 @@ const { resolve: pathResolve } = require("path"); const { readdirSync } = require("fs"); const { spawn } = require("tap"); +console.log(`tap --no-coverage --timeout=60 test/unit/*-test.js`); spawn("tap", ["--no-coverage", "--timeout=60", "test/unit/*-test.js"], { name: "unit tests", env: { PATH: process.env.PATH } @@ -13,6 +14,11 @@ spawn("tap", ["--no-coverage", "--timeout=60", "test/unit/*-test.js"], { const apis = readdirSync(pathResolve(__dirname, "..", "openapi")); for (const api of apis) { const GHE_VERSION = parseFloat(api.replace(/^ghe-(\d+\.\d+)$/, "$1")) || null; + console.log( + `${ + GHE_VERSION ? `GHE_VERSION=${GHE_VERSION} ` : "" + }tap --no-coverage --timeout=60 test/unit/*-test.js` + ); spawn( "tap", ["--no-coverage", "--timeout=60", "test/integration/*-test.js"],
test: add more logs to test:ci script
octokit_routes
train
js
01d74ef6ad12e93cd90213519cd17646b4c2fd0b
diff --git a/src/body-renderer.js b/src/body-renderer.js index <HASH>..<HASH> 100644 --- a/src/body-renderer.js +++ b/src/body-renderer.js @@ -14,7 +14,7 @@ export default class BodyRenderer { renderRows(rows) { let config = { - itemHeight: 40, + itemHeight: this.options.cellHeight, total: rows.length, generate: (index) => { const el = document.createElement('div'); @@ -30,7 +30,7 @@ export default class BodyRenderer { const rows = this.datamanager.getRowsForView(); let config = { - itemHeight: 40, + itemHeight: this.options.cellHeight, total: rows.length, generate: (index) => { const el = document.createElement('div'); diff --git a/src/defaults.js b/src/defaults.js index <HASH>..<HASH> 100644 --- a/src/defaults.js +++ b/src/defaults.js @@ -52,7 +52,7 @@ export default { logs: false, layout: 'fixed', // fixed, fluid, ratio noDataMessage: 'No Data', - cellHeight: null, + cellHeight: 40, inlineFilters: false, treeView: false, checkedRowStatus: true,
fix: 🐛 Pick cellHeight from options HyperList should take cellHeight from options
frappe_datatable
train
js,js
2fd3fbda44d45566cb4ae34b957d9f1ded3a5169
diff --git a/lib/client/bundler/index.js b/lib/client/bundler/index.js index <HASH>..<HASH> 100644 --- a/lib/client/bundler/index.js +++ b/lib/client/bundler/index.js @@ -72,7 +72,7 @@ function getBundler(client){ module.exports = function(ss,options) { var proto = require('./proto')(ss, bundlers, bundlerById, options), - compressor = uglifyjs.Compressor(); + compressor = uglifyjs.Compressor({warnings:false}); function systemModule(name,wrap) { name = name.replace(/\.js$/,'');
fix(logging): no warnings by Uglify
socketstream_socketstream
train
js
4c8b7ec74debd1ceee37eddbd5f123f5df147325
diff --git a/docgen/plugins/documentationjs-data.js b/docgen/plugins/documentationjs-data.js index <HASH>..<HASH> 100644 --- a/docgen/plugins/documentationjs-data.js +++ b/docgen/plugins/documentationjs-data.js @@ -74,7 +74,6 @@ function mapInstantSearch([instantsearchFactory, InstantSearch], symbols, files) // console.log(JSON.stringify(InstantSearchSymbol.params, null, 2)); const fileName = 'instantsearch.html'; - const symbolWithRelatedType = files[fileName] = { mode: '0764', contents: '', @@ -178,7 +177,7 @@ function findRelatedTypes(functionSymbol, symbols) { else { types = [...types, typeSymbol]; // iterate over each property to get their types - forEach(typeSymbol.properties, p => findParamsTypes(p)); + forEach(typeSymbol.properties, p => findParamsTypes({name: p.type.name, type: p.type})); } } }
fix(documentationjs): fix 2+ depth structs
algolia_instantsearch.js
train
js
72470f0fe0ac71cd36e18d585404a90c6ce382bb
diff --git a/lib/scenario.js b/lib/scenario.js index <HASH>..<HASH> 100644 --- a/lib/scenario.js +++ b/lib/scenario.js @@ -95,7 +95,6 @@ module.exports.test = (test) => { */ module.exports.injected = function (fn, suite, hookName) { return function (done) { - const errHandler = (err) => { recorder.session.start('teardown'); recorder.cleanAsyncErr(); @@ -111,7 +110,7 @@ module.exports.injected = function (fn, suite, hookName) { if (!fn) throw new Error('fn is not defined'); - event.emit(event.hook.started, suite); + event.emit(event.hook.started, suite); if (!recorder.isRunning()) { recorder.start(); recorder.errHandler((err) => { @@ -119,7 +118,7 @@ module.exports.injected = function (fn, suite, hookName) { }); } - this.test.body = fn.toString(); + this.test.body = fn.toString(); if (isAsyncFunction(fn)) { fn.apply(this, getInjectedArguments(fn)).then(() => {
refactor: fix eslint errors (#<I>)
Codeception_CodeceptJS
train
js
627735b49e5e9a0fdcbade4b35df0aa8e21c0e05
diff --git a/intranet/apps/eighth/models.py b/intranet/apps/eighth/models.py index <HASH>..<HASH> 100644 --- a/intranet/apps/eighth/models.py +++ b/intranet/apps/eighth/models.py @@ -1080,7 +1080,7 @@ class EighthScheduledActivity(AbstractBaseEighthModel): capacity = self.get_true_capacity() return capacity != -1 and self.eighthsignup_set.count() > capacity - def is_too_early_to_signup(self, now: datetime.datetime = None) -> bool: + def is_too_early_to_signup(self, now: Optional[datetime.datetime] = None) -> bool: """Returns whether it is too early to sign up for the activity if it is a presign.
refactor(eighth): fix type annotation
tjcsl_ion
train
py
6d7529c34f54ff51843c8ae46e079dc79299bb54
diff --git a/commons-types/src/main/java/se/l4/commons/types/reflect/Annotated.java b/commons-types/src/main/java/se/l4/commons/types/reflect/Annotated.java index <HASH>..<HASH> 100644 --- a/commons-types/src/main/java/se/l4/commons/types/reflect/Annotated.java +++ b/commons-types/src/main/java/se/l4/commons/types/reflect/Annotated.java @@ -24,7 +24,7 @@ public interface Annotated /** * Get if an annotation of the specific type is present. */ - default boolean hasAnnotation(@NonNull Class<?> annotationClass) + default boolean hasAnnotation(@NonNull Class<? extends Annotation> annotationClass) { for(Annotation a : getAnnotations()) {
fix(types): hasAnnotation should only take in annotation types
LevelFourAB_commons
train
java
317f24076eeaf221b74d7ef1eb5a549c0c8b1169
diff --git a/src/util/Util.js b/src/util/Util.js index <HASH>..<HASH> 100644 --- a/src/util/Util.js +++ b/src/util/Util.js @@ -24,12 +24,11 @@ class Util { static flatten(obj, ...props) { if (!isObject(obj)) return obj; - props = Object.assign( - ...Object.keys(obj) - .filter(k => !k.startsWith('_')) - .map(k => ({ [k]: true })), - ...props, - ); + const objProps = Object.keys(obj) + .filter(k => !k.startsWith('_')) + .map(k => ({ [k]: true })); + + props = objProps.length ? Object.assign(...objProps, ...props) : Object.assign({}, ...props); const out = {};
fix(Util): support empty array for flatten (#<I>)
discordjs_discord.js
train
js
9339fe50f20edbc7ec99c1b036245509955f1b9e
diff --git a/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js b/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js +++ b/packages/node_modules/@webex/plugin-meetings/test/unit/spec/meeting/index.js @@ -931,6 +931,7 @@ describe('plugin-meetings', () => { it('should reject promise if user is in lobby ', async () => { meeting.meetingState = 'ACTIVE'; meeting.locusInfo.parsedLocus = {self: {state: 'IDLE'}}; + meeting.isUserUnadmitted = true; try { await meeting.addMedia();
test(plugin-meetings): update unit test for wait in lobby
webex_spark-js-sdk
train
js
1ea97c7297b91510fa120f1051c1b7c2cd7b7302
diff --git a/api/src/opentrons/hardware_control/api.py b/api/src/opentrons/hardware_control/api.py index <HASH>..<HASH> 100644 --- a/api/src/opentrons/hardware_control/api.py +++ b/api/src/opentrons/hardware_control/api.py @@ -118,6 +118,9 @@ class API(HardwareAPILike): except Exception: mod_log.exception('Errored during door state event callback') + def _reset_last_mount(self): + self._last_moved_mount = None + @classmethod async def build_hardware_controller( cls, config: robot_configs.robot_config = None, @@ -639,6 +642,7 @@ class API(HardwareAPILike): # Gantry/frame (i.e. not pipette) action API async def home_z(self, mount: top_types.Mount = None): """ Home the two z-axes """ + self._reset_last_mount() if not mount: axes = [Axis.Z, Axis.A] else: @@ -693,6 +697,7 @@ class API(HardwareAPILike): home everything. """ await self._wait_for_is_running() + self._reset_last_mount() # Initialize/update current_position checked_axes = axes or [ax for ax in Axis] gantry = [ax for ax in checked_axes if ax in Axis.gantry_axes()]
fix(api): Prevent extra pipette movement after homing (#<I>)
Opentrons_opentrons
train
py
b1add21837e7f91017e41366ff8f05c156ba546f
diff --git a/anyconfig/processors.py b/anyconfig/processors.py index <HASH>..<HASH> 100644 --- a/anyconfig/processors.py +++ b/anyconfig/processors.py @@ -98,9 +98,12 @@ def list_processors_by_ext(prs): in anyconfig.utils.groupby(ps_by_ext, operator.itemgetter(0))) -def list_types(prs): +def list_types(tps): """List types that any processors can process them are available. + + :param tps: A list (generator) of (processor_type, [processor_cls]) + :return: [processor_type] """ - return sorted(set(next(anyconfig.compat.izip(*prs)))) + return sorted(set(next(anyconfig.compat.izip(*tps)))) # vim:sw=4:ts=4:et:
refactor: make clear what the argument of .processors.list_type is
ssato_python-anyconfig
train
py
0e90150e9c6f79d5f0deb8bef242fe60baa06cfb
diff --git a/rollup.config.js b/rollup.config.js index <HASH>..<HASH> 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -1,11 +1,8 @@ import { plugins } from '../../rollup.base.config'; -import { checkIsReleaseReady } from '../../scripts/checkIsReleaseReady'; import { getBundleBanner } from '../../scripts/getBundleBanner'; import pkg from './package.json'; -checkIsReleaseReady(); - if (!process.env.BUILD) { throw new Error('The `BUILD` environment variable is required to build.'); }
chore(release): don't check for NODE_ENV to set banner
algolia_docsearch
train
js
ae83eec6ff5679992404ecd20d2019cb21422adb
diff --git a/Tests/DependencyInjection/Fixtures/Util/EventDispatcherSpy.php b/Tests/DependencyInjection/Fixtures/Util/EventDispatcherSpy.php index <HASH>..<HASH> 100644 --- a/Tests/DependencyInjection/Fixtures/Util/EventDispatcherSpy.php +++ b/Tests/DependencyInjection/Fixtures/Util/EventDispatcherSpy.php @@ -2,7 +2,6 @@ namespace OpenClassrooms\Bundle\UseCaseBundle\Tests\DependencyInjection\Fixtures\Util; -use Symfony\Component\EventDispatcher\Event; use Symfony\Component\EventDispatcher\EventDispatcher; /** @@ -26,11 +25,11 @@ class EventDispatcherSpy extends EventDispatcher self::$sent = false; } - public function dispatch($eventName, Event $event = null) + public function dispatch($event, string $eventName = null) { self::$eventName = $eventName; self::$sent = true; - parent::dispatch($eventName, $event); + parent::dispatch($event, $eventName); } }
chore(f-deprecation): refactored EventDispatcherSpy following deprecation cleanup
OpenClassrooms_UseCaseBundle
train
php
3a157b54917a3a1dd2431f38d88ea4b89fd36942
diff --git a/examples/record_loader.rb b/examples/record_loader.rb index <HASH>..<HASH> 100644 --- a/examples/record_loader.rb +++ b/examples/record_loader.rb @@ -11,10 +11,7 @@ class RecordLoader < GraphQL::Batch::Loader end def perform(keys) - query(keys).each do |record| - value = @column_type.cast(record.public_send(@column)) - fulfill(value, record) - end + query(keys).each { |record| fulfill(record.public_send(@column), record) } keys.each { |key| fulfill(key, nil) unless fulfilled?(key) } end
docs(example): Remove unnecessary type cast in RecordLoader example The record's attribute reader method should already be returning values of the right type.
Shopify_graphql-batch
train
rb
7e182cde16ba583d84c1d07214634da7358ed3d9
diff --git a/lib/config/definitions.js b/lib/config/definitions.js index <HASH>..<HASH> 100644 --- a/lib/config/definitions.js +++ b/lib/config/definitions.js @@ -968,7 +968,7 @@ const options = [ stage: 'package', type: 'json', default: { - fileMatch: ['\\.buildkite/.+\\.yml$'], + fileMatch: ['buildkite\\.ya?ml', '\\.buildkite/.+\\.ya?ml$'], commitMessageTopic: 'buildkite plugin {{depName}}', commitMessageExtra: 'to {{#if isMajor}}v{{{newMajor}}}{{else}}{{{newValue}}}{{/if}}',
fix(buildkite): better fileMatch
renovatebot_renovate
train
js
18d24b237ba0bd475951af6789b92aea07ba22c6
diff --git a/py/semaphore/processing.py b/py/semaphore/processing.py index <HASH>..<HASH> 100644 --- a/py/semaphore/processing.py +++ b/py/semaphore/processing.py @@ -53,7 +53,7 @@ class GeoIpLookup(RustObject): return rv def __repr__(self): - return "<GeoIpLookup %r>" % (self.path,) + return "<GeoIpLookup %r>" % (self._path,) class StoreNormalizer(RustObject): diff --git a/py/semaphore/utils.py b/py/semaphore/utils.py index <HASH>..<HASH> 100644 --- a/py/semaphore/utils.py +++ b/py/semaphore/utils.py @@ -36,12 +36,12 @@ class RustObject(with_metaclass(_NoDict)): raise RuntimeError("Object is closed") return self._objptr - def __del__(self): + def __del__(self, _rustcall=rustcall): if self._objptr is None or self._shared: return f = self.__class__.__dealloc_func__ if f is not None: - rustcall(f, self._objptr) + _rustcall(f, self._objptr) self._objptr = None
fix: Fix broken repr and crash when shutting down python
getsentry_semaphore
train
py,py
ab05a3df98c200ca5c2941343a08a7c0b2aabeaf
diff --git a/packages/tc-icon/index.js b/packages/tc-icon/index.js index <HASH>..<HASH> 100644 --- a/packages/tc-icon/index.js +++ b/packages/tc-icon/index.js @@ -1,4 +1,4 @@ -export { default as default } from './src'; +export { default } from './src'; export { default as Add } from './Add.js' export { default as App } from './App.js' export { default as Bell } from './Bell.js'
style(icon): main entry file Remove extra us of default in main export.
trend-community_trend-components
train
js
5107de17147458ba76784350732f2a67ec0e4383
diff --git a/src/sensors.js b/src/sensors.js index <HASH>..<HASH> 100644 --- a/src/sensors.js +++ b/src/sensors.js @@ -24,13 +24,6 @@ const nativeApis = new Map([ ["barometer", BarNative] ]); -const eventEmitters = new Map([ - ["accelerometer", new NativeEventEmitter(AccNative)], - ["gyroscope", new NativeEventEmitter(GyroNative)], - ["magnetometer", new NativeEventEmitter(MagnNative)], - ["barometer", new NativeEventEmitter(BarNative)] -]); - const eventEmitterSubsciption = new Map([ ["accelerometer", null], ["gyroscope", null], @@ -54,13 +47,13 @@ function createSensorObservable(sensorType) { () => { this.isSensorAvailable = true; + const emitter = new NativeEventEmitter(nativeApis.get(sensorType)); + eventEmitterSubsciption.set( sensorType, - eventEmitters - .get(sensorType) - .addListener(listenerKeys.get(sensorType), data => { - observer.next(data); - }) + emitter.addListener(listenerKeys.get(sensorType), data => { + observer.next(data); + }) ); // Start the sensor manager
fix: EventEmitter is not cached
react-native-sensors_react-native-sensors
train
js
73dc376b6a4fbde2af653fa4400cdd725a58d71d
diff --git a/src/ToastContainer.js b/src/ToastContainer.js index <HASH>..<HASH> 100644 --- a/src/ToastContainer.js +++ b/src/ToastContainer.js @@ -78,7 +78,12 @@ module.exports = React.createClass({ toastId, key, ref: `toasts__${ key }`, - handleOnClick: this._handle_toast_on_click, + handleOnClick: (e) => { + if ("function" === typeof optionsOverride.handleOnClick) { + optionsOverride.handleOnClick(); + } + return this._handle_toast_on_click(e); + }, handleRemove: this._handle_toast_remove, }, });
feat(ToastContainer): add support for optionsOverride.handleOnClick * So react component actions can be dispatched * Closes #<I> * Original
tomchentw_react-toastr
train
js
4aa115f67741bdf2284a78816112ffd4b02d462f
diff --git a/packages/hoc-input/src/index.js b/packages/hoc-input/src/index.js index <HASH>..<HASH> 100644 --- a/packages/hoc-input/src/index.js +++ b/packages/hoc-input/src/index.js @@ -1 +1,2 @@ export { default, formInputProps } from "./formInput"; +export { default as styledInput } from "./styledComponents/Wrapper";
feat(hoc-input): export the wrapper style as part of the lib affects: @crave/farmblocks-hoc-input
CraveFood_farmblocks
train
js
8cd6163975c6c0cf2ac776d87ffef8f4c16f5668
diff --git a/ecell4/deprecated.py b/ecell4/deprecated.py index <HASH>..<HASH> 100644 --- a/ecell4/deprecated.py +++ b/ecell4/deprecated.py @@ -16,7 +16,11 @@ def deprecated(suggest=None): doc = "[Deprecated]\n" else: doc = "[Deprecated] Use '" + suggest + "' instead.\n" - wrapper.__doc__ = doc + wrapper.__doc__ + + if wrapper.__doc__ is None: + wrapper.__doc__ = doc + else: + wrapper.__doc__ = doc + wrapper.__doc__ return wrapper return decorator
fix: Check whether the original docstring is not None when deprecated
ecell_ecell4
train
py
eb8fcf833c1e898206d183a8b4a415cd487179c5
diff --git a/npm/index.js b/npm/index.js index <HASH>..<HASH> 100644 --- a/npm/index.js +++ b/npm/index.js @@ -15,4 +15,20 @@ function getElectronPath () { } } -module.exports = getElectronPath() +// A list of the main modules the people will attempt to use from the Electron API, this is not a complete list but should cover most +// use cases. +var electronModuleNames = ['app', 'autoUpdater', 'BrowserWindow', 'ipcMain', 'Menu', 'net', 'Notification', 'systemPreferences', 'Tray'] +var electronPath = new String(getElectronPath()) + +electronModuleNames.forEach(function warnOnElectronAPIAccess (apiKey) { + Object.defineProperty(electronPath, apiKey, { + enumerable: false, + configurable: false, + get: function getElectronAPI () { + console.warn('WARNING: You are attempting to access an Electron API from a node environment.\n\n' + + 'You need to use the "electron" command to run your app. E.g. "npx electron ./myapp.js"') + } + }) +}) + +module.exports = electronPath
chore: warn when people attempt to use the Electron module to do Electron things but from node (#<I>) * chore: warn when people attempt to use the Electron module to do Electron things but from node * update node env console warning
electron_electron
train
js
38d2129d9013b7d11eaf1a07883fdbd3eb8d280d
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -403,6 +403,17 @@ export default class Carousel extends Component { this._ignoreNextMomentum = true; } } + + if (autoplay) { + // Restart autoplay after a little while + // This could be done when releasing touch + // but the event is buggy on Android... + clearTimeout(this._enableAutoplayTimeout); + this._enableAutoplayTimeout = + setTimeout(() => { + this.startAutoplay(true); + }, autoplayDelay + 1000); + } } snapToNext (animated = true) { @@ -450,6 +461,7 @@ export default class Carousel extends Component { onScrollEndDrag={!enableMomentum ? this._onScrollEnd : undefined} onResponderRelease={this._onTouchRelease} onResponderMove={this._onTouchMove} + onMoveShouldSetResponder={() => true} // enables _onTouchMove on Android onScroll={this._onScroll} scrollEventThrottle={50} {...this.props}
fix(component): autoplay will start and stop properly on Android
archriss_react-native-snap-carousel
train
js
d1c5b6fe9e18b532ad69ed4bd82e1874a6dff4df
diff --git a/src/sharding/ShardClientUtil.js b/src/sharding/ShardClientUtil.js index <HASH>..<HASH> 100644 --- a/src/sharding/ShardClientUtil.js +++ b/src/sharding/ShardClientUtil.js @@ -200,13 +200,14 @@ class ShardClientUtil { */ _respond(type, message) { this.send(message).catch(err => { - err.message = `Error when sending ${type} response to master process: ${err.message}`; + const error = new Error(`Error when sending ${type} response to master process: ${err.message}`); + error.stack = err.stack; /** * Emitted when the client encounters an error. * @event Client#error * @param {Error} error The error encountered */ - this.client.emit(Events.ERROR, err); + this.client.emit(Events.ERROR, error); }); }
fix(ShardingManager): client error event cannot be emitted (#<I>)
discordjs_discord.js
train
js
e134ff41dab7ca2190204f52b132d3234d52e034
diff --git a/src/av.js b/src/av.js index <HASH>..<HASH> 100644 --- a/src/av.js +++ b/src/av.js @@ -266,7 +266,7 @@ AV._encode = function(value, seenObjects, disallowObjects) { * @private */ AV._decode = function(value, key) { - if (!_.isObject(value)) { + if (!_.isObject(value) || _.isDate(value)) { return value; } if (_.isArray(value)) { diff --git a/test/av.js b/test/av.js index <HASH>..<HASH> 100644 --- a/test/av.js +++ b/test/av.js @@ -25,5 +25,13 @@ describe('AV utils', () => { array[0].should.be.a.String(); array[0].should.be.exactly(value); }); + + it('should bypass with non-plain object', () => { + const now = new Date(); + AV._decode(now).should.be.exactly(now); + AV._decode(3.14).should.be.exactly(3.14); + AV._decode(false).should.be.exactly(false); + AV._decode('false').should.be.exactly('false'); + }); }); });
fix: bypass Date for AV._decode (#<I>)
leancloud_javascript-sdk
train
js,js
09f6b5743bca12f4283fac11cec9b29118779892
diff --git a/test/ut/spec/model/Component.js b/test/ut/spec/model/Component.js index <HASH>..<HASH> 100755 --- a/test/ut/spec/model/Component.js +++ b/test/ut/spec/model/Component.js @@ -46,7 +46,7 @@ describe('Component', function() { ComponentModel.topologicalTravel(['m1', 'a2'], allList, function (componentType, dependencies) { result.push([componentType, dependencies]); }); - expect(result).toEqual([['a2', []], ['m1', ['a1', 'a2']]]); + expect(result).toEqual([['a2', ['dataset']], ['m1', ['dataset', 'a1', 'a2']]]); }); testCase('topologicalTravel_empty', function (ComponentModel) {
refactor(UT): update update Component topologicalTravel a1IsAbsent test case
apache_incubator-echarts
train
js
8b1a83855371d1008bfb5730bdac06caf5500fba
diff --git a/src/express.js b/src/express.js index <HASH>..<HASH> 100644 --- a/src/express.js +++ b/src/express.js @@ -802,8 +802,7 @@ Collection.prototype.express = function(app, auth) { /* * /api/NAME */ - - console.log('adding route: ' + name); + Tyr.info('adding route: ' + name); let r = app.route('/api/' + name); r.all(auth);
feat: log express routes using internal log setup
tyranid-org_tyranid
train
js
3c57c234a736ac67e018f724803c879f0791466f
diff --git a/src/plugin.js b/src/plugin.js index <HASH>..<HASH> 100644 --- a/src/plugin.js +++ b/src/plugin.js @@ -537,6 +537,7 @@ class VR extends Plugin { window.addEventListener('vrdisplaydeactivate', this.handleVrDisplayDeactivate_, true); this.initialized_ = true; + this.trigger('initialized'); } addCardboardButton_() {
feat: Add an initialization event that triggers after init() is finished (#<I>)
videojs_videojs-vr
train
js
62d9632d04f2f1fbee6ad852d355339c81fb145f
diff --git a/spec/operators/retry-spec.js b/spec/operators/retry-spec.js index <HASH>..<HASH> 100644 --- a/spec/operators/retry-spec.js +++ b/spec/operators/retry-spec.js @@ -78,20 +78,24 @@ describe('Observable.prototype.retry()', function () { it('should handle an empty source', function () { var source = cold('|'); + var subs = '(^!)'; var expected = '|'; var result = source.retry(); expectObservable(result).toBe(expected); + expectSubscriptions(source.subscriptions).toBe(subs); }); it('should handle a never source', function () { var source = cold('-'); + var subs = '^'; var expected = '-'; var result = source.retry(); expectObservable(result).toBe(expected); + expectSubscriptions(source.subscriptions).toBe(subs); }); it('should return a never observable given an async just-throw source and no count', function () {
test(retry): improve subscription assertions on retry tests
ReactiveX_rxjs
train
js
28c19048d52cb57d50e4a92b92069e14efd065f7
diff --git a/packages/mdc-textfield/addon/components/mdc-textfield-input.js b/packages/mdc-textfield/addon/components/mdc-textfield-input.js index <HASH>..<HASH> 100644 --- a/packages/mdc-textfield/addon/components/mdc-textfield-input.js +++ b/packages/mdc-textfield/addon/components/mdc-textfield-input.js @@ -52,8 +52,13 @@ export default TextField.extend({ let nextInput = getNextSibling (this.element, 'input'); if (isPresent (nextInput)) { + // Move the focus to the next element. nextInput.focus (); } + else { + // Take the focus of the current element. + this.element.blur (); + } } } });
fix: take focus off current input if there is no next input
onehilltech_ember-cli-mdc
train
js
88a6ce3fbf98919c17db134496a33cab4d0eaed5
diff --git a/test/functional/runner/index.js b/test/functional/runner/index.js index <HASH>..<HASH> 100644 --- a/test/functional/runner/index.js +++ b/test/functional/runner/index.js @@ -462,6 +462,8 @@ function resolveOperationArgs(operationName, operationArgs, context) { return result; } +const CURSOR_COMMANDS = new Set(['find', 'aggregate', 'listIndexes']); + /** * * @param {Object} operation the operation definition from the spec test @@ -549,7 +551,8 @@ function testOperation(operation, obj, context, options) { } let opPromise; - if (operationName === 'find' || operationName === 'aggregate') { + + if (CURSOR_COMMANDS.has(operationName)) { // `find` creates a cursor, so we need to call `toArray` on it const cursor = obj[operationName].apply(obj, args); opPromise = cursor.toArray();
test: start to collect a list of operations that return a cursor
mongodb_node-mongodb-native
train
js
d8488bc74da79beea3ca9a01ffc28c6735217976
diff --git a/lib/promise.js b/lib/promise.js index <HASH>..<HASH> 100644 --- a/lib/promise.js +++ b/lib/promise.js @@ -5,6 +5,7 @@ const { deprecationLog } = require('./helper'); /** * @extends Promise + * @deprecated */ class ZkPromise extends Promise { /**
fix: set deprecated for entire legacy Promise class
yfinkelstein_node-zookeeper
train
js
0cbd9c94efe11a57ebb9423b55e8e10db04ca7b8
diff --git a/src/main/java/org/camunda/bpm/model/bpmn/Bpmn.java b/src/main/java/org/camunda/bpm/model/bpmn/Bpmn.java index <HASH>..<HASH> 100644 --- a/src/main/java/org/camunda/bpm/model/bpmn/Bpmn.java +++ b/src/main/java/org/camunda/bpm/model/bpmn/Bpmn.java @@ -45,10 +45,10 @@ public class Bpmn { /** the singleton instance of {@link Bpmn}. If you want to customize the behavior of Bpmn, * replace this instance with an instance of a custom subclass of {@link Bpmn}. */ - public static final Bpmn INSTANCE = new Bpmn(); + public static Bpmn INSTANCE = new Bpmn(); /** the parser used by the Bpmn implementation. */ - private final BpmnParser bpmnParser = new BpmnParser(); + private BpmnParser bpmnParser = new BpmnParser(); private final ModelBuilder bpmnModelBuilder; /** The {@link Model} @@ -162,7 +162,7 @@ public class Bpmn { /** * Register known types of the BPMN model */ - private Bpmn() { + protected Bpmn() { bpmnModelBuilder = ModelBuilder.createInstance("BPMN Model"); doRegisterTypes(bpmnModelBuilder); bpmnModel = bpmnModelBuilder.build();
chore(Bpmn): make some fields non-public
camunda_camunda-bpmn-model
train
java
6f9aa1b88892de8fcf5c9895ac9c25b45f96378f
diff --git a/cmd/helm/repo.go b/cmd/helm/repo.go index <HASH>..<HASH> 100644 --- a/cmd/helm/repo.go +++ b/cmd/helm/repo.go @@ -65,8 +65,7 @@ func runRepoList(cmd *cobra.Command, args []string) error { return err } if len(f.Repositories) == 0 { - fmt.Println("No repositories to show") - return nil + return errors.New("no repositories to show") } table := uitable.New() table.MaxColWidth = 50
fix(helm): change helm repo list to return error when empty Following other commands, an empty list should return an error.
helm_helm
train
go
d25f04e3af7db5677149a7bf6ab771a3449edebf
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -42,7 +42,8 @@ function Passport(Users, config) { github: { clientID: process.env.GITHUB_CLIENT_ID, clientSecret: process.env.GITHUB_CLIENT_SECRET, - callbackURL: process.env.GITHUB_CALLBACK_URL + callbackURL: process.env.GITHUB_CALLBACK_URL, + scope: ['user:email'] }, otp: { codeField: process.env.OTP_CODE_FIELD || 'passcode',
fix: added scope to main strategy for github
ladjs_passport
train
js
0ad7c24aa394249a5213a8e11a826821d4b56266
diff --git a/src/structures/User.js b/src/structures/User.js index <HASH>..<HASH> 100644 --- a/src/structures/User.js +++ b/src/structures/User.js @@ -141,7 +141,7 @@ class User extends Base { } /** - * The Discord "tag" (e.g. `hydrabolt#0086`) for this user + * The Discord "tag" (e.g. `hydrabolt#0001`) for this user * @type {string} * @readonly */
docs(User): fix hydrabolt's tag (#<I>)
discordjs_discord.js
train
js
17d2f27271818b15de4670a149b50f1f9860823e
diff --git a/src/js/mixin/slider-drag.js b/src/js/mixin/slider-drag.js index <HASH>..<HASH> 100644 --- a/src/js/mixin/slider-drag.js +++ b/src/js/mixin/slider-drag.js @@ -5,6 +5,7 @@ import { includes, isRtl, isTouch, + noop, off, on, selInput, @@ -14,7 +15,7 @@ import { const pointerOptions = { passive: false, capture: true }; const pointerDown = 'touchstart mousedown'; const pointerMove = 'touchmove mousemove'; -const pointerUp = 'touchend touchcancel mouseup click input scroll'; +const pointerUp = 'touchend touchcancel mouseup click input'; export default { props: { @@ -70,6 +71,16 @@ export default { e.preventDefault(); }, }, + + { + // iOS workaround for slider stopping if swiping fast + name: `${pointerMove} ${pointerUp}`, + el() { + return this.list; + }, + handler: noop, + ...pointerOptions, + }, ], methods: { @@ -172,7 +183,7 @@ export default { } }, - end(e) { + end() { off(document, pointerMove, this.move, pointerOptions); off(document, pointerUp, this.end, pointerOptions);
fix: dragging in Slider component on iOS
uikit_uikit
train
js
f2d6f609bab41fcdb0f1487c52b94a3e56a8274f
diff --git a/embark-ui/src/components/Preview.js b/embark-ui/src/components/Preview.js index <HASH>..<HASH> 100644 --- a/embark-ui/src/components/Preview.js +++ b/embark-ui/src/components/Preview.js @@ -1,5 +1,6 @@ import React from 'react'; import {Button, InputGroup, Input, InputGroupAddon} from 'reactstrap'; +import FontAwesome from 'react-fontawesome'; class Preview extends React.Component { constructor(props) { @@ -31,9 +32,11 @@ class Preview extends React.Component { <InputGroup> <Input placeholder="URL" value={this.state.previewUrl} - onChange={(e) => this.handlePreviewUrlChange(e)} /> + onChange={(e) => this.handlePreviewUrlChange(e)}/> <InputGroupAddon addonType="append"> - <Button className="ml-auto" color="primary" onClick={(e) => this.handlePreviewGo(e)}>Go</Button> + <Button className="ml-auto" color="primary" onClick={(e) => this.handlePreviewGo(e)}> + <FontAwesome name="refresh"/> + </Button> </InputGroupAddon> </InputGroup> <iframe width="100%"
chore(browser): change Go to refresh since that's what they do
embark-framework_embark
train
js
d5bef71d41412f129883496f0e0b8ecf0ace4f88
diff --git a/viewport-units-buggyfill.js b/viewport-units-buggyfill.js index <HASH>..<HASH> 100755 --- a/viewport-units-buggyfill.js +++ b/viewport-units-buggyfill.js @@ -131,6 +131,14 @@ options.isMobileSafari = isMobileSafari; options.isBadStockAndroid = isBadStockAndroid; + if (options.ignoreVmax && !options.force && !isOldIE) { + // modern IE (10 and up) do not support vmin/vmax, + // but chances are this unit is not even used, so + // allow overwriting the "hacktivation" + // https://github.com/rodneyrehm/viewport-units-buggyfill/issues/56 + isBuggyIE = false; + } + if (isOldIE || (!options.force && !isMobileSafari && !isBuggyIE && !isBadStockAndroid && !isOperaMini && (!options.hacks || !options.hacks.required(options)))) { // this buggyfill only applies to mobile safari, IE9-10 and the Stock Android Browser. if (window.console && isOldIE) {
fix(polyfill): adding option ignoreVmax to deliberately not engage the hacks on IE9+ - closes #<I>
rodneyrehm_viewport-units-buggyfill
train
js
94556346550677d51a5ebaaad297b5f33d2d039c
diff --git a/test/tobe_instrumented/assertion.es20xx.js b/test/tobe_instrumented/assertion.es20xx.js index <HASH>..<HASH> 100644 --- a/test/tobe_instrumented/assertion.es20xx.js +++ b/test/tobe_instrumented/assertion.es20xx.js @@ -78,13 +78,12 @@ describe('power-assert on ES20xx syntax', function () { it('Object Rest/Spread', () => { expectPowerAssertMessage (() => { var o = { a: 1, b: 2 }; - var obj = { ...o, c: 5 }; - assert.deepStrictEqual(obj, { a: 1, b: 2, c: 3 }); + assert.deepStrictEqual({ ...o, c: 5 }, { a: 1, b: 2, c: 3 }); }, [ - ' assert.deepStrictEqual(obj, { a: 1, b: 2, c: 3 })', - ' | | ', - ' | Object{a:1,b:2,c:3} ', - ' Object{a:1,b:2,c:5} ' + ' assert.deepStrictEqual({ ...o, c: 5 }, { a: 1, b: 2, c: 3 })', + ' | | ', + ' | Object{a:1,b:2,c:3} ', + ' Object{a:1,b:2,c:5} ' ]); }); });
test: Object Rest/Spread in assertion expression
power-assert-js_power-assert
train
js
791390d1eaf6376f829093d1fbe47dc8f63b0093
diff --git a/src/configure-apollo.js b/src/configure-apollo.js index <HASH>..<HASH> 100644 --- a/src/configure-apollo.js +++ b/src/configure-apollo.js @@ -17,7 +17,7 @@ import { } from './apollo-links/'; const httpLink = createHttpLink({ - uri: `${window.app.protocol}://${window.app.host}/graphql`, + uri: `${window.app.protocol}://${window.app.backendHost}/graphql`, credentials: 'include', // manual polyfill for fetch to support older browsers like IE11 // for some reason that I wasn't able to figure out just importing
chore(app): use new host vars
commercetools_merchant-center-application-kit
train
js
d69003c789eda49d17f3802dbc76b19766fdd9af
diff --git a/src/ObjectMapper.php b/src/ObjectMapper.php index <HASH>..<HASH> 100644 --- a/src/ObjectMapper.php +++ b/src/ObjectMapper.php @@ -275,6 +275,10 @@ class ObjectMapper throw new PropertyNotAccessibleException($propertyName); } + if ($field->name == null) { + $field->name = $propertyName; + } + $val = null; if ($property->isPublic()) { $val = $object->{$propertyName};
fix: make @JsonField->name nullable
mintware-de_json-object-mapper
train
php
40e5469d0494df1ccbb33fa83a476bb273fdd446
diff --git a/src/components/sticky/sticky.js b/src/components/sticky/sticky.js index <HASH>..<HASH> 100644 --- a/src/components/sticky/sticky.js +++ b/src/components/sticky/sticky.js @@ -204,7 +204,7 @@ function MdSticky($document, $mdConstant, $$rAF, $mdUtil) { } // If the next item is close to the current one, pull the current one down into view - if (self.next && scrollTop >= self.next.top - self.current.height) { + if (self.next && self.current && (scrollTop >= (self.next.top - self.current.height))) { translate(self.current, scrollTop + (self.next.top - scrollTop - self.current.height)); return; }
fix(sticky): improve onScroll logic resolve possible RTE with `self.current`
angular_material
train
js
2c5410594a348ff89ce68e2e0d02fe30a8cbbd68
diff --git a/src/Keboola/Syrup/Monolog/Handler/StorageApiHandler.php b/src/Keboola/Syrup/Monolog/Handler/StorageApiHandler.php index <HASH>..<HASH> 100644 --- a/src/Keboola/Syrup/Monolog/Handler/StorageApiHandler.php +++ b/src/Keboola/Syrup/Monolog/Handler/StorageApiHandler.php @@ -7,6 +7,7 @@ namespace Keboola\Syrup\Monolog\Handler; +use Keboola\StorageApi\Client; use Keboola\StorageApi\Event; use Monolog\Logger; use Keboola\Syrup\Exception\NoRequestException;
fix: logging to SAPI events (fix typehint)
keboola_syrup
train
php
ba886e5b44fdad7f2bf1d90d4ee371620b02d6d4
diff --git a/packages/plugin-logger/src/index.js b/packages/plugin-logger/src/index.js index <HASH>..<HASH> 100644 --- a/packages/plugin-logger/src/index.js +++ b/packages/plugin-logger/src/index.js @@ -9,7 +9,8 @@ import Logger from './logger'; import config from './config'; registerPlugin(`logger`, Logger, { - config + config, + replace: true }); export {
fix(plugin-logger): make sure plugin-logger replaces the core logger when specifed
webex_spark-js-sdk
train
js
fd0ef76f14a78c4d992c41bb3e000115482a4960
diff --git a/contextMenu.js b/contextMenu.js index <HASH>..<HASH> 100644 --- a/contextMenu.js +++ b/contextMenu.js @@ -129,8 +129,15 @@ angular.module('ui.bootstrap.contextMenu', []) var leftCoordinate = event.pageX; var menuWidth = angular.element($ul[0]).prop('offsetWidth'); var winWidth = event.view.innerWidth; - if (leftCoordinate > menuWidth && winWidth - leftCoordinate < menuWidth) { - leftCoordinate = event.pageX - menuWidth; + var rightPadding = 5; + if (leftCoordinate > menuWidth && winWidth - leftCoordinate - rightPadding < menuWidth) { + leftCoordinate = winWidth - menuWidth - rightPadding; + } else if(winWidth - leftCoordinate < menuWidth) { + var reduceThreshold = 5; + if(leftCoordinate < reduceThreshold + rightPadding) { + reduceThreshold = leftCoordinate + rightPadding; + } + leftCoordinate = winWidth - menuWidth - reduceThreshold - rightPadding; } $ul.css({
fix: correct left coordinate being set when menu will overflow x-axis
Templarian_ui.bootstrap.contextMenu
train
js
05478166baffe2ca7a4fbceb4d898824a59c849d
diff --git a/packages/pob-release/index.js b/packages/pob-release/index.js index <HASH>..<HASH> 100644 --- a/packages/pob-release/index.js +++ b/packages/pob-release/index.js @@ -20,10 +20,6 @@ const availableVersions = [ 'minor', 'major', 'manual', - 'premajor', - 'preminor', - 'prepatch', - 'prerelease', ]; const packageJson = JSON.parse(readFileSync('./package.json'));
feat: remove useless premajor, preminor, prepatch and prerelease
christophehurpeau_pob-lerna
train
js
7838c0de31981318ad7f5d6e7ee0c7f1ccd6d460
diff --git a/packages/@vue/cli-plugin-unit-mocha/setup.js b/packages/@vue/cli-plugin-unit-mocha/setup.js index <HASH>..<HASH> 100644 --- a/packages/@vue/cli-plugin-unit-mocha/setup.js +++ b/packages/@vue/cli-plugin-unit-mocha/setup.js @@ -4,3 +4,5 @@ require('jsdom-global')(undefined, { pretendToBeVisual: true, url: 'http://local window.Date = Date // https://github.com/vuejs/vue-next/pull/2943 global.ShadowRoot = window.ShadowRoot + +global.SVGElement = window.SVGElement
fix(mocha): workaround the SVGElement issue in Vue (#<I>) related to <URL>
vuejs_vue-cli
train
js
b39ad49b7b39834e23d3745323399c4c4cd364c2
diff --git a/packages/create-razzle-app/lib/index.js b/packages/create-razzle-app/lib/index.js index <HASH>..<HASH> 100644 --- a/packages/create-razzle-app/lib/index.js +++ b/packages/create-razzle-app/lib/index.js @@ -20,7 +20,7 @@ const officialExamplesApiUrl = 'https://api.github.com/repos/jaredpalmer/razzle/contents/examples'; const branch = 'next-awesome'; // this line auto updates when yarn update-examples is run -const razzlePkg = `razzle${branch == 'master' ? '' : '@' + branch}`; +const razzlePkg = `razzle${branch == 'canary' ? '@' + branch : '' }`; const getOfficialExamples = () => { if (typeof process.env.CI === 'undefined') {
fix(create-razzle-app): reverse the logic for razzle version tag
jaredpalmer_razzle
train
js
43f46945a35a2281894c602d6557686e2536db16
diff --git a/lib/https/ca.js b/lib/https/ca.js index <HASH>..<HASH> 100644 --- a/lib/https/ca.js +++ b/lib/https/ca.js @@ -137,9 +137,23 @@ function getCacheCert(hostname) { return customPairs[hostname] || cachePairs.get(hostname) || certsCache.get(hostname); } +var curIndex = 0; +function getIndex() { + ++curIndex; + if (curIndex < 10) { + return '0' + curIndex; + } + if (curIndex > 99) { + curIndex = 0; + return '00'; + } + return curIndex; +} + + function createSelfCert(hostname) { var serialNumber = crypto.createHash('sha1') - .update(hostname + RANDOM_SERIAL, 'binary').digest('hex') + workerIndex; + .update(hostname + RANDOM_SERIAL, 'binary').digest('hex') + getIndex() + workerIndex; var cert = createCert(pki.setRsaPublicKey(ROOT_KEY.n, ROOT_KEY.e), serialNumber, true); cert.setSubject([{ name: 'commonName',
refactor: refine serialNumber
avwo_whistle
train
js
7277b00516905f0e26c78c063b7f84044c069b6d
diff --git a/lib/master.js b/lib/master.js index <HASH>..<HASH> 100644 --- a/lib/master.js +++ b/lib/master.js @@ -479,7 +479,7 @@ function isProduction() { } function isDebug() { - return process.execArgv.indexOf('--debug') !== -1 || typeof v8debug !== 'undefined'; + return process.execArgv.some(argv => argv.includes('--debug') || argv.includes('--inspect')); } function getAddress({ addressType, address, port, protocal }) {
fix: debug status detect should support inspect (#<I>)
eggjs_egg-cluster
train
js
e8941083057453f16bae6e555917f77bb1c887e1
diff --git a/builder/etcd/etcd.go b/builder/etcd/etcd.go index <HASH>..<HASH> 100644 --- a/builder/etcd/etcd.go +++ b/builder/etcd/etcd.go @@ -349,14 +349,13 @@ func UpdateHostPort(c cookoo.Context, p *cookoo.Params) (interface{}, cookoo.Int safely.GoDo(c, func() { ticker := time.NewTicker(10 * time.Second) for range ticker.C { - //log.Infof(c, "Setting SSHD host/port") if _, err := os.FindProcess(sshd); err != nil { log.Errf(c, "Lost SSHd process: %s", err) break } else { if err := setHostPort(client, base, host, port, ttl); err != nil { log.Errf(c, "Etcd error setting host/port: %s", err) - break + continue } } }
fix(builder): continue updating etcd after errors
deis_deis
train
go
e8cc0c3f765959417451174a289a2685053b8d41
diff --git a/packages/lingui-i18n/src/compile.test.js b/packages/lingui-i18n/src/compile.test.js index <HASH>..<HASH> 100644 --- a/packages/lingui-i18n/src/compile.test.js +++ b/packages/lingui-i18n/src/compile.test.js @@ -50,7 +50,8 @@ describe('compile', function () { const currency = compile('en', '{value, number, currency}', { currency: { style: 'currency', - currency: 'EUR' + currency: 'EUR', + minimumFractionDigits: 2 } }) expect(currency({ value: 0.1 })).toEqual('€0.10') diff --git a/packages/lingui-react/src/Trans.test.js b/packages/lingui-react/src/Trans.test.js index <HASH>..<HASH> 100644 --- a/packages/lingui-react/src/Trans.test.js +++ b/packages/lingui-react/src/Trans.test.js @@ -76,7 +76,8 @@ describe('Trans component', function () { params={{ value: 1 }} formats={{ currency: { style: 'currency', - currency: 'EUR' + currency: 'EUR', + minimumFractionDigits: 2 }}} />) expect(translation).toEqual('€1.00')
test: Fix test suit to run correctly on node 4
lingui_js-lingui
train
js,js
d4be910e671d6b5f812ae1284d9b03edc9cd379c
diff --git a/lib/util.js b/lib/util.js index <HASH>..<HASH> 100644 --- a/lib/util.js +++ b/lib/util.js @@ -9,6 +9,8 @@ const _ = require('lodash'); const engineUtil = require('../core/lib/engine_util'); const renderVariables = engineUtil._renderVariables; +const template = engineUtil.template; + module.exports = { readScript, @@ -17,7 +19,8 @@ module.exports = { addOverrides, addVariables, checkConfig, - renderVariables + renderVariables, + template }; function readScript(scriptPath, callback) {
feat: Export template() from artillery/util
artilleryio_artillery
train
js
99c8fa83b53d5febec14c94db40da9e8bf7dddea
diff --git a/lib/zlib/deflate.js b/lib/zlib/deflate.js index <HASH>..<HASH> 100644 --- a/lib/zlib/deflate.js +++ b/lib/zlib/deflate.js @@ -484,7 +484,7 @@ function deflate_stored(s, flush) { return BS_FINISH_STARTED; } /***/ - return BS_FINISH_STARTED; + return BS_FINISH_DONE; } if (s.strstart > s.block_start) { diff --git a/test/deflate.js b/test/deflate.js index <HASH>..<HASH> 100644 --- a/test/deflate.js +++ b/test/deflate.js @@ -65,7 +65,7 @@ describe('Deflate levels', function () { it('level 1', function(done) { testDeflate(zlib.createDeflate, pako.deflate, samples, { level: 1 }, done); }); - it.skip('level 0', function(done) { + it('level 0', function(done) { testDeflate(zlib.createDeflate, pako.deflate, samples, { level: 0 }, done); });
fix: return correct block state in deflate_stored & enable tests for level 0
nodeca_pako
train
js,js
109cdcc6f914540d20a94ce8f55dd44b0955cb54
diff --git a/api/src/opentrons/drivers/smoothie_drivers/driver_3_0.py b/api/src/opentrons/drivers/smoothie_drivers/driver_3_0.py index <HASH>..<HASH> 100755 --- a/api/src/opentrons/drivers/smoothie_drivers/driver_3_0.py +++ b/api/src/opentrons/drivers/smoothie_drivers/driver_3_0.py @@ -500,11 +500,7 @@ class SmoothieDriver_3_0_0: if res is None: raise ValueError( f'{key} was not updated to {value} on {axis} axis') - # ensure smoothie received code and changed value through - # return message. Format of return message: - # <Axis> (or E for endstop) updated <Value> - arr_result = res.strip().split(' ') - res_msg[axis][str(arr_result[0])] = float(arr_result[2]) + res_msg[axis][key] = value return res_msg
fix(api): dont parse the smoothie response to udpate_pipette_config (#<I>) This parsing is unreliable because we have the smoothie's echo mode on and our multiple new lines sometimes stomp the actual response from the smoothie. This raises an IndexError and breaks pipette config updating and makes the system unreliable.
Opentrons_opentrons
train
py
c04872d00a26e9bf0f48eeacb360b37ce0fba01e
diff --git a/semantic_release/pypi.py b/semantic_release/pypi.py index <HASH>..<HASH> 100644 --- a/semantic_release/pypi.py +++ b/semantic_release/pypi.py @@ -1,6 +1,7 @@ """PyPI """ from invoke import run +from twine import settings from twine.commands import upload as twine_upload @@ -20,17 +21,11 @@ def upload_to_pypi( """ run('python setup.py {}'.format(dists)) twine_upload.upload( - dists=['dist/*'], - sign=False, - identity=None, - username=username, - password=password, - comment=None, - sign_with='gpg', - config_file='~/.pypirc', - skip_existing=skip_existing, - cert=None, - client_cert=None, - repository_url=None + settings.Settings( + username=username, + password=password, + skip_existing=skip_existing, + ), + ['dist/*'], ) run('rm -rf build dist')
fix: Use new interface for twine
relekang_python-semantic-release
train
py
8233e0c15eb6bd32c3ff8351fa399524dbb603e2
diff --git a/lib/instrumentation/transaction.js b/lib/instrumentation/transaction.js index <HASH>..<HASH> 100644 --- a/lib/instrumentation/transaction.js +++ b/lib/instrumentation/transaction.js @@ -58,7 +58,7 @@ function Transaction (agent, name, type) { this.type = type || 'custom' this.result = 'success' this.traces = [] - this._buildTraces = [] + this._builtTraces = [] this.ended = false this._abortTime = 0 this._agent = agent @@ -95,7 +95,7 @@ Transaction.prototype.buildTrace = function () { } var trace = new Trace(this) - this._buildTraces.push(trace) + this._builtTraces.push(trace) return trace } @@ -141,7 +141,7 @@ Transaction.prototype.end = function () { if (!this._defaultName && this.req) this.setDefaultNameFromRequest() - this._buildTraces.forEach(function (trace) { + this._builtTraces.forEach(function (trace) { if (trace.ended || !trace.started) return trace.truncate() })
refactor(transaction): fix typo
elastic_apm-agent-nodejs
train
js
322d5826627ba74a188f381e37a1365fe390baa2
diff --git a/packages/pob/lib/generators/core/yarn/CoreYarnGenerator.js b/packages/pob/lib/generators/core/yarn/CoreYarnGenerator.js index <HASH>..<HASH> 100644 --- a/packages/pob/lib/generators/core/yarn/CoreYarnGenerator.js +++ b/packages/pob/lib/generators/core/yarn/CoreYarnGenerator.js @@ -112,6 +112,7 @@ export default class CoreYarnGenerator extends Generator { } end() { + this.fs.delete(this.destinationPath('.yarn/build-state.yml')); if (this.options.enable) { if (this.options.yarnNodeLinker === 'pnp') { this.spawnCommandSync('yarn', ['dlx', '@yarnpkg/sdks', 'vscode']);
fix(pob): make sure build-state.yml doesnt exists
christophehurpeau_pob-lerna
train
js
bf7de75ac38685d3a30d065c1f558fa96a8e4209
diff --git a/tests/integration/components/ui-dropdown-test.js b/tests/integration/components/ui-dropdown-test.js index <HASH>..<HASH> 100644 --- a/tests/integration/components/ui-dropdown-test.js +++ b/tests/integration/components/ui-dropdown-test.js @@ -796,10 +796,11 @@ test('The correct number of items get selected when array is modified', function assert.ok(this.$('.item[data-id=2]').hasClass('active')); assert.equal(this.get('selected').join(','), ['2'].join(',')); + Ember.run.begin(); this.set('selected', ['2', '4']); // Have to clear the queue to ensure that property change gets notified // Doesn't clear in time on tests occasionally - Ember.run.sync(); + Ember.run.end(); assert.ok(this.$('.item[data-id=4]').hasClass('active')); assert.equal(this.get('selected').join(','), ['2', '4'].join(','));
fix: Ember.run.sync() is deprecated, use begin() and end()
Semantic-Org_Semantic-UI-Ember
train
js
489c8084dd34f93a8d336cf33bac367c22252389
diff --git a/lib/crabfarm/modes/publisher.rb b/lib/crabfarm/modes/publisher.rb index <HASH>..<HASH> 100644 --- a/lib/crabfarm/modes/publisher.rb +++ b/lib/crabfarm/modes/publisher.rb @@ -88,7 +88,7 @@ module Crabfarm end def validate_remote(_url) - return true if /^\w+\/\w+$/i === _url + return true if /^[\w\-]+\/[\w\-]+$/i === _url puts "Invalid remote syntax: #{_url}".color :red return false end
fix(publisher): fixes remote validation expression to accept dashes
platanus_crabfarm-gem
train
rb
fc4c4bee739a8bc2dbe7f726cb9c6bc358440c9d
diff --git a/packages/eslint-midway-contrib/base.js b/packages/eslint-midway-contrib/base.js index <HASH>..<HASH> 100644 --- a/packages/eslint-midway-contrib/base.js +++ b/packages/eslint-midway-contrib/base.js @@ -3,6 +3,7 @@ module.exports = { browser: true, commonjs: true, es6: true, + mocha: true, node: true, }, extends: ['./plugins/import.yml'],
chore(eslint-midway-contrib): add mocha into env (#<I>) to solve "'describe' is not defined no-undef" (cherry picked from commit a<I>ca<I>ef<I>c6ca4b<I>de6c<I>bce<I>ab2)
midwayjs_midway
train
js
08c4b073f3850235bc85dd757874de66038add04
diff --git a/webpack.config.dist.js b/webpack.config.dist.js index <HASH>..<HASH> 100644 --- a/webpack.config.dist.js +++ b/webpack.config.dist.js @@ -1,15 +1,22 @@ const path = require("path"); +const webpack = require("webpack"); module.exports = { - devtool: "source-map", - entry: ["./src/index.js"], + entry: { + "js-worker-search": "./src/index.js" + }, output: { path: "dist", - filename: "js-worker-search.js", + filename: "[name].js", libraryTarget: "commonjs2", library: "redux-search" }, - plugins: [], + plugins: [ + new webpack.SourceMapDevToolPlugin({ + exclude: /.*worker\.js$/, + filename: "[name].js.map" + }) + ], module: { loaders: [ {
fix: exclude source maps for worker scripts Fixes #<I>
bvaughn_js-worker-search
train
js
3df264501f85a414b62a128ba95f679be09e961f
diff --git a/lib/workers/package-file/index.js b/lib/workers/package-file/index.js index <HASH>..<HASH> 100644 --- a/lib/workers/package-file/index.js +++ b/lib/workers/package-file/index.js @@ -29,6 +29,10 @@ async function renovatePackageFile(packageFileConfig) { return [config]; } + if (packageContent.workspaces) { + logger.warn('Found workspaces'); + } + // Check for renovate config inside the package.json if (packageContent.renovate) { logger.trace( diff --git a/test/workers/package-file/index.spec.js b/test/workers/package-file/index.spec.js index <HASH>..<HASH> 100644 --- a/test/workers/package-file/index.spec.js +++ b/test/workers/package-file/index.spec.js @@ -65,7 +65,7 @@ describe('packageFileWorker', () => { expect(res).toEqual([]); }); it('calls depTypeWorker', async () => { - config.api.getFileJson.mockReturnValueOnce({}); + config.api.getFileJson.mockReturnValueOnce({ workspaces: true }); depTypeWorker.renovateDepType.mockReturnValueOnce([{}]); depTypeWorker.renovateDepType.mockReturnValueOnce([{}, {}]); depTypeWorker.renovateDepType.mockReturnValueOnce([]);
chore: add warning if yarn workspaces found (#<I>)
renovatebot_renovate
train
js,js
de9d33b2cfb1e7bd904c8da66bfd0af65a633612
diff --git a/test/runner-browser.js b/test/runner-browser.js index <HASH>..<HASH> 100644 --- a/test/runner-browser.js +++ b/test/runner-browser.js @@ -1,6 +1,7 @@ // Readd promise polyfills for legacy browsers since karma-webpack removes them require('core-js/fn/promise') require('core-js/fn/object/assign') +require('core-js/fn/array/from') // This file is required due to an issue with karma-tap // https://github.com/tmcw-up-for-adoption/karma-tap/issues/10 diff --git a/webpack.config.js b/webpack.config.js index <HASH>..<HASH> 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -112,7 +112,8 @@ legacyBundle.module.loaders = [ // https://github.com/babel/babel-preset-env/pull/241 legacyBundle.entry = [ 'core-js/fn/promise', - 'core-js/fn/object/assign' + 'core-js/fn/object/assign', + 'core-js/fn/array/from' ].concat(legacyBundle.entry) legacyBundle.output.filename = `${baseFileName}.legacy${PROD ? '.min' : ''}.js`
fix(polyfill): add array from polyfill for IE
contentful_contentful.js
train
js,js
1b2dcd516e430915f698d574513f93bb1bce4b68
diff --git a/ui-ace.js b/ui-ace.js index <HASH>..<HASH> 100644 --- a/ui-ace.js +++ b/ui-ace.js @@ -26,7 +26,7 @@ angular.module('ui.ace', []) onChange = function (callback) { return function (e) { var newValue = session.getValue(); - if (newValue !== scope.$eval(attrs.value) && !scope.$$phase) { + if (newValue !== scope.$eval(attrs.value) && !scope.$$phase && !scope.$root.$$phase) { if (angular.isDefined(ngModel)) { scope.$apply(function () { ngModel.$setViewValue(newValue);
fix(ui-ace): issue with digest already in progress error
angular-ui_ui-ace
train
js
e62e207010e96a23ce1bbea139f38b473f8d3b07
diff --git a/post-install.js b/post-install.js index <HASH>..<HASH> 100644 --- a/post-install.js +++ b/post-install.js @@ -57,7 +57,7 @@ function getConfig (file, options = { home: false, json: true }) { /** * tests if an absolute path exists */ -export function exists (pathname) { +function exists (pathname) { try { return statSync(pathname) } catch (e) {
fix(northbrook): remove export statement
northbrookjs_northbrook
train
js
dbab61064dc869460a7bc2eabee3085e93283424
diff --git a/packages/cozy-client/src/StackLink.js b/packages/cozy-client/src/StackLink.js index <HASH>..<HASH> 100644 --- a/packages/cozy-client/src/StackLink.js +++ b/packages/cozy-client/src/StackLink.js @@ -35,7 +35,7 @@ export default class StackLink extends CozyLink { } const collection = this.stackClient.collection(doctype) if (id) { - return collection.get(id) + return collection.get(id, query) } if (ids) { return collection.getAll(ids) diff --git a/packages/cozy-stack-client/src/AppCollection.js b/packages/cozy-stack-client/src/AppCollection.js index <HASH>..<HASH> 100644 --- a/packages/cozy-stack-client/src/AppCollection.js +++ b/packages/cozy-stack-client/src/AppCollection.js @@ -17,7 +17,7 @@ class AppCollection extends DocumentCollection { this.endpoint = '/apps/' } - get(idArg) { + get(idArg, query) { let id if (idArg.indexOf('/') > -1) { id = idArg.split('/')[1]
feat: Add query as argument to collection.get()
cozy_cozy-client
train
js,js
08e87c1f30025918e04b44c36bdef61d3bafa188
diff --git a/lib/compile/formats.js b/lib/compile/formats.js index <HASH>..<HASH> 100644 --- a/lib/compile/formats.js +++ b/lib/compile/formats.js @@ -116,7 +116,9 @@ function uri(str) { } +var Z_ANCHOR = /[^\\]\\Z/; function regex(str) { + if (Z_ANCHOR.test(str)) return false; try { new RegExp(str); return true;
feat: format "regex" should fail if regular expression contains \Z anchor
epoberezkin_ajv
train
js
6786eeff611bdee4b5e5d9ae5c0a5d2caf8cc466
diff --git a/client/community/action-creators/async-invite.js b/client/community/action-creators/async-invite.js index <HASH>..<HASH> 100644 --- a/client/community/action-creators/async-invite.js +++ b/client/community/action-creators/async-invite.js @@ -4,11 +4,17 @@ import * as t from '~client/community/action-types' import * as AwaitActions from '~client/components/await/redux/action-creators' import { genericRequestError, communityInviteSuccess } from '~client/utils/notifications' +const COMMUNITY_USER_ROLES = { + owner: 1, + admin: 2, + participant: 3 +} + export default (communityId, invitation) => (dispatch, getState, { api, intl }) => { const { auth: { credentials } } = getState() const endpoint = `/communities/${communityId}/invitation` - const body = { invitation } + const body = { invitation: { ...invitation, role: COMMUNITY_USER_ROLES.admin } } const options = { headers: credentials } dispatch(AwaitActions.setLoading(true))
fix(community): set user role on invitation request fix #<I>
nossas_bonde-client
train
js
4fa563ba24b7dbaa29613092e8b8a5a32c90bd5f
diff --git a/src/ChipInput.js b/src/ChipInput.js index <HASH>..<HASH> 100644 --- a/src/ChipInput.js +++ b/src/ChipInput.js @@ -230,7 +230,7 @@ class ChipInput extends React.Component { } handleKeyDown = (event) => { - if (event.keyCode === 13) { // enter + if (event.keyCode === this.props.newChipKeyCode) { // default 13/enter this.handleAddChip(event.target.value) } else if (event.keyCode === 8 || event.keyCode === 46) { if (event.target.value === '') { @@ -517,11 +517,13 @@ ChipInput.propTypes = { onUpdateInput: PropTypes.func, openOnFocus: PropTypes.bool, chipRenderer: PropTypes.func, + newChipKeyCode: PropTypes.number, clearOnBlur: PropTypes.bool } ChipInput.defaultProps = { filter: AutoComplete.caseInsensitiveFilter, + newChipKeyCode: 13, clearOnBlur: true }
feat: add newChipKeyCode prop to ChipInput component The newChipKeyCode prop (default <I>) is compared against the event keyCode in the onKeyDownHandler, if they match then a new chip is rendered.
TeamWertarbyte_material-ui-chip-input
train
js
8f28ad477f2de539c071a430394a55734537b8cc
diff --git a/api/opentrons/drivers/smoothie_drivers/driver_3_0.py b/api/opentrons/drivers/smoothie_drivers/driver_3_0.py index <HASH>..<HASH> 100755 --- a/api/opentrons/drivers/smoothie_drivers/driver_3_0.py +++ b/api/opentrons/drivers/smoothie_drivers/driver_3_0.py @@ -65,7 +65,7 @@ GCODES = {'HOME': 'G28.2', 'DWELL': 'G4', 'CURRENT_POSITION': 'M114.2', 'LIMIT_SWITCH_STATUS': 'M119', - 'PROBE': 'G38.2', + 'PROBE': 'G38.2 F420', # 420 mm/min (7 mm/sec) to avoid resonance 'ABSOLUTE_COORDS': 'G90', 'RELATIVE_COORDS': 'G91', 'RESET_FROM_ERROR': 'M999',
perf(api): Slightly increase probing speed, avoid resonance and pipette shaking (#<I>)
Opentrons_opentrons
train
py
7e6b4cfa8d73da691bb49c18ae58f0f7eaaa54fe
diff --git a/src/CognosRequest.js b/src/CognosRequest.js index <HASH>..<HASH> 100644 --- a/src/CognosRequest.js +++ b/src/CognosRequest.js @@ -340,9 +340,7 @@ class CognosRequest { result = response; } else { try { - result = response.replace(/=\\'/g, "='"); - result = result.replace(/\\']/g, "']"); - result = JSON.parse(result); + result = response.data; } catch (err) { me.log('No valid JSON returned from delete request. ' + path); result = response;
fix: Made http delete request return better information
CognosExt_jcognos
train
js
63034b44c9849087e391684d9b6c0c6ae9a21113
diff --git a/packages/discord.js/src/structures/Role.js b/packages/discord.js/src/structures/Role.js index <HASH>..<HASH> 100644 --- a/packages/discord.js/src/structures/Role.js +++ b/packages/discord.js/src/structures/Role.js @@ -1,6 +1,5 @@ 'use strict'; -const process = require('node:process'); const Base = require('./Base'); const { Error } = require('../errors'); const Permissions = require('../util/Permissions');
fix(Role): remove unused process (#<I>)
discordjs_discord.js
train
js
0f97a8ddc5b860f72ddb9c4cfcdb3f2e9bd77552
diff --git a/lib/util/validate-script.js b/lib/util/validate-script.js index <HASH>..<HASH> 100644 --- a/lib/util/validate-script.js +++ b/lib/util/validate-script.js @@ -10,7 +10,7 @@ const config = Joi.object({ http: Joi.object({ extendedMetrics: Joi.boolean(), maxSockets: Joi.number(), - timeout: Joi.number() + timeout: Joi.alternatives(Joi.number(), Joi.string()) }), environments: Joi.object(), processor: Joi.string(), @@ -70,7 +70,7 @@ const wsItems = { const flowItemSchema = Joi.object({ function: Joi.string(), log: Joi.string(), - think: Joi.number(), + think: Joi.alternatives(Joi.number(), Joi.string()), loop: Joi.array(), ...httpItems, ...wsItems, @@ -78,7 +78,7 @@ const flowItemSchema = Joi.object({ }).when('.loop', { is: Joi.exist(), then: Joi.object({ - count: Joi.number(), + count: Joi.alternatives(Joi.number(), Joi.string()), over: Joi.alternatives(Joi.array(), Joi.string()) }), otherwise: Joi.object().length(1)
fix: allow some properties to be numbers or strings Allow think, count and timeout properties to be string for when they are set through environment variable with "{{ $processEnvironment.SOME_VAR }}"
artilleryio_artillery
train
js
2c8de0ed2914b4977f45dc2c911597e78bb93950
diff --git a/code/CalendarDateTime.php b/code/CalendarDateTime.php index <HASH>..<HASH> 100755 --- a/code/CalendarDateTime.php +++ b/code/CalendarDateTime.php @@ -200,6 +200,9 @@ class CalendarDateTime extends DataObject { } public function canCreate($member = null) { + if (!$member) { + $member = Member::currentUser(); + } $extended = $this->extendedCan(__FUNCTION__, $member); if($extended !== null) { return $extended; @@ -208,6 +211,9 @@ class CalendarDateTime extends DataObject { } public function canEdit($member = null) { + if (!$member) { + $member = Member::currentUser(); + } $extended = $this->extendedCan(__FUNCTION__, $member); if($extended !== null) { return $extended; @@ -216,6 +222,9 @@ class CalendarDateTime extends DataObject { } public function canDelete($member = null) { + if (!$member) { + $member = Member::currentUser(); + } $extended = $this->extendedCan(__FUNCTION__, $member); if($extended !== null) { return $extended; @@ -224,6 +233,9 @@ class CalendarDateTime extends DataObject { } public function canView($member = null) { + if (!$member) { + $member = Member::currentUser(); + } $extended = $this->extendedCan(__FUNCTION__, $member); if($extended !== null) { return $extended;
fix(CalendarDateTime): Fixes cases for certain modules where the default member isn't passed.
unclecheese_silverstripe-event-calendar
train
php
46d5d3e583138916ce4481138248d66929d685bc
diff --git a/nomad/config.go b/nomad/config.go index <HASH>..<HASH> 100644 --- a/nomad/config.go +++ b/nomad/config.go @@ -43,9 +43,9 @@ func init() { } } -var ( - DefaultRPCAddr = &net.TCPAddr{IP: net.ParseIP("127.0.0.1"), Port: 4647} -) +func DefaultRPCAddr() *net.TCPAddr { + return &net.TCPAddr{IP: net.ParseIP("127.0.0.1"), Port: 4647} +} // Config is used to parameterize the server type Config struct { @@ -362,7 +362,7 @@ func DefaultConfig() *Config { RaftConfig: raft.DefaultConfig(), RaftTimeout: 10 * time.Second, LogOutput: os.Stderr, - RPCAddr: DefaultRPCAddr, + RPCAddr: DefaultRPCAddr(), SerfConfig: serf.DefaultConfig(), NumSchedulers: 1, ReconcileInterval: 60 * time.Second,
test: fix race around reused default rpc addr The default RPC addr was a global which is fine for normal runtime use when it only has a single user. However many tests modify it and cause races. Follow our convention of returning defaults from funcs instead of using globals.
hashicorp_nomad
train
go
caa4539d0e2a93b8a904e418bd40a4b8c9832926
diff --git a/task/backend/scheduler.go b/task/backend/scheduler.go index <HASH>..<HASH> 100644 --- a/task/backend/scheduler.go +++ b/task/backend/scheduler.go @@ -194,9 +194,8 @@ func (s *outerScheduler) ClaimTask(task *StoreTask, meta *StoreTaskMeta) (err er s.schedulerMu.Unlock() - // Okay to read ts.nextDue without locking, - // because we just created it and there won't be any concurrent access. - if now := atomic.LoadInt64(&s.now); now >= ts.nextDue || len(meta.ManualRuns) > 0 { + next, hasQueue := ts.NextDue() + if now := atomic.LoadInt64(&s.now); now >= next || hasQueue { ts.Work() } return nil
fix(task): fix data race in scheduler
influxdata_influxdb
train
go
50d1242133bf2c9f500635068e942451e55bbd81
diff --git a/test/cr_complex_test.go b/test/cr_complex_test.go index <HASH>..<HASH> 100644 --- a/test/cr_complex_test.go +++ b/test/cr_complex_test.go @@ -740,6 +740,7 @@ func TestCrUnmergedSetMtimeOfRemovedDir(t *testing.T) { ) } +/* TODO: Investigate and enable this. // bob moves and sets the mtime of a file that was written by alice func TestCrConflictMoveAndSetMtimeWrittenFile(t *testing.T) { targetMtime := time.Now().Add(1 * time.Minute) @@ -770,3 +771,4 @@ func TestCrConflictMoveAndSetMtimeWrittenFile(t *testing.T) { ), ) } +*/
test: Disable TestCrConflictMoveAndSetMtimeWrittenFile for now
keybase_client
train
go
af0fc05f5e25b0b3237c452c4cfea26a78e10e02
diff --git a/http/telegraf.go b/http/telegraf.go index <HASH>..<HASH> 100644 --- a/http/telegraf.go +++ b/http/telegraf.go @@ -485,7 +485,15 @@ func (s *TelegrafService) CreateTelegrafConfig(ctx context.Context, tc *platform // UpdateTelegrafConfig updates a single telegraf config. // Returns the new telegraf config after update. func (s *TelegrafService) UpdateTelegrafConfig(ctx context.Context, id platform.ID, tc *platform.TelegrafConfig, userID platform.ID) (*platform.TelegrafConfig, error) { - panic("not implemented") + var teleResp platform.TelegrafConfig + err := s.client. + PutJSON(tc, prefixTelegraf, id.String()). + DecodeJSON(&teleResp). + Do(ctx) + if err != nil { + return nil, err + } + return &teleResp, nil } // DeleteTelegrafConfig removes a telegraf config by ID.
fix(http): provide support for telegraf update in http client
influxdata_influxdb
train
go
eeeab25e12433b2718874100d30a1e946fc3dabc
diff --git a/packages/tpl-service/src/app.js b/packages/tpl-service/src/app.js index <HASH>..<HASH> 100644 --- a/packages/tpl-service/src/app.js +++ b/packages/tpl-service/src/app.js @@ -45,9 +45,9 @@ if (NODE_ENV !== "production") { */ app .use(helmet()) + .use(cors({ exposeHeaders: ["Link", "X-Total-Count"] })) .use(health({ url: `${BASE}/health`, version: pkg.version })) .use(openapi({ url: `${BASE}/openapi.yml`, file: openapiFile })) - .use(cors({ exposeHeaders: ["Link", "X-Total-Count"] })) .use(jwt({ secret: publicKey })) .use(body()) .use(someMid())
fix(tpl-service): cors for health and openapi
36node_sketch
train
js
94d0d2aa7d6b037dc4047df8a3dfa0ec55262fe8
diff --git a/packages/ui-presets/karma.js b/packages/ui-presets/karma.js index <HASH>..<HASH> 100644 --- a/packages/ui-presets/karma.js +++ b/packages/ui-presets/karma.js @@ -78,6 +78,10 @@ module.exports = function makeConfig ({ bundle, coverageDirectory, coverageThres config.set({ basePath: '', + // The default has some problems inside a monorepo, but specifying this manually + // seems to pull in all karma plugins across disparate node_modules/ dirs + plugins: ['karma-*'], + frameworks: ['mocha'], files: [ bundle ],
fix(karma): Improve plugin support inside monorepos The default karma plugin loading appears to be a little buggy if plugins are distributed among different node_modules dirs. Specifying this manually seems to work well, though. Change-Id: I<I>f4eb<I>e3d<I>f<I>efda6e<I>f4f<I>cfb Reviewed-on: <URL>
instructure_instructure-ui
train
js
d709c72ed3efb2b8a82dcb0132796bde685d64b3
diff --git a/src/mixin.js b/src/mixin.js index <HASH>..<HASH> 100644 --- a/src/mixin.js +++ b/src/mixin.js @@ -55,6 +55,12 @@ export default { return; } + // There is a validator but it isn't injected, mark as reactive. + if (!requested && this.$validator) { + const Vue = this.$options._base; // the vue constructor. + Vue.util.defineReactive(this.$validator, 'errors', this.$validator.errors); + } + if (! this.$options.computed) { this.$options.computed = {}; }
fix: fix errors reactivity issue closes #<I>
baianat_vee-validate
train
js
d09eea2dcc5ab9e19ad002d6729a2db3dbafd279
diff --git a/lib/boot/mods/apply.js b/lib/boot/mods/apply.js index <HASH>..<HASH> 100644 --- a/lib/boot/mods/apply.js +++ b/lib/boot/mods/apply.js @@ -77,6 +77,11 @@ function applyJson (originalComponent, mod) { return } - const res = applyPatch(originalComponent, mod.operations) - return res.newDocument + try { + const res = applyPatch(originalComponent, mod.operations) + return res.newDocument + } catch (error) { + console.log(error) + return + } } // applyJson
fix: handle errors with patching json
wmfs_tymly-core
train
js
f9ce1387bf9a948517f835fd04c139ee9a1fcdc6
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -75,7 +75,7 @@ require('./lib/rollbar') await enterpriseSetup() } - const scheduleRemindersJobData = Buffer.from(JSON.stringify({name: 'schedule-stale-initial-pr-reminders'})) + const scheduleRemindersJobData = { content: Buffer.from(JSON.stringify({name: 'schedule-stale-initial-pr-reminders'})) } async function scheduleReminders () { try { await scheduleJob(scheduleRemindersJobData, {priority: 1})
fix: schedule reminders job with content object
greenkeeperio_greenkeeper
train
js
032bdcf22999a61c543edb56646eff37fdfb88f4
diff --git a/raiden/network/proxies/token_network.py b/raiden/network/proxies/token_network.py index <HASH>..<HASH> 100644 --- a/raiden/network/proxies/token_network.py +++ b/raiden/network/proxies/token_network.py @@ -311,13 +311,14 @@ class TokenNetwork: block_identifier: BlockSpecification = 'pending', ) -> ChannelID: if not channel_identifier: - channel_identifier = self._call_and_check_result( - block_identifier, - 'getChannelIdentifier', + channel_identifier = self.proxy.contract.functions.getChannelIdentifier( to_checksum_address(participant1), to_checksum_address(participant2), - ) - assert isinstance(channel_identifier, T_ChannelID) + ).call(block_identifier=block_identifier) + + if not isinstance(channel_identifier, T_ChannelID): + raise ValueError('channel_identifier must be of type T_ChannelID') + if channel_identifier == 0: raise RaidenRecoverableError( f'When calling {called_by_fn} either 0 value was given for the ' @@ -325,6 +326,7 @@ class TokenNetwork: f'no channel currently exists between {pex(participant1)} and ' f'{pex(participant2)}', ) + return channel_identifier def channel_exists_and_not_settled(
fix: getChannelIdentifier cannot return empty The signature of getChannelIdentifier is: function (address, address) view public returns (uint<I>) So the function will return 0 if the value exists, never the empty string
raiden-network_raiden
train
py
46c1caced2ddcb773d15d76ca01e448a0cf700f9
diff --git a/lib/definitions/errors.js b/lib/definitions/errors.js index <HASH>..<HASH> 100644 --- a/lib/definitions/errors.js +++ b/lib/definitions/errors.js @@ -1,7 +1,6 @@ -const url = require('url'); const pkg = require('../../package.json'); -const homepage = url.format({...url.parse(pkg.homepage), ...{hash: null}}); +const [homepage] = pkg.homepage.split('#'); const linkify = file => `${homepage}/blob/master/${file}`; module.exports = {
refactor: replace url parse and format with simple split
byCedric_semantic-release-git-branches
train
js
bd638d926b65b95d16a881e4aa2893b66716a536
diff --git a/packages/app-frontend/src/features/timeline/index.js b/packages/app-frontend/src/features/timeline/index.js index <HASH>..<HASH> 100644 --- a/packages/app-frontend/src/features/timeline/index.js +++ b/packages/app-frontend/src/features/timeline/index.js @@ -63,6 +63,7 @@ const resetCbs = [] export function resetTimeline () { selectedEvent.value = null + inspectedEvent.value = null layersPerApp.value = {} vScrollPerApp.value = {} hoverLayerId.value = null
fix(timeline): reset inspected event
vuejs_vue-devtools
train
js