instance_id stringlengths 30 32 | text stringlengths 7.7k 116k | repo stringclasses 1
value | base_commit stringlengths 40 40 | problem_statement stringlengths 127 5.13k | hints_text stringclasses 20
values | created_at timestamp[us] | patch stringlengths 767 94.8k | test_patch stringlengths 527 58.5k | version stringclasses 1
value | FAIL_TO_PASS stringclasses 1
value | PASS_TO_PASS stringclasses 1
value | environment_setup_commit stringclasses 1
value |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
corona-warn-app__cwa-server-277 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Switch application*.properties files to Yaml
Let's switch over to YAML for better readability.
Affected files:
common/persistence/src/test/resources/application.properties
services/submission/src/main/re... | corona-warn-app/cwa-server | 576fd8b20079374458ffb650fe63ca6002e84a39 | Switch application*.properties files to Yaml
Let's switch over to YAML for better readability.
Affected files:
common/persistence/src/test/resources/application.properties
services/submission/src/main/resources/application.properties
services/submission/src/test/resources/application.properties
services/dist... | 2020-05-23T21:07:14 | <patch>
diff --git a/README.md b/README.md
--- a/README.md
+++ b/README.md
@@ -6,7 +6,7 @@
<a href="https://github.com/corona-warn-app/cwa-server/commits/" title="Last Commit"><img src="https://img.shields.io/github/last-commit/corona-warn-app/cwa-server?style=flat"></a>
<a href="https://github.com/corona-war... | diff --git a/common/persistence/src/test/resources/application.properties b/common/persistence/src/test/resources/application.properties
deleted file mode 100644
--- a/common/persistence/src/test/resources/application.properties
+++ /dev/null
@@ -1,6 +0,0 @@
-spring.flyway.enabled=false
-spring.jpa.hibernate.ddl-auto=c... | |||||
corona-warn-app__cwa-server-1965 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
min-android 1.5.1 differs from production 1.0.4 value
## Describe the bug
The `min-android` value served on
https://svc90.main.px.t-online.de/version/v1/configuration/country/DE/app_config is
`1.0.4`
... | corona-warn-app/cwa-server | f20af0764008b8ef07ba67c3b26693115035c43f | min-android 1.5.1 differs from production 1.0.4 value
## Describe the bug
The `min-android` value served on
https://svc90.main.px.t-online.de/version/v1/configuration/country/DE/app_config is
`1.0.4`
which differs from the value
`1.5.1`
stored in https://github.com/corona-warn-app/cwa-server/blob/mai... | - FYI: I opened https://github.com/corona-warn-app/cwa-server/issues/1963 asking the team to check for other differences between this repositories `main` branch & the production environment.
Also I would expect `min-android-version-code` / `minVersionCode=48` and not `31` to be served. | 2022-11-21T14:08:50 | <patch>
diff --git a/services/distribution/src/main/resources/application.yaml b/services/distribution/src/main/resources/application.yaml
--- a/services/distribution/src/main/resources/application.yaml
+++ b/services/distribution/src/main/resources/application.yaml
@@ -140,11 +140,11 @@ services:
app-versions:
... | diff --git a/services/distribution/src/test/resources/application-allow-list-invalid.yaml b/services/distribution/src/test/resources/application-allow-list-invalid.yaml
--- a/services/distribution/src/test/resources/application-allow-list-invalid.yaml
+++ b/services/distribution/src/test/resources/application-allow-lis... | ||||
corona-warn-app__cwa-server-406 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Aggregate File Creation: Skip packages if payload too small
Change the aggregate file creation logic in a way, in which packages are skipped in case the payload (amount of keys) is too small. The threshold shou... | corona-warn-app/cwa-server | fd114fd04e36c36c8081e0286e3f3fd27170777e | Aggregate File Creation: Skip packages if payload too small
Change the aggregate file creation logic in a way, in which packages are skipped in case the payload (amount of keys) is too small. The threshold should be configurable, and defaulted to 50 for now.
| Maybe combine with #140
**Alternative suggestion: Pad packages with random dummy keys if too small**
Thinking a bit further into the hoped for future, when new infections are becoming rare, this might lead to unnecessary (possibly quite long) delays in notifications being sent. Could one instead use random dummy ke... | 2020-06-01T17:31:01 | <patch>
diff --git a/README.md b/README.md
--- a/README.md
+++ b/README.md
@@ -148,7 +148,7 @@ Profile | Effect
-----------------|-------------
`dev` | Turns the log level to `DEBUG`.
`cloud` | Removes default values for the `datasource` and `objectstore` configurations.
-`demo` ... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerTest.java
new file mode 100644
--- /dev/nul... | ||||
corona-warn-app__cwa-server-232 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Open MinIO read access
## Current Implementation
Receiving files from local MinIO requires access key and secret key.
## Suggested Enhancement
Add a security policy to the MinIO configuration to only prote... | corona-warn-app/cwa-server | 9a5ae8bbf8872b63578dcca32b3258c012a63866 | Open MinIO read access
## Current Implementation
Receiving files from local MinIO requires access key and secret key.
## Suggested Enhancement
Add a security policy to the MinIO configuration to only protect write access, but have open read access.
## Expected Benefits
Mobile colleagues can use local setup for... | 2020-05-21T13:53:01 | <patch>
diff --git a/.env b/.env
--- a/.env
+++ b/.env
@@ -10,9 +10,9 @@ POSTGRES_PASSWORD=postgres
PGADMIN_DEFAULT_EMAIL=user@domain.com
PGADMIN_DEFAULT_PASSWORD=password
-# Docker Compose MinIO settings
-MINIO_ACCESS_KEY=minioadmin
-MINIO_SECRET_KEY=minioadmin
+# Docker Compose objectstore settings
+OBJECTSTORE_A... | diff --git a/services/distribution/src/test/resources/application.properties b/services/distribution/src/test/resources/application.properties
--- a/services/distribution/src/test/resources/application.properties
+++ b/services/distribution/src/test/resources/application.properties
@@ -14,9 +14,9 @@ spring.flyway.locat... | |||||
corona-warn-app__cwa-server-783 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Improve logging of the submission validation process
<!--
Thanks for proposing an enhancement 🙌 ❤️
Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensu... | corona-warn-app/cwa-server | 3b67b75657b26418691e024e049af7f3494c787b | Improve logging of the submission validation process
<!--
Thanks for proposing an enhancement 🙌 ❤️
Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and ... | 2020-09-16T09:58:13 | <patch>
diff --git a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey.java b/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey.java
--- a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey... | diff --git a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/service/DiagnosisKeyServiceTest.java b/common/persistence/src/test/java/app/coronawarn/server/common/persistence/service/DiagnosisKeyServiceTest.java
--- a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/ser... | |||||
corona-warn-app__cwa-server-387 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Use typed client and entities for tan verification
## Current Implementation
The current tan verification look like this:
https://github.com/corona-warn-app/cwa-server/blob/3b98beb268bac511c00f8e13bcbb4978a8c... | corona-warn-app/cwa-server | db3d5faa1fe2702ef32ee0e3a965d0097c394df7 | Use typed client and entities for tan verification
## Current Implementation
The current tan verification look like this:
https://github.com/corona-warn-app/cwa-server/blob/3b98beb268bac511c00f8e13bcbb4978a8cdb4fd/services/submission/src/main/java/app/coronawarn/server/services/submission/verification/TanVerifier.jav... | I like those suggestions. The introduction of a value object for a TAN is something I thought about suggesting as well. Would bind the verification logic into a value and make the using code more expressive and safe.
Although I am more of a hypermedia guy and thus not a big fan of hard coding URIs in clients, I thin... | 2020-05-30T17:08:20 | <patch>
diff --git a/THIRD-PARTY-NOTICES b/THIRD-PARTY-NOTICES
--- a/THIRD-PARTY-NOTICES
+++ b/THIRD-PARTY-NOTICES
@@ -80,6 +80,11 @@ Licensor: VMWare Inc.
Website: https://spring.io/
License: Apache License 2.0
+Component: Spring Cloud
+Licensor: VMWare Inc.
+Website: https://spring.io/
+License: Apache ... | diff --git a/services/submission/src/test/java/app/coronawarn/server/services/submission/verification/FeignTestConfiguration.java b/services/submission/src/test/java/app/coronawarn/server/services/submission/verification/FeignTestConfiguration.java
new file mode 100644
--- /dev/null
+++ b/services/submission/src/test/j... | ||||
corona-warn-app__cwa-server-260 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Exposure configuration parameters not validated
The exposure configuration parameters are currently not validated after being read from the respective yml file. The validation code in ``ExposureConfigurationVal... | corona-warn-app/cwa-server | 218e0c75d3890fd6c1166fc63ce287f3b9d51fa7 | Exposure configuration parameters not validated
The exposure configuration parameters are currently not validated after being read from the respective yml file. The validation code in ``ExposureConfigurationValidator`` is currently used in tests only.
However, the expected behavior shall be the following:
- The ``... | 2020-05-22T19:20:31 | <patch>
diff --git a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/risk_score_classification.proto b/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/risk_score_classification.proto
new file mode 100644
--- /dev/null
+++ b/common/protocols/src/main/proto/... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/exposureconfig/ExposureConfigurationProviderMasterFileTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/ExposureConfigurationProviderMasterFileTest.java
simi... | |||||
corona-warn-app__cwa-server-441 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Application Configuration: Attenuation Duration Enhancements
We need two additional configuration variables for the attenuation duration, namely defaultBucketOffset and riskScoreNormalizationDivisor.
The tar... | corona-warn-app/cwa-server | 2165f162938409e6401c926d8643835a114ab887 | Application Configuration: Attenuation Duration Enhancements
We need two additional configuration variables for the attenuation duration, namely defaultBucketOffset and riskScoreNormalizationDivisor.
The target config should look like this:
```yaml
default-bucket-offset: 0 # discussed as W4
risk-score-normaliza... | @michael-burwig
Proposed .proto file:
```
syntax = "proto3";
package app.coronawarn.server.common.protocols.internal;
option java_package = "app.coronawarn.server.common.protocols.internal";
option java_multiple_files = true;
message AttenuationDuration {
Thresholds thresholds = 1;
Weights weights = 2;
... | 2020-06-03T19:38:59 | <patch>
diff --git a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/attenuation_duration.proto b/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/attenuation_duration.proto
--- a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/intern... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/AttenuationDurationValidatorTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/AttenuationDurationValidatorTest.java
--- a/ser... | ||||
corona-warn-app__cwa-server-541 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
SSL: Set a profile to willingly decrease security
Currently, we have the profiles `ssl-server`, `ssl-client-verification` and `ssl-client-postgres` which will enable `ssl` for certain situations.
In context... | corona-warn-app/cwa-server | 27ba812e04d6f842e15999adfbe388137b0c316b | SSL: Set a profile to willingly decrease security
Currently, we have the profiles `ssl-server`, `ssl-client-verification` and `ssl-client-postgres` which will enable `ssl` for certain situations.
In context of secure-by-default, we should have it in the opposite way - you can set a profile to willingly decrease sec... | 2020-06-11T13:35:23 | <patch>
diff --git a/README.md b/README.md
--- a/README.md
+++ b/README.md
@@ -113,12 +113,14 @@ For the distribution module:
```bash
POSTGRESQL_SERVICE_PORT=8001
VAULT_FILESIGNING_SECRET=</path/to/your/private_key>
+SPRING_PROFILES_ACTIVE=signature-dev,disable-ssl-client-postgres
```
For the submission module:
... | diff --git a/services/submission/src/test/java/app/coronawarn/server/services/submission/ServerApplicationTests.java b/services/submission/src/test/java/app/coronawarn/server/services/submission/ServerApplicationTests.java
--- a/services/submission/src/test/java/app/coronawarn/server/services/submission/ServerApplicati... | |||||
corona-warn-app__cwa-server-424 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Application Configuration: Add version update support
We would like to keep the mobile application informed about new releases/current release of the app. This information can then be presented to the user, in ... | corona-warn-app/cwa-server | 2be284e0518658dcb7ef8d1df5515fd5f962e242 | Application Configuration: Add version update support
We would like to keep the mobile application informed about new releases/current release of the app. This information can then be presented to the user, in order to ask for applying updates.
We would like to add new fields to the application config (example valu... | 2020-06-02T19:03:56 | <patch>
diff --git a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto b/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto
--- a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto
... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/ApplicationVersionConfigurationProviderMasterFileTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/ApplicationVersionConfigurationProviderMasterFil... | |||||
corona-warn-app__cwa-server-422 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Application Config: Add new Parameter attenuationDurationThresholds
Add a new parameter to the application configuration, called "attenuationDurationTresholds". With the help of this parameter, we will be able ... | corona-warn-app/cwa-server | 1032f0e5950d2d6fa064da7026825e3c25260c79 | Application Config: Add new Parameter attenuationDurationThresholds
Add a new parameter to the application configuration, called "attenuationDurationTresholds". With the help of this parameter, we will be able to calculate the overall risk factor much better.
Default values are: X=50, Y=70. There will be call with t... | Are there any known constraints that define the validity of X/Y values?
Should be:
- type: integer
- 0 to 100 (upper bound might change though, but use 100 for now)
- x must by lower than y -> so would also be nice to make that more explicit, by calling them lower and upper. (edited description of ticket) | 2020-06-02T17:41:10 | <patch>
diff --git a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto b/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto
--- a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto
... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ApplicationConfigurationValidatorTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ApplicationConfigurationValidatorTest.java... | ||||
corona-warn-app__cwa-server-652 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Validate that no attributes are missing in .yaml
validate that no attributes are missing in .yaml when accordingly re-enable the ``ScoreNegative`` test case in:
https://github.com/corona-warn-app/cwa-server/bl... | corona-warn-app/cwa-server | ac86a35d9c4a40d55315ce50052ea0e4a64f036e | Validate that no attributes are missing in .yaml
validate that no attributes are missing in .yaml when accordingly re-enable the ``ScoreNegative`` test case in:
https://github.com/corona-warn-app/cwa-server/blob/master/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/v... | 2020-07-06T08:16:37 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ValidationError.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ValidationError.java
--- a/services/distribution/src/mai... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ExposureConfigurationValidatorTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ExposureConfigurationValidatorTest.java
--- a... | |||||
corona-warn-app__cwa-server-436 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Remove "empty" dates/hours from index files
## Current Implementation
All dates/hours between the first submission and now (last full hour) are included in the index files, even if there were no submissions.
... | corona-warn-app/cwa-server | ebb112166c8b6bf21ba18232db773be9a03b93e8 | Remove "empty" dates/hours from index files
## Current Implementation
All dates/hours between the first submission and now (last full hour) are included in the index files, even if there were no submissions.
## Suggested Enhancement
Only list dates/hours for which there were submissions in the index files. The "em... | Why should the empty files still be generated?
Basically to attest that there were really no submissions in that time window (and that the distribution run didn't just fail). Since we are not (yet) signing index files, I guess the best we can do is to just create and sign the empty exports. | 2020-06-03T16:28:18 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/component/DiagnosisKeysStructureProvider.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/component/DiagnosisKeysStructureProvider.java
--- a/services/distribution... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerExpiryPolicyTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerExpiryPolicyTest.java
new file ... | ||||
corona-warn-app__cwa-server-346 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Retention: Enforce period on Object Store
Currently, the retention period is only enforced for keys on the database, but it should be enforced on the S3 as well.
Therefore, we need to delete the items on the... | corona-warn-app/cwa-server | 92f3c9bd98420cd26c4216cace3e481874be6140 | Retention: Enforce period on Object Store
Currently, the retention period is only enforced for keys on the database, but it should be enforced on the S3 as well.
Therefore, we need to delete the items on the S3, when the retention policy is reached.
When the retention mechanism is kicked off, and then delete the ... | I propose to just remove the "delta upload" feature from the S3Publisher (see [here](https://github.com/corona-warn-app/cwa-server/blob/master/services/distribution/src/main/java/app/coronawarn/server/services/distribution/objectstore/S3Publisher.java#L75)) and instead just wipe the whole bucket on every distribution r... | 2020-05-27T15:03:01 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccess.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccess.java
--- a/services/distribution/src/main/java/app/coronawarn/server/ser... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/S3RetentionPolicyTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/S3RetentionPolicyTest.java
new file mode 100644
--- /dev/null
+++ b/services/distribution/src/... | ||||
corona-warn-app__cwa-server-466 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
S3Publisher: Increase performance
The S3Publisher is currently running in only one thread, making it quite slow for uploads/requests for metadata.
Enhance the S3Publisher/ObjectStoreAccess, so that multiple ... | corona-warn-app/cwa-server | b148f9eae02d75e509e9b0cc1ae0cdd3fbbad77e | S3Publisher: Increase performance
The S3Publisher is currently running in only one thread, making it quite slow for uploads/requests for metadata.
Enhance the S3Publisher/ObjectStoreAccess, so that multiple threads are being used for interacting with S3.
| 2020-06-06T12:41:36 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/config/DistributionServiceConfig.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/config/DistributionServiceConfig.java
--- a/services/distribution/src/main/java/app/coronawarn/serv... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccessTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccessTest.java
--- a/services/distribution/src/test/java/app/coronawarn/server/ser... | |||||
corona-warn-app__cwa-server-573 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Add JPA range validator for submissionTimestamp of DiagnosisKey
DiagnosisKey uses a submissionTimestamp field of type long
https://github.com/corona-warn-app/cwa-server/blob/7059232b48d2507d142fe683fbebdda37... | corona-warn-app/cwa-server | 670560bd755a94fe8cf7dfea5bba13c9b64858ed | Add JPA range validator for submissionTimestamp of DiagnosisKey
DiagnosisKey uses a submissionTimestamp field of type long
https://github.com/corona-warn-app/cwa-server/blob/7059232b48d2507d142fe683fbebdda371a98652/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey.java#L73... | I could open a PR wit the proposal if you think it makes sense
the getter and Builder already do have javadoc "hours since epoch"
https://github.com/corona-warn-app/cwa-server/blob/master/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyBuilders.java#L80
so it's actua... | 2020-06-13T22:50:51 | <patch>
diff --git a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey.java b/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey.java
--- a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey... | diff --git a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyBuilderTest.java b/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyBuilderTest.java
--- a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domai... | ||||
corona-warn-app__cwa-server-572 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
S3ClientWrapper getObjects: Not all objects could be received
<!--
Thanks for reporting a bug 🙌 ❤️
Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensu... | corona-warn-app/cwa-server | 97f16ca7b711a30eec695c1ae7a6f032df16533b | S3ClientWrapper getObjects: Not all objects could be received
<!--
Thanks for reporting a bug 🙌 ❤️
Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and ... | 2020-06-13T13:23:53 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/objectstore/client/S3ClientWrapper.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/objectstore/client/S3ClientWrapper.java
--- a/services/distribution/src/main/java/app/coronawarn/... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/client/S3ClientWrapperTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/client/S3ClientWrapperTest.java
--- a/services/distribution/src/test/java/app/coronawarn/... | |||||
corona-warn-app__cwa-server-463 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Distribution: Add Safeguard to not generate any exposure key file > 16MB
In order to prevent issues on the mobile device & potential abuse, add a safeguard, so that we do not publish any files, which are bigger... | corona-warn-app/cwa-server | eb68e1126a4f9bcb169afef6a2ca1dbbbcf8b3cd | Distribution: Add Safeguard to not generate any exposure key file > 16MB
In order to prevent issues on the mobile device & potential abuse, add a safeguard, so that we do not publish any files, which are bigger than 16MB. In case this threshold is reached for any file, an error message must be logged.
Make sure to k... | > In order to align with the current concept of always generating a file, we should generate an empty file in this case as well.
Will skip generating files larger than 600,000 keys in order to stay constistent with the current implementation. | 2020-06-05T22:23:20 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/DiagnosisKeyBundler.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/DiagnosisKeyBundler.java
--- a/services/distribution/src/main/java... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/structure/directory/decorator/DateIndexingDecoratorTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/structure/directory/decorator/DateInde... | ||||
corona-warn-app__cwa-server-272 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Update signature algorithm to SHA-256 + ECDSA P-256
## Feature description
The current CWA server implementation signs diagnosis key packages with the ``Ed25519`` algorithm. However, the current [Google/Apple ... | corona-warn-app/cwa-server | 73b566ec755cc61fc4c08da274c133535adb6ae7 | Update signature algorithm to SHA-256 + ECDSA P-256
## Feature description
The current CWA server implementation signs diagnosis key packages with the ``Ed25519`` algorithm. However, the current [Google/Apple spec](https://developer.apple.com/documentation/exposurenotification/setting_up_an_exposure_notification_serve... | 2020-05-23T13:07:15 | <patch>
diff --git a/docker-compose-test-secrets/certificate.crt b/docker-compose-test-secrets/certificate.crt
--- a/docker-compose-test-secrets/certificate.crt
+++ b/docker-compose-test-secrets/certificate.crt
@@ -1,16 +1,18 @@
-----BEGIN CERTIFICATE-----
-MIHxMIGkAgFkMAUGAytlcDAkMSIwIAYDVQQDDBlFTkEgVGVzdCBSb290IENlc... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/RiskScoreClassificationProviderMasterFileTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/RiskScoreClassificationProviderMasterFileTest.java
--- a... | |||||
corona-warn-app__cwa-server-551 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
BatchCounter uses Double for counting
## Describe the bug
BatchCounter uses `double` for integer arithmetics, which is commonly discouraged.
## Expected behaviour
BatchCounter uses `int` for counting u... | corona-warn-app/cwa-server | 39cf982dab39722accf5cbb2cc6f2c6ef15c8456 | BatchCounter uses Double for counting
## Describe the bug
BatchCounter uses `double` for integer arithmetics, which is commonly discouraged.
## Expected behaviour
BatchCounter uses `int` for counting up to `batchSize`, since `batchSize` is also of type `int`.
It's faster.
In theory it's more accurate. (In pr... | 2020-06-11T18:31:41 | <patch>
diff --git a/services/submission/src/main/java/app/coronawarn/server/services/submission/config/SubmissionServiceConfig.java b/services/submission/src/main/java/app/coronawarn/server/services/submission/config/SubmissionServiceConfig.java
--- a/services/submission/src/main/java/app/coronawarn/server/services/su... | diff --git a/services/submission/src/test/java/app/coronawarn/server/services/submission/monitoring/BatchCounterTest.java b/services/submission/src/test/java/app/coronawarn/server/services/submission/monitoring/BatchCounterTest.java
new file mode 100644
--- /dev/null
+++ b/services/submission/src/test/java/app/coronawa... | |||||
corona-warn-app__cwa-server-349 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
S3Publisher should set Cache Control Headers
The S3Publisher is currently not setting Cache Control Headers. We should cache-control: public, maxage=N
N depends on the type of file:
- for hours index files,... | corona-warn-app/cwa-server | ef4edb4c92fb9bf65544e22e2b4f2e8f8a55fa97 | S3Publisher should set Cache Control Headers
The S3Publisher is currently not setting Cache Control Headers. We should cache-control: public, maxage=N
N depends on the type of file:
- for hours index files, it should be rather low (5 minutes)
- for days index files, it should be higher (2 hours)
- for all generat... | For the sake of simplicity, I think we can get away with just setting everything to 5 minutes. In the worst case, we need to expect requests for all available files by all 4 CDN master cache servers every 5 minutes. We serve a peak total of 356 files (1 version index, 1 version OpenAPI JSON, 2 country indices for diag... | 2020-05-27T19:29:49 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccess.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccess.java
--- a/services/distribution/src/main/java/app/coronawarn/server/ser... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccessUnitTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/ObjectStoreAccessUnitTest.java
new file mode 100644
--- /dev/null
+++ b/services/distribut... | ||||
corona-warn-app__cwa-server-431 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Application Configuration: Attenuation Duration
The RKI requested weighting parameters for the three buckets defined by the attenuation duration threshold. Add this to the attenuation duration configuration.
... | corona-warn-app/cwa-server | 20492aaed28176142700486f99877b602b9f1cde | Application Configuration: Attenuation Duration
The RKI requested weighting parameters for the three buckets defined by the attenuation duration threshold. Add this to the attenuation duration configuration.
@michael-burwig
```yaml
attenuation-duration:
thresholds:
lower: 50
upper: 70
weights:
... | Are the weights in the range of [0, 1]?
Is the threshold value range still [0, 100]?
Thresholds remain unchanged.
For weight, lets go with 0...1 for now. There will be another RKI call in the afternoon which might change that though. | 2020-06-03T09:23:16 | <patch>
diff --git a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto b/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto
--- a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/app_config.proto
... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/AttenuationDurationMasterFileTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/AttenuationDurationMasterFileTest.java
new file mode 100644
--- /dev... | ||||
corona-warn-app__cwa-server-308 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Apple's Proposal for Exposure Key Validation
#92 Current Implementation
We used sensible assumptions for key validation.
## Suggested Enhancement
[Apple proposes](https://developer.apple.com/documenta... | corona-warn-app/cwa-server | 9ef96cbec24163360512f3d4748a248d6eddd078 | Apple's Proposal for Exposure Key Validation
#92 Current Implementation
We used sensible assumptions for key validation.
## Suggested Enhancement
[Apple proposes](https://developer.apple.com/documentation/exposurenotification/setting_up_an_exposure_notification_server?changes=latest_beta):
> An EN server ... | Part of https://github.com/corona-warn-app/cwa-server/issues/168 | 2020-05-25T20:36:01 | <patch>
diff --git a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey.java b/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey.java
--- a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey... | diff --git a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyBuilderTest.java b/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyBuilderTest.java
--- a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domai... | ||||
corona-warn-app__cwa-server-676 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Wrong hash value for 2020-06-23 and 2020-06-24
<!--
Thanks for proposing an enhancement 🙌 ❤️
Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure thi... | corona-warn-app/cwa-server | 7e519598cbf2823ab655a057f8a0f77297bf6ed1 | Wrong hash value for 2020-06-23 and 2020-06-24
<!--
Thanks for proposing an enhancement 🙌 ❤️
Before opening a new issue, please make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a ... | Initial suspicion: Retention Policy kicked in and deleted older keys, which were not immediately distributed due to shifting policy. This in turn did lead to even less keys for the first days of CWA so the other packages were now also shifted.
<del>I believe this only affects hourly packages as retention enforcement... | 2020-07-20T15:16:34 | <patch>
diff --git a/docker-compose.yml b/docker-compose.yml
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -46,6 +46,7 @@ services:
services.distribution.paths.output: /tmp/distribution
# Settings for cryptographic artifacts
VAULT_FILESIGNING_SECRET: ${SECRET_PRIVATE}
+ FORCE_UPDATE_KEY... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerKeyRetrievalTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerKeyRetrievalTest.java
--- a/ser... | ||||
corona-warn-app__cwa-server-429 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Use Implicit Constructor Injection over Explicit
The `@Autowired` annotation for Spring components can be omitted for constructors in case there is only one constructor present on the class. Therefore, remove a... | corona-warn-app/cwa-server | 528b73595c202a8216bd321dafd431206a6fd2c0 | Use Implicit Constructor Injection over Explicit
The `@Autowired` annotation for Spring components can be omitted for constructors in case there is only one constructor present on the class. Therefore, remove all the unnecessary annotation for those cases.
| I guess it should be doable for me to get started | 2020-06-02T21:54:44 | <patch>
diff --git a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/service/DiagnosisKeyService.java b/common/persistence/src/main/java/app/coronawarn/server/common/persistence/service/DiagnosisKeyService.java
--- a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/ser... | diff --git a/services/submission/src/test/java/app/coronawarn/server/services/submission/controller/RequestExecutor.java b/services/submission/src/test/java/app/coronawarn/server/services/submission/controller/RequestExecutor.java
--- a/services/submission/src/test/java/app/coronawarn/server/services/submission/control... | ||||
corona-warn-app__cwa-server-419 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
S3Publisher: Resilience
The S3Publisher/ObjectStoreAccess is currently lacking resilience features, like re-trys and error handling.
</issue>
<code>
[start of README.md]
1 <!-- markdownlint-disable MD041 -->... | corona-warn-app/cwa-server | 896d24d3730d455ddc7a67bdaebd843ba7bd91dd | S3Publisher: Resilience
The S3Publisher/ObjectStoreAccess is currently lacking resilience features, like re-trys and error handling.
| 2020-06-02T14:48:26 | <patch>
diff --git a/services/distribution/pom.xml b/services/distribution/pom.xml
--- a/services/distribution/pom.xml
+++ b/services/distribution/pom.xml
@@ -78,6 +78,11 @@
<groupId>org.apache.commons</groupId>
<version>3.2</version>
</dependency>
+ <dependency>
+ <artifactId>spring-retry</a... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/ApplicationVersionConfigurationProviderMasterFileTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/ApplicationVersionConfigurationProviderMasterFil... | |||||
corona-warn-app__cwa-server-135 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Submission Service: Enable waiting for Fake Requests
When fake requests are send to the submission service, ensure that the duration of the fake requests take as long as normal requests, so attackers sniffing t... | corona-warn-app/cwa-server | 8655863c4c989c437ad9b5ef84c7e2afb699be8d | Submission Service: Enable waiting for Fake Requests
When fake requests are send to the submission service, ensure that the duration of the fake requests take as long as normal requests, so attackers sniffing the traffic are unable to distinguish between fake/normal requests.
| 2020-05-17T13:49:18 | <patch>
diff --git a/services/submission/pom.xml b/services/submission/pom.xml
--- a/services/submission/pom.xml
+++ b/services/submission/pom.xml
@@ -22,6 +22,12 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-security</artifactId>
</dependency>
+ <dependency>
+ ... | diff --git a/services/submission/src/test/resources/application.properties b/services/submission/src/test/resources/application.properties
--- a/services/submission/src/test/resources/application.properties
+++ b/services/submission/src/test/resources/application.properties
@@ -3,4 +3,7 @@ logging.level.org.springframe... | |||||
corona-warn-app__cwa-server-45 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Diagnosis key submission unit tests
Implement unit tests for the diagnosis key submission service according to best practices.
</issue>
<code>
[start of README.md]
1 # cwa-server
2
3 # API
4 ## Distribution
... | corona-warn-app/cwa-server | e8ca246da1ab3620b6340383d4a59fe2041af562 | Diagnosis key submission unit tests
Implement unit tests for the diagnosis key submission service according to best practices.
| 2020-05-08T09:00:07 | <patch>
diff --git a/common/persistence/src/main/java/app/coronawarn/server/services/common/persistence/service/DiagnosisKeyService.java b/common/persistence/src/main/java/app/coronawarn/server/services/common/persistence/service/DiagnosisKeyService.java
--- a/common/persistence/src/main/java/app/coronawarn/server/serv... | diff --git a/services/distribution/src/test/resources/application.properties b/services/distribution/src/test/resources/application.properties
--- a/services/distribution/src/test/resources/application.properties
+++ b/services/distribution/src/test/resources/application.properties
@@ -1,5 +1,4 @@
-spring.datasource.dr... | |||||
corona-warn-app__cwa-server-386 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
TEK Exports should not contain any keys which recently expired
Currently the system also packages keys, which expired recently. Instead, only keys which have been expired since at least 2 hours should be part o... | corona-warn-app/cwa-server | 943a9cea975f6395f99217bb380e526e937f093e | TEK Exports should not contain any keys which recently expired
Currently the system also packages keys, which expired recently. Instead, only keys which have been expired since at least 2 hours should be part of the export.
Can also be a nice prework for https://github.com/corona-warn-app/cwa-server/issues/108.
P... | [Apple spec](https://developer.apple.com/documentation/exposurenotification/setting_up_an_exposure_notification_server) states:
> [Your EN Server...] must not distribute temporary exposure key data until at least 2 hours after the end of the keyʼs expiration window
I think this is a subtle but important differenc... | 2020-05-30T14:56:55 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/structure/directory/DiagnosisKeysHourDirectory.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/structure/directory/DiagnosisKeysHourDi... | diff --git a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyTest.java b/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKeyTest.java
--- a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/domain/DiagnosisKey... | ||||
corona-warn-app__cwa-server-388 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Ensure uniqueness of diagnosis keys
## Current Implementation
The uniqueness of diagnosis keys is neither guaranteed by the database, nor by validation logic.
## Suggested Enhancement
Ensure that diagnosis... | corona-warn-app/cwa-server | 00a342298942773ee49eeea9387a2acd164c3d49 | Ensure uniqueness of diagnosis keys
## Current Implementation
The uniqueness of diagnosis keys is neither guaranteed by the database, nor by validation logic.
## Suggested Enhancement
Ensure that diagnosis keys in the database are unique (there are no duplicates).
What needs to be decided:
- [x] Is it sufficie... | Decisions made by @christian-kirschnick:
- Ensuring the uniqueness of the diagnosis key is sufficient
- Duplicate check should happen on the database
- `id` column should be removed
- `key_data` column should become primary key
- If we encounter problems with the current type (`bytea`) of `key_data` as primary key... | 2020-05-30T23:22:36 | <patch>
diff --git a/common/persistence/pom.xml b/common/persistence/pom.xml
--- a/common/persistence/pom.xml
+++ b/common/persistence/pom.xml
@@ -78,7 +78,7 @@
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
- <version>1.4.199</version>
+ <version>1.4.200</versio... | diff --git a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/service/DiagnosisKeyServiceTest.java b/common/persistence/src/test/java/app/coronawarn/server/common/persistence/service/DiagnosisKeyServiceTest.java
--- a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/ser... | ||||
corona-warn-app__cwa-server-642 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
[MINOR] Incorrect value range in attenuation risk parameter
## Describe the bug
The `AttenuationRiskParameters` proto message (see [here](https://github.com/corona-warn-app/cwa-server/blob/master/common/protoc... | corona-warn-app/cwa-server | fa9adc6631233172684910191efdf00429799365 | [MINOR] Incorrect value range in attenuation risk parameter
## Describe the bug
The `AttenuationRiskParameters` proto message (see [here](https://github.com/corona-warn-app/cwa-server/blob/master/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/risk_score_parameters.proto)) is defined as... | 2020-07-01T11:58:13 | <patch>
diff --git a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/risk_score_parameters.proto b/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/risk_score_parameters.proto
--- a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/inte... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/YamlLoaderTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/YamlLoaderTest.java
--- a/services/distribution/src/test/java/app/coronawarn/server/ser... | |||||
corona-warn-app__cwa-server-350 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Blank URL in RiskScoreClassificationValidator
In `app.coronawarn.server.services.distribution.assembly.appconfig.validation.RiskScoreClassificationValidator#validateUrl` [(link to source code)](https://github.c... | corona-warn-app/cwa-server | 8d8a0a5e16bc252364812017a85418b054d739f7 | Blank URL in RiskScoreClassificationValidator
In `app.coronawarn.server.services.distribution.assembly.appconfig.validation.RiskScoreClassificationValidator#validateUrl` [(link to source code)](https://github.com/corona-warn-app/cwa-server/blob/63dda0c2a5e1ff09fe998dd05637d76dea2e3833/services/distribution/src/main/jav... | Confirmed URL should **not** be empty - It should be a valid URL with http/https as allowed protocol | 2020-05-27T19:55:53 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/RiskScoreClassificationValidator.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/RiskScoreClassificationValidator.java
-... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/RiskScoreClassificationValidatorTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/RiskScoreClassificationValidatorTest.java
-... | ||||
corona-warn-app__cwa-server-378 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Remove MinIO SDK and use AWS SDK instead
Since MinIO SDK still hasn't released a fix version for fixing the XML vulnerability in the SimpleXML library, we need to consider alternative S3 SDK's. Therefore, prepa... | corona-warn-app/cwa-server | 79eef3fa06e3e6bd1bfa9a97c0959d62551295b8 | Remove MinIO SDK and use AWS SDK instead
Since MinIO SDK still hasn't released a fix version for fixing the XML vulnerability in the SimpleXML library, we need to consider alternative S3 SDK's. Therefore, prepare an alternative approach with AWS SDK, which is then used by the ObjectStoreAccess class.
| 2020-05-29T21:57:57 | <patch>
diff --git a/services/distribution/pom.xml b/services/distribution/pom.xml
--- a/services/distribution/pom.xml
+++ b/services/distribution/pom.xml
@@ -54,9 +54,9 @@
<artifactId>distribution</artifactId>
<dependencies>
<dependency>
- <groupId>io.minio</groupId>
- <artifactId>minio</artifactI... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/client/MinioClientWrapperTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/objectstore/client/MinioClientWrapperTest.java
deleted file mode 100644
--- a/services/distributio... | |||||
corona-warn-app__cwa-server-972 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
[BSI][20201107] Denial-of-Service in Download Service
Rating: Informational
Description:
The download service component of the cwa-server backend can be forced into an endless loop by a malicious or faulty ... | corona-warn-app/cwa-server | e3f867a8005bd7f79c9eabe269d168fc01330484 | [BSI][20201107] Denial-of-Service in Download Service
Rating: Informational
Description:
The download service component of the cwa-server backend can be forced into an endless loop by a malicious or faulty federation gateway server. When downloading new batches from the federation gateway server, the download servi... | 2020-11-09T15:39:20 | <patch>
diff --git a/services/download/src/main/java/app/coronawarn/server/services/download/FederationBatchProcessor.java b/services/download/src/main/java/app/coronawarn/server/services/download/FederationBatchProcessor.java
--- a/services/download/src/main/java/app/coronawarn/server/services/download/FederationBatch... | diff --git a/services/download/src/test/java/app/coronawarn/server/services/download/FederationBatchProcessorTest.java b/services/download/src/test/java/app/coronawarn/server/services/download/FederationBatchProcessorTest.java
--- a/services/download/src/test/java/app/coronawarn/server/services/download/FederationBatch... | |||||
corona-warn-app__cwa-server-113 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
DiagnosisKeyDistributionRunner deletes exposure configuration
``DiagnosisKeyDistributionRunner`` deletes the files written by ``ExposureConfigurationDistributionRunner`` before they are published.
</issue>
<c... | corona-warn-app/cwa-server | ac44b28ad79130bd39e2d002cddf3a67799a80fb | DiagnosisKeyDistributionRunner deletes exposure configuration
``DiagnosisKeyDistributionRunner`` deletes the files written by ``ExposureConfigurationDistributionRunner`` before they are published.
| 2020-05-15T14:41:59 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/crypto/CryptoProvider.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/component/CryptoProvider.java
similarity index 89%
rename from services/distribution/src/main/java/ap... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/ApplicationInitializationTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/ApplicationInitializationTest.java
--- a/services/distribution/src/test/java/app/coronawarn/server/services/di... | |||||
corona-warn-app__cwa-server-659 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Plausible Deniability: Add "Padding" property to submission payload
Currently, mobile apps are collecting keys based on their install date. When a user uploads his keys (after being tested positive), the payloa... | corona-warn-app/cwa-server | ee78bf15ece7f282836149b5f39422892f055096 | Plausible Deniability: Add "Padding" property to submission payload
Currently, mobile apps are collecting keys based on their install date. When a user uploads his keys (after being tested positive), the payload will contain 1-13 keys. Although the traffic between mobile & server is secured, an attacker may still sniff... | 2020-07-10T07:37:14 | <patch>
diff --git a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/submission_payload.proto b/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/submission_payload.proto
--- a/common/protocols/src/main/proto/app/coronawarn/server/common/protocols/internal/s... | diff --git a/services/submission/src/test/java/app/coronawarn/server/services/submission/config/SubmissionServiceConfigValidatorTest.java b/services/submission/src/test/java/app/coronawarn/server/services/submission/config/SubmissionServiceConfigValidatorTest.java
new file mode 100644
--- /dev/null
+++ b/services/submi... | |||||
corona-warn-app__cwa-server-629 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Simplifying DateAggregatingDecorator
The DateAggregatingDecorator should make more use of the `DiagnosisKeyBundler`. Please team up with @pithumke on this.
</issue>
<code>
[start of README.md]
1 <!-- markdow... | corona-warn-app/cwa-server | 2e2655a94ae13a663cdbbcb17c5b1065edccf90b | Simplifying DateAggregatingDecorator
The DateAggregatingDecorator should make more use of the `DiagnosisKeyBundler`. Please team up with @pithumke on this.
| 2020-06-25T15:35:31 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/structure/directory/AppConfigurationDirectory.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/structure/directory/AppConfigurationDirectory.ja... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerKeyRetrievalTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/diagnosiskeys/ProdDiagnosisKeyBundlerKeyRetrievalTest.java
--- a/ser... | |||||
corona-warn-app__cwa-server-106 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Set Retention Days to 14
Any key data that is associated to a point in time older than 14 days shall be removed from the database and will also be removed from the CDN and therefore the index file.
</issue>
<... | corona-warn-app/cwa-server | 23b492fe7b9f0821f2a8c34516cb858efcfaa55b | Set Retention Days to 14
Any key data that is associated to a point in time older than 14 days shall be removed from the database and will also be removed from the CDN and therefore the index file.
| 2020-05-14T23:08:17 | <patch>
diff --git a/common/persistence/src/main/java/app/coronawarn/server/common/persistence/repository/DiagnosisKeyRepository.java b/common/persistence/src/main/java/app/coronawarn/server/common/persistence/repository/DiagnosisKeyRepository.java
--- a/common/persistence/src/main/java/app/coronawarn/server/common/per... | diff --git a/common/persistence/src/test/java/app/coronawarn/server/common/persistence/TestApplication.java b/common/persistence/src/test/java/app/coronawarn/server/common/persistence/TestApplication.java
new file mode 100644
--- /dev/null
+++ b/common/persistence/src/test/java/app/coronawarn/server/common/persistence/... | |||||
corona-warn-app__cwa-server-352 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
Sonar - Mitigate/Audit synchronized class "Stack"
See https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-server&issues=AXI3CJu7vPFV4POpyUFA&open=AXI3CJu7vPFV4POpyUFA
Strongly consider using existing... | corona-warn-app/cwa-server | 207bdd8d4d701ab8df608db7caa9f2613fa86b84 | Sonar - Mitigate/Audit synchronized class "Stack"
See https://sonarcloud.io/project/issues?id=corona-warn-app_cwa-server&issues=AXI3CJu7vPFV4POpyUFA&open=AXI3CJu7vPFV4POpyUFA
Strongly consider using existing [data structure implementations.](https://www.eclipse.org/collections/javadoc/9.2.0/org/eclipse/collections/a... | 2020-05-27T23:46:21 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/structure/directory/IndexDirectory.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/structure/directory/IndexDirectory.java
--- a/services/distribution/src/main/ja... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/structure/util/ImmutableStackTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/structure/util/ImmutableStackTest.java
new file mode 100644
--- /dev/null
+++ b/services... | |||||
corona-warn-app__cwa-server-299 | You will be provided with a partial code base and an issue statement explaining a problem to resolve.
<issue>
RKI: Adjust Risk Score Parameters in master config
RKI decided for the following risk score parameter values:
```
1 2 3 4 5 6 7 8 // Bucket No.
-------------------... | corona-warn-app/cwa-server | c5991b2fcb894aa4a8eec41c51a2f2cc366a13b5 | RKI: Adjust Risk Score Parameters in master config
RKI decided for the following risk score parameter values:
```
1 2 3 4 5 6 7 8 // Bucket No.
----------------------------------------------------------
0 1 2 4 5 7 8 8 // Duration... | Config file that needs updating: [master.yaml](https://github.com/corona-warn-app/cwa-server/blob/master/services/distribution/src/main/resources/exposure-config/master.yaml) | 2020-05-25T09:41:14 | <patch>
diff --git a/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ExposureConfigurationValidator.java b/services/distribution/src/main/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ExposureConfigurationValidator.java
--- a... | diff --git a/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ExposureConfigurationValidatorTest.java b/services/distribution/src/test/java/app/coronawarn/server/services/distribution/assembly/appconfig/validation/ExposureConfigurationValidatorTest.java
--- a... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.