Datasets:
feedback-to-code
/
mozzarella

Dataset card Data Studio Files
xet
 Community
1
instance_id
stringlengths
17
39
repo
stringclasses
8 values
issue_id
stringlengths
14
34
pr_id
stringlengths
14
34
linking_methods
listlengths
1
3
base_commit
stringlengths
40
40
merge_commit
stringlengths
0
40
⌀
hints_text
listlengths
0
106
resolved_comments
listlengths
0
119
created_at
timestamp[ns, tz=UTC]
labeled_as
listlengths
0
7
problem_title
stringlengths
7
174
problem_statement
stringlengths
0
55.4k
gold_files
listlengths
0
10
gold_files_postpatch
listlengths
1
10
test_files
listlengths
0
60
gold_patch
stringlengths
220
5.83M
test_patch
stringlengths
386
194k
⌀
split_random
stringclasses
3 values
split_time
stringclasses
3 values
issue_start_time
timestamp[ns]
issue_created_at
timestamp[ns, tz=UTC]
issue_by_user
stringlengths
3
21
split_repo
stringclasses
3 values
netty/netty/6628_6635
netty/netty
netty/netty/6628
netty/netty/6635
[ "timestamp(timedelta=108971.0, similarity=0.8467740071384211)" ]
cc5d1d0a7e6475c6dc3628321c17a62785016163
59e95c98afa10568327d2678c4e1c65f99131041
[ "Fixed... we now also deploy the OS X snapshot version", "Which remote repository will upload? Is it only sonatype-nexus?", "https://oss.sonatype.org/content/repositories/snapshots/io/netty/netty-tcnative/2.0.1.Final-SNAPSHOT/\r\n\r\nWe will release a final version this week tho", "At this time ,the final ver...
[]
2017-04-18T08:14:00Z
[]
Could not find artifact io.netty:netty-tcnative:jar:osx-x86_64:2.0.1.Final-SNAPSHOT
### Expected behavior mvn -s ~/.m2/settings_default.xml package is ok. ### Actual behavior Could not find artifact io.netty:netty-tcnative:jar:osx-x86_64:2.0.1.Final-SNAPSHOT ### Steps to reproduce 1.git clone https://github.com/netty/netty.git 2.mvn -s ~/.m2/settings_default.xml package ### Minimal yet ...
[ "pom.xml" ]
[ "pom.xml" ]
[]
diff --git a/pom.xml b/pom.xml index a2ebfb0ce6d..86d54c3ce3f 100644 --- a/pom.xml +++ b/pom.xml @@ -242,7 +242,7 @@ <!-- Fedora-"like" systems. This is currently only used for the netty-tcnative dependency --> <os.detection.classifierWithLikes>fedora</os.detection.classifierWithLikes> <tcnative.artifact...
null
train
train
2017-04-18T08:16:33
2017-04-16T02:06:12Z
typercode
val
netty/netty/6577_6636
netty/netty
netty/netty/6577
netty/netty/6636
[ "timestamp(timedelta=51941.0, similarity=0.8466659931370951)" ]
cc5d1d0a7e6475c6dc3628321c17a62785016163
0babef24a9a63282eb9d0aec570b99a1639bd723
[ "from https://github.com/netty/netty/pull/6601#issuecomment-291454620\r\n\r\n<details><pre><code>\r\n[09:17:00] :\t\t [io.netty:netty-codec-http2] 09:17:00.076 [main] ERROR io.netty.util.ResourceLeakDetector - LEAK: ByteBuf.release() was not called before it's garbage-collected. See http://netty.io/wiki/reference-c...
[]
2017-04-18T09:17:40Z
[ "defect" ]
HTTP/2 unit test LocalChannel ByteBuf leak
Leak observed on the CI servers while building PR #6000 CI build: https://garage.netty.io/teamcity/viewLog.html?buildId=18539&buildTypeId=pulls_netty&tab=buildLog Related: https://github.com/netty/netty/issues/5850 ``` [03:28:18] : [io.netty:netty-codec-http2] java.nio.channels.ClosedChannelException: nul...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java" ]
[]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java index d288e196a6d..0ed847f59d6 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java +++ b/codec-http2/src/main/java/i...
null
train
train
2017-04-18T08:16:33
2017-03-28T17:08:48Z
Scottmitch
val
netty/netty/6657_6658
netty/netty
netty/netty/6657
netty/netty/6658
[ "timestamp(timedelta=24.0, similarity=0.8852732037586727)" ]
799350c369e68462b61c6aef97db2a33ea937434
06ecb915bdff4e83baa7d041bbb65cb20c7a78fb
[ "Fixed by https://github.com/netty/netty/pull/6658" ]
[]
2017-04-22T17:19:45Z
[ "defect" ]
IpSubnetFilterRule throws ClassCastException when non expected IP version comes
### Expected behavior No error. `IpSubnetFilterRule.match` returns false. ### Actual behavior `IpSubnetFilterRule.match` throws `ClassCastException`. ### Steps to reproduce ``` IpSubnetFilterRule rule = new IpSubnetFilterRule("0.0.0.0", 0, IpFilterRuleType.ACCEPT); //remoteAddress.getAddress() instan...
[ "handler/src/main/java/io/netty/handler/ipfilter/IpSubnetFilterRule.java" ]
[ "handler/src/main/java/io/netty/handler/ipfilter/IpSubnetFilterRule.java" ]
[ "handler/src/test/java/io/netty/handler/ipfilter/IpSubnetFilterTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ipfilter/IpSubnetFilterRule.java b/handler/src/main/java/io/netty/handler/ipfilter/IpSubnetFilterRule.java index abcb150687f..b6c2e83ebca 100644 --- a/handler/src/main/java/io/netty/handler/ipfilter/IpSubnetFilterRule.java +++ b/handler/src/main/java/io/netty/handler/...
diff --git a/handler/src/test/java/io/netty/handler/ipfilter/IpSubnetFilterTest.java b/handler/src/test/java/io/netty/handler/ipfilter/IpSubnetFilterTest.java index e93908b67cf..0be4cab797d 100644 --- a/handler/src/test/java/io/netty/handler/ipfilter/IpSubnetFilterTest.java +++ b/handler/src/test/java/io/netty/handler/...
val
train
2017-04-22T17:26:47
2017-04-22T17:08:43Z
doom369
val
netty/netty/6674_6676
netty/netty
netty/netty/6674
netty/netty/6676
[ "timestamp(timedelta=26.0, similarity=1.0000000000000002)" ]
57d3393527a9dba78eda4365eae13c655e7b3f28
20c2891e8cfab711ac415e37a74cee672ad48c6b
[ "I'll fix this as it was my doing.", "@snicoll by removing the reference to the parent the version of the bom artifact is no longer updated when the version is bumped via Maven plugins, I will check into this soon.", "@johnou you can use the `oss-parent` (you'll have to add a few more details to the pom so that...
[ "According to [this page](https://maven.apache.org/guides/mini/guide-central-repository-upload.html) you need to add the `<url>`, `<license>` and `<scm>` tags to be able to deploy it to Maven central. Check the sample BOM in the related issue for reference.", "roger." ]
2017-04-27T10:04:09Z
[ "defect" ]
Netty BOM inherit from parent and its own dependency management
A BOM was recently added in #5994 but is not valid. A BOM should only expose dependency management for the artifacts that the project produces (so in this case, netty artifacts). It should not have an opinion about third party dependencies (otherwise including that BOM in a project potentially overrides decisions th...
[ "bom/pom.xml" ]
[ "bom/pom.xml" ]
[]
diff --git a/bom/pom.xml b/bom/pom.xml index dd72ee32e99..88d00a71cdb 100644 --- a/bom/pom.xml +++ b/bom/pom.xml @@ -15,136 +15,176 @@ ~ under the License. --> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/...
null
train
train
2017-04-27T04:05:16
2017-04-26T09:29:16Z
snicoll
val
netty/netty/3063_6688
netty/netty
netty/netty/3063
netty/netty/6688
[ "timestamp(timedelta=24.0, similarity=0.8425311106642784)" ]
6915ec3bb9f5ff20ca8a3ac9264117d208dc4ab7
9bbe9c1c87a76dcce9eb09dd301f54b7501bfb69
[ "Investigating more on this issue, I found out that due to the channel being closed right after sending the `CloseWebSocketFrame`, the client is unable to process the `CloseWebSocketFrame`, rising an `Exception` while trying to process it (as far as I'm able to reason). I have, both in the client and the server, an...
[]
2017-05-01T17:50:01Z
[ "defect" ]
WebSocketServerProtocolHandler breaks ChannelHandler's exceptionCaught behavior
`WebSocketServerProtocolHandler` overrides `exceptionCaught` method. If an exception happens in the pipeline before `WebSocketServerProtocolHandler` it closes the channel, leaving the Handlers that follow it unable to handle the `Exception`. This is the `WebSocketServerProtocolHandler's` `exceptionCaught` code: ``` ja...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java" ]
[]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java index bb150e39b09..7037ae34686 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocket...
null
train
train
2017-04-29T14:10:00
2014-10-28T15:10:51Z
mereshow
val
netty/netty/6698_6699
netty/netty
netty/netty/6698
netty/netty/6699
[ "timestamp(timedelta=39.0, similarity=0.8742627997936318)" ]
464ae9fb7a1710c63646467fd0ca34c78bd1747a
dd8c47741fb5dfb4f4f287576438a58ac68c8ad6
[ "Fixed by #6699" ]
[ "maybe just merge these two lines ?\r\n\r\n`promise.unvoid().addListener(....)`", "use `HttpHeaderValues.CLOSE`", "use `HttpHeaderValues.CLOSE`", "@normanmaurer the next line is \r\n\r\n`super.write(ctx, msg, promise);`\r\n\r\nso I think newly created promise should be passed there. Am I wrong?", "ah yeah.....
2017-05-03T21:40:45Z
[ "defect" ]
HttpServerKeepAliveHandler throws java.lang.IllegalStateException: void future
### Expected behavior No error when I do `ctx.writeAndFlush(msg, ctx.voidPromise());` where msg is with header "Connection:close". ### Actual behavior HttpServerKeepAliveHandler throws IllegalStateException exception. ### Steps to reproduce Use `ctx.writeAndFlush(msg, ctx.voidPromise());` where msg is `D...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java index c6305a5e2a2..28813332857 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerKeepAliveHandler.java +++ b/...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest.java index bcd64bebad0..1332a2b8a89 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpServerKeepAliveHandlerTest...
train
train
2017-05-03T23:14:39
2017-05-03T20:57:22Z
doom369
val
netty/netty/6709_6713
netty/netty
netty/netty/6709
netty/netty/6713
[ "timestamp(timedelta=28.0, similarity=0.8917066281732946)" ]
0db2901f4db2d3f12b2febe220da113a9e3ed100
015496d5e3cdcde1a7ae8bde281a503eb640f441
[ "@sudheeshkatkam will check... thanks!", "@sudheeshkatkam PTAL https://github.com/netty/netty/pull/6713", "LGTM!", "Fixed by https://github.com/netty/netty/pull/6713" ]
[ "nit: add static import for `SslUtils.getEncryptedPacketLength`", "done..." ]
2017-05-08T03:56:36Z
[ "defect" ]
SslHandler does not work with little endian buffers
### Expected behavior SslHandler to work regardless of LE or BE buffers ### Actual behavior SslHandler uses [SslUtils#getEncryptedPacketLength](https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/ssl/SslUtils.java#L123) which does not work with little endian buffers. Looks like the issu...
[ "handler/src/main/java/io/netty/handler/ssl/SslUtils.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/SslUtils.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslUtilsTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/SslUtils.java b/handler/src/main/java/io/netty/handler/ssl/SslUtils.java index dbb22609eea..bdf65672485 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslUtils.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslUtils.java @@ -17,11 +17,13 @@ impo...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslUtilsTest.java b/handler/src/test/java/io/netty/handler/ssl/SslUtilsTest.java new file mode 100644 index 00000000000..c1de33dd6e3 --- /dev/null +++ b/handler/src/test/java/io/netty/handler/ssl/SslUtilsTest.java @@ -0,0 +1,66 @@ +/* + * Copyright 2017 The Netty ...
train
train
2017-05-11T16:00:55
2017-05-06T00:52:53Z
sudheeshkatkam
val
netty/netty/6717_6719
netty/netty
netty/netty/6717
netty/netty/6719
[ "timestamp(timedelta=8.0, similarity=0.989915987786101)" ]
6a8532acd1451f34bf4f7b93bc7967b6b857238e
d33891140c57b678060c3d0bdfe8d4a5dae7c6d0
[ "@rkapsi sounds good (do it as the RFC). You want to do a PR or should I put it on my back burner ?", "Sounds good, inbound PR shortly", "<3" ]
[ "please also call `ch.finishAndReleaseAll();` if `ch != null`" ]
2017-05-08T18:14:28Z
[]
The value of the SNI extension is ASCII encoded but Netty uses UTF-8
The value of the SNI extension is ASCII encoded but Netty's SNI code tries to decode the `byte[]` as UTF-8. The was flagged by @fenik17 in this https://github.com/netty/netty/pull/6623#discussion_r111070719 https://github.com/netty/netty/blob/4.1/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java#...
[ "handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java b/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java index e75c0554f13..86e7eb25be8 100644 --- a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/AbstractSni...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java index d49bdeaeebe..44cfbe9df93 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SniHandlerTest.java @@ ...
train
train
2017-05-19T19:36:04
2017-05-08T17:57:24Z
rkapsi
val
netty/netty/6736_6748
netty/netty
netty/netty/6736
netty/netty/6748
[ "timestamp(timedelta=3.0, similarity=0.8843457443954279)" ]
4c6d946fbadfb14806f8232b844c5e6a26eff2de
0a97712c94f5f8cdf6bffcf5af51a7f1f5c15385
[ "@trustin can you submit a pr with a fix ?", "Can't promise it at the moment because of busyness... 😢 ", "> The expected behavior of DnsNameResolver is to try somehost and then somehost.linecorp.local.\r\n\r\nThe behavior of modifying the hostname should be provided at a higher layer (e.g. [DnsNameResolverCont...
[ "this seems to be not related to the PR. can you revert ?", "Yes this is not directly related to this change but it makes unit testing more difficult. If I pull this out I would also pull the unit tests out (and submit them together) ... is that preferred from your approach?\r\n\r\nhttps://developer.apple.com/leg...
2017-05-18T00:14:27Z
[ "defect" ]
Incorrect UnixResolverDnsServerAddressStreamProvider
### Minimal yet complete reproducer code (or URL to code) ```java import static org.junit.Assert.assertNotNull; import java.io.File; import java.io.FileOutputStream; import java.io.OutputStream; import java.nio.charset.StandardCharsets; import org.junit.Rule; import org.junit.Test; import org.junit.rules...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java" ]
[ "resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java" ]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java b/resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProvider.java index d12c63749bc..c22f3ae6c4d 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/UnixResolverDnsSer...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/UnixResolverDnsServerAddressStreamProviderTest.java new file mode 100644 index 00000000000..bcb61e78d14 --- /dev/null +++ b/resolver-dns/src/test/java/io/n...
train
train
2017-05-18T20:26:27
2017-05-12T08:36:27Z
trustin
val
netty/netty/6739_6780
netty/netty
netty/netty/6739
netty/netty/6780
[ "timestamp(timedelta=21.0, similarity=0.8848071776930232)" ]
ca9d1658a00fef7be53abeaf499cb78bdc3a5017
cf983846e0d8b39d8a61c6c6449be313e31cecdf
[ "Oh my.... let me see if we can easily fix this 😂\n\n> Am 12.05.2017 um 15:29 schrieb Roger <notifications@github.com>:\n> \n> I don't know if it's worth pursuing but I came yesterday across a network appliance that seemed to perform malformed HTTP based health checks against our Netty application.\n> \n> The HTTP...
[]
2017-05-25T15:42:04Z
[ "defect" ]
Handle missing version in HTTP request line (a.k.a HTTP/0.9)
I don't know if it's worth pursuing but I came yesterday across a network appliance that seemed to perform malformed HTTP based health checks against our Netty application. The HTTP requests looked like this `GET /\r\n` without the version and [HttpVersion line 63](https://github.com/netty/netty/blob/4.1/codec-http/...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpVersion.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpVersion.java" ]
[]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpVersion.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpVersion.java index 806a1b7fdef..352ea848c52 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpVersion.java +++ b/codec-http/src/main/java/io/netty/handler/cod...
null
train
train
2017-05-25T09:28:28
2017-05-12T13:29:14Z
rkapsi
val
netty/netty/6784_6785
netty/netty
netty/netty/6784
netty/netty/6785
[ "timestamp(timedelta=196.0, similarity=0.9871972148863147)" ]
3c4dfed08ae2ce300f6ac1d0794d42a14c344b79
9297bfb0c0767749082c422e9ae3a05ae978d75c
[ "Can you provide a reproducer / testcase?\n\n> Am 26.05.2017 um 18:18 schrieb NSProgrammer <notifications@github.com>:\n> \n> Expected behavior\n> \n> Brotli content passes through with Content-Encoding being untouched\n> \n> Actual behavior\n> \n> Content-Encoding changed to gzip and already encoded content (in br...
[]
2017-05-26T16:20:27Z
[ "defect" ]
Netty force encodes already encoded responses
### Expected behavior Brotli content passes through with Content-Encoding being untouched ### Actual behavior Content-Encoding changed to gzip and already encoded content (in brotli) encoded again with gzip ### Steps to reproduce 1) Encode response with Brotli 2) Set Content-Encoding to "br" ### Nett...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java index 11c61293338..fcf22e011ad 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java +++ b/codec-http/src/...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java index 4946328eba2..94b1aa6cd68 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java +++ b/cod...
test
train
2017-05-26T07:56:34
2017-05-26T16:18:49Z
NSProgrammer
val
netty/netty/6761_6788
netty/netty
netty/netty/6761
netty/netty/6788
[ "timestamp(timedelta=3.0, similarity=0.9662848026936318)" ]
d56a7560ead181f987677c71713b8dc815dab67a
4893bbd01fa28e4fefdd628ce1f6086a96ebbed7
[ "@vietj so you say it is package private and it should be not package-private ? Whats your use-case ?", "my use case is to not send content in a response to HEAD, Vert.x has a special subclass (that you actually created) of `HttpObjectEncoder` that forces the usage of direct buffers, so we cannot use the `HttpSer...
[ "false positive", "`{@code true}`", "I tend to [agree with @jodastephen that `{@code ...}` is overhead for `true`, `false`, and `null`](http://blog.joda.org/2012/11/javadoc-coding-standards.html). 😄", "And I fully acknowledge that this is bike-shedding, sorry so much for that.", "![MAJOR](https://raw.githu...
2017-05-29T12:46:08Z
[ "improvement" ]
HttpObjectEncoder#isContentAlwaysEmpty cannot be overridden by subclasses
### Expected behavior the `HttpObjectEncoder#isContentAlwaysEmpty()` method is package private, so subclasses can change its behavior. Currently Vert.x has a subclass extending `HttpObjectEncoder `. ### Actual behavior the `HttpObjectEncoder#isContentAlwaysEmpty()` method is package private ### Steps to rep...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpServerCodec.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpServerCodec.java" ]
[]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java index 7ef528f365a..878a264ab68 100755 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java +++ b/codec-http/src/main/java/io...
null
val
train
2017-05-27T08:26:14
2017-05-19T15:22:55Z
vietj
val
netty/netty/6791_6793
netty/netty
netty/netty/6791
netty/netty/6793
[ "timestamp(timedelta=23859.0, similarity=0.8847535486130266)" ]
742ee764241b7db536b320d1c572d78e069142c3
ae2ac78ed90d57e63d4a83900bad9c766ee74383
[ "@rkapsi will check", "@rkapsi Please check https://github.com/netty/netty/pull/6793" ]
[]
2017-05-30T19:13:51Z
[ "defect" ]
io.netty.internal.tcnative.* classes bundled with netty-all JAR
I believe none of the `io.netty.internal.tcnative.*` classes is supposed to be bundled with the netty-all JAR but they are... ```bash $ unzip netty-all-4.1.11.Final.jar | grep tcnative creating: io/netty/internal/tcnative/ inflating: io/netty/internal/tcnative/SSL.class inflating: io/netty/internal/tcna...
[ "all/pom.xml" ]
[ "all/pom.xml" ]
[]
diff --git a/all/pom.xml b/all/pom.xml index 47e763f50de..d7b0b124eb0 100644 --- a/all/pom.xml +++ b/all/pom.xml @@ -551,7 +551,7 @@ <goal>unpack-dependencies</goal> </goals> <configuration> - <excludes>io/netty/example/**,META-INF/native/libnetty-tcnative*,META-INF...
null
train
train
2017-05-30T17:53:36
2017-05-30T17:23:14Z
rkapsi
val
netty/netty/6802_6807
netty/netty
netty/netty/6802
netty/netty/6807
[ "timestamp(timedelta=0.0, similarity=0.9428825409266821)" ]
24f801c7d1d1e66193d6ff0da3b93ce427b2b329
f8788a9f6cbad154c505c63be9602f2eb324e0c8
[ "@mousom - ping (for reference see [1])\r\n\r\n@Sammers21 - You can see how PUBLISH is encoded here [2]. Do you think there is an issue with this?\r\n\r\n[1] http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/csprd02/mqtt-v3.1.1-csprd02.html#_Toc385349775\r\n[2] https://github.com/netty/netty/blob/4.1/codec-mqtt/src/main/...
[]
2017-06-02T17:20:15Z
[]
Not specified field in MQTT codec
### Expected behavior According to the [MQTT 3.1.1 spec](http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/csprd02/mqtt-v3.1.1-csprd02.html), the variable header must not have a messageId in the variable header when publishing PUBLISH packet. It must have only these two: Topic Name and Packet Identifier. ### Actual behav...
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttPublishVariableHeader.java" ]
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttPublishVariableHeader.java" ]
[]
diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttPublishVariableHeader.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttPublishVariableHeader.java index 6422d53b901..a0d0481b14c 100644 --- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttPublishVariableHeader.java +++ b/cod...
null
train
train
2017-06-02T16:47:35
2017-06-01T22:32:51Z
Sammers21
val
netty/netty/6808_6809
netty/netty
netty/netty/6808
netty/netty/6809
[ "timestamp(timedelta=25.0, similarity=0.8503605160022504)" ]
f8788a9f6cbad154c505c63be9602f2eb324e0c8
13509878a805401d24f45df90aa7b5702eb4c5c6
[ "This appears to be a very deliberate behavior, but I don't see a reason other than for implementation convenience. I'm happy to take a look at this if you're willing to accept a patch.", "IIUC it was done out of convenience (not required ... chunked should be \"semantically correct\" in either case so no need fo...
[ "in runtime an `assert` block is ignoring if `-ea` option has not specified.", "We don't want this to be an `assert`, right? `assert` statements can be disabled via command line and optimized away by JIT.", "consider just directly casting to the object you expect like the other tests ... a class cast exception ...
2017-06-02T21:04:37Z
[ "improvement" ]
HttpContentCompressor/HttpContentEncoder should reset the content-length header for FullHttpMessages
### Expected behavior When the `HttpContentEncoder` is tasked with compressing a full `HttpMessage` that already contains a `Content-Length` header it should perform the compression and _adjust_ the `Content-Length`. ### Actual behavior All messages compressed result in `Transfer-Encoding: Chunked` and don't have ...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java", "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentEncoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java index 578deb25999..c04d5386819 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java +++ b/codec-http/src/main/java...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java index 94b1aa6cd68..c6ff3bd6bc0 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java +++ b/cod...
train
train
2017-06-05T22:21:49
2017-06-02T19:21:36Z
bryce-anderson
val
netty/netty/6797_6811
netty/netty
netty/netty/6797
netty/netty/6811
[ "timestamp(timedelta=263.0, similarity=0.8796850436353353)" ]
b03b0f22d1e54733c2d39c7f913f971dab14ebfa
ab207aeadba40de1a92ac933b6100b71fe5335e8
[]
[ "nit: `length % 2 != 0` -> `(length & 1) != 0`. you can avoid modulo for a cheaper bit mask operation.", "please change the indexing to the way it was previously. You are adding additional arithmetic on each loop iteration which can be avoided.", "can you include a microbenchmark comparing this method vs `Chara...
2017-06-03T01:12:37Z
[]
QueryStringDecoder and ByteBufUtil decoding hex string duplication
QueryStringDecoder has methods which deal with decoding hex into bytes (e.g. `decodeHexByte`, `decodeHexNibble`) and `ByteBufUtil` has `decodeHexDump`. Can we share code between these two classes?
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java" ]
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "codec-http/src/main/java/io/netty/handler/codec/http/QueryStringDecoder.java" ]
[ "buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java", "codec-http/src/test/java/io/netty/handler/codec/http/QueryStringDecoderTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java index 2dda96bac28..98574503233 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java @@ -125,6 +125,13 @@ public static Stri...
diff --git a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java index e1bf859b2ca..9865ed0109f 100644 --- a/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java +++ b/buffer/src/test/java/io/netty/buffer/ByteBufUtilTest.java @@ -20,6 +20,7 @@ impo...
test
train
2017-06-07T04:30:04
2017-05-31T20:51:59Z
Scottmitch
val
netty/netty/6804_6816
netty/netty
netty/netty/6804
netty/netty/6816
[ "timestamp(timedelta=43.0, similarity=0.8710672718801298)" ]
f8788a9f6cbad154c505c63be9602f2eb324e0c8
251f77aa9f201ed0704f0ed311deaf61454a6e43
[ "@lsqlebai can you please provide a full reproducer ? Also please update to latest netty version just to be sure.", "sorry the netty version is 4.1.6.Final", "@normanmaurer What would you want? my project is so large. maybe i can give u a demo when i free.", "@lsqlebai I want you to upgrade to latest 4.1. ver...
[]
2017-06-05T22:42:07Z
[ "defect" ]
JDKZlibEncoder or JDKZlibDecoder can't work correct with large data
### Expected behavior work ### Actual behavior decode error(protobuf decode error) ### Steps to reproduce i have 2 server. and them communicate with tcp. and the pipeline init code double with them. when the send data > 16000 byte (maybe less). the decode side can't correct decode (protobuf decode error). ###...
[ "codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java", "codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java", "codec/src/main/java/io/netty/handler/codec/compression/JdkZlibDecoder.java" ]
[]
diff --git a/codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java b/codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java index ad2ae299044..5d23bb8bd6f 100644 --- a/codec/src/main/java/io/netty/handler/codec/compression/JZlibDecoder.java +++ b/codec/src/main/java/io/netty/handler...
null
train
train
2017-06-05T22:21:49
2017-06-02T08:40:40Z
lsqlebai
val
netty/netty/6750_6817
netty/netty
netty/netty/6750
netty/netty/6817
[ "timestamp(timedelta=0.0, similarity=0.9233935247334096)" ]
b6c27b9f6befa7a66bf23f9a2aa0c9c943981c6a
97d48c65f80d8d90d4bc1962c6c63771d5e4c05a
[ "are you interested in submitting a PR to correct this issue?", "Fixed by https://github.com/netty/netty/pull/681" ]
[ "Please use the same approach (add a new method) as in https://github.com/netty/netty/pull/6769 and avoid breaking the public API.", "can we remove `minBytes` and `maxBytes` parameters? `maxBytes` is always `MAX_VALUE` and `minBytes` is always `0`. can we instead just throw an exception (or return early) if `size...
2017-06-06T00:53:23Z
[]
codec.mqtt: wrong password and willMessage field types in MqttConnectPayload/MqttEncoder (should be byte[])
In the present implementation of MqttConnectPayload/MqttEncoder, willMessage and password fields are strings. However, spec (3.1.3.5) clearly mandates that the password filed should support arbitrary binary data: > The Password field contains 0 to 65535 bytes of binary data prefixed with a two byte length field whi...
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectPayload.java", "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java", "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttEncoder.java", "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageBuilders.java" ]
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectPayload.java", "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java", "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttEncoder.java", "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttMessageBuilders.java" ]
[ "codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java" ]
diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectPayload.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectPayload.java index 1e16acf4430..e274e3f29e6 100644 --- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttConnectPayload.java +++ b/codec-mqtt/src/main/java...
diff --git a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java b/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java index 8bfd2fb95db..21a69055ed5 100644 --- a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java +++ b/codec-mqtt/src/test/java/io/netty/handl...
train
train
2017-06-09T20:34:28
2017-05-18T04:14:03Z
oakad
val
netty/netty/6849_6851
netty/netty
netty/netty/6849
netty/netty/6851
[ "timestamp(timedelta=13.0, similarity=0.8658447283010114)" ]
3f0085c267b5f59a7ca70729e14a18f13581dac2
f5de662f71ebc2bf6af19b659a1a0f8a32a04931
[ "And now I've noticed that the module name's incorrect. I believe it should be `netty-transport-native-unix-common`. Sorry, if that's the case, I should have spotted it when reviewing https://github.com/netty/netty/pull/6740.", "Fixed by https://github.com/netty/netty/pull/6851" ]
[]
2017-06-13T08:58:06Z
[ "defect" ]
4.1.12.Final bom uses 4.1.12.Final-SNAPSHOT for the version of netty-transport-unix-common
### Expected behavior The bom provides consistent versions for all of Netty's modules ### Actual behavior netty-transport-unix-common is using a different (and snapshot) version ### Steps to reproduce Import the bom and try to resolve netty-transport-unix-common from Maven Central ### Minimal yet comp...
[ "bom/pom.xml" ]
[ "bom/pom.xml" ]
[]
diff --git a/bom/pom.xml b/bom/pom.xml index a0425e225ea..ed7bffe0579 100644 --- a/bom/pom.xml +++ b/bom/pom.xml @@ -188,8 +188,8 @@ </dependency> <dependency> <groupId>io.netty</groupId> - <artifactId>netty-transport-unix-common</artifactId> - <version>4.1.12.Final-SNAPSHOT</versio...
null
train
train
2017-06-13T07:43:29
2017-06-13T07:59:22Z
wilkinsona
val
netty/netty/6846_6857
netty/netty
netty/netty/6846
netty/netty/6857
[ "timestamp(timedelta=32.0, similarity=0.9015057496224571)" ]
e597756a56398a73f851f97ac667f3ae198f4545
33b7478b5c157f246708ced77bb2e28c89715ef1
[ "thanks for reporting @normanmaurer! My guess is this will have a measurable impact if the initial size is too small (currently defaults to 32). We reset to the initial array size on each decode operation.", "@Scottmitch agree... I would say we should double up to 512 bytes . WDYT ? I can do a pr", "It will dep...
[ "nit: consider using tertiary for less boiler plate:\r\n\r\n```java\r\nfinal int newLength = bytes.length >= 1024 ? bytes.length + initialCapacity : bytes.length << 1;\r\n```", "Consider leaving a comment as to how this value was derived (educated guess, average header length from source X, etc..)", "sure why n...
2017-06-14T10:51:29Z
[ "improvement" ]
Reconsider growing strategy in HpackHuffmanDecoder
At the moment we just increase my intialCapacity but it may make sense to double it up to a certain size: https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanDecoder.java#L237
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanDecoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanDecoder.java" ]
[]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanDecoder.java index 307d11a7d53..b49c30d69b5 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackHuffmanDecoder.java +++ b/codec-http2/src...
null
val
train
2017-06-15T06:29:14
2017-06-12T18:01:04Z
normanmaurer
val
netty/netty/6909_6910
netty/netty
netty/netty/6909
netty/netty/6910
[ "timestamp(timedelta=16.0, similarity=0.8987650822178376)" ]
dd69a813d46c2db2b8071445ecddb4bf939ba2e9
faa7b9e82b07be9b8fb1138d6241396c28d7d792
[ "yep but it's public so it cannot be changed until the next major version.", "It can not be changed but we can add a new method and deprecate the old one... let me do in a few minutes ", "Fixed by https://github.com/netty/netty/pull/6910. Please check", "Fixed by https://github.com/netty/netty/pull/6910" ]
[]
2017-06-27T17:09:09Z
[]
Typo? EpollSocketChannelConfig.setTcpKeepCntl
https://github.com/netty/netty/blob/3cc405296310643bccddc8c81998c97f25b3201c/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelConfig.java#L420 shouldn't it be called setTcpKeepCnt?
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelConfig.java" ]
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelConfig.java" ]
[]
diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelConfig.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelConfig.java index 4ac335619b8..eaf2523b980 100644 --- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollSocketChannelCon...
null
train
train
2017-06-27T10:53:43
2017-06-27T16:25:06Z
testn
val
netty/netty/6951_6978
netty/netty
netty/netty/6951
netty/netty/6978
[ "timestamp(timedelta=172310.0, similarity=0.8482712342758469)" ]
3e9f617504adb6f3ac984a9320020dd2c202739e
decbbac593edfc3c33c0636181ed996e90f07309
[ "We should check the ref count before writing to the underlying storage. Typically the write/set methods use [checIndex](https://github.com/netty/netty/blob/4.1/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java#L1346) to accomplish this. I'm AFK but can look in more detail later.", "That's a bug... lookin...
[ "this feels backwards, isn't it usually the public method eg. mymethod invoking the private mymethod0?", "@johnou an `ensureAccessible()` method is protected, not is public.", "I was looking at `public int ensureWritable(int minWritableBytes, boolean force)` but it even with the modifier as protected it still f...
2017-07-17T13:46:07Z
[ "defect" ]
Writing to released ByteBuf
What is the concept of checking the possibility of accessing to `ByteBuf`? Probably a bug. A `writeCharSequence` (`setCharSequence`) can allow writing to released buffer: ```java ByteBuf buf = Unpooled.directBuffer(16); buf.release(); buf.writeCharSequence("1", CharsetUtil.US_ASCII); // <-- no except...
[ "buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java", "buffer/src/main/java/io/netty/buffer/AbstractUnsafeSwappedByteBuf.java", "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java", "buffer/src/main/java/io/netty/buffer/PooledU...
[ "buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java", "buffer/src/main/java/io/netty/buffer/AbstractUnsafeSwappedByteBuf.java", "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "buffer/src/main/java/io/netty/buffer/PooledUnsafeDirectByteBuf.java", "buffer/src/main/java/io/netty/buffer/PooledU...
[ "buffer/src/test/java/io/netty/buffer/SlicedByteBufTest.java", "buffer/src/test/java/io/netty/buffer/WrappedUnpooledUnsafeByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java index a4efb2b97ac..87a512741da 100644 --- a/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/AbstractByteBuf.java @@ -266,7 +266,8 @@ pub...
diff --git a/buffer/src/test/java/io/netty/buffer/SlicedByteBufTest.java b/buffer/src/test/java/io/netty/buffer/SlicedByteBufTest.java index 641d3426469..410f21aad3d 100644 --- a/buffer/src/test/java/io/netty/buffer/SlicedByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/SlicedByteBufTest.java @@ -94,18 +94,6...
train
train
2017-07-18T13:25:12
2017-07-06T20:49:31Z
fenik17
val
netty/netty/6968_6982
netty/netty
netty/netty/6968
netty/netty/6982
[ "timestamp(timedelta=55439.0, similarity=0.8439824231223864)" ]
e6a399a7785b41dc941e8037257a30a0df1d92d4
06e16a2c85800492fbc1f1211a0f9a5e37d0c163
[ "@nayato can you submit a pr with something that you think makes things more clear ?", "@nayato - please check if https://github.com/netty/netty/pull/6982 is what you had in mind.", "@nayato does https://github.com/netty/netty/pull/6987 work for you ?", "Fixed by https://github.com/netty/netty/pull/6987" ]
[]
2017-07-18T07:05:35Z
[ "defect", "improvement" ]
TlsReadTest tests are misleading
Tests rely on channel having AutoRead = false and verify that read was issued through setting readIssued. In reality read method is called during construction of EmbeddedChannel - because AutoRead is true at this time, before AutoRead is set to false in test.
[ "transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java" ]
[ "transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java" ]
diff --git a/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java b/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java index 2dcb577deb7..58302c60bbb 100644 --- a/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java +++ b/transport/src/main/java/io/netty/channel/e...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java index 84559a76407..d67986abfca 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java @@ ...
test
train
2017-07-18T07:24:04
2017-07-13T22:02:25Z
nayato
val
netty/netty/6984_6985
netty/netty
netty/netty/6984
netty/netty/6985
[ "timestamp(timedelta=5.0, similarity=1.0)" ]
0ad99310f5c02363f9402872d9b3d803654a794d
3952673f170478a1d9f04d5d50cb76a94b134e09
[ "Fixed by https://github.com/netty/netty/pull/6985" ]
[]
2017-07-18T10:30:33Z
[ "defect" ]
MQTT unknown message type isn't handled as decoding error
### Expected behavior When there is an MQTT decoding error, an invalidMessage is created and a DecodeResult with failure and related cause exception is filled with right information so that the user application can see what's the problem. It should happens in any step in the decoding phase. ### Actual behavior ...
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java" ]
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java" ]
[ "codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java" ]
diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java index c8a3546e0ed..8d94ee48e96 100644 --- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java +++ b/codec-mqtt/src/main/java/io/netty/handler/cod...
diff --git a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java b/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java index 21a69055ed5..dd6c74269fa 100644 --- a/codec-mqtt/src/test/java/io/netty/handler/codec/mqtt/MqttCodecTest.java +++ b/codec-mqtt/src/test/java/io/netty/handl...
train
train
2017-07-18T09:28:56
2017-07-18T10:26:33Z
ppatierno
val
netty/netty/5478_6991
netty/netty
netty/netty/5478
netty/netty/6991
[ "timestamp(timedelta=1125.0, similarity=0.8645560119075416)" ]
0afe4e09643c457c452ef0d9563c46f8e7c24ad1
bb22bd8e7a8db6a7139dff4893fd9015b0796c71
[ "Can you provide a PR with the test and a fix?\n\n> Am 30.06.2016 um 16:49 schrieb Benjamin Fiorini notifications@github.com:\n> \n> Hello,\n> \n> There is a bug in the nextChunk() algorithm of the HttpPostRequestEncoder. When chunking a big request or multipart data, if the size of the resulting query is a multipl...
[ "call `httpContent.release()`", "call httpContent.release()", "static", "done", "done", "done" ]
2017-07-19T07:53:36Z
[ "defect" ]
NullPointerException in HttpPostRequestEncoder
Hello, There is a bug in the `nextChunk()` algorithm of the `HttpPostRequestEncoder`. When chunking a big request or multipart data, if the size of the resulting query is a multiple of the chunk size, `isLastChunkSent` is not set to `true` at the end, resulting in a NullPointerException. This bug is present in versio...
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.java index 57f81f5b66b..a56431e2226 100755 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostRequestE...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestEncoderTest.java index 3a206f44ba7..2d821273fa8 100755 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
train
train
2017-07-19T07:59:56
2016-06-30T14:49:50Z
bfiorini
val
netty/netty/6993_6994
netty/netty
netty/netty/6993
netty/netty/6994
[ "timestamp(timedelta=225.0, similarity=0.9252722530631794)" ]
a91df58ca17d5b30c57c46dde5b1d60bb659b029
85da3a22b7d30bc63ea3528dfc4d4243f33e6ad9
[ "@Scottmitch please remember to set the milestone when you close issues so it is listed for the correct version." ]
[ "Please address the TODO ", "Or just remove the fprintf for now", "Please revert these changes as it seems this just moves code and so is not related", "IIUC the static methods have to move up to avoid their first use case or we need to declare the method before the first use.", "IIUC this method doesn't ha...
2017-07-19T20:20:09Z
[ "defect", "improvement" ]
Netty Epoll fails in IPv6 only environment
https://github.com/netty/netty/blob/83de77fbe5385130ba9afc666fecbe9b59bd8032/transport-native-unix-common/src/main/c/netty_unix_socket.c#L198 In this code, it tries to set dual stack sockets, but fails when running in an IPv6 only environment. Such an environment exists in Google by blocking all IPv4 functionality ...
[ "transport-native-unix-common/src/main/c/netty_unix_socket.c" ]
[ "transport-native-unix-common/src/main/c/netty_unix_socket.c" ]
[]
diff --git a/transport-native-unix-common/src/main/c/netty_unix_socket.c b/transport-native-unix-common/src/main/c/netty_unix_socket.c index 2cfb5e4d7d5..519f701c839 100644 --- a/transport-native-unix-common/src/main/c/netty_unix_socket.c +++ b/transport-native-unix-common/src/main/c/netty_unix_socket.c @@ -188,17 +188...
null
val
train
2017-07-19T22:37:23
2017-07-19T20:19:28Z
carl-mastrangelo
val
netty/netty/6998_6999
netty/netty
netty/netty/6998
netty/netty/6999
[ "timestamp(timedelta=18.0, similarity=0.8677490189405712)" ]
f23b2fc25d05134ce9a3811043df274ee4685720
fbd0b3f3ca3b8f80335a881782e73602bfd2b6a9
[ "@MartyIX yes... Can you please open a PR with a fix ?", "Yes, https://github.com/netty/netty/pull/6999", "Fixes by https://github.com/netty/netty/pull/6999 . @MartyIX thanks" ]
[ "![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Replace this usage of System.out or System.err by a logger. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://garage.netty.io/sonarqube/coding_rules#rule_ke...
2017-07-20T10:16:58Z
[ "defect" ]
Websocket example and WebSocketHandshakeException
Hi, Websocket example contains the following code: if (!handshaker.isHandshakeComplete()) { handshaker.finishHandshake(ch, (FullHttpResponse) msg); System.out.println("WebSocket Client connected!"); handshakeFuture.setSuccess(); return; } (ht...
[ "example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHandler.java" ]
[ "example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHandler.java" ]
[]
diff --git a/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHandler.java b/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHandler.java index c36283cd8ef..fb10576e2e4 100644 --- a/example/src/main/java/io/netty/example/http/websocketx/client/WebSocketClientHand...
null
test
train
2017-07-20T10:24:18
2017-07-20T08:58:14Z
MartyIX
val
netty/netty/7012_7013
netty/netty
netty/netty/7012
netty/netty/7013
[ "timestamp(timedelta=9.0, similarity=0.9377339943090868)" ]
452fd3624081553ed0d2b9b6f59c21789a274f69
b29f0a1023f4829c5899ed667c1424534c8f9b0a
[]
[]
2017-07-23T14:22:29Z
[]
small Default max message size in MqttDecoder
### Expected behavior According to [MQTT 3.1.1 spec, section 2.2.3](http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/csprd02/mqtt-v3.1.1-csprd02.html#_Toc385349759), MQTT packets size can take up to 268 435 455 bytes. I think this value should be a default. ### Actual behavior The current default value of MQTT packet ...
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java" ]
[ "codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java" ]
[]
diff --git a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java b/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java index 8d94ee48e96..6789722a895 100644 --- a/codec-mqtt/src/main/java/io/netty/handler/codec/mqtt/MqttDecoder.java +++ b/codec-mqtt/src/main/java/io/netty/handler/cod...
null
train
train
2017-07-22T17:44:48
2017-07-23T14:19:12Z
Sammers21
val
netty/netty/7025_7026
netty/netty
netty/netty/7025
netty/netty/7026
[ "timestamp(timedelta=6.0, similarity=0.9000798950654655)" ]
efb2d141c1de9ef19443bb04678ef753894fcbe2
94b0b92f8d1f9a7214e12ac94458e7738ca25da8
[ "Check enable or not logger before encode already was introduced in #3492 but then lost in #6877", "Will fix ...", "@normanmaurer sorry, I already prepare PR #7026", "Ha! Even better\n\n> Am 26.07.2017 um 15:02 schrieb Vladimir Gordiychuk <notifications@github.com>:\n> \n> @normanmaurer sorry, I already prepa...
[ "The log level will be enforced by the logger. We should only have to \"double check\" the log level if creation of one of the arguments may potentially be expensive. We should only need this double check on methods with a `toString(..)` as a parameter.\r\n\r\nAlternatively we could isolate the check in `toString`:...
2017-07-26T13:01:48Z
[ "defect" ]
Http2FrameLogger to many char[] allocation when logger disabled
### Expected behavior No char[] allocation when logger disabled ### Actual behavior The logger always performing a hex dump of the ByteBufs regarless whether or not the log would take place. I faced with huge allocation during run grpc benchmarks ![screenshot from 2017-07-26 15 40 17](https://user-images.githubus...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java" ]
[]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java index 5a29d7f4616..f0297f9b1e9 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameLogger.java +++ b/codec-http2/src/main/jav...
null
train
train
2017-07-25T16:18:52
2017-07-26T12:48:18Z
Gordiychuk
val
netty/netty/3756_7058
netty/netty
netty/netty/3756
netty/netty/7058
[ "timestamp(timedelta=48.0, similarity=0.9515524125474241)" ]
348745608faae89c33d5dbae40be8e81b239177d
9408a6c203d5afa2512dfd839b8a1d2f6bb6e9f6
[ "Fixed by https://github.com/netty/netty/pull/7058" ]
[ "is this change necessary?", "would it make sense to move the OS X platform detection to `PlatformDependent`?", "yes as we use it in ´NativeLibraryLoader´", "sure we can do but as there were no other places where this is used I did not bother. ", "It looks like you removed all usages in this PR, or am I mis...
2017-08-06T14:07:25Z
[ "cleanup" ]
Duplicate code in NativeLibraryLoader
`NativeLibraryLoader` has some functions which are similar to `PlatformDependent`'s. For example, - tmpdir() - toDirectory() - isWindow() I wonder if these can be replaced with functions of `PlatformDependent`. WDYT?
[ "common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java", "common/src/main/java/io/netty/util/internal/PlatformDependent.java" ]
[ "common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java", "common/src/main/java/io/netty/util/internal/PlatformDependent.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java b/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java index da8054a560c..729373506a6 100644 --- a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java +++ b/common/src/main/java/io/netty/util/internal/Nati...
null
test
train
2017-08-08T07:47:18
2015-05-07T09:37:46Z
jlim262
val
netty/netty/6576_7099
netty/netty
netty/netty/6576
netty/netty/7099
[ "timestamp(timedelta=16.0, similarity=0.904038667647538)" ]
505993a2fb6016c58d0f95392d7317a6d80f2ac7
d543509085bd1d2132919bb0ca225177a2ff5b1f
[ "Probably not a good idea to add these methods to 4.1 but we could in 4.2+", "@trustin I guess we still could as `ByteBuf` is an abstract class and just implement them directly there. We then could implement these in an optimized way in the sub-classes. WDYT ?", "Sounds good to me as long as we put some noticea...
[]
2017-08-12T19:44:42Z
[ "feature" ]
ByteBuf does not have access methods for little endian floats and doubles
### Expected behavior `ByteBuf` has `get/read/set/writeFloatLE()` and `get/read/set/writeDoubleLE()`. ### Actual behavior `ByteBuf` does not have the little endian variant of float/double access methods. ### Netty version 4.0.x and 4.1.x
[ "buffer/src/main/java/io/netty/buffer/ByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/ByteBuf.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/ByteBuf.java b/buffer/src/main/java/io/netty/buffer/ByteBuf.java index 607a4b13acc..753c67a97a4 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBuf.java @@ -757,6 +757,20 @@ public abstract class ByteBuf impl...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java index ef2cd3c08d0..e4a117a2063 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java @@ -786...
train
train
2017-08-12T20:19:12
2017-03-28T08:17:29Z
trustin
val
netty/netty/6127_7099
netty/netty
netty/netty/6127
netty/netty/7099
[ "timestamp(timedelta=6056.0, similarity=0.8735487342040955)" ]
505993a2fb6016c58d0f95392d7317a6d80f2ac7
d543509085bd1d2132919bb0ca225177a2ff5b1f
[ "Although this wouldn't be consistent with `readDouble` and `readFloat` (which are abstract and implemented in `AbstractByteBuf`) we could add these methods and default implementations to `ByteBuf` ... @normanmaurer WDYT?", "@Scottmitch yeah... not sure about it... Let me think about it :)", "This was fixed by ...
[]
2017-08-12T19:44:42Z
[]
Add readDoubleLE and readFloatLE methods to ByteBuf
ByteBuf.order methods are deprecated now and getShortLE, getIntLE .. methods should be used instead. But such important methods like `readDoubleLE` and `readFloatLE` are not implemented. ### Netty version Netty 4.1.6
[ "buffer/src/main/java/io/netty/buffer/ByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/ByteBuf.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/ByteBuf.java b/buffer/src/main/java/io/netty/buffer/ByteBuf.java index 607a4b13acc..753c67a97a4 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBuf.java @@ -757,6 +757,20 @@ public abstract class ByteBuf impl...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java index ef2cd3c08d0..e4a117a2063 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/AbstractByteBufTest.java @@ -786...
train
train
2017-08-12T20:19:12
2016-12-12T10:39:37Z
mrniko
val
netty/netty/6933_7126
netty/netty
netty/netty/6933
netty/netty/7126
[ "timestamp(timedelta=677.0, similarity=0.9227435941944693)" ]
c93e58c453147ab5b34a708a85530d2372bbac81
d5b78a09004f35d8732a0ce1d1e33a2e8cad41df
[ "I forgot the most obvious solution, which is to create a `java.lang.reflect.Proxy` from a simple `InvocationHandler` that delegates to `ProtocolSelector#select`. This is much simpler than defining a class directly from an ASM-produced `byte[]`, but I don't know what the performance implications are.", "@rschmitt...
[ "Do we care about double spaces? ", "And server mode? Throw unsupported operation exception? ", "Does this need to be invoked every setHandshakeSuccess? ", "Yes need to fix", "This way I not need any checks in SslHandler....", "I guess it would be better to only call it once... let me fix", "actually th...
2017-08-18T11:53:53Z
[ "feature" ]
Netty 4.1 should support ALPN on JDK9
This is obviously a known issue, but it's worth tracking. It may also be tricky to pull this off while compiling against JDK6; in particular, invoking `SSLEngine#setHandshakeApplicationProtocolSelector` requires passing a `BiFunction` implementation. I see a few ways of accomplishing this, assuming that calling this me...
[ "handler/src/main/java/io/netty/handler/ssl/JdkAlpnApplicationProtocolNegotiator.java", "handler/src/main/java/io/netty/handler/ssl/JdkBaseApplicationProtocolNegotiator.java", "handler/src/main/java/io/netty/handler/ssl/JdkSslEngine.java", "handler/src/main/java/io/netty/handler/ssl/JdkSslSession.java", "ha...
[ "handler/src/main/java/io/netty/handler/ssl/Java9SslEngine.java", "handler/src/main/java/io/netty/handler/ssl/Java9SslUtils.java", "handler/src/main/java/io/netty/handler/ssl/JdkAlpnApplicationProtocolNegotiator.java", "handler/src/main/java/io/netty/handler/ssl/JdkBaseApplicationProtocolNegotiator.java", "...
[ "handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/Java9SslEngine.java b/handler/src/main/java/io/netty/handler/ssl/Java9SslEngine.java new file mode 100644 index 00000000000..6534f39b503 --- /dev/null +++ b/handler/src/main/java/io/netty/handler/ssl/Java9SslEngine.java @@ -0,0 +1,175 @@ +/* + * Copyright 2017 The...
diff --git a/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java b/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java index c1205130fc5..110871b3603 100644 --- a/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/JdkSslEngineTest....
train
train
2017-08-24T07:40:47
2017-07-02T05:27:58Z
rschmitt
val
netty/netty/7156_7157
netty/netty
netty/netty/7156
netty/netty/7157
[ "timestamp(timedelta=22.0, similarity=0.9158764485680886)" ]
d9d0e633dc69b9b93139d822eaa17b97ff3826ab
5a93ae4c2afedcb5aca9d172c17df485616f4498
[ "@axtavt please check https://github.com/netty/netty/pull/7157", "Fixed by https://github.com/netty/netty/pull/7157" ]
[]
2017-08-28T09:00:28Z
[ "defect" ]
DefaultSocks5CommandRequest incorrectly rejects SOCKS5 commands with dstPort=0
### Expected behavior According to [SOCKS 5 spec](https://www.ietf.org/rfc/rfc1928.txt), dstPort = 0 is a valid value in case of UDP ASSOCIATE command: > If the client is not in possesion of the information at the time of the UDP ASSOCIATE, the client MUST use a port number and address of all zeros. ### Actual b...
[ "codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/DefaultSocks5CommandRequest.java" ]
[ "codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/DefaultSocks5CommandRequest.java" ]
[ "codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/DefaultSocks5CommandRequestTest.java" ]
diff --git a/codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/DefaultSocks5CommandRequest.java b/codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/DefaultSocks5CommandRequest.java index d90150ebc24..ddd35fd6250 100755 --- a/codec-socks/src/main/java/io/netty/handler/codec/socksx/v5/DefaultSocks5Comma...
diff --git a/codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/DefaultSocks5CommandRequestTest.java b/codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/DefaultSocks5CommandRequestTest.java index e4dc2dade7a..3b3b5db5281 100755 --- a/codec-socks/src/test/java/io/netty/handler/codec/socksx/v5/DefaultSoc...
train
train
2017-08-28T20:21:57
2017-08-27T18:44:23Z
axtavt
val
netty/netty/7083_7160
netty/netty
netty/netty/7083
netty/netty/7160
[ "timestamp(timedelta=11.0, similarity=0.8930761190728315)" ]
d9d0e633dc69b9b93139d822eaa17b97ff3826ab
4e9348da823491a9a8e299e8cf7d4ecad3cb6d28
[ "@amizurov maybe you want to submit a PR and just make it configurable via a constructor argument (and using the current behaviour by default) ?", "@normanmaurer Ok, with great pleasure.", "Fixed by https://github.com/netty/netty/pull/7160" ]
[ "For splitting with one-char String better use `String#split` instead of `Pattern`, [there is an optimization for this](http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/lang/String.java#l2316).", "@fenik17 Thanks, I agree it is better approach for this case.", "nit: you can remo...
2017-08-28T21:01:33Z
[]
StompSubframeDecoder.redHeaders no any notification when parsed line that contains multiple colon
### Expected behavior By STOMP 1.2 specification - header name or value include any octet except CR or LF or ":". I understand that we can not just change the current behavior because of compatibility, but maybe we can add some kind of error notification ? ### Actual behavior We can built stomp frame that cont...
[ "codec-stomp/src/main/java/io/netty/handler/codec/stomp/StompSubframeDecoder.java" ]
[ "codec-stomp/src/main/java/io/netty/handler/codec/stomp/StompSubframeDecoder.java" ]
[ "codec-stomp/src/test/java/io/netty/handler/codec/stomp/StompSubframeDecoderTest.java", "codec-stomp/src/test/java/io/netty/handler/codec/stomp/StompTestConstants.java" ]
diff --git a/codec-stomp/src/main/java/io/netty/handler/codec/stomp/StompSubframeDecoder.java b/codec-stomp/src/main/java/io/netty/handler/codec/stomp/StompSubframeDecoder.java index e25c15447ac..3ce55f21cbe 100644 --- a/codec-stomp/src/main/java/io/netty/handler/codec/stomp/StompSubframeDecoder.java +++ b/codec-stomp/...
diff --git a/codec-stomp/src/test/java/io/netty/handler/codec/stomp/StompSubframeDecoderTest.java b/codec-stomp/src/test/java/io/netty/handler/codec/stomp/StompSubframeDecoderTest.java index 5b9b97e32c8..fe772126a55 100644 --- a/codec-stomp/src/test/java/io/netty/handler/codec/stomp/StompSubframeDecoderTest.java +++ b/...
train
train
2017-08-28T20:21:57
2017-08-10T15:21:17Z
amizurov
val
netty/netty/7178_7180
netty/netty
netty/netty/7178
netty/netty/7180
[ "timestamp(timedelta=16.0, similarity=0.852711418881674)" ]
5c572f0f63da22392d477697c4c289072915d483
71a474a1082f43366416929c1df813d731eac441
[ "The stracktrace of the exception when running modified `Http2MultiplexCodecBuilderTest`.\r\n```\r\n15:49:13.120 [defaultEventLoop-1-1] WARN io.netty.channel.ChannelInitializer - Failed to initialize a channel. Closing: [id: 0x70bc891d, L:local:E:e07decb9 - R:local:io.netty.handler.codec.http2.http2multiplexcodecb...
[]
2017-09-05T17:37:26Z
[ "defect" ]
The ChannelHandler which is used to construct Http2MultiplexCodecBuilder will also be added to out bound streams
### Expected behavior The `ChannelHandler` which is used to construct `Http2MultiplexCodecBuilder` should only be added to remotely-created streams. ### Actual behavior It is also added to out bound streams. ### Steps to reproduce Modify `Http2MultiplexCodecBuilderTest`, replace the code in `setUp` ``` ...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java index 7cb3ec0c70e..db513d3dae8 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java +++ b/codec-http2/src...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilderTest.java index 383d17104c9..f798b021f70 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuild...
train
train
2017-09-04T20:20:04
2017-09-05T07:53:55Z
Apache9
val
netty/netty/7082_7181
netty/netty
netty/netty/7082
netty/netty/7181
[ "timestamp(timedelta=33555.0, similarity=0.883115206972504)" ]
de9e666493469d40fa9107a78f9ae421a05f9cf4
bdc899fab4d0ae22db35cb4da6d5b86e06c95fd6
[ "This is \"fixed\" by https://github.com/netty/netty/pull/7181 ... To make it short no it makes no sense.", "Fixed by #7181 ", "@normanmaurer - Can you explain why the policy suggested here \"makes no sense\"? The policy implemented in #7181 seems incomplete and may incorrectly report writability in a few cases...
[ "false positive ?", "I'm not seeing a `setStreamAndProperty()` for client-created streams... Should it be part of `Http2FrameCodec.writeHeadersFrame()`?\r\n\r\nIf `s == null` then the stream must be client-side, since newStream() on server-side is initialized immediately. Since the headers frame/first frame issue...
2017-09-06T07:09:52Z
[]
h2childchan: DefaultHttp2StreamChannel initial writability
Currently the initial writability of `DefaultHttp2StreamChannel` is false if we have not yet created the underlying `Http2Stream` object. Typically a channel is default writability is true, unless conditions otherwise prohibit this. In the case of `DefaultHttp2StreamChannel` we should investigate if the following polic...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilderTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java index b1bcdd213a0..a0685899632 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2FrameCodec.java +++ b/codec-http2/src/main/java/i...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuilderTest.java index f798b021f70..c394689fb6b 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecBuild...
train
train
2017-09-08T10:38:16
2017-08-10T15:01:47Z
Scottmitch
val
netty/netty/7199_7200
netty/netty
netty/netty/7199
netty/netty/7200
[ "timestamp(timedelta=16585.0, similarity=0.9814131261476915)" ]
de9e666493469d40fa9107a78f9ae421a05f9cf4
249aa1238d72474b77642d432b7fc20595265009
[ "I don't believe Google is using it. No concerns here.", "Sounds fine to me. Searching around it seems like there may be some small projects using it on the Raspberry Pi or to talk to a wireless modem. They probably wouldn't be served fine using RXTX directly (says the person who hasn't looked at RXTX at all).",...
[ "Compiler in IntelliJ IDEA still is not allow `@Deprecated` in package-info's:\r\n> Error:(23, 1) java: modifier deprecated not allowed here", "Fixed it... ff592c8d5c54d6a81b17050f980c5d57299a5148" ]
2017-09-10T07:07:09Z
[ "discussion" ]
Mark transport-rxtx as `@deprecated`
https://github.com/netty/netty/pull/7198 just reminded me that I wanted to bring up the topic of mark transport-rxtx as `@deprecated` for some time. This is mainly driven because I think there is really no-one that maintain this one and there is no easy way for us to even test it. I think we should better concentra...
[ "transport-rxtx/src/main/java/io/netty/channel/rxtx/DefaultRxtxChannelConfig.java", "transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannel.java", "transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannelConfig.java", "transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannelOption.java", ...
[ "transport-rxtx/src/main/java/io/netty/channel/rxtx/DefaultRxtxChannelConfig.java", "transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannel.java", "transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannelConfig.java", "transport-rxtx/src/main/java/io/netty/channel/rxtx/RxtxChannelOption.java", ...
[]
diff --git a/transport-rxtx/src/main/java/io/netty/channel/rxtx/DefaultRxtxChannelConfig.java b/transport-rxtx/src/main/java/io/netty/channel/rxtx/DefaultRxtxChannelConfig.java index 0fbf37e5140..c5a15e36ff7 100644 --- a/transport-rxtx/src/main/java/io/netty/channel/rxtx/DefaultRxtxChannelConfig.java +++ b/transport-rx...
null
train
train
2017-09-08T10:38:16
2017-09-08T21:58:32Z
normanmaurer
val
netty/netty/7214_7215
netty/netty
netty/netty/7214
netty/netty/7215
[ "timestamp(timedelta=273.0, similarity=0.8671342247371197)" ]
14189140a0e07ab1cac8b91b49a787143870890e
1aacc1fc2ddbcdc807a7416757fea870eb9d5069
[ "Fixed " ]
[ "so created is more correct then ok ?", "@normanmaurer \r\nhttps://tools.ietf.org/html/rfc7540#section-8.2.1, \r\nThe PUSH_PROMISE frame contains a header block that contains a complete set of request header fields that the server attributes to the request.\r\nIn fact, the first time I used OK as the Http respons...
2017-09-15T08:51:09Z
[ "defect" ]
NPE in InboundHttp2ToHttpAdapter When a HTTP/2 PUSH_PROMISE comes in
### Expected behavior No null pointer exceptions ### Actual behavior When a HTTP/2 PUSH_PROMISE comes in, we call **onPushPromiseRead** in InboundHttp2ToHttpAdapter. This makes us create a FullHttpMessage, which eventually calls "HttpConversionUtil.parseStatus", which occurs always NPE because status is null. ...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapter.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapter.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapter.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapter.java index 0c8ba812c62..8ab511ea42e 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapter.java +++...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java index 33393afc0a3..07fa916cbc3 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterT...
train
train
2017-09-14T23:51:20
2017-09-15T08:28:07Z
durigon
val
netty/netty/7222_7228
netty/netty
netty/netty/7222
netty/netty/7228
[ "timestamp(timedelta=13.0, similarity=0.9515025860879004)" ]
9d56439aa1c221d38ee3b526c63d268c2e6f16c7
7418ac1205be4205c7461b3ace0a6507d6d22ef4
[ "@vietj please check https://github.com/netty/netty/pull/7228", "Fixed by https://github.com/netty/netty/pull/7228", "awesome!" ]
[]
2017-09-19T04:33:52Z
[ "improvement" ]
NativeLibraryLoader should check the result of ClassLoader#getResource method
### Expected behavior `NativeLibraryLoader` uses `ClassLoader#getResource` method that can return nulls when the resource cannot be found. The returned `url` variable should be checked for nullity and fail in a more usable manner than a `NullPointerException` ### Actual behavior `NativeLibraryLoader` fails wi...
[ "common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java" ]
[ "common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java" ]
[ "common/src/test/java/io/netty/util/internal/NativeLibraryLoaderTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java b/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java index dc3e359a78b..a1ea75fc2f1 100644 --- a/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java +++ b/common/src/main/java/io/netty/util/internal/Nati...
diff --git a/common/src/test/java/io/netty/util/internal/NativeLibraryLoaderTest.java b/common/src/test/java/io/netty/util/internal/NativeLibraryLoaderTest.java new file mode 100644 index 00000000000..151e3fc5bc6 --- /dev/null +++ b/common/src/test/java/io/netty/util/internal/NativeLibraryLoaderTest.java @@ -0,0 +1,37 ...
test
train
2017-09-19T06:42:46
2017-09-18T08:42:42Z
vietj
val
netty/netty/7253_7261
netty/netty
netty/netty/7253
netty/netty/7261
[ "timestamp(timedelta=152.0, similarity=0.8985595275090416)" ]
47f016bf564e9b86571fcb04d42f3ae327d0f58d
c0467df838349d5f3db4c1d3b66987ea950959e0
[ "@normanmaurer This looks related to https://github.com/netty/netty/commit/ecd6e5ce6d82756475e88ae69d2bfef1082edb68#diff-9cc075ed08ebc635ad5afcdb82bd449b I think we just need to add the `Content-Length` header for all cases, including when consumers use `preflightResponseHeader()` too.", "Pull request for the fix...
[ "`HttpHeaderValues.ZERO`", "`HtpHeaderValues.ZERO`", "No problem, I changed that in commit 9c5c89c55. I squashed commits too so there is a single commit message and reverting is easy. If I shouldn't do that let me know." ]
2017-09-28T14:57:04Z
[ "defect" ]
CorsHandler not responding with Content-Length
### Expected behavior * `CorsHandler` responds with `Content-Length: 0` when origin is allowed * `CorsHandler` responds with `Content-Length: 0` when origin is not allowed ### Actual behavior * `CorsHandler` responds with `Content-Length: 0` when origin is allowed * `CorsHandler` does not respond with a `Co...
[ "codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java index 63bffe15f00..f4b5552b724 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java +++ b/codec-http/src/main/java/io/ne...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java index e3d67b6bf5a..f3fe97efd01 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java +++ b/codec-http/src/tes...
train
train
2017-09-27T13:25:16
2017-09-27T15:22:44Z
matthewbelisle-wf
val
netty/netty/7230_7277
netty/netty
netty/netty/7230
netty/netty/7277
[ "timestamp(timedelta=29.0, similarity=0.8598549436188782)" ]
5eca326c3568566f334b31b18f7866af19a989c8
3cf2b478c715fffb746de6ff756cf4bbe09fac63
[ "@BillyYccc please check https://github.com/netty/netty/pull/7277", "Fixed" ]
[ "![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) Remove this use of \"Thread.sleep()\". [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://garage.netty.io/sonarqube/coding_rules#rule_key=squid%3AS2925...
2017-10-05T08:24:18Z
[ "defect" ]
Method setHandshakeTimeout of SslHandler does not work in server side
### Expected behavior I want to enable `setHandshakeTimeout()` in server side. I call the method setHandshakeTimeout() like this `sslHandler.setHandshakeTimeout(1,TimeUnit.MILLISECONDS);` The value of HandshakeTimeout is set to a very small value so that the client and server can not complete the handshake since the h...
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java index ac32c9c76f0..f72cf874623 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java @@ -1536,11 +1536,1...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java index 5e10a6d569b..478c77400f0 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java @@ ...
train
train
2017-10-05T08:26:42
2017-09-19T06:27:11Z
BillyYccc
val
netty/netty/6100_7283
netty/netty
netty/netty/6100
netty/netty/7283
[ "timestamp(timedelta=1556.0, similarity=0.9223981932983233)" ]
5eca326c3568566f334b31b18f7866af19a989c8
f85039695d37aab08d41adf2319f2e066e039d1b
[]
[ "After updating animal-sniffer-maven-plugin.. should be fine as NioDatagramChannel only supports >= java17\r\n\r\n```text\r\n[INFO] --- animal-sniffer-maven-plugin:1.16:check (default) @ netty-transport ---\r\n[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.1\r\n[ERROR] /home/johno/Wor...
2017-10-07T08:34:43Z
[]
Upgrade ASM dependency to 6.0.0 final once released
We need to upgrade our ASM dependency to 6.0.0 final once its released to also support compiling on java9. See https://issues.apache.org/jira/browse/MSHADE-242
[ "common/pom.xml", "pom.xml" ]
[ "common/pom.xml", "pom.xml" ]
[]
diff --git a/common/pom.xml b/common/pom.xml index 66efb88a2df..e8c7bf372f8 100644 --- a/common/pom.xml +++ b/common/pom.xml @@ -102,30 +102,6 @@ </configuration> </execution> </executions> - <!-- Needed to support JDK9 --> - <!-- See https://github.com/netty/netty/issues/...
null
train
train
2017-10-05T08:26:42
2016-12-03T08:08:47Z
normanmaurer
val
netty/netty/7337_7338
netty/netty
netty/netty/7337
netty/netty/7338
[ "timestamp(timedelta=13352.0, similarity=0.8889366655100914)" ]
dcbbae7f9006f5b995d055702dd1c9f55f0e0c9d
addf44225db03b73b48e32f11106d00f40da13ad
[ "You are correct... let me fix it.", "Cool, thanks", "@Anon43590 please check https://github.com/netty/netty/pull/7338", "@normanmaurer looks correct to me, thanks" ]
[ "`transfered ` -> `transferred`" ]
2017-10-24T12:21:25Z
[ "defect" ]
Possible buffer leak in SslHandler?
Excuse me if I'm missing something obvious, but it seems to me that in SslHandler.java, "buf" removed from "pendingUnencryptedWrites" on line 751 may leak if "wrap(alloc, engine, buf, out)" called on line 762 throws. The wrap function on line 912 is marked as "throws SSLException", which I assume is something that coul...
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java index c3920e68c4d..444ba2f4b4e 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java @@ -742,13 +742,14 ...
null
train
train
2017-10-24T09:32:06
2017-10-24T12:04:30Z
Anon43590
val
netty/netty/7353_7357
netty/netty
netty/netty/7353
netty/netty/7357
[ "timestamp(timedelta=23.0, similarity=0.8823948021739179)" ]
cdb2a27857e2dc0bc12ac97eaf2edd23a6467568
a03b3fc5d260e159875afcc5cb31ef41b1e6d650
[ "Will have a look tomorrow\n\n> Am 31.10.2017 um 17:07 schrieb Search Guard <notifications@github.com>:\n> \n> Expected behavior\n> \n> No NPE\n> \n> Actual behavior\n> \n> java.lang.NullPointerException: ssl (see stracktrace below) at ReferenceCountedOpenSslEngine.rejectRemoteInitiatedRenegotiation\n> \n> Steps to...
[]
2017-11-01T07:12:15Z
[ "defect" ]
java.lang.NullPointerException: ssl at ReferenceCountedOpenSslEngine.rejectRemoteInitiatedRenegotiation
### Expected behavior No NPE ### Actual behavior java.lang.NullPointerException: ssl (see stracktrace below) at ReferenceCountedOpenSslEngine.rejectRemoteInitiatedRenegotiation ### Steps to reproduce Happens randomly ### Minimal yet complete reproducer code (or URL to code) ### Netty version 4.1.13.Fina...
[ "handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java index 0c4bf5c2d47..5b2848e2373 100644 --- a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java +++ b/handler/src/main/java...
null
val
train
2017-10-29T13:42:15
2017-10-31T16:07:12Z
floragunn
val
netty/netty/7378_7380
netty/netty
netty/netty/7378
netty/netty/7380
[ "timestamp(timedelta=6.0, similarity=0.8634903348220907)" ]
8618a3351cbecc68562c06c409538b182077f8d9
6b5e8d82e05a7732dc239a38429736ad016db6f9
[ "See https://github.com/netty/netty/pull/7380" ]
[]
2017-11-07T16:45:36Z
[ "defect" ]
Channel promise of a write is successful, although SSL handshake fails.
### Expected behavior When a SSL handshake fails, a channel promise of a write operation should fail aswell. ### Actual behavior The channel promise succeeds. ### Steps to reproduce $ git clone https://github.com/s-gheldd/netty-reproducer.git $ cd netty-reproducer $ mvn test ### Minimal ye...
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java", "transport/src/main/java/io/netty/channel/AbstractCoalescingBufferQueue.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/SslHandler.java", "transport/src/main/java/io/netty/channel/AbstractCoalescingBufferQueue.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java index 4cd8013ba0a..82fc18657a4 100644 --- a/handler/src/main/java/io/netty/handler/ssl/SslHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/SslHandler.java @@ -794,7 +794,10 @...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java index 1e78a6e47dd..0afe89ccf73 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java @@ ...
test
train
2017-11-07T06:58:16
2017-11-07T13:49:34Z
sauroter
val
netty/netty/7393_7395
netty/netty
netty/netty/7393
netty/netty/7395
[ "timestamp(timedelta=48330.0, similarity=0.8428181346150718)" ]
188ea59c9d5be75ee0879c114a20e6b633e3714b
a8205e480ee752d6a0fabe222ab96221341cd94b
[ "I think changing copy() to create pooled buffers would be api breaking and would cause memory leaks in user apps...(no need to call .release() right now)\r\nPersonally I avoid using copy() for the reason you mentioned and replace it with:\r\n1. create new pooled buffer with the same size\r\n2. newBuf.readBytes(buf...
[ "Maybe `allocBuffer(length)`?", "@fenik17 good catch... let me do this and add one more assert in the tests 👍 " ]
2017-11-09T16:51:30Z
[ "improvement" ]
pooled ByteBuf copy will create unpooled ByteBuf
-Dio.netty.allocator.type : pooled When i call CompositeByteBuf.copy , but it create a Unpooled ByteBuf. and then my server frequently GC. I think this method should be written like this : `public ByteBuf copy(int index, int length) {` `checkIndex(index, length);` `ByteBuf dst = ByteBufAllocator.DEFAULT.buffe...
[ "buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java" ]
[ "buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java" ]
[ "buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java", "buffer/src/test/java/io/netty/buffer/ConsolidationTest.java" ]
diff --git a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java index da4876d837b..8a3681b5305 100644 --- a/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java +++ b/buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java @@ -1333,7 +1333,7 ...
diff --git a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java b/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java index 0d3b5db3c9d..f51475bf9ae 100644 --- a/buffer/src/test/java/io/netty/buffer/AbstractCompositeByteBufTest.java +++ b/buffer/src/test/java/io/netty/buffer/Abstr...
test
val
2017-11-08T23:36:53
2017-11-09T09:24:34Z
las1991
val
netty/netty/7355_7399
netty/netty
netty/netty/7355
netty/netty/7399
[ "timestamp(timedelta=35.0, similarity=0.852190933309667)" ]
f115bf50cbda70964130236a09fd3045f1b250be
4a4f4ab0cdb403beda217d3d972c79da550aacee
[ "@mosesn sounds right... want to do a PR against `HttpConversionUtil.toHttp2Headers ` ", "we could enhance the conversion to extract out the `trailers` value from the `TE` header instead of just throwing. +1 for a PR.", "I made a PR that extracted the trailers value and also cleaned up the behavior around \"con...
[ "should we use the constructor that takes the `arraySizeHint` based on `values.size()` ?", "consider using an \"old for\" loop if the List implements `RandomAccess` to reduce GC pressure (as the foreach thingy you use here will always create an Iterator)", "While it creates an iterator, it can be allocated on t...
2017-11-10T22:13:37Z
[ "defect" ]
HttpConversionUtil.toHttp2Headers should strip http/2 incompatible headers
### Expected behavior When servers receive an h2c upgrade request, it's an http/1.1 message, and it quickly gets turned into an h2c message. ### Actual behavior If the upgrade request has illegal headers, like `te: deflate,gzip;q=0.3` then it doesn't handle it gracefully and throws an exception. ``` W 1030 21:...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java", "common/src/main/java/io/netty/util/AsciiString.java", "common/src/main/java/io/netty/util/ByteProcessor.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java", "common/src/main/java/io/netty/util/AsciiString.java", "common/src/main/java/io/netty/util/ByteProcessor.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HttpConversionUtilTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java index 03e338fad45..71932fdd808 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HttpConversionUtil.java +++ b/codec-http2/src/ma...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpConversionUtilTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpConversionUtilTest.java index 98e563ee45e..8b665930f6c 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HttpConversionUtilTest.java +++ b/codec-...
train
val
2017-11-16T14:07:54
2017-10-31T20:33:41Z
mosesn
val
netty/netty/7365_7402
netty/netty
netty/netty/7365
netty/netty/7402
[ "timestamp(timedelta=22.0, similarity=0.9999999999999999)" ]
010dbe3c734aff7b400c7be8666e5f0c055fca62
b47fb817991b42ec8808c7d26538f3f2464e1fa6
[ "will have a look. Most likely its an overflow.", "@zyclonite please check https://github.com/netty/netty/pull/7402", "thank you for the fast fix!\r\nworks for linux so far (will test it for osx in the evening)\r\n\r\ntypo or on purpose? ```static final long MAX_SCHEDULED_DAYS = 356 * 3;```", "works on osx as...
[ "please note that I used this as it seems to work on linux / Windows and macOS.", "Why do we care about windows and linux here? This is in the kqueue transport.", "add a comment explaining where this number comes from.", "https://www.freebsd.org/cgi/man.cgi?query=kqueue&sektion=2#end\r\n\r\n> The timeout val...
2017-11-13T12:27:26Z
[ "defect" ]
EventLoop.schedule with big delay fails
this behaviour was discovered by accident, so there is no actual usecase behind it but it is definitely not possible to use Long.MAX_VALUE in milliseconds for a scheduled event ### Expected behavior runnable should trigger after given delay getting a proper exception if something goes wrong ### Actual behavior ...
[ "common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java", "transport/src/main/java/io/netty/channel/nio/NioEventLo...
[ "common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollEventLoop.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/KQueueEventLoop.java", "transport/src/main/java/io/netty/channel/nio/NioEventLo...
[ "transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java", "transport-native-kqueue/src/test/java/io/netty/channel/kqueue/KQueueEventLoopTest.java", "transport/src/test/java/io/netty/channel/nio/NioEventLoopTest.java" ]
diff --git a/common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java index 3043b1709fe..795aeba907c 100644 --- a/common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java +++ b/common/sr...
diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollEventLoopTest.java new file mode 100644 index 00000000000..0fe824b334d --- /dev/null +++ b/transport-native-epoll/src/test/java/io/netty/channel/epoll/Epoll...
train
val
2018-04-24T09:19:01
2017-11-04T13:22:29Z
zyclonite
val
netty/netty/7418_7420
netty/netty
netty/netty/7418
netty/netty/7420
[ "timestamp(timedelta=35.0, similarity=0.8444596576464353)" ]
5ca273814ffde676083751352f9c957a912387b9
7baaf9164f3b8bb3f018cd59ae5964d76caf9f5c
[ "Will have a Look\n\n> Am 18.11.2017 um 23:03 schrieb Piotr Kołaczkowski <notifications@github.com>:\n> \n> Expected behavior\n> \n> Writing DefaultLastContent object with trailing headers sends an empty chunk with trailing headers.\n> \n> Actual behavior\n> \n> Writing DefaultLastContent with trailing headers caus...
[]
2017-11-19T08:32:10Z
[ "defect" ]
Sending DefaultLastContent with trailers causes "io.netty.handler.codec.EncoderException: HttpServerCodec$HttpServerResponseEncoder must produce at least one message."
### Expected behavior Writing `DefaultLastContent` object with trailing headers sends an empty chunk with trailing headers. ### Actual behavior Writing `DefaultLastContent` with trailing headers causes EncoderException: ``` io.netty.handler.codec.EncoderException: HttpServerCodec$HttpServerResponseEncoder must p...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java", "codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseEncoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java index 2bdb6ce78ec..50b3ab76731 100755 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpObjectEncoder.java +++ b/codec-http/src/main/java/io...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java index 742689f683d..ddcb007c571 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpRequestEncoderTest.java +++ b/codec-http/s...
train
val
2017-11-18T09:07:46
2017-11-18T22:03:49Z
pkolaczk
val
netty/netty/7428_7429
netty/netty
netty/netty/7428
netty/netty/7429
[ "timestamp(timedelta=20.0, similarity=0.9429919324532562)" ]
7f4ade7e7d6f907a30926c54e16abefe88e81a8e
5583da60988f634eadebe35785b1a7cdd04648ba
[ "@mikkokar thanks! Will check", "@mikkokar PTAL https://github.com/netty/netty/pull/7429 ", "Fixed via https://github.com/netty/netty/pull/7429" ]
[ "i think the iterator says you need to call hasNext()?", "@carl-mastrangelo yep this would be more correct... let me do this.", "Why is this not passed in as a String[] ?", "Good point. I guess its because the signature of `public <X> X[] toArray(X[] a)` is generic and it is still shared between both `toArray...
2017-11-21T13:19:55Z
[ "defect" ]
Usage of DefaultHttpHeader.names() outcome may result in java.lang.ArrayStoreException
`DefaultHttpHeader.names()` exposes HTTP header names as a `Set<String>`. Converting the resulting set to an array using `toArray(String[])` throws an exception: `java.lang.ArrayStoreException: io.netty.util.AsciiString`. ### Expected behavior I expect following code to return an array of String objects: ``...
[ "codec/src/main/java/io/netty/handler/codec/HeadersUtils.java" ]
[ "codec/src/main/java/io/netty/handler/codec/HeadersUtils.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java" ]
diff --git a/codec/src/main/java/io/netty/handler/codec/HeadersUtils.java b/codec/src/main/java/io/netty/handler/codec/HeadersUtils.java index d4062209b38..0582353b765 100644 --- a/codec/src/main/java/io/netty/handler/codec/HeadersUtils.java +++ b/codec/src/main/java/io/netty/handler/codec/HeadersUtils.java @@ -15,6 +1...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java index b09546eeb73..5514f23ff07 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpHeadersTest.java +++ b/codec-http/s...
train
val
2017-11-21T11:55:39
2017-11-21T12:43:45Z
mikkokar
val
netty/netty/7483_7492
netty/netty
netty/netty/7483
netty/netty/7492
[ "timestamp(timedelta=24.0, similarity=0.9999999999999999)" ]
b2bc6407ab6ff6e9be65ada56e4a4058e2c6a293
4f0ec0d83eb63876ef67ad58fcee44a063b6c220
[ "@rvansa looking now", "@rvansa PTAL #7492", "Fixed by https://github.com/netty/netty/pull/7492" ]
[ "`j.u.c.RejectedExecutionHandler` is not limited to throwing REEs, why not `Throwable`?", "We try to not introduce more Throwable catches if we rethrow these. Maybe `Exception` ?", "Sounds good.", "@rvansa PTAL again just pushed", "optional:\r\n\r\n`if (cause instanceof Error)) {`\r\n", "I think I would l...
2017-12-11T13:38:23Z
[ "defect" ]
SingleThreadEventExecutor ignores startThread failures
### Expected behavior SingleThreadEventExecutor should throw an exception when it can't start the thread second time. ### Actual behavior When `doStartThread` throws an exception, e.g. due to the actual executor being depleted of threads and throwing in its rejected execution handler, the STEE ends up in started s...
[ "common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java" ]
[ "common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java" ]
[ "common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java" ]
diff --git a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java index 510d05aea49..d1de03fe6e3 100644 --- a/common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java +++ b/common/src/main/java/io/...
diff --git a/common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java b/common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java index 3be7dc8f831..55981b24060 100644 --- a/common/src/test/java/io/netty/util/concurrent/SingleThreadEventExecutorTest.java +++ b/common/src/t...
val
val
2017-12-08T10:26:15
2017-12-07T10:00:53Z
rvansa
val
netty/netty/5226_7503
netty/netty
netty/netty/5226
netty/netty/7503
[ "timestamp(timedelta=18.0, similarity=0.8450339385731247)" ]
1988cd041d3d5eaa5f52e58d3d3f773b9ef17fe7
443243a7d0c0b3f4ff129211b2f99b66178cf73b
[ "@Scottmitch I will take care.\n", "Fixed by https://github.com/netty/netty/pull/7503" ]
[ "Note this change was needed as we not correctly copied the headers before in our replace(...) methods.", "Also we missed this before :(", "Also we missed this before :(", "`set` will also do `clear` which will do some unnecessary work (array filling, pointer updating, assignments). We should be able to just ...
2017-12-13T19:30:21Z
[]
HttpObjectAggregator.replace headers may enforce validation when they should not
`HttpObjectAggregator.replace` creates a new `DefaultFullHttpRequest` and does not specify a value for the `validateHeaders` during construction. This would mean that header validation is not consistent from the user's perspective and may enforce validation when the user does not want validation ... which may throw une...
[ "codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java", "codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpResponse.java", "codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpHea...
[ "codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java", "codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpResponse.java", "codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpHeaders.java", "codec-http/src/main/java/io/netty/handler/codec/http/HttpHea...
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java index ba55d9657e9..117e6dbf648 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultFullHttpRequest.java +++ b/codec-http/s...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterTest.java index b29c0966d7d..8fb4ebfc678 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/InboundHttp2ToHttpAdapterT...
val
val
2017-12-12T09:08:58
2016-05-09T15:27:51Z
Scottmitch
val
netty/netty/7511_7512
netty/netty
netty/netty/7511
netty/netty/7512
[ "timestamp(timedelta=0.0, similarity=0.8629639334100965)" ]
640a22df9efb41e3d29b79916938c1c315be2872
94ab0dc4425b05e8691c0954f70c1859d0b7294c
[ "@mosesn can you open a PR with a unit test ?", "@normanmaurer yeah, I'll take a look.", "@mosesn thanks buddy", "I still haven't been able to make a unit test, but I have a better idea of what's happening.\r\n\r\nAfter we have already added the name length and value length of the header with the long name l...
[ "this comment is a bit confusing... when we \"get an exception\" shouldn't we need to catch it ?", "oh, I just copy/pasted this from the previous test. I'll just delete it.", "updated, PTAL" ]
2017-12-16T02:19:27Z
[]
double counting header name length in http/2
### Expected behavior A header with a name of length X and a value of length Y gets considered as being length X + Y in total. ### Actual behavior A header with a name of length X and a value of length Y gets considered as being length 2X + Y in total. I think this is where the bug is: https://github.com/n...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java index ce81f7c4984..07b1e30b535 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java +++ b/codec-http2/src/main/java/io/netty/h...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java index 8dd885400ce..04552b9263e 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java +++ b/codec-http2/src/test/jav...
train
val
2017-12-15T21:21:18
2017-12-15T17:17:05Z
mosesn
val
netty/netty/7509_7523
netty/netty
netty/netty/7509
netty/netty/7523
[ "keyword_issue_to_pr", "timestamp(timedelta=67.0, similarity=0.843997554030955)" ]
94ab0dc4425b05e8691c0954f70c1859d0b7294c
144716f668efaa5bf4bb4175ec5513bd4f0f60b7
[ "@durigon just to ensure did you try 4.1.18.Final as well ?", "@normanmaurer #4283 and #4585 are still in process, so it seems that it has not been fixed.\r\n", "I think this will be resolved once https://github.com/netty/netty/issues/4283 is resolved.", "@durigon - Can you run your tests with https://github...
[]
2017-12-19T03:54:42Z
[ "defect" ]
HTTP/2 UniformStreamByteDistributor has an infinite loop problem when transferring content that exceeds 2 GB.
### Expected behavior no infinite loop ### Actual behavior HTTP/2 UniformStreamByteDistributor has an infinite loop problem when transferring content that exceeds 2GB. - [Http2CodecUtil streamableBytes - If pendingBytes is out of the integer range, streamableBytes may be zero.](https://github.com/netty/netty/b...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/StreamByteDistributor.java", "codec-http2/src/main/java/io/netty/handler/codec/h...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/StreamByteDistributor.java", "codec-http2/src/main/java/io/netty/handler/codec/h...
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/AbstractWeightedFairQueueByteDistributorDependencyTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2TestUtil.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/UniformStreamByteDistributorTest.java", "codec-http2/src/te...
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java index 034140c81f8..6e02e7cecf5 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFl...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/AbstractWeightedFairQueueByteDistributorDependencyTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/AbstractWeightedFairQueueByteDistributorDependencyTest.java index 12b177f975a..bb1e4695abf 100644 --- a/codec-http2/src/test/java/io/ne...
val
val
2017-12-19T02:41:09
2017-12-15T08:53:15Z
durigon
val
netty/netty/4283_7523
netty/netty
netty/netty/4283
netty/netty/7523
[ "timestamp(timedelta=0.0, similarity=0.8439626116831509)" ]
94ab0dc4425b05e8691c0954f70c1859d0b7294c
144716f668efaa5bf4bb4175ec5513bd4f0f60b7
[ "@nmittler - So you are thinking that each stream's `pendingBytes` should be of data type `long` (and then what ever else needs to change to accommodate this)?\n", "@Scottmitch yeah that's basically it (for now). The `writableBytes` would still be an int, but streams may have more than `MAX_INT` to send. \n" ]
[]
2017-12-19T03:54:42Z
[ "feature" ]
Allow writing long-length objects in HTTP/2 flow control
This is just to capture the data byte we use for `streamableBytes`. It should be changed to `long` to support very large objects (e.g. FileRegion). @Scottmitch FYI
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/StreamByteDistributor.java", "codec-http2/src/main/java/io/netty/handler/codec/h...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2CodecUtil.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/StreamByteDistributor.java", "codec-http2/src/main/java/io/netty/handler/codec/h...
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/AbstractWeightedFairQueueByteDistributorDependencyTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2TestUtil.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/UniformStreamByteDistributorTest.java", "codec-http2/src/te...
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFlowController.java index 034140c81f8..6e02e7cecf5 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2RemoteFl...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/AbstractWeightedFairQueueByteDistributorDependencyTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/AbstractWeightedFairQueueByteDistributorDependencyTest.java index 12b177f975a..bb1e4695abf 100644 --- a/codec-http2/src/test/java/io/ne...
train
val
2017-12-19T02:41:09
2015-09-25T18:25:20Z
nmittler
val
netty/netty/7514_7531
netty/netty
netty/netty/7514
netty/netty/7531
[ "keyword_pr_to_issue", "timestamp(timedelta=0.0, similarity=0.8670675281921579)" ]
c9668ce40f80f73763165a8bfe70969de830204c
6b033c51a50e96714bf6939bd8a7706ee173d8e6
[ "@mosesn are you planing to work on a PR / unit test ?", "Not right now, maybe in the next couple months? It's not causing us a problem, it just made debugging an issue we ran into a bit harder.", "@mosesn got it", "I may have a go at it. Sounds simple enough 😝 ", "@madgnome yay :)", "Thanks @madgnome!"...
[ "just change this to `catch (Http2Exception.HeaderListSizeException expected)` and remove the `assertTrue(...)` below ?", "fyi, in the future, this should be final", "https://github.com/netty/netty/pull/7596" ]
2017-12-21T10:59:59Z
[]
hpackdecoder doesn't account for header overhead
Http/2 says for max header list size: > SETTINGS_MAX_HEADER_LIST_SIZE (0x6): This advisory setting informs a > peer of the maximum size of header list that the sender is > prepared to accept, in octets. The value is based on the > uncompressed size of header fields, including the length of ...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java index 07b1e30b535..ca7610816d2 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java +++ b/codec-http2/src/main/java/io/netty/h...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java index 04552b9263e..18220338882 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java +++ b/codec-http2/src/test/jav...
val
val
2017-12-21T07:41:38
2017-12-16T22:29:04Z
mosesn
val
netty/netty/6320_7544
netty/netty
netty/netty/6320
netty/netty/7544
[ "timestamp(timedelta=0.0, similarity=0.8480668595327252)" ]
b6c42f6547e6621dd924707167db83b15652d7f6
e24e06bfcb8114270d46572cf96af49be76237b1
[ "OpenSSL 1.1.0e cannot be used in netty-tcnative, because SSL_set_state no longer exists in OpenSSL since 1.1.0 (https://github.com/netty/netty-tcnative/issues/263).\r\nGiven that OpenSSL 1.1.1 (hopefully) supports TLS 1.3, it seems worth to remove usage of SSL_set_state.", "I don't know if this helps, but this i...
[]
2017-12-23T13:26:03Z
[]
OpenSslEngine should not call SSL_set_state
OpenSslEngine currently calls `SSL_set_state(SSL_ST_ACCEPT)` during the renegotiation process. The OpenSSL team has advised against this [1]. We should investigate and avoid calling `SSL_ST_ACCEPT` if possible. [1] https://github.com/openssl/openssl/issues/2551#issuecomment-277644153
[ "handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java b/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java index 360d9fd9ab2..d235653cfd4 100644 --- a/handler/src/main/java/io/netty/handler/ssl/ReferenceCountedOpenSslEngine.java +++ b/handler/src/main/java...
diff --git a/handler/src/test/java/io/netty/handler/ssl/OpenSslRenegotiateSmallBIOTest.java b/handler/src/test/java/io/netty/handler/ssl/OpenSslRenegotiateSmallBIOTest.java deleted file mode 100644 index 3959e646998..00000000000 --- a/handler/src/test/java/io/netty/handler/ssl/OpenSslRenegotiateSmallBIOTest.java +++ /d...
train
val
2017-12-22T19:32:56
2017-02-06T19:46:20Z
Scottmitch
val
netty/netty/7561_7562
netty/netty
netty/netty/7561
netty/netty/7562
[ "timestamp(timedelta=19.0, similarity=0.9280960646913106)" ]
4c1e0f596ad25bf891570ea67c5322a35938bfa5
3b81d8791438b7f8424effbf23cf139b95491d85
[ "Fixed by https://github.com/netty/netty/pull/7562" ]
[ "Please use the same strategy as https://github.com/netty/netty/commit/942b993f2b9781ff2126ff92a6be5b975dfc72ed#diff-17c17dd59c9912dd08e4dc95fa04bcab. In summary adding a `copy()` method on `DefaultStompHeaders` which leverages `DefaultHeaders#copy()`.", "I looked to this strategy but `DefaultStompHeaders extends...
2018-01-03T16:19:18Z
[ "defect" ]
StompFrame.copy() does not copy headers
### Expected behavior Call stompFrame.copy() do copies of content and headers. ### Actual behavior After call stompFrame.copy() only content was copy. ### Minimal yet complete reproducer code (or URL to code) `StompFrame stompFrame = new DefaultStompFrame(StompCommand.CONNECT);` `stompFrame.headers().set(...
[ "codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java", "codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompHeaders.java", "codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompHeadersSubframe.java" ]
[ "codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java", "codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompHeaders.java", "codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompHeadersSubframe.java" ]
[ "codec-stomp/src/test/java/io/netty/handler/codec/stomp/DefaultStompFrameTest.java" ]
diff --git a/codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java b/codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java index d113ed6f2b7..8df4c650439 100644 --- a/codec-stomp/src/main/java/io/netty/handler/codec/stomp/DefaultStompFrame.java +++ b/codec-stomp/src/main/...
diff --git a/codec-stomp/src/test/java/io/netty/handler/codec/stomp/DefaultStompFrameTest.java b/codec-stomp/src/test/java/io/netty/handler/codec/stomp/DefaultStompFrameTest.java new file mode 100644 index 00000000000..c995ca7f1b8 --- /dev/null +++ b/codec-stomp/src/test/java/io/netty/handler/codec/stomp/DefaultStompFr...
val
val
2018-01-23T11:34:28
2018-01-03T16:13:16Z
amizurov
val
netty/netty/7583_7587
netty/netty
netty/netty/7583
netty/netty/7587
[ "timestamp(timedelta=86811.0, similarity=0.8799133035237494)" ]
46dac128f7472f264e3cb53e4d1fa40f6b043034
03c8c5b67a2d9ce62c7cd7974ca33bb4a675eeca
[ "Some notes..\r\n\r\nMight make more sense for io.netty.resolver.dns.DefaultDnsCache#get to return something like this to avoid concurrency issues with the list (in my experience exposing mutable data from a cache is a bad idea)..\r\n\r\n```java\r\n @Override\r\n public List<? extends DnsCacheEntry> get(Strin...
[ "Little cleaner and less boiler plate code if we assign the locks to final fields as suggested in the javadocs https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/ReentrantReadWriteLock.html\r\n\r\n```java\r\nprivate final Lock readLock = lock.readLock();\r\nprivate final Lock writeLock = lock.writ...
2018-01-16T11:39:19Z
[ "defect" ]
io.netty.resolver.dns.DnsNameResolver#doResolveCached race condition
### Expected behavior No exception. ### Actual behavior ``` 2018-01-15 05:33:32,915 ERROR [Redisson-Epoll-1-15] (org.redisson.connection.DNSMonitor) Unable to resolve xxx.0001.use1.cache.amazonaws.com java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 at java.util.ArrayList.rangeCheck(ArrayList.java...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsCache.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsCache.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java" ]
[]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsCache.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsCache.java index f2acd3fac76..2b3477bd381 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DefaultDnsCache.java +++ b/resolver-dns/src/main/java/io/netty/resolver/...
null
train
val
2018-01-22T20:17:56
2018-01-15T12:02:48Z
johnou
val
netty/netty/7585_7594
netty/netty
netty/netty/7585
netty/netty/7594
[ "timestamp(timedelta=33.0, similarity=1.0000000000000002)" ]
336bea9dc541413be4cd961417e2be456bdcac11
882c59c6aa6323236abb1a5bc18820b1feacf5e2
[ "Fixed by https://github.com/netty/netty/pull/7594 ... @asarkar PTAL", "Fixed by https://github.com/netty/netty/pull/7594" ]
[ "Consider merging this into one `RUN ... && \\ ...` command to have a single layer created for this group of operation that is logically related.", "Consider sorting and multi-lining for easier maintenance: https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#sort-multi-line-arguments", ...
2018-01-18T15:23:16Z
[ "improvement", "feature" ]
Provide a Docker image for reproducible builds
### Expected behavior Developer can build on any platform using a Docker image without having to install additional native packages. Simply cloning the repo and following an one-liner build command should be enough. We should provide a fully-configured Docker image, and also configure the TeamCity CI to use it (I h...
[]
[ "docker/Dockerfile-netty-centos6", "docker/README.md" ]
[]
diff --git a/docker/Dockerfile-netty-centos6 b/docker/Dockerfile-netty-centos6 new file mode 100644 index 00000000000..d6e2339f510 --- /dev/null +++ b/docker/Dockerfile-netty-centos6 @@ -0,0 +1,34 @@ +FROM centos:6 +MAINTAINER netty@googlegroups.com +ENTRYPOINT /bin/bash + +ENV SOURCE_DIR $HOME/source +ENV MAVEN_VERSIO...
null
train
val
2018-01-22T19:50:08
2018-01-16T01:27:44Z
asarkar
val
netty/netty/7607_7612
netty/netty
netty/netty/7607
netty/netty/7612
[ "timestamp(timedelta=0.0, similarity=0.8693949310932216)" ]
27ff15319c2e566c44e333b9bd59cf210c130c2f
8a095d0244da237f6eb76c4c24be49a1833b3988
[ "Test case\r\n```java\r\n@Test\r\n public void freesPingFrames() {\r\n ByteBuf content = UnpooledByteBufAllocator.DEFAULT.buffer(8).writeLong(0);\r\n DefaultHttp2PingFrame frame = new DefaultHttp2PingFrame(content);\r\n assertEquals(1, content.refCnt());\r\n codec.onHttp2Frame(frame);...
[ "btw, do you need to free this content?", "Do you mean for the test, or for the `Http2MultiplexedCodec`?", "It doesn't look like it's released. It should be. That's why the CI test fails with \"Build failure on specific text in build log: Resource leak detected\".", "IIUC we need a `decodedFrame.release();` a...
2018-01-23T15:33:59Z
[ "defect" ]
Http2MultiplexCodec leaks ping payloads
### Expected behavior The payload of a PingFrame would be released or passed somewhere into the application for consumption. ### Actual behavior It appears that `Http2PingFrame`s are dropped on the floor in the [`Http2MultiplexCodec.onHttp2Frame`](https://github.com/netty/netty/blob/4.1/codec-http2/src/main/ja...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java index ae98bfea08b..aeeec3feb68 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java +++ b/codec-http2/src...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java index ecdcdcf7c85..bec5cd964ee 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java +++ b/cod...
test
val
2018-01-23T15:27:57
2018-01-23T00:07:55Z
bryce-anderson
val
netty/netty/7620_7622
netty/netty
netty/netty/7620
netty/netty/7622
[ "timestamp(timedelta=14.0, similarity=0.9017916825519452)" ]
4921f62c8ab8205fd222439dcd1811760b05daf1
688c0ca551a2486c38ced56baa23d41a712ab8c2
[ "```\r\nprivate static String[] splitMultipartHeader(String sb) {\r\n ...\r\n valueStart = HttpPostBodyUtil.findNonWhitespace(sb, colonEnd);\r\n valueEnd = HttpPostBodyUtil.findEndOfString(sb);\r\n headers.add(sb.substring(nameStart, nameEnd));\r\n\r\n String svalue = sb.substring...
[ "@matteobertozzi should we just make this `StringUtil.EMPTY_STRING` when `valueStart >= valueEnd` ?\r\n\r\nSo something like this:\r\n\r\n```\r\nString svalue == valueStart >= valueEnd ? StringUtil.EMPTY_STRING : sb.substring(valueStart, valueEnd))\r\n```\r\nWDYT ?", "yeah, that's better", "@matteobertozzi plea...
2018-01-24T22:04:48Z
[]
HttpPostMultipartRequestDecoder.splitMultipartHeader() String index out of range: -1 with empty Content-Type
Parsing a multi-part request with an empty content type header: e.g. "Content-Type: " will produce a java.lang.StringIndexOutOfBoundsException: String index out of range: -1 ``` java.lang.StringIndexOutOfBoundsException: String index out of range: -1 at java.lang.String.substring(String.java:1967) at io.netty....
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/multipart/HttpPostMultipartRequestDecoder.java index 44b2641c6a4..8e3a90c009b 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/multipar...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPostRequestDecoderTest.java index 31e786a38c3..f8b756ca70a 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/multipart/HttpPost...
test
val
2018-01-25T07:01:52
2018-01-24T16:35:32Z
matteobertozzi
val
netty/netty/7609_7624
netty/netty
netty/netty/7609
netty/netty/7624
[ "timestamp(timedelta=444.0, similarity=0.9133649548851649)" ]
b769ec09346e227b9e33d581f26e2cb0b22911a7
e1386713560a70218fc34f65e345abff491a4bed
[ "@laosijikaichele PRs welcome... that said I am not sure if we need anything here as `mayInterruptIfRunning` already signals that it may interrupt or not.", "I am setting up the netty development environment, after that, I will try a PR for this doc issue. :)", "Fixed by https://github.com/netty/netty/pull/7624...
[ "at a minimum we need {@inheritDoc}, and in general I'm not convinced this change is necessary as the `cancel` operation itself is indicated as best effort in the original javadocs and therefore the parameter may not be used in general.", "if a param value does not used in the method, then it should be indicated ...
2018-01-25T03:32:48Z
[ "documentation" ]
should add java-doc for method DefaultPromise#cancel(boolean mayInterruptIfRunning)
### Expected behavior implementation of method `io.netty.util.concurrent.DefaultPromise#cancel(boolean mayInterruptIfRunning)` actually ignored the param `mayInterruptIfRunning`. so it need to make a comment like following: (this comment is copied from `java.util.concurrent.CompletableFuture#cancel`): > * @p...
[ "common/src/main/java/io/netty/util/concurrent/CompleteFuture.java", "common/src/main/java/io/netty/util/concurrent/DefaultPromise.java", "common/src/main/java/io/netty/util/concurrent/ScheduledFutureTask.java", "transport/src/main/java/io/netty/channel/VoidChannelPromise.java", "transport/src/main/java/io/...
[ "common/src/main/java/io/netty/util/concurrent/CompleteFuture.java", "common/src/main/java/io/netty/util/concurrent/DefaultPromise.java", "common/src/main/java/io/netty/util/concurrent/ScheduledFutureTask.java", "transport/src/main/java/io/netty/channel/VoidChannelPromise.java", "transport/src/main/java/io/...
[]
diff --git a/common/src/main/java/io/netty/util/concurrent/CompleteFuture.java b/common/src/main/java/io/netty/util/concurrent/CompleteFuture.java index 84376233dd3..ed5755f5727 100644 --- a/common/src/main/java/io/netty/util/concurrent/CompleteFuture.java +++ b/common/src/main/java/io/netty/util/concurrent/CompleteFut...
null
train
val
2018-01-24T19:42:13
2018-01-23T08:24:28Z
laosijikaichele
val
netty/netty/7617_7627
netty/netty
netty/netty/7617
netty/netty/7627
[ "timestamp(timedelta=15.0, similarity=0.8980620280882211)" ]
b640797de17f1afef26fbae778fad13d6b93767d
d74d3217301f1ad308560a7532f935daca99356a
[ "@hank-whu it should be after 10 seconds maximum if there are no more references: https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/internal/ObjectCleaner.java#L52\r\n\r\nAre you sure there are no more references hold ?", "@normanmaurer why isn't there a break in the loop if the thread is...
[ "never ending loop?", "Yeah this needs to be removed, done..", "@jaymode question... does this also need to be in a privileged block ?", "This is a good question. `Thread#setDaemon` does check permissions by calling `Thread#checkAccess`, but I think it is important to look at what happens there before wrappin...
2018-01-25T13:00:28Z
[ "defect" ]
ObjectCleanerThread not be closed
### Netty version 4.1.20.Final ### JVM version (e.g. `java -version`) 9.0.1 ### OS version (e.g. `uname -a`) Windows 10 Non-finished threads: Thread[DestroyJavaVM,5,main] Thread[ObjectCleanerThread,1,main] at java.base@9.0.1/java.lang.Object.wait(Native Method) at java.base@9.0.1/java.lang.ref.R...
[ "common/src/main/java/io/netty/util/internal/ObjectCleaner.java" ]
[ "common/src/main/java/io/netty/util/internal/ObjectCleaner.java" ]
[ "common/src/test/java/io/netty/util/internal/ObjectCleanerTest.java" ]
diff --git a/common/src/main/java/io/netty/util/internal/ObjectCleaner.java b/common/src/main/java/io/netty/util/internal/ObjectCleaner.java index 96d04439563..991f30d0dc0 100644 --- a/common/src/main/java/io/netty/util/internal/ObjectCleaner.java +++ b/common/src/main/java/io/netty/util/internal/ObjectCleaner.java @@ ...
diff --git a/common/src/test/java/io/netty/util/internal/ObjectCleanerTest.java b/common/src/test/java/io/netty/util/internal/ObjectCleanerTest.java index 0db3e269456..7e755040211 100644 --- a/common/src/test/java/io/netty/util/internal/ObjectCleanerTest.java +++ b/common/src/test/java/io/netty/util/internal/ObjectClea...
train
val
2018-01-25T14:03:35
2018-01-24T10:25:46Z
hank-whu
val
netty/netty/7638_7640
netty/netty
netty/netty/7638
netty/netty/7640
[ "timestamp(timedelta=23188.0, similarity=0.8445211806997002)" ]
bed74d8380c57302c771824548386d7f0cb79629
49d1db4113fb04b1d5001499d6c60fa9d3835aa4
[ "See the discussion in https://github.com/netty/netty/pull/7631 for more details including a possible solution.", "@bryce-anderson thanks a lot! I will fix it :)", "@bryce-anderson PTAL https://github.com/netty/netty/pull/7640", "Fixed" ]
[ "I also think the order of these two needs to be reversed, the following test fails:\r\n```java\r\n@Test\r\n public void channelClosedWhenClosePromiseCompletes() {\r\n LastInboundHandler inboundHandler = streamActiveAndWriteHeaders(inboundStream);\r\n Http2StreamChannel childChannel = (Http2StreamC...
2018-01-26T19:38:34Z
[ "defect" ]
The Http2MultiplexCodec StreamChannel will fire channelInactive without the channel.isOpen method reporting false
### Expected behavior When part of a HTTP/2 `StreamChannel` the `StreamChannel.isOpen()` method should report `false` within a call to a `ChannelInboundHandler`s `channelInactive` method. ### Actual behavior Within the `channelInactive` method, `ctx.channel().isOpen() == true` ### Minimal yet complete repro...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java index aeeec3feb68..4972a044d59 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2MultiplexCodec.java +++ b/codec-http2/src...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java index bec5cd964ee..4778729cd97 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/Http2MultiplexCodecTest.java +++ b/cod...
train
val
2018-01-26T17:33:49
2018-01-26T19:01:40Z
bryce-anderson
val
netty/netty/7644_7645
netty/netty
netty/netty/7644
netty/netty/7645
[ "timestamp(timedelta=14.0, similarity=0.8972325862009453)" ]
614b9e0f25e81052ccd1357c7999d0e74a121663
6ff5c6faefaf47f43ecdf6d1c1051cd55e18141c
[ "Can you provide a pr for a fix ?\n\n> Am 27.01.2018 um 10:08 schrieb kashike <notifications@github.com>:\n> \n> The netty-all artifact doesn't have a Automatic-Module-Name defined in the manifest like the rest of the projects do, resulting in requires netty.all.\n> \n> —\n> You are receiving this because you are s...
[]
2018-01-27T09:49:16Z
[ "defect" ]
netty-all artifact missing automatic-module-name
The `netty-all` artifact doesn't have a `Automatic-Module-Name` defined in the manifest like the rest of the projects do, resulting in `requires netty.all`.
[ "README.md", "all/pom.xml" ]
[ "README.md", "all/pom.xml" ]
[]
diff --git a/README.md b/README.md index d45b41a917f..5c4c4b5afd8 100644 --- a/README.md +++ b/README.md @@ -31,6 +31,7 @@ Netty can be used in modular JDK9 applications as a collection of automatic modu reverse-DNS style, and are derived from subproject names rather than root packages due to historical reasons. They ...
null
train
val
2018-01-27T08:57:17
2018-01-27T09:08:36Z
kashike
val
netty/netty/7588_7646
netty/netty
netty/netty/7588
netty/netty/7646
[ "timestamp(timedelta=21.0, similarity=0.8789671300627859)" ]
1c7125750b7f8205c263f6ec730357742b25d222
c7b776a1d224f84cb7f84afc42f8d7561905bcf6
[ "@ivankelly ups... this most be an oversight... you want to do a PR ?", "Can do, though it would probably be better for the person who originally pulled the harmony code to do so, so that you know what to bubble up. The original change was by @trustin (https://github.com/netty/netty/commit/681d46). From what I ca...
[ "Would be more accurate to put it under a NOTICE: header, but this is fine too.", "Sure. Will update.", "yeah but it's still in the license directory.", "Yeah, but I'm not sure I want to add another top-level directory just for this. Perhaps when we have more of these?" ]
2018-01-29T01:15:44Z
[ "cleanup" ]
Netty NOTICE doesn't cover Apache Harmony's notice
... which is required by the ASLv2. https://www.apache.org/licenses/LICENSE-2.0 (section 4d.)
[ "NOTICE.txt" ]
[ "NOTICE.txt", "license/NOTICE.harmony.txt" ]
[]
diff --git a/NOTICE.txt b/NOTICE.txt index 26b5374398b..f973663670b 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -61,6 +61,8 @@ facade for Java, which can be obtained at: This product contains a modified portion of 'Apache Harmony', an open source Java SE, which can be obtained at: + * NOTICE: + * license/NOTICE...
null
train
val
2018-01-27T20:31:16
2018-01-16T13:02:38Z
ivankelly
val
netty/netty/7660_7661
netty/netty
netty/netty/7660
netty/netty/7661
[ "timestamp(timedelta=12.0, similarity=0.8564761240650354)" ]
69582c0b6c190e57e8365c97aa819ac5e965a5bd
529b2c11eef30d7c7e5191852afcf1b6b2a77712
[ "@teaey we will need some more details etc to be able to fix this. Can you give some more or share some code ?", "@normanmaurer Please see : https://github.com/teaey/netty/commit/1cf24675c9e90d29d799e6184a9da13a2984a0f9\r\n\r\nCan I make a PR for this Issue.", "@teaey looks useful... yeah please open a PR and ...
[ "nit: can you move this to the other final variables.", "add whitespace after `,`", "We need to keep the existing constructor to not break the API. Please just create an extra constructor and delegate to it.", "Explain that `<= 0` will disable this.", "add space after `if`", "\r\n@teaey please reword to:\...
2018-01-31T08:25:32Z
[ "improvement", "feature" ]
io.netty.handler.codec.http.HttpContentCompressor need compress threshold
### Expected behavior the response body is compressed, when the response body exceeds the threshold ### Actual behavior no threshold can be set ### Steps to reproduce - ### Minimal yet complete reproducer code (or URL to code) - ### Netty version 4.1.16.Final ### JVM version (e.g. `java -version`) java 1.8 ...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java index fcf22e011ad..e80469f26e4 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java +++ b/codec-http/src/...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java index c6ff3bd6bc0..6ab2ab88c62 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpContentCompressorTest.java +++ b/cod...
val
val
2018-02-21T13:52:33
2018-01-31T07:17:08Z
teaey
val
netty/netty/7662_7663
netty/netty
netty/netty/7662
netty/netty/7663
[ "timestamp(timedelta=3.0, similarity=0.9536617993150428)" ]
e00f24961adbd1ed0e2189cf5ca9dc16632faa7c
1a2d48ea1255bc562f7732c8a6f4ad1d84e699d1
[ "This would be very nice to have.\r\nI've been using:\r\n`if (pipeline.names.contains(\"someHandler\")`\r\n", "Fixed by https://github.com/netty/netty/pull/7663" ]
[ "@doom369 I think this is not safe as in the meantime it could have been removed from another thread which would have this method throw a `NoSuchElementException`", "@normanmaurer I don't see any place where NoSuchElementException could be thrown in above code.", "ah never mind... this should work... " ]
2018-01-31T12:10:44Z
[]
Proposal: add removeIfExists() method to ChannelPipeline
In some cases, I have to remove the handler from the pipeline that may exist or may not. Current Netty `remove()` implementation always throws `NoSuchElementException` that requires construction like this: ``` try { pipeline.remove(LetsEncryptHandler.class); } catch (NoSuchElementException e) { } ``` thi...
[ "transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java" ]
[ "transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java" ]
[ "transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java" ]
diff --git a/transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java b/transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java index e9d92a13970..0d3307a5351 100644 --- a/transport/src/main/java/io/netty/channel/DefaultChannelPipeline.java +++ b/transport/src/main/java/io/netty/channel/Default...
diff --git a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java b/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java index 6071649b340..7cd51b2999f 100644 --- a/transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java +++ b/transport/src/test/java/io/netty/cha...
train
val
2018-02-16T07:57:43
2018-01-31T11:04:27Z
doom369
val
netty/netty/7673_7677
netty/netty
netty/netty/7673
netty/netty/7677
[ "timestamp(timedelta=0.0, similarity=0.9562389561464967)" ]
fe5c69bdd9d65ddd604a03bfc71081b5bc2ad40a
3f3d309a28f66f463bf7c6ade14e7908019b8aae
[ "@slandelle are you sure this was introduced in 4.1.20 ?", "@normanmaurer This renaming was introduced in 449befa0034e2cf77b3033f62d4f2153cef5a1d7 which is tagged as 4.1.20. ", "My bad, I didn't get what those tags meant in the GH interface. I guess it's from 4.1.13.", "I guess this went unnoticed as `SslUtil...
[ "Shouldn't you fall back to adding the original name here?", "the original name has already been added above on line 97, and is known to be supported because it's returned by `engine.getSupportedCipherSuites()`.", "Oh right" ]
2018-02-01T16:41:52Z
[ "defect" ]
JdkSslContext produces invalid supported ciphers
### Expected behavior JdkSslContext should produce valid ciphers that are actually supported by the platform. Typically, it should be possible to use them in a custom `CipherSuiteFilter` to configure a `SSLEngine`. ### Actual behavior Netty 4.1.13.Final introduced a workaround for IBM certs naming scheme. Th...
[ "handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslContextTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java index e027036146a..41fd9c6f6a8 100644 --- a/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java +++ b/handler/src/main/java/io/netty/handler/ssl/JdkSslContext.java @@ -105...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java b/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java index 76526a5b259..1c0032885ac 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SslContextTest.java @@ ...
test
val
2018-02-01T09:31:07
2018-02-01T10:54:23Z
slandelle
val
netty/netty/7655_7691
netty/netty
netty/netty/7655
netty/netty/7691
[ "timestamp(timedelta=20.0, similarity=0.84721031543362)" ]
1e70d3092d547b1d19f9bf3a4da231701d19de6a
3024b1478203f6772f1f4552ca9918a7f3c4c17d
[ "Would you be interested in a PR that would introduce a System prop that would disable filtering?", "So actually, a way better way to implement this would be to have a `CipherSuiteFilter` that, on contrary to `IdentityCipherSuiteFilter`, falls back to `supportedCiphers` instead of `defaultCiphers` when `ciphers` ...
[]
2018-02-05T11:55:16Z
[ "feature" ]
Provide a way to disable cipher suites filtering
### Expected behavior There should be a way to have client side `SslContext` work against any website, regardless of security. ### Actual behavior Supported ciphers are filtered against a hard coded whitelist (`SslUtils#DEFAULT_CIPHER_SUITES`). I wonder if the whitelist way is a good thing. Wouldn't it filt...
[ "handler/src/main/java/io/netty/handler/ssl/IdentityCipherSuiteFilter.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/IdentityCipherSuiteFilter.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/IdentityCipherSuiteFilterTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/IdentityCipherSuiteFilter.java b/handler/src/main/java/io/netty/handler/ssl/IdentityCipherSuiteFilter.java index c9ebfb0da26..cfd5bb7b2a9 100644 --- a/handler/src/main/java/io/netty/handler/ssl/IdentityCipherSuiteFilter.java +++ b/handler/src/main/java/io/netty/ha...
diff --git a/handler/src/test/java/io/netty/handler/ssl/IdentityCipherSuiteFilterTest.java b/handler/src/test/java/io/netty/handler/ssl/IdentityCipherSuiteFilterTest.java new file mode 100644 index 00000000000..fd2dad8dc83 --- /dev/null +++ b/handler/src/test/java/io/netty/handler/ssl/IdentityCipherSuiteFilterTest.java...
val
val
2018-02-05T09:05:51
2018-01-30T12:37:56Z
slandelle
val
netty/netty/7724_7727
netty/netty
netty/netty/7724
netty/netty/7727
[ "timestamp(timedelta=151.0, similarity=0.953443813712184)" ]
dc3036a20201ef031f231e12cfe30d622779a0a1
268b901844c620337bc11ae82e99163a1781b96c
[ "@jianglai thanks I will check.", "@jianglai should be fixed by https://github.com/netty/netty/pull/7727.", "Thanks for the quick turnaround!", "@jianglai no problem... would be nice if you can verify the fix", "fixed by #7727", "Confirmed that with 4.1.22.Final-SNAPSHOT, the demo code works as intended.\...
[]
2018-02-16T08:06:33Z
[ "defect" ]
SSL connection not closed properly after handshake failure in v4.1.21
### Expected behavior When SSL handshake fails, the connection is closed. ### Actual behavior Even though the SSL engine is closed, the connection itself is not closed. ### Steps to reproduce See below. ### Minimal yet complete reproducer code (or URL to code) Run the demo code [here](https://github.com/ji...
[ "handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java", "handler/src/main/java/io/netty/handler/ssl/SslHandler.java", "handler/src/main/java/io/netty/handler/ssl/SslUtils.java" ]
[ "handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java", "handler/src/main/java/io/netty/handler/ssl/SslHandler.java", "handler/src/main/java/io/netty/handler/ssl/SslUtils.java" ]
[ "handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java" ]
diff --git a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java b/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java index ecbf8263c18..05fcaffdfc3 100644 --- a/handler/src/main/java/io/netty/handler/ssl/AbstractSniHandler.java +++ b/handler/src/main/java/io/netty/handler/ssl/AbstractSni...
diff --git a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java index 5366de289f7..f3c31ed6dd4 100644 --- a/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java +++ b/handler/src/test/java/io/netty/handler/ssl/SslHandlerTest.java @@ ...
train
val
2018-02-16T09:18:22
2018-02-16T00:48:14Z
jianglai
val
netty/netty/7729_7730
netty/netty
netty/netty/7729
netty/netty/7730
[ "keyword_pr_to_issue" ]
1e5fafe44651e1e246a9a041cfbb453582e05491
ce241bd11ec26008a692b87391b94d8efe69069d
[ "Have the same issue. For now I fixed it with Increasing chunk size from 8k to 128k. In my case file is 4Mb only. It is reproduced only on specific VM.", "thanks for reporting. I have some questions...\r\n\r\n- Are you using `FileRegion` or do you cache the file in memory and write `ByteBuf`s (sounds like `ByteBu...
[ "@Scottmitch seems like the code is now basically the same as before here... Consider revert the change of the file ? Seems like the only change that is \"new\" is the final keyword", "consider reverting this as the code basically does the same as before.", "yes it is the same as before ... just 1 less LOC and ...
2018-02-18T22:12:38Z
[ "defect" ]
Downloading large file halts during transfer
### Expected behavior When downloading a large file (50MB) from a netty based server, I expect to receive the entire file and that the download does not halt during the transfer. ### Actual behavior Download of file halts during the transfer. Transfer eventually terminates due to idle timeout. ### Steps to rep...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueChannel.java", "transport-native-kqueue/src/main/...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollStreamChannel.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueChannel.java", "transport-native-kqueue/src/main/...
[ "testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketConditionalWritabilityTest.java", "transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollETSocketConditionalWritabilityTest.java", "transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollLTSocketConditionalWritabilityTest.ja...
diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java index 758052db70b..8d3dc5bbcbd 100644 --- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java +++...
diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketConditionalWritabilityTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketConditionalWritabilityTest.java new file mode 100644 index 00000000000..d5265a1a4c5 --- /dev/null +++ b/testsuite/src/main/java/io/netty/test...
train
val
2018-02-17T07:47:44
2018-02-18T08:35:07Z
blucas
val
netty/netty/7760_7765
netty/netty
netty/netty/7760
netty/netty/7765
[ "timestamp(timedelta=0.0, similarity=0.90353806799172)" ]
0a8e1aaf19dc85830478041cb57b308b764cfacd
48df2f66b858f3ce2a0a069dafb1332da55c47f9
[ "@ivankelly this sounds clearly like a bug... Let me check as soon as I have a few cycles or if you like you could also try to provide a PR .", "@normanmaurer I had a quick look. The logic looks sound. If I get more time, I'll look again. It's going to be something to do with something being added to turn it nega...
[ "@normanmaurer what about the case when someone intentionally passes a negative value into delay?", "@johnou hmm good question. I am not sure this is expected but let me add a check as it was \"allowed\" before." ]
2018-03-02T09:02:20Z
[ "defect" ]
HashedWheelTimer doesn't handle very large values
### Expected behavior If I set a timeout with Long.MAX_VALUE (effectively trying to disable it), it should never run. ### Actual behavior It runs. It runs a lot. ### Steps to reproduce ``` @Test public void testMassiveTimeout() throws InterruptedException { final Timer timer = new HashedWhee...
[ "common/src/main/java/io/netty/util/HashedWheelTimer.java" ]
[ "common/src/main/java/io/netty/util/HashedWheelTimer.java" ]
[ "common/src/test/java/io/netty/util/HashedWheelTimerTest.java" ]
diff --git a/common/src/main/java/io/netty/util/HashedWheelTimer.java b/common/src/main/java/io/netty/util/HashedWheelTimer.java index 77d956b12bb..b62ace4695e 100644 --- a/common/src/main/java/io/netty/util/HashedWheelTimer.java +++ b/common/src/main/java/io/netty/util/HashedWheelTimer.java @@ -419,6 +419,11 @@ public...
diff --git a/common/src/test/java/io/netty/util/HashedWheelTimerTest.java b/common/src/test/java/io/netty/util/HashedWheelTimerTest.java index e1a7bccc6ef..2bf1c34819e 100644 --- a/common/src/test/java/io/netty/util/HashedWheelTimerTest.java +++ b/common/src/test/java/io/netty/util/HashedWheelTimerTest.java @@ -230,6 +...
train
val
2018-03-02T02:09:40
2018-03-01T14:47:30Z
ivankelly
val
netty/netty/7752_7774
netty/netty
netty/netty/7752
netty/netty/7774
[ "timestamp(timedelta=14.0, similarity=0.8586944922579707)" ]
6eb9674bf5ded128cb230a31987f14816b7f1886
f6251c8256d8ce3fb6fb76df23e477caa15f627b
[ "@ldaley sorry took me a while due travelling / meetings etc.\r\n\r\nhttps://github.com/netty/netty/pull/7773\r\n", "@normanmaurer no problem sir. Appreciated all the same.", "And https://github.com/netty/netty/pull/7774", "Fixed" ]
[]
2018-03-10T09:28:42Z
[]
IovArray.add(ByteBuf) throws if buffer is a composite of a single direct buffer
### Expected behavior Not throwing unhandled `UnsupportedOperationException`. ### Actual behavior Method throws unhandled `UnsupportedOperationException` which causes channel write operations to fail. ### Steps to reproduce The problem is here: https://github.com/netty/netty/blob/4.1/transport-native-uni...
[ "transport-native-unix-common/src/main/java/io/netty/channel/unix/IovArray.java" ]
[ "transport-native-unix-common/src/main/java/io/netty/channel/unix/IovArray.java" ]
[]
diff --git a/transport-native-unix-common/src/main/java/io/netty/channel/unix/IovArray.java b/transport-native-unix-common/src/main/java/io/netty/channel/unix/IovArray.java index 3e0946e255e..151abe609ae 100644 --- a/transport-native-unix-common/src/main/java/io/netty/channel/unix/IovArray.java +++ b/transport-native-u...
null
train
val
2018-03-10T03:45:02
2018-02-27T01:04:22Z
ldaley
val
netty/netty/7781_7782
netty/netty
netty/netty/7781
netty/netty/7782
[ "timestamp(timedelta=0.0, similarity=0.8447407530444115)" ]
f6251c8256d8ce3fb6fb76df23e477caa15f627b
de082bf4c719f177cb068e01511bc1c69bde4cbf
[ "Will have a look", "@trustin please check the PR." ]
[]
2018-03-15T10:23:10Z
[ "defect" ]
ResourceLeakDetector does not retain the initial record
### Expected behavior The leak report printed by `ResourceLeakDetector` retains the stack trace of the moment the buffer was created. ### Actual behavior The record with `Created at:` heading is not actually the creation record, e.g. ``` Created at: io.netty.buffer.AdvancedLeakAwareByteBuf.writeBytes(...
[ "common/src/main/java/io/netty/util/ResourceLeakDetector.java" ]
[ "common/src/main/java/io/netty/util/ResourceLeakDetector.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/ResourceLeakDetector.java b/common/src/main/java/io/netty/util/ResourceLeakDetector.java index 3872c07d1cc..c29320adb7d 100644 --- a/common/src/main/java/io/netty/util/ResourceLeakDetector.java +++ b/common/src/main/java/io/netty/util/ResourceLeakDetector.java @@ -369,7 +...
null
val
val
2018-03-13T08:51:01
2018-03-15T05:59:37Z
trustin
val
netty/netty/7749_7793
netty/netty
netty/netty/7749
netty/netty/7793
[ "timestamp(timedelta=35.0, similarity=0.9344906068123431)" ]
8189399e9d6a2e17e8d5b4665c86efb696792f56
c0ae5e697c3c4fdf81f0cfc199d18aacd3b8ecba
[ "Fixed by https://github.com/netty/netty/pull/7793" ]
[ "- build -> build a\r\n- DnsNameResolver -> DnsNameResolver. (dot)", "@trustin 🤔shoud other 2 `IllegalStateException` be updated with a trailing dot? ", "This won't work. If someone makes a DnsNameResolverBuilder and then calls build, and then subsequently modifies the builder, the channelFactory of DnsAddre...
2018-03-19T09:00:26Z
[]
Proposal: DnsAddressResolverGroup to use injectable DnsNameResolverBuilder
### Expected behavior It should be possible to create `DnsAddressResolverGroup` having `DnsNameResolverBuilder` ready-to-go. ### Actual behavior Right now, if I want setup custom settings for `DnsAddressResolver` I need to sub-class `DnsAddressResolverGroup` and override `newNameResolver` [method](https://gith...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/RoundRobinDnsAddressResolverGroup.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverBuilder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/RoundRobinDnsAddressResolverGroup.java" ]
[ "resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java" ]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java index fb306082320..303c42a0988 100644 --- a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolverGroup.java +++ b/resolver-dns/src/main...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java index 805121c7304..b2f5c3a9ee5 100644 --- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java +++ b/resolver-dns/src/test/java/io/net...
train
val
2018-03-23T07:39:17
2018-02-26T12:00:12Z
kachayev
val
netty/netty/7785_7800
netty/netty
netty/netty/7785
netty/netty/7800
[ "timestamp(timedelta=0.0, similarity=0.9347780009242861)" ]
6e6cfa0604aa578b52ed5d72ac954f040fadffa3
76c5f6cd03c7c57fab823d3b0774b56c3ed97fc3
[ "@gustavonalle PRs welcome", "Working on it" ]
[]
2018-03-20T16:19:30Z
[]
Enable different Cors rules per origin
### Expected behavior It'd be nice to configure the CorsHandler so that I can specify a different set of permissions based on the Origin. Example, if origin is http://localhost:8080/ I'd like to allow all methods and auth, but for a certain external Url I'd like to be stricter and limit it for GET only. ### A...
[ "codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java", "common/src/main/java/io/netty/util/internal/ObjectUtil.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java", "common/src/main/java/io/netty/util/internal/ObjectUtil.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java index f4b5552b724..1c27863d5dc 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java +++ b/codec-http/src/main/java/io/ne...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java index f3fe97efd01..884c368796b 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/cors/CorsHandlerTest.java +++ b/codec-http/src/tes...
train
val
2018-03-20T15:59:08
2018-03-16T17:10:44Z
gustavocoding
val
netty/netty/7255_7801
netty/netty
netty/netty/7255
netty/netty/7801
[ "timestamp(timedelta=3404.0, similarity=0.850000755448666)" ]
6e6cfa0604aa578b52ed5d72ac954f040fadffa3
ed0668384b393c3502c2136e3cc412a5c8c9056e
[ "Thank you for fast response. It will fix issue for non-autoread channels (original issue), but after looking at affected code I'm afraid that channels with `AUTO_READ` can be hurt with this wakeups.", "@khitrin so you are saying it is not fixed with the PR ?", "I've built netty with the PR and can confirm that...
[ "Replace `DefaultSocketChannelConfig` with `SocketChannelConfig`. After this its ready to be merged :)" ]
2018-03-21T19:26:46Z
[ "defect" ]
A lot of ChannelInputShutdownReadComplete events fired for NIO channel with ALLOW_HALF_CLOSURE
### Expected behavior Single `ChannelInputShutdownReadComplete` event will be fired for closed socket. ### Actual behavior `ChannelInputShutdownReadComplete` event fired on each NIO event loop run. `NioEventLoop` begin consuming a lot of CPU. ### Steps to reproduce Create upstream connection channel with enab...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueChannel.java", "transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java", "transport/src/main/java/io/netty/channel/oio/Abstrac...
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java", "transport-native-kqueue/src/main/java/io/netty/channel/kqueue/AbstractKQueueChannel.java", "transport/src/main/java/io/netty/channel/nio/AbstractNioByteChannel.java", "transport/src/main/java/io/netty/channel/oio/Abstrac...
[ "testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java" ]
diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java index 8d3dc5bbcbd..c1af9975cd2 100644 --- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/AbstractEpollChannel.java +++...
diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java index b5600d4252c..40b5e86ff73 100644 --- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/SocketHalfClosedTest.java +++...
train
val
2018-03-20T15:59:08
2017-09-27T18:16:16Z
khitrin
val
netty/netty/7795_7803
netty/netty
netty/netty/7795
netty/netty/7803
[ "keyword_pr_to_issue" ]
5ebee9426f05b0c9287bf8c0e27e9e37e1d96c66
cd4594d29244f7bea9d718e74ec4ecdcb6c62c13
[ "and does it sound good? :-)", "I'll start to work on this if there's no objection." ]
[ "javadocs please", "revert ?", "...that are...", "...that are...", "...that are...", "Added Javadocs for `DnsAddressDecoder`", "Oops! Reverted.", "Fixed all :-)", "can we use `NetUtil.IPV6_BYTE_COUNT` here instead of duplicating the definition?", "`gotResult` -> `containsExpectedResultType`?", "...
2018-03-22T14:01:59Z
[ "feature" ]
Expose DnsNameResolverContext (or something equivalent to it) to users
A user may want to reuse the logic related with search list enumeration, retries and error handling in his or her resolver implementations. For example, a user could extend or customize `DnsNameResolverContext` to implement DNS-based service discovery that retrieves [SRV records](https://en.wikipedia.org/wiki/SRV_recor...
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolverContext.java" ]
[ "resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressDecoder.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressResolveContext.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java", "resolver-dns/src/main/java/io/netty/resolver/dns/DnsRecordResolveContext.java",...
[ "resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java" ]
diff --git a/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressDecoder.java b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressDecoder.java new file mode 100644 index 00000000000..3dfb56ae8cc --- /dev/null +++ b/resolver-dns/src/main/java/io/netty/resolver/dns/DnsAddressDecoder.java @@ -0,0 +1,67 @@ ...
diff --git a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java b/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java index 805121c7304..c0fdf83b945 100644 --- a/resolver-dns/src/test/java/io/netty/resolver/dns/DnsNameResolverTest.java +++ b/resolver-dns/src/test/java/io/net...
train
val
2018-03-27T19:09:54
2018-03-19T09:32:53Z
trustin
val
netty/netty/7790_7806
netty/netty
netty/netty/7790
netty/netty/7806
[ "keyword_issue_to_pr" ]
8189399e9d6a2e17e8d5b4665c86efb696792f56
fc3b145cbbcad4a257f92f0640eb4ded19b44afe
[ "Thats interesting... @carl-mastrangelo @ejona86 maybe you have some contacts we can loop in ? Generally speaking I think this should not happen as it woke-up the selector without reporting any events that need to be handled.", "CC @ericgribkoff", "This is reproducible on Android 8 for me as well. `selector.sel...
[]
2018-03-23T07:11:05Z
[]
Infinite Selector rebuild loop of death.
I'm experiencing an issue that has been reported about before. None of the reports are giving me any hints though. (e.g. #2426 and #2616) The problem: I'm starting a Websocket server with ServerBootstrap bound to the wifi IP address on Android. As soon the wifi connection changes or wifi is disabled completely, the ...
[ "transport/src/main/java/io/netty/channel/nio/AbstractNioMessageChannel.java", "transport/src/main/java/io/netty/channel/socket/nio/NioServerSocketChannel.java" ]
[ "transport/src/main/java/io/netty/channel/nio/AbstractNioMessageChannel.java", "transport/src/main/java/io/netty/channel/socket/nio/NioServerSocketChannel.java" ]
[ "transport/src/test/java/io/netty/channel/socket/nio/NioServerSocketChannelTest.java" ]
diff --git a/transport/src/main/java/io/netty/channel/nio/AbstractNioMessageChannel.java b/transport/src/main/java/io/netty/channel/nio/AbstractNioMessageChannel.java index 3d05a461841..57dcc85e584 100644 --- a/transport/src/main/java/io/netty/channel/nio/AbstractNioMessageChannel.java +++ b/transport/src/main/java/io/...
diff --git a/transport/src/test/java/io/netty/channel/socket/nio/NioServerSocketChannelTest.java b/transport/src/test/java/io/netty/channel/socket/nio/NioServerSocketChannelTest.java new file mode 100644 index 00000000000..80779902f76 --- /dev/null +++ b/transport/src/test/java/io/netty/channel/socket/nio/NioServerSock...
train
val
2018-03-23T07:39:17
2018-03-17T17:47:18Z
jox
val
netty/netty/7804_7813
netty/netty
netty/netty/7804
netty/netty/7813
[ "keyword_pr_to_issue" ]
5ebee9426f05b0c9287bf8c0e27e9e37e1d96c66
965734a1eb1f2553985094ade9f28871016f652b
[ "You are right...\nWant to do a pr?\n\n> Am 22.03.2018 um 17:58 schrieb Fabian Lange <notifications@github.com>:\n> \n> (running io.netty.buffer:4.1.21.Final)\n> \n> I have a Java Output stream (java.io.OutputStream) I want to incrementally copy a ByteBuffer too.\n> \n> The byte buffer is off heap and big.\n> I nai...
[ "changes -> chances", "How about:\r\n- addr -> inAddr\r\n- array -> in\r\n- offset -> inOffset\r\n- chunkLen -> inLen\r\n- length -> outLen", "Can we just do: `Math.min(Math.min(length, ByteBufUtil.WRITE_CHUNK_SIZE), length)`? This would eliminate the reason to pass 2 length parameters to the `getBytes()` below...
2018-03-28T09:35:40Z
[]
Transferring a ByteBuf to Outputstream without duplicating memory
(running io.netty.buffer:4.1.21.Final) I have a Java Output stream (java.io.OutputStream) I want to incrementally copy a ByteBuffer too. The byte buffer is off heap and big. I naively used: public abstract ByteBuf getBytes(int index, OutputStream out, int length) throws IOException; assuming that it woul...
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "buffer/src/main/java/io/netty/buffer/PooledDirectByteBuf.java", "buffer/src/main/java/io/netty/buffer/UnpooledDirectByteBuf.java", "buffer/src/main/java/io/netty/buffer/UnsafeByteBufUtil.java" ]
[ "buffer/src/main/java/io/netty/buffer/ByteBufUtil.java", "buffer/src/main/java/io/netty/buffer/PooledDirectByteBuf.java", "buffer/src/main/java/io/netty/buffer/UnpooledDirectByteBuf.java", "buffer/src/main/java/io/netty/buffer/UnsafeByteBufUtil.java" ]
[]
diff --git a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java index b0ecb35cace..768f5587146 100644 --- a/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java +++ b/buffer/src/main/java/io/netty/buffer/ByteBufUtil.java @@ -27,6 +27,8 @@ import io.netty.util...
null
val
val
2018-03-27T19:09:54
2018-03-22T16:58:51Z
CodingFabian
val
netty/netty/7820_7821
netty/netty
netty/netty/7820
netty/netty/7821
[ "keyword_pr_to_issue", "timestamp(timedelta=0.0, similarity=0.9128726367498636)" ]
cd4594d29244f7bea9d718e74ec4ecdcb6c62c13
c58069f2849837aaaaa13aa4cb00b83c32966623
[]
[]
2018-03-30T13:46:35Z
[ "defect" ]
JsonObjectDecoder to better handle streaming data
### Description There seems to be a long running issue with several iterations of fixes for streaming of different types of JSON data: - The [6156](https://github.com/netty/netty/issues/6156) was the original issue which made the internal index reset together with resetting the decoder state, but it did not cover the...
[ "codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java" ]
[ "codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java" ]
[ "codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java" ]
diff --git a/codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java b/codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java index 123618b1437..f63e62066ee 100644 --- a/codec/src/main/java/io/netty/handler/codec/json/JsonObjectDecoder.java +++ b/codec/src/main/java/io/netty/handler/codec...
diff --git a/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java index 12eb13ac19c..d29654f2491 100644 --- a/codec/src/test/java/io/netty/handler/codec/json/JsonObjectDecoderTest.java +++ b/codec/src/test/java/io/netty/h...
train
val
2018-03-29T22:01:25
2018-03-30T13:18:38Z
ikurovsky
val
netty/netty/7819_7822
netty/netty
netty/netty/7819
netty/netty/7822
[ "timestamp(timedelta=0.0, similarity=0.8806146228979717)", "keyword_pr_to_issue" ]
cd4594d29244f7bea9d718e74ec4ecdcb6c62c13
8d78893a76a8c14c18b304ffe1fce2dc43ed4206
[ "Yes this sounds good.... can you provide a PR?\n\n> Am 30.03.2018 um 14:24 schrieb Nicolae Mihalache <notifications@github.com>:\n> \n> Hello,\n> \n> I get an exception \"promise already done\" apparently caused by the ChunkedWriteHandler which is called twice for the same message, one from my flush and the other ...
[]
2018-03-30T13:54:55Z
[ "defect" ]
promise already done caused by ChunkedWriteHandler writing the same (non chunked) message twice
Hello, I get an exception "promise already done" apparently caused by the ChunkedWriteHandler which is called twice for the same message, one from my flush and the other time from the channelWritabilityChanged. Not sure if the ChunkedWriteHandler.doFlush method is supposed to be called twice in the same write but...
[ "handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java" ]
[ "handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java" ]
[]
diff --git a/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java b/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java index 1bc0c6bf81d..6f753c5c510 100644 --- a/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java +++ b/handler/src/main/java/io/netty/handler/str...
null
val
val
2018-03-29T22:01:25
2018-03-30T12:24:31Z
xpromache
val
netty/netty/7823_7824
netty/netty
netty/netty/7823
netty/netty/7824
[ "keyword_pr_to_issue", "timestamp(timedelta=0.0, similarity=0.8734165948490467)" ]
8d78893a76a8c14c18b304ffe1fce2dc43ed4206
741602050fbfe555492987b553c6e7023f0e50a1
[ "The problem is pretty simple, it is that we're using `.set(CONNECTION, value)` [here](https://github.com/netty/netty/blob/4.1/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java#L280) where we should probably be using `.add(CONNECTION, value)`.\r\n\r\nI'll open a PR, and if it turns ...
[ "You need to release this one", "Also call channel.finish() and assert the return value" ]
2018-03-30T20:35:47Z
[ "defect" ]
HttpClientUpgradeHandler may clobber existing connection headers
### Expected behavior `Connection` headers on a request that goes through the `HttpClientUpgradeHandler` should be preserved. ### Actual behavior They are clobbered by the `Connection: Upgrade` header. ### Minimal yet complete reproducer code (or URL to code) Test case for `HttpClientUpgradeHandlerTest`: ```j...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java index 235dbb1b5d8..bf2cd5529ac 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpClientUpgradeHandler.java +++ b/codec-...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java index e342ef73e28..a90ee575dd9 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpClientUpgradeHandlerTest.java ...
val
val
2018-03-30T19:32:08
2018-03-30T20:23:19Z
bryce-anderson
val
netty/netty/7829_7834
netty/netty
netty/netty/7829
netty/netty/7834
[ "keyword_pr_to_issue" ]
b02ee1106f81a97334c076e5510d7f90d4f4e224
1fa7a5e697825bdd2f5ad7885b64749ede5c3192
[ "@carl-mastrangelo \r\n> I had assumed the periodic wakeup was some sort of safety net when I saw it. If the intent was to periodically check the scheduledTasks, then yeah, wakeup should probably be the correct mechanism, even if it results in timerfd_settime calls. Arguably there are already a ton of timerfd_setti...
[ "Can't we just use `Delayed` ?\r\n\r\nhttps://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Delayed.html", "revert", "This should have a `throws` as it may throw a `ClosedChannelException`", "Just use an `AtomicBoolean` as we use it as a boolean.", "We want to get the `deadline`, not the `delay`.",...
2018-04-03T03:02:40Z
[ "improvement" ]
Improve Timer Wakeup for Native Transports
from https://github.com/netty/netty/pull/7816#discussion_r178171275 This topic comes up in frequently enough that I usually forget the answer .... "why do we need to have a max wakeup time of 1 second instead of unbounded" for the EventLoop implementations. IIRC the answer is when we schedule tasks we don't check if...
[ "common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java", "common/src/main/java/io/netty/util/concurrent/ScheduledFutureTask.java", "common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java", "transport-native-epoll/src/main/c/netty_epoll_native.c", "transport-...
[ "common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java", "common/src/main/java/io/netty/util/concurrent/ScheduledFutureTask.java", "common/src/main/java/io/netty/util/concurrent/SingleThreadEventExecutor.java", "transport-native-epoll/src/main/c/netty_epoll_native.c", "transport-...
[]
diff --git a/common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java b/common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java index 41430c708c3..6b52151dbfa 100644 --- a/common/src/main/java/io/netty/util/concurrent/AbstractScheduledEventExecutor.java +++ b/common/sr...
diff --git a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollTest.java b/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollTest.java deleted file mode 100644 index 5a9cb19a1ff..00000000000 --- a/transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollTest.java +++ /dev/null @@ -...
test
val
2019-07-10T12:19:15
2018-03-31T18:08:22Z
Scottmitch
val
netty/netty/7837_7839
netty/netty
netty/netty/7837
netty/netty/7839
[ "timestamp(timedelta=0.0, similarity=0.8714330086052116)" ]
473f6a6edb8353728ea8e711ac8241ddc21adf08
ee9057ad99b9cc95140ee3e56265f32b6a28d709
[ "@amizurov its a bug :(\r\n \r\nFixed https://github.com/netty/netty/pull/7839", "@normanmaurer Thanks a lot, It's really quickly as well as Netty :)" ]
[]
2018-04-03T16:42:40Z
[]
CorsHandler do writeAndFlush in override ChannelHandlerContext#write method
Do not really understand, why in `CorsHandler` invoked writeAndFlash ? It's strange side effect. ### Actual behavior https://github.com/netty/netty/blob/473f6a6edb8353728ea8e711ac8241ddc21adf08/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java#L198-L209 ### Steps to reproduce Add `CorsHan...
[ "codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java" ]
[]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java index f4b5552b724..9e7756521e9 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/cors/CorsHandler.java +++ b/codec-http/src/main/java/io/ne...
null
train
val
2018-04-02T21:37:03
2018-04-03T13:07:47Z
amizurov
val
netty/netty/7847_7848
netty/netty
netty/netty/7847
netty/netty/7848
[ "timestamp(timedelta=0.0, similarity=0.91396344380582)" ]
f8ff834f037e51b7119630bdb7713a29c18b8e31
f9604eeff5019219ea2895556309735bb27077fe
[]
[]
2018-04-05T22:29:51Z
[]
Http2ConnectionHandler doesn't set the correct header state for streams generated from upgrades
### Expected behavior When stream 1 is created from a h2c upgrade, the resultant stream should signal that it has sent the headers for the client, and that it has received the headers for the server. ### Actual behavior The stream state doesn't acknowledge that the request headers have been sent/received. #...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Stream.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/Http2Stream.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java index 12815c225c8..42513174572 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2Connection.java +++ b/codec-...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java index 966f668b405..ef385beed64 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/DefaultHttp2ConnectionTest.java ...
train
val
2018-04-10T10:41:50
2018-04-05T22:21:34Z
bryce-anderson
val
netty/netty/7825_7853
netty/netty
netty/netty/7825
netty/netty/7853
[ "timestamp(timedelta=34682.0, similarity=0.8800222931639644)", "keyword_pr_to_issue" ]
587afddb279bea3fd0f64d3421de8e69a35cecb9
a4146b706c0a0577f9ce65d711ad64a6847e3e24
[ "Looks like I can call `defaultHttp2HeadersEncoder.maxHeaderListSize(MAX_HEADER_LIST_SIZE)` to workaround this. If done immediately on creation, it looks like it won't collide with any received SETTINGS requesting a lower value.", "I've created a demo of this bug here: https://github.com/JLofgren/demo-grpc-java-b...
[ "if you look at the comments for `DEFAULT_HEADER_LIST_SIZE` it describes that although the value is arbitrary it is not un-intentional, and technically not in violation of the spec. Having unlimited header size may leave the server exposed to memory exhaustion before it has the chance to communicate a lower limit. ...
2018-04-06T18:59:15Z
[ "defect" ]
HpackEncoder limits header list size to 8K by default
### Expected behavior Sending a header list of arbitrary size would succeed, except when the receiver prohibits header list larger than a certain size. RFC7540 defines SETTINGS_MAX_HEADER_LIST_SIZE's initial value to be unlimited. ### Actual behavior If the receiver does not specify a maximum header list size i...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java index b9a7703042f..7719072a499 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/HpackEncoder.java +++ b/codec-http2/src/main/java/io/netty/h...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java index 2996b5db6b3..b1dce05c38b 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java +++ b/codec-http2/src/test/jav...
train
val
2018-04-05T19:44:08
2018-03-30T23:52:20Z
ejona86
val
netty/netty/7863_7864
netty/netty
netty/netty/7863
netty/netty/7864
[ "timestamp(timedelta=4113.0, similarity=0.9010866880266841)" ]
401b196623b9a2cadaf6ef8a67f2de2d360e8fe3
5891257ca0f09e41b894496bd0e2fc6843d93ec9
[ "@Stefan-Weber yes thanks... working on a patch" ]
[ "I think it will be more correct:\r\n```java\r\nfinal int len = offset + length - subCount;\r\n```\r\nthat is, do not add the `start` to the `len`.", "Agreed. There is also a bounds checking issue with the lastIndexOf below. See PR https://github.com/netty/netty/pull/7866", "sounds good ... let me close this on...
2018-04-12T13:44:37Z
[ "defect" ]
ArrayIndexOutOfBoundsException in AsciiString().indexOf()
### Actual behavior Calling the method indexOf() in a special case throws ArrayIndexOutOfBoundsException. java.lang.ArrayIndexOutOfBoundsException: 6 at io.netty.util.AsciiString.indexOf(AsciiString.java:693) at ByteBufsTests.indexOfSuccess(ByteBufsTests.java:46) at sun.reflect.NativeMethodAccessorImpl.invoke...
[ "common/src/main/java/io/netty/util/AsciiString.java" ]
[ "common/src/main/java/io/netty/util/AsciiString.java" ]
[ "common/src/test/java/io/netty/util/AsciiStringCharacterTest.java" ]
diff --git a/common/src/main/java/io/netty/util/AsciiString.java b/common/src/main/java/io/netty/util/AsciiString.java index 17ef64f3287..621db211e52 100644 --- a/common/src/main/java/io/netty/util/AsciiString.java +++ b/common/src/main/java/io/netty/util/AsciiString.java @@ -689,7 +689,7 @@ public int indexOf(CharSequ...
diff --git a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java b/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java index 60686f18a8c..e80f4424dfb 100644 --- a/common/src/test/java/io/netty/util/AsciiStringCharacterTest.java +++ b/common/src/test/java/io/netty/util/AsciiStringCharacterTest....
train
val
2018-04-11T14:36:56
2018-04-12T11:03:40Z
Stefan-Weber
val
netty/netty/7871_7872
netty/netty
netty/netty/7871
netty/netty/7872
[ "timestamp(timedelta=0.0, similarity=0.9472928157236656)" ]
81a7d1413bd36fc42be5ef3e67a55b0c56a2672f
0b690a991fb86903188e769763225ce9f3099b4c
[ "@kubuzetto PRs welcome", "Fixed via https://github.com/netty/netty/pull/7872" ]
[ "revert", "revert?", "Yes please revert this change ... ", "Do you mean the entire PR? Why?", "No just the one line change above the comment" ]
2018-04-16T15:14:27Z
[]
Add support for IP_TRANSPARENT socket option for UDP connections
Push request at #6835 does not include 'transparent proxy' mode for UDP. setOption() function in EpollDatagramChannelConfig should include IP_TRANSPARENT option.
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java" ]
[ "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java" ]
[]
diff --git a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java b/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannelConfig.java index ddb206551df..0f8e86ec1d9 100644 --- a/transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChan...
null
val
val
2018-04-16T12:11:42
2018-04-16T06:05:07Z
kubuzetto
val
netty/netty/7877_7878
netty/netty
netty/netty/7877
netty/netty/7878
[ "timestamp(timedelta=0.0, similarity=0.9048913290150462)" ]
0b690a991fb86903188e769763225ce9f3099b4c
3ec29455af9642f6b20d7a309d3b6fb19c49b819
[ "@syermakov OMG... looking. Thanks for reporting", "Fixed by https://github.com/netty/netty/pull/7878" ]
[]
2018-04-19T06:27:59Z
[ "defect" ]
Eternal loop in Recycler.WeakOrderQueue.Head#run() that blocks ObjectCleaner thread and causes OOM.
Hi, looks like in commit 6eb9674bf5ded128cb230a31987f14816b7f1886 there is a problem that causes an eternal loop in `Recycler.WeakOrderQueue.Head#run()`: ``` public void run() { Link head = link; while (head != null) { reclaimSpace(LINK_CAPACITY); ...
[ "common/src/main/java/io/netty/util/Recycler.java" ]
[ "common/src/main/java/io/netty/util/Recycler.java" ]
[]
diff --git a/common/src/main/java/io/netty/util/Recycler.java b/common/src/main/java/io/netty/util/Recycler.java index fde88782218..e84adc5a9a6 100644 --- a/common/src/main/java/io/netty/util/Recycler.java +++ b/common/src/main/java/io/netty/util/Recycler.java @@ -261,7 +261,7 @@ public void run() { Li...
null
val
val
2018-04-17T09:07:02
2018-04-19T00:11:30Z
syermakov
val
netty/netty/4950_7879
netty/netty
netty/netty/4950
netty/netty/7879
[ "timestamp(timedelta=0.0, similarity=0.881571595310132)" ]
b75f44db9a0d5255815bff076fe54dec72176ca5
b818852cdb0ee56ce3cf939e2faa538d519baabd
[ "Will check...\n", "Looks like netty cannot get the udp destination address. See:\n\nhttp://developerweb.net/viewtopic.php?id=4342\nhttp://developerweb.net/viewtopic.php?id=4169\n", "Thanks Windie for your comments. I think I have a better understanding of the problem now. IP_PKTINFO socket option should be set...
[ "final" ]
2018-04-19T13:54:46Z
[]
DatagramPacket.recipient() doesn't return the actual destination IP, but the IP the app is bound to
I'm using epoll (on previous versions of my app I was using NIO and I think the behaviour is the same) on an application that is listening on all available interfaces (0.0.0.0). When I try to get the actual UDP packet destination IP, DatagramPacket.recipient() returns 0.0.0.0 and not the real packet destination IP. It ...
[ "transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatag...
[ "transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollChannelOption.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatagramChannel.java", "transport-native-epoll/src/main/java/io/netty/channel/epoll/EpollDatag...
[ "testsuite/src/main/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java", "transport-native-epoll/src/test/java/io/netty/channel/epoll/EpollDatagramUnicastTest.java" ]
diff --git a/transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c b/transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c index 562eaa0b537..d6e3ead94fe 100644 --- a/transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c +++ b/transport-native-epoll/src/main/c/netty_epoll_linuxsocket.c @@ -107,6 +107,...
diff --git a/testsuite/src/main/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java b/testsuite/src/main/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java index 26743ba8c70..b49f6780ef5 100644 --- a/testsuite/src/main/java/io/netty/testsuite/transport/socket/DatagramUnicastTest.java +++ b/...
train
val
2018-04-19T13:56:07
2016-03-07T13:57:03Z
mpolonio
val
netty/netty/7880_7885
netty/netty
netty/netty/7880
netty/netty/7885
[ "timestamp(timedelta=0.0, similarity=0.8924957798753058)" ]
1b1f7677acec6a5ae06a552adc4c046b2ce2490d
f4d7e8de140048047299808bb7e707c15342b826
[ "@normanmaurer do you mean MAX_MESSAGES_PER_READ in netty-5.0.0.Alpha ?", "Ups yes https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/ChannelOption.java#L83" ]
[]
2018-04-23T13:16:38Z
[ "defect" ]
LocalChannel / LocalServerChannel not respect ChannelOption. MAX_MESSAGES_PER_READ
LocalChannel / LocalServerChannel not respect ChannelOption.MAX_MESSAGES_PER_READ and just keeps processing messages until there are no more present.
[ "transport/src/main/java/io/netty/channel/local/LocalChannel.java", "transport/src/main/java/io/netty/channel/local/LocalServerChannel.java" ]
[ "transport/src/main/java/io/netty/channel/local/LocalChannel.java", "transport/src/main/java/io/netty/channel/local/LocalServerChannel.java" ]
[ "transport/src/test/java/io/netty/channel/local/LocalChannelTest.java" ]
diff --git a/transport/src/main/java/io/netty/channel/local/LocalChannel.java b/transport/src/main/java/io/netty/channel/local/LocalChannel.java index 0d4ca82075c..62bd4d6a1cb 100644 --- a/transport/src/main/java/io/netty/channel/local/LocalChannel.java +++ b/transport/src/main/java/io/netty/channel/local/LocalChannel....
diff --git a/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java b/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java index 2ec4c29a6a4..628f621f4e1 100644 --- a/transport/src/test/java/io/netty/channel/local/LocalChannelTest.java +++ b/transport/src/test/java/io/netty/channel/local/L...
train
val
2018-04-23T08:31:30
2018-04-19T19:07:52Z
normanmaurer
val
netty/netty/7888_7891
netty/netty
netty/netty/7888
netty/netty/7891
[ "timestamp(timedelta=0.0, similarity=0.8822347332564776)" ]
c0ae5e697c3c4fdf81f0cfc199d18aacd3b8ecba
c60263e8a3336aae182fdde2dd0202a667cba880
[ "Also verified the same behavior on Netty 4.1.24.Final.", "@nicmunroe PTAL https://github.com/netty/netty/pull/7891" ]
[]
2018-04-25T13:34:50Z
[]
HttpResponseEncoder does not treat status 205 as a content-is-always-empty response
### Expected behavior RFC 2616 (https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.6) states that responses with HTTP status code 205 should never return a payload: `The response MUST NOT include an entity`. Additionally, the RFC 7230 section on content-length (https://tools.ietf.org/html/rfc7230#secti...
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseEncoderTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java b/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java index 60086cfd8a2..5ad7a7938e7 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/HttpResponseEncoder.java +++ b/codec-http/src/main/j...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseEncoderTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseEncoderTest.java index 218f6bdf748..2cd07e1018b 100644 --- a/codec-http/src/test/java/io/netty/handler/codec/http/HttpResponseEncoderTest.java +++ b/codec-htt...
train
val
2018-04-26T08:04:01
2018-04-25T01:14:11Z
nicmunroe
val
netty/netty/7887_7911
netty/netty
netty/netty/7887
netty/netty/7911
[ "timestamp(timedelta=0.0, similarity=0.9201288709387265)", "keyword_pr_to_issue" ]
85e2987719fb6e196feb13a21560cc1ea589e24a
88f0586a7e89a4e35e0011bdf607b3192bfe7b5f
[ "I think what you said @ejona86 makes sense... want to do a pr ?", "I worked on the change last night :) but didn't send it out because I was investigating further changes. Sent it out now." ]
[ "s/max/goAwayMax/", "\"positive or zero\"?", "Yeah, looks like it should be \"non-negative\". This was pre-existing code and just moved, but I can update it.", "@ejona86 move this to the public method (as it was before) ?", "@ejona86 should we just keep the method as well and deprecate it and ignore the sec...
2018-05-06T20:03:11Z
[ "improvement" ]
HpackDecoder's maxHeaderListSizeGoAway kills stream unnecessarily
Consider this a bit of a TODO for myself, although @Scottmitch or @normanmaurer may have opinions about avoiding killing the connection in this case. ### Expected behavior Sending too large of headers would not unnecessarily kill the connection. ### Actual behavior When maxHeaderListSizeGoAway is exceeded, ...
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java", "codec-http2/src/main/java/io/netty/handler/codec/http2/HpackDecoder.java" ]
[ "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java", "codec-http2/src/test/java/io/netty/handler/codec/http2/HpackEncoderTest.java" ]
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java index 684fef03528..5d6320950ca 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/DefaultHttp2HeadersDecoder.java ...
diff --git a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java b/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java index 4652a1fceb6..ba0117553eb 100644 --- a/codec-http2/src/test/java/io/netty/handler/codec/http2/HpackDecoderTest.java +++ b/codec-http2/src/test/jav...
val
val
2018-05-15T11:38:15
2018-04-24T22:12:21Z
ejona86
val
netty/netty/7901_7927
netty/netty
netty/netty/7901
netty/netty/7927
[ "timestamp(timedelta=0.0, similarity=0.8400210261055583)" ]
dc0cf3e099a8f1f4a74cbf114afabaa5ba3eee4f
583fc272f26373ff5f51c0871d9730370cd39a3e
[]
[]
2018-05-11T19:54:37Z
[]
Netty Client concurrent issue when close FixedChannelPool
I use Netty as A tcp Client, use FixedChannelPool as channelPool. when Close client，some time will cause follow exception ### Expected behavior no exception ### Actual behavior ```text [xxxxxx]2018-04-03 14:34:56 04 [io.netty.util.concurrent.DefaultPromise.rejectedExecution]-[ERROR] Fail...
[ "transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java", "transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java" ]
[ "transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java", "transport/src/main/java/io/netty/channel/pool/SimpleChannelPool.java" ]
[]
diff --git a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java b/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java index 1c0ebcc5343..16a8a7cc9a7 100644 --- a/transport/src/main/java/io/netty/channel/pool/FixedChannelPool.java +++ b/transport/src/main/java/io/netty/channel/pool/Fixed...
null
val
val
2018-05-12T20:25:11
2018-04-30T10:22:27Z
caorong
val
netty/netty/7954_7955
netty/netty
netty/netty/7954
netty/netty/7955
[ "timestamp(timedelta=0.0, similarity=0.866942814981692)" ]
583fc272f26373ff5f51c0871d9730370cd39a3e
19d1f4ea628d5042ea93856d286cb31b453beda0
[ "@nicktrav actually I think the idea was that usually PONG frames should be dropped on the floor. That said I would argue that is not the best thing to do \"magically\" and it may be better to let the user decide to drop it or not. So maybe we should not do this ?", "Yeah, that would be awesome for us. Principle ...
[ "assert return value please", "assert return value please", "assert return value please", "You can use use `Unpooled.copiedBuffer(...)` to simplify this a bit.", "Call `channel.finish()` and assert return value", "Call `channel.finish()` and assert return value", "Call `channel.finish()` and assert retu...
2018-05-18T20:49:01Z
[]
PongWebSocketFrames are inaccessible in handlers downstream of a WebSocketClientProtocolHandler
This is probably more of a question / request rather than a bug, as it looks like this was a deliberate decision ([source](https://github.com/netty/netty/blob/netty-4.1.25.Final/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java#L32-L35)). The use-case is a handler being ab...
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandler.java", "codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandlerTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java b/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java index 2ace7e8aa09..7c85c57748d 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/websocke...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandlerTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/websocketx/WebSocketProtocolHandlerTest.java new file mode 100644 index 00000000000..af7498222ce --- /dev/null +++ b/codec-http/src/test/java/io/netty/han...
train
val
2018-05-21T19:22:31
2018-05-18T18:42:56Z
nicktrav
val
netty/netty/7964_7965
netty/netty
netty/netty/7964
netty/netty/7965
[ "timestamp(timedelta=0.0, similarity=0.8595601789507803)" ]
583fc272f26373ff5f51c0871d9730370cd39a3e
4d6b006fe64059b6b9eba9fbb835dc4a22d33393
[ "sounds like a bug to me... looking now", "@ewie thanks for reporting, fixed by https://github.com/netty/netty/pull/7965" ]
[ "Assert the hash codes are equal as well." ]
2018-05-24T06:03:19Z
[]
DefaultHttpResponse does not implement equals and hashCode to cover response status
### Expected behavior Two DefaultHttpResponse instances with different response status should not be considered equal. Headers and HTTP version are already covered in DefaultHttpMessage. DefaultFullHttpResponse also covers content and trailing headers. I would assume the response status is considered as well. ### A...
[ "codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpResponse.java" ]
[ "codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpResponse.java" ]
[ "codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpResponseTest.java" ]
diff --git a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpResponse.java b/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpResponse.java index 86858108a27..d5b7cf0b7b9 100644 --- a/codec-http/src/main/java/io/netty/handler/codec/http/DefaultHttpResponse.java +++ b/codec-http/src/main/j...
diff --git a/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpResponseTest.java b/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpResponseTest.java new file mode 100644 index 00000000000..0a466c6bff9 --- /dev/null +++ b/codec-http/src/test/java/io/netty/handler/codec/http/DefaultHttpRespo...
val
val
2018-05-21T19:22:31
2018-05-24T00:25:56Z
ewie
val