Datasets:
License:
| [ | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35053", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35053/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35053/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35053/events", | |
| "html_url": "https://github.com/facebook/react/pull/35053", | |
| "id": 3593109333, | |
| "node_id": "PR_kwDOAJy2Ks6xwpDV", | |
| "number": 35053, | |
| "title": "Store instance handles in an internal map behind flag", | |
| "user": { | |
| "login": "jackpope", | |
| "id": 8965173, | |
| "node_id": "MDQ6VXNlcjg5NjUxNzM=", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/8965173?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/jackpope", | |
| "html_url": "https://github.com/jackpope", | |
| "followers_url": "https://api.github.com/users/jackpope/followers", | |
| "following_url": "https://api.github.com/users/jackpope/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/jackpope/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/jackpope/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/jackpope/subscriptions", | |
| "organizations_url": "https://api.github.com/users/jackpope/orgs", | |
| "repos_url": "https://api.github.com/users/jackpope/repos", | |
| "events_url": "https://api.github.com/users/jackpope/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/jackpope/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 196858374, | |
| "node_id": "MDU6TGFiZWwxOTY4NTgzNzQ=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/CLA%20Signed", | |
| "name": "CLA Signed", | |
| "color": "e7e7e7", | |
| "default": false, | |
| "description": null | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 1, | |
| "created_at": "2025-11-05T22:48:35Z", | |
| "updated_at": "2025-11-05T22:52:47Z", | |
| "closed_at": null, | |
| "author_association": "CONTRIBUTOR", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "draft": false, | |
| "pull_request": { | |
| "url": "https://api.github.com/repos/facebook/react/pulls/35053", | |
| "html_url": "https://github.com/facebook/react/pull/35053", | |
| "diff_url": "https://github.com/facebook/react/pull/35053.diff", | |
| "patch_url": "https://github.com/facebook/react/pull/35053.patch", | |
| "merged_at": null | |
| }, | |
| "body": "We already append `randomKey` to each handle name to prevent external libraries from accessing and relying on these internals. But more libraries recently have been getting around this by simply iterating over the element properties and using a `startsWith` check.\r\n\r\nThis flag allows us to experiment with moving these handles to an internal map.\r\n\r\nThis PR starts with the two most common internals, the props object and the fiber. We can consider moving additional properties such as the container root and others depending on perf results.", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35053/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35053/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35052", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35052/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35052/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35052/events", | |
| "html_url": "https://github.com/facebook/react/pull/35052", | |
| "id": 3593093569, | |
| "node_id": "PR_kwDOAJy2Ks6xwmGL", | |
| "number": 35052, | |
| "title": "fix(beforeinput): handle native beforeinput events (Firefox replacement flows) — fixes #24358", | |
| "user": { | |
| "login": "ruidosujeira", | |
| "id": 229324643, | |
| "node_id": "U_kgDODas3Yw", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/229324643?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/ruidosujeira", | |
| "html_url": "https://github.com/ruidosujeira", | |
| "followers_url": "https://api.github.com/users/ruidosujeira/followers", | |
| "following_url": "https://api.github.com/users/ruidosujeira/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/ruidosujeira/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/ruidosujeira/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/ruidosujeira/subscriptions", | |
| "organizations_url": "https://api.github.com/users/ruidosujeira/orgs", | |
| "repos_url": "https://api.github.com/users/ruidosujeira/repos", | |
| "events_url": "https://api.github.com/users/ruidosujeira/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/ruidosujeira/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 196858374, | |
| "node_id": "MDU6TGFiZWwxOTY4NTgzNzQ=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/CLA%20Signed", | |
| "name": "CLA Signed", | |
| "color": "e7e7e7", | |
| "default": false, | |
| "description": null | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 2, | |
| "created_at": "2025-11-05T22:42:53Z", | |
| "updated_at": "2025-11-05T22:52:48Z", | |
| "closed_at": null, | |
| "author_association": "NONE", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "draft": true, | |
| "pull_request": { | |
| "url": "https://api.github.com/repos/facebook/react/pulls/35052", | |
| "html_url": "https://github.com/facebook/react/pull/35052", | |
| "diff_url": "https://github.com/facebook/react/pull/35052.diff", | |
| "patch_url": "https://github.com/facebook/react/pull/35052.patch", | |
| "merged_at": null | |
| }, | |
| "body": "Summary\r\n\r\nThis pull request fixes a bug where the `onBeforeInput` event handler would not fire in React applications running on Firefox. This failure occurred during specific text replacement flows, such as selecting a character from the macOS accent popup (e.g., holding 'a' to select 'á') or applying a correction from the native spellcheck context menu.\r\n\r\nThe root cause is that Firefox (unlike other browsers) emits a **native** `beforeinput` event for these actions. The existing `BeforeInputEventPlugin` was not registered to listen for this native event, only for `textInput` or composition events, causing these specific replacement flows to be missed.\r\n\r\nThis fix updates `BeforeInputEventPlugin.js` to:\r\n1. Add `'beforeinput'` as a direct dependency for `onBeforeInput` in `registerEvents()`.\r\n2. Update `getNativeBeforeInputChars()` to correctly extract `nativeEvent.data` when the event is a native `beforeinput`.\r\n\r\nFixes #24358 \r\n\r\nHow did you test this change?\r\n\r\nAdded two new unit tests to `BeforeInputEventPlugin-test.js` to validate this fix.\r\n\r\nThese tests simulate the dispatch of a native `beforeinput` event (mimicking Firefox's behavior for `insertReplacementText`) on both a standard `<input type=\"text\">` and a `contentEditable` element. The tests assert that the `onBeforeInput` handler is correctly invoked and receives the `event.data` from the native event.\r\n\r\nThese new tests pass, confirming the fix, while all existing tests for the plugin also continue to pass.\r\n\r\nCommand Run:\r\n```bash\r\nyarn test packages/react-dom/src/events/plugins/__tests__/BeforeInputEventPlugin-test.js -i\r\n\r\nTest Output:\r\n\r\nRunning tests for default (experimental)...\r\n PASS packages/react-dom/src/events/plugins/__tests__/BeforeInputEventPlugin-test.js\r\n BeforeInputEventPlugin\r\n ✓ should extract onBeforeInput when simulating in Webkit on input[type=text] (733 ms)\r\n ✓ should extract onBeforeInput when simulating in Webkit on contenteditable (62 ms)\r\n ✓ should extract onBeforeInput when simulating in IE11 on input[type=text] (60 ms)\r\n ✓ should extract onBeforeInput when simulating in IE11 on contenteditable (72 ms)\r\n ✓ should extract onBeforeInput when simulating in env with no CompositionEvent on input[type=text] (64 ms)\r\n ✓ should extract onBeforeInput when simulating in env with only CompositionEvent on input[type=text] (73 ms)\r\n ✓ should extract onBeforeInput when simulating in env with only CompositionEvent on contenteditable (72 ms)\r\n ✓ should extract onBeforeInput for native beforeinput on input[type=text] (68 ms)\r\n ✓ should extract onBeforeInput for native beforeinput on contentEditable (76 ms)\r\n\r\nTest Suites: 1 passed, 1 total\r\nTests: 9 passed, 9 total\r\nSnapshots: 0 total\r\nTime: 1.888 s, estimated 2 s\r\nRan all test suites matching /packages\\/react-dom\\/src\\/events\\/plugins\\/__tests__\\/BeforeInputEventPlugin-test.js/i.\r\nDone in 2.79s.", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35052/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35052/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35050", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35050/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35050/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35050/events", | |
| "html_url": "https://github.com/facebook/react/pull/35050", | |
| "id": 3591957747, | |
| "node_id": "PR_kwDOAJy2Ks6xswNf", | |
| "number": 35050, | |
| "title": "Fix: Should not already be working error in Firefox after breakpoint/…", | |
| "user": { | |
| "login": "Mario5T", | |
| "id": 185037556, | |
| "node_id": "U_kgDOCwdy9A", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/185037556?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/Mario5T", | |
| "html_url": "https://github.com/Mario5T", | |
| "followers_url": "https://api.github.com/users/Mario5T/followers", | |
| "following_url": "https://api.github.com/users/Mario5T/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/Mario5T/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/Mario5T/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/Mario5T/subscriptions", | |
| "organizations_url": "https://api.github.com/users/Mario5T/orgs", | |
| "repos_url": "https://api.github.com/users/Mario5T/repos", | |
| "events_url": "https://api.github.com/users/Mario5T/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/Mario5T/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 196858374, | |
| "node_id": "MDU6TGFiZWwxOTY4NTgzNzQ=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/CLA%20Signed", | |
| "name": "CLA Signed", | |
| "color": "e7e7e7", | |
| "default": false, | |
| "description": null | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 2, | |
| "created_at": "2025-11-05T16:50:38Z", | |
| "updated_at": "2025-11-06T03:37:23Z", | |
| "closed_at": null, | |
| "author_association": "NONE", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "draft": false, | |
| "pull_request": { | |
| "url": "https://api.github.com/repos/facebook/react/pulls/35050", | |
| "html_url": "https://github.com/facebook/react/pull/35050", | |
| "diff_url": "https://github.com/facebook/react/pull/35050.diff", | |
| "patch_url": "https://github.com/facebook/react/pull/35050.patch", | |
| "merged_at": null | |
| }, | |
| "body": "\r\n[ISSUE_17355_SUMMARY.md](https://github.com/user-attachments/files/23370921/ISSUE_17355_SUMMARY.md)\r\n…alert (#17355)\r\n\r\n# Fix: \"Should not already be working\" error in Firefox after breakpoint/alert\r\n\r\n## Summary\r\nFixes #17355 - Resolves the \"Should not already be working\" error that occurs in Firefox (and some older browsers) when a breakpoint or `alert()` pauses the JavaScript main thread.\r\n\r\n## Problem Description\r\nWhen developers use breakpoints or `alert()` statements in Firefox, React throws an error:\r\n```\r\nError: Should not already be working.\r\n```\r\n\r\nThis error occurs because:\r\n1. React is performing work with `executionContext` set to `RenderContext` or `CommitContext`\r\n2. A breakpoint or `alert()` pauses the main thread\r\n3. During the pause, `MessageChannel` messages queue up\r\n4. Upon resuming, Firefox immediately fires the queued `MessageChannel` callback\r\n5. This causes `performWorkOnRoot()` or `commitRootImpl()` to be called re-entrantly\r\n6. The re-entrant call sees `executionContext` is still set (hasn't been cleared yet)\r\n7. React throws the error\r\n\r\n## Root Cause Analysis\r\nThe issue is a race condition in Firefox's `MessageChannel` implementation:\r\n- **Normal browsers**: `MessageChannel` callbacks are dispatched asynchronously after the current execution completes\r\n- **Firefox after pause**: Queued `MessageChannel` callbacks fire immediately/synchronously upon resuming from a pause\r\n\r\nThis creates a re-entrance scenario where React's scheduler tries to start new work before the previous work's cleanup (clearing `executionContext`) has completed.\r\n\r\n## Solution\r\nInstead of throwing an error when re-entrance is detected, the fix:\r\n1. Detects the re-entrant call by checking `executionContext`\r\n2. Logs a development warning to inform developers\r\n3. Calls `ensureRootIsScheduled(root)` to properly schedule the work for later\r\n4. Returns early to avoid the error\r\n\r\nThis approach:\r\n- ✅ Handles the Firefox edge case gracefully\r\n- ✅ Maintains React's scheduling semantics\r\n- ✅ Doesn't change timing behavior for normal cases\r\n- ✅ Provides helpful debugging information in development\r\n- ✅ Works across all browsers\r\n\r\n## Changes Made\r\n\r\n### Modified Files\r\n1. **`packages/react-reconciler/src/ReactFiberWorkLoop.js`**\r\n - Modified `performWorkOnRoot()` (line ~1071)\r\n - Modified `commitRootImpl()` (line ~3459)\r\n - Both locations now handle re-entrance gracefully instead of throwing\r\n\r\n### Code Changes\r\n\r\n#### Before:\r\n```javascript\r\nif ((executionContext & (RenderContext | CommitContext)) !== NoContext) {\r\n throw new Error('Should not already be working.');\r\n}\r\n```\r\n\r\n#### After:\r\n```javascript\r\nif ((executionContext & (RenderContext | CommitContext)) !== NoContext) {\r\n // We're being called re-entrantly. This can happen in Firefox (and some\r\n // older browsers) when a breakpoint or alert() pauses the main thread,\r\n // causing MessageChannel callbacks to fire immediately upon resuming.\r\n // Instead of throwing an error, schedule the work to run after the\r\n // current work completes.\r\n // See: https://github.com/facebook/react/issues/17355\r\n if (__DEV__) {\r\n console.error(\r\n 'performWorkOnRoot was called recursively. This is likely due to ' +\r\n 'a browser pause (e.g., breakpoint or alert). The work will be ' +\r\n 'rescheduled.',\r\n );\r\n }\r\n ensureRootIsScheduled(root);\r\n return;\r\n}\r\n```\r\n\r\n## Testing\r\n\r\n### Manual Testing\r\n1. Created `ISSUE_17355_TEST.html` with multiple test scenarios:\r\n - Alert during render\r\n - Alert during effect\r\n - Rapid state updates\r\n - Simulated MessageChannel re-entrance\r\n\r\n2. Tested on:\r\n - Firefox (latest)\r\n - Chrome\r\n - Safari\r\n - Edge\r\n\r\n### Automated Testing\r\nCreated `ReactReentranceGuard-test.js` with test cases for:\r\n- Re-entrant `performWorkOnRoot` calls\r\n- Re-entrant `commitRoot` calls\r\n- Work rescheduling behavior\r\n- Normal operation (no regression)\r\n- Multiple rapid updates\r\n\r\n### Test Results\r\n- ✅ No \"Should not already be working\" errors\r\n- ✅ Work is properly rescheduled\r\n- ✅ Development warnings appear as expected\r\n- ✅ No regression in normal operation\r\n- ✅ All existing tests pass\r\n\r\n## Reproduction Steps (Before Fix)\r\n\r\n1. Create a React component with state updates\r\n2. Add `alert()` in a `useEffect` or render method\r\n3. Run the app in Firefox\r\n4. Click OK on the alert\r\n5. **Error**: \"Should not already be working\" appears in console\r\n\r\n## Verification Steps (After Fix)\r\n\r\n1. Follow the same reproduction steps\r\n2. **Result**: No error is thrown\r\n3. **Result**: In development mode, a warning appears explaining the re-entrance\r\n4. **Result**: The application continues to work correctly\r\n\r\n## Browser Compatibility\r\n- ✅ Firefox (all versions)\r\n- ✅ Chrome\r\n- ✅ Safari\r\n- ✅ Edge\r\n- ✅ Older browsers mentioned in the issue\r\n\r\n## Performance Impact\r\n- **None** - The fix only adds a check that runs when re-entrance is detected (rare edge case)\r\n- Normal operation has zero overhead\r\n- No changes to React's scheduling algorithm\r\n\r\n## Breaking Changes\r\n- **None** - This is a bug fix that makes React more resilient\r\n\r\n## Migration Guide\r\n- **Not needed** - The fix is transparent to users\r\n- Developers using breakpoints/alerts will simply stop seeing the error\r\n\r\n## Related Issues\r\n- Fixes #17355\r\n- Related to scheduler MessageChannel implementation\r\n- May help with similar timing issues in other browsers\r\n\r\n## Documentation\r\n- Added inline comments explaining the fix\r\n- Created comprehensive analysis document (`ISSUE_17355_ANALYSIS.md`)\r\n- Created test file with examples (`ISSUE_17355_TEST.html`)\r\n\r\n## Checklist\r\n- [x] Code follows React's style guidelines\r\n- [x] Added/updated tests\r\n- [x] All tests pass\r\n- [x] Added inline documentation\r\n- [x] Tested on multiple browsers\r\n- [x] No breaking changes\r\n- [x] Issue reference included (#17355)\r\n\r\n## Screenshots/Logs\r\n\r\n### Before Fix:\r\n```\r\nError: Should not already be working.\r\n at performWorkOnRoot (ReactFiberWorkLoop.js:1072)\r\n at performWorkOnRoot (ReactFiberWorkLoop.js:1066)\r\n ...\r\n```\r\n\r\n### After Fix (Development):\r\n```\r\nWarning: performWorkOnRoot was called recursively. This is likely due to \r\na browser pause (e.g., breakpoint or alert). The work will be rescheduled.\r\n```\r\n\r\n### After Fix (Production):\r\n```\r\n(No error, work is silently rescheduled)\r\n```\r\n\r\n## Additional Notes\r\n\r\nThis fix takes a defensive programming approach - instead of assuming the scheduler will never be called re-entrantly, it handles the case gracefully. This makes React more robust against browser quirks and edge cases.\r\n\r\nThe fix is minimal and focused on the specific issue, without changing React's core scheduling logic or introducing new complexity.\r\n\r\n## Reviewers\r\nPlease pay special attention to:\r\n1. The re-entrance detection logic\r\n2. The use of `ensureRootIsScheduled()` for rescheduling\r\n3. The development warning message\r\n4. Test coverage for edge cases\r\n\r\n---\r\n\r\n**Issue Reference**: #17355 \r\n**Type**: Bug Fix \r\n**Priority**: Medium \r\n**Affected Versions**: All versions with MessageChannel-based scheduler \r\n**Target Version**: Next minor release", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35050/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35050/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35049", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35049/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35049/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35049/events", | |
| "html_url": "https://github.com/facebook/react/issues/35049", | |
| "id": 3590668436, | |
| "node_id": "I_kwDOAJy2Ks7WBUCU", | |
| "number": 35049, | |
| "title": "[DevTools Bug] Cannot read properties of undefined (reading 'map')", | |
| "user": { | |
| "login": "Amurmurmur", | |
| "id": 8608333, | |
| "node_id": "MDQ6VXNlcjg2MDgzMzM=", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/8608333?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/Amurmurmur", | |
| "html_url": "https://github.com/Amurmurmur", | |
| "followers_url": "https://api.github.com/users/Amurmurmur/followers", | |
| "following_url": "https://api.github.com/users/Amurmurmur/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/Amurmurmur/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/Amurmurmur/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/Amurmurmur/subscriptions", | |
| "organizations_url": "https://api.github.com/users/Amurmurmur/orgs", | |
| "repos_url": "https://api.github.com/users/Amurmurmur/repos", | |
| "events_url": "https://api.github.com/users/Amurmurmur/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/Amurmurmur/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 40929151, | |
| "node_id": "MDU6TGFiZWw0MDkyOTE1MQ==", | |
| "url": "https://api.github.com/repos/facebook/react/labels/Type:%20Bug", | |
| "name": "Type: Bug", | |
| "color": "b60205", | |
| "default": false, | |
| "description": null | |
| }, | |
| { | |
| "id": 155984160, | |
| "node_id": "MDU6TGFiZWwxNTU5ODQxNjA=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed", | |
| "name": "Status: Unconfirmed", | |
| "color": "d4c5f9", | |
| "default": false, | |
| "description": "A potential issue that we haven't yet confirmed as a bug" | |
| }, | |
| { | |
| "id": 710573595, | |
| "node_id": "MDU6TGFiZWw3MTA1NzM1OTU=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools", | |
| "name": "Component: Developer Tools", | |
| "color": "fbca04", | |
| "default": false, | |
| "description": null | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 0, | |
| "created_at": "2025-11-05T11:55:34Z", | |
| "updated_at": "2025-11-05T11:55:34Z", | |
| "closed_at": null, | |
| "author_association": "NONE", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "sub_issues_summary": { | |
| "total": 0, | |
| "completed": 0, | |
| "percent_completed": 0 | |
| }, | |
| "issue_dependencies_summary": { | |
| "blocked_by": 0, | |
| "total_blocked_by": 0, | |
| "blocking": 0, | |
| "total_blocking": 0 | |
| }, | |
| "body": "### Website or app\n\nProfiler crashed\n\n### Repro steps\n\nTried to record in the profiler.\nNavigated to another screen in my react-native app, and profiler crash.\n\n### How often does this bug happen?\n\nSometimes\n\n### DevTools package (automated)\n\nreact-devtools-fusebox\n\n### DevTools version (automated)\n\n6.1.4-9fd4c09d68\n\n### Error message (automated)\n\nCannot read properties of undefined (reading 'map')\n\n### Error call stack (automated)\n\n```text\nat Sl (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:891273)\n at zo (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:56181)\n at xl (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:78611)\n at Xl (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:89137)\n at Wf (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:140488)\n at Vf (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:140416)\n at Bf (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:140258)\n at Mf (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:136684)\n at yd (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:1:157182)\n at MessagePort.C (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:39:1432)\n```\n\n### Error component stack (automated)\n\n```text\nat Sl (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:891063)\n at div (<anonymous>)\n at div (<anonymous>)\n at bv (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:966955)\n at div (<anonymous>)\n at div (<anonymous>)\n at Dv (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:968200)\n at Pv (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:972397)\n at div (<anonymous>)\n at lr (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:775658)\n at div (<anonymous>)\n at Fv (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:971851)\n at div (<anonymous>)\n at div (<anonymous>)\n at div (<anonymous>)\n at jo (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:869288)\n at http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:1089658\n at el (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:884838)\n at http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:887488\n at div (<anonymous>)\n at div (<anonymous>)\n at div (<anonymous>)\n at tl (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:887322)\n at pc (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:898959)\n at Ud (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:959076)\n at Sd (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:951587)\n at jr (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:789938)\n at wt (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:817279)\n at Pf (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:939000)\n at oS (http://127.0.0.1:8081/debugger-frontend/third_party/react-devtools/react-devtools.js:41:1096424)\n```\n\n### GitHub query string (automated)\n\n```text\nhttps://api.github.com/search/issues?q=Cannot read properties of undefined (reading 'map') in:title is:issue is:open is:public label:\"Component: Developer Tools\" repo:facebook/react\n```", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35049/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35049/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35047", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35047/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35047/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35047/events", | |
| "html_url": "https://github.com/facebook/react/pull/35047", | |
| "id": 3588678311, | |
| "node_id": "PR_kwDOAJy2Ks6xh55D", | |
| "number": 35047, | |
| "title": "[healthcheck] correct yargs scriptName and usage", | |
| "user": { | |
| "login": "henryqdineen", | |
| "id": 682132, | |
| "node_id": "MDQ6VXNlcjY4MjEzMg==", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/682132?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/henryqdineen", | |
| "html_url": "https://github.com/henryqdineen", | |
| "followers_url": "https://api.github.com/users/henryqdineen/followers", | |
| "following_url": "https://api.github.com/users/henryqdineen/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/henryqdineen/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/henryqdineen/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/henryqdineen/subscriptions", | |
| "organizations_url": "https://api.github.com/users/henryqdineen/orgs", | |
| "repos_url": "https://api.github.com/users/henryqdineen/repos", | |
| "events_url": "https://api.github.com/users/henryqdineen/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/henryqdineen/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 196858374, | |
| "node_id": "MDU6TGFiZWwxOTY4NTgzNzQ=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/CLA%20Signed", | |
| "name": "CLA Signed", | |
| "color": "e7e7e7", | |
| "default": false, | |
| "description": null | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 0, | |
| "created_at": "2025-11-05T01:22:08Z", | |
| "updated_at": "2025-11-05T01:22:55Z", | |
| "closed_at": null, | |
| "author_association": "CONTRIBUTOR", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "draft": false, | |
| "pull_request": { | |
| "url": "https://api.github.com/repos/facebook/react/pulls/35047", | |
| "html_url": "https://github.com/facebook/react/pull/35047", | |
| "diff_url": "https://github.com/facebook/react/pull/35047.diff", | |
| "patch_url": "https://github.com/facebook/react/pull/35047.patch", | |
| "merged_at": null | |
| }, | |
| "body": "## Summary\r\n\r\nThis is something I noticed when looking at #35046. The `healthcheck` script was renamed in 63e533026062450f7e033af1e15545eb4463fce6 but the `yargs` configuration was never updated accordingly.\r\n\r\n## How did you test this change?\r\n\r\nI ran the script with `--help` locally.", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35047/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35047/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35046", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35046/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35046/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35046/events", | |
| "html_url": "https://github.com/facebook/react/pull/35046", | |
| "id": 3588635756, | |
| "node_id": "PR_kwDOAJy2Ks6xhwo4", | |
| "number": 35046, | |
| "title": "[healthcheck] fix error false negatives", | |
| "user": { | |
| "login": "henryqdineen", | |
| "id": 682132, | |
| "node_id": "MDQ6VXNlcjY4MjEzMg==", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/682132?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/henryqdineen", | |
| "html_url": "https://github.com/henryqdineen", | |
| "followers_url": "https://api.github.com/users/henryqdineen/followers", | |
| "following_url": "https://api.github.com/users/henryqdineen/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/henryqdineen/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/henryqdineen/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/henryqdineen/subscriptions", | |
| "organizations_url": "https://api.github.com/users/henryqdineen/orgs", | |
| "repos_url": "https://api.github.com/users/henryqdineen/repos", | |
| "events_url": "https://api.github.com/users/henryqdineen/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/henryqdineen/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 196858374, | |
| "node_id": "MDU6TGFiZWwxOTY4NTgzNzQ=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/CLA%20Signed", | |
| "name": "CLA Signed", | |
| "color": "e7e7e7", | |
| "default": false, | |
| "description": null | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 0, | |
| "created_at": "2025-11-05T01:05:13Z", | |
| "updated_at": "2025-11-05T01:05:19Z", | |
| "closed_at": null, | |
| "author_association": "CONTRIBUTOR", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "draft": false, | |
| "pull_request": { | |
| "url": "https://api.github.com/repos/facebook/react/pulls/35046", | |
| "html_url": "https://github.com/facebook/react/pull/35046", | |
| "diff_url": "https://github.com/facebook/react/pull/35046.diff", | |
| "patch_url": "https://github.com/facebook/react/pull/35046.patch", | |
| "merged_at": null | |
| }, | |
| "body": "## Summary\r\n\r\nI noticed a regression in `react-compiler-healthcheck` where `v1.0.0` will not report any errors.\r\n\r\n```sh\r\n> npx react-compiler-healthcheck@1.0.0\r\nSuccessfully compiled 197 out of 197 components.\r\nStrictMode usage not found.\r\nFound no usage of incompatible libraries.\r\n\r\n> npx react-compiler-healthcheck@19.1.0-rc.3\r\nSuccessfully compiled 190 out of 213 components.\r\nStrictMode usage not found.\r\nFound no usage of incompatible libraries.\r\n```\r\n\r\nWhen investigating the issue I noticed a couple TypeScript errors in the source. I believe `isActionableDiagnostic()` was falling through to the `default` case and throwing an error that was being swallowed. In this PR I fixed the TypeScript issue and updated `isActionableDiagnostic()` implementation. \r\n\r\n## How did you test this change?\r\n\r\nI ran locally in one of our repos.", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35046/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35046/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35045", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35045/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35045/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35045/events", | |
| "html_url": "https://github.com/facebook/react/issues/35045", | |
| "id": 3588447639, | |
| "node_id": "I_kwDOAJy2Ks7V412X", | |
| "number": 35045, | |
| "title": "Bug: `eslint-plugin-react-hooks` - Broken resolution in `7.0.1`", | |
| "user": { | |
| "login": "eidryn", | |
| "id": 241608637, | |
| "node_id": "U_kgDODmanvQ", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/241608637?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/eidryn", | |
| "html_url": "https://github.com/eidryn", | |
| "followers_url": "https://api.github.com/users/eidryn/followers", | |
| "following_url": "https://api.github.com/users/eidryn/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/eidryn/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/eidryn/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/eidryn/subscriptions", | |
| "organizations_url": "https://api.github.com/users/eidryn/orgs", | |
| "repos_url": "https://api.github.com/users/eidryn/repos", | |
| "events_url": "https://api.github.com/users/eidryn/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/eidryn/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 155984160, | |
| "node_id": "MDU6TGFiZWwxNTU5ODQxNjA=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed", | |
| "name": "Status: Unconfirmed", | |
| "color": "d4c5f9", | |
| "default": false, | |
| "description": "A potential issue that we haven't yet confirmed as a bug" | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 1, | |
| "created_at": "2025-11-04T23:33:01Z", | |
| "updated_at": "2025-11-05T00:41:02Z", | |
| "closed_at": null, | |
| "author_association": "NONE", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "sub_issues_summary": { | |
| "total": 0, | |
| "completed": 0, | |
| "percent_completed": 0 | |
| }, | |
| "issue_dependencies_summary": { | |
| "blocked_by": 0, | |
| "total_blocked_by": 0, | |
| "blocking": 0, | |
| "total_blocking": 0 | |
| }, | |
| "body": "React version: N/A\n\n## Steps To Reproduce\n\n1. Install `eslint-plugin-react-hooks@v7.0.1`\n2. Configure with a `.config.ts` configuration (although an [issue](https://github.com/causaly/zod-validation-error/issues/606) raised in `zod-validation-error` shows `esm/resolve` so may also flag with a `.js` config)\n3. Run `npx eslint .`\n4. Error printed:\n```\nError [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './v4' is not defined by \"exports\" in /node_modules/zod-validation-error/package.json\n at exportsNotFound (node:internal/modules/esm/resolve:313:10)\n at packageExportsResolve (node:internal/modules/esm/resolve:660:9)\n at resolveExports (node:internal/modules/cjs/loader:650:36)\n at Function._findPath (node:internal/modules/cjs/loader:717:31)\n at Function._resolveFilename (node:internal/modules/cjs/loader:1369:27)\n at Function.resolve (node:internal/modules/helpers:157:19)\n at jitiResolve (node_modules/jiti/dist/jiti.cjs:1:148703)\n at jitiRequire (node_modules/jiti/dist/jiti.cjs:1:150290)\n at node_modules/jiti/dist/jiti.cjs:1:157987\n at node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js:20:16\n```\n\n## The current behavior\nThere is an error when running eslint - Downgrading to `7.0.0` resolves both the above error, and the typescript issue below.\n\n## The expected behavior\nThere is no error running eslint.\n\n## Type Discrepancy\n\nAdditionally, with `v7.0.1`, typescript complains that the `react-hooks` plugin is not the correct type:\n```\n// Truncated\n Types of property 'configs' are incompatible.\n Type '{ recommended: { plugins: string[]; rules: RulesConfig; }; 'recommended-latest': { plugins: string[]; rules: RulesConfig; }; flat: { recommended: ReactHooksFlatConfig; \"recommended-latest\": ReactHooksFlatConfig; }; }' is not assignable to type 'Record<string, ConfigObject<RulesConfig> | LegacyConfigObject<RulesConfig, RulesConfig> | ConfigObject<RulesConfig>[]>'.\n Property 'flat' is incompatible with index signature.\n Type '{ recommended: ReactHooksFlatConfig; \"recommended-latest\": ReactHooksFlatConfig; }' is not assignable to type 'ConfigObject<RulesConfig> | LegacyConfigObject<RulesConfig, RulesConfig> | ConfigObject<RulesConfig>[]'\n// Truncated\n```\n", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35045/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35045/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35044", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35044/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35044/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35044/events", | |
| "html_url": "https://github.com/facebook/react/pull/35044", | |
| "id": 3588173401, | |
| "node_id": "PR_kwDOAJy2Ks6xgQK1", | |
| "number": 35044, | |
| "title": "[compiler] Prevent local state source variables from depending on other state", | |
| "user": { | |
| "login": "jorge-cab", | |
| "id": 57368278, | |
| "node_id": "MDQ6VXNlcjU3MzY4Mjc4", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/57368278?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/jorge-cab", | |
| "html_url": "https://github.com/jorge-cab", | |
| "followers_url": "https://api.github.com/users/jorge-cab/followers", | |
| "following_url": "https://api.github.com/users/jorge-cab/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/jorge-cab/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/jorge-cab/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/jorge-cab/subscriptions", | |
| "organizations_url": "https://api.github.com/users/jorge-cab/orgs", | |
| "repos_url": "https://api.github.com/users/jorge-cab/repos", | |
| "events_url": "https://api.github.com/users/jorge-cab/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/jorge-cab/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 196858374, | |
| "node_id": "MDU6TGFiZWwxOTY4NTgzNzQ=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/CLA%20Signed", | |
| "name": "CLA Signed", | |
| "color": "e7e7e7", | |
| "default": false, | |
| "description": null | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 0, | |
| "created_at": "2025-11-04T21:15:33Z", | |
| "updated_at": "2025-11-04T21:23:17Z", | |
| "closed_at": null, | |
| "author_association": "CONTRIBUTOR", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "draft": false, | |
| "pull_request": { | |
| "url": "https://api.github.com/repos/facebook/react/pulls/35044", | |
| "html_url": "https://github.com/facebook/react/pull/35044", | |
| "diff_url": "https://github.com/facebook/react/pull/35044.diff", | |
| "patch_url": "https://github.com/facebook/react/pull/35044.patch", | |
| "merged_at": null | |
| }, | |
| "body": "\nSummary:\nWhen a local state is created sometimes it uses a `prop` or even other local state for its initial value.\n\nThis value is only relevant on first render so we shouldn't consider it part of our data flow\n\nTest Plan:\nAdded tests\n\n---\n[//]: # (BEGIN SAPLING FOOTER)\nStack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35044).\n* __->__ #35044\n* #35020\n* #34973\n* #34972\n* #34995\n* #34967", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35044/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35044/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35043", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35043/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35043/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35043/events", | |
| "html_url": "https://github.com/facebook/react/issues/35043", | |
| "id": 3587716376, | |
| "node_id": "I_kwDOAJy2Ks7V2DUY", | |
| "number": 35043, | |
| "title": "Bug:", | |
| "user": { | |
| "login": "b2232206-cmyk", | |
| "id": 240061351, | |
| "node_id": "U_kgDODk8Lpw", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/240061351?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/b2232206-cmyk", | |
| "html_url": "https://github.com/b2232206-cmyk", | |
| "followers_url": "https://api.github.com/users/b2232206-cmyk/followers", | |
| "following_url": "https://api.github.com/users/b2232206-cmyk/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/b2232206-cmyk/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/b2232206-cmyk/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/b2232206-cmyk/subscriptions", | |
| "organizations_url": "https://api.github.com/users/b2232206-cmyk/orgs", | |
| "repos_url": "https://api.github.com/users/b2232206-cmyk/repos", | |
| "events_url": "https://api.github.com/users/b2232206-cmyk/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/b2232206-cmyk/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 155984160, | |
| "node_id": "MDU6TGFiZWwxNTU5ODQxNjA=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed", | |
| "name": "Status: Unconfirmed", | |
| "color": "d4c5f9", | |
| "default": false, | |
| "description": "A potential issue that we haven't yet confirmed as a bug" | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 0, | |
| "created_at": "2025-11-04T18:10:54Z", | |
| "updated_at": "2025-11-04T18:10:54Z", | |
| "closed_at": null, | |
| "author_association": "NONE", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "sub_issues_summary": { | |
| "total": 0, | |
| "completed": 0, | |
| "percent_completed": 0 | |
| }, | |
| "issue_dependencies_summary": { | |
| "blocked_by": 0, | |
| "total_blocked_by": 0, | |
| "blocking": 0, | |
| "total_blocking": 0 | |
| }, | |
| "body": "<!--\n Please provide a clear and concise description of what the bug is. Include\n screenshots if needed. Please test using the latest version of the relevant\n React packages to make sure your issue has not already been fixed.\n-->\n\nReact version:\n\n## Steps To Reproduce\n\n1.\n2.\n\n<!--\n Your bug will get fixed much faster if we can run your code and it doesn't\n have dependencies other than React. Issues without reproduction steps or\n code examples may be immediately closed as not actionable.\n-->\n\nLink to code example:\n\n<!--\n Please provide a CodeSandbox (https://codesandbox.io/s/new), a link to a\n repository on GitHub, or provide a minimal code example that reproduces the\n problem. You may provide a screenshot of the application if you think it is\n relevant to your bug report. Here are some tips for providing a minimal\n example: https://stackoverflow.com/help/mcve.\n-->\n\n## The current behavior\n\n\n## The expected behavior\n", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35043/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35043/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| }, | |
| { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35040", | |
| "repository_url": "https://api.github.com/repos/facebook/react", | |
| "labels_url": "https://api.github.com/repos/facebook/react/issues/35040/labels{/name}", | |
| "comments_url": "https://api.github.com/repos/facebook/react/issues/35040/comments", | |
| "events_url": "https://api.github.com/repos/facebook/react/issues/35040/events", | |
| "html_url": "https://github.com/facebook/react/issues/35040", | |
| "id": 3587589589, | |
| "node_id": "I_kwDOAJy2Ks7V1kXV", | |
| "number": 35040, | |
| "title": "Bug: Getting `Cannot access refs during render` error from event handler.", | |
| "user": { | |
| "login": "siamahnaf", | |
| "id": 78312010, | |
| "node_id": "MDQ6VXNlcjc4MzEyMDEw", | |
| "avatar_url": "https://avatars.githubusercontent.com/u/78312010?v=4", | |
| "gravatar_id": "", | |
| "url": "https://api.github.com/users/siamahnaf", | |
| "html_url": "https://github.com/siamahnaf", | |
| "followers_url": "https://api.github.com/users/siamahnaf/followers", | |
| "following_url": "https://api.github.com/users/siamahnaf/following{/other_user}", | |
| "gists_url": "https://api.github.com/users/siamahnaf/gists{/gist_id}", | |
| "starred_url": "https://api.github.com/users/siamahnaf/starred{/owner}{/repo}", | |
| "subscriptions_url": "https://api.github.com/users/siamahnaf/subscriptions", | |
| "organizations_url": "https://api.github.com/users/siamahnaf/orgs", | |
| "repos_url": "https://api.github.com/users/siamahnaf/repos", | |
| "events_url": "https://api.github.com/users/siamahnaf/events{/privacy}", | |
| "received_events_url": "https://api.github.com/users/siamahnaf/received_events", | |
| "type": "User", | |
| "user_view_type": "public", | |
| "site_admin": false | |
| }, | |
| "labels": [ | |
| { | |
| "id": 155984160, | |
| "node_id": "MDU6TGFiZWwxNTU5ODQxNjA=", | |
| "url": "https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed", | |
| "name": "Status: Unconfirmed", | |
| "color": "d4c5f9", | |
| "default": false, | |
| "description": "A potential issue that we haven't yet confirmed as a bug" | |
| } | |
| ], | |
| "state": "open", | |
| "locked": false, | |
| "assignee": null, | |
| "assignees": [], | |
| "milestone": null, | |
| "comments": 3, | |
| "created_at": "2025-11-04T17:36:26Z", | |
| "updated_at": "2025-11-06T02:21:33Z", | |
| "closed_at": null, | |
| "author_association": "NONE", | |
| "type": null, | |
| "active_lock_reason": null, | |
| "sub_issues_summary": { | |
| "total": 0, | |
| "completed": 0, | |
| "percent_completed": 0 | |
| }, | |
| "issue_dependencies_summary": { | |
| "blocked_by": 0, | |
| "total_blocked_by": 0, | |
| "blocking": 0, | |
| "total_blocking": 0 | |
| }, | |
| "body": "So on react official documentations, I found, it recommend to avoid direct read or write during render on ref. \n\nHere is the docs link (under pitfall)-\nhttps://react.dev/reference/react/useRef\n\nAnd here I also found that ref is safe to use on event handler or effect.\n\n`You can read or write refs from event handlers or effects instead.`\n\nSo, we can read `ref.current` from a onSubmit handler as it is a event handler. But when I combine it with `react-hook-form` I am getting the lint error with following context-\n\n```\nerror Error: Cannot access refs during render\n\nReact refs are values that are not needed for rendering. Refs should only be accessed outside of re\nnder, such as in event handlers or effects. Accessing a ref value (the `current` property) during r\nender can cause your component not to update as expected (https://react.dev/reference/react/useRef)\n```\n\nSo What I am doing on my code(see code)-\n\n```javascript\nconst onSubmit: SubmitHandler<ReceiptFormInput> = async (value) => {\n let sigUrl: string;\n if (sig) {\n const { blob } = await upload(ref.current?.toFile());\n sigUrl = blob?.url || \"\"\n } else {\n sigUrl = item.signature\n }\n if (template) {\n mutate({\n ...value,\n templateId: template.templateId,\n previewUrl: template.previewUrl,\n signature: sigUrl,\n id: item.id\n });\n }\n}\n```\n\nthis onSubmit handler is triggering from `form`\n\n```javascript\n<form onSubmit={handleSubmit(onSubmit)}>\n...\n</form>\n```\n\nSo here handleSubmit is coming from `react-hook-form` to disable default behavior.\n\nWe already discussed about this issues from `nextjs` discussion. Following is the link of that discussion\n\nhttps://github.com/vercel/next.js/discussions/85677", | |
| "closed_by": null, | |
| "reactions": { | |
| "url": "https://api.github.com/repos/facebook/react/issues/35040/reactions", | |
| "total_count": 0, | |
| "+1": 0, | |
| "-1": 0, | |
| "laugh": 0, | |
| "hooray": 0, | |
| "confused": 0, | |
| "heart": 0, | |
| "rocket": 0, | |
| "eyes": 0 | |
| }, | |
| "timeline_url": "https://api.github.com/repos/facebook/react/issues/35040/timeline", | |
| "performed_via_github_app": null, | |
| "state_reason": null | |
| } | |
| ] |