Update comprehensive-arithmetic-problems-carries.py

comprehensive-arithmetic-problems-carries.py

@@ -190,36 +190,39 @@ class ArithmeticProblemsDataset(GeneratorBasedBuilder):
             raise ValueError(f"Invalid operator: {operator}")
 
         is_float1, is_float2 = operation_type
-        while True:
-            operand1 = self._generate_number(
-                min_val=min_value,
-                max_val=max_value,
-                is_float=is_float1,
-                max_rounding_precision=max_rounding_precision,
-            )
+        operand1 = self._generate_number(
+            min_val=min_value,
+            max_val=max_value,
+            is_float=is_float1,
+            max_rounding_precision=max_rounding_precision,
+        )
+        # for testing addition
+        operand2 = self._generate_number(
+            min_val=min_value,
+            max_val=max_value,
+            is_float=is_float2,
+            max_rounding_precision=max_rounding_precision,
+        )
+
+        if operator == Operator.SUBTRACT:
+            result = operand1 - operand2
+        elif operator == Operator.ADD:
             if with_carry:
-                try:
-                    # for testing addition
-                    operand2 = self._generate_number(
-                        min_val=min_value,
-                        max_val=max_value - operand1 - 1,
-                        is_float=is_float2,
-                        max_rounding_precision=max_rounding_precision,
-                    )
-                except Exception:
-                    continue
+                # for testing addition
+                operand2 = self._generate_number(
+                    min_val=max_value - operand1 ,
+                    max_val=max_value,
+                    is_float=is_float2,
+                    max_rounding_precision=max_rounding_precision,
+                )
             else:
+                # for testing addition
                 operand2 = self._generate_number(
                     min_val=min_value,
-                    max_val=max_value,
+                    max_val=max_value - operand1 - 1,
                     is_float=is_float2,
                     max_rounding_precision=max_rounding_precision,
                 )
-            break
-
-        if operator == Operator.SUBTRACT:
-            result = operand1 - operand2
-        elif operator == Operator.ADD:
             result = operand1 + operand2
         elif operator == Operator.MULTIPLY:
             result = operand1 * operand2