repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
vercel/next.js
4bc549bf955d98becec09a85bb7c1ee4a1eafaa9
907f37978eabe5cac5449907aa78f074ba4aa21d
Fix: catch expected error in with-supabase example (#57378) ### What? [1] Use camelCase for SVG properties [2] Catch expected error in cookie functions ### Why? [1] Prints error to the console [2] If the cookies `set` or `delete` methods are called in a Server Component, an error is thrown ### How? [1] Change pro...
[ { "path": "examples/with-supabase/components/Code.tsx", "patch": "@@ -10,9 +10,9 @@ const CopyIcon = () => (\n viewBox=\"0 0 24 24\"\n fill=\"none\"\n stroke=\"currentColor\"\n- stroke-width=\"2\"\n- stroke-linecap=\"round\"\n- stroke-linejoin=\"round\"\n+ strokeWidth=\"2\"\n+ str...
2023-10-26T04:37:32
golang/go
a73808e1e06dfca15a51743ced1fab038b5a2392
9e88773383f2d74e769f63fd6348a01aecf8a271
go/parser: fix spelling in error message Make spelling consistent with uses in other error messages. Change-Id: I584cd22413842fb8bae1632ed34c8b0e7ef163cc Reviewed-on: https://go-review.googlesource.com/c/go/+/424902 Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Robert Griesemer <gri@google.com>
[ { "path": "src/go/parser/parser.go", "patch": "@@ -2096,7 +2096,7 @@ func (p *parser) parseIfHeader() (init ast.Stmt, cond ast.Expr) {\n \t\t// accept potential variable declaration but complain\n \t\tif p.tok == token.VAR {\n \t\t\tp.next()\n-\t\t\tp.error(p.pos, \"var declaration not allowed in 'IF' initi...
2022-08-18T22:40:23
nodejs/node
8f86986985b161b7fb5aa41283d792417329bc2c
b9da063ae9034b3fd8207791ef78a5e769a5eb0d
stream: use callback to properly propagate error The stream will be destroyed upstream through the proper error flow. PR-URL: https://github.com/nodejs/node/pull/29179 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
[ { "path": "lib/_stream_readable.js", "patch": "@@ -144,7 +144,10 @@ function ReadableState(options, stream, isDuplex) {\n // Has it been destroyed\n this.destroyed = false;\n \n- // Indicates whether the stream has errored.\n+ // Indicates whether the stream has errored. When true no further\n+ // _r...
2019-08-17T11:11:37
electron/electron
72723646dd7719f57cf13eb1ea5b9d448f868f99
9423143211bc2368a8db188c9381927215228c86
Add tests to check errors in parameters
[ { "path": "spec/api-dialog-spec.js", "patch": "@@ -19,6 +19,10 @@ describe('dialog module', () => {\n assert.throws(() => {\n dialog.showOpenDialog({defaultPath: {}})\n }, /Default path must be a string/)\n+\n+ assert.throws(() => {\n+ dialog.showOpenDialog({message: {}})\n+ ...
2017-02-09T13:23:02
vercel/next.js
907f37978eabe5cac5449907aa78f074ba4aa21d
63b7b90985c35611e8f9cd693507f5d04004d099
perf: enable webpack build worker (#57346) This PR enables the `experimental.webpackBuildWorker` to be on by default. This flag enables logic inside Next.js to run the compilation in an isolated worker. The reason for this is that the webpack compilation process retains a lot of memory for the whole duration of th...
[ { "path": "errors/webpack-build-worker-opt-out.mdx", "patch": "@@ -0,0 +1,15 @@\n+---\n+title: Webpack Build Worker automatic opt-out\n+---\n+\n+## Webpack Build Worker Opt-out\n+\n+#### Why This Error Occurred\n+\n+The Next.js config contains custom webpack configuration, as a result, the webpack build wor...
2023-10-26T04:19:29
facebook/react
70a0746e9f9877c69edc6a2ef7716c928b71841b
1e980a146f2e500c4beaac2240b0a072eedb70d5
Fix react tests
[ { "path": "src/core/__tests__/ReactRenderDocument-test.js", "patch": "@@ -58,7 +58,7 @@ describe('rendering React components at document', function() {\n });\n \n React.renderComponentToString(<Root />, function(markup) {\n- testDocument.innerHTML = markup;\n+ testDocument = getTestDocumen...
2014-01-07T02:22:09
golang/go
4a954fafa3bc294ac56d5aea19dc3b0b3124d4c0
8892a51745accb2f8d18be1628d9b5bb9ecd78a5
cmd/compile/internal/types2: match go/types for "..." related error msg For #54511. Change-Id: I571680dfc25d7b7198e84e11bd311ab8b24d72d9 Reviewed-on: https://go-review.googlesource.com/c/go/+/424818 Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Run-TryBot: Robert Gri...
[ { "path": "src/cmd/compile/internal/types2/call.go", "patch": "@@ -137,7 +137,7 @@ func (check *Checker) callExpr(x *operand, call *syntax.CallExpr) exprKind {\n \t\t\t\t\t}\n \t\t\t\t}\n \t\t\t\tif call.HasDots {\n-\t\t\t\t\tcheck.errorf(call.ArgList[0], \"invalid use of ... in type conversion to %s\", T)\...
2022-08-18T17:40:31
electron/electron
b0487b7d8431bf38d351f38f940bf9d468bc8423
1bf8270c0d61a6df8a9071485520a2972db00a4e
Fix wrong signature for gtk's ShowSaveDialog()
[ { "path": "atom/browser/ui/file_dialog_gtk.cc", "patch": "@@ -298,6 +298,9 @@ void ShowSaveDialog(atom::NativeWindow* parent_window,\n const std::string& button_label,\n const base::FilePath& default_path,\n const Filters& filters,\n+ ...
2017-02-02T13:01:02
nodejs/node
d4fd03e67371ef8db8c47d2981bbee9601700034
83ebd7731852369fa08fb5885c7fcf7b671bce91
doc: fix return type of `crypto.getFips()` `crypto.getFips()` returns a number, not a boolean. PR-URL: https://github.com/nodejs/node/pull/32580 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <ann...
[ { "path": "doc/api/crypto.md", "patch": "@@ -2308,8 +2308,8 @@ console.log(aliceSecret === bobSecret);\n added: v10.0.0\n -->\n \n-* Returns: {boolean} `true` if and only if a FIPS compliant crypto provider is\n- currently in use.\n+* Returns: {number} `1` if and only if a FIPS compliant crypto provider is...
2020-03-31T10:51:47
vercel/next.js
63b7b90985c35611e8f9cd693507f5d04004d099
7c0e66f8d8a18c8f7fdb0eaa510389e9cd48ea03
Fix Regex (#57461) It should be `\.` here.
[ { "path": "packages/next/webpack.config.js", "patch": "@@ -216,7 +216,7 @@ module.exports = ({ dev, turbo, bundleType, experimental }) => {\n module: {\n rules: [\n {\n- include: /[\\\\/]react-server.node/,\n+ include: /[\\\\/]react-server\\.node/,\n layer: 'rea...
2023-10-26T04:07:13
facebook/react
1e980a146f2e500c4beaac2240b0a072eedb70d5
57f208e4025837bcbb96a6299c68586f0ce174a0
Fix bug in cloneWithProps()
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -1231,6 +1231,7 @@ var ReactCompositeComponent = {\n return instance;\n };\n ConvenienceConstructor.componentConstructor = Constructor;\n+ Constructor.ConvenienceConstructor = ConvenienceConstructor;\n ConvenienceConstructor....
2014-01-07T02:20:54
golang/go
9b48ffa98af149408b8e4734676bcc2cf95278fd
0a1da095d1cef7c8ac6065da2983565b450566a5
go/parser: disallow parenthesizing embedded types in structs This was never permitted in Go but the flexibility to do so was introduced through the generics prototype code where we experimented with parentheses to enclose type parameters. Restore original (pre-generics) behavior. Fixes #51655. Change-Id: Ia7a4b2e393...
[ { "path": "src/go/parser/parser.go", "patch": "@@ -643,7 +643,8 @@ func (p *parser) parseFieldDecl() *ast.Field {\n \n \tvar names []*ast.Ident\n \tvar typ ast.Expr\n-\tif p.tok == token.IDENT {\n+\tswitch p.tok {\n+\tcase token.IDENT:\n \t\tname := p.parseIdent()\n \t\tif p.tok == token.PERIOD || p.tok == ...
2022-08-18T03:11:57
rust-lang/rust
dd3b8255ca6215b5129181ceb6912aed1370bdce
26c12c746296e01c2dc13d8078b0a2f1569fcb1c
Do not suggest pinning missing `.get_ref()` When suggesting field access which would encounter a method not found, do not suggest pinning when those methods are on `impl Pin` itself. ``` error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope --> $DIR/missing-field-access.r...
[ { "path": "compiler/rustc_hir_typeck/src/method/suggest.rs", "patch": "@@ -3585,6 +3585,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {\n self.tcx.lang_items().deref_trait(),\n self.tcx.lang_items().deref_mut_trait(),\n self.tcx.lang_items().drop_trait(),\n+ ...
2025-07-29T20:14:02
electron/electron
1bf8270c0d61a6df8a9071485520a2972db00a4e
8843fef06587f6e8a91cb9c97cdae4b41deddc87
:checkered_flag: Fix dialog method calls for Windows
[ { "path": "atom/browser/ui/file_dialog_win.cc", "patch": "@@ -169,7 +169,7 @@ void RunOpenDialogInNewThread(const RunState& run_state,\n const OpenDialogCallback& callback) {\n std::vector<base::FilePath> paths;\n bool result = ShowOpenDialog(parent, title, button_label, de...
2017-02-02T12:21:20
nodejs/node
83ebd7731852369fa08fb5885c7fcf7b671bce91
e629366fc6c41b81e554fea0413ad1fac53adf36
test: replace console.error() with debuglog calls Somehow thought I did this in 8905be2ceea9abead85a5018c09645a3650d7495 but clearly did not. PR-URL: https://github.com/nodejs/node/pull/32588 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <ricl...
[ { "path": "test/parallel/test-http-information-processing.js", "patch": "@@ -2,16 +2,17 @@\n require('../common');\n const assert = require('assert');\n const http = require('http');\n+const debug = require('util').debuglog('test');\n \n const testResBody = 'other stuff!\\n';\n const kMessageCount = 2;\n \n...
2020-03-31T20:30:44
vercel/next.js
7c0e66f8d8a18c8f7fdb0eaa510389e9cd48ea03
668820100a36abcae16425b90b6ad4dfd5780493
turbopack: Fix Server Actions in Edge runtime (#57462) ### What? Changes Server Actions to use a lazy `require()` statement instead of a lazy dynamic `import()`, to fix SA in the Edge runtime. ### Why? The Edge runtime has a restriction that it's not allowed to lazy load more files. The problem is that dyna...
[ { "path": "packages/next-swc/crates/next-api/src/server_actions.rs", "patch": "@@ -95,17 +95,14 @@ async fn build_server_actions_loader(\n for (hash_id, name) in &*actions_map.await? {\n writedoc!(\n contents,\n- \"\n- \\x20 '{hash_id}': (......
2023-10-26T03:51:11
facebook/react
fb858a8fc2d3e125703d485c8b29a31cddd323e3
8f2509e169713b03a4a053ba9532b4933ba6747b
Set event type on enter/leave events Fixes #444.
[ { "path": "src/eventPlugins/EnterLeaveEventPlugin.js", "patch": "@@ -105,6 +105,7 @@ var EnterLeaveEventPlugin = {\n fromID,\n nativeEvent\n );\n+ leave.type = 'mouseleave';\n leave.target = from;\n leave.relatedTarget = to;\n \n@@ -113,6 +114,7 @@ var EnterLeaveEventPlugin = {\n ...
2014-01-01T00:28:59
rust-lang/rust
26c12c746296e01c2dc13d8078b0a2f1569fcb1c
2fd855fbfc8239285aa2d596f76a8cc75e17ce02
Account for bare tuples in field searching logic When looking for the field names and types of a given type, account for tuples. This allows suggestions for incorrectly nested field accesses and field name typos to trigger as intended. Previously these suggestions only worked on `ty::Adt`, including tuple structs whic...
[ { "path": "compiler/rustc_hir_typeck/src/expr.rs", "patch": "@@ -3321,18 +3321,17 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {\n } else {\n (base_ty, \"\")\n };\n- for (found_fields, args) in\n+ for found_fields in\n self.get_field_candidates_considering_privacy...
2025-07-29T18:39:16
golang/go
dc8e2a6a8ec94f2c98ba20edd57932eba284efb1
7dad1d24b2e596b2178c1f94fe877c9effa330cd
io: add OffsetWriter, NewOffsetWriter Offsetwriter refers to the design of SectionReader and removes the section parameter n. Since the size of the written data is determined by the user, we cannot know where the end offset of the original data is. The offset of SeekEnd is not valid in Seek method. Fixes #45899. Ch...
[ { "path": "api/next/45899.txt", "patch": "@@ -0,0 +1,5 @@\n+pkg io, type OffsetWriter struct #45899\n+pkg io, func NewOffsetWriter(WriterAt, int64) *OffsetWriter #45899\n+pkg io, method (*OffsetWriter) Write([]uint8) (int, error) #45899\n+pkg io, method (*OffsetWriter) WriteAt([]uint8, int64) (int, error) #...
2022-05-17T03:24:03
electron/electron
a3c5eafb16bf905c690b0fe347e1ec7fe4fa53f7
90492df1cbbe1ad8535c4b4befada4ee1b354a25
Update libchromiumcontent to include debug symbols
[ { "path": "script/lib/config.py", "patch": "@@ -9,7 +9,7 @@\n BASE_URL = os.getenv('LIBCHROMIUMCONTENT_MIRROR') or \\\n 'https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent'\n LIBCHROMIUMCONTENT_COMMIT = os.getenv('LIBCHROMIUMCONTENT_COMMIT') or \\\n- 'e0da1e9caa7c8f3da3519963a9ea32abb...
2017-02-08T05:28:34
nodejs/node
f621536d8160d3305e8b384e779ed91716c77921
79478113d4b405051a14678fdf2d5fd4b88b90f8
Revert "embedding: make Stop() stop Workers" This reverts commit 037ac99ed5aa763b7a3567da2cc81f9d7b97bdf9. As flaky CI failures have revealed, this feature was implemented incorrectly. `stop_sub_worker_contexts()` needs to be called on the thread on which the `Environment` is currently running, it’s not thread-safe. ...
[ { "path": "src/api/environment.cc", "patch": "@@ -725,7 +725,8 @@ ThreadId AllocateEnvironmentThreadId() {\n }\n \n void DefaultProcessExitHandler(Environment* env, int exit_code) {\n- Stop(env);\n+ env->set_can_call_into_js(false);\n+ env->stop_sub_worker_contexts();\n DisposePlatform();\n exit(exit...
2020-04-02T21:40:25
facebook/react
22ba8b67f136915de9d1b76384b78f4de5d75d15
e65726cd04bf0b270641aab6f57c1192c9cd8a66
Silence console.error in ReactDOMInput-test This test is expected to throw but because of ReactErrorUtils.guard which uses console.error in __DEV__ it also logged the invariant error to the console. This change fixes it by temporarily stubbing out console.error. Fixes #531
[ { "path": "src/dom/components/__tests__/ReactDOMInput-test.js", "patch": "@@ -199,6 +199,11 @@ describe('ReactDOMInput', function() {\n });\n \n it('should throw if both value and valueLink are provided', function() {\n+ // Silences console.error messages\n+ // ReactErrorUtils.guard is applied to ...
2014-01-06T17:43:51
vercel/next.js
4bf19d9da8772f8a5e4f51fefc2d100646c55b3c
185623363ba96d157af69d0ff2f68b2b8c435d98
normalize pattern correctly to avoid slow path in matching (vercel/turbo#6288) ### Description fixes a performance problem with read_matches ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes WEB-1875
[ { "path": "crates/turbopack-core/src/resolve/pattern.rs", "patch": "@@ -4,6 +4,7 @@ use anyhow::Result;\n use lazy_static::lazy_static;\n use regex::Regex;\n use serde::{Deserialize, Serialize};\n+use tracing::Instrument;\n use turbo_tasks::{trace::TraceRawVcs, Value, ValueToString, Vc};\n use turbo_tasks_f...
2023-10-26T03:34:28
rust-lang/rust
99196657fcb5c1e20c13e76166c7f52d35584e88
2fd855fbfc8239285aa2d596f76a8cc75e17ce02
Use `tcx.short_string()` in more diagnostics `TyCtxt::short_string` ensures that user visible type paths aren't overwhelming on the terminal output, and properly saves the long name to disk as a side-channel. We already use these throughout the compiler and have been using them as needed when users find cases where th...
[ { "path": "compiler/rustc_errors/src/diagnostic.rs", "patch": "@@ -1382,6 +1382,11 @@ impl<'a, G: EmissionGuarantee> Diag<'a, G> {\n &mut self.long_ty_path\n }\n \n+ pub fn with_long_ty_path(mut self, long_ty_path: Option<PathBuf>) -> Self {\n+ self.long_ty_path = long_ty_path;\n+ ...
2025-07-16T19:45:07
electron/electron
90492df1cbbe1ad8535c4b4befada4ee1b354a25
9163b601a4c319df977ff0c5d22e59cd2418aa37
Fix exception when executing create-dist directly
[ { "path": "script/create-dist.py", "patch": "@@ -132,9 +132,13 @@ def copy_license():\n shutil.copy2(os.path.join(SOURCE_ROOT, 'LICENSE'), DIST_DIR)\n \n def create_api_json_schema():\n+ node_bin_dir = os.path.join(SOURCE_ROOT, 'node_modules', '.bin')\n+ env = os.environ.copy()\n+ env['PATH'] = os.path...
2017-02-08T05:24:56
golang/go
48297f1fb15206cd13e0f31647e909292fb21975
f65ded56263a9dd7d125f2b0001fb996df1fb3f3
unicode/utf16: add AppendRune AppendRune appends the UTF-16 encoding of a rune to a []uint16. BenchmarkEncodeValidASCII-12 24.61ns 16B 1allocs BenchmarkEncodeValidJapaneseChars-12 18.79ns 8B 1allocs BenchmarkAppendRuneValidASCII-12 6.826ns 0B 0allocs BenchmarkAppendR...
[ { "path": "api/next/51896.txt", "patch": "@@ -0,0 +1 @@\n+pkg unicode/utf16, func AppendRune([]uint16, int32) []uint16 #51896\n\\ No newline at end of file", "additions": 1, "deletions": 0, "language": "Plain Text" }, { "path": "src/unicode/utf16/utf16.go", "patch": "@@ -83,6 +83,23 ...
2022-05-27T13:44:55
facebook/react
089a494a1f0cc1892f1525fd746bac10c5a55175
9b3342ed3425ae89007811dd8b5b2b20918ad6d4
Forbid full-page rendering without server rendering Final part of server rendering cleanup. We should only support full-page rendering when server rendering is involved since otherwise it's slow and can crash browsers when you start adding and removing document roots. This diff removes the magic innerHTML code (since ...
[ { "path": "src/core/ReactComponentBrowserEnvironment.js", "patch": "@@ -27,7 +27,6 @@ var ReactReconcileTransaction = require('ReactReconcileTransaction');\n \n var getReactRootElementInContainer = require('getReactRootElementInContainer');\n var invariant = require('invariant');\n-var mutateHTMLNodeWithMar...
2014-01-06T17:36:38
nodejs/node
79478113d4b405051a14678fdf2d5fd4b88b90f8
1917ba851bd8851a3f27f56b1c1f4b5476cdc124
doc: clarify `requireManualDestroy` option Fixes: https://github.com/nodejs/node/issues/32409 PR-URL: https://github.com/nodejs/node/pull/32514 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vladimir de Turck...
[ { "path": "doc/api/async_hooks.md", "patch": "@@ -681,10 +681,10 @@ asyncResource.triggerAsyncId();\n * `options` {Object}\n * `triggerAsyncId` {number} The ID of the execution context that created this\n async event. **Default:** `executionAsyncId()`.\n- * `requireManualDestroy` {boolean} Disables aut...
2020-03-27T06:22:45
vercel/next.js
b118ffd1541c1fe9bbfb6ae10c3295551cbe3148
6b6eddb50e6017dd0b054137508c7dd8fec5481e
misc: fix build output (#57466) mark dynamic routes as always dynamic <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're maki...
[ { "path": "packages/next/src/build/utils.ts", "patch": "@@ -461,9 +461,9 @@ export async function printTreeView(\n symbol = 'ℇ'\n } else if (pageInfo?.isPPR) {\n // If the page has an empty prelude, then it's equivalent to a static page.\n- if (pageInfo?.hasEmptyPrelude) {\n+ ...
2023-10-26T02:51:43
rust-lang/rust
cdb299c0d8463d7e66b680e93c8d0d7258fc7643
dc0bae1db725fbba8524f195f74f680995fd549e
Enable f16 and f128 on targets that were fixed in LLVM21 LLVM21 fixed the new float types on a number of targets: * SystemZ gained f16 support https://github.com/llvm/llvm-project/pull/109164 * Hexagon now uses soft f16 to avoid recursion bugs https://github.com/llvm/llvm-project/pull/130977 * Mips now correctly ...
[ { "path": "compiler/rustc_codegen_llvm/src/llvm_util.rs", "patch": "@@ -371,24 +371,25 @@ fn update_target_reliable_float_cfg(sess: &Session, cfg: &mut TargetConfig) {\n let target_abi = sess.target.options.abi.as_ref();\n let target_pointer_width = sess.target.pointer_width;\n let version = get...
2025-08-06T08:57:14
electron/electron
9c134e7bf39c955f610f7633374f76bbc34bd899
6b56dfd94b9dccb88b0e58ae03dacd5079cdb995
Assert certificate error
[ { "path": "spec/api-session-spec.js", "patch": "@@ -558,6 +558,7 @@ describe('session module', function () {\n \n it('accepts the request when the callback is called with true', function (done) {\n session.defaultSession.setCertificateVerifyProc(function (hostname, certificate, error, callback) {\...
2017-02-07T23:39:18
golang/go
3204e62dd1abe087430e37e8c33c3d010606aabe
d654117075d1dd0686aa6833b22f28275623c759
syscall: add new CLONE_ flags for Linux The constants for these were auto-generated from the C includes into zerrors_linux* files quite some time ago. The generator is currently broken, but some new flags need to be added nevertheless. As the flags won't change and the values are the same for all architectures, we ca...
[ { "path": "api/next/51246.txt", "patch": "@@ -0,0 +1,60 @@\n+pkg syscall (linux-386), const CLONE_CLEAR_SIGHAND = 4294967296 #51246\n+pkg syscall (linux-386), const CLONE_CLEAR_SIGHAND ideal-int #51246\n+pkg syscall (linux-386), const CLONE_INTO_CGROUP = 8589934592 #51246\n+pkg syscall (linux-386), const CL...
2022-05-20T05:25:42
nodejs/node
1917ba851bd8851a3f27f56b1c1f4b5476cdc124
9129ab1996251245b06d8df599634d31c75849ca
doc: fix wordy sentence PR-URL: https://github.com/nodejs/node/pull/32567 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
[ { "path": "doc/guides/contributing/code-of-conduct.md", "patch": "@@ -26,9 +26,9 @@ All contributors to Node.js tacitly agree to abide by both the letter and\n spirit of the [Code of Conduct][]. Failure, or unwillingness, to do so will\n result in contributions being respectfully declined.\n \n-A *bad actor...
2020-03-30T14:11:43
vercel/next.js
6b6eddb50e6017dd0b054137508c7dd8fec5481e
0052c59022f2a56bb3edba87e44a18993f1d6ef3
misc: fix unhandled err worker hook (#57465) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ...
[ { "path": "packages/next/src/export/index.ts", "patch": "@@ -54,7 +54,6 @@ import { isAppPageRoute } from '../lib/is-app-page-route'\n import isError from '../lib/is-error'\n import { needsExperimentalReact } from '../lib/needs-experimental-react'\n import { formatManifest } from '../build/manifests/formatt...
2023-10-26T02:51:11
rust-lang/rust
163594c8f81fc6bb8bb37645eac2f3b7da0be518
cd434309efcf5dc68b253e5ef6ba40c1c43711c9
Add regression test for `saturating_sub` bounds check issue Add codegen test for issue where `valid_index.saturating_sub(X)` produced an extra bounds check. This was fixed by the LLVM upgrade.
[ { "path": "tests/codegen-llvm/issues/saturating-sub-index-139759.rs", "patch": "@@ -0,0 +1,19 @@\n+// Test that calculating an index with saturating subtraction from an in-bounds\n+// index doesn't generate another bounds check.\n+\n+//@ compile-flags: -Copt-level=3\n+//@ min-llvm-version: 21\n+\n+#![crate_...
2025-08-07T18:22:58
electron/electron
e29b64a18ae03df38beec6550d28ad64d57987b1
d00a96ce356425f5a0c751f236259dbbc8265c32
modify CertVerifier Class * respond to multiple similar verification requests. * accept net error result as callback response.
[ { "path": "atom/browser/api/atom_api_session.cc", "patch": "@@ -738,7 +738,7 @@ void Session::BuildPrototype(v8::Isolate* isolate,\n .SetMethod(\"setDownloadPath\", &Session::SetDownloadPath)\n .SetMethod(\"enableNetworkEmulation\", &Session::EnableNetworkEmulation)\n .SetMethod(\"disableN...
2016-11-09T13:05:46
golang/go
f15761b50bb3a2d1bae9b97f147b2d660e2e4853
dee9adc0f73d361d00a4d9230bb3517f2448b3b0
runtime: fix formula for computing number of padding bytes In order to prevent false sharing of cache lines, structs are padded with some number of bytes. These bytes are unused, serving only to make the size of the struct a multiple of the size of the cache line. The current calculation of how much to pad is an over...
[ { "path": "src/runtime/mheap.go", "patch": "@@ -200,7 +200,7 @@ type mheap struct {\n \t// central is indexed by spanClass.\n \tcentral [numSpanClasses]struct {\n \t\tmcentral mcentral\n-\t\tpad [cpu.CacheLinePadSize - unsafe.Sizeof(mcentral{})%cpu.CacheLinePadSize]byte\n+\t\tpad [(cpu.CacheLinePa...
2022-06-25T20:27:11
nodejs/node
f36e2487581845cfc645ea30dfa73cf55910a980
12a2997bed0efa80d17b498d28c2186b6f73bdaf
test: fix python-version selection with actions s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python PR-URL: https://github.com/nodejs/node/pull/32609 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm....
[ { "path": ".github/workflows/build-windows.yml", "patch": "@@ -14,7 +14,7 @@ jobs:\n - name: Set up Python ${{ env.PYTHON_VERSION }}\n uses: actions/setup-python@v1\n with:\n- PYTHON_VERSION: ${{ env.PYTHON_VERSION }}\n+ python-version: ${{ env.PYTHON_VERSION }}\n ...
2020-04-02T03:06:51
vercel/next.js
0052c59022f2a56bb3edba87e44a18993f1d6ef3
f412c8a9918143850b21fc16322e7113e2f0bfaa
add better messaging around wrapping postpone with try/catch (#57446) when calls to `maybePostpone` throw but there's no postpone state, we want to handle those errors differently so that we can provide clearer messaging around how to prevent them, while still retaining any errors that were re-thrown by the user. ex:...
[ { "path": "errors/ppr-postpone-error.mdx", "patch": "@@ -0,0 +1,11 @@\n+---\n+title: Understanding the postpone error triggered during static generation\n+---\n+\n+## Why This Error Occurred\n+\n+When Partial Prerendering (PPR) is enabled, using APIs that opt into Dynamic Rendering like `cookies`, `headers`...
2023-10-26T02:50:58
rust-lang/rust
d37fae309d66ea337269eeb46a990f0675ad1684
919c40924373c248315a76618d8c52d39aed5e6e
Pass -Werror when building the LLVM wrapper Enabling warning_into_errors() only whether it's in rust-lang/rust CI, so deprecated uses of LLVM methods can be treated as errors.
[ { "path": "compiler/rustc_llvm/build.rs", "patch": "@@ -171,6 +171,16 @@ fn main() {\n let cxxflags = output(&mut cmd);\n let mut cfg = cc::Build::new();\n cfg.warnings(false);\n+\n+ // Prevent critical warnings when we're compiling from rust-lang/rust CI,\n+ // except on MSVC, as the comp...
2025-07-11T16:28:45
electron/electron
24ef8cc8ced46aa459e1daf5961a236071e51ade
73e753ef9ab9664695fc3a02d4edfc802fe31e48
hardcode module path in error message
[ { "path": "npm/index.js", "patch": "@@ -6,5 +6,5 @@ var pathFile = path.join(__dirname, 'path.txt')\n if (fs.existsSync(pathFile)) {\n module.exports = path.join(__dirname, fs.readFileSync(pathFile, 'utf-8'))\n } else {\n- throw new Error('Electron failed to install correctly, please delete node_modules/...
2017-02-08T19:36:38
golang/go
dee9adc0f73d361d00a4d9230bb3517f2448b3b0
f324355d1f482362b87ec4f95ceac00d4b4de797
encoding/gob: use saferio to read large buffer Avoid allocating large amounts of memory for corrupt input. No test case because the problem can only happen for invalid data. Let the fuzzer find cases like this. Fixes #53369 Change-Id: I67c5e75bf181ad84988d6d6da12507df0e6df8e8 Reviewed-on: https://go-review.googleso...
[ { "path": "src/encoding/gob/decode.go", "patch": "@@ -57,17 +57,6 @@ func (d *decBuffer) Drop(n int) {\n \td.offset += n\n }\n \n-// Size grows the buffer to exactly n bytes, so d.Bytes() will\n-// return a slice of length n. Existing data is first discarded.\n-func (d *decBuffer) Size(n int) {\n-\td.Reset(...
2022-06-25T00:00:24
nodejs/node
12a2997bed0efa80d17b498d28c2186b6f73bdaf
a4dce9ab86a29534ba91c5c46df4983ee265b532
src: fix extra includes of "env.h" and "env-inl.h" Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. ...
[ { "path": "src/node_crypto_common.h", "patch": "@@ -3,7 +3,6 @@\n \n #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS\n \n-#include \"env.h\"\n #include \"node_crypto.h\"\n #include \"v8.h\"\n #include <openssl/ssl.h>", "additions": 0, "deletions": 1, "language": "C/C++ Header" }, { ...
2020-03-16T03:22:33
facebook/react
5b43a2e6d734d7a84b2335c87282eddd7cf3776a
605b42e622c187f66d02e22d7e372ff8993b5481
throw error when setState's arguments are bad
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -768,6 +768,10 @@ var ReactCompositeComponentMixin = {\n * @protected\n */\n setState: function(partialState, callback) {\n+ invariant(\n+ typeof partialState === 'object' || partialState == null,\n+ 'setState(...): takes an ...
2014-01-06T02:01:07
vercel/next.js
fcc2b6fa15d8d3379cef72bdd4ed136c59829dcc
8fa15f4c77d6e89bdd0e273f73ebd7ed1b334861
Ignore postponed rejections (#57456) We also don't warn for awaiting a Promise late. That's a fine pattern in Next.js because it allows for fetching early and awaiting late. If a Promise does reject before that we still log an error which is fine because an error actually did happen even if we didn't await it. ...
[ { "path": "packages/next/src/export/index.ts", "patch": "@@ -54,6 +54,7 @@ import { isAppPageRoute } from '../lib/is-app-page-route'\n import isError from '../lib/is-error'\n import { needsExperimentalReact } from '../lib/needs-experimental-react'\n import { formatManifest } from '../build/manifests/formatt...
2023-10-26T00:53:01
rust-lang/rust
186cef0f517816cc655316691ebea665dbdb3e49
9b1a30e5e69e1537ef6eb6eb829eb47075206dea
Move metadata symbol export from exported_non_generic_symbols to exported_symbols The metadata symbol must not be encoded in the crate metadata, and must be exported from proc-macros. Handling the export of the metadata symbol in exported_symbols handles both things at once without requiring manual fixups elsewhere.
[ { "path": "compiler/rustc_codegen_ssa/src/back/linker.rs", "patch": "@@ -1805,11 +1805,18 @@ pub(crate) fn exported_symbols(\n .collect();\n }\n \n- if let CrateType::ProcMacro = crate_type {\n+ let mut symbols = if let CrateType::ProcMacro = crate_type {\n exported_symbols_for...
2025-08-07T14:30:43
electron/electron
090255c3f43fc1d721edba8d8b404f387d89e3e1
84f8bfbdefb3307b0488898be1a1de5d0c1ef1f9
Upgrade node for require wrapper `this` fix
[ { "path": "vendor/node", "patch": "@@ -1 +1 @@\n-Subproject commit be4f9967b2c5e8ce78647f37d44928e028e9f750\n+Subproject commit b64908216a6d5f84862b2b947985a513a6521cb3", "additions": 1, "deletions": 1, "language": "Unknown" } ]
2017-02-07T16:52:11
golang/go
6001c043dc067b7f6b9a2e934439b6a7948f92ef
011a525b21c77c8a11e54c5b15cb10761baf1925
test: add test that caused gccgo crash For #23870 Change-Id: I3bbe0f751254d1354a59a88b45e6f944c7a2fb4d Reviewed-on: https://go-review.googlesource.com/c/go/+/417874 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: ...
[ { "path": "test/fixedbugs/issue23870.go", "patch": "@@ -0,0 +1,16 @@\n+// compile\n+\n+// Copyright 2022 The Go Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style\n+// license that can be found in the LICENSE file.\n+\n+// Crashed gccgo.\n+\n+package p\n+\n+var F func() [0...
2022-07-16T01:41:41
facebook/react
33dcf8a0b57ed05ef675a714ab8762e9ae7471ed
80d7d2d0f8ec0f4f1f3c2dbe613f36bda572ce11
Set currentTarget on synthetic events Fixes #658, fixes #659.
[ { "path": "src/core/ReactDefaultInjection.js", "patch": "@@ -29,6 +29,7 @@ var ReactDOMSelect = require('ReactDOMSelect');\n var ReactDOMTextarea = require('ReactDOMTextarea');\n var ReactEventEmitter = require('ReactEventEmitter');\n var ReactEventTopLevelCallback = require('ReactEventTopLevelCallback');\n...
2013-12-30T18:52:43
vercel/next.js
43150fc67744ef16a732d19391707e8b835ae6ee
5ad8ada198ee1ca4a147aa5a64986314ee430320
Turbopack: Improve error handling (#57386) ### What? * avoid some crash with server actions parsing * don't send serverComponentChanges when there are errors ### Why? ### How? Closes WEB-1852
[ { "path": "packages/next/src/build/swc/index.ts", "patch": "@@ -534,15 +534,6 @@ export interface UpdateInfo {\n tasks: number\n }\n \n-export enum ServerClientChangeType {\n- Server = 'Server',\n- Client = 'Client',\n- Both = 'Both',\n-}\n-export interface ServerClientChange {\n- type: ServerClientCh...
2023-10-25T23:59:38
nodejs/node
ff2f47d78651923a59996f66097e09ef2615f82f
579e6b95aee561d8ddd3e3663fa7a588c6449334
worker: support MessagePort to workers data PR-URL: https://github.com/nodejs/node/pull/32278 Fixes: https://github.com/nodejs/node/issues/32250 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "doc/api/worker_threads.md", "patch": "@@ -513,6 +513,9 @@ if (isMainThread) {\n <!-- YAML\n added: v10.5.0\n changes:\n+ - version: REPLACEME\n+ pr-url: https://github.com/nodejs/node/pull/32278\n+ description: The `transferList` option was introduced.\n - version: v13.12.0\n pr-url:...
2020-03-14T23:11:03
electron/electron
11e1f6b56c15a7ea1edf964bbbc27e8c2e734627
ed44b32ff58348275b3e7c2d4888e9ddf31aa4d2
Fix lint errors
[ { "path": "atom/browser/api/atom_api_web_contents.cc", "patch": "@@ -1494,13 +1494,14 @@ void WebContents::Invalidate() {\n web_contents()->GetRenderWidgetHostView());\n if (osr_rwhv)\n osr_rwhv->Invalidate();\n- }\n- else {\n+ } else {\n const auto ownerWindow = owner_window();\n- ...
2017-02-08T08:05:16
facebook/react
80d7d2d0f8ec0f4f1f3c2dbe613f36bda572ce11
a575e93ecdda5c2027e42cee9bd5cd109723e468
Listen to events on demand Fixes #381 This is a squashed version of https://github.com/facebook/react/pull/462
[ { "path": "src/core/React.js", "patch": "@@ -19,6 +19,7 @@\n \"use strict\";\n \n var DOMPropertyOperations = require('DOMPropertyOperations');\n+var EventPluginUtils = require('EventPluginUtils');\n var ReactComponent = require('ReactComponent');\n var ReactCompositeComponent = require('ReactCompositeCompo...
2014-01-04T07:09:59
golang/go
011a525b21c77c8a11e54c5b15cb10761baf1925
a409356c548133e188acd7873e73a66ff5982b57
test: add test that caused gccgo to crash For #23868 Change-Id: I07b001836e8d1411609ab84786398a5b575bf8d5 Reviewed-on: https://go-review.googlesource.com/c/go/+/417481 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-b...
[ { "path": "test/fixedbugs/issue23868.go", "patch": "@@ -0,0 +1,14 @@\n+// compile\n+\n+// Copyright 2022 The Go Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style\n+// license that can be found in the LICENSE file.\n+\n+// Crashed gccgo.\n+\n+package p\n+\n+var F func([0]i...
2022-07-14T01:31:30
vercel/next.js
0f55e292cf08c4bd31f8ff682913254a602e69b2
32e2317b670f1e8b04752932c74022d12dfa73dd
fix(next-core): fix determining dynamic route (#57435) ### What Fixes how to determine if given route is dynamic to match next-dev does: https://github.com/vercel/next.js/blob/462b8585b61b83fa079f40e2d8432cc643bf0713/packages/next/src/lib/metadata/get-metadata-route.ts#L79 We were passing calculated route ins...
[ { "path": "packages/next-swc/crates/next-core/src/app_structure.rs", "patch": "@@ -128,9 +128,7 @@ pub async fn get_metadata_route_name(meta: MetadataItem) -> Result<Vc<String>> {\n };\n \n match stem.as_str() {\n- \"robots\" => Vc::cell(\"robots.txt\".to_string()),\n ...
2023-10-25T23:29:39
nodejs/node
579e6b95aee561d8ddd3e3663fa7a588c6449334
6480f89b771ac460ca08987a60246bb93ed629e2
test: replace console.log() with debuglog() PR-URL: https://github.com/nodejs/node/pull/32550 Refs: https://github.com/nodejs/node/pull/32541 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@...
[ { "path": "test/parallel/test-process-exit-code.js", "patch": "@@ -22,6 +22,7 @@\n 'use strict';\n require('../common');\n const assert = require('assert');\n+const debug = require('util').debuglog('test');\n \n const testCases = require('../fixtures/process-exit-code-cases');\n \n@@ -30,7 +31,7 @@ if (!pro...
2020-03-29T17:27:51
rust-lang/rust
202963f2215245180fa985f3640a582554656253
e3aae6162e7f0bdacb8b41c7b2f1d92100a0c476
add multiple known-bugs for the linked-list cursor-like pattern of 46859/48001 these are fixed by polonius=legacy, are currently accepted by polonius=next but won't be by the alpha analysis
[ { "path": "tests/ui/nll/polonius/iterating-updating-cursor-issue-108704.nll.stderr", "patch": "@@ -0,0 +1,12 @@\n+error[E0499]: cannot borrow `*elements` as mutable more than once at a time\n+ --> $DIR/iterating-updating-cursor-issue-108704.rs:40:26\n+ |\n+LL | for (idx, el) in elements.iter_mut(...
2025-08-07T13:33:35
facebook/react
309a88bcf62c1c64a2b91c0eb753c19209a425b2
a575e93ecdda5c2027e42cee9bd5cd109723e468
Prefer textContent to innerText Fixes #807.
[ { "path": "src/dom/getTextContentAccessor.js", "patch": "@@ -30,9 +30,11 @@ var contentKey = null;\n */\n function getTextContentAccessor() {\n if (!contentKey && ExecutionEnvironment.canUseDOM) {\n- contentKey = 'innerText' in document.createElement('div') ?\n- 'innerText' :\n- 'textContent...
2014-01-04T06:56:27
electron/electron
a9dae243b4df683c6cd07e0ee38364200e4a47c1
c810e64fdafa0f4de4bd5864bda337f5f3ea2904
Fix large icon spec
[ { "path": "spec/api-app-spec.js", "patch": "@@ -508,11 +508,11 @@ describe('app module', function () {\n if (process.platform === 'darwin') {\n return this.skip() // macOS does not support large icons\n }\n- app.getFileIcon(iconPath, { size: 'normal' }, function (err, icon) ...
2016-11-11T06:32:41
golang/go
a409356c548133e188acd7873e73a66ff5982b57
55ecc3a88670c14bbbfc9d6c96cf65891cc608f5
misc/cgo/testcarchive: permit SIGQUIT for TestSignalForwardingExternal Occasionally the signal will be sent to a Go thread, which will cause the program to exit with SIGQUIT rather than SIGSEGV. Add TestSignalForwardingGo to test the case where the signal is expected to be delivered to a Go thread. Fixes #53907 Cha...
[ { "path": "misc/cgo/testcarchive/carchive_test.go", "patch": "@@ -19,6 +19,7 @@ import (\n \t\"runtime\"\n \t\"strconv\"\n \t\"strings\"\n+\t\"sync\"\n \t\"syscall\"\n \t\"testing\"\n \t\"time\"\n@@ -526,38 +527,13 @@ func TestEarlySignalHandler(t *testing.T) {\n \n func TestSignalForwarding(t *testing.T) {...
2022-07-21T23:49:48
vercel/next.js
32e2317b670f1e8b04752932c74022d12dfa73dd
17bd232cf21c1e0105ec06f8513ff6e3e7f8d7d1
fix(turbopack): don't emit issues when parsing the segment config for non js files (#57452) ### Why? Calling `parse` will emit issues with error severity, causing the build to get marked as failed Closes WEB-1869
[ { "path": "packages/next-swc/crates/next-core/src/app_segment_config.rs", "patch": "@@ -211,6 +211,16 @@ pub async fn parse_segment_config_from_source(\n ) -> Result<Vc<NextSegmentConfig>> {\n let path = source.ident().path().await?;\n \n+ // Don't try parsing if it's not a javascript file, otherwise...
2023-10-25T23:29:11
nodejs/node
882b61a7eef16b373c769339e4246322b75922ad
77f9e0c814e1fafef2e84eabd24c135748217b26
doc: fix more links Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: https://github.com/...
[ { "path": "GOVERNANCE.md", "patch": "@@ -7,7 +7,7 @@\n * [Technical Steering Committee](#technical-steering-committee)\n * [TSC Meetings](#tsc-meetings)\n * [Collaborator Nominations](#collaborator-nominations)\n- * [Onboarding](#./onboarding)\n+ * [Onboarding](#onboarding)\n * [Consensus Seeking Proces...
2020-03-31T17:08:49
electron/electron
c810e64fdafa0f4de4bd5864bda337f5f3ea2904
bcf0964c618637b24e54ecfe87d178fd1bc79a41
Fix doc lint
[ { "path": "docs/api/app.md", "patch": "@@ -407,7 +407,7 @@ You can request the following paths by the name:\n * `options` Object (optional)\n * `size` String - Can be `small`, `normal`, `large`. The `large` size is not supported on _macOS_\n * `callback` Function\n- * `error` `Error`\n+ * `error` Error\...
2016-11-10T19:00:58
golang/go
55ecc3a88670c14bbbfc9d6c96cf65891cc608f5
ee833ed72e8ccfdd2193b0e6c0223ee8eb99b380
net: allow single dot in resolv.conf search statement A single dot in a search statement doesn't affect DNS lookup, so just ignore it and a syntax error. Fixes #54124 Change-Id: Idd43bd34c5c16af50cba51f0b6e24f992eec6e57 Reviewed-on: https://go-review.googlesource.com/c/go/+/423875 Run-TryBot: Ian Lance Taylor <iant@...
[ { "path": "src/net/dnsconfig_unix.go", "patch": "@@ -64,9 +64,13 @@ func dnsReadConfig(filename string) *dnsConfig {\n \t\t\t}\n \n \t\tcase \"search\": // set search path to given servers\n-\t\t\tconf.search = make([]string, len(f)-1)\n-\t\t\tfor i := 0; i < len(conf.search); i++ {\n-\t\t\t\tconf.search[i]...
2022-08-15T15:09:00
vercel/next.js
aa28fa5260f911874c46af8b814aa8bb1d2f47ff
164e43912d7b9079a34d9b841d2ddc8169506373
Process Client -> RSC Server Actions as TS (#57454) ### What? Fixes Client -> RSC (client importing a `"user server"` file) Server Actions that are using TS. ### Why? ### How? I check if the source module is using TS before "processing" the module into the RSC layer. Closes WEB-1871
[ { "path": "packages/next-swc/crates/next-api/src/server_actions.rs", "patch": "@@ -10,7 +10,7 @@ use next_core::{\n use next_swc::server_actions::parse_server_actions;\n use turbo_tasks::{\n graph::{GraphTraversal, NonDeterministic},\n- TryFlatJoinIterExt, Value, ValueToString, Vc,\n+ TryFlatJoinI...
2023-10-25T23:13:31
nodejs/node
98007329ef144106e5297f9efcf1a1a26c74124f
6baddcfddf8dbaeac02c12efac07189919fbd8dd
doc: add flarna to collaborators PR-URL: https://github.com/nodejs/node/pull/32620 Fixes: https://github.com/nodejs/node/issues/32333 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
[ { "path": "README.md", "patch": "@@ -293,6 +293,8 @@ For information about the governance of the Node.js project, see\n **Franziska Hinkelmann** &lt;franziska.hinkelmann@gmail.com&gt; (she/her)\n * [Fishrock123](https://github.com/Fishrock123) -\n **Jeremiah Senkpiel** &lt;fishrock123@rocketmail.com&gt; (h...
2020-04-02T17:30:13
rust-lang/rust
1a73720b8051a533b402ac67e35f84d405ccb28d
efbe625e35df7c2a7fa59b94a783f6f160828167
Disable error log for position clamping, its too noisy due to ease of triggering
[ { "path": "src/tools/rust-analyzer/crates/rust-analyzer/src/lsp/from_proto.rs", "patch": "@@ -40,12 +40,13 @@ pub(crate) fn offset(\n })?;\n let col = TextSize::from(line_col.col);\n let clamped_len = col.min(line_range.len());\n- if clamped_len < col {\n- tracing::error!(\n- ...
2025-08-07T13:14:22
facebook/react
ea40a6aedd7965a33e9504b9d3926481e7628d90
047e962a550da4dfa30b90d96e70898478efbdb2
Fix typo
[ { "path": "docs/docs/ref-04-tags-and-attributes.md", "patch": "@@ -13,7 +13,7 @@ React attempts to support all common elements. If you need an element that isn't\n \n ### HTML Elements\n \n-The following SVG elements are supported:\n+The following HTML elements are supported:\n \n ```\n a abbr address area ...
2014-01-04T06:19:04
electron/electron
bcf0964c618637b24e54ecfe87d178fd1bc79a41
2b60df3d8bbb5b5ac1b8df2efc5b5ab8e225b319
Fix more review
[ { "path": "atom/browser/api/atom_api_app.cc", "patch": "@@ -886,7 +886,7 @@ void App::GetFileIcon(const base::FilePath& path,\n }\n \n if (!args->GetNext(&callback)) {\n- args->ThrowError();\n+ args->ThrowError(\"Missing required callback function\");\n return;\n }\n ", "additions": 1, ...
2016-11-10T18:34:30
golang/go
9ad772033f04ea9b3082440d306e17802a08b4b4
9485d4c1bd871be792d03c29b7902f6ac284ed27
go/types, types2: consolidate testdata/examples test files Besides applying gofmt (which doesn't damage the tests in this case), the ERROR comments in the types2 files now match the go/types files. But because types2 still reports some errors are different positions, the checking code now allows for some position disc...
[ { "path": "src/cmd/compile/internal/types2/check_test.go", "patch": "@@ -299,7 +299,7 @@ func TestManual(t *testing.T) {\n \n func TestCheck(t *testing.T) { DefPredeclaredTestFuncs(); testDirFiles(t, \"testdata/check\", 55, false) } // TODO(gri) narrow column tolerance\n func TestSpec(t *testing.T) ...
2022-08-18T01:09:55
vercel/next.js
691613f8e83bf88a7ef43f3fe89a93508f89deee
23f32465d7c499873d950fc9c73dc65caff67e9c
Fix deploy id env handling when disabled (#57374) Ensure we properly omit the `dpl` fields when the experimental config isn't enabled but the env is present.
[ { "path": "packages/next/src/build/index.ts", "patch": "@@ -374,6 +374,8 @@ export default async function build(\n silent: false,\n })\n )\n+\n+ process.env.NEXT_DEPLOYMENT_ID = config.experimental.deploymentId || ''\n NextBuildContext.config = config\n \n let ...
2023-10-25T21:41:56
nodejs/node
6baddcfddf8dbaeac02c12efac07189919fbd8dd
e20b4f918af8c0e3760252b79a0abe362b42f97c
util: only inspect error properties that are not visible otherwise Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduce...
[ { "path": "lib/internal/util/inspect.js", "patch": "@@ -890,7 +890,7 @@ function formatRaw(ctx, value, recurseTimes, typedArray) {\n return ctx.stylize(base, 'date');\n }\n } else if (isError(value)) {\n- base = formatError(value, constructor, tag, ctx);\n+ base = formatError(val...
2020-03-17T16:24:25
rust-lang/rust
e3aae6162e7f0bdacb8b41c7b2f1d92100a0c476
d6dc3634dbd3ccfaf13bce4422afa5449b1ce2c8
add filtering lending iterator known-bug
[ { "path": "tests/ui/nll/polonius/filtering-lending-iterator-issue-92985.nll.stderr", "patch": "@@ -0,0 +1,14 @@\n+error[E0499]: cannot borrow `self.iter` as mutable more than once at a time\n+ --> $DIR/filtering-lending-iterator-issue-92985.rs:49:32\n+ |\n+LL | fn next(&mut self) -> Option<I::Item<'_...
2025-08-07T13:06:35
facebook/react
d270e2b1c700ab44f1343c743800fa7e5d5b6c62
e3e24500aeebd0c3da0822f50f299b79d9229565
Don't add displayName in transform if already defined This ensures we don't add displayName in the transform if it's already been defined. This is especially important when in strict mode, where duplicate properties in an object is an exception.
[ { "path": "vendor/fbtransform/transforms/reactDisplayName.js", "patch": "@@ -34,7 +34,18 @@ var utils = require('jstransform/src/utils');\n * });\n */\n function visitReactDisplayName(traverse, object, path, state) {\n- if (object.id.type === Syntax.Identifier &&\n+ var displayName = object.id.name;\n+ ...
2014-01-04T00:07:10
electron/electron
2b60df3d8bbb5b5ac1b8df2efc5b5ab8e225b319
29452364f30a06d762c633f18f2f849b00cc1dd6
Fix some feedback
[ { "path": "docs/api/app.md", "patch": "@@ -405,7 +405,7 @@ You can request the following paths by the name:\n \n * `path` String\n * `options` Object (optional)\n- * `size` String - Defaults to `normal`. Can be `small`, `normal`, `large`\n+ * `size` String - Can be `small`, `normal`, `large`. Except for `...
2016-11-06T14:10:33
golang/go
9485d4c1bd871be792d03c29b7902f6ac284ed27
39ec97da15e9167e7a17746c643f264baae6ce7b
cmd/compile/internal/syntax: handle missing index like in go/parser Instead of simply reporting an error but otherwise dropping the index expression from the parse tree when an index is missing (as in: x[]), create an index expression with a "bad expression" as index. This matches the behavior of go/parser and permits...
[ { "path": "src/cmd/compile/internal/syntax/parser.go", "patch": "@@ -1111,20 +1111,19 @@ loop:\n \t\tcase _Lbrack:\n \t\t\tp.next()\n \n-\t\t\tif p.tok == _Rbrack {\n-\t\t\t\t// invalid empty instance, slice or index expression; accept but complain\n-\t\t\t\tp.syntaxError(\"expecting operand\")\n-\t\t\t\tp....
2022-08-17T23:48:07
vercel/next.js
23f32465d7c499873d950fc9c73dc65caff67e9c
7274296681da098b229871ffe5a2517a12a6435f
types: mark ImageResponse from next/server deprecated (#57372) * Should show `ImageResponse` is deprecated if you still import from `"next/server"` <img width="708" alt="image" src="https://github.com/vercel/next.js/assets/4800338/38f9b9db-2cfb-48ec-99cc-08e7d1477155"> * If you build it will fail to compile, this m...
[ { "path": "docs/02-app/01-building-your-application/09-upgrading/01-codemods.mdx", "patch": "@@ -24,6 +24,30 @@ Replacing `<transform>` and `<path>` with appropriate values.\n \n ## Next.js Codemods\n \n+### 14.0\n+\n+#### Migrate `ImageResponse` imports\n+\n+#### `next-og-import`\n+\n+```bash filename=\"Te...
2023-10-25T20:48:33
facebook/react
4de2d39f63965e82e88b12a7bc668fea20fbe7dc
e91a8a1bc30e675c4683d5667b4122106962828b
Fix WheelEvent incorrectly inverting sign of deltaY
[ { "path": "src/event/synthetic/SyntheticWheelEvent.js", "patch": "@@ -27,7 +27,6 @@ var SyntheticMouseEvent = require('SyntheticMouseEvent');\n */\n var WheelEventInterface = {\n deltaX: function(event) {\n- // NOTE: IE<9 does not support x-axis delta.\n return (\n 'deltaX' in event ? event....
2014-01-01T15:00:38
rust-lang/rust
d6dc3634dbd3ccfaf13bce4422afa5449b1ce2c8
9b1a30e5e69e1537ef6eb6eb829eb47075206dea
add multiple known-bugs for NLL problem case 3 these are fixed by polonius=next and polonius=legacy
[ { "path": "tests/ui/nll/polonius/nll-problem-case-3-issue-112087.nll.stderr", "patch": "@@ -0,0 +1,17 @@\n+error[E0506]: cannot assign to `*opt` because it is borrowed\n+ --> $DIR/nll-problem-case-3-issue-112087.rs:23:5\n+ |\n+LL | fn issue_112087<'a>(opt: &'a mut Option<i32>, b: bool) -> Result<&'a mut ...
2025-08-07T13:04:39
nodejs/node
e20b4f918af8c0e3760252b79a0abe362b42f97c
88b4e86fd7ebf986fa55dbf010d39d4d76c35e04
test: fix fs test-fs-utimes strictEqual arg order `actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: https://github.com/nodejs/node/pull/32408#issuecomment-602170887 PR-URL: https://github.com/nodejs/node/pull/3242...
[ { "path": "test/parallel/test-fs-utimes.js", "patch": "@@ -150,15 +150,15 @@ if (!process.arch.includes('arm') &&\n const Y2K38_mtime = 2 ** 31;\n fs.utimesSync(path, Y2K38_mtime, Y2K38_mtime);\n const Y2K38_stats = fs.statSync(path);\n- assert.strictEqual(Y2K38_mtime, Y2K38_stats.mtime.getTime() / 1...
2020-03-22T09:42:39
electron/electron
2e85ff1f57b9d4cca28a89f3c955c5c34d6ac55c
3d47c9b71df7df1b65c330f2110e059a87b4237e
Fix code style
[ { "path": "atom/browser/api/atom_api_app.cc", "patch": "@@ -336,7 +336,7 @@ namespace api {\n \n namespace {\n \n-IconLoader::IconSize GetIconSizeByString(std::string size) {\n+IconLoader::IconSize GetIconSizeByString(const std::string& size) {\n if (size == \"small\") {\n return IconLoader::IconSize:...
2016-11-04T06:59:18
facebook/react
fb8277c819f3ee2aa1ece92d1ca588b81400dc9e
5aae5a7b1df83e60fc722b463d178c9077b5a44c
Set target properties explicitly for enter/leave Fixes #785.
[ { "path": "src/eventPlugins/EnterLeaveEventPlugin.js", "patch": "@@ -93,11 +93,16 @@ var EnterLeaveEventPlugin = {\n fromID,\n nativeEvent\n );\n+ leave.target = from;\n+ leave.relatedTarget = to;\n+\n var enter = SyntheticMouseEvent.getPooled(\n eventTypes.mouseEnter,\n ...
2014-01-03T00:03:11
rust-lang/rust
488876281660590f08083578084163be5266b854
9b1a30e5e69e1537ef6eb6eb829eb47075206dea
Fix doc comment of File::try_lock and File::try_lock_shared
[ { "path": "library/std/src/fs.rs", "patch": "@@ -814,7 +814,7 @@ impl File {\n ///\n /// If this file handle/descriptor, or a clone of it, already holds a lock, the exact behavior\n /// is unspecified and platform dependent, including the possibility that it will deadlock.\n- /// However, if ...
2025-08-07T12:04:12
golang/go
5fcddf3997a89c1f82935cf65d919b7ef03df2c5
0eb56ca4688caed10c422f1d2d3b364d75970b8c
go/types: match types2 error msg formatting for conversion errors This resolves a TODO. Also, it allows go/types and types2 to use identical test files in testdata/spec, a prerequisition for sharing them eventually. For #54511. Change-Id: Ia9d11b15ada237c18b6ce8f72732f70134a1a06f Reviewed-on: https://go-review.googl...
[ { "path": "src/go/types/conversions.go", "patch": "@@ -71,23 +71,23 @@ func (check *Checker) conversion(x *operand, T Type) {\n \t}\n \n \tif !ok {\n-\t\t// TODO(rfindley): use types2-style error reporting here.\n+\t\tvar err error_\n+\t\terr.code = _InvalidConversion\n \t\tif compilerErrorMessages {\n \t\t...
2022-08-17T22:06:56
vercel/next.js
da6562e4a14dfa122cfa6a7e97b3e0c45e30d450
2b400f8fc3b0b7071255e3496afaad7dfabea321
misc: build output rework (#57440) This PR updates the build output in order to reflect the changes brought by PPR and also to make it more consistent. before ``` ○ (Static) automatically pre-rendered as static HTML ◐ (Partially Pre-Rendered) static parts of the page were pre-rendered and th...
[ { "path": ".vscode/settings.json", "patch": "@@ -66,6 +66,7 @@\n \"napi\",\n \"nextjs\",\n \"opentelemetry\",\n+ \"prerendered\",\n \"Threadsafe\",\n \"Turbopack\",\n \"zipkin\"", "additions": 1, "deletions": 0, "language": "JSON" }, { "path": "packages/next/sr...
2023-10-25T20:19:42
nodejs/node
04c9a983ded65466171eb11206df003f95073d93
23a34089aa74b198967397da682af799a80b9222
src: avoid using elevated v8 namespaces in node_errors.h Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
[ { "path": "src/node_errors.h", "patch": "@@ -12,14 +12,10 @@\n \n namespace node {\n \n-using v8::Local;\n-using v8::Message;\n-using v8::Value;\n-\n enum ErrorHandlingMode { CONTEXTIFY_ERROR, FATAL_ERROR, MODULE_ERROR };\n void AppendExceptionLine(Environment* env,\n- Local<Value> e...
2020-03-24T20:53:12
electron/electron
3d47c9b71df7df1b65c330f2110e059a87b4237e
fe99b255c425591dc5fc5729eb2f9f684320e205
Fix lint
[ { "path": "atom/browser/api/atom_api_app.cc", "patch": "@@ -343,7 +343,7 @@ IconLoader::IconSize GetIconSizeByString(std::string size) {\n return IconLoader::IconSize::LARGE;\n }\n return IconLoader::IconSize::NORMAL;\n-};\n+}\n \n // Return the path constant from string.\n int GetPathConstant(const...
2016-11-03T18:43:53
facebook/react
1755d43add21e1721f88faada5d32304fea51a1a
04ad3bfcc36f590239893521d0ced2c84c8101d5
Upgrade commoner build tool to v0.8.12. Fixes #394. Fixes #615.
[ { "path": "package.json", "patch": "@@ -33,7 +33,7 @@\n \"url\": \"https://github.com/facebook/react\"\n },\n \"dependencies\": {\n- \"commoner\": \"~0.8.8\",\n+ \"commoner\": \"~0.8.12\",\n \"esprima-fb\": \"~2001.1001.0-dev-harmony-fb\",\n \"jstransform\": \"~2.0.1\"\n },", "ad...
2014-01-02T17:07:17
rust-lang/rust
c65102e745c5637d0da3e9649aaba7afdce7aa08
9b1a30e5e69e1537ef6eb6eb829eb47075206dea
doc(library): Fix Markdown in `Iterator::by_ref`. This patch fixes the Markdown formatting in `std::core::iter::Iterator::by_ref`. Code is used inside a link without the backticks around the code.
[ { "path": "library/core/src/iter/traits/iterator.rs", "patch": "@@ -1875,7 +1875,7 @@ pub trait Iterator {\n /// without giving up ownership of the original iterator,\n /// so you can use the original iterator afterwards.\n ///\n- /// Uses [impl<I: Iterator + ?Sized> Iterator for &mut I { typ...
2025-08-07T11:20:09
golang/go
a5370d038e56ced398c982f6a610a2ddde1703ff
6dc7b060cd725aa61421e627ec233e9a936600fc
cmd/compile: remove OFORUNTIL Not used any more. Fixes #53860 Change-Id: Id0b1c3ed30b576d6c5f08f064d1262de337262b3 Reviewed-on: https://go-review.googlesource.com/c/go/+/418374 Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: David Chase <drchase@google....
[ { "path": "src/cmd/compile/internal/escape/stmt.go", "patch": "@@ -78,7 +78,7 @@ func (e *escape) stmt(n ir.Node) {\n \t\tn := n.(*ir.UnaryExpr)\n \t\te.discard(n.X)\n \n-\tcase ir.OFOR, ir.OFORUNTIL:\n+\tcase ir.OFOR:\n \t\tn := n.(*ir.ForStmt)\n \t\te.loopDepth++\n \t\te.discard(n.Cond)", "additions":...
2022-07-19T20:15:05
nodejs/node
be876510bf6e0eae8a3cd1f6b8ac669b3d397fb4
0c70e8c6e4eec2b0e7f60bb52c2088dbfa91f2ab
src: clean up worker thread creation code Instead of setting and then in the case of error un-setting properties, only set them when no error occurs. Refs: https://github.com/nodejs/node/pull/32344 PR-URL: https://github.com/nodejs/node/pull/32562 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otris...
[ { "path": "src/node_worker.cc", "patch": "@@ -592,16 +592,7 @@ void Worker::StartThread(const FunctionCallbackInfo<Value>& args) {\n ASSIGN_OR_RETURN_UNWRAP(&w, args.This());\n Mutex::ScopedLock lock(w->mutex_);\n \n- // The object now owns the created thread and should not be garbage collected\n- // ...
2020-03-30T08:35:16
vercel/next.js
dee316c40edffd3e430c172fcbc7245fbb803150
8a4b0f16c8b2cc7a56de7bb663ccfdb9c2688fc4
Turbopack: avoid sending serverComponentChanges with errors (#57425) We don't want to send the serverComponentChanges event until the compilation is free of errors. Closes WEB-1859
[ { "path": "packages/next-swc/crates/napi/src/next_api/endpoint.rs", "patch": "@@ -123,16 +123,17 @@ pub fn endpoint_server_changed_subscribe(\n func,\n move || async move {\n let changed = endpoint.server_changed();\n- // We don't capture issues and diagonistics here s...
2023-10-25T18:41:01
golang/go
661146bc0bb0fad22d561eef2c0b48974aca32b6
52016be3f4e6deba54020ad8c969f1e2dba1eee3
cmd/compile: don't use OFORUNTIL when implementing range loops We don't need this special loop construct anymore now that we do conservative GC scanning of the top of stack. Rewrite instead to a simple pointer increment on every iteration. This leads to having a potential past-the-end pointer at the end of the last it...
[ { "path": "src/cmd/compile/internal/walk/range.go", "patch": "@@ -53,7 +53,7 @@ func walkRange(nrange *ir.RangeStmt) ir.Node {\n \t//\ta, v1, v2: not hidden aggregate, val 1, 2\n \n \ta := nrange.X\n-\tt := typecheck.RangeExprType(a.Type())\n+\tt := a.Type()\n \tlno := ir.SetPos(a)\n \n \tv1, v2 := nrange.K...
2022-06-27T04:18:19
nodejs/node
e06512b9b75552f73371512ded879e472c0ec57e
2a885151e91ec3127030d28571be8a9e3aeb651e
report: add missing locks for report_on_fatalerror accessors Overlooked in 2fa74e3e38bb028339e48763138456b3ed10ed97. Refs: https://github.com/nodejs/node/pull/32207 PR-URL: https://github.com/nodejs/node/pull/32535 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By:...
[ { "path": "src/node_report_module.cc", "patch": "@@ -16,6 +16,7 @@\n \n namespace report {\n using node::Environment;\n+using node::Mutex;\n using node::Utf8Value;\n using v8::Boolean;\n using v8::Context;\n@@ -134,12 +135,14 @@ static void SetSignal(const FunctionCallbackInfo<Value>& info) {\n }\n \n stati...
2020-03-28T13:42:51
vercel/next.js
8a4b0f16c8b2cc7a56de7bb663ccfdb9c2688fc4
d11156c2d21dc1ac2a968ba294e84d1559a3032c
Turbopack: avoid crashing when server actions can't parse the file (#57424) Introducting syntax errors in files throws an error in the server actions parsing, which hides the actual syntax error reported Closes WEB-1858 Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
[ { "path": "packages/next-swc/crates/next-api/src/server_actions.rs", "patch": "@@ -240,10 +240,8 @@ async fn parse_actions(module: Vc<Box<dyn Module>>) -> Result<Vc<OptionActionMap\n comments, program, ..\n } = &*ecmascript_asset.parse().await?\n else {\n- bail!(\n- \"faile...
2023-10-25T18:36:43
golang/go
52016be3f4e6deba54020ad8c969f1e2dba1eee3
d6294e00f029d93b8552827bce1f24f67458d3f2
cmd/compile: enable more inlining for unified IR The non-unified frontend had repeated issues with inlining and generics (#49309, #51909, #52907), which led us to substantially restrict inlining when shape types were present. However, these issues are evidently not present in unified IR's inliner, and the safety rest...
[ { "path": "src/cmd/compile/internal/inline/inl.go", "patch": "@@ -722,44 +722,47 @@ func mkinlcall(n *ir.CallExpr, fn *ir.Func, maxCost int32, inlMap map[*ir.Func]b\n \t\treturn n\n \t}\n \n-\t// Don't inline a function fn that has no shape parameters, but is passed at\n-\t// least one shape arg. This means...
2022-08-18T12:20:16
nodejs/node
72e521f5e891b61c88d3452fcf4abab3cdf0f848
c4b381a1311ef7d77b9e13dc4b1448649823ba02
src: move JSONWriter into its own file The JSONWriter feature is not inherently related to the report feature in any way. As a drive-by fix, remove a number of unused header includes. PR-URL: https://github.com/nodejs/node/pull/32552 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> ...
[ { "path": "node.gyp", "patch": "@@ -561,6 +561,7 @@\n 'src/js_native_api_v8.h',\n 'src/js_native_api_v8_internals.h',\n 'src/js_stream.cc',\n+ 'src/json_utils.cc',\n 'src/module_wrap.cc',\n 'src/node.cc',\n 'src/node_api.cc',\n@@ -645,6 +646,7 @@\n ...
2020-03-29T18:11:56
facebook/react
f0b5219df90d1e15a75130a6564390fd7c90b810
3396654a6f13e75e486e46e624c754207a6842b8
docs better error display for live editor and JSX compiler
[ { "path": "docs/_css/react.scss", "patch": "@@ -466,6 +466,12 @@ section.black content {\n @include code-typography;\n }\n }\n+\n+ .playgroundError {\n+ // The compiler view kills padding in order to render the CodeMirror code\n+ // more nicely. For the error view, put a padding back\n+ ...
2014-01-02T00:41:08
golang/go
d6294e00f029d93b8552827bce1f24f67458d3f2
07cf24bdfe55dd3493e580c67b5437a114df7658
cmd/compile: fix devirtualization bug with unified IR As a consistency check in devirtualization, when we determine `i` (of interface type `I`) always has dynamic type `T`, we insert a type assertion `i.(T)`. This emits an itab check for `go:itab.T,I`, but it's always true (and so SSA optimizes it away). However, if ...
[ { "path": "src/cmd/compile/internal/devirtualize/devirtualize.go", "patch": "@@ -74,6 +74,25 @@ func Call(call *ir.CallExpr) {\n \t\t\t}\n \t\t\treturn\n \t\t}\n+\n+\t\t// Further, if sel.X's type has a shape type, then it's a shaped\n+\t\t// interface type. In this case, the (non-dynamic) TypeAssertExpr\n+...
2022-08-18T11:56:10
nodejs/node
7e664a554ac58f84adee7990d3509f128551cc35
b149eefa82327af9835d3c68b3fd03e0e4a25413
benchmark: fix error on server close in AsyncLocalStorage benchmark PR-URL: https://github.com/nodejs/node/pull/32503 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@c...
[ { "path": "benchmark/async_hooks/async-resource-vs-destroy.js", "patch": "@@ -35,17 +35,14 @@ function buildCurrentResource(getServe) {\n \n function getCLS() {\n const resource = executionAsyncResource();\n- if (resource === null || !resource[cls]) {\n+ if (!resource[cls]) {\n return null...
2020-03-26T12:11:06