1.0.0 further bug investigations

RuREBus.py

@@ -7,7 +7,7 @@ import zipfile
 import os
 import shutil
 
-from .utils import is_notebook
+from .utils import is_notebook, is_url
 
 if is_notebook:
     from tqdm.notebook import tqdm
@@ -46,8 +46,6 @@ _VERSION = '1.0.0'
 
 def extract(zip_file_path):
     p = Path(zip_file_path)
-    if not p.exists():
-        raise FileNotFoundError
     dest_dir = str(p.parent / 'extracted' / p.stem)
     os.makedirs(dest_dir, exist_ok=True)
     with zipfile.ZipFile(zip_file_path) as archive:
@@ -125,10 +123,9 @@ class RuREBusBuilder(datasets.GeneratorBasedBuilder):
             # folder = dl_manager.download_and_extract(self._RAW_TXT_URLS)['raw_txt']
             # decode_file_names(folder)
             zip_file = dl_manager.download(self._RAW_TXT_URLS)['raw_txt']
-            raise ValueError(zip_file)
-            try:
+            if not is_url(zip_file):
                 folder = extract(zip_file)
-            except FileNotFoundError:
+            else:
                 folder = None
             return [
                 datasets.SplitGenerator(

utils.py

@@ -1,3 +1,16 @@
+import re
+
+
+def is_url(s: str):
+    regex = re.compile(
+            r'^(?:http|ftp)s?://' # http:// or https://
+            r'(?:(?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\.)+(?:[A-Z]{2,6}\.?|[A-Z0-9-]{2,}\.?)|' #domain...
+            r'localhost|' #localhost...
+            r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})' # ...or ip
+            r'(?::\d+)?' # optional port
+            r'(?:/?|[/?]\S+)$', re.IGNORECASE)
+    return re.match(regex, s) is not None
+
 
 class IsNotebook:
     def __init__(self):