Lesson text repeats itself: "You can use radio buttons for questions where you want the user to only give you one answer. Radio buttons are a type of input. Each of your radio buttons should be nested within its own label element. All related radio buttons should have the same name attribute. Here's an example of a radio button: <label<input type="radio" name="indoor-outdoor"Indoor</label. Add to your form a pair of radio buttons. Each radio button should be nested within its own label element. They should share a common name attribute. One should have the option of indoor and the other should have the option of outdoor."
It is a style choice of whoever wrote this lesson. A bug would be error in the code that stopped the script or program from executing as intended.


For , the answer is already provided for them. The starting seed code needs to just be the button element without the onclick. Here is the file that needs changing If you are interested in working on this please read through the first We do not assign issues. If you are interested, work on the issue and then create a PR for the fix. Happy coding! incorrect start code This should be the correct starting seed code No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response


I think "Each id should be unique to a specific element." would be less ambiguous (and more accurate) as "Each id must be unique on the page."


I want to suggest that, at this point, in addition to the comment about the block element ' stretch to fill your page's entire horizontal space.', there is a comment that any element following it will flow to a "new line". You could argue that is [almost] "assumed". But I believe it should be stated.


I think the video for this challenge should be updated. It does not show the proper nesting of both the p elements inside the main element. It also has one error as one of the p elements are not closed properly.
Any comments?
Agreed with lasjorg, In this exercise a new paragraph should be below the first, with a main tag then to wrap around both paragraphs. In the video, the main tag is around the newly second paragraph only, plus the newly paragraph has an opening p tag at the end instead of a closing p tag. For contrast, the very next video has the main and paragraph tags the way they should be. Discovered this error when my daughter ran into difficulty with this exercise, and when she watched the video became even more confused.
Any thoughts?
I will redo that video.


Within the challenge it instructs you to create bullets by replacing all the p elements with(no spaces of course) < li elements to get a bulleted list. When I follow it as instructed it leaves my style coding visible (class="red-text") is then displayed. When I remove the end closure < l i (obviously no spaces), it leaves everything intact but the practice won't allow me to advance without adding the closure... even though the closure is at the end of the style portion of my closure Example: For it to look right I remove the end closure making it < l i this happens: <li class="red-text"Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.</liBUT for it to be marked correctly I have to Complete the closure < li class="red-text"Kitty ipsum...... and it looks like this: <liclass="red-text"Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.</liSo In order to fix it, and still make sure my code isn't displayed on my final work, i'd have to remove my styling from the code or simply leave it exposed See below for the link to the segment and below that is my full code Challenge has an issue. User Agent is: <codeMozilla/5.0 (Macintosh; Intel Mac OS X ) AppleWebKit/601.1.56 (KHTML, like Gecko) Version/9.0 Safari/601.1.56</code. Please describe how to reproduce this issue, and include links to screenshots if possible. My code:
What the instructions for this challenge mean to be asking is for you to completely remove the bottom two paragraphs and put an unordered list at the bottom instead. This avoids the problem you're running into of having an anchor tag in the middle of your block (which is not valid markup). I agree that the wording is confusing since there is another tag earlier in the page with other types of tags in between. This should be clarified to reflect that the bottom two tags should be removed and a three item list created in it's place.
I can't complete the challenge either


Challenge has an issue. The commented code sample at the top of the challenge is missing commas between properties. <img width="1158" alt="screen shot 2015-08-16 at 5 01 57 pm" src=""
And on this challenge, too.


The creation of the help wanted forum post should be changed to use correct Python comments for files. Right now the posts are created with the wrong type of comment. !
I want to work on this issue
We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue. Issues labelled with or are open for contributions. Please make sure you read . We prioritize contributors following the instructions in our guide. Join us in or if you need help contributing - our community will be happy to assist you.


Describe your problem and how to reproduce it: SVG image in the challenge description is affected by SVG logo in navbar. They share some element s, what results in malformed image in description. Changing s to make them not overlap should deal with the issue. The simplest way seems to be, to change one of the images (probably one in the challenge), for example by adding unique prefix to s. That wouldn't eliminate completely the chance for some other conflict in future, but that's probably not something to worry about much. Add a Link to the page with the problem: If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): Current look ! Proper image !


Challenge has an issue. It seems that it's more appropritae to show helpful links to: () () instead of: () () Am I right?


<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: The formatting of the header-tag page in the guide is wrong. I checked the codebase and there are missing back-ticks for some of the html tags in the markdown page. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: Version 70.0.3538.102 (Official Build) (64-bit) Operating System: MacOS 10.14.1 If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): !


Challenge has an issue. User Agent is: <codeMozilla/5.0 (X11; Linux x8664) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.71 Safari/537.36</code. Please describe how to reproduce this issue, and include links to screenshots if possible. My code: I was asked to use "the first few words of this kitty ipsum text". I copied the first two words, but it failed validation. I tried copying the first three words instead, and that worked. Google defines 'a few' as "a small number of". synonyms: a small number, a handful, one or two, a couple, two or three_. Edit: it appears that copying 3 or more words works, but copying just 2 of them doesn't.
This isn't bike-shedding. It is rejecting valid solutions very early on in the first lesson, when it is important not to discourage people. Are reports like this not wanted?
Just discovered this. Yeah, "first few" should be "first three". Why have the ambiguity?
Having worked through most of the rest of the programming exercises I wonder if the aim is to get programmers used to working from low-quality specifications. Even if that is the case, I think having a poorly specified problem this early on runs too high a risk of putting people off forever.
That's certainly an interesting idea. I could imagine some sort of course where you must sort through (intentionally) ambiguous and unintelligible requirements to potentially satisfy an irate product manager or customer with unrealistic deadlines. Call it "Worse-case scenario" training :D
Call it: Situation Normal training.
Yes. FreeCodeCamp(now with Situation Normal Training)


I have pass all test case of "Exercise Tracker" challenge except the 7th test case("you can POST to /api/users/:id/exercises with ..."), I tried many way but still can't pass this test case. When i open the console of Chorm, i found the bug "(...).subtingr is not a function" when i click on the button "I've completed this challenge" to submit the `` the console of brower the link into Solution Link on "I've completed this challenge" error This error should be disappear ! Device: [Laptop] OS: [Windows 11] Browser: [Chrome] Version: [106.0.5249.103] No response
~Please provide the link to the project that you submitted~ EDIT: still half asleep sorry, ignore that
Thanks for opening this issue. This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Line contains the typo, should be . Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hello, I am interested in working on it
hey there, I suggest reading our contributing guidelines! as it says, all issues with and labels are up for grabs
I have fixed this issue and raised a PR.


I found a subtle bug while doing the “React: Write a Simple Counter” challenge. If you look at the code below you’ll see that I binded this in to the this .decrement method. It should be: The consequence of this error is that clicking the reset button which calls does not reset the counter and decrements it instead. However, when I run the tests, all the tests are passed and the error is not detected! I think we need to add an additional test for that specific scenario. Browser Name: Chrome Browser Version: 67 Operating System: Mac OS X
I run to this same error just now. Accidentally, I entered which is wrong but it passed the test.
I think we need to check this with a RegEx. What are your opinions and ?
Is there any update on this issue? I could work on this bug.
As of yet, we have not come to a conclusion about what to do on this issue. Although, since this is a confirmed issue, please suggest how you'd like to go ahead with this over here
In terms of the buggy code provided in this issue, I think only the last test case is wrong. Left part is the original version. Right part is the new version I made. ! I checked if my changes work on local host. After I made the change, we can see that the last test fails when I provide the wrong solution codes. ! And the last test passes when I provide the correct solution codes. !
This looks pretty good to me. I see you've made a PR, that's great, we'll QA that soon


This step will fail with code and will pass removing the semicolon at the end of the third line. It doesn't look like this test allows for semicolon


<!-- freeCodeCamp Issue Template --<!-- Please provide as much detail as possible for us to fix your issue --<!-- Remove any heading sections you did not fill out --<!-- NOTE: If your issue is CodePen Project / Test Suite related, please open it using the below URL instead --<!-- --<!-- Insert link to challenge below --Link to external page with anchor elements <!-- Describe below when the issue happens and how to reproduce it --In the translation to Spanish, the instruction is: "Create an element which links to and have the anchor text "fotos de gatos". The validator says: Your a element should have the anchor text of "cat photos". This will be a trouble in all translations when the validator looks for a string given in a specific language. <!-- Describe your workspace in which you are having issues--Browser Name, Version: Operating System: Mobile, Desktop, or Tablet: <!-- If relevant, paste all of your challenge code in here --<!-- Add a screenshot of your issue --!
I can do this!
I guess an overhaul of the challenge JSON structure could go something like: But this would be a big overhaul :D


The description of Working With Text Question D should read "in an tag" instead of "in a tag". <img width="788" alt="Screenshot 2024-03-29 at 23 05 44" src="" Change "in a tag" to "in a tag" in
This issue is open to first-time code contributors to this repository. The file that you should be updating is linked in the original post. Please make sure you read our as well as our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.


<!-- FreeCodeCamp Issue Template --<!-- Please provide as much detail as possible for us to fix your issue --<!-- Remove any heading sections you did not fill out --<!-- Insert link to challenge below -- <!-- Describe below when the issue happens and how to reproduce it --This challenge would be a lot more informative if a description of what adding the form-control class to the input field actually does. Something along the lines of: All textual [input], [textarea], and [select] elements with class [.form-control] have a width of 100%.
This challenge is currently quite short and it's defiantly worth adding an explanation here. To First Timer: You will need to add the sentence under line. Please, check our and if you need any assistance reach out to the .
The code you'll need to add specifically is It should render as
Hey there. I'm a first-timer interested in getting started with contributing to Free Code Camp. I will submit a PR for this issue. Thanks!
Hey What about tests ?? Tests should be for each input.
having issue in style-text-inputs-as-form-controls just give a class="form-control" to before your checkbox's 1st div and finally add here 3)


<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Describe your problem and how to reproduce it: While helping a camper with their work on this solution, I took a look at mine and discovered it passes when it should not. If you paste this code into the editor, you can see that has been modified from to but the test does not catch this fact. I believe it may be due to the tests for array modification calling the function without an parameter: If I assign a default value of in the function, then the tests catch this behaviour as expected. As such, I believe updating these function calls in the tests should correct this error. Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: 85.0.4183.102 Operating System: Windows 10 v 1909 If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): !
I believe so. Essentially if you invoke without , the value of is and from the solution you have given, will be which is . Therefore : As a result and remain unmutated. What i am not sure of is whether invoking the function without was an oversight or intentional.
calling the function without an stops various loop solutions from being accepted. I do not know if it was intentional
Is it to force learners to use / since it is a splice-slice challenge?
There is no requirement to use splice or slice. It is an algorithm challenge. We do not care how they solve the problem.
So, to be clear - you are thinking to put a value in for on those two tests you shared would catch this.
Yes, updating the test call to: should correct this bug


We had this issue on the forum where the camper was unable to pass the test for step 71 with the following code. The test is expecting the use of inside the loop. But is valid too. After a quick scan of the final solution, it looks like the loop is used four times. I have checked the tests, but it is possible that all 4 instances have the same issue where is expected. Update all 4 instances of the tests to accept the use of or multiple pages see explanation above see explanation above No response Device: [e.g. iPhone 6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04] Browser: [e.g. Chrome, Safari] Version: [e.g. 22] No response
I verified other for loops at step 35, 38 and 57. All these accepts the use of let or const or var.


None of the GET request examples/Tests mention to be able to GET with id param, However during one of the PUT request tests there is a GET request sent with an ID, i struggled to find this Bug in my code, i feel adding one extra Functional test for GET request specifically requiring to be able to GET by IDs, If using mongoDB like i was the ID needs the toString Method in order to be read as a string. i attached a screen shot shows the PUT test with the GET request at the bottom Either extra functional test requiring to be able to GET with an ID, or Updated with GET example that shows GET with an ID ! Device: [Desktop] OS: [Windows 11 WSL Ubuntu 22.04.3 LTS] Browser: [Chrome] Version: [122.0.6261.70 ] No response_
This requirement would be covered by: I'd be fine adding another check inside that existing test to look at the param.
i see now the "any field" and value, this was a lack of knowledge at the time, being able to get data by an "id" is imperative. Id like to propose a solution to the test above, change query of to GET the post created by carol and assigned to eric, this keeps the get Multiple aspect but returns 1 doc the of to GET and assert that of is equal to of
I'm hesitant to rewrite the entire tests, when instead we could update the test I indicated to try a query by ID (which we know won't break existing projects because a later test relies on that functionality).
Agreed my proposed solution would be for the existing GET test that you indicated, you could just drop in and after existing , this adds a query by ID. The current tests only query by and !
Ah, I see. Yes, that would be a good approach. I'll go ahead and open this one up.


when I finish all challenges, the flash info is Once you have completed all of our challenges, you should join our<a target=""_blank"" href=""""Half Way Club</aand start getting ready for our nonprofit projects.a element will not open HalfWayClub of gitter I'm using firefox 41.0.1 on windows, I think there is something wrong with


Describe your problem and how to reproduce it: After commenting the code in a , the tests are passing. I think the issue is with this particular challenge only as I have solved many challenges and I haven't observed this bug in any of them. ! Add a Link to the page with the problem: Tell us about your browser and operating system: Browser Name: Chrome Browser Version: 76.0.3809.132 (Official Build) (32-bit) Operating System: Windows 10 Pro
This is not unique to the beta site. Many of the challenges don't ignore comments. We have a helper function which can be applied to the tests which removes comments. We can not use it across all challenges, because there are challenges which involve validating the comments. Since there are only a few challenge tests where we need to be able to check the actual HTML, CSS, or JavaScript comments, maybe we can figure out a way to pass an extra property named with a value of only when comments should not be removed from a specific testString's use of the variable. That way, the default behavior would always be to remove comments from a test. It might be simpler to just add the to the frontMatter of the challenge, so all the tests of a challenge would not remove the comments and the s could be adjusted to account for the comments not being removed from the variable.
I do not like the idea of changing the schema again though. What we really need is a parser to sanitize comments.
Some of the challenges are actually checking the comments, so you can not just sanitize all the challenges' comments.
Did someone say ?
Ooops, been a while since I have been on GitHub. Using an AST will help remove those awful regex tests that many of the older challenges rely on. The is built with . Is wouldn't take much to create a library of helper functions to use in tests.
How do this look? The idea is to provide a challenge test utility to replace the need upon horrible RegEx tests. I have this passing locally as a POC. <img width="568" alt="Screenshot 2019-09-15 at 14 19 32" src="https://user-"
This would be really nice to be able to update those quirky tests. Can you please throw in you changes in a PR?


<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --Affected page Your code Typical user code: Expected behavior We've had an uptick of people blindly copying the help video from this challenge without reading the instructions: This leads to campers failing the requirement (This is generally a problem with the help videos, unfortunately - copying with zero understanding.) Does this video link need to be updated or removed? Screenshots If applicable, add screenshots to help explain your problem. you can drag and drop, png, jpg, gif, etc. in this box. System (please complete the following information): Device: [e.g. iPhone6, Laptop] OS: [e.g. iOS 14, Windows 10, Ubuntu 20.4] Browser: [e.g. chrome, safari] Version: [e.g. 22] Additional context Add any other context about the problem here.
let's remove it, it's already that direction with other videos, once there is a discrepancy, the challenge win and the video is removed
Seeing as this is an easy fix (I assume we just remove the URL) I will open this up to first-timers. If anyone disagrees feel free to remove the label.
Thanks for making this a first timers only. The only additional step I would be recommending is using as an example to add clear instructions for first timers. I am going to go ahead and take care of that here. This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: Edit this file and remove the line containing . Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull-requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Thanks for the help. I have the template to a saved reply. Hopefully, I will remember to use it. Also, I have a stupid question. How do you best "quote" the code and line numbers of a .md file?


Do you just use the blame view or look at a commit/PR? I don't understand the commit link you have in your quote. It looks to be for something else?
Oh - I just use the code view for a markdown file and then grab the permalink. <details<summaryDetails</summaryOpen file in code-view: It's the icon on the left at the top right of the file. Looks like this: ! Getting the permalink by selecting the line (host shift for more lines): ! </details
Right, but you can only get to the code view from inside a commit, right? I mean I do not see the source view for .md files when just looking at the file. Anyway, I will figure it out sorry to bother you with this I know you are a busy man.
Yes, that is correct. I browse the repo with top commit at the time of making a comment. But again, you do not have to spell out every little detail for the first-timers, it's just a "the more the better" type thing.


I see here that we are intentionally supporting confusing but technically correct syntax. In light of this, we should remove the note here All of these are non-standard things that technically work but nobody actually does in practice. We should either go out of our way to support this sort of thing or not. If we are going out of our way to support this sort of thing, then there really isn't much point of letting the users know that it's unconventional syntax. See also: Personally, I think it's valuable to teach the learners how to write code that others expect to see so that it's easier for them to get hired, but we really need to be consistent. We should either help them with conventions or not bother. If we aren't doing anything after making the note, then it's just visual noise and should be removed.
For what it's worth: This code fails the "bracket notation" test, presumably because of the space. And I'm of the opinion that it should stay that way (I'd be okay with updating the test to allow spacing and adding a third test that clarifies "you should not have spacing"). That being said, there are areas where we are more lenient on the spacing/conventional style, which IMHO is okay if that's not the concept being taught/tested.
For what it's worth here's what I think about formatting. In practice the likes of prettier have rendered manual formatting unnecessary and unhelpful - I don't need to see diff noise obscuring actual code changes. If we're overly picky about formatting then I can see that creating a frustrating experience. However, we should provide nicely formatted code in the examples. That way learners can pick up good habits simply by copying.
I'm generally pretty flexible with formatting. I don't think we have any business requiring a specific brace and indentation style. I'll format utterly unformatted code when someone asks for help and explain how it helps me and the learner discuss the code more easily, but that's a very useful context to discuss readability. But the extra spaces in the above three examples are so unusual and uncommon of syntax that it feels strange to make our tests permit them in the recent couple of issues while also calling it out here as something to not do.
I disagree with both propositions — the note is fine, we should encourage standard style. But also let's not be a PITA.


I'll copy my other comment here, so we can have a discussion in a single place:
If we aren't going to enforce/test it, it's just pointless noise that needs to be removed. Text that doesn't related to what is being tested just fills the screen. We have enough trouble getting users to actually read the challenge text without including text we intend for them to ignore.
From an accessibility perspective, I don't think we should be strict on formatting that does not affect the execution of the code. One example that comes to mind is people who are listening to the code. Screen readers don't announce spaces by default so it might not be obvious that there is an extraneous space between the variable name and the bracket notation. I don't think the tests should penalize them for this when the code executes just fine. On a side note, you can use the keyboard shortcut in monaco to format the code and it will remove the space between the variable name and brackets (I just tested it). So I suppose we could require everyone to format their code properly before testing, but this seems like overkill. Or perhaps there is a way to auto-format the code when the user clicks the test button?
I'm not thrilled about intending this syntax to pass, but I find the accessibility concern more compelling than just allowing highly uncommon syntax variations because it can run in other JS environments. But I still say that it we aren't going to test it, then the spacing note should not be there. If its not part of the challenge outcomes, then it's noise. We already struggle to get learners to actually read the parts of the text that relate to their ability to pass the challenge.
Allow me to revise my previous answer just a little. I think I was assuming that this extraneous space issue was being tested in all challenges, but now I'm realizing that it may apply to only this one particular challenge. If so, then as long as the challenge instructions make it clear that this is a requirement to pass the challenge, and there is a clear error message that indicates the reason the test failed is due to the extraneous space, then I think it is OK to leave this test in there if it's deemed important enough to keep. But in general, I do not think such formatting issues should cause a test to fail (as explained above).
Thanks for the thoughts & Here is what we should do: the note.


IMHO you all are correct in assuming it does nothing other than draw attention to a confusing notion. should support the technically correct syntax (ignore testing for it, if we are). may be a good idea, but I am afraid of accidentally introducing something else.


Sure, we could change many tests in other challenges, but I would much rather have the tests as is, teaching users to debug their own code. In programming outside of tutorials, debugging is a massive portion of the process, and programmers do not always write their own tests. In my opinion, the tests are well-suit for teaching programming skills.
Just took a second look and it makes sense now, didn't see the part that specified what the strings had to be. I'll probably just add a couple of tests to check for what the strings are inside of resolve/reject and change the test messages depending on which ones were passed. BTW, if you don't mind me asking, why do you guys have all of your files in Markdown? I'm just curious for the sake of learning.
That’s a question or or some of the moderators could artIculate a better answer, but I think the theory is that markdown is an easy to read input for feeding the curriculum engine/logic.
TL;DR: Markdown is easy on editing. We used to have a json object (schema) for the challenges in the earlier days, but ever since we moved to - A static site generator, we started using markdown. It is easy for contributors to edit a text file. More often than not when making a quick contribution, you do not need to know how the underlying infra works, because maybe you are changing the instructions a little bit, fixing a typo, you get the idea. We wrote a custom parser (and a schema that it needs to be compliant with) to get the content out of the markdown and build the HTML pages (which is implemented as a Gatsby plugin of course). You are welcome to dig into the package to learn how it works. P.S: All questions are welcome, do not be shy :)
That makes a lot of sense thanks for the response, I have a couple more questions actually If you don't mind me asking, Since the challenges are made using Gatsby, how do you guys test your code? Do you make your own site and run it on there? Or do you use extensions on whatever IDE/text editor you use? Also, what does YML mean? I'm assuming YAML, but I honestly don't know, I think however that If I know what that means I can figure it out.


Here's what I have so far:  What I want to do is change the first two tests to just resolve and reject with empty strings inside, then have the last two be with the correct string inside. These are probably very simple questions but I think they would help me out a lot as I contribute more this summer!
have you made a PR yet? When you do put the PR # in this thread so we can test your tests. If you need any help with this let me know. EDIT: Yes, YML stands for YAML files (yet another markup language). If you read the instruction on installing FreeCodeCamp locally there should be instructions for testing locally as well. To test curriculum: To test everything: Check out for all the commands for the project.
Also we have some documentation here: if you want to learn more.
I'm working on setting up my repo locally and getting a basic idea of the codebase, as I've never worked with YAML; if anyone else wants to fix this issue don't hesitate! I can work on something else. Like I said I'm new to open source so all of this stuff is new to me, apologies for me taking this long, I will be a lot more productive once I have more time on my hands.


In step 31 of the Learn HTML Forms by Building a Registration Form project, the step doesn't explicitly say that it wants the input element to be nested inside the label element. Instead it says: "Add a label with the text Upload a profile picture: , and add an input accepting a file upload." This could be interpreted to mean that the input element should be on the right side of the label element. Only when we attempt this are we told by the Hint "You should nest an input element inside the label element." To clarify the requirement, the step should use the word nest in the exercise as below for eg.: "Add a label with the text Upload a profile picture: , and nest an input accepting a file upload within it.", The step should explicitly state that the input element should be nested within the new label element. No response Not Applicable No response
I think if all of the challenges will have specifications defined explicitly, it will serve no purpose of "challenging" the learners to really think and solve it. In the first place, the solution is already implied from the given code and then, if the learners will still have the hard time solving it, then the feature will definitely do its job.
Agreed. The instructions should be clear to begin with. Making the users guess what the test requires isn't a "challenge", it's just rude.
For what it is worth, the camper has nested an input in a label element a few times in this challenge prior to this step. I am not against adding this reminder to the instructions, but I don't want to lose sight of our goal to keep the instructions more lean and have the hints serve as the reminders.
Definitely. But I looked back at the instructions on the steps where they add the previous inputs and we do explicitly tell them to put the input within the label: step 17: Nest an input element within each label. step 25: within each of the first two label elements, add one input element with type="radio". If we can add that information to those instructions then I think we can add it to this one. And let me just clarify that what I am really concerned about is this correct solution being rejected: I'm working under the assumption that correct code should always pass. So we need to tell the user that only a nested input will pass if that's all the test will accept.


I understand that if someone is working on a series of steps they may not need to be told to nest the input again. However, if they stop and return to the project a few weeks later on, they may not remember that. The hint will remind them sure. I guess this is a minor issue given the hint is quite clear. Personally I like a more explicit instruction.


The instructions state "In your fourth tr element, add a th element with the text Total Liabilities." However it is not really clear that the user should or should not include a period. Users will have failed previous tasks if the period was omitted (periods are required on previous exercises) , therefore they will most likely add the period which will result in a failed test case. Also, if the period is included after "Liabilities", the error message gives "Your th element should have the text Total Liabilities." Which does not highlight the actual issue. Maybe making a different test case message that looks for the period would make it more understandable? The code above should highlight the issue of the period being present. The test case that is currently in place can confuse users that they have a spelling issue/spacing instead of the actual issue being the period at the end of "Liabilities". No response Device: Desktop OS: Windows 10 Browser: Chrome Version: Version 108.0.5359.125 No response
I was thinking, that we could change to But this doesn't make a coherent sentence. I am in favor of adding a new test.
I also think a new test case would be good.
Hi! We just opened a to fix it, but it was not accepted . Could you please kindly inform us some feedback about what was going wrong and what else we need to do? So that we can know where to focus. We appreciate any help, thank you!!
Hi Thanks for reaching out and creating a pull request. For reasons of sanity, we can't accept PRs from forks that organizations maintain. You should make a PR from your own personal GitHub account. You can collaborate with others and have commits made by multiple people, but one person needs to create the PR, and then others may push to the same PR should they wish. It is OK if you want to use the draft mode while collaborating. The person making the PR is responsible for ensuring the checklist is followed, tests are working, and so on. You can also commit on someone's behalf. See: Also, please create good, small, and succinct commit messages and PR titles. Keep your commits clean and avoid any merge commits unless you have conflicts to resolve. The final PR should not have dirty commits from collaborating on an organization fork like the previous PR.


The reason is the maintainers of this project will need to validate your changes and the source of the commits. Keeping it clean makes everyone's lives easy. Thanks and happy coding!
Hi Mrugesh! Thank you for your precious feedback! I've switched back to my personal GitHub account, and made a pull request . This time the commits are clean and the messages are concise. Thank you for taking time reviewing! I appreciate any feedback. :D