{"query_id": "q-en-vscode-6ebdcd901316ad872ba60e73ed01ade96ab92f3fa4abdc60a5ce1425555412f7", "query": "In version 0.10.1 it is no longer possible to write to the root of a drive (which worked up to 0.9.1). When trying to save to e.g. , the following error message appears: Tested on Windows 7 Ultimate and Windows 10 Professional, US language, German region settings.\nare you sure you can save there, can you try with nodepad?\nYes, I can write a text file with notepad. And I also tried other drives. What I found out in the meantime is that this happens only when creating a new file. Opening, editing and saving an existing file works correctly.\nso you do Ctrl+N, type something and then try to save it to r: from the windows save dialog?\nExactly. The error message appears trying to use Save, Save As or (when creating multiple files), Save All.\nis R: some drive created with subst or a real physical drive? I assume it is not the root drive where windows is installed?\nR: is a RAM disk - so I suspected this to be the problem at first. That's why I checked on other, \"real\" drives (except the system drive C:), and I can reproduce the behavior.\nWhat I'm not sure about is why VSCode is trying to run at all. When I do this from a command line (), I get an \"Access is denied\" there as well - which doesn't surprise me.\nIt actually tries to create the root path :) If you run VS Code as non-admin, it won't even let you try to save to but if you run VS Code as admin, it will let you try but fails on creating . !\nThanks, will look into it!\nThis looks like a bad regression in (). It relies on the EEXIST error but when reaching the root drive, it ends in EPERM. I think you touched this function last.\nAs of now, 0.10.8-insider build run as an administrator lets you save to D: export function isRoot(path: string): boolean { return path === dirname(path); } export function readdir(path: string): TPromise { return nfcall(extfs.readdir, path); }", "commid": "vscode_pr_475"}], "negative_passages": []} {"query_id": "q-en-vscode-6ebdcd901316ad872ba60e73ed01ade96ab92f3fa4abdc60a5ce1425555412f7", "query": "In version 0.10.1 it is no longer possible to write to the root of a drive (which worked up to 0.9.1). When trying to save to e.g. , the following error message appears: Tested on Windows 7 Ultimate and Windows 10 Professional, US language, German region settings.\nare you sure you can save there, can you try with nodepad?\nYes, I can write a text file with notepad. And I also tried other drives. What I found out in the meantime is that this happens only when creating a new file. Opening, editing and saving an existing file works correctly.\nso you do Ctrl+N, type something and then try to save it to r: from the windows save dialog?\nExactly. The error message appears trying to use Save, Save As or (when creating multiple files), Save All.\nis R: some drive created with subst or a real physical drive? I assume it is not the root drive where windows is installed?\nR: is a RAM disk - so I suspected this to be the problem at first. That's why I checked on other, \"real\" drives (except the system drive C:), and I can reproduce the behavior.\nWhat I'm not sure about is why VSCode is trying to run at all. When I do this from a command line (), I get an \"Access is denied\" there as well - which doesn't surprise me.\nIt actually tries to create the root path :) If you run VS Code as non-admin, it won't even let you try to save to but if you run VS Code as admin, it will let you try but fails on creating . !\nThanks, will look into it!\nThis looks like a bad regression in (). It relies on the EEXIST error but when reaching the root drive, it ends in EPERM. I think you touched this function last.\nAs of now, 0.10.8-insider build run as an administrator lets you save to D:(err); }); if (isRoot(path)) { return TPromise.as(true); } return mkdir().then(null, (err: NodeJS.ErrnoException) => { if (err.code === 'ENOENT') { return mkdirp(dirname(path), mode).then(mkdir);", "commid": "vscode_pr_475"}], "negative_passages": []} {"query_id": "q-en-vscode-882802ede8b9d03547478d251c59456fc1b22e9626f6c5e4eefe285345462f71", "query": "I can confirm this happens for me as well. I am using Mac OS X. The operating system's display scaling is off (i.e. 1:1). I have been experimenting and it seems as though the bug is that the right click menu is displayed according to the cursor position, but this calculation is not adjusted to take into account zoom. The reason I say this is because if I right click near the top left of the editor, the cursor is quite close to the top left of the menu. But if I right click near the bottom right of the editor, the cursor is much further away from the top left of the menu. The misalignment is proportional to the distance from the top left of the editor.", "positive_passages": [{"docid": "doc-en-vscode-001a4b7bb1b7b6d8cb4a037abf74bdad33d227c420c0084d7be954e8c27ee74c", "text": "import {IMessageService} from 'vs/platform/message/common/message'; import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService'; import {remote} from 'electron'; import {remote, webFrame} from 'electron'; export class ContextMenuService implements IContextMenuService {", "commid": "vscode_pr_5158"}], "negative_passages": []} {"query_id": "q-en-vscode-882802ede8b9d03547478d251c59456fc1b22e9626f6c5e4eefe285345462f71", "query": "I can confirm this happens for me as well. I am using Mac OS X. The operating system's display scaling is off (i.e. 1:1). I have been experimenting and it seems as though the bug is that the right click menu is displayed according to the cursor position, but this calculation is not adjusted to take into account zoom. The reason I say this is because if I right click near the top left of the editor, the cursor is quite close to the top left of the menu. But if I right click near the bottom right of the editor, the cursor is much further away from the top left of the menu. The misalignment is proportional to the distance from the top left of the editor.", "positive_passages": [{"docid": "doc-en-vscode-227813d8371170947c184c51151451b0d5005a463e1cfd85a9d929d9d69e861d", "text": "x = pos.x; y = pos.y; } let zoom = webFrame.getZoomFactor(); x *= zoom; y *= zoom; menu.popup(remote.getCurrentWindow(), Math.floor(x), Math.floor(y));", "commid": "vscode_pr_5158"}], "negative_passages": []} {"query_id": "q-en-vscode-882802ede8b9d03547478d251c59456fc1b22e9626f6c5e4eefe285345462f71", "query": "I can confirm this happens for me as well. I am using Mac OS X. The operating system's display scaling is off (i.e. 1:1). I have been experimenting and it seems as though the bug is that the right click menu is displayed according to the cursor position, but this calculation is not adjusted to take into account zoom. The reason I say this is because if I right click near the top left of the editor, the cursor is quite close to the top left of the menu. But if I right click near the bottom right of the editor, the cursor is much further away from the top left of the menu. The misalignment is proportional to the distance from the top left of the editor.", "positive_passages": [{"docid": "doc-en-vscode-99019b1f0a414797c1c69ab436fc4e734db8cc841e3681d76da9c740d49bbbd2", "text": "}) .done(null, e => this.messageService.show(severity.Error, e)); } } No newline at end of file } ", "commid": "vscode_pr_5158"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-ad0786495185e4f4bd1d00ebf729210fe89092bb3cc0fbbdd9aca9d87c3c6382", "text": ".pipe(util.cleanNodeModule('oniguruma', ['binding.gyp', 'build/**', 'src/**', 'deps/**'], ['**/*.node'])) .pipe(util.cleanNodeModule('windows-mutex', ['binding.gyp', 'build/**', 'src/**'], ['**/*.node'])) .pipe(util.cleanNodeModule('native-keymap', ['binding.gyp', 'build/**', 'src/**', 'deps/**'], ['**/*.node'])) .pipe(util.cleanNodeModule('windows-foreground-love', ['binding.gyp', 'build/**', 'src/**'], ['**/*.node'])) .pipe(util.cleanNodeModule('gc-signals', ['binding.gyp', 'build/**', 'src/**', 'deps/**'], ['**/*.node', 'src/index.js'])) .pipe(util.cleanNodeModule('pty.js', ['binding.gyp', 'build/**', 'src/**', 'deps/**'], ['build/Release/**']));", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-7a21bd5463b7c0c8f0c4016051ec5d6627f47087782b4afc1c3328c8849bd245", "text": "\"from\": \"vscode-textmate@2.2.0\", \"resolved\": \"https://registry.npmjs.org/vscode-textmate/-/vscode-textmate-2.2.0.tgz\" }, \"windows-foreground-love\": { \"version\": \"0.1.0\", \"from\": \"windows-foreground-love@0.1.0\", \"resolved\": \"https://registry.npmjs.org/windows-foreground-love/-/windows-foreground-love-0.1.0.tgz\" }, \"windows-mutex\": { \"version\": \"0.2.0\", \"from\": \"windows-mutex@>=0.2.0 <0.3.0\",", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-5c367a0d29a0549bb52c1ea1a673e5c8ae77ec6686397edb87f6e58e658e4f45", "text": "} }, \"optionalDependencies\": { \"windows-foreground-love\": \"0.1.0\", \"windows-mutex\": \"^0.2.0\", \"fsevents\": \"0.3.8\" }", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-7b075409b1a63d0c5395328769980034c4111b7e4ad73e9515a16c995313a46b", "text": " /*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ declare module 'windows-foreground-love' { export function allowSetForegroundWindow(pid?: number): boolean; } No newline at end of file", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-c1adc270de1f3e2197a8f8948414faf2d3cb7dad05ac66e7ae9379ca5e9135b5", "text": "export interface ILaunchService { start(args: ParsedArgs, userEnv: IProcessEnvironment): TPromise; getMainProcessId(): TPromise; } export interface ILaunchChannel extends IChannel { call(command: 'start', arg: IStartArguments): TPromise; call(command: 'get-main-process-id', arg: null): TPromise; call(command: string, arg: any): TPromise; }", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-01b30049a5fa379ac49525d8ef2377794d756f3faaa422a00a546545093eaa0e", "text": "constructor(private service: ILaunchService) { } call(command: string, arg: any): TPromise { const { args, userEnv } = arg as IStartArguments; switch (command) { case 'start': return this.service.start(args, userEnv); case 'start': const { args, userEnv } = arg as IStartArguments; return this.service.start(args, userEnv); case 'get-main-process-id': return this.service.getMainProcessId(); } } }", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-c0610bac00d5c5ba802ccdbacbc87cea5b4146337698da706a40bbf2eaa0ea87", "text": "start(args: ParsedArgs, userEnv: IProcessEnvironment): TPromise { return this.channel.call('start', { args, userEnv }); } getMainProcessId(): TPromise { return this.channel.call('get-main-process-id', null); } } export class LaunchService implements ILaunchService {", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-67cc2de280204bf08d2845639ac73612a186c87805649770163be3ec96b0e8d3", "text": "return TPromise.as(null); } getMainProcessId(): TPromise { this.logService.log('Received request for process ID from other instance.'); return TPromise.as(process.pid); } } No newline at end of file", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-52e531bee5bd90cb77e3e09dfbe5b5b8773a85b3542a7f9f61f72ece54d6f034", "query": "This can happen when code is already running and you start it again from the command line: The process that is started is killed very early after sending a IPC message to the running instance and that running instance is then trying to restore/focus the last active window which often fails. Related: As a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nPushed a workaround.\nReopening, using the () workaround causes issues as it will undock windows it seems.\nThis happens EVERY time for me - on all 3 machines I use it on, Windows 7 and Windows 10.\nAs a workaround if you have access to the windows registry: find change its value to (decimal) restart windows\nJust tried the suggested workaround and it did not work. Using Windows 10 Home\nI've been hit with this bug suddenly after having style execution from WinSCP work flawlessly for months. On top of that, the suggested workaround doesn't work as is nowhere to be found in my registry. Reading this it looks like the issue was fixed but has there been a regression?\nSeems to have re-emerged for me. On first launch of VSCode it will focus on top of other windows, but on subsequent launches it stays in the background and flashes in the taskbar. I searched the registry but can't find any reference to . I'm on Win10 Build\nMust have made the rookie mistake of not starting the search in the registry root earlier. It turns out there are several hits and the first one in seems to have worked.\nI started running into this issue today. Started when I would open a new window from my current window and the new window would not appear on screen, only in the taskbar. Upon restarting the PC, no windows now appear. Tried the workaround but with no luck. Windows10 Build\nUpdate: I made it to work by right clicking the task bar editor thumbnail of VSC and clicking on move. This made my cursor move to the edge of the desktop. I then dragged the corner of the VSC window to bring it to the center. It looks like VSC window was off the desktop boundary for some reason I have made registry changes to hkeylocalmachine and hkeycurrentuser as mentioned but it still doesn't work. Any other suggestions? Reinstalling doesn't fix the issue either.\nThis is happening to me also since the previous 2 releases. Changing the value of did not help", "positive_passages": [{"docid": "doc-en-vscode-bc3bebea08c5990d492be8bbb069d0d26ca1b50d5db8bd81c4eb873d35d9b675", "text": "const channel = client.getChannel('launch'); const service = new LaunchChannelClient(channel); return service.start(environmentService.args, process.env) let promise = TPromise.as(null); if (platform.isWindows) { promise = service.getMainProcessId() .then(processId => { logService.log('Sending some foreground love to the running instance:', processId); try { const { allowSetForegroundWindow } = require.__$__nodeRequire('windows-foreground-love'); allowSetForegroundWindow(processId); } catch (e) { // noop } }); } return promise .then(() => service.start(environmentService.args, process.env)) .then(() => client.dispose()) .then(() => TPromise.wrapError('Sent env to running instance. Terminating...')); },", "commid": "vscode_pr_13255"}], "negative_passages": []} {"query_id": "q-en-vscode-ffc1d310b22f02bd796cbc1ca8ae0fd0fc7365ab1cf1dd4f24534509b25aa91e", "query": "Unsure how I got into this state but changing different files doesn't fix it !\nJoao maybe you have an idea.\nSure, drag a file from the desktop over the explorer and press if (!viewItem) { if (!viewItem || (event.posx === 0 && event.posy === 0 && event.browserEvent.type === DOM.EventType.DRAG_LEAVE)) { // dragging outside of tree if (this.currentDropTarget) {", "commid": "vscode_pr_19667"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-65f80acdb0484c78ea5e35d9322f0b3088bf3a71e0d8c086335bffcc360c103b", "text": "'!build/{lib,tslintRules}/**/*.js', '!build/**/*.sh', '!build/tfs/**/*.js', '!build/tfs/**/*.config', '!**/Dockerfile', '!extensions/markdown-language-features/media/*.js' ];", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-e5e86ed87a771b31b3046f295436992045c1f9344d9a73fa4a099204f34faf5d", "text": "const setupDir = (arch, target) => path.join(repoPath, '.build', `win32-${arch}`, `${target}-setup`); const issPath = path.join(__dirname, 'win32', 'code.iss'); const innoSetupPath = path.join(path.dirname(path.dirname(require.resolve('innosetup-compiler'))), 'bin', 'ISCC.exe'); const signPS1 = path.join(repoPath, 'build', 'tfs', 'win32', 'sign.ps1'); function packageInnoSetup(iss, options, cb) { options = options || {};", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-c7177a5f3c62016e033492f36762942513b5cd4a4c0c52aa8b3e70ce1d8bbe38", "text": "keys.forEach(key => assert(typeof definitions[key] === 'string', `Missing value for '${key}' in Inno Setup package step`)); const defs = keys.map(key => `/d${key}=${definitions[key]}`); const args = [iss].concat(defs); const args = [ iss, ...defs, `/sesrp=powershell.exe -ExecutionPolicy bypass ${signPS1} $f` ]; cp.spawn(innoSetupPath, args, { stdio: ['ignore', 'inherit', 'inherit'] }) .on('error', cb)", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-4fb0c4b6423b94e2dd39249c01a865e4620ead37a6494808db69c979f6025989", "text": "] SessionTimeout: 120 - task: NuGetCommand@2 displayName: Install ESRPClient.exe inputs: restoreSolution: 'buildtfswin32ESRPClientpackages.config' feedsToUse: config nugetConfigPath: 'buildtfswin32ESRPClientNuGet.config' externalFeedCredentials: 3fc0b7f7-da09-4ae7-a9c8-d69824b1819b restoreDirectory: packages - task: ESRPImportCertTask@1 displayName: Import ESRP Request Signing Certificate inputs: ESRP: 'ESRP CodeSign' - powershell: | $ErrorActionPreference = \"Stop\" npm run gulp -- \"vscode-win32-$(VSCODE_ARCH)-archive\" \"vscode-win32-$(VSCODE_ARCH)-system-setup\" \"vscode-win32-$(VSCODE_ARCH)-user-setup\" - task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1 inputs: ConnectedServiceName: 'ESRP CodeSign' FolderPath: '$(agent.builddirectory)' Pattern: VSCodeSetup.exe signConfigType: inlineSignParams inlineOperation: | [ { \"keyCode\": \"CP-229803\", \"operationSetCode\": \"SigntoolSign\", \"parameters\": [ { \"parameterName\": \"OpusName\", \"parameterValue\": \"VS Code\" }, { \"parameterName\": \"OpusInfo\", \"parameterValue\": \"https://code.visualstudio.com/\" }, { \"parameterName\": \"PageHash\", \"parameterValue\": \"/NPH\" }, { \"parameterName\": \"TimeStamp\", \"parameterValue\": \"/t \"http://ts4096.gtm.microsoft.com/TSS/AuthenticodeTS\"\" } ], \"toolName\": \"sign\", \"toolVersion\": \"1.0\" }, { \"keyCode\": \"CP-230012\", \"operationSetCode\": \"SigntoolSign\", \"parameters\": [ { \"parameterName\": \"OpusName\", \"parameterValue\": \"VS Code\" }, { \"parameterName\": \"OpusInfo\", \"parameterValue\": \"https://code.visualstudio.com/\" }, { \"parameterName\": \"Append\", \"parameterValue\": \"/as\" }, { \"parameterName\": \"FileDigest\", \"parameterValue\": \"/fd \"SHA256\"\" }, { \"parameterName\": \"PageHash\", \"parameterValue\": \"/NPH\" }, { \"parameterName\": \"TimeStamp\", \"parameterValue\": \"/tr \"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer\" /td sha256\" } ], \"toolName\": \"sign\", \"toolVersion\": \"1.0\" }, { \"keyCode\": \"CP-230012\", \"operationSetCode\": \"SigntoolVerify\", \"parameters\": [ { \"parameterName\": \"VerifyAll\", \"parameterValue\": \"/all\" } ], \"toolName\": \"sign\", \"toolVersion\": \"1.0\" } ] SessionTimeout: 120 .buildtfswin32import-esrp-auth-cert.ps1 -AuthCertificateBase64 $(ESRP_AUTH_CERTIFICATE) -AuthCertificateKey $(ESRP_AUTH_CERTIFICATE_KEY) displayName: Import ESRP Auth Certificate - powershell: | $ErrorActionPreference = \"Stop\" npm run gulp -- \"vscode-win32-$(VSCODE_ARCH)-archive\" \"vscode-win32-$(VSCODE_ARCH)-system-setup\" \"vscode-win32-$(VSCODE_ARCH)-user-setup\" $Repo = \"$(pwd)\" $Root = \"$Repo..\" $SystemExe = \"$Repo.buildwin32-$(VSCODE_ARCH)system-setupVSCodeSetup.exe\"", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-a78a28ada92e120025260f318882eda8fe3ef65d06818a9b4dc034ea4baba174", "text": " No newline at end of file", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-7f1f7f17bee2f31b16431c090aa3afe27bcbfdb21d0eb212c5f425f3826e1eb8", "text": " ", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-01ec675b824274159db693e376b91791d8b1296597ea49f1d035a6c7c933b73a", "text": " Param( [string]$AuthCertificateBase64, [string]$AuthCertificateKey ) # Import auth certificate $AuthCertificateFileName = [System.IO.Path]::GetTempFileName() $AuthCertificateBytes = [Convert]::FromBase64String($AuthCertificateBase64) [IO.File]::WriteAllBytes($AuthCertificateFileName, $AuthCertificateBytes) $AuthCertificate = Import-PfxCertificate -FilePath $AuthCertificateFileName -CertStoreLocation Cert:LocalMachineMy -Password (ConvertTo-SecureString $AuthCertificateKey -AsPlainText -Force) rm $AuthCertificateFileName $ESRPAuthCertificateSubjectName = $AuthCertificate.Subject Write-Output (\"##vso[task.setvariable variable=ESRPAuthCertificateSubjectName;]$ESRPAuthCertificateSubjectName\") No newline at end of file", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-01b8db83c58ac7323f17e07532b638fe618972c692ece0c26fb9007539efcfda", "text": " function Create-TmpJson($Obj) { $FileName = [System.IO.Path]::GetTempFileName() ConvertTo-Json -Depth 100 $Obj | Out-File -Encoding UTF8 $FileName return $FileName } $Auth = Create-TmpJson @{ Version = \"1.0.0\" AuthenticationType = \"AAD_CERT\" ClientId = $env:ESRPClientId AuthCert = @{ SubjectName = $env:ESRPAuthCertificateSubjectName StoreLocation = \"LocalMachine\" StoreName = \"My\" } RequestSigningCert = @{ SubjectName = $env:ESRPCertificateSubjectName StoreLocation = \"LocalMachine\" StoreName = \"My\" } } $Policy = Create-TmpJson @{ Version = \"1.0.0\" } $Input = Create-TmpJson @{ Version = \"1.0.0\" SignBatches = @( @{ SourceLocationType = \"UNC\" SignRequestFiles = @( @{ SourceLocation = $args[0] } ) SigningInfo = @{ Operations = @( @{ KeyCode = \"CP-229803\" OperationCode = \"SigntoolSign\" Parameters = @{ OpusName = \"VS Code\" OpusInfo = \"https://code.visualstudio.com/\" PageHash = \"/NPH\" TimeStamp = \"/t `\"http://ts4096.gtm.microsoft.com/TSS/AuthenticodeTS`\"\" } ToolName = \"sign\" ToolVersion = \"1.0\" }, @{ KeyCode = \"CP-230012\" OperationCode = \"SigntoolSign\" Parameters = @{ OpusName = \"VS Code\" OpusInfo = \"https://code.visualstudio.com/\" Append = \"/as\" FileDigest = \"/fd `\"SHA256`\"\" PageHash = \"/NPH\" TimeStamp = \"/tr `\"http://rfc3161.gtm.corp.microsoft.com/TSS/HttpTspServer`\" /td sha256\" } ToolName = \"sign\" ToolVersion = \"1.0\" }, @{ KeyCode = \"CP-230012\" OperationCode = \"SigntoolVerify\" Parameters = @{ VerifyAll = \"/all\" } ToolName = \"sign\" ToolVersion = \"1.0\" } ) } } ) } $Output = [System.IO.Path]::GetTempFileName() $ScriptPath = Split-Path -Path $MyInvocation.MyCommand.Definition -Parent & \"$ScriptPathESRPClientpackagesEsrpClient.1.0.27toolsESRPClient.exe\" Sign -a $Auth -p $Policy -i $Input -o $Output No newline at end of file", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-ba9a6069d992286c78c63b7f608ebd449ed24b890769c11fb123420b5b60da82", "query": "Unlike the VS Code installer for Windows, the VS Code uninstaller for Windows is not signed. You can fix this by using the directive in your Inno Setup script. See For dual signing it's easiest to use Inno Setup 5.5.8 instead of 5.5.6 as you currently use: 5.5.8 allows you to have two SignTool directives, one for the sha-1 signing and another for the sha-256 signing.\nTo keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed. Thanks for your understanding. Happy coding!", "positive_passages": [{"docid": "doc-en-vscode-e533d4dc33fa309fdf35fee809afdea1f705360568227d8fd8e9db4f5e370fea", "text": "ShowLanguageDialog=auto ArchitecturesAllowed={#ArchitecturesAllowed} ArchitecturesInstallIn64BitMode={#ArchitecturesInstallIn64BitMode} SignTool=esrp #if \"user\" == InstallTarget DefaultDirName={userpf}{#DirName}", "commid": "vscode_pr_53447"}], "negative_passages": []} {"query_id": "q-en-vscode-8b4176da39d3c93c5cc40cca14c1c61bbe3e94c36ce1953d39474a4a514c729b", "query": ":+1:\n+1\nWhy is this essential feature still not a thing?\nbecause it relies on which is non-trivial and it needs to be prioritized against other work.\n+1\n+1\n+1 or adding a heading list view(TOC view) on the right side, it's really convenient for editing a large markdown file.\nPlease refer to the org-mode tab feature to implement, it's powerful.\n+1\nduplicate of\nReopening to track the markdown specific work of\nI noticed that this is already implemented in the latest insider build, thanks a lot. One more request, would you please preserve the last blank line of a folded region? I mean becomes instead of One reason is that currently\nCan anyone update the status on this?\nit's coming to the next stable release.", "positive_passages": [{"docid": "doc-en-vscode-d724407c5237a753f2d024cf280dbe4e6148d29dc9a8be12d8d2e08dbde3751b", "text": "import MDDocumentSymbolProvider from './features/documentSymbolProvider'; import { MarkdownContentProvider } from './features/previewContentProvider'; import { MarkdownPreviewManager } from './features/previewManager'; import MarkdownFoldingProvider from './features/foldingProvider'; export function activate(context: vscode.ExtensionContext) {", "commid": "vscode_pr_44795"}], "negative_passages": []} {"query_id": "q-en-vscode-8b4176da39d3c93c5cc40cca14c1c61bbe3e94c36ce1953d39474a4a514c729b", "query": ":+1:\n+1\nWhy is this essential feature still not a thing?\nbecause it relies on which is non-trivial and it needs to be prioritized against other work.\n+1\n+1\n+1 or adding a heading list view(TOC view) on the right side, it's really convenient for editing a large markdown file.\nPlease refer to the org-mode tab feature to implement, it's powerful.\n+1\nduplicate of\nReopening to track the markdown specific work of\nI noticed that this is already implemented in the latest insider build, thanks a lot. One more request, would you please preserve the last blank line of a folded region? I mean becomes instead of One reason is that currently\nCan anyone update the status on this?\nit's coming to the next stable release.", "positive_passages": [{"docid": "doc-en-vscode-4a1d333d6eecdf9fdfbd0d60d3fe0ee246a9a109da5889280736df57248e069c", "text": "context.subscriptions.push(vscode.languages.registerDocumentSymbolProvider(selector, new MDDocumentSymbolProvider(engine))); context.subscriptions.push(vscode.languages.registerDocumentLinkProvider(selector, new LinkProvider())); context.subscriptions.push(vscode.languages.registerFoldingProvider(selector, new MarkdownFoldingProvider(engine))); const previewSecuritySelector = new PreviewSecuritySelector(cspArbiter, previewManager);", "commid": "vscode_pr_44795"}], "negative_passages": []} {"query_id": "q-en-vscode-8b4176da39d3c93c5cc40cca14c1c61bbe3e94c36ce1953d39474a4a514c729b", "query": ":+1:\n+1\nWhy is this essential feature still not a thing?\nbecause it relies on which is non-trivial and it needs to be prioritized against other work.\n+1\n+1\n+1 or adding a heading list view(TOC view) on the right side, it's really convenient for editing a large markdown file.\nPlease refer to the org-mode tab feature to implement, it's powerful.\n+1\nduplicate of\nReopening to track the markdown specific work of\nI noticed that this is already implemented in the latest insider build, thanks a lot. One more request, would you please preserve the last blank line of a folded region? I mean becomes instead of One reason is that currently\nCan anyone update the status on this?\nit's coming to the next stable release.", "positive_passages": [{"docid": "doc-en-vscode-691eabeffe30126c71ee38bb5844c2214698a7073e41f7197124f9031fb0eec3", "text": " /*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as vscode from 'vscode'; import { MarkdownEngine } from '../markdownEngine'; import { TableOfContentsProvider } from '../tableOfContentsProvider'; export default class MarkdownFoldingProvider implements vscode.FoldingProvider { constructor( private readonly engine: MarkdownEngine ) { } public async provideFoldingRanges( document: vscode.TextDocument, _token: vscode.CancellationToken ): Promise { const tocProvider = new TableOfContentsProvider(this.engine, document); const toc = await tocProvider.getToc(); const foldingRanges = toc.map((entry, startIndex) => { const start = entry.line; let end: number | undefined = undefined; for (let i = startIndex + 1; i < toc.length; ++i) { if (toc[i].level <= entry.level) { end = toc[i].line - 1; break; } } return new vscode.FoldingRange( start, typeof end === 'number' ? end : document.lineCount - 1); }); return new vscode.FoldingRangeList(foldingRanges); } } No newline at end of file", "commid": "vscode_pr_44795"}], "negative_passages": []} {"query_id": "q-en-vscode-4a8c7d1d3d78ee4197bf9cfd5437af67f6ccde3bb0c20d861766158c78491f7b", "query": "VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) \"publ\" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: \"acceptSelectedSuggestion\" without the caret still works\nLooking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.\nI can confirm it doesn't work on TypeScript due to the context key not being set.\nThere is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting\nDespite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work\nthe timeout and like breakage happened in\nOh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?\nworks", "positive_passages": [{"docid": "doc-en-vscode-695b9a41ca7c1abdf7d840f9d2a1a15ffd14802161319058b01f24851feb7e5c", "text": " /*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ export interface IScrollEvent { vertical: boolean; horizontal: boolean; } export interface IDelegate { getHeight(element: T): number; getTemplateId(element: T): string; } export interface IRenderer { renderTemplate(container: HTMLElement): TTemplateData; renderElement(element: TElement, templateData: TTemplateData): void; disposeTemplate(templateData: TTemplateData): void; } export interface IRendererMap { [templateId: string]: IRenderer; } ", "commid": "vscode_pr_2702"}], "negative_passages": []} {"query_id": "q-en-vscode-4a8c7d1d3d78ee4197bf9cfd5437af67f6ccde3bb0c20d861766158c78491f7b", "query": "VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) \"publ\" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: \"acceptSelectedSuggestion\" without the caret still works\nLooking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.\nI can confirm it doesn't work on TypeScript due to the context key not being set.\nThere is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting\nDespite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work\nthe timeout and like breakage happened in\nOh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?\nworks", "positive_passages": [{"docid": "doc-en-vscode-3291c4f1aa1f92188d2300e4bba0779ea5dac911f7ee700de5d21fd9a7bb633a", "text": " /*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import { IScrollable } from 'vs/base/common/scrollable'; import Event, { Emitter } from 'vs/base/common/event'; import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import { Gesture } from 'vs/base/browser/touch'; import * as DOM from 'vs/base/browser/dom'; import { IScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement'; import { ScrollableElement } from 'vs/base/browser/ui/scrollbar/impl/scrollableElement'; import { RangeMap } from './rangeMap'; import { IScrollEvent, IDelegate, IRendererMap } from './list'; import { RowCache, IRow } from './rowCache'; interface IItem { height: number; templateId: string; row: IRow; } export class List implements IScrollable { private items: IItem[]; private rangeMap: RangeMap; private cache: RowCache; private _scrollTop: number; private _viewHeight: number; private renderTop: number; private renderHeight: number; private domNode: HTMLElement; private wrapper: HTMLElement; private gesture: Gesture; private rowsContainer: HTMLElement; private scrollableElement: IScrollableElement; private _onScroll = new Emitter(); onScroll: Event = this._onScroll.event; constructor(container: HTMLElement, delegate: IDelegate, renderers: IRendererMap) { this.items = []; this.rangeMap = new RangeMap(); this.cache = new RowCache(renderers); this.domNode = document.createElement('div'); this.domNode.className = 'monaco-list'; this.domNode.tabIndex = 0; this.wrapper = document.createElement('div'); this.wrapper.className = 'monaco-list-wrapper'; this.scrollableElement = new ScrollableElement(this.wrapper, { forbidTranslate3dUse: true, scrollable: this, horizontal: 'hidden', vertical: 'auto', useShadows: true, saveLastScrollTimeOnClassName: 'monaco-list-row' }); this.gesture = new Gesture(this.wrapper); this.rowsContainer = document.createElement('div'); this.rowsContainer.className = 'monaco-list-rows'; } layout(height?: number): void { // if (!this.isTreeVisible()) { // \treturn; // } this.viewHeight = height || DOM.getContentHeight(this.wrapper); // render this.setScrollTop(this.scrollTop); // render this.scrollableElement.onElementDimensions(); this.scrollableElement.onElementInternalDimensions(); } // IScrollable getScrollHeight(): number { return this.rangeMap.size; } getScrollWidth(): number { return 0; } getScrollLeft(): number { return 0; } setScrollLeft(scrollLeft: number): void { // noop } getScrollTop(): number { return this.scrollTop; } setScrollTop(scrollTop: number): void { scrollTop = Math.min(scrollTop, this.getScrollHeight() - this.viewHeight); scrollTop = Math.max(scrollTop, 0); this.render(scrollTop, this.viewHeight); this._scrollTop = scrollTop; this._onScroll.fire({ vertical: true, horizontal: false }); } addScrollListener(callback: ()=>void): IDisposable { return this.onScroll(callback); } // Render Properties private get viewHeight() { return this._viewHeight; } private set viewHeight(viewHeight: number) { this.render(this.scrollTop, viewHeight); this._viewHeight = viewHeight; } private get scrollTop(): number { return this._scrollTop; } private set scrollTop(scrollTop: number) { this.setScrollTop(scrollTop); } // Render private render(scrollTop: number, viewHeight: number): void { const renderTop = Math.max(scrollTop, 0); const renderBottom = scrollTop + viewHeight; const thisRenderBottom = this.scrollTop + this.viewHeight; let i: number, stop: number; // when view scrolls down, start rendering from the renderBottom for (i = this.indexAfter(renderBottom) - 1, stop = this.rangeMap.indexAt(Math.max(thisRenderBottom, renderTop)); i >= stop; i--) { this.insertItemInDOM(i); } // when view scrolls up, start rendering from either this.renderTop or renderBottom for (i = Math.min(this.rangeMap.indexAt(this.renderTop), this.indexAfter(renderBottom)) - 1, stop = this.rangeMap.indexAt(renderTop); i >= stop; i--) { this.insertItemInDOM(i); } // when view scrolls down, start unrendering from renderTop for (i = this.rangeMap.indexAt(this.renderTop), stop = Math.min(this.rangeMap.indexAt(renderTop), this.indexAfter(thisRenderBottom)); i < stop; i++) { this.removeItemFromDOM(i); } // when view scrolls up, start unrendering from either renderBottom this.renderTop for (i = Math.max(this.indexAfter(renderBottom), this.rangeMap.indexAt(this.renderTop)), stop = this.indexAfter(thisRenderBottom); i < stop; i++) { this.removeItemFromDOM(i); } const topPosition = this.rangeMap.positionAt(this.rangeMap.indexAt(renderTop)); if (topPosition > -1) { this.rowsContainer.style.top = (topPosition - renderTop) + 'px'; } this.renderTop = renderTop; this.renderHeight = renderBottom - renderTop; } private indexAfter(position: number): number { return Math.min(this.rangeMap.indexAt(position) + 1, this.rangeMap.size); } private insertItemInDOM(index: number): void { const item = this.items[index]; if (!item.row) { item.row = this.cache.alloc(item.templateId); // used in reverse lookup from HTMLElement to Item // ( this.element)[TreeView.BINDING] = this; } if (item.row.domNode.parentElement) { return; } const nextItem = this.items[index + 1]; if (nextItem && nextItem.row) { this.rowsContainer.insertBefore(item.row.domNode, nextItem.row.domNode); } else { this.rowsContainer.appendChild(item.row.domNode); } this.renderItem(index); } private removeItemFromDOM(index: number): void { const item = this.items[index]; if (!item.row) { return; } // ( this.element)[TreeView.BINDING] = null; this.cache.release(item.row); item.row = null; } private renderItem(index: number): void { // TODO } dispose() { this.items = null; if (this.domNode && this.domNode.parentElement) { this.domNode.parentNode.removeChild(this.domNode); this.domNode = null; } this.rangeMap = dispose(this.rangeMap); this.gesture = dispose(this.gesture); this.scrollableElement = dispose(this.scrollableElement); this._onScroll = dispose(this._onScroll); } } ", "commid": "vscode_pr_2702"}], "negative_passages": []} {"query_id": "q-en-vscode-4a8c7d1d3d78ee4197bf9cfd5437af67f6ccde3bb0c20d861766158c78491f7b", "query": "VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) \"publ\" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: \"acceptSelectedSuggestion\" without the caret still works\nLooking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.\nI can confirm it doesn't work on TypeScript due to the context key not being set.\nThere is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting\nDespite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work\nthe timeout and like breakage happened in\nOh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?\nworks", "positive_passages": [{"docid": "doc-en-vscode-7a6267e4f77aa869ebb406aa2b1bcc6ada720afea435bcf1da0fb63e6ce5650d", "text": " /*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ export interface IGroup { count: number; size: number; } export interface IRange { start: number; end: number; } export interface IRangedGroup { range: IRange; size: number; } /** * Returns the intersection between two ranges as a range itself. * Returns `null` if the intersection is empty. */ export function intersect(one: IRange, other: IRange): IRange { if (one.start >= other.end || other.start >= one.end) { return null; } const start = Math.max(one.start, other.start); const end = Math.min(one.end, other.end); if (end - start <= 0) { return null; } return { start, end }; } /** * Returns the intersection between a ranged group and a range. * Returns `[]` if the intersection is empty. */ export function groupIntersect(range: IRange, groups: IRangedGroup[]): IRangedGroup[] { const result: IRangedGroup[] = []; for (const r of groups) { if (range.start >= r.range.end) { continue; } if (range.end < r.range.start) { break; } const intersection = intersect(range, r.range); if (!intersection) { continue; } result.push({ range: intersection, size: r.size }); } return result; } /** * Shifts a range by that `much`. */ function shift({ start, end }: IRange, much: number): IRange { return { start: start + much, end: end + much }; } /** * Consolidates a collection of ranged groups. * * Consolidation is the process of merging consecutive ranged groups * that share the same `size`. */ export function consolidate(groups: IRangedGroup[]): IRangedGroup[] { const result: IRangedGroup[] = []; let previousGroup: IRangedGroup = null; for (const group of groups) { const start = group.range.start; const end = group.range.end; const size = group.size; if (previousGroup && size === previousGroup.size) { previousGroup.range.end = end; continue; } previousGroup = { range: { start, end }, size }; result.push(previousGroup); } return result; } /** * Concatenates several collections of ranged groups into a single * collection. */ function concat(...groups: IRangedGroup[][]): IRangedGroup[] { return consolidate(groups.reduce((r, g) => r.concat(g), [] as IRangedGroup[])); } export class RangeMap { private groups: IRangedGroup[] = []; private _size = 0; splice(index: number, deleteCount: number, ...groups: IGroup[]): void { let diff = -deleteCount; let index2 = index; const middle = groups .filter(g => g.count > 0 && g.size > 0) .map(g => { const end = index2 + g.count; const result = { range: { start: index2, end }, size: g.size }; diff += g.count; index2 = end; return result; }); const before = groupIntersect({ start: 0, end: index }, this.groups); const after = groupIntersect({ start: index + deleteCount, end: Number.POSITIVE_INFINITY }, this.groups) .map(g => ({ range: shift(g.range, diff), size: g.size })); this.groups = concat(before, middle, after); this._size = this.groups.reduce((t, g) => t + (g.size * (g.range.end - g.range.start)), 0); } /** * Returns the number of items in the range map. */ get count(): number { const len = this.groups.length; if (!len) { return 0; } return this.groups[len - 1].range.end; } /** * Returns the sum of the sizes of all items in the range map. */ get size(): number { return this._size; } /** * Returns index of the item at the given position. */ indexAt(position: number): number { if (position < 0) { return -1; } let index = 0; let size = 0; for (const group of this.groups) { const newSize = size + ((group.range.end - group.range.start) * group.size); if (position < newSize) { return index + Math.floor((position - size) / group.size); } index += group.size; size = newSize; } return -1; } /** * Returns the start position of the item at the given index. */ positionAt(index: number): number { if (index < 0) { return -1; } let position = 0; let count = 0; for (const group of this.groups) { const groupCount = group.range.end - group.range.start; const newCount = count + groupCount; if (index < newCount) { return position + ((index - count) * group.size); } position += groupCount * group.size; count = newCount; } return -1; } dispose() { this.groups = null; } } No newline at end of file", "commid": "vscode_pr_2702"}], "negative_passages": []} {"query_id": "q-en-vscode-4a8c7d1d3d78ee4197bf9cfd5437af67f6ccde3bb0c20d861766158c78491f7b", "query": "VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) \"publ\" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: \"acceptSelectedSuggestion\" without the caret still works\nLooking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.\nI can confirm it doesn't work on TypeScript due to the context key not being set.\nThere is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting\nDespite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work\nthe timeout and like breakage happened in\nOh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?\nworks", "positive_passages": [{"docid": "doc-en-vscode-16e8f9e7b12955fa7bc8115af1904f107050605f442f18f003513e2461c7816a", "text": " /*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import { IRendererMap } from './list'; import { IDisposable } from 'vs/base/common/lifecycle'; import { append, emmet as $, addClass, removeClass } from 'vs/base/browser/dom'; export interface IRow { domNode: HTMLElement; templateId: string; templateData: any; } function getLastScrollTime(element: HTMLElement): number { var value = element.getAttribute('last-scroll-time'); return value ? parseInt(value, 10) : 0; } function removeFromParent(element: HTMLElement): void { try { element.parentElement.removeChild(element); } catch (e) { // this will throw if this happens due to a blur event, nasty business } } export class RowCache implements IDisposable { private cache: { [templateId:string]: IRow[]; }; private scrollingRow: IRow; constructor(private renderers: IRendererMap) { this.cache = Object.create(null); this.scrollingRow = null; } /** * Returns a row either by creating a new one or reusing * a previously released row which shares the same templateId. */ alloc(templateId: string): IRow { let result = this.getTemplateCache(templateId).pop(); if (!result) { const domNode = $('div'); const content = append(domNode, $('.content')); const renderer = this.renderers[templateId]; const templateData = renderer.renderTemplate(content); result = { domNode, templateId, templateData }; } return result; } /** * Releases the row for eventual reuse. The row's domNode * will eventually be removed from its parent, given that * it is not the currently scrolling row (for OS X ballistic * scrolling). */ release(row: IRow): void { var lastScrollTime = getLastScrollTime(row.domNode); if (!lastScrollTime) { removeFromParent(row.domNode); this.getTemplateCache(row.templateId).push(row); return; } if (this.scrollingRow) { var lastKnownScrollTime = getLastScrollTime(this.scrollingRow.domNode); if (lastKnownScrollTime > lastScrollTime) { removeFromParent(row.domNode); this.getTemplateCache(row.templateId).push(row); return; } if (this.scrollingRow.domNode.parentElement) { removeFromParent(this.scrollingRow.domNode); removeClass(this.scrollingRow.domNode, 'scrolling'); this.getTemplateCache(this.scrollingRow.templateId).push(this.scrollingRow); } } this.scrollingRow = row; addClass(this.scrollingRow.domNode, 'scrolling'); } private getTemplateCache(templateId: string): IRow[] { return this.cache[templateId] || (this.cache[templateId] = []); } garbageCollect(): void { if (this.cache) { Object.keys(this.cache).forEach(templateId => { this.cache[templateId].forEach(cachedRow => { const renderer = this.renderers[templateId]; renderer.disposeTemplate(cachedRow.templateData); cachedRow.domNode = null; cachedRow.templateData = null; }); delete this.cache[templateId]; }); } if (this.scrollingRow) { const renderer = this.renderers[this.scrollingRow.templateId]; renderer.disposeTemplate(this.scrollingRow.templateData); this.scrollingRow = null; } } dispose(): void { this.garbageCollect(); this.cache = null; this.renderers = null; } } No newline at end of file", "commid": "vscode_pr_2702"}], "negative_passages": []} {"query_id": "q-en-vscode-4a8c7d1d3d78ee4197bf9cfd5437af67f6ccde3bb0c20d861766158c78491f7b", "query": "VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) \"publ\" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: \"acceptSelectedSuggestion\" without the caret still works\nLooking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.\nI can confirm it doesn't work on TypeScript due to the context key not being set.\nThere is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting\nDespite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work\nthe timeout and like breakage happened in\nOh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?\nworks", "positive_passages": [{"docid": "doc-en-vscode-a10bb590c89ef1d28e2a6d11597f64068ddb3b0235968b687088b993d595bd2e", "text": " /*--------------------------------------------------------------------------------------------- * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import assert = require('assert'); import { RangeMap, intersect, groupIntersect, IRangedGroup, consolidate } from '../rangeMap'; suite('RangeMap', () => { var rangeMap: RangeMap; setup(() => { rangeMap = new RangeMap(); }); teardown(() => { rangeMap.dispose(); }); test('intersection', () => { assert.deepEqual(intersect({ start: 0, end: 0 }, { start: 0, end: 0 }), null); assert.deepEqual(intersect({ start: 0, end: 0 }, { start: 5, end: 5 }), null); assert.deepEqual(intersect({ start: 0, end: 1 }, { start: 5, end: 6 }), null); assert.deepEqual(intersect({ start: 5, end: 6 }, { start: 0, end: 1 }), null); assert.deepEqual(intersect({ start: 0, end: 5 }, { start: 2, end: 2 }), null); assert.deepEqual(intersect({ start: 0, end: 1 }, { start: 0, end: 1 }), { start: 0, end: 1 }); assert.deepEqual(intersect({ start: 0, end: 10 }, { start: 0, end: 5 }), { start: 0, end: 5 }); assert.deepEqual(intersect({ start: 0, end: 5 }, { start: 0, end: 10 }), { start: 0, end: 5 }); assert.deepEqual(intersect({ start: 0, end: 10 }, { start: 5, end: 10 }), { start: 5, end: 10 }); assert.deepEqual(intersect({ start: 5, end: 10 }, { start: 0, end: 10 }), { start: 5, end: 10 }); assert.deepEqual(intersect({ start: 0, end: 10 }, { start: 2, end: 8 }), { start: 2, end: 8 }); assert.deepEqual(intersect({ start: 2, end: 8 }, { start: 0, end: 10 }), { start: 2, end: 8 }); assert.deepEqual(intersect({ start: 0, end: 10 }, { start: 5, end: 15 }), { start: 5, end: 10 }); assert.deepEqual(intersect({ start: 5, end: 15 }, { start: 0, end: 10 }), { start: 5, end: 10 }); }); test('multiIntersect', () => { assert.deepEqual( groupIntersect( { start: 0, end: 0 }, [{ range: { start: 0, end: 10 }, size: 1 }] ), [] ); assert.deepEqual( groupIntersect( { start: 10, end: 20 }, [{ range: { start: 0, end: 10 }, size: 1 }] ), [] ); assert.deepEqual( groupIntersect( { start: 2, end: 8 }, [{ range: { start: 0, end: 10 }, size: 1 }] ), [{ range: { start: 2, end: 8 }, size: 1 }] ); assert.deepEqual( groupIntersect( { start: 2, end: 8 }, [{ range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 5 }] ), [{ range: { start: 2, end: 8 }, size: 1 }] ); assert.deepEqual( groupIntersect( { start: 12, end: 18 }, [{ range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 5 }] ), [{ range: { start: 12, end: 18 }, size: 5 }] ); assert.deepEqual( groupIntersect( { start: 2, end: 18 }, [{ range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 5 }] ), [{ range: { start: 2, end: 10 }, size: 1 }, { range: { start: 10, end: 18 }, size: 5 }] ); assert.deepEqual( groupIntersect( { start: 2, end: 28 }, [{ range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 5 }, { range: { start: 20, end: 30 }, size: 10 }] ), [{ range: { start: 2, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 5 }, { range: { start: 20, end: 28 }, size: 10 }] ); }); test('consolidate', () => { assert.deepEqual(consolidate([]), []); assert.deepEqual( consolidate([{ range: { start: 0, end: 10 }, size: 1 }]), [{ range: { start: 0, end: 10 }, size: 1 }] ); assert.deepEqual( consolidate([ { range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 1 } ]), [{ range: { start: 0, end: 20 }, size: 1 }] ); assert.deepEqual( consolidate([ { range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 1 }, { range: { start: 20, end: 100 }, size: 1 } ]), [{ range: { start: 0, end: 100 }, size: 1 }] ); assert.deepEqual( consolidate([ { range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 5 }, { range: { start: 20, end: 30 }, size: 10 } ]), [ { range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 5 }, { range: { start: 20, end: 30 }, size: 10 } ] ); assert.deepEqual( consolidate([ { range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 20 }, size: 2 }, { range: { start: 20, end: 100 }, size: 2 } ]), [ { range: { start: 0, end: 10 }, size: 1 }, { range: { start: 10, end: 100 }, size: 2 } ] ); }); test('empty', () => { assert.equal(rangeMap.size, 0); assert.equal(rangeMap.count, 0); }); test('length & count', () => { rangeMap.splice(0, 0, { count: 1, size: 1 }); assert.equal(rangeMap.size, 1); assert.equal(rangeMap.count, 1); }); test('length & count #2', () => { rangeMap.splice(0, 0, { count: 5, size: 1 }); assert.equal(rangeMap.size, 5); assert.equal(rangeMap.count, 5); }); test('length & count #3', () => { rangeMap.splice(0, 0, { count: 1, size: 5 }); assert.equal(rangeMap.size, 5); assert.equal(rangeMap.count, 1); }); test('length & count #4', () => { rangeMap.splice(0, 0, { count: 5, size: 5 }); assert.equal(rangeMap.size, 25); assert.equal(rangeMap.count, 5); }); test('insert', () => { rangeMap.splice(0, 0, { count: 5, size: 5 }); assert.equal(rangeMap.size, 25); assert.equal(rangeMap.count, 5); rangeMap.splice(0, 0, { count: 5, size: 5 }); assert.equal(rangeMap.size, 50); assert.equal(rangeMap.count, 10); rangeMap.splice(5, 0, { count: 2, size: 10 }); assert.equal(rangeMap.size, 70); assert.equal(rangeMap.count, 12); rangeMap.splice(12, 0, { count: 1, size: 200 }); assert.equal(rangeMap.size, 270); assert.equal(rangeMap.count, 13); }); test('delete', () => { rangeMap.splice(0, 0, { count: 20, size: 5 }); assert.equal(rangeMap.size, 100); assert.equal(rangeMap.count, 20); rangeMap.splice(10, 5); assert.equal(rangeMap.size, 75); assert.equal(rangeMap.count, 15); rangeMap.splice(0, 1); assert.equal(rangeMap.size, 70); assert.equal(rangeMap.count, 14); rangeMap.splice(1, 13); assert.equal(rangeMap.size, 5); assert.equal(rangeMap.count, 1); rangeMap.splice(1, 1); assert.equal(rangeMap.size, 5); assert.equal(rangeMap.count, 1); }); test('insert & delete', () => { assert.equal(rangeMap.size, 0); assert.equal(rangeMap.count, 0); rangeMap.splice(0, 0, { count: 1, size: 1 }); assert.equal(rangeMap.size, 1); assert.equal(rangeMap.count, 1); rangeMap.splice(0, 1); assert.equal(rangeMap.size, 0); assert.equal(rangeMap.count, 0); }); test('insert & delete #2', () => { rangeMap.splice(0, 0, { count: 10, size: 1 }); rangeMap.splice(2, 6); assert.equal(rangeMap.count, 4); assert.equal(rangeMap.size, 4); }); test('insert & delete #3', () => { rangeMap.splice(0, 0, { count: 10, size: 1 }, { count: 10, size: 2 }); rangeMap.splice(8, 4); assert.equal(rangeMap.count, 16); assert.equal(rangeMap.size, 24); }); test('insert & delete #3', () => { rangeMap.splice(0, 0, { count: 10, size: 1 }, { count: 10, size: 2 }); rangeMap.splice(5, 0, { count: 5, size: 3 }); assert.equal(rangeMap.count, 25); assert.equal(rangeMap.size, 45); rangeMap.splice(4, 7); assert.equal(rangeMap.count, 18); assert.equal(rangeMap.size, 28); }); suite('indexAt, positionAt', () => { test('empty', () => { assert.equal(rangeMap.indexAt(0), -1); assert.equal(rangeMap.indexAt(10), -1); assert.equal(rangeMap.indexAt(-1), -1); assert.equal(rangeMap.positionAt(0), -1); assert.equal(rangeMap.positionAt(10), -1); assert.equal(rangeMap.positionAt(-1), -1); }); test('simple', () => { rangeMap.splice(0, 0, { count: 1, size: 1 }); assert.equal(rangeMap.indexAt(0), 0); assert.equal(rangeMap.indexAt(1), -1); assert.equal(rangeMap.positionAt(0), 0); assert.equal(rangeMap.positionAt(1), -1); }); test('simple #2', () => { rangeMap.splice(0, 0, { count: 1, size: 10 }); assert.equal(rangeMap.indexAt(0), 0); assert.equal(rangeMap.indexAt(5), 0); assert.equal(rangeMap.indexAt(9), 0); assert.equal(rangeMap.indexAt(10), -1); assert.equal(rangeMap.positionAt(0), 0); assert.equal(rangeMap.positionAt(1), -1); }); test('insert', () => { rangeMap.splice(0, 0, { count: 10, size: 1 }); assert.equal(rangeMap.indexAt(0), 0); assert.equal(rangeMap.indexAt(1), 1); assert.equal(rangeMap.indexAt(5), 5); assert.equal(rangeMap.indexAt(9), 9); assert.equal(rangeMap.indexAt(10), -1); rangeMap.splice(10, 0, { count: 10, size: 1 }); assert.equal(rangeMap.indexAt(10), 10); assert.equal(rangeMap.indexAt(19), 19); assert.equal(rangeMap.indexAt(20), -1); assert.equal(rangeMap.positionAt(0), 0); assert.equal(rangeMap.positionAt(1), 1); assert.equal(rangeMap.positionAt(19), 19); assert.equal(rangeMap.positionAt(20), -1); }); test('delete', () => { rangeMap.splice(0, 0, { count: 10, size: 1 }); rangeMap.splice(2, 6); assert.equal(rangeMap.indexAt(0), 0); assert.equal(rangeMap.indexAt(1), 1); assert.equal(rangeMap.indexAt(3), 3); assert.equal(rangeMap.indexAt(4), -1); assert.equal(rangeMap.positionAt(0), 0); assert.equal(rangeMap.positionAt(1), 1); assert.equal(rangeMap.positionAt(3), 3); assert.equal(rangeMap.positionAt(4), -1); }); test('delete #2', () => { rangeMap.splice(0, 0, { count: 10, size: 10 }); rangeMap.splice(2, 6); assert.equal(rangeMap.indexAt(0), 0); assert.equal(rangeMap.indexAt(1), 0); assert.equal(rangeMap.indexAt(30), 3); assert.equal(rangeMap.indexAt(40), -1); assert.equal(rangeMap.positionAt(0), 0); assert.equal(rangeMap.positionAt(1), 10); assert.equal(rangeMap.positionAt(2), 20); assert.equal(rangeMap.positionAt(3), 30); assert.equal(rangeMap.positionAt(4), -1); }); }); }); No newline at end of file", "commid": "vscode_pr_2702"}], "negative_passages": []} {"query_id": "q-en-vscode-4a8c7d1d3d78ee4197bf9cfd5437af67f6ccde3bb0c20d861766158c78491f7b", "query": "VSCode Version: 0.10.11 OS Version: Win10 Steps to Reproduce: this key binding: a code file (C#, JS, TS) \"publ\" followed by the space key Expected: The text should be (with a space at the end) Actual: The text is , no autocompletion occurred. Note: \"acceptSelectedSuggestion\" without the caret still works\nLooking thru the default bindings, I noticed this binding at the very bottom of the file: Pressing does not autocomplete in TypeScript either.\nI can confirm it doesn't work on TypeScript due to the context key not being set.\nThere is two problems: commit introduced a regression in that it turns around the boolean condition (missing ) ended up with having the command two times when working on the acceptOnEnter config setting\nDespite the fixes above this still happens. The reason seems to be that uses a timeout. That gives the triggerOnCharacter command a chance to run (and clear the previous suggest model) such that accept doesn't work\nthe timeout and like breakage happened in\nOh, the missing ! Ugh, sorry about that. The was just a leftover. I made a change that enables me to simply remove it. :+1: can you see whether the now works?\nworks", "positive_passages": [{"docid": "doc-en-vscode-f43e1e611f9ebebd0ae926e40dbcdb1c482642feda06865674985e43f3afa895", "text": "dispose(): void; } export function dispose(disposable: T): T { if (disposable) { disposable.dispose(); } return null; } export function disposeAll(arr: T[]): T[] { if (arr) { for (let i = 0, len = arr.length; i < len; i++) {", "commid": "vscode_pr_2702"}], "negative_passages": []} {"query_id": "q-en-vscode-0b9cfdec6b503a498db47ddc80deec18a5d01396e1a8a70c9431829295703722", "query": "VSCode Version: 0.10.11 OS Version: Windows 10 Steps to Reproduce: click on an unknown file type, like or Open with... VS Code and check always use this app to open files of this type The file gets the app icon of VS Code, not the document icon: !", "positive_passages": [{"docid": "doc-en-vscode-8f717e10dac160b1d5650daeaec0a91d7b4888ed07806eda128c9981865783b5", "text": "Root: HKCR; Subkey: \"{#RegValueName}SourceFileDefaultIcon\"; ValueType: string; ValueName: \"\"; ValueData: \"{app}resourcesappresourceswin32code_file.ico\" Root: HKCR; Subkey: \"{#RegValueName}SourceFileshellopencommand\"; ValueType: string; ValueName: \"\"; ValueData: \"\"\"{app}{#ExeBasename}.exe\"\" \"\"%1\"\"\" Root: HKCR; Subkey: \"Applications{#ExeBasename}.exe\"; ValueType: none; ValueName: \"\"; Flags: uninsdeletekey Root: HKCR; Subkey: \"Applications{#ExeBasename}.exeDefaultIcon\"; ValueType: string; ValueName: \"\"; ValueData: \"{app}resourcesappresourceswin32code_file.ico\" Root: HKCR; Subkey: \"Applications{#ExeBasename}.exeshellopencommand\"; ValueType: string; ValueName: \"\"; ValueData: \"\"\"{app}{#ExeBasename}.exe\"\" \"\"%1\"\"\" Root: HKCU; Subkey: \"Environment\"; ValueType: expandsz; ValueName: \"Path\"; ValueData: \"{olddata};{app}bin\"; Tasks: addtopath; Check: NeedsAddPath(ExpandConstant('{app}bin')) Root: HKCU; Subkey: \"SOFTWAREClasses*shell{#RegValueName}\"; ValueType: expandsz; ValueName: \"\"; ValueData: \"Open with {#ShellNameShort}\"; Tasks: addcontextmenufiles; Flags: uninsdeletekey", "commid": "vscode_pr_25497"}], "negative_passages": []} {"query_id": "q-en-vscode-c01ed4d4800630291b3c41463cad1943b56a15ead9499faac1b1b905453427d0", "query": "Issue Id: <-bdb0-aec8-eb4a- } else { const data = templateData as IQuickOpenEntryGroupTemplateData; data.actionBar.dispose(); data.actionBar = null; data.container = null; data.description.dispose(); data.description = null; data.detail.dispose(); data.detail = null; data.group = null; data.icon = null; data.label.dispose(); data.label = null; data.prefix = null; } const data = templateData as IQuickOpenEntryGroupTemplateData; data.actionBar.dispose(); data.actionBar = null; data.container = null; data.description.dispose(); data.description = null; data.detail.dispose(); data.detail = null; data.group = null; data.icon = null; data.label.dispose(); data.label = null; data.prefix = null; } }", "commid": "vscode_pr_4614"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-f8e8b5de54d8e07c8388abc1c854038aa483ab132eae7e2c624d471dda505466", "text": "import { DiffEditorInput } from 'vs/workbench/common/editor/diffEditorInput'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { relative } from 'path'; import { IProcessEnvironment, isWindows } from 'vs/base/common/platform'; export class ConfigurationResolverService implements IConfigurationResolverService { _serviceBrand: any;", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-1cbe8bc704e62e8e387b21829429f73994e6ba9e4e0d900127c32bec4895e7e8", "text": "private _lastWorkspaceFolder: IWorkspaceFolder; constructor( envVariables: { [key: string]: string }, envVariables: IProcessEnvironment, @IWorkbenchEditorService private editorService: IWorkbenchEditorService, @IEnvironmentService environmentService: IEnvironmentService, @IConfigurationService private configurationService: IConfigurationService,", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-3484e22f4130038732965adb81fe8a46393392649cce1d1b6ca1a55358ae0a9f", "text": ") { this._execPath = environmentService.execPath; Object.keys(envVariables).forEach(key => { this[`env:${key}`] = envVariables[key]; const name = isWindows ? key.toLowerCase() : key; this[`env:${name}`] = envVariables[key]; }); }", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-68f08bafb19cdfa75b42c3b23e0a9f0f2fc8ee5758ef899af6c6a991143294ff", "text": "let regexp = /${(.*?)}/g; const originalValue = value; const resolvedString = value.replace(regexp, (match: string, name: string) => { let newValue = (this)[name]; const key = (isWindows && match.indexOf('env:') > 0) ? name.toLowerCase() : name; let newValue = (this)[key]; if (types.isString(newValue)) { return newValue; } else {", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-39e368c5b478b1c7fc8fe081c1797299307ea6dcd98e2391b33b154c4a97eb7e", "text": "suite('Configuration Resolver Service', () => { let configurationResolverService: IConfigurationResolverService; let envVariables: { [key: string]: string } = { key1: 'Value for Key1', key2: 'Value for Key2' }; let envVariables: { [key: string]: string } = { key1: 'Value for key1', key2: 'Value for key2' }; let mockCommandService: MockCommandService; let editorService: TestEditorService; let workspace: IWorkspaceFolder;", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-d46849ea7d976653e73ae65aced5cd9c80bb0460e889aa6d1cd2fe3c059fce0f", "text": "test('substitute one env variable', () => { if (platform.isWindows) { assert.strictEqual(configurationResolverService.resolve(workspace, 'abc ${workspaceFolder} ${env:key1} xyz'), 'abc VSCodeworkspaceLocation Value for Key1 xyz'); assert.strictEqual(configurationResolverService.resolve(workspace, 'abc ${workspaceFolder} ${env:key1} xyz'), 'abc VSCodeworkspaceLocation Value for key1 xyz'); } else { assert.strictEqual(configurationResolverService.resolve(workspace, 'abc ${workspaceFolder} ${env:key1} xyz'), 'abc /VSCode/workspaceLocation Value for Key1 xyz'); assert.strictEqual(configurationResolverService.resolve(workspace, 'abc ${workspaceFolder} ${env:key1} xyz'), 'abc /VSCode/workspaceLocation Value for key1 xyz'); } }); test('substitute many env variable', () => { if (platform.isWindows) { assert.strictEqual(configurationResolverService.resolve(workspace, '${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'VSCodeworkspaceLocation - VSCodeworkspaceLocation Value for Key1 - Value for Key2'); assert.strictEqual(configurationResolverService.resolve(workspace, '${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'VSCodeworkspaceLocation - VSCodeworkspaceLocation Value for key1 - Value for key2'); } else { assert.strictEqual(configurationResolverService.resolve(workspace, '${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), '/VSCode/workspaceLocation - /VSCode/workspaceLocation Value for Key1 - Value for Key2'); assert.strictEqual(configurationResolverService.resolve(workspace, '${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), '/VSCode/workspaceLocation - /VSCode/workspaceLocation Value for key1 - Value for key2'); } }); test('substitute one env variable using platform case sensitivity', () => { if (platform.isWindows) { assert.strictEqual(configurationResolverService.resolve(workspace, '${env:key1} - ${env:Key1}'), 'Value for key1 - Value for key1'); } else { assert.strictEqual(configurationResolverService.resolve(workspace, '${env:key1} - ${env:Key1}'), 'Value for key1 - '); } });", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-293fef48d07c79ad065cbf56bc77f8e585969ba84d1e9d0ba6e22a7d29ffd60e", "text": "let service = new ConfigurationResolverService(envVariables, new TestEditorService(), TestEnvironmentService, configurationService, mockCommandService); if (platform.isWindows) { assert.strictEqual(service.resolve(workspace, 'abc ${config:editor.fontFamily} ${workspaceFolder} ${env:key1} xyz'), 'abc foo VSCodeworkspaceLocation Value for Key1 xyz'); assert.strictEqual(service.resolve(workspace, 'abc ${config:editor.fontFamily} ${workspaceFolder} ${env:key1} xyz'), 'abc foo VSCodeworkspaceLocation Value for key1 xyz'); } else { assert.strictEqual(service.resolve(workspace, 'abc ${config:editor.fontFamily} ${workspaceFolder} ${env:key1} xyz'), 'abc foo /VSCode/workspaceLocation Value for Key1 xyz'); assert.strictEqual(service.resolve(workspace, 'abc ${config:editor.fontFamily} ${workspaceFolder} ${env:key1} xyz'), 'abc foo /VSCode/workspaceLocation Value for key1 xyz'); } });", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-da77aa779aa07c9421f0eb3c7db1cc2691d27232fc9e483d1cb7b34acd45019c", "query": "VSCode Version:0.10.13 alpha OS Version:Windows 10 Steps to Reproduce: an variable to your ex. ${env.PATH} \"command\": \"echo\", \"isShellCommand\": true, \"args\": [\"${env.PATH}\"], the task. This will expand correctly on Linux and OS X but not Windows since the expansion is case sensitive and PATH on Windows is \"Path\". Env Var expansion shouldn't be case sensitive so that the same task can run on all platform. This bug was requested by in vscode-docs issue\nthis is done by the resolver service. IMO env variables on all OSes are case insensitive. Should we address this.\nLet's keep it open and if some user is passionate he can tackle it\nOn linux and macOS environment variables are case sensitive, so \"Path\" and \"PATH\" are different variables on linux and macOS (but not on Windows). So your statement from above \"IMO env variables on all OSes are case insensitive.\" is not correct, right? so you are asking for making env var lookup case insensitive on Windows only, correct?\nI thought they are always case insensitive. So it should be case insensitive then on Windows only\nI'm actually about done with a change for this if you want to take a look.\nthanks, I will review the PR.\ndid you want me to squash it or anything (fixed a broken test because I forgot the existing code returned an empty string for missing environment variables)? Different projects have different requirements and I didn't see anything about squashing in your contrib docs.\nno need to squash, I will add the comments to the PR directly if something is needed. Thanks", "positive_passages": [{"docid": "doc-en-vscode-c3a0739e01b466f395fcecc6b21454cb348d7a0257dff4bf6c0aa81a2f2e42c5", "text": "let service = new ConfigurationResolverService(envVariables, new TestEditorService(), TestEnvironmentService, configurationService, mockCommandService); if (platform.isWindows) { assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar VSCodeworkspaceLocation - VSCodeworkspaceLocation Value for Key1 - Value for Key2'); assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar VSCodeworkspaceLocation - VSCodeworkspaceLocation Value for key1 - Value for key2'); } else { assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar /VSCode/workspaceLocation - /VSCode/workspaceLocation Value for Key1 - Value for Key2'); assert.strictEqual(service.resolve(workspace, '${config:editor.fontFamily} ${config:terminal.integrated.fontFamily} ${workspaceFolder} - ${workspaceFolder} ${env:key1} - ${env:key2}'), 'foo bar /VSCode/workspaceLocation - /VSCode/workspaceLocation Value for key1 - Value for key2'); } });", "commid": "vscode_pr_40466"}], "negative_passages": []} {"query_id": "q-en-vscode-b35ceacb553472d21854b18296ff072aa7dc512449d0f7006f1b0e32d803d110", "query": "VSCode Version: 1.0.0 OS Version: OSX 10.11.3 I noticed that we can set to a keybinding. Which creates a nice input field in the sidebar to create the directory at the current selected position. ! But there is no possibility to do this for a file. Yes you can bind but it does not do the same thing. It just creates a new and when pressing import {AddToWorkingFiles, FocusWorkingFiles, FocusFilesExplorer, OpenPreviousWorkingFile, OpenNextWorkingFile, CloseAllFilesAction, CloseFileAction, CloseOtherFilesAction, GlobalCompareResourcesAction, GlobalNewFolderAction, RevertFileAction, SaveFilesAction, SaveAllAction, SaveFileAction, keybindingForAction, MoveFileToTrashAction, TriggerRenameFileAction, PasteFileAction, CopyFileAction, SelectResourceForCompareAction, CompareResourcesAction, NewFolderAction, NewFileAction, OpenToSideAction, ShowActiveFileInExplorer} from 'vs/workbench/parts/files/browser/fileActions'; import {AddToWorkingFiles, FocusWorkingFiles, FocusFilesExplorer, OpenPreviousWorkingFile, OpenNextWorkingFile, CloseAllFilesAction, CloseFileAction, CloseOtherFilesAction, GlobalCompareResourcesAction, GlobalNewFileAction, GlobalNewFolderAction, RevertFileAction, SaveFilesAction, SaveAllAction, SaveFileAction, keybindingForAction, MoveFileToTrashAction, TriggerRenameFileAction, PasteFileAction, CopyFileAction, SelectResourceForCompareAction, CompareResourcesAction, NewFolderAction, NewFileAction, OpenToSideAction, ShowActiveFileInExplorer} from 'vs/workbench/parts/files/browser/fileActions'; import {RevertLocalChangesAction, AcceptLocalChangesAction, ConflictResolutionDiffEditorInput} from 'vs/workbench/parts/files/browser/saveErrorHandler'; import {SyncActionDescriptor} from 'vs/platform/actions/common/actions'; import {IWorkbenchActionRegistry, Extensions as ActionExtensions} from 'vs/workbench/common/actionRegistry';", "commid": "vscode_pr_5597"}], "negative_passages": []} {"query_id": "q-en-vscode-b35ceacb553472d21854b18296ff072aa7dc512449d0f7006f1b0e32d803d110", "query": "VSCode Version: 1.0.0 OS Version: OSX 10.11.3 I noticed that we can set to a keybinding. Which creates a nice input field in the sidebar to create the directory at the current selected position. ! But there is no possibility to do this for a file. Yes you can bind but it does not do the same thing. It just creates a new and when pressing registry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewFileAction, GlobalNewFileAction.ID, GlobalNewFileAction.LABEL), category, ['new', 'file']); registry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewFolderAction, GlobalNewFolderAction.ID, GlobalNewFolderAction.LABEL), category, ['new', 'folder']); registry.registerWorkbenchAction(new SyncActionDescriptor(GlobalCompareResourcesAction, GlobalCompareResourcesAction.ID, GlobalCompareResourcesAction.LABEL), category, ['compare', 'files']); registry.registerWorkbenchAction(new SyncActionDescriptor(CloseFileAction, CloseFileAction.ID, CloseFileAction.LABEL, { primary: KeyMod.chord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_W) }), category, ['close', 'file']);", "commid": "vscode_pr_5597"}], "negative_passages": []} {"query_id": "q-en-vscode-b35ceacb553472d21854b18296ff072aa7dc512449d0f7006f1b0e32d803d110", "query": "VSCode Version: 1.0.0 OS Version: OSX 10.11.3 I noticed that we can set to a keybinding. Which creates a nice input field in the sidebar to create the directory at the current selected position. ! But there is no possibility to do this for a file. Yes you can bind but it does not do the same thing. It just creates a new and when pressing export class GlobalNewFileAction extends Action { export class GlobalNewUntitledFileAction extends Action { public static ID = 'workbench.action.files.newUntitledFile'; public static LABEL = nls.localize('newFile', \"New File\"); public static LABEL = nls.localize('newUntitledFile', \"New Untitled File\"); constructor( id: string,", "commid": "vscode_pr_5597"}], "negative_passages": []} {"query_id": "q-en-vscode-b35ceacb553472d21854b18296ff072aa7dc512449d0f7006f1b0e32d803d110", "query": "VSCode Version: 1.0.0 OS Version: OSX 10.11.3 I noticed that we can set to a keybinding. Which creates a nice input field in the sidebar to create the directory at the current selected position. ! But there is no possibility to do this for a file. Yes you can bind but it does not do the same thing. It just creates a new and when pressing /* Create new file from anywhere */ export class GlobalNewFileAction extends BaseGlobalNewAction { public static ID = 'workbench.action.files.newFile'; public static LABEL = nls.localize('newFile', \"New File\"); protected getAction(): IConstructorSignature2 { return NewFileAction; } } /* Create new folder from anywhere */ export class GlobalNewFolderAction extends BaseGlobalNewAction { public static ID = 'workbench.action.files.newFolder';", "commid": "vscode_pr_5597"}], "negative_passages": []} {"query_id": "q-en-vscode-b35ceacb553472d21854b18296ff072aa7dc512449d0f7006f1b0e32d803d110", "query": "VSCode Version: 1.0.0 OS Version: OSX 10.11.3 I noticed that we can set to a keybinding. Which creates a nice input field in the sidebar to create the directory at the current selected position. ! But there is no possibility to do this for a file. Yes you can bind but it does not do the same thing. It just creates a new and when pressing case GlobalNewFileAction.ID: case GlobalNewUntitledFileAction.ID: return new Keybinding(KeyMod.CtrlCmd | KeyCode.KEY_N); case TriggerRenameFileAction.ID: return new Keybinding(isMacintosh ? KeyCode.Enter : KeyCode.F2);", "commid": "vscode_pr_5597"}], "negative_passages": []} {"query_id": "q-en-vscode-b35ceacb553472d21854b18296ff072aa7dc512449d0f7006f1b0e32d803d110", "query": "VSCode Version: 1.0.0 OS Version: OSX 10.11.3 I noticed that we can set to a keybinding. Which creates a nice input field in the sidebar to create the directory at the current selected position. ! But there is no possibility to do this for a file. Yes you can bind but it does not do the same thing. It just creates a new and when pressing import {GlobalNewFileAction, SaveFileAsAction} from 'vs/workbench/parts/files/browser/fileActions'; import {GlobalNewUntitledFileAction, SaveFileAsAction} from 'vs/workbench/parts/files/browser/fileActions'; import {FileTracker} from 'vs/workbench/parts/files/electron-browser/electronFileTracker'; import {TextFileService} from 'vs/workbench/parts/files/electron-browser/textFileServices'; import {OpenFolderAction, OPEN_FOLDER_ID, OPEN_FOLDER_LABEL, OpenFileAction, OPEN_FILE_ID, OPEN_FILE_LABEL, OpenFileFolderAction, OPEN_FILE_FOLDER_ID, OPEN_FILE_FOLDER_LABEL, ShowOpenedFileInNewWindow, GlobalRevealInOSAction, GlobalCopyPathAction, CopyPathAction, RevealInOSAction} from 'vs/workbench/parts/files/electron-browser/electronFileActions';", "commid": "vscode_pr_5597"}], "negative_passages": []} {"query_id": "q-en-vscode-b35ceacb553472d21854b18296ff072aa7dc512449d0f7006f1b0e32d803d110", "query": "VSCode Version: 1.0.0 OS Version: OSX 10.11.3 I noticed that we can set to a keybinding. Which creates a nice input field in the sidebar to create the directory at the current selected position. ! But there is no possibility to do this for a file. Yes you can bind but it does not do the same thing. It just creates a new and when pressing Registry.as(ActionExtensions.WorkbenchActions); workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(SaveFileAsAction, SaveFileAsAction.ID, SaveFileAsAction.LABEL, { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_S }), category, ['save', 'as']); workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewFileAction, GlobalNewFileAction.ID, GlobalNewFileAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.KEY_N }), category, ['new', 'file']); workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewUntitledFileAction, GlobalNewUntitledFileAction.ID, GlobalNewUntitledFileAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.KEY_N }), category, ['new', 'untitled', 'file']); workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalCopyPathAction, GlobalCopyPathAction.ID, GlobalCopyPathAction.LABEL, { primary: KeyMod.chord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_P) }), category, ['copy', 'path']); workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalRevealInOSAction, GlobalRevealInOSAction.ID, GlobalRevealInOSAction.LABEL, { primary: KeyMod.chord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_R) }), category, ['reveal', 'file']);", "commid": "vscode_pr_5597"}], "negative_passages": []} {"query_id": "q-en-vscode-02bb14a89c4a8c2e27780a7745ba3dfe033743a418665e760ef394ede1895c88", "query": "VSCode Version: 1.0 OS Version: Ubuntu 16.04 Ubuntu 16.04 (Xenial Xerus) no longer carries , this causes font to be rendered with if Linux desktop user installed MS core fonts (more than likely). Given Ubuntu still carries open source fonts such as or , which are better for LCD than , consider: Adding those to the font list Remove from font list - let the OS decide\nI see uses of this font in editor, git and debug land. Starting with editor.\nI bumped into this today, after updating to insiders 1.2.0. I'm on Ubuntu 16.10. For now, workaround by manually overriding the font family: Either way, I see no sense in giving \"Droid Sans\" as a first option, even on Linux. If the user has the MS fonts installed, they should be used.\nI also noticed this. I installed \"fonts-noto\" package from the repositories because some people say Noto font family is similar to Droid.\nI solved this by simply installing the font from\nthis is somewhat related to which has similar issues for the UI font. The real fix here is to lean on Chromium to pull in the system monospace font from the OS if it's available (a system-ui font was proposed in ). Is there any reason just is not used? Also why is Courier New there at all?\nfor no good reason except version-to-version stability.\nI only just became aware of this but it's a pretty big issue imo. If I remove my on Ubuntu 16.10 it falls back to Courier New which really affects readability because of its weight and the fact it's a serif font. If this was what I saw as my first impression I'd be kind of turned off by the default font. Hack: ! Courier New: ! Sure it can always be changed but we can't rely on people knowing or bothering to do that. Also on this PC seems to fall back on Courier New.\nMy honest suggestion is to ship VSCode with a cool font such as Hack or Inconsolata and have one of those be the default. IMHO too many folks are left with ugly monospace fonts.\nI just read your comment but I'll post this anyway since we agree :stuckouttongue: have you considered bundling a standard monospace font that looks good on all platforms with the distributable? The developer of reached out to me a couple of months ago and asked if we'd be interested in doing that, gzipped the 4 font variants are only ~700kb.\nYeah, I've mentioned this to and a couple of times already. Not sure about the legal implications, but IMHO that would be a smart move for us.\nHere's the expression of interest I mentioned from the developer of Hack\nIs there a reason why couldn't be that alias for the system monospace font?\nThis now also affects Debian Stretch. After upgrading the font is displayed because the fonts-droid is not in the repositories anymore. Debian maintainers switching from to . I have followed the recommendations and have installed and replaced with in which in my opinion looks very good. Setting the default to on Debian results in a very ugly result. I changed the default font in Gnome Tweak Tool and in fontconfig to . as you can see it is not taken into account: ! Until a font is bundled with VSCode, could we add in the for Linux, and perhaps add as a suggested package in the Debian package? is in the section in Debian repositories. Unfortunately it is in the section in the Ubuntu repositories, thus users must activate it before being able to install the package, this is why I suggest to as a package instead of a recommends/depends.\nIsn't this a Debian bug then? AFAIK you can't change the font in gnome-tweak-tool. It will only set a dconf value, not the alias which is configured via fontconfig.\nNote that I have also defined as the font in fontconfig by defining an alias in: As you can see NotoMono is returned as the maching font for . And I confirm that the monospace font is now rendered using on other applications running on my system, except Visual Studio Code where it seems to default to . I don't think there is a bug in Debian because other application seem to behave correctly. I agree that the correct and clean solution would be to define as the only font listed in . Although: In my opinion on many systems the default monospace font is ugly. If we really want to use as a default then we need to find out why the font is rendered as on some systems when is defined as another font.\nCould be a Chromium/Electron bug then. Can you try in Chromium/Chrome? IMHO that's a bug of those systems and will never be fixed, if applications work around it.\nI have interesting results. I have crafted the following html page: And got the following results. ! I noticed that adding quotes around the monospace word would yield different results. I have changed to in VSCode and it is now rendered correctly: !\nTry Ubuntu Mono. Monaco is good one but personally, I like Ubuntu Mono. !\nHi, everybody! Replace 'Droid sans mono' by 'Ubuntu mono' looks good to me. I didn't download any font pack.\nthere was another issue a while ago discouraging the use of Ubuntu Mono as then it's picked up as the default on non-Ubuntu Linux distros . Ideally we would pick up whatever the display manager configures as the default monospace font, but monospace often doesn't give us that.", "positive_passages": [{"docid": "doc-en-vscode-b9a9ac15a16cabf47efed396297d1105a97ee673e1021240101013d7c0ff2a22", "text": "const DEFAULT_WINDOWS_FONT_FAMILY = 'Consolas, 'Courier New', monospace'; const DEFAULT_MAC_FONT_FAMILY = 'Menlo, Monaco, 'Courier New', monospace'; const DEFAULT_LINUX_FONT_FAMILY = ''Droid Sans Mono', 'Courier New', monospace, 'Droid Sans Fallback''; const DEFAULT_LINUX_FONT_FAMILY = ''Droid Sans Mono', 'monospace', monospace, 'Droid Sans Fallback''; /** * @internal", "commid": "vscode_pr_34947"}], "negative_passages": []} {"query_id": "q-en-vscode-3435ff3d8667cca4cd33c3f132027c776988d88995bc11b4d6d6490215bfc1d0", "query": "VSCode Version: 1.2.1 OS Version: Windows 10.0. Steps to Reproduce: editing python document typing in a comment a contraction such as isn't that the editor creates a closing apostrophe that is inappropriate in this context.\nNot sure if this is inside the extension or core. But I have seen issues with wrong auto closing often in selfhost too.\nWell... this has been there since day 1. Does anyone know how JavaScript solves this, since it's solved there?", "positive_passages": [{"docid": "doc-en-vscode-e3d840364057c4c6b72eb5390d01e51ab228e38cc319b071f941ffba0cd42dd5", "text": "[\"(\", \")\"] ], \"autoClosingPairs\": [ [\"{\", \"}\"], [\"[\", \"]\"], [\"(\", \")\"], [\"\"\", \"\"\"], [\"'\", \"'\"] { \"open\": \"{\", \"close\": \"}\" }, { \"open\": \"[\", \"close\": \"]\" }, { \"open\": \"(\", \"close\": \")\" }, { \"open\": \"\"\", \"close\": \"\"\", \"notIn\": [\"string\"] }, { \"open\": \"'\", \"close\": \"'\", \"notIn\": [\"string\", \"comment\"] } ], \"surroundingPairs\": [ [\"{\", \"}\"],", "commid": "vscode_pr_16350"}], "negative_passages": []} {"query_id": "q-en-vscode-f0a3bd61efe349fbf08fb5c02fe106c350bbee2cdf98a99b8706a5a4482f0990", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) 2016-06-30T05:01:53.185Z OS Version: OSX 10.11.5 (15F34) Steps to Reproduce: a new document, type 'ab'. the editor caret between the two characters. . In any standard OSX text area, this results in the text 'ba'. In VS Code, the result is 'bab', which I cannot imagine justifying as desirable. Note that there is a separate behavior when the caret is at end-of-line: in the EOL case, the previous two characters are transposed. VS Code handles this correctly; it is only the \"in between\" case that is broken (as far as I can tell). Any fix should make sure to test both cases.\nI had a look in the source to see if I could fix this since it's driving me nuts. :) I think it may be an Electron issue since I don't see where this editor command is defined. I'm new to the source code so I may be missing it, but I don't see where a command is defined for ctrl-t.\nThis seems to have gotten worse recently; occasionally ctrl-t will cause multiple lines of text below the cursor to get duplicated into the text buffer.\ndo you have any idea if the likely source of this bug is in the vscode or electron code bases? I also went hunting around in vscode and could not find anything. I tried downloading an electron tutorial app but could not find a text field in which to test the problem. Any guidance here would be much appreciated.\nFor what it's worth the Atom app does not exhibit the broken vscode behavior. However, Atom's implementation has slightly different behavior than 'traditional' bash and native Cocoa controls. The traditional behavior is to transpose characters before and after the cursor AND move the cursor to after the transposed pair, or if there is no character after the cursor (end-of-line case) then transpose the preceding two characters. Atom transposes before and after characters around the cursor but does not move them; for the end-of-line case it does no transposition but instead moves the cursor back by one character.\nI would assume that the solution would be to manually reimplement it, like VSCode already does for ^a ^e ^b ^f ^n ^p This extension does just that. It'd be nice if the functionality of this extension were bundled, since it's basic functionality that works on every other macOS textbox. The Sublime Text selection transpose is just bonus that's really nice.\nVerified that when the cursor is in between 2 letters, they get transposed. But when cursor is at eol, previously last 2 letters were getting transposed. That doesn't happen anymore. ?\nI tried ctrl+t in TextEdit and implemented the behaviour I observed there. Is the behaviour different than what TextEdit does?\nI was basing my comment off of the OP's\nctrl+t in the editor now transposes characters like the default mac text editor. IMHO that is a good thing.\nsadly it only matches half of the behavior; there are two cases. When I reported this bug I noted that the EOL case worked correctly but the in-between case did not. Now as of insiders build it appears that the situation has been reversed. Could we please reopen the issue? Thank you.\nI just noticed that the start-of-line case is also incorrect: TextEdit transposes the newline before the caret with the character after the caret while VSCode simply advances the caret.\nI cannot reproduce this issue. Using VS Code 1.12.1 and default key bindings. Move to have this issue closed?\nThis can probably be closed; I believe Transpose has been rewritten since then for Sublime compatibility?\nVSCode does not match TextEdit behavior in the following cases: (where n is newline and ^ is the insertion caret). In all of these cases VSCode does nothing where TextEdit does a transpose operation.\nThis can be closed. I can't reproduce this issue too. (version: 1.13.1)\nI can still reproduce the cases I describe above on OSX; VSCode Version 1.14.0-insider . I think that in order to close this issue somebody needs to explicitly decide that they want VSCode to ship with default behavior that does not match that of OSX and Cocoa.\nI can reproduce, too. VS Code's and commands both do something different with each other and both different from the macOS/emacs standard.", "positive_passages": [{"docid": "doc-en-vscode-851ea51d4258ee37cb573693a75af15bf078f1416b182d1a48271e3aced58983", "text": "import * as nls from 'vs/nls'; import { KeyCode, KeyMod } from 'vs/base/common/keyCodes'; import { isLowSurrogate, isHighSurrogate } from 'vs/base/common/strings'; import { Range } from 'vs/editor/common/core/range'; import { Position, IPosition } from 'vs/editor/common/core/position'; import { ICommand } from 'vs/editor/common/editorCommon'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; import { registerEditorAction, EditorAction, ServicesAccessor } from 'vs/editor/browser/editorExtensions'; import { ReplaceCommand } from 'vs/editor/common/commands/replaceCommand'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { ITextModel } from 'vs/editor/common/model'; class TransposeLettersAction extends EditorAction { private positionLeftOf(start: IPosition, model: ITextModel): Position { let column = start.column; let lineNumber = start.lineNumber; if (column > model.getLineMinColumn(lineNumber)) { if (isLowSurrogate(model.getLineContent(lineNumber).charCodeAt(column - 2))) { // character before column is a low surrogate column = column - 2; } else { column = column - 1; } } else if (lineNumber > 1) { lineNumber = lineNumber - 1; column = model.getLineMaxColumn(lineNumber); } return new Position(lineNumber, column); } private positionRightOf(start: IPosition, model: ITextModel): Position { let column = start.column; let lineNumber = start.lineNumber; if (column < model.getLineMaxColumn(lineNumber)) { if (isHighSurrogate(model.getLineContent(lineNumber).charCodeAt(column - 1))) { // character after column is a high surrogate column = column + 2; } else { column = column + 1; } } else if (lineNumber < model.getLineCount()) { lineNumber = lineNumber + 1; column = 0; } return new Position(lineNumber, column); } constructor() { super({ id: 'editor.action.transposeLetters',", "commid": "vscode_pr_45499"}], "negative_passages": []} {"query_id": "q-en-vscode-f0a3bd61efe349fbf08fb5c02fe106c350bbee2cdf98a99b8706a5a4482f0990", "query": "VSCode Version: Version 1.3.0-insider (1.3.0-insider) 2016-06-30T05:01:53.185Z OS Version: OSX 10.11.5 (15F34) Steps to Reproduce: a new document, type 'ab'. the editor caret between the two characters. . In any standard OSX text area, this results in the text 'ba'. In VS Code, the result is 'bab', which I cannot imagine justifying as desirable. Note that there is a separate behavior when the caret is at end-of-line: in the EOL case, the previous two characters are transposed. VS Code handles this correctly; it is only the \"in between\" case that is broken (as far as I can tell). Any fix should make sure to test both cases.\nI had a look in the source to see if I could fix this since it's driving me nuts. :) I think it may be an Electron issue since I don't see where this editor command is defined. I'm new to the source code so I may be missing it, but I don't see where a command is defined for ctrl-t.\nThis seems to have gotten worse recently; occasionally ctrl-t will cause multiple lines of text below the cursor to get duplicated into the text buffer.\ndo you have any idea if the likely source of this bug is in the vscode or electron code bases? I also went hunting around in vscode and could not find anything. I tried downloading an electron tutorial app but could not find a text field in which to test the problem. Any guidance here would be much appreciated.\nFor what it's worth the Atom app does not exhibit the broken vscode behavior. However, Atom's implementation has slightly different behavior than 'traditional' bash and native Cocoa controls. The traditional behavior is to transpose characters before and after the cursor AND move the cursor to after the transposed pair, or if there is no character after the cursor (end-of-line case) then transpose the preceding two characters. Atom transposes before and after characters around the cursor but does not move them; for the end-of-line case it does no transposition but instead moves the cursor back by one character.\nI would assume that the solution would be to manually reimplement it, like VSCode already does for ^a ^e ^b ^f ^n ^p This extension does just that. It'd be nice if the functionality of this extension were bundled, since it's basic functionality that works on every other macOS textbox. The Sublime Text selection transpose is just bonus that's really nice.\nVerified that when the cursor is in between 2 letters, they get transposed. But when cursor is at eol, previously last 2 letters were getting transposed. That doesn't happen anymore. ?\nI tried ctrl+t in TextEdit and implemented the behaviour I observed there. Is the behaviour different than what TextEdit does?\nI was basing my comment off of the OP's\nctrl+t in the editor now transposes characters like the default mac text editor. IMHO that is a good thing.\nsadly it only matches half of the behavior; there are two cases. When I reported this bug I noted that the EOL case worked correctly but the in-between case did not. Now as of insiders build it appears that the situation has been reversed. Could we please reopen the issue? Thank you.\nI just noticed that the start-of-line case is also incorrect: TextEdit transposes the newline before the caret with the character after the caret while VSCode simply advances the caret.\nI cannot reproduce this issue. Using VS Code 1.12.1 and default key bindings. Move to have this issue closed?\nThis can probably be closed; I believe Transpose has been rewritten since then for Sublime compatibility?\nVSCode does not match TextEdit behavior in the following cases: (where n is newline and ^ is the insertion caret). In all of these cases VSCode does nothing where TextEdit does a transpose operation.\nThis can be closed. I can't reproduce this issue too. (version: 1.13.1)\nI can still reproduce the cases I describe above on OSX; VSCode Version 1.14.0-insider . I think that in order to close this issue somebody needs to explicitly decide that they want VSCode to ship with default behavior that does not match that of OSX and Cocoa.\nI can reproduce, too. VS Code's and commands both do something different with each other and both different from the macOS/emacs standard.", "positive_passages": [{"docid": "doc-en-vscode-2ea66afdef2fd9302b06315db745ffaaae4a6fc1897e89774d931389000a4a32", "text": "let commands: ICommand[] = []; let selections = editor.getSelections(); for (let i = 0; i < selections.length; i++) { let selection = selections[i]; for (let selection of selections) { if (!selection.isEmpty()) { continue; } let lineNumber = selection.startLineNumber; let column = selection.startColumn; if (column === 1) { // at the beginning of line continue; } let maxColumn = model.getLineMaxColumn(lineNumber); if (column === maxColumn) { // at the end of line let lastColumn = model.getLineMaxColumn(lineNumber); if (lineNumber === 1 && (column === 1 || (column === 2 && lastColumn === 2))) { // at beginning of file, nothing to do continue; } let lineContent = model.getLineContent(lineNumber); let charToTheLeft = lineContent.charAt(column - 2); let charToTheRight = lineContent.charAt(column - 1); // handle special case: when at end of line, transpose left two chars // otherwise, transpose left and right chars let endPosition = (column === lastColumn) ? selection.getPosition() : this.positionRightOf(selection.getPosition(), model); let middlePosition = this.positionLeftOf(endPosition, model); let beginPosition = this.positionLeftOf(middlePosition, model); let replaceRange = new Range(lineNumber, column - 1, lineNumber, column + 1); let leftChar = model.getValueInRange(Range.fromPositions(beginPosition, middlePosition)); let rightChar = model.getValueInRange(Range.fromPositions(middlePosition, endPosition)); commands.push(new ReplaceCommand(replaceRange, charToTheRight + charToTheLeft)); let replaceRange = Range.fromPositions(beginPosition, endPosition); commands.push(new ReplaceCommand(replaceRange, rightChar + leftChar)); } if (commands.length > 0) {", "commid": "vscode_pr_45499"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-c73ee8d9c77724944e3b4b165399535af56d978d9462e30f8b43e41c345fd96d", "text": "import DOM = require('vs/base/browser/dom'); import URI from 'vs/base/common/uri'; import errors = require('vs/base/common/errors'); import {RunOnceScheduler} from 'vs/base/common/async'; import {isMacintosh} from 'vs/base/common/platform'; import {IWorkbenchEditorService} from 'vs/workbench/services/editor/common/editorService'; import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-ec0b5d257df7c0ec82090efdb90c8449ef0ab10bcf96b1892ca3b25cbc5a122c", "text": "private _onGroupFocusChanged: Emitter; private onStacksChangeScheduler: RunOnceScheduler; private stacksChangedBuffer: IStacksModelChangeEvent[]; private toDispose: IDisposable[]; constructor(", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-bcd82d958d5c5b191cd504371d82bd2bbbbd1847222464f637104a318df71f11", "text": "@IInstantiationService private instantiationService: IInstantiationService ) { this.stacks = editorGroupService.getStacksModel(); this.toDispose = []; this.parent = parent; this.dimension = new Dimension(0, 0);", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-45fcbe9b6048fdc442f0b6b018e8401bbaee1395bc4d02b4a6a1dda7d0940d59", "text": "this._onGroupFocusChanged = new Emitter(); this.toDispose = []; this.onStacksChangeScheduler = new RunOnceScheduler(() => this.handleStacksChanged(), 0); this.toDispose.push(this.onStacksChangeScheduler); this.stacksChangedBuffer = []; this.create(this.parent); this.registerListeners();", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-315b129da66e604ddcd80716c271b05c9b947bf4ad3fd486a9887397aa193288", "text": "} private onStacksChanged(e: IStacksModelChangeEvent): void { this.stacksChangedBuffer.push(e); this.onStacksChangeScheduler.schedule(); } private handleStacksChanged(): void { // Up to date context // Read and reset buffer of events const buffer = this.stacksChangedBuffer; this.stacksChangedBuffer = []; // Up to date context for all title controls POSITIONS.forEach(position => { this.getTitleAreaControl(position).setContext(this.stacks.groupAt(position)); const titleAreaControl = this.getTitleAreaControl(position); const context = this.stacks.groupAt(position); titleAreaControl.setContext(context); if (!context) { titleAreaControl.refresh(); // clear out the control if the context is no longer present } }); // Refresh / update if group is visible and has a position const position = this.stacks.positionOfGroup(e.group); if (position >= 0) { if (e.structural) { this.getTitleAreaControl(position).refresh(); } else { this.getTitleAreaControl(position).update(); buffer.forEach(e => { const position = this.stacks.positionOfGroup(e.group); if (position >= 0) { // group could be gone by now because we run from a scheduler with timeout if (e.structural) { this.getTitleAreaControl(position).refresh(); } else { this.getTitleAreaControl(position).update(); } } } }); } public get onGroupFocusChanged(): Event {", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-48de79e981715386436ba82998ec672f1d697ec3c9082a80f41a716e63402dc8", "text": "private rochade(from: Position, to: Position): void { // Move editor to new position // Move container to new position const containerFrom = this.silos[from].child(); containerFrom.appendTo(this.silos[to]); const containerTo = this.silos[to].child(); containerTo.appendTo(this.silos[from]); // Inform editor const editor = this.visibleEditors[from]; editor.getContainer().offDOM().build(this.silos[to].child()); editor.changePosition(to); // Change data structures", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-e45dd22f022d255928bc53b29e3fcea89aea6352948c86587d7bf878f54d5744", "text": "// Distance 1: Swap Editors if (Math.abs(from - to) === 1) { // Move editors to new position let editorPos1 = this.visibleEditors[from]; editorPos1.getContainer().offDOM().build(this.silos[to].child()); editorPos1.changePosition(to); // Move containers to new position const containerFrom = this.silos[from].child(); containerFrom.appendTo(this.silos[to]); const containerTo = this.silos[to].child(); containerTo.appendTo(this.silos[from]); let editorPos2 = this.visibleEditors[to]; editorPos2.getContainer().offDOM().build(this.silos[from].child()); editorPos2.changePosition(from); // Inform Editors this.visibleEditors[from].changePosition(to); this.visibleEditors[to].changePosition(from); // Update last active position accordingly if (this.lastActivePosition === from) {", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-33c68e16e9b77f95560f12079069e7945de731a1923cbe30a24fd9b4706a08fa", "text": "newRightPosition = Position.LEFT; } // Move editors to new position let editorPos1 = this.visibleEditors[Position.LEFT]; editorPos1.getContainer().offDOM().build(this.silos[newLeftPosition].child()); editorPos1.changePosition(newLeftPosition); // Move containers to new position const containerPos1 = this.silos[Position.LEFT].child(); containerPos1.appendTo(this.silos[newLeftPosition]); let editorPos2 = this.visibleEditors[Position.CENTER]; editorPos2.getContainer().offDOM().build(this.silos[newCenterPosition].child()); editorPos2.changePosition(newCenterPosition); const containerPos2 = this.silos[Position.CENTER].child(); containerPos2.appendTo(this.silos[newCenterPosition]); const editorPos3 = this.visibleEditors[Position.RIGHT]; editorPos3.getContainer().offDOM().build(this.silos[newRightPosition].child()); editorPos3.changePosition(newRightPosition); const containerPos3 = this.silos[Position.RIGHT].child(); containerPos3.appendTo(this.silos[newRightPosition]); // Inform Editors this.visibleEditors[Position.LEFT].changePosition(newLeftPosition); this.visibleEditors[Position.CENTER].changePosition(newCenterPosition); this.visibleEditors[Position.RIGHT].changePosition(newRightPosition); // Update last active position accordingly if (this.lastActivePosition === Position.LEFT) {", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-c20411fcc6cd86776507e407196f88b03fb6ddc13b966055f6ca0d3c1801ec92", "text": "const titleAreaControl = instantiationService.createInstance(useTabs ? TabsTitleControl : NoTabsTitleControl); titleAreaControl.create(container.getHTMLElement()); titleAreaControl.setContext(context); titleAreaControl.refresh(); titleAreaControl.refresh(true /* instant */); silo.child().setProperty(SideBySideEditorControl.TITLE_AREA_CONTROL_KEY, titleAreaControl); // associate with container }", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-c556e6bd24c589a108bb68d14ba153a41f4f60737bf96d7a2d124cb7eb6c560f", "query": "For: scoped keybinding service scoped progress service For the title area and the editor itself. This requires a common parent (or the editor-container itself) to be reparented instead of the editor moving around. Enables more scenarios around menu and command contributions for contexts.\nI merged this to master: title container, editor container, progress bar widget and the instantiation service are now within a new container that gets reparented when a) you move an editor around or b) you close editor group LEFT when LEFT | RIGHT exist and RIGHT becomes LEFT as well as for when you have 3 editors open and you close the left or center group. Is there a way to verify this works for the scenario you disabled late before we finished June milestone? I remember you reverted a commit and I am not sure if this can be now reverted back again. !\nI can verify\nLGTM - will push the revert revert commit\nVerified via", "positive_passages": [{"docid": "doc-en-vscode-172fbfb6d6d78927b60556b2704de9e323b3898c2451ac4b01c89e7ecc7e55d1", "text": "// Move to valid position if any if (moveTo !== null) { this.editorGroupService.moveGroup(position, moveTo); // To reduce flickering during this operation we trigger a refresh of all // title controls right after. POSITIONS.forEach(p => { this.getTitleAreaControl(p).refresh(true); }); } // Otherwise layout to restore proper positioning", "commid": "vscode_pr_9255"}], "negative_passages": []} {"query_id": "q-en-vscode-fe55011eebfac313ba802ee92e08c432e56d5c1d303a114666f759cd4b4da52a", "query": "VSCode Version: 1.3.0-Insider OS Version: MacOSX 10.11.5 Steps to Reproduce: document with long lines (longer then screen width to the right and move the cursor to accordingly -Cursor is invisible\nUnless I'm misunderstanding the issue, this is expected behaviour. How would you expect the editor to behave? This happens on every editor. If you'd like your long line to wrap, you can control that by setting the configuration to .\nNo, this has nothing to do with wrapping long lines. My cursor is literally invisible: !\nInteresting, but I still can't reproduce... Can you provide a screencast or similar?\nWhere is your focus? The cursor blinks/is rendered only when the editor is focused\nI tried reproducing it with new files, but I'm unable to. This happens with a few xsl files at work. I'll try to see if I can get a 100% reproducible file. The focus is in the active editor. I'm only moving the cursor to the right. Screencast: ! EDIT: The cursor is only visible for as long as it doesn't surpass the last character that was visible in the initial view region of the editor\nThank you for the gif! I've never seen that before. Do you see any errors in the console () ? I've quickly tried with a file with these contents but could not reproduce: Other things that might be relevant: does this reproduce when running code without extensions (close it completely and launch with ), did you customize the font and/or picked a different theme?\nI found a way to reliably reproduce this issue. The missing piece was, that it only happens when you have split the main editor. I can't reproduce it with just one editor visible. Launching with doesn't help. I did try with the default user settings and theme as well, but without success. I managed to nail it down to the following steps to reproduce this issue: vscode random file (doesn't matter) the editor with (this is important) random code/text with long lines in one of the 2 editor panels\nForgot to mention: unfortunately there are no errors in the devtools console.\nI'm also seeing this issue. VS Code 1.3.0 commit Windows 10.0. Edit: Oops, didn't notice that a fix was already committed yesterday.\ncan you try my solution in ?\nYes, but disabling extensions doesn't help. This issue only occurs when you have more than a single editor view. See:\nWe decided to fix this by removing the property from the tabs container. The visual impact is that if you use a theme that introduces a custom background color, it will only be picked up for the active tab. E.g. for our themes \"red\" and \"abyss\": ! ! To verify: be on windows have 2 groups open at least have enough tabs open to cause scrolling activate a tab that is at the end of the tab list in group one find a long line and arrow right verify the cursor is not lost\ncan I ask you to verify this on Windows using this 1.3.1 stable build: Thanks!\nI verified this.", "positive_passages": [{"docid": "doc-en-vscode-3e00c0904a6d33a98f605205beb5195914ac4591e6b25546cc5b6cf55c720f27", "text": "private _readOnly: boolean; private _cursorBlinking: editorCommon.TextEditorCursorBlinkingStyle; private _cursorStyle: editorCommon.TextEditorCursorStyle; private _canUseTranslate3d: boolean; private _isVisible: boolean;", "commid": "vscode_pr_8854"}], "negative_passages": []} {"query_id": "q-en-vscode-fe55011eebfac313ba802ee92e08c432e56d5c1d303a114666f759cd4b4da52a", "query": "VSCode Version: 1.3.0-Insider OS Version: MacOSX 10.11.5 Steps to Reproduce: document with long lines (longer then screen width to the right and move the cursor to accordingly -Cursor is invisible\nUnless I'm misunderstanding the issue, this is expected behaviour. How would you expect the editor to behave? This happens on every editor. If you'd like your long line to wrap, you can control that by setting the configuration to .\nNo, this has nothing to do with wrapping long lines. My cursor is literally invisible: !\nInteresting, but I still can't reproduce... Can you provide a screencast or similar?\nWhere is your focus? The cursor blinks/is rendered only when the editor is focused\nI tried reproducing it with new files, but I'm unable to. This happens with a few xsl files at work. I'll try to see if I can get a 100% reproducible file. The focus is in the active editor. I'm only moving the cursor to the right. Screencast: ! EDIT: The cursor is only visible for as long as it doesn't surpass the last character that was visible in the initial view region of the editor\nThank you for the gif! I've never seen that before. Do you see any errors in the console () ? I've quickly tried with a file with these contents but could not reproduce: Other things that might be relevant: does this reproduce when running code without extensions (close it completely and launch with ), did you customize the font and/or picked a different theme?\nI found a way to reliably reproduce this issue. The missing piece was, that it only happens when you have split the main editor. I can't reproduce it with just one editor visible. Launching with doesn't help. I did try with the default user settings and theme as well, but without success. I managed to nail it down to the following steps to reproduce this issue: vscode random file (doesn't matter) the editor with (this is important) random code/text with long lines in one of the 2 editor panels\nForgot to mention: unfortunately there are no errors in the devtools console.\nI'm also seeing this issue. VS Code 1.3.0 commit Windows 10.0. Edit: Oops, didn't notice that a fix was already committed yesterday.\ncan you try my solution in ?\nYes, but disabling extensions doesn't help. This issue only occurs when you have more than a single editor view. See:\nWe decided to fix this by removing the property from the tabs container. The visual impact is that if you use a theme that introduces a custom background color, it will only be picked up for the active tab. E.g. for our themes \"red\" and \"abyss\": ! ! To verify: be on windows have 2 groups open at least have enough tabs open to cause scrolling activate a tab that is at the end of the tab list in group one find a long line and arrow right verify the cursor is not lost\ncan I ask you to verify this on Windows using this 1.3.1 stable build: Thanks!\nI verified this.", "positive_passages": [{"docid": "doc-en-vscode-9375428133b0926a8ef2cfe55ac5014f86b211f9dd395a083ed9c4d9aacc9d32", "text": "this._readOnly = this._context.configuration.editor.readOnly; this._cursorBlinking = this._context.configuration.editor.viewInfo.cursorBlinking; this._cursorStyle = this._context.configuration.editor.viewInfo.cursorStyle; this._canUseTranslate3d = context.configuration.editor.viewInfo.canUseTranslate3d; this._primaryCursor = new ViewCursor(this._context, false); this._secondaryCursors = [];", "commid": "vscode_pr_8854"}], "negative_passages": []} {"query_id": "q-en-vscode-fe55011eebfac313ba802ee92e08c432e56d5c1d303a114666f759cd4b4da52a", "query": "VSCode Version: 1.3.0-Insider OS Version: MacOSX 10.11.5 Steps to Reproduce: document with long lines (longer then screen width to the right and move the cursor to accordingly -Cursor is invisible\nUnless I'm misunderstanding the issue, this is expected behaviour. How would you expect the editor to behave? This happens on every editor. If you'd like your long line to wrap, you can control that by setting the configuration to .\nNo, this has nothing to do with wrapping long lines. My cursor is literally invisible: !\nInteresting, but I still can't reproduce... Can you provide a screencast or similar?\nWhere is your focus? The cursor blinks/is rendered only when the editor is focused\nI tried reproducing it with new files, but I'm unable to. This happens with a few xsl files at work. I'll try to see if I can get a 100% reproducible file. The focus is in the active editor. I'm only moving the cursor to the right. Screencast: ! EDIT: The cursor is only visible for as long as it doesn't surpass the last character that was visible in the initial view region of the editor\nThank you for the gif! I've never seen that before. Do you see any errors in the console () ? I've quickly tried with a file with these contents but could not reproduce: Other things that might be relevant: does this reproduce when running code without extensions (close it completely and launch with ), did you customize the font and/or picked a different theme?\nI found a way to reliably reproduce this issue. The missing piece was, that it only happens when you have split the main editor. I can't reproduce it with just one editor visible. Launching with doesn't help. I did try with the default user settings and theme as well, but without success. I managed to nail it down to the following steps to reproduce this issue: vscode random file (doesn't matter) the editor with (this is important) random code/text with long lines in one of the 2 editor panels\nForgot to mention: unfortunately there are no errors in the devtools console.\nI'm also seeing this issue. VS Code 1.3.0 commit Windows 10.0. Edit: Oops, didn't notice that a fix was already committed yesterday.\ncan you try my solution in ?\nYes, but disabling extensions doesn't help. This issue only occurs when you have more than a single editor view. See:\nWe decided to fix this by removing the property from the tabs container. The visual impact is that if you use a theme that introduces a custom background color, it will only be picked up for the active tab. E.g. for our themes \"red\" and \"abyss\": ! ! To verify: be on windows have 2 groups open at least have enough tabs open to cause scrolling activate a tab that is at the end of the tab list in group one find a long line and arrow right verify the cursor is not lost\ncan I ask you to verify this on Windows using this 1.3.1 stable build: Thanks!\nI verified this.", "positive_passages": [{"docid": "doc-en-vscode-83badf54dd37e4fa2adf08d08f2145902793d9c1678080819b9300e7199f5733", "text": "if (e.viewInfo.cursorStyle) { this._cursorStyle = this._context.configuration.editor.viewInfo.cursorStyle; } if (e.viewInfo.canUseTranslate3d) { this._canUseTranslate3d = this._context.configuration.editor.viewInfo.canUseTranslate3d; } this._primaryCursor.onConfigurationChanged(e); this._updateBlinking();", "commid": "vscode_pr_8854"}], "negative_passages": []} {"query_id": "q-en-vscode-fe55011eebfac313ba802ee92e08c432e56d5c1d303a114666f759cd4b4da52a", "query": "VSCode Version: 1.3.0-Insider OS Version: MacOSX 10.11.5 Steps to Reproduce: document with long lines (longer then screen width to the right and move the cursor to accordingly -Cursor is invisible\nUnless I'm misunderstanding the issue, this is expected behaviour. How would you expect the editor to behave? This happens on every editor. If you'd like your long line to wrap, you can control that by setting the configuration to .\nNo, this has nothing to do with wrapping long lines. My cursor is literally invisible: !\nInteresting, but I still can't reproduce... Can you provide a screencast or similar?\nWhere is your focus? The cursor blinks/is rendered only when the editor is focused\nI tried reproducing it with new files, but I'm unable to. This happens with a few xsl files at work. I'll try to see if I can get a 100% reproducible file. The focus is in the active editor. I'm only moving the cursor to the right. Screencast: ! EDIT: The cursor is only visible for as long as it doesn't surpass the last character that was visible in the initial view region of the editor\nThank you for the gif! I've never seen that before. Do you see any errors in the console () ? I've quickly tried with a file with these contents but could not reproduce: Other things that might be relevant: does this reproduce when running code without extensions (close it completely and launch with ), did you customize the font and/or picked a different theme?\nI found a way to reliably reproduce this issue. The missing piece was, that it only happens when you have split the main editor. I can't reproduce it with just one editor visible. Launching with doesn't help. I did try with the default user settings and theme as well, but without success. I managed to nail it down to the following steps to reproduce this issue: vscode random file (doesn't matter) the editor with (this is important) random code/text with long lines in one of the 2 editor panels\nForgot to mention: unfortunately there are no errors in the devtools console.\nI'm also seeing this issue. VS Code 1.3.0 commit Windows 10.0. Edit: Oops, didn't notice that a fix was already committed yesterday.\ncan you try my solution in ?\nYes, but disabling extensions doesn't help. This issue only occurs when you have more than a single editor view. See:\nWe decided to fix this by removing the property from the tabs container. The visual impact is that if you use a theme that introduces a custom background color, it will only be picked up for the active tab. E.g. for our themes \"red\" and \"abyss\": ! ! To verify: be on windows have 2 groups open at least have enough tabs open to cause scrolling activate a tab that is at the end of the tab list in group one find a long line and arrow right verify the cursor is not lost\ncan I ask you to verify this on Windows using this 1.3.1 stable build: Thanks!\nI verified this.", "positive_passages": [{"docid": "doc-en-vscode-b048ebc4756d89cbda61340fece47c463437edc831f4cf54b1dd2574d9ceaf79", "text": "for (var i = 0, len = this._secondaryCursors.length; i < len; i++) { this._secondaryCursors[i].render(ctx); } if (this._canUseTranslate3d) { this._domNode.setTransform('translate3d(0px, 0px, 0px)'); } else { this._domNode.setTransform(''); } } }", "commid": "vscode_pr_8854"}], "negative_passages": []} {"query_id": "q-en-vscode-85d3d660931fae8f2ff8e625b0ade66357978a55177de2bf305459a62331bffb", "query": "There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says \"There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off.\" This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.\nIt should be possible to uninstall the VS Code php extension.\nfyi\nI think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. \"\", so it could be turned off.\nYes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.\nThis is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.\nRelated\nAny update on this?\nI have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?\nI agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:\nAlso just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)\nthanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).\nI pushed the PR and changes the setting name for the code completion to \"\". If disabled, hover and signature help are also disabled.\nI don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.\nI don't think this is related, this only removes the built-in completion provider.\nSo something else which controls the display of suggestions list from extensions like php intellisense is broken?\nPart of the January build. Add to your settings to disable all completions from the built-in PHP extension.", "positive_passages": [{"docid": "doc-en-vscode-51e66fd831cfd96d1a906f542012752e5ad81b0fd8a1bfe736f09d2b03dd3916", "text": "\"type\": \"object\", \"order\": 20, \"properties\": { \"php.builtInCompletions.enable\": { \"type\": \"boolean\", \"default\": true, \"description\": \"%configuration.builtInCompletions.enable%\" }, \"php.validate.enable\": { \"type\": \"boolean\", \"default\": true,", "commid": "vscode_pr_19015"}], "negative_passages": []} {"query_id": "q-en-vscode-85d3d660931fae8f2ff8e625b0ade66357978a55177de2bf305459a62331bffb", "query": "There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says \"There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off.\" This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.\nIt should be possible to uninstall the VS Code php extension.\nfyi\nI think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. \"\", so it could be turned off.\nYes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.\nThis is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.\nRelated\nAny update on this?\nI have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?\nI agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:\nAlso just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)\nthanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).\nI pushed the PR and changes the setting name for the code completion to \"\". If disabled, hover and signature help are also disabled.\nI don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.\nI don't think this is related, this only removes the built-in completion provider.\nSo something else which controls the display of suggestions list from extensions like php intellisense is broken?\nPart of the January build. Add to your settings to disable all completions from the built-in PHP extension.", "positive_passages": [{"docid": "doc-en-vscode-5de86772850d79bd864b804f365469c3a34ee7c4414773d68fd6d7e6c9e92dd6", "text": "\ufeff{ \"configuration.validate.enable\": \"Whether php validation is enabled or not.\", \"configuration.validate.executablePath\": \"Points to the php executable.\", \"configuration.builtInCompletions.enable\": \"Enable/disable built-in PHP completions.\", \"configuration.validate.enable\": \"Enable/disable built-in PHP validation.\", \"configuration.validate.executablePath\": \"Points to the PHP executable.\", \"configuration.validate.run\": \"Whether the linter is run on save or on type.\", \"configuration.title\": \"PHP\" } No newline at end of file", "commid": "vscode_pr_19015"}], "negative_passages": []} {"query_id": "q-en-vscode-85d3d660931fae8f2ff8e625b0ade66357978a55177de2bf305459a62331bffb", "query": "There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says \"There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off.\" This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.\nIt should be possible to uninstall the VS Code php extension.\nfyi\nI think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. \"\", so it could be turned off.\nYes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.\nThis is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.\nRelated\nAny update on this?\nI have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?\nI agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:\nAlso just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)\nthanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).\nI pushed the PR and changes the setting name for the code completion to \"\". If disabled, hover and signature help are also disabled.\nI don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.\nI don't think this is related, this only removes the built-in completion provider.\nSo something else which controls the display of suggestions list from extensions like php intellisense is broken?\nPart of the January build. Add to your settings to disable all completions from the built-in PHP extension.", "positive_passages": [{"docid": "doc-en-vscode-1d53816905e23850e05c090e3a3c2eb0dea951806b45128a6909e660062e42e2", "text": "'use strict'; import { CompletionItemProvider, CompletionItem, CompletionItemKind, CancellationToken, TextDocument, Position, Range, TextEdit } from 'vscode'; import { CompletionItemProvider, CompletionItem, CompletionItemKind, CancellationToken, TextDocument, Position, Range, TextEdit, workspace } from 'vscode'; import phpGlobals = require('./phpGlobals'); export default class PHPCompletionItemProvider implements CompletionItemProvider {", "commid": "vscode_pr_19015"}], "negative_passages": []} {"query_id": "q-en-vscode-85d3d660931fae8f2ff8e625b0ade66357978a55177de2bf305459a62331bffb", "query": "There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says \"There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off.\" This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.\nIt should be possible to uninstall the VS Code php extension.\nfyi\nI think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. \"\", so it could be turned off.\nYes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.\nThis is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.\nRelated\nAny update on this?\nI have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?\nI agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:\nAlso just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)\nthanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).\nI pushed the PR and changes the setting name for the code completion to \"\". If disabled, hover and signature help are also disabled.\nI don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.\nI don't think this is related, this only removes the built-in completion provider.\nSo something else which controls the display of suggestions list from extensions like php intellisense is broken?\nPart of the January build. Add to your settings to disable all completions from the built-in PHP extension.", "positive_passages": [{"docid": "doc-en-vscode-94dfb8e3f7f05ccd8c1df7c9feac4588da5122e29758c37a514138a1801137dd", "text": "public provideCompletionItems(document: TextDocument, position: Position, token: CancellationToken): Promise { let result: CompletionItem[] = []; let shouldProvideCompletionItems = workspace.getConfiguration('php').get('builtInCompletions.enable', true); if (!shouldProvideCompletionItems) { return Promise.resolve(result); } var range = document.getWordRangeAtPosition(position); var prefix = range ? document.getText(range) : ''; if (!range) {", "commid": "vscode_pr_19015"}], "negative_passages": []} {"query_id": "q-en-vscode-85d3d660931fae8f2ff8e625b0ade66357978a55177de2bf305459a62331bffb", "query": "There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says \"There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off.\" This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.\nIt should be possible to uninstall the VS Code php extension.\nfyi\nI think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. \"\", so it could be turned off.\nYes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.\nThis is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.\nRelated\nAny update on this?\nI have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?\nI agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:\nAlso just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)\nthanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).\nI pushed the PR and changes the setting name for the code completion to \"\". If disabled, hover and signature help are also disabled.\nI don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.\nI don't think this is related, this only removes the built-in completion provider.\nSo something else which controls the display of suggestions list from extensions like php intellisense is broken?\nPart of the January build. Add to your settings to disable all completions from the built-in PHP extension.", "positive_passages": [{"docid": "doc-en-vscode-6126fe677ef4a9a5aea26612f8f1ba5618e37d1a9a0366d12637a75a126d77f9", "text": "'editor.snippetSuggestions', 'editor.selectionHighlight', 'editor.glyphMargin', 'php.validate.run', 'editor.wordSeparators', 'editor.mouseWheelScrollSensitivity', 'editor.suggestOnTriggerCharacters',", "commid": "vscode_pr_19015"}], "negative_passages": []} {"query_id": "q-en-vscode-85d3d660931fae8f2ff8e625b0ade66357978a55177de2bf305459a62331bffb", "query": "There is now a better Intellisense plugins for Vscode PHP: and . In it's known issues it says \"There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off.\" This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.\nIt should be possible to uninstall the VS Code php extension.\nfyi\nI think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter? P.S. I think simple options would suffice, e.g. \"\", so it could be turned off.\nYes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.\nThis is now annoying the testing of proper language server in here : Quote: P.S. I think the option would be a simplest thing to implement for now.\nRelated\nAny update on this?\nI have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?\nI agree it makes sense to provide a temporary option to disable this. Just submitted a PR here:\nAlso just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)\nthanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).\nI pushed the PR and changes the setting name for the code completion to \"\". If disabled, hover and signature help are also disabled.\nI don't think the setting achieves the desired result. Setting to I no longer get completion suggestions even from PHP Intellisense extension. If have to use to trigger the completion suggestions list.\nI don't think this is related, this only removes the built-in completion provider.\nSo something else which controls the display of suggestions list from extensions like php intellisense is broken?\nPart of the January build. Add to your settings to disable all completions from the built-in PHP extension.", "positive_passages": [{"docid": "doc-en-vscode-7aa3d938088b297be1b2aeb719911b70aae5c1ccccd4322f4be8a491b6522f05", "text": "'editor.trimAutoWhitespace', 'editor.folding', 'workbench.editor.enablePreviewFromQuickOpen', 'php.builtInCompletions.enable', 'php.validate.enable', 'php.validate.run', 'editor.parameterHints', ];", "commid": "vscode_pr_19015"}], "negative_passages": []} {"query_id": "q-en-vscode-c105775a2570d6090959c87952b7e1283a3ff7307fe64d41ab814bb894b19971", "query": "! H1 and H2 are not highlighted. The preview is fine. Tested on VS Code 1.3.1 on OS X 10.11.6\nI wanna give this one a try. Here is what I have achieved so far. !\nCouple of updates on this: to highlight both lines at the same time, the way I was trying above doesn't look practical. It automatically highlights the current line assuming a match of the begin, until it finds a non matching end/while (Basically the line highlights, and if the next line isn't a '-{3,}' then the syntax goes back to normal mode. alt heading 2 syntax (just the -{3,} part) is conflicting with the rule meta.separator.markdown, which takes precedence and hence the issue. Would it be a better option to fix this conflict instead?\nIt doesn't work with 1.9.0 !\nI believe this is as designed. Getting the TM grammar to highlight both the lines is tricky. If you refer to my previous comment, the first point: This would be confusing for the user. In simple terms, it means that as soon as a user starts typing, the line highlights, and goes back to normal syntax if the next line is neither of the alternate H1/H2 (---/===) text. What do you think?\nIs it possible to let the line white and if a line starts with --- oder ===, then this one and the previous one switch to blue? That is the same behavior like in other editors.", "positive_passages": [{"docid": "doc-en-vscode-ded098187ac899f31765b3248ce78f226c16c1b366a5e1fc44f0e1dfca5f5616", "text": " (^|G)(?!s*$|#|[ ]{0,3}((([-*_][ ]{0,2}2){2,}[ t]*$n?)|([*+-]([ ]{1,3}|t)))|s*[.+?]:|>) (^|G)(?!s*$|#|[ ]{0,3}((([*_][ ]{0,2}2){2,}[ t]*$n?)|([*+-]([ ]{1,3}|t)))|s*[.+?]:|>) raw_block ", "commid": "vscode_pr_11066"}], "negative_passages": []} {"query_id": "q-en-vscode-c105775a2570d6090959c87952b7e1283a3ff7307fe64d41ab814bb894b19971", "query": "! H1 and H2 are not highlighted. The preview is fine. Tested on VS Code 1.3.1 on OS X 10.11.6\nI wanna give this one a try. Here is what I have achieved so far. !\nCouple of updates on this: to highlight both lines at the same time, the way I was trying above doesn't look practical. It automatically highlights the current line assuming a match of the begin, until it finds a non matching end/while (Basically the line highlights, and if the next line isn't a '-{3,}' then the syntax goes back to normal mode. alt heading 2 syntax (just the -{3,} part) is conflicting with the rule meta.separator.markdown, which takes precedence and hence the issue. Would it be a better option to fix this conflict instead?\nIt doesn't work with 1.9.0 !\nI believe this is as designed. Getting the TM grammar to highlight both the lines is tricky. If you refer to my previous comment, the first point: This would be confusing for the user. In simple terms, it means that as soon as a user starts typing, the line highlights, and goes back to normal syntax if the next line is neither of the alternate H1/H2 (---/===) text. What do you think?\nIs it possible to let the line white and if a line starts with --- oder ===, then this one and the previous one switch to blue? That is the same behavior like in other editors.", "positive_passages": [{"docid": "doc-en-vscode-28d2f2b0eecefb6fe92e41a189ad036acb00dfec7f41fdfcd3e08f067b876560", "text": "separator match (^|G)[ ]{0,3}([-*_])([ ]{0,2}2){2,}[ t]*$n? (^|G)[ ]{0,3}([*-_])([ ]{0,2}2){2,}[ t]*$n? name meta.separator.markdown ", "commid": "vscode_pr_11066"}], "negative_passages": []} {"query_id": "q-en-vscode-c105775a2570d6090959c87952b7e1283a3ff7307fe64d41ab814bb894b19971", "query": "! H1 and H2 are not highlighted. The preview is fine. Tested on VS Code 1.3.1 on OS X 10.11.6\nI wanna give this one a try. Here is what I have achieved so far. !\nCouple of updates on this: to highlight both lines at the same time, the way I was trying above doesn't look practical. It automatically highlights the current line assuming a match of the begin, until it finds a non matching end/while (Basically the line highlights, and if the next line isn't a '-{3,}' then the syntax goes back to normal mode. alt heading 2 syntax (just the -{3,} part) is conflicting with the rule meta.separator.markdown, which takes precedence and hence the issue. Would it be a better option to fix this conflict instead?\nIt doesn't work with 1.9.0 !\nI believe this is as designed. Getting the TM grammar to highlight both the lines is tricky. If you refer to my previous comment, the first point: This would be confusing for the user. In simple terms, it means that as soon as a user starts typing, the line highlights, and goes back to normal syntax if the next line is neither of the alternate H1/H2 (---/===) text. What do you think?\nIs it possible to let the line white and if a line starts with --- oder ===, then this one and the previous one switch to blue? That is the same behavior like in other editors.", "positive_passages": [{"docid": "doc-en-vscode-930a48a540c2bcdff868f82bb75a7551f882af929ab6d750dd9b5dd1e6d84c81", "text": "## Markdown plus h2 with a custom ID ## {#id-goes-here} [Link back to H2](#id-goes-here) ### Alternate heading styles: Alternate Header 1 ================== Alternate Header 2 ------------------
", "commid": "vscode_pr_11066"}], "negative_passages": []} {"query_id": "q-en-vscode-c105775a2570d6090959c87952b7e1283a3ff7307fe64d41ab814bb894b19971", "query": "! H1 and H2 are not highlighted. The preview is fine. Tested on VS Code 1.3.1 on OS X 10.11.6\nI wanna give this one a try. Here is what I have achieved so far. !\nCouple of updates on this: to highlight both lines at the same time, the way I was trying above doesn't look practical. It automatically highlights the current line assuming a match of the begin, until it finds a non matching end/while (Basically the line highlights, and if the next line isn't a '-{3,}' then the syntax goes back to normal mode. alt heading 2 syntax (just the -{3,} part) is conflicting with the rule meta.separator.markdown, which takes precedence and hence the issue. Would it be a better option to fix this conflict instead?\nIt doesn't work with 1.9.0 !\nI believe this is as designed. Getting the TM grammar to highlight both the lines is tricky. If you refer to my previous comment, the first point: This would be confusing for the user. In simple terms, it means that as soon as a user starts typing, the line highlights, and goes back to normal syntax if the next line is neither of the alternate H1/H2 (---/===) text. What do you think?\nIs it possible to let the line white and if a line starts with --- oder ===, then this one and the previous one switch to blue? That is the same behavior like in other editors.", "positive_passages": [{"docid": "doc-en-vscode-e083c5c5842d93a394a82b831074f1046978d1ddb1f0337200a14b40b8e5fa94", "text": "} }, { \"c\": \"###\", \"t\": \"${1/(#)(#)?(#)?(#)?(#)?(#)?/${6:?6:${5:?5:${4:?4:${3:?3:${2:?2:1}}}}}/}.definition.heading.markdown.markup.punctuation\", \"r\": { \"dark_plus\": \".vs-dark.vscode-theme-defaults-themes-dark_plus-json .token.markup.heading rgb(86, 156, 214)\", \"light_plus\": \".vs.vscode-theme-defaults-themes-light_plus-json .token.markup.heading rgb(128, 0, 0)\", \"dark_vs\": \".vs-dark.vscode-theme-defaults-themes-dark_vs-json .token.markup.heading rgb(86, 156, 214)\", \"light_vs\": \".vs.vscode-theme-defaults-themes-light_vs-json .token.markup.heading rgb(128, 0, 0)\", \"hc_black\": \".hc-black.vscode-theme-defaults-themes-hc_black-json .token.markup.heading rgb(103, 150, 230)\" } }, { \"c\": \" \", \"t\": \"${1/(#)(#)?(#)?(#)?(#)?(#)?/${6:?6:${5:?5:${4:?4:${3:?3:${2:?2:1}}}}}/}.heading.markdown.markup\", \"r\": { \"dark_plus\": \".vs-dark.vscode-theme-defaults-themes-dark_plus-json .token.markup.heading rgb(86, 156, 214)\", \"light_plus\": \".vs.vscode-theme-defaults-themes-light_plus-json .token.markup.heading rgb(128, 0, 0)\", \"dark_vs\": \".vs-dark.vscode-theme-defaults-themes-dark_vs-json .token.markup.heading rgb(86, 156, 214)\", \"light_vs\": \".vs.vscode-theme-defaults-themes-light_vs-json .token.markup.heading rgb(128, 0, 0)\", \"hc_black\": \".hc-black.vscode-theme-defaults-themes-hc_black-json .token.markup.heading rgb(103, 150, 230)\" } }, { \"c\": \"Alternate heading styles:\", \"t\": \"${1/(#)(#)?(#)?(#)?(#)?(#)?/${6:?6:${5:?5:${4:?4:${3:?3:${2:?2:1}}}}}/}.entity.heading.markdown.markup.name.section\", \"r\": { \"dark_plus\": \".vs-dark.vscode-theme-defaults-themes-dark_plus-json .token.markup.heading rgb(86, 156, 214)\", \"light_plus\": \".vs.vscode-theme-defaults-themes-light_plus-json .token.markup.heading rgb(128, 0, 0)\", \"dark_vs\": \".vs-dark.vscode-theme-defaults-themes-dark_vs-json .token.markup.heading rgb(86, 156, 214)\", \"light_vs\": \".vs.vscode-theme-defaults-themes-light_vs-json .token.markup.heading rgb(128, 0, 0)\", \"hc_black\": \".hc-black.vscode-theme-defaults-themes-hc_black-json .token.markup.heading rgb(103, 150, 230)\" } }, { \"c\": \"Alternate Header 1\", \"t\": \"markdown.meta.paragraph\", \"r\": { \"dark_plus\": \".vs-dark .token rgb(212, 212, 212)\", \"light_plus\": \".vs .token rgb(0, 0, 0)\", \"dark_vs\": \".vs-dark .token rgb(212, 212, 212)\", \"light_vs\": \".vs .token rgb(0, 0, 0)\", \"hc_black\": \".hc-black .token rgb(255, 255, 255)\" } }, { \"c\": \"==================\", \"t\": \"1.heading.markdown.markup.meta.paragraph.setext\", \"r\": { \"dark_plus\": \".vs-dark.vscode-theme-defaults-themes-dark_plus-json .token.markup.heading rgb(86, 156, 214)\", \"light_plus\": \".vs.vscode-theme-defaults-themes-light_plus-json .token.markup.heading rgb(128, 0, 0)\", \"dark_vs\": \".vs-dark.vscode-theme-defaults-themes-dark_vs-json .token.markup.heading rgb(86, 156, 214)\", \"light_vs\": \".vs.vscode-theme-defaults-themes-light_vs-json .token.markup.heading rgb(128, 0, 0)\", \"hc_black\": \".hc-black.vscode-theme-defaults-themes-hc_black-json .token.markup.heading rgb(103, 150, 230)\" } }, { \"c\": \"Alternate Header 2\", \"t\": \"markdown.meta.paragraph\", \"r\": { \"dark_plus\": \".vs-dark .token rgb(212, 212, 212)\", \"light_plus\": \".vs .token rgb(0, 0, 0)\", \"dark_vs\": \".vs-dark .token rgb(212, 212, 212)\", \"light_vs\": \".vs .token rgb(0, 0, 0)\", \"hc_black\": \".hc-black .token rgb(255, 255, 255)\" } }, { \"c\": \"------------------\", \"t\": \"2.heading.markdown.markup.meta.paragraph.setext\", \"r\": { \"dark_plus\": \".vs-dark.vscode-theme-defaults-themes-dark_plus-json .token.markup.heading rgb(86, 156, 214)\", \"light_plus\": \".vs.vscode-theme-defaults-themes-light_plus-json .token.markup.heading rgb(128, 0, 0)\", \"dark_vs\": \".vs-dark.vscode-theme-defaults-themes-dark_vs-json .token.markup.heading rgb(86, 156, 214)\", \"light_vs\": \".vs.vscode-theme-defaults-themes-light_vs-json .token.markup.heading rgb(128, 0, 0)\", \"hc_black\": \".hc-black.vscode-theme-defaults-themes-hc_black-json .token.markup.heading rgb(103, 150, 230)\" } }, { \"c\": \"\"], [\"<\", \">\"], [\"{\", \"}\"], [\"(\", \")\"] ],", "commid": "vscode_pr_175899"}], "negative_passages": []} {"query_id": "q-en-vscode-58446ca3c7da8f78eb068cb097cc01ca4464b81eac021940a2ab4f7a80229d87", "query": "\"], [\"<\", \">\"], [\"{\", \"}\"], [\"(\", \")\"] ],", "commid": "vscode_pr_176493"}], "negative_passages": []} {"query_id": "q-en-vscode-56f0c166bab049bc4f9a72a7166073a99d6e5fd04fcddbef9664ba3ed3c92984", "query": "On Windows: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated :bug: No code code completion or schema association\n76 candidate PR:", "positive_passages": [{"docid": "doc-en-vscode-ba625fc3acee476cdb866320acef39dae0c4f0a6c7205b49b8a558184ed10007", "text": "\"@vscode/l10n\": \"^0.0.11\", \"jsonc-parser\": \"^3.2.0\", \"request-light\": \"^0.7.0\", \"vscode-json-languageservice\": \"^5.3.1\", \"vscode-json-languageservice\": \"^5.3.2\", \"vscode-languageserver\": \"^8.1.0\", \"vscode-uri\": \"^3.0.7\" },", "commid": "vscode_pr_176306"}], "negative_passages": []} {"query_id": "q-en-vscode-56f0c166bab049bc4f9a72a7166073a99d6e5fd04fcddbef9664ba3ed3c92984", "query": "On Windows: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated :bug: No code code completion or schema association\n76 candidate PR:", "positive_passages": [{"docid": "doc-en-vscode-ea63b7ef322f061634bb2df99509cb1836822b9e0a0ccc7b0537466a81b1eafe", "text": "resolved \"https://registry.yarnpkg.com/request-light/-/request-light-0.7.0.tgz#885628bb2f8040c26401ebf258ec51c4ae98ac2a\" integrity sha512-lMbBMrDoxgsyO+yB3sDcrDuX85yYt7sS8BfQd11jtbW/z5ZWgLZRcEGLsLoYw7I0WSUGQBs8CC8ScIxkTX1+6Q== vscode-json-languageservice@^5.3.1: version \"5.3.1\" resolved \"https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.3.1.tgz#c36175d05f425fbd8f47dcee6f2a72096bdda36f\" integrity sha512-tPRf/2LOBS6uFflFLABdj8T3ol2/QgZ0kpzZHFCs+cbxpnjBNiCo+rfh3th0dtdytq5dSnWo5iFJj99zF6jZWQ== vscode-json-languageservice@^5.3.2: version \"5.3.2\" resolved \"https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.3.2.tgz#11e530ba9ec541eaeb421dc274a22efdb5d580ef\" integrity sha512-5td6olfoNdtyxnNA4uocq7V9jdTJt63o9mGEntQb6cbD2HiObZW2XgbSj6nRaebWwBCiYdWpFklNjm6Wz6Xy1Q== dependencies: \"@vscode/l10n\" \"^0.0.11\" jsonc-parser \"^3.2.0\"", "commid": "vscode_pr_176306"}], "negative_passages": []} {"query_id": "q-en-vscode-56f0c166bab049bc4f9a72a7166073a99d6e5fd04fcddbef9664ba3ed3c92984", "query": "On Windows: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated :bug: No code code completion or schema association\n76 candidate PR:", "positive_passages": [{"docid": "doc-en-vscode-ba625fc3acee476cdb866320acef39dae0c4f0a6c7205b49b8a558184ed10007", "text": "\"@vscode/l10n\": \"^0.0.11\", \"jsonc-parser\": \"^3.2.0\", \"request-light\": \"^0.7.0\", \"vscode-json-languageservice\": \"^5.3.1\", \"vscode-json-languageservice\": \"^5.3.2\", \"vscode-languageserver\": \"^8.1.0\", \"vscode-uri\": \"^3.0.7\" },", "commid": "vscode_pr_176307"}], "negative_passages": []} {"query_id": "q-en-vscode-56f0c166bab049bc4f9a72a7166073a99d6e5fd04fcddbef9664ba3ed3c92984", "query": "On Windows: clone open workspace look at the workspace settings: all files are associated with schema . Note that this is a relative path to the workspace file open both files and check that code completion gives back property . You can also click on the JSON language selector ( next to JSON in the status bar) to see the schema that is associated :bug: No code code completion or schema association\n76 candidate PR:", "positive_passages": [{"docid": "doc-en-vscode-ea63b7ef322f061634bb2df99509cb1836822b9e0a0ccc7b0537466a81b1eafe", "text": "resolved \"https://registry.yarnpkg.com/request-light/-/request-light-0.7.0.tgz#885628bb2f8040c26401ebf258ec51c4ae98ac2a\" integrity sha512-lMbBMrDoxgsyO+yB3sDcrDuX85yYt7sS8BfQd11jtbW/z5ZWgLZRcEGLsLoYw7I0WSUGQBs8CC8ScIxkTX1+6Q== vscode-json-languageservice@^5.3.1: version \"5.3.1\" resolved \"https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.3.1.tgz#c36175d05f425fbd8f47dcee6f2a72096bdda36f\" integrity sha512-tPRf/2LOBS6uFflFLABdj8T3ol2/QgZ0kpzZHFCs+cbxpnjBNiCo+rfh3th0dtdytq5dSnWo5iFJj99zF6jZWQ== vscode-json-languageservice@^5.3.2: version \"5.3.2\" resolved \"https://registry.yarnpkg.com/vscode-json-languageservice/-/vscode-json-languageservice-5.3.2.tgz#11e530ba9ec541eaeb421dc274a22efdb5d580ef\" integrity sha512-5td6olfoNdtyxnNA4uocq7V9jdTJt63o9mGEntQb6cbD2HiObZW2XgbSj6nRaebWwBCiYdWpFklNjm6Wz6Xy1Q== dependencies: \"@vscode/l10n\" \"^0.0.11\" jsonc-parser \"^3.2.0\"", "commid": "vscode_pr_176307"}], "negative_passages": []} {"query_id": "q-en-vscode-01c587bca3095c23b81024db49d761632c43e7669b8a8c6fc92d9e6ce7a06889", "query": "Type: private async selectStep(id: string | undefined, delayFocus = true, forceRebuild = false) { if (id && this.editorInput.selectedStep === id && !forceRebuild) { return; } private async selectStep(id: string | undefined, delayFocus = true) { if (id && this.editorInput.selectedStep === id) { return; } if (id) { let stepElement = this.container.querySelector(`[data-step-id=\"${id}\"]`);", "commid": "vscode_pr_177966"}], "negative_passages": []} {"query_id": "q-en-vscode-01c587bca3095c23b81024db49d761632c43e7669b8a8c6fc92d9e6ce7a06889", "query": "Type: index < currentStepIndex() && this.contextService.contextMatchesRules(step.when)); if (toExpand.length) { this.selectStep(toExpand[toExpand.length - 1].id, false, false); this.selectStep(toExpand[toExpand.length - 1].id, false); } } if (event.keyCode === KeyCode.DownArrow) { const toExpand = category.steps.find((step, index) => index > currentStepIndex() && this.contextService.contextMatchesRules(step.when)); if (toExpand) { this.selectStep(toExpand.id, false, false); this.selectStep(toExpand.id, false); } } }));", "commid": "vscode_pr_177966"}], "negative_passages": []} {"query_id": "q-en-vscode-01c587bca3095c23b81024db49d761632c43e7669b8a8c6fc92d9e6ce7a06889", "query": "Type: this.selectStep(this.editorInput.selectedStep, false, true); this.selectStep(this.editorInput.selectedStep, false); } }));", "commid": "vscode_pr_177966"}], "negative_passages": []} {"query_id": "q-en-vscode-01c587bca3095c23b81024db49d761632c43e7669b8a8c6fc92d9e6ce7a06889", "query": "Type: this.contextService.contextMatchesRules(step.when) && !step.done) ?? category.steps[0]; this.selectStep(selectedStep ?? toExpand.id, !selectedStep, true); this.selectStep(selectedStep ?? toExpand.id, !selectedStep); this.detailsScrollbar.scanDomNode(); this.detailsPageScrollbar?.scanDomNode();", "commid": "vscode_pr_177966"}], "negative_passages": []} {"query_id": "q-en-vscode-b00414a562d82f438dc7cfa0a997678a914d8ebdda70351fd5f346dbca6230cb", "query": "Version : 1.76.1 Commit : Date : 2023-03-08T16:32:15.546Z Navigateur : Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.4985.0 Safari/537.36 Edg/102.0.1235.1 with the extension installed (stable) switch the display language to French, reload VS Code switch the display language to English, reload VS Code open the remote menu, see that there's still a French menu entry in there ! Open the extension view ! I also see it the other way around: !\nAhhh so it looks like this is returning remote-repositories extension: with the old german manifest. What\u2019s odd to me is that remote-repositories is being returned by and ... but even still, I don't know much about this code, but I would expect that the cache would cache the manifest in its raw form with the placeholders and then allow the runtime to translate the manifest (which could be optimized to cache both raw and translated form and only re-compute when language changes)\nI'm giving this one to you since it seems like a issue from the caching changes.\nIt seems we are translating the manifest always even if it is cached. But, I observed that some how (I do not know, may be in the old code), cache is having the already translated manifest. Therefore, while translating nothing gets translated. We do update cache every time but it seems if the version has not changed, we reuse the entry from the cache. There is no reason we have to reuse the entry from the cache. So fixed it by recomputing the cache entry always while updating the cache.", "positive_passages": [{"docid": "doc-en-vscode-aa47c369b7dbed8478d5cb657452eb0315cbbc8002f179188dca9119482831f5", "text": "if (!this._updateCustomBuiltinExtensionsCachePromise) { this._updateCustomBuiltinExtensionsCachePromise = (async () => { this.logService.info('Updating additional builtin extensions cache'); const cached = await this.getCustomBuiltinExtensionsFromCache(); const webExtensions: IWebExtension[] = []; const { extensions } = await this.readCustomBuiltinExtensionsInfoFromEnv(); if (extensions.length) {", "commid": "vscode_pr_177657"}], "negative_passages": []} {"query_id": "q-en-vscode-b00414a562d82f438dc7cfa0a997678a914d8ebdda70351fd5f346dbca6230cb", "query": "Version : 1.76.1 Commit : Date : 2023-03-08T16:32:15.546Z Navigateur : Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.4985.0 Safari/537.36 Edg/102.0.1235.1 with the extension installed (stable) switch the display language to French, reload VS Code switch the display language to English, reload VS Code open the remote menu, see that there's still a French menu entry in there ! Open the extension view ! I also see it the other way around: !\nAhhh so it looks like this is returning remote-repositories extension: with the old german manifest. What\u2019s odd to me is that remote-repositories is being returned by and ... but even still, I don't know much about this code, but I would expect that the cache would cache the manifest in its raw form with the placeholders and then allow the runtime to translate the manifest (which could be optimized to cache both raw and translated form and only re-compute when language changes)\nI'm giving this one to you since it seems like a issue from the caching changes.\nIt seems we are translating the manifest always even if it is cached. But, I observed that some how (I do not know, may be in the old code), cache is having the already translated manifest. Therefore, while translating nothing gets translated. We do update cache every time but it seems if the version has not changed, we reuse the entry from the cache. There is no reason we have to reuse the entry from the cache. So fixed it by recomputing the cache entry always while updating the cache.", "positive_passages": [{"docid": "doc-en-vscode-b6d2bd6ba9e96e59e294d328dd6f74817255079b915e81ade1a96711b290f22d", "text": "} await Promise.all([...galleryExtensionsMap.values()].map(async gallery => { try { const webExtension = cached.find(e => areSameExtensions(e.identifier, gallery.identifier) && e.version === gallery.version) ?? await this.toWebExtensionFromGallery(gallery, { isPreReleaseVersion: gallery.properties.isPreReleaseVersion, preRelease: gallery.properties.isPreReleaseVersion, isBuiltin: true }); const webExtension = await this.toWebExtensionFromGallery(gallery, { isPreReleaseVersion: gallery.properties.isPreReleaseVersion, preRelease: gallery.properties.isPreReleaseVersion, isBuiltin: true }); webExtensions.push(webExtension); } catch (error) { this.logService.info(`Ignoring additional builtin extension ${gallery.identifier.id} because there is an error while converting it into web extension`, getErrorMessage(error));", "commid": "vscode_pr_177657"}], "negative_passages": []} {"query_id": "q-en-vscode-971b94ebe46a657b3d52c92d6efede52ce5c675662c52a1016d6d952deba2ddc", "query": "Type: 'default': { 'compilerOptions': { 'target': 'ES5' } }, 'default': { 'compilerOptions': { 'target': 'ES6' } }, 'properties': { 'compilerOptions': { 'type': 'object',", "commid": "vscode_pr_337"}], "negative_passages": []} {"query_id": "q-en-vscode-971b94ebe46a657b3d52c92d6efede52ce5c675662c52a1016d6d952deba2ddc", "query": "Type: this._compilerOptions.target = options && options.target !== undefined ? options.target : ts.ScriptTarget.Latest; // because of JS* } getCompilationSettings(): ts.CompilerOptions {", "commid": "vscode_pr_337"}], "negative_passages": []} {"query_id": "q-en-vscode-3b4ad927a6827cd02fc0e42b94fd3d65f3da53920f29b0b1b316217a88dd3f2d", "query": " When the notebook document contains markdown cells or rich outputs, the workflow is a bit more complex and become asynchronous partially due to the fact the markdown and rich outputs are rendered in a separate webview/iframe. While the list view renders the cell/row, it will send requests to the webview for output rendering, the rendering result (like dimensions of the output elements) won't come back in current frame. Once we receive the output rendering results from the webview (say next frame), we would ask the list view to adjust the position/dimension of the cell and ones below. ![render outputs in the webview/iframe](https://user-images.githubusercontent.com/876920/142923784-4e7a297c-6ce4-4741-b306-cbfb3277699b.png) ## Cell rendering The rendering of cells in the notebook editor consists of following steps: * Update reused DOM nodes in the template and cell decorations * Set up context for the cell and toolbars * Update cell toolbar, run toolbar and insertion toolbar between cells * Render cell * Register listeners for: * Notebook layout change * Cell layout change * Cell state change: Folding, Collapse, Focus ## Focus Tracking Due to the nature of virtualization (list view) and two layers architecture, the focus tracking is more complex compared to file explorer or monaco editor. When a notebook is *focused*, the `document.activeElement` can be * Monaco editor, when users focus on a cell editor * `textarea` when users focus the text * Widgets * Webview/iframe, when users focus on markdown cell or rich outputs rendered rendered in iframe * List view container, when users focus on cell container * Focusable element inside the notebook editor * Builtin output (e.g., text output) * Find Widget * Cell statusbar * Toolbars The catch here is if the focus is on a monaco editor, instead of the list view container, when the cell is moved out of view, the list view removes the cell row from the DOM tree. The `document.activeElement` will fall back `document.body` when that happens. To ensure that the notebook editor doesn't blur, we need to move focus back to list view container when the focused cell is moved out of view. More importantly, focus the cell editor again when the cell is visible again (if the cell is still the *active* cell). Copy in Notebook depends on the focus tracking * Send `document.executeCommand('copy')` if users select text in output rendered in main frame by builtin renderer * Request webview copy if the focus is inside the webview * Copy cells if the focus is on notebook cell list * Copy text if the focus is in cell editor (monaco editor) ![diagram](https://user-images.githubusercontent.com/876920/141730905-2818043e-1a84-45d3-ad27-83bd89235ca5.png) # Optimizations Since most elements' positions are absolute and there is latency between the two frames, we have multiple optimizations to ensure smooth (we try our best) perceived user experience. The optimizations are mostly around: * Ensure the elements in current viewport are stable when other elements' dimensions update * Fewer layout messages between the main and iframe * Less flickering and forced reflow on scrolling While we continue optimizing the layout code, we need to make sure that the new optimization won't lead to regression in above three aspects. Here is a list of existing optimziations we already have and we want to make sure they still perform well when updating layout code. ## Avoid flickering on resize of cells above current viewport We always ensure that elements in current viewport are stable (their visual positions don't change) when cells above current viewport resize. Resizing a cell above viewport will then include following steps as shown in below diagram ![cell resize above viewport](./cell-resize-above-viewport.drawio.svg) 1. User scrolls to the middle of the document, with one markdown cell partially visible (blue box in the green container) and one code cell fully visible (blue box in the white container) 2. The code cell above current viewport grows by 50px. The list view will then push down every cell below it. Thus the code cell in the viewport will move down by 50px. In current tick/frame, the markdown preview elements in the webview are not updated yet thus it's still partially visible. 3. To ensure the code cell's position is stable, we would scroll the whole list view downwards by 50px. The code cell's position is now fixed but at the same time, the webview also moves up by 50px (as it's a child of the list view scrollable element). 4. Lastly we sent requests to the webview to fix the visual positions of markdown previews After the last step, both the code and markdown cells in the viewport stays where they were. However due to the fact that code cells and markdown cells are rendered in two different contexts (UI and iframe), there is always latency between step 3 and 4 so users will notice annoying flickering of markdown cells easily. The fix is kind of \"tricky\". Instead of adjusting the position of the partially markdown cells, we can actually make it visually stable by adjusting the position of the webview element (step 4). That would mess up the positions of markdown cells above current viewport, but we can fix them in next frame/tick (step 5) and since they are never in the viewport, users won't notice their position flicker/shift. ## Executing code cell followed by markdown cells Code cell outputs and markdown cells are both rendered in the underlying webview. When executing a code cell, the list view will 1. Request cell output rendering in webview 2. Cell output height change 1. in the webview, we set `maxHeight: 0; overflow: hidden` on the output DOM node, then it won't overlap with the following markdown cells 2. broadcast the height change to the list view in main frame 3. List view received the height update request 1. Send acknowledge of the output height change to webview 2. Push down code cells below 3. Webview remove `maxHeight: 0` on the output DOM node Whether users would see flickering or overlap of outputs, monaco editor and markdown cells depends on the latency between 3.2 and 3.3. ## Re-executing code cell followed by markdown cells Re-executing code cell consists of two steps: 1. Remove old outputs, which will reset the output height to 0 2. Render new outputs, which will push elements below downwards The latency between 1 and 2 will cause the UI to flicker (as cells below this code cell will move upwards then downwards in a short period of time. However a lot of the time, we just tweak the code a bit and the outputs will have the same shape and very likely same rendered height, seeing the movement of cells below it is not pleasant. For example say we have code ```py print(1) ``` it will generate text output `1`. Updating the code to ```py print(2) ``` will genrate text output `2`. The re-rendering of the output is fast and we want to ensure the UI is stable in this scenario, to achieve this: 1. Clear existing output `1` 1. Remove the output DOM node, but we reserve the height of the output 2. In 200ms, we will reset the output height to `0`, unless there is a new output rendered 2. Received new output 1. Re-render the new output 2. Calcuate the height of the new output, update layout If the new output is rendered within 200ms, users won't see the UI movement. ## Scrolling Code cell outputs and markdown cells are rendered in the webview, which are async in nature. In order to have the cell outputs and markdown previews rendered when users scroll to them, we send rendering requests of cells in the next and previous viewport when it's idle. Thus scrolling is smoother. We also warm up all rendered markdown in the document, from top to bottom, when the browser is idle. We don't warm up outputs like this, since they can be more expensive to render than markdown. But outputs do get rendered when the user starts a search in outputs. ", "commid": "vscode_pr_178312"}], "negative_passages": []} {"query_id": "q-en-vscode-13297bdaf2806fc5bb27ce5bf0a0d1721bb2b34f44248de4ea87647ca7a8f6b0", "query": "\"image\"
Render Viewport
Render Viewport
Notebook List View
Notebook List View
Render Template
Render Template
Render Element
Render Element
Get Dynamic Height
Get Dynamic Height
Create Cell Templates/Parts
Create Cell Templates/Parts
Toolbar
Toolbar
Editor
Editor
Statusbar
Statusbar
Code Cell
Code Cell
Render Cell Parts
Render Cell Parts
CellPart read DOM
CellPart read DOM
Update layout info
Update layout info
Toolbar.renderCell
Toolbar.renderCell
Toolbar.renderCell
Toolbar.renderCell
Toolbar.didRenderCell
Toolbar.didRenderCell
Toolbar.renderCell
Toolbar.renderCell
Toolbar.renderCell
Toolbar.renderCell
Toolbar.prepareLayout
Toolbar.prepareLay...
Cell Layout Change
Cell Layout Change
Cell Part updateInternalLayoutNow
Cell Part updateInternalLayoutNow
Toolbar.renderCell
Toolbar.renderCell
Toolbar.renderCell
Toolbar.renderCell
Toolbar.updateInternalLayoutNow
Toolbar.updateInternalLayout...
Next Frame
Next Frame
DOM Read
DOM Read
DOM Write
DOM Write Viewer does not support full SVG 1.1 ", "commid": "vscode_pr_178312"}], "negative_passages": []} {"query_id": "q-en-vscode-4d171807d049adad47c7c3098c979c5853a85f2c581164f16b802d95b615517c", "query": "